[jira] [Created] (WAGON-448) Use Java String replace to avoid commons-lang dependency
Fabian Lange created WAGON-448:
--
Summary: Use Java String replace to avoid commons-lang dependency
Key: WAGON-448
URL: https://issues.apache.org/jira/browse/WAGON-448
Project: Maven Wagon
Issue Type: Bug
Components: wagon-file
Reporter: Fabian Lange
I am trying to reduce the amount of dependencies of the Apache Karaf project.
One of the subcomponents uses wagon-http and wagon-file. By doing so, it
receives a dependency to commons-lang.
The reason is that wagon-file has a single use of StringUtils.replaceAll().
https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206
This dependency can be easily avoided using the JDK util
destinationPath.replace('\\', '/');
while this is also a bit faster, the main benefit is that we now can completely
remove the lang dependency.
Thank you!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WAGON-448) Use Java String replace to avoid commons-lang dependency
[
https://issues.apache.org/jira/browse/WAGON-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Lange updated WAGON-448:
---
Description:
I am trying to reduce the amount of dependencies of the Apache Karaf project.
One of the subcomponents uses wagon-http and wagon-file. By doing so, it
receives a dependency to commons-lang.
The reason is that wagon-file has a single use of StringUtils.replaceAll().
https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206
This dependency can be easily avoided using the JDK util
{code}
destinationPath.replace('\\', '/');
{code}
while this is also a bit faster, the main benefit is that we now can completely
remove the lang dependency.
Thank you!
was:
I am trying to reduce the amount of dependencies of the Apache Karaf project.
One of the subcomponents uses wagon-http and wagon-file. By doing so, it
receives a dependency to commons-lang.
The reason is that wagon-file has a single use of StringUtils.replaceAll().
https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206
This dependency can be easily avoided using the JDK util
destinationPath.replace('\\', '/');
while this is also a bit faster, the main benefit is that we now can completely
remove the lang dependency.
Thank you!
> Use Java String replace to avoid commons-lang dependency
>
>
> Key: WAGON-448
> URL: https://issues.apache.org/jira/browse/WAGON-448
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-file
>Reporter: Fabian Lange
>
> I am trying to reduce the amount of dependencies of the Apache Karaf project.
> One of the subcomponents uses wagon-http and wagon-file. By doing so, it
> receives a dependency to commons-lang.
> The reason is that wagon-file has a single use of StringUtils.replaceAll().
> https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206
> This dependency can be easily avoided using the JDK util
> {code}
> destinationPath.replace('\\', '/');
> {code}
> while this is also a bit faster, the main benefit is that we now can
> completely remove the lang dependency.
> Thank you!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WAGON-448) Use Java String replace to avoid commons-lang dependency
[
https://issues.apache.org/jira/browse/WAGON-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080408#comment-15080408
]
Fabian Lange commented on WAGON-448:
added PR for your convenience https://github.com/apache/maven-wagon/pull/20
> Use Java String replace to avoid commons-lang dependency
>
>
> Key: WAGON-448
> URL: https://issues.apache.org/jira/browse/WAGON-448
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-file
>Reporter: Fabian Lange
>
> I am trying to reduce the amount of dependencies of the Apache Karaf project.
> One of the subcomponents uses wagon-http and wagon-file. By doing so, it
> receives a dependency to commons-lang.
> The reason is that wagon-file has a single use of StringUtils.replaceAll().
> https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206
> This dependency can be easily avoided using the JDK util
> {code}
> destinationPath.replace('\\', '/');
> {code}
> while this is also a bit faster, the main benefit is that we now can
> completely remove the lang dependency.
> Thank you!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WAGON-447) Replace Commons Lang with Plexus Utils
[ https://issues.apache.org/jira/browse/WAGON-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080411#comment-15080411 ] Fabian Lange commented on WAGON-447: Hi Michael, would you mind including my change from 448 into your change? In wagon-file you do not need any utility library at all, but can directly use the JDK functionality. > Replace Commons Lang with Plexus Utils > -- > > Key: WAGON-447 > URL: https://issues.apache.org/jira/browse/WAGON-447 > Project: Maven Wagon > Issue Type: Task >Affects Versions: 2.11 >Reporter: Michael Osipov >Assignee: Michael Osipov > Fix For: 2.11 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WAGON-447) Replace Commons Lang with Plexus Utils
[ https://issues.apache.org/jira/browse/WAGON-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080413#comment-15080413 ] Fabian Lange commented on WAGON-447: PS: What is the likelyhood we did a similar motivated change after such a long lifetime of the project within 1 day. I checked the jira before you opened 447... > Replace Commons Lang with Plexus Utils > -- > > Key: WAGON-447 > URL: https://issues.apache.org/jira/browse/WAGON-447 > Project: Maven Wagon > Issue Type: Task >Affects Versions: 2.11 >Reporter: Michael Osipov >Assignee: Michael Osipov > Fix For: 2.11 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
