[jira] [Created] (SCM-835) includes directive doesn't work correctly when it covers only files in a dir
Eli Shvartsman created SCM-835:
--
Summary: includes directive doesn't work correctly when it covers
only files in a dir
Key: SCM-835
URL: https://issues.apache.org/jira/browse/SCM-835
Project: Maven SCM
Issue Type: Bug
Reporter: Eli Shvartsman
We have a scenario, when we have to commit only one file, for example
"LICENSE.md".
When we use
{code}
LICENSE.md
{code}
GitCheckInCommand is invoking a GitStatusConsumer for fileSet.getBasedir() and
if there are any changes, passes them to "commit" and "push" phases.
If there are any other files changed (except LICENSE.md), than
statusConsumer.getChangedFiles() is not empty and we proceed. But if we didn't
made any changes to our file, "commit" phase will fail, as there is nothing to
commit (in terms of our fileSet).
I suppose to patch GitStatusConsumer, so it could be aware of fileSet and not
give us status of changed files if they are not in a fileSet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SCM-835) includes directive doesn't work correctly when other files in directory changes
[
https://issues.apache.org/jira/browse/SCM-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Shvartsman updated SCM-835:
---
Summary: includes directive doesn't work correctly when other files in
directory changes (was: includes directive doesn't work correctly when it
covers only files in a dir)
> includes directive doesn't work correctly when other files in directory
> changes
> ---
>
> Key: SCM-835
> URL: https://issues.apache.org/jira/browse/SCM-835
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Eli Shvartsman
>
> We have a scenario, when we have to commit only one file, for example
> "LICENSE.md".
> When we use
> {code}
> LICENSE.md
> {code}
> GitCheckInCommand is invoking a GitStatusConsumer for fileSet.getBasedir()
> and if there are any changes, passes them to "commit" and "push" phases.
> If there are any other files changed (except LICENSE.md), than
> statusConsumer.getChangedFiles() is not empty and we proceed. But if we
> didn't made any changes to our file, "commit" phase will fail, as there is
> nothing to commit (in terms of our fileSet).
> I suppose to patch GitStatusConsumer, so it could be aware of fileSet and not
> give us status of changed files if they are not in a fileSet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SCM-835) includes directive doesn't work correctly when other files in directory changes
[
https://issues.apache.org/jira/browse/SCM-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365786#comment-15365786
]
Eli Shvartsman commented on SCM-835:
Added a pull request on github: https://github.com/apache/maven-scm/pull/51
> includes directive doesn't work correctly when other files in directory
> changes
> ---
>
> Key: SCM-835
> URL: https://issues.apache.org/jira/browse/SCM-835
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Eli Shvartsman
>
> We have a scenario, when we have to commit only one file, for example
> "LICENSE.md".
> When we use
> {code}
> LICENSE.md
> {code}
> GitCheckInCommand is invoking a GitStatusConsumer for fileSet.getBasedir()
> and if there are any changes, passes them to "commit" and "push" phases.
> If there are any other files changed (except LICENSE.md), than
> statusConsumer.getChangedFiles() is not empty and we proceed. But if we
> didn't made any changes to our file, "commit" phase will fail, as there is
> nothing to commit (in terms of our fileSet).
> I suppose to patch GitStatusConsumer, so it could be aware of fileSet and not
> give us status of changed files if they are not in a fileSet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Issue Comment Deleted] (SCM-835) includes directive doesn't work correctly when other files in directory changes
[
https://issues.apache.org/jira/browse/SCM-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Shvartsman updated SCM-835:
---
Comment: was deleted
(was: Added a pull request on github:
https://github.com/apache/maven-scm/pull/51)
> includes directive doesn't work correctly when other files in directory
> changes
> ---
>
> Key: SCM-835
> URL: https://issues.apache.org/jira/browse/SCM-835
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Eli Shvartsman
>
> We have a scenario, when we have to commit only one file, for example
> "LICENSE.md".
> When we use
> {code}
> LICENSE.md
> {code}
> GitCheckInCommand is invoking a GitStatusConsumer for fileSet.getBasedir()
> and if there are any changes, passes them to "commit" and "push" phases.
> If there are any other files changed (except LICENSE.md), than
> statusConsumer.getChangedFiles() is not empty and we proceed. But if we
> didn't made any changes to our file, "commit" phase will fail, as there is
> nothing to commit (in terms of our fileSet).
> I suppose to patch GitStatusConsumer, so it could be aware of fileSet and not
> give us status of changed files if they are not in a fileSet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SCM-835) includes directive doesn't work correctly when other files in directory changes
[
https://issues.apache.org/jira/browse/SCM-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Shvartsman updated SCM-835:
---
Flags: Patch
> includes directive doesn't work correctly when other files in directory
> changes
> ---
>
> Key: SCM-835
> URL: https://issues.apache.org/jira/browse/SCM-835
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Eli Shvartsman
>
> We have a scenario, when we have to commit only one file, for example
> "LICENSE.md".
> When we use
> {code}
> LICENSE.md
> {code}
> GitCheckInCommand is invoking a GitStatusConsumer for fileSet.getBasedir()
> and if there are any changes, passes them to "commit" and "push" phases.
> If there are any other files changed (except LICENSE.md), than
> statusConsumer.getChangedFiles() is not empty and we proceed. But if we
> didn't made any changes to our file, "commit" phase will fail, as there is
> nothing to commit (in terms of our fileSet).
> I suppose to patch GitStatusConsumer, so it could be aware of fileSet and not
> give us status of changed files if they are not in a fileSet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
