[PR] Bump org.wiremock:wiremock from 3.12.1 to 3.13.0 [maven-dist-tool]
dependabot[bot] opened a new pull request, #107: URL: https://github.com/apache/maven-dist-tool/pull/107 Bumps [org.wiremock:wiremock](https://github.com/wiremock/wiremock) from 3.12.1 to 3.13.0. Release notes Sourced from https://github.com/wiremock/wiremock/releases";>org.wiremock:wiremock's releases. 3.13.0 🚀 New Features Allow the WireMockExtension to not reset in beforeEach (https://redirect.github.com/wiremock/wiremock/issues/3010";>#3010) https://github.com/leeturner";>@leeturner Allow the webhook scheduler thread pool size to be configured (https://redirect.github.com/wiremock/wiremock/issues/3009";>#3009) https://github.com/leeturner";>@leeturner Add method to MappingBuilder to add multiple form params (https://redirect.github.com/wiremock/wiremock/issues/2927";>#2927) https://github.com/wernerblanck";>@wernerblanck Expose native matcher for client ip address (https://redirect.github.com/wiremock/wiremock/issues/3014";>#3014) https://github.com/lhcopetti";>@lhcopetti Extend LogNormal to add an optional maxValue (https://redirect.github.com/wiremock/wiremock/issues/3026";>#3026) https://github.com/paul-poulain-vodafone";>@paul-poulain-vodafone feat: admin API endpoints to find/remove unmatched stub mappings (https://redirect.github.com/wiremock/wiremock/issues/2991";>#2991) https://github.com/MasonM";>@MasonM feat: record query param matchers. (https://redirect.github.com/wiremock/wiremock/issues/3008";>#3008) https://github.com/RafeArnold";>@RafeArnold allow admin calls when standalone instance is behind haproxy/loadbala… (https://redirect.github.com/wiremock/wiremock/issues/2990";>#2990) https://github.com/vggeorgas";>@vggeorgas 🐞 Bug fixes fix: matched stub name header value encoding. (https://redirect.github.com/wiremock/wiremock/issues/3027";>#3027) https://github.com/RafeArnold";>@RafeArnold fix: run chunked dribble delay asynchronously (https://redirect.github.com/wiremock/wiremock/issues/3012";>#3012) https://github.com/lhcopetti";>@lhcopetti Fixed matches-json-schema-pattern.yaml so that it correctly takes the schema as a string (https://redirect.github.com/wiremock/wiremock/issues/3020";>#3020) https://github.com/tomakehurst";>@tomakehurst Fix OpenAPI 3.0 schemas (https://redirect.github.com/wiremock/wiremock/issues/2953";>#2953) https://github.com/ascopes";>@ascopes fix: handle null key in RequestPartTemplateModel for RFC 2387 compliance (https://redirect.github.com/wiremock/wiremock/issues/3022";>#3022) https://github.com/ns-amosc";>@ns-amosc fix: check casing when matching basic credentials. (https://redirect.github.com/wiremock/wiremock/issues/2997";>#2997) https://github.com/RafeArnold";>@RafeArnold Always use the system default DocumentBuilderFactory, TransformerFactory and XPathFactory (https://redirect.github.com/wiremock/wiremock/issues/2975";>#2975) https://github.com/vkuzel";>@vkuzel ✍ Other changes fix: publishing branch snapshots to github. (https://redirect.github.com/wiremock/wiremock/issues/3005";>#3005 https://redirect.github.com/wiremock/wiremock/issues/3003";>#3003 https://redirect.github.com/wiremock/wiremock/issues/3002";>#3002) https://github.com/RafeArnold";>@RafeArnold feat: allow publishing branch snapshots to github. (https://redirect.github.com/wiremock/wiremock/issues/3001";>#3001) https://github.com/RafeArnold";>@RafeArnold chore: remove json-smart dependency constraint. (https://redirect.github.com/wiremock/wiremock/issues/2965";>#2965) https://github.com/RafeArnold";>@RafeArnold 📦 Dependency updates chore(deps): bump versions.junitJupiter from 5.12.1 to 5.12.2 (https://redirect.github.com/wiremock/wiremock/issues/3023";>#3023) https://github.com/dependabot";>@dependabot chore(deps): bump commons-io:commons-io from 2.18.0 to 2.19.0 (https://redirect.github.com/wiremock/wiremock/issues/3024";>#3024) https://github.com/dependabot";>@dependabot chore(deps): bump org.mockito:mockito-junit-jupiter from 5.16.1 to 5.17.0 (https://redirect.github.com/wiremock/wiremock/issues/3017";>#3017) https://github.com/dependabot";>@dependabot chore(deps): bump org.mockito:mockito-core from 5.16.1 to 5.17.0 (https://redirect.github.com/wiremock/wiremock/issues/3016";>#3016) https://github.com/dependabot";>@dependabot chore(deps): bump com.google.guava:guava from 33.4.6-jre to 33.4.8-jre (https://redirect.github.com/wiremock/wiremock/issues/3025";>#3025) https://github.com/dependabot";>@dependabot chore(deps): bump org.apache.httpcomponents.client5:httpclient5 from 5.4.2 to 5.4.3 (https://redirect.github.com/wiremock/wiremock/issues/3007";>#3007) https://github.com/dependabot";>@dependabot Bump com.dorongold.task-tree from 4.0.0 to 4.0.1 (https://redirect.github.com/wiremock/wiremock/issues/2986";>#2986) https://github.com/dependabot";>@dependabot Bump org.sonarqube from 6.0.1.5171 to 6.1.0.5360 (
Re: [I] Guide for users: Maven 4 preparation / migration [maven-site]
Bukama closed issue #729: Guide for users: Maven 4 preparation / migration URL: https://github.com/apache/maven-site/issues/729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] User guide: Migrate projects to Maven 4 [maven-site]
Bukama merged PR #759: URL: https://github.com/apache/maven-site/pull/759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
Yu Yu created MBUILDCACHE-123:
-
Summary: do not set projectExecutions if cacheState is disabled
Key: MBUILDCACHE-123
URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
Project: Maven Build Cache Extension
Issue Type: Bug
Affects Versions: 1.2.0
Reporter: Yu Yu
Revised content:
# modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got cacheState
and don't allocate projectExecutions memory if cacheState is disabled.
# added sisu-maven-plugin to pom.xml for generating
{{META-INF/sisu/javax.inject.Named}} which should be included in the maven
extension jar.
Cause:
if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
MojoParametersListener will always allocate memory for saving projectExecutions
even disable the cache by {{-Dmaven.build.cache.enabled=false}}
[!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
i will modify the pr title after i could submit an issue for this pr, i don't
have jira account yet (already send request).
this pr is related to
[apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Yu updated MBUILDCACHE-123:
--
Description:
Revised content:
# modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got cacheState
and don't allocate projectExecutions memory if cacheState is disabled.
# added sisu-maven-plugin to pom.xml for generating
{{META-INF/sisu/javax.inject.Named}} which should be included in the maven
extension jar.
Cause:
if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
MojoParametersListener will always allocate memory for saving projectExecutions
even disable the cache by {{-Dmaven.build.cache.enabled=false}}
[!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
this pr is related to
[apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
was:
Revised content:
# modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got cacheState
and don't allocate projectExecutions memory if cacheState is disabled.
# added sisu-maven-plugin to pom.xml for generating
{{META-INF/sisu/javax.inject.Named}} which should be included in the maven
extension jar.
Cause:
if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
MojoParametersListener will always allocate memory for saving projectExecutions
even disable the cache by {{-Dmaven.build.cache.enabled=false}}
[!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
i will modify the pr title after i could submit an issue for this pr, i don't
have jira account yet (already send request).
this pr is related to
[apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Ext
Re: [PR] Bump commons-cli:commons-cli from 1.8.0 to 1.9.0 [maven]
gnodet commented on PR #1665: URL: https://github.com/apache/maven/pull/1665#issuecomment-2828302081 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8706] Bump commons-cli:commons-cli from 1.8.0 to 1.9.0 [maven]
gnodet merged PR #1665: URL: https://github.com/apache/maven/pull/1665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8706) Bump commons-cli:commons-cli from 1.8.0 to 1.9.0
Guillaume Nodet created MNG-8706: Summary: Bump commons-cli:commons-cli from 1.8.0 to 1.9.0 Key: MNG-8706 URL: https://issues.apache.org/jira/browse/MNG-8706 Project: Maven Issue Type: Task Reporter: Guillaume Nodet GitHub Pull Request: https://github.com/apache/maven/pull/1665 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8706) Bump commons-cli:commons-cli from 1.8.0 to 1.9.0
[ https://issues.apache.org/jira/browse/MNG-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-8706: Assignee: Guillaume Nodet > Bump commons-cli:commons-cli from 1.8.0 to 1.9.0 > > > Key: MNG-8706 > URL: https://issues.apache.org/jira/browse/MNG-8706 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > > GitHub Pull Request: https://github.com/apache/maven/pull/1665 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8706) Bump commons-cli:commons-cli from 1.8.0 to 1.9.0
[ https://issues.apache.org/jira/browse/MNG-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8706: - Issue Type: Dependency upgrade (was: Task) > Bump commons-cli:commons-cli from 1.8.0 to 1.9.0 > > > Key: MNG-8706 > URL: https://issues.apache.org/jira/browse/MNG-8706 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Priority: Major > > GitHub Pull Request: https://github.com/apache/maven/pull/1665 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8706) Bump commons-cli:commons-cli from 1.8.0 to 1.9.0
[ https://issues.apache.org/jira/browse/MNG-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8706. Resolution: Fixed > Bump commons-cli:commons-cli from 1.8.0 to 1.9.0 > > > Key: MNG-8706 > URL: https://issues.apache.org/jira/browse/MNG-8706 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.9.10 > > > GitHub Pull Request: https://github.com/apache/maven/pull/1665 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MNG-8694 - fix for resolve version from nested props [maven]
gnodet commented on code in PR #2272: URL: https://github.com/apache/maven/pull/2272#discussion_r2057963779 ## impl/maven-core/src/test/resources/projects/pom-parent-version-from-nested-properties/pom.xml: ## @@ -0,0 +1,14 @@ +http://maven.apache.org/POM/4.1.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 http://maven.apache.org/xsd/maven-4.1.0.xsd";> + 4.0.0 Review Comment: Please change this line to 4.1.0. This should make the test fail with: ``` org.apache.maven.project.ProjectBuildingException: 1 problem was - [FATAL] 'version' contains an expression but should be a constant. @ line 7, column 3 for project at .../maven/impl/maven-core/src/test/resources/projects/pom-parent-version-from-nested-properties/pom.xml ``` The reason is that the 4.1.0 model validation enforces the fact that version can be completely resolved. I think we need to use the `org.apache.maven.impl.model.DefaultInterpolator` service as indicated in the TODO above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MNG-8694 - fix for resolve version from nested props [maven]
gnodet commented on code in PR #2272:
URL: https://github.com/apache/maven/pull/2272#discussion_r2057972739
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##
@@ -597,8 +597,8 @@ String replaceCiFriendlyVersion(Map
properties, String version)
// extract the key inside ${}
String key = matcher.group(1);
Review Comment:
Actually the whole method can be replaced easily with:
```
String replaceCiFriendlyVersion(Map properties,
String version) {
return version != null ? interpolator.interpolate(version,
properties::get) : null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MNG-8694) Version not augmentable during runtime in Maven 4 as it was in Maven 3
[
https://issues.apache.org/jira/browse/MNG-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reassigned MNG-8694:
Assignee: Guillaume Nodet
> Version not augmentable during runtime in Maven 4 as it was in Maven 3
> ---
>
> Key: MNG-8694
> URL: https://issues.apache.org/jira/browse/MNG-8694
> Project: Maven
> Issue Type: Wish
> Components: Reactor and Workspace
>Affects Versions: 4.0.0-rc-3
> Environment: MacOS Silicon
> Zulu Java 21
>Reporter: Nico Jahn
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-rc-4
>
> Attachments: MNG-6894-log.txt, revision-demo.zip
>
>
> In Maven 3.x the revision property could be used to
> - dynamically define the final version of a project
> - while defining the version core (SemVer) hardcoded in the project setup.
> This is useful when defining special versions based on profiles.
> In our special case we do not inject version info from outside, but keep the
> version hardcoded and used profiles to augment the version during a build on
> a developer's computer by "-DEVELOPER" while enabling a build server to
> create a final release.
> Here a working example in Maven 3.x
> {{ de.g667.m4-demo}}
> {{ m4-demo-revision}}
> {{ ${revision}}}
> {{ pom}}
> {{ }}
> {{ 0.1.0}}
> {{ ${versionCore}}}
> {{ }}
> {{ }}
> {{ }}
> {{ development}}
> {{ }}
> {{ }}
> {{ !release}}
> {{ }}
> {{ }}
> {{ }}
> {{ ${versionCore}-DEVELOPER}}
> {{ }}
> {{ }}
> {{ }}
> Developer calls {{mvn clean install}}
> and produces Building {{m4-demo-revision 0.1.0-DEVELOPER}}
> Build server calls {{mvn clean install -Drelease}}
> and produces Building {{m4-demo-revision 0.1.0}}
> There are also more complex scenarios where other profiles are used to
> augment the version by additional data like a build number etc.
> With Maven 4 this does not work anymore. As far as I understand it is because
> Maven now resolves {{}} before it evaluates {{}} and
> therefore returns
> {{[ERROR] Internal error: java.lang.IllegalArgumentException: No group with
> name \{versionCore} -> [Help 1]}}
> {{{}org.apache.maven.InternalErrorException: Internal error:
> java.lang.IllegalArgumentException: No group with name {versionCore{
> After some investigation is seems there is no other way to reach our goal,
> without writing the version core at least twice in the pom files, which is
> error-prone.
> Especially since Maven gets "Full support of CI-friendly variables" and
> therefore the revision property can be used easier as before, it would also
> be nice to have the possiblity to enable version management like shown in the
> example. In some scenarios it is not feasible to inject versions externally,
> but ensure correct version management within the project setup directly.
> Handling version this way ensures version integrity accross multiple build
> systems during different development phases. Additionally when a whole
> software product line is maintained in multiple versions developers can
> simply switch between versions, build and reference their local build
> artifacts and dont have cross-effects on their machines.
> Maven 4 breaks a working and simple pattern from Maven 3, without providing a
> proper replacement.
> ===
> Without knowing if it is (and hoping it's not) actually an intended behavior,
> maybe a solution is already available. The error (see attached log) is during
> parsing by a regex. At exactly this place a comment to use an interpolation
> service instead was created and one day later it was added.
> {{2024-10-02 f6417e4944}}
> {{[MNG-8281] Interpolator service}}
> {{MNG-8281 is Task according MNG-8262 }}
> {{2024-10-01 885a4b3a26}}
> {{[MNG-8230] Rewrite CI friendly versions (#1710)}}
> {{maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java}}
> {{location in current commit on master:
> /impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java}}
> {{603 String replaceCiFriendlyVersion(Map properties, String
> version) {}}
> {{604 // TODO: we're using a simple regex here, but we should probably
> use}}
> {{605 // a proper interpolation service to do the replacements}}
> {{606 // once one is available in maven-api-impl}}
> {{607 // https://issues.apache.org/jira/browse/MNG-8262}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8694) Version not augmentable during runtime in Maven 4 as it was in Maven 3
[
https://issues.apache.org/jira/browse/MNG-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8694:
-
Fix Version/s: 4.0.0-rc-4
> Version not augmentable during runtime in Maven 4 as it was in Maven 3
> ---
>
> Key: MNG-8694
> URL: https://issues.apache.org/jira/browse/MNG-8694
> Project: Maven
> Issue Type: Wish
> Components: Reactor and Workspace
>Affects Versions: 4.0.0-rc-3
> Environment: MacOS Silicon
> Zulu Java 21
>Reporter: Nico Jahn
>Priority: Major
> Fix For: 4.0.0-rc-4
>
> Attachments: MNG-6894-log.txt, revision-demo.zip
>
>
> In Maven 3.x the revision property could be used to
> - dynamically define the final version of a project
> - while defining the version core (SemVer) hardcoded in the project setup.
> This is useful when defining special versions based on profiles.
> In our special case we do not inject version info from outside, but keep the
> version hardcoded and used profiles to augment the version during a build on
> a developer's computer by "-DEVELOPER" while enabling a build server to
> create a final release.
> Here a working example in Maven 3.x
> {{ de.g667.m4-demo}}
> {{ m4-demo-revision}}
> {{ ${revision}}}
> {{ pom}}
> {{ }}
> {{ 0.1.0}}
> {{ ${versionCore}}}
> {{ }}
> {{ }}
> {{ }}
> {{ development}}
> {{ }}
> {{ }}
> {{ !release}}
> {{ }}
> {{ }}
> {{ }}
> {{ ${versionCore}-DEVELOPER}}
> {{ }}
> {{ }}
> {{ }}
> Developer calls {{mvn clean install}}
> and produces Building {{m4-demo-revision 0.1.0-DEVELOPER}}
> Build server calls {{mvn clean install -Drelease}}
> and produces Building {{m4-demo-revision 0.1.0}}
> There are also more complex scenarios where other profiles are used to
> augment the version by additional data like a build number etc.
> With Maven 4 this does not work anymore. As far as I understand it is because
> Maven now resolves {{}} before it evaluates {{}} and
> therefore returns
> {{[ERROR] Internal error: java.lang.IllegalArgumentException: No group with
> name \{versionCore} -> [Help 1]}}
> {{{}org.apache.maven.InternalErrorException: Internal error:
> java.lang.IllegalArgumentException: No group with name {versionCore{
> After some investigation is seems there is no other way to reach our goal,
> without writing the version core at least twice in the pom files, which is
> error-prone.
> Especially since Maven gets "Full support of CI-friendly variables" and
> therefore the revision property can be used easier as before, it would also
> be nice to have the possiblity to enable version management like shown in the
> example. In some scenarios it is not feasible to inject versions externally,
> but ensure correct version management within the project setup directly.
> Handling version this way ensures version integrity accross multiple build
> systems during different development phases. Additionally when a whole
> software product line is maintained in multiple versions developers can
> simply switch between versions, build and reference their local build
> artifacts and dont have cross-effects on their machines.
> Maven 4 breaks a working and simple pattern from Maven 3, without providing a
> proper replacement.
> ===
> Without knowing if it is (and hoping it's not) actually an intended behavior,
> maybe a solution is already available. The error (see attached log) is during
> parsing by a regex. At exactly this place a comment to use an interpolation
> service instead was created and one day later it was added.
> {{2024-10-02 f6417e4944}}
> {{[MNG-8281] Interpolator service}}
> {{MNG-8281 is Task according MNG-8262 }}
> {{2024-10-01 885a4b3a26}}
> {{[MNG-8230] Rewrite CI friendly versions (#1710)}}
> {{maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java}}
> {{location in current commit on master:
> /impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java}}
> {{603 String replaceCiFriendlyVersion(Map properties, String
> version) {}}
> {{604 // TODO: we're using a simple regex here, but we should probably
> use}}
> {{605 // a proper interpolation service to do the replacements}}
> {{606 // once one is available in maven-api-impl}}
> {{607 // https://issues.apache.org/jira/browse/MNG-8262}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-8705) Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0
Guillaume Nodet created MNG-8705: Summary: Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0 Key: MNG-8705 URL: https://issues.apache.org/jira/browse/MNG-8705 Project: Maven Issue Type: Task Reporter: Guillaume Nodet GitHub Pull Request: https://github.com/apache/maven/pull/2270 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8705] Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0 [maven]
gnodet merged PR #2270: URL: https://github.com/apache/maven/pull/2270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8705) Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0
[ https://issues.apache.org/jira/browse/MNG-8705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8705. Resolution: Fixed > Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0 > > > Key: MNG-8705 > URL: https://issues.apache.org/jira/browse/MNG-8705 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.9.10 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2270 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8705) Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0
[ https://issues.apache.org/jira/browse/MNG-8705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8705: - Fix Version/s: 3.9.10 > Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0 > > > Key: MNG-8705 > URL: https://issues.apache.org/jira/browse/MNG-8705 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Priority: Major > Fix For: 3.9.10 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2270 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8705) Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0
[ https://issues.apache.org/jira/browse/MNG-8705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8705: - Issue Type: Dependency upgrade (was: Task) > Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0 > > > Key: MNG-8705 > URL: https://issues.apache.org/jira/browse/MNG-8705 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Priority: Major > > GitHub Pull Request: https://github.com/apache/maven/pull/2270 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8705) Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0
[ https://issues.apache.org/jira/browse/MNG-8705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-8705: Assignee: Guillaume Nodet > Bump commons-jxpath:commons-jxpath from 1.3 to 1.4.0 > > > Key: MNG-8705 > URL: https://issues.apache.org/jira/browse/MNG-8705 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.9.10 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2270 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MNG-8694 - fix for resolve version from nested props [maven]
kamilkrzywanski commented on PR #2272: URL: https://github.com/apache/maven/pull/2272#issuecomment-2827082457 @gnodet Removed unused regex as well, can you approve again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8632] Update Full Build pipeline to also build with JDK 24 [maven]
slachiewicz commented on PR #2169: URL: https://github.com/apache/maven/pull/2169#issuecomment-2827051766 While change to sisu was merged, it is blocked by lack of Sisu release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MNG-8694 - fix for resolve version from nested props [maven]
gnodet commented on code in PR #2272:
URL: https://github.com/apache/maven/pull/2272#discussion_r2058021561
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##
@@ -597,8 +597,8 @@ String replaceCiFriendlyVersion(Map
properties, String version)
// extract the key inside ${}
String key = matcher.group(1);
Review Comment:
Yes, though I'm not sure it will completely solve the original problem which
is to provide the version using a profile. This may require to use a different
mechanism, such as default values with the support for `:-` and `:+` already
provided by the interpolator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.testcontainers:testcontainers-bom from 1.20.6 to 1.21.0 [maven-build-cache-extension]
dependabot[bot] opened a new pull request, #208:
URL: https://github.com/apache/maven-build-cache-extension/pull/208
Bumps
[org.testcontainers:testcontainers-bom](https://github.com/testcontainers/testcontainers-java)
from 1.20.6 to 1.21.0.
Release notes
Sourced from https://github.com/testcontainers/testcontainers-java/releases";>org.testcontainers:testcontainers-bom's
releases.
1.21.0
What's Changed
Fix typo in LGTM container method (https://redirect.github.com/testcontainers/testcontainers-java/issues/10189";>#10189)
https://github.com/jaydeluca";>@jaydeluca
Pass start command required in Solr 10 (https://redirect.github.com/testcontainers/testcontainers-java/issues/10174";>#10174)
https://github.com/epugh";>@epugh
[solr] Replace "create_core" with "create" command
(https://redirect.github.com/testcontainers/testcontainers-java/issues/10172";>#10172)
https://github.com/epugh";>@epugh
Update docs version to ${GITHUB_REF##*/} (https://redirect.github.com/testcontainers/testcontainers-java/issues/10063";>#10063)
https://github.com/github-actions";>@github-actions
Update testcontainers version to ${GITHUB_REF##*/} (https://redirect.github.com/testcontainers/testcontainers-java/issues/10062";>#10062)
https://github.com/github-actions";>@github-actions
⚠️ Breaking API changes
Remove spock-core from spock module (https://redirect.github.com/testcontainers/testcontainers-java/issues/10069";>#10069)
https://github.com/eddumelendez";>@eddumelendez
Uses clickhouse/clickhouse-server as Docker Image in
ClickHouseProvider (https://redirect.github.com/testcontainers/testcontainers-java/issues/8738";>#8738)
https://github.com/linghengqian";>@linghengqian
🚀 Features & Enhancements
Expose Tempo in LgtmContainer (https://redirect.github.com/testcontainers/testcontainers-java/issues/10192";>#10192)
https://github.com/jaydeluca";>@jaydeluca
Allow spock tests to be skipped when Docker is unavailable (https://redirect.github.com/testcontainers/testcontainers-java/issues/10180";>#10180)
https://github.com/eddumelendez";>@eddumelendez
Support new chromadb api version (https://redirect.github.com/testcontainers/testcontainers-java/issues/10170";>#10170)
https://github.com/dev-jonghoonpark";>@dev-jonghoonpark
Add default database name to MongoDB Atlas (https://redirect.github.com/testcontainers/testcontainers-java/issues/10034";>#10034)
https://github.com/blancqua";>@blancqua
[servicebus] Skip waiting for sql to be ready (https://redirect.github.com/testcontainers/testcontainers-java/issues/10092";>#10092)
https://github.com/eddumelendez";>@eddumelendez
Support additional flags in FirestoreEmulatorContainer (https://redirect.github.com/testcontainers/testcontainers-java/issues/10067";>#10067)
https://github.com/eddumelendez";>@eddumelendez
☠️ Deprecations
Deprecate getUserPass and add getPassword (https://redirect.github.com/testcontainers/testcontainers-java/issues/10064";>#10064)
https://github.com/eddumelendez";>@eddumelendez
🐛 Bug Fixes
Fix connection leak in JdbcDatabaseDelegate (https://redirect.github.com/testcontainers/testcontainers-java/issues/9662";>#9662)
https://github.com/froque";>@froque
Allow configuring the AlwaysPullPolicy (https://redirect.github.com/testcontainers/testcontainers-java/issues/10188";>#10188)
https://github.com/sebastian-steiner";>@sebastian-steiner
📖 Documentation
Add DockerModelRunnerContainer to core (https://redirect.github.com/testcontainers/testcontainers-java/issues/10183";>#10183)
https://github.com/kiview";>@kiview
Allow configuring the AlwaysPullPolicy (https://redirect.github.com/testcontainers/testcontainers-java/issues/10188";>#10188)
https://github.com/sebastian-steiner";>@sebastian-steiner
Fix Apache Solr link (https://redirect.github.com/testcontainers/testcontainers-java/issues/10171";>#10171)
https://github.com/epugh";>@epugh
Remove incubator note from Solr docs (https://redirect.github.com/testcontainers/testcontainers-java/issues/10173";>#10173)
https://github.com/epugh";>@epugh
Remove linked-container (https://redirect.github.com/testcontainers/testcontainers-java/issues/10065";>#10065)
https://github.com/eddumelendez";>@eddumelendez
🧹 Housekeeping
Add SFTP host key check example (https://redirect.github.com/testcontainers/testcontainers-java/issues/10127";>#10127)
https://github.com/julianladisch";>@julianladisch
Remove linked-container (https://redirect.github.com/testcontainers/testcontainers-java/issues/10065";>#10065)
https://github.com/eddumelendez";>@eddumelendez
📦 Dependency updates
Update Gradle Wrapper from undefined to 8.13 (https://redirect.github.com/testcontainers/testcontainers-java/issues/10033";>#10033)
https://github.com/github-actions";>@github-actions
Update docker-java version to 3.4.2 (https://redirect.github.com/testcontai
Re: [PR] MNG-8694 - fix for resolve version from nested props [maven]
kamilkrzywanski commented on code in PR #2272: URL: https://github.com/apache/maven/pull/2272#discussion_r2057990378 ## impl/maven-core/src/test/resources/projects/pom-parent-version-from-nested-properties/pom.xml: ## @@ -0,0 +1,14 @@ +http://maven.apache.org/POM/4.1.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 http://maven.apache.org/xsd/maven-4.1.0.xsd";> + 4.0.0 Review Comment: Right, fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MNG-8694 - fix for resolve version from nested props [maven]
kamilkrzywanski commented on code in PR #2272:
URL: https://github.com/apache/maven/pull/2272#discussion_r2057998800
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##
@@ -597,8 +597,8 @@ String replaceCiFriendlyVersion(Map
properties, String version)
// extract the key inside ${}
String key = matcher.group(1);
Review Comment:
Right, now works with 4.0.0 and 4.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8649) Maven 4 migration tool
[ https://issues.apache.org/jira/browse/MNG-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947105#comment-17947105 ] Tim te Beek commented on MNG-8649: -- Great to hear you're looking to help automate migrations to Maven 4. If there's any interest in using OpenRewrite to do so I'd love to collaborate with you all. On our end we've already automated some of the necessary steps, as part of [our Maven best practices recipe,|https://docs.openrewrite.org/recipes/maven/bestpractices] and we're looking to do more as needed. I'll let you weigh your options, but you know how to reach me if needed. :) > Maven 4 migration tool > -- > > Key: MNG-8649 > URL: https://issues.apache.org/jira/browse/MNG-8649 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Critical > > We should be able to help our users to migrate to Maven 4. > This can be done in several steps: > * fix POMs (not necessarily migrate to 4.1.0 model, but fix any deprecated > construct) > * update to more recent versions of plugins (some are known to have problems > with Maven 4) > * if the project is a plugin, we can try applying the draft > https://gist.github.com/gnodet/c297ccae07dd2ee67dfa98cf1ef128f9 > This may be implemented as a plugin or as a tool in the mvnsh script somehow. > A lot of failures for the first point can be found at > https://github.com/gnodet/maven4-testing/issues/2812. > It would be nice to alter the workflow above so that, in case of failure, the > migration tool is run and another attempt is done. > Ideally, the workflow would raise an issue on the project to track progress > in case the initial build fails (it may be difficult to track the link so > that we don't create a new issue each time we run the workflow). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8706) Bump commons-cli:commons-cli from 1.8.0 to 1.9.0
[ https://issues.apache.org/jira/browse/MNG-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8706: - Fix Version/s: 3.9.10 > Bump commons-cli:commons-cli from 1.8.0 to 1.9.0 > > > Key: MNG-8706 > URL: https://issues.apache.org/jira/browse/MNG-8706 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.9.10 > > > GitHub Pull Request: https://github.com/apache/maven/pull/1665 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8632) Add JDK 24 to the Full Build Pipeline Job
[ https://issues.apache.org/jira/browse/MNG-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-8632: -- Priority: Major (was: Trivial) > Add JDK 24 to the Full Build Pipeline Job > - > > Key: MNG-8632 > URL: https://issues.apache.org/jira/browse/MNG-8632 > Project: Maven > Issue Type: Improvement > Components: Bootstrap & Build >Affects Versions: 4.0.0-rc-3 >Reporter: Mark Derricutt >Priority: Major > > I noticed that the build currently fails under JDK 24 due to an outdated ASM > version in `sisu-maven-plugin`. > This is already being tracked upstream in: > https://github.com/eclipse-sisu/sisu-project/issues/174 > and once completed/released we can update Maven to use the newer plugin. > Prior to that we should update the Github pipelines to include JDK 24 in the > Full Build job. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-603) Apache HTTP transport should expose config for max redirects
[
https://issues.apache.org/jira/browse/MRESOLVER-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947148#comment-17947148
]
Slawomir Jaranowski commented on MRESOLVER-603:
---
[~cstamas] [~Didier Loiseau] cloned to MRESOLVER-703, I will try to do it for
19.23
> Apache HTTP transport should expose config for max redirects
>
>
> Key: MRESOLVER-603
> URL: https://issues.apache.org/jira/browse/MRESOLVER-603
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Affects Versions: 1.9.x
>Reporter: Didier Loiseau
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.2
>
>
> Apache HttpClient allows to {{{}RequestConfig.maxRedirects{}}}. It would be
> nice to expose it through configuration as for Jetty (MRESOLVER-595) and
> Wagon.
> Also note that setting it to 0 actually sets a value of 50, so it could be
> nice to be able to disable redirects entirely (as for Jetty).
> Ideally this should be implemented in 1.9.x since it {{HttpTransport}} is the
> default in Maven 3.9. (apparently the fix version was copied from
> MRESOLVER-595 when I cloned it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRESOLVER-704) Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3
[ https://issues.apache.org/jira/browse/MRESOLVER-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MRESOLVER-704: -- Fix Version/s: 1.9.23 > Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3 > -- > > Key: MRESOLVER-704 > URL: https://issues.apache.org/jira/browse/MRESOLVER-704 > Project: Maven Resolver > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 1.9.23 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRESOLVER-704) Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3
Slawomir Jaranowski created MRESOLVER-704: - Summary: Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3 Key: MRESOLVER-704 URL: https://issues.apache.org/jira/browse/MRESOLVER-704 Project: Maven Resolver Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-703) Apache HTTP transport should expose config for max redirects
[
https://issues.apache.org/jira/browse/MRESOLVER-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MRESOLVER-703:
--
Fix Version/s: (was: 2.0.2)
> Apache HTTP transport should expose config for max redirects
>
>
> Key: MRESOLVER-703
> URL: https://issues.apache.org/jira/browse/MRESOLVER-703
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Affects Versions: 1.9.x
>Reporter: Didier Loiseau
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 1.9.23
>
>
> Apache HttpClient allows to {{{}RequestConfig.maxRedirects{}}}. It would be
> nice to expose it through configuration as for Jetty (MRESOLVER-595) and
> Wagon.
> Also note that setting it to 0 actually sets a value of 50, so it could be
> nice to be able to disable redirects entirely (as for Jetty).
> Ideally this should be implemented in 1.9.x since it {{HttpTransport}} is the
> default in Maven 3.9. (apparently the fix version was copied from
> MRESOLVER-595 when I cloned it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRESOLVER-603) Apache HTTP transport should expose config for max redirects
[
https://issues.apache.org/jira/browse/MRESOLVER-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MRESOLVER-603:
--
Fix Version/s: (was: 1.9.23)
> Apache HTTP transport should expose config for max redirects
>
>
> Key: MRESOLVER-603
> URL: https://issues.apache.org/jira/browse/MRESOLVER-603
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Affects Versions: 1.9.x
>Reporter: Didier Loiseau
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.2
>
>
> Apache HttpClient allows to {{{}RequestConfig.maxRedirects{}}}. It would be
> nice to expose it through configuration as for Jetty (MRESOLVER-595) and
> Wagon.
> Also note that setting it to 0 actually sets a value of 50, so it could be
> nice to be able to disable redirects entirely (as for Jetty).
> Ideally this should be implemented in 1.9.x since it {{HttpTransport}} is the
> default in Maven 3.9. (apparently the fix version was copied from
> MRESOLVER-595 when I cloned it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MRESOLVER-703) Apache HTTP transport should expose config for max redirects
Slawomir Jaranowski created MRESOLVER-703:
-
Summary: Apache HTTP transport should expose config for max
redirects
Key: MRESOLVER-703
URL: https://issues.apache.org/jira/browse/MRESOLVER-703
Project: Maven Resolver
Issue Type: Improvement
Components: Resolver
Affects Versions: 1.9.x
Reporter: Didier Loiseau
Assignee: Tamas Cservenak
Fix For: 1.9.23, 2.0.2
Apache HttpClient allows to {{{}RequestConfig.maxRedirects{}}}. It would be
nice to expose it through configuration as for Jetty (MRESOLVER-595) and Wagon.
Also note that setting it to 0 actually sets a value of 50, so it could be nice
to be able to disable redirects entirely (as for Jetty).
Ideally this should be implemented in 1.9.x since it {{HttpTransport}} is the
default in Maven 3.9. (apparently the fix version was copied from MRESOLVER-595
when I cloned it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MRESOLVER-703) Apache HTTP transport should expose config for max redirects
[
https://issues.apache.org/jira/browse/MRESOLVER-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MRESOLVER-703:
-
Assignee: Slawomir Jaranowski (was: Tamas Cservenak)
> Apache HTTP transport should expose config for max redirects
>
>
> Key: MRESOLVER-703
> URL: https://issues.apache.org/jira/browse/MRESOLVER-703
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Affects Versions: 1.9.x
>Reporter: Didier Loiseau
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 1.9.23, 2.0.2
>
>
> Apache HttpClient allows to {{{}RequestConfig.maxRedirects{}}}. It would be
> nice to expose it through configuration as for Jetty (MRESOLVER-595) and
> Wagon.
> Also note that setting it to 0 actually sets a value of 50, so it could be
> nice to be able to disable redirects entirely (as for Jetty).
> Ideally this should be implemented in 1.9.x since it {{HttpTransport}} is the
> default in Maven 3.9. (apparently the fix version was copied from
> MRESOLVER-595 when I cloned it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947218#comment-17947218
]
ASF GitHub Bot commented on MBUILDCACHE-123:
zrlw opened a new pull request, #209:
URL: https://github.com/apache/maven-build-cache-extension/pull/209
```MojoParametersListener#beforeMojoExecution``` only needs to set
projectExecutions when ```source == Source.LIFECYCLE && !forkedExecution``` is
true, the most appropriate way to handle it is adding field cacheState to
MojoParametersListener and setting it's value by
```BuildCacheMojosExecutionStrategy```.
@olamy
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [MBUILDCACHE JIRA
issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Yu Yu
>Assignee: Olivier Lamy
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdT
[jira] [Commented] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947204#comment-17947204
]
ASF GitHub Bot commented on MBUILDCACHE-123:
zrlw opened a new pull request, #209:
URL: https://github.com/apache/maven-build-cache-extension/pull/209
```MojoParametersListener#beforeMojoExecution``` only needs to set
projectExecutions when ```source == Source.LIFECYCLE && !forkedExecution``` is
true, the most appropriate way to handle it is adding field cacheState to
MojoParametersListener and setting it's value by
```BuildCacheMojosExecutionStrategy```.
@olamy
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [MBUILDCACHE JIRA
issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Yu Yu
>Assignee: Olivier Lamy
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdT
[PR] [MBUILDCACHE-123] remove duplicated codes by adding field cacheState to MojoParametersListener [maven-build-cache-extension]
zrlw opened a new pull request, #209: URL: https://github.com/apache/maven-build-cache-extension/pull/209 ```MojoParametersListener#beforeMojoExecution``` only needs to set projectExecutions when ```source == Source.LIFECYCLE && !forkedExecution``` is true, the most appropriate way to handle it is adding field cacheState to MojoParametersListener and setting it's value by ```BuildCacheMojosExecutionStrategy```. @olamy Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [MBUILDCACHE JIRA issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MBUILDCACHE-123] do not set projectExecutions if cacheState is disabled [maven-build-cache-extension]
zrlw commented on PR #207: URL: https://github.com/apache/maven-build-cache-extension/pull/207#issuecomment-2829263096 the pr needs to be optimized since it has duplicated codes and did useless work when the condition ```source == Source.LIFECYCLE && !forkedExecution``` is false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947208#comment-17947208
]
ASF GitHub Bot commented on MBUILDCACHE-123:
zrlw commented on PR #207:
URL:
https://github.com/apache/maven-build-cache-extension/pull/207#issuecomment-2829263096
the pr needs to be optimized since it has duplicated codes and did useless
work when the condition ```source == Source.LIFECYCLE && !forkedExecution``` is
false.
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Yu Yu
>Assignee: Olivier Lamy
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
> this pr is related to
> [apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8694] Fix version interpolation and ternary operator [maven]
gnodet commented on PR #2272:
URL: https://github.com/apache/maven/pull/2272#issuecomment-2829536911
> @gnodet Test case extended
Thx, I slightly modified it as one of the problem was the generation of an
empty string when `release` is defined to `true` (which is what happens when
using `-Drelease` on the command line for example).
This PR now fixes the ternary operator to support expressions such as
`${release:+${foo}:-${bar}}` or `${versionCore}${release:+-DEVELOPER}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947184#comment-17947184
]
ASF GitHub Bot commented on MBUILDCACHE-123:
olamy merged PR #207:
URL: https://github.com/apache/maven-build-cache-extension/pull/207
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Yu Yu
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 1.3.0
>
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
> this pr is related to
> [apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MBUILDCACHE-123.
Resolution: Fixed
Thanks for the contribution
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Yu Yu
>Assignee: Olivier Lamy
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
> this pr is related to
> [apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.testcontainers:testcontainers-bom from 1.20.6 to 1.21.0 [maven-build-cache-extension]
dependabot[bot] merged PR #208: URL: https://github.com/apache/maven-build-cache-extension/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy reassigned MBUILDCACHE-123:
Assignee: Olivier Lamy
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Yu Yu
>Assignee: Olivier Lamy
>Priority: Major
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
> this pr is related to
> [apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8694] fix for resolve version from nested props [maven]
kamilkrzywanski commented on PR #2272: URL: https://github.com/apache/maven/pull/2272#issuecomment-2828900977 @gnodet Test case extebded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8531) Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 3.6.0
[ https://issues.apache.org/jira/browse/MNG-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8531: - Issue Type: Dependency upgrade (was: Task) > Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 3.6.0 > - > > Key: MNG-8531 > URL: https://issues.apache.org/jira/browse/MNG-8531 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.9.10 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2013 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8534) Bump org.codehaus.mojo:buildnumber-maven-plugin from 3.2.0 to 3.2.1
[ https://issues.apache.org/jira/browse/MNG-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8534: - Issue Type: Dependency upgrade (was: Task) > Bump org.codehaus.mojo:buildnumber-maven-plugin from 3.2.0 to 3.2.1 > --- > > Key: MNG-8534 > URL: https://issues.apache.org/jira/browse/MNG-8534 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.9.10 > > > GitHub Pull Request: https://github.com/apache/maven/pull/1699 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8532) Bump commons-io:commons-io from 2.16.1 to 2.18.0
[ https://issues.apache.org/jira/browse/MNG-8532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8532: - Issue Type: Dependency upgrade (was: Task) > Bump commons-io:commons-io from 2.16.1 to 2.18.0 > > > Key: MNG-8532 > URL: https://issues.apache.org/jira/browse/MNG-8532 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.9.10 > > > GitHub Pull Request: https://github.com/apache/maven/pull/1926 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-113) java.security.AccessController in java.security has been deprecated and marked for removal
[ https://issues.apache.org/jira/browse/MBUILDCACHE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947188#comment-17947188 ] ASF GitHub Bot commented on MBUILDCACHE-113: olamy merged PR #205: URL: https://github.com/apache/maven-build-cache-extension/pull/205 > java.security.AccessController in java.security has been deprecated and > marked for removal > -- > > Key: MBUILDCACHE-113 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-113 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Sylwester Lachiewicz >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.3.0 > > > in the class CloseableBuffer we have calls to > java.security.AccessController.doPrivileged that should be removed to support > Java 24+ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-113) java.security.AccessController in java.security has been deprecated and marked for removal
[ https://issues.apache.org/jira/browse/MBUILDCACHE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947187#comment-17947187 ] ASF GitHub Bot commented on MBUILDCACHE-113: olamy commented on PR #205: URL: https://github.com/apache/maven-build-cache-extension/pull/205#issuecomment-2829201257 Thanks for the contribution > java.security.AccessController in java.security has been deprecated and > marked for removal > -- > > Key: MBUILDCACHE-113 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-113 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Sylwester Lachiewicz >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.3.0 > > > in the class CloseableBuffer we have calls to > java.security.AccessController.doPrivileged that should be removed to support > Java 24+ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MBUILDCACHE-113) java.security.AccessController in java.security has been deprecated and marked for removal
[ https://issues.apache.org/jira/browse/MBUILDCACHE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MBUILDCACHE-113. Resolution: Fixed Thanks for the contribution > java.security.AccessController in java.security has been deprecated and > marked for removal > -- > > Key: MBUILDCACHE-113 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-113 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Sylwester Lachiewicz >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.3.0 > > > in the class CloseableBuffer we have calls to > java.security.AccessController.doPrivileged that should be removed to support > Java 24+ -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-123] do not set projectExecutions if cacheState is disabled [maven-build-cache-extension]
olamy merged PR #207: URL: https://github.com/apache/maven-build-cache-extension/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated MBUILDCACHE-123:
---
Labels: pull-request-available (was: )
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Yu Yu
>Assignee: Olivier Lamy
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
> this pr is related to
> [apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy updated MBUILDCACHE-123:
-
Fix Version/s: 1.3.0
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Yu Yu
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 1.3.0
>
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
> this pr is related to
> [apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.testcontainers:testcontainers-bom from 1.20.6 to 1.21.0 [maven-build-cache-extension]
olamy commented on PR #208: URL: https://github.com/apache/maven-build-cache-extension/pull/208#issuecomment-2829199826 @dependabot merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.fasterxml.jackson:jackson-bom from 2.18.3 to 2.19.0 [maven-changes-plugin]
dependabot[bot] opened a new pull request, #126: URL: https://github.com/apache/maven-changes-plugin/pull/126 Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.18.3 to 2.19.0. Commits https://github.com/FasterXML/jackson-bom/commit/077244b0591351fd93f5f16bd0ea2fecf0ff55d6";>077244b [maven-release-plugin] prepare release jackson-bom-2.19.0 https://github.com/FasterXML/jackson-bom/commit/4dc20cbff733f8d27b6a153e087f4d57ceb864ca";>4dc20cb Prep for 2.19.0 release https://github.com/FasterXML/jackson-bom/commit/d9bd9169172d9e6d559b3dd288c9574f208c4c1b";>d9bd916 Merge branch '2.18' into 2.19 https://github.com/FasterXML/jackson-bom/commit/6b19afb61225dc396dd3354ee0a42a9aed401db5";>6b19afb Update CI to latest Ubuntu https://github.com/FasterXML/jackson-bom/commit/08349a2705673d85bcbb454d054fa796553560a5";>08349a2 Back to snapshot dep https://github.com/FasterXML/jackson-bom/commit/4a60457d99d5c9739df941b73191655a9d25213a";>4a60457 [maven-release-plugin] prepare for next development iteration https://github.com/FasterXML/jackson-bom/commit/59119afb2dbba7e46e15246b36500785c2db63e3";>59119af [maven-release-plugin] prepare release jackson-bom-2.19.0-rc2 https://github.com/FasterXML/jackson-bom/commit/503a4443e7ccb264a67e32a091a06afdca2e805f";>503a444 Prep for 2.19.0-rc2 (due to botched rc1) https://github.com/FasterXML/jackson-bom/commit/52fed7bb539e34b4ee3a0dd1e1c3d6493c126a71";>52fed7b Rename master->3.x https://github.com/FasterXML/jackson-bom/commit/8953aa24c8c569a229016e509f366a81f0cc31c5";>8953aa2 Back to snapshot dep Additional commits viewable in https://github.com/FasterXML/jackson-bom/compare/jackson-bom-2.18.3...jackson-bom-2.19.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-8572) DI beans are not visible from build extensions
[ https://issues.apache.org/jira/browse/MNG-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-8572: Assignee: Guillaume Nodet > DI beans are not visible from build extensions > -- > > Key: MNG-8572 > URL: https://issues.apache.org/jira/browse/MNG-8572 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-rc-2 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-113] java.security.AccessController in java.security has been deprecated and marked for removal [maven-build-cache-extension]
olamy commented on PR #205: URL: https://github.com/apache/maven-build-cache-extension/pull/205#issuecomment-2829201257 Thanks for the contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MBUILDCACHE-113) java.security.AccessController in java.security has been deprecated and marked for removal
[ https://issues.apache.org/jira/browse/MBUILDCACHE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy reassigned MBUILDCACHE-113: Assignee: Olivier Lamy > java.security.AccessController in java.security has been deprecated and > marked for removal > -- > > Key: MBUILDCACHE-113 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-113 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Sylwester Lachiewicz >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > > in the class CloseableBuffer we have calls to > java.security.AccessController.doPrivileged that should be removed to support > Java 24+ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-113) java.security.AccessController in java.security has been deprecated and marked for removal
[ https://issues.apache.org/jira/browse/MBUILDCACHE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MBUILDCACHE-113: - Fix Version/s: 1.3.0 > java.security.AccessController in java.security has been deprecated and > marked for removal > -- > > Key: MBUILDCACHE-113 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-113 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Sylwester Lachiewicz >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.3.0 > > > in the class CloseableBuffer we have calls to > java.security.AccessController.doPrivileged that should be removed to support > Java 24+ -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-113] java.security.AccessController in java.security has been deprecated and marked for removal [maven-build-cache-extension]
olamy merged PR #205: URL: https://github.com/apache/maven-build-cache-extension/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MBUILDCACHE-123] remove duplicated codes by adding field cacheState to MojoParametersListener [maven-build-cache-extension]
zrlw closed pull request #209: [MBUILDCACHE-123] remove duplicated codes by adding field cacheState to MojoParametersListener URL: https://github.com/apache/maven-build-cache-extension/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-123) do not set projectExecutions if cacheState is disabled
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947216#comment-17947216
]
ASF GitHub Bot commented on MBUILDCACHE-123:
zrlw closed pull request #209: [MBUILDCACHE-123] remove duplicated codes by
adding field cacheState to MojoParametersListener
URL: https://github.com/apache/maven-build-cache-extension/pull/209
> do not set projectExecutions if cacheState is disabled
> ---
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Yu Yu
>Assignee: Olivier Lamy
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
> this pr is related to
> [apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Fix the checkstyle violation introduced in the new version of the parent pom [maven-jlink-plugin]
Ndacyayisenga-droid opened a new pull request, #608: URL: https://github.com/apache/maven-jlink-plugin/pull/608 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [GitHub issue](https://github.com/apache/maven-jlink-plugin/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[#] - Fixes bug in ApproximateQuantiles`, where you replace `#` with the appropriate GitHub issue. Best practice is to use the GitHub issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8694] fix for resolve version from nested props [maven]
kamilkrzywanski commented on PR #2272:
URL: https://github.com/apache/maven/pull/2272#issuecomment-2828834033
@gnodet I've created an example like this:
However, it fails with: org.apache.maven.api.services.InterpolatorException:
recursive variable reference: release.
I'll investigate further.
```
http://maven.apache.org/POM/4.1.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.1.0
http://maven.apache.org/xsd/maven-4.1.0.xsd";
>
4.0.0
de.g667.m4-demo
m4-demo-revision
${revision}
pom
0.1.0
${release:--DEVELOPER}
${versionCore}${release}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] GitHub action set fail-fast to false [maven-javadoc-plugin]
slawekjaranowski opened a new pull request, #366: URL: https://github.com/apache/maven-javadoc-plugin/pull/366 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-cli:commons-cli from 1.8.0 to 1.9.0 [maven]
cowwoc commented on PR #1665: URL: https://github.com/apache/maven/pull/1665#issuecomment-2828294364 Any progress on this issue? I'm looking forward to JDK 24 support and this issue is the only one listed as pending before the Maven 3.9.10 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8694] fix for resolve version from nested props [maven]
gnodet commented on PR #2272:
URL: https://github.com/apache/maven/pull/2272#issuecomment-2828217618
I still think this only partially address the use case from MNG-8694, so
IMHO we'd need to extend the test to support a similar use case. Probably not
using a profile, since it won't work, but using a value such as
`${coreVersion}${release:--DEVELOPER}` or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Add standard dependabot labels for 1.9.x [maven-resolver]
slawekjaranowski opened a new pull request, #690: URL: https://github.com/apache/maven-resolver/pull/690 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
