[jira] [Closed] (MNG-8612) Node.asString vs toString
[ https://issues.apache.org/jira/browse/MNG-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8612. Resolution: Fixed > Node.asString vs toString > - > > Key: MNG-8612 > URL: https://issues.apache.org/jira/browse/MNG-8612 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-rc-3 >Reporter: Elliotte Rusty Harold >Assignee: Guillaume Nodet >Priority: Blocker > Fix For: 4.0.0-rc-4 > > > The Node interface has an asString method. It seems likely that this should > just be toString like other Java classes. However, if there's a reason for a > separate method, the JavaDoc should explain that. Currently it says "Returns > a string representation of this dependency node." which is almost what the > JavaDoc for the generic toString method of object says: "Returns a string > representation of the object." -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8248) WARNING: A restricted method in java.lang.System has been called
[
https://issues.apache.org/jira/browse/MNG-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MNG-8248.
Resolution: Fixed
> WARNING: A restricted method in java.lang.System has been called
>
>
> Key: MNG-8248
> URL: https://issues.apache.org/jira/browse/MNG-8248
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.1, 3.8.2, 3.8.3, 3.8.4, 3.8.5, 3.8.6, 3.8.7, 3.8.8,
> 3.9.0, 3.9.1, 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6, 3.9.7, 3.9.8, 3.9.9,
> 4.0.0-beta-3, 4.0.0-beta-4
>Reporter: Karl Heinz Marbaise
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.9.10
>
>
> Building a project with JDK 24.ea.13 produces the following WARNING:
> {code}
> $> mvn clean verify
> WARNING: A restricted method in java.lang.System has been called
> WARNING: java.lang.System::load has been called by
> org.jline.nativ.JLineNativeLoader in an unnamed module
> (file:/Users/khm/tools/maven/lib/jline-3.26.3.jar)
> WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for
> callers in this module
> WARNING: Restricted methods will be blocked in a future release unless native
> access is enabled
> {code}
> also a simple:
> {code}
> mvn --version
> {code}
> wil trigger:
> {code}
> $> mvn --version
> WARNING: A restricted method in java.lang.System has been called
> WARNING: java.lang.System::load has been called by
> org.fusesource.jansi.internal.JansiLoader in an unnamed module
> (file:/Users/khm/tools/maven/lib/jansi-2.4.1.jar)
> WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for
> callers in this module
> WARNING: Restricted methods will be blocked in a future release unless native
> access is enabled
> Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
> Maven home: /Users/khm/tools/maven
> Java version: 24-ea, vendor: Oracle Corporation, runtime:
> /Users/khm/.sdkman/candidates/java/24.ea.13-open
> Default locale: en_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
> {code}
> Also opened an issue on JLine3 Project:
> https://github.com/jline/jline3/issues/1067
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8248) WARNING: A restricted method in java.lang.System has been called
[
https://issues.apache.org/jira/browse/MNG-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937948#comment-17937948
]
Jeremy Norris commented on MNG-8248:
Great, thanks! We look forward to the 3.9.10 release that resolves this.
> WARNING: A restricted method in java.lang.System has been called
>
>
> Key: MNG-8248
> URL: https://issues.apache.org/jira/browse/MNG-8248
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.1, 3.8.2, 3.8.3, 3.8.4, 3.8.5, 3.8.6, 3.8.7, 3.8.8,
> 3.9.0, 3.9.1, 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6, 3.9.7, 3.9.8, 3.9.9,
> 4.0.0-beta-3, 4.0.0-beta-4
>Reporter: Karl Heinz Marbaise
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.9.10
>
>
> Building a project with JDK 24.ea.13 produces the following WARNING:
> {code}
> $> mvn clean verify
> WARNING: A restricted method in java.lang.System has been called
> WARNING: java.lang.System::load has been called by
> org.jline.nativ.JLineNativeLoader in an unnamed module
> (file:/Users/khm/tools/maven/lib/jline-3.26.3.jar)
> WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for
> callers in this module
> WARNING: Restricted methods will be blocked in a future release unless native
> access is enabled
> {code}
> also a simple:
> {code}
> mvn --version
> {code}
> wil trigger:
> {code}
> $> mvn --version
> WARNING: A restricted method in java.lang.System has been called
> WARNING: java.lang.System::load has been called by
> org.fusesource.jansi.internal.JansiLoader in an unnamed module
> (file:/Users/khm/tools/maven/lib/jansi-2.4.1.jar)
> WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for
> callers in this module
> WARNING: Restricted methods will be blocked in a future release unless native
> access is enabled
> Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
> Maven home: /Users/khm/tools/maven
> Java version: 24-ea, vendor: Oracle Corporation, runtime:
> /Users/khm/.sdkman/candidates/java/24.ea.13-open
> Default locale: en_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
> {code}
> Also opened an issue on JLine3 Project:
> https://github.com/jline/jline3/issues/1067
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
desruisseaux commented on code in PR #2180:
URL: https://github.com/apache/maven/pull/2180#discussion_r2010521455
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -26,13 +26,23 @@
/**
* A root directory of source files.
* The sources may be Java main classes, test classes, resources or anything
else identified by the scope.
+ *
+ * Default values
+ * The default implementation of all methods in this interface match the
default values
+ * documented in {@code maven.mdo} (the POM model).
Review Comment:
Is the following better?
> The properties in this interface are defined in the `` element of
the [Maven project descriptor
4.1](https://maven.apache.org/xsd/maven-4.1.0.xsd). For each property, the
default value is either empty or documented in the project descriptor. The
default implementations of the methods provided in this interface are
consistent with that specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Enable GitHub issues [maven-war-plugin]
Bukama merged PR #84: URL: https://github.com/apache/maven-war-plugin/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable GitHub issues [maven-jar-plugin]
Bukama merged PR #126: URL: https://github.com/apache/maven-jar-plugin/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable GitHub issues [maven-ear-plugin]
Bukama merged PR #132: URL: https://github.com/apache/maven-ear-plugin/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable GitHub issues [maven-ear-plugin]
Bukama commented on PR #132: URL: https://github.com/apache/maven-ear-plugin/pull/132#issuecomment-2748955135 Oh. Will do in another. Took one of the PRs linked in the list to be sure everything is in and made the same changes here (and in the other PRs). After that my brain said "done" with part 1 🙈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8644) DefaultProject should check for non null values earlier
Elliotte Rusty Harold created MNG-8644: -- Summary: DefaultProject should check for non null values earlier Key: MNG-8644 URL: https://issues.apache.org/jira/browse/MNG-8644 Project: Maven Issue Type: Bug Reporter: Elliotte Rusty Harold That is, in constructor rather than in getter -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.15.5 to 1.17.3 [maven-plugin-tools]
dependabot[bot] closed pull request #387: Bump net.bytebuddy:byte-buddy from 1.15.5 to 1.17.3 URL: https://github.com/apache/maven-plugin-tools/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump net.bytebuddy:byte-buddy from 1.15.5 to 1.17.4 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #391: URL: https://github.com/apache/maven-plugin-tools/pull/391 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.15.5 to 1.17.4. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-buddy's releases. Byte Buddy 1.17.4 Add SafeVarargs plugin. Fix OSGi declaration for byte-buddy-agent. Byte Buddy 1.17.3 Fix bug in ASM to Class File API bridge handling tableswitch instructions. Add plugin for adding SafeVarargs annotations. Further generify MemberSubstitution API. Byte Buddy 1.17.2 Update Class File API integration to include support for several omitted byte codes. Adjust attach API emulation for OpenJ9 to not create subfolder if temporary folder is set explicitly. Byte Buddy 1.17.1 Fix bug in MemberSubstitution were argument indices were resolved by one digit off. Update Class File API integration to avoid that parameter annotations are lost. Byte Buddy 1.17.0 Assure that implicit choice for class reader and class writer are always symmetric with regard to internal representation. Retrofit MemberSubstitution to also allow for intercepting invokedynamic instructions. Introduce @Handle annotations to allow for injecting constant pool-stored method handle in Advice, MemberSubstitution and MethodDelegation. Introduce @DynamicConstant annotations to allow for injecting constant pool-stored dynamic constants in Advice, MemberSubstitution and MethodDelegation. Byte Buddy 1.16.1 Correct reflective activation of Class File API. Reject array descriptors that are not well-formed in TypePool. Byte Buddy 1.16.0 Allow for erasure of types of bootstrapped methods in Advice within instrumented class. Rework Advice post-processing to allow for erasure of bootstrapped methods. Fix missing application of hashCode/equals plugin for Java 8 code. Include support for JDK Class File API. Allow Plugin.Engine to retain folders. Byte Buddy 1.15.11 Avoid dependency of CachedReturnPlugin on precompiled class files. Add NOP instruction when Advice is used on void methods as those might be empty which results on a frame being written to the same offset, causing an exception. Allow Plugin.Engine to link files instead of copying. Adjust validator code to avoid compiler bug that was reported by multiple users. Allow injection of class path as File[] to Plugin constructors. Allow for configuring variants when using the Android Gradle plugin. Byte Buddy 1.15.10 Fix Java 8 patterns for multi-release jars to avoid that inner classes are excluded. Byte Buddy 1.15.9 Additional release after time out during previous Gradle plugin release. Byte Buddy 1.15.8 Extend ClassInjector API to support lazy resolution of class files. ... (truncated) Changelog Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md";>net.bytebuddy:byte-buddy's changelog. 23. March 2025: version 1.17.4 Add SafeVarargs plugin. Fix OSGi declaration for byte-buddy-agent. 21. March 2025: version 1.17.3 Fix bug in ASM to Class File API bridge handling tableswitch instructions. Add plugin for adding SafeVarargs annotations. Further generify MemberSubstitution API. 3. March 2025: version 1.17.2 Update Class File API integration to include support for several omitted byte codes. Adjust attach API emulation for OpenJ9 to not create subfolder if temporary folder is set explicitly. 14. February 2025: version 1.17.1 Fix bug in MemberSubstitution were argument indices were resolved by one digit off. Update Class File API integration to avoid that parameter annotations are lost. 29. January 2025: version 1.17.0 Assure that implicit choice for class reader and class writer are always symmetric with regard to internal representation. Retrofit MemberSubstitution to also allow for intercepting invokedynamic instructions. Introduce @Handle annotations to allow for injecting constant pool-stored method handle in Advice, MemberSubstitution and MethodDelegation. Introduce @DynamicConstant annotations to allow for injecting constant pool-stored dynamic constants in Advice, MemberSubstitution and MethodDelegation. 19. January 2025: version 1.16.1 Correct reflective activation of Class File API. Reject array descriptors that are not well-formed in TypePool. 17. January 2025: version 1.16.0 Allow for erasure of types of bootstrapped methods in Advice within instrumented class. Rework Advice post-processing to allow for erasure of bootstrapped methods. Fix missing application of hashCode/equals plugin for Java 8 code. Include support for JDK Class File AP
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.15.5 to 1.17.3 [maven-plugin-tools]
dependabot[bot] commented on PR #387: URL: https://github.com/apache/maven-plugin-tools/pull/387#issuecomment-2748410591 Superseded by #391. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add badge for 3.x version [maven-jar-plugin]
Bukama merged PR #129: URL: https://github.com/apache/maven-jar-plugin/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8645) Plugins resolving don't use dependency management for plugin project
Slawomir Jaranowski created MNG-8645:
Summary: Plugins resolving don't use dependency management for
plugin project
Key: MNG-8645
URL: https://issues.apache.org/jira/browse/MNG-8645
Project: Maven
Issue Type: Bug
Affects Versions: 4.0.0-rc-3
Reporter: Slawomir Jaranowski
example in maven-jar-plugin (3.x) we have dependencyManagement for commons-io
https://github.com/apache/maven-jar-plugin/blob/08cea8ed3caf1c7f6575b8392d4fc1396f24a09c/pom.xml#L82
Maven 3.9.x and rc-2 resolve as:
{code}
[DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
[DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
[DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:4.0.1 [compile]
[DEBUG] | \- commons-io:commons-io:jar:2.16.1 [compile]
[DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
[DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
[DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
[DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
[DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
[DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
[DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
[DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
[DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
[DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
[DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
[DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
{code}
but for rc-3 we have:
{code}
[DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
[DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
[DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:3.4.2 [compile]
[DEBUG] | \- commons-io:commons-io:jar:2.11.0 [compile]
[DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
[DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
[DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
[DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
[DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
[DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
[DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
[DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
[DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
[DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
[DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
[DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
{code}
{{commons-io}} and {{plexus-utils}} have defined versions in dependency
management but it is not taken into account.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] requireNonNull [maven]
elharo merged PR #2181: URL: https://github.com/apache/maven/pull/2181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
desruisseaux commented on code in PR #2180:
URL: https://github.com/apache/maven/pull/2180#discussion_r2011009165
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java:
##
@@ -65,24 +65,26 @@ public final class DefaultSourceRoot implements SourceRoot {
* @param source a source element from the model
*/
public DefaultSourceRoot(final Session session, final Path baseDir, final
Source source) {
-String value = nonBlank(source.getDirectory());
-if (value == null) {
-throw new IllegalArgumentException("Source declaration without
directory value.");
-}
-directory = baseDir.resolve(value);
-FileSystem fs = directory.getFileSystem();
+FileSystem fs = baseDir.getFileSystem();
includes = matchers(fs, source.getIncludes());
excludes = matchers(fs, source.getExcludes());
stringFiltering = source.isStringFiltering();
enabled = source.isEnabled();
moduleName = nonBlank(source.getModule());
-value = nonBlank(source.getScope());
+String value = nonBlank(source.getScope());
scope = (value != null) ? session.requireProjectScope(value) :
ProjectScope.MAIN;
value = nonBlank(source.getLang());
Review Comment:
This is often true. But in this particular case, I have some difficulties to
find a nice alternative. Multiplying the number of variables also increases the
risk that we use the wrong ones. In the current code, the `value` variable is
used each time for initializing a final field, then immediately assigned the
next value, with each block separated by a blank line. There is no much room
for confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.apache.commons:commons-vfs2 from 2.9.0 to 2.10.0 in /src/it/projects/MSHADE-467_parallel-dependency-reduced-pom [maven-shade-plugin]
dependabot[bot] opened a new pull request, #252: URL: https://github.com/apache/maven-shade-plugin/pull/252 Bumps org.apache.commons:commons-vfs2 from 2.9.0 to 2.10.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-shade-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Skip generating of xml reader and writer for FileSet [maven-file-management]
slawekjaranowski opened a new pull request, #46: URL: https://github.com/apache/maven-file-management/pull/46 xml reader and writer should not be used we only have documented how to use FileSet in java code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 43 to 44 [maven-file-management]
slawekjaranowski merged PR #45: URL: https://github.com/apache/maven-file-management/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve release-drafter configuration [maven-jar-plugin]
slawekjaranowski commented on PR #128: URL: https://github.com/apache/maven-jar-plugin/pull/128#issuecomment-2749172083 fix for build is in: #130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
desruisseaux commented on code in PR #2180:
URL: https://github.com/apache/maven/pull/2180#discussion_r2010804269
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -26,13 +26,23 @@
/**
* A root directory of source files.
* The sources may be Java main classes, test classes, resources or anything
else identified by the scope.
+ *
+ * Default values
+ * The default implementation of all methods in this interface match the
default values
+ * documented in {@code maven.mdo} (the POM model).
Review Comment:
I will put a link to
https://maven.apache.org/ref/current/maven-model/maven.html on the assumption
that `current` will redirect to version 4.1 some day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Remove old symbolic link in ITmng8400 test [maven]
slawekjaranowski merged PR #2178: URL: https://github.com/apache/maven/pull/2178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8645) Plugins resolving don't use dependency management for plugin project
[
https://issues.apache.org/jira/browse/MNG-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938048#comment-17938048
]
Guillaume Nodet commented on MNG-8645:
--
Could you double check, I haven't been able to reproduce the problem on that
branch of m-jar-p:
{code}
➜ maven-jar-plugin git:(08cea8e) ~/.sdkman/candidates/maven/3.9.9/bin/mvn
dependency:tree -V | grep -E "Maven|commons-io"
Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: /Users/gnodet/.sdkman/candidates/maven/3.9.9
[INFO] Building Apache Maven JAR Plugin 3.4.3-SNAPSHOT
[INFO] | \- commons-io:commons-io:jar:2.16.1:compile
➜ maven-jar-plugin git:(08cea8e) ~/.sdkman/candidates/maven/4.0.0-rc-2/bin/mvn
dependency:tree -V | grep -E "Maven|commons-io"
Apache Maven 4.0.0-rc-2 (273314404f85ec3c089e295d8b4e0cb18c287cf5)
Maven home: /Users/gnodet/.sdkman/candidates/maven/4.0.0-rc-2
[INFO] Building Apache Maven JAR Plugin 3.4.3-SNAPSHOT
[INFO] | \- commons-io:commons-io:jar:2.16.1:compile
➜ maven-jar-plugin git:(08cea8e) ~/.sdkman/candidates/maven/4.0.0-rc-3/bin/mvn
dependency:tree -V | grep -E "Maven|commons-io"
Apache Maven 4.0.0-rc-3 (3952d00ce65df6753b63a51e86b1f626c55a8df2)
Maven home: /Users/gnodet/.sdkman/candidates/maven/4.0.0-rc-3
[INFO] Building Apache Maven JAR Plugin 3.4.3-SNAPSHOT
[INFO] | \- commons-io:commons-io:jar:2.16.1:compile
{code}
> Plugins resolving don't use dependency management for plugin project
>
>
> Key: MNG-8645
> URL: https://issues.apache.org/jira/browse/MNG-8645
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-rc-3
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> example in maven-jar-plugin (3.x) we have dependencyManagement for commons-io
> https://github.com/apache/maven-jar-plugin/blob/08cea8ed3caf1c7f6575b8392d4fc1396f24a09c/pom.xml#L82
> Maven 3.9.x and rc-2 resolve as:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:4.0.1 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.16.1 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> but for rc-3 we have:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:3.4.2 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.11.0 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> {{commons-io}} and {{plexus-utils}} have defined versions in dependency
> management but it is not taken into account.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.4 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #393: URL: https://github.com/apache/maven-plugin-tools/pull/393 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.17.2 to 1.17.4. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-buddy's releases. Byte Buddy 1.17.4 Add SafeVarargs plugin. Fix OSGi declaration for byte-buddy-agent. Byte Buddy 1.17.3 Fix bug in ASM to Class File API bridge handling tableswitch instructions. Add plugin for adding SafeVarargs annotations. Further generify MemberSubstitution API. Changelog Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md";>net.bytebuddy:byte-buddy's changelog. 23. March 2025: version 1.17.4 Add SafeVarargs plugin. Fix OSGi declaration for byte-buddy-agent. 21. March 2025: version 1.17.3 Fix bug in ASM to Class File API bridge handling tableswitch instructions. Add plugin for adding SafeVarargs annotations. Further generify MemberSubstitution API. Commits https://github.com/raphw/byte-buddy/commit/2cc263eeba8924ca1f49889f70967355b85761f0";>2cc263e [maven-release-plugin] prepare release byte-buddy-1.17.4 https://github.com/raphw/byte-buddy/commit/210216337067e6481f2f40d5986bbd8360cff810";>2102163 [release] Release new version https://github.com/raphw/byte-buddy/commit/0cf03f7051d030a075742d6d2edd383bc214e21f";>0cf03f7 Add JNA to imports. https://github.com/raphw/byte-buddy/commit/2240cbd0c60984d65f1f2da6de1cac881478ad99";>2240cbd Add checksums https://github.com/raphw/byte-buddy/commit/6b9b27dbd71e273dbc4f0b4429d259a5d2272b3b";>6b9b27d Add checksums. https://github.com/raphw/byte-buddy/commit/61115ac25151015214369a459876718a4e68bb19";>61115ac Update internal Byte Buddy, add release notes and safe varargs plugin. https://github.com/raphw/byte-buddy/commit/7417abbc751110ce97fd05f2a22a5fa8bc16daa6";>7417abb [maven-release-plugin] prepare for next development iteration https://github.com/raphw/byte-buddy/commit/baec297640c2b3762188c587cb3830b0e8a1448b";>baec297 [maven-release-plugin] prepare release byte-buddy-1.17.3 https://github.com/raphw/byte-buddy/commit/6ee1a9ef11b5eed95111412fd146bddca0480f7b";>6ee1a9e [release] Release new version https://github.com/raphw/byte-buddy/commit/eee02d92b3a3bdc1505ee8ac63748e6ed7965400";>eee02d9 Fix build. Additional commits viewable in https://github.com/raphw/byte-buddy/compare/byte-buddy-1.17.2...byte-buddy-1.17.4";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
elharo commented on code in PR #2180:
URL: https://github.com/apache/maven/pull/2180#discussion_r2010548117
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -26,13 +26,23 @@
/**
* A root directory of source files.
* The sources may be Java main classes, test classes, resources or anything
else identified by the scope.
+ *
+ * Default values
+ * The default implementation of all methods in this interface match the
default values
+ * documented in {@code maven.mdo} (the POM model).
Review Comment:
Can we link to something easier to read than the XSD?
Consider deleting "The default implementations of the methods provided in
this interface are consistent with that specification." as that's implied by
the previous sentence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
desruisseaux commented on code in PR #2180:
URL: https://github.com/apache/maven/pull/2180#discussion_r2010550105
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -26,13 +26,23 @@
/**
* A root directory of source files.
* The sources may be Java main classes, test classes, resources or anything
else identified by the scope.
+ *
+ * Default values
+ * The default implementation of all methods in this interface match the
default values
+ * documented in {@code maven.mdo} (the POM model).
*/
public interface SourceRoot {
/**
* {@return the root directory where the sources are stored}.
* The path is relative to the POM file.
+ *
+ * Default implementation
+ * The default value is src/{@linkplain #scope() scope}/{@linkplain
#language() language}
Review Comment:
Currently, this is called "scope" with two recognized values: `main` or
`test`. I agree that there is a risk of confusion with dependency scopes.
However, the "scope" term is already used in different contexts. Maven core
currently has:
* `ProjectScope` with `main` and `test` (the scopes in question above).
* `DependencyScope` with `compile`, `runtime`, `provided`, `test`, etc.
* `PathScope` with `main-compile`, `main-runtime`, `test-compile` and
`test-runtime`.
* `Scope` for lifecycle and visibility of objects in the dependency
injection system.
* `SessionScope` (internal)
* `MojoExecutionScope` (internal)
I agree that users would see only dependency scopes and project scopes. We
could rename the latter. However, we could also said that a scope is like
`name` or a `id` properties: they are used for different kinds of objects, and
their meaning depend on the object where they appear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump parent to 44 [maven-surefire]
slawekjaranowski merged PR #817: URL: https://github.com/apache/maven-surefire/pull/817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
desruisseaux opened a new pull request, #2180:
URL: https://github.com/apache/maven/pull/2180
The `maven.mdo` file for the `` element said that the default
directories are `src/${scope}/${lang}`. but this is effective only if no source
is specified at all. It would be helpful to have this default value when some
`` are specified. The intend is to allow users to write:
```xml
21
test
```
instead of:
```xml
src/main/java
21
test
src/test/java
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8617) sonar-maven-plugin fails with Maven 4.0.0-rc3 with UnsupportedOperationException
[
https://issues.apache.org/jira/browse/MNG-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937942#comment-17937942
]
Filipe Roque commented on MNG-8617:
---
[https://sonarsource.atlassian.net/browse/SCANMAVEN-283]
> sonar-maven-plugin fails with Maven 4.0.0-rc3 with
> UnsupportedOperationException
>
>
> Key: MNG-8617
> URL: https://issues.apache.org/jira/browse/MNG-8617
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-rc-3
>Reporter: Filipe Roque
>Priority: Major
>
> {code:java}
> ❯ docker run -d \
> --name sonarqube \
> -e SONAR_ES_BOOTSTRAP_CHECKS_DISABLE=true \
> -p 9000:9000 \
> sonarqube:lts-community
> {code}
> {code:java}
> ❯ cat pom.xml
>
> 4.0.0
> com.mycompany.app
> my-app
> 1
>
> {code}
> {code:java}
> ❯ /opt/maven/apache-maven-4.0.0-rc-2/bin/mvn -q \
> org.sonarsource.scanner.maven:sonar-maven-plugin:5.0.0.4389:sonar \
> -Dsonar.login=admin \
> -Dsonar.password=admin \
> -Dsonar.host.url=http://localhost:9000/
> {code}
> {code:java}
> ❯ /opt/maven/apache-maven-4.0.0-rc-3/bin/mvn -q \
> org.sonarsource.scanner.maven:sonar-maven-plugin:5.0.0.4389:sonar \
> -Dsonar.login=admin \
> -Dsonar.password=admin \
> -Dsonar.host.url=http://localhost:9000/
> [ERROR] Failed to execute goal
> org.sonarsource.scanner.maven:sonar-maven-plugin:5.0.0.4389:sonar
> (default-cli) on project my-app: null: MojoExecutionException:
> UnsupportedOperationException -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the '-e'
> switch
> [ERROR] Re-run Maven using the '-X' switch to enable verbose output
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.0.0 [maven-plugin-tools]
slawekjaranowski commented on PR #336: URL: https://github.com/apache/maven-plugin-tools/pull/336#issuecomment-2748477641 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] requireNonNull [maven]
elharo opened a new pull request, #2181: URL: https://github.com/apache/maven/pull/2181 Let's see if this breaks anything -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]
slawekjaranowski merged PR #2171: URL: https://github.com/apache/maven/pull/2171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
elharo commented on code in PR #2180:
URL: https://github.com/apache/maven/pull/2180#discussion_r2010479726
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -26,13 +26,23 @@
/**
* A root directory of source files.
* The sources may be Java main classes, test classes, resources or anything
else identified by the scope.
+ *
+ * Default values
+ * The default implementation of all methods in this interface match the
default values
+ * documented in {@code maven.mdo} (the POM model).
*/
public interface SourceRoot {
/**
* {@return the root directory where the sources are stored}.
* The path is relative to the POM file.
+ *
+ * Default implementation
+ * The default value is src/{@linkplain #scope() scope}/{@linkplain
#language() language}
Review Comment:
main is not a scope. Is that OK?
##
api/maven-api-model/src/main/mdo/maven.mdo:
##
@@ -875,7 +875,7 @@
All the sources to compile and resources files to copy for a
project or it's unit tests.
The sources can be Java source files, generated source files,
scripts or resources for examples.
-Each source is specified by a mandatory {@code directory} element,
which is relative to the POM.
+Each source is specified by a {@code directory} element, which is
relative to the POM.
The kind of sources (codes to compile or resources to copy) and
their usage (for the main code
Review Comment:
codes --> code or perhaps source files
##
api/maven-api-model/src/main/mdo/maven.mdo:
##
@@ -2005,7 +2005,7 @@
[jira] [Commented] (MNG-8248) WARNING: A restricted method in java.lang.System has been called
[
https://issues.apache.org/jira/browse/MNG-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937946#comment-17937946
]
Slawomir Jaranowski commented on MNG-8248:
--
[~norrisjeremy] fixed in 3.x branch.
> WARNING: A restricted method in java.lang.System has been called
>
>
> Key: MNG-8248
> URL: https://issues.apache.org/jira/browse/MNG-8248
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.1, 3.8.2, 3.8.3, 3.8.4, 3.8.5, 3.8.6, 3.8.7, 3.8.8,
> 3.9.0, 3.9.1, 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6, 3.9.7, 3.9.8, 3.9.9,
> 4.0.0-beta-3, 4.0.0-beta-4
>Reporter: Karl Heinz Marbaise
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.9.10
>
>
> Building a project with JDK 24.ea.13 produces the following WARNING:
> {code}
> $> mvn clean verify
> WARNING: A restricted method in java.lang.System has been called
> WARNING: java.lang.System::load has been called by
> org.jline.nativ.JLineNativeLoader in an unnamed module
> (file:/Users/khm/tools/maven/lib/jline-3.26.3.jar)
> WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for
> callers in this module
> WARNING: Restricted methods will be blocked in a future release unless native
> access is enabled
> {code}
> also a simple:
> {code}
> mvn --version
> {code}
> wil trigger:
> {code}
> $> mvn --version
> WARNING: A restricted method in java.lang.System has been called
> WARNING: java.lang.System::load has been called by
> org.fusesource.jansi.internal.JansiLoader in an unnamed module
> (file:/Users/khm/tools/maven/lib/jansi-2.4.1.jar)
> WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for
> callers in this module
> WARNING: Restricted methods will be blocked in a future release unless native
> access is enabled
> Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
> Maven home: /Users/khm/tools/maven
> Java version: 24-ea, vendor: Oracle Corporation, runtime:
> /Users/khm/.sdkman/candidates/java/24.ea.13-open
> Default locale: en_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
> {code}
> Also opened an issue on JLine3 Project:
> https://github.com/jline/jline3/issues/1067
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Use Maven 3.9.9 for build maven-3.9.x branch [maven]
slawekjaranowski merged PR #2177: URL: https://github.com/apache/maven/pull/2177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.mockito:mockito-core from 3.12.4 to 4.0.0 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #394:
URL: https://github.com/apache/maven-plugin-tools/pull/394
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from
3.12.4 to 4.0.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-core's
releases.
v4.0.0
Mockito 4: Removing deprecated APIs.
All of these APIs have been marked as deprecated and have been present
in Mockito for quite a while.
An overview of now-deleted classes/methods:
org.mockito.Matchers which was an alias for
org.mockito.ArgumentMatchers
org.mockito.ArgumentMatchers#{anyObject,anyVararg} both
which were
aliases for org.mockito.ArgumentMatchers#any
org.mockito.ArgumentMatchers#any*Of, which were aliases for
the same
method name without the Of and the generic parameters (which were
ignored)
org.mockito.ArgumentMatchers#{is}{Not}Null(Class) which
took a class
which was ignored. Aliases for the same methods without the parameter
org.mockito.MockedStatic#verify which had the parameter
types reversed
org.mockito.Mockito#verifyZeroInteractions an alias of
verifyNoMoreInteractions
org.mockito.Mockito#debug framework integration API that we
later
refactored
org.mockito.configuration.AnnotationEngine which was
leaking internal
APIs and instead users should use
org.mockito.plugins.AnnotationEngine
org.mockito.exceptions.verification.TooLittleActualInvocations
fixed
the grammar from "Little" to "Few"
Numerous internal APIs that we never officially supported and can now
remove
org.mockito.plugins.InstantiatorProvider which was leaking
internal
APIs and instead users should use InstantiatorProvider2 (we should
probably rename back to remove the number in a future major release)
org.mockito.runners a package that hosted several old JUnit
runners
which were no longer supported. Users should instead use
org.mockito.junit.MockitoJUnitRunner which is our official
JUnit4
runner.
Commits
https://github.com/mockito/mockito/commit/e8f26b3785a8434861e505727c580de730627540";>e8f26b3
Fixes https://redirect.github.com/mockito/mockito/issues/2281";>#2281: Make
MockedConstruction stubs close on demand (https://redirect.github.com/mockito/mockito/issues/2442";>#2442)
https://github.com/mockito/mockito/commit/bf480c3ec4c433f4f7b93233eef4ee3d4601ec97";>bf480c3
Bump versions.bytebuddy from 1.11.18 to 1.11.19 (https://redirect.github.com/mockito/mockito/issues/2441";>#2441)
https://github.com/mockito/mockito/commit/d4180a27156b59bdd4436878b1b93a18b29a7023";>d4180a2
Update BND plugin to 6.0.0 (https://redirect.github.com/mockito/mockito/issues/2440";>#2440)
https://github.com/mockito/mockito/commit/7032574ce1fb65e5dbdcf24f65f87766d7124db3";>7032574
Remove all Incubating annotations (https://redirect.github.com/mockito/mockito/issues/2437";>#2437)
https://github.com/mockito/mockito/commit/c8dbc10d2060d1b800cc4d0d558736439db57929";>c8dbc10
Fix spelling in old release notes (https://redirect.github.com/mockito/mockito/issues/2439";>#2439)
https://github.com/mockito/mockito/commit/40d6f6840e8935c3fdc5b085a21d0e70561820e7";>40d6f68
Add test for enum mocking using inline mock maker.
https://github.com/mockito/mockito/commit/6a50cc458b6fbc575009653d0f036367b28029b0";>6a50cc4
Run CI on Java 17 (https://redirect.github.com/mockito/mockito/issues/2417";>#2417)
https://github.com/mockito/mockito/commit/99f8a62536aa822e5ab6fe76704a9707f6f8904c";>99f8a62
Add monospace font fallback for JavaDoc (https://redirect.github.com/mockito/mockito/issues/2434";>#2434)
https://github.com/mockito/mockito/commit/651feb30076ef4764158ed956ae80993cf75ec97";>651feb3
Bump versions.junitJupiter from 5.8.0 to 5.8.1 (https://redirect.github.com/mockito/mockito/issues/2430";>#2430)
https://github.com/mockito/mockito/commit/6db7a02587556d18792e3ee7cee159844396f6d6";>6db7a02
Bump junit-platform-launcher from 1.8.0 to 1.8.1 (https://redirect.github.com/mockito/mockito/issues/2432";>#2432)
Additional commits viewable in https://github.com/mockito/mockito/compare/v3.12.4...v4.0.0";>compare
view
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
| org.mockito:mockito-core | [>= 4.a, < 5] |
| org.mockito:mockito-core | [>= 5.a, < 6] |
| org.mockito:mockito-core | [>= 5.a0, < 6] |
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase
Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.0.0 [maven-plugin-tools]
slawekjaranowski commented on PR #336: URL: https://github.com/apache/maven-plugin-tools/pull/336#issuecomment-2748480813 @dependabot reopen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.0.0 [maven-plugin-tools]
dependabot[bot] commented on PR #336: URL: https://github.com/apache/maven-plugin-tools/pull/336#issuecomment-2748477875 Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use `@dependabot reopen` if the branch has been deleted). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.mockito:mockito-core from 3.12.4 to 5.0.0 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #336: URL: https://github.com/apache/maven-plugin-tools/pull/336 Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 3.12.4 to 5.0.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-core's releases. v5.0.0 Mockito 5: prepare for future JDK versions For a while now, we have seen an increase in problems/incompatibilities with recent versions of the JDK due to our usage of JVM-internal API. Most notably, JDK 17 made some changes which are incompatible with the current subclass mockmaker. Therefore, to prepare for the future of JDK, we are making some core changes to ensure Mockito keeps on working. Switch the default mockmaker to mockito-inline Back in Mockito 2.7.6, we published a new mockmaker based on the "inline bytecode" principle. This mockmaker creates mocks manipulating bytecode equivalent within the original class such that its method implementations hook into the normal Mockito machinery. As a comparison, the subclass mockmaker generates "real" subclasses for mocks, to mimic the same behavior. While the approaches are similar, the inline mockmaker avoids certain restrictions that the JDK imposes. For example, it does not violate module boundaries (introduced in JDK 9, but more heavily used in JDK 17) and avoids the leaking of the creation of the subclass. Massive thanks to community member https://github.com/reta";>@reta who implemented this change. Note: this does not affect mockito-android nor testing on Android. When should I still be using the subclass mockmaker? There are legitimate remaining use cases for the subclass mockmaker. For example, on the Graal VM's native image, the inline mockmaker will not work and the subclass mockmaker is the appropriate choice. Additionally, if you would like to avoid mocking final classes, using the subclass mockmaker is a possibibility. Note however that if you solely want to use the subclass mockmaker to avoid mocking final, you will run into the above mentioned issues on JDK 17+. We want to leave this choice up to our users, which is why we will keep on supporting the subclass mockmaker. If you want to use the subclass mockmaker instead, you can use the new mockito-subclass artifact (published https://search.maven.org/artifact/org.mockito/mockito-subclass";>on Maven Central along with all our other artifacts). Update the minimum supported Java version to 11 Mockito 4 supports Java 8 and above. Similar to other open source projects, we are moving away from JDK 8 and to newer versions. The primary reason for moving away from JDK 8 is the increasing maintenance costs with keeping our own infrastructure working. Lately we have been running into more and more JDK 8 breakages. Additionally, while we want to support the newest JDK API's, our current solution to support both JDK 8 and newer versions causes https://redirect.github.com/mockito/mockito/issues/2798";>issues with the SecurityManager. Since we want Mockito to work on the newest version and more and more businesses adopting JDK 11, we have decided to make the switch as well. Massive thanks to community member https://github.com/reta";>@reta who implemented this change. What should I do if I still run JDK 8? For JDK 8 and below, you can keep on using Mockito 4. This is similar to if you are using JDK 6, for which you can keep on using Mockito 2. The changes in Mockito 5 (for now) are primarily focused on the latest JDK versions, which means the API differences between Mockito 4 and 5 are minimal. However, over time this will most likely widen, so we do recommend adopting JDK 11 in the future. New type() method on ArgumentMatcher One of our most used public API's for customizing Mockito is the https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/ArgumentMatcher.html";>ArgumentMatcher interface. ... (truncated) Commits https://github.com/mockito/mockito/commit/adf528d173f8b763fcd4fedab245ed485b465211";>adf528d Bump versions.bytebuddy from 1.12.21 to 1.12.22 (https://redirect.github.com/mockito/mockito/issues/2864";>#2864) https://github.com/mockito/mockito/commit/2418419a1915bd234332eac2b4d5de85622d4699";>2418419 Bump versions.junitJupiter from 5.9.1 to 5.9.2 (https://redirect.github.com/mockito/mockito/issues/2858";>#2858) https://github.com/mockito/mockito/commit/3d40cd51d3982e33f7c2a2670c65d28233ceb66e";>3d40cd5 Bump junit-platform-launcher from 1.9.1 to 1.9.2 (https://redirect.github.com/mockito/mockito/issues/2859";>#2859) https://github.com/mockito/mockito/commit/9bec8e3a1a0f57e4baa9b64825d67641e9eb2d5e";>9bec8e3 Bump versions.errorprone from 2.17.0 to 2.18.0 (https://redirect.github.com/mockito/mockito/issues/2857";>#2857) https://github.com/mockito/mockito/commit/a9595f559cf4acdae
Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.0.0 [maven-plugin-tools]
dependabot[bot] commented on PR #336: URL: https://github.com/apache/maven-plugin-tools/pull/336#issuecomment-2748481707 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.0.0 [maven-plugin-tools]
slawekjaranowski closed pull request #336: Bump org.mockito:mockito-core from 3.12.4 to 5.0.0 URL: https://github.com/apache/maven-plugin-tools/pull/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
desruisseaux commented on code in PR #2180: URL: https://github.com/apache/maven/pull/2180#discussion_r2010564486 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -2005,7 +2005,7 @@
Re: [PR] requireNonNull [maven]
gnodet commented on PR #2181: URL: https://github.com/apache/maven/pull/2181#issuecomment-2748817783 Why not using a static import ? `requireNonNull` is quite unambiguous... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8511] Explains the meaning of cling [maven]
gnodet merged PR #2174: URL: https://github.com/apache/maven/pull/2174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8639] Check namespaces when reading XML models [maven]
gnodet merged PR #2170: URL: https://github.com/apache/maven/pull/2170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8612] Document Node#asString and remove Version#asString and VersionConstraint#asString [maven]
gnodet merged PR #2172: URL: https://github.com/apache/maven/pull/2172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8510] Avoid duplicate Utils classes [maven]
gnodet merged PR #2173: URL: https://github.com/apache/maven/pull/2173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8510) Rename or combine Utils classes
[ https://issues.apache.org/jira/browse/MNG-8510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8510. Resolution: Fixed > Rename or combine Utils classes > --- > > Key: MNG-8510 > URL: https://issues.apache.org/jira/browse/MNG-8510 > Project: Maven > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Guillaume Nodet >Priority: Minor > Fix For: 4.0.0-rc-4 > > Attachments: image-2025-01-11-12-31-54-146.png > > > If for no other reason than to avoid confusion and conflicts in tools and > imports: > !image-2025-01-11-12-31-54-146.png! > Easier to do before a release than after -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.3 [maven-plugin-tools]
dependabot[bot] commented on PR #388: URL: https://github.com/apache/maven-plugin-tools/pull/388#issuecomment-2748462758 Superseded by #393. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.3 [maven-plugin-tools]
dependabot[bot] closed pull request #388: Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.3 URL: https://github.com/apache/maven-plugin-tools/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump slf4jVersion from 1.7.36 to 2.0.0 [maven-plugin-tools]
slawekjaranowski commented on PR #326: URL: https://github.com/apache/maven-plugin-tools/pull/326#issuecomment-2748466339 @gnodet you are right - revert PR created -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] requireNonNull [maven]
elharo commented on PR #2181: URL: https://github.com/apache/maven/pull/2181#issuecomment-2748851086 Only because the IntelliJ inline refactoring didn't use a static import. If the tests pass I can do that and a couple of other things to clean this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
desruisseaux commented on code in PR #2180:
URL: https://github.com/apache/maven/pull/2180#discussion_r2010602493
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -26,13 +26,23 @@
/**
* A root directory of source files.
* The sources may be Java main classes, test classes, resources or anything
else identified by the scope.
+ *
+ * Default values
+ * The default implementation of all methods in this interface match the
default values
+ * documented in {@code maven.mdo} (the POM model).
Review Comment:
Do we have something equivalent to the [descriptor reference
documentation](https://maven.apache.org/ref/current/maven-model/maven.html)
online for Maven 4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Minor doc fixes [maven-changes-plugin]
elharo merged PR #112: URL: https://github.com/apache/maven-changes-plugin/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8639) Check namespaces when reading XML models
[ https://issues.apache.org/jira/browse/MNG-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8639. Resolution: Fixed > Check namespaces when reading XML models > > > Key: MNG-8639 > URL: https://issues.apache.org/jira/browse/MNG-8639 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2170 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8511) Explains the meaning of cling
[ https://issues.apache.org/jira/browse/MNG-8511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8511. Resolution: Fixed > Explains the meaning of cling > - > > Key: MNG-8511 > URL: https://issues.apache.org/jira/browse/MNG-8511 > Project: Maven > Issue Type: Improvement > Components: Command Line >Reporter: Elliotte Rusty Harold >Assignee: Guillaume Nodet >Priority: Blocker > Fix For: 4.0.0-rc-4 > > > Personally I found this package name confusing. I read it as the English word > "cling" or possibly a misremembered name of a popular C compiler (which is > actually Clang when I googled it.) And if I was confused by this, others are > likely to be too. > If there's already a org.apache.maven.cli package somewhere, maybe > org.apache.maven.commandline? > Like all new API changes, it's now or never. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8645) Plugins resolving doesn't use dependency management for plugin project
[
https://issues.apache.org/jira/browse/MNG-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MNG-8645:
-
Summary: Plugins resolving doesn't use dependency management for plugin
project (was: Plugins resolving don't use dependency management for plugin
project)
> Plugins resolving doesn't use dependency management for plugin project
> --
>
> Key: MNG-8645
> URL: https://issues.apache.org/jira/browse/MNG-8645
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-rc-3
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> example in maven-jar-plugin (3.x) we have dependencyManagement for commons-io
> https://github.com/apache/maven-jar-plugin/blob/08cea8ed3caf1c7f6575b8392d4fc1396f24a09c/pom.xml#L82
> Maven 3.9.x and rc-2 resolve as:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:4.0.1 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.16.1 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> but for rc-3 we have:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:3.4.2 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.11.0 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> {{commons-io}} and {{plexus-utils}} have defined versions in dependency
> management but it is not taken into account.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Fix for Maven 4.0.0-rc-3 [maven-jar-plugin]
slawekjaranowski merged PR #130: URL: https://github.com/apache/maven-jar-plugin/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Github issues EAR-plugin [maven-site]
Bukama merged PR #744: URL: https://github.com/apache/maven-site/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Github issues JAR-plugin [maven-site]
Bukama merged PR #746: URL: https://github.com/apache/maven-site/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Github issues WAR-plugin [maven-site]
Bukama merged PR #745: URL: https://github.com/apache/maven-site/pull/745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add PR-automation and stale action [maven-jar-plugin]
Bukama merged PR #131: URL: https://github.com/apache/maven-jar-plugin/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Mention GitHub issues in Getting Help page [maven-site]
Bukama merged PR #743: URL: https://github.com/apache/maven-site/pull/743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] move this dependency to dptMngt [maven-surefire]
slawekjaranowski commented on PR #818: URL: https://github.com/apache/maven-surefire/pull/818#issuecomment-2750263367 To be consequently we should remove `version` from all other place, like: https://github.com/apache/maven-surefire/blob/05bb867b9fdfd52d0eaa7ac14dc40c2a80fbc717/maven-failsafe-plugin/pom.xml#L68-L72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] move this dependency to dptMngt [maven-surefire]
olamy commented on PR #818: URL: https://github.com/apache/maven-surefire/pull/818#issuecomment-2750277837 > To be consequently we should remove `version` from all other place, like: > > https://github.com/apache/maven-surefire/blob/05bb867b9fdfd52d0eaa7ac14dc40c2a80fbc717/maven-failsafe-plugin/pom.xml#L68-L72 good catch. I did forget few others fixed with https://github.com/apache/maven-surefire/pull/818/commits/69cb34a0874191edf74c534120fe4cbf0e166871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8645) Plugins resolving don't use dependency management for plugin project
[
https://issues.apache.org/jira/browse/MNG-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938112#comment-17938112
]
Guillaume Nodet commented on MNG-8645:
--
Ah, I see now. The problem is in the consumer POM. I'll have a look.
> Plugins resolving don't use dependency management for plugin project
>
>
> Key: MNG-8645
> URL: https://issues.apache.org/jira/browse/MNG-8645
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-rc-3
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> example in maven-jar-plugin (3.x) we have dependencyManagement for commons-io
> https://github.com/apache/maven-jar-plugin/blob/08cea8ed3caf1c7f6575b8392d4fc1396f24a09c/pom.xml#L82
> Maven 3.9.x and rc-2 resolve as:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:4.0.1 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.16.1 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> but for rc-3 we have:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:3.4.2 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.11.0 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> {{commons-io}} and {{plexus-utils}} have defined versions in dependency
> management but it is not taken into account.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Add release drafter, PR-automation and stale action [maven-war-plugin]
Bukama commented on PR #85: URL: https://github.com/apache/maven-war-plugin/pull/85#issuecomment-2750091285 Updated, please have another look. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve release-drafter configuration [maven-jar-plugin]
slawekjaranowski merged PR #127: URL: https://github.com/apache/maven-jar-plugin/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] move this dependency to dptMngt [maven-surefire]
olamy opened a new pull request, #818: URL: https://github.com/apache/maven-surefire/pull/818 Signed-off-by: Olivier Lamy Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8537) Maven 4 namespace should not change
[ https://issues.apache.org/jira/browse/MNG-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938050#comment-17938050 ] Guillaume Nodet commented on MNG-8537: -- In order to stop the bleeding, we need to: * make sure Maven 4 enforces the use of a namespace (that has been implemented with MNG-8639) * enforce that POMs uploaded to Maven Central are valid. This is actually more than just the fact that they adhere to the schema, we should do proper validation with our own ModelValidator. And ask Sonatype to include our checks while vetting uploaded bundles. I fully support those, but that's somewhat unrelated to any namespace change or not change. > Maven 4 namespace should not change > --- > > Key: MNG-8537 > URL: https://issues.apache.org/jira/browse/MNG-8537 > Project: Maven > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Blocker > > Just noticed that Maven 4 has a new namespace URL. The old namespace was > > [http://maven.apache.org/POM/4.0.0] > > The new one is > > [http://maven.apache.org/POM/4.1.0] > > Putting version numbers in namespaces is a known XML antipattern because it > makes it extremely difficult and inconvenient to write tools that process > both, even when they are much the same. XSLT, DOM, XQuery, JDOM, etc. — > really any XML aware tool — is going to have problems with this. > Model version 4.1.0 is not a new and different schema that completely breaks > with the past. Most old elements from 4.0.0 are still present and still mean > exactly the same thing: groupId, artifactId, name, dependency, and most > others. There are new elements but that doesn't imply a new namespace. Adding > a new namespace is asserting that all the elements are different. > IMHO Maven 4 should not change the namespace URL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8644) DefaultProject should check for non null values earlier
[ https://issues.apache.org/jira/browse/MNG-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938049#comment-17938049 ] Guillaume Nodet commented on MNG-8644: -- Note that in Maven 3.x, a MavenProject can be loaded from any pom in the repository. This is imho not a good idea, and Maven 4.x API uses Project for the project you will actually build (as explained in the Project's javadoc), and just Model in other cases. So there's a small difference between both, and that may be the reason why the check is done in the getters. > DefaultProject should check for non null values earlier > --- > > Key: MNG-8644 > URL: https://issues.apache.org/jira/browse/MNG-8644 > Project: Maven > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Priority: Minor > > That is, in constructor rather than in getter -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8617) sonar-maven-plugin fails with Maven 4.0.0-rc3 with UnsupportedOperationException
[
https://issues.apache.org/jira/browse/MNG-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8617.
Resolution: Won't Fix
> sonar-maven-plugin fails with Maven 4.0.0-rc3 with
> UnsupportedOperationException
>
>
> Key: MNG-8617
> URL: https://issues.apache.org/jira/browse/MNG-8617
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-rc-3
>Reporter: Filipe Roque
>Priority: Major
>
> {code:java}
> ❯ docker run -d \
> --name sonarqube \
> -e SONAR_ES_BOOTSTRAP_CHECKS_DISABLE=true \
> -p 9000:9000 \
> sonarqube:lts-community
> {code}
> {code:java}
> ❯ cat pom.xml
>
> 4.0.0
> com.mycompany.app
> my-app
> 1
>
> {code}
> {code:java}
> ❯ /opt/maven/apache-maven-4.0.0-rc-2/bin/mvn -q \
> org.sonarsource.scanner.maven:sonar-maven-plugin:5.0.0.4389:sonar \
> -Dsonar.login=admin \
> -Dsonar.password=admin \
> -Dsonar.host.url=http://localhost:9000/
> {code}
> {code:java}
> ❯ /opt/maven/apache-maven-4.0.0-rc-3/bin/mvn -q \
> org.sonarsource.scanner.maven:sonar-maven-plugin:5.0.0.4389:sonar \
> -Dsonar.login=admin \
> -Dsonar.password=admin \
> -Dsonar.host.url=http://localhost:9000/
> [ERROR] Failed to execute goal
> org.sonarsource.scanner.maven:sonar-maven-plugin:5.0.0.4389:sonar
> (default-cli) on project my-app: null: MojoExecutionException:
> UnsupportedOperationException -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the '-e'
> switch
> [ERROR] Re-run Maven using the '-X' switch to enable verbose output
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.4 [maven-plugin-tools]
slawekjaranowski merged PR #393: URL: https://github.com/apache/maven-plugin-tools/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add release drafter, PR-automation and stale action [maven-war-plugin]
slawekjaranowski commented on code in PR #85: URL: https://github.com/apache/maven-war-plugin/pull/85#discussion_r2010916316 ## .github/release-drafter.yml: ## @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +_extends: maven-gh-actions-shared + +tag-template: maven-war-plugin-$RESOLVED_VERSION Review Comment: from parent 44 we will have tag as `v` do default one will be ok, we can drop this line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add release drafter, PR-automation and stale action [maven-war-plugin]
slawekjaranowski commented on code in PR #85: URL: https://github.com/apache/maven-war-plugin/pull/85#discussion_r2010917780 ## .github/release-drafter.yml: ## @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +_extends: maven-gh-actions-shared + +tag-template: maven-war-plugin-$RESOLVED_VERSION + +include-pre-releases: true +prerelease: true Review Comment: we have only one production branch we don't have a beta and other pre - release version here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add release-drafter, PR-automation and stale action [maven-ear-plugin]
slawekjaranowski commented on code in PR #133: URL: https://github.com/apache/maven-ear-plugin/pull/133#discussion_r2010919690 ## .github/release-drafter.yml: ## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +_extends: maven-gh-actions-shared + +tag-template: maven-ear-plugin-$RESOLVED_VERSION Review Comment: not needed from parent 44 ## .github/workflows/stale.yml: ## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Stale + +on: + schedule: +- cron: '16 4 * * *' Review Comment: can be randomly changed to have different in different projects 😄 ## .github/release-drafter.yml: ## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +_extends: maven-gh-actions-shared + +tag-template: maven-ear-plugin-$RESOLVED_VERSION + +include-pre-releases: true +prerelease: true Review Comment: there is no pre release version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Set the default source directory to `src/${scope}/${lang}` as per documentation [maven]
elharo commented on code in PR #2180:
URL: https://github.com/apache/maven/pull/2180#discussion_r2011014381
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java:
##
@@ -65,24 +65,26 @@ public final class DefaultSourceRoot implements SourceRoot {
* @param source a source element from the model
*/
public DefaultSourceRoot(final Session session, final Path baseDir, final
Source source) {
-String value = nonBlank(source.getDirectory());
-if (value == null) {
-throw new IllegalArgumentException("Source declaration without
directory value.");
-}
-directory = baseDir.resolve(value);
-FileSystem fs = directory.getFileSystem();
+FileSystem fs = baseDir.getFileSystem();
includes = matchers(fs, source.getIncludes());
excludes = matchers(fs, source.getExcludes());
stringFiltering = source.isStringFiltering();
enabled = source.isEnabled();
moduleName = nonBlank(source.getModule());
-value = nonBlank(source.getScope());
+String value = nonBlank(source.getScope());
scope = (value != null) ? session.requireProjectScope(value) :
ProjectScope.MAIN;
value = nonBlank(source.getLang());
Review Comment:
It's not new in this PR so it's not a blocker, but I don't agree this is OK
and I wouldn't have approved it if this were new code. Each could simply be
named based on the source field it's derived from
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Reenable many old style tests [maven]
elharo opened a new pull request, #2182: URL: https://github.com/apache/maven/pull/2182 Presumably these were all accidentally disabled but let's see what shape they're in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8645) Plugins resolving don't use dependency management for plugin project
[
https://issues.apache.org/jira/browse/MNG-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938053#comment-17938053
]
Slawomir Jaranowski commented on MNG-8645:
--
to reproduce please execute:
{code}
mvn verify -P run-its -Dinvoker.test=MJAR-307}}
{code}
in maven-jar-plugin, dependency:tree is ok, internal plugin resolving in Maven
has issue.
> Plugins resolving don't use dependency management for plugin project
>
>
> Key: MNG-8645
> URL: https://issues.apache.org/jira/browse/MNG-8645
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-rc-3
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> example in maven-jar-plugin (3.x) we have dependencyManagement for commons-io
> https://github.com/apache/maven-jar-plugin/blob/08cea8ed3caf1c7f6575b8392d4fc1396f24a09c/pom.xml#L82
> Maven 3.9.x and rc-2 resolve as:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:4.0.1 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.16.1 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> but for rc-3 we have:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:3.4.2 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.11.0 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> {{commons-io}} and {{plexus-utils}} have defined versions in dependency
> management but it is not taken into account.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8645) Plugins resolving don't use dependency management for plugin project
[
https://issues.apache.org/jira/browse/MNG-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938053#comment-17938053
]
Slawomir Jaranowski edited comment on MNG-8645 at 3/24/25 10:41 PM:
to reproduce please execute:
{code:java}
mvn verify -P run-its -Dinvoker.test=MJAR-307
{code}
in maven-jar-plugin, dependency:tree is ok, internal plugin resolving in Maven
has issue.
was (Author: slawekjaranowski):
to reproduce please execute:
{code}
mvn verify -P run-its -Dinvoker.test=MJAR-307}}
{code}
in maven-jar-plugin, dependency:tree is ok, internal plugin resolving in Maven
has issue.
> Plugins resolving don't use dependency management for plugin project
>
>
> Key: MNG-8645
> URL: https://issues.apache.org/jira/browse/MNG-8645
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-rc-3
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> example in maven-jar-plugin (3.x) we have dependencyManagement for commons-io
> https://github.com/apache/maven-jar-plugin/blob/08cea8ed3caf1c7f6575b8392d4fc1396f24a09c/pom.xml#L82
> Maven 3.9.x and rc-2 resolve as:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:4.0.1 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.16.1 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> but for rc-3 we have:
> {code}
> [DEBUG] org.apache.maven.plugins:maven-jar-plugin:jar:3.4.3-SNAPSHOT
> [DEBUG] +- org.apache.maven.shared:file-management:jar:3.1.0 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-utils:jar:3.4.2 [compile]
> [DEBUG] | \- commons-io:commons-io:jar:2.11.0 [compile]
> [DEBUG] +- org.apache.maven:maven-archiver:jar:3.6.2 [compile]
> [DEBUG] | \- org.codehaus.plexus:plexus-interpolation:jar:1.27 [compile]
> [DEBUG] +- org.codehaus.plexus:plexus-archiver:jar:4.9.2 [compile]
> [DEBUG] | +- org.codehaus.plexus:plexus-io:jar:3.4.2 [compile]
> [DEBUG] | +- org.apache.commons:commons-compress:jar:1.26.1 [compile]
> [DEBUG] | | \- org.apache.commons:commons-lang3:jar:3.14.0 [compile]
> [DEBUG] | +- commons-codec:commons-codec:jar:1.16.1 [compile]
> [DEBUG] | +- org.iq80.snappy:snappy:jar:0.4 [compile]
> [DEBUG] | +- org.tukaani:xz:jar:1.9 [runtime]
> [DEBUG] | \- com.github.luben:zstd-jni:jar:1.5.5-11 [runtime]
> [DEBUG] +- javax.inject:javax.inject:jar:1 [compile]
> [DEBUG] \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
> {code}
> {{commons-io}} and {{plexus-utils}} have defined versions in dependency
> management but it is not taken into account.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8510] Rename cling.invoker.Utils class and reduce public API surface [maven]
elharo closed pull request #2041: [MNG-8510] Rename cling.invoker.Utils class and reduce public API surface URL: https://github.com/apache/maven/pull/2041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-1737] Fix disable in statelessTestsetReporter [maven-surefire]
slawekjaranowski merged PR #816: URL: https://github.com/apache/maven-surefire/pull/816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-1737) Disabling the JUnit5Xml30StatelessReporter has no effect
[
https://issues.apache.org/jira/browse/SUREFIRE-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed SUREFIRE-1737.
-
Resolution: Fixed
> Disabling the JUnit5Xml30StatelessReporter has no effect
> -
>
> Key: SUREFIRE-1737
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1737
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M4
>Reporter: Dietrich Schulten
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release, 3.5.1
>
>
> I have the following configuration for JUnit 5 display names:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.0.0-M4
>
> implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
> true
> true
> true
> true
> true
>
>
> {code}
> Based on the disable flag, the {{JUnit5Xml30StatelessReporter}} should be
> {{disabled}}, but it evaluates display names according to the
> {{usePhrasedXXX}} flags.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [IT] Fix to make Mimir cache for ITs [maven]
cstamas commented on PR #2176: URL: https://github.com/apache/maven/pull/2176#issuecomment-2747838605 I dislike it. It means we need to modify _legacy_ code base to make it work with Maven 4? Are we sure we cannot make it work by improving the heuristic instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8643) Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.4
Tamas Cservenak created MNG-8643: Summary: Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.4 Key: MNG-8643 URL: https://issues.apache.org/jira/browse/MNG-8643 Project: Maven Issue Type: Dependency upgrade Components: Dependencies Reporter: Tamas Cservenak Fix For: 4.0.0-rc-4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8640) Bump org.apache.maven:maven-parent from 43 to 44
[ https://issues.apache.org/jira/browse/MNG-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MNG-8640. Resolution: Fixed > Bump org.apache.maven:maven-parent from 43 to 44 > > > Key: MNG-8640 > URL: https://issues.apache.org/jira/browse/MNG-8640 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.10 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.4 [maven]
cstamas merged PR #2179: URL: https://github.com/apache/maven/pull/2179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-8643) Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.4
[ https://issues.apache.org/jira/browse/MNG-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8643: Assignee: Tamas Cservenak > Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.4 > --- > > Key: MNG-8643 > URL: https://issues.apache.org/jira/browse/MNG-8643 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0-rc-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8643) Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.4
[ https://issues.apache.org/jira/browse/MNG-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8643. Resolution: Fixed > Bump net.bytebuddy:byte-buddy from 1.17.2 to 1.17.4 > --- > > Key: MNG-8643 > URL: https://issues.apache.org/jira/browse/MNG-8643 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0-rc-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Add release drafter, PR-automation and stale action [maven-war-plugin]
Bukama commented on code in PR #85: URL: https://github.com/apache/maven-war-plugin/pull/85#discussion_r2011311224 ## .github/release-drafter.yml: ## @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +_extends: maven-gh-actions-shared + +tag-template: maven-war-plugin-$RESOLVED_VERSION Review Comment: Okay I'll remove it, but we should upgrade to parent soon then to don't run into problems I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
