[jira] [Assigned] (MNG-8248) WARNING: A restricted method in java.lang.System has been called
[
https://issues.apache.org/jira/browse/MNG-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MNG-8248:
Assignee: Slawomir Jaranowski
> WARNING: A restricted method in java.lang.System has been called
>
>
> Key: MNG-8248
> URL: https://issues.apache.org/jira/browse/MNG-8248
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.1, 3.8.2, 3.8.3, 3.8.4, 3.8.5, 3.8.6, 3.8.7, 3.8.8,
> 3.9.0, 3.9.1, 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6, 3.9.7, 3.9.8, 3.9.9,
> 4.0.0-beta-3, 4.0.0-beta-4
>Reporter: Karl Heinz Marbaise
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.9.10
>
>
> Building a project with JDK 24.ea.13 produces the following WARNING:
> {code}
> $> mvn clean verify
> WARNING: A restricted method in java.lang.System has been called
> WARNING: java.lang.System::load has been called by
> org.jline.nativ.JLineNativeLoader in an unnamed module
> (file:/Users/khm/tools/maven/lib/jline-3.26.3.jar)
> WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for
> callers in this module
> WARNING: Restricted methods will be blocked in a future release unless native
> access is enabled
> {code}
> also a simple:
> {code}
> mvn --version
> {code}
> wil trigger:
> {code}
> $> mvn --version
> WARNING: A restricted method in java.lang.System has been called
> WARNING: java.lang.System::load has been called by
> org.fusesource.jansi.internal.JansiLoader in an unnamed module
> (file:/Users/khm/tools/maven/lib/jansi-2.4.1.jar)
> WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for
> callers in this module
> WARNING: Restricted methods will be blocked in a future release unless native
> access is enabled
> Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
> Maven home: /Users/khm/tools/maven
> Java version: 24-ea, vendor: Oracle Corporation, runtime:
> /Users/khm/.sdkman/candidates/java/24.ea.13-open
> Default locale: en_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
> {code}
> Also opened an issue on JLine3 Project:
> https://github.com/jline/jline3/issues/1067
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8639] Check namespaces when reading XML models [maven]
gnodet commented on code in PR #2170:
URL: https://github.com/apache/maven/pull/2170#discussion_r2006965673
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##
@@ -48,8 +48,37 @@
@Singleton
public class DefaultModelXmlFactory implements ModelXmlFactory {
@Override
+@Nonnull
public Model read(@Nonnull XmlReaderRequest request) throws
XmlReaderException {
nonNull(request, "request");
+Model model = doRead(request);
+if (isModelVersionGreaterThan400(model)
+&&
!model.getNamespaceUri().startsWith("http://maven.apache.org/POM/";)) {
+throw new XmlReaderException(
+"Invalid namespace '" + model.getNamespaceUri() + "' for
model version " + model.getModelVersion(),
+null,
+null);
+}
+return model;
+}
+
+private boolean isModelVersionGreaterThan400(Model model) {
+String version = model.getModelVersion();
+if (version == null) {
+return false;
+}
+try {
+String[] parts = version.split("\\.");
+int major = Integer.parseInt(parts[0]);
+int minor = parts.length > 1 ? Integer.parseInt(parts[1]) : 0;
+return major > 4 || (major == 4 && minor > 0);
+} catch (NumberFormatException | ArrayIndexOutOfBoundsException e) {
Review Comment:
Definitely, I've change the code to reflect that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8537) Maven 4 namespace should not change
[ https://issues.apache.org/jira/browse/MNG-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937208#comment-17937208 ] Guillaume Nodet commented on MNG-8537: -- I've create MNG-8639 to validate namespace consistency and enforce the use of a namespace when reading XML models with modelVersion > 4.0.0. > Maven 4 namespace should not change > --- > > Key: MNG-8537 > URL: https://issues.apache.org/jira/browse/MNG-8537 > Project: Maven > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Priority: Blocker > > Just noticed that Maven 4 has a new namespace URL. The old namespace was > > [http://maven.apache.org/POM/4.0.0] > > The new one is > > [http://maven.apache.org/POM/4.1.0] > > Putting version numbers in namespaces is a known XML antipattern because it > makes it extremely difficult and inconvenient to write tools that process > both, even when they are much the same. XSLT, DOM, XQuery, JDOM, etc. — > really any XML aware tool — is going to have problems with this. > Model version 4.1.0 is not a new and different schema that completely breaks > with the past. Most old elements from 4.0.0 are still present and still mean > exactly the same thing: groupId, artifactId, name, dependency, and most > others. There are new elements but that doesn't imply a new namespace. Adding > a new namespace is asserting that all the elements are different. > IMHO Maven 4 should not change the namespace URL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Check namespaces when reading XML models [maven]
gnodet opened a new pull request, #2170: URL: https://github.com/apache/maven/pull/2170 * validate namespace consistency in XML * make sure a valid namespace is used for modelVersion > 4.0.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8639) Check namespaces when reading XML models
[ https://issues.apache.org/jira/browse/MNG-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8639: - Issue Type: Bug (was: Task) > Check namespaces when reading XML models > > > Key: MNG-8639 > URL: https://issues.apache.org/jira/browse/MNG-8639 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2170 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8639) Check namespaces when reading XML models
[ https://issues.apache.org/jira/browse/MNG-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8639: - Fix Version/s: 4.0.0-rc-4 > Check namespaces when reading XML models > > > Key: MNG-8639 > URL: https://issues.apache.org/jira/browse/MNG-8639 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2170 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8639) Check namespaces when reading XML models
Guillaume Nodet created MNG-8639: Summary: Check namespaces when reading XML models Key: MNG-8639 URL: https://issues.apache.org/jira/browse/MNG-8639 Project: Maven Issue Type: Task Reporter: Guillaume Nodet GitHub Pull Request: https://github.com/apache/maven/pull/2170 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8639) Check namespaces when reading XML models
[ https://issues.apache.org/jira/browse/MNG-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-8639: Assignee: Guillaume Nodet > Check namespaces when reading XML models > > > Key: MNG-8639 > URL: https://issues.apache.org/jira/browse/MNG-8639 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2170 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8638) Properties in repository id/url not supported anymore
[
https://issues.apache.org/jira/browse/MNG-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937214#comment-17937214
]
Tamas Cservenak commented on MNG-8638:
--
Again, POMs are deployed to Central, and as such, they should be deterministic
(reproducible). You can still achieve your goals and make build work same way
in both Maven 3 and Maven 4 with a local (or project) settings.xml that
redefine the snapshotsRepo.
Basically make pom contains snapshotsRepo with
[https://my.server/snapshotsRepo] and whoever (user or CI) can "redefine" this
repo to point at nightly snapshots using settings.xml.
> Properties in repository id/url not supported anymore
> -
>
> Key: MNG-8638
> URL: https://issues.apache.org/jira/browse/MNG-8638
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Marc Guillemot
>Priority: Major
>
> Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> properties-in-repos
> 0.0.1-SNAPSHOT
> pom
>
> snapshotsRepo
>
> https://my.server/snapshotsRepo
>
>
>
> useNightlySnapshot
>
>
> nightlySnapshotsRepo
>
> https://my.server/nightlySnapshotsRepo
>
>
>
>
>
> ${repo.snapshots.id}
> ${repo.snapshots.url}
>
> false
>
>
>
>
> {code}
> Maven 4.0.0-rc-3 fails with following error:
> {code:java}
> [ERROR] Some problems were encountered while processing the POMs
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
> (C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1
> error
> [ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
> unsupported expression (only expressions starting with 'project.basedir' or
> 'project.rootDirectory' are supported). @
> test:properties-in-repos:0.0.1-SNAPSHOT,
> file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
> {code}
> This would block our migration to Maven 4 as we use such a construct to
> deploy snapshots from nightly builds to a separate repository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven]
cstamas commented on PR #2162: URL: https://github.com/apache/maven/pull/2162#issuecomment-2741617277 If you already have it locally, just push here IMO, but separate PR is ok as well but that PR will fail as long this one is not merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8640] Bump org.apache.maven:maven-parent from 43 to 44 [maven]
slawekjaranowski merged PR #2163: URL: https://github.com/apache/maven/pull/2163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven]
slawekjaranowski commented on PR #2162: URL: https://github.com/apache/maven/pull/2162#issuecomment-274143 By the way we need a fix site build eg with profile run-its without it is ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8640) Bump org.apache.maven:maven-parent from 43 to 44
Slawomir Jaranowski created MNG-8640: Summary: Bump org.apache.maven:maven-parent from 43 to 44 Key: MNG-8640 URL: https://issues.apache.org/jira/browse/MNG-8640 Project: Maven Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.9.10 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven]
slawekjaranowski commented on PR #2162: URL: https://github.com/apache/maven/pull/2162#issuecomment-2741682203 > > By the way we need a fix site build eg with profile run-its without it is ok. > > @slawekjaranowski Could you rephrase please ? I'm not sure to understand exactly what you mean. please try ``` mvn site -P run-its ``` will try to build site also in its modules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.google.guava:guava from 32.0.1-jre to 33.4.5-jre [maven-resources-plugin]
dependabot[bot] opened a new pull request, #110: URL: https://github.com/apache/maven-resources-plugin/pull/110 Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.0.1-jre to 33.4.5-jre. Release notes Sourced from https://github.com/google/guava/releases";>com.google.guava:guava's releases. 33.4.5 For those upgrading from Guava 33.4.0 or earlier, be sure to read https://github.com/google/guava/releases/tag/v33.4.1";>the release notes for Guava 33.4.1. MavenJar files https://repo1.maven.org/maven2/com/google/guava/guava/33.4.5-jre/guava-33.4.5-jre.jar";>33.4.5-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/33.4.5-android/guava-33.4.5-android.jar";>33.4.5-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies";>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.3/failureaccess-1.0.3.jar";>failureaccess-1.0.3.jar Javadoc https://guava.dev/releases/33.4.5-jre/api/docs/";>33.4.5-jre https://guava.dev/releases/33.4.5-android/api/docs/";>33.4.5-android JDiff https://guava.dev/releases/33.4.5-jre/api/diffs/";>33.4.5-jre vs. 33.4.4-jre https://guava.dev/releases/33.4.5-android/api/diffs/";>33.4.5-android vs. 33.4.4-android https://guava.dev/releases/33.4.5-android/api/androiddiffs/";>33.4.5-android vs. 33.4.5-jre Changelog Changed the Guava jar (plus guava-testlib and https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies";>failureaccess jars) to be a modular jar. (7a71ea0bfa, 287c701a86) Changed various classes to stop using sun.misc.Unsafe under Java 9+. (ee63055ddd, 80aab00dc5b7a36785f5e09b6a54397388980cde, 400af25292096746ed3f6164f0ff88209acbb19f, 71d0692d418a5dd001c9b3786275a5f1f94e1971, d1a3cd5037528a2ae990bfceed9cdd009fbc54de, b3bb29a54b8f13d6f6630b6cb929867adbf6b9a0, 1a300f6b2f7ba03ae9bc3620a80c4d4589c65b69) Note that, if you use guava-android on the JVM (instead of using guava-jre), Guava will still try to use sun.misc.Unsafe. We will do https://redirect.github.com/google/guava/issues/6806#issuecomment-2738313040";>further work on this in the future. Belatedly updated the Public Suffix List data. (ee3b9c64382037f72b3a8341915cc64b87850b53, d25d62fc843ece1c3866859bc8639b815093eac8) Special thanks to https://github.com/sgammon";>@sgammon for https://javamodules.dev/";>his modularization efforts. 33.4.4 This is one of a series of releases that improve Guava's nullness annotations. For more information, including troubleshooting help, see https://github.com/google/guava/releases/tag/v33.4.1";>the release notes for Guava 33.4.1. Most users can update directly to Guava 33.4.5. Maven ... (truncated) Commits See full diff in https://github.com/google/guava/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any com.google.guava guava 33.4.5-jre 33.4.5-android
Re: [PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven]
gnodet commented on PR #2162: URL: https://github.com/apache/maven/pull/2162#issuecomment-2741677679 > By the way we need a fix site build eg with profile run-its without it is ok. @slawekjaranowski Could you rephrase please ? I'm not sure to understand exactly what you mean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre [maven-deploy-plugin]
dependabot[bot] opened a new pull request, #119: URL: https://github.com/apache/maven-deploy-plugin/pull/119 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.4.0-jre to 33.4.5-jre. Release notes Sourced from https://github.com/google/guava/releases";>com.google.guava:guava's releases. 33.4.5 For those upgrading from Guava 33.4.0 or earlier, be sure to read https://github.com/google/guava/releases/tag/v33.4.1";>the release notes for Guava 33.4.1. MavenJar files https://repo1.maven.org/maven2/com/google/guava/guava/33.4.5-jre/guava-33.4.5-jre.jar";>33.4.5-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/33.4.5-android/guava-33.4.5-android.jar";>33.4.5-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies";>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.3/failureaccess-1.0.3.jar";>failureaccess-1.0.3.jar Javadoc https://guava.dev/releases/33.4.5-jre/api/docs/";>33.4.5-jre https://guava.dev/releases/33.4.5-android/api/docs/";>33.4.5-android JDiff https://guava.dev/releases/33.4.5-jre/api/diffs/";>33.4.5-jre vs. 33.4.4-jre https://guava.dev/releases/33.4.5-android/api/diffs/";>33.4.5-android vs. 33.4.4-android https://guava.dev/releases/33.4.5-android/api/androiddiffs/";>33.4.5-android vs. 33.4.5-jre Changelog Changed the Guava jar (plus guava-testlib and https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies";>failureaccess jars) to be a modular jar. (7a71ea0bfa, 287c701a86) Changed various classes to stop using sun.misc.Unsafe under Java 9+. (ee63055ddd, 80aab00dc5b7a36785f5e09b6a54397388980cde, 400af25292096746ed3f6164f0ff88209acbb19f, 71d0692d418a5dd001c9b3786275a5f1f94e1971, d1a3cd5037528a2ae990bfceed9cdd009fbc54de, b3bb29a54b8f13d6f6630b6cb929867adbf6b9a0, 1a300f6b2f7ba03ae9bc3620a80c4d4589c65b69) Note that, if you use guava-android on the JVM (instead of using guava-jre), Guava will still try to use sun.misc.Unsafe. We will do https://redirect.github.com/google/guava/issues/6806#issuecomment-2738313040";>further work on this in the future. Belatedly updated the Public Suffix List data. (ee3b9c64382037f72b3a8341915cc64b87850b53, d25d62fc843ece1c3866859bc8639b815093eac8) Special thanks to https://github.com/sgammon";>@sgammon for https://javamodules.dev/";>his modularization efforts. 33.4.4 This is one of a series of releases that improve Guava's nullness annotations. For more information, including troubleshooting help, see https://github.com/google/guava/releases/tag/v33.4.1";>the release notes for Guava 33.4.1. Most users can update directly to Guava 33.4.5. Maven ... (truncated) Commits See full diff in https://github.com/google/guava/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any mo com.google.guava guava 33.4.5-jre 33.4.5-android
Re: [PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven]
slawekjaranowski commented on PR #2163: URL: https://github.com/apache/maven/pull/2163#issuecomment-2741413136 I will fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8639] Check namespaces when reading XML models [maven]
michael-o commented on code in PR #2170:
URL: https://github.com/apache/maven/pull/2170#discussion_r2006925005
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##
@@ -48,8 +48,37 @@
@Singleton
public class DefaultModelXmlFactory implements ModelXmlFactory {
@Override
+@Nonnull
public Model read(@Nonnull XmlReaderRequest request) throws
XmlReaderException {
nonNull(request, "request");
+Model model = doRead(request);
+if (isModelVersionGreaterThan400(model)
+&&
!model.getNamespaceUri().startsWith("http://maven.apache.org/POM/";)) {
+throw new XmlReaderException(
+"Invalid namespace '" + model.getNamespaceUri() + "' for
model version " + model.getModelVersion(),
+null,
+null);
+}
+return model;
+}
+
+private boolean isModelVersionGreaterThan400(Model model) {
+String version = model.getModelVersion();
+if (version == null) {
+return false;
+}
+try {
+String[] parts = version.split("\\.");
+int major = Integer.parseInt(parts[0]);
+int minor = parts.length > 1 ? Integer.parseInt(parts[1]) : 0;
+return major > 4 || (major == 4 && minor > 0);
+} catch (NumberFormatException | ArrayIndexOutOfBoundsException e) {
Review Comment:
Isn't IOOBE enough to catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8638) Properties in repository id/url not supported anymore
[
https://issues.apache.org/jira/browse/MNG-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937090#comment-17937090
]
Tamas Cservenak commented on MNG-8638:
--
That's right, and this is due "build reproducibility" reasons, given
project/repositories/repository is not for deploy but consumptions.
So you consume nightly snapshots from different repositories?
> Properties in repository id/url not supported anymore
> -
>
> Key: MNG-8638
> URL: https://issues.apache.org/jira/browse/MNG-8638
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Marc Guillemot
>Priority: Major
>
> Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> properties-in-repos
> 0.0.1-SNAPSHOT
> pom
>
> snapshotsRepo
>
> https://my.server/snapshotsRepo
>
>
>
>
>
> nightlySnapshotsRepo
>
> https://my.server/nightlySnapshotsRepo
>
>
>
>
>
> ${repo.snapshots.id}
> ${repo.snapshots.url}
>
> false
>
>
> {code}
> Maven 4.0.0-rc-3 fails with following error:
> {code:java}
> [ERROR] Some problems were encountered while processing the POMs
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
> (C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1
> error
> [ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
> unsupported expression (only expressions starting with 'project.basedir' or
> 'project.rootDirectory' are supported). @
> test:properties-in-repos:0.0.1-SNAPSHOT,
> file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
> {code}
> This would block our migration to Maven 4 as we use such a construct to
> deploy snapshots from nightly builds to a separate repository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8638) Properties in repository id/url not supported anymore
[
https://issues.apache.org/jira/browse/MNG-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937093#comment-17937093
]
Tamas Cservenak edited comment on MNG-8638 at 3/20/25 11:32 AM:
So, in short: Repositories defined in POM (as they are deployed and latest on
consumed) must be "known ahead", they cannot be "dynamically evaluated" as that
renders build reproducibility impossible. Proper solution for this would be
(that works in Maven 3 and Maven 4) is to have settings.xml that introduces any
"variable" to the picture, and have only "fixed" repositories in POM (so this
one removed).
was (Author: cstamas):
So, in short: Repositories defined in POM but be "known ahead", they cannot be
"dynamically evaluated" as that renders build reproducibility impossible.
Proper solution for this would be (that works in Maven 3 and Maven 4) is to
have settings.xml that introduces any "variable" to the picture, and have only
"fixed" repositories in POM (so this one removed).
> Properties in repository id/url not supported anymore
> -
>
> Key: MNG-8638
> URL: https://issues.apache.org/jira/browse/MNG-8638
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Marc Guillemot
>Priority: Major
>
> Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> properties-in-repos
> 0.0.1-SNAPSHOT
> pom
>
> snapshotsRepo
>
> https://my.server/snapshotsRepo
>
>
>
>
>
> nightlySnapshotsRepo
>
> https://my.server/nightlySnapshotsRepo
>
>
>
>
>
> ${repo.snapshots.id}
> ${repo.snapshots.url}
>
> false
>
>
> {code}
> Maven 4.0.0-rc-3 fails with following error:
> {code:java}
> [ERROR] Some problems were encountered while processing the POMs
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
> (C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1
> error
> [ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
> unsupported expression (only expressions starting with 'project.basedir' or
> 'project.rootDirectory' are supported). @
> test:properties-in-repos:0.0.1-SNAPSHOT,
> file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
> {code}
> This would block our migration to Maven 4 as we use such a construct to
> deploy snapshots from nightly builds to a separate repository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8638) Properties in repository id/url not supported anymore
[
https://issues.apache.org/jira/browse/MNG-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937100#comment-17937100
]
Michael Osipov commented on MNG-8638:
-
Repos are expected to be static...
> Properties in repository id/url not supported anymore
> -
>
> Key: MNG-8638
> URL: https://issues.apache.org/jira/browse/MNG-8638
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Marc Guillemot
>Priority: Major
>
> Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> properties-in-repos
> 0.0.1-SNAPSHOT
> pom
>
> snapshotsRepo
>
> https://my.server/snapshotsRepo
>
>
>
>
>
> nightlySnapshotsRepo
>
> https://my.server/nightlySnapshotsRepo
>
>
>
>
>
> ${repo.snapshots.id}
> ${repo.snapshots.url}
>
> false
>
>
> {code}
> Maven 4.0.0-rc-3 fails with following error:
> {code:java}
> [ERROR] Some problems were encountered while processing the POMs
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
> (C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1
> error
> [ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
> unsupported expression (only expressions starting with 'project.basedir' or
> 'project.rootDirectory' are supported). @
> test:properties-in-repos:0.0.1-SNAPSHOT,
> file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
> {code}
> This would block our migration to Maven 4 as we use such a construct to
> deploy snapshots from nightly builds to a separate repository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRESOLVER-646) Maven4 supplier should use maven-impl
[ https://issues.apache.org/jira/browse/MRESOLVER-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-646: -- Fix Version/s: (was: 2.0.8) > Maven4 supplier should use maven-impl > - > > Key: MRESOLVER-646 > URL: https://issues.apache.org/jira/browse/MRESOLVER-646 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8624] Fix dependency not being set correctly for unsupported types [maven]
gnodet merged PR #2153: URL: https://github.com/apache/maven/pull/2153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8632] Update Full Build pipeline to also build with JDK 24 [maven]
slachiewicz commented on PR #2169: URL: https://github.com/apache/maven/pull/2169#issuecomment-2741771593 Before Temurin availability, we still could use 24-ea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8641) Bump org.apache.maven:maven-parent from 43 to 44
[ https://issues.apache.org/jira/browse/MNG-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8641: - Issue Type: Dependency upgrade (was: Task) > Bump org.apache.maven:maven-parent from 43 to 44 > > > Key: MNG-8641 > URL: https://issues.apache.org/jira/browse/MNG-8641 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2162 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8641) Bump org.apache.maven:maven-parent from 43 to 44
[ https://issues.apache.org/jira/browse/MNG-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8641: - Fix Version/s: 4.0.0-rc-4 > Bump org.apache.maven:maven-parent from 43 to 44 > > > Key: MNG-8641 > URL: https://issues.apache.org/jira/browse/MNG-8641 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2162 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8641) Bump org.apache.maven:maven-parent from 43 to 44
Guillaume Nodet created MNG-8641: Summary: Bump org.apache.maven:maven-parent from 43 to 44 Key: MNG-8641 URL: https://issues.apache.org/jira/browse/MNG-8641 Project: Maven Issue Type: Task Reporter: Guillaume Nodet GitHub Pull Request: https://github.com/apache/maven/pull/2162 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8641] Bump org.apache.maven:maven-parent from 43 to 44 [maven]
gnodet merged PR #2162: URL: https://github.com/apache/maven/pull/2162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8641) Bump org.apache.maven:maven-parent from 43 to 44
[ https://issues.apache.org/jira/browse/MNG-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8641. Resolution: Fixed > Bump org.apache.maven:maven-parent from 43 to 44 > > > Key: MNG-8641 > URL: https://issues.apache.org/jira/browse/MNG-8641 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2162 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8641) Bump org.apache.maven:maven-parent from 43 to 44
[ https://issues.apache.org/jira/browse/MNG-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-8641: Assignee: Guillaume Nodet > Bump org.apache.maven:maven-parent from 43 to 44 > > > Key: MNG-8641 > URL: https://issues.apache.org/jira/browse/MNG-8641 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2162 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8624) Fix dependency not being set correctly for unsupported types
[ https://issues.apache.org/jira/browse/MNG-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8624. Resolution: Fixed > Fix dependency not being set correctly for unsupported types > > > Key: MNG-8624 > URL: https://issues.apache.org/jira/browse/MNG-8624 > Project: Maven > Issue Type: Task >Affects Versions: 4.0.0-rc-3 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2153 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MNG-8248] Add enable-native-access to startup scripts [maven]
slawekjaranowski opened a new pull request, #2171: URL: https://github.com/apache/maven/pull/2171 In order to avoid WARNING A restricted method in java.lang.System has been called --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8632] Update Full Build pipeline to also build with JDK 24 [maven]
slachiewicz commented on PR #2169: URL: https://github.com/apache/maven/pull/2169#issuecomment-2739786595 Depends on Temurin availability https://github.com/adoptium/temurin/issues/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRESOLVER-693) Deprecate mvn4 supplier module
Tamas Cservenak created MRESOLVER-693: - Summary: Deprecate mvn4 supplier module Key: MRESOLVER-693 URL: https://issues.apache.org/jira/browse/MRESOLVER-693 Project: Maven Resolver Issue Type: Task Components: Resolver Reporter: Tamas Cservenak Fix For: 2.0.8 Once new "standalone Maven API" module materializes and becomes released (lands on Maven Central) the supplier-mvn4 should be deprecated with a message pointing at new "standalone API" artifacts. Supplier mvn4 anyway used Maven4 in "maven 3 way": via maven-resolver-supplier that IS in Maven 4 compat. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8633] Initialize entities map lazily [maven]
gnodet merged PR #2165: URL: https://github.com/apache/maven/pull/2165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-5102] Add support for POM mixins [maven]
jimisola commented on code in PR #1209: URL: https://github.com/apache/maven/pull/1209#discussion_r2005077787 ## its/core-it-suite/src/test/resources/mng-5102-mixins/gav/project/pom.xml: ## @@ -0,0 +1,60 @@ + + +http://maven.apache.org/POM/4.1.0"; root="true"> + org.apache.maven.its.mng5102 + gav + 0.1 + pom + + Maven Integration Test :: MNG-5102 + Mixins tests. + + + + +org.apache.maven.its.plugins +maven-it-plugin-expression +2.1-SNAPSHOT + + + + eval + +validate + + target/model.properties + +project/properties + + + + + + + + + + + org.apache.maven.its.mng5102 + mixin-2 Review Comment: Not sure if it is of interest for @gnodet but here is our Maven Tiles setup. We use tiles and composites where are used to group tiles. Hence, we have a need for including mixins in mixins for us to be able to group mixins into composites. Parent Tile - maven-tiles-parent which is used to set the Maven Tiles version for all tiles (won't be needed with Maven Mixins) Tiles: - common-tile - java-17-tile - java-21-tile - lfv-development-environment-tile - lint-tile - maven-core-versions-tile - openapi-tile - opentelemetry-tile - reqstool-tile - soap-tile - spring-boot-amqp-tile - spring-boot-application-tile - spring-boot-camel-tile - spring-boot-mvc-tile - spring-boot-oauth-tile - spring-boot-redis-tile - spring-boot-tile - spring-boot-vault-tile - sysdev-common-tile - test-compile-tile @talios As for the properties issue (our use case seem to be different), with respect for this PR we refer to this [new ticket](https://github.com/repaint-io/maven-tiles/issues/159) in Maven Tiles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPMD-414) maven-pmd-plugin fails with NoClassDefFoundError after upgrading to Maven 4 RC3
Thomas Scheffler created MPMD-414:
-
Summary: maven-pmd-plugin fails with NoClassDefFoundError after
upgrading to Maven 4 RC3
Key: MPMD-414
URL: https://issues.apache.org/jira/browse/MPMD-414
Project: Maven PMD Plugin
Issue Type: Bug
Components: PMD
Affects Versions: 3.26.0
Environment: Maven version: 4 RC3
maven-pmd-plugin version: 3.26.0
PMD version: 7.11.0
Reporter: Thomas Scheffler
After upgrading to Maven 4 RC3, the `maven-pmd-plugin` fails with the following
error:
{noformat}
[INFO] Toolchain in maven-pmd-plugin:
ToolchainWrapperV3[delegate=org.apache.maven.impl.DefaultJavaToolchainFactory$DefaultJavaToolchain@4b8e778d]
[INFO] PMD version: 7.11.0
[WARNING] [stderr] Exception in thread "main" java.lang.NoClassDefFoundError:
org/apache/maven/cli/logging/Slf4jConfigurationFactory
[WARNING] [stderr] at
org.apache.maven.plugins.pmd.exec.Executor.setupLogLevel(Executor.java:45)
[WARNING] [stderr] at
org.apache.maven.plugins.pmd.exec.PmdExecutor.main(PmdExecutor.java:136)
[WARNING] [stderr] Caused by: java.lang.ClassNotFoundException:
org.apache.maven.cli.logging.Slf4jConfigurationFactory
[WARNING] [stderr] at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
[WARNING] [stderr] at
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
[WARNING] [stderr] at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
[WARNING] [stderr] ... 2 more
{noformat}
*Steps to Reproduce*:
1. Upgrade to Maven 4 RC3.
2. Run the `maven-pmd-plugin` with pmd goal.
*Expected Result*:
The `maven-pmd-plugin` should run without errors.
*Actual Result*:
The `maven-pmd-plugin` fails with a `NoClassDefFoundError`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SUREFIRE-1643] surefire junit5 parallel tests [maven-surefire]
slawekjaranowski commented on code in PR #815: URL: https://github.com/apache/maven-surefire/pull/815#discussion_r2004985987 ## Jenkinsfile: ## @@ -21,19 +21,18 @@ properties( [ -buildDiscarder(logRotator(artifactDaysToKeepStr: env.BRANCH_NAME == 'master' ? '14' : '7', - artifactNumToKeepStr: '50', +buildDiscarder(logRotator(artifactNumToKeepStr: env.BRANCH_NAME == 'master' ? '15' : '5', daysToKeepStr: env.BRANCH_NAME == 'master' ? '30' : '14', numToKeepStr: env.BRANCH_NAME == 'master' ? '20' : '10') -), -disableConcurrentBuilds() +)//, +//disableConcurrentBuilds() ] ) // final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def oses = ['linux':'ubuntu && maven'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.x.x', '3.6.3'] : ['3.x.x'] +final def oses = ['linux':'ubuntu'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.x.x', '3.8.8'] : ['3.x.x'] Review Comment: as minimum maven we have in code 3.6.3 https://github.com/apache/maven-surefire/blob/66e85890cc4c4fb466726abf7339cbd952052ecc/pom.xml#L91 We can change it to 3.8.8 but if possible I would like to see it in separate PR By the way should we start discussion about next minimum version for all plugins? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8632) Add JDK 24 to the Full Build Pipeline Job
Mark Derricutt created MNG-8632: --- Summary: Add JDK 24 to the Full Build Pipeline Job Key: MNG-8632 URL: https://issues.apache.org/jira/browse/MNG-8632 Project: Maven Issue Type: Improvement Components: Bootstrap & Build Affects Versions: 4.0.0-rc-3 Reporter: Mark Derricutt I noticed that the build currently fails under JDK 24 due to an outdated ASM version in `sisu-maven-plugin`. This is already being tracked upstream in: https://github.com/eclipse-sisu/sisu-project/issues/174 and once completed/released we can update Maven to use the newer plugin. Prior to that we should update the Github pipelines to include JDK 24 in the Full Build job. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [SUREFIRE-1643] surefire junit5 parallel tests [maven-surefire]
olamy commented on code in PR #815: URL: https://github.com/apache/maven-surefire/pull/815#discussion_r2005077652 ## Jenkinsfile: ## @@ -21,19 +21,18 @@ properties( [ -buildDiscarder(logRotator(artifactDaysToKeepStr: env.BRANCH_NAME == 'master' ? '14' : '7', - artifactNumToKeepStr: '50', +buildDiscarder(logRotator(artifactNumToKeepStr: env.BRANCH_NAME == 'master' ? '15' : '5', daysToKeepStr: env.BRANCH_NAME == 'master' ? '30' : '14', numToKeepStr: env.BRANCH_NAME == 'master' ? '20' : '10') -), -disableConcurrentBuilds() +)//, +//disableConcurrentBuilds() ] ) // final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def oses = ['linux':'ubuntu && maven'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.x.x', '3.6.3'] : ['3.x.x'] +final def oses = ['linux':'ubuntu'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.x.x', '3.8.8'] : ['3.x.x'] Review Comment: I have restored this. If this hurt you :) cced9cd1e557ff6b96da41862421373a4fae5253 But to be honest, I don't understand why we should support a plugin with a core version we do not officially support. This looks weird to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8633) Initialize entities map lazily
Guillaume Nodet created MNG-8633: Summary: Initialize entities map lazily Key: MNG-8633 URL: https://issues.apache.org/jira/browse/MNG-8633 Project: Maven Issue Type: Task Reporter: Guillaume Nodet GitHub Pull Request: https://github.com/apache/maven/pull/2165 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump com.google.guava:failureaccess from 1.0.2 to 1.0.3 [maven]
cstamas merged PR #2167: URL: https://github.com/apache/maven/pull/2167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8634) Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre
[ https://issues.apache.org/jira/browse/MNG-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8634. Resolution: Fixed > Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre > - > > Key: MNG-8634 > URL: https://issues.apache.org/jira/browse/MNG-8634 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0-rc-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8635) Bump com.google.guava:failureaccess from 1.0.2 to 1.0.3
Tamas Cservenak created MNG-8635: Summary: Bump com.google.guava:failureaccess from 1.0.2 to 1.0.3 Key: MNG-8635 URL: https://issues.apache.org/jira/browse/MNG-8635 Project: Maven Issue Type: Dependency upgrade Components: Dependencies Reporter: Tamas Cservenak Fix For: 4.0.0-rc-4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre [maven]
cstamas merged PR #2166: URL: https://github.com/apache/maven/pull/2166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8633) Initialize entities map lazily
[ https://issues.apache.org/jira/browse/MNG-8633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8633. Fix Version/s: 4.0.0-rc-4 Assignee: Guillaume Nodet Resolution: Fixed > Initialize entities map lazily > -- > > Key: MNG-8633 > URL: https://issues.apache.org/jira/browse/MNG-8633 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-rc-4 > > > GitHub Pull Request: https://github.com/apache/maven/pull/2165 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8634) Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre
Tamas Cservenak created MNG-8634: Summary: Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre Key: MNG-8634 URL: https://issues.apache.org/jira/browse/MNG-8634 Project: Maven Issue Type: Dependency upgrade Components: Dependencies Reporter: Tamas Cservenak Fix For: 4.0.0-rc-4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8635) Bump com.google.guava:failureaccess from 1.0.2 to 1.0.3
[ https://issues.apache.org/jira/browse/MNG-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8635. Assignee: Tamas Cservenak Resolution: Fixed > Bump com.google.guava:failureaccess from 1.0.2 to 1.0.3 > --- > > Key: MNG-8635 > URL: https://issues.apache.org/jira/browse/MNG-8635 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0-rc-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8635) Bump com.google.guava:failureaccess from 1.0.2 to 1.0.3
[ https://issues.apache.org/jira/browse/MNG-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8635: - Fix Version/s: 3.9.10 (was: 4.0.0-rc-4) > Bump com.google.guava:failureaccess from 1.0.2 to 1.0.3 > --- > > Key: MNG-8635 > URL: https://issues.apache.org/jira/browse/MNG-8635 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.10 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre [maven]
cstamas merged PR #2168: URL: https://github.com/apache/maven/pull/2168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8636) Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre
Tamas Cservenak created MNG-8636: Summary: Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre Key: MNG-8636 URL: https://issues.apache.org/jira/browse/MNG-8636 Project: Maven Issue Type: Dependency upgrade Components: Dependencies Reporter: Tamas Cservenak Fix For: 3.9.10 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8636) Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre
[ https://issues.apache.org/jira/browse/MNG-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8636. Assignee: Tamas Cservenak Resolution: Fixed > Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre > - > > Key: MNG-8636 > URL: https://issues.apache.org/jira/browse/MNG-8636 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.10 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8634) Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre
[ https://issues.apache.org/jira/browse/MNG-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8634: Assignee: Tamas Cservenak > Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre > - > > Key: MNG-8634 > URL: https://issues.apache.org/jira/browse/MNG-8634 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0-rc-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump com.google.guava:guava from 32.0.1-jre to 33.4.5-jre [maven-source-plugin]
dependabot[bot] opened a new pull request, #53: URL: https://github.com/apache/maven-source-plugin/pull/53 Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.0.1-jre to 33.4.5-jre. Release notes Sourced from https://github.com/google/guava/releases";>com.google.guava:guava's releases. 33.4.5 For those upgrading from Guava 33.4.0 or earlier, be sure to read https://github.com/google/guava/releases/tag/v33.4.1";>the release notes for Guava 33.4.1. MavenJar files https://repo1.maven.org/maven2/com/google/guava/guava/33.4.5-jre/guava-33.4.5-jre.jar";>33.4.5-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/33.4.5-android/guava-33.4.5-android.jar";>33.4.5-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies";>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.3/failureaccess-1.0.3.jar";>failureaccess-1.0.3.jar Javadoc https://guava.dev/releases/33.4.5-jre/api/docs/";>33.4.5-jre https://guava.dev/releases/33.4.5-android/api/docs/";>33.4.5-android JDiff https://guava.dev/releases/33.4.5-jre/api/diffs/";>33.4.5-jre vs. 33.4.4-jre https://guava.dev/releases/33.4.5-android/api/diffs/";>33.4.5-android vs. 33.4.4-android https://guava.dev/releases/33.4.5-android/api/androiddiffs/";>33.4.5-android vs. 33.4.5-jre Changelog Changed the Guava jar (plus guava-testlib and https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies";>failureaccess jars) to be a modular jar. (7a71ea0bfa, 287c701a86) Changed various classes to stop using sun.misc.Unsafe under Java 9+. (ee63055ddd, 80aab00dc5b7a36785f5e09b6a54397388980cde, 400af25292096746ed3f6164f0ff88209acbb19f, 71d0692d418a5dd001c9b3786275a5f1f94e1971, d1a3cd5037528a2ae990bfceed9cdd009fbc54de, b3bb29a54b8f13d6f6630b6cb929867adbf6b9a0, 1a300f6b2f7ba03ae9bc3620a80c4d4589c65b69) Note that, if you use guava-android on the JVM (instead of using guava-jre), Guava will still try to use sun.misc.Unsafe. We will do https://redirect.github.com/google/guava/issues/6806#issuecomment-2738313040";>further work on this in the future. Belatedly updated the Public Suffix List data. (ee3b9c64382037f72b3a8341915cc64b87850b53, d25d62fc843ece1c3866859bc8639b815093eac8) Special thanks to https://github.com/sgammon";>@sgammon for https://javamodules.dev/";>his modularization efforts. 33.4.4 This is one of a series of releases that improve Guava's nullness annotations. For more information, including troubleshooting help, see https://github.com/google/guava/releases/tag/v33.4.1";>the release notes for Guava 33.4.1. Most users can update directly to Guava 33.4.5. Maven ... (truncated) Commits See full diff in https://github.com/google/guava/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more com.google.guava guava 33.4.5-jre 33.4.5-android
Re: [PR] Bump com.google.guava:guava from 32.0.1-jre to 33.4.0-jre [maven-source-plugin]
dependabot[bot] closed pull request #47: Bump com.google.guava:guava from 32.0.1-jre to 33.4.0-jre URL: https://github.com/apache/maven-source-plugin/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.0.1-jre to 33.4.0-jre [maven-source-plugin]
dependabot[bot] commented on PR #47: URL: https://github.com/apache/maven-source-plugin/pull/47#issuecomment-2739397624 Superseded by #53. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-1643] surefire junit5 parallel tests [maven-surefire]
olamy commented on code in PR #815: URL: https://github.com/apache/maven-surefire/pull/815#discussion_r2004969538 ## surefire-its/src/test/resources/surefire-1643-parallel-junit5/pom.xml: ## @@ -0,0 +1,97 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + org.apache.maven.plugins.surefire + junit-platform-1.0.0 + 1.0 + [SUREFIRE-1643] JUnit 5: Parallel Test mixed + + +UTF-8 +1.8 +1.8 + 3 + fixed + true + concurrent + same_thread + + + + + +org.junit +junit-bom +5.9.1 +pom +import + + + + + + + org.junit.jupiter + junit-jupiter-api + test + + + + + + + + + maven-clean-plugin + 3.4.0 + + + + maven-resources-plugin + 3.3.1 + + + maven-compiler-plugin + 3.13.0 + + + maven-surefire-plugin + 3.5.3-SNAPSHOT Review Comment: oops :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-1643] surefire junit5 parallel tests [maven-surefire]
olamy commented on code in PR #815: URL: https://github.com/apache/maven-surefire/pull/815#discussion_r2004972221 ## Jenkinsfile: ## @@ -21,19 +21,18 @@ properties( [ -buildDiscarder(logRotator(artifactDaysToKeepStr: env.BRANCH_NAME == 'master' ? '14' : '7', - artifactNumToKeepStr: '50', +buildDiscarder(logRotator(artifactNumToKeepStr: env.BRANCH_NAME == 'master' ? '15' : '5', daysToKeepStr: env.BRANCH_NAME == 'master' ? '30' : '14', numToKeepStr: env.BRANCH_NAME == 'master' ? '20' : '10') -), -disableConcurrentBuilds() +)//, +//disableConcurrentBuilds() ] ) // final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def oses = ['linux':'ubuntu && maven'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.x.x', '3.6.3'] : ['3.x.x'] +final def oses = ['linux':'ubuntu'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.x.x', '3.8.8'] : ['3.x.x'] Review Comment: but we support only 3.8.x and 3.9.x as of today :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-1643] surefire junit5 parallel tests [maven-surefire]
olamy commented on code in PR #815: URL: https://github.com/apache/maven-surefire/pull/815#discussion_r2004972916 ## surefire-its/pom.xml: ## @@ -241,6 +242,13 @@ + + apache.ci + +0.4C +1 + + Review Comment: it looks to GH nodes are not shared and so support more load. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-1643] surefire junit5 parallel tests [maven-surefire]
olamy commented on code in PR #815: URL: https://github.com/apache/maven-surefire/pull/815#discussion_r2004969538 ## surefire-its/src/test/resources/surefire-1643-parallel-junit5/pom.xml: ## @@ -0,0 +1,97 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + org.apache.maven.plugins.surefire + junit-platform-1.0.0 + 1.0 + [SUREFIRE-1643] JUnit 5: Parallel Test mixed + + +UTF-8 +1.8 +1.8 + 3 + fixed + true + concurrent + same_thread + + + + + +org.junit +junit-bom +5.9.1 +pom +import + + + + + + + org.junit.jupiter + junit-jupiter-api + test + + + + + + + + + maven-clean-plugin + 3.4.0 + + + + maven-resources-plugin + 3.3.1 + + + maven-compiler-plugin + 3.13.0 + + + maven-surefire-plugin + 3.5.3-SNAPSHOT Review Comment: oops :) good catch fixed with 7402d848ff1dbdc0040de112ea7bf0f371d89640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8637) Pull out "Standalone API" from UTs
Tamas Cservenak created MNG-8637: Summary: Pull out "Standalone API" from UTs Key: MNG-8637 URL: https://issues.apache.org/jira/browse/MNG-8637 Project: Maven Issue Type: Task Components: Core Reporter: Tamas Cservenak Fix For: 4.0.0-rc-4 We have means to boot Maven in "Standalone API" (ie. "maven without maven") to perform mostly Resolver-only tasks. This code is currently in maven-impl UTs. This code needs to be pulled out and made reusable, as this should become "the proper way" to utilize Maven 4 in 'MIMA-like scenarios'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre [maven-mvnd]
dependabot[bot] opened a new pull request, #1299: URL: https://github.com/apache/maven-mvnd/pull/1299 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.4.0-jre to 33.4.5-jre. Release notes Sourced from https://github.com/google/guava/releases";>com.google.guava:guava's releases. 33.4.5 For those upgrading from Guava 33.4.0 or earlier, be sure to read https://github.com/google/guava/releases/tag/v33.4.1";>the release notes for Guava 33.4.1. MavenJar files https://repo1.maven.org/maven2/com/google/guava/guava/33.4.5-jre/guava-33.4.5-jre.jar";>33.4.5-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/33.4.5-android/guava-33.4.5-android.jar";>33.4.5-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies";>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.3/failureaccess-1.0.3.jar";>failureaccess-1.0.3.jar Javadoc https://guava.dev/releases/33.4.5-jre/api/docs/";>33.4.5-jre https://guava.dev/releases/33.4.5-android/api/docs/";>33.4.5-android JDiff https://guava.dev/releases/33.4.5-jre/api/diffs/";>33.4.5-jre vs. 33.4.4-jre https://guava.dev/releases/33.4.5-android/api/diffs/";>33.4.5-android vs. 33.4.4-android https://guava.dev/releases/33.4.5-android/api/androiddiffs/";>33.4.5-android vs. 33.4.5-jre Changelog Changed the Guava jar (plus guava-testlib and https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies";>failureaccess jars) to be a modular jar. (7a71ea0bfa, 287c701a86) Changed various classes to stop using sun.misc.Unsafe under Java 9+. (ee63055ddd, 80aab00dc5b7a36785f5e09b6a54397388980cde, 400af25292096746ed3f6164f0ff88209acbb19f, 71d0692d418a5dd001c9b3786275a5f1f94e1971, d1a3cd5037528a2ae990bfceed9cdd009fbc54de, b3bb29a54b8f13d6f6630b6cb929867adbf6b9a0, 1a300f6b2f7ba03ae9bc3620a80c4d4589c65b69) Note that, if you use guava-android on the JVM (instead of using guava-jre), Guava will still try to use sun.misc.Unsafe. We will do https://redirect.github.com/google/guava/issues/6806#issuecomment-2738313040";>further work on this in the future. Belatedly updated the Public Suffix List data. (ee3b9c64382037f72b3a8341915cc64b87850b53, d25d62fc843ece1c3866859bc8639b815093eac8) Special thanks to https://github.com/sgammon";>@sgammon for https://javamodules.dev/";>his modularization efforts. 33.4.4 This is one of a series of releases that improve Guava's nullness annotations. For more information, including troubleshooting help, see https://github.com/google/guava/releases/tag/v33.4.1";>the release notes for Guava 33.4.1. Most users can update directly to Guava 33.4.5. Maven ... (truncated) Commits See full diff in https://github.com/google/guava/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for com.google.guava guava 33.4.5-jre 33.4.5-android
[jira] [Created] (MNG-8638) Properties in repository id/url not supported anymore
Marc Guillemot created MNG-8638:
---
Summary: Properties in repository id/url not supported anymore
Key: MNG-8638
URL: https://issues.apache.org/jira/browse/MNG-8638
Project: Maven
Issue Type: Bug
Components: Core
Affects Versions: 4.0.0-rc-3
Reporter: Marc Guillemot
Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
{code:xml}
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
properties-in-repos
0.0.1-SNAPSHOT
pom
snapshotsRepo
https://my.server/snapshotsRepo
nightlySnapshotsRepo
https://my.server/nightlySnapshotsRepo
${repo.snapshots.id}
${repo.snapshots.url}
false
[Help 1]
[ERROR]
[ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
(C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.
xml) has 1 error
[ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
unsupported expression (only expressions starting wit
h 'project.basedir' or 'project.rootDirectory' are supported). @
test:properties-in-repos:0.0.1-SNAPSHOT,
file://.../poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
{code}
This would block our migration to Maven 4 as we use such a construct to deploy
snapshots from nightly builds to a separate repository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SUREFIRE-1643] surefire junit5 parallel tests [maven-surefire]
slawekjaranowski commented on code in PR #815: URL: https://github.com/apache/maven-surefire/pull/815#discussion_r2005354753 ## Jenkinsfile: ## @@ -21,19 +21,18 @@ properties( [ -buildDiscarder(logRotator(artifactDaysToKeepStr: env.BRANCH_NAME == 'master' ? '14' : '7', - artifactNumToKeepStr: '50', +buildDiscarder(logRotator(artifactNumToKeepStr: env.BRANCH_NAME == 'master' ? '15' : '5', daysToKeepStr: env.BRANCH_NAME == 'master' ? '30' : '14', numToKeepStr: env.BRANCH_NAME == 'master' ? '20' : '10') -), -disableConcurrentBuilds() +)//, +//disableConcurrentBuilds() ] ) // final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def oses = ['linux':'ubuntu && maven'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.x.x', '3.6.3'] : ['3.x.x'] +final def oses = ['linux':'ubuntu'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.x.x', '3.8.8'] : ['3.x.x'] Review Comment: It is not a problem for me, even more I am for it ... But should be done in separate PR. We should discuss and start switching all plugins We also have info about 3.6.3 at https://maven.apache.org/docs/history.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-646) Maven4 supplier should use maven-impl
[ https://issues.apache.org/jira/browse/MRESOLVER-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-646. - Resolution: Won't Fix > Maven4 supplier should use maven-impl > - > > Key: MRESOLVER-646 > URL: https://issues.apache.org/jira/browse/MRESOLVER-646 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8638) Properties in repository id/url not supported anymore
[
https://issues.apache.org/jira/browse/MNG-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937093#comment-17937093
]
Tamas Cservenak commented on MNG-8638:
--
So, in short: Repositories defined in POM but be "known ahead", they cannot be
"dynamically evaluated" as that renders build reproducibility impossible.
Proper solution for this would be (that works in Maven 3 and Maven 4) is to
have settings.xml that introduces any "variable" to the picture, and have only
"fixed" repositories in POM (so this one removed).
> Properties in repository id/url not supported anymore
> -
>
> Key: MNG-8638
> URL: https://issues.apache.org/jira/browse/MNG-8638
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Marc Guillemot
>Priority: Major
>
> Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> properties-in-repos
> 0.0.1-SNAPSHOT
> pom
>
> snapshotsRepo
>
> https://my.server/snapshotsRepo
>
>
>
>
>
> nightlySnapshotsRepo
>
> https://my.server/nightlySnapshotsRepo
>
>
>
>
>
> ${repo.snapshots.id}
> ${repo.snapshots.url}
>
> false
>
>
> {code}
> Maven 4.0.0-rc-3 fails with following error:
> {code:java}
> [ERROR] Some problems were encountered while processing the POMs
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
> (C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1
> error
> [ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
> unsupported expression (only expressions starting with 'project.basedir' or
> 'project.rootDirectory' are supported). @
> test:properties-in-repos:0.0.1-SNAPSHOT,
> file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
> {code}
> This would block our migration to Maven 4 as we use such a construct to
> deploy snapshots from nightly builds to a separate repository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRESOLVER-646) Maven4 supplier should use maven-impl
[ https://issues.apache.org/jira/browse/MRESOLVER-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937098#comment-17937098 ] ASF GitHub Bot commented on MRESOLVER-646: -- cstamas closed pull request #672: [MRESOLVER-646] Use Maven 4 internal bits URL: https://github.com/apache/maven-resolver/pull/672 > Maven4 supplier should use maven-impl > - > > Key: MRESOLVER-646 > URL: https://issues.apache.org/jira/browse/MRESOLVER-646 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-693) Deprecate mvn4 supplier module
[ https://issues.apache.org/jira/browse/MRESOLVER-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937099#comment-17937099 ] Tamas Cservenak commented on MRESOLVER-693: --- This should be done once we provide "escape route" like Standalone Maven API reusable. > Deprecate mvn4 supplier module > -- > > Key: MRESOLVER-693 > URL: https://issues.apache.org/jira/browse/MRESOLVER-693 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.8 > > > Once new "standalone Maven API" module materializes and becomes released > (lands on Maven Central) the supplier-mvn4 should be deprecated with a > message pointing at new "standalone API" artifacts. > Supplier mvn4 anyway used Maven4 in "maven 3 way": via > maven-resolver-supplier that IS in Maven 4 compat. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-693) Deprecate mvn4 supplier module
[ https://issues.apache.org/jira/browse/MRESOLVER-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-693: -- Fix Version/s: (was: 2.0.8) > Deprecate mvn4 supplier module > -- > > Key: MRESOLVER-693 > URL: https://issues.apache.org/jira/browse/MRESOLVER-693 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > > Once new "standalone Maven API" module materializes and becomes released > (lands on Maven Central) the supplier-mvn4 should be deprecated with a > message pointing at new "standalone API" artifacts. > Supplier mvn4 anyway used Maven4 in "maven 3 way": via > maven-resolver-supplier that IS in Maven 4 compat. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-646] Use Maven 4 internal bits [maven-resolver]
cstamas closed pull request #672: [MRESOLVER-646] Use Maven 4 internal bits URL: https://github.com/apache/maven-resolver/pull/672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8638) Properties in repository id/url not supported anymore
[
https://issues.apache.org/jira/browse/MNG-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marc Guillemot updated MNG-8638:
Description:
Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
{code:xml}
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
properties-in-repos
0.0.1-SNAPSHOT
pom
snapshotsRepo
https://my.server/snapshotsRepo
nightlySnapshotsRepo
https://my.server/nightlySnapshotsRepo
${repo.snapshots.id}
${repo.snapshots.url}
false
[Help 1]
[ERROR]
[ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
(C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1 error
[ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
unsupported expression (only expressions starting with 'project.basedir' or
'project.rootDirectory' are supported). @
test:properties-in-repos:0.0.1-SNAPSHOT,
file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
{code}
This would block our migration to Maven 4 as we use such a construct to deploy
snapshots from nightly builds to a separate repository.
was:
Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
{code:xml}
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
properties-in-repos
0.0.1-SNAPSHOT
pom
snapshotsRepo
https://my.server/snapshotsRepo
nightlySnapshotsRepo
https://my.server/nightlySnapshotsRepo
${repo.snapshots.id}
${repo.snapshots.url}
false
[Help 1]
[ERROR]
[ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
(C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.
xml) has 1 error
[ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
unsupported expression (only expressions starting wit
h 'project.basedir' or 'project.rootDirectory' are supported). @
test:properties-in-repos:0.0.1-SNAPSHOT,
file://.../poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
{code}
This would block our migration to Maven 4 as we use such a construct to deploy
snapshots from nightly builds to a separate repository.
> Properties in repository id/url not supported anymore
> -
>
> Key: MNG-8638
> URL: https://issues.apache.org/jira/browse/MNG-8638
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Marc Guillemot
>Priority: Major
>
> Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> properties-in-repos
> 0.0.1-SNAPSHOT
> pom
>
> snapshotsRepo
>
> https://my.server/snapshotsRepo
>
>
>
>
>
> nightlySnapshotsRepo
>
> https://my.server/nightlySnapshotsRepo
>
>
>
>
>
> ${repo.snapshots.id}
> ${repo.snapshots.url}
>
> false
>
>
> {code}
> Maven 4.0.0-rc-3 fails with following error:
> {code:java}
> [ERROR] Some problems were encountered while processing the POMs
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
> (C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1
> error
> [ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
> unsupported expression (only expressions starting with 'project.basedir' or
> 'project.rootDirectory' are supported). @
> test:properties-in-repos:0.0.1-
[jira] [Comment Edited] (MNG-8638) Properties in repository id/url not supported anymore
[
https://issues.apache.org/jira/browse/MNG-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937090#comment-17937090
]
Tamas Cservenak edited comment on MNG-8638 at 3/20/25 11:26 AM:
That's right, and this is due "build reproducibility" reasons, given
project/repositories/repository is not for deploy but consuming artifacts.
So you consume nightly snapshots from different repositories each time?
was (Author: cstamas):
That's right, and this is due "build reproducibility" reasons, given
project/repositories/repository is not for deploy but consumptions.
So you consume nightly snapshots from different repositories?
> Properties in repository id/url not supported anymore
> -
>
> Key: MNG-8638
> URL: https://issues.apache.org/jira/browse/MNG-8638
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Marc Guillemot
>Priority: Major
>
> Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> properties-in-repos
> 0.0.1-SNAPSHOT
> pom
>
> snapshotsRepo
>
> https://my.server/snapshotsRepo
>
>
>
>
>
> nightlySnapshotsRepo
>
> https://my.server/nightlySnapshotsRepo
>
>
>
>
>
> ${repo.snapshots.id}
> ${repo.snapshots.url}
>
> false
>
>
> {code}
> Maven 4.0.0-rc-3 fails with following error:
> {code:java}
> [ERROR] Some problems were encountered while processing the POMs
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
> (C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1
> error
> [ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
> unsupported expression (only expressions starting with 'project.basedir' or
> 'project.rootDirectory' are supported). @
> test:properties-in-repos:0.0.1-SNAPSHOT,
> file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
> {code}
> This would block our migration to Maven 4 as we use such a construct to
> deploy snapshots from nightly builds to a separate repository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre [maven-mvnd]
cstamas merged PR #1299: URL: https://github.com/apache/maven-mvnd/pull/1299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8632] Update Full Build pipeline to also build with JDK 24 [maven]
gnodet commented on PR #2169: URL: https://github.com/apache/maven/pull/2169#issuecomment-2740641721 Moving to draft until JDK 24 is available on GHA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8638) Properties in repository id/url not supported anymore
[
https://issues.apache.org/jira/browse/MNG-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marc Guillemot updated MNG-8638:
Description:
Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
{code:xml}
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
properties-in-repos
0.0.1-SNAPSHOT
pom
snapshotsRepo
https://my.server/snapshotsRepo
useNightlySnapshot
nightlySnapshotsRepo
https://my.server/nightlySnapshotsRepo
${repo.snapshots.id}
${repo.snapshots.url}
false
{code}
Maven 4.0.0-rc-3 fails with following error:
{code:java}
[ERROR] Some problems were encountered while processing the POMs
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
(C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1 error
[ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
unsupported expression (only expressions starting with 'project.basedir' or
'project.rootDirectory' are supported). @
test:properties-in-repos:0.0.1-SNAPSHOT,
file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
{code}
This would block our migration to Maven 4 as we use such a construct to deploy
snapshots from nightly builds to a separate repository.
was:
Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
{code:xml}
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
properties-in-repos
0.0.1-SNAPSHOT
pom
snapshotsRepo
https://my.server/snapshotsRepo
nightlySnapshotsRepo
https://my.server/nightlySnapshotsRepo
${repo.snapshots.id}
${repo.snapshots.url}
false
[Help 1]
[ERROR]
[ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
(C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1 error
[ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
unsupported expression (only expressions starting with 'project.basedir' or
'project.rootDirectory' are supported). @
test:properties-in-repos:0.0.1-SNAPSHOT,
file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
{code}
This would block our migration to Maven 4 as we use such a construct to deploy
snapshots from nightly builds to a separate repository.
> Properties in repository id/url not supported anymore
> -
>
> Key: MNG-8638
> URL: https://issues.apache.org/jira/browse/MNG-8638
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Marc Guillemot
>Priority: Major
>
> Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> properties-in-repos
> 0.0.1-SNAPSHOT
> pom
>
> snapshotsRepo
>
> https://my.server/snapshotsRepo
>
>
>
> useNightlySnapshot
>
>
> nightlySnapshotsRepo
>
> https://my.server/nightlySnapshotsRepo
>
>
>
>
>
> ${repo.snapshots.id}
> ${repo.snapshots.url}
>
> false
>
>
>
>
> {code}
> Maven 4.0.0-rc-3 fails with following error:
> {code:java}
> [ERROR] Some problems were encountered while processing the POMs
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
> (C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-
Re: [PR] [MNG-8632] Update Full Build pipeline to also build with JDK 24 [maven]
cstamas commented on PR #2169: URL: https://github.com/apache/maven/pull/2169#issuecomment-2741041538 And Jenkins? Or should we in fact just "lower" ASF Jenkins usage to provide daily snapshots only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8638) Properties in repository id/url not supported anymore
[
https://issues.apache.org/jira/browse/MNG-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937168#comment-17937168
]
Marc Guillemot commented on MNG-8638:
-
A quick try give the impression that repositories can still be enabled/disabled
based on properties what should be a simple way for us. I don't really
understand how it fits with the "build reproducibility" reasons ;)
> Properties in repository id/url not supported anymore
> -
>
> Key: MNG-8638
> URL: https://issues.apache.org/jira/browse/MNG-8638
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Marc Guillemot
>Priority: Major
>
> Following pom.xml can be used with Maven 3.9.x but not mit Maven 4.
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> properties-in-repos
> 0.0.1-SNAPSHOT
> pom
>
> snapshotsRepo
>
> https://my.server/snapshotsRepo
>
>
>
> useNightlySnapshot
>
>
> nightlySnapshotsRepo
>
> https://my.server/nightlySnapshotsRepo
>
>
>
>
>
> ${repo.snapshots.id}
> ${repo.snapshots.url}
>
> false
>
>
>
>
> {code}
> Maven 4.0.0-rc-3 fails with following error:
> {code:java}
> [ERROR] Some problems were encountered while processing the POMs
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project test:properties-in-repos:pom:0.0.1-SNAPSHOT
> (C:\dev\eclipse-workspace-okular-bis\poc-dynamic-mvn-deploy\pom.xml) has 1
> error
> [ERROR] 'repositories.repository.[${repo.snapshots.id}].url' contains an
> unsupported expression (only expressions starting with 'project.basedir' or
> 'project.rootDirectory' are supported). @
> test:properties-in-repos:0.0.1-SNAPSHOT,
> file://[sic]/poc-dynamic-mvn-deploy/pom.xml, line 26, column 13
> {code}
> This would block our migration to Maven 4 as we use such a construct to
> deploy snapshots from nightly builds to a separate repository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven]
slawekjaranowski commented on PR #2162: URL: https://github.com/apache/maven/pull/2162#issuecomment-2741466026 > Needs site descriptor changes as well... What do you think to update site descriptors in separate PR ... ? I have fixed it - changes about 92 files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
