[jira] [Assigned] (SUREFIRE-2277) The value of RunResult flakes field is lost during serialisation and deserialisation to and from failsafe-summary.xml
[ https://issues.apache.org/jira/browse/SUREFIRE-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned SUREFIRE-2277: Assignee: Michael Osipov > The value of RunResult flakes field is lost during serialisation and > deserialisation to and from failsafe-summary.xml > - > > Key: SUREFIRE-2277 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2277 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.5.1 >Reporter: Bing Xu >Assignee: Michael Osipov >Priority: Major > > Hello from Atlassian, > > I have found a bug in `RunResult.testAppendSerialization`. I don't think it > should be passing on master. > This test creates a `RunResult` object in-memory, serialises it, writes it to > disk and then again deserialises the same file into a `RunResult` in-memory. > I have run the test with the debugger and found that the final in-memory > `RunResult` object is not the same as the initial one. The test is only > passing because the `RunResult.flakes` field is not being considered in the > `RunResult.equals` method (and the RunResult.equals method is used in the > assertion within the test `RunResult.testAppendSerialization`). > This is due to a bug in how the RunResult is converted to a > `failsafe-summary.xml`. In the function > `FailsafeSummaryXmlUtils.fromRunResultToFile`, `RunResult.flakes` is not > written to the xml. To fix this issue, I have modified the > `failsafe-summary.xsd` to include , which will allow Flakes to be > persisted in the `failsafe-summary.xml`. I have also changed the > serialisation and deserialisation methods for `RunResult` to account for > `flakes`. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2277) The value of RunResult flakes field is lost during serialisation and deserialisation to and from failsafe-summary.xml
[ https://issues.apache.org/jira/browse/SUREFIRE-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888542#comment-17888542 ] Michael Osipov commented on SUREFIRE-2277: -- Will try to look at this this month. Thanks for the PR. > The value of RunResult flakes field is lost during serialisation and > deserialisation to and from failsafe-summary.xml > - > > Key: SUREFIRE-2277 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2277 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.5.1 >Reporter: Bing Xu >Assignee: Michael Osipov >Priority: Major > > Hello from Atlassian, > > I have found a bug in `RunResult.testAppendSerialization`. I don't think it > should be passing on master. > This test creates a `RunResult` object in-memory, serialises it, writes it to > disk and then again deserialises the same file into a `RunResult` in-memory. > I have run the test with the debugger and found that the final in-memory > `RunResult` object is not the same as the initial one. The test is only > passing because the `RunResult.flakes` field is not being considered in the > `RunResult.equals` method (and the RunResult.equals method is used in the > assertion within the test `RunResult.testAppendSerialization`). > This is due to a bug in how the RunResult is converted to a > `failsafe-summary.xml`. In the function > `FailsafeSummaryXmlUtils.fromRunResultToFile`, `RunResult.flakes` is not > written to the xml. To fix this issue, I have modified the > `failsafe-summary.xsd` to include , which will allow Flakes to be > persisted in the `failsafe-summary.xml`. I have also changed the > serialisation and deserialisation methods for `RunResult` to account for > `flakes`. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.15.3 to 1.15.4 [maven]
gnodet commented on PR #1791: URL: https://github.com/apache/maven/pull/1791#issuecomment-2408196111 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.5.8 to 1.5.9 [maven]
gnodet commented on PR #1789: URL: https://github.com/apache/maven/pull/1789#issuecomment-2408195942 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1438] Resolve Code Duplication for XRef Link generation [maven-reporting-impl]
michael-o commented on PR #56: URL: https://github.com/apache/maven-reporting-impl/pull/56#issuecomment-2407817123 @slawekjaranowski Simplified impl. Docs still missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1438) Resolve Code Duplication for XRef Link generation
[ https://issues.apache.org/jira/browse/MSHARED-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888718#comment-17888718 ] ASF GitHub Bot commented on MSHARED-1438: - michael-o commented on PR #56: URL: https://github.com/apache/maven-reporting-impl/pull/56#issuecomment-2407817123 @slawekjaranowski Simplified impl. Docs still missing. > Resolve Code Duplication for XRef Link generation > - > > Key: MSHARED-1438 > URL: https://issues.apache.org/jira/browse/MSHARED-1438 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl-4.0.0-M15 >Reporter: Andreas Dangel >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-impl-4.0.0 > > > PMD, Checkstyle and Surefire all have the same code to determine the xref > code location for reporting and linking to the source code. > See MPMD-128 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-689) Archetype Plugin 3.3.0 introduced incompatibilities
[
https://issues.apache.org/jira/browse/ARCHETYPE-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888759#comment-17888759
]
Joe DiPol commented on ARCHETYPE-689:
-
[~sjaranowski] thanks for the quick response. We are reviewing the PR, and have
run into an issue testing with the changes. Will provide more feedback when we
get to the bottom of it.
> Archetype Plugin 3.3.0 introduced incompatibilities
> ---
>
> Key: ARCHETYPE-689
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-689
> Project: Maven Archetype
> Issue Type: Bug
> Components: Generator, Plugin
>Affects Versions: 3.3.0
>Reporter: Joe DiPol
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.1
>
>
> Archetype Plugin 3.3.0 introduced API incompatibilities that can break
> existing maven archetypes. This is significant because when the plugin is
> invoked by users the version of the plugin is rarely specified. An example of
> such a breakage is [https://github.com/helidon-io/helidon/issues/9305] (where
> all previously shipped versions of our maven archetypes broke).
> The incompatibilities were introduced by
> [https://github.com/apache/maven-archetype/pull/211] and
> [https://github.com/apache/maven-archetype/pull/215]
> Changes that broke our archetypes:
> # The removal of {{ArchetypeGenerationRequest.getProjectBuildingRequest()}}
> # The changing of the return type of
> {{ArchetypeGenerationRequest.getRemoteArtifactRepositories()}} from
> {{List}} to {{List}}
> It also looks like a number of other methods were removed from
> {{ArchetypeGenerationRequest}}.
> As documented in
> [https://maven.apache.org/archetype/maven-archetype-plugin/advanced-usage.html#post-generation-script]
> the {{ArchetypeGenerationRequest}} object is the primary API for
> customization by a post-generation groovy script. And the changed/removed
> methods were not marked for deprecation. Any archetype released before 3.3.0
> that relied on this class is potentially broken.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-sec-dispatcher from 2.0 to 3.0.0 [maven-release]
slachiewicz commented on PR #233: URL: https://github.com/apache/maven-release/pull/233#issuecomment-2408029587 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-sec-dispatcher from 2.0 to 3.0.0 [maven-release]
dependabot[bot] closed pull request #233: Bump org.codehaus.plexus:plexus-sec-dispatcher from 2.0 to 3.0.0 URL: https://github.com/apache/maven-release/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-sec-dispatcher from 2.0 to 3.0.0 [maven-release]
dependabot[bot] commented on PR #233: URL: https://github.com/apache/maven-release/pull/233#issuecomment-2408029672 OK, I won't notify you about version 3.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (ARCHETYPE-688) Incompatibities with Velocity in Archetypes
[ https://issues.apache.org/jira/browse/ARCHETYPE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed ARCHETYPE-688. - Resolution: Fixed > Incompatibities with Velocity in Archetypes > --- > > Key: ARCHETYPE-688 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-688 > Project: Maven Archetype > Issue Type: Bug > Components: Archetypes, Generator, Plugin >Affects Versions: 3.3.0 >Reporter: Javid >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.1 > > > Hello, > I am having an issue caused by the new version of the > maven-archetype-plugin:3.3.0 related with the recent upgrade of velocity 1.7 > to velocity 2.3. > As it is reported in the [Velocity > configuration|https://velocity.apache.org/engine/2.3/upgrading.html#vtl-changes_1], > from version 1.7 to version 2+, the use of hyphens have changed and now they > are not supported in parameters, causing errors. > To avoid this, there is a property that allow backwards compatibility > [detailed > here|https://velocity.apache.org/engine/2.3/configuration.html#backward-compatibility], > but I believe there is no way to tell maven-archetype-plugin to allow this > compatibility in the configuration. > I have a very complex project that uses hyphens in multiple instances and > now, it is impossible to generate a project with the new archetype:3.3.0 > version. > My problem is that changing the hyphen will cause a major impact in some > other projects that rely on this archetype, so it is not a viable option for > me to do. > Could it be possible for you to include a way to modify Velocity > configuration in maven-archetype-plugin:3.3.0? This would be extremely > helpful so we can keep up with the future updates > Thanks in advance! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [ARCHETYPE-688] Allow hyphen in requiredProperty [maven-archetype]
slawekjaranowski merged PR #230: URL: https://github.com/apache/maven-archetype/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (ARCHETYPE-689) Archetype Plugin 3.3.0 introduced incompatibilities
[
https://issues.apache.org/jira/browse/ARCHETYPE-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888769#comment-17888769
]
Slawomir Jaranowski edited comment on ARCHETYPE-689 at 10/11/24 8:55 PM:
-
[~barchetta] ok, I will waiting for feedback, it is one last issue ... and I
can release 3.3.1 version
was (Author: slawekjaranowski):
[~barchetta] ok, I will waiting for feedback, it is one last issue ... and I
can release 3.2.1 version
> Archetype Plugin 3.3.0 introduced incompatibilities
> ---
>
> Key: ARCHETYPE-689
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-689
> Project: Maven Archetype
> Issue Type: Bug
> Components: Generator, Plugin
>Affects Versions: 3.3.0
>Reporter: Joe DiPol
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.1
>
>
> Archetype Plugin 3.3.0 introduced API incompatibilities that can break
> existing maven archetypes. This is significant because when the plugin is
> invoked by users the version of the plugin is rarely specified. An example of
> such a breakage is [https://github.com/helidon-io/helidon/issues/9305] (where
> all previously shipped versions of our maven archetypes broke).
> The incompatibilities were introduced by
> [https://github.com/apache/maven-archetype/pull/211] and
> [https://github.com/apache/maven-archetype/pull/215]
> Changes that broke our archetypes:
> # The removal of {{ArchetypeGenerationRequest.getProjectBuildingRequest()}}
> # The changing of the return type of
> {{ArchetypeGenerationRequest.getRemoteArtifactRepositories()}} from
> {{List}} to {{List}}
> It also looks like a number of other methods were removed from
> {{ArchetypeGenerationRequest}}.
> As documented in
> [https://maven.apache.org/archetype/maven-archetype-plugin/advanced-usage.html#post-generation-script]
> the {{ArchetypeGenerationRequest}} object is the primary API for
> customization by a post-generation groovy script. And the changed/removed
> methods were not marked for deprecation. Any archetype released before 3.3.0
> that relied on this class is potentially broken.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-689) Archetype Plugin 3.3.0 introduced incompatibilities
[
https://issues.apache.org/jira/browse/ARCHETYPE-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888769#comment-17888769
]
Slawomir Jaranowski commented on ARCHETYPE-689:
---
[~barchetta] ok, I will waiting for feedback, it is one last issue ... and I
can release 3.2.1 version
> Archetype Plugin 3.3.0 introduced incompatibilities
> ---
>
> Key: ARCHETYPE-689
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-689
> Project: Maven Archetype
> Issue Type: Bug
> Components: Generator, Plugin
>Affects Versions: 3.3.0
>Reporter: Joe DiPol
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.1
>
>
> Archetype Plugin 3.3.0 introduced API incompatibilities that can break
> existing maven archetypes. This is significant because when the plugin is
> invoked by users the version of the plugin is rarely specified. An example of
> such a breakage is [https://github.com/helidon-io/helidon/issues/9305] (where
> all previously shipped versions of our maven archetypes broke).
> The incompatibilities were introduced by
> [https://github.com/apache/maven-archetype/pull/211] and
> [https://github.com/apache/maven-archetype/pull/215]
> Changes that broke our archetypes:
> # The removal of {{ArchetypeGenerationRequest.getProjectBuildingRequest()}}
> # The changing of the return type of
> {{ArchetypeGenerationRequest.getRemoteArtifactRepositories()}} from
> {{List}} to {{List}}
> It also looks like a number of other methods were removed from
> {{ArchetypeGenerationRequest}}.
> As documented in
> [https://maven.apache.org/archetype/maven-archetype-plugin/advanced-usage.html#post-generation-script]
> the {{ArchetypeGenerationRequest}} object is the primary API for
> customization by a post-generation groovy script. And the changed/removed
> methods were not marked for deprecation. Any archetype released before 3.3.0
> that relied on this class is potentially broken.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8058) Allow variables defined in .mvn/maven.config used as constants
[
https://issues.apache.org/jira/browse/MNG-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888775#comment-17888775
]
Stefan Bischof commented on MNG-8058:
-
does this now work with the change:
https://issues.apache.org/jira/browse/MNG-8230
https://github.com/apache/maven/pull/1710
> Allow variables defined in .mvn/maven.config used as constants
> --
>
> Key: MNG-8058
> URL: https://issues.apache.org/jira/browse/MNG-8058
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.9.6, 4.0.0-alpha-12
>Reporter: Stefan Bischof
>Priority: Major
>
> I would like to have all variables defined in .mvn/maven.config to be allowed
> as constants.
> My setup uses different versions on each module but i want to define them
> central.
> in my `.mvn/maven.config` file I define the variables
>
> {code:java}
> -Drevision.org.aaa.bbb=0.0.1-SNAPSHOT
> -Drevision.org.aaa.bbb.ccc=0.0.2-SNAPSHOT
> -Drevision.org.aaa.bbb.ddd=0.0.3-SNAPSHOT {code}
>
> In my pom i want to use this variables to set version of perant ans artifact
> itsselfe
> {code:java}
>
> org.aaa
> org.aaa.bbb
> ${revision.org.aaa.bbb}
>
> org.aaa.bbb.ccc
> ${revision.org.aaa.bbb.ccc} {code}
> I am getting the warning
>
> {code:java}
> 'version' contains an expression but should be a constant. {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Use same repository that maven, allow access to central [maven-integration-testing]
gnodet opened a new pull request, #385: URL: https://github.com/apache/maven-integration-testing/pull/385 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-java from 1.2.0 to 1.3.0 [maven-compiler-plugin]
dependabot[bot] commented on PR #263: URL: https://github.com/apache/maven-compiler-plugin/pull/263#issuecomment-2408071764 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-java from 1.2.0 to 1.3.0 [maven-compiler-plugin]
slachiewicz commented on PR #263: URL: https://github.com/apache/maven-compiler-plugin/pull/263#issuecomment-2408071698 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump slf4j.version from 1.7.36 to 2.0.0 [maven-mvnd]
slachiewicz closed pull request #1161: Bump slf4j.version from 1.7.36 to 2.0.0 URL: https://github.com/apache/maven-mvnd/pull/1161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.10.0 to 3.10.1 [maven-mvnd]
slachiewicz merged PR #1162: URL: https://github.com/apache/maven-mvnd/pull/1162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump slf4j.version from 1.7.36 to 2.0.0 [maven-mvnd]
dependabot[bot] commented on PR #1161: URL: https://github.com/apache/maven-mvnd/pull/1161#issuecomment-2408083991 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.0 [maven-artifact-plugin]
slachiewicz closed pull request #56: Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.0 URL: https://github.com/apache/maven-artifact-plugin/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.0 [maven-artifact-plugin]
dependabot[bot] commented on PR #56: URL: https://github.com/apache/maven-artifact-plugin/pull/56#issuecomment-2408088264 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-105) Classes processed by the relocator still have references to the original classes in their constant pools
[ https://issues.apache.org/jira/browse/MSHADE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888766#comment-17888766 ] ASF GitHub Bot commented on MSHADE-105: --- slachiewicz merged PR #241: URL: https://github.com/apache/maven-shade-plugin/pull/241 > Classes processed by the relocator still have references to the original > classes in their constant pools > > > Key: MSHADE-105 > URL: https://issues.apache.org/jira/browse/MSHADE-105 > Project: Maven Shade Plugin > Issue Type: Bug >Affects Versions: 1.4 >Reporter: Andreas Veithen >Assignee: Olivier Lamy >Priority: Minor > Fix For: 1.6 > > Attachments: constant-pool.patch, javap.txt, javap2.txt, > mshade-105-test.zip > > > DefaultShader uses the ClassWriter(ClassReader, int) constructor instead of > ClassWriter(int). According to the ASM Javadoc, this has the following > effects: > "- The constant pool from the original class is copied as is in the new > class, which saves time. New constant pool entries will be added at the end > if necessary, but unused constant pool entries won't be removed. > - Methods that are not transformed are copied as is in the new class, > directly from the original class bytecode (i.e. without emitting visit events > for all the method instructions), which saves a lot of time. Untransformed > methods are detected by the fact that the ClassReader receives MethodVisitor > objects that come from a ClassWriter (and not from a custom ClassAdapter or > any other ClassVisitor instance)." > The second item is actually not applicable in the case of DefaultShader > because the entire class needs to be transformed anyway. On the other hand, > the first item implies that the constant pool of the transformed class will > still have references to the original classes. This can be seen from the > attached "javap.txt" file (produced by javap on a class relocated by > maven-shade-plugin): the relocation adds new entries at the end of the > constant pool, but the original entries are still present. > Since the original entries are no longer referenced anywhere in the class, > this has no consequences at runtime. However, some tools such as Felix' > maven-bundle-plugin use the constant pool to determine the dependencies of a > class. The effect is that if such a shaded JAR is embedded into a bundle > using maven-bundle-plugin, it will generate spurious Import-Package > instructions referring to the original package names. An example of this is > described in AXIS2-5145. > The solution to this problem is simply not to pass the ClassReader object to > the ClassWriter constructor. With this change, the constant pool is properly > cleaned up (see the attached "javap2.txt" file). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump commons-io:commons-io from 2.13.0 to 2.14.0 in /src/it/projects/MSHADE-105/shaded-jar [maven-shade-plugin]
slachiewicz merged PR #241: URL: https://github.com/apache/maven-shade-plugin/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.junit.jupiter:junit-jupiter from 5.11.0 to 5.11.2 [maven-verifier]
slachiewicz merged PR #99: URL: https://github.com/apache/maven-verifier/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.slf4j:slf4j-nop from 1.7.36 to 2.0.0 [maven-resolver-ant-tasks]
slachiewicz closed pull request #45: Bump org.slf4j:slf4j-nop from 1.7.36 to 2.0.0 URL: https://github.com/apache/maven-resolver-ant-tasks/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.slf4j:slf4j-nop from 1.7.36 to 2.0.0 [maven-resolver-ant-tasks]
dependabot[bot] commented on PR #45: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/45#issuecomment-2408093987 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove unecessary test dependency on plexus-container-default [maven-checkstyle-plugin]
slachiewicz merged PR #148: URL: https://github.com/apache/maven-checkstyle-plugin/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.junit.jupiter:junit-jupiter-api from 5.10.2 to 5.11.0 [maven-install-plugin]
slachiewicz merged PR #82: URL: https://github.com/apache/maven-install-plugin/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.5 to 2.14.0 [maven-linkcheck-plugin]
slachiewicz merged PR #5: URL: https://github.com/apache/maven-linkcheck-plugin/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8297) Color output no longer possible on dumb terminals
[ https://issues.apache.org/jira/browse/MNG-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888665#comment-17888665 ] Stefan Oehme commented on MNG-8297: --- Yep, adding both system properties brings color back. It does feel a bit clunky though :) > Color output no longer possible on dumb terminals > - > > Key: MNG-8297 > URL: https://issues.apache.org/jira/browse/MNG-8297 > Project: Maven > Issue Type: Bug > Components: Logging >Affects Versions: 4.0.x-candidate >Reporter: Stefan Oehme >Assignee: Guillaume Nodet >Priority: Major > > We have a couple of integration tests for how our tool captures Maven console > output, including color. These tests capture Maven's output in a > ByteArrayOutputStream, which results in a "dumb terminal". With Maven 3.x, we > still get color output. With the latest 4.x nightlies, the output is no > longer colored. I dug through the code a bit and it seems to be related to > the change to JLine. I tried adding `-Djansi.mode=force` to the MAVEN_OPTS, > but that didn't bring coloring back. > You can try this yourself by doing `export TERM=dumb`, followed by any Maven > command. The output is uncolored, even though Maven itself says `Message > scheme: color` > To be clear, I think having no color on dumb terminals is the correct > default, but there should be a switch to bring it back for testing purposes. > If there already is, please let me know how. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Improve logging [maven-mvnd]
gnodet opened a new pull request, #1164: URL: https://github.com/apache/maven-mvnd/pull/1164 - **Maven Daemon CLIng** - **Fix chicken-and-egg situation** - **Use own parser** - **Fix types** - **Dont forget the cwd!** - **Use deployed version** - **Add daemon options.** - **Follow rename** - **Do not fiddle with propeties, LookupInvoker does** - **Logger, extensions, extClasspath support** - **More adoptions** - **Updates** - **Daemon does NOT get --raw-streams** - **Up the help plugin** - **Remove mrm plugin, remove test repeats** - **Fix exlusions** - **Properly align versions tied to Maven (and group them)** - **To not generate waste** - **Some cleanup** - **HACK: This is EXPERIMENT, must not enter merge!** - **Fix logs** - **More log fixes, native were missed** - **Revert "HACK: This is EXPERIMENT, must not enter merge!"** - **Improve log (wip)** - **wip2** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSCMPUB-70) Remove include/exclude parameters
[
https://issues.apache.org/jira/browse/MSCMPUB-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed MSCMPUB-70.
--
Fix Version/s: 3.3.1
Resolution: Fixed
Fixed in
https://github.com/apache/maven-scm-publish-plugin/commit/07d07f25e898d0d5b2d11fe4e729985e95d58952.
> Remove include/exclude parameters
> -
>
> Key: MSCMPUB-70
> URL: https://issues.apache.org/jira/browse/MSCMPUB-70
> Project: Maven SCM Publish Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.3.1
>
>
> The {{publish-scm}} goal has an
> 1. {{includes}}
> (https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L152)
> and
> 2. {{excludes}}
> (https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L146)
> parameter which are passed as {{FileSet}}
> (https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L381)
> to either
> {{ScmProvider.checkout(...)}} or {{ScmProvider.update(...)}}.
> I have quickly checked the implementation of SVN and Git and it seems that
> only the basedir of the {{ScmFileSet}} is ever considered for checkout and
> update.
> For the actual commit (delete, add or update) they are not used at all.
> So to me it seems that those parameters never have any effect and should be
> removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSCMPUB-70] Remove irrelevant includes & excludes parameters [maven-scm-publish-plugin]
kwin merged PR #46: URL: https://github.com/apache/maven-scm-publish-plugin/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSCMPUB-70) Remove include/exclude parameters
[
https://issues.apache.org/jira/browse/MSCMPUB-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888687#comment-17888687
]
ASF GitHub Bot commented on MSCMPUB-70:
---
kwin merged PR #46:
URL: https://github.com/apache/maven-scm-publish-plugin/pull/46
> Remove include/exclude parameters
> -
>
> Key: MSCMPUB-70
> URL: https://issues.apache.org/jira/browse/MSCMPUB-70
> Project: Maven SCM Publish Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> The {{publish-scm}} goal has an
> 1. {{includes}}
> (https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L152)
> and
> 2. {{excludes}}
> (https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L146)
> parameter which are passed as {{FileSet}}
> (https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L381)
> to either
> {{ScmProvider.checkout(...)}} or {{ScmProvider.update(...)}}.
> I have quickly checked the implementation of SVN and Git and it seems that
> only the basedir of the {{ScmFileSet}} is ever considered for checkout and
> update.
> For the actual commit (delete, add or update) they are not used at all.
> So to me it seems that those parameters never have any effect and should be
> removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
