Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
michael-o commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2157527964 I have done some further testing. Good news: [DOXIASITETOOLS-303](https://issues.apache.org/jira/browse/DOXIASITETOOLS-303) seems to be solved by this. Bad news: It does not work the way advertised. I have in my `settings.xml`: * central-mirror * lda-public (serves only com.example, rest is blocked with 403) * dynamowerk-public tried: ``` osipovmi@deblndw011x:~/var/Projekte/maven-site (master *=) $ git diff -U0 diff --git a/pom.xml b/pom.xml index 66e7e5bc..556fb363 100644 --- a/pom.xml +++ b/pom.xml @@ -77 +77 @@ -2.0.0-M6 +1.12.0 ``` ran: ``` osipovmi@deblndw011x:~/var/Projekte/maven-site (master *=) $ JAVA_VERSION=17 /tmp/apache-maven-4.0.0-beta-4-SNAPSHOT/bin/mvn clean site -Dmaven.repo.local=/var/tmp/repo-site2 ... [INFO] -- [INFO] BUILD FAILURE [INFO] -- [INFO] Total time: 1.580 s [INFO] Finished at: 2024-06-10T09:18:14+02:00 [INFO] -- [ERROR] Failed to execute goal on project maven-site: Could not collect dependencies for project org.apache.maven:maven-site:jar:1.0 [ERROR] Failed to read artifact descriptor for org.jsoup:jsoup:jar:1.17.3 [ERROR] Caused by: The following artifacts could not be resolved: org.jsoup:jsoup:pom:1.17.3 (absent): Could not transfer artifact org.jsoup:jsoup:pom:1.17.3 from/to lda-public (https://.../lda-public/): HTTP Status: 403 [ERROR] ``` Is it what you expect? I would expect to try all four repos. It is trying: ``` Downloading from lda-public: https://.../nexus/content/groups/lda-public/org/jsoup/jsoup/1.17.3/jsoup-1.17.3.pom Downloading from dynamowerk-public: https://.../nexus/content/groups/dynamowerk-public/org/jsoup/jsoup/1.17.3/jsoup-1.17.3.pom Downloading from apache.staging: https://repository.apache.org/content/repositories/maven-1906/org/jsoup/jsoup/1.17.3/jsoup-1.17.3.pom Downloading from central-mirror: https://.../nexus/content/repositories/central/org/jsoup/jsoup/1.17.3/jsoup-1.17.3.pom ``` so does `jsoup-1.17.3.pom.lastUpdated`: ``` #NOTE: This is a Maven Resolver internal implementation file, its format can be changed without prior notice. #Mon Jun 10 09:19:48 CEST 2024 https\://.../nexus/content/groups/dynamowerk-public/.lastUpdated=1718003988205 https\://.../nexus/content/repositories/central/.error= https\://repository.apache.org/content/repositories/maven-1906/.error= https\://.../nexus/content/groups/lda-public/.error=Could not transfer artifact org.jsoup\:jsoup\:pom\:1.17.3 from/to lda-public (https\://.../nexus/content/gr oups/lda-public/)\: HTTP Status\: 403 https\://.../nexus/content/groups/dynamowerk-public/.error= https\://repository.apache.org/content/repositories/maven-1906/.lastUpdated=1718003988246 02b43e8beafaf18c207565d70bf0dc68eea2ac76@default-lda-public-https\://.../nexus/content/groups/lda-public/.lastUpdated=1718003988184 https\://.../nexus/content/repositories/central/.lastUpdated=1718003988342 ``` Thoughts? The issue can be easily recreated by setting up web sever denying all requests with 403. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853569#comment-17853569
]
ASF GitHub Bot commented on MNG-7758:
-
michael-o commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2157527964
I have done some further testing. Good news:
[DOXIASITETOOLS-303](https://issues.apache.org/jira/browse/DOXIASITETOOLS-303)
seems to be solved by this. Bad news: It does not work the way advertised. I
have in my `settings.xml`:
* central-mirror
* lda-public (serves only com.example, rest is blocked with 403)
* dynamowerk-public
tried:
```
osipovmi@deblndw011x:~/var/Projekte/maven-site (master *=)
$ git diff -U0
diff --git a/pom.xml b/pom.xml
index 66e7e5bc..556fb363 100644
-
> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your POM
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three
> exceptions:
> - {{TransferException}} with nested {{AuthorizationException}},
> - {{ArtifactNotFoundException}},
> - {{ArtifactNotFoundException}}.
> {{ArtifactResolutionException#getCause()}} will be populated with the
> {{TransferException}} so will
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first
> exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will
> do {{if (e.getCause() instanceof ArtifactNotFoundException)}} which is
> deceiving.
> Here is a sample for a non-existing artifact:
> {noformat}
> [INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @
> mskins-222 ---
> [INFO] Configuring report plugin
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
> [WARNING] index report is declared twice in default reportSet
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2:
> index, summary, dependency-info, modules, team, scm, issue-management,
> mailing-lists, dependency-management, dependencies, dependency-convergence,
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site for default locale
> Downloading from lda-public:
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.214 s
> [INFO] Finished at: 2023-04-02T12:51:02+02:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site
> (default-site) on project mskins-222: SiteToolException: The site descriptor
> cannot be resolved from the repository: Unable to locate site descriptor:
> Could not transfer artifact org.apache:apache:xml:site:29 from/to lda-public
> (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/):
> authorization failed for
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
> status: 403 Forbidden -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> for a dependency:
> {noformat}
> [INFO] org.apache.maven.cli.event.ExecutionEventLogger
Re: [PR] Bump org.codehaus.plexus:plexus-interpolation from 1.26 to 1.27 [maven-release]
michael-o commented on PR #206: URL: https://github.com/apache/maven-release/pull/206#issuecomment-2157667721 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.2 to 1.3 [maven-release]
michael-o commented on PR #210: URL: https://github.com/apache/maven-release/pull/210#issuecomment-2157667922 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump scmVersion from 2.0.1 to 2.1.0 [maven-release]
michael-o commented on PR #213: URL: https://github.com/apache/maven-release/pull/213#issuecomment-2157668150 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven-release]
michael-o commented on PR #214: URL: https://github.com/apache/maven-release/pull/214#issuecomment-2157668474 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8141] Model Builder report issues during build [maven]
cstamas commented on PR #1569: URL: https://github.com/apache/maven/pull/1569#issuecomment-2157674604 Reproducer looks like this: https://gist.github.com/cstamas/14db1a530cb5c2d705ee95554b882c97 In DEBUG messages are: https://gist.github.com/cstamas/e2d32d1ca9702d49785e2e36c34556b3 (which surprised me, as they exactly pinpoint the problems at file line level, unlike 3.9.x) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853579#comment-17853579 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1569: URL: https://github.com/apache/maven/pull/1569#issuecomment-2157674604 Reproducer looks like this: https://gist.github.com/cstamas/14db1a530cb5c2d705ee95554b882c97 In DEBUG messages are: https://gist.github.com/cstamas/e2d32d1ca9702d49785e2e36c34556b3 (which surprised me, as they exactly pinpoint the problems at file line level, unlike 3.9.x) > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8141] Model Builder report issues during build [maven]
cstamas commented on code in PR #1569: URL: https://github.com/apache/maven/pull/1569#discussion_r1632812563 ## maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java: ## @@ -816,6 +817,15 @@ private Model readEffectiveModel( // profile activation profileActivationContext.setProjectProperties(modelv4.getProperties()); +// profile check +HashSet profileIds = new HashSet<>(); Review Comment: I like these changes (having _validation in validator_), so am tempted to introduce this change in 3.9 line as well... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853581#comment-17853581 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on code in PR #1569: URL: https://github.com/apache/maven/pull/1569#discussion_r1632812563 ## maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java: ## @@ -816,6 +817,15 @@ private Model readEffectiveModel( // profile activation profileActivationContext.setProjectProperties(modelv4.getProperties()); +// profile check +HashSet profileIds = new HashSet<>(); Review Comment: I like these changes (having _validation in validator_), so am tempted to introduce this change in 3.9 line as well... > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2157707829
> The change to "Forbid the possibility to extract/restore data in a
directory outside the project" is a breaking change for some of my projects.
>
> In my case, I have several multi-module projects with child POMs
configured to use ../target/${project.artifactId} as their build directory in
order to have a single target dir in the parent rather than N children target
directories.
>
> Would you consider adding an opt-out option ? @kbuntrock
Hello @julien-pcd
I'm sorry to ear that. I see 3 options :
1. An opt-out parameter allowing to disable the security
2. A configuration parameter allowing a specific path for extract/restore.
By default it is `project.basedir` (the current hardcoded value)
3. Automatic detection of a wider allowed extract/restore area, based on
parents location resolution. But since you can specify relative path for
parents, I'm expecting a lot of edge cases.
My favourite solution is by far the number 2.
Could I have your opinion @AlexanderAshitkin and @olamy ?
And I wish a good day yo all of you! 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[
https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853585#comment-17853585
]
ASF GitHub Bot commented on MBUILDCACHE-86:
---
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2157707829
> The change to "Forbid the possibility to extract/restore data in a
directory outside the project" is a breaking change for some of my projects.
>
> In my case, I have several multi-module projects with child POMs
configured to use ../target/${project.artifactId} as their build directory in
order to have a single target dir in the parent rather than N children target
directories.
>
> Would you consider adding an opt-out option ? @kbuntrock
Hello @julien-pcd
I'm sorry to ear that. I see 3 options :
1. An opt-out parameter allowing to disable the security
2. A configuration parameter allowing a specific path for extract/restore.
By default it is `project.basedir` (the current hardcoded value)
3. Automatic detection of a wider allowed extract/restore area, based on
parents location resolution. But since you can specify relative path for
parents, I'm expecting a lot of edge cases.
My favourite solution is by far the number 2.
Could I have your opinion @AlexanderAshitkin and @olamy ?
And I wish a good day yo all of you! 😊
> Bugfix and enhancements with the restoration of outputs on disk
> ---
>
> Key: MBUILDCACHE-86
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86
> Project: Maven Build Cache Extension
> Issue Type: Improvement
>Reporter: Kevin Buntrock
>Assignee: Olivier Lamy
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.2.0
>
>
> *Fixes :*
> * Files containing an underscore in their name can't be restored in the
> cache directory correctly (not in the same directory location).
> * The cache is able to extract/restore files in locations outside the
> project. I guess the extraction part is not a vulnerability since someone
> with commit permissions can guess other ways to extract data. But the
> possibility of restoring at any place on the disk looks pretty dangerous to
> me if a remote cache server is compromised.
> *Enhancements :*
> * Possibility to restore artefacts on disk, with a dedicated property :
> maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the
> project directory, as opposed to the cache directory.
> ** IDE integration and use of the cache locally in developement is way
> easier. It is now possible to retrieve a cached jar in the "target" directory.
> * Introduce "globs" to filter extra attached outputs by filenames.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0 [maven-release]
michael-o commented on PR #215: URL: https://github.com/apache/maven-release/pull/215#issuecomment-2157721261 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7194) PluginParameterExpressionEvaluator incorrectly interpolates unknown subexpression
[
https://issues.apache.org/jira/browse/MNG-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853591#comment-17853591
]
ASF GitHub Bot commented on MNG-7194:
-
pzygielo opened a new pull request, #1570:
URL: https://github.com/apache/maven/pull/1570
(no comment)
> PluginParameterExpressionEvaluator incorrectly interpolates unknown
> subexpression
> -
>
> Key: MNG-7194
> URL: https://issues.apache.org/jira/browse/MNG-7194
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Reporter: Robert Scholte
>Priority: Minor
>
> The PluginParameterExpressionEvaluator evaluate(String,Class)-method ends
> like this:
> {code:java}
> if ( value instanceof String )
> {
> // TODO: without #, this could just be an evaluate call...
> String val = (String) value;
> int exprStartDelimiter = val.indexOf( "${" );
> if ( exprStartDelimiter >= 0 )
> {
> if ( exprStartDelimiter > 0 )
> {
> value = val.substring( 0, exprStartDelimiter ) +
> evaluate( val.substring( exprStartDelimiter ) );
> }
> else
> {
> value = evaluate( val.substring( exprStartDelimiter ) );
> }
> }
> }
> {code}
> Assume that pre${unknown} needs to be evaluated and {{unknown}} does not
> exist, the result well be "{{prenull}}"
> Just ${unknown} evaluates to null, but because there's no String concat it
> will be a real null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7194) PluginParameterExpressionEvaluator incorrectly interpolates unknown subexpression
[
https://issues.apache.org/jira/browse/MNG-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853592#comment-17853592
]
ASF GitHub Bot commented on MNG-7194:
-
pzygielo opened a new pull request, #1571:
URL: https://github.com/apache/maven/pull/1571
Builds on top of
- #1570
> PluginParameterExpressionEvaluator incorrectly interpolates unknown
> subexpression
> -
>
> Key: MNG-7194
> URL: https://issues.apache.org/jira/browse/MNG-7194
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Reporter: Robert Scholte
>Priority: Minor
>
> The PluginParameterExpressionEvaluator evaluate(String,Class)-method ends
> like this:
> {code:java}
> if ( value instanceof String )
> {
> // TODO: without #, this could just be an evaluate call...
> String val = (String) value;
> int exprStartDelimiter = val.indexOf( "${" );
> if ( exprStartDelimiter >= 0 )
> {
> if ( exprStartDelimiter > 0 )
> {
> value = val.substring( 0, exprStartDelimiter ) +
> evaluate( val.substring( exprStartDelimiter ) );
> }
> else
> {
> value = evaluate( val.substring( exprStartDelimiter ) );
> }
> }
> }
> {code}
> Assume that pre${unknown} needs to be evaluated and {{unknown}} does not
> exist, the result well be "{{prenull}}"
> Just ${unknown} evaluates to null, but because there's no String concat it
> will be a real null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-942) Deprecate the get goal
[
https://issues.apache.org/jira/browse/MDEP-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853594#comment-17853594
]
Slawomir Jaranowski commented on MDEP-942:
--
3.7.0 is ok
We should think more about this issue looks like more work will be needed
> Deprecate the get goal
> --
>
> Key: MDEP-942
> URL: https://issues.apache.org/jira/browse/MDEP-942
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> It looks like goal {{get}} is not usable or can be misunderstood
> - there is no {{destination}} parameter MDEP-395, MDEP-495
> But mentioned goal {{copy}}
> - doesn't have a possibility to copy transitive dependencies
> - doesn't support additional remote repositories
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8031] Backport concurrent friendly transport listener [maven]
pshevche commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1632930409
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 3.9.7
+ */
+public final class SimplexTransferListener extends AbstractTransferListener {
+private static final Logger LOGGER =
LoggerFactory.getLogger(SimplexTransferListener.class);
+private static final int QUEUE_SIZE = 1024;
+private static final int BATCH_MAX_SIZE = 500;
+private final TransferListener delegate;
+private final int batchMaxSize;
+private final boolean blockOnLastEvent;
+private final ArrayBlockingQueue eventQueue;
+
+/**
+ * Constructor that makes passed in delegate run on single thread, and
will block on last event.
+ */
+public SimplexTransferListener(TransferListener delegate) {
+this(delegate, QUEUE_SIZE, BATCH_MAX_SIZE, true);
+}
+
+/**
+ * Constructor that may alter behaviour of this listener.
+ *
+ * @param delegate The delegate that should run on single thread.
+ * @param queueSize The event queue size (default {@code 1024}).
+ * @param batchMaxSize The maximum batch size delegate should receive
(default {@code 500}).
+ * @param blockOnLastEvent Should this listener block on last transfer end
(completed or corrupted) block? (default {@code true}).
+ */
+public SimplexTransferListener(
+TransferListener delegate, int queueSize, int batchMaxSize,
boolean blockOnLastEvent) {
+this.delegate = requireNonNull(delegate);
+if (queueSize < 1 || batchMaxSize < 1) {
+throw new IllegalArgumentException("Queue and batch sizes must be
greater than 1");
+}
+this.batchMaxSize = batchMaxSize;
+this.blockOnLastEvent = blockOnLastEvent;
+
+this.eventQueue = new ArrayBlockingQueue<>(queueSize);
+Thread updater = new Thread(this::feedConsumer);
+updater.setDaemon(true);
+updater.start();
+}
+
+public TransferListener getDelegate() {
+return delegate;
+}
+
+private void feedConsumer() {
+final ArrayList batch = new ArrayList<>(batchMaxSize);
+try {
+while (true) {
+batch.clear();
+if (eventQueue.drainTo(batch, BATCH_MAX_SIZE) == 0) {
+batch.add(eventQueue.take());
+}
+demux(batch);
+}
+} catch (InterruptedException e) {
+throw new RuntimeException(e);
+}
+}
+
+private void demux(List exchanges) {
+for (Exchange exchange : exchanges) {
+exchange.process(transferEvent -> {
+TransferEvent.EventType type = transferEvent.getType();
+try {
+switch (type) {
+case INITIATED:
+delegate.transferInitiated(transferEvent);
+break;
+case STARTED:
+delegate.transferStarted(transferEvent);
[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[
https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853595#comment-17853595
]
ASF GitHub Bot commented on MNG-8031:
-
pshevche commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1632930409
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 3.9.7
+ */
+public final class SimplexTransferListener extends AbstractTransferListener {
+private static final Logger LOGGER =
LoggerFactory.getLogger(SimplexTransferListener.class);
+private static final int QUEUE_SIZE = 1024;
+private static final int BATCH_MAX_SIZE = 500;
+private final TransferListener delegate;
+private final int batchMaxSize;
+private final boolean blockOnLastEvent;
+private final ArrayBlockingQueue eventQueue;
+
+/**
+ * Constructor that makes passed in delegate run on single thread, and
will block on last event.
+ */
+public SimplexTransferListener(TransferListener delegate) {
+this(delegate, QUEUE_SIZE, BATCH_MAX_SIZE, true);
+}
+
+/**
+ * Constructor that may alter behaviour of this listener.
+ *
+ * @param delegate The delegate that should run on single thread.
+ * @param queueSize The event queue size (default {@code 1024}).
+ * @param batchMaxSize The maximum batch size delegate should receive
(default {@code 500}).
+ * @param blockOnLastEvent Should this listener block on last transfer end
(completed or corrupted) block? (default {@code true}).
+ */
+public SimplexTransferListener(
+TransferListener delegate, int queueSize, int batchMaxSize,
boolean blockOnLastEvent) {
+this.delegate = requireNonNull(delegate);
+if (queueSize < 1 || batchMaxSize < 1) {
+throw new IllegalArgumentException("Queue and batch sizes must be
greater than 1");
+}
+this.batchMaxSize = batchMaxSize;
+this.blockOnLastEvent = blockOnLastEvent;
+
+this.eventQueue = new ArrayBlockingQueue<>(queueSize);
+Thread updater = new Thread(this::feedConsumer);
+updater.setDaemon(true);
+updater.start();
+}
+
+public TransferListener getDelegate() {
+return delegate;
+}
+
+private void feedConsumer() {
+final ArrayList batch = new ArrayList<>(batchMaxSize);
+try {
+while (true) {
+batch.clear();
+if (eventQueue.drainTo(batch, BATCH_MAX_SIZE) == 0) {
+batch.add(eventQueue.take());
+}
+demux(batch);
+}
+} catch (InterruptedException e) {
+throw new RuntimeException(e);
+}
+}
+
+private void demux(List exchanges) {
+for (Exchange exchange : exchanges) {
+exchange.process(transferEvent -> {
+TransferEvent.EventType type = transferEvent.getType();
+try {
+switch (type) {
+
Re: [PR] [MNG-8031] Backport concurrent friendly transport listener [maven]
cstamas commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1632962644
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 3.9.7
+ */
+public final class SimplexTransferListener extends AbstractTransferListener {
+private static final Logger LOGGER =
LoggerFactory.getLogger(SimplexTransferListener.class);
+private static final int QUEUE_SIZE = 1024;
+private static final int BATCH_MAX_SIZE = 500;
+private final TransferListener delegate;
+private final int batchMaxSize;
+private final boolean blockOnLastEvent;
+private final ArrayBlockingQueue eventQueue;
+
+/**
+ * Constructor that makes passed in delegate run on single thread, and
will block on last event.
+ */
+public SimplexTransferListener(TransferListener delegate) {
+this(delegate, QUEUE_SIZE, BATCH_MAX_SIZE, true);
+}
+
+/**
+ * Constructor that may alter behaviour of this listener.
+ *
+ * @param delegate The delegate that should run on single thread.
+ * @param queueSize The event queue size (default {@code 1024}).
+ * @param batchMaxSize The maximum batch size delegate should receive
(default {@code 500}).
+ * @param blockOnLastEvent Should this listener block on last transfer end
(completed or corrupted) block? (default {@code true}).
+ */
+public SimplexTransferListener(
+TransferListener delegate, int queueSize, int batchMaxSize,
boolean blockOnLastEvent) {
+this.delegate = requireNonNull(delegate);
+if (queueSize < 1 || batchMaxSize < 1) {
+throw new IllegalArgumentException("Queue and batch sizes must be
greater than 1");
+}
+this.batchMaxSize = batchMaxSize;
+this.blockOnLastEvent = blockOnLastEvent;
+
+this.eventQueue = new ArrayBlockingQueue<>(queueSize);
+Thread updater = new Thread(this::feedConsumer);
+updater.setDaemon(true);
+updater.start();
+}
+
+public TransferListener getDelegate() {
+return delegate;
+}
+
+private void feedConsumer() {
+final ArrayList batch = new ArrayList<>(batchMaxSize);
+try {
+while (true) {
+batch.clear();
+if (eventQueue.drainTo(batch, BATCH_MAX_SIZE) == 0) {
+batch.add(eventQueue.take());
+}
+demux(batch);
+}
+} catch (InterruptedException e) {
+throw new RuntimeException(e);
+}
+}
+
+private void demux(List exchanges) {
+for (Exchange exchange : exchanges) {
+exchange.process(transferEvent -> {
+TransferEvent.EventType type = transferEvent.getType();
+try {
+switch (type) {
+case INITIATED:
+delegate.transferInitiated(transferEvent);
+break;
+case STARTED:
+delegate.transferStarted(transferEvent);
+
Re: [PR] [MNG-7194] Change expectation for missing property evaluation [maven]
pzygielo commented on PR #1571: URL: https://github.com/apache/maven/pull/1571#issuecomment-2157869928 The failure of modified test (https://github.com/apache/maven/actions/runs/9445675139/job/26014692434?pr=1571#step:5:1428) is _expected_ with current implementation. However the current implementation is not expected by me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7194) PluginParameterExpressionEvaluator incorrectly interpolates unknown subexpression
[
https://issues.apache.org/jira/browse/MNG-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853597#comment-17853597
]
ASF GitHub Bot commented on MNG-7194:
-
pzygielo commented on PR #1571:
URL: https://github.com/apache/maven/pull/1571#issuecomment-2157869928
The failure of modified test
(https://github.com/apache/maven/actions/runs/9445675139/job/26014692434?pr=1571#step:5:1428)
is _expected_ with current implementation.
However the current implementation is not expected by me.
> PluginParameterExpressionEvaluator incorrectly interpolates unknown
> subexpression
> -
>
> Key: MNG-7194
> URL: https://issues.apache.org/jira/browse/MNG-7194
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Reporter: Robert Scholte
>Priority: Minor
>
> The PluginParameterExpressionEvaluator evaluate(String,Class)-method ends
> like this:
> {code:java}
> if ( value instanceof String )
> {
> // TODO: without #, this could just be an evaluate call...
> String val = (String) value;
> int exprStartDelimiter = val.indexOf( "${" );
> if ( exprStartDelimiter >= 0 )
> {
> if ( exprStartDelimiter > 0 )
> {
> value = val.substring( 0, exprStartDelimiter ) +
> evaluate( val.substring( exprStartDelimiter ) );
> }
> else
> {
> value = evaluate( val.substring( exprStartDelimiter ) );
> }
> }
> }
> {code}
> Assume that pre${unknown} needs to be evaluated and {{unknown}} does not
> exist, the result well be "{{prenull}}"
> Just ${unknown} evaluates to null, but because there's no String concat it
> will be a real null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[
https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853596#comment-17853596
]
ASF GitHub Bot commented on MNG-8031:
-
cstamas commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1632962644
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 3.9.7
+ */
+public final class SimplexTransferListener extends AbstractTransferListener {
+private static final Logger LOGGER =
LoggerFactory.getLogger(SimplexTransferListener.class);
+private static final int QUEUE_SIZE = 1024;
+private static final int BATCH_MAX_SIZE = 500;
+private final TransferListener delegate;
+private final int batchMaxSize;
+private final boolean blockOnLastEvent;
+private final ArrayBlockingQueue eventQueue;
+
+/**
+ * Constructor that makes passed in delegate run on single thread, and
will block on last event.
+ */
+public SimplexTransferListener(TransferListener delegate) {
+this(delegate, QUEUE_SIZE, BATCH_MAX_SIZE, true);
+}
+
+/**
+ * Constructor that may alter behaviour of this listener.
+ *
+ * @param delegate The delegate that should run on single thread.
+ * @param queueSize The event queue size (default {@code 1024}).
+ * @param batchMaxSize The maximum batch size delegate should receive
(default {@code 500}).
+ * @param blockOnLastEvent Should this listener block on last transfer end
(completed or corrupted) block? (default {@code true}).
+ */
+public SimplexTransferListener(
+TransferListener delegate, int queueSize, int batchMaxSize,
boolean blockOnLastEvent) {
+this.delegate = requireNonNull(delegate);
+if (queueSize < 1 || batchMaxSize < 1) {
+throw new IllegalArgumentException("Queue and batch sizes must be
greater than 1");
+}
+this.batchMaxSize = batchMaxSize;
+this.blockOnLastEvent = blockOnLastEvent;
+
+this.eventQueue = new ArrayBlockingQueue<>(queueSize);
+Thread updater = new Thread(this::feedConsumer);
+updater.setDaemon(true);
+updater.start();
+}
+
+public TransferListener getDelegate() {
+return delegate;
+}
+
+private void feedConsumer() {
+final ArrayList batch = new ArrayList<>(batchMaxSize);
+try {
+while (true) {
+batch.clear();
+if (eventQueue.drainTo(batch, BATCH_MAX_SIZE) == 0) {
+batch.add(eventQueue.take());
+}
+demux(batch);
+}
+} catch (InterruptedException e) {
+throw new RuntimeException(e);
+}
+}
+
+private void demux(List exchanges) {
+for (Exchange exchange : exchanges) {
+exchange.process(transferEvent -> {
+TransferEvent.EventType type = transferEvent.getType();
+try {
+switch (type) {
+
[jira] [Created] (MPMD-398) Refresh download page
Slawomir Jaranowski created MPMD-398: Summary: Refresh download page Key: MPMD-398 URL: https://issues.apache.org/jira/browse/MPMD-398 Project: Maven PMD Plugin Issue Type: Task Reporter: Slawomir Jaranowski -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853607#comment-17853607 ] ASF GitHub Bot commented on MNG-8141: - cstamas opened a new pull request, #1572: URL: https://github.com/apache/maven/pull/1572 No (logic) change, merely moved the new code to proper place (validation) to not piggy back onto processing: this is much cleaner. --- https://issues.apache.org/jira/browse/MNG-8141 Inspired by suggestions in master PR https://github.com/apache/maven/pull/1569 > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7194] Test missing property evaluation [maven]
gnodet commented on PR #1570: URL: https://github.com/apache/maven/pull/1570#issuecomment-2158026627 Please target master branch instead, there's not much interest to backport such PR in 3.9.x imho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7194) PluginParameterExpressionEvaluator incorrectly interpolates unknown subexpression
[
https://issues.apache.org/jira/browse/MNG-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853613#comment-17853613
]
ASF GitHub Bot commented on MNG-7194:
-
gnodet commented on PR #1570:
URL: https://github.com/apache/maven/pull/1570#issuecomment-2158026627
Please target master branch instead, there's not much interest to backport
such PR in 3.9.x imho.
> PluginParameterExpressionEvaluator incorrectly interpolates unknown
> subexpression
> -
>
> Key: MNG-7194
> URL: https://issues.apache.org/jira/browse/MNG-7194
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Reporter: Robert Scholte
>Priority: Minor
>
> The PluginParameterExpressionEvaluator evaluate(String,Class)-method ends
> like this:
> {code:java}
> if ( value instanceof String )
> {
> // TODO: without #, this could just be an evaluate call...
> String val = (String) value;
> int exprStartDelimiter = val.indexOf( "${" );
> if ( exprStartDelimiter >= 0 )
> {
> if ( exprStartDelimiter > 0 )
> {
> value = val.substring( 0, exprStartDelimiter ) +
> evaluate( val.substring( exprStartDelimiter ) );
> }
> else
> {
> value = evaluate( val.substring( exprStartDelimiter ) );
> }
> }
> }
> {code}
> Assume that pre${unknown} needs to be evaluated and {{unknown}} does not
> exist, the result well be "{{prenull}}"
> Just ${unknown} evaluates to null, but because there's no String concat it
> will be a real null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8141] Aftermath, and tidy up [maven]
cstamas merged PR #1572: URL: https://github.com/apache/maven/pull/1572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853614#comment-17853614 ] ASF GitHub Bot commented on MNG-8141: - cstamas merged PR #1572: URL: https://github.com/apache/maven/pull/1572 > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSITE-1010) site-deployment for POM projects does not create project folders in site-repository
[
https://issues.apache.org/jira/browse/MSITE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Bünger updated MSITE-1010:
---
Attachment: pom.xml
> site-deployment for POM projects does not create project folders in
> site-repository
> ---
>
> Key: MSITE-1010
> URL: https://issues.apache.org/jira/browse/MSITE-1010
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: site:deploy
>Affects Versions: 3.12.0, 4.0.0-M14
> Environment: Nexus, since at least Maven 3.6.3 (not tested with 3.9.7
> or 4.0.0-beta)
>Reporter: Matthias Bünger
>Priority: Minor
> Fix For: waiting-for-feedback
>
> Attachments: pom.xml
>
>
> I noticed the following issue while updating the plugins in our teams
> META-POM and could backtrack it at least until 3.12 but might be an even
> older issue. Havn't checked 4.0.0-M15 but from the releases notes I doubt it
> is fixed.
> When you do "site-deploy" for a single module or multi module project the
> site files (.html, css-folders, etc.) are stored in the site-repository (we
> have current Nexus version) within a subfolder with the name of the project,
> e.g
> {code}
> / (root of site-repository)
> /- project-A
>/css
>report.html
> /- project-B
>/css
>report.html
> /project-C
> {code}
> If you do the same for a "POM" project (e.g. a META-POM or BOM) the site
> files are all stored at root level (instead of creating a project folder) and
> ofc overwriting the ones from other POM-projects:
> {code}
> / (root of site-repository)
> /css
> /project-A
> /project-B
> /project-C
> report.html
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSITE-1010) site-deployment for POM projects does not create project folders in site-repository
[
https://issues.apache.org/jira/browse/MSITE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853616#comment-17853616
]
Matthias Bünger commented on MSITE-1010:
Added our POM (only replaced name of internal things and URL) which is used by
our single- and multi-module projects. If you site-deploy one of these a
subfolder in the site-repo is created, but if you site-deploy the pom itself it
is not.
> site-deployment for POM projects does not create project folders in
> site-repository
> ---
>
> Key: MSITE-1010
> URL: https://issues.apache.org/jira/browse/MSITE-1010
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: site:deploy
>Affects Versions: 3.12.0, 4.0.0-M14
> Environment: Nexus, since at least Maven 3.6.3 (not tested with 3.9.7
> or 4.0.0-beta)
>Reporter: Matthias Bünger
>Priority: Minor
> Fix For: waiting-for-feedback
>
> Attachments: pom.xml
>
>
> I noticed the following issue while updating the plugins in our teams
> META-POM and could backtrack it at least until 3.12 but might be an even
> older issue. Havn't checked 4.0.0-M15 but from the releases notes I doubt it
> is fixed.
> When you do "site-deploy" for a single module or multi module project the
> site files (.html, css-folders, etc.) are stored in the site-repository (we
> have current Nexus version) within a subfolder with the name of the project,
> e.g
> {code}
> / (root of site-repository)
> /- project-A
>/css
>report.html
> /- project-B
>/css
>report.html
> /project-C
> {code}
> If you do the same for a "POM" project (e.g. a META-POM or BOM) the site
> files are all stored at root level (instead of creating a project folder) and
> ofc overwriting the ones from other POM-projects:
> {code}
> / (root of site-repository)
> /css
> /project-A
> /project-B
> /project-C
> report.html
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8141] Model Builder report issues during build [maven]
cstamas merged PR #1569: URL: https://github.com/apache/maven/pull/1569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853617#comment-17853617 ] ASF GitHub Bot commented on MNG-8141: - cstamas merged PR #1569: URL: https://github.com/apache/maven/pull/1569 > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8141. Resolution: Fixed > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSITE-1010) site-deployment for POM projects does not create project folders in site-repository
[
https://issues.apache.org/jira/browse/MSITE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853620#comment-17853620
]
Michael Osipov commented on MSITE-1010:
---
I see you deploy through WebDAV. Please see whether file-based deployment makes
a difference. Maybe the DAV module is faulty.
> site-deployment for POM projects does not create project folders in
> site-repository
> ---
>
> Key: MSITE-1010
> URL: https://issues.apache.org/jira/browse/MSITE-1010
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: site:deploy
>Affects Versions: 3.12.0, 4.0.0-M14
> Environment: Nexus, since at least Maven 3.6.3 (not tested with 3.9.7
> or 4.0.0-beta)
>Reporter: Matthias Bünger
>Priority: Minor
> Fix For: waiting-for-feedback
>
> Attachments: pom.xml
>
>
> I noticed the following issue while updating the plugins in our teams
> META-POM and could backtrack it at least until 3.12 but might be an even
> older issue. Havn't checked 4.0.0-M15 but from the releases notes I doubt it
> is fixed.
> When you do "site-deploy" for a single module or multi module project the
> site files (.html, css-folders, etc.) are stored in the site-repository (we
> have current Nexus version) within a subfolder with the name of the project,
> e.g
> {code}
> / (root of site-repository)
> /- project-A
>/css
>report.html
> /- project-B
>/css
>report.html
> /project-C
> {code}
> If you do the same for a "POM" project (e.g. a META-POM or BOM) the site
> files are all stored at root level (instead of creating a project folder) and
> ofc overwriting the ones from other POM-projects:
> {code}
> / (root of site-repository)
> /css
> /project-A
> /project-B
> /project-C
> report.html
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MINDEXER-226) Bump lucene.version from 9.10.0 to 9.11.0
Tamas Cservenak created MINDEXER-226: Summary: Bump lucene.version from 9.10.0 to 9.11.0 Key: MINDEXER-226 URL: https://issues.apache.org/jira/browse/MINDEXER-226 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump lucene.version from 9.10.0 to 9.11.0 [maven-indexer]
cstamas merged PR #372: URL: https://github.com/apache/maven-indexer/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINDEXER-226) Bump lucene.version from 9.10.0 to 9.11.0
[ https://issues.apache.org/jira/browse/MINDEXER-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-226. Resolution: Fixed > Bump lucene.version from 9.10.0 to 9.11.0 > - > > Key: MINDEXER-226 > URL: https://issues.apache.org/jira/browse/MINDEXER-226 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINDEXER-227) Bump org.eclipse.sisu:org.eclipse.sisu.inject from 0.9.0.M2 to 0.9.0.M3
Tamas Cservenak created MINDEXER-227: Summary: Bump org.eclipse.sisu:org.eclipse.sisu.inject from 0.9.0.M2 to 0.9.0.M3 Key: MINDEXER-227 URL: https://issues.apache.org/jira/browse/MINDEXER-227 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINDEXER-226) Bump lucene.version from 9.10.0 to 9.11.0
[ https://issues.apache.org/jira/browse/MINDEXER-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-226: Assignee: Tamas Cservenak > Bump lucene.version from 9.10.0 to 9.11.0 > - > > Key: MINDEXER-226 > URL: https://issues.apache.org/jira/browse/MINDEXER-226 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.eclipse.sisu:org.eclipse.sisu.inject from 0.9.0.M2 to 0.9.0.M3 [maven-indexer]
cstamas merged PR #371: URL: https://github.com/apache/maven-indexer/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINDEXER-228) Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre
Tamas Cservenak created MINDEXER-228: Summary: Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre Key: MINDEXER-228 URL: https://issues.apache.org/jira/browse/MINDEXER-228 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre [maven-indexer]
cstamas merged PR #370: URL: https://github.com/apache/maven-indexer/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINDEXER-229) Bump commons-cli:commons-cli from 1.7.0 to 1.8.0
Tamas Cservenak created MINDEXER-229: Summary: Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 Key: MINDEXER-229 URL: https://issues.apache.org/jira/browse/MINDEXER-229 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 [maven-indexer]
cstamas merged PR #368: URL: https://github.com/apache/maven-indexer/pull/368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.gaul:modernizer-maven-plugin from 2.8.0 to 2.9.0 [maven-indexer]
cstamas merged PR #367: URL: https://github.com/apache/maven-indexer/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINDEXER-230) (build) Bump org.gaul:modernizer-maven-plugin from 2.8.0 to 2.9.0
Tamas Cservenak created MINDEXER-230: Summary: (build) Bump org.gaul:modernizer-maven-plugin from 2.8.0 to 2.9.0 Key: MINDEXER-230 URL: https://issues.apache.org/jira/browse/MINDEXER-230 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-229) Bump commons-cli:commons-cli from 1.7.0 to 1.8.0
[ https://issues.apache.org/jira/browse/MINDEXER-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-229. Resolution: Fixed > Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 > > > Key: MINDEXER-229 > URL: https://issues.apache.org/jira/browse/MINDEXER-229 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-228) Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre
[ https://issues.apache.org/jira/browse/MINDEXER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-228. Resolution: Fixed > Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre > - > > Key: MINDEXER-228 > URL: https://issues.apache.org/jira/browse/MINDEXER-228 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINDEXER-229) Bump commons-cli:commons-cli from 1.7.0 to 1.8.0
[ https://issues.apache.org/jira/browse/MINDEXER-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-229: Assignee: Tamas Cservenak > Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 > > > Key: MINDEXER-229 > URL: https://issues.apache.org/jira/browse/MINDEXER-229 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-230) (build) Bump org.gaul:modernizer-maven-plugin from 2.8.0 to 2.9.0
[ https://issues.apache.org/jira/browse/MINDEXER-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-230. Resolution: Fixed > (build) Bump org.gaul:modernizer-maven-plugin from 2.8.0 to 2.9.0 > - > > Key: MINDEXER-230 > URL: https://issues.apache.org/jira/browse/MINDEXER-230 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINDEXER-230) (build) Bump org.gaul:modernizer-maven-plugin from 2.8.0 to 2.9.0
[ https://issues.apache.org/jira/browse/MINDEXER-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-230: Assignee: Tamas Cservenak > (build) Bump org.gaul:modernizer-maven-plugin from 2.8.0 to 2.9.0 > - > > Key: MINDEXER-230 > URL: https://issues.apache.org/jira/browse/MINDEXER-230 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINDEXER-227) Bump org.eclipse.sisu:org.eclipse.sisu.inject from 0.9.0.M2 to 0.9.0.M3
[ https://issues.apache.org/jira/browse/MINDEXER-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-227: Assignee: Tamas Cservenak > Bump org.eclipse.sisu:org.eclipse.sisu.inject from 0.9.0.M2 to 0.9.0.M3 > --- > > Key: MINDEXER-227 > URL: https://issues.apache.org/jira/browse/MINDEXER-227 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINDEXER-228) Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre
[ https://issues.apache.org/jira/browse/MINDEXER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-228: Assignee: Tamas Cservenak > Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre > - > > Key: MINDEXER-228 > URL: https://issues.apache.org/jira/browse/MINDEXER-228 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-227) Bump org.eclipse.sisu:org.eclipse.sisu.inject from 0.9.0.M2 to 0.9.0.M3
[ https://issues.apache.org/jira/browse/MINDEXER-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-227. Resolution: Fixed > Bump org.eclipse.sisu:org.eclipse.sisu.inject from 0.9.0.M2 to 0.9.0.M3 > --- > > Key: MINDEXER-227 > URL: https://issues.apache.org/jira/browse/MINDEXER-227 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSITE-1010) site-deployment for POM projects does not create project folders in site-repository
[
https://issues.apache.org/jira/browse/MSITE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853621#comment-17853621
]
Matthias Bünger commented on MSITE-1010:
I already tried to get rid of the WebDAV (as Karl-Heinz said it should be not
needed anymore), but the nexus site-deploy worked only with that. See txt file
with my tries and errors
> site-deployment for POM projects does not create project folders in
> site-repository
> ---
>
> Key: MSITE-1010
> URL: https://issues.apache.org/jira/browse/MSITE-1010
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: site:deploy
>Affects Versions: 3.12.0, 4.0.0-M14
> Environment: Nexus, since at least Maven 3.6.3 (not tested with 3.9.7
> or 4.0.0-beta)
>Reporter: Matthias Bünger
>Priority: Minor
> Fix For: waiting-for-feedback
>
> Attachments: pom.xml, webdav.txt
>
>
> I noticed the following issue while updating the plugins in our teams
> META-POM and could backtrack it at least until 3.12 but might be an even
> older issue. Havn't checked 4.0.0-M15 but from the releases notes I doubt it
> is fixed.
> When you do "site-deploy" for a single module or multi module project the
> site files (.html, css-folders, etc.) are stored in the site-repository (we
> have current Nexus version) within a subfolder with the name of the project,
> e.g
> {code}
> / (root of site-repository)
> /- project-A
>/css
>report.html
> /- project-B
>/css
>report.html
> /project-C
> {code}
> If you do the same for a "POM" project (e.g. a META-POM or BOM) the site
> files are all stored at root level (instead of creating a project folder) and
> ofc overwriting the ones from other POM-projects:
> {code}
> / (root of site-repository)
> /css
> /project-A
> /project-B
> /project-C
> report.html
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSITE-1010) site-deployment for POM projects does not create project folders in site-repository
[
https://issues.apache.org/jira/browse/MSITE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Bünger updated MSITE-1010:
---
Attachment: webdav.txt
> site-deployment for POM projects does not create project folders in
> site-repository
> ---
>
> Key: MSITE-1010
> URL: https://issues.apache.org/jira/browse/MSITE-1010
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: site:deploy
>Affects Versions: 3.12.0, 4.0.0-M14
> Environment: Nexus, since at least Maven 3.6.3 (not tested with 3.9.7
> or 4.0.0-beta)
>Reporter: Matthias Bünger
>Priority: Minor
> Fix For: waiting-for-feedback
>
> Attachments: pom.xml, webdav.txt
>
>
> I noticed the following issue while updating the plugins in our teams
> META-POM and could backtrack it at least until 3.12 but might be an even
> older issue. Havn't checked 4.0.0-M15 but from the releases notes I doubt it
> is fixed.
> When you do "site-deploy" for a single module or multi module project the
> site files (.html, css-folders, etc.) are stored in the site-repository (we
> have current Nexus version) within a subfolder with the name of the project,
> e.g
> {code}
> / (root of site-repository)
> /- project-A
>/css
>report.html
> /- project-B
>/css
>report.html
> /project-C
> {code}
> If you do the same for a "POM" project (e.g. a META-POM or BOM) the site
> files are all stored at root level (instead of creating a project folder) and
> ofc overwriting the ones from other POM-projects:
> {code}
> / (root of site-repository)
> /css
> /project-A
> /project-B
> /project-C
> report.html
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-pmd-plugin]
dependabot[bot] opened a new pull request, #152: URL: https://github.com/apache/maven-pmd-plugin/pull/152 Bumps `resolverVersion` from 1.4.1 to 1.9.20. Updates `org.apache.maven.resolver:maven-resolver-api` from 1.4.1 to 1.9.20 Release notes Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-api's releases. 1.9.20 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354578";>Release Notes - Maven Resolver - Version 1.9.20 What's Changed [MRESOLVER-547] Just use setVersion by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/483";>apache/maven-resolver#483 [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/484";>apache/maven-resolver#484 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release Notes - Maven Resolver - Version 1.9.19 ... (truncated) Commits https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3";>f5fbc24 [maven-release-plugin] prepare release maven-resolver-1.9.20 https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82";>446009d [MRESOLVER-549][MRESOLVER-550][MRESOLVER-551] Parent POM 42 (https://redirect.github.com/apache/maven-resolver/issues/484";>#484) https://github.com/apache/maven-resolver/commit/4f16d5ecd94f85e6e7d793e6b6b82f20c9afbf56";>4f16d5e [MRESOLVER-547] Just use setVersion (https://redirect.github.com/apache/maven-resolver/issues/483";>#483) https://github.com/apache/maven-resolver/commit/c1b24c699621930f4eb77721400f2f6c46930626";>c1b24c6 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56";>c1b0357 [maven-release-plugin] prepare release maven-resolver-1.9.19 https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0";>adadd42 [MRESOLVER-536] Do not belly up if FS does not support setting mtime (https://redirect.github.com/apache/maven-resolver/issues/469";>#469) https://github.com/apache/maven-resolver/commit/31df8a3dc503895172d277de56b1c4a53da0a27c";>31df8a3 [1.9.x] Update dependencies (https://redirect.github.com/apache/maven-resolver/issues/462";>#462) https://github.com/apache/maven-resolver/commit/b225076e5d5b2fe3f166a4018802ac94b7cc94f7";>b225076 [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) (https://redirect.github.com/apache/maven-resolver/issues/461";>#461) https://github.com/apache/maven-resolver/commit/fc969c2570041bb72c3f0141ff4957e8754f365c";>fc969c2 [1.9.x][MRESOLVER-483] Fix path concatenation logic (https://redirect.github.com/apache/maven-resolver/issues/420";>#420) https://github.com/apache/maven-resolver/commit/a3e620d6d2ab6ca58d42d264347341b31da00dde";>a3e620d Use one Maven in CI Additional commits viewable in https://github.com/apache/maven-resolver/compare/maven-resolver-1.4.1...maven-resolver-1.9.20";>compare view Updates `org.apache.maven.resolver:maven-resolver-impl` from 1.4.1 to 1.9.20 Release notes Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-impl's releases. 1.9.20 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354578";>Release Notes - Maven Resolver - Version 1.9.20 What's Changed [MRESOLVER-547] Just use setVersion by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/483";>apache/maven-resolver#483 [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/484";>apache/maven-resolver#484 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release Notes - Maven Resolver - Version 1.9.19 ... (truncated) Commits https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3";>f5fbc24 [maven-release-plugin] prepare release maven-resolver-1.9.20 https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82";>446009d [MRESOLVER-549][MRESO
[PR] Bump org.apache.maven.shared:maven-common-artifact-filters from 3.3.2 to 3.4.0 [maven-pmd-plugin]
dependabot[bot] opened a new pull request, #153: URL: https://github.com/apache/maven-pmd-plugin/pull/153 Bumps [org.apache.maven.shared:maven-common-artifact-filters](https://github.com/apache/maven-common-artifact-filters) from 3.3.2 to 3.4.0. Commits https://github.com/apache/maven-common-artifact-filters/commit/d3cd1e4a9646de2a2f30ddd34e1e4471b2a75f8f";>d3cd1e4 [maven-release-plugin] prepare release maven-common-artifact-filters-3.4.0 https://github.com/apache/maven-common-artifact-filters/commit/31ecf96e47a6e8aa9f45e47c70767e2f378db919";>31ecf96 Ignore blame revs https://github.com/apache/maven-common-artifact-filters/commit/888d69aee331d183a5f1e6343246fbe2dd712965";>888d69a [MSHARED-1301] Upgrade to Parent 42 and Maven 3.6.3 https://github.com/apache/maven-common-artifact-filters/commit/1742cb10aefa271fbf7dd526b635dca5aa14481a";>1742cb1 Bump maven-gh-actions-shared to v4 https://github.com/apache/maven-common-artifact-filters/commit/9d692d49b35014a2d308c78894ee502bccd0361e";>9d692d4 [MSHARED-1302] upgrade commons-io to 2.13.0 (https://redirect.github.com/apache/maven-common-artifact-filters/issues/34";>#34) https://github.com/apache/maven-common-artifact-filters/commit/bbcf21338500a56de7301667900f181cc2bbfc5c";>bbcf213 [MSHARED-1300] Order of dependencies is not always retained when filtering (https://redirect.github.com/apache/maven-common-artifact-filters/issues/33";>#33) https://github.com/apache/maven-common-artifact-filters/commit/c3b2940621e5a9871d181d05f1c51eab2fc335e0";>c3b2940 Auto-link MSHARED Jira https://github.com/apache/maven-common-artifact-filters/commit/9a65b6570154ae48ab8a6c7154e0fa07d3cc2c49";>9a65b65 add Reproducible Builds badge https://github.com/apache/maven-common-artifact-filters/commit/6c7242159031dd72f36bcc15f76f86b4faee70b4";>6c72421 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-common-artifact-filters/compare/maven-common-artifact-filters-3.3.2...maven-common-artifact-filters-3.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Upgrade to beta-4 [maven-plugin-tools]
gnodet opened a new pull request, #295: URL: https://github.com/apache/maven-plugin-tools/pull/295 - **[MPLUGIN-508] Upgrade to 4.0.0-beta-3** - **Upgrade to beta-4-SNAPSHOT** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8134] Add a @Dependencies annotation to mojos to inject project dependencies collection / resolution result [maven]
gnodet commented on PR #1559: URL: https://github.com/apache/maven/pull/1559#issuecomment-2158113685 The v4api IT in https://github.com/apache/maven-plugin-tools/pull/295 adds a field with the `@Dependencies` annotation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8134) Provide an annotation that can be used to inject dependencies resolution/collection in mojos
[ https://issues.apache.org/jira/browse/MNG-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853624#comment-17853624 ] ASF GitHub Bot commented on MNG-8134: - gnodet commented on PR #1559: URL: https://github.com/apache/maven/pull/1559#issuecomment-2158113685 The v4api IT in https://github.com/apache/maven-plugin-tools/pull/295 adds a field with the `@Dependencies` annotation. > Provide an annotation that can be used to inject dependencies > resolution/collection in mojos > > > Key: MNG-8134 > URL: https://issues.apache.org/jira/browse/MNG-8134 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0 > > > See > https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8150) Make SimplexTransferListener handle absent source/target files
Pavlo Shevchenko created MNG-8150: - Summary: Make SimplexTransferListener handle absent source/target files Key: MNG-8150 URL: https://issues.apache.org/jira/browse/MNG-8150 Project: Maven Issue Type: Improvement Components: Core Reporter: Pavlo Shevchenko Assignee: Tamas Cservenak Fix For: 3.9.7 Backport of MNG-8007 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavlo Shevchenko updated MNG-8150: -- Component/s: (was: Core) Affects Version/s: 3.9.7 Description: See the discussion: [https://github.com/apache/maven/pull/1471/files#r1632930409] The `TransferResource#file` may be `null`. The current implementation of the `SimplexTransferListener` cannot handle this case and will break with an NPE. Â The fix should be merged to `master` and backported to `maven-3.9.x` branches. Â Â was:Backport of MNG-8007 Priority: Minor (was: Major) > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 3.9.7 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8031] Backport concurrent friendly transport listener [maven]
pshevche commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1633119070
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 3.9.7
+ */
+public final class SimplexTransferListener extends AbstractTransferListener {
+private static final Logger LOGGER =
LoggerFactory.getLogger(SimplexTransferListener.class);
+private static final int QUEUE_SIZE = 1024;
+private static final int BATCH_MAX_SIZE = 500;
+private final TransferListener delegate;
+private final int batchMaxSize;
+private final boolean blockOnLastEvent;
+private final ArrayBlockingQueue eventQueue;
+
+/**
+ * Constructor that makes passed in delegate run on single thread, and
will block on last event.
+ */
+public SimplexTransferListener(TransferListener delegate) {
+this(delegate, QUEUE_SIZE, BATCH_MAX_SIZE, true);
+}
+
+/**
+ * Constructor that may alter behaviour of this listener.
+ *
+ * @param delegate The delegate that should run on single thread.
+ * @param queueSize The event queue size (default {@code 1024}).
+ * @param batchMaxSize The maximum batch size delegate should receive
(default {@code 500}).
+ * @param blockOnLastEvent Should this listener block on last transfer end
(completed or corrupted) block? (default {@code true}).
+ */
+public SimplexTransferListener(
+TransferListener delegate, int queueSize, int batchMaxSize,
boolean blockOnLastEvent) {
+this.delegate = requireNonNull(delegate);
+if (queueSize < 1 || batchMaxSize < 1) {
+throw new IllegalArgumentException("Queue and batch sizes must be
greater than 1");
+}
+this.batchMaxSize = batchMaxSize;
+this.blockOnLastEvent = blockOnLastEvent;
+
+this.eventQueue = new ArrayBlockingQueue<>(queueSize);
+Thread updater = new Thread(this::feedConsumer);
+updater.setDaemon(true);
+updater.start();
+}
+
+public TransferListener getDelegate() {
+return delegate;
+}
+
+private void feedConsumer() {
+final ArrayList batch = new ArrayList<>(batchMaxSize);
+try {
+while (true) {
+batch.clear();
+if (eventQueue.drainTo(batch, BATCH_MAX_SIZE) == 0) {
+batch.add(eventQueue.take());
+}
+demux(batch);
+}
+} catch (InterruptedException e) {
+throw new RuntimeException(e);
+}
+}
+
+private void demux(List exchanges) {
+for (Exchange exchange : exchanges) {
+exchange.process(transferEvent -> {
+TransferEvent.EventType type = transferEvent.getType();
+try {
+switch (type) {
+case INITIATED:
+delegate.transferInitiated(transferEvent);
+break;
+case STARTED:
+delegate.transferStarted(transferEvent);
[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[
https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853625#comment-17853625
]
ASF GitHub Bot commented on MNG-8031:
-
pshevche commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1633119070
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 3.9.7
+ */
+public final class SimplexTransferListener extends AbstractTransferListener {
+private static final Logger LOGGER =
LoggerFactory.getLogger(SimplexTransferListener.class);
+private static final int QUEUE_SIZE = 1024;
+private static final int BATCH_MAX_SIZE = 500;
+private final TransferListener delegate;
+private final int batchMaxSize;
+private final boolean blockOnLastEvent;
+private final ArrayBlockingQueue eventQueue;
+
+/**
+ * Constructor that makes passed in delegate run on single thread, and
will block on last event.
+ */
+public SimplexTransferListener(TransferListener delegate) {
+this(delegate, QUEUE_SIZE, BATCH_MAX_SIZE, true);
+}
+
+/**
+ * Constructor that may alter behaviour of this listener.
+ *
+ * @param delegate The delegate that should run on single thread.
+ * @param queueSize The event queue size (default {@code 1024}).
+ * @param batchMaxSize The maximum batch size delegate should receive
(default {@code 500}).
+ * @param blockOnLastEvent Should this listener block on last transfer end
(completed or corrupted) block? (default {@code true}).
+ */
+public SimplexTransferListener(
+TransferListener delegate, int queueSize, int batchMaxSize,
boolean blockOnLastEvent) {
+this.delegate = requireNonNull(delegate);
+if (queueSize < 1 || batchMaxSize < 1) {
+throw new IllegalArgumentException("Queue and batch sizes must be
greater than 1");
+}
+this.batchMaxSize = batchMaxSize;
+this.blockOnLastEvent = blockOnLastEvent;
+
+this.eventQueue = new ArrayBlockingQueue<>(queueSize);
+Thread updater = new Thread(this::feedConsumer);
+updater.setDaemon(true);
+updater.start();
+}
+
+public TransferListener getDelegate() {
+return delegate;
+}
+
+private void feedConsumer() {
+final ArrayList batch = new ArrayList<>(batchMaxSize);
+try {
+while (true) {
+batch.clear();
+if (eventQueue.drainTo(batch, BATCH_MAX_SIZE) == 0) {
+batch.add(eventQueue.take());
+}
+demux(batch);
+}
+} catch (InterruptedException e) {
+throw new RuntimeException(e);
+}
+}
+
+private void demux(List exchanges) {
+for (Exchange exchange : exchanges) {
+exchange.process(transferEvent -> {
+TransferEvent.EventType type = transferEvent.getType();
+try {
+switch (type) {
+
[jira] [Commented] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853626#comment-17853626 ] Pavlo Shevchenko commented on MNG-8150: --- I will prepare a PR for this. > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 3.9.7 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8150: - Fix Version/s: 4.0.0 4.0.0-beta-4 > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 3.9.7, 4.0.0, 4.0.0-beta-4 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8150: - Fix Version/s: 3.9.8 (was: 3.9.7) > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8150: - Component/s: Core > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSITE-1010) site-deployment for POM projects does not create project folders in site-repository
[
https://issues.apache.org/jira/browse/MSITE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853631#comment-17853631
]
Michael Osipov commented on MSITE-1010:
---
It does not answer my question. Can you try test setup which just deploys
locally with {{file://}} and check whether the structure is the way you expect?
> site-deployment for POM projects does not create project folders in
> site-repository
> ---
>
> Key: MSITE-1010
> URL: https://issues.apache.org/jira/browse/MSITE-1010
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: site:deploy
>Affects Versions: 3.12.0, 4.0.0-M14
> Environment: Nexus, since at least Maven 3.6.3 (not tested with 3.9.7
> or 4.0.0-beta)
>Reporter: Matthias Bünger
>Priority: Minor
> Fix For: waiting-for-feedback
>
> Attachments: pom.xml, webdav.txt
>
>
> I noticed the following issue while updating the plugins in our teams
> META-POM and could backtrack it at least until 3.12 but might be an even
> older issue. Havn't checked 4.0.0-M15 but from the releases notes I doubt it
> is fixed.
> When you do "site-deploy" for a single module or multi module project the
> site files (.html, css-folders, etc.) are stored in the site-repository (we
> have current Nexus version) within a subfolder with the name of the project,
> e.g
> {code}
> / (root of site-repository)
> /- project-A
>/css
>report.html
> /- project-B
>/css
>report.html
> /project-C
> {code}
> If you do the same for a "POM" project (e.g. a META-POM or BOM) the site
> files are all stored at root level (instead of creating a project folder) and
> ofc overwriting the ones from other POM-projects:
> {code}
> / (root of site-repository)
> /css
> /project-A
> /project-B
> /project-C
> report.html
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSITE-1010) site-deployment for POM projects does not create project folders in site-repository
[
https://issues.apache.org/jira/browse/MSITE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853632#comment-17853632
]
Michael Osipov commented on MSITE-1010:
---
The bug might just be in the WebDAV provider.
> site-deployment for POM projects does not create project folders in
> site-repository
> ---
>
> Key: MSITE-1010
> URL: https://issues.apache.org/jira/browse/MSITE-1010
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: site:deploy
>Affects Versions: 3.12.0, 4.0.0-M14
> Environment: Nexus, since at least Maven 3.6.3 (not tested with 3.9.7
> or 4.0.0-beta)
>Reporter: Matthias Bünger
>Priority: Minor
> Fix For: waiting-for-feedback
>
> Attachments: pom.xml, webdav.txt
>
>
> I noticed the following issue while updating the plugins in our teams
> META-POM and could backtrack it at least until 3.12 but might be an even
> older issue. Havn't checked 4.0.0-M15 but from the releases notes I doubt it
> is fixed.
> When you do "site-deploy" for a single module or multi module project the
> site files (.html, css-folders, etc.) are stored in the site-repository (we
> have current Nexus version) within a subfolder with the name of the project,
> e.g
> {code}
> / (root of site-repository)
> /- project-A
>/css
>report.html
> /- project-B
>/css
>report.html
> /project-C
> {code}
> If you do the same for a "POM" project (e.g. a META-POM or BOM) the site
> files are all stored at root level (instead of creating a project folder) and
> ofc overwriting the ones from other POM-projects:
> {code}
> / (root of site-repository)
> /css
> /project-A
> /project-B
> /project-C
> report.html
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7194) PluginParameterExpressionEvaluator incorrectly interpolates unknown subexpression
[
https://issues.apache.org/jira/browse/MNG-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853637#comment-17853637
]
ASF GitHub Bot commented on MNG-7194:
-
pzygielo opened a new pull request, #1573:
URL: https://github.com/apache/maven/pull/1573
- #1570 but for master
> PluginParameterExpressionEvaluator incorrectly interpolates unknown
> subexpression
> -
>
> Key: MNG-7194
> URL: https://issues.apache.org/jira/browse/MNG-7194
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Reporter: Robert Scholte
>Priority: Minor
>
> The PluginParameterExpressionEvaluator evaluate(String,Class)-method ends
> like this:
> {code:java}
> if ( value instanceof String )
> {
> // TODO: without #, this could just be an evaluate call...
> String val = (String) value;
> int exprStartDelimiter = val.indexOf( "${" );
> if ( exprStartDelimiter >= 0 )
> {
> if ( exprStartDelimiter > 0 )
> {
> value = val.substring( 0, exprStartDelimiter ) +
> evaluate( val.substring( exprStartDelimiter ) );
> }
> else
> {
> value = evaluate( val.substring( exprStartDelimiter ) );
> }
> }
> }
> {code}
> Assume that pre${unknown} needs to be evaluated and {{unknown}} does not
> exist, the result well be "{{prenull}}"
> Just ${unknown} evaluates to null, but because there's no String concat it
> will be a real null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MNG-7194] Change expectation for missing property evaluation [maven]
pzygielo opened a new pull request, #1574: URL: https://github.com/apache/maven/pull/1574 - Like #1571 but based on #1573 and for master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7194) PluginParameterExpressionEvaluator incorrectly interpolates unknown subexpression
[
https://issues.apache.org/jira/browse/MNG-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853638#comment-17853638
]
ASF GitHub Bot commented on MNG-7194:
-
pzygielo opened a new pull request, #1574:
URL: https://github.com/apache/maven/pull/1574
- Like #1571 but based on #1573 and for master
> PluginParameterExpressionEvaluator incorrectly interpolates unknown
> subexpression
> -
>
> Key: MNG-7194
> URL: https://issues.apache.org/jira/browse/MNG-7194
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Reporter: Robert Scholte
>Priority: Minor
>
> The PluginParameterExpressionEvaluator evaluate(String,Class)-method ends
> like this:
> {code:java}
> if ( value instanceof String )
> {
> // TODO: without #, this could just be an evaluate call...
> String val = (String) value;
> int exprStartDelimiter = val.indexOf( "${" );
> if ( exprStartDelimiter >= 0 )
> {
> if ( exprStartDelimiter > 0 )
> {
> value = val.substring( 0, exprStartDelimiter ) +
> evaluate( val.substring( exprStartDelimiter ) );
> }
> else
> {
> value = evaluate( val.substring( exprStartDelimiter ) );
> }
> }
> }
> {code}
> Assume that pre${unknown} needs to be evaluated and {{unknown}} does not
> exist, the result well be "{{prenull}}"
> Just ${unknown} evaluates to null, but because there's no String concat it
> will be a real null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8134] Add a @Dependencies annotation to mojos to inject project dependencies collection / resolution result [maven]
rmannibucau commented on PR #1559: URL: https://github.com/apache/maven/pull/1559#issuecomment-2158189094 I'd shamefully copy a new `DependencySet` wrapper idea to avoid to have to inject a map or a list which are rarely what is needed so a think wrapper enabling to lookup what is needed (with filter + default collectors support). That said I don't know if we need an injection or just this wrapper being accessible from the project - I have a few cases where the scope is configured in the mojo so the injection can need an expression to work (+-0 to make it working or just rely on v4 project). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8134) Provide an annotation that can be used to inject dependencies resolution/collection in mojos
[ https://issues.apache.org/jira/browse/MNG-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853639#comment-17853639 ] ASF GitHub Bot commented on MNG-8134: - rmannibucau commented on PR #1559: URL: https://github.com/apache/maven/pull/1559#issuecomment-2158189094 I'd shamefully copy a new `DependencySet` wrapper idea to avoid to have to inject a map or a list which are rarely what is needed so a think wrapper enabling to lookup what is needed (with filter + default collectors support). That said I don't know if we need an injection or just this wrapper being accessible from the project - I have a few cases where the scope is configured in the mojo so the injection can need an expression to work (+-0 to make it working or just rely on v4 project). > Provide an annotation that can be used to inject dependencies > resolution/collection in mojos > > > Key: MNG-8134 > URL: https://issues.apache.org/jira/browse/MNG-8134 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0 > > > See > https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.
AB-xdev created MPMD-399:
Summary: Incorrect warning: The project X does not seem to be
compiled. PMD results might be inaccurate.
Key: MPMD-399
URL: https://issues.apache.org/jira/browse/MPMD-399
Project: Maven PMD Plugin
Issue Type: Bug
Components: PMD
Affects Versions: 3.22.0
Reporter: AB-xdev
PMD plugin is reporting the following warnings on in a multi-maven project:
"The project X does not seem to be compiled. PMD results might be inaccurate."
This is caused by the fact that not all modules have a
* {{src/main/java}} or
* {{src/test/java}} folder
and therefore no {{target/classes}} or {{target/test-classes}} folders are
generated.
The affected code that causes the problem can be found here:
https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532
Reproduction example:
* Create a maven multi-module project
* Leave {{src/main/java}} of one module empty
* Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
-DskipTests}}
→ (x) Warning is reported
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7194] Change expectation for missing property evaluation [maven]
pzygielo commented on PR #1574: URL: https://github.com/apache/maven/pull/1574#issuecomment-2158199989 - The [failure](https://github.com/apache/maven/actions/runs/9448106653/job/26021560449?pr=1574#step:5:2679) - as in #1571 - is _expected_ with current implementation. However the current implementation is not expected by me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7194) PluginParameterExpressionEvaluator incorrectly interpolates unknown subexpression
[
https://issues.apache.org/jira/browse/MNG-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853640#comment-17853640
]
ASF GitHub Bot commented on MNG-7194:
-
pzygielo commented on PR #1574:
URL: https://github.com/apache/maven/pull/1574#issuecomment-2158199989
- The
[failure](https://github.com/apache/maven/actions/runs/9448106653/job/26021560449?pr=1574#step:5:2679)
- as in #1571 - is _expected_ with current implementation.
However the current implementation is not expected by me.
> PluginParameterExpressionEvaluator incorrectly interpolates unknown
> subexpression
> -
>
> Key: MNG-7194
> URL: https://issues.apache.org/jira/browse/MNG-7194
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Reporter: Robert Scholte
>Priority: Minor
>
> The PluginParameterExpressionEvaluator evaluate(String,Class)-method ends
> like this:
> {code:java}
> if ( value instanceof String )
> {
> // TODO: without #, this could just be an evaluate call...
> String val = (String) value;
> int exprStartDelimiter = val.indexOf( "${" );
> if ( exprStartDelimiter >= 0 )
> {
> if ( exprStartDelimiter > 0 )
> {
> value = val.substring( 0, exprStartDelimiter ) +
> evaluate( val.substring( exprStartDelimiter ) );
> }
> else
> {
> value = evaluate( val.substring( exprStartDelimiter ) );
> }
> }
> }
> {code}
> Assume that pre${unknown} needs to be evaluated and {{unknown}} does not
> exist, the result well be "{{prenull}}"
> Just ${unknown} evaluates to null, but because there's no String concat it
> will be a real null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.
[
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AB-xdev updated MPMD-399:
-
Description:
PMD plugin is reporting the following warnings on in a multi-maven project:
"The project X does not seem to be compiled. PMD results might be inaccurate."
This is caused by the fact that not all modules have a
* {{src/main/java}} or
* {{src/test/java}} folder
and therefore no {{target/classes}} or {{target/test-classes}} folders are
generated.
The affected code that causes the problem can be found here:
[https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
h3. Reproduction example
* Create a maven multi-module project
* Leave {{src/main/java}} of one module empty
* Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
-DskipTests}}
→ (x) Warning is reported
h3. Possible fixes
* Make it possible to ignore this warning
* Do not warn when at least {{target/classes}} or {{target/test-classes}} is
present
Â
was:
PMD plugin is reporting the following warnings on in a multi-maven project:
"The project X does not seem to be compiled. PMD results might be inaccurate."
This is caused by the fact that not all modules have a
* {{src/main/java}} or
* {{src/test/java}} folder
and therefore no {{target/classes}} or {{target/test-classes}} folders are
generated.
The affected code that causes the problem can be found here:
https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532
Reproduction example:
* Create a maven multi-module project
* Leave {{src/main/java}} of one module empty
* Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
-DskipTests}}
→ (x) Warning is reported
> Incorrect warning: The project X does not seem to be compiled. PMD results
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
> * {{src/main/java}} or
> * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
> * Create a maven multi-module project
> * Leave {{src/main/java}} of one module empty
> * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is
> present
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7194] Test missing property evaluation [maven]
pzygielo commented on PR #1570: URL: https://github.com/apache/maven/pull/1570#issuecomment-2158210463  Being the member of that group (_all users_) I target the latest released version. IMO - as this PR only shows current state, it wouldn't hurt to be integrated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7194) PluginParameterExpressionEvaluator incorrectly interpolates unknown subexpression
[
https://issues.apache.org/jira/browse/MNG-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853642#comment-17853642
]
ASF GitHub Bot commented on MNG-7194:
-
pzygielo commented on PR #1570:
URL: https://github.com/apache/maven/pull/1570#issuecomment-2158210463
Being the member of that group (_all users_) I target the latest released
version.
IMO - as this PR only shows current state, it wouldn't hurt to be integrated.
> PluginParameterExpressionEvaluator incorrectly interpolates unknown
> subexpression
> -
>
> Key: MNG-7194
> URL: https://issues.apache.org/jira/browse/MNG-7194
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Reporter: Robert Scholte
>Priority: Minor
>
> The PluginParameterExpressionEvaluator evaluate(String,Class)-method ends
> like this:
> {code:java}
> if ( value instanceof String )
> {
> // TODO: without #, this could just be an evaluate call...
> String val = (String) value;
> int exprStartDelimiter = val.indexOf( "${" );
> if ( exprStartDelimiter >= 0 )
> {
> if ( exprStartDelimiter > 0 )
> {
> value = val.substring( 0, exprStartDelimiter ) +
> evaluate( val.substring( exprStartDelimiter ) );
> }
> else
> {
> value = evaluate( val.substring( exprStartDelimiter ) );
> }
> }
> }
> {code}
> Assume that pre${unknown} needs to be evaluated and {{unknown}} does not
> exist, the result well be "{{prenull}}"
> Just ${unknown} evaluates to null, but because there's no String concat it
> will be a real null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.
[
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853645#comment-17853645
]
Michael Osipov commented on MPMD-399:
-
What packaging type is the project in question?
> Incorrect warning: The project X does not seem to be compiled. PMD results
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
> * {{src/main/java}} or
> * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
> * Create a maven multi-module project
> * Leave {{src/main/java}} of one module empty
> * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is
> present
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
pshevche opened a new pull request, #1575: URL: https://github.com/apache/maven/pull/1575 ## Summary The PR address two issues observed in the `SimplexTransferListener` and `ConsoleMavenTransferListener`: 1. [TransferResource#getFile()](https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferResource.java#L170) can be null. The current `SimplexTransferListener` will break with an NPE if the `file` is not set on the resource. 2. `TransferResource` is not immutable and does not implement `equals` or `hashCode,` making its usage in collections brittle. Listener consumers are not guaranteed to reuse the same instance across listener invocations. I suggest wrapping it in an immutable identifier. Let me know if I am overthinking this or if anything else is needed. Resolves https://issues.apache.org/jira/browse/MNG-8150 - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853648#comment-17853648 ] ASF GitHub Bot commented on MNG-8150: - pshevche opened a new pull request, #1575: URL: https://github.com/apache/maven/pull/1575 ## Summary The PR address two issues observed in the `SimplexTransferListener` and `ConsoleMavenTransferListener`: 1. [TransferResource#getFile()](https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferResource.java#L170) can be null. The current `SimplexTransferListener` will break with an NPE if the `file` is not set on the resource. 2. `TransferResource` is not immutable and does not implement `equals` or `hashCode,` making its usage in collections brittle. Listener consumers are not guaranteed to reuse the same instance across listener invocations. I suggest wrapping it in an immutable identifier. Let me know if I am overthinking this or if anything else is needed. Resolves https://issues.apache.org/jira/browse/MNG-8150 - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.
[
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853649#comment-17853649
]
AB-xdev commented on MPMD-399:
--
The packaging type is jar
> Incorrect warning: The project X does not seem to be compiled. PMD results
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
> * {{src/main/java}} or
> * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
> * Create a maven multi-module project
> * Leave {{src/main/java}} of one module empty
> * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is
> present
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
cstamas commented on PR #1575: URL: https://github.com/apache/maven/pull/1575#issuecomment-2158265116 Looks nice, but the maven-3.9.x branch (Maven 3.9.x) is Java 8... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853651#comment-17853651 ] ASF GitHub Bot commented on MNG-8150: - cstamas commented on PR #1575: URL: https://github.com/apache/maven/pull/1575#issuecomment-2158265116 Looks nice, but the maven-3.9.x branch (Maven 3.9.x) is Java 8... > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.
[
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853652#comment-17853652
]
Michael Osipov commented on MPMD-399:
-
Does it work for your with {{-Dpmd.typeResolution=false}}?
> Incorrect warning: The project X does not seem to be compiled. PMD results
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
> * {{src/main/java}} or
> * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
> * Create a maven multi-module project
> * Leave {{src/main/java}} of one module empty
> * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is
> present
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
pshevche commented on PR #1575: URL: https://github.com/apache/maven/pull/1575#issuecomment-2158275480 > Looks nice, but the maven-3.9.x branch (Maven 3.9.x) is Java 8... Yeah, I see that now :) Do you want me to keep records on this branch and use a class on `maven-3.9.x` branch or would you rather prefer the same style everywhere? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853653#comment-17853653 ] ASF GitHub Bot commented on MNG-8150: - pshevche commented on PR #1575: URL: https://github.com/apache/maven/pull/1575#issuecomment-2158275480 > Looks nice, but the maven-3.9.x branch (Maven 3.9.x) is Java 8... Yeah, I see that now :) Do you want me to keep records on this branch and use a class on `maven-3.9.x` branch or would you rather prefer the same style everywhere? > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
cstamas commented on PR #1575: URL: https://github.com/apache/maven/pull/1575#issuecomment-2158279929 No, IMO records on master (Maven 4, that is Java 17) is ok, I just warned you when you try to backport this to maven-3.9.x branch... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853654#comment-17853654 ] ASF GitHub Bot commented on MNG-8150: - cstamas commented on PR #1575: URL: https://github.com/apache/maven/pull/1575#issuecomment-2158279929 No, IMO records on master (Maven 4, that is Java 17) is ok, I just warned you when you try to backport this to maven-3.9.x branch... > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Backport TransferListenerImprovements for Maven 3.9.x [maven]
pshevche opened a new pull request, #1576: URL: https://github.com/apache/maven/pull/1576 ## Summary Backporting https://github.com/apache/maven/pull/1575 to Maven 3.9.x. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
pshevche commented on PR #1575: URL: https://github.com/apache/maven/pull/1575#issuecomment-2158289393 > No, IMO records on master (Maven 4, that is Java 17) is ok, I just warned you when you try to backport this to maven-3.9.x branch... Makes sense, thank you. Here is the PR for backport: https://github.com/apache/maven/pull/1576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8150) Make SimplexTransferListener handle absent source/target files
[ https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853656#comment-17853656 ] ASF GitHub Bot commented on MNG-8150: - pshevche commented on PR #1575: URL: https://github.com/apache/maven/pull/1575#issuecomment-2158289393 > No, IMO records on master (Maven 4, that is Java 17) is ok, I just warned you when you try to backport this to maven-3.9.x branch... Makes sense, thank you. Here is the PR for backport: https://github.com/apache/maven/pull/1576 > Make SimplexTransferListener handle absent source/target files > -- > > Key: MNG-8150 > URL: https://issues.apache.org/jira/browse/MNG-8150 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.9.7 >Reporter: Pavlo Shevchenko >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > See the discussion: > [https://github.com/apache/maven/pull/1471/files#r1632930409] > The `TransferResource#file` may be `null`. The current implementation of the > `SimplexTransferListener` cannot handle this case and will break with an NPE. > Â > The fix should be merged to `master` and backported to `maven-3.9.x` branches. > Â > Â -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.
[
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853657#comment-17853657
]
AB-xdev commented on MPMD-399:
--
Well it then fails with some false positives (as the types are not resolved),
but yes the warning is then gone.
I still prefer some incorrect warnings instead of FP, so I don't think this is
a long term solution ;)
> Incorrect warning: The project X does not seem to be compiled. PMD results
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
> * {{src/main/java}} or
> * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
> * Create a maven multi-module project
> * Leave {{src/main/java}} of one module empty
> * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is
> present
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.
[
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853660#comment-17853660
]
Michael Osipov commented on MPMD-399:
-
I am inclined to delete this entire block
https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L522-L532
because in a single module there is not such message, but would make sense to
be consistent:
https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L539-L541
Either both or none, WDYT?
> Incorrect warning: The project X does not seem to be compiled. PMD results
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
> * {{src/main/java}} or
> * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
> * Create a maven multi-module project
> * Leave {{src/main/java}} of one module empty
> * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is
> present
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.
[
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853667#comment-17853667
]
AB-xdev commented on MPMD-399:
--
Well I'm not that familiar with the code, but anyway my opinion:
Block 1: Either delete it or add some kind of flag that let's the end-user
control this check
Block 2: According to
https://github.com/apache/maven-pmd-plugin/blob/master/src/main/java/org/apache/maven/plugins/pmd/AbstractPmdReport.java#L548
this seems to be deprecated anyway? Maybe a good time to remove it :)
> Incorrect warning: The project X does not seem to be compiled. PMD results
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
> * {{src/main/java}} or
> * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
> * Create a maven multi-module project
> * Leave {{src/main/java}} of one module empty
> * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is
> present
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.
[
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853670#comment-17853670
]
Michael Osipov commented on MPMD-399:
-
The method is deprecated, but the information is still required and needs to be
obtained elsewhere. That is different discussion. I would take care of the
message.
Why do you have a JAR project w/o source code in the first place?
> Incorrect warning: The project X does not seem to be compiled. PMD results
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
> * {{src/main/java}} or
> * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
> * Create a maven multi-module project
> * Leave {{src/main/java}} of one module empty
> * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is
> present
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
