[jira] [Commented] (MSHARED-1175) describe from and to in "Copying x resources" info message
[ https://issues.apache.org/jira/browse/MSHARED-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803770#comment-17803770 ] Herve Boutemy commented on MSHARED-1175: [~Abel S.Romero] good catch, please create a distinct issue that we can link and work on > describe from and to in "Copying x resources" info message > -- > > Key: MSHARED-1175 > URL: https://issues.apache.org/jira/browse/MSHARED-1175 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-filtering >Affects Versions: maven-filtering-3.3.0 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: maven-filtering-3.3.1 > > > see MRESOURCES-292 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Correct reporting - maven-plugin-report-plugin [maven-archetype]
slachiewicz merged PR #182: URL: https://github.com/apache/maven-archetype/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-surefire]
asfgit merged PR #714: URL: https://github.com/apache/maven-surefire/pull/714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-component-metadata from 2.1.1 to 2.2.0 [maven-surefire]
michael-o commented on PR #715: URL: https://github.com/apache/maven-surefire/pull/715#issuecomment-1879615439 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSHARED-1347) maven-dependency-plugin ignores class of object passed as a parameter to method references
[
https://issues.apache.org/jira/browse/MSHARED-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MSHARED-1347.
Fix Version/s: maven-dependency-analyzer-next-release
Resolution: Fixed
> maven-dependency-plugin ignores class of object passed as a parameter to
> method references
> --
>
> Key: MSHARED-1347
> URL: https://issues.apache.org/jira/browse/MSHARED-1347
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.13.2
>Reporter: Vidar Breivik
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: maven-dependency-analyzer-next-release
>
>
> Text copied from [MDEP-576|https://issues.apache.org/jira/browse/MDEP-576]
> Hi there, i created a project on
> [github|https://github.com/vdergachev/dependency-plugin-vs-java-lambda] that
> can help you to reproduce the issue. Just clone it and make
> {code:java}
> mvn clean install{code}
> In my case plugin ignored Server class from jetty-server.jar and a as result
> i got message
> {code:java}
> Unused declared dependencies found{code}
>
> h4.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MSHARED-1347) maven-dependency-plugin ignores class of object passed as a parameter to method references
[
https://issues.apache.org/jira/browse/MSHARED-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MSHARED-1347:
Assignee: Elliotte Rusty Harold
> maven-dependency-plugin ignores class of object passed as a parameter to
> method references
> --
>
> Key: MSHARED-1347
> URL: https://issues.apache.org/jira/browse/MSHARED-1347
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.13.2
>Reporter: Vidar Breivik
>Assignee: Elliotte Rusty Harold
>Priority: Minor
>
> Text copied from [MDEP-576|https://issues.apache.org/jira/browse/MDEP-576]
> Hi there, i created a project on
> [github|https://github.com/vdergachev/dependency-plugin-vs-java-lambda] that
> can help you to reproduce the issue. Just clone it and make
> {code:java}
> mvn clean install{code}
> In my case plugin ignored Server class from jetty-server.jar and a as result
> i got message
> {code:java}
> Unused declared dependencies found{code}
>
> h4.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [ARCHETYPE-652] Added system requirements history [maven-archetype]
slachiewicz commented on code in PR #158: URL: https://github.com/apache/maven-archetype/pull/158#discussion_r1443691792 ## maven-archetype-plugin/pom.xml: ## @@ -172,6 +172,154 @@ + + + + org.apache.maven.plugins + maven-plugin-report-plugin + + + + + Review Comment: i'll fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (ARCHETYPE-652) document requirement history
[ https://issues.apache.org/jira/browse/ARCHETYPE-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803794#comment-17803794 ] ASF GitHub Bot commented on ARCHETYPE-652: -- slachiewicz commented on code in PR #158: URL: https://github.com/apache/maven-archetype/pull/158#discussion_r1443691792 ## maven-archetype-plugin/pom.xml: ## @@ -172,6 +172,154 @@ + + + + org.apache.maven.plugins + maven-plugin-report-plugin + + + + + Review Comment: i'll fix it > document requirement history > > > Key: ARCHETYPE-652 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-652 > Project: Maven Archetype > Issue Type: Task >Affects Versions: 3.2.1 >Reporter: Herve Boutemy >Priority: Major > Fix For: 3.3.0 > > > required by upgrade to Java 8: people ned to know how to keep a Java 7 > compatible plugin previous release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPOM-453) Disable annotation processing by compiler
[
https://issues.apache.org/jira/browse/MPOM-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803798#comment-17803798
]
Konrad Windszus commented on MPOM-453:
--
Compare with https://github.com/eclipse/sisu.inject/issues/104.
> Disable annotation processing by compiler
> -
>
> Key: MPOM-453
> URL: https://issues.apache.org/jira/browse/MPOM-453
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We can disable annotation processing by default.
> We use {{sisu-maven-plugin}} for processing components annotations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [ARCHETYPE-652] Added system requirements history [maven-archetype]
asfgit closed pull request #158: [ARCHETYPE-652] Added system requirements history URL: https://github.com/apache/maven-archetype/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (ARCHETYPE-652) document requirement history
[ https://issues.apache.org/jira/browse/ARCHETYPE-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803800#comment-17803800 ] ASF GitHub Bot commented on ARCHETYPE-652: -- asfgit closed pull request #158: [ARCHETYPE-652] Added system requirements history URL: https://github.com/apache/maven-archetype/pull/158 > document requirement history > > > Key: ARCHETYPE-652 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-652 > Project: Maven Archetype > Issue Type: Task >Affects Versions: 3.2.1 >Reporter: Herve Boutemy >Priority: Major > Fix For: 3.3.0 > > > required by upgrade to Java 8: people ned to know how to keep a Java 7 > compatible plugin previous release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-652) document requirement history
[ https://issues.apache.org/jira/browse/ARCHETYPE-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803801#comment-17803801 ] ASF GitHub Bot commented on ARCHETYPE-652: -- slachiewicz commented on PR #158: URL: https://github.com/apache/maven-archetype/pull/158#issuecomment-1879646320 Thank You @BrowneMonke for the initial PR. I've updated it to match the configuration for the latest report plugin version and merged it with 2b58aebfbe2398dfc1374114341ec47a2a63c8e4 It also includes now planned 3.3.0 > document requirement history > > > Key: ARCHETYPE-652 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-652 > Project: Maven Archetype > Issue Type: Task >Affects Versions: 3.2.1 >Reporter: Herve Boutemy >Priority: Major > Fix For: 3.3.0 > > > required by upgrade to Java 8: people ned to know how to keep a Java 7 > compatible plugin previous release -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [ARCHETYPE-652] Added system requirements history [maven-archetype]
slachiewicz commented on PR #158: URL: https://github.com/apache/maven-archetype/pull/158#issuecomment-1879646320 Thank You @BrowneMonke for the initial PR. I've updated it to match the configuration for the latest report plugin version and merged it with 2b58aebfbe2398dfc1374114341ec47a2a63c8e4 It also includes now planned 3.3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (ARCHETYPE-652) document requirement history
[ https://issues.apache.org/jira/browse/ARCHETYPE-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned ARCHETYPE-652: -- Assignee: Sylwester Lachiewicz > document requirement history > > > Key: ARCHETYPE-652 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-652 > Project: Maven Archetype > Issue Type: Task >Affects Versions: 3.2.1 >Reporter: Herve Boutemy >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.3.0 > > > required by upgrade to Java 8: people ned to know how to keep a Java 7 > compatible plugin previous release -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]
CrazyHZM commented on PR #208: URL: https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1879687922 > Shouldn't we have a unit test to avoid this regression in the first place? I already add it for this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-462) 3.5.1 not compatible with 3.4.1: The version cannot be empty
[
https://issues.apache.org/jira/browse/MSHADE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803814#comment-17803814
]
ASF GitHub Bot commented on MSHADE-462:
---
CrazyHZM commented on PR #208:
URL:
https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1879687922
> Shouldn't we have a unit test to avoid this regression in the first place?
I already add it for this case.
> 3.5.1 not compatible with 3.4.1: The version cannot be empty
>
>
> Key: MSHADE-462
> URL: https://issues.apache.org/jira/browse/MSHADE-462
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
> Environment: Apache Maven 3.8.8
> (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
> Maven home: /usr/share/apache-maven-3.8.8
> Java version: 17.0.9, vendor: Eclipse Adoptium, runtime:
> /usr/lib/jvm/temurin-17-jdk-amd64
> Default locale: en, platform encoding: UTF-8
> OS name: "linux", version: "6.2.0-1018-azure", arch: "amd64", family: "unix"
>Reporter: Gary D. Gregory
>Priority: Major
>
> When updating Apache Juneau git master from 3.4.1 to 3.5.1, we get:
> {noformat}
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:3.5.1:shade (source-jar) on
> project juneau-all: Execution source-jar of goal
> org.apache.maven.plugins:maven-shade-plugin:3.5.1:shade failed: For artifact
> {org.apache.juneau:juneau-marshall:null:jar}: The version cannot be empty. ->
> [Help 1]
> {noformat}
> See the build failure in the PR https://github.com/apache/juneau/pull/125
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]
garydgregory commented on PR #208: URL: https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1879713133 https://issues.apache.org/jira/browse/MSHADE-462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-462) 3.5.1 not compatible with 3.4.1: The version cannot be empty
[
https://issues.apache.org/jira/browse/MSHADE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803819#comment-17803819
]
ASF GitHub Bot commented on MSHADE-462:
---
garydgregory commented on PR #208:
URL:
https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1879713133
https://issues.apache.org/jira/browse/MSHADE-462
> 3.5.1 not compatible with 3.4.1: The version cannot be empty
>
>
> Key: MSHADE-462
> URL: https://issues.apache.org/jira/browse/MSHADE-462
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
> Environment: Apache Maven 3.8.8
> (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
> Maven home: /usr/share/apache-maven-3.8.8
> Java version: 17.0.9, vendor: Eclipse Adoptium, runtime:
> /usr/lib/jvm/temurin-17-jdk-amd64
> Default locale: en, platform encoding: UTF-8
> OS name: "linux", version: "6.2.0-1018-azure", arch: "amd64", family: "unix"
>Reporter: Gary D. Gregory
>Priority: Major
>
> When updating Apache Juneau git master from 3.4.1 to 3.5.1, we get:
> {noformat}
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:3.5.1:shade (source-jar) on
> project juneau-all: Execution source-jar of goal
> org.apache.maven.plugins:maven-shade-plugin:3.5.1:shade failed: For artifact
> {org.apache.juneau:juneau-marshall:null:jar}: The version cannot be empty. ->
> [Help 1]
> {noformat}
> See the build failure in the PR https://github.com/apache/juneau/pull/125
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-462) 3.5.1 not compatible with 3.4.1: The version cannot be empty
[
https://issues.apache.org/jira/browse/MSHADE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803820#comment-17803820
]
Gary D. Gregory commented on MSHADE-462:
TY [~crazyhzm] !
Would someone on the MSHADE team please take a look SVP?
> 3.5.1 not compatible with 3.4.1: The version cannot be empty
>
>
> Key: MSHADE-462
> URL: https://issues.apache.org/jira/browse/MSHADE-462
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
> Environment: Apache Maven 3.8.8
> (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
> Maven home: /usr/share/apache-maven-3.8.8
> Java version: 17.0.9, vendor: Eclipse Adoptium, runtime:
> /usr/lib/jvm/temurin-17-jdk-amd64
> Default locale: en, platform encoding: UTF-8
> OS name: "linux", version: "6.2.0-1018-azure", arch: "amd64", family: "unix"
>Reporter: Gary D. Gregory
>Priority: Major
>
> When updating Apache Juneau git master from 3.4.1 to 3.5.1, we get:
> {noformat}
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:3.5.1:shade (source-jar) on
> project juneau-all: Execution source-jar of goal
> org.apache.maven.plugins:maven-shade-plugin:3.5.1:shade failed: For artifact
> {org.apache.juneau:juneau-marshall:null:jar}: The version cannot be empty. ->
> [Help 1]
> {noformat}
> See the build failure in the PR https://github.com/apache/juneau/pull/125
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [I] Non-resolvable parent POM [maven-mvnd]
ppalaga commented on issue #905: URL: https://github.com/apache/maven-mvnd/issues/905#issuecomment-1879767598 `mvnd` is primarily an interactive tool for Java developers. It was not designed for Jenkins and similar environments. When doing it anyway, you should consider that deamon re-use may cause serious build reproducibility issues. Please read more in other issues, e.g. here: https://github.com/apache/maven-mvnd/issues/704 To overcome the reproducibility issue, but still profit from parallel builds and sane console output, you may want to try `mvnd.sh` with the `-Dmvnd.noDaemon` flag. Check `mvnd --help` for more info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-component-metadata from 2.1.1 to 2.2.0 [maven-surefire]
asfgit merged PR #715: URL: https://github.com/apache/maven-surefire/pull/715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MSOURCES-137) umask makes artifacts generated by maven-source-plugin not easy to reproduce
[
https://issues.apache.org/jira/browse/MSOURCES-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742302#comment-17742302
]
Herve Boutemy edited comment on MSOURCES-137 at 1/6/24 6:59 PM:
root cause found in plexus-archiver
[https://github.com/codehaus-plexus/plexus-archiver/pull/293] included in 4.8.0
release
was (Author: hboutemy):
root cause found in plexus-archiver
https://github.com/codehaus-plexus/plexus-archiver/pull/293
> umask makes artifacts generated by maven-source-plugin not easy to reproduce
>
>
> Key: MSOURCES-137
> URL: https://issues.apache.org/jira/browse/MSOURCES-137
> Project: Maven Source Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Andreas Veithen
>Priority: Minor
>
> It appears that inside the archive created by maven-source-plugin, the
> permissions of {{META-INF/maven/\*/\*/pom.properties}} depend on the current
> umask.
> Steps to reproduce:
> {code:java}
> $ umask 022
> $ mvn clean install
> $ umask 002
> $ mvn clean verify artifact:compare
> {code}
> This can be used on any project attaching a source jar (e.g.
> [https://github.com/apache/ws-axiom/]).
> Example diffoscope output:
> {code:java}
> --- target/reference/axiom-weaver-annotations-2.0.0-SNAPSHOT-sources.jar
> +++ target/axiom-weaver-annotations-2.0.0-SNAPSHOT-sources.jar
> │┄ Archive contents identical but files differ, possibly due to different
> compression levels. Falling back to binary comparison.
> ├── zipinfo {}
> │ @@ -14,9 +14,9 @@
> │ -rw-r--r-- 2.0 unx 170 b- defN 22-Mar-13 11:17 META-INF/NOTICE
> │ -rw-r--r-- 2.0 unx 1365 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/FactoryMethod.java
> │ -rw-r--r-- 2.0 unx 1101 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/Inject.java
> │ -rw-r--r-- 2.0 unx 1095 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/Mixin.java
> │ -rw-r--r-- 2.0 unx 1100 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/Singleton.java
> │ -rw-r--r-- 2.0 unx 1136 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/WeavablePackage.java
> │ -rw-r--r-- 2.0 unx 1411 b- defN 22-Mar-13 11:17
> META-INF/maven/org.apache.ws.commons.axiom/axiom-weaver-annotations/pom.xml
> │ --rw-r--r-- 2.0 unx 95 b- defN 22-Mar-13 11:17
> META-INF/maven/org.apache.ws.commons.axiom/axiom-weaver-annotations/pom.properties
> │ +-rw-rw-r-- 2.0 unx 95 b- defN 22-Mar-13 11:17
> META-INF/maven/org.apache.ws.commons.axiom/axiom-weaver-annotations/pom.properties
> │ 20 files, 19157 bytes uncompressed, 8089 bytes compressed: 57.8%
> │ --- target/reference/axiom-weaver-annotations-2.0.0-SNAPSHOT-sources.jar
> ├── +++ target/axiom-weaver-annotations-2.0.0-SNAPSHOT-sources.jar
> │ @@ -676,15 +676,15 @@
> │ 2a30: a481 b020 4d45 5441 . ..META
> │ 2a40: 2d49 4e46 2f6d 6176 656e 2f6f 7267 2e61 -INF/maven/org.a
> │ 2a50: 7061 6368 652e 7773 2e63 6f6d 6d6f 6e73 pache.ws.commons
> │ 2a60: 2e61 7869 6f6d 2f61 7869 6f6d 2d77 6561 .axiom/axiom-wea
> │ 2a70: 7665 722d 616e 6e6f 7461 7469 6f6e 732f ver-annotations/
> │ 2a80: 706f 6d2e 786d 6c50 4b01 0214 0314 pom.xmlPK...
> │ 2a90: 0808 0022 5a6d 54b9 68bb 2558 005f ..."ZmT.h.%X..._
> │ -2aa0: 0052 00a4 ...R
> │ +2aa0: 0052 00b4 ...R
> │ 2ab0: 81e8 2300 004d 4554 412d 494e 462f 6d61 ..#..META-INF/ma
> │ 2ac0: 7665 6e2f 6f72 672e 6170 6163 6865 2e77 ven/org.apache.w
> │ 2ad0: 732e 636f 6d6d 6f6e 732e 6178 696f 6d2f s.commons.axiom/
> │ 2ae0: 6178 696f 6d2d 7765 6176 6572 2d61 6e6e axiom-weaver-ann
> │ 2af0: 6f74 6174 696f 6e73 2f70 6f6d 2e70 726f otations/pom.pro
> │ 2b00: 7065 7274 6965 7350 4b05 0600 0014 pertiesPK...
> │ 2b10: 0014 0057 0600 00b0 2400 00 ...W$
> {code}
> Note that although maven-jar-plugin adds the same {{pom.properties}} file to
> the archive, it isn't affected by this problem.
> I discovered this while trying to check the reproducibility of Apache Axiom
> builds in a Github Codespace, where file permissions are set in a peculiar
> way; see [https://github.com/orgs/community/discussions/26026].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MSOURCES-137) umask makes artifacts generated by maven-source-plugin not easy to reproduce
[
https://issues.apache.org/jira/browse/MSOURCES-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy closed MSOURCES-137.
--
Fix Version/s: 3.3.1
Assignee: Herve Boutemy
Resolution: Fixed
fixed by MSOURCES-142 to benefit from plexus-archiver 4.8.0
> umask makes artifacts generated by maven-source-plugin not easy to reproduce
>
>
> Key: MSOURCES-137
> URL: https://issues.apache.org/jira/browse/MSOURCES-137
> Project: Maven Source Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Andreas Veithen
>Assignee: Herve Boutemy
>Priority: Minor
> Fix For: 3.3.1
>
>
> It appears that inside the archive created by maven-source-plugin, the
> permissions of {{META-INF/maven/\*/\*/pom.properties}} depend on the current
> umask.
> Steps to reproduce:
> {code:java}
> $ umask 022
> $ mvn clean install
> $ umask 002
> $ mvn clean verify artifact:compare
> {code}
> This can be used on any project attaching a source jar (e.g.
> [https://github.com/apache/ws-axiom/]).
> Example diffoscope output:
> {code:java}
> --- target/reference/axiom-weaver-annotations-2.0.0-SNAPSHOT-sources.jar
> +++ target/axiom-weaver-annotations-2.0.0-SNAPSHOT-sources.jar
> │┄ Archive contents identical but files differ, possibly due to different
> compression levels. Falling back to binary comparison.
> ├── zipinfo {}
> │ @@ -14,9 +14,9 @@
> │ -rw-r--r-- 2.0 unx 170 b- defN 22-Mar-13 11:17 META-INF/NOTICE
> │ -rw-r--r-- 2.0 unx 1365 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/FactoryMethod.java
> │ -rw-r--r-- 2.0 unx 1101 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/Inject.java
> │ -rw-r--r-- 2.0 unx 1095 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/Mixin.java
> │ -rw-r--r-- 2.0 unx 1100 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/Singleton.java
> │ -rw-r--r-- 2.0 unx 1136 b- defN 22-Mar-13 11:17
> org/apache/axiom/weaver/annotation/WeavablePackage.java
> │ -rw-r--r-- 2.0 unx 1411 b- defN 22-Mar-13 11:17
> META-INF/maven/org.apache.ws.commons.axiom/axiom-weaver-annotations/pom.xml
> │ --rw-r--r-- 2.0 unx 95 b- defN 22-Mar-13 11:17
> META-INF/maven/org.apache.ws.commons.axiom/axiom-weaver-annotations/pom.properties
> │ +-rw-rw-r-- 2.0 unx 95 b- defN 22-Mar-13 11:17
> META-INF/maven/org.apache.ws.commons.axiom/axiom-weaver-annotations/pom.properties
> │ 20 files, 19157 bytes uncompressed, 8089 bytes compressed: 57.8%
> │ --- target/reference/axiom-weaver-annotations-2.0.0-SNAPSHOT-sources.jar
> ├── +++ target/axiom-weaver-annotations-2.0.0-SNAPSHOT-sources.jar
> │ @@ -676,15 +676,15 @@
> │ 2a30: a481 b020 4d45 5441 . ..META
> │ 2a40: 2d49 4e46 2f6d 6176 656e 2f6f 7267 2e61 -INF/maven/org.a
> │ 2a50: 7061 6368 652e 7773 2e63 6f6d 6d6f 6e73 pache.ws.commons
> │ 2a60: 2e61 7869 6f6d 2f61 7869 6f6d 2d77 6561 .axiom/axiom-wea
> │ 2a70: 7665 722d 616e 6e6f 7461 7469 6f6e 732f ver-annotations/
> │ 2a80: 706f 6d2e 786d 6c50 4b01 0214 0314 pom.xmlPK...
> │ 2a90: 0808 0022 5a6d 54b9 68bb 2558 005f ..."ZmT.h.%X..._
> │ -2aa0: 0052 00a4 ...R
> │ +2aa0: 0052 00b4 ...R
> │ 2ab0: 81e8 2300 004d 4554 412d 494e 462f 6d61 ..#..META-INF/ma
> │ 2ac0: 7665 6e2f 6f72 672e 6170 6163 6865 2e77 ven/org.apache.w
> │ 2ad0: 732e 636f 6d6d 6f6e 732e 6178 696f 6d2f s.commons.axiom/
> │ 2ae0: 6178 696f 6d2d 7765 6176 6572 2d61 6e6e axiom-weaver-ann
> │ 2af0: 6f74 6174 696f 6e73 2f70 6f6d 2e70 726f otations/pom.pro
> │ 2b00: 7065 7274 6965 7350 4b05 0600 0014 pertiesPK...
> │ 2b10: 0014 0057 0600 00b0 2400 00 ...W$
> {code}
> Note that although maven-jar-plugin adds the same {{pom.properties}} file to
> the archive, it isn't affected by this problem.
> I discovered this while trying to check the reproducibility of Apache Axiom
> builds in a Github Codespace, where file permissions are set in a peculiar
> way; see [https://github.com/orgs/community/discussions/26026].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSOURCES-141) Check duplication of attached jar should be configurable to not fail when using the build cache
[
https://issues.apache.org/jira/browse/MSOURCES-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MSOURCES-141:
---
Description:
because MSOURCES-121 using source jar mojo and build cache generate an error as
the cache restore a project with attached artifacts and so the source mojo fail
because of this.
{code}
Caused by: org.apache.maven.plugin.MojoExecutionException: Presumably you have
configured maven-source-plugn to execute twice times in your build. You have to
configure a classifier for at least on of them.
at org.apache.maven.plugins.source.AbstractSourceJarMojo.packageSources
(AbstractSourceJarMojo.java:309)
at org.apache.maven.plugins.source.AbstractSourceJarMojo.packageSources
(AbstractSourceJarMojo.java:257)
at org.apache.maven.plugins.source.AbstractSourceJarMojo.execute
(AbstractSourceJarMojo.java:225)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:126)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:328)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
(MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
(MojoExecutor.java:162)
at
org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject
(BuildCacheMojosExecutionStrategy.java:224)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:131)
{code}
was:
because https://issues.apache.org/jira/browse/MSOURCES-121 using source jar
mojo and build cache generate an error as the cache restore a project with
attached artifacts and so the source mojo fail because of this.
{code}
Caused by: org.apache.maven.plugin.MojoExecutionException: Presumably you have
configured maven-source-plugn to execute twice times in your build. You have to
configure a classifier for at least on of them.
at org.apache.maven.plugins.source.AbstractSourceJarMojo.packageSources
(AbstractSourceJarMojo.java:309)
at org.apache.maven.plugins.source.AbstractSourceJarMojo.packageSources
(AbstractSourceJarMojo.java:257)
at org.apache.maven.plugins.source.AbstractSourceJarMojo.execute
(AbstractSourceJarMojo.java:225)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:126)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:328)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
(MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
(MojoExecutor.java:162)
at
org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject
(BuildCacheMojosExecutionStrategy.java:224)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:131)
{code}
> Check duplication of attached jar should be configurable to not fail when
> using the build cache
> ---
>
> Key: MSOURCES-141
> URL: https://issues.apache.org/jira/browse/MSOURCES-141
> Project: Maven Source Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.3.1
>
> Attachments: issue-msources-141.zip
>
>
> because MSOURCES-121 using source jar mojo and build cache generate an error
> as the cache restore a project with attached artifacts and so the source mojo
> fail because of this.
> {code}
> Caused by: org.apache.maven.plugin.MojoExecutionException: Presumably you
> have configured maven-source-plugn to execute twice times in your build. You
> have to configure a classifier for at least on of them.
> at org.apache.maven.plugins.source.AbstractSourceJarMojo.packageSources
> (AbstractSourceJarMojo.java:309)
> at org.apache.maven.plugins.source.AbstractSourceJarMojo.packageSources
> (AbstractSourceJarMojo.java:257)
> at org.apache.maven.plugins.source.AbstractSourceJarMojo.execute
> (AbstractSourceJarMojo.java:225)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126)
> at org.apache.maven.lifecycle.i
[jira] [Updated] (MSOURCES-121) Check for duplicated addition of the same file
[ https://issues.apache.org/jira/browse/MSOURCES-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MSOURCES-121: --- Description: By configuring the execution of maven-source-plugin twice, you can fail the build during a release only which is annoying for users. We need to check if we could identify the duplicate execution of maven-source-plugin and producing the same files twice... If we identify such situation we should fail the build. was: By configuring the execution of maven-source-plugin twice you can fail the build during a release only which is annoying for users. We need to check if we could identify the duplicate execution of maven-source-plugin and producing the same files twice...If we identify such situation we should fail the build. > Check for duplicated addition of the same file > -- > > Key: MSOURCES-121 > URL: https://issues.apache.org/jira/browse/MSOURCES-121 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.0.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Critical > Fix For: 3.3.0 > > > By configuring the execution of maven-source-plugin twice, you can fail the > build during a release only which is annoying for users. > We need to check if we could identify the duplicate execution of > maven-source-plugin and producing the same files twice... If we identify such > situation we should fail the build. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803865#comment-17803865 ] ASF GitHub Bot commented on MNG-6776: - michael-o opened a new pull request, #1362: URL: https://github.com/apache/maven/pull/1362 It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. Co-authored-by: Marc Wrobel Co-authored-by: Slawomir Jaranowski (cherry picked from commit cc51006f2973356a1046ae0757325d5e9be75327) (cherry picked from commit 5ce5591ae341188230d6ecca76c90bd0a786fcb2) (cherry picked from commit 47e2d689d687358a85c2cdecc176cac36093817e) --- https://issues.apache.org/jira/browse/MNG-7309 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o opened a new pull request, #1362: URL: https://github.com/apache/maven/pull/1362 It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. Co-authored-by: Marc Wrobel Co-authored-by: Slawomir Jaranowski (cherry picked from commit cc51006f2973356a1046ae0757325d5e9be75327) (cherry picked from commit 5ce5591ae341188230d6ecca76c90bd0a786fcb2) (cherry picked from commit 47e2d689d687358a85c2cdecc176cac36093817e) --- https://issues.apache.org/jira/browse/MNG-7309 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
fanshichao commented on PR #1362: URL: https://github.com/apache/maven/pull/1362#issuecomment-1879823720 这是来自QQ邮箱的假期自动回复邮件。 您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803866#comment-17803866 ] ASF GitHub Bot commented on MNG-6776: - fanshichao commented on PR #1362: URL: https://github.com/apache/maven/pull/1362#issuecomment-1879823720 这是来自QQ邮箱的假期自动回复邮件。 您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。 > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (ARCHETYPE-652) document requirement history
[ https://issues.apache.org/jira/browse/ARCHETYPE-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed ARCHETYPE-652. -- Resolution: Fixed > document requirement history > > > Key: ARCHETYPE-652 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-652 > Project: Maven Archetype > Issue Type: Task >Affects Versions: 3.2.1 >Reporter: Herve Boutemy >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.3.0 > > > required by upgrade to Java 8: people ned to know how to keep a Java 7 > compatible plugin previous release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-442) org.codehaus.plexus:plexus-utils 3.5.0 -> 4.0.0
[ https://issues.apache.org/jira/browse/MPIR-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803871#comment-17803871 ] Sylwester Lachiewicz commented on MPIR-442: --- we don't have plans to stay with 3.x > org.codehaus.plexus:plexus-utils 3.5.0 -> 4.0.0 > > > Key: MPIR-442 > URL: https://issues.apache.org/jira/browse/MPIR-442 > Project: Maven Project Info Reports Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > > The split of plexus-utils and plexus-xml in 4.0.0 risks split package > problems in Java 9+: > https://jlbp.dev/JLBP-19 > It might be better to stick with 3.5 indefinitely. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-1271) deprecate fileutils
[ https://issues.apache.org/jira/browse/MSHARED-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-1271: -- Component/s: maven-shared-utils > deprecate fileutils > --- > > Key: MSHARED-1271 > URL: https://issues.apache.org/jira/browse/MSHARED-1271 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > > Seems all the methods have replacements in apache commons -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-1271) deprecate fileutils
[ https://issues.apache.org/jira/browse/MSHARED-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-1271: -- Fix Version/s: maven-shared-utils-next-release > deprecate fileutils > --- > > Key: MSHARED-1271 > URL: https://issues.apache.org/jira/browse/MSHARED-1271 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: maven-shared-utils-next-release > > > Seems all the methods have replacements in apache commons -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1271) deprecate fileutils
[ https://issues.apache.org/jira/browse/MSHARED-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSHARED-1271. - Resolution: Fixed > deprecate fileutils > --- > > Key: MSHARED-1271 > URL: https://issues.apache.org/jira/browse/MSHARED-1271 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: maven-shared-utils-next-release > > > Seems all the methods have replacements in apache commons -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1273) getFiles/getFileNames do not throw IOException
[ https://issues.apache.org/jira/browse/MSHARED-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSHARED-1273. - Resolution: Fixed > getFiles/getFileNames do not throw IOException > -- > > Key: MSHARED-1273 > URL: https://issues.apache.org/jira/browse/MSHARED-1273 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: maven-shared-utils-next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-1273) getFiles/getFileNames do not throw IOException
[ https://issues.apache.org/jira/browse/MSHARED-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-1273: -- Fix Version/s: maven-shared-utils-next-release > getFiles/getFileNames do not throw IOException > -- > > Key: MSHARED-1273 > URL: https://issues.apache.org/jira/browse/MSHARED-1273 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: maven-shared-utils-next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-io from 3.4.1 to 3.4.2 [maven-javadoc-plugin]
slachiewicz merged PR #257: URL: https://github.com/apache/maven-javadoc-plugin/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1 [maven-javadoc-plugin]
slachiewicz merged PR #256: URL: https://github.com/apache/maven-javadoc-plugin/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
asfgit merged PR #1361: URL: https://github.com/apache/maven/pull/1361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803872#comment-17803872 ] ASF GitHub Bot commented on MNG-6776: - asfgit merged PR #1361: URL: https://github.com/apache/maven/pull/1361 > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o commented on PR #1362: URL: https://github.com/apache/maven/pull/1362#issuecomment-1879829855 @slachiewicz As requested... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7309) Remove redundant MojoDescriptor parameterMap
[
https://issues.apache.org/jira/browse/MNG-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803873#comment-17803873
]
Michael Osipov commented on MNG-7309:
-
Fixed with
[b23afbc9849d57b0a4ff0f2bdd3fff5520a95f7c|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=b23afbc9849d57b0a4ff0f2bdd3fff5520a95f7c]
for {{maven-3.9.x}} branch.
> Remove redundant MojoDescriptor parameterMap
>
>
> Key: MNG-7309
> URL: https://issues.apache.org/jira/browse/MNG-7309
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.0-alpha-2, 4.0.0
>
>
> The class maven-plugin-api:MojoDescriptor contains a list of parameters and a
> map of parameters:
> https://maven.apache.org/ref/3.8.4/maven-plugin-api/xref/org/apache/maven/plugin/descriptor/MojoDescriptor.html#L58
> The code is broken, in a way that the two – that should contain same things –
> may end up not containing same things.
> Note: not that anything uses it in such way, as instances of this class are
> loaded up from descriptor, but still, it may easily lead to confusion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803874#comment-17803874 ] ASF GitHub Bot commented on MNG-6776: - michael-o commented on PR #1362: URL: https://github.com/apache/maven/pull/1362#issuecomment-1879829855 @slachiewicz As requested... > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-plugin-tools]
slachiewicz merged PR #256: URL: https://github.com/apache/maven-plugin-tools/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-plugin-tools]
michael-o commented on PR #254: URL: https://github.com/apache/maven-plugin-tools/pull/254#issuecomment-1879830301 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-plugin-tools]
dependabot[bot] commented on PR #254: URL: https://github.com/apache/maven-plugin-tools/pull/254#issuecomment-1879830398 Looks like org.jsoup:jsoup is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-plugin-tools]
dependabot[bot] closed pull request #254: Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 URL: https://github.com/apache/maven-plugin-tools/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7309) Remove redundant MojoDescriptor parameterMap
[ https://issues.apache.org/jira/browse/MNG-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7309: Fix Version/s: 3.9.7 (was: 3.9.x-candidate) > Remove redundant MojoDescriptor parameterMap > > > Key: MNG-7309 > URL: https://issues.apache.org/jira/browse/MNG-7309 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7, 4.0.0-alpha-2, 4.0.0 > > > The class maven-plugin-api:MojoDescriptor contains a list of parameters and a > map of parameters: > https://maven.apache.org/ref/3.8.4/maven-plugin-api/xref/org/apache/maven/plugin/descriptor/MojoDescriptor.html#L58 > The code is broken, in a way that the two – that should contain same things – > may end up not containing same things. > Note: not that anything uses it in such way, as instances of this class are > loaded up from descriptor, but still, it may easily lead to confusion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1443866032
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
@kwin Can we merge this as-is as a compromise like all other components just
use `provided` scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803875#comment-17803875
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1443866032
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
@kwin Can we merge this as-is as a compromise like all other components just
use `provided` scope?
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-324] Allow configuration of Doxia parser [maven-doxia-sitetools]
michael-o commented on code in PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#discussion_r1443866765
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfiguration.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.doxia.siterenderer;
+
+import java.util.function.Consumer;
+
+import org.apache.maven.doxia.parser.Parser;
+
+/**
+ * Configures a Doxia {@link Parser}.
+ * @since 2.0.0
+ */
+@FunctionalInterface
+public interface ParserConfiguration extends Consumer {
+
+/**
+ * Applies the configuration to the given parser.
+ * @param parser the parser to configure
+ */
+@Override
+void accept(Parser parser);
Review Comment:
Wouldn't `configure()` be more reasonable here?
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DocumentRenderingContext.java:
##
@@ -286,4 +319,13 @@ public String getDoxiaSourcePath() {
public String getDoxiaSourcePath(String base) {
return PathTool.calculateLink(getDoxiaSourcePath(), base);
}
+
+/**
+ * Get the configuration to use for the parsing the document or {@code
null} if the default configuration should be used (or if this context
+ * is not for a Doxia markup source, i.e. not parsing is involved).
Review Comment:
no parsing
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DocumentRenderingContext.java:
##
@@ -101,8 +103,39 @@ public DocumentRenderingContext(
String extension,
boolean editable,
String generator) {
+this(basedir, basedirRelativePath, document, parserId, null,
extension, editable, generator);
+}
+
+/**
+ *
+ * Constructor for document rendering context.
+ *
+ *
+ * @param basedir the source base directory (not null, pseudo value when
not a Doxia source).
+ * @param basedirRelativePath the relative path from root (null if not
Doxia source)
+ * @param document the source document path.
+ * @param parserId the Doxia module parser id associated to this document,
may be null if document not rendered from
+ *a Doxia markup source.
+ * @param parserConfiguration the configuration to use for the Doxia
parser, may be {@null} if default should be used or if
+ *document is not rendered from a Doxia markup source
+ * @param extension the source document filename extension, may be null if
document not rendered from
+ *a Doxia source.
+ * @param editable is the document editable as source, i.e. not generated?
+ * @param generator the generator (in general a reporting goal:
groupId:artifactId:version:goal)
+ * @since 2.0
Review Comment:
2.0.0
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -388,4 +391,20 @@ public File getRootDirectory() {
public void setRootDirectory(File rootDirectory) {
this.rootDirectory = rootDirectory;
}
+
+/**
+ *
+ * @return the retriever for parser configurations (only relevant for
Doxia sources)
+ * @since 2.0.0
+ */
+public ParserConfigurationRetriever getParserConfigurationRetriever() {
+if (parserConfigurationRetriever == null) {
Review Comment:
Am I stupid or why not just return the object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser (per markup source path pattern)
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803876#comment-17803876
]
ASF GitHub Bot commented on DOXIASITETOOLS-324:
---
michael-o commented on code in PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#discussion_r1443866765
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfiguration.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.doxia.siterenderer;
+
+import java.util.function.Consumer;
+
+import org.apache.maven.doxia.parser.Parser;
+
+/**
+ * Configures a Doxia {@link Parser}.
+ * @since 2.0.0
+ */
+@FunctionalInterface
+public interface ParserConfiguration extends Consumer {
+
+/**
+ * Applies the configuration to the given parser.
+ * @param parser the parser to configure
+ */
+@Override
+void accept(Parser parser);
Review Comment:
Wouldn't `configure()` be more reasonable here?
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DocumentRenderingContext.java:
##
@@ -286,4 +319,13 @@ public String getDoxiaSourcePath() {
public String getDoxiaSourcePath(String base) {
return PathTool.calculateLink(getDoxiaSourcePath(), base);
}
+
+/**
+ * Get the configuration to use for the parsing the document or {@code
null} if the default configuration should be used (or if this context
+ * is not for a Doxia markup source, i.e. not parsing is involved).
Review Comment:
no parsing
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DocumentRenderingContext.java:
##
@@ -101,8 +103,39 @@ public DocumentRenderingContext(
String extension,
boolean editable,
String generator) {
+this(basedir, basedirRelativePath, document, parserId, null,
extension, editable, generator);
+}
+
+/**
+ *
+ * Constructor for document rendering context.
+ *
+ *
+ * @param basedir the source base directory (not null, pseudo value when
not a Doxia source).
+ * @param basedirRelativePath the relative path from root (null if not
Doxia source)
+ * @param document the source document path.
+ * @param parserId the Doxia module parser id associated to this document,
may be null if document not rendered from
+ *a Doxia markup source.
+ * @param parserConfiguration the configuration to use for the Doxia
parser, may be {@null} if default should be used or if
+ *document is not rendered from a Doxia markup source
+ * @param extension the source document filename extension, may be null if
document not rendered from
+ *a Doxia source.
+ * @param editable is the document editable as source, i.e. not generated?
+ * @param generator the generator (in general a reporting goal:
groupId:artifactId:version:goal)
+ * @since 2.0
Review Comment:
2.0.0
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -388,4 +391,20 @@ public File getRootDirectory() {
public void setRootDirectory(File rootDirectory) {
this.rootDirectory = rootDirectory;
}
+
+/**
+ *
+ * @return the retriever for parser configurations (only relevant for
Doxia sources)
+ * @since 2.0.0
+ */
+public ParserConfigurationRetriever getParserConfigurationRetriever() {
+if (parserConfigurationRetriever == null) {
Review Comment:
Am I stupid or why not just return the object?
> Allow configuration of parser (per markup source path pattern)
> --
>
> Key: DOXIASITETOOLS-324
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-324
> Project: Maven Doxia Sitetools
> Issue Type: New Feature
> Components: Site renderer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>P
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
asfgit merged PR #1362: URL: https://github.com/apache/maven/pull/1362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803877#comment-17803877 ] ASF GitHub Bot commented on MNG-6776: - asfgit merged PR #1362: URL: https://github.com/apache/maven/pull/1362 > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7309) Remove redundant MojoDescriptor parameterMap
[
https://issues.apache.org/jira/browse/MNG-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803878#comment-17803878
]
Michael Osipov commented on MNG-7309:
-
Fixed with
[b953b14928f657804b608520ef5cb3fb22c6038f|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=b953b14928f657804b608520ef5cb3fb22c6038f]
for {{maven-3.8.x}} branch.
> Remove redundant MojoDescriptor parameterMap
>
>
> Key: MNG-7309
> URL: https://issues.apache.org/jira/browse/MNG-7309
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7, 4.0.0-alpha-2, 4.0.0
>
>
> The class maven-plugin-api:MojoDescriptor contains a list of parameters and a
> map of parameters:
> https://maven.apache.org/ref/3.8.4/maven-plugin-api/xref/org/apache/maven/plugin/descriptor/MojoDescriptor.html#L58
> The code is broken, in a way that the two – that should contain same things –
> may end up not containing same things.
> Note: not that anything uses it in such way, as instances of this class are
> loaded up from descriptor, but still, it may easily lead to confusion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7309) Remove redundant MojoDescriptor parameterMap
[ https://issues.apache.org/jira/browse/MNG-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7309: Fix Version/s: 3.8.9 > Remove redundant MojoDescriptor parameterMap > > > Key: MNG-7309 > URL: https://issues.apache.org/jira/browse/MNG-7309 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.8.9, 3.9.7, 4.0.0-alpha-2, 4.0.0 > > > The class maven-plugin-api:MojoDescriptor contains a list of parameters and a > map of parameters: > https://maven.apache.org/ref/3.8.4/maven-plugin-api/xref/org/apache/maven/plugin/descriptor/MojoDescriptor.html#L58 > The code is broken, in a way that the two – that should contain same things – > may end up not containing same things. > Note: not that anything uses it in such way, as instances of this class are > loaded up from descriptor, but still, it may easily lead to confusion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776 ] Sylwester Lachiewicz deleted comment on MNG-6776: --- was (Author: githubbot): fanshichao commented on PR #1362: URL: https://github.com/apache/maven/pull/1362#issuecomment-1879823720 这是来自QQ邮箱的假期自动回复邮件。 您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。 > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]
asfgit closed pull request #253: [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter URL: https://github.com/apache/maven-plugin-tools/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter
[
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803881#comment-17803881
]
ASF GitHub Bot commented on MPLUGIN-495:
asfgit closed pull request #253: [MPLUGIN-495] WARNINGs based on usage of
@Component for MavenSession/MavenProject instead of @Parameter
URL: https://github.com/apache/maven-plugin-tools/pull/253
> WARNINGs based on usage of @Component for MavenSession/MavenProject instead
> of @Parameter
> -
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
> Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 3.11.0
>
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning: Deprecated @Component annotation for 'session' field in
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter(
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components
> to be injected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter
[
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MPLUGIN-495.
--
Resolution: Fixed
Fixed with
[641849004597c74304b9d7e06379190130bdaf3e|https://gitbox.apache.org/repos/asf?p=maven-plugin-tools.git;a=commit;h=641849004597c74304b9d7e06379190130bdaf3e].
> WARNINGs based on usage of @Component for MavenSession/MavenProject instead
> of @Parameter
> -
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
> Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 3.11.0
>
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning: Deprecated @Component annotation for 'session' field in
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter(
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components
> to be injected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Add JDK 21 to default tests [maven-gh-actions-shared]
slachiewicz opened a new pull request, #91: URL: https://github.com/apache/maven-gh-actions-shared/pull/91 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-5695] document Maven 3.2.5+ scoped components usage [maven-plugin-tools]
asfgit closed pull request #236: [MNG-5695] document Maven 3.2.5+ scoped components usage URL: https://github.com/apache/maven-plugin-tools/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-5695] document Maven 3.2.5+ scoped components usage [maven-plugin-tools]
asfgit merged PR #236: URL: https://github.com/apache/maven-plugin-tools/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-5695) inconsistent custom Guice scope bindings
[
https://issues.apache.org/jira/browse/MNG-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803883#comment-17803883
]
ASF GitHub Bot commented on MNG-5695:
-
asfgit closed pull request #236: [MNG-5695] document Maven 3.2.5+ scoped
components usage
URL: https://github.com/apache/maven-plugin-tools/pull/236
> inconsistent custom Guice scope bindings
>
>
> Key: MNG-5695
> URL: https://issues.apache.org/jira/browse/MNG-5695
> Project: Maven
> Issue Type: Bug
>Reporter: Igor Fedorenko
>Assignee: igorfie
>Priority: Major
> Fix For: 3.2.5
>
>
> - Session scope ({{MavenSession}}) is only available for maven core and core
> extensions components (i.e. -Dmaven.ext.class.path stuff), but does not work
> for components from maven plugins.
> - Mojo execution scope ({{MavenProject}} and {{MojoExecution}}) works for
> components from maven plugins but not for maven core and core extensions.
> Need to consistently bind custom Guice scopes in all realms.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5695) inconsistent custom Guice scope bindings
[
https://issues.apache.org/jira/browse/MNG-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803884#comment-17803884
]
ASF GitHub Bot commented on MNG-5695:
-
asfgit merged PR #236:
URL: https://github.com/apache/maven-plugin-tools/pull/236
> inconsistent custom Guice scope bindings
>
>
> Key: MNG-5695
> URL: https://issues.apache.org/jira/browse/MNG-5695
> Project: Maven
> Issue Type: Bug
>Reporter: Igor Fedorenko
>Assignee: igorfie
>Priority: Major
> Fix For: 3.2.5
>
>
> - Session scope ({{MavenSession}}) is only available for maven core and core
> extensions components (i.e. -Dmaven.ext.class.path stuff), but does not work
> for components from maven plugins.
> - Mojo execution scope ({{MavenProject}} and {{MojoExecution}}) works for
> components from maven plugins but not for maven core and core extensions.
> Need to consistently bind custom Guice scopes in all realms.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 [maven-jdeprscan-plugin]
slachiewicz merged PR #12: URL: https://github.com/apache/maven-jdeprscan-plugin/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-utils from 3.4.1 to 3.4.2 [maven-shared-incremental]
slachiewicz merged PR #26: URL: https://github.com/apache/maven-shared-incremental/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 40 to 41 [maven-jdeprscan-plugin]
dependabot[bot] commented on PR #15: URL: https://github.com/apache/maven-jdeprscan-plugin/pull/15#issuecomment-1879900226 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 40 to 41 [maven-jdeprscan-plugin]
slachiewicz closed pull request #15: Bump org.apache.maven.plugins:maven-plugins from 40 to 41 URL: https://github.com/apache/maven-jdeprscan-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJDEPRSCAN-10) Upgrade maven-plugin parent to 41
[ https://issues.apache.org/jira/browse/MJDEPRSCAN-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803889#comment-17803889 ] ASF GitHub Bot commented on MJDEPRSCAN-10: -- slachiewicz opened a new pull request, #17: URL: https://github.com/apache/maven-jdeprscan-plugin/pull/17 (no comment) > Upgrade maven-plugin parent to 41 > - > > Key: MJDEPRSCAN-10 > URL: https://issues.apache.org/jira/browse/MJDEPRSCAN-10 > Project: Maven JDeprScan Plugin > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJDEPRSCAN-9) jdeprscan plugin does not work when JAVA_HOME is not set
[
https://issues.apache.org/jira/browse/MJDEPRSCAN-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MJDEPRSCAN-9:
--
Fix Version/s: 3.0.0
> jdeprscan plugin does not work when JAVA_HOME is not set
>
>
> Key: MJDEPRSCAN-9
> URL: https://issues.apache.org/jira/browse/MJDEPRSCAN-9
> Project: Maven JDeprScan Plugin
> Issue Type: Wish
>Affects Versions: 3.0.0-alpha-1
> Environment: Ubuntu 22.04.2 LTS
> 5.15.0-69-generic #76-Ubuntu SMP x86_64 GNU/Linux
> Installed JDK:
> Package: openjdk-11-jdk
> Version: 11.0.18+10-0ubuntu1~22.04
> openjdk 11.0.18 2023-01-17
> OpenJDK Runtime Environment (build 11.0.18+10-post-Ubuntu-0ubuntu122.04)
> OpenJDK 64-Bit Server VM (build 11.0.18+10-post-Ubuntu-0ubuntu122.04, mixed
> mode, sharing)
> $JAVA_HOME is empty
>Reporter: Andrii Radistao
>Priority: Minor
> Fix For: 3.0.0
>
>
> When running command
>
> {code:java}
> mvn jdeprscan:jdeprscan{code}
>
> (or any other maven workflow, which uses jdeprscan)
> on _any_ project without specified system environment variable {{JAVA_HOME}}
> - the build fails with the error:
> {quote}[ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-jdeprscan-plugin:3.0.0-alpha-1:jdeprscan
> (default-cli) on project cloud-backend-internal-client: Unable to find
> jdeprscan command: The environment variable JAVA_HOME is not correctly set.
> -> [Help 1]
> {quote}
> all other maven tools ({{{}javac{}}}, {{{}jar{}}}, tests) and most of other
> plugins work fine without {{JAVA_HOME}} specified
> Note, that we use default java-11 installation on Debian (Ubuntu):
>
> {code:java}
> openjdk-11-jdk:amd64 11.0.18+10-0ubuntu1~22.04 amd64{code}
> which doesn't set JAVA_HOME by default, but still has {{jdeprscan}} installed
> and provided in the PATH (same as {{javac}} or {{{}jar{}}}):
>
>
> {code:java}
> $ command -v jdeprscan
> /usr/bin/jdeprscan
> $ jdeprscan --version
> 11.0.18{code}
>
> The issue happens because {{maven-jdeprscan-plugin:3.0.0-alpha-1}} resolves
> executable path only by toolchain or JAVA_HOME, but ignores default {{PATH}}
> (like {{javac}} or {{jar}} do) or JDK installation configuration:
> [https://github.com/apache/maven-jdeprscan-plugin/blob/36641ba0b618bf1e8bf84c51ac4f07e60cf0c01b/src/main/java/org/apache/maven/plugins/jdeprscan/AbstractJDeprScanMojo.java#L148-L154]
>
>
> {code:java}
> if ( !jdeprscanExe.exists() || !jdeprscanExe.isFile() )
> {
> Properties env = CommandLineUtils.getSystemEnvVars();
> String javaHome = env.getProperty( "JAVA_HOME" );
> if ( StringUtils.isEmpty( javaHome ) )
> {
> throw new IOException( "The environment variable JAVA_HOME is not
> correctly set." );
> }{code}
> *Proposition:*
> consider resolving {{jdeprscan}} executable location either by default
> {{PATH}} or by {{{}SystemUtils#getJavaHome{}}}, like in [this
> line|https://github.com/apache/maven-jdeprscan-plugin/blob/36641ba0b618bf1e8bf84c51ac4f07e60cf0c01b/src/main/java/org/apache/maven/plugins/jdeprscan/AbstractJDeprScanMojo.java#L142-L144]:
> {code:java}
> jdeprscanExe =
> new File( SystemUtils.getJavaHome() + File.separator + ".." +
> File.separator + "sh", jdepsCommand );{code}
> *but* without {{".." + File.separator + "sh"}}
> i tried and it proved to work:
> {code:java}
> new File( SystemUtils.getJavaHome() + File.separator + "bin", jdepsCommand
> );{code}
> I can supply a PR if this helps.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
