[GitHub] [maven-mvnd] gnodet merged pull request #680: System properties should have precedence over environment variables, fixes #675
gnodet merged PR #680: URL: https://github.com/apache/maven-mvnd/pull/680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet closed issue #675: How do I change the JDK dynamically
gnodet closed issue #675: How do I change the JDK dynamically URL: https://github.com/apache/maven-mvnd/issues/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #670: bash-completion gives error "__git_reassemble_comp_words_by_ref: command not found"
gnodet commented on issue #670: URL: https://github.com/apache/maven-mvnd/issues/670#issuecomment-1239147128 You need to install [git bash completion](https://stackoverflow.com/questions/12399002/how-to-configure-git-bash-command-line-completion). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-45) Migrate/Sync startup scripts with Maven 4
[ https://issues.apache.org/jira/browse/MWRAPPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601224#comment-17601224 ] Jimisola Laursen commented on MWRAPPER-45: -- Just to confirm, Maven 4 has not been released yet to my knowledge. What is Maven 4 referring to? > Migrate/Sync startup scripts with Maven 4 > - > > Key: MWRAPPER-45 > URL: https://issues.apache.org/jira/browse/MWRAPPER-45 > Project: Maven Wrapper > Issue Type: Task > Components: Maven Wrapper Scripts >Affects Versions: 3.1.0 >Reporter: Michael Osipov >Priority: Major > > The scripts are Maven 3 based. Maven 4 has simplified the scripts and > introduced consistency improvements. We should port those over for version 4?! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] gzm55 commented on issue #670: bash-completion gives error "__git_reassemble_comp_words_by_ref: command not found"
gzm55 commented on issue #670: URL: https://github.com/apache/maven-mvnd/issues/670#issuecomment-1239235884 can we inline this implicit dependency shell function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #670: bash-completion gives error "__git_reassemble_comp_words_by_ref: command not found"
gnodet commented on issue #670: URL: https://github.com/apache/maven-mvnd/issues/670#issuecomment-1239341480 #gzm55 can you check the fix at #682 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gzm55 commented on issue #670: bash-completion gives error "__git_reassemble_comp_words_by_ref: command not found"
gzm55 commented on issue #670: URL: https://github.com/apache/maven-mvnd/issues/670#issuecomment-1239350104 > @gzm55 can you check the fix at #682 ? it works @gnodet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet closed issue #670: bash-completion gives error "__git_reassemble_comp_words_by_ref: command not found"
gnodet closed issue #670: bash-completion gives error "__git_reassemble_comp_words_by_ref: command not found" URL: https://github.com/apache/maven-mvnd/issues/670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet merged pull request #682: Add missing function for mvnd-bash-completion, fixes #670
gnodet merged PR #682: URL: https://github.com/apache/maven-mvnd/pull/682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-48) Error "}" was unexpected at this time (Windows 10)
[ https://issues.apache.org/jira/browse/MWRAPPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601310#comment-17601310 ] Svein commented on MWRAPPER-48: --- See: https://issues.apache.org/jira/browse/MWRAPPER-76 Is this project dead? Seems to be no activity? > Error "}" was unexpected at this time (Windows 10) > -- > > Key: MWRAPPER-48 > URL: https://issues.apache.org/jira/browse/MWRAPPER-48 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 0.5.6 >Reporter: Valentin Despa >Priority: Major > Labels: waiting-for-feedback > Fix For: 3.1.0 > > Attachments: 2022-08-23_16-25-17.png, demo.zip, > image-2022-02-06-14-14-42-220.png, not-working.png, working.png > > > I have generated a simple project using the Spring Initializr. If I try to > run the Maven wrapper from a workspace folder within Jenkins, the following > error occurs: > {{"}" was unexpected at this time}} > If I copy the project folder and run it from a different location, it works > with no issues. > A similar issue has been reported on Stackoverflow as well: > [https://stackoverflow.com/q/62028432/766177] > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] gnodet commented on issue #681: ClassNotFoundException when starting jetty with jetty-maven-plugin
gnodet commented on issue #681: URL: https://github.com/apache/maven-mvnd/issues/681#issuecomment-1239416218 The issue seems to be caused by the logback jar leaking from the `mvnd` main classloader to the plugin classloader. Logback defines a `ServletContainerInitializer` which jetty tries to load and fail with the below exception: ``` WARN] Failed startup of context o.e.j.m.p.JettyWebAppContext@2d39da8c{/mvnd-test,file:///Users/gnodet/tmp/mvnd-jetty-plugin-issue/src/main/webapp/,UNAVAILABLE}{file:///Users/gnodet/tmp/mvnd-jetty-plugin-issue/src/main/webapp/} java.lang.NoClassDefFoundError: javax/servlet/ServletContainerInitializer at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:524) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421) at java.base/java.security.AccessController.doPrivileged(AccessController.java:712) at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420) at org.mvndaemon.mvnd.common.MavenDaemon$1.findClass(MavenDaemon.java:62) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromParent(ClassRealm.java:469) at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:46) at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239) at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:538) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520) at java.base/java.lang.Class.forName0(Native Method) at java.base/java.lang.Class.forName(Class.java:467) at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.nextProviderClass(ServiceLoader.java:1217) at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1228) at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273) at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309) at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393) at org.eclipse.jetty.annotations.AnnotationConfiguration.getNonExcludedInitializers(AnnotationConfiguration.java:829) at org.eclipse.jetty.annotations.AnnotationConfiguration.configure(AnnotationConfiguration.java:343) at org.eclipse.jetty.webapp.WebAppContext.configure(WebAppContext.java:498) at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1409) at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:916) at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:288) at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524) at org.eclipse.jetty.maven.plugin.JettyWebAppContext.doStart(JettyWebAppContext.java:397) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117) at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117) at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) at org.eclipse.jetty.server.Server.start(Server.java:423) at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110) at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97) at org.eclipse.jetty.server.Server.doStart(Server.java:387) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractL
[GitHub] [maven-mvnd] Levi-dong commented on issue #675: How do I change the JDK dynamically
Levi-dong commented on issue #675: URL: https://github.com/apache/maven-mvnd/issues/675#issuecomment-1239429032 when will the new version be released? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #675: How do I change the JDK dynamically
gnodet commented on issue #675: URL: https://github.com/apache/maven-mvnd/issues/675#issuecomment-1239442260 > when will the new version be released? ASAP, certainly before end of September. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] Levi-dong commented on issue #675: How do I change the JDK dynamically
Levi-dong commented on issue #675: URL: https://github.com/apache/maven-mvnd/issues/675#issuecomment-1239444722 I am looking forward to the new version of MVND very much. By the way, are there any plans to inherit MVND into IDEA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slachiewicz closed pull request #790: [MNG-7502] Upgrade to Guice 5.1.0
slachiewicz closed pull request #790: [MNG-7502] Upgrade to Guice 5.1.0 URL: https://github.com/apache/maven/pull/790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0
[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601336#comment-17601336 ] ASF GitHub Bot commented on MNG-7502: - slachiewicz closed pull request #790: [MNG-7502] Upgrade to Guice 5.1.0 URL: https://github.com/apache/maven/pull/790 > Upgrade Guice to 5.1.0 > -- > > Key: MNG-7502 > URL: https://issues.apache.org/jira/browse/MNG-7502 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.9.0-candidate, 4.0.x-candidate > > > h3. Release notes: > https://github.com/google/guice/wiki/Guice510 > https://github.com/google/guice/wiki/Guice501 > > * Java 17 support: updated asm version and fixed unsafe class defining to > work with Java 17. > * Removed cglib as a core dependency. Guice now uses ASM directly to > generate bytecode at runtime for invoking user code and supporting method > interception > * Improved error messages > ** package names in error messages are compressed to make it easier to read > ** errors with the same cause are grouped and reported together > ** common error now links to a wiki page on how to debug and fix the error > ** additional information like parameter names are included when code are > compiled with javac {{-parameters}} flag > ** rich formatting like bold, color are used when errors are displayed in a > supported console (can be disabled with > {{-Dguice_colorize_error_messages=DISABLED}} flag) > * Removed no-aop build variant. > * Updated the Guava and ASM versions -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-971) Symbolic links created by the plugin are absolute (i.e., the build environment is leaking through them)
[ https://issues.apache.org/jira/browse/MASSEMBLY-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601363#comment-17601363 ] Stefan Seifert commented on MASSEMBLY-971: -- this seems to be a duplicate of MASSEMBLY-965 > Symbolic links created by the plugin are absolute (i.e., the build > environment is leaking through them) > --- > > Key: MASSEMBLY-971 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-971 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.4.2 > Environment: ubuntu 22.04, maven 3.8.6, assembly plugin 3.4.2 >Reporter: Gabor Kecskemeti >Priority: Major > Attachments: test971.sh > > > To recreate this: > create a folder, then create a file in it. create a symlink to the file from > the parent of the previously created folder (should be a relative link e.g., > run ln -s folder/file from parent). > create an assembly descriptor that creates a tar.gz from the parent of the > above create folder and run it. 1) The produced tgz will contain a symlink > which is broken. 2) the produced symlink leaks information about the build > environment as instead of the original folder/file symlink we end up with the > complete path of the assembled project + parent/folder/file. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MASSEMBLY-971) Symbolic links created by the plugin are absolute (i.e., the build environment is leaking through them)
[ https://issues.apache.org/jira/browse/MASSEMBLY-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MASSEMBLY-971. Resolution: Duplicate > Symbolic links created by the plugin are absolute (i.e., the build > environment is leaking through them) > --- > > Key: MASSEMBLY-971 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-971 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.4.2 > Environment: ubuntu 22.04, maven 3.8.6, assembly plugin 3.4.2 >Reporter: Gabor Kecskemeti >Priority: Major > Attachments: test971.sh > > > To recreate this: > create a folder, then create a file in it. create a symlink to the file from > the parent of the previously created folder (should be a relative link e.g., > run ln -s folder/file from parent). > create an assembly descriptor that creates a tar.gz from the parent of the > above create folder and run it. 1) The produced tgz will contain a symlink > which is broken. 2) the produced symlink leaks information about the build > environment as instead of the original folder/file symlink we end up with the > complete path of the assembled project + parent/folder/file. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-965) Symbolic links get copied with absolute path
[ https://issues.apache.org/jira/browse/MASSEMBLY-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601364#comment-17601364 ] Stefan Seifert commented on MASSEMBLY-965: -- i ran into this problem today as well - an it was also reported in MASSEMBLY-971 (closed as duplicate). > Symbolic links get copied with absolute path > > > Key: MASSEMBLY-965 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-965 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.4.0 >Reporter: Marc Guillemot >Priority: Major > > Copied symbolic links in a `` have an absolute path as target and > not the one of the original resource. > Example: > Source: {{foo -> ../my-file1}} > Assembly: {{foo ->/home/marc/projects/demo/src/somestuff/myfile1}} > This is a regression compared to 3.3.0. According to git bisect, the problem > has been introduced with commit > [https://github.com/apache/maven-assembly-plugin/commit/937750250bfe06333f92351fa1a19a9cd5e59d28] > Pull Request with failing integration test follows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-965) Symbolic links get copied with absolute path
[ https://issues.apache.org/jira/browse/MASSEMBLY-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601368#comment-17601368 ] Stefan Seifert commented on MASSEMBLY-965: -- problem is still present in version 3.4.2 of the plugin > Symbolic links get copied with absolute path > > > Key: MASSEMBLY-965 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-965 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.4.0 >Reporter: Marc Guillemot >Priority: Major > > Copied symbolic links in a `` have an absolute path as target and > not the one of the original resource. > Example: > Source: {{foo -> ../my-file1}} > Assembly: {{foo ->/home/marc/projects/demo/src/somestuff/myfile1}} > This is a regression compared to 3.3.0. According to git bisect, the problem > has been introduced with commit > [https://github.com/apache/maven-assembly-plugin/commit/937750250bfe06333f92351fa1a19a9cd5e59d28] > Pull Request with failing integration test follows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-jar-plugin] slawekjaranowski commented on pull request #9: [MJAR-271] - Flag for maven-jar-plugin to prevent artifact attachment
slawekjaranowski commented on PR #9: URL: https://github.com/apache/maven-jar-plugin/pull/9#issuecomment-1239640722 Corresponding issue was closed, so I close this PR also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jar-plugin] slawekjaranowski closed pull request #9: [MJAR-271] - Flag for maven-jar-plugin to prevent artifact attachment
slawekjaranowski closed pull request #9: [MJAR-271] - Flag for maven-jar-plugin to prevent artifact attachment URL: https://github.com/apache/maven-jar-plugin/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #194: Add cli arguments one by one for Verifier
slawekjaranowski opened a new pull request, #194: URL: https://github.com/apache/maven-integration-testing/pull/194 Prepare for Verifier 2.0 - MSHARED-1125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #194: Add cli arguments one by one for Verifier
slawekjaranowski merged PR #194: URL: https://github.com/apache/maven-integration-testing/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] dependabot[bot] opened a new pull request, #562: Bump mockito-core from 2.28.2 to 4.8.0
dependabot[bot] opened a new pull request, #562: URL: https://github.com/apache/maven-surefire/pull/562 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.8.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.8.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.8.0 2022-09-07 - https://github.com/mockito/mockito/compare/v4.7.0...v4.8.0";>10 commit(s) by Alex, James Baker, Johannes Spangenberg, Kurt Alfred Kluever, Rafael Winterhalter, Thibault Helsmoortel, dependabot[bot] GitHub Workflows security hardening [(https://github-redirect.dependabot.com/mockito/mockito/issues/2744";>#2744)](https://github-redirect.dependabot.com/mockito/mockito/pull/2744";>mockito/mockito#2744) Assign GlobalConfiguration initializer to unused variable [(https://github-redirect.dependabot.com/mockito/mockito/issues/2742";>#2742)](https://github-redirect.dependabot.com/mockito/mockito/pull/2742";>mockito/mockito#2742) Bump com.diffplug.spotless from 6.9.1 to 6.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2738";>#2738)](https://github-redirect.dependabot.com/mockito/mockito/pull/2738";>mockito/mockito#2738) Drop varargs collector before invoking a user method. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2736";>#2736)](https://github-redirect.dependabot.com/mockito/mockito/pull/2736";>mockito/mockito#2736) Bump versions.bytebuddy from 1.12.13 to 1.12.14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2734";>#2734)](https://github-redirect.dependabot.com/mockito/mockito/pull/2734";>mockito/mockito#2734) Remove useless thrown exception from constructor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2732";>#2732)](https://github-redirect.dependabot.com/mockito/mockito/pull/2732";>mockito/mockito#2732) TypeSafeMatching no longer iterates over class methods inefficiently [(https://github-redirect.dependabot.com/mockito/mockito/issues/2729";>#2729)](https://github-redirect.dependabot.com/mockito/mockito/pull/2729";>mockito/mockito#2729) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720: Use StackWalker on Java 9+ to create Locations [(https://github-redirect.dependabot.com/mockito/mockito/issues/2723";>#2723)](https://github-redirect.dependabot.com/mockito/mockito/pull/2723";>mockito/mockito#2723) LocationImpl adds performance overheads due to instantiating a stack trace [(https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720)](https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>mockito/mockito#2720) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626 : Introduce MockSettings.mockMaker [(https://github-redirect.dependabot.com/mockito/mockito/issues/2701";>#2701)](https://github-redirect.dependabot.com/mockito/mockito/pull/2701";>mockito/mockito#2701) Introduce option to disable inline-mock-maker for a specific instance [(https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626)](https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>mockito/mockito#2626) v4.7.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.7.0 2022-08-13 - https://github.com/mockito/mockito/compare/v4.6.1...v4.7.0";>33 commit(s) by 198812345678, Andy Coates, Chen Ni, Marius Lichtblau, Nikita Koselev. Developer Advocate, Open Source Ally, Rafael Winterhalter, dependabot[bot], dstango, fishautumn, heqiang Bump com.diffplug.spotless from 6.9.0 to 6.9.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2725";>#2725)](https://github-redirect.dependabot.com/mockito/mockito/pull/2725";>mockito/mockito#2725) Bump versions.bytebuddy from 1.12.12 to 1.12.13 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2719";>#2719)](https://github-redirect.dependabot.com/mockito/mockito/pull/2719";>mockito/mockito#2719) Fix Javadoc for Mockito. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2718";>#2718)](https://github-redirect.dependabot.com/mockito/mockito/pull/2718";>mockito/mockito#2718) Bump com.diffplug.spotless from 6.8.0 to 6.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2717";>#2717)](https://github-redirect.dependabot.com/mockito/mockito/pull/2717";>mockito/mockito#2717) Fix a typo in comment of InternalRunner.java [(https://github-redirect.dependabot.com/mockito/mockito/issues/2715";>#2715)](https://github-redirect.dependabot.com/mockito/mockito/pull/2715";>mockito/mockito#2715) Bump junit-platform-launcher from 1.8.2 to 1.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2713";>#2713)](https://github-redirect.dependabot.com/mockito/mockito/pull/2713";>mockito/mockito#2713) Bump versions
[GitHub] [maven-surefire] dependabot[bot] commented on pull request #561: Bump mockito-core from 2.28.2 to 4.7.0
dependabot[bot] commented on PR #561: URL: https://github.com/apache/maven-surefire/pull/561#issuecomment-1239788680 Superseded by #562. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] dependabot[bot] closed pull request #561: Bump mockito-core from 2.28.2 to 4.7.0
dependabot[bot] closed pull request #561: Bump mockito-core from 2.28.2 to 4.7.0 URL: https://github.com/apache/maven-surefire/pull/561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #195: Add missing artifacts for tests to bootstrap
slawekjaranowski opened a new pull request, #195: URL: https://github.com/apache/maven-integration-testing/pull/195 maven-plugin-api:3.2.5, sisu-maven-plugin:0.3.5 are used eg. in mng7474 it causes errors with empty local repo - from time to time 😄 example last build on 3.9.x https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] slachiewicz merged pull request #63: Bump junit-jupiter-engine from 5.8.2 to 5.9.0
slachiewicz merged PR #63: URL: https://github.com/apache/maven-antrun-plugin/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] dependabot[bot] opened a new pull request, #65: Bump maven-javadoc-plugin from 3.4.0 to 3.4.1
dependabot[bot] opened a new pull request, #65: URL: https://github.com/apache/maven-antrun-plugin/pull/65 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.4.0 to 3.4.1. Release notes Sourced from https://github.com/apache/maven-javadoc-plugin/releases";>maven-javadoc-plugin's releases. 3.4.1 https://issues.apache.org/jira/browse/MJAVADOC-723";>[MJAVADOC-723] - Upgrade Maven Reporting API to 3.1.1/Complete with Maven Reporting Impl 3.2.0 (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/158";>#158) https://github.com/pzygielo";>@pzygielo Skip Java 9-14 in reproducible test (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/155";>#155) https://github.com/jorsol";>@jorsol Add Integration Test for reproducible builds (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/152";>#152) https://github.com/jorsol";>@jorsol https://issues.apache.org/jira/browse/MJAVADOC-719";>[MJAVADOC-719] - Update Maven Archiver to 3.6.0 (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/150";>#150) https://github.com/jorsol";>@jorsol 📦 Dependency updates Bump assertj-core from 3.21.0 to 3.23.1 (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/143";>#143) https://github.com/dependabot";>@dependabot Bump spring-webmvc from 4.3.29.RELEASE to 5.2.21.RELEASE in /src/it/projects/MJAVADOC-434_fixcompile (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/135";>#135) https://github.com/dependabot";>@dependabot Bump mockito-core from 4.1.0 to 4.4.0 (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/133";>#133) https://github.com/dependabot";>@dependabot Commits https://github.com/apache/maven-javadoc-plugin/commit/a5db96e7e16cc432d8fdea05f460f6c3fa258ba9";>a5db96e [maven-release-plugin] prepare release maven-javadoc-plugin-3.4.1 https://github.com/apache/maven-javadoc-plugin/commit/a10f0b11e89fd65d61938186ddf16fb86ded239e";>a10f0b1 [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1/Complete with Maven Repor... https://github.com/apache/maven-javadoc-plugin/commit/c19dba2fac27b75633efe3c9f905527ba2a8d4e1";>c19dba2 Skip Java 9-14 in reproducible test https://github.com/apache/maven-javadoc-plugin/commit/26d84b264b7a010783ce9373a6f6ebc33bdb0a3b";>26d84b2 Add notimestamp for reproducible builds test https://github.com/apache/maven-javadoc-plugin/commit/92ce668896a95263944ea9235dd99ad8b5c28ab5";>92ce668 Ignore Maven Core updates https://github.com/apache/maven-javadoc-plugin/commit/bacc078f88b29dbdfc4fc8e31a86717a59c4e3b6";>bacc078 Add Integration Test for reproducible builds https://github.com/apache/maven-javadoc-plugin/commit/497f80f40308ba40a30b129f44f5d537fccbb322";>497f80f [MJAVADOC-719] - Update Maven Archiver to 3.6.0 https://github.com/apache/maven-javadoc-plugin/commit/34b501d78a00fa7a222343a7d70cdf65eea6b390";>34b501d Bump assertj-core from 3.21.0 to 3.23.1 https://github.com/apache/maven-javadoc-plugin/commit/b92897088f6fcbc5ec4f3346de591eb97a1c580f";>b928970 Bump spring-webmvc in /src/it/projects/MJAVADOC-434_fixcompile https://github.com/apache/maven-javadoc-plugin/commit/4306c9201551b7cff45f13aaeeb5e17179fdeb7f";>4306c92 Bump mockito-core from 4.1.0 to 4.4.0 Additional commits viewable in https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.4.0...maven-javadoc-plugin-3.4.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore th
[GitHub] [maven-antrun-plugin] dependabot[bot] opened a new pull request, #66: Bump maven-site-plugin from 3.12.0 to 3.12.1
dependabot[bot] opened a new pull request, #66: URL: https://github.com/apache/maven-antrun-plugin/pull/66 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.12.0 to 3.12.1. Commits https://github.com/apache/maven-site-plugin/commit/ecae28fb0990eb5a7fc8f2d4ffe07f348d927f4b";>ecae28f [maven-release-plugin] prepare release maven-site-plugin-3.12.1 https://github.com/apache/maven-site-plugin/commit/d98569b083ded7a5182bf6cb5814ddcbd3150267";>d98569b [MSITE-908] Upgrade Maven Reporting API to 3.1.1 https://github.com/apache/maven-site-plugin/commit/bd3376f52d0053e05c78327aad39353710702a7a";>bd3376f [MSITE-901] If precending standalone report has been run, site:jar does not r... https://github.com/apache/maven-site-plugin/commit/b99c0ef371774a414ade764f2921bdfe8918ed60";>b99c0ef [MSITE-902] Upgrade Plexus Utils to 3.4.2 https://github.com/apache/maven-site-plugin/commit/3c6ff2e285063231b7042bfe7875871c9d339830";>3c6ff2e Update CI URL https://github.com/apache/maven-site-plugin/commit/f314e9da6ba0b5611fd5dd7dcff2d9ecc36dcd61";>f314e9d [MSITE-898] Upgrade Parent to 36 https://github.com/apache/maven-site-plugin/commit/bce7458375464e58f5d2d6cff92f8dde5f45de67";>bce7458 [MSITE-897] Upgrade Plexus Archiver to 4.2.7 https://github.com/apache/maven-site-plugin/commit/3c8d426aae79c793a2a3acfddbd47a6826346382";>3c8d426 keep only release month, drop day https://github.com/apache/maven-site-plugin/commit/6604ab3b53d3f4045cc755340aeb0c4feaeaf8df";>6604ab3 also keep only Doxia versions changes https://github.com/apache/maven-site-plugin/commit/789a7a1054babde3c5b01e48bbf8abca49f5af8f";>789a7a1 lighten content: keep only meaningful values Additional commits viewable in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.12.0...maven-site-plugin-3.12.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] slachiewicz merged pull request #65: Bump maven-javadoc-plugin from 3.4.0 to 3.4.1
slachiewicz merged PR #65: URL: https://github.com/apache/maven-antrun-plugin/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] slachiewicz merged pull request #64: Bump maven-project-info-reports-plugin from 3.3.0 to 3.4.1
slachiewicz merged PR #64: URL: https://github.com/apache/maven-antrun-plugin/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] slachiewicz merged pull request #57: Bump plexus-utils from 3.4.1 to 3.4.2
slachiewicz merged PR #57: URL: https://github.com/apache/maven-antrun-plugin/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #195: Add missing artifacts for tests to bootstrap
slawekjaranowski merged PR #195: URL: https://github.com/apache/maven-integration-testing/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MANTRUN-238) Upgrade parent POM to version 37
Sylwester Lachiewicz created MANTRUN-238: Summary: Upgrade parent POM to version 37 Key: MANTRUN-238 URL: https://issues.apache.org/jira/browse/MANTRUN-238 Project: Maven Antrun Plugin Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MANTRUN-238) Upgrade parent POM to version 37
[ https://issues.apache.org/jira/browse/MANTRUN-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MANTRUN-238: Assignee: Sylwester Lachiewicz > Upgrade parent POM to version 37 > > > Key: MANTRUN-238 > URL: https://issues.apache.org/jira/browse/MANTRUN-238 > Project: Maven Antrun Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MANTRUN-223) Bad links in Javadoc
[ https://issues.apache.org/jira/browse/MANTRUN-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz resolved MANTRUN-223. -- Resolution: Fixed > Bad links in Javadoc > > > Key: MANTRUN-223 > URL: https://issues.apache.org/jira/browse/MANTRUN-223 > Project: Maven Antrun Plugin > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > > [WARNING] Error fetching link: http://ant.apache.org/apidocs/package-list. > Ignored it. > [WARNING] Error fetching link: http://junit.org/apidocs/package-list. Ignored > it. > [WARNING] Error fetching link: https://www.xmlunit.org/apidocs/package-list. > Ignored it. > [WARNING] Error fetching link: https://www.xmlunit.org/apidocs/package-list. > Ignored it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] slachiewicz opened a new pull request, #798: [MNG-7502] Upgrade to Guice 5.1.0
slachiewicz opened a new pull request, #798: URL: https://github.com/apache/maven/pull/798 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0
[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601513#comment-17601513 ] ASF GitHub Bot commented on MNG-7502: - slachiewicz opened a new pull request, #798: URL: https://github.com/apache/maven/pull/798 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Upgrade Guice to 5.1.0 > -- > > Key: MNG-7502 > URL: https://issues.apache.org/jira/browse/MNG-7502 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.9.0-candidate, 4.0.x-candidate > > > h3. Release notes: > https://github.com/google/guice/wiki/Guice510 > https://github.com/google/guice/wiki/Guice501 > > * Java 17 support: updated asm version and fixed unsafe class defining to > work with Java 17. > * Removed cglib as a core dependency. Guice now uses ASM directly to > generate bytecode at runtime for invoking user code and supporting method > interception > * Improved error messages > ** package names in error messages are compressed to make it easier to read > ** errors with the same cause are grouped and reported together > ** common error now links to a wiki page on how to debug and fix the error > ** additional information like parameter names are included when code are > compiled with javac {{-parameters}} flag > ** rich formatting like bold, color are used when errors are displayed in a > supported console (can be disabled with > {{-Dguice_colorize_error_messages=DISABLED}} flag) > * Removed no-aop build variant. > * Updated the Guava and ASM versions -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-antrun-plugin] asfgit closed pull request #66: Bump maven-site-plugin from 3.12.0 to 3.12.1
asfgit closed pull request #66: Bump maven-site-plugin from 3.12.0 to 3.12.1 URL: https://github.com/apache/maven-antrun-plugin/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] dependabot[bot] commented on pull request #66: Bump maven-site-plugin from 3.12.0 to 3.12.1
dependabot[bot] commented on PR #66: URL: https://github.com/apache/maven-antrun-plugin/pull/66#issuecomment-1239919512 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] asfgit closed pull request #62: Bump maven-plugins from 34 to 37
asfgit closed pull request #62: Bump maven-plugins from 34 to 37 URL: https://github.com/apache/maven-antrun-plugin/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] dependabot[bot] commented on pull request #62: Bump maven-plugins from 34 to 37
dependabot[bot] commented on PR #62: URL: https://github.com/apache/maven-antrun-plugin/pull/62#issuecomment-1239919703 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] asfgit closed pull request #58: Bump maven-enforcer-plugin from 3.0.0 to 3.1.0
asfgit closed pull request #58: Bump maven-enforcer-plugin from 3.0.0 to 3.1.0 URL: https://github.com/apache/maven-antrun-plugin/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] dependabot[bot] commented on pull request #58: Bump maven-enforcer-plugin from 3.0.0 to 3.1.0
dependabot[bot] commented on PR #58: URL: https://github.com/apache/maven-antrun-plugin/pull/58#issuecomment-1239919822 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7474) SessionScoped beans should be singletons for a given session
[ https://issues.apache.org/jira/browse/MNG-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601520#comment-17601520 ] Hudson commented on MNG-7474: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #85 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/85/ > SessionScoped beans should be singletons for a given session > > > Key: MNG-7474 > URL: https://issues.apache.org/jira/browse/MNG-7474 > Project: Maven > Issue Type: Improvement >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > Investigate an solution different from MNG-7347. > This is a real problem for maven-build-cache-extension which rely on the > {{@SessionScope}} a lot. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request, #244: Bump mockito-core from 4.7.0 to 4.8.0
dependabot[bot] opened a new pull request, #244: URL: https://github.com/apache/maven-dependency-plugin/pull/244 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.7.0 to 4.8.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.8.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.8.0 2022-09-07 - https://github.com/mockito/mockito/compare/v4.7.0...v4.8.0";>10 commit(s) by Alex, James Baker, Johannes Spangenberg, Kurt Alfred Kluever, Rafael Winterhalter, Thibault Helsmoortel, dependabot[bot] GitHub Workflows security hardening [(https://github-redirect.dependabot.com/mockito/mockito/issues/2744";>#2744)](https://github-redirect.dependabot.com/mockito/mockito/pull/2744";>mockito/mockito#2744) Assign GlobalConfiguration initializer to unused variable [(https://github-redirect.dependabot.com/mockito/mockito/issues/2742";>#2742)](https://github-redirect.dependabot.com/mockito/mockito/pull/2742";>mockito/mockito#2742) Bump com.diffplug.spotless from 6.9.1 to 6.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2738";>#2738)](https://github-redirect.dependabot.com/mockito/mockito/pull/2738";>mockito/mockito#2738) Drop varargs collector before invoking a user method. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2736";>#2736)](https://github-redirect.dependabot.com/mockito/mockito/pull/2736";>mockito/mockito#2736) Bump versions.bytebuddy from 1.12.13 to 1.12.14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2734";>#2734)](https://github-redirect.dependabot.com/mockito/mockito/pull/2734";>mockito/mockito#2734) Remove useless thrown exception from constructor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2732";>#2732)](https://github-redirect.dependabot.com/mockito/mockito/pull/2732";>mockito/mockito#2732) TypeSafeMatching no longer iterates over class methods inefficiently [(https://github-redirect.dependabot.com/mockito/mockito/issues/2729";>#2729)](https://github-redirect.dependabot.com/mockito/mockito/pull/2729";>mockito/mockito#2729) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720: Use StackWalker on Java 9+ to create Locations [(https://github-redirect.dependabot.com/mockito/mockito/issues/2723";>#2723)](https://github-redirect.dependabot.com/mockito/mockito/pull/2723";>mockito/mockito#2723) LocationImpl adds performance overheads due to instantiating a stack trace [(https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720)](https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>mockito/mockito#2720) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626 : Introduce MockSettings.mockMaker [(https://github-redirect.dependabot.com/mockito/mockito/issues/2701";>#2701)](https://github-redirect.dependabot.com/mockito/mockito/pull/2701";>mockito/mockito#2701) Introduce option to disable inline-mock-maker for a specific instance [(https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626)](https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>mockito/mockito#2626) Commits https://github.com/mockito/mockito/commit/3e910ea990e61b29ec76d8b47a6d1b1607d9da3f";>3e910ea Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626 : Introduce MockSettings.mockMaker (https://github-redirect.dependabot.com/mockito/mockito/issues/2701";>#2701) https://github.com/mockito/mockito/commit/0753d48161bc6376108f38146c01c80274a712e3";>0753d48 Explicitly add permissions to GitHub actions (https://github-redirect.dependabot.com/mockito/mockito/issues/2744";>#2744) https://github.com/mockito/mockito/commit/530558ae3c721cb310f3410a66ff4061414cf836";>530558a Assign GlobalConfiguration initializer to unused variable (https://github-redirect.dependabot.com/mockito/mockito/issues/2742";>#2742) https://github.com/mockito/mockito/commit/4b8042e24e4d2009eb46c5319673fd9755c86e45";>4b8042e Bump com.diffplug.spotless from 6.9.1 to 6.10.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2738";>#2738) https://github.com/mockito/mockito/commit/9b93df72c9aad120057ff82d25d0fd5dc3af2317";>9b93df7 Merge pull request https://github-redirect.dependabot.com/mockito/mockito/issues/2736";>#2736 from mockito/static-varargs-call https://github.com/mockito/mockito/commit/160e3daf446e508eb17c6fc21a0932246848206b";>160e3da Drop varargs collector before invoking a user method. https://github.com/mockito/mockito/commit/e123c2cdf7e4688bae7e4ecc145eb960626894db";>e123c2c Bump versions.bytebuddy from 1.12.13 to 1.12.14 (https://github-redirect.dependabot.com/mockito/mockito/issues/2734";>#2734) https://github.com/mockito/mockito/commit/2ded10ec704f2c93648d976031c2520a5a9b84aa";>2ded10e Remove usel
[GitHub] [maven-doxia-sitetools] dependabot[bot] opened a new pull request, #60: Bump mockito-core from 2.28.2 to 4.8.0
dependabot[bot] opened a new pull request, #60: URL: https://github.com/apache/maven-doxia-sitetools/pull/60 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.8.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.8.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.8.0 2022-09-07 - https://github.com/mockito/mockito/compare/v4.7.0...v4.8.0";>10 commit(s) by Alex, James Baker, Johannes Spangenberg, Kurt Alfred Kluever, Rafael Winterhalter, Thibault Helsmoortel, dependabot[bot] GitHub Workflows security hardening [(https://github-redirect.dependabot.com/mockito/mockito/issues/2744";>#2744)](https://github-redirect.dependabot.com/mockito/mockito/pull/2744";>mockito/mockito#2744) Assign GlobalConfiguration initializer to unused variable [(https://github-redirect.dependabot.com/mockito/mockito/issues/2742";>#2742)](https://github-redirect.dependabot.com/mockito/mockito/pull/2742";>mockito/mockito#2742) Bump com.diffplug.spotless from 6.9.1 to 6.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2738";>#2738)](https://github-redirect.dependabot.com/mockito/mockito/pull/2738";>mockito/mockito#2738) Drop varargs collector before invoking a user method. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2736";>#2736)](https://github-redirect.dependabot.com/mockito/mockito/pull/2736";>mockito/mockito#2736) Bump versions.bytebuddy from 1.12.13 to 1.12.14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2734";>#2734)](https://github-redirect.dependabot.com/mockito/mockito/pull/2734";>mockito/mockito#2734) Remove useless thrown exception from constructor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2732";>#2732)](https://github-redirect.dependabot.com/mockito/mockito/pull/2732";>mockito/mockito#2732) TypeSafeMatching no longer iterates over class methods inefficiently [(https://github-redirect.dependabot.com/mockito/mockito/issues/2729";>#2729)](https://github-redirect.dependabot.com/mockito/mockito/pull/2729";>mockito/mockito#2729) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720: Use StackWalker on Java 9+ to create Locations [(https://github-redirect.dependabot.com/mockito/mockito/issues/2723";>#2723)](https://github-redirect.dependabot.com/mockito/mockito/pull/2723";>mockito/mockito#2723) LocationImpl adds performance overheads due to instantiating a stack trace [(https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720)](https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>mockito/mockito#2720) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626 : Introduce MockSettings.mockMaker [(https://github-redirect.dependabot.com/mockito/mockito/issues/2701";>#2701)](https://github-redirect.dependabot.com/mockito/mockito/pull/2701";>mockito/mockito#2701) Introduce option to disable inline-mock-maker for a specific instance [(https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626)](https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>mockito/mockito#2626) v4.7.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.7.0 2022-08-13 - https://github.com/mockito/mockito/compare/v4.6.1...v4.7.0";>33 commit(s) by 198812345678, Andy Coates, Chen Ni, Marius Lichtblau, Nikita Koselev. Developer Advocate, Open Source Ally, Rafael Winterhalter, dependabot[bot], dstango, fishautumn, heqiang Bump com.diffplug.spotless from 6.9.0 to 6.9.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2725";>#2725)](https://github-redirect.dependabot.com/mockito/mockito/pull/2725";>mockito/mockito#2725) Bump versions.bytebuddy from 1.12.12 to 1.12.13 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2719";>#2719)](https://github-redirect.dependabot.com/mockito/mockito/pull/2719";>mockito/mockito#2719) Fix Javadoc for Mockito. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2718";>#2718)](https://github-redirect.dependabot.com/mockito/mockito/pull/2718";>mockito/mockito#2718) Bump com.diffplug.spotless from 6.8.0 to 6.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2717";>#2717)](https://github-redirect.dependabot.com/mockito/mockito/pull/2717";>mockito/mockito#2717) Fix a typo in comment of InternalRunner.java [(https://github-redirect.dependabot.com/mockito/mockito/issues/2715";>#2715)](https://github-redirect.dependabot.com/mockito/mockito/pull/2715";>mockito/mockito#2715) Bump junit-platform-launcher from 1.8.2 to 1.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2713";>#2713)](https://github-redirect.dependabot.com/mockito/mockito/pull/2713";>mockito/mockito#2713) Bump ver
[GitHub] [maven-doxia-sitetools] dependabot[bot] commented on pull request #59: Bump mockito-core from 2.28.2 to 4.7.0
dependabot[bot] commented on PR #59: URL: https://github.com/apache/maven-doxia-sitetools/pull/59#issuecomment-1240016320 Superseded by #60. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-sitetools] dependabot[bot] closed pull request #59: Bump mockito-core from 2.28.2 to 4.7.0
dependabot[bot] closed pull request #59: Bump mockito-core from 2.28.2 to 4.7.0 URL: https://github.com/apache/maven-doxia-sitetools/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wrapper] dependabot[bot] closed pull request #60: Bump mockito-core from 4.6.1 to 4.7.0
dependabot[bot] closed pull request #60: Bump mockito-core from 4.6.1 to 4.7.0 URL: https://github.com/apache/maven-wrapper/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wrapper] dependabot[bot] opened a new pull request, #62: Bump mockito-core from 4.6.1 to 4.8.0
dependabot[bot] opened a new pull request, #62: URL: https://github.com/apache/maven-wrapper/pull/62 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.6.1 to 4.8.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.8.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.8.0 2022-09-07 - https://github.com/mockito/mockito/compare/v4.7.0...v4.8.0";>10 commit(s) by Alex, James Baker, Johannes Spangenberg, Kurt Alfred Kluever, Rafael Winterhalter, Thibault Helsmoortel, dependabot[bot] GitHub Workflows security hardening [(https://github-redirect.dependabot.com/mockito/mockito/issues/2744";>#2744)](https://github-redirect.dependabot.com/mockito/mockito/pull/2744";>mockito/mockito#2744) Assign GlobalConfiguration initializer to unused variable [(https://github-redirect.dependabot.com/mockito/mockito/issues/2742";>#2742)](https://github-redirect.dependabot.com/mockito/mockito/pull/2742";>mockito/mockito#2742) Bump com.diffplug.spotless from 6.9.1 to 6.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2738";>#2738)](https://github-redirect.dependabot.com/mockito/mockito/pull/2738";>mockito/mockito#2738) Drop varargs collector before invoking a user method. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2736";>#2736)](https://github-redirect.dependabot.com/mockito/mockito/pull/2736";>mockito/mockito#2736) Bump versions.bytebuddy from 1.12.13 to 1.12.14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2734";>#2734)](https://github-redirect.dependabot.com/mockito/mockito/pull/2734";>mockito/mockito#2734) Remove useless thrown exception from constructor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2732";>#2732)](https://github-redirect.dependabot.com/mockito/mockito/pull/2732";>mockito/mockito#2732) TypeSafeMatching no longer iterates over class methods inefficiently [(https://github-redirect.dependabot.com/mockito/mockito/issues/2729";>#2729)](https://github-redirect.dependabot.com/mockito/mockito/pull/2729";>mockito/mockito#2729) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720: Use StackWalker on Java 9+ to create Locations [(https://github-redirect.dependabot.com/mockito/mockito/issues/2723";>#2723)](https://github-redirect.dependabot.com/mockito/mockito/pull/2723";>mockito/mockito#2723) LocationImpl adds performance overheads due to instantiating a stack trace [(https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720)](https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>mockito/mockito#2720) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626 : Introduce MockSettings.mockMaker [(https://github-redirect.dependabot.com/mockito/mockito/issues/2701";>#2701)](https://github-redirect.dependabot.com/mockito/mockito/pull/2701";>mockito/mockito#2701) Introduce option to disable inline-mock-maker for a specific instance [(https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626)](https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>mockito/mockito#2626) v4.7.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.7.0 2022-08-13 - https://github.com/mockito/mockito/compare/v4.6.1...v4.7.0";>33 commit(s) by 198812345678, Andy Coates, Chen Ni, Marius Lichtblau, Nikita Koselev. Developer Advocate, Open Source Ally, Rafael Winterhalter, dependabot[bot], dstango, fishautumn, heqiang Bump com.diffplug.spotless from 6.9.0 to 6.9.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2725";>#2725)](https://github-redirect.dependabot.com/mockito/mockito/pull/2725";>mockito/mockito#2725) Bump versions.bytebuddy from 1.12.12 to 1.12.13 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2719";>#2719)](https://github-redirect.dependabot.com/mockito/mockito/pull/2719";>mockito/mockito#2719) Fix Javadoc for Mockito. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2718";>#2718)](https://github-redirect.dependabot.com/mockito/mockito/pull/2718";>mockito/mockito#2718) Bump com.diffplug.spotless from 6.8.0 to 6.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2717";>#2717)](https://github-redirect.dependabot.com/mockito/mockito/pull/2717";>mockito/mockito#2717) Fix a typo in comment of InternalRunner.java [(https://github-redirect.dependabot.com/mockito/mockito/issues/2715";>#2715)](https://github-redirect.dependabot.com/mockito/mockito/pull/2715";>mockito/mockito#2715) Bump junit-platform-launcher from 1.8.2 to 1.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2713";>#2713)](https://github-redirect.dependabot.com/mockito/mockito/pull/2713";>mockito/mockito#2713) Bump versions.juni
[GitHub] [maven-wrapper] dependabot[bot] commented on pull request #60: Bump mockito-core from 4.6.1 to 4.7.0
dependabot[bot] commented on PR #60: URL: https://github.com/apache/maven-wrapper/pull/60#issuecomment-1240112944 Superseded by #62. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] euvitudo commented on issue #681: ClassNotFoundException when starting jetty with jetty-maven-plugin
euvitudo commented on issue #681: URL: https://github.com/apache/maven-mvnd/issues/681#issuecomment-1240125727 @gnodet I applied this to a clone of master and it works. Looking forward to 0.8.1. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHARED-1130) PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and artifactoid w/ null on any coordinate
Andrzej Jarmoniuk created MSHARED-1130: -- Summary: PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and artifactoid w/ null on any coordinate Key: MSHARED-1130 URL: https://issues.apache.org/jira/browse/MSHARED-1130 Project: Maven Shared Components Issue Type: Bug Affects Versions: maven-common-artifact-filters-3.3.1 Reporter: Andrzej Jarmoniuk Encountered an NPE from {{PatternIncludesArtifactFilters.match}} if the pattern includes wildcards and the artifactoid returns null on any of its coordinates. In such cases, the {{value}} argument will be null, which will lead to an NPE when it's being dereferenced in line 653. This led to https://github.com/mojohaus/versions-maven-plugin/issues/673 In this case, {{token}} was {{JET*-SNAPSHOT}} and {{value}} as returned from the artifactoid was null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #139: Bump mockito-core from 4.6.1 to 4.8.0
dependabot[bot] opened a new pull request, #139: URL: https://github.com/apache/maven-invoker-plugin/pull/139 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.6.1 to 4.8.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.8.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.8.0 2022-09-07 - https://github.com/mockito/mockito/compare/v4.7.0...v4.8.0";>10 commit(s) by Alex, James Baker, Johannes Spangenberg, Kurt Alfred Kluever, Rafael Winterhalter, Thibault Helsmoortel, dependabot[bot] GitHub Workflows security hardening [(https://github-redirect.dependabot.com/mockito/mockito/issues/2744";>#2744)](https://github-redirect.dependabot.com/mockito/mockito/pull/2744";>mockito/mockito#2744) Assign GlobalConfiguration initializer to unused variable [(https://github-redirect.dependabot.com/mockito/mockito/issues/2742";>#2742)](https://github-redirect.dependabot.com/mockito/mockito/pull/2742";>mockito/mockito#2742) Bump com.diffplug.spotless from 6.9.1 to 6.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2738";>#2738)](https://github-redirect.dependabot.com/mockito/mockito/pull/2738";>mockito/mockito#2738) Drop varargs collector before invoking a user method. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2736";>#2736)](https://github-redirect.dependabot.com/mockito/mockito/pull/2736";>mockito/mockito#2736) Bump versions.bytebuddy from 1.12.13 to 1.12.14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2734";>#2734)](https://github-redirect.dependabot.com/mockito/mockito/pull/2734";>mockito/mockito#2734) Remove useless thrown exception from constructor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2732";>#2732)](https://github-redirect.dependabot.com/mockito/mockito/pull/2732";>mockito/mockito#2732) TypeSafeMatching no longer iterates over class methods inefficiently [(https://github-redirect.dependabot.com/mockito/mockito/issues/2729";>#2729)](https://github-redirect.dependabot.com/mockito/mockito/pull/2729";>mockito/mockito#2729) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720: Use StackWalker on Java 9+ to create Locations [(https://github-redirect.dependabot.com/mockito/mockito/issues/2723";>#2723)](https://github-redirect.dependabot.com/mockito/mockito/pull/2723";>mockito/mockito#2723) LocationImpl adds performance overheads due to instantiating a stack trace [(https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720)](https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>mockito/mockito#2720) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626 : Introduce MockSettings.mockMaker [(https://github-redirect.dependabot.com/mockito/mockito/issues/2701";>#2701)](https://github-redirect.dependabot.com/mockito/mockito/pull/2701";>mockito/mockito#2701) Introduce option to disable inline-mock-maker for a specific instance [(https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626)](https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>mockito/mockito#2626) v4.7.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.7.0 2022-08-13 - https://github.com/mockito/mockito/compare/v4.6.1...v4.7.0";>33 commit(s) by 198812345678, Andy Coates, Chen Ni, Marius Lichtblau, Nikita Koselev. Developer Advocate, Open Source Ally, Rafael Winterhalter, dependabot[bot], dstango, fishautumn, heqiang Bump com.diffplug.spotless from 6.9.0 to 6.9.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2725";>#2725)](https://github-redirect.dependabot.com/mockito/mockito/pull/2725";>mockito/mockito#2725) Bump versions.bytebuddy from 1.12.12 to 1.12.13 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2719";>#2719)](https://github-redirect.dependabot.com/mockito/mockito/pull/2719";>mockito/mockito#2719) Fix Javadoc for Mockito. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2718";>#2718)](https://github-redirect.dependabot.com/mockito/mockito/pull/2718";>mockito/mockito#2718) Bump com.diffplug.spotless from 6.8.0 to 6.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2717";>#2717)](https://github-redirect.dependabot.com/mockito/mockito/pull/2717";>mockito/mockito#2717) Fix a typo in comment of InternalRunner.java [(https://github-redirect.dependabot.com/mockito/mockito/issues/2715";>#2715)](https://github-redirect.dependabot.com/mockito/mockito/pull/2715";>mockito/mockito#2715) Bump junit-platform-launcher from 1.8.2 to 1.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2713";>#2713)](https://github-redirect.dependabot.com/mockito/mockito/pull/2713";>mockito/mockito#2713) Bump vers
[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #137: Bump mockito-core from 4.6.1 to 4.7.0
dependabot[bot] commented on PR #137: URL: https://github.com/apache/maven-invoker-plugin/pull/137#issuecomment-1240193539 Superseded by #139. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] closed pull request #137: Bump mockito-core from 4.6.1 to 4.7.0
dependabot[bot] closed pull request #137: Bump mockito-core from 4.6.1 to 4.7.0 URL: https://github.com/apache/maven-invoker-plugin/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #119: Bump mockito-core from 4.2.0 to 4.7.0
dependabot[bot] commented on PR #119: URL: https://github.com/apache/maven-jlink-plugin/pull/119#issuecomment-1240194088 Superseded by #120. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #119: Bump mockito-core from 4.2.0 to 4.7.0
dependabot[bot] closed pull request #119: Bump mockito-core from 4.2.0 to 4.7.0 URL: https://github.com/apache/maven-jlink-plugin/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #120: Bump mockito-core from 4.2.0 to 4.8.0
dependabot[bot] opened a new pull request, #120: URL: https://github.com/apache/maven-jlink-plugin/pull/120 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.2.0 to 4.8.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.8.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.8.0 2022-09-07 - https://github.com/mockito/mockito/compare/v4.7.0...v4.8.0";>10 commit(s) by Alex, James Baker, Johannes Spangenberg, Kurt Alfred Kluever, Rafael Winterhalter, Thibault Helsmoortel, dependabot[bot] GitHub Workflows security hardening [(https://github-redirect.dependabot.com/mockito/mockito/issues/2744";>#2744)](https://github-redirect.dependabot.com/mockito/mockito/pull/2744";>mockito/mockito#2744) Assign GlobalConfiguration initializer to unused variable [(https://github-redirect.dependabot.com/mockito/mockito/issues/2742";>#2742)](https://github-redirect.dependabot.com/mockito/mockito/pull/2742";>mockito/mockito#2742) Bump com.diffplug.spotless from 6.9.1 to 6.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2738";>#2738)](https://github-redirect.dependabot.com/mockito/mockito/pull/2738";>mockito/mockito#2738) Drop varargs collector before invoking a user method. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2736";>#2736)](https://github-redirect.dependabot.com/mockito/mockito/pull/2736";>mockito/mockito#2736) Bump versions.bytebuddy from 1.12.13 to 1.12.14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2734";>#2734)](https://github-redirect.dependabot.com/mockito/mockito/pull/2734";>mockito/mockito#2734) Remove useless thrown exception from constructor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2732";>#2732)](https://github-redirect.dependabot.com/mockito/mockito/pull/2732";>mockito/mockito#2732) TypeSafeMatching no longer iterates over class methods inefficiently [(https://github-redirect.dependabot.com/mockito/mockito/issues/2729";>#2729)](https://github-redirect.dependabot.com/mockito/mockito/pull/2729";>mockito/mockito#2729) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720: Use StackWalker on Java 9+ to create Locations [(https://github-redirect.dependabot.com/mockito/mockito/issues/2723";>#2723)](https://github-redirect.dependabot.com/mockito/mockito/pull/2723";>mockito/mockito#2723) LocationImpl adds performance overheads due to instantiating a stack trace [(https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720)](https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>mockito/mockito#2720) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626 : Introduce MockSettings.mockMaker [(https://github-redirect.dependabot.com/mockito/mockito/issues/2701";>#2701)](https://github-redirect.dependabot.com/mockito/mockito/pull/2701";>mockito/mockito#2701) Introduce option to disable inline-mock-maker for a specific instance [(https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626)](https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>mockito/mockito#2626) v4.7.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.7.0 2022-08-13 - https://github.com/mockito/mockito/compare/v4.6.1...v4.7.0";>33 commit(s) by 198812345678, Andy Coates, Chen Ni, Marius Lichtblau, Nikita Koselev. Developer Advocate, Open Source Ally, Rafael Winterhalter, dependabot[bot], dstango, fishautumn, heqiang Bump com.diffplug.spotless from 6.9.0 to 6.9.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2725";>#2725)](https://github-redirect.dependabot.com/mockito/mockito/pull/2725";>mockito/mockito#2725) Bump versions.bytebuddy from 1.12.12 to 1.12.13 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2719";>#2719)](https://github-redirect.dependabot.com/mockito/mockito/pull/2719";>mockito/mockito#2719) Fix Javadoc for Mockito. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2718";>#2718)](https://github-redirect.dependabot.com/mockito/mockito/pull/2718";>mockito/mockito#2718) Bump com.diffplug.spotless from 6.8.0 to 6.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2717";>#2717)](https://github-redirect.dependabot.com/mockito/mockito/pull/2717";>mockito/mockito#2717) Fix a typo in comment of InternalRunner.java [(https://github-redirect.dependabot.com/mockito/mockito/issues/2715";>#2715)](https://github-redirect.dependabot.com/mockito/mockito/pull/2715";>mockito/mockito#2715) Bump junit-platform-launcher from 1.8.2 to 1.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2713";>#2713)](https://github-redirect.dependabot.com/mockito/mockito/pull/2713";>mockito/mockito#2713) Bump versio
[GitHub] [maven-mvnd] gnodet merged pull request #683: Fix plugins' parent classloader to not include libraries, fixes #681
gnodet merged PR #683: URL: https://github.com/apache/maven-mvnd/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet closed issue #681: ClassNotFoundException when starting jetty with jetty-maven-plugin
gnodet closed issue #681: ClassNotFoundException when starting jetty with jetty-maven-plugin URL: https://github.com/apache/maven-mvnd/issues/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1130) PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and artifactoid w/ null on any coordinate
[ https://issues.apache.org/jira/browse/MSHARED-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601626#comment-17601626 ] Andrzej Jarmoniuk commented on MSHARED-1130: Simple unit test to reproduce: {code:java:title=AbstractPatternArtifactFilterTest} @Test public void testPartialWildcardShouldNotMatchEmptyComponent() { final String groupId = "com.mycompany.myproject"; final String artifactId = "some-artifact-id"; final String version = "1.0.0"; Artifact artifact = mock( Artifact.class ); when( artifact.getGroupId() ).thenReturn( groupId ); when( artifact.getArtifactId() ).thenReturn( artifactId ); when( artifact.getVersion() ).thenReturn( version ); when( artifact.getType() ).thenReturn( null ); when( artifact.getBaseVersion() ).thenReturn( "version" ); final List patterns = new ArrayList<>(); patterns.add( "com.mycompany.myproject:some-artifact-id:*:ERROR*" ); final ArtifactFilter filter = createFilter( patterns ); if ( isInclusionNotExpected() ) { assertFalse( filter.include( artifact ) ); } else { assertTrue( filter.include( artifact ) ); } {code} > PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and > artifactoid w/ null on any coordinate > -- > > Key: MSHARED-1130 > URL: https://issues.apache.org/jira/browse/MSHARED-1130 > Project: Maven Shared Components > Issue Type: Bug >Affects Versions: maven-common-artifact-filters-3.3.1 >Reporter: Andrzej Jarmoniuk >Priority: Major > > Encountered an NPE from {{PatternIncludesArtifactFilters.match}} if the > pattern includes wildcards and the artifactoid returns null on any of its > coordinates. > In such cases, the {{value}} argument will be null, which will lead to an NPE > when it's being dereferenced in line 653. > This led to https://github.com/mojohaus/versions-maven-plugin/issues/673 > In this case, {{token}} was {{JET*-SNAPSHOT}} and {{value}} as returned from > the artifactoid was null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MSHARED-1130) PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and artifactoid w/ null on any coordinate
[ https://issues.apache.org/jira/browse/MSHARED-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601626#comment-17601626 ] Andrzej Jarmoniuk edited comment on MSHARED-1130 at 9/8/22 4:25 AM: Simple unit test to reproduce: {code:java:title=AbstractPatternArtifactFilterTest} @Test public void testPartialWildcardShouldNotMatchEmptyComponent() { final String groupId = "com.mycompany.myproject"; final String artifactId = "some-artifact-id"; final String version = "1.0.0"; Artifact artifact = mock( Artifact.class ); when( artifact.getGroupId() ).thenReturn( groupId ); when( artifact.getArtifactId() ).thenReturn( artifactId ); when( artifact.getVersion() ).thenReturn( version ); when( artifact.getType() ).thenReturn( null ); when( artifact.getBaseVersion() ).thenReturn( "version" ); final List patterns = new ArrayList<>(); patterns.add( "com.mycompany.myproject:some-artifact-id:*:ERROR*" ); final ArtifactFilter filter = createFilter( patterns ); if ( isInclusionNotExpected() ) { assertFalse( filter.include( artifact ) ); } else { assertFalse( filter.include( artifact ) ); } {code} was (Author: ajarmoniuk): Simple unit test to reproduce: {code:java:title=AbstractPatternArtifactFilterTest} @Test public void testPartialWildcardShouldNotMatchEmptyComponent() { final String groupId = "com.mycompany.myproject"; final String artifactId = "some-artifact-id"; final String version = "1.0.0"; Artifact artifact = mock( Artifact.class ); when( artifact.getGroupId() ).thenReturn( groupId ); when( artifact.getArtifactId() ).thenReturn( artifactId ); when( artifact.getVersion() ).thenReturn( version ); when( artifact.getType() ).thenReturn( null ); when( artifact.getBaseVersion() ).thenReturn( "version" ); final List patterns = new ArrayList<>(); patterns.add( "com.mycompany.myproject:some-artifact-id:*:ERROR*" ); final ArtifactFilter filter = createFilter( patterns ); if ( isInclusionNotExpected() ) { assertFalse( filter.include( artifact ) ); } else { assertTrue( filter.include( artifact ) ); } {code} > PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and > artifactoid w/ null on any coordinate > -- > > Key: MSHARED-1130 > URL: https://issues.apache.org/jira/browse/MSHARED-1130 > Project: Maven Shared Components > Issue Type: Bug >Affects Versions: maven-common-artifact-filters-3.3.1 >Reporter: Andrzej Jarmoniuk >Priority: Major > > Encountered an NPE from {{PatternIncludesArtifactFilters.match}} if the > pattern includes wildcards and the artifactoid returns null on any of its > coordinates. > In such cases, the {{value}} argument will be null, which will lead to an NPE > when it's being dereferenced in line 653. > This led to https://github.com/mojohaus/versions-maven-plugin/issues/673 > In this case, {{token}} was {{JET*-SNAPSHOT}} and {{value}} as returned from > the artifactoid was null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MSHARED-1130) PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and artifactoid w/ null on any coordinate
[ https://issues.apache.org/jira/browse/MSHARED-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601626#comment-17601626 ] Andrzej Jarmoniuk edited comment on MSHARED-1130 at 9/8/22 4:27 AM: Simple unit test to reproduce: {code:java:title=AbstractPatternArtifactFilterTest} @Test public void testPartialWildcardShouldNotMatchEmptyComponent() { final String groupId = "com.mycompany.myproject"; final String artifactId = "some-artifact-id"; final String version = "1.0.0"; Artifact artifact = mock( Artifact.class ); when( artifact.getGroupId() ).thenReturn( groupId ); when( artifact.getArtifactId() ).thenReturn( artifactId ); when( artifact.getVersion() ).thenReturn( version ); when( artifact.getType() ).thenReturn( null ); final ArtifactFilter filter = createFilter( Collections.singletonList( "com.mycompany.myproject:some-artifact-id:*:ERROR*" ) ); if ( isInclusionNotExpected() ) { assertFalse( filter.include( artifact ) ); } else { assertTrue( filter.include( artifact ) ); } } {code} was (Author: ajarmoniuk): Simple unit test to reproduce: {code:java:title=AbstractPatternArtifactFilterTest} @Test public void testPartialWildcardShouldNotMatchEmptyComponent() { final String groupId = "com.mycompany.myproject"; final String artifactId = "some-artifact-id"; final String version = "1.0.0"; Artifact artifact = mock( Artifact.class ); when( artifact.getGroupId() ).thenReturn( groupId ); when( artifact.getArtifactId() ).thenReturn( artifactId ); when( artifact.getVersion() ).thenReturn( version ); when( artifact.getType() ).thenReturn( null ); when( artifact.getBaseVersion() ).thenReturn( "version" ); final List patterns = new ArrayList<>(); patterns.add( "com.mycompany.myproject:some-artifact-id:*:ERROR*" ); final ArtifactFilter filter = createFilter( patterns ); if ( isInclusionNotExpected() ) { assertFalse( filter.include( artifact ) ); } else { assertFalse( filter.include( artifact ) ); } {code} > PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and > artifactoid w/ null on any coordinate > -- > > Key: MSHARED-1130 > URL: https://issues.apache.org/jira/browse/MSHARED-1130 > Project: Maven Shared Components > Issue Type: Bug >Affects Versions: maven-common-artifact-filters-3.3.1 >Reporter: Andrzej Jarmoniuk >Priority: Major > > Encountered an NPE from {{PatternIncludesArtifactFilters.match}} if the > pattern includes wildcards and the artifactoid returns null on any of its > coordinates. > In such cases, the {{value}} argument will be null, which will lead to an NPE > when it's being dereferenced in line 653. > This led to https://github.com/mojohaus/versions-maven-plugin/issues/673 > In this case, {{token}} was {{JET*-SNAPSHOT}} and {{value}} as returned from > the artifactoid was null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-release] dependabot[bot] opened a new pull request, #148: Bump mockito-core from 2.28.2 to 4.8.0
dependabot[bot] opened a new pull request, #148: URL: https://github.com/apache/maven-release/pull/148 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.8.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.8.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.8.0 2022-09-07 - https://github.com/mockito/mockito/compare/v4.7.0...v4.8.0";>10 commit(s) by Alex, James Baker, Johannes Spangenberg, Kurt Alfred Kluever, Rafael Winterhalter, Thibault Helsmoortel, dependabot[bot] GitHub Workflows security hardening [(https://github-redirect.dependabot.com/mockito/mockito/issues/2744";>#2744)](https://github-redirect.dependabot.com/mockito/mockito/pull/2744";>mockito/mockito#2744) Assign GlobalConfiguration initializer to unused variable [(https://github-redirect.dependabot.com/mockito/mockito/issues/2742";>#2742)](https://github-redirect.dependabot.com/mockito/mockito/pull/2742";>mockito/mockito#2742) Bump com.diffplug.spotless from 6.9.1 to 6.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2738";>#2738)](https://github-redirect.dependabot.com/mockito/mockito/pull/2738";>mockito/mockito#2738) Drop varargs collector before invoking a user method. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2736";>#2736)](https://github-redirect.dependabot.com/mockito/mockito/pull/2736";>mockito/mockito#2736) Bump versions.bytebuddy from 1.12.13 to 1.12.14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2734";>#2734)](https://github-redirect.dependabot.com/mockito/mockito/pull/2734";>mockito/mockito#2734) Remove useless thrown exception from constructor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2732";>#2732)](https://github-redirect.dependabot.com/mockito/mockito/pull/2732";>mockito/mockito#2732) TypeSafeMatching no longer iterates over class methods inefficiently [(https://github-redirect.dependabot.com/mockito/mockito/issues/2729";>#2729)](https://github-redirect.dependabot.com/mockito/mockito/pull/2729";>mockito/mockito#2729) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720: Use StackWalker on Java 9+ to create Locations [(https://github-redirect.dependabot.com/mockito/mockito/issues/2723";>#2723)](https://github-redirect.dependabot.com/mockito/mockito/pull/2723";>mockito/mockito#2723) LocationImpl adds performance overheads due to instantiating a stack trace [(https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720)](https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>mockito/mockito#2720) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626 : Introduce MockSettings.mockMaker [(https://github-redirect.dependabot.com/mockito/mockito/issues/2701";>#2701)](https://github-redirect.dependabot.com/mockito/mockito/pull/2701";>mockito/mockito#2701) Introduce option to disable inline-mock-maker for a specific instance [(https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626)](https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>mockito/mockito#2626) v4.7.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.7.0 2022-08-13 - https://github.com/mockito/mockito/compare/v4.6.1...v4.7.0";>33 commit(s) by 198812345678, Andy Coates, Chen Ni, Marius Lichtblau, Nikita Koselev. Developer Advocate, Open Source Ally, Rafael Winterhalter, dependabot[bot], dstango, fishautumn, heqiang Bump com.diffplug.spotless from 6.9.0 to 6.9.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2725";>#2725)](https://github-redirect.dependabot.com/mockito/mockito/pull/2725";>mockito/mockito#2725) Bump versions.bytebuddy from 1.12.12 to 1.12.13 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2719";>#2719)](https://github-redirect.dependabot.com/mockito/mockito/pull/2719";>mockito/mockito#2719) Fix Javadoc for Mockito. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2718";>#2718)](https://github-redirect.dependabot.com/mockito/mockito/pull/2718";>mockito/mockito#2718) Bump com.diffplug.spotless from 6.8.0 to 6.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2717";>#2717)](https://github-redirect.dependabot.com/mockito/mockito/pull/2717";>mockito/mockito#2717) Fix a typo in comment of InternalRunner.java [(https://github-redirect.dependabot.com/mockito/mockito/issues/2715";>#2715)](https://github-redirect.dependabot.com/mockito/mockito/pull/2715";>mockito/mockito#2715) Bump junit-platform-launcher from 1.8.2 to 1.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2713";>#2713)](https://github-redirect.dependabot.com/mockito/mockito/pull/2713";>mockito/mockito#2713) Bump versions.
[GitHub] [maven-release] dependabot[bot] commented on pull request #146: Bump mockito-core from 2.28.2 to 4.7.0
dependabot[bot] commented on PR #146: URL: https://github.com/apache/maven-release/pull/146#issuecomment-1240204741 Superseded by #148. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] dependabot[bot] closed pull request #146: Bump mockito-core from 2.28.2 to 4.7.0
dependabot[bot] closed pull request #146: Bump mockito-core from 2.28.2 to 4.7.0 URL: https://github.com/apache/maven-release/pull/146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MSHARED-1130) PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and artifactoid w/ null on any coordinate
[ https://issues.apache.org/jira/browse/MSHARED-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601626#comment-17601626 ] Andrzej Jarmoniuk edited comment on MSHARED-1130 at 9/8/22 4:40 AM: Simple unit test to reproduce: {code:java:title=AbstractPatternArtifactFilterTest} @Test public void testPartialWildcardShouldNotMatchEmptyComponent() { final String groupId = "com.mycompany.myproject"; final String artifactId = "some-artifact-id"; final String version = "1.0.0"; Artifact artifact = mock( Artifact.class ); when( artifact.getGroupId() ).thenReturn( groupId ); when( artifact.getArtifactId() ).thenReturn( artifactId ); when( artifact.getVersion() ).thenReturn( version ); when( artifact.getType() ).thenReturn( null ); final ArtifactFilter filter = createFilter( Collections.singletonList( "com.mycompany.myproject:some-artifact-id:*:ERROR*" ) ); if ( isInclusionNotExpected() ) { assertTrue( filter.include( artifact ) ); } else { assertFalse( filter.include( artifact ) ); } } {code} was (Author: ajarmoniuk): Simple unit test to reproduce: {code:java:title=AbstractPatternArtifactFilterTest} @Test public void testPartialWildcardShouldNotMatchEmptyComponent() { final String groupId = "com.mycompany.myproject"; final String artifactId = "some-artifact-id"; final String version = "1.0.0"; Artifact artifact = mock( Artifact.class ); when( artifact.getGroupId() ).thenReturn( groupId ); when( artifact.getArtifactId() ).thenReturn( artifactId ); when( artifact.getVersion() ).thenReturn( version ); when( artifact.getType() ).thenReturn( null ); final ArtifactFilter filter = createFilter( Collections.singletonList( "com.mycompany.myproject:some-artifact-id:*:ERROR*" ) ); if ( isInclusionNotExpected() ) { assertFalse( filter.include( artifact ) ); } else { assertTrue( filter.include( artifact ) ); } } {code} > PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and > artifactoid w/ null on any coordinate > -- > > Key: MSHARED-1130 > URL: https://issues.apache.org/jira/browse/MSHARED-1130 > Project: Maven Shared Components > Issue Type: Bug >Affects Versions: maven-common-artifact-filters-3.3.1 >Reporter: Andrzej Jarmoniuk >Priority: Major > > Encountered an NPE from {{PatternIncludesArtifactFilters.match}} if the > pattern includes wildcards and the artifactoid returns null on any of its > coordinates. > In such cases, the {{value}} argument will be null, which will lead to an NPE > when it's being dereferenced in line 653. > This led to https://github.com/mojohaus/versions-maven-plugin/issues/673 > In this case, {{token}} was {{JET*-SNAPSHOT}} and {{value}} as returned from > the artifactoid was null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-common-artifact-filters] ajarmoniuk opened a new pull request, #31: MSHARED-1130: Sanitised value nullability in match(Pattern, boolean, String)
ajarmoniuk opened a new pull request, #31: URL: https://github.com/apache/maven-common-artifact-filters/pull/31 Fixing MSHARED-1130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-1130) PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and artifactoid w/ null on any coordinate
[ https://issues.apache.org/jira/browse/MSHARED-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Jarmoniuk updated MSHARED-1130: --- Component/s: maven-common-artifact-filters > PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and > artifactoid w/ null on any coordinate > -- > > Key: MSHARED-1130 > URL: https://issues.apache.org/jira/browse/MSHARED-1130 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.3.1 >Reporter: Andrzej Jarmoniuk >Priority: Major > > Encountered an NPE from {{PatternIncludesArtifactFilters.match}} if the > pattern includes wildcards and the artifactoid returns null on any of its > coordinates. > In such cases, the {{value}} argument will be null, which will lead to an NPE > when it's being dereferenced in line 653. > This led to https://github.com/mojohaus/versions-maven-plugin/issues/673 > In this case, {{token}} was {{JET*-SNAPSHOT}} and {{value}} as returned from > the artifactoid was null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-assembly-plugin] dependabot[bot] opened a new pull request, #89: Bump mockito-core from 4.6.1 to 4.8.0
dependabot[bot] opened a new pull request, #89: URL: https://github.com/apache/maven-assembly-plugin/pull/89 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.6.1 to 4.8.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.8.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.8.0 2022-09-07 - https://github.com/mockito/mockito/compare/v4.7.0...v4.8.0";>10 commit(s) by Alex, James Baker, Johannes Spangenberg, Kurt Alfred Kluever, Rafael Winterhalter, Thibault Helsmoortel, dependabot[bot] GitHub Workflows security hardening [(https://github-redirect.dependabot.com/mockito/mockito/issues/2744";>#2744)](https://github-redirect.dependabot.com/mockito/mockito/pull/2744";>mockito/mockito#2744) Assign GlobalConfiguration initializer to unused variable [(https://github-redirect.dependabot.com/mockito/mockito/issues/2742";>#2742)](https://github-redirect.dependabot.com/mockito/mockito/pull/2742";>mockito/mockito#2742) Bump com.diffplug.spotless from 6.9.1 to 6.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2738";>#2738)](https://github-redirect.dependabot.com/mockito/mockito/pull/2738";>mockito/mockito#2738) Drop varargs collector before invoking a user method. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2736";>#2736)](https://github-redirect.dependabot.com/mockito/mockito/pull/2736";>mockito/mockito#2736) Bump versions.bytebuddy from 1.12.13 to 1.12.14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2734";>#2734)](https://github-redirect.dependabot.com/mockito/mockito/pull/2734";>mockito/mockito#2734) Remove useless thrown exception from constructor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2732";>#2732)](https://github-redirect.dependabot.com/mockito/mockito/pull/2732";>mockito/mockito#2732) TypeSafeMatching no longer iterates over class methods inefficiently [(https://github-redirect.dependabot.com/mockito/mockito/issues/2729";>#2729)](https://github-redirect.dependabot.com/mockito/mockito/pull/2729";>mockito/mockito#2729) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720: Use StackWalker on Java 9+ to create Locations [(https://github-redirect.dependabot.com/mockito/mockito/issues/2723";>#2723)](https://github-redirect.dependabot.com/mockito/mockito/pull/2723";>mockito/mockito#2723) LocationImpl adds performance overheads due to instantiating a stack trace [(https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>#2720)](https://github-redirect.dependabot.com/mockito/mockito/issues/2720";>mockito/mockito#2720) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626 : Introduce MockSettings.mockMaker [(https://github-redirect.dependabot.com/mockito/mockito/issues/2701";>#2701)](https://github-redirect.dependabot.com/mockito/mockito/pull/2701";>mockito/mockito#2701) Introduce option to disable inline-mock-maker for a specific instance [(https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>#2626)](https://github-redirect.dependabot.com/mockito/mockito/issues/2626";>mockito/mockito#2626) v4.7.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.7.0 2022-08-13 - https://github.com/mockito/mockito/compare/v4.6.1...v4.7.0";>33 commit(s) by 198812345678, Andy Coates, Chen Ni, Marius Lichtblau, Nikita Koselev. Developer Advocate, Open Source Ally, Rafael Winterhalter, dependabot[bot], dstango, fishautumn, heqiang Bump com.diffplug.spotless from 6.9.0 to 6.9.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2725";>#2725)](https://github-redirect.dependabot.com/mockito/mockito/pull/2725";>mockito/mockito#2725) Bump versions.bytebuddy from 1.12.12 to 1.12.13 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2719";>#2719)](https://github-redirect.dependabot.com/mockito/mockito/pull/2719";>mockito/mockito#2719) Fix Javadoc for Mockito. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2718";>#2718)](https://github-redirect.dependabot.com/mockito/mockito/pull/2718";>mockito/mockito#2718) Bump com.diffplug.spotless from 6.8.0 to 6.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2717";>#2717)](https://github-redirect.dependabot.com/mockito/mockito/pull/2717";>mockito/mockito#2717) Fix a typo in comment of InternalRunner.java [(https://github-redirect.dependabot.com/mockito/mockito/issues/2715";>#2715)](https://github-redirect.dependabot.com/mockito/mockito/pull/2715";>mockito/mockito#2715) Bump junit-platform-launcher from 1.8.2 to 1.9.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2713";>#2713)](https://github-redirect.dependabot.com/mockito/mockito/pull/2713";>mockito/mockito#2713) Bump versi
[GitHub] [maven-assembly-plugin] dependabot[bot] commented on pull request #87: Bump mockito-core from 4.6.1 to 4.7.0
dependabot[bot] commented on PR #87: URL: https://github.com/apache/maven-assembly-plugin/pull/87#issuecomment-1240222763 Superseded by #89. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] dependabot[bot] closed pull request #87: Bump mockito-core from 4.6.1 to 4.7.0
dependabot[bot] closed pull request #87: Bump mockito-core from 4.6.1 to 4.7.0 URL: https://github.com/apache/maven-assembly-plugin/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] walnut-tom commented on issue #665: can mvnd support remote daemon?
walnut-tom commented on issue #665: URL: https://github.com/apache/maven-mvnd/issues/665#issuecomment-1240234446 Is it possible to send workspace content to daemon like docker build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #655: :bug: Unable to rebuild a project
gnodet commented on issue #655: URL: https://github.com/apache/maven-mvnd/issues/655#issuecomment-1240234536 More information would be helpful. Do you know which files are locked ? Any way to reproduce the problem ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #651: Path problems in git-for-windows bash
gnodet commented on issue #651: URL: https://github.com/apache/maven-mvnd/issues/651#issuecomment-1240236733 Do you have a simple project to reproduce the problem ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #649: Maven goal is sometimes skipped
gnodet commented on issue #649: URL: https://github.com/apache/maven-mvnd/issues/649#issuecomment-1240247584 Or at least provide a debug output to see if it contains anything useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #665: can mvnd support remote daemon?
gnodet commented on issue #665: URL: https://github.com/apache/maven-mvnd/issues/665#issuecomment-1240249577 > Is it possible to send workspace content to daemon like docker build? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet closed issue #628: make libmvndnative.* builds reproducible
gnodet closed issue #628: make libmvndnative.* builds reproducible URL: https://github.com/apache/maven-mvnd/issues/628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #628: make libmvndnative.* builds reproducible
gnodet commented on issue #628: URL: https://github.com/apache/maven-mvnd/issues/628#issuecomment-1240253376 Closing this one, I think the work has been done for 0.8.0. @hboutemy please reopen if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet merged pull request #684: Improve Intellij integration, fixes #664
gnodet merged PR #684: URL: https://github.com/apache/maven-mvnd/pull/684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet closed issue #664: Improved support for IntelliJ Idea
gnodet closed issue #664: Improved support for IntelliJ Idea URL: https://github.com/apache/maven-mvnd/issues/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] slawekjaranowski commented on a diff in pull request #31: MSHARED-1130: Sanitised value nullability in match(Pattern, boolean, String)
slawekjaranowski commented on code in PR #31: URL: https://github.com/apache/maven-common-artifact-filters/pull/31#discussion_r965541271 ## src/test/java/org/apache/maven/shared/artifact/filter/AbstractPatternArtifactFilterTest.java: ## @@ -579,4 +579,26 @@ public void testmassembly955() assertTrue( filter.include( artifact2 ) ); } } + +@Test +public void testPartialWildcardShouldNotMatchEmptyComponent() +{ +Artifact artifact = mock( Artifact.class ); +when( artifact.getGroupId() ).thenReturn( "test-group" ); +when( artifact.getArtifactId() ).thenReturn( "test-artifact" ); +when( artifact.getVersion() ).thenReturn( "test-version" ); +when( artifact.getType() ).thenReturn( null ); Review Comment: Try test with `DefaultArtifact` implementations - not mock. https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java#L126-L151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] ajarmoniuk commented on a diff in pull request #31: MSHARED-1130: Sanitised value nullability in match(Pattern, boolean, String)
ajarmoniuk commented on code in PR #31: URL: https://github.com/apache/maven-common-artifact-filters/pull/31#discussion_r965553206 ## src/test/java/org/apache/maven/shared/artifact/filter/AbstractPatternArtifactFilterTest.java: ## @@ -579,4 +579,26 @@ public void testmassembly955() assertTrue( filter.include( artifact2 ) ); } } + +@Test +public void testPartialWildcardShouldNotMatchEmptyComponent() +{ +Artifact artifact = mock( Artifact.class ); +when( artifact.getGroupId() ).thenReturn( "test-group" ); +when( artifact.getArtifactId() ).thenReturn( "test-artifact" ); +when( artifact.getVersion() ).thenReturn( "test-version" ); +when( artifact.getType() ).thenReturn( null ); Review Comment: Ok, done -> I had to mock or subclass ArtifactHandler because the classifier was null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1130) PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and artifactoid w/ null on any coordinate
[ https://issues.apache.org/jira/browse/MSHARED-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601666#comment-17601666 ] Slawomir Jaranowski commented on MSHARED-1130: -- Interesting case, but in {{DefaultArtifact}} we have: {code} public DefaultArtifact( String groupId, String artifactId, VersionRange versionRange, String scope, String type, String classifier, ArtifactHandler artifactHandler, boolean optional ) { this.groupId = groupId; this.artifactId = artifactId; this.versionRange = versionRange; selectVersionFromNewRangeIfAvailable(); this.artifactHandler = artifactHandler; this.scope = scope; this.type = type; if ( classifier == null ) { classifier = artifactHandler.getClassifier(); } this.classifier = classifier; this.optional = optional; validateIdentity(); } {code} and {code} private void validateIdentity() { if ( empty( groupId ) ) { throw new InvalidArtifactRTException( groupId, artifactId, getVersion(), type, "The groupId cannot be empty." ); } if ( artifactId == null ) { throw new InvalidArtifactRTException( groupId, artifactId, getVersion(), type, "The artifactId cannot be empty." ); } if ( type == null ) { throw new InvalidArtifactRTException( groupId, artifactId, getVersion(), type, "The type cannot be empty." ); } if ( ( version == null ) && ( versionRange == null ) ) { throw new InvalidArtifactRTException( groupId, artifactId, getVersion(), type, "The version cannot be empty." ); } } {code} so {{type}} can not be {{null}} > PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and > artifactoid w/ null on any coordinate > -- > > Key: MSHARED-1130 > URL: https://issues.apache.org/jira/browse/MSHARED-1130 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.3.1 >Reporter: Andrzej Jarmoniuk >Priority: Major > > Encountered an NPE from {{PatternIncludesArtifactFilters.match}} if the > pattern includes wildcards and the artifactoid returns null on any of its > coordinates. > In such cases, the {{value}} argument will be null, which will lead to an NPE > when it's being dereferenced in line 653. > This led to https://github.com/mojohaus/versions-maven-plugin/issues/673 > In this case, {{token}} was {{JET*-SNAPSHOT}} and {{value}} as returned from > the artifactoid was null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-common-artifact-filters] ajarmoniuk commented on a diff in pull request #31: MSHARED-1130: Sanitised value nullability in match(Pattern, boolean, String)
ajarmoniuk commented on code in PR #31: URL: https://github.com/apache/maven-common-artifact-filters/pull/31#discussion_r965567742 ## src/test/java/org/apache/maven/shared/artifact/filter/AbstractPatternArtifactFilterTest.java: ## @@ -19,20 +19,22 @@ * under the License. */ -import static org.junit.Assert.assertFalse; Review Comment: Those were changed by the formatter, but this is in line with coding conventions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org