[jira] [Updated] (DOXIA-668) Remove all obsolete attributes in HTML5
[
https://issues.apache.org/jira/browse/DOXIA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated DOXIA-668:
Description:
This listing provides all obsolete elements along with obsolete attributes per
element:
[https://www.tutorialrepublic.com/html-reference/html5-tags.php|https://www.tutorialrepublic.com/html-reference/html5-tags.php].
We will remove attribute definitions in Sink and Parser (XHTML5 and derived
like Xdoc and FML). Moreover these changes will break some usage:
* Aligning of table cell must now happen through CSS on the TDs rather than
providing it to table rows. There is no simple way to parse and write it in a
format-neutral manner w/o huge effort.
* Replace {{name}} with {{id}} on anchors.
* Table borders must be solved by CSS now
* Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}}, {{td}}/{{th}},
sections, verbatims, {{tr}}
Virtual all deprecated attributes have been superseded by CSS. Improve also
tests because code is stricter now.
was:
[This|https://www.tutorialrepublic.com/html-reference/html5-tags.php] listing
provides all obsolete elements along with obsolete attributes per element. We
will remove attribute definitions in Sink and Parser (XHTML5 and derived like
Xdoc and FML). Moreover these changes will break usage:
* Aligning of table cell must now happen through CSS on the TDs rather than
providing it to table rows. There is no simple way to parse and write it in a
format-neutral manner w/o huge effort.
* Replace {{name}} with {{id}} on anchors.
* Table borders must be solved by CSS now
* Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}}, {{td}}/{{th}},
sections, verbatims, {{tr}}
Virtual all deprecated attributes have been superseded by CSS. Improve also
tests because code is stricter now.
> Remove all obsolete attributes in HTML5
> ---
>
> Key: DOXIA-668
> URL: https://issues.apache.org/jira/browse/DOXIA-668
> Project: Maven Doxia
> Issue Type: Sub-task
> Components: Module - Xhtml
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> This listing provides all obsolete elements along with obsolete attributes
> per element:
> [https://www.tutorialrepublic.com/html-reference/html5-tags.php|https://www.tutorialrepublic.com/html-reference/html5-tags.php].
> We will remove attribute definitions in Sink and Parser (XHTML5 and derived
> like Xdoc and FML). Moreover these changes will break some usage:
> * Aligning of table cell must now happen through CSS on the TDs rather than
> providing it to table rows. There is no simple way to parse and write it in a
> format-neutral manner w/o huge effort.
> * Replace {{name}} with {{id}} on anchors.
> * Table borders must be solved by CSS now
> * Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}},
> {{td}}/{{th}}, sections, verbatims, {{tr}}
> Virtual all deprecated attributes have been superseded by CSS. Improve also
> tests because code is stricter now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] hboutemy commented on pull request #114: [DOXIA-668] Remove all obsolete attributes in HTML5
hboutemy commented on PR #114: URL: https://github.com/apache/maven-doxia/pull/114#issuecomment-1204876148 @michael-o do we provide an example of how to use CSS instead? and IIUC, we'll need to update our apt format reference documentation https://maven.apache.org/doxia/references/apt-format.html , for example, to show the updated behaviour (for example "+-- instead of --- draws a box around verbatim text.", or "| Centered | Left-aligned | Right-aligned |")? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-668) Remove all obsolete attributes in HTML5
[
https://issues.apache.org/jira/browse/DOXIA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575085#comment-17575085
]
ASF GitHub Bot commented on DOXIA-668:
--
hboutemy commented on PR #114:
URL: https://github.com/apache/maven-doxia/pull/114#issuecomment-1204876148
@michael-o do we provide an example of how to use CSS instead?
and IIUC, we'll need to update our apt format reference documentation
https://maven.apache.org/doxia/references/apt-format.html , for example, to
show the updated behaviour (for example "+
> Remove all obsolete attributes in HTML5
> ---
>
> Key: DOXIA-668
> URL: https://issues.apache.org/jira/browse/DOXIA-668
> Project: Maven Doxia
> Issue Type: Sub-task
> Components: Module - Xhtml
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> This listing provides all obsolete elements along with obsolete attributes
> per element:
> [https://www.tutorialrepublic.com/html-reference/html5-tags.php|https://www.tutorialrepublic.com/html-reference/html5-tags.php].
> We will remove attribute definitions in Sink and Parser (XHTML5 and derived
> like Xdoc and FML). Moreover these changes will break some usage:
> * Aligning of table cell must now happen through CSS on the TDs rather than
> providing it to table rows. There is no simple way to parse and write it in a
> format-neutral manner w/o huge effort.
> * Replace {{name}} with {{id}} on anchors.
> * Table borders must be solved by CSS now
> * Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}},
> {{td}}/{{th}}, sections, verbatims, {{tr}}
> Virtual all deprecated attributes have been superseded by CSS. Improve also
> tests because code is stricter now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] michael-o commented on pull request #114: [DOXIA-668] Remove all obsolete attributes in HTML5
michael-o commented on PR #114: URL: https://github.com/apache/maven-doxia/pull/114#issuecomment-1204952945 > @michael-o do we provide an example of how to use CSS instead? > > and IIUC, we'll need to update our apt format reference documentation https://maven.apache.org/doxia/references/apt-format.html , for example, to show the updated behaviour (for example "+-- instead of --- draws a box around verbatim text.", or "| Centered | Left-aligned | Right-aligned |")? Very good question. This I need to check. I also ran MSITE with current version of Doxia (M3) and upcoming M4 and the only difference I have seen is that some plugin output is broken due https://github.com/apache/maven-doxia/pull/114/files#diff-d01624ca9c1507eb1b1a45dbae19428e9a80912f545953340b53a0d09f015c00L114-L127 Give me some time... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-668) Remove all obsolete attributes in HTML5
[
https://issues.apache.org/jira/browse/DOXIA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575126#comment-17575126
]
ASF GitHub Bot commented on DOXIA-668:
--
michael-o commented on PR #114:
URL: https://github.com/apache/maven-doxia/pull/114#issuecomment-1204952945
> @michael-o do we provide an example of how to use CSS instead?
>
> and IIUC, we'll need to update our apt format reference documentation
https://maven.apache.org/doxia/references/apt-format.html , for example, to
show the updated behaviour (for example "+
> Remove all obsolete attributes in HTML5
> ---
>
> Key: DOXIA-668
> URL: https://issues.apache.org/jira/browse/DOXIA-668
> Project: Maven Doxia
> Issue Type: Sub-task
> Components: Module - Xhtml
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> This listing provides all obsolete elements along with obsolete attributes
> per element:
> [https://www.tutorialrepublic.com/html-reference/html5-tags.php|https://www.tutorialrepublic.com/html-reference/html5-tags.php].
> We will remove attribute definitions in Sink and Parser (XHTML5 and derived
> like Xdoc and FML). Moreover these changes will break some usage:
> * Aligning of table cell must now happen through CSS on the TDs rather than
> providing it to table rows. There is no simple way to parse and write it in a
> format-neutral manner w/o huge effort.
> * Replace {{name}} with {{id}} on anchors.
> * Table borders must be solved by CSS now
> * Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}},
> {{td}}/{{th}}, sections, verbatims, {{tr}}
> Virtual all deprecated attributes have been superseded by CSS. Improve also
> tests because code is stricter now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] cstamas commented on pull request #191: [MRESOLVER-268] Allow for checksum validation upon artifact resolution.
cstamas commented on PR #191: URL: https://github.com/apache/maven-resolver/pull/191#issuecomment-1204954822 ProvidedChecksumsSource was done to be aligned with other checksum stuff (external, inlined and provided) and whole resolver was done in a way that only remote transport checks checksums. Before, it was envisioned to have local repo "nuked" (hence, CI starts from clean slate), and whatever your build up in local repo afterwards is downloaded (will have checksum checked) or was produced during build. Naturally, this implies some sort of artifact cache (repo manager of any kind). These days OTOH CIs like GH Actions can and do cache local repository, so this change would make sense IMHO. Still, whole resolver was originally implemented in this spirit (as @michael-o explained above), hence this may/will leave inevitable to breakage, especially if local repo is shared across projects (so, where "suddenly" locally built/installed artifact becomes a dependency). For me, it "smells" like split repository could come into play, but this is still just a hunch/feeling/faint-idea but unsure how and where. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-268) Apply artifact checksum verification for any resolved artifact
[ https://issues.apache.org/jira/browse/MRESOLVER-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575129#comment-17575129 ] ASF GitHub Bot commented on MRESOLVER-268: -- cstamas commented on PR #191: URL: https://github.com/apache/maven-resolver/pull/191#issuecomment-1204954822 ProvidedChecksumsSource was done to be aligned with other checksum stuff (external, inlined and provided) and whole resolver was done in a way that only remote transport checks checksums. Before, it was envisioned to have local repo "nuked" (hence, CI starts from clean slate), and whatever your build up in local repo afterwards is downloaded (will have checksum checked) or was produced during build. Naturally, this implies some sort of artifact cache (repo manager of any kind). These days OTOH CIs like GH Actions can and do cache local repository, so this change would make sense IMHO. Still, whole resolver was originally implemented in this spirit (as @michael-o explained above), hence this may/will leave inevitable to breakage, especially if local repo is shared across projects (so, where "suddenly" locally built/installed artifact becomes a dependency). For me, it "smells" like split repository could come into play, but this is still just a hunch/feeling/faint-idea but unsure how and where. > Apply artifact checksum verification for any resolved artifact > -- > > Key: MRESOLVER-268 > URL: https://issues.apache.org/jira/browse/MRESOLVER-268 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Rafael Winterhalter >Priority: Major > > Maven resolver currently only verifies provided checksums (via > ProvidedChecksumsSource) when artifacts are downloaded from a remote > repository. While this strategy is efficient when working with a clean local > repository, it can create problems if two Maven projects share a local > repository, where only one project validates hashes. If the first project has > downloaded a corrupted artifact, the second project would now use this > corrupted artifact despite knowing a non-matching checksum. > With the proposed change, artifacts are validated whenever they are resolved. > This allows to retain the integrity of a project also when sharing a local > Maven repository with other, unsecured projects. > The current PR only activates this general validation if a global validation > policy is defined. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] rmannibucau opened a new pull request, #59: Enable to customize classworlds.conf
rmannibucau opened a new pull request, #59: URL: https://github.com/apache/maven-wrapper/pull/59 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHADE-424) Upgrade jdependency 2.8.0
Karl Heinz Marbaise created MSHADE-424: -- Summary: Upgrade jdependency 2.8.0 Key: MSHADE-424 URL: https://issues.apache.org/jira/browse/MSHADE-424 Project: Maven Shade Plugin Issue Type: Dependency upgrade Affects Versions: 3.3.0 Reporter: Karl Heinz Marbaise Fix For: 3.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MSHADE-424) Upgrade jdependency 2.8.0
[ https://issues.apache.org/jira/browse/MSHADE-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MSHADE-424: -- Assignee: Karl Heinz Marbaise > Upgrade jdependency 2.8.0 > - > > Key: MSHADE-424 > URL: https://issues.apache.org/jira/browse/MSHADE-424 > Project: Maven Shade Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.3.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHADE-424) Upgrade jdependency 2.8.0
[ https://issues.apache.org/jira/browse/MSHADE-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575187#comment-17575187 ] Karl Heinz Marbaise commented on MSHADE-424: Done in [cd9c24bd2440a0f447ecf933e7f0126390d03c37|https://gitbox.apache.org/repos/asf?p=maven-shade-plugin.git;a=commitdiff;h=cd9c24bd2440a0f447ecf933e7f0126390d03c37] > Upgrade jdependency 2.8.0 > - > > Key: MSHADE-424 > URL: https://issues.apache.org/jira/browse/MSHADE-424 > Project: Maven Shade Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.3.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHADE-424) Upgrade jdependency 2.8.0
[ https://issues.apache.org/jira/browse/MSHADE-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHADE-424. -- Resolution: Done > Upgrade jdependency 2.8.0 > - > > Key: MSHADE-424 > URL: https://issues.apache.org/jira/browse/MSHADE-424 > Project: Maven Shade Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.3.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-485) Incorrect internal string format in generated package-info.class files on Windows
[
https://issues.apache.org/jira/browse/MCOMPILER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575191#comment-17575191
]
Alexander Kriegisch commented on MCOMPILER-485:
---
Before messaging here, I did of yourse notice [~gnodet]'s [statement in the PR
for
MCOMIPLER-205|https://github.com/apache/maven-compiler-plugin/pull/88#issue-1124280483]:
{quote}This PR provides an option (turned on by default) to generate class
files for missing {{package-info}} classes. This happens when the
{{package-info.java}} source file only contains a javadoc and no annotations on
the package.
This can be turned on some JDK using {{-Xpkginfo:always}}, but that may not
work on all JDKs.{quote}
Therefore, of course I understand the idea to generate the class files
manually, but as we have painfully experienced, it is a possible source of
errors. Now, it seems to be fixed, but anyway, I believe that each compiler
which can be uses with Maven Compiler Plugin has one or another way to enforce
package info class file creation. Javac has {{-Xpkginfo}}, ECJ seems to always
create those files anyway (thus probably also ECJ forks like GrEclipse and
AspectJ). I do not know which other compiler back-ends MCompiler / Plexus
supports, but hopefully onf of you committers can say morwe about that.
> Incorrect internal string format in generated package-info.class files on
> Windows
> -
>
> Key: MCOMPILER-485
> URL: https://issues.apache.org/jira/browse/MCOMPILER-485
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
> Environment: Windows, or any operating system with a file separator
> character other than a forward slash
>Reporter: Daniel Widdis
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.10.1
>
>
> In 3.10.0, a new feature to generate package-info classes was added in
> [[MCOMPILER-205] |https://github.com/apache/maven-compiler-plugin/pull/88]
> Unfortunately, the binary class file is incorrectly generated using Java's
> file toString() which uses a platform dependent file separator character: on
> Windows, these Strings contain a backslash. See [this
> line|https://github.com/gnodet/maven-compiler-plugin/blob/8521ef8fdd12cc0b85c1ace17114ed3d3ffd0b0c/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L1356]
> which passes the platform-dependent file name (minus the root path and .java
> extension) to the ClassWriter.
> The Java class file specification (4.2.1) specifies the internal format: "In
> this internal form, the ASCII periods (.) that normally separate the
> identifiers which make up the binary name are replaced by ASCII forward
> slashes (/)."
> This invalid class file format causes problems in downstream plugins, e.g.,
> * The bnd-maven-plugin fails with an error: Classes found in the wrong
> directory:
> \{oshi/jna/platform/unix/package-info.class=oshi\jna\platform\unix\package-info
> ... (and hundreds more) ... }
> * The JDK's
> [classFileParser|https://github.com/openjdk/jdk17/blob/74007890bb9a3fa3a65683a3f480e399f2b1a0b6/src/hotspot/share/classfile/classFileParser.cpp#L5797]
> will throw java.lang.NoClassDefFoundError:
> com\puppycrawl\tools\checkstyle\ant\package-info (wrong name:
> com/puppycrawl/tools/checkstyle/ant/package-info
> Steps to reproduce:
> # Perform a build on any Windows machine using maven-compiler-plugin 3.10.0
> # Inspect any of the generated package-info.class files in target/classes
> using a text editor
> Expected behavior:
> Internal strings representing package names use forward slashes
> Observed behavior:
> Internal strings representing package names use backward slashes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MCOMPILER-485) Incorrect internal string format in generated package-info.class files on Windows
[
https://issues.apache.org/jira/browse/MCOMPILER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575191#comment-17575191
]
Alexander Kriegisch edited comment on MCOMPILER-485 at 8/4/22 10:12 AM:
Before messaging here, I did of course notice [~gnodet]'s [statement in the PR
for
MCOMIPLER-205|https://github.com/apache/maven-compiler-plugin/pull/88#issue-1124280483]:
{quote}This PR provides an option (turned on by default) to generate class
files for missing {{package-info}} classes. This happens when the
{{package-info.java}} source file only contains a javadoc and no annotations on
the package.
This can be turned on some JDK using {{{}-Xpkginfo:always{}}}, but that may not
work on all JDKs.
{quote}
Therefore, of course I understand the idea to generate the class files
manually, but as we have painfully experienced, it is a possible source of
errors. Now, it seems to be fixed, but anyway, I believe that each compiler
which can be used with Maven Compiler Plugin has one or another way to enforce
package info class file creation. Javac has {{{}-Xpkginfo{}}}, ECJ seems to
always create those files anyway (thus probably also ECJ forks like GrEclipse
and AspectJ). I do not know which other compiler back-ends MCompiler / Plexus
supports, but hopefully one of you committers can say morwe about that.
was (Author: kriegaex):
Before messaging here, I did of yourse notice [~gnodet]'s [statement in the PR
for
MCOMIPLER-205|https://github.com/apache/maven-compiler-plugin/pull/88#issue-1124280483]:
{quote}This PR provides an option (turned on by default) to generate class
files for missing {{package-info}} classes. This happens when the
{{package-info.java}} source file only contains a javadoc and no annotations on
the package.
This can be turned on some JDK using {{-Xpkginfo:always}}, but that may not
work on all JDKs.{quote}
Therefore, of course I understand the idea to generate the class files
manually, but as we have painfully experienced, it is a possible source of
errors. Now, it seems to be fixed, but anyway, I believe that each compiler
which can be uses with Maven Compiler Plugin has one or another way to enforce
package info class file creation. Javac has {{-Xpkginfo}}, ECJ seems to always
create those files anyway (thus probably also ECJ forks like GrEclipse and
AspectJ). I do not know which other compiler back-ends MCompiler / Plexus
supports, but hopefully onf of you committers can say morwe about that.
> Incorrect internal string format in generated package-info.class files on
> Windows
> -
>
> Key: MCOMPILER-485
> URL: https://issues.apache.org/jira/browse/MCOMPILER-485
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
> Environment: Windows, or any operating system with a file separator
> character other than a forward slash
>Reporter: Daniel Widdis
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.10.1
>
>
> In 3.10.0, a new feature to generate package-info classes was added in
> [[MCOMPILER-205] |https://github.com/apache/maven-compiler-plugin/pull/88]
> Unfortunately, the binary class file is incorrectly generated using Java's
> file toString() which uses a platform dependent file separator character: on
> Windows, these Strings contain a backslash. See [this
> line|https://github.com/gnodet/maven-compiler-plugin/blob/8521ef8fdd12cc0b85c1ace17114ed3d3ffd0b0c/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L1356]
> which passes the platform-dependent file name (minus the root path and .java
> extension) to the ClassWriter.
> The Java class file specification (4.2.1) specifies the internal format: "In
> this internal form, the ASCII periods (.) that normally separate the
> identifiers which make up the binary name are replaced by ASCII forward
> slashes (/)."
> This invalid class file format causes problems in downstream plugins, e.g.,
> * The bnd-maven-plugin fails with an error: Classes found in the wrong
> directory:
> \{oshi/jna/platform/unix/package-info.class=oshi\jna\platform\unix\package-info
> ... (and hundreds more) ... }
> * The JDK's
> [classFileParser|https://github.com/openjdk/jdk17/blob/74007890bb9a3fa3a65683a3f480e399f2b1a0b6/src/hotspot/share/classfile/classFileParser.cpp#L5797]
> will throw java.lang.NoClassDefFoundError:
> com\puppycrawl\tools\checkstyle\ant\package-info (wrong name:
> com/puppycrawl/tools/checkstyle/ant/package-info
> Steps to reproduce:
> # Perform a build on any Windows machine using maven-compiler-plugin 3.10.0
> # Inspect any of the generated package-info.class files in target/classes
> using a text editor
> Expected behavior:
> Internal s
[jira] [Commented] (MSHADE-424) Upgrade jdependency 2.8.0
[ https://issues.apache.org/jira/browse/MSHADE-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575194#comment-17575194 ] Hudson commented on MSHADE-424: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-shade-plugin » master #22 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-shade-plugin/job/master/22/ > Upgrade jdependency 2.8.0 > - > > Key: MSHADE-424 > URL: https://issues.apache.org/jira/browse/MSHADE-424 > Project: Maven Shade Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.3.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] ppalaga commented on issue #667: Exception in thread "main" java.io.UncheckedIOException: java.nio.charset.MalformedInputException: Input length = 1
ppalaga commented on issue #667: URL: https://github.com/apache/maven-mvnd/issues/667#issuecomment-1205150617 Happy to hear that you found your way @meiMingle! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] ppalaga closed issue #667: Exception in thread "main" java.io.UncheckedIOException: java.nio.charset.MalformedInputException: Input length = 1
ppalaga closed issue #667: Exception in thread "main" java.io.UncheckedIOException: java.nio.charset.MalformedInputException: Input length = 1 URL: https://github.com/apache/maven-mvnd/issues/667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] opened a new pull request, #65: Bump maven-site-plugin from 3.12.0 to 3.12.1
dependabot[bot] opened a new pull request, #65: URL: https://github.com/apache/maven-jxr/pull/65 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.12.0 to 3.12.1. Commits https://github.com/apache/maven-site-plugin/commit/ecae28fb0990eb5a7fc8f2d4ffe07f348d927f4b";>ecae28f [maven-release-plugin] prepare release maven-site-plugin-3.12.1 https://github.com/apache/maven-site-plugin/commit/d98569b083ded7a5182bf6cb5814ddcbd3150267";>d98569b [MSITE-908] Upgrade Maven Reporting API to 3.1.1 https://github.com/apache/maven-site-plugin/commit/bd3376f52d0053e05c78327aad39353710702a7a";>bd3376f [MSITE-901] If precending standalone report has been run, site:jar does not r... https://github.com/apache/maven-site-plugin/commit/b99c0ef371774a414ade764f2921bdfe8918ed60";>b99c0ef [MSITE-902] Upgrade Plexus Utils to 3.4.2 https://github.com/apache/maven-site-plugin/commit/3c6ff2e285063231b7042bfe7875871c9d339830";>3c6ff2e Update CI URL https://github.com/apache/maven-site-plugin/commit/f314e9da6ba0b5611fd5dd7dcff2d9ecc36dcd61";>f314e9d [MSITE-898] Upgrade Parent to 36 https://github.com/apache/maven-site-plugin/commit/bce7458375464e58f5d2d6cff92f8dde5f45de67";>bce7458 [MSITE-897] Upgrade Plexus Archiver to 4.2.7 https://github.com/apache/maven-site-plugin/commit/3c8d426aae79c793a2a3acfddbd47a6826346382";>3c8d426 keep only release month, drop day https://github.com/apache/maven-site-plugin/commit/6604ab3b53d3f4045cc755340aeb0c4feaeaf8df";>6604ab3 also keep only Doxia versions changes https://github.com/apache/maven-site-plugin/commit/789a7a1054babde3c5b01e48bbf8abca49f5af8f";>789a7a1 lighten content: keep only meaningful values Additional commits viewable in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.12.0...maven-site-plugin-3.12.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on issue #669: runtime jdk requirement of java client (via mvnd.sh) should be aligned to JDK8
ppalaga commented on issue #669: URL: https://github.com/apache/maven-mvnd/issues/669#issuecomment-1205335100 > * Native `mvnd`: requires JDK8 Well, strictly speaking, `mvnd` is a native executable not requiring any JRE to run. A VM (called Substrate) is embedded. The daemon started by that executable is fine with Java 8. > * maven 3.8.5: requires JDK8 > * `mvnd.sh`: requires JDK11 ? Yes, this is by design. The client requires [some features](https://github.com/apache/maven-mvnd/issues/56) not available in Java 8. If you are on Mac M1 and you want to overcome this limitation, you may want to compile mvnd yourself following @orpiske 's script https://www.orpiske.net/2022/07/try-apache-maven-daemon/ We actually had a similar question before. Here is a dirty hack I recommended at that time: https://github.com/apache/maven-mvnd/issues/547#issuecomment-1004889625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on issue #669: runtime jdk requirement of java client (via mvnd.sh) should be aligned to JDK8
ppalaga commented on issue #669: URL: https://github.com/apache/maven-mvnd/issues/669#issuecomment-1205336054 Maybe we should document the limitation in README. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7310) Maven loads extension from another submodule
[
https://issues.apache.org/jira/browse/MNG-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575296#comment-17575296
]
Martin Kanters commented on MNG-7310:
-
Came back to this after a long break and got the integration-tests fixed. The
maven-core change was already fixed before (see last comment).
Please review the following PRs:
- https://github.com/apache/maven/pull/639
- https://github.com/apache/maven-integration-testing/pull/131
> Maven loads extension from another submodule
>
>
> Key: MNG-7310
> URL: https://issues.apache.org/jira/browse/MNG-7310
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-alpha-1
>Reporter: Martin Kanters
>Priority: Major
> Attachments: demo-plugins.zip
>
>
> With the latest Maven master, I'm not able to build a certain multi module
> project.
> It fails with the following error:
> C:\work\apache\demo>mvn validate
> [INFO] Scanning for projects...
> ...
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project com.example:demo2:0.0.1-SNAPSHOT
> (C:\work\apache\demo\demo2\pom.xml) has 1 error
> [ERROR] 'build.plugins.plugin.version' for
> org.springframework.cloud:spring-cloud-contract-maven-plugin must be a valid
> version but is '${project.version}'. @
> org.apache.maven:maven-core:4.0.0-alpha-1-SNAPSHOT:default-lifecycle-bindings
> The project looks as follows:
> parent
> – demo (module containing plugin "spring-cloud-contract-maven-plugin")
> – demo2 (module)
> "demo2" has no dependency on "demo" and the parent of "demo2" is "parent"..
> Somehow, the plugin from "demo" leaks into "demo2", which I've verified is
> the case during a debug session.
> I'm still unsure of a couple of things:
> - Does it only happen with the "spring-cloud-contract-maven-plugin" plugin?
> - Where does ${project.version} come from? (I've not defined it)
> I've done a bisect and tracked it down to the following commit:
> [[MNG-5577] Convert maven-core to JSR
> 330|https://github.com/apache/maven/commit/9567da2bc889a94f5c3b692b4afb310ddbacd6e5]
> Subject project is attached. Reproduce with the current master of Maven: mvn
> validate.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #776: [MNG-7520] Simplify integration of Redisson and Hazelcast for Maven R…
michael-o commented on PR #776: URL: https://github.com/apache/maven/pull/776#issuecomment-1205345299 @cstamas how should I continue here? This is a reasonable simplification for everyone wants to use either one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7520) Simplify integration of Redisson and Hazelcast for Maven Resolver
[
https://issues.apache.org/jira/browse/MNG-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575300#comment-17575300
]
ASF GitHub Bot commented on MNG-7520:
-
michael-o commented on PR #776:
URL: https://github.com/apache/maven/pull/776#issuecomment-1205345299
@cstamas how should I continue here? This is a reasonable simplification for
everyone wants to use either one.
> Simplify integration of Redisson and Hazelcast for Maven Resolver
> -
>
> Key: MNG-7520
> URL: https://issues.apache.org/jira/browse/MNG-7520
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories, Dependencies
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently, to integrate Redisson or Hazelcast into Maven for distributed
> locking you need to create directories and modify {{m2.conf}}. We can make
> life easier by pre-creating them in the distribution.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-mvnd] jglick opened a new issue, #672: Deployed timestamped snapshot version does not change
jglick opened a new issue, #672: URL: https://github.com/apache/maven-mvnd/issues/672 ```bash mvn deploy # edit some file mvn deploy ``` (3.8.6) on a `*-SNAPSHOT` project using `nexus-staging-maven-plugin` will deploy snapshots with two different versions (`…-1` and `…-2`), as expected. But ```bash mvnd deploy # edit some file mvnd deploy ``` (0.7.1) seems to redeploy the same timestamped version (`…-1`). Maybe whatever inside Maven holds a consistent version number across reactor modules (recently added) is improperly being cached? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia] asfgit closed pull request #115: [DOXIA-669] Improve/rework CachedFileEntityResolver
asfgit closed pull request #115: [DOXIA-669] Improve/rework CachedFileEntityResolver URL: https://github.com/apache/maven-doxia/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-669) Improve/rework CachedFileEntityResolver
[
https://issues.apache.org/jira/browse/DOXIA-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575384#comment-17575384
]
ASF GitHub Bot commented on DOXIA-669:
--
asfgit closed pull request #115: [DOXIA-669] Improve/rework
CachedFileEntityResolver
URL: https://github.com/apache/maven-doxia/pull/115
> Improve/rework CachedFileEntityResolver
> ---
>
> Key: DOXIA-669
> URL: https://issues.apache.org/jira/browse/DOXIA-669
> Project: Maven Doxia
> Issue Type: Improvement
>Affects Versions: 2.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> While working on a few other the following flaws have been detected with the
> {{CachedFileEntityResolver}} which need to be addressed:
> * If a resource is not available, but through HTTP and the target will
> redirect to HTTPS {{HttpURLConnection}} will not follow by default and even
> worse it will not notify us
> * Our required resources: fml.xsd, xdoc.xsd and xml.xsd are only checked by
> system id and not public id which means you need to take care of multiple URLs
> * It perfoms outbound connections for resources which could be available
> offline, e.g., schemas from above
> * It logs zero information what is happening making debugging very hard
> * If a document does not supply a schema or DTD the validation fails while
> logically there is nothing to validate. E.g., HTML5 is now schemaless with
> mere {{}}.
> Things to be done:
> * Have all supported schema in the classpath for fast access
> * Remove all not used schemas
> * Provide a public id to classpath resource mapping to avoid alternating
> system ids
> * Add debug logging to assist analysis
> * Don't fail if a schema is not provided
> * If URL is a file load directly because file IO is fast.
> Likely other points.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (DOXIA-669) Improve/rework CachedFileEntityResolver
[
https://issues.apache.org/jira/browse/DOXIA-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed DOXIA-669.
Resolution: Fixed
Fixed with
[3b1499d0572718fa4dcb7c6b775bedbe757d46c5|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=3b1499d0572718fa4dcb7c6b775bedbe757d46c5].
> Improve/rework CachedFileEntityResolver
> ---
>
> Key: DOXIA-669
> URL: https://issues.apache.org/jira/browse/DOXIA-669
> Project: Maven Doxia
> Issue Type: Improvement
>Affects Versions: 2.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> While working on a few other the following flaws have been detected with the
> {{CachedFileEntityResolver}} which need to be addressed:
> * If a resource is not available, but through HTTP and the target will
> redirect to HTTPS {{HttpURLConnection}} will not follow by default and even
> worse it will not notify us
> * Our required resources: fml.xsd, xdoc.xsd and xml.xsd are only checked by
> system id and not public id which means you need to take care of multiple URLs
> * It perfoms outbound connections for resources which could be available
> offline, e.g., schemas from above
> * It logs zero information what is happening making debugging very hard
> * If a document does not supply a schema or DTD the validation fails while
> logically there is nothing to validate. E.g., HTML5 is now schemaless with
> mere {{}}.
> Things to be done:
> * Have all supported schema in the classpath for fast access
> * Remove all not used schemas
> * Provide a public id to classpath resource mapping to avoid alternating
> system ids
> * Add debug logging to assist analysis
> * Don't fail if a schema is not provided
> * If URL is a file load directly because file IO is fast.
> Likely other points.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] michael-o commented on pull request #114: [DOXIA-668] Remove all obsolete attributes in HTML5
michael-o commented on PR #114: URL: https://github.com/apache/maven-doxia/pull/114#issuecomment-1205638260 @hboutemy Added a commit for the table grid. As far as I udnerstand `border="1"` is a combination of CSS applied to `table` and `td`/`th` so we will leave this to the skin at most. Looking into alignment... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-668) Remove all obsolete attributes in HTML5
[
https://issues.apache.org/jira/browse/DOXIA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575400#comment-17575400
]
ASF GitHub Bot commented on DOXIA-668:
--
michael-o commented on PR #114:
URL: https://github.com/apache/maven-doxia/pull/114#issuecomment-1205638260
@hboutemy Added a commit for the table grid. As far as I udnerstand
`border="1"` is a combination of CSS applied to `table` and `td`/`th` so we
will leave this to the skin at most. Looking into alignment...
> Remove all obsolete attributes in HTML5
> ---
>
> Key: DOXIA-668
> URL: https://issues.apache.org/jira/browse/DOXIA-668
> Project: Maven Doxia
> Issue Type: Sub-task
> Components: Module - Xhtml
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> This listing provides all obsolete elements along with obsolete attributes
> per element:
> [https://www.tutorialrepublic.com/html-reference/html5-tags.php|https://www.tutorialrepublic.com/html-reference/html5-tags.php].
> We will remove attribute definitions in Sink and Parser (XHTML5 and derived
> like Xdoc and FML). Moreover these changes will break some usage:
> * Aligning of table cell must now happen through CSS on the TDs rather than
> providing it to table rows. There is no simple way to parse and write it in a
> format-neutral manner w/o huge effort.
> * Replace {{name}} with {{id}} on anchors.
> * Table borders must be solved by CSS now
> * Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}},
> {{td}}/{{th}}, sections, verbatims, {{tr}}
> Virtual all deprecated attributes have been superseded by CSS. Improve also
> tests because code is stricter now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] michael-o commented on a diff in pull request #114: [DOXIA-668] Remove all obsolete attributes in HTML5
michael-o commented on code in PR #114:
URL: https://github.com/apache/maven-doxia/pull/114#discussion_r938158983
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##
@@ -1621,29 +1503,6 @@ private void tableCell( boolean headerRow,
MutableAttributeSet attributes )
{
Tag t = ( headerRow ? HtmlMarkup.TH : HtmlMarkup.TD );
-if ( !headerRow && cellCountStack != null && !cellCountStack.isEmpty()
-&& cellJustifStack != null && !cellJustifStack.isEmpty() &&
getCellJustif() != null )
-{
-int cellCount = getCellCount();
-if ( cellCount < getCellJustif().length )
-{
-Map hash = new HashMap<>();
-hash.put( Sink.JUSTIFY_CENTER, SinkEventAttributeSet.CENTER );
-hash.put( Sink.JUSTIFY_LEFT, SinkEventAttributeSet.LEFT );
-hash.put( Sink.JUSTIFY_RIGHT, SinkEventAttributeSet.RIGHT );
-MutableAttributeSet atts = hash.get(
getCellJustif()[cellCount] );
-
-if ( attributes == null )
-{
-attributes = new SinkEventAttributeSet();
-}
-if ( atts != null )
-{
-attributes.addAttributes( atts );
-}
-}
-}
Review Comment:
Looking into this one..
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Xhtml5BaseParser.java:
##
@@ -1218,26 +1212,13 @@ private void handleSectionEnd( Sink sink )
private void handleTableStart( Sink sink, SinkEventAttributeSet attribs,
XmlPullParser parser )
{
sink.table( attribs );
-String border = parser.getAttributeValue( null,
Attribute.BORDER.toString() );
-boolean grid = true;
-
-if ( border == null || "0".equals( border ) )
+String givenTableClass = parser.getAttributeValue( null,
Attribute.CLASS.toString() );
+boolean grid = false;
+if ( givenTableClass != null && BODYTABLEBORDER_CLASS_PATTERN.matcher(
givenTableClass ).matches() )
{
-grid = false;
+grid = true;
}
-
-String align = parser.getAttributeValue( null,
Attribute.ALIGN.toString() );
-int[] justif = {Sink.JUSTIFY_LEFT};
-
-if ( "center".equals( align ) )
-{
-justif[0] = Sink.JUSTIFY_CENTER;
-}
-else if ( "right".equals( align ) )
-{
-justif[0] = Sink.JUSTIFY_RIGHT;
-}
-
-sink.tableRows( justif, grid );
+sink.tableRows( new int[0], grid );
Review Comment:
@hboutemy The only way to solve this here is to get the `style` from the
table and try to read for `text-align: {value}` and convert. It will not cover
any CSS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-668) Remove all obsolete attributes in HTML5
[
https://issues.apache.org/jira/browse/DOXIA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575407#comment-17575407
]
ASF GitHub Bot commented on DOXIA-668:
--
michael-o commented on code in PR #114:
URL: https://github.com/apache/maven-doxia/pull/114#discussion_r938158983
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##
@@ -1621,29 +1503,6 @@ private void tableCell( boolean headerRow,
MutableAttributeSet attributes )
{
Tag t = ( headerRow ? HtmlMarkup.TH : HtmlMarkup.TD );
-if ( !headerRow && cellCountStack != null && !cellCountStack.isEmpty()
-&& cellJustifStack != null && !cellJustifStack.isEmpty() &&
getCellJustif() != null )
-{
-int cellCount = getCellCount();
-if ( cellCount < getCellJustif().length )
-{
-Map hash = new HashMap<>();
-hash.put( Sink.JUSTIFY_CENTER, SinkEventAttributeSet.CENTER );
-hash.put( Sink.JUSTIFY_LEFT, SinkEventAttributeSet.LEFT );
-hash.put( Sink.JUSTIFY_RIGHT, SinkEventAttributeSet.RIGHT );
-MutableAttributeSet atts = hash.get(
getCellJustif()[cellCount] );
-
-if ( attributes == null )
-{
-attributes = new SinkEventAttributeSet();
-}
-if ( atts != null )
-{
-attributes.addAttributes( atts );
-}
-}
-}
Review Comment:
Looking into this one..
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Xhtml5BaseParser.java:
##
@@ -1218,26 +1212,13 @@ private void handleSectionEnd( Sink sink )
private void handleTableStart( Sink sink, SinkEventAttributeSet attribs,
XmlPullParser parser )
{
sink.table( attribs );
-String border = parser.getAttributeValue( null,
Attribute.BORDER.toString() );
-boolean grid = true;
-
-if ( border == null || "0".equals( border ) )
+String givenTableClass = parser.getAttributeValue( null,
Attribute.CLASS.toString() );
+boolean grid = false;
+if ( givenTableClass != null && BODYTABLEBORDER_CLASS_PATTERN.matcher(
givenTableClass ).matches() )
{
-grid = false;
+grid = true;
}
-
-String align = parser.getAttributeValue( null,
Attribute.ALIGN.toString() );
-int[] justif = {Sink.JUSTIFY_LEFT};
-
-if ( "center".equals( align ) )
-{
-justif[0] = Sink.JUSTIFY_CENTER;
-}
-else if ( "right".equals( align ) )
-{
-justif[0] = Sink.JUSTIFY_RIGHT;
-}
-
-sink.tableRows( justif, grid );
+sink.tableRows( new int[0], grid );
Review Comment:
@hboutemy The only way to solve this here is to get the `style` from the
table and try to read for `text-align: {value}` and convert. It will not cover
any CSS
> Remove all obsolete attributes in HTML5
> ---
>
> Key: DOXIA-668
> URL: https://issues.apache.org/jira/browse/DOXIA-668
> Project: Maven Doxia
> Issue Type: Sub-task
> Components: Module - Xhtml
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> This listing provides all obsolete elements along with obsolete attributes
> per element:
> [https://www.tutorialrepublic.com/html-reference/html5-tags.php|https://www.tutorialrepublic.com/html-reference/html5-tags.php].
> We will remove attribute definitions in Sink and Parser (XHTML5 and derived
> like Xdoc and FML). Moreover these changes will break some usage:
> * Aligning of table cell must now happen through CSS on the TDs rather than
> providing it to table rows. There is no simple way to parse and write it in a
> format-neutral manner w/o huge effort.
> * Replace {{name}} with {{id}} on anchors.
> * Table borders must be solved by CSS now
> * Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}},
> {{td}}/{{th}}, sections, verbatims, {{tr}}
> Virtual all deprecated attributes have been superseded by CSS. Improve also
> tests because code is stricter now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPH-189) Get rid of commons-lang3
Karl Heinz Marbaise created MPH-189: --- Summary: Get rid of commons-lang3 Key: MPH-189 URL: https://issues.apache.org/jira/browse/MPH-189 Project: Maven Help Plugin Issue Type: Task Affects Versions: 3.2.0 Reporter: Karl Heinz Marbaise Fix For: 3.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MPH-189) Get rid of commons-lang3
[ https://issues.apache.org/jira/browse/MPH-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MPH-189: --- Assignee: Karl Heinz Marbaise > Get rid of commons-lang3 > > > Key: MPH-189 > URL: https://issues.apache.org/jira/browse/MPH-189 > Project: Maven Help Plugin > Issue Type: Task >Affects Versions: 3.2.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (DOXIA-670) Remove code duplication XdocSink
Michael Osipov created DOXIA-670:
Summary: Remove code duplication XdocSink
Key: DOXIA-670
URL: https://issues.apache.org/jira/browse/DOXIA-670
Project: Maven Doxia
Issue Type: Task
Components: Module - Xhtml
Affects Versions: 2.0.0-M3
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 2.0.0-M4
{{Xhtml5Sink}} duplicates code from the parent class. That code can safely be
removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-670) Remove code duplication XdocSink
[
https://issues.apache.org/jira/browse/DOXIA-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-670:
-
Description: {{XdocSink}} duplicates code from the parent class. That code
can be removed. It has one caveat: The {{source}} element cannot be retained at
all because it has a completely different meaning in HTML5:
https://www.tutorialrepublic.com/html-reference/html5-source-tag.php and since
only the {{XHTML5Parser}} can properly detect the new construct
{{verbatim(boxed)}} will always be parsed as unboxed. (was: {{Xhtml5Sink}}
duplicates code from the parent class. That code can safely be removed.)
> Remove code duplication XdocSink
>
>
> Key: DOXIA-670
> URL: https://issues.apache.org/jira/browse/DOXIA-670
> Project: Maven Doxia
> Issue Type: Task
> Components: Module - Xhtml
>Affects Versions: 2.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> {{XdocSink}} duplicates code from the parent class. That code can be removed.
> It has one caveat: The {{source}} element cannot be retained at all because
> it has a completely different meaning in HTML5:
> https://www.tutorialrepublic.com/html-reference/html5-source-tag.php and
> since only the {{XHTML5Parser}} can properly detect the new construct
> {{verbatim(boxed)}} will always be parsed as unboxed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-670) Remove code duplication in XdocSink
[
https://issues.apache.org/jira/browse/DOXIA-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-670:
-
Summary: Remove code duplication in XdocSink (was: Remove code duplication
XdocSink)
> Remove code duplication in XdocSink
> ---
>
> Key: DOXIA-670
> URL: https://issues.apache.org/jira/browse/DOXIA-670
> Project: Maven Doxia
> Issue Type: Task
> Components: Module - Xhtml
>Affects Versions: 2.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> {{XdocSink}} duplicates code from the parent class. That code can be removed.
> It has one caveat: The {{source}} element cannot be retained at all because
> it has a completely different meaning in HTML5:
> https://www.tutorialrepublic.com/html-reference/html5-source-tag.php and
> since only the {{XHTML5Parser}} can properly detect the new construct
> {{verbatim(boxed)}} will always be parsed as unboxed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] michael-o commented on a diff in pull request #114: [DOXIA-668] Remove all obsolete attributes in HTML5
michael-o commented on code in PR #114:
URL: https://github.com/apache/maven-doxia/pull/114#discussion_r938215528
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##
@@ -1621,29 +1503,6 @@ private void tableCell( boolean headerRow,
MutableAttributeSet attributes )
{
Tag t = ( headerRow ? HtmlMarkup.TH : HtmlMarkup.TD );
-if ( !headerRow && cellCountStack != null && !cellCountStack.isEmpty()
-&& cellJustifStack != null && !cellJustifStack.isEmpty() &&
getCellJustif() != null )
-{
-int cellCount = getCellCount();
-if ( cellCount < getCellJustif().length )
-{
-Map hash = new HashMap<>();
-hash.put( Sink.JUSTIFY_CENTER, SinkEventAttributeSet.CENTER );
-hash.put( Sink.JUSTIFY_LEFT, SinkEventAttributeSet.LEFT );
-hash.put( Sink.JUSTIFY_RIGHT, SinkEventAttributeSet.RIGHT );
-MutableAttributeSet atts = hash.get(
getCellJustif()[cellCount] );
Review Comment:
This can be converted to CSS classes... during parsing this is retained...
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Xhtml5BaseParser.java:
##
@@ -1218,26 +1212,13 @@ private void handleSectionEnd( Sink sink )
private void handleTableStart( Sink sink, SinkEventAttributeSet attribs,
XmlPullParser parser )
{
sink.table( attribs );
-String border = parser.getAttributeValue( null,
Attribute.BORDER.toString() );
-boolean grid = true;
-
-if ( border == null || "0".equals( border ) )
+String givenTableClass = parser.getAttributeValue( null,
Attribute.CLASS.toString() );
+boolean grid = false;
+if ( givenTableClass != null && BODYTABLEBORDER_CLASS_PATTERN.matcher(
givenTableClass ).matches() )
{
-grid = false;
+grid = true;
}
-
-String align = parser.getAttributeValue( null,
Attribute.ALIGN.toString() );
-int[] justif = {Sink.JUSTIFY_LEFT};
-
-if ( "center".equals( align ) )
-{
-justif[0] = Sink.JUSTIFY_CENTER;
-}
-else if ( "right".equals( align ) )
-{
-justif[0] = Sink.JUSTIFY_RIGHT;
-}
-
-sink.tableRows( justif, grid );
Review Comment:
This could be a fixed, pregiven CSS class name, but then it does not make
sense to parse because it will be passed through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-668) Remove all obsolete attributes in HTML5
[
https://issues.apache.org/jira/browse/DOXIA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575444#comment-17575444
]
ASF GitHub Bot commented on DOXIA-668:
--
michael-o commented on code in PR #114:
URL: https://github.com/apache/maven-doxia/pull/114#discussion_r938215528
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##
@@ -1621,29 +1503,6 @@ private void tableCell( boolean headerRow,
MutableAttributeSet attributes )
{
Tag t = ( headerRow ? HtmlMarkup.TH : HtmlMarkup.TD );
-if ( !headerRow && cellCountStack != null && !cellCountStack.isEmpty()
-&& cellJustifStack != null && !cellJustifStack.isEmpty() &&
getCellJustif() != null )
-{
-int cellCount = getCellCount();
-if ( cellCount < getCellJustif().length )
-{
-Map hash = new HashMap<>();
-hash.put( Sink.JUSTIFY_CENTER, SinkEventAttributeSet.CENTER );
-hash.put( Sink.JUSTIFY_LEFT, SinkEventAttributeSet.LEFT );
-hash.put( Sink.JUSTIFY_RIGHT, SinkEventAttributeSet.RIGHT );
-MutableAttributeSet atts = hash.get(
getCellJustif()[cellCount] );
Review Comment:
This can be converted to CSS classes... during parsing this is retained...
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Xhtml5BaseParser.java:
##
@@ -1218,26 +1212,13 @@ private void handleSectionEnd( Sink sink )
private void handleTableStart( Sink sink, SinkEventAttributeSet attribs,
XmlPullParser parser )
{
sink.table( attribs );
-String border = parser.getAttributeValue( null,
Attribute.BORDER.toString() );
-boolean grid = true;
-
-if ( border == null || "0".equals( border ) )
+String givenTableClass = parser.getAttributeValue( null,
Attribute.CLASS.toString() );
+boolean grid = false;
+if ( givenTableClass != null && BODYTABLEBORDER_CLASS_PATTERN.matcher(
givenTableClass ).matches() )
{
-grid = false;
+grid = true;
}
-
-String align = parser.getAttributeValue( null,
Attribute.ALIGN.toString() );
-int[] justif = {Sink.JUSTIFY_LEFT};
-
-if ( "center".equals( align ) )
-{
-justif[0] = Sink.JUSTIFY_CENTER;
-}
-else if ( "right".equals( align ) )
-{
-justif[0] = Sink.JUSTIFY_RIGHT;
-}
-
-sink.tableRows( justif, grid );
Review Comment:
This could be a fixed, pregiven CSS class name, but then it does not make
sense to parse because it will be passed through.
> Remove all obsolete attributes in HTML5
> ---
>
> Key: DOXIA-668
> URL: https://issues.apache.org/jira/browse/DOXIA-668
> Project: Maven Doxia
> Issue Type: Sub-task
> Components: Module - Xhtml
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> This listing provides all obsolete elements along with obsolete attributes
> per element:
> [https://www.tutorialrepublic.com/html-reference/html5-tags.php|https://www.tutorialrepublic.com/html-reference/html5-tags.php].
> We will remove attribute definitions in Sink and Parser (XHTML5 and derived
> like Xdoc and FML). Moreover these changes will break some usage:
> * Aligning of table cell must now happen through CSS on the TDs rather than
> providing it to table rows. There is no simple way to parse and write it in a
> format-neutral manner w/o huge effort.
> * Replace {{name}} with {{id}} on anchors.
> * Table borders must be solved by CSS now
> * Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}},
> {{td}}/{{th}}, sections, verbatims, {{tr}}
> Virtual all deprecated attributes have been superseded by CSS. Improve also
> tests because code is stricter now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] dependabot[bot] opened a new pull request, #316: Bump maven-site-plugin from 3.12.0 to 3.12.1
dependabot[bot] opened a new pull request, #316: URL: https://github.com/apache/maven-site/pull/316 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.12.0 to 3.12.1. Commits https://github.com/apache/maven-site-plugin/commit/ecae28fb0990eb5a7fc8f2d4ffe07f348d927f4b";>ecae28f [maven-release-plugin] prepare release maven-site-plugin-3.12.1 https://github.com/apache/maven-site-plugin/commit/d98569b083ded7a5182bf6cb5814ddcbd3150267";>d98569b [MSITE-908] Upgrade Maven Reporting API to 3.1.1 https://github.com/apache/maven-site-plugin/commit/bd3376f52d0053e05c78327aad39353710702a7a";>bd3376f [MSITE-901] If precending standalone report has been run, site:jar does not r... https://github.com/apache/maven-site-plugin/commit/b99c0ef371774a414ade764f2921bdfe8918ed60";>b99c0ef [MSITE-902] Upgrade Plexus Utils to 3.4.2 https://github.com/apache/maven-site-plugin/commit/3c6ff2e285063231b7042bfe7875871c9d339830";>3c6ff2e Update CI URL https://github.com/apache/maven-site-plugin/commit/f314e9da6ba0b5611fd5dd7dcff2d9ecc36dcd61";>f314e9d [MSITE-898] Upgrade Parent to 36 https://github.com/apache/maven-site-plugin/commit/bce7458375464e58f5d2d6cff92f8dde5f45de67";>bce7458 [MSITE-897] Upgrade Plexus Archiver to 4.2.7 https://github.com/apache/maven-site-plugin/commit/3c8d426aae79c793a2a3acfddbd47a6826346382";>3c8d426 keep only release month, drop day https://github.com/apache/maven-site-plugin/commit/6604ab3b53d3f4045cc755340aeb0c4feaeaf8df";>6604ab3 also keep only Doxia versions changes https://github.com/apache/maven-site-plugin/commit/789a7a1054babde3c5b01e48bbf8abca49f5af8f";>789a7a1 lighten content: keep only meaningful values Additional commits viewable in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.12.0...maven-site-plugin-3.12.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #101: Bump maven-site-plugin from 3.12.0 to 3.12.1
dependabot[bot] opened a new pull request, #101: URL: https://github.com/apache/maven-apache-parent/pull/101 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.12.0 to 3.12.1. Commits https://github.com/apache/maven-site-plugin/commit/ecae28fb0990eb5a7fc8f2d4ffe07f348d927f4b";>ecae28f [maven-release-plugin] prepare release maven-site-plugin-3.12.1 https://github.com/apache/maven-site-plugin/commit/d98569b083ded7a5182bf6cb5814ddcbd3150267";>d98569b [MSITE-908] Upgrade Maven Reporting API to 3.1.1 https://github.com/apache/maven-site-plugin/commit/bd3376f52d0053e05c78327aad39353710702a7a";>bd3376f [MSITE-901] If precending standalone report has been run, site:jar does not r... https://github.com/apache/maven-site-plugin/commit/b99c0ef371774a414ade764f2921bdfe8918ed60";>b99c0ef [MSITE-902] Upgrade Plexus Utils to 3.4.2 https://github.com/apache/maven-site-plugin/commit/3c6ff2e285063231b7042bfe7875871c9d339830";>3c6ff2e Update CI URL https://github.com/apache/maven-site-plugin/commit/f314e9da6ba0b5611fd5dd7dcff2d9ecc36dcd61";>f314e9d [MSITE-898] Upgrade Parent to 36 https://github.com/apache/maven-site-plugin/commit/bce7458375464e58f5d2d6cff92f8dde5f45de67";>bce7458 [MSITE-897] Upgrade Plexus Archiver to 4.2.7 https://github.com/apache/maven-site-plugin/commit/3c8d426aae79c793a2a3acfddbd47a6826346382";>3c8d426 keep only release month, drop day https://github.com/apache/maven-site-plugin/commit/6604ab3b53d3f4045cc755340aeb0c4feaeaf8df";>6604ab3 also keep only Doxia versions changes https://github.com/apache/maven-site-plugin/commit/789a7a1054babde3c5b01e48bbf8abca49f5af8f";>789a7a1 lighten content: keep only meaningful values Additional commits viewable in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.12.0...maven-site-plugin-3.12.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #116: Bump maven-site-plugin from 3.9.1 to 3.12.1
dependabot[bot] opened a new pull request, #116: URL: https://github.com/apache/maven-jlink-plugin/pull/116 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.9.1 to 3.12.1. Release notes Sourced from https://github.com/apache/maven-site-plugin/releases";>maven-site-plugin's releases. 3.11.0 What's Changed [MSITE-812] Missing '/' in log when deploying documentation by site:stage by https://github.com/aajisaka";>@aajisaka in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/1";>apache/maven-site-plugin#1 [MSITE-828] Upgrade jetty to recent version. Update to java 1.8 (required for jetty) by https://github.com/oflebbe";>@oflebbe in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/3";>apache/maven-site-plugin#3 MSITE-848 Update sitedescriptor.apt by https://github.com/ctubbsii";>@ctubbsii in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/13";>apache/maven-site-plugin#13 MSITE-847: Corrected link to prerequisite maven version. by https://github.com/KathrynN";>@KathrynN in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/14";>apache/maven-site-plugin#14 remove info about old version by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/19";>apache/maven-site-plugin#19 update test dependencies by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/17";>apache/maven-site-plugin#17 Only reference current version: created on website by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/18";>apache/maven-site-plugin#18 [MNGSITE-393] assume Maven 3 as default by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/20";>apache/maven-site-plugin#20 add .checkstyle to .gitignore by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/22";>apache/maven-site-plugin#22 remove unused code by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/23";>apache/maven-site-plugin#23 [MSITE-859] update apache commons lang and IO by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/25";>apache/maven-site-plugin#25 [MSITE-757] remove Maven 2 support by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/24";>apache/maven-site-plugin#24 [MSITE-757] drop Maven 2 mention by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/26";>apache/maven-site-plugin#26 docs: use https by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/28";>apache/maven-site-plugin#28 [MSITE-861] remove obsolete dependency by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/29";>apache/maven-site-plugin#29 [MNGSITE-393] remove Maven 1 and 2 info by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/30";>apache/maven-site-plugin#30 Fix script injection example in docs by https://github.com/strkkk";>@strkkk in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/35";>apache/maven-site-plugin#35 trivial change by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/38";>apache/maven-site-plugin#38 [MSITE-871] Upgrade Maven Javadoc Plugin in integration tests by https://github.com/mthmulders";>@mthmulders in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/39";>apache/maven-site-plugin#39 Bump plexus-archiver from 4.2.4 to 4.2.5 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/47";>apache/maven-site-plugin#47 Bump maven-shared-utils from 3.3.3 to 3.3.4 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/50";>apache/maven-site-plugin#50 Bump slf4jVersion from 1.7.29 to 1.7.31 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/54";>apache/maven-site-plugin#54 Bump slf4jVersion from 1.7.31 to 1.7.32 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/58";>apache/maven-site-plugin#58 Add PR template by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/63";>apache/maven-site-plugin#63 [MSITE-877] Shared GitHub Actions by https://github.
[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #106: Bump maven-site-plugin from 3.9.1 to 3.12.0
dependabot[bot] commented on PR #106: URL: https://github.com/apache/maven-jlink-plugin/pull/106#issuecomment-1206018364 Superseded by #116. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #106: Bump maven-site-plugin from 3.9.1 to 3.12.0
dependabot[bot] closed pull request #106: Bump maven-site-plugin from 3.9.1 to 3.12.0 URL: https://github.com/apache/maven-jlink-plugin/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
