[jira] [Created] (DOXIA-668) Remove all obsolete attributes in HTML5
Michael Osipov created DOXIA-668:
Summary: Remove all obsolete attributes in HTML5
Key: DOXIA-668
URL: https://issues.apache.org/jira/browse/DOXIA-668
Project: Maven Doxia
Issue Type: Sub-task
Components: Module - Xhtml
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 2.0.0-M4
[This|https://www.tutorialrepublic.com/html-reference/html5-tags.php] listing
provides all obsolete elements along with obsolete attributes per element. We
will remove attribute definitons in Sink and Parser (XHTML5 and derived like
Xdoc and FML). Moreover these changes will break usage:
* Aligning of table cell must now happen through CSS on the TDs rather than
providing it to table rows. There is no simple way to parse and write it in a
format-neutral manner w/o huge effort.
* Replace {{name}} with {{id}} on anchors.
* Table borders must be solved by CSS now
* Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}}, {{td}}/{{th}},
sections, verbatims, {{tr}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-668) Remove all obsolete attributes in HTML5
[
https://issues.apache.org/jira/browse/DOXIA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-668:
-
Description:
[This|https://www.tutorialrepublic.com/html-reference/html5-tags.php] listing
provides all obsolete elements along with obsolete attributes per element. We
will remove attribute definitions in Sink and Parser (XHTML5 and derived like
Xdoc and FML). Moreover these changes will break usage:
* Aligning of table cell must now happen through CSS on the TDs rather than
providing it to table rows. There is no simple way to parse and write it in a
format-neutral manner w/o huge effort.
* Replace {{name}} with {{id}} on anchors.
* Table borders must be solved by CSS now
* Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}}, {{td}}/{{th}},
sections, verbatims, {{tr}}
Virtual all deprecated attributes have been superseded by CSS.
was:
[This|https://www.tutorialrepublic.com/html-reference/html5-tags.php] listing
provides all obsolete elements along with obsolete attributes per element. We
will remove attribute definitons in Sink and Parser (XHTML5 and derived like
Xdoc and FML). Moreover these changes will break usage:
* Aligning of table cell must now happen through CSS on the TDs rather than
providing it to table rows. There is no simple way to parse and write it in a
format-neutral manner w/o huge effort.
* Replace {{name}} with {{id}} on anchors.
* Table borders must be solved by CSS now
* Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}}, {{td}}/{{th}},
sections, verbatims, {{tr}}
> Remove all obsolete attributes in HTML5
> ---
>
> Key: DOXIA-668
> URL: https://issues.apache.org/jira/browse/DOXIA-668
> Project: Maven Doxia
> Issue Type: Sub-task
> Components: Module - Xhtml
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> [This|https://www.tutorialrepublic.com/html-reference/html5-tags.php] listing
> provides all obsolete elements along with obsolete attributes per element. We
> will remove attribute definitions in Sink and Parser (XHTML5 and derived like
> Xdoc and FML). Moreover these changes will break usage:
> * Aligning of table cell must now happen through CSS on the TDs rather than
> providing it to table rows. There is no simple way to parse and write it in a
> format-neutral manner w/o huge effort.
> * Replace {{name}} with {{id}} on anchors.
> * Table borders must be solved by CSS now
> * Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}},
> {{td}}/{{th}}, sections, verbatims, {{tr}}
> Virtual all deprecated attributes have been superseded by CSS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-assembly-plugin] pzygielo opened a new pull request, #85: Fix site "usage" page
pzygielo opened a new pull request, #85: URL: https://github.com/apache/maven-assembly-plugin/pull/85 Similar to - https://github.com/apache/maven-remote-resources-plugin/pull/8  - To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DOXIA-668) Remove all obsolete attributes in HTML5
[
https://issues.apache.org/jira/browse/DOXIA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-668:
-
Description:
[This|https://www.tutorialrepublic.com/html-reference/html5-tags.php] listing
provides all obsolete elements along with obsolete attributes per element. We
will remove attribute definitions in Sink and Parser (XHTML5 and derived like
Xdoc and FML). Moreover these changes will break usage:
* Aligning of table cell must now happen through CSS on the TDs rather than
providing it to table rows. There is no simple way to parse and write it in a
format-neutral manner w/o huge effort.
* Replace {{name}} with {{id}} on anchors.
* Table borders must be solved by CSS now
* Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}}, {{td}}/{{th}},
sections, verbatims, {{tr}}
Virtual all deprecated attributes have been superseded by CSS. Improve also
tests because code is stricter now.
was:
[This|https://www.tutorialrepublic.com/html-reference/html5-tags.php] listing
provides all obsolete elements along with obsolete attributes per element. We
will remove attribute definitions in Sink and Parser (XHTML5 and derived like
Xdoc and FML). Moreover these changes will break usage:
* Aligning of table cell must now happen through CSS on the TDs rather than
providing it to table rows. There is no simple way to parse and write it in a
format-neutral manner w/o huge effort.
* Replace {{name}} with {{id}} on anchors.
* Table borders must be solved by CSS now
* Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}}, {{td}}/{{th}},
sections, verbatims, {{tr}}
Virtual all deprecated attributes have been superseded by CSS.
> Remove all obsolete attributes in HTML5
> ---
>
> Key: DOXIA-668
> URL: https://issues.apache.org/jira/browse/DOXIA-668
> Project: Maven Doxia
> Issue Type: Sub-task
> Components: Module - Xhtml
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> [This|https://www.tutorialrepublic.com/html-reference/html5-tags.php] listing
> provides all obsolete elements along with obsolete attributes per element. We
> will remove attribute definitions in Sink and Parser (XHTML5 and derived like
> Xdoc and FML). Moreover these changes will break usage:
> * Aligning of table cell must now happen through CSS on the TDs rather than
> providing it to table rows. There is no simple way to parse and write it in a
> format-neutral manner w/o huge effort.
> * Replace {{name}} with {{id}} on anchors.
> * Table borders must be solved by CSS now
> * Affected elements: {{img}}, {{hr}}, links ({{a}}), {{table}},
> {{td}}/{{th}}, sections, verbatims, {{tr}}
> Virtual all deprecated attributes have been superseded by CSS. Improve also
> tests because code is stricter now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-assembly-plugin] michael-o merged pull request #85: Fix site "usage" page
michael-o merged PR #85: URL: https://github.com/apache/maven-assembly-plugin/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DOXIA-669) Improve/rework CachedFileEntityResolver
[
https://issues.apache.org/jira/browse/DOXIA-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-669:
-
Summary: Improve/rework CachedFileEntityResolver (was: Improve rework
CachedFileEntityResolver)
> Improve/rework CachedFileEntityResolver
> ---
>
> Key: DOXIA-669
> URL: https://issues.apache.org/jira/browse/DOXIA-669
> Project: Maven Doxia
> Issue Type: Improvement
>Affects Versions: 2.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> While working on a few other the following flaws have been detected with the
> {{CachedFileEntityResolver}} which need to be addressed:
> * If a resource is not available, but through HTTP and the target will
> redirect to HTTPS {{HttpURLConnection}} will not follow by default and even
> worse it will not notify us
> * Our required resources: fml.xsd, xdoc.xsd and xml.xsd are only checked by
> system id and not public id which means you need to take care of multiple URLs
> * It perfoms outbound connections for resources which could be available
> offline, e.g., schemas from above
> * It logs zero information what is happening making debugging very hard
> * If a document does not supply a schema or DTD the validation fails while
> logically there is nothing to validate. E.g., HTML5 is now schemaless with
> mere {{}}.
> Things to be done:
> * Have all supported schema in the classpath for fast access
> * Remove all not used schemas
> * Provide a public id to classpath resource mapping to avoid alternating
> system ids
> * Add debug logging to assist analysis
> * Don't fail if a schema is not required
> * If URL is a file load directly because file IO is fast.
> Likely other points.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (DOXIA-669) Improve rework CachedFileEntityResolver
Michael Osipov created DOXIA-669:
Summary: Improve rework CachedFileEntityResolver
Key: DOXIA-669
URL: https://issues.apache.org/jira/browse/DOXIA-669
Project: Maven Doxia
Issue Type: Improvement
Affects Versions: 2.0.0-M3
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 2.0.0-M4
While working on a few other the following flaws have been detected with the
{{CachedFileEntityResolver}} which need to be addressed:
* If a resource is not available, but through HTTP and the target will redirect
to HTTPS {{HttpURLConnection}} will not follow by default and even worse it
will not notify us
* Our required resources: fml.xsd, xdoc.xsd and xml.xsd are only checked by
system id and not public id which means you need to take care of multiple URLs
* It perfoms outbound connections for resources which could be available
offline, e.g., schemas from above
* It logs zero information what is happening making debugging very hard
* If a document does not supply a schema or DTD the validation fails while
logically there is nothing to validate. E.g., HTML5 is now schemaless with mere
{{}}.
Things to be done:
* Have all supported schema in the classpath for fast access
* Remove all not used schemas
* Provide a public id to classpath resource mapping to avoid alternating system
ids
* Add debug logging to assist analysis
* Don't fail if a schema is not required
* If URL is a file load directly because file IO is fast.
Likely other points.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-485) Incorrect internal string format in generated package-info.class files on Windows
[
https://issues.apache.org/jira/browse/MCOMPILER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574296#comment-17574296
]
Alexander Kriegisch commented on MCOMPILER-485:
---
Just in case other AspectJ users also get weird errors due to this problem: I
never would have expected this to be an MCOMPILER problem, unaware of the fact
that the plugin actually creates byte code for package infos using ASM instead
of relying on Javac or ECJ functionality. I even implemented a woraround in the
AspectJ compiler for this, because I thought that Javac itself creates bogus
byte code for this corner case. Only later I noticed that Maven Compiler itself
was the culprit. See https://github.com/eclipse/org.aspectj/issues/176. This
was an expensive bug.
Lesson learned(?): I think you should have used Java compiler functionality in
order to create those files, namely {{-Xpkginfo:always}} on Javac and rely on
ECJ to create those class files by default anyway. No own implementation, no
own bug.
> Incorrect internal string format in generated package-info.class files on
> Windows
> -
>
> Key: MCOMPILER-485
> URL: https://issues.apache.org/jira/browse/MCOMPILER-485
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
> Environment: Windows, or any operating system with a file separator
> character other than a forward slash
>Reporter: Daniel Widdis
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.10.1
>
>
> In 3.10.0, a new feature to generate package-info classes was added in
> [[MCOMPILER-205] |https://github.com/apache/maven-compiler-plugin/pull/88]
> Unfortunately, the binary class file is incorrectly generated using Java's
> file toString() which uses a platform dependent file separator character: on
> Windows, these Strings contain a backslash. See [this
> line|https://github.com/gnodet/maven-compiler-plugin/blob/8521ef8fdd12cc0b85c1ace17114ed3d3ffd0b0c/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L1356]
> which passes the platform-dependent file name (minus the root path and .java
> extension) to the ClassWriter.
> The Java class file specification (4.2.1) specifies the internal format: "In
> this internal form, the ASCII periods (.) that normally separate the
> identifiers which make up the binary name are replaced by ASCII forward
> slashes (/)."
> This invalid class file format causes problems in downstream plugins, e.g.,
> * The bnd-maven-plugin fails with an error: Classes found in the wrong
> directory:
> \{oshi/jna/platform/unix/package-info.class=oshi\jna\platform\unix\package-info
> ... (and hundreds more) ... }
> * The JDK's
> [classFileParser|https://github.com/openjdk/jdk17/blob/74007890bb9a3fa3a65683a3f480e399f2b1a0b6/src/hotspot/share/classfile/classFileParser.cpp#L5797]
> will throw java.lang.NoClassDefFoundError:
> com\puppycrawl\tools\checkstyle\ant\package-info (wrong name:
> com/puppycrawl/tools/checkstyle/ant/package-info
> Steps to reproduce:
> # Perform a build on any Windows machine using maven-compiler-plugin 3.10.0
> # Inspect any of the generated package-info.class files in target/classes
> using a text editor
> Expected behavior:
> Internal strings representing package names use forward slashes
> Observed behavior:
> Internal strings representing package names use backward slashes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MCOMPILER-485) Incorrect internal string format in generated package-info.class files on Windows
[
https://issues.apache.org/jira/browse/MCOMPILER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574296#comment-17574296
]
Alexander Kriegisch edited comment on MCOMPILER-485 at 8/2/22 3:46 PM:
---
Just in case other AspectJ users also get weird errors due to this problem: I
never would have expected this to be an MCOMPILER problem, unaware of the fact
that the plugin actually creates byte code for package infos using ASM instead
of relying on Javac or ECJ functionality. I even implemented a woraround in the
AspectJ compiler for this, because I thought that Javac itself creates bogus
byte code for this corner case. Only later I noticed that Maven Compiler itself
was the culprit. See https://github.com/eclipse/org.aspectj/issues/176. This
was an expensive bug.
Lesson learned (I hope): I think you should have used Java compiler
functionality in order to create those files, namely {{-Xpkginfo:always}} on
Javac and rely on ECJ to create those class files by default anyway. No own
implementation, no own bug.
was (Author: kriegaex):
Just in case other AspectJ users also get weird errors due to this problem: I
never would have expected this to be an MCOMPILER problem, unaware of the fact
that the plugin actually creates byte code for package infos using ASM instead
of relying on Javac or ECJ functionality. I even implemented a woraround in the
AspectJ compiler for this, because I thought that Javac itself creates bogus
byte code for this corner case. Only later I noticed that Maven Compiler itself
was the culprit. See https://github.com/eclipse/org.aspectj/issues/176. This
was an expensive bug.
Lesson learned(?): I think you should have used Java compiler functionality in
order to create those files, namely {{-Xpkginfo:always}} on Javac and rely on
ECJ to create those class files by default anyway. No own implementation, no
own bug.
> Incorrect internal string format in generated package-info.class files on
> Windows
> -
>
> Key: MCOMPILER-485
> URL: https://issues.apache.org/jira/browse/MCOMPILER-485
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
> Environment: Windows, or any operating system with a file separator
> character other than a forward slash
>Reporter: Daniel Widdis
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.10.1
>
>
> In 3.10.0, a new feature to generate package-info classes was added in
> [[MCOMPILER-205] |https://github.com/apache/maven-compiler-plugin/pull/88]
> Unfortunately, the binary class file is incorrectly generated using Java's
> file toString() which uses a platform dependent file separator character: on
> Windows, these Strings contain a backslash. See [this
> line|https://github.com/gnodet/maven-compiler-plugin/blob/8521ef8fdd12cc0b85c1ace17114ed3d3ffd0b0c/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L1356]
> which passes the platform-dependent file name (minus the root path and .java
> extension) to the ClassWriter.
> The Java class file specification (4.2.1) specifies the internal format: "In
> this internal form, the ASCII periods (.) that normally separate the
> identifiers which make up the binary name are replaced by ASCII forward
> slashes (/)."
> This invalid class file format causes problems in downstream plugins, e.g.,
> * The bnd-maven-plugin fails with an error: Classes found in the wrong
> directory:
> \{oshi/jna/platform/unix/package-info.class=oshi\jna\platform\unix\package-info
> ... (and hundreds more) ... }
> * The JDK's
> [classFileParser|https://github.com/openjdk/jdk17/blob/74007890bb9a3fa3a65683a3f480e399f2b1a0b6/src/hotspot/share/classfile/classFileParser.cpp#L5797]
> will throw java.lang.NoClassDefFoundError:
> com\puppycrawl\tools\checkstyle\ant\package-info (wrong name:
> com/puppycrawl/tools/checkstyle/ant/package-info
> Steps to reproduce:
> # Perform a build on any Windows machine using maven-compiler-plugin 3.10.0
> # Inspect any of the generated package-info.class files in target/classes
> using a text editor
> Expected behavior:
> Internal strings representing package names use forward slashes
> Observed behavior:
> Internal strings representing package names use backward slashes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-669) Improve/rework CachedFileEntityResolver
[
https://issues.apache.org/jira/browse/DOXIA-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574317#comment-17574317
]
Michael Osipov commented on DOXIA-669:
--
Note: The validation cannot be turned off/skipped for HTML5 doctype since both
public id and system id are null. Best is not to validate these documents at
all.
> Improve/rework CachedFileEntityResolver
> ---
>
> Key: DOXIA-669
> URL: https://issues.apache.org/jira/browse/DOXIA-669
> Project: Maven Doxia
> Issue Type: Improvement
>Affects Versions: 2.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> While working on a few other the following flaws have been detected with the
> {{CachedFileEntityResolver}} which need to be addressed:
> * If a resource is not available, but through HTTP and the target will
> redirect to HTTPS {{HttpURLConnection}} will not follow by default and even
> worse it will not notify us
> * Our required resources: fml.xsd, xdoc.xsd and xml.xsd are only checked by
> system id and not public id which means you need to take care of multiple URLs
> * It perfoms outbound connections for resources which could be available
> offline, e.g., schemas from above
> * It logs zero information what is happening making debugging very hard
> * If a document does not supply a schema or DTD the validation fails while
> logically there is nothing to validate. E.g., HTML5 is now schemaless with
> mere {{}}.
> Things to be done:
> * Have all supported schema in the classpath for fast access
> * Remove all not used schemas
> * Provide a public id to classpath resource mapping to avoid alternating
> system ids
> * Add debug logging to assist analysis
> * Don't fail if a schema is not required
> * If URL is a file load directly because file IO is fast.
> Likely other points.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-ejb-plugin] pzygielo opened a new pull request, #18: Fix site "usage" page
pzygielo opened a new pull request, #18: URL: https://github.com/apache/maven-ejb-plugin/pull/18 Similar to - https://github.com/apache/maven-remote-resources-plugin/pull/8  - To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ejb-plugin] michael-o merged pull request #18: Fix site "usage" page
michael-o merged PR #18: URL: https://github.com/apache/maven-ejb-plugin/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DOXIA-669) Improve/rework CachedFileEntityResolver
[
https://issues.apache.org/jira/browse/DOXIA-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-669:
-
Description:
While working on a few other the following flaws have been detected with the
{{CachedFileEntityResolver}} which need to be addressed:
* If a resource is not available, but through HTTP and the target will redirect
to HTTPS {{HttpURLConnection}} will not follow by default and even worse it
will not notify us
* Our required resources: fml.xsd, xdoc.xsd and xml.xsd are only checked by
system id and not public id which means you need to take care of multiple URLs
* It perfoms outbound connections for resources which could be available
offline, e.g., schemas from above
* It logs zero information what is happening making debugging very hard
* If a document does not supply a schema or DTD the validation fails while
logically there is nothing to validate. E.g., HTML5 is now schemaless with mere
{{}}.
Things to be done:
* Have all supported schema in the classpath for fast access
* Remove all not used schemas
* Provide a public id to classpath resource mapping to avoid alternating system
ids
* Add debug logging to assist analysis
* Don't fail if a schema is not provided
* If URL is a file load directly because file IO is fast.
Likely other points.
was:
While working on a few other the following flaws have been detected with the
{{CachedFileEntityResolver}} which need to be addressed:
* If a resource is not available, but through HTTP and the target will redirect
to HTTPS {{HttpURLConnection}} will not follow by default and even worse it
will not notify us
* Our required resources: fml.xsd, xdoc.xsd and xml.xsd are only checked by
system id and not public id which means you need to take care of multiple URLs
* It perfoms outbound connections for resources which could be available
offline, e.g., schemas from above
* It logs zero information what is happening making debugging very hard
* If a document does not supply a schema or DTD the validation fails while
logically there is nothing to validate. E.g., HTML5 is now schemaless with mere
{{}}.
Things to be done:
* Have all supported schema in the classpath for fast access
* Remove all not used schemas
* Provide a public id to classpath resource mapping to avoid alternating system
ids
* Add debug logging to assist analysis
* Don't fail if a schema is not required
* If URL is a file load directly because file IO is fast.
Likely other points.
> Improve/rework CachedFileEntityResolver
> ---
>
> Key: DOXIA-669
> URL: https://issues.apache.org/jira/browse/DOXIA-669
> Project: Maven Doxia
> Issue Type: Improvement
>Affects Versions: 2.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> While working on a few other the following flaws have been detected with the
> {{CachedFileEntityResolver}} which need to be addressed:
> * If a resource is not available, but through HTTP and the target will
> redirect to HTTPS {{HttpURLConnection}} will not follow by default and even
> worse it will not notify us
> * Our required resources: fml.xsd, xdoc.xsd and xml.xsd are only checked by
> system id and not public id which means you need to take care of multiple URLs
> * It perfoms outbound connections for resources which could be available
> offline, e.g., schemas from above
> * It logs zero information what is happening making debugging very hard
> * If a document does not supply a schema or DTD the validation fails while
> logically there is nothing to validate. E.g., HTML5 is now schemaless with
> mere {{}}.
> Things to be done:
> * Have all supported schema in the classpath for fast access
> * Remove all not used schemas
> * Provide a public id to classpath resource mapping to avoid alternating
> system ids
> * Add debug logging to assist analysis
> * Don't fail if a schema is not provided
> * If URL is a file load directly because file IO is fast.
> Likely other points.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-ejb-plugin] pzygielo commented on pull request #18: Fix site "usage" page
pzygielo commented on PR #18: URL: https://github.com/apache/maven-ejb-plugin/pull/18#issuecomment-1203042607 @michael-o - thanks for checking. Per my investigation that's all in plugins :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-485) Incorrect internal string format in generated package-info.class files on Windows
[
https://issues.apache.org/jira/browse/MCOMPILER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574527#comment-17574527
]
Olivier Lamy commented on MCOMPILER-485:
ah yes this option -Xpkginfo:always sounds good to replace all the code with
simply adding the arg to compiler call.
[~gnodet] wdyt? we could get rid of some code
> Incorrect internal string format in generated package-info.class files on
> Windows
> -
>
> Key: MCOMPILER-485
> URL: https://issues.apache.org/jira/browse/MCOMPILER-485
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
> Environment: Windows, or any operating system with a file separator
> character other than a forward slash
>Reporter: Daniel Widdis
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.10.1
>
>
> In 3.10.0, a new feature to generate package-info classes was added in
> [[MCOMPILER-205] |https://github.com/apache/maven-compiler-plugin/pull/88]
> Unfortunately, the binary class file is incorrectly generated using Java's
> file toString() which uses a platform dependent file separator character: on
> Windows, these Strings contain a backslash. See [this
> line|https://github.com/gnodet/maven-compiler-plugin/blob/8521ef8fdd12cc0b85c1ace17114ed3d3ffd0b0c/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L1356]
> which passes the platform-dependent file name (minus the root path and .java
> extension) to the ClassWriter.
> The Java class file specification (4.2.1) specifies the internal format: "In
> this internal form, the ASCII periods (.) that normally separate the
> identifiers which make up the binary name are replaced by ASCII forward
> slashes (/)."
> This invalid class file format causes problems in downstream plugins, e.g.,
> * The bnd-maven-plugin fails with an error: Classes found in the wrong
> directory:
> \{oshi/jna/platform/unix/package-info.class=oshi\jna\platform\unix\package-info
> ... (and hundreds more) ... }
> * The JDK's
> [classFileParser|https://github.com/openjdk/jdk17/blob/74007890bb9a3fa3a65683a3f480e399f2b1a0b6/src/hotspot/share/classfile/classFileParser.cpp#L5797]
> will throw java.lang.NoClassDefFoundError:
> com\puppycrawl\tools\checkstyle\ant\package-info (wrong name:
> com/puppycrawl/tools/checkstyle/ant/package-info
> Steps to reproduce:
> # Perform a build on any Windows machine using maven-compiler-plugin 3.10.0
> # Inspect any of the generated package-info.class files in target/classes
> using a text editor
> Expected behavior:
> Internal strings representing package names use forward slashes
> Observed behavior:
> Internal strings representing package names use backward slashes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
