[GitHub] [maven-reporting-impl] hboutemy commented on a diff in pull request #9: Render with Skins

2022-07-03 Thread GitBox


hboutemy commented on code in PR #9:
URL: https://github.com/apache/maven-reporting-impl/pull/9#discussion_r912445797


##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -90,6 +98,27 @@
 @Parameter( property = "outputEncoding", defaultValue = 
"${project.reporting.outputEncoding}", readonly = true )
 private String outputEncoding;
 
+/**
+ * The local repository.
+ */
+@Parameter( defaultValue = "${localRepository}", readonly = true )
+protected ArtifactRepository localRepository;
+
+/**
+ * Remote repositories used for the project.
+ */
+@Parameter( defaultValue = "${project.remoteArtifactRepositories}", 
readonly = true )
+protected List remoteRepositories;
+
+@Parameter
+Skin skin;

Review Comment:
   this parameter requires a little description: "the skin to use when doing 
standalone report, run as direct goal invocation"
   
   and ideally, it would be nice to see in this description the default value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-project-info-reports-plugin] hboutemy commented on pull request #39: Make magic happen

2022-07-03 Thread GitBox


hboutemy commented on PR #39:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/39#issuecomment-1173031972

   description is really cryptic...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-project-info-reports-plugin] hboutemy commented on a diff in pull request #39: Make magic happen

2022-07-03 Thread GitBox


hboutemy commented on code in PR #39:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/39#discussion_r912446436


##
pom.xml:
##
@@ -134,12 +134,12 @@ under the License.
 
   org.apache.maven.reporting
   maven-reporting-api
-  3.1.0
+  4.0.0-M2
 
 
   org.apache.maven.reporting
   maven-reporting-impl
-  3.1.0
+  4.0.0-M2-SNAPSHOT
   

Review Comment:
   do we still need this exclusion?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #39: Make magic happen

2022-07-03 Thread GitBox


michael-o commented on PR #39:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/39#issuecomment-1173032456

   > description is really cryptic...
   
   True, of course. Requires polish. I wanted to have a PoC.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-project-info-reports-plugin] michael-o commented on a diff in pull request #39: Make magic happen

2022-07-03 Thread GitBox


michael-o commented on code in PR #39:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/39#discussion_r912446763


##
pom.xml:
##
@@ -134,12 +134,12 @@ under the License.
 
   org.apache.maven.reporting
   maven-reporting-api
-  3.1.0
+  4.0.0-M2
 
 
   org.apache.maven.reporting
   maven-reporting-impl
-  3.1.0
+  4.0.0-M2-SNAPSHOT
   

Review Comment:
   Need toncheck with @cstamas 



##
pom.xml:
##
@@ -134,12 +134,12 @@ under the License.
 
   org.apache.maven.reporting
   maven-reporting-api
-  3.1.0
+  4.0.0-M2
 
 
   org.apache.maven.reporting
   maven-reporting-impl
-  3.1.0
+  4.0.0-M2-SNAPSHOT
   

Review Comment:
   Need to check with @cstamas 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-reporting-impl] michael-o commented on a diff in pull request #9: Render with Skins

2022-07-03 Thread GitBox


michael-o commented on code in PR #9:
URL: https://github.com/apache/maven-reporting-impl/pull/9#discussion_r912446896


##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -90,6 +98,27 @@
 @Parameter( property = "outputEncoding", defaultValue = 
"${project.reporting.outputEncoding}", readonly = true )
 private String outputEncoding;
 
+/**
+ * The local repository.
+ */
+@Parameter( defaultValue = "${localRepository}", readonly = true )
+protected ArtifactRepository localRepository;
+
+/**
+ * Remote repositories used for the project.
+ */
+@Parameter( defaultValue = "${project.remoteArtifactRepositories}", 
readonly = true )
+protected List remoteRepositories;
+
+@Parameter
+Skin skin;

Review Comment:
   Yes, that I plan to add.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-reporting-impl] michael-o commented on a diff in pull request #9: Render with Skins

2022-07-03 Thread GitBox


michael-o commented on code in PR #9:
URL: https://github.com/apache/maven-reporting-impl/pull/9#discussion_r912446896


##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -90,6 +98,27 @@
 @Parameter( property = "outputEncoding", defaultValue = 
"${project.reporting.outputEncoding}", readonly = true )
 private String outputEncoding;
 
+/**
+ * The local repository.
+ */
+@Parameter( defaultValue = "${localRepository}", readonly = true )
+protected ArtifactRepository localRepository;
+
+/**
+ * Remote repositories used for the project.
+ */
+@Parameter( defaultValue = "${project.remoteArtifactRepositories}", 
readonly = true )
+protected List remoteRepositories;
+
+@Parameter
+Skin skin;

Review Comment:
   Yes, that I plan to add. A default value can only be provided by text/code, 
nit injection. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-assembly-plugin] slawekjaranowski commented on a diff in pull request #81: [MASSEMBLY-964] Fix initFile for FileLocation, UrlLocation

2022-07-03 Thread GitBox


slawekjaranowski commented on code in PR #81:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/81#discussion_r912458512


##
pom.xml:
##
@@ -365,6 +365,7 @@ under the License.
 ${https.protocols}
   
   true
+

Review Comment:
   my local testing ... removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-compiler-plugin] dependabot[bot] opened a new pull request, #138: Bump plexus-utils from 2.0.4 to 3.0.16 in /src/it/MCOMPILER-366

2022-07-03 Thread GitBox


dependabot[bot] opened a new pull request, #138:
URL: https://github.com/apache/maven-compiler-plugin/pull/138

   Bumps [plexus-utils](https://github.com/sonatype/plexus-utils) from 2.0.4 to 
3.0.16.
   
   Commits
   
   https://github.com/sonatype/plexus-utils/commit/cf317f9b4070c3c619e9ee75a3e38bea3ff621c1";>cf317f9
 [maven-release-plugin] prepare release plexus-utils-3.0.16
   https://github.com/sonatype/plexus-utils/commit/26e3ae87b56a7f389f1a1ce1fa563686b924256a";>26e3ae8
 Remove incorrect tag element
   https://github.com/sonatype/plexus-utils/commit/99639d6558620da489b7c6d1b0c88491cde75884";>99639d6
 Little test to mimic ${project.artifactMap(g:a:c)} usage
   https://github.com/sonatype/plexus-utils/commit/5d4697966d4c6161fc4bde1fd3fa27be6440eec0";>5d46979
 Needs to build with 1.7 because of some Java7 utils, but source/target needs 
...
   https://github.com/sonatype/plexus-utils/commit/18bd77d716ff73a707e09af7efc4d5ef5658ac35";>18bd77d
 We can't switch to Java7 yet while Maven still needs to run on Java6
   https://github.com/sonatype/plexus-utils/commit/3cf855c6403061ae216b0f805debbfda09be9245";>3cf855c
 Remove release cruft
   https://github.com/sonatype/plexus-utils/commit/3196d4c3c1fa42d11cfeb4e39c418c2f75c5a138";>3196d4c
 ignore .java-version
   https://github.com/sonatype/plexus-utils/commit/57b636d2c57f3c023a95be3fcb8270fb6ff6780c";>57b636d
 changed XmlUtilTest to create test output directory
   https://github.com/sonatype/plexus-utils/commit/33091f9b1e5a9abc0927bc51a1670d9d5ba85a1c";>33091f9
 Use the same method for finding the basedir as our other code.
   https://github.com/sonatype/plexus-utils/commit/a153249c24c32d3ab81850aaf7a263a78ca23f99";>a153249
 MNG-5553 reworked dotted expressions interpreter
   Additional commits viewable in https://github.com/sonatype/plexus-utils/compare/plexus-utils-2.0.4...plexus-utils-3.0.16";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-utils&package-manager=maven&previous-version=2.0.4&new-version=3.0.16)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/maven-compiler-plugin/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-dependency-tree] slawekjaranowski commented on pull request #10: Drop maven 3.0 compatibility

2022-07-03 Thread GitBox


slawekjaranowski commented on PR #10:
URL: 
https://github.com/apache/maven-dependency-tree/pull/10#issuecomment-1173117650

   I think that it is still valuable, @gnodet  could you rebase and resolve 
conflicts ... if you don't have time I can take care about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-dependency-tree] slawekjaranowski commented on pull request #9: MSHARED-1016 - exclude transitive provided scope dependencies

2022-07-03 Thread GitBox


slawekjaranowski commented on PR #9:
URL: 
https://github.com/apache/maven-dependency-tree/pull/9#issuecomment-1173123178

   Should be the same as in Maven Core ... 
https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80
   
   So i think it is correct change.
   
   @cstamas what do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-assembly-plugin] slawekjaranowski merged pull request #81: [MASSEMBLY-964] Fix initFile for FileLocation, UrlLocation

2022-07-03 Thread GitBox


slawekjaranowski merged PR #81:
URL: https://github.com/apache/maven-assembly-plugin/pull/81


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (MSHARED-1016) Transitive provided dependencies are not removed from collected dependency graph

2022-07-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MSHARED-1016:


Assignee: Slawomir Jaranowski

> Transitive provided dependencies are not removed from collected dependency 
> graph
> 
>
> Key: MSHARED-1016
> URL: https://issues.apache.org/jira/browse/MSHARED-1016
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-tree
>Affects Versions: maven-dependency-tree-3.1.0
>Reporter: Daniel Norberg
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> DependencyCollectorBuilder#collectDependencyGraph returns a dependency graph 
> containing transitive provided scope dependencies. This is inconsistent with 
> Maven behavior, which removes transitive provided scope dependencies from the 
> dependency graph:
> [https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80|https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80.]
> This might be the root cause of 
> https://issues.apache.org/jira/browse/MENFORCER-402 and 
> https://issues.apache.org/jira/browse/MENFORCER-394
> Note that transitive test scope dependencies are correctly filtered out using 
> a dependency selector.
> It seems to me that we can add another dependency selector to also filter out 
> transitive provided scope dependencies:
> [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108|https://github.com/apache/maven-dependency-tree/blob/master/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108]
> [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven3DependencyCollectorBuilder.java#L108]
> I have submitted a PR to do this: 
> [https://github.com/apache/maven-dependency-tree/pull/9]
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MASSEMBLY-964) Error build with shared assemblies

2022-07-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MASSEMBLY-964.
-
Fix Version/s: 3.4.1
   Resolution: Fixed

> Error build with shared assemblies 
> ---
>
> Key: MASSEMBLY-964
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-964
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.4.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 3.4.1
>
>
> To reproduce please checkout: https://github.com/apache/maven-apache-parent 
> commit 6c63a05 - latest master.
> Excuting:
> {code}
> mvn clean  package -P apache-release -e
> {code}
> I have:
> {code}
> $ mvn package -P apache-release -e
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/Cellar/maven/3.8.6/libexec
> Java version: 1.8.0_322, vendor: Homebrew, runtime: 
> /usr/local/Cellar/openjdk@8/1.8.0+322/libexec/openjdk.jdk/Contents/Home/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "12.3.1", arch: "x86_64", family: "mac"
> ...
> [INFO] --- maven-assembly-plugin:3.4.0:single (source-release-assembly) @ 
> apache ---
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  1.384 s
> [INFO] Finished at: 2022-07-02T14:26:37+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-assembly-plugin:3.4.0:single 
> (source-release-assembly) on project apache: Error reading assemblies: Error 
> reading component descriptor: assemblies/source-shared.xml (resolved to: 
> assemblies/source-shared.xml): assemblies/source-shared.xml (No such file or 
> directory) -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-assembly-plugin:3.4.0:single 
> (source-release-assembly) on project apache: Error reading assemblies: Error 
> reading component descriptor: assemblies/source-shared.xml (resolved to: 
> assemblies/source-shared.xml)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
> (MojoExecutor.java:375)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:351)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:171)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:163)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error reading 
> assemblies: Error reading component descriptor: assemblies/source-shared.xml 
> (resolved to: assemblies/source-shared.xml)
> at org.apache.maven.plugins.assembly.mojos.AbstractAssemblyMojo.execute 
> (AbstractAssemblyMojo.java:488)
> at org.apache.maven.plugins.assembly.mojos.SingleAssemblyMojo.execute 
> (SingleAssemblyMojo.java:60)
> at org.apache.maven.plugin.DefaultBuildPluginManager.ex

[GitHub] [maven-assembly-plugin] slawekjaranowski commented on pull request #77: Bump maven-archiver from 3.5.2 to 3.6.0

2022-07-03 Thread GitBox


slawekjaranowski commented on PR #77:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/77#issuecomment-1173126552

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-assembly-plugin] dependabot[bot] commented on pull request #77: Bump maven-archiver from 3.5.2 to 3.6.0

2022-07-03 Thread GitBox


dependabot[bot] commented on PR #77:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/77#issuecomment-1173126644

   Looks like org.apache.maven:maven-archiver is up-to-date now, so this is no 
longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-assembly-plugin] dependabot[bot] closed pull request #77: Bump maven-archiver from 3.5.2 to 3.6.0

2022-07-03 Thread GitBox


dependabot[bot] closed pull request #77: Bump maven-archiver from 3.5.2 to 3.6.0
URL: https://github.com/apache/maven-assembly-plugin/pull/77


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-dependency-tree] slawekjaranowski merged pull request #9: [MSHARED-1016] - exclude transitive provided scope dependencies

2022-07-03 Thread GitBox


slawekjaranowski merged PR #9:
URL: https://github.com/apache/maven-dependency-tree/pull/9


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-dependency-tree] slawekjaranowski commented on pull request #9: [MSHARED-1016] - exclude transitive provided scope dependencies

2022-07-03 Thread GitBox


slawekjaranowski commented on PR #9:
URL: 
https://github.com/apache/maven-dependency-tree/pull/9#issuecomment-1173127684

   @danielnorberg thanks, I have changed commit message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MSHARED-1016) Transitive provided dependencies are not removed from collected dependency graph

2022-07-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1016.

Fix Version/s: maven-dependency-tree-next-release
   Resolution: Fixed

> Transitive provided dependencies are not removed from collected dependency 
> graph
> 
>
> Key: MSHARED-1016
> URL: https://issues.apache.org/jira/browse/MSHARED-1016
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-tree
>Affects Versions: maven-dependency-tree-3.1.0
>Reporter: Daniel Norberg
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-tree-next-release
>
>
> DependencyCollectorBuilder#collectDependencyGraph returns a dependency graph 
> containing transitive provided scope dependencies. This is inconsistent with 
> Maven behavior, which removes transitive provided scope dependencies from the 
> dependency graph:
> [https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80|https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80.]
> This might be the root cause of 
> https://issues.apache.org/jira/browse/MENFORCER-402 and 
> https://issues.apache.org/jira/browse/MENFORCER-394
> Note that transitive test scope dependencies are correctly filtered out using 
> a dependency selector.
> It seems to me that we can add another dependency selector to also filter out 
> transitive provided scope dependencies:
> [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108|https://github.com/apache/maven-dependency-tree/blob/master/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108]
> [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven3DependencyCollectorBuilder.java#L108]
> I have submitted a PR to do this: 
> [https://github.com/apache/maven-dependency-tree/pull/9]
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1016) Transitive provided dependencies are not removed from collected dependency graph

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561900#comment-17561900
 ] 

Hudson commented on MSHARED-1016:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency-tree » master 
#16

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dependency-tree/job/master/16/

> Transitive provided dependencies are not removed from collected dependency 
> graph
> 
>
> Key: MSHARED-1016
> URL: https://issues.apache.org/jira/browse/MSHARED-1016
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-tree
>Affects Versions: maven-dependency-tree-3.1.0
>Reporter: Daniel Norberg
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-tree-next-release
>
>
> DependencyCollectorBuilder#collectDependencyGraph returns a dependency graph 
> containing transitive provided scope dependencies. This is inconsistent with 
> Maven behavior, which removes transitive provided scope dependencies from the 
> dependency graph:
> [https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80|https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80.]
> This might be the root cause of 
> https://issues.apache.org/jira/browse/MENFORCER-402 and 
> https://issues.apache.org/jira/browse/MENFORCER-394
> Note that transitive test scope dependencies are correctly filtered out using 
> a dependency selector.
> It seems to me that we can add another dependency selector to also filter out 
> transitive provided scope dependencies:
> [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108|https://github.com/apache/maven-dependency-tree/blob/master/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108]
> [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven3DependencyCollectorBuilder.java#L108]
> I have submitted a PR to do this: 
> [https://github.com/apache/maven-dependency-tree/pull/9]
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MASSEMBLY-964) Error build with shared assemblies

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MASSEMBLY-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561901#comment-17561901
 ] 

Hudson commented on MASSEMBLY-964:
--

Build succeeded in Jenkins: Maven » Maven TLP » maven-assembly-plugin » master 
#20

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-assembly-plugin/job/master/20/

> Error build with shared assemblies 
> ---
>
> Key: MASSEMBLY-964
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-964
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.4.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 3.4.1
>
>
> To reproduce please checkout: https://github.com/apache/maven-apache-parent 
> commit 6c63a05 - latest master.
> Excuting:
> {code}
> mvn clean  package -P apache-release -e
> {code}
> I have:
> {code}
> $ mvn package -P apache-release -e
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/Cellar/maven/3.8.6/libexec
> Java version: 1.8.0_322, vendor: Homebrew, runtime: 
> /usr/local/Cellar/openjdk@8/1.8.0+322/libexec/openjdk.jdk/Contents/Home/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "12.3.1", arch: "x86_64", family: "mac"
> ...
> [INFO] --- maven-assembly-plugin:3.4.0:single (source-release-assembly) @ 
> apache ---
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  1.384 s
> [INFO] Finished at: 2022-07-02T14:26:37+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-assembly-plugin:3.4.0:single 
> (source-release-assembly) on project apache: Error reading assemblies: Error 
> reading component descriptor: assemblies/source-shared.xml (resolved to: 
> assemblies/source-shared.xml): assemblies/source-shared.xml (No such file or 
> directory) -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-assembly-plugin:3.4.0:single 
> (source-release-assembly) on project apache: Error reading assemblies: Error 
> reading component descriptor: assemblies/source-shared.xml (resolved to: 
> assemblies/source-shared.xml)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
> (MojoExecutor.java:375)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:351)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:171)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:163)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error reading 
> assemblies: Error reading component descriptor: assemblies/source-shared.xml 
> (resolved to: assemblies/source-shared.xml)
> at org.apache.maven.plugins.assembly.mojos.AbstractAssemblyMojo.execute 
> (AbstractAssemblyMojo.java:488)
> 

[GitHub] [maven] hboutemy commented on pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-03 Thread GitBox


hboutemy commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1173131229

   IT added, that checks every CLI goal invocation format (with or without 
executionId)
   please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561902#comment-17561902
 ] 

ASF GitHub Bot commented on MNG-7353:
-

hboutemy commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1173131229

   IT added, that checks every CLI goal invocation format (with or without 
executionId)
   please review




> add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-6965) Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their classpath

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561904#comment-17561904
 ] 

Hudson commented on MNG-6965:
-

Build failed in Jenkins: Maven » Maven TLP » maven » PR-757 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-757/2/

> Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their 
> classpath
> 
>
> Key: MNG-6965
> URL: https://issues.apache.org/jira/browse/MNG-6965
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.0, 3.6.3
> Environment: Win7, Win10, at least one variant of Linux (not sure 
> which)
>Reporter: Mark Nolan
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: archetype
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
> Attachments: pom.xml
>
>
> A simple minimal archetype pom following the manual pages downloads 
> plexus-utils 1.1, even though it is not (apparently) declared anywhere. This 
> version is banned at my organization (edited to add: due to vulnerabilities), 
> meaning such a pom always fails.
>  
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
>   http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> 0.0.1-SNAPSHOT
> maven-archetype
> test
> 
>    
> 
>   org.apache.maven.archetype
>   archetype-packaging
>   3.1.2
> 
>   
>   
> 
>   
> org.apache.maven.plugins
> maven-archetype-plugin
> 3.1.2
>   
> 
>   
> 
> 
> {code}
> Running any goal, such as mvn -X clean, produces the following before the 
> goal is executed:
> {code}
> [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=952800, 
> ConflictMarker.markTime=586900, ConflictMarker.nodeCount=1, 
> ConflictIdSorter.graphTime=549200, ConflictIdSorter.topsortTime=586700, 
> ConflictIdSorter.conflictIdCount=1, ConflictIdSorter.conflictIdCycleCount=0, 
> ConflictResolver.totalTime=3313100, ConflictResolver.conflictItemCount=1, 
> DefaultDependencyCollector.collectTime=66890900, 
> DefaultDependencyCollector.transformTime=8523500}
> [DEBUG] org.apache.maven.archetype:archetype-packaging:jar:3.1.2:
> [DEBUG]org.codehaus.plexus:plexus-utils:jar:1.1:runtime
> {code}
>  
> As far as I can see, there is no declared dependency on plexus-utils:1.1.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7501) display relative path to pom.xml

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561905#comment-17561905
 ] 

Hudson commented on MNG-7501:
-

Build failed in Jenkins: Maven » Maven TLP » maven » PR-757 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-757/2/

> display relative path to pom.xml
> 
>
> Key: MNG-7501
> URL: https://issues.apache.org/jira/browse/MNG-7501
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.8.6
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> when building large multi-module project, when a failure happens in the 
> middle of the build, it's not easy to even identify where the module is 
> located in the source tree: Maven displays the module name, but not the path 
> to pom.xml. Then often we have to read output log of goals that have run 
> hoping to find a hint
> it would be nice to have by default the path to the pom.xml displayed during 
> Maven run.
> I see 2 options:
> 1. either in the module build header:
> {noformat}
> [INFO] --< org.apache.maven.its.plugins:maven-it-plugin-dependency-resolution 
> >--
> [INFO] Building Maven IT Plugin :: Dependency Resolution 2.1-SNAPSHOT   
> [31/78]
> [INFO] 
> core-it-support/core-it-plugins/maven-it-plugin-dependency-resolution/pom.xml
> [INFO] [ maven-plugin 
> ]
> {noformat}
> 2. or in each goal execution line during the module build:
> {noformat}
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
> maven-it-plugin-dependency-resolution 
> core-it-support/core-it-plugins/maven-it-plugin-dependency-resolution/pom.xml 
> ---
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561907#comment-17561907
 ] 

Hudson commented on MNG-7353:
-

Build failed in Jenkins: Maven » Maven TLP » maven » PR-757 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-757/2/

> add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561903#comment-17561903
 ] 

Hudson commented on MNG-7504:
-

Build failed in Jenkins: Maven » Maven TLP » maven » PR-757 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-757/2/

> Warning about unknown reportPlugins parameters for m-site-p are always 
> generated
> 
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0
>
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed 
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}} 
> which always add configuration for m-site-p with unsupported parameter 
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution 
> - drop service  - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but 
> workaround



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7506) Upgrade Maven Wagon to 3.5.2

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561906#comment-17561906
 ] 

Hudson commented on MNG-7506:
-

Build failed in Jenkins: Maven » Maven TLP » maven » PR-757 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-757/2/

> Upgrade Maven Wagon to 3.5.2
> 
>
> Key: MNG-7506
> URL: https://issues.apache.org/jira/browse/MNG-7506
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7360) Can't parse project that has tag in plugin configuration

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561908#comment-17561908
 ] 

Hudson commented on MNG-7360:
-

Build failed in Jenkins: Maven » Maven TLP » maven » PR-757 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-757/2/

> Can't parse project that has  tag in plugin configuration
> -
>
> Key: MNG-7360
> URL: https://issues.apache.org/jira/browse/MNG-7360
> Project: Maven
>  Issue Type: Bug
>  Components: build/consumer
>Affects Versions: 4.0.x-candidate
> Environment: Apache Maven 4.0.0-alpha-1-SNAPSHOT 
> (3a06530dbce82e2054afa3cc4c81631910474bd0)
> Maven home: 
> /usr/local/Cellar/maven-snapshot/4.0.0-alpha-1-SNAPSHOT_290/libexec
> Java version: 17.0.1, vendor: Eclipse Adoptium, runtime: 
> /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac"
>Reporter: Maarten Mulders
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-1, 4.0.0
>
> Attachments: Screenshot 2021-12-13 at 13.45.01.png
>
>
> The Apache Camel project has the following snippet in their root POM:
> {code:xml}
> 
> org.codehaus.mojo
> flatten-maven-plugin
> 1.2.5
> 
> 
> default-cli
> process-resources
> 
> flatten
> 
> 
> 
> 
> 
> expand
> 
> 
> 
> 
> 
> 
> {code}
> With Maven 4's "Build Consumer" feature enabled, parsing this plugin 
> definition breaks with
> {code:none}
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Unable to transform pom
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]   
> [ERROR]   The project (/Users/maarten/Code/open-source/camel/pom.xml) has 1 
> error
> [ERROR] Unable to transform pom: Not a regular file: 
> /Users/maarten/Code/open-source/pom.xml
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the '-e' 
> switch
> [ERROR] Re-run Maven using the '-X' switch to enable verbose output
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> {code}
> I suspect that the {{}} tag is the culprit. It seems to me that it 
> causes the {{ParentXMLFilter}} to think it needs to do its work. The attached 
> screenshot shows the stacktrace that brought me to this idea. As the 
> {{BufferingParser}} class processes its buffer of events, it encounters a 
> situation of an "end {{parent}} tag". But that {{parent}} tag did not have 
> child elements {{version}} and {{relativePath}} and so, it decides it needs 
> to resolve the parent as {{../pom.xml}} against the project path 
> ({{/Users/maarten/Code/open-source/camel/}} in my case), leading to the 
> non-existing path of {{/Users/maarten/Code/open-source/pom.xml}}.
> I think the bug here is not that it resolves to a non-existing path (it's 
> good to check that before actually reading the file). I think the bug is that 
> the {{ParentXMLFilter}} is acting on the {{parent}} tag inside the plugin 
> configuration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-install-plugin] cstamas merged pull request #15: [MINSTALL-115] Install At End feature (no extension)

2022-07-03 Thread GitBox


cstamas merged PR #15:
URL: https://github.com/apache/maven-install-plugin/pull/15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-deploy-plugin] cstamas merged pull request #20: [MDEPLOY-193] Deploy At End feature (no extension)

2022-07-03 Thread GitBox


cstamas merged PR #20:
URL: https://github.com/apache/maven-deploy-plugin/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MINSTALL-115) Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MINSTALL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561918#comment-17561918
 ] 

Hudson commented on MINSTALL-115:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-install-plugin » master 
#11

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-install-plugin/job/master/11/

> Setting installAtEnd causes no installs to occur when a multimodule project 
> has multiple class realms
> -
>
> Key: MINSTALL-115
> URL: https://issues.apache.org/jira/browse/MINSTALL-115
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 2.5.2
>Reporter: Philip Pearson
>Priority: Major
> Attachments: InstallConfiguration.java, mojo.patch, 
> oginsta-10-14-0.apk
>
>
> When the {{installAtEnd}} configuration parameter is set to {{true}} on a 
> multimodule project with multiple class realms then because a different class 
> loaders creates instances of the {{InstallMojo}} class there will be muliple 
> instances of {{readyProjectsCounter}} and {{installRequests}}.
> However, because the end is determined by {{projectsReady = 
> readyProjectsCounter.incrementAndGet() == reactorProjects.size()}} it will 
> never complete as {{readyProjectsCounter}} will never equal the size 
> {{reactorProjects}} if even one project is executed in another class realm.
> {{maven-deploy-plugin}} partially solved this in MDEPLOY-193 by using 
> {{project.equals(reactorProjects.get(reactorProjects.size() - 1))}} instead.  
> However, the installation is a little more complex than the deploy as we need 
> to read the used the {{createChecksum}} and {{updateReleaseInfo}} 
> configuration parameters from each installed project - we can't store them 
> ahead of time because of the issue with the class realms, so we need to read 
> the plugin configurations before we can call 
> {{installProject(instalRequest)}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEPLOY-193) deployAtEnd does not deploy artifacts for multi-module project with build extensions

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MDEPLOY-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561920#comment-17561920
 ] 

Hudson commented on MDEPLOY-193:


Build succeeded in Jenkins: Maven » Maven TLP » maven-deploy-plugin » master #9

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-deploy-plugin/job/master/9/

> deployAtEnd does not deploy artifacts for multi-module project with build 
> extensions
> 
>
> Key: MDEPLOY-193
> URL: https://issues.apache.org/jira/browse/MDEPLOY-193
> Project: Maven Deploy Plugin
>  Issue Type: Bug
>  Components: deploy:deploy
>Affects Versions: 2.8.2
> Environment: windows 7 / sles 11
> maven 3.0.5
> java 7u45
>Reporter: Jörg Sesterhenn
>Priority: Major
> Attachments: deployAtEndFailure.zip
>
>
> The deploy plugin shows the same behaviour as described in MINSTALL-102. 
> We noticed that multimodule projects do not deploy any artifacts if there are 
> modules with packagings that add build extensions (e.g. atlassian-plugin, aar 
> = axis archives).
> This issue is here for better visibility as discussed in MINSTALL-102. 
> Please find attached testcase there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1098) Drop legacy, update module

2022-07-03 Thread Jira
Tamás Cservenák created MSHARED-1098:


 Summary: Drop legacy, update module
 Key: MSHARED-1098
 URL: https://issues.apache.org/jira/browse/MSHARED-1098
 Project: Maven Shared Components
  Issue Type: Task
  Components: maven-shared-jar
Reporter: Tamás Cservenák
Assignee: Tamás Cservenák
 Fix For: maven-shared-jar-3.0.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1098) Drop legacy, update module

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MSHARED-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MSHARED-1098:
-
Description: 
Changes:
* update to parent POM 36
* drop Plexus and Plexus APIs, convert to JSR330
* Update to Java8
* Update dependencies blocked by Java8 (bcel, commons-collections)

> Drop legacy, update module
> --
>
> Key: MSHARED-1098
> URL: https://issues.apache.org/jira/browse/MSHARED-1098
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-shared-jar
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: maven-shared-jar-3.0.0
>
>
> Changes:
> * update to parent POM 36
> * drop Plexus and Plexus APIs, convert to JSR330
> * Update to Java8
> * Update dependencies blocked by Java8 (bcel, commons-collections)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1098) Drop legacy, update module

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MSHARED-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MSHARED-1098:
-
Description: 
Changes:
* update to parent POM 36
* update to Maven 3.2.5
* drop Plexus and Plexus APIs, convert to JSR330
* Update to Java8
* Update dependencies blocked by Java8 (bcel, commons-collections)

  was:
Changes:
* update to parent POM 36
* drop Plexus and Plexus APIs, convert to JSR330
* Update to Java8
* Update dependencies blocked by Java8 (bcel, commons-collections)


> Drop legacy, update module
> --
>
> Key: MSHARED-1098
> URL: https://issues.apache.org/jira/browse/MSHARED-1098
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-shared-jar
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: maven-shared-jar-3.0.0
>
>
> Changes:
> * update to parent POM 36
> * update to Maven 3.2.5
> * drop Plexus and Plexus APIs, convert to JSR330
> * Update to Java8
> * Update dependencies blocked by Java8 (bcel, commons-collections)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1098) Drop legacy, update module

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MSHARED-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák closed MSHARED-1098.


> Drop legacy, update module
> --
>
> Key: MSHARED-1098
> URL: https://issues.apache.org/jira/browse/MSHARED-1098
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-shared-jar
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: maven-shared-jar-3.0.0
>
>
> Changes:
> * update to parent POM 36
> * update to Maven 3.2.5
> * drop Plexus and Plexus APIs, convert to JSR330
> * Update to Java8
> * Update dependencies blocked by Java8 (bcel, commons-collections)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MSHARED-1098) Drop legacy, update module

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MSHARED-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák resolved MSHARED-1098.
--
Resolution: Fixed

> Drop legacy, update module
> --
>
> Key: MSHARED-1098
> URL: https://issues.apache.org/jira/browse/MSHARED-1098
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-shared-jar
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: maven-shared-jar-3.0.0
>
>
> Changes:
> * update to parent POM 36
> * update to Maven 3.2.5
> * drop Plexus and Plexus APIs, convert to JSR330
> * Update to Java8
> * Update dependencies blocked by Java8 (bcel, commons-collections)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1098) Drop legacy, update module

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561922#comment-17561922
 ] 

Hudson commented on MSHARED-1098:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-shared-jar » master #9

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-shared-jar/job/master/9/

> Drop legacy, update module
> --
>
> Key: MSHARED-1098
> URL: https://issues.apache.org/jira/browse/MSHARED-1098
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-shared-jar
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: maven-shared-jar-3.0.0
>
>
> Changes:
> * update to parent POM 36
> * update to Maven 3.2.5
> * drop Plexus and Plexus APIs, convert to JSR330
> * Update to Java8
> * Update dependencies blocked by Java8 (bcel, commons-collections)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MINSTALL-115) Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MINSTALL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MINSTALL-115:
-
Fix Version/s: 3.0.0

> Setting installAtEnd causes no installs to occur when a multimodule project 
> has multiple class realms
> -
>
> Key: MINSTALL-115
> URL: https://issues.apache.org/jira/browse/MINSTALL-115
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 2.5.2
>Reporter: Philip Pearson
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: InstallConfiguration.java, mojo.patch, 
> oginsta-10-14-0.apk
>
>
> When the {{installAtEnd}} configuration parameter is set to {{true}} on a 
> multimodule project with multiple class realms then because a different class 
> loaders creates instances of the {{InstallMojo}} class there will be muliple 
> instances of {{readyProjectsCounter}} and {{installRequests}}.
> However, because the end is determined by {{projectsReady = 
> readyProjectsCounter.incrementAndGet() == reactorProjects.size()}} it will 
> never complete as {{readyProjectsCounter}} will never equal the size 
> {{reactorProjects}} if even one project is executed in another class realm.
> {{maven-deploy-plugin}} partially solved this in MDEPLOY-193 by using 
> {{project.equals(reactorProjects.get(reactorProjects.size() - 1))}} instead.  
> However, the installation is a little more complex than the deploy as we need 
> to read the used the {{createChecksum}} and {{updateReleaseInfo}} 
> configuration parameters from each installed project - we can't store them 
> ahead of time because of the issue with the class realms, so we need to read 
> the plugin configurations before we can call 
> {{installProject(instalRequest)}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MINSTALL-115) Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MINSTALL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák resolved MINSTALL-115.
--
Resolution: Fixed

> Setting installAtEnd causes no installs to occur when a multimodule project 
> has multiple class realms
> -
>
> Key: MINSTALL-115
> URL: https://issues.apache.org/jira/browse/MINSTALL-115
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 2.5.2
>Reporter: Philip Pearson
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: InstallConfiguration.java, mojo.patch, 
> oginsta-10-14-0.apk
>
>
> When the {{installAtEnd}} configuration parameter is set to {{true}} on a 
> multimodule project with multiple class realms then because a different class 
> loaders creates instances of the {{InstallMojo}} class there will be muliple 
> instances of {{readyProjectsCounter}} and {{installRequests}}.
> However, because the end is determined by {{projectsReady = 
> readyProjectsCounter.incrementAndGet() == reactorProjects.size()}} it will 
> never complete as {{readyProjectsCounter}} will never equal the size 
> {{reactorProjects}} if even one project is executed in another class realm.
> {{maven-deploy-plugin}} partially solved this in MDEPLOY-193 by using 
> {{project.equals(reactorProjects.get(reactorProjects.size() - 1))}} instead.  
> However, the installation is a little more complex than the deploy as we need 
> to read the used the {{createChecksum}} and {{updateReleaseInfo}} 
> configuration parameters from each installed project - we can't store them 
> ahead of time because of the issue with the class realms, so we need to read 
> the plugin configurations before we can call 
> {{installProject(instalRequest)}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MINSTALL-115) Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MINSTALL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák reassigned MINSTALL-115:


Assignee: Tamás Cservenák

> Setting installAtEnd causes no installs to occur when a multimodule project 
> has multiple class realms
> -
>
> Key: MINSTALL-115
> URL: https://issues.apache.org/jira/browse/MINSTALL-115
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 2.5.2
>Reporter: Philip Pearson
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: InstallConfiguration.java, mojo.patch, 
> oginsta-10-14-0.apk
>
>
> When the {{installAtEnd}} configuration parameter is set to {{true}} on a 
> multimodule project with multiple class realms then because a different class 
> loaders creates instances of the {{InstallMojo}} class there will be muliple 
> instances of {{readyProjectsCounter}} and {{installRequests}}.
> However, because the end is determined by {{projectsReady = 
> readyProjectsCounter.incrementAndGet() == reactorProjects.size()}} it will 
> never complete as {{readyProjectsCounter}} will never equal the size 
> {{reactorProjects}} if even one project is executed in another class realm.
> {{maven-deploy-plugin}} partially solved this in MDEPLOY-193 by using 
> {{project.equals(reactorProjects.get(reactorProjects.size() - 1))}} instead.  
> However, the installation is a little more complex than the deploy as we need 
> to read the used the {{createChecksum}} and {{updateReleaseInfo}} 
> configuration parameters from each installed project - we can't store them 
> ahead of time because of the issue with the class realms, so we need to read 
> the plugin configurations before we can call 
> {{installProject(instalRequest)}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINSTALL-115) Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MINSTALL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák closed MINSTALL-115.


> Setting installAtEnd causes no installs to occur when a multimodule project 
> has multiple class realms
> -
>
> Key: MINSTALL-115
> URL: https://issues.apache.org/jira/browse/MINSTALL-115
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 2.5.2
>Reporter: Philip Pearson
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: InstallConfiguration.java, mojo.patch, 
> oginsta-10-14-0.apk
>
>
> When the {{installAtEnd}} configuration parameter is set to {{true}} on a 
> multimodule project with multiple class realms then because a different class 
> loaders creates instances of the {{InstallMojo}} class there will be muliple 
> instances of {{readyProjectsCounter}} and {{installRequests}}.
> However, because the end is determined by {{projectsReady = 
> readyProjectsCounter.incrementAndGet() == reactorProjects.size()}} it will 
> never complete as {{readyProjectsCounter}} will never equal the size 
> {{reactorProjects}} if even one project is executed in another class realm.
> {{maven-deploy-plugin}} partially solved this in MDEPLOY-193 by using 
> {{project.equals(reactorProjects.get(reactorProjects.size() - 1))}} instead.  
> However, the installation is a little more complex than the deploy as we need 
> to read the used the {{createChecksum}} and {{updateReleaseInfo}} 
> configuration parameters from each installed project - we can't store them 
> ahead of time because of the issue with the class realms, so we need to read 
> the plugin configurations before we can call 
> {{installProject(instalRequest)}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MDEPLOY-193) deployAtEnd does not deploy artifacts for multi-module project with build extensions

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák reassigned MDEPLOY-193:
---

Assignee: Tamás Cservenák

> deployAtEnd does not deploy artifacts for multi-module project with build 
> extensions
> 
>
> Key: MDEPLOY-193
> URL: https://issues.apache.org/jira/browse/MDEPLOY-193
> Project: Maven Deploy Plugin
>  Issue Type: Bug
>  Components: deploy:deploy
>Affects Versions: 2.8.2
> Environment: windows 7 / sles 11
> maven 3.0.5
> java 7u45
>Reporter: Jörg Sesterhenn
>Assignee: Tamás Cservenák
>Priority: Major
> Attachments: deployAtEndFailure.zip
>
>
> The deploy plugin shows the same behaviour as described in MINSTALL-102. 
> We noticed that multimodule projects do not deploy any artifacts if there are 
> modules with packagings that add build extensions (e.g. atlassian-plugin, aar 
> = axis archives).
> This issue is here for better visibility as discussed in MINSTALL-102. 
> Please find attached testcase there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MDEPLOY-193) deployAtEnd does not deploy artifacts for multi-module project with build extensions

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák closed MDEPLOY-193.
---

> deployAtEnd does not deploy artifacts for multi-module project with build 
> extensions
> 
>
> Key: MDEPLOY-193
> URL: https://issues.apache.org/jira/browse/MDEPLOY-193
> Project: Maven Deploy Plugin
>  Issue Type: Bug
>  Components: deploy:deploy
>Affects Versions: 2.8.2
> Environment: windows 7 / sles 11
> maven 3.0.5
> java 7u45
>Reporter: Jörg Sesterhenn
>Assignee: Tamás Cservenák
>Priority: Major
> Attachments: deployAtEndFailure.zip
>
>
> The deploy plugin shows the same behaviour as described in MINSTALL-102. 
> We noticed that multimodule projects do not deploy any artifacts if there are 
> modules with packagings that add build extensions (e.g. atlassian-plugin, aar 
> = axis archives).
> This issue is here for better visibility as discussed in MINSTALL-102. 
> Please find attached testcase there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-193) deployAtEnd does not deploy artifacts for multi-module project with build extensions

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MDEPLOY-193:

Fix Version/s: 3.0.0

> deployAtEnd does not deploy artifacts for multi-module project with build 
> extensions
> 
>
> Key: MDEPLOY-193
> URL: https://issues.apache.org/jira/browse/MDEPLOY-193
> Project: Maven Deploy Plugin
>  Issue Type: Bug
>  Components: deploy:deploy
>Affects Versions: 2.8.2
> Environment: windows 7 / sles 11
> maven 3.0.5
> java 7u45
>Reporter: Jörg Sesterhenn
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: deployAtEndFailure.zip
>
>
> The deploy plugin shows the same behaviour as described in MINSTALL-102. 
> We noticed that multimodule projects do not deploy any artifacts if there are 
> modules with packagings that add build extensions (e.g. atlassian-plugin, aar 
> = axis archives).
> This issue is here for better visibility as discussed in MINSTALL-102. 
> Please find attached testcase there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MDEPLOY-193) deployAtEnd does not deploy artifacts for multi-module project with build extensions

2022-07-03 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák resolved MDEPLOY-193.
-
Resolution: Fixed

> deployAtEnd does not deploy artifacts for multi-module project with build 
> extensions
> 
>
> Key: MDEPLOY-193
> URL: https://issues.apache.org/jira/browse/MDEPLOY-193
> Project: Maven Deploy Plugin
>  Issue Type: Bug
>  Components: deploy:deploy
>Affects Versions: 2.8.2
> Environment: windows 7 / sles 11
> maven 3.0.5
> java 7u45
>Reporter: Jörg Sesterhenn
>Assignee: Tamás Cservenák
>Priority: Major
> Attachments: deployAtEndFailure.zip
>
>
> The deploy plugin shows the same behaviour as described in MINSTALL-102. 
> We noticed that multimodule projects do not deploy any artifacts if there are 
> modules with packagings that add build extensions (e.g. atlassian-plugin, aar 
> = axis archives).
> This issue is here for better visibility as discussed in MINSTALL-102. 
> Please find attached testcase there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-indexer] StefSC opened a new pull request, #227: [MINDEXER-155] Add Maven site descriptor for all modules

2022-07-03 Thread GitBox


StefSC opened a new pull request, #227:
URL: https://github.com/apache/maven-indexer/pull/227

   JIRA: https://issues.apache.org/jira/browse/MINDEXER-155
   
   @slawekjaranowski 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MINDEXER-155) Add Maven site descriptor for all modules

2022-07-03 Thread Serban-Cristian Stef (Jira)


[ 
https://issues.apache.org/jira/browse/MINDEXER-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561924#comment-17561924
 ] 

Serban-Cristian Stef commented on MINDEXER-155:
---

[~sjaranowski] please find the link to the PR: 
[https://github.com/apache/maven-indexer/pull/227]

 

Let me know if there are any issues!

 

Regards,

Stef Serban

> Add Maven site descriptor for all modules
> -
>
> Key: MINDEXER-155
> URL: https://issues.apache.org/jira/browse/MINDEXER-155
> Project: Maven Indexer
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Priority: Major
>  Labels: up-for-grabs
> Attachments: image-2022-07-02-13-57-07-719.png, 
> image-2022-07-02-13-57-46-834.png
>
>
> Each module should contains own site.xml descriptor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-site] ravn opened a new pull request, #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-03 Thread GitBox


ravn opened a new pull request, #308:
URL: https://github.com/apache/maven-site/pull/308

   I have had a look at the current launcher scripts (mvn/mvnDebug) and updated 
configure.md accordingly.
   
   Notably, Maven 4 information has been commented out for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] michael-o commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-03 Thread GitBox


michael-o commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r912527357


##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,
+which - based on several environment variables, project files and system files 
as described below
+- constructs and runs the appropriate `java ...` command line which then 
invokes the Java Virtual Machine (JVM) 
+that actually runs Maven.
 
-This variable contains parameters used to start up the JVM running Maven and
-can be used to supply additional options to it. E.g. JVM memory
-settings could be defined with the value `-Xms256m -Xmx512m`.
+* `mvn` - normal way to run from the command line.
+* `mvnDebug` - launches `mvn` in debug mode, waiting for a Java debugger to 
attach to port `$MAVEN_DEBUG_ADDRESS` (default 8000).

Review Comment:
   not port, address!



##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,
+which - based on several environment variables, project files and system files 
as described below

Review Comment:
   en dash, not hyphen



##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,
+which - based on several environment variables, project files and system files 
as described below
+- constructs and runs the appropriate `java ...` command line which then 
invokes the Java Virtual Machine (JVM) 
+that actually runs Maven.
 
-This variable contains parameters used to start up the JVM running Maven and
-can be used to supply additional options to it. E.g. JVM memory
-settings could be defined with the value `-Xms256m -Xmx512m`.
+* `mvn` - normal way to run from the command line.
+* `mvnDebug` - launches `mvn` in debug mode, waiting for a Java debugger to 
attach to port `$MAVEN_DEBUG_ADDRESS` (default 8000).
 
-## `MAVEN_ARGS` environment variable:
+
+## Environment variables
+
+In the following the Unix syntax for environment variables is used in the text.
+
+For Windows the syntax is slightly different, for `$A` use `%A%`.
+
+### `$MAVEN_OPTS` - `%MAVEN_OPTS%`
+
+The contents of this variable is placed in the `java` command _before_ the 
class name, and 
+can therefore be used to provide additional arguments to the Java Virtual 
Machine (JVM) without
+having to specify them on the command line every time.
+
+Examples include garbage collector and memory configuration, but _not_ options 
to Maven itself
+
+Use `java --help` and `java -X` to see what is possible in this particular JVM.
+
+
+
+### `$MAVEN_BASEDIR` - `%MAVEN_BASEDIR%`
+
+If set, this is considered the base directory of the Maven project.  If not 
set, 
+the launcher scripts search for a `.mvn` folder towards the root of the drive, 
and if
+found consider that the base directory.
+
+
+### `$MAVEN_SKIP_RC` - `%MAVEN_SKIP_RC%`
+
+If set, tells the launcher scripts _not_ to read the various Maven 
configuration files.
+This is useful to get standard behaviour.
+
+### `$JAVA_HOME` - `%JAVA_HOME%`
+
+If set, the Java binary to be used must be found at `$JAVA_HOME/bin/java` or 
an error will
+be reported.  If not set, the Java binary is found in the `$PATH`.
+
+### `$MAVEN_DEBUG_OPTS` - `%MAVEN_DEBUG_OPTS%`

Review Comment:
   same here



##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,

Review Comment:
   directory



##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under

[GitHub] [maven-reporting-impl] asfgit merged pull request #8: [MSHARED-390] Add startSection method AbstractMavenReportRenderer whe…

2022-07-03 Thread GitBox


asfgit merged PR #8:
URL: https://github.com/apache/maven-reporting-impl/pull/8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MSHARED-390) Add startSection method AbstractMavenReportRenderer where anchor != name

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MSHARED-390.
--
Resolution: Fixed

Fixed with  
[7b7664dff26ea7a6ba51d3aeea1e88c19ea69a3a|https://gitbox.apache.org/repos/asf?p=maven-reporting-impl.git;a=commit;h=7b7664dff26ea7a6ba51d3aeea1e88c19ea69a3a].

> Add startSection method AbstractMavenReportRenderer where anchor != name
> 
>
> Key: MSHARED-390
> URL: https://issues.apache.org/jira/browse/MSHARED-390
> Project: Maven Shared Components
>  Issue Type: New Feature
>  Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl-2.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: maven-reporting-impl-4.0.0-M2
>
>
> Sometimes it is necessary to provide a custom anchor name instead of using 
> the text as an anchor. This could be a synthetic anchor or a 
> language-independent one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-390) Add startSection method AbstractMavenReportRenderer where anchor != name

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561937#comment-17561937
 ] 

Hudson commented on MSHARED-390:


Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-impl » master 
#17

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-impl/job/master/17/

> Add startSection method AbstractMavenReportRenderer where anchor != name
> 
>
> Key: MSHARED-390
> URL: https://issues.apache.org/jira/browse/MSHARED-390
> Project: Maven Shared Components
>  Issue Type: New Feature
>  Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl-2.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: maven-reporting-impl-4.0.0-M2
>
>
> Sometimes it is necessary to provide a custom anchor name instead of using 
> the text as an anchor. This could be a synthetic anchor or a 
> language-independent one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1099) Render with a skin when report is run in standalone mode

2022-07-03 Thread Michael Osipov (Jira)
Michael Osipov created MSHARED-1099:
---

 Summary: Render with a skin when report is run in standalone mode
 Key: MSHARED-1099
 URL: https://issues.apache.org/jira/browse/MSHARED-1099
 Project: Maven Shared Components
  Issue Type: Improvement
  Components: maven-reporting-impl
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: maven-reporting-impl-4.0.0-M2


Currently, when a report is run in standalone mode the default skin is always 
applied. This causes several problems:
* It is always tied to the Doxia Sitetools version
* The default skin cannot be removed
* Another skin cannot be used

The improvement is to fully utilize skins from repos just like Maven Site 
Plugin does and provide a default skin: 
{{org.apache.maven.skins:maven-fluido-skin:1.11.1}}. This can always be 
overriden on a per-plugin basis. Completely decoupled from the Maven Site 
Plugin since it does not use {{site.xml}}. For skin developers, a {{standalone 
== true (Boolean)}} attribute will be added to switch between site and 
standalone mode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1099) Render with a skin when report is run in standalone mode

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1099:

Description: 
Currently, when a report is run in standalone mode the default skin is always 
applied. This causes several problems:
* It is always tied to the Doxia Sitetools version
* The default skin cannot be removed
* Another skin cannot be used

The improvement is to fully utilize skins from repos just like Maven Site 
Plugin does and provide a default skin: 
{{org.apache.maven.skins:maven-fluido-skin:1.11.1}}. This can always be 
overriden on a per-plugin basis. Completely decoupled from the Maven Site 
Plugin since it does not use {{site.xml}}. For skin developers, a {{standalone 
== true (Boolean)}} attribute will be added to the template properties to 
switch between site and standalone mode.

  was:
Currently, when a report is run in standalone mode the default skin is always 
applied. This causes several problems:
* It is always tied to the Doxia Sitetools version
* The default skin cannot be removed
* Another skin cannot be used

The improvement is to fully utilize skins from repos just like Maven Site 
Plugin does and provide a default skin: 
{{org.apache.maven.skins:maven-fluido-skin:1.11.1}}. This can always be 
overriden on a per-plugin basis. Completely decoupled from the Maven Site 
Plugin since it does not use {{site.xml}}. For skin developers, a {{standalone 
== true (Boolean)}} attribute will be added to switch between site and 
standalone mode.


> Render with a skin when report is run in standalone mode
> 
>
> Key: MSHARED-1099
> URL: https://issues.apache.org/jira/browse/MSHARED-1099
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M2
>
>
> Currently, when a report is run in standalone mode the default skin is always 
> applied. This causes several problems:
> * It is always tied to the Doxia Sitetools version
> * The default skin cannot be removed
> * Another skin cannot be used
> The improvement is to fully utilize skins from repos just like Maven Site 
> Plugin does and provide a default skin: 
> {{org.apache.maven.skins:maven-fluido-skin:1.11.1}}. This can always be 
> overriden on a per-plugin basis. Completely decoupled from the Maven Site 
> Plugin since it does not use {{site.xml}}. For skin developers, a 
> {{standalone == true (Boolean)}} attribute will be added to the template 
> properties to switch between site and standalone mode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1044) Required report phase are executed many times in the same Maven session

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1044:

Summary: Required report phase are executed many times in the same Maven 
session  (was: Required report phase are executed many time in the same Maven 
session)

> Required report phase are executed many times in the same Maven session
> ---
>
> Key: MSHARED-1044
> URL: https://issues.apache.org/jira/browse/MSHARED-1044
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-reporting-exec
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Project with two reports javadoc and surefire.
> Maven comand to execute:
> {code}
> mvn clean test site
> {code}
> And in build we have:
> {code}
> Standard test phase:
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> forked-lifecycle ---
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ 
> forked-lifecycle ---
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> forked-lifecycle ---
> [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
> forked-lifecycle ---
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ 
> forked-lifecycle ---
> Site build in the same session:
> [INFO] --- maven-site-plugin:3.10.0:site (default-site) @ forked-lifecycle ---
> [INFO] configuring report plugin 
> org.apache.maven.plugins:maven-javadoc-plugin:3.3.1
> [INFO] preparing maven-javadoc-plugin:javadoc report requires 
> 'generate-sources' forked phase execution
> [INFO] 
> [INFO] >>> maven-javadoc-plugin:3.3.1:javadoc > generate-sources @ 
> forked-lifecycle >>>
> [INFO] 
> [INFO] <<< maven-javadoc-plugin:3.3.1:javadoc < generate-sources @ 
> forked-lifecycle <<<
> [INFO] 
> [INFO] 'generate-sources' forked phase execution for 
> maven-javadoc-plugin:javadoc report preparation done
> [INFO] preparing maven-javadoc-plugin:test-javadoc report requires 
> 'generate-test-sources' forked phase execution
> [INFO] 
> [INFO] >>> maven-javadoc-plugin:3.3.1:test-javadoc > generate-test-sources @ 
> forked-lifecycle >>>
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> forked-lifecycle ---
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ 
> forked-lifecycle ---
> [INFO] 
> [INFO] <<< maven-javadoc-plugin:3.3.1:test-javadoc < generate-test-sources @ 
> forked-lifecycle <<<
> [INFO] 
> [INFO] 'generate-test-sources' forked phase execution for 
> maven-javadoc-plugin:test-javadoc report preparation done
> [INFO] 6 reports detected for maven-javadoc-plugin:3.3.1: aggregate-no-fork, 
> javadoc, javadoc-no-fork, test-aggregate-no-fork, test-javadoc, 
> test-javadoc-no-fork
> [INFO] configuring report plugin 
> org.apache.maven.plugins:maven-surefire-report-plugin:2.22.2
> [INFO] preparing maven-surefire-report-plugin:report report requires 
> '[surefire]test' forked phase execution
> [INFO] 
> [INFO] >>> maven-surefire-report-plugin:2.22.2:report > [surefire]test @ 
> forked-lifecycle >>>
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> forked-lifecycle ---
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ 
> forked-lifecycle ---
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> forked-lifecycle ---
> [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
> forked-lifecycle ---
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ 
> forked-lifecycle ---
> [INFO] 
> [INFO] <<< maven-surefire-report-plugin:2.22.2:report < [surefire]test @ 
> forked-lifecycle <<<
> [INFO] 
> [INFO] '[surefire]test' forked phase execution for 
> maven-surefire-report-plugin:report report preparation done
> {code}
> We can see that:
> maven-resources-plugin:2.6:resources (default-resources)
> maven-compiler-plugin:3.1:compile (default-compile) 
> was run 3 times
> maven-resources-plugin:2.6:testResources 
> maven-compiler-plugin:3.1:testCompile
> maven-surefire-plugin:2.12.4:test
> was run 2 times



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-install-plugin] cstamas commented on a diff in pull request #31: [MINSTALL-175] Drop MAT

2022-07-03 Thread GitBox


cstamas commented on code in PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#discussion_r912534598


##
src/main/java/org/apache/maven/plugins/install/AbstractInstallMojo.java:
##
@@ -49,28 +56,98 @@
  * Gets the path of the specified artifact within the local repository. 
Note that the returned path need not exist
  * (yet).
  *
- * @param buildingRequest {@link ProjectBuildingRequest}.
  * @param artifact The artifact whose local repo path should be 
determined, must not be null.
  * @return The absolute path to the artifact when installed, never 
null.
  */
-protected File getLocalRepoFile( ProjectBuildingRequest buildingRequest, 
Artifact artifact )
+protected File getLocalRepoFile( Artifact artifact )
 {
-String path = repositoryManager.getPathForLocalArtifact( 
buildingRequest, artifact );
-return new File( repositoryManager.getLocalRepositoryBasedir( 
buildingRequest ), path );
+String path = 
session.getRepositorySession().getLocalRepositoryManager()
+.getPathForLocalArtifact( RepositoryUtils.toArtifact( artifact 
) );
+return new File( 
session.getRepositorySession().getLocalRepository().getBasedir(), path );
 }
 
 /**
  * Gets the path of the specified artifact metadata within the local 
repository. Note that the returned path need
  * not exist (yet).
  *
- * @param buildingRequest {@link ProjectBuildingRequest}.
  * @param metadata The artifact metadata whose local repo path should be 
determined, must not be null.
  * @return The absolute path to the artifact metadata when installed, 
never null.
  */
-protected File getLocalRepoFile( ProjectBuildingRequest buildingRequest, 
ProjectArtifactMetadata metadata )
+protected File getLocalRepoFile( ProjectArtifactMetadata metadata )
 {
-String path = repositoryManager.getPathForLocalMetadata( 
buildingRequest, metadata );
-return new File( repositoryManager.getLocalRepositoryBasedir( 
buildingRequest ), path );
+DefaultArtifact pomArtifact = new DefaultArtifact(
+metadata.getGroupId(),
+metadata.getArtifactId(),
+"",
+"pom",
+metadata.getBaseVersion() );
+
+String path = 
session.getRepositorySession().getLocalRepositoryManager().getPathForLocalArtifact(
+pomArtifact );
+return new File( 
session.getRepositorySession().getLocalRepository().getBasedir(), path );
 }
 
+protected void installProject( MavenProject project )
+throws MojoFailureException, MojoExecutionException
+{
+try
+{
+InstallRequest request = new InstallRequest();
+Artifact artifact = project.getArtifact();
+String packaging = project.getPackaging();
+File pomFile = project.getFile();
+boolean isPomArtifact = "pom".equals( packaging );
+
+if ( pomFile != null )
+{
+request.addArtifact( RepositoryUtils.toArtifact( new 
ProjectArtifact( project ) ) );
+}
+
+if ( !isPomArtifact )
+{
+File file = artifact.getFile();
+
+// Here, we have a temporary solution to MINSTALL-3 
(isDirectory() is true if it went through compile

Review Comment:
   I lifted the relevant MAT code here, so this PR does not change "logic", it 
merely moves it into this plugin (that was before in MAT). So, just like in 
https://github.com/apache/maven-install-plugin/pull/15 "minimal change" is in 
place, that will subsequent PRs refine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] cstamas commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-03 Thread GitBox


cstamas commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173170285

   > As an Apache project we do not own the package `org.eclipse.aether` so we 
cannot promote the use of such package distributed in a `org.apache.maven 
groupId`. This was supposed to be a temporary transitional phase. It's now 
almost 7 years the project has been moved here. So as a transition phase we had 
enough time to change this aberration from our source code. This usage should 
be dead already after so many years. It looks to moving backward with such 
change.. if the goal is remove some old dependencies we don't like (e.g the 
dependencies pulled by m-a-t) we can certainly exclude:
   > 
   > ```
   > maven-artifact-transfer-maven-3.0.x
   > ```
   > 
   > And even drop this module from our source code if we don't want to keep 
supporting it. But the history of the source here at Apache is remove the usage 
of org.eclipse as a package we distribute which again is totally wrong and we 
cannot keep promoting.
   
   Stop spreading FUD man, you personally voted +1 on threads "[VOTE] Accept 
the Aether code into the Maven project" and also on "[IP CLEARANCE] Aether, 
renamed to Maven Artifact Resolver" on private ML (unsure could I link these as 
archives for private ML are not public). Hence, due those two before, I bet you 
got mails from thread "Trademark requests from Apache Maven regarding Aether" 
as well, also on private ML (same ML as those two before). In short, 
"distributing org.eclipse.aether" packages IS NOT WRONG.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-dependency-tree] slawekjaranowski opened a new pull request, #21: [MSHARED-1016] IT tests for transitive provided scope dependencies

2022-07-03 Thread GitBox


slawekjaranowski opened a new pull request, #21:
URL: https://github.com/apache/maven-dependency-tree/pull/21

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/MSHARED) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MSHARED-1100) Upgrade Maven Parent to 36

2022-07-03 Thread Michael Osipov (Jira)
Michael Osipov created MSHARED-1100:
---

 Summary: Upgrade Maven Parent to 36
 Key: MSHARED-1100
 URL: https://issues.apache.org/jira/browse/MSHARED-1100
 Project: Maven Shared Components
  Issue Type: Dependency upgrade
  Components: maven-reporting-impl
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: maven-reporting-impl-4.0.0-M2






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1100) Upgrade Maven Parent to 36

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1100:

Component/s: maven-reporting-exec
 (was: maven-reporting-impl)

> Upgrade Maven Parent to 36
> --
>
> Key: MSHARED-1100
> URL: https://issues.apache.org/jira/browse/MSHARED-1100
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1100) Upgrade Maven Parent to 36

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1100:

Fix Version/s: maven-reporting-exec-2.0.0-M2
   (was: maven-reporting-impl-4.0.0-M2)

> Upgrade Maven Parent to 36
> --
>
> Key: MSHARED-1100
> URL: https://issues.apache.org/jira/browse/MSHARED-1100
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-exec-2.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1101) Upgrade to Doxia/Doxia Sitetools to 2.0.0-M3

2022-07-03 Thread Michael Osipov (Jira)
Michael Osipov created MSHARED-1101:
---

 Summary: Upgrade to Doxia/Doxia Sitetools to 2.0.0-M3
 Key: MSHARED-1101
 URL: https://issues.apache.org/jira/browse/MSHARED-1101
 Project: Maven Shared Components
  Issue Type: Dependency upgrade
  Components: maven-reporting-impl
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: maven-reporting-impl-4.0.0-M2






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1101) Upgrade to Doxia/Doxia Sitetools to 2.0.0-M3

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1101:

Component/s: maven-reporting-exec
 (was: maven-reporting-impl)

> Upgrade to Doxia/Doxia Sitetools to 2.0.0-M3
> 
>
> Key: MSHARED-1101
> URL: https://issues.apache.org/jira/browse/MSHARED-1101
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1101) Upgrade to Doxia/Doxia Sitetools to 2.0.0-M3

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1101:

Fix Version/s: maven-reporting-exec-2.0.0-M2
   (was: maven-reporting-impl-4.0.0-M2)

> Upgrade to Doxia/Doxia Sitetools to 2.0.0-M3
> 
>
> Key: MSHARED-1101
> URL: https://issues.apache.org/jira/browse/MSHARED-1101
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-exec-2.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1102) Upgrade plugins and components in ITs

2022-07-03 Thread Michael Osipov (Jira)
Michael Osipov created MSHARED-1102:
---

 Summary: Upgrade plugins and components in ITs
 Key: MSHARED-1102
 URL: https://issues.apache.org/jira/browse/MSHARED-1102
 Project: Maven Shared Components
  Issue Type: Dependency upgrade
  Components: maven-reporting-impl
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: maven-reporting-impl-4.0.0-M2


* Maven to 3.2.5
* Maven Plugin Plugin to 3.6.4
* Maven Install Plugin to 3.0.0-M1
* Maven Compiler Plugin to 3.10.1
* Maven Site Plugin to 4.0.0-M2
* Maven Project Info Reports to 3.2.2



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1102) Upgrade plugins and components in ITs

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1102:

Component/s: maven-reporting-exec
 (was: maven-reporting-impl)

> Upgrade plugins and components in ITs
> -
>
> Key: MSHARED-1102
> URL: https://issues.apache.org/jira/browse/MSHARED-1102
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M2
>
>
> * Maven to 3.2.5
> * Maven Plugin Plugin to 3.6.4
> * Maven Install Plugin to 3.0.0-M1
> * Maven Compiler Plugin to 3.10.1
> * Maven Site Plugin to 4.0.0-M2
> * Maven Project Info Reports to 3.2.2



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1102) Upgrade plugins and components in ITs

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1102:

Fix Version/s: maven-reporting-exec-2.0.0-M2
   (was: maven-reporting-impl-4.0.0-M2)

> Upgrade plugins and components in ITs
> -
>
> Key: MSHARED-1102
> URL: https://issues.apache.org/jira/browse/MSHARED-1102
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-exec-2.0.0-M2
>
>
> * Maven to 3.2.5
> * Maven Plugin Plugin to 3.6.4
> * Maven Install Plugin to 3.0.0-M1
> * Maven Compiler Plugin to 3.10.1
> * Maven Site Plugin to 4.0.0-M2
> * Maven Project Info Reports to 3.2.2



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1102) Upgrade plugins and components in ITs

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1102:

Description: 
* Maven Reporting Impl to 4.0.0-M2
* Maven Site Plugin to 4.0.0-M2
* Maven Project Info Reports to 3.3.0

  was:
* Maven to 3.2.5
* Maven Plugin Plugin to 3.6.4
* Maven Install Plugin to 3.0.0-M1
* Maven Compiler Plugin to 3.10.1
* Maven Site Plugin to 4.0.0-M2
* Maven Project Info Reports to 3.2.2


> Upgrade plugins and components in ITs
> -
>
> Key: MSHARED-1102
> URL: https://issues.apache.org/jira/browse/MSHARED-1102
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-exec-2.0.0-M2
>
>
> * Maven Reporting Impl to 4.0.0-M2
> * Maven Site Plugin to 4.0.0-M2
> * Maven Project Info Reports to 3.3.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1103) Upgrade Maven Reporting API to 4.0.0-M2

2022-07-03 Thread Michael Osipov (Jira)
Michael Osipov created MSHARED-1103:
---

 Summary: Upgrade Maven Reporting API to 4.0.0-M2
 Key: MSHARED-1103
 URL: https://issues.apache.org/jira/browse/MSHARED-1103
 Project: Maven Shared Components
  Issue Type: Dependency upgrade
  Components: maven-reporting-impl
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: maven-reporting-impl-4.0.0-M2






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1103) Upgrade Maven Reporting API to 4.0.0-M2

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1103:

Component/s: maven-reporting-exec
 (was: maven-reporting-impl)

> Upgrade Maven Reporting API to 4.0.0-M2
> ---
>
> Key: MSHARED-1103
> URL: https://issues.apache.org/jira/browse/MSHARED-1103
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1103) Upgrade Maven Reporting API to 4.0.0-M2

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1103:

Fix Version/s: maven-reporting-exec-2.0.0-M2
   (was: maven-reporting-impl-4.0.0-M2)

> Upgrade Maven Reporting API to 4.0.0-M2
> ---
>
> Key: MSHARED-1103
> URL: https://issues.apache.org/jira/browse/MSHARED-1103
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-exec-2.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-install-plugin] slachiewicz commented on pull request #22: Bump slf4jVersion from 1.7.32 to 1.7.36

2022-07-03 Thread GitBox


slachiewicz commented on PR #22:
URL: 
https://github.com/apache/maven-install-plugin/pull/22#issuecomment-1173181536

   @dependabot ignore this dependency


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] dependabot[bot] closed pull request #22: Bump slf4jVersion from 1.7.32 to 1.7.36

2022-07-03 Thread GitBox


dependabot[bot] closed pull request #22: Bump slf4jVersion from 1.7.32 to 1.7.36
URL: https://github.com/apache/maven-install-plugin/pull/22


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] dependabot[bot] commented on pull request #22: Bump slf4jVersion from 1.7.32 to 1.7.36

2022-07-03 Thread GitBox


dependabot[bot] commented on PR #22:
URL: 
https://github.com/apache/maven-install-plugin/pull/22#issuecomment-1173181544

   OK, I won't notify you about any of these dependencies again, unless you 
re-open this PR or update them yourself. 😢


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] ravn commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-03 Thread GitBox


ravn commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r912549914


##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,

Review Comment:
   coming from mac 🙂 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] ravn commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-03 Thread GitBox


ravn commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r912551048


##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,
+which - based on several environment variables, project files and system files 
as described below
+- constructs and runs the appropriate `java ...` command line which then 
invokes the Java Virtual Machine (JVM) 
+that actually runs Maven.
 
-This variable contains parameters used to start up the JVM running Maven and
-can be used to supply additional options to it. E.g. JVM memory
-settings could be defined with the value `-Xms256m -Xmx512m`.
+* `mvn` - normal way to run from the command line.
+* `mvnDebug` - launches `mvn` in debug mode, waiting for a Java debugger to 
attach to port `$MAVEN_DEBUG_ADDRESS` (default 8000).
 
-## `MAVEN_ARGS` environment variable:
+
+## Environment variables
+
+In the following the Unix syntax for environment variables is used in the text.
+
+For Windows the syntax is slightly different, for `$A` use `%A%`.
+
+### `$MAVEN_OPTS` - `%MAVEN_OPTS%`
+
+The contents of this variable is placed in the `java` command _before_ the 
class name, and 
+can therefore be used to provide additional arguments to the Java Virtual 
Machine (JVM) without
+having to specify them on the command line every time.
+
+Examples include garbage collector and memory configuration, but _not_ options 
to Maven itself
+
+Use `java --help` and `java -X` to see what is possible in this particular JVM.

Review Comment:
   My OpenJDK 18 on macos accepted --help.  I use it very rarely and was in 
doubt so I checked.  Now I checked again and -help is accepted as well.  I'll 
remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] ravn commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-03 Thread GitBox


ravn commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r912551203


##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,
+which - based on several environment variables, project files and system files 
as described below
+- constructs and runs the appropriate `java ...` command line which then 
invokes the Java Virtual Machine (JVM) 
+that actually runs Maven.
 
-This variable contains parameters used to start up the JVM running Maven and
-can be used to supply additional options to it. E.g. JVM memory
-settings could be defined with the value `-Xms256m -Xmx512m`.
+* `mvn` - normal way to run from the command line.
+* `mvnDebug` - launches `mvn` in debug mode, waiting for a Java debugger to 
attach to port `$MAVEN_DEBUG_ADDRESS` (default 8000).
 
-## `MAVEN_ARGS` environment variable:
+
+## Environment variables
+
+In the following the Unix syntax for environment variables is used in the text.
+
+For Windows the syntax is slightly different, for `$A` use `%A%`.
+
+### `$MAVEN_OPTS` - `%MAVEN_OPTS%`
+
+The contents of this variable is placed in the `java` command _before_ the 
class name, and 
+can therefore be used to provide additional arguments to the Java Virtual 
Machine (JVM) without
+having to specify them on the command line every time.
+
+Examples include garbage collector and memory configuration, but _not_ options 
to Maven itself
+
+Use `java --help` and `java -X` to see what is possible in this particular JVM.
+
+
+
+### `$MAVEN_BASEDIR` - `%MAVEN_BASEDIR%`

Review Comment:
   It was a comment placeholder.  I'll remove it completely.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] ravn commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-03 Thread GitBox


ravn commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r912551491


##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,
+which - based on several environment variables, project files and system files 
as described below
+- constructs and runs the appropriate `java ...` command line which then 
invokes the Java Virtual Machine (JVM) 
+that actually runs Maven.
 
-This variable contains parameters used to start up the JVM running Maven and
-can be used to supply additional options to it. E.g. JVM memory
-settings could be defined with the value `-Xms256m -Xmx512m`.
+* `mvn` - normal way to run from the command line.
+* `mvnDebug` - launches `mvn` in debug mode, waiting for a Java debugger to 
attach to port `$MAVEN_DEBUG_ADDRESS` (default 8000).
 
-## `MAVEN_ARGS` environment variable:
+
+## Environment variables
+
+In the following the Unix syntax for environment variables is used in the text.
+
+For Windows the syntax is slightly different, for `$A` use `%A%`.
+
+### `$MAVEN_OPTS` - `%MAVEN_OPTS%`
+
+The contents of this variable is placed in the `java` command _before_ the 
class name, and 
+can therefore be used to provide additional arguments to the Java Virtual 
Machine (JVM) without
+having to specify them on the command line every time.
+
+Examples include garbage collector and memory configuration, but _not_ options 
to Maven itself
+
+Use `java --help` and `java -X` to see what is possible in this particular JVM.
+
+
+
+### `$MAVEN_BASEDIR` - `%MAVEN_BASEDIR%`

Review Comment:
   Oh, this is about MAVEN_BASEDIR which is a thing in the current wrappers.  
Should it not be documented until maven 4 is released?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] ravn commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-03 Thread GitBox


ravn commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r912552470


##
content/markdown/configure.md:
##
@@ -65,26 +130,35 @@ From now on this can be done much more simpler and in a 
more Maven like way. So
 
 ```
 
-Now you can simply use an extension by defining the usual maven coordinates 
groupId, artifactId, version as any other artifact. Furthermore all transitive 
dependencies of those extensions will automatically being downloaded from your 
repository. So no need to create a shaded artifact anymore.
+### `/usr/local/etc/mavenrc` + `/etc/mavenrc` + `$HOME/.mavenrc`
 
-### `.mvn/maven.config` file:
+Unix-like systems only: 
+Configuration files executed by the Unix launcher scripts first thing, unless
+if the environment variable `$MAVEN_SKIP_RC` is set.
 
-It’s really hard to define a general set of options for calling the maven 
command line. Starting with Maven 3.3.1+, this can be solved by 
-putting this 
-options to a script but this can now simple being done by defining 
`${maven.projectBasedir}/.mvn/maven.config` file which contains the 
-configuration options for the `mvn` command line. 
+Typically environment variables - including `$PATH` - are set here.
 
-For example things like `-T3 -U --fail-at-end`. So you only have to call Maven 
just by using `mvn 
-clean package` instead of `mvn -T3 -U --fail-at-end clean package` and not to 
miss the `-T3 -U --fail-at-end` options on every call. The 
-`${maven.projectBasedir}/.mvn/maven.config` is located in the 
`${maven.projectBasedir}/.mvn/` directory; also works if in the root of a multi 
module build.
+### `%USERPROFILE%\mavenrc_pre.bat` + `%USERPROFILE%\mavenrc_pre.cmd`

Review Comment:
   Not in the wrapper scripts I was looking at for 3.84.  Has this just changed?
   
   ```
   @REM Execute a user defined script before this one
   if not "%MAVEN_SKIP_RC%"=="" goto skipRcPre
   @REM check for pre script, once with legacy .bat ending and once with .cmd 
ending
   if exist "%USERPROFILE%\mavenrc_pre.bat" call 
"%USERPROFILE%\mavenrc_pre.bat" %*
   if exist "%USERPROFILE%\mavenrc_pre.cmd" call 
"%USERPROFILE%\mavenrc_pre.cmd" %*
   :skipRcPre
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] ravn commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-03 Thread GitBox


ravn commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r912553299


##
content/markdown/configure.md:
##
@@ -65,26 +130,35 @@ From now on this can be done much more simpler and in a 
more Maven like way. So
 
 ```
 
-Now you can simply use an extension by defining the usual maven coordinates 
groupId, artifactId, version as any other artifact. Furthermore all transitive 
dependencies of those extensions will automatically being downloaded from your 
repository. So no need to create a shaded artifact anymore.
+### `/usr/local/etc/mavenrc` + `/etc/mavenrc` + `$HOME/.mavenrc`
 
-### `.mvn/maven.config` file:
+Unix-like systems only: 
+Configuration files executed by the Unix launcher scripts first thing, unless
+if the environment variable `$MAVEN_SKIP_RC` is set.
 
-It’s really hard to define a general set of options for calling the maven 
command line. Starting with Maven 3.3.1+, this can be solved by 
-putting this 
-options to a script but this can now simple being done by defining 
`${maven.projectBasedir}/.mvn/maven.config` file which contains the 
-configuration options for the `mvn` command line. 
+Typically environment variables - including `$PATH` - are set here.
 
-For example things like `-T3 -U --fail-at-end`. So you only have to call Maven 
just by using `mvn 
-clean package` instead of `mvn -T3 -U --fail-at-end clean package` and not to 
miss the `-T3 -U --fail-at-end` options on every call. The 
-`${maven.projectBasedir}/.mvn/maven.config` is located in the 
`${maven.projectBasedir}/.mvn/` directory; also works if in the root of a multi 
module build.
+### `%USERPROFILE%\mavenrc_pre.bat` + `%USERPROFILE%\mavenrc_pre.cmd`
 
-### `.mvn/jvm.config` file:
+Windows systems only:
+Configuration files executed by the Windows launcher scripts first thing 
_before_ launching the Maven JVM, 
+unless if the environment variable `%MAVEN_SKIP_RC%` is set.
 
-Starting with Maven 3.3.1+ you can define JVM configuration via 
`${maven.projectBasedir}/.mvn/jvm.config` file which means you can define the 
options for your build on a per project base. This file will become part of 
your project and will be checked in along with your project. So no need anymore 
for `MAVEN_OPTS`, `.mavenrc` files. So for example if you put the following JVM 
options into the `${maven.projectBasedir}/.mvn/jvm.config` file
+This can be used to provide secrets, like the password for a keystore:

Review Comment:
   I found it in a comment on this issue.  
https://issues.apache.org/jira/browse/MNGSITE-246.  I have added a warning.  
Should it be removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] ravn commented on pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-03 Thread GitBox


ravn commented on PR #308:
URL: https://github.com/apache/maven-site/pull/308#issuecomment-1173199801

   I have applied the suggested changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-jar-plugin] dependabot[bot] opened a new pull request, #45: Bump plexus-archiver from 4.3.0 to 4.4.0

2022-07-03 Thread GitBox


dependabot[bot] opened a new pull request, #45:
URL: https://github.com/apache/maven-jar-plugin/pull/45

   Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) 
from 4.3.0 to 4.4.0.
   
   Release notes
   Sourced from https://github.com/codehaus-plexus/plexus-archiver/releases";>plexus-archiver's
 releases.
   
   4.4.0
   
   🚀 New features and improvements
   
   Drop legacy plexus API and use only JSR330 components (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/220";>#220)
 https://github.com/cstamas";>@​cstamas
   
   
   
   
   Commits
   
   https://github.com/codehaus-plexus/plexus-archiver/commit/ac624a71e14e4a471eb90137cc461eeb9c5be3fe";>ac624a7
 [maven-release-plugin] prepare release plexus-archiver-4.4.0
   https://github.com/codehaus-plexus/plexus-archiver/commit/4c51190950446112f206089ff0825592b2f7f413";>4c51190
 Bump to 4.4.0
   https://github.com/codehaus-plexus/plexus-archiver/commit/48d3280d366232606a39a5dca0c8b183428b5dde";>48d3280
 Drop legacy plexus API and use only JSR330 components (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/220";>#220)
   https://github.com/codehaus-plexus/plexus-archiver/commit/337214c2976564ff4255882bd76954c331a4e62e";>337214c
 [maven-release-plugin] prepare for next development iteration
   See full diff in https://github.com/codehaus-plexus/plexus-archiver/compare/plexus-archiver-4.3.0...plexus-archiver-4.4.0";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-archiver&package-manager=maven&previous-version=4.3.0&new-version=4.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-doxia-converter] dependabot[bot] opened a new pull request, #28: Bump maven-assembly-plugin from 3.3.0 to 3.4.0

2022-07-03 Thread GitBox


dependabot[bot] opened a new pull request, #28:
URL: https://github.com/apache/maven-doxia-converter/pull/28

   Bumps 
[maven-assembly-plugin](https://github.com/apache/maven-assembly-plugin) from 
3.3.0 to 3.4.0.
   
   Commits
   
   https://github.com/apache/maven-assembly-plugin/commit/2d163c17e398624a5d785e0bf4aff198e057c952";>2d163c1
 [maven-release-plugin] prepare release maven-assembly-plugin-3.4.0
   https://github.com/apache/maven-assembly-plugin/commit/937750250bfe06333f92351fa1a19a9cd5e59d28";>9377502
 [MASSEMBLY-961] Update maven-archiver to 3.6.0 (https://github-redirect.dependabot.com/apache/maven-assembly-plugin/issues/70";>#70)
   https://github.com/apache/maven-assembly-plugin/commit/0635269bae1fbd4d6a20db6cdc19a1048e35e36e";>0635269
 [MASSEMBLY-960] Update maven-filtering to 3.3.0 (https://github-redirect.dependabot.com/apache/maven-assembly-plugin/issues/69";>#69)
   https://github.com/apache/maven-assembly-plugin/commit/d37c5cf6802aae122a53e3881367ce22d65ffea6";>d37c5cf
 [MASSEMBLY-962] Update m-common-a-f to 3.3.0 (https://github-redirect.dependabot.com/apache/maven-assembly-plugin/issues/68";>#68)
   https://github.com/apache/maven-assembly-plugin/commit/a006e1bf0c82d8a80ba2b25d7de456cb1d54f720";>a006e1b
 Bump commons-fileupload in /src/it/projects/bugs/massembly-580
   https://github.com/apache/maven-assembly-plugin/commit/e9b5a0142103ff67d2cd6bbdec73ff3752021d96";>e9b5a01
 Bump commons-io from 2.2 to 2.7 in /src/it/projects/bugs/massembly-730
   https://github.com/apache/maven-assembly-plugin/commit/3356517955a91f53f7a920554b2c8458bac1fa59";>3356517
 Bump junit from 4.11 to 4.13.1 in /src/it/projects/bugs/massembly-730
   https://github.com/apache/maven-assembly-plugin/commit/7124746d426fca482e3015c20f83a6ca6d28967f";>7124746
 Bump postgresql in /src/it/projects/bugs/massembly-730
   https://github.com/apache/maven-assembly-plugin/commit/a206f1678c394c50919fd4ab070826196b0a0b13";>a206f16
 Bump commons-compress from 1.20 to 1.21
   https://github.com/apache/maven-assembly-plugin/commit/d92242df1146a4f4a3a9b6beab0672454814c0e7";>d92242d
 Bump mockito-core from 2.28.2 to 4.6.1
   Additional commits viewable in https://github.com/apache/maven-assembly-plugin/compare/maven-assembly-plugin-3.3.0...maven-assembly-plugin-3.4.0";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.plugins:maven-assembly-plugin&package-manager=maven&previous-version=3.3.0&new-version=3.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-jar-plugin] slawekjaranowski merged pull request #43: [MJAR-275] - Fix outputTimestamp not applied to module-info; breaks reproducible builds

2022-07-03 Thread GitBox


slawekjaranowski merged PR #43:
URL: https://github.com/apache/maven-jar-plugin/pull/43


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-jar-plugin] dependabot[bot] commented on pull request #45: Bump plexus-archiver from 4.3.0 to 4.4.0

2022-07-03 Thread GitBox


dependabot[bot] commented on PR #45:
URL: https://github.com/apache/maven-jar-plugin/pull/45#issuecomment-1173358626

   Looks like org.codehaus.plexus:plexus-archiver is no longer a dependency, so 
this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-jar-plugin] dependabot[bot] closed pull request #45: Bump plexus-archiver from 4.3.0 to 4.4.0

2022-07-03 Thread GitBox


dependabot[bot] closed pull request #45: Bump plexus-archiver from 4.3.0 to 
4.4.0
URL: https://github.com/apache/maven-jar-plugin/pull/45


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MJAR-275) outputTimestamp not applied to module-info; breaks reproducible builds

2022-07-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MJAR-275.

  Assignee: Slawomir Jaranowski
Resolution: Fixed

> outputTimestamp not applied to module-info; breaks reproducible builds
> --
>
> Key: MJAR-275
> URL: https://issues.apache.org/jira/browse/MJAR-275
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.0
> Environment: Mac OS X 10.14.6
> JDK 15 (build 15+36)
> JDK 11 (build 11.0.8+10)
>Reporter: Anand Beh
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: MCOMPILER-439.zip, Screenshot 2020-10-25 at 2.35.59 
> PM.png
>
>
> Setting {{project.build.outputTimestamp}} to a fixed value allows creating 
> reproducible builds per this guide: 
> [https://maven.apache.org/guides/mini/guide-reproducible-builds.html 
> |https://maven.apache.org/guides/mini/guide-reproducible-builds.html]However, 
> if one adds a module-info file to the project, reproducible builds break.
> This is caused by module-info.class using the latest timestamp and not 
> {{project.build.outputTimestamp}}. I was able to identify the problem using 
> diffoscope: [https://diffoscope.org/.|https://diffoscope.org/] With it I 
> determined the timestamp across 2 builds was constant for all but the 
> module-info.class:
>  
> {code:java}
>   -rw 2.0 fat  862 bl defN 20-Oct-17 00:40 
> space/arim/libertybans/api/select/SelectionOrder.class
> │  -rw 2.0 fat 1113 bl defN 20-Oct-17 00:40 
> space/arim/libertybans/api/select/SelectionOrderBuilder.class
> │  -rw 2.0 fat 2285 bl defN 20-Oct-17 00:40 
> META-INF/maven/space.arim.libertybans/bans-api/pom.xml
> │  -rw 2.0 fat   74 bl defN 20-Oct-17 00:40 
> META-INF/maven/space.arim.libertybans/bans-api/pom.properties
> │ --rw 2.0 fat  557 bl defN 20-Oct-25 12:39 module-info.class
> │ +-rw 2.0 fat  557 bl defN 20-Oct-25 12:41 module-info.class
> {code}
>  
> Note the + and - which are diffoscope's way of indicating the difference 
> between the .jar files. Here the {{project.build.outputTimestamp}} is on 17 
> October. As shown, module-info has a "rebellious" timestamp.
>  
> *EDIT:*
> Example project to reproduce the bug:
> [https://github.com/A248/MJAR-275|https://github.com/A248/MCOMPILER-439] 
> (Renamed from [https://github.com/A248/MCOMPILER-439])
> Source code is also provided as an attachment below



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAR-275) outputTimestamp not applied to module-info; breaks reproducible builds

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MJAR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562013#comment-17562013
 ] 

Hudson commented on MJAR-275:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-jar-plugin » master #19

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-jar-plugin/job/master/19/

> outputTimestamp not applied to module-info; breaks reproducible builds
> --
>
> Key: MJAR-275
> URL: https://issues.apache.org/jira/browse/MJAR-275
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.0
> Environment: Mac OS X 10.14.6
> JDK 15 (build 15+36)
> JDK 11 (build 11.0.8+10)
>Reporter: Anand Beh
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: MCOMPILER-439.zip, Screenshot 2020-10-25 at 2.35.59 
> PM.png
>
>
> Setting {{project.build.outputTimestamp}} to a fixed value allows creating 
> reproducible builds per this guide: 
> [https://maven.apache.org/guides/mini/guide-reproducible-builds.html 
> |https://maven.apache.org/guides/mini/guide-reproducible-builds.html]However, 
> if one adds a module-info file to the project, reproducible builds break.
> This is caused by module-info.class using the latest timestamp and not 
> {{project.build.outputTimestamp}}. I was able to identify the problem using 
> diffoscope: [https://diffoscope.org/.|https://diffoscope.org/] With it I 
> determined the timestamp across 2 builds was constant for all but the 
> module-info.class:
>  
> {code:java}
>   -rw 2.0 fat  862 bl defN 20-Oct-17 00:40 
> space/arim/libertybans/api/select/SelectionOrder.class
> │  -rw 2.0 fat 1113 bl defN 20-Oct-17 00:40 
> space/arim/libertybans/api/select/SelectionOrderBuilder.class
> │  -rw 2.0 fat 2285 bl defN 20-Oct-17 00:40 
> META-INF/maven/space.arim.libertybans/bans-api/pom.xml
> │  -rw 2.0 fat   74 bl defN 20-Oct-17 00:40 
> META-INF/maven/space.arim.libertybans/bans-api/pom.properties
> │ --rw 2.0 fat  557 bl defN 20-Oct-25 12:39 module-info.class
> │ +-rw 2.0 fat  557 bl defN 20-Oct-25 12:41 module-info.class
> {code}
>  
> Note the + and - which are diffoscope's way of indicating the difference 
> between the .jar files. Here the {{project.build.outputTimestamp}} is on 17 
> October. As shown, module-info has a "rebellious" timestamp.
>  
> *EDIT:*
> Example project to reproduce the bug:
> [https://github.com/A248/MJAR-275|https://github.com/A248/MCOMPILER-439] 
> (Renamed from [https://github.com/A248/MCOMPILER-439])
> Source code is also provided as an attachment below



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-doxia-converter] slachiewicz merged pull request #28: Bump maven-assembly-plugin from 3.3.0 to 3.4.0

2022-07-03 Thread GitBox


slachiewicz merged PR #28:
URL: https://github.com/apache/maven-doxia-converter/pull/28


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] mthmulders commented on pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-03 Thread GitBox


mthmulders commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1173382409

   Thanks for the IT. I've learned about `mvn :@` today 
:-)
   
   Since there's no PR for the IT, let me ask one question here: I noticed the 
name of the test methods all start with `test`, but there's no `@Test` 
annotation. I thought we were on JUnit 4, with JUnit 5 
[underway](https://github.com/apache/maven-integration-testing/pull/176). 
Wouldn't it make more sense to write the tests in JUnit 4 style? Also, if we 
were on JUnit 5 already, you could even turn it into a parameterised test, but 
I think that's not possible at the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562019#comment-17562019
 ] 

ASF GitHub Bot commented on MNG-7353:
-

mthmulders commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1173382409

   Thanks for the IT. I've learned about `mvn :@` today 
:-)
   
   Since there's no PR for the IT, let me ask one question here: I noticed the 
name of the test methods all start with `test`, but there's no `@Test` 
annotation. I thought we were on JUnit 4, with JUnit 5 
[underway](https://github.com/apache/maven-integration-testing/pull/176). 
Wouldn't it make more sense to write the tests in JUnit 4 style? Also, if we 
were on JUnit 5 already, you could even turn it into a parameterised test, but 
I think that's not possible at the moment.




> add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-335) Bump maven-assembly-plugin from 3.3.0 to 3.4.1

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MPOM-335:

Summary: Bump maven-assembly-plugin from 3.3.0 to 3.4.1  (was: Bump 
maven-assembly-plugin from 3.3.0 to 3.4.0)

> Bump maven-assembly-plugin from 3.3.0 to 3.4.1
> --
>
> Key: MPOM-335
> URL: https://issues.apache.org/jira/browse/MPOM-335
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-27
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1096) Upgrade Maven Reporting API to 4.0.0-M2

2022-07-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MSHARED-1096.
---
Resolution: Fixed

Fixed with  
[258769f26f354b2bbb9bf82483fa182a89a12cf0|https://gitbox.apache.org/repos/asf?p=maven-reporting-impl.git;a=commit;h=258769f26f354b2bbb9bf82483fa182a89a12cf0].

> Upgrade Maven Reporting API to 4.0.0-M2
> ---
>
> Key: MSHARED-1096
> URL: https://issues.apache.org/jira/browse/MSHARED-1096
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1096) Upgrade Maven Reporting API to 4.0.0-M2

2022-07-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562027#comment-17562027
 ] 

Hudson commented on MSHARED-1096:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-impl » master 
#18

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-impl/job/master/18/

> Upgrade Maven Reporting API to 4.0.0-M2
> ---
>
> Key: MSHARED-1096
> URL: https://issues.apache.org/jira/browse/MSHARED-1096
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] kwin commented on pull request #703: New API with immutable model

2022-07-03 Thread GitBox


kwin commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173423189

   What about 
https://github.com/apache/maven/blob/2926f033cb934e7bcef51362639663bc2a39cf9a/maven-core/src/main/java/org/apache/maven/artifact/handler/DefaultArtifactHandler.java
 and 
https://github.com/apache/maven/blob/896c707d324330d7d4ad92674187923945efcda9/maven-core/src/main/java/org/apache/maven/lifecycle/mapping/DefaultLifecycleMapping.java?
 IMHO those are the recommend way to override the default lifecycles for 
certain types 
(https://books.sonatype.com/mvnref-book/reference/writing-plugins-sect-plugins-lifecycle.html).
 Are those supposed to be implementation details or should those be moved to 
API as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org