[GitHub] [maven-jar-plugin] slachiewicz merged pull request #42: Bump plexus-utils from 3.3.1 to 3.4.2
slachiewicz merged PR #42: URL: https://github.com/apache/maven-jar-plugin/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] slachiewicz merged pull request #27: Bump plexus-utils from 3.4.1 to 3.4.2
slachiewicz merged PR #27: URL: https://github.com/apache/maven-doxia-converter/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-analyzer] slachiewicz merged pull request #63: Bump plexus-utils from 3.4.1 to 3.4.2
slachiewicz merged PR #63: URL: https://github.com/apache/maven-dependency-analyzer/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slachiewicz merged pull request #121: Bump plexus-utils from 3.4.1 to 3.4.2
slachiewicz merged PR #121: URL: https://github.com/apache/maven-invoker-plugin/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slachiewicz commented on pull request #36: Bump plexus-utils from 3.3.0 to 3.4.1
slachiewicz commented on PR #36: URL: https://github.com/apache/maven-help-plugin/pull/36#issuecomment-1129663066 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] slachiewicz merged pull request #128: Bump plexus-utils from 3.4.1 to 3.4.2
slachiewicz merged PR #128: URL: https://github.com/apache/maven-release/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #36: Bump plexus-utils from 3.3.0 to 3.4.1
dependabot[bot] commented on PR #36: URL: https://github.com/apache/maven-help-plugin/pull/36#issuecomment-1129663766 Superseded by #59. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #59: Bump plexus-utils from 3.3.0 to 3.4.2
dependabot[bot] opened a new pull request, #59: URL: https://github.com/apache/maven-help-plugin/pull/59 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.3.0 to 3.4.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexus-utils's releases. 3.4.2 🚀 New features and improvements Provides a CachingOuptutStream and a CachingWriter (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/184";>#184) https://github.com/gnodet";>@gnodet Use (already) precalculated value (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/186";>#186) https://github.com/pzygielo";>@pzygielo use github shared actions (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/171";>#171) https://github.com/olamy";>@olamy 🐛 Bug Fixes MXParser fixes (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/185";>#185) https://github.com/gnodet";>@gnodet Fix last modified time not being updated on linux (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/203";>#203) https://github.com/gnodet";>@gnodet Fix regression and deprecate: FileUtils.fileAppend should create file… (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/200";>#200) https://github.com/slachiewicz";>@slachiewicz Fix some testing XML files checkout with incorrect eol (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/198";>#198) https://github.com/belingueres";>@belingueres Fixed regressions: https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163 and https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/194";>#194 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/195";>#195) https://github.com/belingueres";>@belingueres Don't ignore valid SCM files (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/174";>#174) https://github.com/michael-o";>@michael-o 📦 Dependency updates Bump github/codeql-action from 1 to 2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/202";>#202) https://github.com/dependabot";>@dependabot Bump actions/checkout from 3.0.1 to 3.0.2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/199";>#199) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.18.1 to 5.19.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/188";>#188) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/189";>#189) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/190";>#190) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.4.0 to 3.0.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/197";>#197) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/175";>#175) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.18.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/183";>#183) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.3.4 to 2.4.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/173";>#173) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/170";>#170) https://github.com/dependabot";>@dependabot 3.4.1 🐛 Bug Fixes Fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163: Regression: encoding error when parsing a ISO-8859-1 xml (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/164";>#164) https://github.com/belingueres";>@belingueres 📦 Dependency updates Bump actions/setup-java from 2.2.0 to 2.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/168";>#168) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.32 to 1.33 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/166";>#166) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.32 to 1.33 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/165";>#
[GitHub] [maven-help-plugin] dependabot[bot] closed pull request #36: Bump plexus-utils from 3.3.0 to 3.4.1
dependabot[bot] closed pull request #36: Bump plexus-utils from 3.3.0 to 3.4.1 URL: https://github.com/apache/maven-help-plugin/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] slachiewicz merged pull request #28: Bump plexus-utils from 3.4.1 to 3.4.2
slachiewicz merged PR #28: URL: https://github.com/apache/maven-resources-plugin/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz merged pull request #79: Bump plexus-utils from 3.4.1 to 3.4.2
slachiewicz merged PR #79: URL: https://github.com/apache/maven-checkstyle-plugin/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSITE-902) Upgrade Plexus Utils to 3.4.2
[ https://issues.apache.org/jira/browse/MSITE-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-902. Resolution: Fixed Fixed with [65a8052261a6e4cf2c34da44ce3186faa4e9|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=65a8052261a6e4cf2c34da44ce3186faa4e9] and with [b99c0ef371774a414ade764f2921bdfe8918ed60|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=b99c0ef371774a414ade764f2921bdfe8918ed60] for 3.x branch. > Upgrade Plexus Utils to 3.4.2 > - > > Key: MSITE-902 > URL: https://issues.apache.org/jira/browse/MSITE-902 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0-M2, 3.12.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSITE-902) Upgrade Plexus Utils to 3.4.2
[ https://issues.apache.org/jira/browse/MSITE-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538654#comment-17538654 ] Hudson commented on MSITE-902: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-site-plugin » master #28 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site-plugin/job/master/28/ > Upgrade Plexus Utils to 3.4.2 > - > > Key: MSITE-902 > URL: https://issues.apache.org/jira/browse/MSITE-902 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0-M2, 3.12.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven] rfscholte commented on a diff in pull request #744: [MNG-7360] Fix xml transformation to ensure proper context
rfscholte commented on code in PR #744: URL: https://github.com/apache/maven/pull/744#discussion_r875617018 ## maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/BufferingParser.java: ## @@ -430,7 +430,7 @@ public int nextToken() throws XmlPullParserException, IOException throw new XmlPullParserException( "already reached end of XML input", this, null ); } int currentEvent = xmlPullParser.nextToken(); -if ( accept() ) +if ( disabled || accept() ) Review Comment: This looks like to conflicting states, which makes me wonder if we can always return currentEvent. If current expression is required, we need to think of better naming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7360) Can't parse project that has tag in plugin configuration
[ https://issues.apache.org/jira/browse/MNG-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538658#comment-17538658 ] ASF GitHub Bot commented on MNG-7360: - rfscholte commented on code in PR #744: URL: https://github.com/apache/maven/pull/744#discussion_r875617018 ## maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/BufferingParser.java: ## @@ -430,7 +430,7 @@ public int nextToken() throws XmlPullParserException, IOException throw new XmlPullParserException( "already reached end of XML input", this, null ); } int currentEvent = xmlPullParser.nextToken(); -if ( accept() ) +if ( disabled || accept() ) Review Comment: This looks like to conflicting states, which makes me wonder if we can always return currentEvent. If current expression is required, we need to think of better naming. > Can't parse project that has tag in plugin configuration > - > > Key: MNG-7360 > URL: https://issues.apache.org/jira/browse/MNG-7360 > Project: Maven > Issue Type: Bug > Components: build/consumer >Affects Versions: 4.0.x-candidate > Environment: Apache Maven 4.0.0-alpha-1-SNAPSHOT > (3a06530dbce82e2054afa3cc4c81631910474bd0) > Maven home: > /usr/local/Cellar/maven-snapshot/4.0.0-alpha-1-SNAPSHOT_290/libexec > Java version: 17.0.1, vendor: Eclipse Adoptium, runtime: > /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" >Reporter: Maarten Mulders >Assignee: Guillaume Nodet >Priority: Major > Attachments: Screenshot 2021-12-13 at 13.45.01.png > > > The Apache Camel project has the following snippet in their root POM: > {code:xml} > > org.codehaus.mojo > flatten-maven-plugin > 1.2.5 > > > default-cli > process-resources > > flatten > > > > > > expand > > > > > > > {code} > With Maven 4's "Build Consumer" feature enabled, parsing this plugin > definition breaks with > {code:none} > [INFO] BuildTimeEventSpy is registered. > [INFO] Scanning for projects... > [ERROR] [ERROR] Some problems were encountered while processing the POMs: > [FATAL] Unable to transform pom > [ERROR] The build could not read 1 project -> [Help 1] > [ERROR] > [ERROR] The project (/Users/maarten/Code/open-source/camel/pom.xml) has 1 > error > [ERROR] Unable to transform pom: Not a regular file: > /Users/maarten/Code/open-source/pom.xml > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the '-e' > switch > [ERROR] Re-run Maven using the '-X' switch to enable verbose output > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException > {code} > I suspect that the {{}} tag is the culprit. It seems to me that it > causes the {{ParentXMLFilter}} to think it needs to do its work. The attached > screenshot shows the stacktrace that brought me to this idea. As the > {{BufferingParser}} class processes its buffer of events, it encounters a > situation of an "end {{parent}} tag". But that {{parent}} tag did not have > child elements {{version}} and {{relativePath}} and so, it decides it needs > to resolve the parent as {{../pom.xml}} against the project path > ({{/Users/maarten/Code/open-source/camel/}} in my case), leading to the > non-existing path of {{/Users/maarten/Code/open-source/pom.xml}}. > I think the bug here is not that it resolves to a non-existing path (it's > good to check that before actually reading the file). I think the bug is that > the {{ParentXMLFilter}} is acting on the {{parent}} tag inside the plugin > configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-site-plugin] asfgit closed pull request #82: [MSITE-901] If preceding standalone report has been run, site:jar do…
asfgit closed pull request #82: [MSITE-901] If preceding standalone report has been run, site:jar do… URL: https://github.com/apache/maven-site-plugin/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-901) If preceding standalone report has been run, site:jar does not reinvoke site:site
[ https://issues.apache.org/jira/browse/MSITE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538661#comment-17538661 ] ASF GitHub Bot commented on MSITE-901: -- asfgit closed pull request #82: [MSITE-901] If preceding standalone report has been run, site:jar do… URL: https://github.com/apache/maven-site-plugin/pull/82 > If preceding standalone report has been run, site:jar does not reinvoke > site:site > - > > Key: MSITE-901 > URL: https://issues.apache.org/jira/browse/MSITE-901 > Project: Maven Site Plugin > Issue Type: Bug > Components: site:jar >Affects Versions: 3.12.0, 4.0.0-M1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0-M2, 3.12.1 > > > When {{site:jar}} is run or bound to a phase and a prior report to a earlier > lifecycle binding has been generated, e.g., {{pmd:check}}, the output > directory will be generated by PMD and {{site:jar}} Java code sees that the > dir is there and will never generate the site. Thus, the JAR will be empty. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MSITE-901) If preceding standalone report has been run, site:jar does not reinvoke site:site
[ https://issues.apache.org/jira/browse/MSITE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-901. Resolution: Fixed Fixed with [4a38a81f06d5ba95eb9d8d1ebb89b4f88c4932c3|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=4a38a81f06d5ba95eb9d8d1ebb89b4f88c4932c3] and with [bd3376f52d0053e05c78327aad39353710702a7a|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=bd3376f52d0053e05c78327aad39353710702a7a] for 3.x branch. > If preceding standalone report has been run, site:jar does not reinvoke > site:site > - > > Key: MSITE-901 > URL: https://issues.apache.org/jira/browse/MSITE-901 > Project: Maven Site Plugin > Issue Type: Bug > Components: site:jar >Affects Versions: 3.12.0, 4.0.0-M1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0-M2, 3.12.1 > > > When {{site:jar}} is run or bound to a phase and a prior report to a earlier > lifecycle binding has been generated, e.g., {{pmd:check}}, the output > directory will be generated by PMD and {{site:jar}} Java code sees that the > dir is there and will never generate the site. Thus, the JAR will be empty. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-site-plugin] michael-o closed pull request #83: Bump plexus-utils from 3.3.1 to 3.4.2
michael-o closed pull request #83: Bump plexus-utils from 3.3.1 to 3.4.2 URL: https://github.com/apache/maven-site-plugin/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site-plugin] dependabot[bot] commented on pull request #83: Bump plexus-utils from 3.3.1 to 3.4.2
dependabot[bot] commented on PR #83: URL: https://github.com/apache/maven-site-plugin/pull/83#issuecomment-1129730452 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #83: Bump plexus-utils from 3.3.1 to 3.4.2
michael-o commented on PR #83: URL: https://github.com/apache/maven-site-plugin/pull/83#issuecomment-1129730418 Superseded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #74: Example of passing ITs for PR #73
michael-o commented on PR #74: URL: https://github.com/apache/maven-site-plugin/pull/74#issuecomment-1129733109 I think this is obsolete with Plexus Utils 3.4.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #744: [MNG-7360] Fix xml transformation to ensure proper context
gnodet commented on code in PR #744: URL: https://github.com/apache/maven/pull/744#discussion_r875636830 ## maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/BufferingParser.java: ## @@ -430,7 +430,7 @@ public int nextToken() throws XmlPullParserException, IOException throw new XmlPullParserException( "already reached end of XML input", this, null ); } int currentEvent = xmlPullParser.nextToken(); -if ( accept() ) +if ( disabled || accept() ) Review Comment: Maybe rename `disabled` to `bypass` ? Or `accept()` to `canYieldCurrentEvent()` ? Or both... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7360) Can't parse project that has tag in plugin configuration
[ https://issues.apache.org/jira/browse/MNG-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538667#comment-17538667 ] ASF GitHub Bot commented on MNG-7360: - gnodet commented on code in PR #744: URL: https://github.com/apache/maven/pull/744#discussion_r875636830 ## maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/BufferingParser.java: ## @@ -430,7 +430,7 @@ public int nextToken() throws XmlPullParserException, IOException throw new XmlPullParserException( "already reached end of XML input", this, null ); } int currentEvent = xmlPullParser.nextToken(); -if ( accept() ) +if ( disabled || accept() ) Review Comment: Maybe rename `disabled` to `bypass` ? Or `accept()` to `canYieldCurrentEvent()` ? Or both... > Can't parse project that has tag in plugin configuration > - > > Key: MNG-7360 > URL: https://issues.apache.org/jira/browse/MNG-7360 > Project: Maven > Issue Type: Bug > Components: build/consumer >Affects Versions: 4.0.x-candidate > Environment: Apache Maven 4.0.0-alpha-1-SNAPSHOT > (3a06530dbce82e2054afa3cc4c81631910474bd0) > Maven home: > /usr/local/Cellar/maven-snapshot/4.0.0-alpha-1-SNAPSHOT_290/libexec > Java version: 17.0.1, vendor: Eclipse Adoptium, runtime: > /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" >Reporter: Maarten Mulders >Assignee: Guillaume Nodet >Priority: Major > Attachments: Screenshot 2021-12-13 at 13.45.01.png > > > The Apache Camel project has the following snippet in their root POM: > {code:xml} > > org.codehaus.mojo > flatten-maven-plugin > 1.2.5 > > > default-cli > process-resources > > flatten > > > > > > expand > > > > > > > {code} > With Maven 4's "Build Consumer" feature enabled, parsing this plugin > definition breaks with > {code:none} > [INFO] BuildTimeEventSpy is registered. > [INFO] Scanning for projects... > [ERROR] [ERROR] Some problems were encountered while processing the POMs: > [FATAL] Unable to transform pom > [ERROR] The build could not read 1 project -> [Help 1] > [ERROR] > [ERROR] The project (/Users/maarten/Code/open-source/camel/pom.xml) has 1 > error > [ERROR] Unable to transform pom: Not a regular file: > /Users/maarten/Code/open-source/pom.xml > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the '-e' > switch > [ERROR] Re-run Maven using the '-X' switch to enable verbose output > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException > {code} > I suspect that the {{}} tag is the culprit. It seems to me that it > causes the {{ParentXMLFilter}} to think it needs to do its work. The attached > screenshot shows the stacktrace that brought me to this idea. As the > {{BufferingParser}} class processes its buffer of events, it encounters a > situation of an "end {{parent}} tag". But that {{parent}} tag did not have > child elements {{version}} and {{relativePath}} and so, it decides it needs > to resolve the parent as {{../pom.xml}} against the project path > ({{/Users/maarten/Code/open-source/camel/}} in my case), leading to the > non-existing path of {{/Users/maarten/Code/open-source/pom.xml}}. > I think the bug here is not that it resolves to a non-existing path (it's > good to check that before actually reading the file). I think the bug is that > the {{ParentXMLFilter}} is acting on the {{parent}} tag inside the plugin > configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSITE-901) If preceding standalone report has been run, site:jar does not reinvoke site:site
[ https://issues.apache.org/jira/browse/MSITE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538666#comment-17538666 ] Hudson commented on MSITE-901: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-site-plugin » master #29 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site-plugin/job/master/29/ > If preceding standalone report has been run, site:jar does not reinvoke > site:site > - > > Key: MSITE-901 > URL: https://issues.apache.org/jira/browse/MSITE-901 > Project: Maven Site Plugin > Issue Type: Bug > Components: site:jar >Affects Versions: 3.12.0, 4.0.0-M1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0-M2, 3.12.1 > > > When {{site:jar}} is run or bound to a phase and a prior report to a earlier > lifecycle binding has been generated, e.g., {{pmd:check}}, the output > directory will be generated by PMD and {{site:jar}} Java code sees that the > dir is there and will never generate the site. Thus, the JAR will be empty. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7360) Can't parse project that has tag in plugin configuration
[ https://issues.apache.org/jira/browse/MNG-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538671#comment-17538671 ] ASF GitHub Bot commented on MNG-7360: - mthmulders commented on code in PR #744: URL: https://github.com/apache/maven/pull/744#discussion_r875647056 ## maven-model-transform/src/test/java/org/apache/maven/model/transform/ParentXMLFilterTest.java: ## @@ -33,30 +33,55 @@ public class ParentXMLFilterTest extends AbstractXMLFilterTests { -private Function filterCreator; +private Function filterCreator; @BeforeEach void reset() { filterCreator = null; } @Override -protected ParentXMLFilter getFilter( XmlPullParser parser ) +protected XmlPullParser getFilter( XmlPullParser parser ) { -Function filterCreator = +Function filterCreator = (this.filterCreator != null ? this.filterCreator : this::createFilter); return filterCreator.apply(parser); } -protected ParentXMLFilter createFilter( XmlPullParser parser ) { +protected XmlPullParser createFilter( XmlPullParser parser ) { return createFilter( parser, x -> Optional.of(new RelativeProject("GROUPID", "ARTIFACTID", "1.0.0")), Paths.get( "pom.xml").toAbsolutePath() ); } -protected ParentXMLFilter createFilter( XmlPullParser parser, Function> pathMapper, Path projectPath ) { +protected XmlPullParser createFilter( XmlPullParser parser, Function> pathMapper, Path projectPath ) { ParentXMLFilter filter = new ParentXMLFilter( parser, pathMapper, projectPath ); -return filter; +return new FastForwardFilter( filter ); +} + +@Test +public void testWithFastForward() Review Comment: Just to check: would it make sense to also add a test for the opposite case, i.e. where the ParentXMLFilter is _not_ supposed to bypass other filters? ## maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/BufferingParser.java: ## @@ -430,7 +430,7 @@ public int nextToken() throws XmlPullParserException, IOException throw new XmlPullParserException( "already reached end of XML input", this, null ); } int currentEvent = xmlPullParser.nextToken(); -if ( accept() ) +if ( disabled || accept() ) Review Comment: I like `bypass` - and I'd like it even more if the variable name would be in the same terminology as the class Javadoc. So maybe we should rephrase the Javadoc a bit and say something like "This filter will bypass all following filters and write directly to the output." > Can't parse project that has tag in plugin configuration > - > > Key: MNG-7360 > URL: https://issues.apache.org/jira/browse/MNG-7360 > Project: Maven > Issue Type: Bug > Components: build/consumer >Affects Versions: 4.0.x-candidate > Environment: Apache Maven 4.0.0-alpha-1-SNAPSHOT > (3a06530dbce82e2054afa3cc4c81631910474bd0) > Maven home: > /usr/local/Cellar/maven-snapshot/4.0.0-alpha-1-SNAPSHOT_290/libexec > Java version: 17.0.1, vendor: Eclipse Adoptium, runtime: > /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" >Reporter: Maarten Mulders >Assignee: Guillaume Nodet >Priority: Major > Attachments: Screenshot 2021-12-13 at 13.45.01.png > > > The Apache Camel project has the following snippet in their root POM: > {code:xml} > > org.codehaus.mojo > flatten-maven-plugin > 1.2.5 > > > default-cli > process-resources > > flatten > > > > > > expand > > > > > > > {code} > With Maven 4's "Build Consumer" feature enabled, parsing this plugin > definition breaks with > {code:none} > [INFO] BuildTimeEventSpy is registered. > [INFO] Scanning for projects... > [ERROR] [ERROR] Some problems were encountered while processing the POMs: > [FATAL] Unable to transform pom > [ERROR] The build could not read 1 project -> [Help 1] > [ERROR] > [ERROR] The project (/Users/maarten/Code/ope
[GitHub] [maven] mthmulders commented on a diff in pull request #744: [MNG-7360] Fix xml transformation to ensure proper context
mthmulders commented on code in PR #744: URL: https://github.com/apache/maven/pull/744#discussion_r875647056 ## maven-model-transform/src/test/java/org/apache/maven/model/transform/ParentXMLFilterTest.java: ## @@ -33,30 +33,55 @@ public class ParentXMLFilterTest extends AbstractXMLFilterTests { -private Function filterCreator; +private Function filterCreator; @BeforeEach void reset() { filterCreator = null; } @Override -protected ParentXMLFilter getFilter( XmlPullParser parser ) +protected XmlPullParser getFilter( XmlPullParser parser ) { -Function filterCreator = +Function filterCreator = (this.filterCreator != null ? this.filterCreator : this::createFilter); return filterCreator.apply(parser); } -protected ParentXMLFilter createFilter( XmlPullParser parser ) { +protected XmlPullParser createFilter( XmlPullParser parser ) { return createFilter( parser, x -> Optional.of(new RelativeProject("GROUPID", "ARTIFACTID", "1.0.0")), Paths.get( "pom.xml").toAbsolutePath() ); } -protected ParentXMLFilter createFilter( XmlPullParser parser, Function> pathMapper, Path projectPath ) { +protected XmlPullParser createFilter( XmlPullParser parser, Function> pathMapper, Path projectPath ) { ParentXMLFilter filter = new ParentXMLFilter( parser, pathMapper, projectPath ); -return filter; +return new FastForwardFilter( filter ); +} + +@Test +public void testWithFastForward() Review Comment: Just to check: would it make sense to also add a test for the opposite case, i.e. where the ParentXMLFilter is _not_ supposed to bypass other filters? ## maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/BufferingParser.java: ## @@ -430,7 +430,7 @@ public int nextToken() throws XmlPullParserException, IOException throw new XmlPullParserException( "already reached end of XML input", this, null ); } int currentEvent = xmlPullParser.nextToken(); -if ( accept() ) +if ( disabled || accept() ) Review Comment: I like `bypass` - and I'd like it even more if the variable name would be in the same terminology as the class Javadoc. So maybe we should rephrase the Javadoc a bit and say something like "This filter will bypass all following filters and write directly to the output." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] pzygielo commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
pzygielo commented on PR #134: URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1129760619 May I ask to have it finalized, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-976) [GITEXE] Changelog does not work in current versions of git.
[ https://issues.apache.org/jira/browse/SCM-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538675#comment-17538675 ] ASF GitHub Bot commented on SCM-976: pzygielo commented on PR #134: URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1129760619 May I ask to have it finalized, please? > [GITEXE] Changelog does not work in current versions of git. > > > Key: SCM-976 > URL: https://issues.apache.org/jira/browse/SCM-976 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-gitexe >Affects Versions: 2.0.0-M1 >Reporter: Niels Basjes >Priority: Major > > Since a long time the headers for the output of "git whatchanged" have been > changed, as a consequence there is no more output from this command. > The reason is that the output of this command used to be something like this: > {code} > commit 2d22f2da71ef279c4759b1c09cdb8282b63f0cf6 > Author: Mark Struberg > Date: 2007-11-24 01:10:06 +0100 > {code} > yet currently it looks like this: > {code} > commit 4fc34cfa14f2e72506187b03a492ce55ed459d4c (HEAD -> master, > origin/master, origin/HEAD) > Author: Michael Osipov > AuthorDate: 2022-01-08 21:02:12 +0100 > Commit: Michael Osipov > CommitDate: 2022-01-08 21:02:12 +0100 > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MASSEMBLY-957) Deprecate the repository element in assembly decriptor
Tamás Cservenák created MASSEMBLY-957: - Summary: Deprecate the repository element in assembly decriptor Key: MASSEMBLY-957 URL: https://issues.apache.org/jira/browse/MASSEMBLY-957 Project: Maven Assembly Plugin Issue Type: Task Affects Versions: 3.0.0 Reporter: Tamás Cservenák The {{repository}} element in assembly descriptor is present since 1.0 of m-assembly-p, so it comes from Maven 2.0 times. The intent of this element is aligned with Maven 2.0 in a way, that Maven "local repository" and "remote repository" were same (plus some metadata needed for remote). This is NOT true since Maven 3.0, local repository is NOT transportable (this is since "enhanced" local repository implementation in Aether/Maven-Resolver). Simply put, "transporting" local repository from workstation to workstation is NOT JUST tarring up your local repository and un-tarring on target computer (this WAS like it with Maven2). As mentioned, this element documentation is vague and unclear what it does: creates "local" repository? Creates "remote" repository? Both? Also, since 3.0.0 of m-assembly-p it introduces bug and wrong behaviour: it (mis) uses Aether local repository to create something that may be assumed is a remote repository, and while doing that, introduces issues like MASSEMBLY-870 and MASSEMBLY-874 and alike (as in a moment local repo is redefined to that _tmp directory, Aether MUST re-download everything, despite all is present in your "real" local repository). We MAY introduce new element that buys out this deprecated element, like {{remoteRepository}} that would be clearly documented it creates Maven 3 remote repository, while adding element like {{localRepository}} may be just overkill, as explained above, Maven 3 local repositories are NOT transportable. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-ear-plugin] dependabot[bot] opened a new pull request, #54: Bump plexus-utils from 3.3.0 to 3.4.2
dependabot[bot] opened a new pull request, #54: URL: https://github.com/apache/maven-ear-plugin/pull/54 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.3.0 to 3.4.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexus-utils's releases. 3.4.2 🚀 New features and improvements Provides a CachingOuptutStream and a CachingWriter (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/184";>#184) https://github.com/gnodet";>@gnodet Use (already) precalculated value (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/186";>#186) https://github.com/pzygielo";>@pzygielo use github shared actions (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/171";>#171) https://github.com/olamy";>@olamy 🐛 Bug Fixes MXParser fixes (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/185";>#185) https://github.com/gnodet";>@gnodet Fix last modified time not being updated on linux (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/203";>#203) https://github.com/gnodet";>@gnodet Fix regression and deprecate: FileUtils.fileAppend should create file… (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/200";>#200) https://github.com/slachiewicz";>@slachiewicz Fix some testing XML files checkout with incorrect eol (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/198";>#198) https://github.com/belingueres";>@belingueres Fixed regressions: https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163 and https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/194";>#194 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/195";>#195) https://github.com/belingueres";>@belingueres Don't ignore valid SCM files (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/174";>#174) https://github.com/michael-o";>@michael-o 📦 Dependency updates Bump github/codeql-action from 1 to 2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/202";>#202) https://github.com/dependabot";>@dependabot Bump actions/checkout from 3.0.1 to 3.0.2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/199";>#199) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.18.1 to 5.19.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/188";>#188) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/189";>#189) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/190";>#190) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.4.0 to 3.0.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/197";>#197) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/175";>#175) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.18.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/183";>#183) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.3.4 to 2.4.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/173";>#173) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/170";>#170) https://github.com/dependabot";>@dependabot 3.4.1 🐛 Bug Fixes Fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163: Regression: encoding error when parsing a ISO-8859-1 xml (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/164";>#164) https://github.com/belingueres";>@belingueres 📦 Dependency updates Bump actions/setup-java from 2.2.0 to 2.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/168";>#168) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.32 to 1.33 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/166";>#166) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.32 to 1.33 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/165";>#1
[GitHub] [maven-ear-plugin] dependabot[bot] commented on pull request #47: Bump plexus-utils from 3.3.0 to 3.4.1
dependabot[bot] commented on PR #47: URL: https://github.com/apache/maven-ear-plugin/pull/47#issuecomment-1129769975 Superseded by #54. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] dependabot[bot] closed pull request #47: Bump plexus-utils from 3.3.0 to 3.4.1
dependabot[bot] closed pull request #47: Bump plexus-utils from 3.3.0 to 3.4.1 URL: https://github.com/apache/maven-ear-plugin/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-976) [GITEXE] Changelog does not work in current versions of git.
[ https://issues.apache.org/jira/browse/SCM-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538679#comment-17538679 ] ASF GitHub Bot commented on SCM-976: slawekjaranowski commented on PR #134: URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1129775516 @nielsbasjes build was failed, please rebase with current basecode, we will can see the result of build > [GITEXE] Changelog does not work in current versions of git. > > > Key: SCM-976 > URL: https://issues.apache.org/jira/browse/SCM-976 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-gitexe >Affects Versions: 2.0.0-M1 >Reporter: Niels Basjes >Priority: Major > > Since a long time the headers for the output of "git whatchanged" have been > changed, as a consequence there is no more output from this command. > The reason is that the output of this command used to be something like this: > {code} > commit 2d22f2da71ef279c4759b1c09cdb8282b63f0cf6 > Author: Mark Struberg > Date: 2007-11-24 01:10:06 +0100 > {code} > yet currently it looks like this: > {code} > commit 4fc34cfa14f2e72506187b03a492ce55ed459d4c (HEAD -> master, > origin/master, origin/HEAD) > Author: Michael Osipov > AuthorDate: 2022-01-08 21:02:12 +0100 > Commit: Michael Osipov > CommitDate: 2022-01-08 21:02:12 +0100 > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-scm] slawekjaranowski commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
slawekjaranowski commented on PR #134: URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1129775516 @nielsbasjes build was failed, please rebase with current basecode, we will can see the result of build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slawekjaranowski closed pull request #74: Bump maven-plugins from 34 to 36
slawekjaranowski closed pull request #74: Bump maven-plugins from 34 to 36 URL: https://github.com/apache/maven-checkstyle-plugin/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] dependabot[bot] commented on pull request #74: Bump maven-plugins from 34 to 36
dependabot[bot] commented on PR #74: URL: https://github.com/apache/maven-checkstyle-plugin/pull/74#issuecomment-112986 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] cstamas opened a new pull request, #64: [MASSEMBLY-957] Deprecate repository element
cstamas opened a new pull request, #64: URL: https://github.com/apache/maven-assembly-plugin/pull/64 We have to deprecate ancient repository element in descriptor, as it was done for Maven 2.0 (present since 1.0 version of this plugin), but since Maven 3.0 things changed quite a lot. --- https://issues.apache.org/jira/browse/MASSEMBLY-957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slawekjaranowski commented on a diff in pull request #78: [MCHECKSTYLE-414] - documentation: property expansion example does not parse
slawekjaranowski commented on code in PR #78: URL: https://github.com/apache/maven-checkstyle-plugin/pull/78#discussion_r875735079 ## src/site/apt/examples/custom-property-expansion.apt.vm: ## @@ -68,7 +68,10 @@ Using Custom Checkstyle Property Expansion Definitions ${project.version} checkstyle.xml - projectname=whizbang + +projectname=whizbang +anotherProperty=bazinga + Review Comment: oh, this parameter should have `Map` type instead `String` ... but it is another story 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slawekjaranowski commented on a diff in pull request #78: [MCHECKSTYLE-414] - documentation: property expansion example does not parse
slawekjaranowski commented on code in PR #78: URL: https://github.com/apache/maven-checkstyle-plugin/pull/78#discussion_r875735079 ## src/site/apt/examples/custom-property-expansion.apt.vm: ## @@ -68,7 +68,10 @@ Using Custom Checkstyle Property Expansion Definitions ${project.version} checkstyle.xml - projectname=whizbang + +projectname=whizbang +anotherProperty=bazinga + Review Comment: oh, this parameter should has `Map` type instead `String` ... but it is another story 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slawekjaranowski merged pull request #78: [MCHECKSTYLE-414] - documentation: property expansion example does not parse
slawekjaranowski merged PR #78: URL: https://github.com/apache/maven-checkstyle-plugin/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MCHECKSTYLE-414) documentation: property expansion example does not parse
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MCHECKSTYLE-414. --- Fix Version/s: 3.2.0 Resolution: Fixed > documentation: property expansion example does not parse > > > Key: MCHECKSTYLE-414 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-414 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Reporter: Pearce Merritt >Assignee: Slawomir Jaranowski >Priority: Trivial > Fix For: 3.2.0 > > > this doc page has a typo in a code example ("propertesLocation" instead of > "propert{+}*i*{+}esLocation") -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (MCHECKSTYLE-414) documentation: property expansion example does not parse
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MCHECKSTYLE-414: --- Assignee: Slawomir Jaranowski > documentation: property expansion example does not parse > > > Key: MCHECKSTYLE-414 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-414 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Reporter: Pearce Merritt >Assignee: Slawomir Jaranowski >Priority: Trivial > > this doc page has a typo in a code example ("propertesLocation" instead of > "propert{+}*i*{+}esLocation") -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MCHECKSTYLE-414) documentation: property expansion example does not parse
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538726#comment-17538726 ] Hudson commented on MCHECKSTYLE-414: Build succeeded in Jenkins: Maven » Maven TLP » maven-checkstyle-plugin » master #11 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-checkstyle-plugin/job/master/11/ > documentation: property expansion example does not parse > > > Key: MCHECKSTYLE-414 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-414 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Reporter: Pearce Merritt >Assignee: Slawomir Jaranowski >Priority: Trivial > Fix For: 3.2.0 > > > this doc page has a typo in a code example ("propertesLocation" instead of > "propert{+}*i*{+}esLocation") -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MPMD-299) Change of default skipEmptyReport value breaks site:jar
[ https://issues.apache.org/jira/browse/MPMD-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPMD-299. --- Resolution: Information Provided Root cause has been fixed in MSITE. > Change of default skipEmptyReport value breaks site:jar > --- > > Key: MPMD-299 > URL: https://issues.apache.org/jira/browse/MPMD-299 > Project: Maven PMD Plugin > Issue Type: Bug > Components: CPD, PMD >Affects Versions: 3.13.0 >Reporter: Matt Nelson >Assignee: Michael Osipov >Priority: Major > Attachments: build.log > > Time Spent: 10m > Remaining Estimate: 0h > > Change of default skipEmptyReport value in MPMD-225 causes > [site:jar|https://maven.apache.org/plugins/maven-site-plugin/jar-mojo.html] > to be empty. > Had to revert to the value to get site jars working again. > {code:xml} > > org.apache.maven.plugins > maven-pmd-plugin > 3.13.0 > > true > > > {code} > Working on getting a repro case against > https://github.com/apache/maven-pmd-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-help-plugin] peterschrammel commented on pull request #46: Bump xstream from 1.4.18 to 1.4.19
peterschrammel commented on PR #46: URL: https://github.com/apache/maven-help-plugin/pull/46#issuecomment-1129885158 Would be great to merge this and get a new release out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request, #70: Bump mavenVersion from 3.2.5 to 3.8.5
dependabot[bot] opened a new pull request, #70: URL: https://github.com/apache/maven-pmd-plugin/pull/70 Bumps `mavenVersion` from 3.2.5 to 3.8.5. Updates `maven-core` from 3.2.5 to 3.8.5 Release notes Sourced from https://github.com/apache/maven/releases";>maven-core's releases. 3.8.5 What's Changed [3.8.x][MNG-7156][MNG-7285] Add locking in MojoExecutor by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/628";>apache/maven#628 [MNG-6326] Make the build fail if core extensions can not be loaded by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/648";>apache/maven#648 [3.8.x][MNG-7347] SessionScoped beans should be singletons for a given session by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/653";>apache/maven#653 [3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/656";>apache/maven#656 [3.8.x][MNG-7349] Limit relocation warning message to direct dependencies only by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/657";>apache/maven#657 [3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/670";>apache/maven#670 [3.8.x][MNG-7395] - Support system-properties in extension.xml by https://github.com/laeubi";>@laeubi in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 New Contributors https://github.com/laeubi";>@laeubi made their first contribution in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 Full Changelog: https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5";>https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5 3.8.4 What's Changed [MNG-6302] logging the module count by https://github.com/rmannibucau";>@rmannibucau in https://github-redirect.dependabot.com/apache/maven/pull/136";>apache/maven#136 [MNG-6424] - Upgrade plexus-interpolation to 1.25 by https://github.com/shemic87";>@shemic87 in https://github-redirect.dependabot.com/apache/maven/pull/172";>apache/maven#172 Update Jenkins build to use Maven 3.5.4 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/179";>apache/maven#179 [MNG-6473] Update Mockito to 2.21.0 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/181";>apache/maven#181 MNG-6414 Add more Apache license headers to skip downloading license … by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/167";>apache/maven#167 [MNG-6479] Upgrade XMLUnit to 2.2.1 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/183";>apache/maven#183 Fixed typo in exception logging by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/170";>apache/maven#170 [MNG-6490] Maven fails reporting circular dependency when the depende… by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/188";>apache/maven#188 [MNG-6261] - using java File api to compare by https://github.com/fabcipriano";>@fabcipriano in https://github-redirect.dependabot.com/apache/maven/pull/192";>apache/maven#192 MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependencies() by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/193";>apache/maven#193 [MNG-6559] Fix mailing list URL by https://github.com/johnlinp";>@johnlinp in https://github-redirect.dependabot.com/apache/maven/pull/230";>apache/maven#230 [MNG-6611] Update animal-sniffer-maven-plugin to version 1.17 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/237";>apache/maven#237 [MNG-6405] Fix basedir in MavenProject.deepCopy by https://github.com/jglick";>@jglick in https://github-redirect.dependabot.com/apache/maven/pull/225";>apache/maven#225 [MNG-6655] Add support for "release" qualifier by https://github.com/michael-o";>@michael-o in https://github-redirect.dependabot.com/apache/maven/pull/249";>apache/maven#249 Always deploy snapshot from master by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/250";>apache/maven#250 [MNG-6665] toolchain.xml file should support environment variables by https://github.com/MartinKanters";>@MartinKanters in https://github-
[GitHub] [maven-help-plugin] slachiewicz merged pull request #46: Bump xstream from 1.4.18 to 1.4.19
slachiewicz merged PR #46: URL: https://github.com/apache/maven-help-plugin/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slachiewicz merged pull request #56: Bump maven-javadoc-plugin from 3.3.1 to 3.4.0
slachiewicz merged PR #56: URL: https://github.com/apache/maven-help-plugin/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slachiewicz merged pull request #55: Bump maven-site-plugin from 3.10.0 to 3.12.0
slachiewicz merged PR #55: URL: https://github.com/apache/maven-help-plugin/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slachiewicz merged pull request #54: Bump maven-model from 3.8.4 to 3.8.5
slachiewicz merged PR #54: URL: https://github.com/apache/maven-help-plugin/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slachiewicz merged pull request #44: Bump mavenPluginToolsVersion from 3.6.2 to 3.6.4
slachiewicz merged PR #44: URL: https://github.com/apache/maven-help-plugin/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slachiewicz merged pull request #49: Bump maven-reporting-exec from 1.5.1 to 1.6.0
slachiewicz merged PR #49: URL: https://github.com/apache/maven-help-plugin/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slachiewicz merged pull request #51: Bump modello-maven-plugin from 1.11 to 2.0.0
slachiewicz merged PR #51: URL: https://github.com/apache/maven-help-plugin/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slachiewicz commented on pull request #47: Bump maven-reporting-api from 3.0 to 3.1.0
slachiewicz commented on PR #47: URL: https://github.com/apache/maven-help-plugin/pull/47#issuecomment-1129896424 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #60: Bump mavenVersion from 3.1.1 to 3.8.5
dependabot[bot] opened a new pull request, #60: URL: https://github.com/apache/maven-help-plugin/pull/60 Bumps `mavenVersion` from 3.1.1 to 3.8.5. Updates `maven-artifact` from 3.1.1 to 3.8.5 Release notes Sourced from https://github.com/apache/maven/releases";>maven-artifact's releases. 3.8.5 What's Changed [3.8.x][MNG-7156][MNG-7285] Add locking in MojoExecutor by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/628";>apache/maven#628 [MNG-6326] Make the build fail if core extensions can not be loaded by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/648";>apache/maven#648 [3.8.x][MNG-7347] SessionScoped beans should be singletons for a given session by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/653";>apache/maven#653 [3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/656";>apache/maven#656 [3.8.x][MNG-7349] Limit relocation warning message to direct dependencies only by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/657";>apache/maven#657 [3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/670";>apache/maven#670 [3.8.x][MNG-7395] - Support system-properties in extension.xml by https://github.com/laeubi";>@laeubi in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 New Contributors https://github.com/laeubi";>@laeubi made their first contribution in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 Full Changelog: https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5";>https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5 3.8.4 What's Changed [MNG-6302] logging the module count by https://github.com/rmannibucau";>@rmannibucau in https://github-redirect.dependabot.com/apache/maven/pull/136";>apache/maven#136 [MNG-6424] - Upgrade plexus-interpolation to 1.25 by https://github.com/shemic87";>@shemic87 in https://github-redirect.dependabot.com/apache/maven/pull/172";>apache/maven#172 Update Jenkins build to use Maven 3.5.4 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/179";>apache/maven#179 [MNG-6473] Update Mockito to 2.21.0 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/181";>apache/maven#181 MNG-6414 Add more Apache license headers to skip downloading license … by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/167";>apache/maven#167 [MNG-6479] Upgrade XMLUnit to 2.2.1 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/183";>apache/maven#183 Fixed typo in exception logging by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/170";>apache/maven#170 [MNG-6490] Maven fails reporting circular dependency when the depende… by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/188";>apache/maven#188 [MNG-6261] - using java File api to compare by https://github.com/fabcipriano";>@fabcipriano in https://github-redirect.dependabot.com/apache/maven/pull/192";>apache/maven#192 MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependencies() by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/193";>apache/maven#193 [MNG-6559] Fix mailing list URL by https://github.com/johnlinp";>@johnlinp in https://github-redirect.dependabot.com/apache/maven/pull/230";>apache/maven#230 [MNG-6611] Update animal-sniffer-maven-plugin to version 1.17 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/237";>apache/maven#237 [MNG-6405] Fix basedir in MavenProject.deepCopy by https://github.com/jglick";>@jglick in https://github-redirect.dependabot.com/apache/maven/pull/225";>apache/maven#225 [MNG-6655] Add support for "release" qualifier by https://github.com/michael-o";>@michael-o in https://github-redirect.dependabot.com/apache/maven/pull/249";>apache/maven#249 Always deploy snapshot from master by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/250";>apache/maven#250 [MNG-6665] toolchain.xml file should support environment variables by https://github.com/MartinKanters";>@MartinKanters in https:
[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #61: Bump asm from 9.2 to 9.3
dependabot[bot] opened a new pull request, #61: URL: https://github.com/apache/maven-help-plugin/pull/61 Bumps asm from 9.2 to 9.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #62: Bump maven-plugins from 34 to 36
dependabot[bot] opened a new pull request, #62: URL: https://github.com/apache/maven-help-plugin/pull/62 Bumps [maven-plugins](https://github.com/apache/maven-parent) from 34 to 36. Release notes Sourced from https://github.com/apache/maven-parent/releases";>maven-plugins's releases. 36 What's Changed [MPOM-300] switch from GA to ASF Matomo. by https://github.com/bmarwell";>@bmarwell in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 [MPOM-308] Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/59";>apache/maven-parent#59 Bump taglist-maven-plugin from 2.4 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/45";>apache/maven-parent#45 Bump maven-jxr-plugin from 3.1.1 to 3.2.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/60";>apache/maven-parent#60 [MPOM-313] execute checkstyle in early phase of the build by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 [MPOM-314] Upgrade modello-maven-plugin from 1.11 to 2.0.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/61";>apache/maven-parent#61 Bump apache from 25 to 26 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/62";>apache/maven-parent#62 New Contributors https://github.com/bmarwell";>@bmarwell made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 https://github.com/olamy";>@olamy made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 Full Changelog: https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36";>https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36 35 What's Changed docs: remove out of date comment by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-parent/pull/8";>apache/maven-parent#8 [MPOM-252] remove broken mail list archives by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-parent/pull/18";>apache/maven-parent#18 Bump plexus-utils from 3.1.0 to 3.3.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/13";>apache/maven-parent#13 Bump maven-toolchains-plugin from 1.1 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/10";>apache/maven-parent#10 Bump plexus-container-default from 1.0-alpha-30 to 2.1.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/11";>apache/maven-parent#11 Bump plexus-component-annotations from 2.0.0 to 2.1.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/15";>apache/maven-parent#15 Bump mavenPluginToolsVersion from 3.5.2 to 3.6.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/16";>apache/maven-parent#16 Bump modello-maven-plugin from 1.9.1 to 1.11 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/12";>apache/maven-parent#12 Bump maven-jxr-plugin from 2.5 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/9";>apache/maven-parent#9 Bump maven-pmd-plugin from 3.8 to 3.13.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/17";>apache/maven-parent#17 Bump maven-pmd-plugin from 3.14.0 to 3.15.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/28";>apache/maven-parent#28 [MPOM-268] - Removed unused property by https://github.com/khmarbaise";>@khmarbaise in https://github-redirect.dependabot.com/apache/maven-parent/pull/29";>apache/maven-parent#29 Bump mavenPluginToolsVersion from 3.6.0 to 3.6.1 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/25";>apache/maven-parent#25 [MPOM-270] Fix enforcer plugin by https://github.com/cstamas";>@cstamas in https://github-redirect.dependabot.com/apache/maven-parent/pull/32";>apache/maven-parent#32 [MPOM-271] Add "drop legacy dependencies" profile by https://github.com/cstamas";>@cstamas in h
[GitHub] [maven-help-plugin] dependabot[bot] closed pull request #60: Bump mavenVersion from 3.1.1 to 3.8.5
dependabot[bot] closed pull request #60: Bump mavenVersion from 3.1.1 to 3.8.5 URL: https://github.com/apache/maven-help-plugin/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slachiewicz commented on pull request #60: Bump mavenVersion from 3.1.1 to 3.8.5
slachiewicz commented on PR #60: URL: https://github.com/apache/maven-help-plugin/pull/60#issuecomment-1129897708 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #60: Bump mavenVersion from 3.1.1 to 3.8.5
dependabot[bot] commented on PR #60: URL: https://github.com/apache/maven-help-plugin/pull/60#issuecomment-1129897748 OK, I won't notify you about version 3.x.x again, unless you re-open this PR or update to a 3.x.x release yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] bmarwell commented on pull request #23: [MWAR-453] Require Java 8
bmarwell commented on PR #23: URL: https://github.com/apache/maven-war-plugin/pull/23#issuecomment-1129908046 @dennisl can you drop the commit which merges master into this branch and do a rebase instead please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] bmarwell commented on a diff in pull request #23: [MWAR-453] Require Java 8
bmarwell commented on code in PR #23: URL: https://github.com/apache/maven-war-plugin/pull/23#discussion_r875796588 ## src/test/java/org/apache/maven/plugins/war/AbstractWarMojoTest.java: ## @@ -74,7 +74,7 @@ protected void configureMojo( AbstractWarMojo mojo, List filters, File c new DefaultMavenExecutionRequest().setSystemProperties( System.getProperties() ).setStartTime( new Date() ); MavenSession mavenSession = -new MavenSession( (PlexusContainer) null, (RepositorySystemSession) null, request, null ); +new MavenSession( null, null, request, null ); Review Comment: Are you sure this is a good idea? Imagine a new constructor came up with four other parameters. ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -149,7 +149,7 @@ public void testDefaultOverlays() assertOverlayedFile( webAppDirectory, "overlay-two", "admin.jsp" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: That is not a Java 8 change. ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -111,7 +111,7 @@ public void testDefaultOverlay() assertOverlayedFile( webAppDirectory, "overlay-one", "login.jsp" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: That is not a Java 8 change. ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -362,7 +362,7 @@ public void testOverlaysIncludesExcludesWithMultipleDefinitions() assertOverlayedFile( webAppDirectory, "overlay-full-2", "WEB-INF/lib/c.jar" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: That is not a Java 8 change. ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -432,7 +432,7 @@ public void testOverlaysIncludesExcludesWithMultipleDefinitions2() assertOverlayedFile( webAppDirectory, "overlay-full-2", "WEB-INF/lib/c.jar" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: That is not a Java 8 change. ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -293,7 +293,7 @@ private void assertScenariOne( String testId, File webAppDirectory ) assertOverlayedFile( webAppDirectory, "overlay-full-1", "WEB-INF/lib/c.jar" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: That is not a Java 8 change. ## src/main/java/org/apache/maven/plugins/war/packaging/AbstractWarPackagingTask.java: ## @@ -342,14 +344,16 @@ protected boolean copyFile( WarPackagingContext context, File source, File desti { context.addResource( targetFilename ); -if ( onlyIfModified && destination.lastModified() >= source.lastModified() ) +BasicFileAttributes readAttributes = Files.readAttributes( source.toPath(), BasicFileAttributes.class ); +if ( onlyIfModified && destination.lastModified() >= readAttributes.lastModifiedTime() +.toMillis() ) Review Comment: What is the advantage to use another API here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pdf-plugin] dependabot[bot] opened a new pull request, #25: Bump plexus-utils from 3.4.1 to 3.4.2
dependabot[bot] opened a new pull request, #25: URL: https://github.com/apache/maven-pdf-plugin/pull/25 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.1 to 3.4.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexus-utils's releases. 3.4.2 🚀 New features and improvements Provides a CachingOuptutStream and a CachingWriter (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/184";>#184) https://github.com/gnodet";>@gnodet Use (already) precalculated value (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/186";>#186) https://github.com/pzygielo";>@pzygielo use github shared actions (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/171";>#171) https://github.com/olamy";>@olamy 🐛 Bug Fixes MXParser fixes (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/185";>#185) https://github.com/gnodet";>@gnodet Fix last modified time not being updated on linux (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/203";>#203) https://github.com/gnodet";>@gnodet Fix regression and deprecate: FileUtils.fileAppend should create file… (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/200";>#200) https://github.com/slachiewicz";>@slachiewicz Fix some testing XML files checkout with incorrect eol (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/198";>#198) https://github.com/belingueres";>@belingueres Fixed regressions: https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163 and https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/194";>#194 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/195";>#195) https://github.com/belingueres";>@belingueres Don't ignore valid SCM files (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/174";>#174) https://github.com/michael-o";>@michael-o 📦 Dependency updates Bump github/codeql-action from 1 to 2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/202";>#202) https://github.com/dependabot";>@dependabot Bump actions/checkout from 3.0.1 to 3.0.2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/199";>#199) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.18.1 to 5.19.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/188";>#188) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/189";>#189) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/190";>#190) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.4.0 to 3.0.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/197";>#197) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/175";>#175) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.18.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/183";>#183) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.3.4 to 2.4.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/173";>#173) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/170";>#170) https://github.com/dependabot";>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/01908b2979d4104a1e87f7e1eb0e157c9e1a3f8c";>01908b2 [maven-release-plugin] prepare release plexus-utils-3.4.2 https://github.com/codehaus-plexus/plexus-utils/commit/0d97c8ba8dfa4663e86c5827555f980fd47c27a9";>0d97c8b Fix endless loop caused by aborted subsequent PI or comment (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/124";>#124) https://github.com/codehaus-plexus/plexus-utils/commit/11c749d677176b5b04573a1acd37997ec61dcc05";>11c749d Fix endless loop with invalid PI containing XML (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/122";>#122) https://github.com/codehaus-plexus/plexus-utils/commit/2c6fe7e293425795835766319bff524ef47bb94a";>2c6fe7e Fix start position of PI and c
[GitHub] [maven-jxr] dependabot[bot] opened a new pull request, #56: Bump mavenVersion from 3.2.5 to 3.8.5
dependabot[bot] opened a new pull request, #56: URL: https://github.com/apache/maven-jxr/pull/56 Bumps `mavenVersion` from 3.2.5 to 3.8.5. Updates `maven-plugin-api` from 3.2.5 to 3.8.5 Release notes Sourced from https://github.com/apache/maven/releases";>maven-plugin-api's releases. 3.8.5 What's Changed [3.8.x][MNG-7156][MNG-7285] Add locking in MojoExecutor by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/628";>apache/maven#628 [MNG-6326] Make the build fail if core extensions can not be loaded by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/648";>apache/maven#648 [3.8.x][MNG-7347] SessionScoped beans should be singletons for a given session by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/653";>apache/maven#653 [3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/656";>apache/maven#656 [3.8.x][MNG-7349] Limit relocation warning message to direct dependencies only by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/657";>apache/maven#657 [3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/670";>apache/maven#670 [3.8.x][MNG-7395] - Support system-properties in extension.xml by https://github.com/laeubi";>@laeubi in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 New Contributors https://github.com/laeubi";>@laeubi made their first contribution in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 Full Changelog: https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5";>https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5 3.8.4 What's Changed [MNG-6302] logging the module count by https://github.com/rmannibucau";>@rmannibucau in https://github-redirect.dependabot.com/apache/maven/pull/136";>apache/maven#136 [MNG-6424] - Upgrade plexus-interpolation to 1.25 by https://github.com/shemic87";>@shemic87 in https://github-redirect.dependabot.com/apache/maven/pull/172";>apache/maven#172 Update Jenkins build to use Maven 3.5.4 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/179";>apache/maven#179 [MNG-6473] Update Mockito to 2.21.0 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/181";>apache/maven#181 MNG-6414 Add more Apache license headers to skip downloading license … by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/167";>apache/maven#167 [MNG-6479] Upgrade XMLUnit to 2.2.1 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/183";>apache/maven#183 Fixed typo in exception logging by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/170";>apache/maven#170 [MNG-6490] Maven fails reporting circular dependency when the depende… by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/188";>apache/maven#188 [MNG-6261] - using java File api to compare by https://github.com/fabcipriano";>@fabcipriano in https://github-redirect.dependabot.com/apache/maven/pull/192";>apache/maven#192 MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependencies() by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/193";>apache/maven#193 [MNG-6559] Fix mailing list URL by https://github.com/johnlinp";>@johnlinp in https://github-redirect.dependabot.com/apache/maven/pull/230";>apache/maven#230 [MNG-6611] Update animal-sniffer-maven-plugin to version 1.17 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/237";>apache/maven#237 [MNG-6405] Fix basedir in MavenProject.deepCopy by https://github.com/jglick";>@jglick in https://github-redirect.dependabot.com/apache/maven/pull/225";>apache/maven#225 [MNG-6655] Add support for "release" qualifier by https://github.com/michael-o";>@michael-o in https://github-redirect.dependabot.com/apache/maven/pull/249";>apache/maven#249 Always deploy snapshot from master by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/250";>apache/maven#250 [MNG-6665] toolchain.xml file should support environment variables by https://github.com/MartinKanters";>@MartinKanters in https://gi
[GitHub] [maven-jxr] dependabot[bot] opened a new pull request, #57: Bump plexus-utils from 3.4.1 to 3.4.2
dependabot[bot] opened a new pull request, #57: URL: https://github.com/apache/maven-jxr/pull/57 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.1 to 3.4.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexus-utils's releases. 3.4.2 🚀 New features and improvements Provides a CachingOuptutStream and a CachingWriter (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/184";>#184) https://github.com/gnodet";>@gnodet Use (already) precalculated value (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/186";>#186) https://github.com/pzygielo";>@pzygielo use github shared actions (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/171";>#171) https://github.com/olamy";>@olamy 🐛 Bug Fixes MXParser fixes (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/185";>#185) https://github.com/gnodet";>@gnodet Fix last modified time not being updated on linux (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/203";>#203) https://github.com/gnodet";>@gnodet Fix regression and deprecate: FileUtils.fileAppend should create file… (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/200";>#200) https://github.com/slachiewicz";>@slachiewicz Fix some testing XML files checkout with incorrect eol (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/198";>#198) https://github.com/belingueres";>@belingueres Fixed regressions: https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163 and https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/194";>#194 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/195";>#195) https://github.com/belingueres";>@belingueres Don't ignore valid SCM files (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/174";>#174) https://github.com/michael-o";>@michael-o 📦 Dependency updates Bump github/codeql-action from 1 to 2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/202";>#202) https://github.com/dependabot";>@dependabot Bump actions/checkout from 3.0.1 to 3.0.2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/199";>#199) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.18.1 to 5.19.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/188";>#188) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/189";>#189) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/190";>#190) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.4.0 to 3.0.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/197";>#197) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/175";>#175) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.18.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/183";>#183) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.3.4 to 2.4.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/173";>#173) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/170";>#170) https://github.com/dependabot";>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/01908b2979d4104a1e87f7e1eb0e157c9e1a3f8c";>01908b2 [maven-release-plugin] prepare release plexus-utils-3.4.2 https://github.com/codehaus-plexus/plexus-utils/commit/0d97c8ba8dfa4663e86c5827555f980fd47c27a9";>0d97c8b Fix endless loop caused by aborted subsequent PI or comment (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/124";>#124) https://github.com/codehaus-plexus/plexus-utils/commit/11c749d677176b5b04573a1acd37997ec61dcc05";>11c749d Fix endless loop with invalid PI containing XML (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/122";>#122) https://github.com/codehaus-plexus/plexus-utils/commit/2c6fe7e293425795835766319bff524ef47bb94a";>2c6fe7e Fix start position of PI and comment
[GitHub] [maven-antrun-plugin] dependabot[bot] opened a new pull request, #57: Bump plexus-utils from 3.4.1 to 3.4.2
dependabot[bot] opened a new pull request, #57: URL: https://github.com/apache/maven-antrun-plugin/pull/57 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.1 to 3.4.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexus-utils's releases. 3.4.2 🚀 New features and improvements Provides a CachingOuptutStream and a CachingWriter (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/184";>#184) https://github.com/gnodet";>@gnodet Use (already) precalculated value (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/186";>#186) https://github.com/pzygielo";>@pzygielo use github shared actions (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/171";>#171) https://github.com/olamy";>@olamy 🐛 Bug Fixes MXParser fixes (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/185";>#185) https://github.com/gnodet";>@gnodet Fix last modified time not being updated on linux (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/203";>#203) https://github.com/gnodet";>@gnodet Fix regression and deprecate: FileUtils.fileAppend should create file… (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/200";>#200) https://github.com/slachiewicz";>@slachiewicz Fix some testing XML files checkout with incorrect eol (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/198";>#198) https://github.com/belingueres";>@belingueres Fixed regressions: https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163 and https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/194";>#194 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/195";>#195) https://github.com/belingueres";>@belingueres Don't ignore valid SCM files (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/174";>#174) https://github.com/michael-o";>@michael-o 📦 Dependency updates Bump github/codeql-action from 1 to 2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/202";>#202) https://github.com/dependabot";>@dependabot Bump actions/checkout from 3.0.1 to 3.0.2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/199";>#199) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.18.1 to 5.19.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/188";>#188) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/189";>#189) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/190";>#190) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.4.0 to 3.0.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/197";>#197) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/175";>#175) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.18.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/183";>#183) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.3.4 to 2.4.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/173";>#173) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/170";>#170) https://github.com/dependabot";>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/01908b2979d4104a1e87f7e1eb0e157c9e1a3f8c";>01908b2 [maven-release-plugin] prepare release plexus-utils-3.4.2 https://github.com/codehaus-plexus/plexus-utils/commit/0d97c8ba8dfa4663e86c5827555f980fd47c27a9";>0d97c8b Fix endless loop caused by aborted subsequent PI or comment (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/124";>#124) https://github.com/codehaus-plexus/plexus-utils/commit/11c749d677176b5b04573a1acd37997ec61dcc05";>11c749d Fix endless loop with invalid PI containing XML (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/122";>#122) https://github.com/codehaus-plexus/plexus-utils/commit/2c6fe7e293425795835766319bff524ef47bb94a";>2c6fe7e Fix start position of PI an
[GitHub] [maven-jxr] slachiewicz commented on pull request #56: Bump mavenVersion from 3.2.5 to 3.8.5
slachiewicz commented on PR #56: URL: https://github.com/apache/maven-jxr/pull/56#issuecomment-112710 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] closed pull request #56: Bump mavenVersion from 3.2.5 to 3.8.5
dependabot[bot] closed pull request #56: Bump mavenVersion from 3.2.5 to 3.8.5 URL: https://github.com/apache/maven-jxr/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] commented on pull request #56: Bump mavenVersion from 3.2.5 to 3.8.5
dependabot[bot] commented on PR #56: URL: https://github.com/apache/maven-jxr/pull/56#issuecomment-112747 OK, I won't notify you about version 3.x.x again, unless you re-open this PR or update to a 3.x.x release yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pdf-plugin] slachiewicz merged pull request #25: Bump plexus-utils from 3.4.1 to 3.4.2
slachiewicz merged PR #25: URL: https://github.com/apache/maven-pdf-plugin/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request, #80: Bump mavenVersion from 3.2.5 to 3.8.5
dependabot[bot] opened a new pull request, #80: URL: https://github.com/apache/maven-plugin-tools/pull/80 Bumps `mavenVersion` from 3.2.5 to 3.8.5. Updates `maven-model` from 3.2.5 to 3.8.5 Release notes Sourced from https://github.com/apache/maven/releases";>maven-model's releases. 3.8.5 What's Changed [3.8.x][MNG-7156][MNG-7285] Add locking in MojoExecutor by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/628";>apache/maven#628 [MNG-6326] Make the build fail if core extensions can not be loaded by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/648";>apache/maven#648 [3.8.x][MNG-7347] SessionScoped beans should be singletons for a given session by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/653";>apache/maven#653 [3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/656";>apache/maven#656 [3.8.x][MNG-7349] Limit relocation warning message to direct dependencies only by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/657";>apache/maven#657 [3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/670";>apache/maven#670 [3.8.x][MNG-7395] - Support system-properties in extension.xml by https://github.com/laeubi";>@laeubi in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 New Contributors https://github.com/laeubi";>@laeubi made their first contribution in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 Full Changelog: https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5";>https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5 3.8.4 What's Changed [MNG-6302] logging the module count by https://github.com/rmannibucau";>@rmannibucau in https://github-redirect.dependabot.com/apache/maven/pull/136";>apache/maven#136 [MNG-6424] - Upgrade plexus-interpolation to 1.25 by https://github.com/shemic87";>@shemic87 in https://github-redirect.dependabot.com/apache/maven/pull/172";>apache/maven#172 Update Jenkins build to use Maven 3.5.4 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/179";>apache/maven#179 [MNG-6473] Update Mockito to 2.21.0 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/181";>apache/maven#181 MNG-6414 Add more Apache license headers to skip downloading license … by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/167";>apache/maven#167 [MNG-6479] Upgrade XMLUnit to 2.2.1 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/183";>apache/maven#183 Fixed typo in exception logging by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/170";>apache/maven#170 [MNG-6490] Maven fails reporting circular dependency when the depende… by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/188";>apache/maven#188 [MNG-6261] - using java File api to compare by https://github.com/fabcipriano";>@fabcipriano in https://github-redirect.dependabot.com/apache/maven/pull/192";>apache/maven#192 MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependencies() by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/193";>apache/maven#193 [MNG-6559] Fix mailing list URL by https://github.com/johnlinp";>@johnlinp in https://github-redirect.dependabot.com/apache/maven/pull/230";>apache/maven#230 [MNG-6611] Update animal-sniffer-maven-plugin to version 1.17 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/237";>apache/maven#237 [MNG-6405] Fix basedir in MavenProject.deepCopy by https://github.com/jglick";>@jglick in https://github-redirect.dependabot.com/apache/maven/pull/225";>apache/maven#225 [MNG-6655] Add support for "release" qualifier by https://github.com/michael-o";>@michael-o in https://github-redirect.dependabot.com/apache/maven/pull/249";>apache/maven#249 Always deploy snapshot from master by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/250";>apache/maven#250 [MNG-6665] toolchain.xml file should support environment variables by https://github.com/MartinKanters";>@MartinKanters in https://git
[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request, #81: Bump plexus-utils from 3.3.0 to 3.4.2
dependabot[bot] opened a new pull request, #81: URL: https://github.com/apache/maven-plugin-tools/pull/81 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.3.0 to 3.4.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexus-utils's releases. 3.4.2 🚀 New features and improvements Provides a CachingOuptutStream and a CachingWriter (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/184";>#184) https://github.com/gnodet";>@gnodet Use (already) precalculated value (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/186";>#186) https://github.com/pzygielo";>@pzygielo use github shared actions (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/171";>#171) https://github.com/olamy";>@olamy 🐛 Bug Fixes MXParser fixes (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/185";>#185) https://github.com/gnodet";>@gnodet Fix last modified time not being updated on linux (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/203";>#203) https://github.com/gnodet";>@gnodet Fix regression and deprecate: FileUtils.fileAppend should create file… (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/200";>#200) https://github.com/slachiewicz";>@slachiewicz Fix some testing XML files checkout with incorrect eol (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/198";>#198) https://github.com/belingueres";>@belingueres Fixed regressions: https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163 and https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/194";>#194 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/195";>#195) https://github.com/belingueres";>@belingueres Don't ignore valid SCM files (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/174";>#174) https://github.com/michael-o";>@michael-o 📦 Dependency updates Bump github/codeql-action from 1 to 2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/202";>#202) https://github.com/dependabot";>@dependabot Bump actions/checkout from 3.0.1 to 3.0.2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/199";>#199) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.18.1 to 5.19.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/188";>#188) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/189";>#189) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/190";>#190) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.4.0 to 3.0.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/197";>#197) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/175";>#175) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.18.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/183";>#183) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.3.4 to 2.4.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/173";>#173) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/170";>#170) https://github.com/dependabot";>@dependabot 3.4.1 🐛 Bug Fixes Fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163: Regression: encoding error when parsing a ISO-8859-1 xml (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/164";>#164) https://github.com/belingueres";>@belingueres 📦 Dependency updates Bump actions/setup-java from 2.2.0 to 2.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/168";>#168) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.32 to 1.33 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/166";>#166) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.32 to 1.33 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/165";>
[GitHub] [maven-plugin-tools] dependabot[bot] commented on pull request #63: Bump plexus-utils from 3.3.0 to 3.4.1
dependabot[bot] commented on PR #63: URL: https://github.com/apache/maven-plugin-tools/pull/63#issuecomment-1130017067 Superseded by #81. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] dependabot[bot] closed pull request #63: Bump plexus-utils from 3.3.0 to 3.4.1
dependabot[bot] closed pull request #63: Bump plexus-utils from 3.3.0 to 3.4.1 URL: https://github.com/apache/maven-plugin-tools/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] slachiewicz commented on a diff in pull request #23: [MWAR-453] Require Java 8
slachiewicz commented on code in PR #23: URL: https://github.com/apache/maven-war-plugin/pull/23#discussion_r875899182 ## src/main/java/org/apache/maven/plugins/war/packaging/AbstractWarPackagingTask.java: ## @@ -342,14 +344,16 @@ protected boolean copyFile( WarPackagingContext context, File source, File desti { context.addResource( targetFilename ); -if ( onlyIfModified && destination.lastModified() >= source.lastModified() ) +BasicFileAttributes readAttributes = Files.readAttributes( source.toPath(), BasicFileAttributes.class ); +if ( onlyIfModified && destination.lastModified() >= readAttributes.lastModifiedTime() +.toMillis() ) Review Comment: Imho we should migrate to NIO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] slachiewicz commented on a diff in pull request #23: [MWAR-453] Require Java 8
slachiewicz commented on code in PR #23: URL: https://github.com/apache/maven-war-plugin/pull/23#discussion_r875900238 ## src/test/java/org/apache/maven/plugins/war/AbstractWarMojoTest.java: ## @@ -74,7 +74,7 @@ protected void configureMojo( AbstractWarMojo mojo, List filters, File c new DefaultMavenExecutionRequest().setSystemProperties( System.getProperties() ).setStartTime( new Date() ); MavenSession mavenSession = -new MavenSession( (PlexusContainer) null, (RepositorySystemSession) null, request, null ); +new MavenSession( null, null, request, null ); Review Comment: Yes i can revert it. intellij suggested this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] slachiewicz commented on a diff in pull request #23: [MWAR-453] Require Java 8
slachiewicz commented on code in PR #23: URL: https://github.com/apache/maven-war-plugin/pull/23#discussion_r875900932 ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -111,7 +111,7 @@ public void testDefaultOverlay() assertOverlayedFile( webAppDirectory, "overlay-one", "login.jsp" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: To be reverted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] slachiewicz commented on a diff in pull request #23: [MWAR-453] Require Java 8
slachiewicz commented on code in PR #23: URL: https://github.com/apache/maven-war-plugin/pull/23#discussion_r875901156 ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -149,7 +149,7 @@ public void testDefaultOverlays() assertOverlayedFile( webAppDirectory, "overlay-two", "admin.jsp" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: To be reverted ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -293,7 +293,7 @@ private void assertScenariOne( String testId, File webAppDirectory ) assertOverlayedFile( webAppDirectory, "overlay-full-1", "WEB-INF/lib/c.jar" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] slachiewicz commented on a diff in pull request #23: [MWAR-453] Require Java 8
slachiewicz commented on code in PR #23: URL: https://github.com/apache/maven-war-plugin/pull/23#discussion_r875901528 ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -362,7 +362,7 @@ public void testOverlaysIncludesExcludesWithMultipleDefinitions() assertOverlayedFile( webAppDirectory, "overlay-full-2", "WEB-INF/lib/c.jar" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: Yes ## src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java: ## @@ -432,7 +432,7 @@ public void testOverlaysIncludesExcludesWithMultipleDefinitions2() assertOverlayedFile( webAppDirectory, "overlay-full-2", "WEB-INF/lib/c.jar" ); // Ok now check that there is no more files/directories -final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); +final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); Review Comment: Sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSKINS-189) Remove Piwik support
Konrad Windszus created MSKINS-189: -- Summary: Remove Piwik support Key: MSKINS-189 URL: https://issues.apache.org/jira/browse/MSKINS-189 Project: Maven Skins Issue Type: Improvement Components: Fluido Skin Affects Versions: fluido-1.11.0 Reporter: Konrad Windszus As Piwik is now named Matomo (with dedicated support added in MSKINS-177) the Piwik feature should be removed and no longer being mentioned in https://maven.apache.org/skins/maven-fluido-skin/#piwik-web-analytics. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-189) Remove Piwik support
[ https://issues.apache.org/jira/browse/MSKINS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated MSKINS-189: --- Description: As [Piwik is named Matomo since 2018|https://matomo.org/blog/2018/01/piwik-is-now-matomo/] (with dedicated support added in MSKINS-177) the Piwik feature should be removed and no longer being mentioned in https://maven.apache.org/skins/maven-fluido-skin/#piwik-web-analytics. (was: As Piwik is now named Matomo (with dedicated support added in MSKINS-177) the Piwik feature should be removed and no longer being mentioned in https://maven.apache.org/skins/maven-fluido-skin/#piwik-web-analytics.) > Remove Piwik support > > > Key: MSKINS-189 > URL: https://issues.apache.org/jira/browse/MSKINS-189 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.11.0 >Reporter: Konrad Windszus >Priority: Major > > As [Piwik is named Matomo since > 2018|https://matomo.org/blog/2018/01/piwik-is-now-matomo/] (with dedicated > support added in MSKINS-177) the Piwik feature should be removed and no > longer being mentioned in > https://maven.apache.org/skins/maven-fluido-skin/#piwik-web-analytics. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-plugin-tools] slachiewicz commented on pull request #81: Bump plexus-utils from 3.3.0 to 3.4.2
slachiewicz commented on PR #81: URL: https://github.com/apache/maven-plugin-tools/pull/81#issuecomment-1130073146 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] dependabot[bot] commented on pull request #81: Bump plexus-utils from 3.3.0 to 3.4.2
dependabot[bot] commented on PR #81: URL: https://github.com/apache/maven-plugin-tools/pull/81#issuecomment-1130073214 OK, I won't notify you about version 3.x.x again, unless you re-open this PR or update to a 3.x.x release yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] dependabot[bot] closed pull request #81: Bump plexus-utils from 3.3.0 to 3.4.2
dependabot[bot] closed pull request #81: Bump plexus-utils from 3.3.0 to 3.4.2 URL: https://github.com/apache/maven-plugin-tools/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] dependabot[bot] commented on pull request #80: Bump mavenVersion from 3.2.5 to 3.8.5
dependabot[bot] commented on PR #80: URL: https://github.com/apache/maven-plugin-tools/pull/80#issuecomment-1130073951 OK, I won't notify you about version 3.x.x again, unless you re-open this PR or update to a 3.x.x release yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] dependabot[bot] closed pull request #80: Bump mavenVersion from 3.2.5 to 3.8.5
dependabot[bot] closed pull request #80: Bump mavenVersion from 3.2.5 to 3.8.5 URL: https://github.com/apache/maven-plugin-tools/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] slachiewicz commented on pull request #77: Bump mockito-core from 2.28.2 to 4.5.1
slachiewicz commented on PR #77: URL: https://github.com/apache/maven-plugin-tools/pull/77#issuecomment-1130074187 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] dependabot[bot] commented on pull request #77: Bump mockito-core from 2.28.2 to 4.5.1
dependabot[bot] commented on PR #77: URL: https://github.com/apache/maven-plugin-tools/pull/77#issuecomment-1130074226 OK, I won't notify you about version 4.x.x again, unless you re-open this PR or update to a 4.x.x release yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] dependabot[bot] closed pull request #77: Bump mockito-core from 2.28.2 to 4.5.1
dependabot[bot] closed pull request #77: Bump mockito-core from 2.28.2 to 4.5.1 URL: https://github.com/apache/maven-plugin-tools/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] slachiewicz commented on pull request #80: Bump mavenVersion from 3.2.5 to 3.8.5
slachiewicz commented on PR #80: URL: https://github.com/apache/maven-plugin-tools/pull/80#issuecomment-1130073894 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #744: [MNG-7360] Fix xml transformation to ensure proper context
gnodet commented on code in PR #744: URL: https://github.com/apache/maven/pull/744#discussion_r875960387 ## maven-model-transform/src/test/java/org/apache/maven/model/transform/ParentXMLFilterTest.java: ## @@ -33,30 +33,55 @@ public class ParentXMLFilterTest extends AbstractXMLFilterTests { -private Function filterCreator; +private Function filterCreator; @BeforeEach void reset() { filterCreator = null; } @Override -protected ParentXMLFilter getFilter( XmlPullParser parser ) +protected XmlPullParser getFilter( XmlPullParser parser ) { -Function filterCreator = +Function filterCreator = (this.filterCreator != null ? this.filterCreator : this::createFilter); return filterCreator.apply(parser); } -protected ParentXMLFilter createFilter( XmlPullParser parser ) { +protected XmlPullParser createFilter( XmlPullParser parser ) { return createFilter( parser, x -> Optional.of(new RelativeProject("GROUPID", "ARTIFACTID", "1.0.0")), Paths.get( "pom.xml").toAbsolutePath() ); } -protected ParentXMLFilter createFilter( XmlPullParser parser, Function> pathMapper, Path projectPath ) { +protected XmlPullParser createFilter( XmlPullParser parser, Function> pathMapper, Path projectPath ) { ParentXMLFilter filter = new ParentXMLFilter( parser, pathMapper, projectPath ); -return filter; +return new FastForwardFilter( filter ); +} + +@Test +public void testWithFastForward() Review Comment: I've added a test with a bypass section and a section which should not be bypassed after. It was actually failing, so I had to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7360) Can't parse project that has tag in plugin configuration
[ https://issues.apache.org/jira/browse/MNG-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538869#comment-17538869 ] ASF GitHub Bot commented on MNG-7360: - gnodet commented on code in PR #744: URL: https://github.com/apache/maven/pull/744#discussion_r875960387 ## maven-model-transform/src/test/java/org/apache/maven/model/transform/ParentXMLFilterTest.java: ## @@ -33,30 +33,55 @@ public class ParentXMLFilterTest extends AbstractXMLFilterTests { -private Function filterCreator; +private Function filterCreator; @BeforeEach void reset() { filterCreator = null; } @Override -protected ParentXMLFilter getFilter( XmlPullParser parser ) +protected XmlPullParser getFilter( XmlPullParser parser ) { -Function filterCreator = +Function filterCreator = (this.filterCreator != null ? this.filterCreator : this::createFilter); return filterCreator.apply(parser); } -protected ParentXMLFilter createFilter( XmlPullParser parser ) { +protected XmlPullParser createFilter( XmlPullParser parser ) { return createFilter( parser, x -> Optional.of(new RelativeProject("GROUPID", "ARTIFACTID", "1.0.0")), Paths.get( "pom.xml").toAbsolutePath() ); } -protected ParentXMLFilter createFilter( XmlPullParser parser, Function> pathMapper, Path projectPath ) { +protected XmlPullParser createFilter( XmlPullParser parser, Function> pathMapper, Path projectPath ) { ParentXMLFilter filter = new ParentXMLFilter( parser, pathMapper, projectPath ); -return filter; +return new FastForwardFilter( filter ); +} + +@Test +public void testWithFastForward() Review Comment: I've added a test with a bypass section and a section which should not be bypassed after. It was actually failing, so I had to fix it. > Can't parse project that has tag in plugin configuration > - > > Key: MNG-7360 > URL: https://issues.apache.org/jira/browse/MNG-7360 > Project: Maven > Issue Type: Bug > Components: build/consumer >Affects Versions: 4.0.x-candidate > Environment: Apache Maven 4.0.0-alpha-1-SNAPSHOT > (3a06530dbce82e2054afa3cc4c81631910474bd0) > Maven home: > /usr/local/Cellar/maven-snapshot/4.0.0-alpha-1-SNAPSHOT_290/libexec > Java version: 17.0.1, vendor: Eclipse Adoptium, runtime: > /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" >Reporter: Maarten Mulders >Assignee: Guillaume Nodet >Priority: Major > Attachments: Screenshot 2021-12-13 at 13.45.01.png > > > The Apache Camel project has the following snippet in their root POM: > {code:xml} > > org.codehaus.mojo > flatten-maven-plugin > 1.2.5 > > > default-cli > process-resources > > flatten > > > > > > expand > > > > > > > {code} > With Maven 4's "Build Consumer" feature enabled, parsing this plugin > definition breaks with > {code:none} > [INFO] BuildTimeEventSpy is registered. > [INFO] Scanning for projects... > [ERROR] [ERROR] Some problems were encountered while processing the POMs: > [FATAL] Unable to transform pom > [ERROR] The build could not read 1 project -> [Help 1] > [ERROR] > [ERROR] The project (/Users/maarten/Code/open-source/camel/pom.xml) has 1 > error > [ERROR] Unable to transform pom: Not a regular file: > /Users/maarten/Code/open-source/pom.xml > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the '-e' > switch > [ERROR] Re-run Maven using the '-X' switch to enable verbose output > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException > {code} > I suspect that the {{}} tag is the culprit. It seems to me that it > causes the {{ParentXMLFilter}} to think it needs to do its work. The attached > screenshot shows the stacktrace that brought me to this idea. As the > {{B
[GitHub] [maven] gnodet commented on pull request #697: [MNG-7360] Fix xml transformation to ensure proper context
gnodet commented on PR #697: URL: https://github.com/apache/maven/pull/697#issuecomment-1130093500 Superseded by #744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet closed pull request #697: [MNG-7360] Fix xml transformation to ensure proper context
gnodet closed pull request #697: [MNG-7360] Fix xml transformation to ensure proper context URL: https://github.com/apache/maven/pull/697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7360) Can't parse project that has tag in plugin configuration
[ https://issues.apache.org/jira/browse/MNG-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538876#comment-17538876 ] ASF GitHub Bot commented on MNG-7360: - gnodet closed pull request #697: [MNG-7360] Fix xml transformation to ensure proper context URL: https://github.com/apache/maven/pull/697 > Can't parse project that has tag in plugin configuration > - > > Key: MNG-7360 > URL: https://issues.apache.org/jira/browse/MNG-7360 > Project: Maven > Issue Type: Bug > Components: build/consumer >Affects Versions: 4.0.x-candidate > Environment: Apache Maven 4.0.0-alpha-1-SNAPSHOT > (3a06530dbce82e2054afa3cc4c81631910474bd0) > Maven home: > /usr/local/Cellar/maven-snapshot/4.0.0-alpha-1-SNAPSHOT_290/libexec > Java version: 17.0.1, vendor: Eclipse Adoptium, runtime: > /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" >Reporter: Maarten Mulders >Assignee: Guillaume Nodet >Priority: Major > Attachments: Screenshot 2021-12-13 at 13.45.01.png > > > The Apache Camel project has the following snippet in their root POM: > {code:xml} > > org.codehaus.mojo > flatten-maven-plugin > 1.2.5 > > > default-cli > process-resources > > flatten > > > > > > expand > > > > > > > {code} > With Maven 4's "Build Consumer" feature enabled, parsing this plugin > definition breaks with > {code:none} > [INFO] BuildTimeEventSpy is registered. > [INFO] Scanning for projects... > [ERROR] [ERROR] Some problems were encountered while processing the POMs: > [FATAL] Unable to transform pom > [ERROR] The build could not read 1 project -> [Help 1] > [ERROR] > [ERROR] The project (/Users/maarten/Code/open-source/camel/pom.xml) has 1 > error > [ERROR] Unable to transform pom: Not a regular file: > /Users/maarten/Code/open-source/pom.xml > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the '-e' > switch > [ERROR] Re-run Maven using the '-X' switch to enable verbose output > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException > {code} > I suspect that the {{}} tag is the culprit. It seems to me that it > causes the {{ParentXMLFilter}} to think it needs to do its work. The attached > screenshot shows the stacktrace that brought me to this idea. As the > {{BufferingParser}} class processes its buffer of events, it encounters a > situation of an "end {{parent}} tag". But that {{parent}} tag did not have > child elements {{version}} and {{relativePath}} and so, it decides it needs > to resolve the parent as {{../pom.xml}} against the project path > ({{/Users/maarten/Code/open-source/camel/}} in my case), leading to the > non-existing path of {{/Users/maarten/Code/open-source/pom.xml}}. > I think the bug here is not that it resolves to a non-existing path (it's > good to check that before actually reading the file). I think the bug is that > the {{ParentXMLFilter}} is acting on the {{parent}} tag inside the plugin > configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7360) Can't parse project that has tag in plugin configuration
[ https://issues.apache.org/jira/browse/MNG-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538875#comment-17538875 ] ASF GitHub Bot commented on MNG-7360: - gnodet commented on PR #697: URL: https://github.com/apache/maven/pull/697#issuecomment-1130093500 Superseded by #744 > Can't parse project that has tag in plugin configuration > - > > Key: MNG-7360 > URL: https://issues.apache.org/jira/browse/MNG-7360 > Project: Maven > Issue Type: Bug > Components: build/consumer >Affects Versions: 4.0.x-candidate > Environment: Apache Maven 4.0.0-alpha-1-SNAPSHOT > (3a06530dbce82e2054afa3cc4c81631910474bd0) > Maven home: > /usr/local/Cellar/maven-snapshot/4.0.0-alpha-1-SNAPSHOT_290/libexec > Java version: 17.0.1, vendor: Eclipse Adoptium, runtime: > /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" >Reporter: Maarten Mulders >Assignee: Guillaume Nodet >Priority: Major > Attachments: Screenshot 2021-12-13 at 13.45.01.png > > > The Apache Camel project has the following snippet in their root POM: > {code:xml} > > org.codehaus.mojo > flatten-maven-plugin > 1.2.5 > > > default-cli > process-resources > > flatten > > > > > > expand > > > > > > > {code} > With Maven 4's "Build Consumer" feature enabled, parsing this plugin > definition breaks with > {code:none} > [INFO] BuildTimeEventSpy is registered. > [INFO] Scanning for projects... > [ERROR] [ERROR] Some problems were encountered while processing the POMs: > [FATAL] Unable to transform pom > [ERROR] The build could not read 1 project -> [Help 1] > [ERROR] > [ERROR] The project (/Users/maarten/Code/open-source/camel/pom.xml) has 1 > error > [ERROR] Unable to transform pom: Not a regular file: > /Users/maarten/Code/open-source/pom.xml > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the '-e' > switch > [ERROR] Re-run Maven using the '-X' switch to enable verbose output > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException > {code} > I suspect that the {{}} tag is the culprit. It seems to me that it > causes the {{ParentXMLFilter}} to think it needs to do its work. The attached > screenshot shows the stacktrace that brought me to this idea. As the > {{BufferingParser}} class processes its buffer of events, it encounters a > situation of an "end {{parent}} tag". But that {{parent}} tag did not have > child elements {{version}} and {{relativePath}} and so, it decides it needs > to resolve the parent as {{../pom.xml}} against the project path > ({{/Users/maarten/Code/open-source/camel/}} in my case), leading to the > non-existing path of {{/Users/maarten/Code/open-source/pom.xml}}. > I think the bug here is not that it resolves to a non-existing path (it's > good to check that before actually reading the file). I think the bug is that > the {{ParentXMLFilter}} is acting on the {{parent}} tag inside the plugin > configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-site] jorlina opened a new pull request, #302: Removing line about contacting Sonatype to set up a new mirror
jorlina opened a new pull request, #302: URL: https://github.com/apache/maven-site/pull/302 I'm also planning to update https://repo.maven.apache.org/maven2/.meta/repository-metadata.xml with a list of current mirrors (outdated mirrors have been commented out and Google mirrors added). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #150: Bump maven-dependency-tree from 3.1.0 to 3.1.1
dependabot[bot] opened a new pull request, #150: URL: https://github.com/apache/maven-enforcer/pull/150 Bumps [maven-dependency-tree](https://github.com/apache/maven-dependency-tree) from 3.1.0 to 3.1.1. Release notes Sourced from https://github.com/apache/maven-dependency-tree/releases";>maven-dependency-tree's releases. v3.1.1 What's Changed MSHARED-994 - fix collect dependencies when artifact has 'war' packaging by https://github.com/belingueres";>@belingueres in https://github-redirect.dependabot.com/apache/maven-dependency-tree/pull/7";>apache/maven-dependency-tree#7 Bump maven-site-plugin from 3.9.1 to 3.10.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-dependency-tree/pull/8";>apache/maven-dependency-tree#8 Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-dependency-tree/pull/14";>apache/maven-dependency-tree#14 [MSHARED-1069] Upgrade Parent to 36 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-dependency-tree/pull/20";>apache/maven-dependency-tree#20 New Contributors https://github.com/belingueres";>@belingueres made their first contribution in https://github-redirect.dependabot.com/apache/maven-dependency-tree/pull/7";>apache/maven-dependency-tree#7 https://github.com/dependabot";>@dependabot made their first contribution in https://github-redirect.dependabot.com/apache/maven-dependency-tree/pull/8";>apache/maven-dependency-tree#8 https://github.com/slawekjaranowski";>@slawekjaranowski made their first contribution in https://github-redirect.dependabot.com/apache/maven-dependency-tree/pull/20";>apache/maven-dependency-tree#20 Full Changelog: https://github.com/apache/maven-dependency-tree/compare/maven-dependency-tree-3.1.0...maven-dependency-tree-3.1.1";>https://github.com/apache/maven-dependency-tree/compare/maven-dependency-tree-3.1.0...maven-dependency-tree-3.1.1 Commits https://github.com/apache/maven-dependency-tree/commit/05bb7530c3fa8f78e9168751c814c6fc9d511de1";>05bb753 [maven-release-plugin] prepare release maven-dependency-tree-3.1.1 https://github.com/apache/maven-dependency-tree/commit/8732ab77cbcadfab55458b9f0934a2cc5a294b78";>8732ab7 Move execution of m-invoker-p to run-its profile https://github.com/apache/maven-dependency-tree/commit/7d1c702fcc00f118d02ecb03465cb2a1f364d17e";>7d1c702 [MSHARED-1069] Upgrade Parent to 36 https://github.com/apache/maven-dependency-tree/commit/74c79a5d4132e5261dd53cb79eda65fafedf61f1";>74c79a5 Add PR template https://github.com/apache/maven-dependency-tree/commit/df560858b249f5a3803aaf1b4e4cfcaa5d5634d0";>df56085 Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2 https://github.com/apache/maven-dependency-tree/commit/dffd33c41902805ea574cb0ddff29681028e1806";>dffd33c Shared GitHub actions v2 https://github.com/apache/maven-dependency-tree/commit/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a";>7a1a125 Bump maven-site-plugin from 3.9.1 to 3.10.0 https://github.com/apache/maven-dependency-tree/commit/9878b40fb3531bee47b148b1a4dc3129709a7a86";>9878b40 Drop noinstantiate, noreference https://github.com/apache/maven-dependency-tree/commit/134615e524baea40f0f0bf83a1aea8e16a5c71c8";>134615e Updated plugins https://github.com/apache/maven-dependency-tree/commit/064e63be0d21580dc6163eed037d9253cda09d03";>064e63b Added GH Shared Workflow Additional commits viewable in https://github.com/apache/maven-dependency-tree/compare/maven-dependency-tree-3.1.0...maven-dependency-tree-3.1.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen t
[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #151: Bump plexus-utils from 3.4.1 to 3.4.2
dependabot[bot] opened a new pull request, #151: URL: https://github.com/apache/maven-enforcer/pull/151 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.1 to 3.4.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexus-utils's releases. 3.4.2 🚀 New features and improvements Provides a CachingOuptutStream and a CachingWriter (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/184";>#184) https://github.com/gnodet";>@gnodet Use (already) precalculated value (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/186";>#186) https://github.com/pzygielo";>@pzygielo use github shared actions (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/171";>#171) https://github.com/olamy";>@olamy 🐛 Bug Fixes MXParser fixes (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/185";>#185) https://github.com/gnodet";>@gnodet Fix last modified time not being updated on linux (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/203";>#203) https://github.com/gnodet";>@gnodet Fix regression and deprecate: FileUtils.fileAppend should create file… (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/200";>#200) https://github.com/slachiewicz";>@slachiewicz Fix some testing XML files checkout with incorrect eol (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/198";>#198) https://github.com/belingueres";>@belingueres Fixed regressions: https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163 and https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/194";>#194 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/195";>#195) https://github.com/belingueres";>@belingueres Don't ignore valid SCM files (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/174";>#174) https://github.com/michael-o";>@michael-o 📦 Dependency updates Bump github/codeql-action from 1 to 2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/202";>#202) https://github.com/dependabot";>@dependabot Bump actions/checkout from 3.0.1 to 3.0.2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/199";>#199) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.18.1 to 5.19.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/188";>#188) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/189";>#189) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/190";>#190) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.4.0 to 3.0.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/197";>#197) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/175";>#175) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.18.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/183";>#183) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.3.4 to 2.4.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/173";>#173) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/170";>#170) https://github.com/dependabot";>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/01908b2979d4104a1e87f7e1eb0e157c9e1a3f8c";>01908b2 [maven-release-plugin] prepare release plexus-utils-3.4.2 https://github.com/codehaus-plexus/plexus-utils/commit/0d97c8ba8dfa4663e86c5827555f980fd47c27a9";>0d97c8b Fix endless loop caused by aborted subsequent PI or comment (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/124";>#124) https://github.com/codehaus-plexus/plexus-utils/commit/11c749d677176b5b04573a1acd37997ec61dcc05";>11c749d Fix endless loop with invalid PI containing XML (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/122";>#122) https://github.com/codehaus-plexus/plexus-utils/commit/2c6fe7e293425795835766319bff524ef47bb94a";>2c6fe7e Fix start position of PI and c