[GitHub] [maven-integration-testing] cstamas closed pull request #155: [MNG-7470] Quarkus build

[GitBox]

cstamas closed pull request #155: [MNG-7470] Quarkus build
URL: https://github.com/apache/maven-integration-testing/pull/155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #155: [MNG-7470] Quarkus build

[GitBox]

cstamas commented on PR #155:
URL: 
https://github.com/apache/maven-integration-testing/pull/155#issuecomment-1123273756

   Dropping this IT for now, is really overkill


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MNG-7470) Add IT involving resolver transport

[Jira]

 [ 
https://issues.apache.org/jira/browse/MNG-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MNG-7470:
-
Summary: Add IT involving resolver transport  (was: Add IT with quarkus 
plugin)

> Add IT involving resolver transport
> ---
>
> Key: MNG-7470
> URL: https://issues.apache.org/jira/browse/MNG-7470
> Project: Maven
>  Issue Type: Task
>  Components: Integration Tests
>Reporter: Tamás Cservenák
>Priority: Major
>
> Ideally just copy mvnd TypeDescriptionTest to maven ITs



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Created] (MBUILDCACHE-19) Upgrade to resolver 1.8.0

[Guillaume Nodet (Jira)]

Guillaume Nodet created MBUILDCACHE-19:
--

 Summary: Upgrade to resolver 1.8.0
 Key: MBUILDCACHE-19
 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-19
 Project: Maven Build Cache Extension
  Issue Type: Improvement
Affects Versions: 1.0.0-alpha
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet






--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-integration-testing] gnodet commented on pull request #155: [MNG-7470] Quarkus build

[GitBox]

gnodet commented on PR #155:
URL: 
https://github.com/apache/maven-integration-testing/pull/155#issuecomment-1123290634

   @cstamas when you say overkill, is that caused by the native compilation
   step ? I'm not convinced it is actually needed in order to test the
   resolver part, is it ?
   
   Le mer. 11 mai 2022 à 09:17, Tamas Cservenak ***@***.***> a
   écrit :
   
   > Closed #155 
   > .
   >
   > —
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***
   > com>
   >
   
   
   -- 
   ---
   Guillaume Nodet
   
   Red Hat, Open Source Integration
   
   Email: ***@***.***
   Web: http://fusesource.com
   Blog: http://gnodet.blogspot.com/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-build-cache-extension] gnodet merged pull request #12: [MBUILDCACHE-19] Upgrade to resolver 1.8.0

[GitBox]

gnodet merged PR #12:
URL: https://github.com/apache/maven-build-cache-extension/pull/12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MBUILDCACHE-19) Upgrade to resolver 1.8.0

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534736#comment-17534736
 ] 

ASF GitHub Bot commented on MBUILDCACHE-19:
---

gnodet merged PR #12:
URL: https://github.com/apache/maven-build-cache-extension/pull/12




> Upgrade to resolver 1.8.0
> -
>
> Key: MBUILDCACHE-19
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-19
> Project: Maven Build Cache Extension
>  Issue Type: Improvement
>Affects Versions: 1.0.0-alpha
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MBUILDCACHE-19) Upgrade to resolver 1.8.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated MBUILDCACHE-19:
--
Labels: pull-request-available  (was: )

> Upgrade to resolver 1.8.0
> -
>
> Key: MBUILDCACHE-19
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-19
> Project: Maven Build Cache Extension
>  Issue Type: Improvement
>Affects Versions: 1.0.0-alpha
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Closed] (MBUILDCACHE-19) Upgrade to resolver 1.8.0

[Guillaume Nodet (Jira)]

 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MBUILDCACHE-19.
--
Fix Version/s: 1.0.0-alpha
   Resolution: Fixed

> Upgrade to resolver 1.8.0
> -
>
> Key: MBUILDCACHE-19
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-19
> Project: Maven Build Cache Extension
>  Issue Type: Improvement
>Affects Versions: 1.0.0-alpha
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0-alpha
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MBUILDCACHE-19) Upgrade to resolver 1.8.0

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534742#comment-17534742
 ] 

Hudson commented on MBUILDCACHE-19:
---

Build failed in Jenkins: Maven » Maven TLP » maven-build-cache-extension » 
master #16

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-build-cache-extension/job/master/16/

> Upgrade to resolver 1.8.0
> -
>
> Key: MBUILDCACHE-19
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-19
> Project: Maven Build Cache Extension
>  Issue Type: Improvement
>Affects Versions: 1.0.0-alpha
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0-alpha
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-integration-testing] cstamas opened a new pull request, #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas opened a new pull request, #158:
URL: https://github.com/apache/maven-integration-testing/pull/158

   An IT for Maven 3.9+ that "exercise" both resolver transport: wagon and 
native.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

michael-o commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870023132


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,89 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption(new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=wagon" );
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+public void testResolverTransportNative()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "native" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.native" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption(new File( testDir, "settings.xml" 
).getAbsolutePath() );

Review Comment:
   space missing



##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,89 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870024752


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,89 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption(new File( testDir, "settings.xml" 
).getAbsolutePath() );

Review Comment:
   > Where is the verification that the transport actually works, i.e., the 
right one is picked?
   
   Maven build fails if project deps cannot be resolved... is that what you 
asking?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123359503

   > Where is the verification that the transport actually works, i.e., the 
right one is picked?
   
   Maven build fails if project deps cannot be resolved... is that what you 
asking?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] michael-o commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

michael-o commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123368629

   > > Where is the verification that the transport actually works, i.e., the 
right one is picked?
   > 
   > Maven build fails if project deps cannot be resolved... is that what you 
asking?
   
   Yes, this is what I will look for. Can you add this as a comment to the 
tests. It is not obvious from the code itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123373546

   > Yes, this is what I will look for. Can you add this as a comment to the 
tests. It is not obvious from the code itself.
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] michael-o commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

michael-o commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123375096

   Testing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123394490

   Do not merge pls, I'll do myself once done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] michael-o commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

michael-o commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123404480

   [INFO] Downloading from maven-core-it: 
http://localhost:53770/org/apache/maven/its/resolver-transport/wagon/dependency/1.0/dependency-1.0.pom
   [WARNING] Checksum validation failed, expected 
'97641443fee307b6c3593080be865df89ace3d86' (REMOTE_EXTERNAL) but is actually 
'cd16a85341375c7f9dda5edd75dedb83e213e425' from maven-core-it for 
http://localhost:53770/org/apache/maven/its/resolver-transport/wagon/dependency/1.0/dependency-1.0.pom
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-mvnd] gnodet merged pull request #647: Add scoop.sh to install instructions

[GitBox]

gnodet merged PR #647:
URL: https://github.com/apache/maven-mvnd/pull/647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] michael-o commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

michael-o commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123413971

   On
   ```
   Java version: 1.8.0_322, vendor: OpenJDK BSD Porting Team, runtime: 
/usr/local/openjdk8/jre
   Default locale: de_DE, platform encoding: UTF-8
   OS name: "freebsd", version: "12.3-stable", arch: "amd64", family: "unix"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

slawekjaranowski commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870072935


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,95 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=wagon" );

Review Comment:
   I can remove it and test still pass ...



##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,95 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=wagon" );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+public void testResolverTransportNative()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toStri

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

slawekjaranowski commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870074803


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,95 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=wagon" );

Review Comment:
   only one line ...
   ```
verifier.addCliOption( "-Dmaven.resolver.transport=wagon" );
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

slawekjaranowski commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870073498


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,95 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=wagon" );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+public void testResolverTransportNative()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "native" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.native" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=native" );

Review Comment:
   I can remove it and test still pass ...
   
   ```
   verifier.addCliOption( "-Dmaven.resolver.transport=native" );
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-mvnd] gnodet merged pull request #643: Configure execution bit for required scripts in source distribution

[GitBox]

gnodet merged PR #643:
URL: https://github.com/apache/maven-mvnd/pull/643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-mvnd] gnodet opened a new pull request, #648: Update release scripts

[GitBox]

gnodet opened a new pull request, #648:
URL: https://github.com/apache/maven-mvnd/pull/648

   Still need some scripts for macports, chocolatey and scoop...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123475324

   @michael-o @slawekjaranowski so pushed all I wanted, and locally tested, 
updated description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870109065


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,95 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=wagon" );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+public void testResolverTransportNative()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "native" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.native" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=native" );

Review Comment:
   sure, as it fallbacks to wagon, that's not the point here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870109314


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,95 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=wagon" );

Review Comment:
   sure, as wagon is the default, but is here only to be explicit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided

[GitBox]

michael-o commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123503869

   Stupid question: Do we need an IT which proves that these changes are 
required?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534801#comment-17534801
 ] 

ASF GitHub Bot commented on MNG-7471:
-

michael-o commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123503869

   Stupid question: Do we need an IT which proves that these changes are 
required?




> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-integration-testing] michael-o commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

michael-o commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123506079

   Will test again...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

slawekjaranowski commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870122411


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,95 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+public void testResolverTransportWagon()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "wagon" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.wagon" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=wagon" );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+public void testResolverTransportNative()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "native" 
).getAbsolutePath() );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport.native" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=native" );

Review Comment:
   We should check if in log we have
   
   ```
   [DEBUG] Using transporter ...
   ```
   
   If we explicite selected transport, no fallback should occurs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

slawekjaranowski commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123537993

   We should also check what happens if wrong transport will be provided, like 
`maven.resolver.transport=xxx`
   We will be sure that property is used at all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123538639

   > Is it ok?
   
   That should not happen, especially as now assertion to debug log is added. 
Did you return the removed line?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7464) Warn about using read-only parameters for Mojo in configuration

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534806#comment-17534806
 ] 

Hudson commented on MNG-7464:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-732 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-732/2/

> Warn about using read-only parameters for Mojo in configuration
> ---
>
> Key: MNG-7464
> URL: https://issues.apache.org/jira/browse/MNG-7464
> Project: Maven
>  Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MNG-7347) SessionScoped beans should be singletons for a given session

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534807#comment-17534807
 ] 

Hudson commented on MNG-7347:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-732 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-732/2/

> SessionScoped beans should be singletons for a given session
> 
>
> Key: MNG-7347
> URL: https://issues.apache.org/jira/browse/MNG-7347
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.8.4
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-integration-testing] cstamas commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123552489

   > We should also check what happens if wrong transport will be provided, 
like `maven.resolver.transport=xxx` We will be sure that property is used at all
   
   IMHO, this is not a UT, this IT merely ensures that selected transport IS 
used and WORKS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided

[GitBox]

cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123557648

   > Stupid question: Do we need an IT which proves that these changes are 
required?
   
   https://github.com/apache/maven-integration-testing/pull/158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534810#comment-17534810
 ] 

ASF GitHub Bot commented on MNG-7471:
-

cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123557648

   > Stupid question: Do we need an IT which proves that these changes are 
required?
   
   https://github.com/apache/maven-integration-testing/pull/158




> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided

[GitBox]

cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123563671

   The CI failed on macOS as for some reason Bootstrap failed, and hence, many 
unrelated ITs failed as well (as things were not present in local repo)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534812#comment-17534812
 ] 

ASF GitHub Bot commented on MNG-7471:
-

cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123563671

   The CI failed on macOS as for some reason Bootstrap failed, and hence, many 
unrelated ITs failed as well (as things were not present in local repo)




> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

slawekjaranowski commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123568367

   Now i have ...
   
   ```
   Caused by: java.lang.NoSuchMethodError: 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(Lorg/eclipse/aether/artifact/Artifact;ZLjava/net/URI;)Ljava/util/List;
   at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get 
(BasicRepositoryConnector.java:257)
   at 
org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads 
(DefaultArtifactResolver.java:520)
   at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
(DefaultArtifactResolver.java:408)
   at 
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts 
(DefaultArtifactResolver.java:235)
   at 
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
(DefaultArtifactResolver.java:212)
   at 
org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
(DefaultRepositorySystem.java:272)
   at org.apache.maven.resolver.examples.maven.ResolveArtifactMojo.execute 
(ResolveArtifactMojo.java:98)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123569929

   @slawekjaranowski cool, that's expected with latest maven 3.9.x build, as it 
uses resolver 1.8.0 but has no fix in https://github.com/apache/maven/pull/732 
Now, to verify, build locally that PR and run ITs with it, and they should all 
pass OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

slawekjaranowski commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123571081

   Both tests use the same project directory  pleas add
   
   ```
   verifier.setLogFileName( ... );
   ```
   
   without it we have logs in file `log.txt` which content logs from last 
executed test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123577828

   > Both tests use the same project directory  pleas add
   > 
   > ```
   > verifier.setLogFileName( ... );
   > ```
   > 
   > without it we have logs in file `log.txt` which content logs from last 
executed test
   
   fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-resolver] cstamas commented on pull request #175: Add test for empty children and collapse tests

[GitBox]

cstamas commented on PR #175:
URL: https://github.com/apache/maven-resolver/pull/175#issuecomment-1123588756

   @michael-o ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

slawekjaranowski commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870172914


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,87 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+private void performTest( final String transport, final String logSnippet 
) throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "project" 
).getAbsolutePath() );
+verifier.setLogFileName( transport + "-transport.log" );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=" + transport );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+// verify maven console output contains "[DEBUG] Using transporter 
XXXTransporter"
+verifyLogHasLine( verifier, logSnippet );
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+private void verifyLogHasLine( final Verifier verifier, final String 
logSnippet )
+throws VerificationException
+{
+List lines = verifier.loadFile( verifier.getBasedir(), 
verifier.getLogFileName(), false );
+
+for ( String line : lines )
+{
+if ( !line.contains( logSnippet ) )

Review Comment:
   should be
   ```
   if ( line.contains( logSnippet ) )
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870174840


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,87 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+private void performTest( final String transport, final String logSnippet 
) throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "project" 
).getAbsolutePath() );
+verifier.setLogFileName( transport + "-transport.log" );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=" + transport );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+// verify maven console output contains "[DEBUG] Using transporter 
XXXTransporter"
+verifyLogHasLine( verifier, logSnippet );
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+private void verifyLogHasLine( final Verifier verifier, final String 
logSnippet )
+throws VerificationException
+{
+List lines = verifier.loadFile( verifier.getBasedir(), 
verifier.getLogFileName(), false );
+
+for ( String line : lines )
+{
+if ( !line.contains( logSnippet ) )

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] slawekjaranowski commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided

[GitBox]

slawekjaranowski commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123596093

   > The CI failed on macOS as for some reason Bootstrap failed, and hence, 
many unrelated ITs failed as well (as things were not present in local repo)
   
   reason:
   ```
   transfer failed for 
https://repo1.maven.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom:
 Operation timed out (Read failed)
   ```
   try re-run filed build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534822#comment-17534822
 ] 

ASF GitHub Bot commented on MNG-7471:
-

slawekjaranowski commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123596093

   > The CI failed on macOS as for some reason Bootstrap failed, and hence, 
many unrelated ITs failed as well (as things were not present in local repo)
   
   reason:
   ```
   transfer failed for 
https://repo1.maven.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom:
 Operation timed out (Read failed)
   ```
   try re-run filed build




> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-integration-testing] cstamas commented on pull request #155: [MNG-7470] Quarkus build

[GitBox]

cstamas commented on PR #155:
URL: 
https://github.com/apache/maven-integration-testing/pull/155#issuecomment-1123597724

   No, I meant "overkill for IT", to pull in all transitive deps of quarkus etc 
plugin See https://github.com/apache/maven-integration-testing/pull/158
   
   This IT reproduces same error we saw in mvnd and maven-3.9.x just fine, but 
is much simpler and uses much less moving parts...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided

[GitBox]

cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123600512

   > reason:...
   
   Whatever the reason is, it is unrelated to change in this PR, that was my 
point. Probably some networking issue on GH side...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534824#comment-17534824
 ] 

ASF GitHub Bot commented on MNG-7471:
-

cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123600512

   > reason:...
   
   Whatever the reason is, it is unrelated to change in this PR, that was my 
point. Probably some networking issue on GH side...




> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven] slawekjaranowski commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided

[GitBox]

slawekjaranowski commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123605541

   
   > Whatever the reason is, it is unrelated to change in this PR, that was my 
point. Probably some networking issue on GH side...
   
   exactly GH issue ...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534826#comment-17534826
 ] 

ASF GitHub Bot commented on MNG-7471:
-

slawekjaranowski commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123605541

   
   > Whatever the reason is, it is unrelated to change in this PR, that was my 
point. Probably some networking issue on GH side...
   
   exactly GH issue ...
   




> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MJAVADOC-652) Dependencies on the patch-module path

[Phil (Jira)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534829#comment-17534829
 ] 

Phil commented on MJAVADOC-652:
---

No sorry, this issue still exists even in 3.4.0. It seems the use of 
module-path and patch-module path only occurs if the javadoc plugin runs after 
the maven-jar-plugin:3.2.2:jar plugin. It puts everything onto the classpath if 
run before (or run without). 

> Dependencies on the patch-module path
> -
>
> Key: MJAVADOC-652
> URL: https://issues.apache.org/jira/browse/MJAVADOC-652
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 3.2.0
>Reporter: Phil
>Assignee: Robert Scholte
>Priority: Major
> Attachments: MJAVADOC-652.zip
>
>
> When building with Java 11 (so >9) the Javadoc options argument is built 
> using the module-path and patch-module. Some of the dependencies I work with 
> are ending up in patch-module which generates an error on Javadoc creation - 
> class not found.
> From what I can see from the code (3.2.0), the decision of which argument to 
> use is based on:
>  # If the dependency jar has a module-info.class, add to module-path
>  # If the dependency jar has a MANIFEST file with Automatic-Module-Name 
> defined, add to module-path.
>  # If neither of the above, add to patch-module. 
> The javax.servlet-API-3.1.0.jar, for example, has neither 1 nor 2, so gets 
> amended to the patch-module. This then prevents Javadoc generation because 
> Java is unable to link classes from the servlet API. If I put the servlet API 
> into the module-path manually it works fine. 
> From my understanding, patch-module is used to either override classes in a 
> module or augment contents of a module. In this case, it is its own 'module' 
> (I think) and should not be patched into my module. I do not see a reason to 
> put any of my dependencies into patch-module. 
> Is this a bug, or just an unfortunate consequence of having to deal with 
> non-modular dependencies when building under a Java version that supports 
> modules. For what it is worth, the project I work on does not use modules, 
> everything on -classpath works just fine. 
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven] michael-o commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided

[GitBox]

michael-o commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123656284

   Testing again...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534845#comment-17534845
 ] 

ASF GitHub Bot commented on MNG-7471:
-

michael-o commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123656284

   Testing again...




> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-resolver] michael-o commented on pull request #175: Add test for empty children and collapse tests

[GitBox]

michael-o commented on PR #175:
URL: https://github.com/apache/maven-resolver/pull/175#issuecomment-1123666899

   Testing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-resolver] cstamas merged pull request #175: Add test for empty children and collapse tests

[GitBox]

cstamas merged PR #175:
URL: https://github.com/apache/maven-resolver/pull/175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MSITE-896) Is it possible to override the Project Reports menu order?

[Joshua (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSITE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joshua updated MSITE-896:
-
Attachment: image-2022-05-11-08-24-14-242.png

> Is it possible to override the Project Reports menu order?
> --
>
> Key: MSITE-896
> URL: https://issues.apache.org/jira/browse/MSITE-896
> Project: Maven Site Plugin
>  Issue Type: Wish
>Reporter: Joshua
>Priority: Major
> Attachments: image-2022-04-27-15-50-48-346.png, 
> image-2022-04-27-15-51-39-355.png, image-2022-05-11-08-24-14-242.png
>
>
> I have to inherit a parent pom per organization guidelines.
> Inheriting that parent pom messes up the ordering of the report sets in the 
> generated project report menu.
> Here is before the inheritance
> !image-2022-04-27-15-50-48-346.png!
> Here is after the inheritance
> !image-2022-04-27-15-51-39-355.png!
> Is there any way I can override/specify the order of the report sets in this 
> menu in either my pom or the site.xml?
> I would like the after ordering to be the same as before ordering.
> I can't change the parent pom which defines most of the report sets.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MSITE-896) Is it possible to override the Project Reports menu order?

[Joshua (Jira)]

[ 
https://issues.apache.org/jira/browse/MSITE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534902#comment-17534902
 ] 

Joshua commented on MSITE-896:
--

[~michael-o]  I did try not using the  in my site.xml and 
instead I just put each report in the site.xml

The only problem with that is that there are certain times when spotbugs, pmd, 
and cpd reports aren't generated due to their being no issues.

!image-2022-05-11-08-24-14-242.png!

I am not sure how to detect in the site.xml whether the report it there or not 
before adding the item to the menu.

> Is it possible to override the Project Reports menu order?
> --
>
> Key: MSITE-896
> URL: https://issues.apache.org/jira/browse/MSITE-896
> Project: Maven Site Plugin
>  Issue Type: Wish
>Reporter: Joshua
>Priority: Major
> Attachments: image-2022-04-27-15-50-48-346.png, 
> image-2022-04-27-15-51-39-355.png, image-2022-05-11-08-24-14-242.png
>
>
> I have to inherit a parent pom per organization guidelines.
> Inheriting that parent pom messes up the ordering of the report sets in the 
> generated project report menu.
> Here is before the inheritance
> !image-2022-04-27-15-50-48-346.png!
> Here is after the inheritance
> !image-2022-04-27-15-51-39-355.png!
> Is there any way I can override/specify the order of the report sets in this 
> menu in either my pom or the site.xml?
> I would like the after ordering to be the same as before ordering.
> I can't change the parent pom which defines most of the report sets.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

michael-o commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870300031


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,87 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+private void performTest( final String transport, final String logSnippet 
) throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "project" 
).getAbsolutePath() );
+verifier.setLogFileName( transport + "-transport.log" );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );

Review Comment:
   space



##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,87 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+private void performTest( final String transport, final String logSnippet 
) throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "project" 
).getAbsolutePath() );
+verifier.setLogFileName( transport + "-transport.log" );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=" + transport );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+// verify maven console output contains "[DEBUG] Using transporter 
XXXTransporter"
+verifyLogHasLine( verifier, logSnippet );
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+private void verifyLogHasLine( final Verifier verifier, final String 
logSnippet )

Review Comment:
   I bet I have seen this in other ITs already. I guess `Verifier` needs this 
bundled. Out of scope for this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this s

[jira] [Created] (MSKINS-187) Wrong left margin for externalLink decoration in sideBar

[Konrad Windszus (Jira)]

Konrad Windszus created MSKINS-187:
--

 Summary: Wrong left margin for externalLink decoration in sideBar
 Key: MSKINS-187
 URL: https://issues.apache.org/jira/browse/MSKINS-187
 Project: Maven Skins
  Issue Type: Bug
  Components: Fluido Skin
Affects Versions: fluido-1.10.0
Reporter: Konrad Windszus
 Attachments: Screenshot 2022-05-11 at 15.31.17.png

External links get some decoration via CSS class "externalLink". The left 
margin is not correct though for external links appearing in the side bar.

 !Screenshot 2022-05-11 at 15.31.17.png! 

That is due to the left-margin of -15px set for {{.nav-list>li>a}}.

A similar issue has been reported in MSKINS-173.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870318471


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,87 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+private void performTest( final String transport, final String logSnippet 
) throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "project" 
).getAbsolutePath() );
+verifier.setLogFileName( transport + "-transport.log" );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=" + transport );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+// verify maven console output contains "[DEBUG] Using transporter 
XXXTransporter"
+verifyLogHasLine( verifier, logSnippet );
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+private void verifyLogHasLine( final Verifier verifier, final String 
logSnippet )

Review Comment:
   Agreed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MJAVADOC-713) Skipping Javadoc reportset leaves empty Javadoc link in site

[Joshua (Jira)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534903#comment-17534903
 ] 

Joshua commented on MJAVADOC-713:
-

[~michael-o]  Any updates here? It says waiting for feedback and I have already 
provided a sample project.

> Skipping Javadoc reportset leaves empty Javadoc link in site
> 
>
> Key: MJAVADOC-713
> URL: https://issues.apache.org/jira/browse/MJAVADOC-713
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Joshua
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: image-2022-04-15-17-47-49-771.png, sampleproject.zip
>
>
> I am trying to skip a reportset that is inherited from a parent pom
> This is what the report plugin looks like in the parent pom
>             
>                 org.apache.maven.plugins
>                 maven-javadoc-plugin
>                 
>                     
>                         javadoc-no-fork
>                         
>                             javadoc-no-fork
>                         
>                     
>                     
>                         test-javadoc-no-fork
>                         
>                             test-javadoc-no-fork
>                         
>                         
>                             package
>                         
>                     
>                 
>             
> I don't want the test-javadoc-no-fork report in my project
>  
> If I do this in my pom
> 
>     org.apache.maven.plugins
>     maven-javadoc-plugin
>     
>              
>                      test-javadoc-no-fork
>                       
>                            true
>                       
>              
>     
> 
>  
> It will skip the Javadoc generation but still adds a link to site and when 
> you click on the link you get a 404 since the test Javadoc wasn't inherited.
> !image-2022-04-15-17-47-49-771.png!
> I logged this as a defect because I would think skip would prevent the 
> Javadoc generation and NOT add a link to the site for a report set that 
> wasn't generated.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MSKINS-187) Wrong left margin for externalLink decoration in sideBar

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSKINS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSKINS-187:
--
Attachment: image-2022-05-11-15-47-18-117.png

> Wrong left margin for externalLink decoration in sideBar
> 
>
> Key: MSKINS-187
> URL: https://issues.apache.org/jira/browse/MSKINS-187
> Project: Maven Skins
>  Issue Type: Bug
>  Components: Fluido Skin
>Affects Versions: fluido-1.10.0
>Reporter: Konrad Windszus
>Priority: Major
> Attachments: Screenshot 2022-05-11 at 15.31.17.png, 
> image-2022-05-11-15-47-18-117.png
>
>
> External links get some decoration via CSS class "externalLink". The left 
> margin is not correct though for external links appearing in the side bar.
>  !Screenshot 2022-05-11 at 15.31.17.png! 
> That is due to the left-margin of -15px set for {{.nav-list>li>a}}.
> A similar issue has been reported in MSKINS-173.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MSKINS-187) Wrong left margin for externalLink decoration in sideBar

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MSKINS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534912#comment-17534912
 ] 

Michael Osipov commented on MSKINS-187:
---

Is this what you expect to see

Alignment with the menu chevron?

> Wrong left margin for externalLink decoration in sideBar
> 
>
> Key: MSKINS-187
> URL: https://issues.apache.org/jira/browse/MSKINS-187
> Project: Maven Skins
>  Issue Type: Bug
>  Components: Fluido Skin
>Affects Versions: fluido-1.10.0
>Reporter: Konrad Windszus
>Priority: Major
> Attachments: Screenshot 2022-05-11 at 15.31.17.png, 
> image-2022-05-11-15-47-18-117.png
>
>
> External links get some decoration via CSS class "externalLink". The left 
> margin is not correct though for external links appearing in the side bar.
>  !Screenshot 2022-05-11 at 15.31.17.png! 
> That is due to the left-margin of -15px set for {{.nav-list>li>a}}.
> A similar issue has been reported in MSKINS-173.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MSKINS-187) Wrong left margin for externalLink decoration in sideBar

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSKINS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSKINS-187:
--
Fix Version/s: fluido-1.11.0

> Wrong left margin for externalLink decoration in sideBar
> 
>
> Key: MSKINS-187
> URL: https://issues.apache.org/jira/browse/MSKINS-187
> Project: Maven Skins
>  Issue Type: Bug
>  Components: Fluido Skin
>Affects Versions: fluido-1.10.0
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: Screenshot 2022-05-11 at 15.31.17.png, 
> image-2022-05-11-15-47-18-117.png
>
>
> External links get some decoration via CSS class "externalLink". The left 
> margin is not correct though for external links appearing in the side bar.
>  !Screenshot 2022-05-11 at 15.31.17.png! 
> That is due to the left-margin of -15px set for {{.nav-list>li>a}}.
> A similar issue has been reported in MSKINS-173.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Assigned] (MSKINS-187) Wrong left margin for externalLink decoration in sideBar

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSKINS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MSKINS-187:
-

Assignee: Michael Osipov

> Wrong left margin for externalLink decoration in sideBar
> 
>
> Key: MSKINS-187
> URL: https://issues.apache.org/jira/browse/MSKINS-187
> Project: Maven Skins
>  Issue Type: Bug
>  Components: Fluido Skin
>Affects Versions: fluido-1.10.0
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Attachments: Screenshot 2022-05-11 at 15.31.17.png, 
> image-2022-05-11-15-47-18-117.png
>
>
> External links get some decoration via CSS class "externalLink". The left 
> margin is not correct though for external links appearing in the side bar.
>  !Screenshot 2022-05-11 at 15.31.17.png! 
> That is due to the left-margin of -15px set for {{.nav-list>li>a}}.
> A similar issue has been reported in MSKINS-173.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MSKINS-187) Wrong left margin for externalLink decoration in sideBar

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/MSKINS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534914#comment-17534914
 ] 

Konrad Windszus commented on MSKINS-187:


[~michael-o] Yes, that looks much nicer. I haven't really thought about a 
reasonable margin right, but the current 0 margin is just ugly. Your proposal 
sounds fine to me.

> Wrong left margin for externalLink decoration in sideBar
> 
>
> Key: MSKINS-187
> URL: https://issues.apache.org/jira/browse/MSKINS-187
> Project: Maven Skins
>  Issue Type: Bug
>  Components: Fluido Skin
>Affects Versions: fluido-1.10.0
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: Screenshot 2022-05-11 at 15.31.17.png, 
> image-2022-05-11-15-47-18-117.png
>
>
> External links get some decoration via CSS class "externalLink". The left 
> margin is not correct though for external links appearing in the side bar.
>  !Screenshot 2022-05-11 at 15.31.17.png! 
> That is due to the left-margin of -15px set for {{.nav-list>li>a}}.
> A similar issue has been reported in MSKINS-173.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided

[GitBox]

cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123820300

   Merged manually:
   maven-3.9.x 4de39476ff690774ece57637e91653d2ef234fd3
   master a83ed86c4850c3fc09e5623eb00869ab3e39c959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] cstamas closed pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided

[GitBox]

cstamas closed pull request #732: [MNG-7471] 3.9.x Make Resolver util and 
connector-basic provided
URL: https://github.com/apache/maven/pull/732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534921#comment-17534921
 ] 

ASF GitHub Bot commented on MNG-7471:
-

cstamas closed pull request #732: [MNG-7471] 3.9.x Make Resolver util and 
connector-basic provided
URL: https://github.com/apache/maven/pull/732




> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534920#comment-17534920
 ] 

ASF GitHub Bot commented on MNG-7471:
-

cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123820300

   Merged manually:
   maven-3.9.x 4de39476ff690774ece57637e91653d2ef234fd3
   master a83ed86c4850c3fc09e5623eb00869ab3e39c959




> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Resolved] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[Jira]

 [ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák resolved MNG-7471.
--
Resolution: Fixed

> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1
>
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[Jira]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534922#comment-17534922
 ] 

Tamás Cservenák commented on MNG-7471:
--

Merged as

maven-3.9.x 4de39476ff690774ece57637e91653d2ef234fd3
master a83ed86c4850c3fc09e5623eb00869ab3e39c959

> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[Jira]

 [ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MNG-7471:
-
Fix Version/s: 3.9.0
   4.0.0-alpha-1

> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1
>
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Closed] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[Jira]

 [ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák closed MNG-7471.


> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1
>
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[Jira]

 [ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MNG-7471:
-
Fix Version/s: 4.0.0

> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MSKINS-187) Wrong left margin for externalLink decoration in sideBar

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MSKINS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534924#comment-17534924
 ] 

Michael Osipov commented on MSKINS-187:
---

Look at the margin of "Project Reports", it is -6px. I would align both after 
an investigation. Will work on a PR tomorrow.

> Wrong left margin for externalLink decoration in sideBar
> 
>
> Key: MSKINS-187
> URL: https://issues.apache.org/jira/browse/MSKINS-187
> Project: Maven Skins
>  Issue Type: Bug
>  Components: Fluido Skin
>Affects Versions: fluido-1.10.0
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: Screenshot 2022-05-11 at 15.31.17.png, 
> image-2022-05-11-15-47-18-117.png
>
>
> External links get some decoration via CSS class "externalLink". The left 
> margin is not correct though for external links appearing in the side bar.
>  !Screenshot 2022-05-11 at 15.31.17.png! 
> That is due to the left-margin of -15px set for {{.nav-list>li>a}}.
> A similar issue has been reported in MSKINS-173.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-integration-testing] cstamas commented on pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#issuecomment-1123846265

   Fix merged, so the IT can be as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (MNG-7455) [REGRESSION] IllegalStateException in SessionScope during guice injection in multithreaded build

[Guillaume Nodet (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MNG-7455.

Fix Version/s: 3.8.6
 Assignee: Guillaume Nodet
   Resolution: Fixed

> [REGRESSION] IllegalStateException in SessionScope during guice injection in 
> multithreaded build
> 
>
> Key: MNG-7455
> URL: https://issues.apache.org/jira/browse/MNG-7455
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Emond Papegaaij
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.6
>
> Attachments: pom.xml.effective
>
>
> Since Maven 3.8.5 we are seeing intermittent failures with the stacktrace 
> below. With 3.8.4 we did not have this issue. Looking at the changelog I 
> suspect this regression is caused by MNG-7347.
> {code:java}
> 09:36:53 [mvn-builder-keyhub-manual] [INFO] --- 
> asciidoctor-maven-plugin:2.2.2:process-asciidoc (output-html-nl) @ 
> keyhub-manual ---
> 09:36:53 [mvn-builder-keyhub-manual] [WARNING] Error injecting: 
> org.asciidoctor.maven.AsciidoctorMojo
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, java.lang.IllegalStateException
>   at 
> org.apache.maven.session.scope.internal.SessionScopeModule.configure(SessionScopeModule.java:64)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.session.scope.internal.SessionScopeModule)
>   while locating org.apache.maven.execution.MavenSession
> for field at org.asciidoctor.maven.AsciidoctorMojo.session(Unknown Source)
>   while locating org.asciidoctor.maven.AsciidoctorMojo
> 1 error
> at 
> com.google.inject.internal.InternalProvisionException.toProvisionException 
> (InternalProvisionException.java:226)
> at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1053)
> at com.google.inject.internal.InjectorImpl.getInstance 
> (InjectorImpl.java:1086)
> at org.eclipse.sisu.space.AbstractDeferredClass.get 
> (AbstractDeferredClass.java:48)
> at com.google.inject.internal.ProviderInternalFactory.provision 
> (ProviderInternalFactory.java:85)
> at 
> com.google.inject.internal.InternalFactoryToInitializableAdapter.provision 
> (InternalFactoryToInitializableAdapter.java:57)
> at com.google.inject.internal.ProviderInternalFactory$1.call 
> (ProviderInternalFactory.java:66)
> at 
> com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision 
> (ProvisionListenerStackCallback.java:112)
> at 
> com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision 
> (ProvisionListenerStackCallback.java:127)
> at com.google.inject.internal.ProvisionListenerStackCallback.provision 
> (ProvisionListenerStackCallback.java:66)
> at com.google.inject.internal.ProviderInternalFactory.circularGet 
> (ProviderInternalFactory.java:61)
> at com.google.inject.internal.InternalFactoryToInitializableAdapter.get 
> (InternalFactoryToInitializableAdapter.java:47)
> at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1050)
> at org.eclipse.sisu.inject.Guice4$1.get (Guice4.java:162)
> at org.eclipse.sisu.inject.LazyBeanEntry.getValue (LazyBeanEntry.java:81)
> at org.eclipse.sisu.plexus.LazyPlexusBean.getValue 
> (LazyPlexusBean.java:51)
> at org.codehaus.plexus.DefaultPlexusContainer.lookup 
> (DefaultPlexusContainer.java:263)
> at org.codehaus.plexus.DefaultPlexusContainer.lookup 
> (DefaultPlexusContainer.java:255)
> at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.getConfiguredMojo 
> (DefaultMavenPluginManager.java:520)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:124)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:301)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
> at 
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
>  (MultiThreadedBuilder.java:210)
> at 
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
>  (MultiThreadedBuilder.java:195)
> at java.util.concurrent.FutureTask.run (FutureTask.java:264)
> at java.util.concurrent.Executors$RunnableAdapter.call 
> (Executors.java:539)
> at java.util.concurrent.FutureTask.run (Futu

[GitHub] [maven] cstamas opened a new pull request, #735: Trasnport: use config properties instead user properties.

[GitBox]

cstamas opened a new pull request, #735:
URL: https://github.com/apache/maven/pull/735

   This setting should be possible to be set via MAVEN_OPTS (system wide) or in 
.mvn/maven.config etc, Currently it is possible only via `-Dxxx` AFTER mvn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on a diff in pull request #735: Trasnport: use config properties instead user properties.

[GitBox]

michael-o commented on code in PR #735:
URL: https://github.com/apache/maven/pull/735#discussion_r870388634


##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -261,8 +261,7 @@ else if ( request.isUpdateSnapshots() )
 }
 session.setAuthenticationSelector( authSelector );
 
-String transport = request.getUserProperties()
-.getProperty( MAVEN_RESOLVER_TRANSPORT_KEY, 
MAVEN_RESOLVER_TRANSPORT_WAGON );

Review Comment:
   So this is a merged, final version of the properties and the actual source 
is irrelevant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] cstamas commented on a diff in pull request #735: Trasnport: use config properties instead user properties.

[GitBox]

cstamas commented on code in PR #735:
URL: https://github.com/apache/maven/pull/735#discussion_r870393670


##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -261,8 +261,7 @@ else if ( request.isUpdateSnapshots() )
 }
 session.setAuthenticationSelector( authSelector );
 
-String transport = request.getUserProperties()
-.getProperty( MAVEN_RESOLVER_TRANSPORT_KEY, 
MAVEN_RESOLVER_TRANSPORT_WAGON );

Review Comment:
   yup, this is "config" properties (merged plus added things). I think I 
understand from where "request.systemProperties" are sourced, but from where 
are "request.userProperties" sourced?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on a diff in pull request #735: Trasnport: use config properties instead user properties.

[GitBox]

michael-o commented on code in PR #735:
URL: https://github.com/apache/maven/pull/735#discussion_r870405282


##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -261,8 +261,7 @@ else if ( request.isUpdateSnapshots() )
 }
 session.setAuthenticationSelector( authSelector );
 
-String transport = request.getUserProperties()
-.getProperty( MAVEN_RESOLVER_TRANSPORT_KEY, 
MAVEN_RESOLVER_TRANSPORT_WAGON );

Review Comment:
   Look into Maven CLI, that is the source for it. Commons CLI provides it and 
it is passed down the line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534940#comment-17534940
 ] 

Hudson commented on MNG-7471:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » master #43

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/43/

> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #735: Trasnport: use config properties instead user properties.

[GitBox]

slawekjaranowski commented on code in PR #735:
URL: https://github.com/apache/maven/pull/735#discussion_r870423542


##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -261,8 +261,7 @@ else if ( request.isUpdateSnapshots() )
 }
 session.setAuthenticationSelector( authSelector );
 
-String transport = request.getUserProperties()
-.getProperty( MAVEN_RESOLVER_TRANSPORT_KEY, 
MAVEN_RESOLVER_TRANSPORT_WAGON );

Review Comment:
   `request.*Properties` is populated in 
   
https://github.com/apache/maven/blob/master/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #735: Trasnport: use config properties instead user properties.

[GitBox]

slawekjaranowski commented on code in PR #735:
URL: https://github.com/apache/maven/pull/735#discussion_r870423542


##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -261,8 +261,7 @@ else if ( request.isUpdateSnapshots() )
 }
 session.setAuthenticationSelector( authSelector );
 
-String transport = request.getUserProperties()
-.getProperty( MAVEN_RESOLVER_TRANSPORT_KEY, 
MAVEN_RESOLVER_TRANSPORT_WAGON );

Review Comment:
   `request.*Properties` are populated in 
   
https://github.com/apache/maven/blob/master/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534943#comment-17534943
 ] 

Hudson commented on MNG-7471:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #29

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/29/

> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven] cstamas commented on a diff in pull request #735: Trasnport: use config properties instead user properties.

[GitBox]

cstamas commented on code in PR #735:
URL: https://github.com/apache/maven/pull/735#discussion_r870431077


##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -261,8 +261,7 @@ else if ( request.isUpdateSnapshots() )
 }
 session.setAuthenticationSelector( authSelector );
 
-String transport = request.getUserProperties()
-.getProperty( MAVEN_RESOLVER_TRANSPORT_KEY, 
MAVEN_RESOLVER_TRANSPORT_WAGON );

Review Comment:
   IMHO this is correct change: we do want to allow setting transport in 
various ways, allowing the change to be "persistent". What we have on master 
works ONLY if you use `-Dmaven.resolver.transport=xx` on CLI and nothing else.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] cstamas commented on a diff in pull request #735: Trasnport: use config properties instead user properties.

[GitBox]

cstamas commented on code in PR #735:
URL: https://github.com/apache/maven/pull/735#discussion_r870431077


##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -261,8 +261,7 @@ else if ( request.isUpdateSnapshots() )
 }
 session.setAuthenticationSelector( authSelector );
 
-String transport = request.getUserProperties()
-.getProperty( MAVEN_RESOLVER_TRANSPORT_KEY, 
MAVEN_RESOLVER_TRANSPORT_WAGON );

Review Comment:
   IMHO this is correct change: we do want to allow setting transport in 
various ways, allowing the change to be "persistent". What we have on master 
works ONLY if you use `-Dmaven.resolver.transport=xx` on CLI and nothing else. 
This also allows CLI override (ie. you have it set in MAVEN_OPTS but you use 
`-Dxxx` on command line)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (MNG-7474) SessionScoped beans should be singletons for a given session

[Guillaume Nodet (Jira)]

Guillaume Nodet created MNG-7474:


 Summary: SessionScoped beans should be singletons for a given 
session
 Key: MNG-7474
 URL: https://issues.apache.org/jira/browse/MNG-7474
 Project: Maven
  Issue Type: Improvement
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: 3.9.0-candidate


Investigate an solution different from MNG-7347.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-mvnd] eforx opened a new issue, #649: Maven goal is sometimes skipped

[GitBox]

eforx opened a new issue, #649:
URL: https://github.com/apache/maven-mvnd/issues/649

   In our CI pipeline, we call Maven Daemon in loop (single thread). Most of 
the time it works, but about 1 out of 50 times mvnd skips the target goal.
   
   Executed command: `mvnd 
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:get 
-Dartifact=${mavenArtifactId} -ntp 
-Dmaven.repo.local=${pathToLocalMavenRepository}`
   
   Output log of single iteration looks like this
   ```
   [INFO] Processing build on daemon 39c6fb35
   [INFO] Scanning for projects...
   [INFO] BuildTimeEventSpy is registered.
   [INFO] Task segments : 
[org.apache.maven.plugins:maven-dependency-plugin:3.2.0:get]
   [INFO] Build maximum degree of concurrency is 1
   [INFO] Total number of projects is 1
   [INFO] 
   [INFO] --< org.apache.maven:standalone-pom 
>---
   [INFO] Building Maven Stub Project (No POM) 1
   [INFO] [ pom 
]-
   [INFO] 
   [INFO] --- maven-dependency-plugin:3.2.0:get (default-cli) @ standalone-pom 
---
   [INFO] Resolving ${mavenArtifactId}:jar:1.2.3.4-SNAPSHOT with transitive 
dependencies
   [INFO] Segment walltime 0 s, segment projects service time 0 s, 
effective/maximum degree of concurrency 0.62/1
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time:  0.186 s
   [INFO] Finished at: 2022-05-11T16:02:15Z
   [INFO] 

   ```
   
   while sometimes we got
   ```
   [INFO] Processing build on daemon 39c6fb35
   [INFO] Scanning for projects...
   [INFO] BuildTimeEventSpy is registered.
   [INFO] Task segments : 
[org.apache.maven.plugins:maven-dependency-plugin:3.2.0:get]
   [INFO] Build maximum degree of concurrency is 1
   [INFO] Total number of projects is 1
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time:  0.008 s
   [INFO] Finished at: 2022-05-11T16:02:15Z
   [INFO] 

   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-resolver] cstamas opened a new pull request, #176: Idea: collector listener

[GitBox]

cstamas opened a new pull request, #176:
URL: https://github.com/apache/maven-resolver/pull/176

   This basically does what this example did:
   https://github.com/grgrzybek/tracking-maven-extension
   
   To finish, it would be an "extension point": interface that if extension 
implements as component, would be picked up.
   
   BUT: am not quite in favor of this, as collector is HOT, and any time this 
listener would spend on work, would directly affect collection process. Am 
slowly leaning to simply define a callback for result graph (once collection is 
done), as then:
   * that would minimally affect collection, would not, would just add 
"postprocessing" cost, no in-processing cost that can quickly ass up
   * whole graph would be handed over, same as for caller along with session


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

slawekjaranowski commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870536089


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,87 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+private void performTest( final String transport, final String logSnippet 
) throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "project" 
).getAbsolutePath() );
+verifier.setLogFileName( transport + "-transport.log" );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=" + transport );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+// verify maven console output contains "[DEBUG] Using transporter 
XXXTransporter"
+verifyLogHasLine( verifier, logSnippet );
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+private void verifyLogHasLine( final Verifier verifier, final String 
logSnippet )

Review Comment:
   There is `verifier.verifyTextInLog(...)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #158: [MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

[GitBox]

cstamas commented on code in PR #158:
URL: 
https://github.com/apache/maven-integration-testing/pull/158#discussion_r870565382


##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##
@@ -0,0 +1,87 @@
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7470";>MNG-7470:
+ * check that Maven two bundled transports works as expected.
+ */
+public class MavenITmng7470ResolverTransportTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng7470ResolverTransportTest()
+{
+super( "[3.9.0,)" );
+}
+
+private void performTest( final String transport, final String logSnippet 
) throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/mng-7470-resolver-transport" );
+
+HttpServer server = HttpServer.builder()
+.port( 0 )
+.source( new File( testDir, "repo" ) )
+.build();
+server.start();
+try
+{
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+HashMap properties = new HashMap<>();
+properties.put( "@port@", Integer.toString( server.port() ) );
+verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", properties );
+
+verifier = newVerifier( new File( testDir, "project" 
).getAbsolutePath() );
+verifier.setLogFileName( transport + "-transport.log" );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( 
"org.apache.maven.its.resolver-transport" );
+verifier.addCliOption( "-X" );
+verifier.addCliOption("-s" );
+verifier.addCliOption( new File( testDir, "settings.xml" 
).getAbsolutePath() );
+verifier.addCliOption( "-Pmaven-core-it-repo" );
+verifier.addCliOption( "-Dmaven.resolver.transport=" + transport );
+// Maven will fail if project dependencies cannot be resolved.
+// As dependency exists ONLY in HTTP repo, it MUST be reached 
using selected transport and
+// successfully resolved from it.
+verifier.executeGoal( "verify" );
+verifier.verifyErrorFreeLog();
+// verify maven console output contains "[DEBUG] Using transporter 
XXXTransporter"
+verifyLogHasLine( verifier, logSnippet );
+verifier.resetStreams();
+}
+finally
+{
+server.stop();
+}
+}
+
+private void verifyLogHasLine( final Verifier verifier, final String 
logSnippet )

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on a diff in pull request #730: [MNG-7433] Warn if in parallel build aggregator Mojo found

[GitBox]

michael-o commented on code in PR #730:
URL: https://github.com/apache/maven/pull/730#discussion_r870604293


##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java:
##
@@ -232,7 +237,17 @@ private static class ProjectLock implements AutoCloseable
 boolean aggregator = mojoDescriptor.isAggregator();
 acquiredAggregatorLock = aggregator ? 
aggregatorLock.writeLock() : aggregatorLock.readLock();
 acquiredProjectLock = getProjectLock( session );
-acquiredAggregatorLock.lock();
+if ( !acquiredAggregatorLock.tryLock() )
+{
+for ( String s : MessageHelper.formatWarning(

Review Comment:
   An aggregator mojo is already being executed in this parallel build, those 
kind of mojos require...
   
   ..until the aggregator mojo is done.



##
maven-core/src/main/java/org/apache/maven/internal/MessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format warning messages to the console
+ */
+public class MessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;

Review Comment:
   Stupid question, didn't we introduce dynamic sizing with Jansi since we can 
determine the terminal size?
   
   Note: this would also require to auto-reflow the content...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org