[GitHub] [maven-mvnd] hboutemy commented on issue #628: make libmvndnative.* builds reproducible

2022-05-04 Thread GitBox


hboutemy commented on issue #628:
URL: https://github.com/apache/maven-mvnd/issues/628#issuecomment-1116993223

   wow, really nice: I now have only 1 difference = 
`src/main/resources/org/mvndaemon/mvnd/nativ/Linux/x86/libmvndnative.so`
   I suppose this is due to the fact that it is my platform (I'm running 
Ubuntu), then my local build did not use the containerized build
   using diffoscope, I see
   ```
   │ -  [ 0]  GCC: (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
   │ +  [ 0]  GCC: (Debian 10.2.1-6) 10.2.1 20210110
   ```
   
   last remaining issue: I still have 1 Mac arch and the 2 FreeBSD archs 
created as root in target, with the FreeBSD ones copied to src as root also:
   ```
   $ ll target/
   total 80
   drwxrwxr-x 20 herve herve 4096 mai4 09:02 ./
   drwxrwxr-x  6 herve herve 4096 mai4 09:01 ../
   drwxr-xr-x  3 herve herve 4096 mai4 09:01 classes/
   drwxrwxr-x  6 herve herve 4096 mai4 09:01 crossbuild/
   drwxr-xr-x  7 herve herve 4096 mai4 09:02 ducible/
   drwxrwxr-x  4 herve herve 4096 mai4 09:01 inc/
   drwxr-xr-x  2 root  root  4096 mai4 09:02 native-FreeBSD-x86/
   drwxr-xr-x  2 root  root  4096 mai4 09:02 native-FreeBSD-x86_64/
   drwxr-xr-x  2 herve herve 4096 mai4 09:01 native-Linux-arm/
   drwxr-xr-x  2 herve herve 4096 mai4 09:01 native-Linux-arm64/
   drwxr-xr-x  2 herve herve 4096 mai4 09:01 native-Linux-armv6/
   drwxr-xr-x  2 herve herve 4096 mai4 09:01 native-Linux-armv7/
   drwxr-xr-x  2 herve herve 4096 mai4 09:01 native-Linux-ppc64/
   drwxr-xr-x  2 herve herve 4096 mai4 09:01 native-Linux-x86/
   drwxr-xr-x  2 herve herve 4096 mai4 09:01 native-Linux-x86_64/
   drwxr-xr-x  2 root  root  4096 mai4 09:02 native-Mac-arm64/
   drwxr-xr-x  2 herve herve 4096 mai4 09:02 native-Mac-x86/
   drwxr-xr-x  2 herve herve 4096 mai4 09:02 native-Mac-x86_64/
   drwxr-xr-x  2 herve herve 4096 mai4 09:02 native-Windows-x86/
   drwxr-xr-x  2 herve herve 4096 mai4 09:02 native-Windows-x86_64/
   
   $ ll src/main/resources/org/mvndaemon/mvnd/nativ/*/*
   src/main/resources/org/mvndaemon/mvnd/nativ/FreeBSD/x86:
   total 16
   drwxrwxr-x 2 herve herve 4096 mai4 09:02 ./
   drwxrwxr-x 4 herve herve 4096 mai4 09:01 ../
   -rwxr-xr-x 1 root  root  4803 mai4 09:02 libmvndnative.so*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/FreeBSD/x86_64:
   total 16
   drwxrwxr-x 2 herve herve 4096 mai4 09:02 ./
   drwxrwxr-x 4 herve herve 4096 mai4 09:01 ../
   -rwxr-xr-x 1 root  root  6755 mai4 09:02 libmvndnative.so*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Linux/arm:
   total 16
   drwxr-xr-x 2 herve herve 4096 mai4 09:01 ./
   drwxrwxr-x 9 herve herve 4096 mai4 08:58 ../
   -rwxrwxr-x 1 herve herve 7804 mai4 09:01 libmvndnative.so*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Linux/arm64:
   total 20
   drwxr-xr-x 2 herve herve 4096 mai4 09:01 ./
   drwxrwxr-x 9 herve herve 4096 mai4 08:58 ../
   -rwxrwxr-x 1 herve herve 8864 mai4 09:01 libmvndnative.so*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Linux/armv6:
   total 20
   drwxr-xr-x 2 herve herve 4096 mai4 09:01 ./
   drwxrwxr-x 9 herve herve 4096 mai4 08:58 ../
   -rwxrwxr-x 1 herve herve 8564 mai4 09:01 libmvndnative.so*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Linux/armv7:
   total 16
   drwxr-xr-x 2 herve herve 4096 mai4 09:01 ./
   drwxrwxr-x 9 herve herve 4096 mai4 08:58 ../
   -rwxrwxr-x 1 herve herve 7824 mai4 09:01 libmvndnative.so*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Linux/ppc64:
   total 24
   drwxr-xr-x 2 herve herve  4096 mai4 09:01 ./
   drwxrwxr-x 9 herve herve  4096 mai4 08:58 ../
   -rwxrwxr-x 1 herve herve 70304 mai4 09:01 libmvndnative.so*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Linux/x86:
   total 24
   drwxr-xr-x 2 herve herve  4096 mai4 09:01 ./
   drwxrwxr-x 9 herve herve  4096 mai4 08:58 ../
   -rwxrwxr-x 1 herve herve 15188 mai4 09:01 libmvndnative.so*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Linux/x86_64:
   total 20
   drwxr-xr-x 2 herve herve 4096 mai4 09:01 ./
   drwxrwxr-x 9 herve herve 4096 mai4 08:58 ../
   -rwxrwxr-x 1 herve herve 8384 mai4 09:01 libmvndnative.so*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Mac/arm64:
   total 60
   drwxrwxr-x 2 herve herve  4096 mai4 09:01 ./
   drwxrwxr-x 5 herve herve  4096 mai4 09:01 ../
   -rwxrwxr-x 1 herve herve 50801 mai4 09:02 libmvndnative.jnilib*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Mac/x86:
   total 20
   drwxr-xr-x 2 herve herve 4096 mai4 09:01 ./
   drwxrwxr-x 5 herve herve 4096 mai4 09:01 ../
   -rwxrwxr-x 1 herve herve 9044 mai4 09:02 libmvndnative.jnilib*
   
   src/main/resources/org/mvndaemon/mvnd/nativ/Mac/x86_64:
   total 20
   drwxr-xr-x 2 herve herve 4096 mai4 09:01 ./
   drwxrwxr-x 5 herve herve 4096 mai4 09:01 ../
   -rwxrwxr-x 1 herve herve 926

[GitHub] [maven-mvnd] mike-boost opened a new issue, #637: Timeout waiting to connect to the Maven daemon

2022-05-04 Thread GitBox


mike-boost opened a new issue, #637:
URL: https://github.com/apache/maven-mvnd/issues/637

   $ java -version  

 
   openjdk version "1.8.0_332"
   OpenJDK Runtime Environment (Zulu 8.62.0.19-CA-macosx) (build 1.8.0_332-b09)
   OpenJDK 64-Bit Server VM (Zulu 8.62.0.19-CA-macosx) (build 25.332-b09, mixed 
mode)
   
   
   $ $MVND_HOME/bin/mvnd --status   

   
 ID  PID   Address   StatusRSSLast 
activity  Java home
   
   
   
   
   $ $MVND_HOME/bin/mvnd --version  


   mvnd native client 0.7.1-darwin-amd64 
(97c587c11383a67b5bd0ff8388bd94c694b91c1e)
   Terminal: org.jline.terminal.impl.PosixSysTerminal with pty 
org.jline.terminal.impl.jansi.osx.OsXNativePty
   Exception in thread "main" 
org.mvndaemon.mvnd.common.DaemonException$ConnectException: Timeout waiting to 
connect to the Maven daemon.
   Daemon id: 2505973f
 no log file at: /Users/xxx/.m2/mvnd/registry/0.7.1/daemon-2505973f.log
 output: /Users/xxx/.m2/mvnd/registry/0.7.1/daemon-2505973f.out.log
   - Last  200 lines from daemon output - 
/Users/xxx/.m2/mvnd/registry/0.7.1/daemon-2505973f.out.log -
   Listening for transport dt_socket at address: 8000
   - End of the daemon output -
   
at 
org.mvndaemon.mvnd.client.DaemonConnector.startDaemon(DaemonConnector.java:299)
at 
org.mvndaemon.mvnd.client.DaemonConnector.connect(DaemonConnector.java:122)
at 
org.mvndaemon.mvnd.client.DefaultClient.execute(DefaultClient.java:272)
at org.mvndaemon.mvnd.client.DefaultClient.main(DefaultClient.java:118)
   
   
   $ $MVND_HOME/bin/mvnd --status   

 
 ID  PID   Address   StatusRSSLast 
activity  Java home
   
   
   
   $ $MVND_HOME/bin/mvnd clean install  

 
   Exception in thread "main" 
org.mvndaemon.mvnd.common.DaemonException$ConnectException: Timeout waiting to 
connect to the Maven daemon.
   Daemon id: 19a8bc0e
 no log file at: /Users/xxx/.m2/mvnd/registry/0.7.1/daemon-19a8bc0e.log
 output: /Users/xxx/.m2/mvnd/registry/0.7.1/daemon-19a8bc0e.out.log
   - Last  200 lines from daemon output - 
/Users/xxx/.m2/mvnd/registry/0.7.1/daemon-19a8bc0e.out.log -
   ERROR: transport error 202: bind failed: Address already in use
   ERROR: JDWP Transport dt_socket failed to initialize, TRANSPORT_INIT(510)
   JDWP exit error AGENT_ERROR_TRANSPORT_INIT(197): No transports initialized 
[debugInit.c:750]
   - End of the daemon output -
   
at 
org.mvndaemon.mvnd.client.DaemonConnector.startDaemon(DaemonConnector.java:299)
at 
org.mvndaemon.mvnd.client.DaemonConnector.connect(DaemonConnector.java:122)
at 
org.mvndaemon.mvnd.client.DefaultClient.execute(DefaultClient.java:272)
at org.mvndaemon.mvnd.client.DefaultClient.main(DefaultClient.java:118)
   
   
   
   $ ps -ef|grep mvnd  


  [
 501 84661 1   0  3:14下午 ttys0050:00.09 
/Users/xxx/.sdkman/candidates/java/8.0.332-zulu/bin/java -classpath 
/Users/xxx/Tools/mvnd/mvn/lib/ext/mvnd-common-0.7.1.jar:/Users/xxx/Tools/mvnd/mvn/lib/ext/mvnd-agent-0.7.1.jar
 -javaagent:/Users/xxx/Tools/mvnd/mvn/lib/ext/mvnd-agent-0.7.1.jar 
-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=8000 -Xms128M 
-Xmx2G -Xss1M -Dmvnd.home=/Users/xxx/Tools/mvnd 
-Dmvnd.java.home=/Users/xxx/.sdkman/candidates/java/8.0.332-zulu 
-Dlogback.configurationFile=/Users/xxx/Tools/mvnd/conf/logback.xml 
-Dmvnd.id=2505973f -Dmvnd.daemonStorage=/Users/xxx/.m2/mvnd/registry/0.7.1 
-Dmvnd.registry=/Users/xxx/.m2/mvnd/registry/0.7.1/registry.bin 
-Dmvnd.socketFamily=inet -Djdk.java.options= --add-opens 
java.base/java.io=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED 
--add-opens java.base/java.util=ALL-UNNAMED --add-opens 
java.base/sun.nio.fs=ALL-UNNAMED -Dmvnd.noDaemon=true -Dmvnd.debug=true 
-Dmvnd.idleTimeout=3h -Dmvnd.keepAlive=100m
 s -Dmvnd.extClasspath= -Dmvnd.coreExtensions= -Dmvnd.minHeapSize=128M 
-Dmvnd.maxHeapSize=2G -Dmvnd.th

[GitHub] [maven-mvnd] mike-boost commented on issue #637: Timeout waiting to connect to the Maven daemon

2022-05-04 Thread GitBox


mike-boost commented on issue #637:
URL: https://github.com/apache/maven-mvnd/issues/637#issuecomment-1117002495

   unable to use mvnd
   I tried install it with sdkman or binary, neither work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #23: [MSKINS-169] Image height not effective

2022-05-04 Thread GitBox


michael-o commented on code in PR #23:
URL: https://github.com/apache/maven-fluido-skin/pull/23#discussion_r864529221


##
pom.xml:
##
@@ -253,7 +253,6 @@ under the License.
   
 site
   
-  true

Review Comment:
   I can't tell whether this is enabled for other components as well, but the 
build.log will contain debug output which is very helpful in failure cases. If 
it is not enabled, you need to enable it temporarily and and run everything 
again. Just losing time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-fluido-skin] michael-o commented on pull request #23: [MSKINS-169] Image height not effective

2022-05-04 Thread GitBox


michael-o commented on PR #23:
URL: https://github.com/apache/maven-fluido-skin/pull/23#issuecomment-1117008828

   @kwin any change you can verify this in time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSKINS-170) Allow to show name as headline in addition to bannerLeft

2022-05-04 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531538#comment-17531538
 ] 

Michael Osipov commented on MSKINS-170:
---

I am totally blind and do not understand what you are trying to convey.
Is this related DOXIA-619?
I also consider {{h2}} as an abuse here because I consider headings to be used 
in content only, no? This is a header, not body.

> Allow to show name as headline in addition to bannerLeft
> 
>
> Key: MSKINS-170
> URL: https://issues.apache.org/jira/browse/MSKINS-170
> Project: Maven Skins
>  Issue Type: Improvement
>  Components: Fluido Skin
>Affects Versions: fluido-1.9
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently there is a fallback with text in case no bannerLeft is configured: 
> https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/META-INF/maven/site.vm#L188.
>  It would be nice to optionally show that next to the banner.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Comment Edited] (MSKINS-170) Allow to show name as headline in addition to bannerLeft

2022-05-04 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531538#comment-17531538
 ] 

Michael Osipov edited comment on MSKINS-170 at 5/4/22 7:46 AM:
---

I am totally blind and do not understand what you are trying to convey.
Is this related DOXIA-619?


was (Author: michael-o):
I am totally blind and do not understand what you are trying to convey.
Is this related DOXIA-619?
I also consider {{h2}} as an abuse here because I consider headings to be used 
in content only, no? This is a header, not body.

> Allow to show name as headline in addition to bannerLeft
> 
>
> Key: MSKINS-170
> URL: https://issues.apache.org/jira/browse/MSKINS-170
> Project: Maven Skins
>  Issue Type: Improvement
>  Components: Fluido Skin
>Affects Versions: fluido-1.9
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently there is a fallback with text in case no bannerLeft is configured: 
> https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/META-INF/maven/site.vm#L188.
>  It would be nice to optionally show that next to the banner.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-mvnd] cstamas closed pull request #635: Use "official" sisu-maven-plugin

2022-05-04 Thread GitBox


cstamas closed pull request #635: Use "official" sisu-maven-plugin
URL: https://github.com/apache/maven-mvnd/pull/635


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-7470) Add IT with quarkus plugin

2022-05-04 Thread Jira
Tamás Cservenák created MNG-7470:


 Summary: Add IT with quarkus plugin
 Key: MNG-7470
 URL: https://issues.apache.org/jira/browse/MNG-7470
 Project: Maven
  Issue Type: Task
  Components: Integration Tests
Reporter: Tamás Cservenák


Ideally just copy mvnd TypeDescriptionTest to maven ITs



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-integration-testing] cstamas opened a new pull request, #155: [MNG-7470] Quarkus build

2022-05-04 Thread GitBox


cstamas opened a new pull request, #155:
URL: https://github.com/apache/maven-integration-testing/pull/155

   A build "borrowed" as is from mvnd build that uses
   quarkus plugin, a notorius one for using resolver.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] slawekjaranowski commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration

2022-05-04 Thread GitBox


slawekjaranowski commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r864561100


##
maven-core/src/main/java/org/apache/maven/plugin/internal/ReadOnlyPluginParametersValidator.java:
##
@@ -0,0 +1,80 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.Parameter;
+import 
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Print warnings if read-only parameters of plugin are used in configuration.
+ *
+ * @author Slawomir Jaranowski
+ */
+@Named
+@Singleton
+public class ReadOnlyPluginParametersValidator extends 
AbstractMavenPluginParametersValidator
+{
+private static final Logger LOGGER = LoggerFactory.getLogger( 
ReadOnlyPluginParametersValidator.class );
+
+@Override
+protected Logger getLogger()
+{
+return LOGGER;
+}
+
+@Override
+protected String getParameterLogReason( Parameter parameter )
+{
+return "is read-only, should not be used in configuration";

Review Comment:
   Yes.
   according to RFC:
   
   > MUST NOT   This phrase, or the phrase "SHALL NOT", mean that the
  definition is an absolute prohibition of the specification.
   
   I will choose  `MUST NOT` - I hope it will be the most accurate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7464) Warn about using read-only parameters for Mojo in configuration

2022-05-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531596#comment-17531596
 ] 

ASF GitHub Bot commented on MNG-7464:
-

slawekjaranowski commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r864561100


##
maven-core/src/main/java/org/apache/maven/plugin/internal/ReadOnlyPluginParametersValidator.java:
##
@@ -0,0 +1,80 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.Parameter;
+import 
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Print warnings if read-only parameters of plugin are used in configuration.
+ *
+ * @author Slawomir Jaranowski
+ */
+@Named
+@Singleton
+public class ReadOnlyPluginParametersValidator extends 
AbstractMavenPluginParametersValidator
+{
+private static final Logger LOGGER = LoggerFactory.getLogger( 
ReadOnlyPluginParametersValidator.class );
+
+@Override
+protected Logger getLogger()
+{
+return LOGGER;
+}
+
+@Override
+protected String getParameterLogReason( Parameter parameter )
+{
+return "is read-only, should not be used in configuration";

Review Comment:
   Yes.
   according to RFC:
   
   > MUST NOT   This phrase, or the phrase "SHALL NOT", mean that the
  definition is an absolute prohibition of the specification.
   
   I will choose  `MUST NOT` - I hope it will be the most accurate





> Warn about using read-only parameters for Mojo in configuration
> ---
>
> Key: MNG-7464
> URL: https://issues.apache.org/jira/browse/MNG-7464
> Project: Maven
>  Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-mvnd] gnodet merged pull request #636: Use sisu apt processor

2022-05-04 Thread GitBox


gnodet merged PR #636:
URL: https://github.com/apache/maven-mvnd/pull/636


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2022-05-04 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531599#comment-17531599
 ] 

Michael Osipov commented on MSHADE-420:
---

I'd like to point out that MSHADE uses Java's zip implementation while all 
other plugins use Maven Archiver. This makes a difference. I would expect that 
for consistency reasons that MSHADE will move to Maven Archiver as well at some 
point in time.

> Reproducible Builds timestamp issue in some cases
> -
>
> Key: MSHADE-420
> URL: https://issues.apache.org/jira/browse/MSHADE-420
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.4
>Reporter: Herve Boutemy
>Priority: Major
>
> seen in Tika 
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/tika/tika-2.4.0.diffoscope
> maven-shade-plugin 3.2.4 has an issue with timestamps in unexplained 
> circumstances:
> why does 21-Nov-20 20:25 from reference become 21-Nov-21 01:25 in rebuild?
> why does 20-May-14 07:15 from reference become 20-May-14 11:15 in rebuild?
> could be related to the timezone of the rebuilder?
> {noformat}
> 21 / 44 target/reference/tika-parser-nlp-package-2.4.0.jar 
> tika-parsers/tika-parsers-ml/tika-parser-nlp-package/target/tika-parser-nlp-package-2.4.0.jar
> --- target/reference/tika-parser-nlp-package-2.4.0.jar
> +++ 
> tika-parsers/tika-parsers-ml/tika-parser-nlp-package/target/tika-parser-nlp-package-2.4.0.jar
> ├── zipinfo {}
> │ @@ -9868,1231 +9868,1231 @@
> │  -rw 2.0 fat 2653 bl defN 22-Apr-08 17:41 
> schemas/wsdl/ws-addr-wsdl.xsd
> │  -rw 2.0 fat 5591 bl defN 22-Apr-08 17:41 
> schemas/wsdl/ws-addr.xsd
> │  -rw 2.0 fat 1606 bl defN 22-Apr-08 17:41 schemas/wsdl/wsdl.xjb
> │  -rw 2.0 fat12126 bl defN 22-Apr-08 17:41 schemas/wsdl/wsdl.xsd
> │  -rw 2.0 fat 8198 bl defN 22-Apr-08 17:41 schemas/wsdl/wsrm.xsd
> │  -rw 2.0 fat  932 bl defN 22-Apr-08 17:41 schemas/wsdl/xmime.xsd
> │  -rw 2.0 fat 5840 bl defN 22-Apr-08 17:41 schemas/wsdl/xml.xsd
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 
> META-INF/maven/com.fasterxml.woodstox/
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/
> │ --rw 2.0 fat   70 bl defN 21-Nov-20 20:25 
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.properties
> │ --rw 2.0 fat15917 bl defN 21-Nov-20 20:25 
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.xml
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 com/ctc/
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 com/ctc/wstx/
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 com/ctc/wstx/api/
> ...
> │ --rw 2.0 fat  722 bl defN 20-May-14 07:15 
> org/codehaus/stax2/validation/XMLValidationSchema.class
> │ --rw 2.0 fat 7795 bl defN 20-May-14 07:15 
> org/codehaus/stax2/validation/XMLValidationSchemaFactory.class
> │ --rw 2.0 fat 1801 bl defN 20-May-14 07:15 
> org/codehaus/stax2/validation/XMLValidator.class
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 
> META-INF/maven/com.fasterxml.woodstox/
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/
> │ +-rw 2.0 fat   70 bl defN 21-Nov-21 01:25 
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.properties
> │ +-rw 2.0 fat15917 bl defN 21-Nov-21 01:25 
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.xml
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 com/ctc/
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 com/ctc/wstx/
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 com/ctc/wstx/api/
> ...
> │ +-rw 2.0 fat  722 bl defN 20-May-14 11:15 
> org/codehaus/stax2/validation/XMLValidationSchema.class
> │ +-rw 2.0 fat 7795 bl defN 20-May-14 11:15 
> org/codehaus/stax2/validation/XMLValidationSchemaFactory.class
> │ +-rw 2.0 fat 1801 bl defN 20-May-14 11:15 
> org/codehaus/stax2/validation/XMLValidator.class
> │  -rw 2.0 fat0 bl defN 21-Sep-14 14:41 
> META-INF/maven/org.apache.ws.xmlschema/
> │  -rw 2.0 fat0 bl defN 21-Sep-14 14:41 
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/
> │  -rw 2.0 fat  146 bl defN 21-Sep-14 14:41 
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/pom.properties
> │  -rw 2.0 fat 6857 bl defN 21-Sep-14 14:41 
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/pom.xml
> │  -rw 2.0 fat0 bl defN 21-Sep-14 14:41 org/apache/ws/
> │  -rw 2.0 fat0 bl defN 21-Sep-14 14:41 org/apache/ws/commons/
> │  -rw 2.0 fat   

[jira] [Created] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

2022-05-04 Thread Jira
Tamás Cservenák created MNG-7471:


 Summary: Resolver 1.8.0 introduces binary breakage in plugin using 
Resolver
 Key: MNG-7471
 URL: https://issues.apache.org/jira/browse/MNG-7471
 Project: Maven
  Issue Type: Bug
  Components: Class Loading
Affects Versions: 3.9.0-candidate
Reporter: Tamás Cservenák


With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
introduced for plugins using Resolver, as proven by new IT MNG-7470.

Problem is following:

Maven Core exports following packages:
 * resolver-api
 * resolver-spi
 * resolver-impl

This means, that a plugin will be forced to use these from core (1.8.0), but 
they will keep using their own resolver-connector-basic. Resolver 1.8.0 
introduces changes that affects the impl, connector-basic and spi, basically 
their own copy of connector-basic will fail.

Error that is thrown during execution of plugin using Resolver:
{{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: java.lang.NoSuchMethodError: 
'java.util.List 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
 boolean, java.net.URI)'}}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Updated] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

2022-05-04 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MNG-7471:
-
Description: 
With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
introduced for plugins using Resolver, as proven by new IT MNG-7470.

Problem is following:

Maven Core exports following packages:
 * resolver-api
 * resolver-spi
 * resolver-impl

This means, that a plugin will be forced to use these from core (1.8.0), but 
they will keep using their own resolver-connector-basic. Resolver 1.8.0 
introduces API changes that affects all of impl, connector-basic and spi, 
basically their own copy of connector-basic will fail.

Error that is thrown during execution of plugin using Resolver:
{{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: java.lang.NoSuchMethodError: 
'java.util.List 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
 boolean, java.net.URI)'}}

  was:
With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
introduced for plugins using Resolver, as proven by new IT MNG-7470.

Problem is following:

Maven Core exports following packages:
 * resolver-api
 * resolver-spi
 * resolver-impl

This means, that a plugin will be forced to use these from core (1.8.0), but 
they will keep using their own resolver-connector-basic. Resolver 1.8.0 
introduces changes that affects the impl, connector-basic and spi, basically 
their own copy of connector-basic will fail.

Error that is thrown during execution of plugin using Resolver:
{{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: java.lang.NoSuchMethodError: 
'java.util.List 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
 boolean, java.net.URI)'}}


> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> This means, that a plugin will be forced to use these from core (1.8.0), but 
> they will keep using their own resolver-connector-basic. Resolver 1.8.0 
> introduces API changes that affects all of impl, connector-basic and spi, 
> basically their own copy of connector-basic will fail.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Updated] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

2022-05-04 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MNG-7471:
-
Description: 
With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
introduced for plugins using Resolver, as proven by new IT MNG-7470.

Problem is following:

Maven Core exports following packages:
 * resolver-api
 * resolver-spi
 * resolver-impl

This means, that a plugin will be forced to use these from core (1.8.0), but 
they will keep using their own resolver-connector-basic. Resolver 1.8.0 
introduces API changes that affects all of impl, connector-basic and spi, 
basically their own copy of connector-basic will fail.

Error that is thrown during execution of plugin using Resolver:
{{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: java.lang.NoSuchMethodError: 
'java.util.List 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
 boolean, java.net.URI)'}}

Important note: the error is triggered only when remote download happens, so 
even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is pre-populated, 
hence, no remote download happens!

  was:
With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
introduced for plugins using Resolver, as proven by new IT MNG-7470.

Problem is following:

Maven Core exports following packages:
 * resolver-api
 * resolver-spi
 * resolver-impl

This means, that a plugin will be forced to use these from core (1.8.0), but 
they will keep using their own resolver-connector-basic. Resolver 1.8.0 
introduces API changes that affects all of impl, connector-basic and spi, 
basically their own copy of connector-basic will fail.

Error that is thrown during execution of plugin using Resolver:
{{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: java.lang.NoSuchMethodError: 
'java.util.List 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
 boolean, java.net.URI)'}}


> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> This means, that a plugin will be forced to use these from core (1.8.0), but 
> they will keep using their own resolver-connector-basic. Resolver 1.8.0 
> introduces API changes that affects all of impl, connector-basic and spi, 
> basically their own copy of connector-basic will fail.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Updated] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

2022-05-04 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MNG-7471:
-
Description: 
With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
introduced for plugins using Resolver, as proven by new IT MNG-7470.

Problem is following:

Maven Core exports following packages:
 * resolver-api
 * resolver-spi
 * resolver-impl

This means, that a plugin will be forced to use these from core (1.8.0), but 
they will keep using their own resolver-connector-basic. Resolver 1.8.0 
introduces API changes that affects all of impl, connector-basic and spi, 
basically their own copy of connector-basic will fail.

So plugin will have added its "own" dependencies to plugin realm with:
 * resolver-util
 * resolver-connector-basic

But alas, the interface change from resolver-spi will prevent class from 
resolver-connector-basic to be instantiated.

Error that is thrown during execution of plugin using Resolver:
{{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: java.lang.NoSuchMethodError: 
'java.util.List 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
 boolean, java.net.URI)'}}

Important note: the error is triggered only when remote download happens, so 
even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is pre-populated, 
hence, no remote download happens!

  was:
With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
introduced for plugins using Resolver, as proven by new IT MNG-7470.

Problem is following:

Maven Core exports following packages:
 * resolver-api
 * resolver-spi
 * resolver-impl

This means, that a plugin will be forced to use these from core (1.8.0), but 
they will keep using their own resolver-connector-basic. Resolver 1.8.0 
introduces API changes that affects all of impl, connector-basic and spi, 
basically their own copy of connector-basic will fail.

Error that is thrown during execution of plugin using Resolver:
{{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: java.lang.NoSuchMethodError: 
'java.util.List 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
 boolean, java.net.URI)'}}

Important note: the error is triggered only when remote download happens, so 
even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is pre-populated, 
hence, no remote download happens!


> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> This means, that a plugin will be forced to use these from core (1.8.0), but 
> they will keep using their own resolver-connector-basic. Resolver 1.8.0 
> introduces API changes that affects all of impl, connector-basic and spi, 
> basically their own copy of connector-basic will fail.
> So plugin will have added its "own" dependencies to plugin realm with:
>  * resolver-util
>  * resolver-connector-basic
> But alas, the interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Updated] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

2022-05-04 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamás Cservenák updated MNG-7471:
-
Description: 
With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
introduced for plugins using Resolver, as proven by new IT MNG-7470.

Problem is following:

Maven Core exports following packages:
 * resolver-api
 * resolver-spi
 * resolver-impl

While plugin will have added its "own" versions of these below to plugin realm:
 * resolver-util
 * resolver-connector-basic

This means, that a plugin will be forced to use api/spi/imp from core (1.8.0), 
but they will keep using their own util and connector-basic.

Resolver 1.8.0 introduces API changes that affects all of impl, connector-basic 
and spi, basically their own copy of connector-basic will fail. The interface 
change from resolver-spi will prevent class from resolver-connector-basic to be 
instantiated.

Error that is thrown during execution of plugin using Resolver:
{{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: java.lang.NoSuchMethodError: 
'java.util.List 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
 boolean, java.net.URI)'}}

Important note: the error is triggered only when remote download happens, so 
even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is pre-populated, 
hence, no remote download happens!

  was:
With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
introduced for plugins using Resolver, as proven by new IT MNG-7470.

Problem is following:

Maven Core exports following packages:
 * resolver-api
 * resolver-spi
 * resolver-impl

This means, that a plugin will be forced to use these from core (1.8.0), but 
they will keep using their own resolver-connector-basic. Resolver 1.8.0 
introduces API changes that affects all of impl, connector-basic and spi, 
basically their own copy of connector-basic will fail.

So plugin will have added its "own" dependencies to plugin realm with:
 * resolver-util
 * resolver-connector-basic

But alas, the interface change from resolver-spi will prevent class from 
resolver-connector-basic to be instantiated.

Error that is thrown during execution of plugin using Resolver:
{{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: java.lang.NoSuchMethodError: 
'java.util.List 
org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
 boolean, java.net.URI)'}}

Important note: the error is triggered only when remote download happens, so 
even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is pre-populated, 
hence, no remote download happens!


> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven] cstamas opened a new pull request, #732: [MNG-7471] Make Resolver util and connector-basic provided

2022-05-04 Thread GitBox


cstamas opened a new pull request, #732:
URL: https://github.com/apache/maven/pull/732

   The util is exportedArtifact AND exportedPackage
   The connector-basic is only exportedArtifact.
   
   Reasoning:
   * exportedArtifact -- prevents "own" artifact to be added to realm
   * exportedPackage -- makes it "visible" in realm
   
   So, this basically prevents bad versions of util and connector-basic
   enter the plugin realm (as they will be not added to it), while
   util remains "visible" to plugins, as the intent was, most
   common due GenericVersions etc.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7471


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7471) Resolver 1.8.0 introduces binary breakage in plugin using Resolver

2022-05-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531635#comment-17531635
 ] 

ASF GitHub Bot commented on MNG-7471:
-

cstamas opened a new pull request, #732:
URL: https://github.com/apache/maven/pull/732

   The util is exportedArtifact AND exportedPackage
   The connector-basic is only exportedArtifact.
   
   Reasoning:
   * exportedArtifact 

> Resolver 1.8.0 introduces binary breakage in plugin using Resolver
> --
>
> Key: MNG-7471
> URL: https://issues.apache.org/jira/browse/MNG-7471
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.9.0-candidate
>Reporter: Tamás Cservenák
>Priority: Major
>
> With Maven 3.9.0-SNAPSHOT (post MNG-7453 done) there is a binary breakage 
> introduced for plugins using Resolver, as proven by new IT MNG-7470.
> Problem is following:
> Maven Core exports following packages:
>  * resolver-api
>  * resolver-spi
>  * resolver-impl
> While plugin will have added its "own" versions of these below to plugin 
> realm:
>  * resolver-util
>  * resolver-connector-basic
> This means, that a plugin will be forced to use api/spi/imp from core 
> (1.8.0), but they will keep using their own util and connector-basic.
> Resolver 1.8.0 introduces API changes that affects all of impl, 
> connector-basic and spi, basically their own copy of connector-basic will 
> fail. The interface change from resolver-spi will prevent class from 
> resolver-connector-basic to be instantiated.
> Error that is thrown during execution of plugin using Resolver:
> {{Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> io.quarkus:quarkus-maven-plugin:2.3.1.Final:build: 
> java.lang.NoSuchMethodError: 'java.util.List 
> org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(org.eclipse.aether.artifact.Artifact,
>  boolean, java.net.URI)'}}
> Important note: the error is triggered only when remote download happens, so 
> even IT will pass OK with 3.9.0-SNAPSHOT IF local repository is 
> pre-populated, hence, no remote download happens!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-mvnd] gnodet merged pull request #638: Use maven-mvnd as a distribution name

2022-05-04 Thread GitBox


gnodet merged PR #638:
URL: https://github.com/apache/maven-mvnd/pull/638


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MJAVADOC-700) Plugin duplicates classes in Java 8 all-classes lists

2022-05-04 Thread Roman Huber (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531679#comment-17531679
 ] 

Roman Huber commented on MJAVADOC-700:
--

My guess is that either packages (@packages) or source files (@argfile) should 
be provided to the javadoc tool, not both. If a class is included in a package 
and a source file, it is added twice.

 

See 
[here|[http://example.com|https://github.com/apache/maven-javadoc-plugin/blob/40cc602f84dbb0689020b55b24970cdd7147722c/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L4762]]
 for a possible cause of accidentally adding the files. The path has been 
converted to '/' by MJAVADOC-584. But the comparison here is against '\'.

> Plugin duplicates classes in Java 8 all-classes  lists
> --
>
> Key: MJAVADOC-700
> URL: https://issues.apache.org/jira/browse/MJAVADOC-700
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0, 3.3.1
>Reporter: Rob Spoor
>Priority: Major
>
> Versions 3.3.0 and 3.3.1 of the Javadoc Plugin create allclasses-frame.html 
> and allclasses-noframe.html files that duplicate all classes, interfaces, etc.
> To reproduce:
> * Clone https://github.com/robtimus/data-url (a simple and small project that 
> can be used to showcase the issue)
> * Run {{mvn javadoc:javadoc}}, which uses version 3.2.0
> * Check target/site/apidocs/allclasses-frame.html - no duplicates
> * Run {{mvn javadoc:javadoc -Dversion.plugin.javadoc=3.3.0}} to build the 
> same with version 3.3.0
> * Check target/site/apidocs/allclasses-frame.html - all classes are duplicated
> The same issue occurs with {{javadoc:aggregate}}, possibly others as well.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Comment Edited] (MJAVADOC-700) Plugin duplicates classes in Java 8 all-classes lists

2022-05-04 Thread Roman Huber (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531679#comment-17531679
 ] 

Roman Huber edited comment on MJAVADOC-700 at 5/4/22 11:25 AM:
---

My guess is that either packages (@packages) or source files (@argfile) should 
be provided to the javadoc tool, not both. If a class is included in a package 
and a source file, it is added twice.

 

See 
[here|https://github.com/apache/maven-javadoc-plugin/blob/40cc602f84dbb0689020b55b24970cdd7147722c/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L4762]
 for a possible cause of accidentally adding the files. The path has been 
converted to '/' by MJAVADOC-584. But the comparison here is against '\'.


was (Author: alerosmile):
My guess is that either packages (@packages) or source files (@argfile) should 
be provided to the javadoc tool, not both. If a class is included in a package 
and a source file, it is added twice.

 

See 
[here|[http://example.com|https://github.com/apache/maven-javadoc-plugin/blob/40cc602f84dbb0689020b55b24970cdd7147722c/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L4762]]
 for a possible cause of accidentally adding the files. The path has been 
converted to '/' by MJAVADOC-584. But the comparison here is against '\'.

> Plugin duplicates classes in Java 8 all-classes  lists
> --
>
> Key: MJAVADOC-700
> URL: https://issues.apache.org/jira/browse/MJAVADOC-700
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0, 3.3.1
>Reporter: Rob Spoor
>Priority: Major
>
> Versions 3.3.0 and 3.3.1 of the Javadoc Plugin create allclasses-frame.html 
> and allclasses-noframe.html files that duplicate all classes, interfaces, etc.
> To reproduce:
> * Clone https://github.com/robtimus/data-url (a simple and small project that 
> can be used to showcase the issue)
> * Run {{mvn javadoc:javadoc}}, which uses version 3.2.0
> * Check target/site/apidocs/allclasses-frame.html - no duplicates
> * Run {{mvn javadoc:javadoc -Dversion.plugin.javadoc=3.3.0}} to build the 
> same with version 3.3.0
> * Check target/site/apidocs/allclasses-frame.html - all classes are duplicated
> The same issue occurs with {{javadoc:aggregate}}, possibly others as well.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Comment Edited] (MJAVADOC-700) Plugin duplicates classes in Java 8 all-classes lists

2022-05-04 Thread Roman Huber (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531679#comment-17531679
 ] 

Roman Huber edited comment on MJAVADOC-700 at 5/4/22 11:25 AM:
---

My guess is that either packages (@packages) or source files (@argfile) should 
be provided to the javadoc tool, not both. If a class is included in a package 
and a source file, it is added twice.

See 
[here|https://github.com/apache/maven-javadoc-plugin/blob/40cc602f84dbb0689020b55b24970cdd7147722c/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L4762]
 for a possible cause of accidentally adding the files. The path has been 
converted to '/' by MJAVADOC-584. But the comparison here is against '\'.


was (Author: alerosmile):
My guess is that either packages (@packages) or source files (@argfile) should 
be provided to the javadoc tool, not both. If a class is included in a package 
and a source file, it is added twice.

 

See 
[here|https://github.com/apache/maven-javadoc-plugin/blob/40cc602f84dbb0689020b55b24970cdd7147722c/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L4762]
 for a possible cause of accidentally adding the files. The path has been 
converted to '/' by MJAVADOC-584. But the comparison here is against '\'.

> Plugin duplicates classes in Java 8 all-classes  lists
> --
>
> Key: MJAVADOC-700
> URL: https://issues.apache.org/jira/browse/MJAVADOC-700
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0, 3.3.1
>Reporter: Rob Spoor
>Priority: Major
>
> Versions 3.3.0 and 3.3.1 of the Javadoc Plugin create allclasses-frame.html 
> and allclasses-noframe.html files that duplicate all classes, interfaces, etc.
> To reproduce:
> * Clone https://github.com/robtimus/data-url (a simple and small project that 
> can be used to showcase the issue)
> * Run {{mvn javadoc:javadoc}}, which uses version 3.2.0
> * Check target/site/apidocs/allclasses-frame.html - no duplicates
> * Run {{mvn javadoc:javadoc -Dversion.plugin.javadoc=3.3.0}} to build the 
> same with version 3.3.0
> * Check target/site/apidocs/allclasses-frame.html - all classes are duplicated
> The same issue occurs with {{javadoc:aggregate}}, possibly others as well.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Comment Edited] (MJAVADOC-700) Plugin duplicates classes in Java 8 all-classes lists

2022-05-04 Thread Roman Huber (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531679#comment-17531679
 ] 

Roman Huber edited comment on MJAVADOC-700 at 5/4/22 11:26 AM:
---

My guess is that either packages (@packages) or source files (@argfile) should 
be provided to the javadoc tool, not both. If a class is included in a package 
and a source file, it is added twice.

See 
[here|https://github.com/apache/maven-javadoc-plugin/blob/40cc602f84dbb0689020b55b24970cdd7147722c/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L4762]
 for a possible cause of accidentally adding the files. The path has been 
converted to '/' by MJAVADOC-584. But the comparison here on Windows is against 
'\'.


was (Author: alerosmile):
My guess is that either packages (@packages) or source files (@argfile) should 
be provided to the javadoc tool, not both. If a class is included in a package 
and a source file, it is added twice.

See 
[here|https://github.com/apache/maven-javadoc-plugin/blob/40cc602f84dbb0689020b55b24970cdd7147722c/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L4762]
 for a possible cause of accidentally adding the files. The path has been 
converted to '/' by MJAVADOC-584. But the comparison here is against '\'.

> Plugin duplicates classes in Java 8 all-classes  lists
> --
>
> Key: MJAVADOC-700
> URL: https://issues.apache.org/jira/browse/MJAVADOC-700
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0, 3.3.1
>Reporter: Rob Spoor
>Priority: Major
>
> Versions 3.3.0 and 3.3.1 of the Javadoc Plugin create allclasses-frame.html 
> and allclasses-noframe.html files that duplicate all classes, interfaces, etc.
> To reproduce:
> * Clone https://github.com/robtimus/data-url (a simple and small project that 
> can be used to showcase the issue)
> * Run {{mvn javadoc:javadoc}}, which uses version 3.2.0
> * Check target/site/apidocs/allclasses-frame.html - no duplicates
> * Run {{mvn javadoc:javadoc -Dversion.plugin.javadoc=3.3.0}} to build the 
> same with version 3.3.0
> * Check target/site/apidocs/allclasses-frame.html - all classes are duplicated
> The same issue occurs with {{javadoc:aggregate}}, possibly others as well.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Commented] (MNG-7078) The integration tests use the user maven settings

2022-05-04 Thread Jira


[ 
https://issues.apache.org/jira/browse/MNG-7078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531691#comment-17531691
 ] 

Tamás Cservenák commented on MNG-7078:
--

On related note: IF no user settings.xml present, then Central is redefined (by 
IT env I guess) as `central:file://...` repository. This implies, that our IT 
suite is NOT testing maven in a way, that all our users use it, by getting 
dependencies via HTTP protocol, but by getting them via file:// protocol...

And I find it kinda awkward, as it implies that HTTP bugs cannot be revealed 
with IT suite?

> The integration tests use the user maven settings
> -
>
> Key: MNG-7078
> URL: https://issues.apache.org/jira/browse/MNG-7078
> Project: Maven
>  Issue Type: Improvement
>  Components: Integration Tests
>Reporter: Guillaume Nodet
>Priority: Major
>
> I have a profile that caused one integration test to fail, but it took me 
> some time to realise the problem came from my {{~/.m2/settings.xml}} file.  
> It would be better to have the tests use an empty settings file.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Comment Edited] (MNG-7078) The integration tests use the user maven settings

2022-05-04 Thread Jira


[ 
https://issues.apache.org/jira/browse/MNG-7078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531691#comment-17531691
 ] 

Tamás Cservenák edited comment on MNG-7078 at 5/4/22 11:58 AM:
---

On related note: IF no user settings.xml present, then Central is redefined (by 
IT env I guess) as `central:[file://|file:///]...` repository. This implies, 
that our IT suite is NOT testing maven in a way, that all our users use it, by 
getting dependencies via HTTP protocol, but by getting them via 
[file://|file:///] protocol...

And I find it kinda awkward, as it implies that HTTP bugs cannot be revealed 
with IT suite?

For some context: there is MNG-7471 that is triggered ONLY if remote download 
happens via HTTP transport (wagon or native, does not matter). How to write IT 
for it?


was (Author: cstamas):
On related note: IF no user settings.xml present, then Central is redefined (by 
IT env I guess) as `central:file://...` repository. This implies, that our IT 
suite is NOT testing maven in a way, that all our users use it, by getting 
dependencies via HTTP protocol, but by getting them via file:// protocol...

And I find it kinda awkward, as it implies that HTTP bugs cannot be revealed 
with IT suite?

> The integration tests use the user maven settings
> -
>
> Key: MNG-7078
> URL: https://issues.apache.org/jira/browse/MNG-7078
> Project: Maven
>  Issue Type: Improvement
>  Components: Integration Tests
>Reporter: Guillaume Nodet
>Priority: Major
>
> I have a profile that caused one integration test to fail, but it took me 
> some time to realise the problem came from my {{~/.m2/settings.xml}} file.  
> It would be better to have the tests use an empty settings file.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-mvnd] gnodet merged pull request #639: Use the easier --user option of docker

2022-05-04 Thread GitBox


gnodet merged PR #639:
URL: https://github.com/apache/maven-mvnd/pull/639


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPDF-104) i18n broken

2022-05-04 Thread Xavi Lee (Jira)
Xavi Lee created MPDF-104:
-

 Summary: i18n broken
 Key: MPDF-104
 URL: https://issues.apache.org/jira/browse/MPDF-104
 Project: Maven PDF Plugin
  Issue Type: Bug
Affects Versions: 1.6.0
Reporter: Xavi Lee


In mybatis release pdf, we can see it doesn't display the words of non English. 
It's "#".

If you think it's not plugin problem, please give me a proper example for using 
i18n. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Updated] (MPDF-104) i18n broken

2022-05-04 Thread Xavi Lee (Jira)


 [ 
https://issues.apache.org/jira/browse/MPDF-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xavi Lee updated MPDF-104:
--
Attachment: 164194106-b4c23811-dee7-4849-abc4-6d88d7005d93.png

> i18n broken
> ---
>
> Key: MPDF-104
> URL: https://issues.apache.org/jira/browse/MPDF-104
> Project: Maven PDF Plugin
>  Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Xavi Lee
>Priority: Major
> Attachments: 164194106-b4c23811-dee7-4849-abc4-6d88d7005d93.png
>
>
> In mybatis release pdf, we can see it doesn't display the words of non 
> English. It's "#".
> If you think it's not plugin problem, please give me a proper example for 
> using i18n. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Updated] (MPDF-104) i18n broken

2022-05-04 Thread Xavi Lee (Jira)


 [ 
https://issues.apache.org/jira/browse/MPDF-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xavi Lee updated MPDF-104:
--
Description: 
In mybatis release pdf, we can see it doesn't display the words of non English. 
It's "#".

If you think it's not plugin problem, please give me a proper example for using 
i18n.  !164194106-b4c23811-dee7-4849-abc4-6d88d7005d93.png!

  was:
In mybatis release pdf, we can see it doesn't display the words of non English. 
It's "#".

If you think it's not plugin problem, please give me a proper example for using 
i18n. 


> i18n broken
> ---
>
> Key: MPDF-104
> URL: https://issues.apache.org/jira/browse/MPDF-104
> Project: Maven PDF Plugin
>  Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Xavi Lee
>Priority: Major
> Attachments: 164194106-b4c23811-dee7-4849-abc4-6d88d7005d93.png
>
>
> In mybatis release pdf, we can see it doesn't display the words of non 
> English. It's "#".
> If you think it's not plugin problem, please give me a proper example for 
> using i18n.  !164194106-b4c23811-dee7-4849-abc4-6d88d7005d93.png!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-mvnd] bonepl opened a new issue, #640: Add scoop installation to readme

2022-05-04 Thread GitBox


bonepl opened a new issue, #640:
URL: https://github.com/apache/maven-mvnd/issues/640

   Hi, this should be quick. 
   I would add scoop (http://scoop.sh) installation instructions below 
Chocolatey in readme.
   
   To install mvnd from scoop you need to
   `scoop install mvndaemon`
   
   It is available in main scoop repository, no additional setup required:
   https://github.com/ScoopInstaller/Main/blob/master/bucket/mvndaemon.json


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-mvnd] gnodet commented on issue #640: Add scoop installation to readme

2022-05-04 Thread GitBox


gnodet commented on issue #640:
URL: https://github.com/apache/maven-mvnd/issues/640#issuecomment-1117298919

   Thx ! I'm currently trying to get a 0.8.0 out and a bunch of things will 
change regarding the way `mvnd` will be available (mainly from the ASF download 
mirrors), so I think the above json will have to change.  I'd rather defer 
until this is fixed properly, but feel free to provide a PR so that we can 
merge it when 0.8.0 is out and the json fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] sbabcoc commented on pull request #528: SUREFIRE-2075: Only set thread count if specified in configuration

2022-05-04 Thread GitBox


sbabcoc commented on PR #528:
URL: https://github.com/apache/maven-surefire/pull/528#issuecomment-1117550351

   @Tibor17 With the revisions in this PR, the ASF TestNG implementation will 
exhibit the behavior you've described.
   * With no value specified for the [parallel] setting, tests execute 
sequentially on a single thread.
   * If any valid value is specified for the [parallel] setting (other than 
`none`), tests execute in parallel...
 *  ... on 5 threads if the [threadCount] setting is unspecified (as 
indicated by the ASF documentation).
 * ... on [threadCount] threads if a valid integer value is specified for 
this setting.
   
   Without the revisions in this PR, tests always execute sequentially unless 
valid values are provided for both [parallel] and [threadCount]. Specifying 
[parallel] by itself is insufficient to activate parallel execution behavior. 
This contradicts the ASF documentation and alters the execution behavior 
exhibited natively by TestNG or in other test harnesses (e.g. - Gradle).
   
   The revisions in this PR resolve the issue of default [threadCount] value 
and always provide parallel execution behavior when [parallel] is specified. It 
also emits an actionable error message if an invalid value is specified for 
[threadCount], instead of the naked **NumberFormatException** that is currently 
produced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7464) Warn about using read-only parameters for Mojo in configuration

2022-05-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531872#comment-17531872
 ] 

Hudson commented on MNG-7464:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-731 #5

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-731/5/

> Warn about using read-only parameters for Mojo in configuration
> ---
>
> Key: MNG-7464
> URL: https://issues.apache.org/jira/browse/MNG-7464
> Project: Maven
>  Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-mvnd] ppalaga merged pull request #641: Update RELEASING.adoc

2022-05-04 Thread GitBox


ppalaga merged PR #641:
URL: https://github.com/apache/maven-mvnd/pull/641


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-mvnd] ppalaga commented on pull request #641: Update RELEASING.adoc

2022-05-04 Thread GitBox


ppalaga commented on PR #641:
URL: https://github.com/apache/maven-mvnd/pull/641#issuecomment-1117786178

   Thanks @delanym!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] djohle commented on pull request #295: [MNG-5600] Dependency management import should support exclusions

2022-05-04 Thread GitBox


djohle commented on PR #295:
URL: https://github.com/apache/maven/pull/295#issuecomment-1117940950

   Not to be a "me 2" here, but I ran into this issue today.  But I figured I 
would at least comment to show my support of including this change.
   
   I was centralizing some repeatedly used dependencies in a multi-module 
project via dependencyManagement in the parent POM.  These dependencies came 
with some excludes (fortunately the same one in each usage), so I put those in 
the parent as well.  Was quite surprised that building my application resulted 
in 2x the size of the final package and a complete failure to function at all 
(there is a reason I do these exclusions!).  To work around this I had to 
re-add the exclusions to each of the relevant modules.
   
   Like the previous comment...I can totally understand if there are reasons 
for blockage, but those are not apparent.  Looking back to the beginning, this 
enhancement/fix is over 4 years old now!  Kind of sucks to see an 
already-solved issues be ignored like this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-5600) Dependency management import should support exclusions.

2022-05-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531946#comment-17531946
 ] 

ASF GitHub Bot commented on MNG-5600:
-

djohle commented on PR #295:
URL: https://github.com/apache/maven/pull/295#issuecomment-1117940950

   Not to be a "me 2" here, but I ran into this issue today.  But I figured I 
would at least comment to show my support of including this change.
   
   I was centralizing some repeatedly used dependencies in a multi-module 
project via dependencyManagement in the parent POM.  These dependencies came 
with some excludes (fortunately the same one in each usage), so I put those in 
the parent as well.  Was quite surprised that building my application resulted 
in 2x the size of the final package and a complete failure to function at all 
(there is a reason I do these exclusions!).  To work around this I had to 
re-add the exclusions to each of the relevant modules.
   
   Like the previous comment...I can totally understand if there are reasons 
for blockage, but those are not apparent.  Looking back to the beginning, this 
enhancement/fix is over 4 years old now!  Kind of sucks to see an 
already-solved issues be ignored like this.




> Dependency management import should support exclusions.
> ---
>
> Key: MNG-5600
> URL: https://issues.apache.org/jira/browse/MNG-5600
> Project: Maven
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Radai Rosenblatt
>Priority: Major
> Fix For: 4.0.x-candidate
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> suppose i have a multi-module project that uses spring, and so have this in 
> dependency-managements in a parent pom:
> {code:xml}
> 
>   org.springframework
>   spring-framework-bom
>   ${org.springframework.version}
>   pom
>   import   
> 
> {code}
> spring artifacts (or at least a lot of them) have a dependency on 
> commons-logging. right now, if i want to exclude commons-logging i have to 
> add an exclusion to every spring dependency in every module of my project, 
> which is actually more XML overall than giving up on using the bom dependency 
> altogether and listing all spring dependencies with excludes once in the 
> parent dependency management.
> I'd like to be able to do this:
> {code:xml}
> 
>   org.springframework
>   spring-framework-bom
>   ${org.springframework.version}
>   pom
>   import
>   
>   
>   commons-logging
>   commons-logging
>   
>   
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-release] slawekjaranowski commented on pull request #118: Catch up

2022-05-04 Thread GitBox


slawekjaranowski commented on PR #118:
URL: https://github.com/apache/maven-release/pull/118#issuecomment-1117963562

   
`maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml` 
was changed so we need change `expected-*-pom.xml` for UT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-release] slawekjaranowski commented on a diff in pull request #118: Catch up

2022-05-04 Thread GitBox


slawekjaranowski commented on code in PR #118:
URL: https://github.com/apache/maven-release/pull/118#discussion_r865414828


##
maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractReleaseTestCase.java:
##
@@ -213,7 +213,13 @@ public FileVisitResult visitFile( Path file, 
BasicFileAttributes attrs )
 for ( MavenProject project  : reactorProjects )
 {
 MavenProject resolvedProject = projectBuilder.build( 
project.getFile(), buildingRequest ).getProject();
-
+
+// FIXME ... setDependencyArtifacts -  set direct dependencies ...
+// but in 
org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseDependencies
+// getArtifacts is used ...
+
+// so we probably also need call setResolvedArtifacts
+

Review Comment:
   Probable cause of ignore tests in AbstractRewritingReleasePhaseTestCase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] slawekjaranowski closed pull request #525: Bump maven-parent from 35 to 36

2022-05-04 Thread GitBox


slawekjaranowski closed pull request #525: Bump maven-parent from 35 to 36
URL: https://github.com/apache/maven-surefire/pull/525


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] dependabot[bot] commented on pull request #525: Bump maven-parent from 35 to 36

2022-05-04 Thread GitBox


dependabot[bot] commented on PR #525:
URL: https://github.com/apache/maven-surefire/pull/525#issuecomment-1117974718

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] slawekjaranowski merged pull request #505: [SUREFIRE-2055] Always show random seed

2022-05-04 Thread GitBox


slawekjaranowski merged PR #505:
URL: https://github.com/apache/maven-surefire/pull/505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (SUREFIRE-2055) Always show random seed

2022-05-04 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed SUREFIRE-2055.
-
Resolution: Fixed

> Always show random seed
> ---
>
> Key: SUREFIRE-2055
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2055
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Delany
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.0.0-M7
>
>
> When I run tests in random order I get the message "Tests will run in random 
> order. To reproduce ordering use flag 
> -Dsurefire.runOrder.random.seed=55174043965113"
> When I provide the seed, I don't get the message, so there's no record of the 
> seed in the log.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Updated] (SUREFIRE-2055) Always show random seed

2022-05-04 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated SUREFIRE-2055:
--
Fix Version/s: 3.0.0-M7

> Always show random seed
> ---
>
> Key: SUREFIRE-2055
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2055
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Delany
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.0.0-M7
>
>
> When I run tests in random order I get the message "Tests will run in random 
> order. To reproduce ordering use flag 
> -Dsurefire.runOrder.random.seed=55174043965113"
> When I provide the seed, I don't get the message, so there's no record of the 
> seed in the log.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-surefire] slawekjaranowski commented on pull request #499: Remove TestListResolver#optionallyWildcardFilter

2022-05-04 Thread GitBox


slawekjaranowski commented on PR #499:
URL: https://github.com/apache/maven-surefire/pull/499#issuecomment-1117978121

   Kindly reminder @Tibor17 or someone else ... 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')

2022-05-04 Thread GitBox


Tibor17 commented on PR #233:
URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-1117983506

   @dejan2609 
   You are welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-mvnd] finalcreator commented on issue #637: Timeout waiting to connect to the Maven daemon

2022-05-04 Thread GitBox


finalcreator commented on issue #637:
URL: https://github.com/apache/maven-mvnd/issues/637#issuecomment-1118111390

   try with latest 0.8.1 build from source, still failed
   
   $ java -version  

   openjdk version "11.0.15" 2022-04-19
   OpenJDK Runtime Environment GraalVM CE 20.3.6 (build 
11.0.15+10-jvmci-20.3-b33)
   OpenJDK 64-Bit Server VM GraalVM CE 20.3.6 (build 11.0.15+10-jvmci-20.3-b33, 
mixed mode, sharing)
   
   $ /Users/xxx/Tools/mvnd081/bin/mvnd -v   
 
   mvnd 0.8.1-SNAPSHOT darwin-amd64 native client 
(c3612be87eedac16826572e831618291b777213e)
   Terminal: org.jline.terminal.impl.PosixSysTerminal with pty 
org.jline.terminal.impl.jansi.osx.OsXNativePty
   Exception in thread "main" 
org.mvndaemon.mvnd.common.DaemonException$ConnectException: Timeout waiting to 
connect to the Maven daemon.
   Daemon id: ee87ff3f
 no log file at: 
/Users/xxx/.m2/mvnd/registry/0.8.1-SNAPSHOT/daemon-ee87ff3f.log
 output: /Users/xxx/.m2/mvnd/registry/0.8.1-SNAPSHOT/daemon-ee87ff3f.out.log
   - Last  200 lines from daemon output - 
/Users/xxx/.m2/mvnd/registry/0.8.1-SNAPSHOT/daemon-ee87ff3f.out.log -
   NOTE: Picked up JDK_JAVA_OPTIONS: --add-opens java.base/java.io=ALL-UNNAMED 
--add-opens java.base/java.lang=ALL-UNNAMED --add-opens 
java.base/java.util=ALL-UNNAMED --add-opens 
java.base/sun.net.www.protocol.jar=ALL-UNNAMED --add-opens 
java.base/sun.nio.fs=ALL-UNNAMED
   Listening for transport dt_socket at address: 8000
   - End of the daemon output -
   
 at 
org.mvndaemon.mvnd.client.DaemonConnector.startDaemon(DaemonConnector.java:298)
 at 
org.mvndaemon.mvnd.client.DaemonConnector.connect(DaemonConnector.java:121)
 at org.mvndaemon.mvnd.client.DefaultClient.execute(DefaultClient.java:284)
 at org.mvndaemon.mvnd.client.DefaultClient.main(DefaultClient.java:129)
   FAIL
   
   
   
   $ cat /Users/xxx/.m2/mvnd/registry/0.8.1-SNAPSHOT/daemon-ee87ff3f.out.log
  
   NOTE: Picked up JDK_JAVA_OPTIONS: --add-opens java.base/java.io=ALL-UNNAMED 
--add-opens java.base/java.lang=ALL-UNNAMED --add-opens 
java.base/java.util=ALL-UNNAMED --add-opens 
java.base/sun.net.www.protocol.jar=ALL-UNNAMED --add-opens 
java.base/sun.nio.fs=ALL-UNNAMED
   Listening for transport dt_socket at address: 8000
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] dependabot[bot] opened a new pull request, #130: Bump maven-plugins from 35 to 36

2022-05-04 Thread GitBox


dependabot[bot] opened a new pull request, #130:
URL: https://github.com/apache/maven-shade-plugin/pull/130

   Bumps [maven-plugins](https://github.com/apache/maven-parent) from 35 to 36.
   
   Release notes
   Sourced from https://github.com/apache/maven-parent/releases";>maven-plugins's 
releases.
   
   36
   What's Changed
   
   [MPOM-300] switch from GA to ASF Matomo. by https://github.com/bmarwell";>@​bmarwell in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58
   [MPOM-308] Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0 by https://github.com/slawekjaranowski";>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-parent/pull/59";>apache/maven-parent#59
   Bump taglist-maven-plugin from 2.4 to 3.0.0 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/45";>apache/maven-parent#45
   Bump maven-jxr-plugin from 3.1.1 to 3.2.0 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/60";>apache/maven-parent#60
   [MPOM-313] execute checkstyle in early phase of the build by https://github.com/olamy";>@​olamy in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55
   [MPOM-314] Upgrade modello-maven-plugin from 1.11 to 2.0.0 by https://github.com/slawekjaranowski";>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-parent/pull/61";>apache/maven-parent#61
   Bump apache from 25 to 26 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/62";>apache/maven-parent#62
   
   New Contributors
   
   https://github.com/bmarwell";>@​bmarwell made 
their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58
   https://github.com/olamy";>@​olamy made their 
first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55
   
   Full Changelog: https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36";>https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36
   
   
   
   Commits
   
   See full diff in https://github.com/apache/maven-parent/commits";>compare view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.plugins:maven-plugins&package-manager=maven&previous-version=35&new-version=36)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #126: Bump maven-plugins from 34 to 35

2022-05-04 Thread GitBox


dependabot[bot] commented on PR #126:
URL: 
https://github.com/apache/maven-shade-plugin/pull/126#issuecomment-1118145642

   Superseded by #130.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #126: Bump maven-plugins from 34 to 35

2022-05-04 Thread GitBox


dependabot[bot] closed pull request #126: Bump maven-plugins from 34 to 35
URL: https://github.com/apache/maven-shade-plugin/pull/126


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #58: Bump asm-commons from 9.2 to 9.3

2022-05-04 Thread GitBox


dependabot[bot] opened a new pull request, #58:
URL: https://github.com/apache/maven-help-plugin/pull/58

   Bumps asm-commons from 9.2 to 9.3.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.ow2.asm:asm-commons&package-manager=maven&previous-version=9.2&new-version=9.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (SUREFIRE-2081) Upgrade Parent to 36

2022-05-04 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created SUREFIRE-2081:
-

 Summary: Upgrade Parent to 36
 Key: SUREFIRE-2081
 URL: https://issues.apache.org/jira/browse/SUREFIRE-2081
 Project: Maven Surefire
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.0.0-M7






--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Commented] (MPDF-104) i18n broken

2022-05-04 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPDF-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532070#comment-17532070
 ] 

Michael Osipov commented on MPDF-104:
-

Wild guess, no Unicode glyph mapping. Need to check.

> i18n broken
> ---
>
> Key: MPDF-104
> URL: https://issues.apache.org/jira/browse/MPDF-104
> Project: Maven PDF Plugin
>  Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Xavi Lee
>Priority: Major
> Attachments: 164194106-b4c23811-dee7-4849-abc4-6d88d7005d93.png
>
>
> In mybatis release pdf, we can see it doesn't display the words of non 
> English. It's "#".
> If you think it's not plugin problem, please give me a proper example for 
> using i18n.  !164194106-b4c23811-dee7-4849-abc4-6d88d7005d93.png!



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-surefire] slawekjaranowski opened a new pull request, #530: [SUREFIRE-2081] Upgrade Parent to 36

2022-05-04 Thread GitBox


slawekjaranowski opened a new pull request, #530:
URL: https://github.com/apache/maven-surefire/pull/530

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-checkstyle-plugin] dependabot[bot] opened a new pull request, #75: Bump maven-project-info-reports-plugin from 3.1.2 to 3.3.0

2022-05-04 Thread GitBox


dependabot[bot] opened a new pull request, #75:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/75

   Bumps 
[maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin)
 from 3.1.2 to 3.3.0.
   
   Commits
   
   https://github.com/apache/maven-project-info-reports-plugin/commit/563a0b261722719f9bf6ead946f3d5e30ef611c8";>563a0b2
 [maven-release-plugin] prepare release 
maven-project-info-reports-plugin-3.3.0
   https://github.com/apache/maven-project-info-reports-plugin/commit/9549763fbbdea2ee504412b06c2df1d14c25cb4a";>9549763
 [MPIR-416] Upgrade maven-dependency-tree to 3.1.0
   https://github.com/apache/maven-project-info-reports-plugin/commit/eab4f24d5cfc44aa91f62bde51e5f8001b36334f";>eab4f24
 [MPIR-417] Upgrade Parent to 36
   https://github.com/apache/maven-project-info-reports-plugin/commit/3538a85109299b942b3feab5a76b93d6d86d2b5c";>3538a85
 Bump project version for next release candidate
   https://github.com/apache/maven-project-info-reports-plugin/commit/634275979993b45426af278b0c1c886b32fa130a";>6342759
 PR template
   https://github.com/apache/maven-project-info-reports-plugin/commit/8d7b024591e8a4dad675b6a97ebbfb5f86fd2668";>8d7b024
 Use shared GitHub actions
   https://github.com/apache/maven-project-info-reports-plugin/commit/f784eef507716c789c2e05a93750c508ce8b9947";>f784eef
 [MPIR-399] Upgrade to Maven 3.2.5
   https://github.com/apache/maven-project-info-reports-plugin/commit/62f490b101f01215e39a86f2810679a77249e024";>62f490b
 [MPIR-415] Wrong old goal name in "Incompatibility Notice" table in 
website
   https://github.com/apache/maven-project-info-reports-plugin/commit/5bb94e115426c59340db739c9fc3302480528c63";>5bb94e1
 [maven-release-plugin] prepare for next development iteration
   https://github.com/apache/maven-project-info-reports-plugin/commit/ca84755a9d1f58f6bd39e70457fb0d36ce3755c4";>ca84755
 [maven-release-plugin] prepare release 
maven-project-info-reports-plugin-3.2.2
   Additional commits viewable in https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.1.2...maven-project-info-reports-plugin-3.3.0";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.plugins:maven-project-info-reports-plugin&package-manager=maven&previous-version=3.1.2&new-version=3.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-checkstyle-plugin] dependabot[bot] commented on pull request #69: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2

2022-05-04 Thread GitBox


dependabot[bot] commented on PR #69:
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/69#issuecomment-1118197365

   Superseded by #75.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-checkstyle-plugin] dependabot[bot] closed pull request #69: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2

2022-05-04 Thread GitBox


dependabot[bot] closed pull request #69: Bump maven-project-info-reports-plugin 
from 3.1.2 to 3.2.2
URL: https://github.com/apache/maven-checkstyle-plugin/pull/69


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-mvnd] gnodet commented on issue #637: Timeout waiting to connect to the Maven daemon

2022-05-04 Thread GitBox


gnodet commented on issue #637:
URL: https://github.com/apache/maven-mvnd/issues/637#issuecomment-1118201285

   Can you try using the shell script `mvnd.sh` ?
   Could you also try creating a user with a name with only ascii characters 
and try with it (so that there's no unicode chars in the installation path and 
user home  ?
   Also, try running `java -jar $MVND_HOME/mvn/lib/ext/jansi-2.4.0.jar` and 
paste the output in case...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-mvnd] ppalaga commented on issue #637: Timeout waiting to connect to the Maven daemon

2022-05-04 Thread GitBox


ppalaga commented on issue #637:
URL: https://github.com/apache/maven-mvnd/issues/637#issuecomment-1118211721

   > Listening for transport dt_socket at address: 8000
   
   Your daemon started a debug session - is that your intention?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-mvnd] gnodet commented on issue #637: Timeout waiting to connect to the Maven daemon

2022-05-04 Thread GitBox


gnodet commented on issue #637:
URL: https://github.com/apache/maven-mvnd/issues/637#issuecomment-1118216189

   > > Listening for transport dt_socket at address: 8000
   > 
   > Your daemon started a debug session - is that your intention?
   
   Nice catch, this definitely looks like the daemon is waiting for the 
debugger to connect.
   See the `-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=8000` 
parameters passed as an argument when starting the daemon JVM. 
   @mike-boost you must have the `mvnd.debug` system property set to `true` 
somewhere


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MRELEASE-1087) drop Plexus container APIs, move to JSR 330 + slf4j

2022-05-04 Thread Herve Boutemy (Jira)
Herve Boutemy created MRELEASE-1087:
---

 Summary: drop Plexus container APIs, move to JSR 330 + slf4j
 Key: MRELEASE-1087
 URL: https://issues.apache.org/jira/browse/MRELEASE-1087
 Project: Maven Release Plugin
  Issue Type: Task
Affects Versions: 3.0.0-M5
Reporter: Herve Boutemy
Assignee: Tamás Cservenák
 Fix For: 3.0.0-M6


https://github.com/apache/maven-release/pull/118



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-release] hboutemy commented on pull request #118: Catch up

2022-05-04 Thread GitBox


hboutemy commented on PR #118:
URL: https://github.com/apache/maven-release/pull/118#issuecomment-1118218500

   Jira issue created https://issues.apache.org/jira/browse/MRELEASE-1087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MRELEASE-1087) drop Plexus container APIs, move to JSR 330 + slf4j-api

2022-05-04 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MRELEASE-1087:

Summary: drop Plexus container APIs, move to JSR 330 + slf4j-api  (was: 
drop Plexus container APIs, move to JSR 330 + slf4j)

> drop Plexus container APIs, move to JSR 330 + slf4j-api
> ---
>
> Key: MRELEASE-1087
> URL: https://issues.apache.org/jira/browse/MRELEASE-1087
> Project: Maven Release Plugin
>  Issue Type: Task
>Affects Versions: 3.0.0-M5
>Reporter: Herve Boutemy
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> https://github.com/apache/maven-release/pull/118



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-release] hboutemy commented on pull request #110: [MRELEASE-955] first pass at release profile documentation

2022-05-04 Thread GitBox


hboutemy commented on PR #110:
URL: https://github.com/apache/maven-release/pull/110#issuecomment-1118220079

   IMHO, we need to document the 2 strategies: users will decide when they 
invest time in creating their own profile
   and we'll have time to create good documentation on that profile creation: 
if you look, we don't have any documentation
   
   PRs welcome


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MRELEASE-1022) release:prepare does not honor project.dev version predefined in release.properties

2022-05-04 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MRELEASE-1022:

Affects Version/s: 3.0.0-M5

> release:prepare does not honor project.dev version predefined in 
> release.properties
> ---
>
> Key: MRELEASE-1022
> URL: https://issues.apache.org/jira/browse/MRELEASE-1022
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: prepare
>Affects Versions: 2.5.3, 3.0.0-M5
> Environment: 
> C:\Users\fandre\Documents\MXW\RD\RD>C:\ASF\apache-maven-3.6.1\bin\mvn 
> --version
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: C:\ASF\apache-maven-3.6.1\bin\..
> Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program 
> Files\Java\jdk1.8.0_181\jre
> Default locale: fr_FR, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: zosrothko
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: mvn.log, pom.xml, pom.xml, pom.xml, release.properties, 
> release.properties.dryRun
>
>
> Hi
> Using the release.properties defined as below
> {code:java}
> scm.tag=rd-2019.3
> project.rel.com.scort\:rd=2019.3
> project.dev.com.scort\:rd=2019.4-SNAPSHOT
> project.rel.com.scort.merge\:mergejar=1.2.0
> project.dev.com.scort.merge\:mergejar=1.2.0
> project.rel.com.scort.plugins\:mergejar=1.2.0
> project.dev.com.scort.plugins\:mergejar=1.2.0
> {code}
> with the command
> {code:java}
> mvn -B release:prepare -DdryRun=true
> {code}
> the maven-release-plugin does not use the specified 'project.dev' version to 
> update the pom in the second phase. Here the log
> {code:java}
> [INFO] Scanning for projects...
> [INFO] 
> 
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] RD 
> [pom]
> [INFO] Jar Merger 
> [jar]
> [INFO] MAVEN plugin to merge jar 
> [maven-plugin]
> [INFO]
> [INFO] < com.scort:rd 
> >
> [INFO] Building RD 2019.3-SNAPSHOT    
> [1/3]
> [INFO] [ pom 
> ]-
> [INFO]
> [INFO] --- maven-release-plugin:2.5.3:prepare (default-cli) @ rd ---
> [INFO] Verifying that there are no local modifications...
> [INFO]   ignoring changes on: **\pom.xml.next, **\release.properties, 
> **\pom.xml.branch, **\pom.xml.tag, **\pom.xml.backup, **\pom.xml.releaseBackup
> [INFO] Executing: cmd.exe /X /C "git rev-parse --show-toplevel"
> [INFO] Working directory: C:\Users\fandre\Documents\MXW\RD\RD
> [INFO] Executing: cmd.exe /X /C "git status --porcelain ."
> [INFO] Working directory: C:\Users\fandre\Documents\MXW\RD\RD
> [WARNING] Ignoring unrecognized line: ?? RD/release.properties.copy
> [INFO] Checking dependencies and plugins for snapshots ...
> [INFO] Transforming 'RD'...
> [INFO]   Updating ${antmergejar} to 1.2.0
> [INFO]   Updating ${mavenmergejar} to 1.2.0
> [INFO] Transforming 'Jar Merger'...
> [INFO] Transforming 'MAVEN plugin to merge jar'...
> [INFO] Not generating release POMs
> [INFO] Executing preparation goals - since this is simulation mode it is 
> running against the original project, not the rewritten ones
> [INFO] Executing goals 'clean verify'...
> [INFO] [INFO] Scanning for projects...
> [INFO] [INFO] 
> 
> [INFO] [INFO] Reactor Build Order:
> [INFO] [INFO]
> [INFO] [INFO] RD  
>    [pom]
> [INFO] [INFO] Jar Merger  
>    [jar]
> [INFO] [INFO] MAVEN plugin to merge jar 
> [maven-plugin]
> [INFO] [INFO]
> [INFO] [INFO] < com.scort:rd 
> >
> [INFO] [INFO] Building RD 2019.3-SNAPSHOT 
>    [1/3]
> [INFO] [INFO] [ pom 
> ]-
> [INFO] [INFO]
> [INFO] [INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ rd ---
> [INFO] [INFO]
> [INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ rd ---
> [INFO] [INFO]
> [INFO] [INFO] --< com.scort.merge:mergejar 
> >--
> [INFO] [INFO] Building Jar Merger 1.2.0   
>    [2/3]
> [INFO] [INFO] [ jar 
> ]---

[GitHub] [maven-release] cstamas commented on a diff in pull request #118: Catch up

2022-05-04 Thread GitBox


cstamas commented on code in PR #118:
URL: https://github.com/apache/maven-release/pull/118#discussion_r865600455


##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -530,25 +537,25 @@ else if ( mappedVersion.equals( propertyValue ) )
 {
 // this property may have been updated during 
processing a sibling.
 logInfo( result, "  Ignoring artifact version 
update for expression " + rawVersion
-+ " because it is already updated" );
++ " because it is already updated" );
 }
 else if ( !mappedVersion.equals( rawVersion ) )
 {
 if ( mappedVersion.matches( 
"\\$\\{project.+\\}" )
-|| mappedVersion.matches( "\\$\\{pom.+\\}" 
)
-|| "${version}".equals( mappedVersion ) )
+|| mappedVersion.matches( 
"\\$\\{pom.+\\}" )
+|| "${version}".equals( mappedVersion 
) )

Review Comment:
   Added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-release] cstamas commented on a diff in pull request #118: Catch up

2022-05-04 Thread GitBox


cstamas commented on code in PR #118:
URL: https://github.com/apache/maven-release/pull/118#discussion_r865600675


##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -530,25 +537,25 @@ else if ( mappedVersion.equals( propertyValue ) )
 {
 // this property may have been updated during 
processing a sibling.
 logInfo( result, "  Ignoring artifact version 
update for expression " + rawVersion
-+ " because it is already updated" );
++ " because it is already updated" );
 }
 else if ( !mappedVersion.equals( rawVersion ) )
 {
 if ( mappedVersion.matches( 
"\\$\\{project.+\\}" )
-|| mappedVersion.matches( "\\$\\{pom.+\\}" 
)
-|| "${version}".equals( mappedVersion ) )
+|| mappedVersion.matches( 
"\\$\\{pom.+\\}" )
+|| "${version}".equals( mappedVersion 
) )

Review Comment:
   BTW, this is yet another indicator release plugin does too much: it seems to 
duplicate too much logic that is in core...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MINDEXER-153) upgrade maven-bundle-plugin, fixes OSGi reproducibility issues

2022-05-04 Thread Herve Boutemy (Jira)
Herve Boutemy created MINDEXER-153:
--

 Summary: upgrade maven-bundle-plugin, fixes OSGi reproducibility 
issues
 Key: MINDEXER-153
 URL: https://issues.apache.org/jira/browse/MINDEXER-153
 Project: Maven Indexer
  Issue Type: Dependency upgrade
Affects Versions: 6.2.0
Reporter: Herve Boutemy


currently uses 5.1.4, 5.1.5 has been done to fix FELIX-6496



--
This message was sent by Atlassian Jira
(v8.20.7#820007)