[jira] [Commented] (MSKINS-117) Improve lisibility and user-friendliness in the left menu
[ https://issues.apache.org/jira/browse/MSKINS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530489#comment-17530489 ] Herve Boutemy commented on MSKINS-117: -- UX and visual improvement request still seem valid: now we need some help from people able to update the look and feel of these web pages we can split the required knowledge in 2 steps: 1. pure HTML/CSS = do some fixes on rendered pages, directly in HTML/CSS 2. update the templates to generate previous HTML/CSS help welcome on first step: I can help on the second one > Improve lisibility and user-friendliness in the left menu > - > > Key: MSKINS-117 > URL: https://issues.apache.org/jira/browse/MSKINS-117 > Project: Maven Skins > Issue Type: Wish > Components: Fluido Skin >Affects Versions: fluido-1.4 >Reporter: Cyril JACQUENOT >Priority: Major > Fix For: wontfix-candidate > > Attachments: actual_skin_bad_lisibility.jpg, > skin_maven_old_better_lisibility.jpg > > > In our company, we now use *Maven Fluido Skin* for our projects > online-documentation. > I like the design but the lisibility is not optimal: it is hard for me to > find the location of my current page in the menu. > Great improvements should be : > * to increase indentations > * to use fonts weight to show different levels of indentation > * to give the possibility to manage more than 2 levels in the menu > _here is the bad lisibility skin :_ > !actual_skin_bad_lisibility.jpg! > _here is an old skin, but with *better lisibility* :_ > !skin_maven_old_better_lisibility.jpg! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-mvnd] hboutemy opened a new pull request, #626: prepare Reproducible Builds
hboutemy opened a new pull request, #626: URL: https://github.com/apache/maven-mvnd/pull/626 not sure this is sufficient, but at least this is required for Reproducible Builds... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] hboutemy opened a new issue, #627: building libmvndnative.* creates root files in target directory
hboutemy opened a new issue, #627: URL: https://github.com/apache/maven-mvnd/issues/627 ``` $ cd native $ make native-all ... $ ls -l target/native-* target/native-FreeBSD-x86: total 12 -rwxr-xr-x 1 root root 4803 mai1 10:13 libmvndnative.so -rw-r--r-- 1 root root 1344 mai1 10:13 mvndnative.o target/native-FreeBSD-x86_64: total 12 -rwxr-xr-x 1 root root 6755 mai1 10:13 libmvndnative.so -rw-r--r-- 1 root root 2240 mai1 10:13 mvndnative.o target/native-Linux-arm: total 12 -rwxr-xr-x 1 root root 7804 mai1 10:13 libmvndnative.so -rw-r--r-- 1 root root 1584 mai1 10:13 mvndnative.o target/native-Linux-arm64: total 16 -rwxr-xr-x 1 root root 8864 mai1 10:13 libmvndnative.so -rw-r--r-- 1 root root 1976 mai1 10:13 mvndnative.o target/native-Linux-armv6: total 16 -rwxr-xr-x 1 herve herve 8564 mai1 10:13 libmvndnative.so -rw-r--r-- 1 herve herve 1520 mai1 10:13 mvndnative.o target/native-Linux-armv7: total 12 -rwxr-xr-x 1 root root 7824 mai1 10:13 libmvndnative.so -rw-r--r-- 1 root root 1404 mai1 10:13 mvndnative.o target/native-Linux-ppc64: total 20 -rwxr-xr-x 1 root root 70304 mai1 10:13 libmvndnative.so -rw-r--r-- 1 root root 2536 mai1 10:13 mvndnative.o target/native-Linux-x86: total 20 -rwxr-xr-x 1 herve herve 15188 mai1 10:13 libmvndnative.so -rw-r--r-- 1 herve herve 1988 mai1 10:13 mvndnative.o target/native-Linux-x86_64: total 16 -rwxr-xr-x 1 root root 8384 mai1 10:13 libmvndnative.so -rw-r--r-- 1 root root 2384 mai1 10:13 mvndnative.o target/native-Mac-arm64: total 56 -rwxr-xr-x 1 root root 50801 mai1 10:13 libmvndnative.jnilib -rw-r--r-- 1 root root 2160 mai1 10:13 mvndnative.o target/native-Mac-x86: total 16 -rwxr-xr-x 1 root root 9044 mai1 10:13 libmvndnative.jnilib -rw-r--r-- 1 root root 1492 mai1 10:13 mvndnative.o target/native-Mac-x86_64: total 16 -rwxr-xr-x 1 root root 9260 mai1 10:13 libmvndnative.jnilib -rw-r--r-- 1 root root 2156 mai1 10:13 mvndnative.o target/native-Windows-x86: total 92 -rwxr-xr-x 1 herve herve 87265 mai1 10:13 mvndnative.dll -rw-r--r-- 1 herve herve 1323 mai1 10:13 mvndnative.o target/native-Windows-x86_64: total 108 -rwxr-xr-x 1 herve herve 103015 mai1 10:13 mvndnative.dll -rw-r--r-- 1 herve herve 1665 mai1 10:13 mvndnative.o ``` majority of outputs are root, only a few respect user (Windows and Linux x86 and armv6) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] hboutemy commented on issue #627: building libmvndnative.* creates root files in target directory
hboutemy commented on issue #627: URL: https://github.com/apache/maven-mvnd/issues/627#issuecomment-1114173216 first research results: the 4 cases respecting user are in fact those having a script that does proper job for user detection: https://github.com/apache/maven-mvnd/tree/master/native/docker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified
[
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530497#comment-17530497
]
Slawomir Jaranowski commented on MNG-7468:
--
We can only check root parameters provide by plugin.xml descriptor.
If something is in complex user defined object or in manually managed plexus
configuration by plugin - it is not possible to verify such internal items as I
know.
> Unsupported plugins parameters in configuration should be verified
> --
>
> Key: MNG-7468
> URL: https://issues.apache.org/jira/browse/MNG-7468
> Project: Maven
> Issue Type: New Feature
> Components: Plugins and Lifecycle
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
>
> example-maven-plugin
> 1.1.1
>
>
>
>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of
> invalid plugin configuration exception ...
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-mvnd] hboutemy opened a new issue, #628: make libmvndnative.* builds reproducible
hboutemy opened a new issue, #628: URL: https://github.com/apache/maven-mvnd/issues/628 currently, when doing `cd native ; make native-all`, we see that on the 14 native libs built and stored in `src/main/resources/org/mvndaemon/mvnd/nativ/`, 11 are not reproducible = each run gives a different output, that will lead to a Git commit during a release even if there was no code change ideally, such rebuilds should give reproducible output https://reproducible-builds.org/ the non-reproducible targets are: - Linux for all arch (arm, arm64, armv6, armv7, ppc64, x86, x86_64) - Mac for x86 and x86_64 arch (arm64 arch is ok...) - Windows for all arch (x86, x86_64) FreeBSD is already ok for all arch (x86, x86_64) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] hboutemy commented on pull request #626: prepare Reproducible Builds
hboutemy commented on PR #626: URL: https://github.com/apache/maven-mvnd/pull/626#issuecomment-1114191846 removing platform-dependant data from daemon common breaks tests... I'm convinced that such things should not be at that place: perhaps only in client, because client is the only aspect that is native at the end? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSKINS-169) Image height not effective
[
https://issues.apache.org/jira/browse/MSKINS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSKINS-169:
--
Summary: Image height not effective (was: image height not effective)
> Image height not effective
> --
>
> Key: MSKINS-169
> URL: https://issues.apache.org/jira/browse/MSKINS-169
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.9
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
>
> As bootstrap 2.3.2 styles all images with {{height: auto}}
> (https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/css/bootstrap-2.3.2.css#L103)
> setting a height in
> https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerLeft
> does not have any effect (although the HTML img element carries it, it is
> overwritten by the bootstrap.css)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-fluido-skin] michael-o opened a new pull request, #23: [MSKINS-169] Image height not effective
michael-o opened a new pull request, #23: URL: https://github.com/apache/maven-fluido-skin/pull/23 It is also imperative to provide units otherwise the browser will ignore them. Reason for the failure: https://stackoverflow.com/a/44010892/696632 This closes #23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #23: [MSKINS-169] Image height not effective
michael-o commented on PR #23: URL: https://github.com/apache/maven-fluido-skin/pull/23#issuecomment-1114195235 @kwin Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSKINS-169) Image height not effective
[
https://issues.apache.org/jira/browse/MSKINS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530505#comment-17530505
]
Michael Osipov commented on MSKINS-169:
---
[~kwin], PR created. Please review/test.
> Image height not effective
> --
>
> Key: MSKINS-169
> URL: https://issues.apache.org/jira/browse/MSKINS-169
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.9
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
>
> As bootstrap 2.3.2 styles all images with {{height: auto}}
> (https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/css/bootstrap-2.3.2.css#L103)
> setting a height in
> https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerLeft
> does not have any effect (although the HTML img element carries it, it is
> overwritten by the bootstrap.css)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MSKINS-170) Allow to show name as headline in addition to bannerLeft
[ https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530508#comment-17530508 ] Michael Osipov commented on MSKINS-170: --- Can you explain where you see the benefit? > Allow to show name as headline in addition to bannerLeft > > > Key: MSKINS-170 > URL: https://issues.apache.org/jira/browse/MSKINS-170 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.9 >Reporter: Konrad Windszus >Priority: Major > > Currently there is a fallback with text in case no bannerLeft is configured: > https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/META-INF/maven/site.vm#L188. > It would be nice to optionally show that next to the banner. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #23: [MSKINS-169] Image height not effective
olamy commented on code in PR #23: URL: https://github.com/apache/maven-fluido-skin/pull/23#discussion_r862469166 ## pom.xml: ## @@ -253,7 +253,6 @@ under the License. site - true Review Comment: Why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #23: [MSKINS-169] Image height not effective
michael-o commented on code in PR #23: URL: https://github.com/apache/maven-fluido-skin/pull/23#discussion_r862476253 ## pom.xml: ## @@ -253,7 +253,6 @@ under the License. site - true Review Comment: It spills the terminals with thousands of lines of debug output. Basically impossible to scroll back to the invoker report and pray that your terminal buffer is large enough. Moreover, in other components this isn't enabled also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MDEP-804: - Fix Version/s: wontfix-candidate > Allow auto-ignore of all non-test scoped dependencies used only in test scope > - > > Key: MDEP-804 > URL: https://issues.apache.org/jira/browse/MDEP-804 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: analyze >Affects Versions: 3.3.0 >Reporter: Henning Schmiedehausen >Priority: Major > Labels: pull-request-available > Fix For: wontfix-candidate > > > Pre-3.2.0, dependencies that were used only in test scope but not declared in > test scope (most likely declared in compile scope) were accepted by the > plugin and not flagged as a problem. > Starting with 3.2.0 (and the current 3.3.0), these are reported with > "Non-test scoped test only dependencies found". If the scope of the > dependencies can not be changed (there are many reasons for that in large > projects), the old behavior can be restored by adding each flagged dependency > to the "ignoredNonTestScopedDependencies" configuration option in the > respective project. > This is, especially in large projects, cumbersome and brittle. > There should be a boolean flag, "ignoreAllNonTestScoped" that, when set, > allows ignoring non-test scoped dependencies if they are used only in test > scope. This flag restores the pre-3.2.0 behavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope
[
https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530533#comment-17530533
]
Slawomir Jaranowski commented on MDEP-804:
--
Why not use:
{code}
< ignoredNonTestScopedDependency>*
{code}
your PR do exactly the same.
I prefer to not add next options if we can achieve the same result by existing
ones.
We can extends documentation about such case.
And of course thanks for PR and involvement.
> Allow auto-ignore of all non-test scoped dependencies used only in test scope
> -
>
> Key: MDEP-804
> URL: https://issues.apache.org/jira/browse/MDEP-804
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: analyze
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Priority: Major
> Labels: pull-request-available
>
> Pre-3.2.0, dependencies that were used only in test scope but not declared in
> test scope (most likely declared in compile scope) were accepted by the
> plugin and not flagged as a problem.
> Starting with 3.2.0 (and the current 3.3.0), these are reported with
> "Non-test scoped test only dependencies found". If the scope of the
> dependencies can not be changed (there are many reasons for that in large
> projects), the old behavior can be restored by adding each flagged dependency
> to the "ignoredNonTestScopedDependencies" configuration option in the
> respective project.
> This is, especially in large projects, cumbersome and brittle.
> There should be a boolean flag, "ignoreAllNonTestScoped" that, when set,
> allows ignoring non-test scoped dependencies if they are used only in test
> scope. This flag restores the pre-3.2.0 behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-dependency-plugin] slawekjaranowski closed pull request #211: [MDEP-804] - Allow auto-ignore of all non-test scoped dependencies used only in test scope
slawekjaranowski closed pull request #211: [MDEP-804] - Allow auto-ignore of all non-test scoped dependencies used only in test scope URL: https://github.com/apache/maven-dependency-plugin/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #211: [MDEP-804] - Allow auto-ignore of all non-test scoped dependencies used only in test scope
slawekjaranowski commented on PR #211: URL: https://github.com/apache/maven-dependency-plugin/pull/211#issuecomment-1114284099 Explanation in issue - why I close it. https://issues.apache.org/jira/browse/MDEP-804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-777) String index out of range when using FlattenFileMapper
[
https://issues.apache.org/jira/browse/MDEP-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530537#comment-17530537
]
Slawomir Jaranowski commented on MDEP-777:
--
please provide simple minimal project for reproduce.
> String index out of range when using FlattenFileMapper
> --
>
> Key: MDEP-777
> URL: https://issues.apache.org/jira/browse/MDEP-777
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: unpack
>Affects Versions: 3.2.0
>Reporter: Lieven Cardoen
>Priority: Blocker
>
> When using FlattenFileMapper I'm getting a *String index out of range 0*
> If I comment out the FileMappers then everything runs fine.
> {code:xml}
>
> org.apache.maven.plugins
> maven-dependency-plugin
> 3.2.0
>
>
>
> copy-databases-to-dbf-folder
> install
>
> unpack
>
>
>
>
> be.mips.appl.database
>
> ${db.variant}-db-oe${oe.major.version}-${os.classifier}
> ${be.mips.appl.database.version}
> zip
> true
>
>
> implementation="org.codehaus.plexus.components.io.filemappers.FlattenFileMapper"/>
>
>
>
> be.mips.appl.database
>
> name-db-oe${oe.major.version}-${os.classifier}
> ${be.mips.appl.database.version}
> zip
> true
>
>
> **/*
> ${custom.build.directory}/dbf
> true
> true
>
>
>
>
> {code}
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-dependency-plugin:3.2.0:unpack
> (copy-databases-to-dbf-folder) on project build-appl: Execution
> copy-databases-to-dbf-folder of goal
> org.apache.maven.plugins:maven-dependency-plugin:3.2.0:unpack failed: String
> index out of range: 0 -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
> {code}
> The ZIP contains two folders with files in both of the folders. So no empty
> folders.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Comment Edited] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope
[
https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530533#comment-17530533
]
Slawomir Jaranowski edited comment on MDEP-804 at 5/1/22 5:07 PM:
--
Why not use:
{code}
*
{code}
your PR do exactly the same.
I prefer to not add next options if we can achieve the same result by existing
ones.
We can extends documentation about such case.
And of course thanks for PR and involvement.
was (Author: slawekjaranowski):
Why not use:
{code}
< ignoredNonTestScopedDependency>*
{code}
your PR do exactly the same.
I prefer to not add next options if we can achieve the same result by existing
ones.
We can extends documentation about such case.
And of course thanks for PR and involvement.
> Allow auto-ignore of all non-test scoped dependencies used only in test scope
> -
>
> Key: MDEP-804
> URL: https://issues.apache.org/jira/browse/MDEP-804
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: analyze
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Priority: Major
> Labels: pull-request-available
> Fix For: wontfix-candidate
>
>
> Pre-3.2.0, dependencies that were used only in test scope but not declared in
> test scope (most likely declared in compile scope) were accepted by the
> plugin and not flagged as a problem.
> Starting with 3.2.0 (and the current 3.3.0), these are reported with
> "Non-test scoped test only dependencies found". If the scope of the
> dependencies can not be changed (there are many reasons for that in large
> projects), the old behavior can be restored by adding each flagged dependency
> to the "ignoredNonTestScopedDependencies" configuration option in the
> respective project.
> This is, especially in large projects, cumbersome and brittle.
> There should be a boolean flag, "ignoreAllNonTestScoped" that, when set,
> allows ignoring non-test scoped dependencies if they are used only in test
> scope. This flag restores the pre-3.2.0 behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope
[
https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530538#comment-17530538
]
Henning Schmiedehausen commented on MDEP-804:
-
You are correct, this would be equivalent. However, the normal use case for a
flag is something like this:
{quote}
<
ignoreAllNonTestScoped>${some.property.used.by.the.build.system>
{quote}
We have massive build configurations with dozens of modules and multiple
projects. I can add the block that you suggested to our master pom and as a
result, I can not use the option anywhere, because now I would need to undo
that global setting and add my explicit excludes. This is a very brittle and
complicated way to do this. With a flag, I can set the flag in the projects
where I want to ignore all deps and unset it in all the others (and there I can
add the explicit excludes).
As the original author of quite a bit of these excludes (yeah, look it up; I
was as surprised as you. Back in 2015. :-) ), I have done a lot of workarounds
before adding flags. For large scale systems, flags are a life-saver because
they allow property driven enabling/disabling of features in a way that the
lists do not.
(Technically I should still be a committer on Apache Maven; I don't think my
commit bit ever lapsed. I very much prefer to have a discussion about this, but
I don't feel that a blanket "There is a workaround that does it in isolation"
statement is the best answer).
> Allow auto-ignore of all non-test scoped dependencies used only in test scope
> -
>
> Key: MDEP-804
> URL: https://issues.apache.org/jira/browse/MDEP-804
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: analyze
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Priority: Major
> Labels: pull-request-available
> Fix For: wontfix-candidate
>
>
> Pre-3.2.0, dependencies that were used only in test scope but not declared in
> test scope (most likely declared in compile scope) were accepted by the
> plugin and not flagged as a problem.
> Starting with 3.2.0 (and the current 3.3.0), these are reported with
> "Non-test scoped test only dependencies found". If the scope of the
> dependencies can not be changed (there are many reasons for that in large
> projects), the old behavior can be restored by adding each flagged dependency
> to the "ignoredNonTestScopedDependencies" configuration option in the
> respective project.
> This is, especially in large projects, cumbersome and brittle.
> There should be a boolean flag, "ignoreAllNonTestScoped" that, when set,
> allows ignoring non-test scoped dependencies if they are used only in test
> scope. This flag restores the pre-3.2.0 behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530539#comment-17530539 ] Henning Schmiedehausen commented on MDEP-804: - Yeah, according to https://people.apache.org/phonebook.html?unix=maven, I am still an Apache Maven committer. Can I get that bit for github as well please? ;-) > Allow auto-ignore of all non-test scoped dependencies used only in test scope > - > > Key: MDEP-804 > URL: https://issues.apache.org/jira/browse/MDEP-804 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: analyze >Affects Versions: 3.3.0 >Reporter: Henning Schmiedehausen >Priority: Major > Labels: pull-request-available > Fix For: wontfix-candidate > > > Pre-3.2.0, dependencies that were used only in test scope but not declared in > test scope (most likely declared in compile scope) were accepted by the > plugin and not flagged as a problem. > Starting with 3.2.0 (and the current 3.3.0), these are reported with > "Non-test scoped test only dependencies found". If the scope of the > dependencies can not be changed (there are many reasons for that in large > projects), the old behavior can be restored by adding each flagged dependency > to the "ignoredNonTestScopedDependencies" configuration option in the > respective project. > This is, especially in large projects, cumbersome and brittle. > There should be a boolean flag, "ignoreAllNonTestScoped" that, when set, > allows ignoring non-test scoped dependencies if they are used only in test > scope. This flag restores the pre-3.2.0 behavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530543#comment-17530543 ] Slawomir Jaranowski commented on MDEP-804: -- Nevermind if you are or not committed I prefer discus new feature in projects. I see that many projects have many (some time too many) options and the result is code is complicated and nobody happy to maintain it. First I want to understand your needs, maybe someone else want to add his opinions. PS. You have access to github - go to selfserve, check your github username, and synchronize git ... > Allow auto-ignore of all non-test scoped dependencies used only in test scope > - > > Key: MDEP-804 > URL: https://issues.apache.org/jira/browse/MDEP-804 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: analyze >Affects Versions: 3.3.0 >Reporter: Henning Schmiedehausen >Priority: Major > Labels: pull-request-available > Fix For: wontfix-candidate > > > Pre-3.2.0, dependencies that were used only in test scope but not declared in > test scope (most likely declared in compile scope) were accepted by the > plugin and not flagged as a problem. > Starting with 3.2.0 (and the current 3.3.0), these are reported with > "Non-test scoped test only dependencies found". If the scope of the > dependencies can not be changed (there are many reasons for that in large > projects), the old behavior can be restored by adding each flagged dependency > to the "ignoredNonTestScopedDependencies" configuration option in the > respective project. > This is, especially in large projects, cumbersome and brittle. > There should be a boolean flag, "ignoreAllNonTestScoped" that, when set, > allows ignoring non-test scoped dependencies if they are used only in test > scope. This flag restores the pre-3.2.0 behavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530551#comment-17530551 ] Henning Schmiedehausen commented on MDEP-804: - Very much agreed. That is why I opened a PR and a ticket. I feel that discussing use cases is valuable. This PR is mostly a reaction to the behavior changes from 3.1.x -> 3.2.0. A flag allows us to transition to the newer plugin versions with much less pain than using excludes. I hope you understand the use case (flags can be driven out of properties, lists can not) and why this is still beneficial. Personally, I don't mind lots of flags; the problem is that they often could be documented better and their interaction is sometimes undefined. I hope I documented this new flag sufficiently. > Allow auto-ignore of all non-test scoped dependencies used only in test scope > - > > Key: MDEP-804 > URL: https://issues.apache.org/jira/browse/MDEP-804 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: analyze >Affects Versions: 3.3.0 >Reporter: Henning Schmiedehausen >Priority: Major > Labels: pull-request-available > Fix For: wontfix-candidate > > > Pre-3.2.0, dependencies that were used only in test scope but not declared in > test scope (most likely declared in compile scope) were accepted by the > plugin and not flagged as a problem. > Starting with 3.2.0 (and the current 3.3.0), these are reported with > "Non-test scoped test only dependencies found". If the scope of the > dependencies can not be changed (there are many reasons for that in large > projects), the old behavior can be restored by adding each flagged dependency > to the "ignoredNonTestScopedDependencies" configuration option in the > respective project. > This is, especially in large projects, cumbersome and brittle. > There should be a boolean flag, "ignoreAllNonTestScoped" that, when set, > allows ignoring non-test scoped dependencies if they are used only in test > scope. This flag restores the pre-3.2.0 behavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-surefire] dejan2609 commented on pull request #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')
dejan2609 commented on PR #233: URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-1114306994 Sure @Tibor17, will do that (I'm currently almost off the grid, but will be back soon). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
michael-o commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862515080
##
maven-core/src/main/java/org/apache/maven/plugin/internal/ReadOnlyPluginParametersValidator.java:
##
@@ -0,0 +1,80 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.Parameter;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Print warnings if read-only parameters of plugin are used in configuration.
+ *
+ * @author Slawomir Jaranowski
+ */
+@Named
+@Singleton
+public class ReadOnlyPluginParametersValidator extends
AbstractMavenPluginParametersValidator
+{
+private static final Logger LOGGER = LoggerFactory.getLogger(
ReadOnlyPluginParametersValidator.class );
+
+@Override
+protected Logger getLogger()
+{
+return LOGGER;
+}
+
+@Override
+protected String getParameterLogReason( Parameter parameter )
+{
+return "is read-only, should not be used in configuration";
Review Comment:
Look at https://datatracker.ietf.org/doc/html/rfc2119 and should not, it
gives me the feeling that the log message is wrong. As far as I understand:
Setting those has no effect, but should not does not tell, no? If so, I would
expect "shall not".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-deploy-plugin] michael-o commented on a diff in pull request #22: [MDEPLOY-291] Update POM parent and Maven
michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-deploy-plugin/pull/22#discussion_r862515576
##
pom.xml:
##
@@ -126,33 +138,45 @@ under the License.
test
- org.mockito
- mockito-core
- 2.28.2
+ org.apache.maven
+ maven-resolver-provider
+ ${mavenVersion}
test
- junit
- junit
- 4.13.1
+ org.apache.maven.resolver
+ maven-resolver-connector-basic
+ ${resolverVersion}
test
- org.sonatype.aether
- aether-connector-file
- 1.7
+ org.apache.maven.resolver
+ maven-resolver-transport-file
+ ${resolverVersion}
test
- org.slf4j
- slf4j-api
- 1.7.5
- provided
+ org.apache.maven.resolver
+ maven-resolver-transport-http
+ ${resolverVersion}
+ test
+
+
+ org.mockito
+ mockito-core
+ 4.4.0
+ test
+
+
+ junit
+ junit
+ 4.13.2
+ test
org.slf4j
slf4j-nop
- 1.7.5
+ 1.7.36
Review Comment:
Move this to a property please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7429) The classloader containing build extensions should be used throughout the build
[ https://issues.apache.org/jira/browse/MNG-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530560#comment-17530560 ] Michael Osipov commented on MNG-7429: - [~gnodet], is this still valid? > The classloader containing build extensions should be used throughout the > build > --- > > Key: MNG-7429 > URL: https://issues.apache.org/jira/browse/MNG-7429 > Project: Maven > Issue Type: Bug >Affects Versions: 3.8.5, 3.9.0, 4.0.0-alpha-1 >Reporter: Guillaume Nodet >Priority: Major > Labels: Regression > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-170) Allow to show name as headline in addition to bannerLeft
[ https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530563#comment-17530563 ] Konrad Windszus commented on MSKINS-170: Just compare https://sling.apache.org/components/scriptingbundle-maven-plugin-archives/scriptingbundle-maven-plugin-0.3.0/ and https://sling.apache.org/components/scriptingbundle-maven-plugin-archives/scriptingbundle-maven-plugin-0.4.0/. Often the banners are useful in addition to an automatically generated h1. > Allow to show name as headline in addition to bannerLeft > > > Key: MSKINS-170 > URL: https://issues.apache.org/jira/browse/MSKINS-170 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.9 >Reporter: Konrad Windszus >Priority: Major > > Currently there is a fallback with text in case no bannerLeft is configured: > https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/META-INF/maven/site.vm#L188. > It would be nice to optionally show that next to the banner. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-170) Allow to show name as headline in addition to bannerLeft
[ https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530564#comment-17530564 ] Konrad Windszus commented on MSKINS-170: This probably requires a new version of https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html to allow to toggle the automatic h1. > Allow to show name as headline in addition to bannerLeft > > > Key: MSKINS-170 > URL: https://issues.apache.org/jira/browse/MSKINS-170 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.9 >Reporter: Konrad Windszus >Priority: Major > > Currently there is a fallback with text in case no bannerLeft is configured: > https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/META-INF/maven/site.vm#L188. > It would be nice to optionally show that next to the banner. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-mvnd] hboutemy opened a new pull request, #629: don't skip build/ in source archive
hboutemy opened a new pull request, #629: URL: https://github.com/apache/maven-mvnd/pull/629 fixes issue found during 0.8.0 vote -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #23: [MSKINS-169] Image height not effective
olamy commented on code in PR #23: URL: https://github.com/apache/maven-fluido-skin/pull/23#discussion_r862553037 ## pom.xml: ## @@ -253,7 +253,6 @@ under the License. site - true Review Comment: fair enough but the problem is more: why do we have this for m-invoker-p? (as you complain about verbosity :) ) ``` true ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] dependabot[bot] opened a new pull request, #73: Bump checkstyle from 9.3 to 10.2
dependabot[bot] opened a new pull request, #73: URL: https://github.com/apache/maven-checkstyle-plugin/pull/73 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.3 to 10.2. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's releases. checkstyle-10.2 https://checkstyle.org/releasenotes.html#Release_10.2";>https://checkstyle.org/releasenotes.html#Release_10.2 checkstyle-10.1 https://checkstyle.org/releasenotes.html#Release_10.1";>https://checkstyle.org/releasenotes.html#Release_10.1 checkstyle-10.0 https://checkstyle.org/releasenotes.html#Release_10.0";>https://checkstyle.org/releasenotes.html#Release_10.0 Commits https://github.com/checkstyle/checkstyle/commit/0678fc609ec1889e3534940aa9d094887a4af2f3";>0678fc6 [maven-release-plugin] prepare release checkstyle-10.2 https://github.com/checkstyle/checkstyle/commit/acf70b4d7e8e4423579f02bf88d9773ba9574a77";>acf70b4 doc: release notes for 10.2 https://github.com/checkstyle/checkstyle/commit/591b41028cecc786ea94556791a8e53a99defb4c";>591b410 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/4845";>#4845: remove dependency on netbuddy from test inputs https://github.com/checkstyle/checkstyle/commit/0fda5157d34980c229090931af2a1a1ce74e87a9";>0fda515 dependency: bump maven-antrun-plugin from 3.0.0 to 3.1.0 https://github.com/checkstyle/checkstyle/commit/7f5fcc814f63a590d24b34a3e6289facfbffc264";>7f5fcc8 supplemental: Modify pitest.sh to support unstable mutations list https://github.com/checkstyle/checkstyle/commit/0ab05c948d302dde4f3e4144e97af30a2613900a";>0ab05c9 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11528";>#11528: Kill surviving mutation in EqualsAvoidNullCheck https://github.com/checkstyle/checkstyle/commit/c2abb6fb4cef7c4d3e565bd05d061841fc86db50";>c2abb6f minor: fix link (link-check-plugin) https://github.com/checkstyle/checkstyle/commit/4a7e6fa6b7eeb0658d09c64bc9f390f24c3ab10b";>4a7e6fa dependency: bump nexus-staging-maven-plugin from 1.6.12 to 1.6.13 https://github.com/checkstyle/checkstyle/commit/8035e76a5ba81f4841519d0d3ceb9e7a4f913506";>8035e76 dependency: bump mockito-inline from 4.5.0 to 4.5.1 https://github.com/checkstyle/checkstyle/commit/d00939d8400537a7eecc56e7ec1fdaf3f0574333";>d00939d dependency: bump maven-site-plugin from 3.11.0 to 3.12.0 Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.3...checkstyle-10.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] dependabot[bot] commented on pull request #72: Bump checkstyle from 9.3 to 10.1
dependabot[bot] commented on PR #72: URL: https://github.com/apache/maven-checkstyle-plugin/pull/72#issuecomment-1114517856 Superseded by #73. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] dependabot[bot] closed pull request #72: Bump checkstyle from 9.3 to 10.1
dependabot[bot] closed pull request #72: Bump checkstyle from 9.3 to 10.1 URL: https://github.com/apache/maven-checkstyle-plugin/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
