[GitHub] [maven-integration-testing] michael-o commented on pull request #154: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
michael-o commented on PR #154: URL: https://github.com/apache/maven-integration-testing/pull/154#issuecomment-1113939644 Question: So settings these is a no-op, true? I wonder whether we'd like to have this warning in 3.9.0 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
michael-o commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862325468
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localRepository",
+"mojo",
+"mojoExecution",
+"plugin",
+"project",
+"reactorProjects",
+"session",
+"settings"
+);
+
+private static final List IGNORED_PROPERTY_PREFIX = Arrays.asList(
+"mojo.",
+"plugin.",
+"pom.",
Review Comment:
The `pom` prefix has already been removed, no? Why ignore?
##
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java:
##
@@ -606,7 +606,10 @@ else if ( cause instanceof LinkageError )
ExpressionEvaluator expressionEvaluator = new
PluginParameterExpressionEvaluator( session, mojoExecution );
-configurationValidator.validate( mojoDescriptor, pomConfiguration,
expressionEvaluator );
+for ( MavenPluginConfigurationValidator validator:
configurationValidator )
Review Comment:
configurationValidators
##
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java:
##
@@ -143,7 +143,7 @@
private PluginVersionResolver pluginVersionResolver;
private PluginArtifactsCache pluginArtifactsCache;
private MavenPluginValidator pluginValidator;
-private MavenPluginConfigurationValidator configurationValidator;
+private List configurationValidator;
Review Comment:
configurationValidators
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.Expression
[GitHub] [maven-install-plugin] slawekjaranowski merged pull request #26: [MINSTALL-174] Upgrade maven-plugin parent to 36
slawekjaranowski merged PR #26: URL: https://github.com/apache/maven-install-plugin/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] pzygielo commented on pull request #154: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
pzygielo commented on PR #154: URL: https://github.com/apache/maven-integration-testing/pull/154#issuecomment-1113943656 > Question: So settings these is a no-op, true? How I checked it: Set compiler's [`outputDirectory`](https://github.com/apache/maven-compiler-plugin/blob/1d912302d1f4a315b1db18fcc3197cae7796cc4f/src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java#L74). It is respected (at least in maven 3.8.5) and value from pom is used. I'm 100% sure that _readonlines_ of parameter probably results in not having it in mojo docs only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINSTALL-174) Upgrade maven-plugin parent to 36
[ https://issues.apache.org/jira/browse/MINSTALL-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINSTALL-174. Resolution: Fixed > Upgrade maven-plugin parent to 36 > - > > Key: MINSTALL-174 > URL: https://issues.apache.org/jira/browse/MINSTALL-174 > Project: Maven Install Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.0.0-M2 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-integration-testing] pzygielo commented on pull request #154: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
pzygielo commented on PR #154: URL: https://github.com/apache/maven-integration-testing/pull/154#issuecomment-1113944242 MNG-5001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINSTALL-174) Upgrade maven-plugin parent to 36
[ https://issues.apache.org/jira/browse/MINSTALL-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530350#comment-17530350 ] Hudson commented on MINSTALL-174: - Build succeeded in Jenkins: Maven » Maven TLP » maven-install-plugin » master #7 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-install-plugin/job/master/7/ > Upgrade maven-plugin parent to 36 > - > > Key: MINSTALL-174 > URL: https://issues.apache.org/jira/browse/MINSTALL-174 > Project: Maven Install Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.0.0-M2 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #154: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
slawekjaranowski commented on PR #154: URL: https://github.com/apache/maven-integration-testing/pull/154#issuecomment-1113947889 > I wonder whether we'd like to have this warning in 3.9.0 as well. will be in next PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #154: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
slawekjaranowski commented on PR #154: URL: https://github.com/apache/maven-integration-testing/pull/154#issuecomment-1113948604 is is first step for MAN-5001 ... as we see many plugins should be changed like m-compiler with `outputDirectory` if user need override some of parameters those should be not read-only, or plugins should provide another way ... So only warring -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
slawekjaranowski commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862330410
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localRepository",
+"mojo",
+"mojoExecution",
+"plugin",
+"project",
+"reactorProjects",
+"session",
+"settings"
+);
+
+private static final List IGNORED_PROPERTY_PREFIX = Arrays.asList(
+"mojo.",
+"plugin.",
+"pom.",
Review Comment:
still exist in `PluginParameterExpressionEvaluator`
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java#L245
I can remove it here if there is plan to remove such prefix from maven ...
IHMO should be done together with change in `PluginParameterExpressionEvaluator`
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localReposit
[GitHub] [maven] michael-o commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
michael-o commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862330673
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localRepository",
+"mojo",
+"mojoExecution",
+"plugin",
+"project",
+"reactorProjects",
+"session",
+"settings"
+);
+
+private static final List IGNORED_PROPERTY_PREFIX = Arrays.asList(
+"mojo.",
+"plugin.",
+"pom.",
Review Comment:
Add a note with the JIRA issue where it has been removed in Maven 4.
@mthmulders Did remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
michael-o commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862330706
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localRepository",
+"mojo",
+"mojoExecution",
+"plugin",
+"project",
+"reactorProjects",
+"session",
+"settings"
+);
+
+private static final List IGNORED_PROPERTY_PREFIX = Arrays.asList(
+"mojo.",
+"plugin.",
+"pom.",
+"project.",
+"session.",
+"settings."
+);
+
+protected abstract Logger getLogger();
+
+protected static boolean isValueSet( PlexusConfiguration config,
+ ExpressionEvaluator
expressionEvaluator )
+{
+if ( config == null )
+{
+return false;
+}
+
+// there are sub items ... so configuration is declared
+if ( config.getChildCount() > 0 )
+{
+return true;
+}
+
+String strValue = config.getValue();
+
+if ( strValue == null || strValue.isEmpty() )
+{
+return false;
+}
+
+if ( isIgnoredProperty( strValue ) )
+{
+return false;
+}
+
+// for declaration like @Parameter( property = "config.property" )
+// the value will contains ${config.property}
+
+try
+{
+return expressionEvaluator.evaluate( strValue ) != null;
+}
+catch ( ExpressionEvaluationException e )
+{
+// not important
+// will be reported during Mojo fields populate
+}
+
+// fallback - in case of error in expressionEvaluator
+return false;
+}
+
+private static boolean isIgnoredProperty( String strValue )
+{
+if ( !strValue.startsWith( "${" ) )
+{
+return false;
+}
+
+String propertyName = strValue.replace( "${", "" ).replace( "}", "" );
+
+if ( IGNORED_PROPERTY_VALUES.contains( propertyName ) )
+{
+return true;
+}
+
+return IGNORED_PROPERTY_PREFIX.stream().anyMatch(
propertyName::startsWith );
Review Comment:
No, nope. I just find the expression extremely cool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
slawekjaranowski commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862331108
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localRepository",
+"mojo",
+"mojoExecution",
+"plugin",
+"project",
+"reactorProjects",
+"session",
+"settings"
+);
+
+private static final List IGNORED_PROPERTY_PREFIX = Arrays.asList(
+"mojo.",
+"plugin.",
+"pom.",
Review Comment:
I see one about prefixless https://issues.apache.org/jira/browse/MNG-7404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-7404) Change from deprecated WARNING to FAIL the build for usage of {X} placeholders rather than ${project.X}
[
https://issues.apache.org/jira/browse/MNG-7404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7404:
Fix Version/s: 4.0.0
> Change from deprecated WARNING to FAIL the build for usage of {X}
> placeholders rather than ${project.X}
> ---
>
> Key: MNG-7404
> URL: https://issues.apache.org/jira/browse/MNG-7404
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 4.0.0-alpha-1
>Reporter: Maarten Mulders
>Assignee: Maarten Mulders
>Priority: Minor
> Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.0-alpha-1, 4.0.0
>
>
> Currently we produce a {{WARNING}} in case of using {{version}} or alike.
> I would suggest to change {{WARNING}} into a failing build in such use cases.
> {code}
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for 'com.soebes.examples.j2ee:appasm:pom:1.0-SNAPSHOT'
> [WARNING] The expression ${version} is deprecated. Please use
> ${project.version} instead.
> {code}
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (MNG-7404) Change from deprecated WARNING to FAIL the build for usage of {X} placeholders rather than ${project.X}
[
https://issues.apache.org/jira/browse/MNG-7404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-7404.
---
> Change from deprecated WARNING to FAIL the build for usage of {X}
> placeholders rather than ${project.X}
> ---
>
> Key: MNG-7404
> URL: https://issues.apache.org/jira/browse/MNG-7404
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 4.0.0-alpha-1
>Reporter: Maarten Mulders
>Assignee: Maarten Mulders
>Priority: Minor
> Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.0-alpha-1
>
>
> Currently we produce a {{WARNING}} in case of using {{version}} or alike.
> I would suggest to change {{WARNING}} into a failing build in such use cases.
> {code}
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for 'com.soebes.examples.j2ee:appasm:pom:1.0-SNAPSHOT'
> [WARNING] The expression ${version} is deprecated. Please use
> ${project.version} instead.
> {code}
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (MNG-7406) Strange formatting of warning/errors from project building
[
https://issues.apache.org/jira/browse/MNG-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-7406.
---
> Strange formatting of warning/errors from project building
> --
>
> Key: MNG-7406
> URL: https://issues.apache.org/jira/browse/MNG-7406
> Project: Maven
> Issue Type: Improvement
> Components: Errors
>Affects Versions: 4.0.x-candidate
>Reporter: Maarten Mulders
>Assignee: Maarten Mulders
>Priority: Minor
> Fix For: 4.0.0-alpha-1, 4.0.0
>
> Attachments: after.png, before.png, image.png
>
>
> If Maven finds an error while building the model, it throws a
> {{{}ProjectBuildingException{}}}. When that makes it to the CLI, it is
> printed in a bit strange way:
> !image.png!
> Note how the message reads:
> {code:java}
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project foo:bar:1.0-SNAPSHOT (/private/tmp/ner/bar/pom.xml) has
> 1 error
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] {code}
> # It contains a severity marker *twice*
> # It repeats the error/warning message
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven] michael-o commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
michael-o commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862331679
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localRepository",
+"mojo",
+"mojoExecution",
+"plugin",
+"project",
+"reactorProjects",
+"session",
+"settings"
+);
+
+private static final List IGNORED_PROPERTY_PREFIX = Arrays.asList(
+"mojo.",
+"plugin.",
+"pom.",
Review Comment:
Beat me, but I am certain that we have worked on it because `pom.` is
deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
michael-o commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862331778
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localRepository",
+"mojo",
+"mojoExecution",
+"plugin",
+"project",
+"reactorProjects",
+"session",
+"settings"
+);
+
+private static final List IGNORED_PROPERTY_PREFIX = Arrays.asList(
+"mojo.",
+"plugin.",
+"pom.",
Review Comment:
b2a21f12f8a0598dd4a286177e340bda0148e9ba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
michael-o commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862331813
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localRepository",
+"mojo",
+"mojoExecution",
+"plugin",
+"project",
+"reactorProjects",
+"session",
+"settings"
+);
+
+private static final List IGNORED_PROPERTY_PREFIX = Arrays.asList(
+"mojo.",
+"plugin.",
+"pom.",
Review Comment:
https://issues.apache.org/jira/browse/MNG-7244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7464) Warn about using read-only parameters for Mojo in configuration
[ https://issues.apache.org/jira/browse/MNG-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530361#comment-17530361 ] Hudson commented on MNG-7464: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-731 #3 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-731/3/ > Warn about using read-only parameters for Mojo in configuration > --- > > Key: MNG-7464 > URL: https://issues.apache.org/jira/browse/MNG-7464 > Project: Maven > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
slawekjaranowski commented on code in PR #731:
URL: https://github.com/apache/maven/pull/731#discussion_r862333656
##
maven-core/src/main/java/org/apache/maven/plugin/internal/AbstractMavenPluginParametersValidator.java:
##
@@ -0,0 +1,153 @@
+package org.apache.maven.plugin.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.maven.plugin.descriptor.Parameter;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.slf4j.Logger;
+
+/**
+ * Common implementations for plugin parameters configuration validation.
+ *
+ * @author Slawomir Jaranowski
+ */
+abstract class AbstractMavenPluginParametersValidator implements
MavenPluginConfigurationValidator
+{
+
+// plugin author can provide @Parameter( property = "session" ) in this
case property will always evaluate
+// so, we need ignore those
+
+// source org.apache.maven.plugin.PluginParameterExpressionEvaluator
+private static final List IGNORED_PROPERTY_VALUES = Arrays.asList(
+"basedir",
+"executedProject",
+"localRepository",
+"mojo",
+"mojoExecution",
+"plugin",
+"project",
+"reactorProjects",
+"session",
+"settings"
+);
+
+private static final List IGNORED_PROPERTY_PREFIX = Arrays.asList(
+"mojo.",
+"plugin.",
+"pom.",
Review Comment:
ok, I will remove `pom` for 4.0.x ... but restore it in 3.9.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] pzygielo commented on pull request #154: [MNG-7464] Warn about using read-only parameters for Mojo in configuration
pzygielo commented on PR #154: URL: https://github.com/apache/maven-integration-testing/pull/154#issuecomment-1113955626 > is first step for MAN-5001 Indeed - and it's even linked to it. I was blind, but now I see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MPMD-329) Upgrade to PMD 6.45.0
[ https://issues.apache.org/jira/browse/MPMD-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-329: Summary: Upgrade to PMD 6.45.0 (was: Upgrade to PMD 6.44.0) > Upgrade to PMD 6.45.0 > - > > Key: MPMD-329 > URL: https://issues.apache.org/jira/browse/MPMD-329 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.17.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MPMD-329) Upgrade to PMD 6.45.0
[ https://issues.apache.org/jira/browse/MPMD-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530365#comment-17530365 ] Andreas Dangel commented on MPMD-329: - Updated to PMD 6.45.0: https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=commit;h=0e8f29d228bc232f6aba51faa7bdcb910a99e666 > Upgrade to PMD 6.45.0 > - > > Key: MPMD-329 > URL: https://issues.apache.org/jira/browse/MPMD-329 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.17.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request, #65: Bump commons-io from 2.6 to 2.7 in /src/it/MPMD-318-auxclasspath-includeTests/module-a
dependabot[bot] opened a new pull request, #65: URL: https://github.com/apache/maven-pmd-plugin/pull/65 Bumps commons-io from 2.6 to 2.7. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-pmd-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7464) Warn about using read-only parameters for Mojo in configuration
[ https://issues.apache.org/jira/browse/MNG-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530367#comment-17530367 ] Hudson commented on MNG-7464: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-731 #4 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-731/4/ > Warn about using read-only parameters for Mojo in configuration > --- > > Key: MNG-7464 > URL: https://issues.apache.org/jira/browse/MNG-7464 > Project: Maven > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MPMD-329) Upgrade to PMD 6.45.0
[ https://issues.apache.org/jira/browse/MPMD-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530368#comment-17530368 ] Hudson commented on MPMD-329: - Build succeeded in Jenkins: Maven » Maven TLP » maven-pmd-plugin » master #21 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-pmd-plugin/job/master/21/ > Upgrade to PMD 6.45.0 > - > > Key: MPMD-329 > URL: https://issues.apache.org/jira/browse/MPMD-329 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.17.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-release] kwin commented on pull request #110: [MRELEASE-955] first pass at release profile documentation
kwin commented on PR #110: URL: https://github.com/apache/maven-release/pull/110#issuecomment-1113965210 Instead of reenabling the deprecated default release profile we should rather document a best practice profile one should copy and adjust to the project pom and probably link to requirements for Maven Central deployment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MJAR-287) Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2
David Georg Reichelt created MJAR-287: - Summary: Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2 Key: MJAR-287 URL: https://issues.apache.org/jira/browse/MJAR-287 Project: Maven JAR Plugin Issue Type: Bug Components: site Affects Versions: 3.3.0 Reporter: David Georg Reichelt If I go on the maven jar plugin site, e.g. on [https://maven.apache.org/shared/maven-archiver/summary.html,] everything says version 3.5.2 is current (also in the right top corner at every page). But as far as I see it, the newest version at least in maven central is 3.2.2 ([https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-jar-plugin).] As an end user, it would be nice if the latest deployed version and the version in the documentation would match (like for the compiler plugin: [https://maven.apache.org/plugins/maven-compiler-plugin/summary.html] where 3.10.1 is the latest version, both on the site and in maven central). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MJAR-287) Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2
[ https://issues.apache.org/jira/browse/MJAR-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anders Hammar closed MJAR-287. -- Resolution: Not A Bug > Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2 > - > > Key: MJAR-287 > URL: https://issues.apache.org/jira/browse/MJAR-287 > Project: Maven JAR Plugin > Issue Type: Bug > Components: site >Affects Versions: 3.3.0 >Reporter: David Georg Reichelt >Priority: Minor > > If I go on the maven jar plugin site, e.g. on > [https://maven.apache.org/shared/maven-archiver/summary.html,] everything > says version 3.5.2 is current (also in the right top corner at every page). > But as far as I see it, the newest version at least in maven central is 3.2.2 > ([https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-jar-plugin).] > As an end user, it would be nice if the latest deployed version and the > version in the documentation would match (like for the compiler plugin: > [https://maven.apache.org/plugins/maven-compiler-plugin/summary.html] where > 3.10.1 is the latest version, both on the site and in maven central). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MJAR-287) Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2
[ https://issues.apache.org/jira/browse/MJAR-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530379#comment-17530379 ] Anders Hammar commented on MJAR-287: The maven-jar-plugin site, https://maven.apache.org/plugins/maven-jar-plugin/, says 3.2.2 as current version. The link you provided is for the "maven-archiver" component. > Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2 > - > > Key: MJAR-287 > URL: https://issues.apache.org/jira/browse/MJAR-287 > Project: Maven JAR Plugin > Issue Type: Bug > Components: site >Affects Versions: 3.3.0 >Reporter: David Georg Reichelt >Priority: Minor > > If I go on the maven jar plugin site, e.g. on > [https://maven.apache.org/shared/maven-archiver/summary.html,] everything > says version 3.5.2 is current (also in the right top corner at every page). > But as far as I see it, the newest version at least in maven central is 3.2.2 > ([https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-jar-plugin).] > As an end user, it would be nice if the latest deployed version and the > version in the documentation would match (like for the compiler plugin: > [https://maven.apache.org/plugins/maven-compiler-plugin/summary.html] where > 3.10.1 is the latest version, both on the site and in maven central). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MJAR-287) Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2
[ https://issues.apache.org/jira/browse/MJAR-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anders Hammar updated MJAR-287: --- Affects Version/s: (was: 3.3.0) > Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2 > - > > Key: MJAR-287 > URL: https://issues.apache.org/jira/browse/MJAR-287 > Project: Maven JAR Plugin > Issue Type: Bug > Components: site >Reporter: David Georg Reichelt >Priority: Minor > > If I go on the maven jar plugin site, e.g. on > [https://maven.apache.org/shared/maven-archiver/summary.html,] everything > says version 3.5.2 is current (also in the right top corner at every page). > But as far as I see it, the newest version at least in maven central is 3.2.2 > ([https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-jar-plugin).] > As an end user, it would be nice if the latest deployed version and the > version in the documentation would match (like for the compiler plugin: > [https://maven.apache.org/plugins/maven-compiler-plugin/summary.html] where > 3.10.1 is the latest version, both on the site and in maven central). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MJAR-287) Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2
[ https://issues.apache.org/jira/browse/MJAR-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530380#comment-17530380 ] David Georg Reichelt commented on MJAR-287: --- Sorry, my mistake. > Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2 > - > > Key: MJAR-287 > URL: https://issues.apache.org/jira/browse/MJAR-287 > Project: Maven JAR Plugin > Issue Type: Bug > Components: site >Reporter: David Georg Reichelt >Priority: Minor > > If I go on the maven jar plugin site, e.g. on > [https://maven.apache.org/shared/maven-archiver/summary.html,] everything > says version 3.5.2 is current (also in the right top corner at every page). > But as far as I see it, the newest version at least in maven central is 3.2.2 > ([https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-jar-plugin).] > As an end user, it would be nice if the latest deployed version and the > version in the documentation would match (like for the compiler plugin: > [https://maven.apache.org/plugins/maven-compiler-plugin/summary.html] where > 3.10.1 is the latest version, both on the site and in maven central). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-wagon] michael-o commented on pull request #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o commented on PR #60: URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-1113974977 JSoup has been removed, time to close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] michael-o closed pull request #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o closed pull request #60: [WAGON-574] advertise jsoup license for shaded jar URL: https://github.com/apache/maven-wagon/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRESOLVER-255) Update Jetty to 9.4.46 (test dependency)
Tamás Cservenák created MRESOLVER-255: - Summary: Update Jetty to 9.4.46 (test dependency) Key: MRESOLVER-255 URL: https://issues.apache.org/jira/browse/MRESOLVER-255 Project: Maven Resolver Issue Type: Dependency upgrade Components: Resolver Reporter: Tamás Cservenák Fix For: 1.8.1 Update Jetty used in maven-resolver-transport-http tests to latest 9.x version. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-resolver] cstamas opened a new pull request, #171: [MRESOLVER-255] Update Jetty to 9.4.46.v20220331
cstamas opened a new pull request, #171: URL: https://github.com/apache/maven-resolver/pull/171 Jetty is used in tests for Transport HTTP only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MRESOLVER-255) Update Jetty to 9.4.46 (test dependency)
[ https://issues.apache.org/jira/browse/MRESOLVER-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MRESOLVER-255: - Assignee: Tamás Cservenák > Update Jetty to 9.4.46 (test dependency) > > > Key: MRESOLVER-255 > URL: https://issues.apache.org/jira/browse/MRESOLVER-255 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Update Jetty used in maven-resolver-transport-http tests to latest 9.x > version. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-resolver] cstamas merged pull request #171: [MRESOLVER-255] Update Jetty to 9.4.46.v20220331
cstamas merged PR #171: URL: https://github.com/apache/maven-resolver/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] dependabot[bot] commented on pull request #165: Bump jetty-server from 9.4.36.v20210114 to 9.4.41.v20210516 in /maven-resolver-transport-http
dependabot[bot] commented on PR #165: URL: https://github.com/apache/maven-resolver/pull/165#issuecomment-1113986821 Looks like org.eclipse.jetty:jetty-server is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] dependabot[bot] closed pull request #165: Bump jetty-server from 9.4.36.v20210114 to 9.4.41.v20210516 in /maven-resolver-transport-http
dependabot[bot] closed pull request #165: Bump jetty-server from 9.4.36.v20210114 to 9.4.41.v20210516 in /maven-resolver-transport-http URL: https://github.com/apache/maven-resolver/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MRESOLVER-255) Update Jetty to 9.4.46 (test dependency)
[ https://issues.apache.org/jira/browse/MRESOLVER-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MRESOLVER-255. --- Resolution: Fixed > Update Jetty to 9.4.46 (test dependency) > > > Key: MRESOLVER-255 > URL: https://issues.apache.org/jira/browse/MRESOLVER-255 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Update Jetty used in maven-resolver-transport-http tests to latest 9.x > version. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MRESOLVER-255) Update Jetty to 9.4.46 (test dependency)
[ https://issues.apache.org/jira/browse/MRESOLVER-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MRESOLVER-255. - > Update Jetty to 9.4.46 (test dependency) > > > Key: MRESOLVER-255 > URL: https://issues.apache.org/jira/browse/MRESOLVER-255 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Update Jetty used in maven-resolver-transport-http tests to latest 9.x > version. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRESOLVER-255) Update Jetty to 9.4.46 (test dependency)
[ https://issues.apache.org/jira/browse/MRESOLVER-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530389#comment-17530389 ] Hudson commented on MRESOLVER-255: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-resolver » master #27 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/27/ > Update Jetty to 9.4.46 (test dependency) > > > Key: MRESOLVER-255 > URL: https://issues.apache.org/jira/browse/MRESOLVER-255 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Update Jetty used in maven-resolver-transport-http tests to latest 9.x > version. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-mvnd] hboutemy opened a new pull request, #625: only publish sha512, skip md5+sha1+sha256
hboutemy opened a new pull request, #625: URL: https://github.com/apache/maven-mvnd/pull/625 ASF does not need md5 nor sha1 nor sha256: only .asc and .sha512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSKINS-178) Upgrade Parent to 36
Michael Osipov created MSKINS-178: - Summary: Upgrade Parent to 36 Key: MSKINS-178 URL: https://issues.apache.org/jira/browse/MSKINS-178 Project: Maven Skins Issue Type: Dependency upgrade Components: Fluido Skin Reporter: Michael Osipov Assignee: Michael Osipov Fix For: fluido-1.11.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MPOM-317) Remove custom Matomo code when Fluido Skin 1.11.0 is used
Michael Osipov created MPOM-317: --- Summary: Remove custom Matomo code when Fluido Skin 1.11.0 is used Key: MPOM-317 URL: https://issues.apache.org/jira/browse/MPOM-317 Project: Maven POMs Issue Type: Task Components: maven Affects Versions: MAVEN-36 Reporter: Michael Osipov -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-release] ViliusS opened a new pull request, #119: Add git example for release:perform
ViliusS opened a new pull request, #119: URL: https://github.com/apache/maven-release/pull/119 Git doesn't support passing tags in the URL, however I have found that passing -Dtag does the trick. This still will work only with 2.3.2 and earlier versions because of https://issues.apache.org/jira/browse/MRELEASE-839 , but at least nobody will have to spent 5 hours like me, trying to find why it doesn't work. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSKINS-179) Upgrade plugins ITs
Michael Osipov created MSKINS-179: - Summary: Upgrade plugins ITs Key: MSKINS-179 URL: https://issues.apache.org/jira/browse/MSKINS-179 Project: Maven Skins Issue Type: Dependency upgrade Components: Fluido Skin Reporter: Michael Osipov Assignee: Michael Osipov Fix For: fluido-1.11.0 * Maven Site Plugin to 3.12.0 * Maven Project Info Reports Plugin 3.12.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MSKINS-180) Raise Doxia Sitetools prerequisite to 1.11.1
Michael Osipov created MSKINS-180: - Summary: Raise Doxia Sitetools prerequisite to 1.11.1 Key: MSKINS-180 URL: https://issues.apache.org/jira/browse/MSKINS-180 Project: Maven Skins Issue Type: Task Components: Fluido Skin Reporter: Michael Osipov Assignee: Michael Osipov Fix For: fluido-1.11.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified
[
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530449#comment-17530449
]
Konrad Windszus commented on MNG-7468:
--
Some plugins use the raw XML elements for configuration, therefore breaking in
4.0 seems kind of hard given that right now there isn’t even a warning. There
should probably be a flag to optionally only issue a warning even in 4.0.
> Unsupported plugins parameters in configuration should be verified
> --
>
> Key: MNG-7468
> URL: https://issues.apache.org/jira/browse/MNG-7468
> Project: Maven
> Issue Type: New Feature
> Components: Plugins and Lifecycle
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
>
> example-maven-plugin
> 1.1.1
>
>
>
>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of
> invalid plugin configuration exception ...
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified
[
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530450#comment-17530450
]
Michael Osipov commented on MNG-7468:
-
[~kwin], can you show one example of such a plugin?
> Unsupported plugins parameters in configuration should be verified
> --
>
> Key: MNG-7468
> URL: https://issues.apache.org/jira/browse/MNG-7468
> Project: Maven
> Issue Type: New Feature
> Components: Plugins and Lifecycle
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
>
> example-maven-plugin
> 1.1.1
>
>
>
>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of
> invalid plugin configuration exception ...
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (MSKINS-181) Replace deprecated Velocity context parameters
Michael Osipov created MSKINS-181: - Summary: Replace deprecated Velocity context parameters Key: MSKINS-181 URL: https://issues.apache.org/jira/browse/MSKINS-181 Project: Maven Skins Issue Type: Task Components: Fluido Skin Reporter: Michael Osipov Assignee: Michael Osipov Fix For: fluido-1.11.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified
[
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530452#comment-17530452
]
Konrad Windszus commented on MNG-7468:
--
I only have an older example which has been adjusted meanwhile but I fear there
may be others:
https://github.com/bndtools/bnd/blob/b9125ed9fd5823d4deaebd788db8499d36a3480d/maven/bnd-maven-plugin/src/main/java/aQute/bnd/maven/plugin/BndMavenPlugin.java#L265
> Unsupported plugins parameters in configuration should be verified
> --
>
> Key: MNG-7468
> URL: https://issues.apache.org/jira/browse/MNG-7468
> Project: Maven
> Issue Type: New Feature
> Components: Plugins and Lifecycle
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
>
> example-maven-plugin
> 1.1.1
>
>
>
>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of
> invalid plugin configuration exception ...
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified
[
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530454#comment-17530454
]
Michael Osipov commented on MNG-7468:
-
[~sjaranowski], I see that as a valid point. I cannot judge whether there are
justified cases for uses Plexus Config directly.
> Unsupported plugins parameters in configuration should be verified
> --
>
> Key: MNG-7468
> URL: https://issues.apache.org/jira/browse/MNG-7468
> Project: Maven
> Issue Type: New Feature
> Components: Plugins and Lifecycle
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
>
> example-maven-plugin
> 1.1.1
>
>
>
>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of
> invalid plugin configuration exception ...
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (MSKINS-172) Non-deliberate margin between navigation and rest in side bar
[
https://issues.apache.org/jira/browse/MSKINS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MSKINS-172:
-
Assignee: Michael Osipov
> Non-deliberate margin between navigation and rest in side bar
> -
>
> Key: MSKINS-172
> URL: https://issues.apache.org/jira/browse/MSKINS-172
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Attachments: fluido-1.7.png, fluido-1.9.png
>
>
> Due to the change
> https://github.com/apache/maven-fluido-skin/commit/f9cbe82ff307c61cefe0336da89eb0082086585a#diff-f1940cd019654c7f2cb1801363b96b62c6526752fa8640c8de042ea4f0f36778R226
> introduced with MSKINS-153 there is a margin between the navigation and the
> google site search bar and the powered by section. For example look at
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html.
> This is caused by the markup change from
> {code}
>
> ...menu, search bar and powered by
>
> {code} to
> {code}
>
> ...menu
>
>
> ...search bar and powered by
>
> {code}
> combined with the CSS for class {{sidebar-nav}}:
> https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L126
> Example site leveraging fluido 1.9
> (https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html):
> !fluido-1.9.png!
> Example site leveraging fluido 1.7
> (https://maven.apache.org/plugins/maven-compiler-plugin/index.html referenced
> in
> https://github.com/apache/maven-parent/blob/maven-parent-34/src/site/site.xml#L39):
> !fluido-1.7.png!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (MSKINS-172) Non-deliberate margin between navigation and rest in side bar
[
https://issues.apache.org/jira/browse/MSKINS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSKINS-172:
--
Fix Version/s: fluido-1.11.0
> Non-deliberate margin between navigation and rest in side bar
> -
>
> Key: MSKINS-172
> URL: https://issues.apache.org/jira/browse/MSKINS-172
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: fluido-1.7.png, fluido-1.9.png
>
>
> Due to the change
> https://github.com/apache/maven-fluido-skin/commit/f9cbe82ff307c61cefe0336da89eb0082086585a#diff-f1940cd019654c7f2cb1801363b96b62c6526752fa8640c8de042ea4f0f36778R226
> introduced with MSKINS-153 there is a margin between the navigation and the
> google site search bar and the powered by section. For example look at
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html.
> This is caused by the markup change from
> {code}
>
> ...menu, search bar and powered by
>
> {code} to
> {code}
>
> ...menu
>
>
> ...search bar and powered by
>
> {code}
> combined with the CSS for class {{sidebar-nav}}:
> https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L126
> Example site leveraging fluido 1.9
> (https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html):
> !fluido-1.9.png!
> Example site leveraging fluido 1.7
> (https://maven.apache.org/plugins/maven-compiler-plugin/index.html referenced
> in
> https://github.com/apache/maven-parent/blob/maven-parent-34/src/site/site.xml#L39):
> !fluido-1.7.png!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MSKINS-172) Non-deliberate margin between navigation and rest in side bar
[
https://issues.apache.org/jira/browse/MSKINS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530455#comment-17530455
]
Michael Osipov commented on MSKINS-172:
---
I will reduce the margin to 5px. This is visually acceptable and both boxes
won't stick together.
> Non-deliberate margin between navigation and rest in side bar
> -
>
> Key: MSKINS-172
> URL: https://issues.apache.org/jira/browse/MSKINS-172
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: fluido-1.7.png, fluido-1.9.png
>
>
> Due to the change
> https://github.com/apache/maven-fluido-skin/commit/f9cbe82ff307c61cefe0336da89eb0082086585a#diff-f1940cd019654c7f2cb1801363b96b62c6526752fa8640c8de042ea4f0f36778R226
> introduced with MSKINS-153 there is a margin between the navigation and the
> google site search bar and the powered by section. For example look at
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html.
> This is caused by the markup change from
> {code}
>
> ...menu, search bar and powered by
>
> {code} to
> {code}
>
> ...menu
>
>
> ...search bar and powered by
>
> {code}
> combined with the CSS for class {{sidebar-nav}}:
> https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L126
> Example site leveraging fluido 1.9
> (https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html):
> !fluido-1.9.png!
> Example site leveraging fluido 1.7
> (https://maven.apache.org/plugins/maven-compiler-plugin/index.html referenced
> in
> https://github.com/apache/maven-parent/blob/maven-parent-34/src/site/site.xml#L39):
> !fluido-1.7.png!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MSKINS-117) Improve lisibility and user-friendliness in the left menu
[ https://issues.apache.org/jira/browse/MSKINS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530456#comment-17530456 ] Michael Osipov commented on MSKINS-117: --- Is this one still valid? I cannot reproduce it with 1.11.0. > Improve lisibility and user-friendliness in the left menu > - > > Key: MSKINS-117 > URL: https://issues.apache.org/jira/browse/MSKINS-117 > Project: Maven Skins > Issue Type: Wish > Components: Fluido Skin >Affects Versions: fluido-1.4 >Reporter: Cyril JACQUENOT >Priority: Major > Labels: close-pending > Attachments: actual_skin_bad_lisibility.jpg, > skin_maven_old_better_lisibility.jpg > > > In our company, we now use *Maven Fluido Skin* for our projects > online-documentation. > I like the design but the lisibility is not optimal: it is hard for me to > find the location of my current page in the menu. > Great improvements should be : > * to increase indentations > * to use fonts weight to show different levels of indentation > * to give the possibility to manage more than 2 levels in the menu > _here is the bad lisibility skin :_ > !actual_skin_bad_lisibility.jpg! > _here is an old skin, but with *better lisibility* :_ > !skin_maven_old_better_lisibility.jpg! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-117) Improve lisibility and user-friendliness in the left menu
[ https://issues.apache.org/jira/browse/MSKINS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-117: -- Fix Version/s: wontfix-candidate > Improve lisibility and user-friendliness in the left menu > - > > Key: MSKINS-117 > URL: https://issues.apache.org/jira/browse/MSKINS-117 > Project: Maven Skins > Issue Type: Wish > Components: Fluido Skin >Affects Versions: fluido-1.4 >Reporter: Cyril JACQUENOT >Priority: Major > Labels: close-pending > Fix For: wontfix-candidate > > Attachments: actual_skin_bad_lisibility.jpg, > skin_maven_old_better_lisibility.jpg > > > In our company, we now use *Maven Fluido Skin* for our projects > online-documentation. > I like the design but the lisibility is not optimal: it is hard for me to > find the location of my current page in the menu. > Great improvements should be : > * to increase indentations > * to use fonts weight to show different levels of indentation > * to give the possibility to manage more than 2 levels in the menu > _here is the bad lisibility skin :_ > !actual_skin_bad_lisibility.jpg! > _here is an old skin, but with *better lisibility* :_ > !skin_maven_old_better_lisibility.jpg! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-117) Improve lisibility and user-friendliness in the left menu
[ https://issues.apache.org/jira/browse/MSKINS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-117: -- Labels: (was: close-pending) > Improve lisibility and user-friendliness in the left menu > - > > Key: MSKINS-117 > URL: https://issues.apache.org/jira/browse/MSKINS-117 > Project: Maven Skins > Issue Type: Wish > Components: Fluido Skin >Affects Versions: fluido-1.4 >Reporter: Cyril JACQUENOT >Priority: Major > Fix For: wontfix-candidate > > Attachments: actual_skin_bad_lisibility.jpg, > skin_maven_old_better_lisibility.jpg > > > In our company, we now use *Maven Fluido Skin* for our projects > online-documentation. > I like the design but the lisibility is not optimal: it is hard for me to > find the location of my current page in the menu. > Great improvements should be : > * to increase indentations > * to use fonts weight to show different levels of indentation > * to give the possibility to manage more than 2 levels in the menu > _here is the bad lisibility skin :_ > !actual_skin_bad_lisibility.jpg! > _here is an old skin, but with *better lisibility* :_ > !skin_maven_old_better_lisibility.jpg! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (MSKINS-172) Non-deliberate margin between navigation and rest in side bar
[
https://issues.apache.org/jira/browse/MSKINS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530455#comment-17530455
]
Michael Osipov edited comment on MSKINS-172 at 4/30/22 9:01 PM:
I will reduce the margin to 10px. This is visually acceptable and both boxes
won't stick together.
was (Author: michael-o):
I will reduce the margin to 5px. This is visually acceptable and both boxes
won't stick together.
> Non-deliberate margin between navigation and rest in side bar
> -
>
> Key: MSKINS-172
> URL: https://issues.apache.org/jira/browse/MSKINS-172
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: fluido-1.7.png, fluido-1.9.png
>
>
> Due to the change
> https://github.com/apache/maven-fluido-skin/commit/f9cbe82ff307c61cefe0336da89eb0082086585a#diff-f1940cd019654c7f2cb1801363b96b62c6526752fa8640c8de042ea4f0f36778R226
> introduced with MSKINS-153 there is a margin between the navigation and the
> google site search bar and the powered by section. For example look at
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html.
> This is caused by the markup change from
> {code}
>
> ...menu, search bar and powered by
>
> {code} to
> {code}
>
> ...menu
>
>
> ...search bar and powered by
>
> {code}
> combined with the CSS for class {{sidebar-nav}}:
> https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L126
> Example site leveraging fluido 1.9
> (https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html):
> !fluido-1.9.png!
> Example site leveraging fluido 1.7
> (https://maven.apache.org/plugins/maven-compiler-plugin/index.html referenced
> in
> https://github.com/apache/maven-parent/blob/maven-parent-34/src/site/site.xml#L39):
> !fluido-1.7.png!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (MSKINS-182) Fix padding of search input form
Michael Osipov created MSKINS-182: - Summary: Fix padding of search input form Key: MSKINS-182 URL: https://issues.apache.org/jira/browse/MSKINS-182 Project: Maven Skins Issue Type: Bug Components: Fluido Skin Affects Versions: fluido-1.10.0 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: fluido-1.11.0 Attachments: screenshot-1.png The padding is currently out of bounds: -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-182) Fix padding of search input form
[ https://issues.apache.org/jira/browse/MSKINS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-182: -- Attachment: screenshot-1.png > Fix padding of search input form > > > Key: MSKINS-182 > URL: https://issues.apache.org/jira/browse/MSKINS-182 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.10.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > Attachments: screenshot-1.png > > > The padding is currently out of bounds: -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-182) Fix padding of search input form
[ https://issues.apache.org/jira/browse/MSKINS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-182: -- Description: The padding is currently out of bounds: !screenshot-1.png! Make the search input form inside the bounds of the div element. was: The padding is currently out of bounds: > Fix padding of search input form > > > Key: MSKINS-182 > URL: https://issues.apache.org/jira/browse/MSKINS-182 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.10.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > Attachments: screenshot-1.png > > > The padding is currently out of bounds: > !screenshot-1.png! > Make the search input form inside the bounds of the div element. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-169) image height not effective
[
https://issues.apache.org/jira/browse/MSKINS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530459#comment-17530459
]
Michael Osipov commented on MSKINS-169:
---
Reason: https://stackoverflow.com/a/44010892/696632
Fix: use inline CSS, no other way to solve this.
> image height not effective
> --
>
> Key: MSKINS-169
> URL: https://issues.apache.org/jira/browse/MSKINS-169
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.9
>Reporter: Konrad Windszus
>Priority: Major
>
> As bootstrap 2.3.2 styles all images with {{height: auto}}
> (https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/css/bootstrap-2.3.2.css#L103)
> setting a height in
> https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerLeft
> does not have any effect (although the HTML img element carries it, it is
> overwritten by the bootstrap.css)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (MSKINS-178) Upgrade Parent to 36
[ https://issues.apache.org/jira/browse/MSKINS-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-178. - Resolution: Fixed Fixed with [2d0db13be254cd0b9007baab4c5294fde6eed0c1|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=2d0db13be254cd0b9007baab4c5294fde6eed0c1]. > Upgrade Parent to 36 > > > Key: MSKINS-178 > URL: https://issues.apache.org/jira/browse/MSKINS-178 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MSKINS-181) Replace deprecated Velocity context parameters
[ https://issues.apache.org/jira/browse/MSKINS-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-181. - Resolution: Fixed Fixed with [e39a0c67a0f4284f23cd298d83965d87062d4f6d|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=e39a0c67a0f4284f23cd298d83965d87062d4f6d]. > Replace deprecated Velocity context parameters > -- > > Key: MSKINS-181 > URL: https://issues.apache.org/jira/browse/MSKINS-181 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MSKINS-179) Upgrade plugins ITs
[ https://issues.apache.org/jira/browse/MSKINS-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-179. - Resolution: Fixed Fixed with [9b3a6ca879430f53f4d17a48cdfa8cd4076e19fe|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=9b3a6ca879430f53f4d17a48cdfa8cd4076e19fe]. > Upgrade plugins ITs > --- > > Key: MSKINS-179 > URL: https://issues.apache.org/jira/browse/MSKINS-179 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > > * Maven Site Plugin to 3.12.0 > * Maven Project Info Reports Plugin 3.12.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MSKINS-180) Raise Doxia Sitetools prerequisite to 1.11.1
[ https://issues.apache.org/jira/browse/MSKINS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-180. - Resolution: Fixed Fixed with [18665825b16e1d675b5039fa887af7d6a9abec12|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=18665825b16e1d675b5039fa887af7d6a9abec12]. > Raise Doxia Sitetools prerequisite to 1.11.1 > > > Key: MSKINS-180 > URL: https://issues.apache.org/jira/browse/MSKINS-180 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MSKINS-172) Non-deliberate margin between navigation and rest in side bar
[
https://issues.apache.org/jira/browse/MSKINS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MSKINS-172.
-
Resolution: Fixed
Fixed with
[fcad04c7fa9dcb5336bc9c399253d78d340b2b56|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=fcad04c7fa9dcb5336bc9c399253d78d340b2b56].
> Non-deliberate margin between navigation and rest in side bar
> -
>
> Key: MSKINS-172
> URL: https://issues.apache.org/jira/browse/MSKINS-172
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: fluido-1.7.png, fluido-1.9.png
>
>
> Due to the change
> https://github.com/apache/maven-fluido-skin/commit/f9cbe82ff307c61cefe0336da89eb0082086585a#diff-f1940cd019654c7f2cb1801363b96b62c6526752fa8640c8de042ea4f0f36778R226
> introduced with MSKINS-153 there is a margin between the navigation and the
> google site search bar and the powered by section. For example look at
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html.
> This is caused by the markup change from
> {code}
>
> ...menu, search bar and powered by
>
> {code} to
> {code}
>
> ...menu
>
>
> ...search bar and powered by
>
> {code}
> combined with the CSS for class {{sidebar-nav}}:
> https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L126
> Example site leveraging fluido 1.9
> (https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html):
> !fluido-1.9.png!
> Example site leveraging fluido 1.7
> (https://maven.apache.org/plugins/maven-compiler-plugin/index.html referenced
> in
> https://github.com/apache/maven-parent/blob/maven-parent-34/src/site/site.xml#L39):
> !fluido-1.7.png!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (MSKINS-182) Fix padding of search input form
[ https://issues.apache.org/jira/browse/MSKINS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-182. - Resolution: Fixed Fixed with [ce84a312dee11becf2c37ff6b32694bcb030e5df|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=ce84a312dee11becf2c37ff6b32694bcb030e5df]. > Fix padding of search input form > > > Key: MSKINS-182 > URL: https://issues.apache.org/jira/browse/MSKINS-182 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.10.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > Attachments: screenshot-1.png > > > The padding is currently out of bounds: > !screenshot-1.png! > Make the search input form inside the bounds of the div element. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-169) image height not effective
[
https://issues.apache.org/jira/browse/MSKINS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSKINS-169:
--
Fix Version/s: fluido-1.11.0
> image height not effective
> --
>
> Key: MSKINS-169
> URL: https://issues.apache.org/jira/browse/MSKINS-169
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.9
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
>
> As bootstrap 2.3.2 styles all images with {{height: auto}}
> (https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/css/bootstrap-2.3.2.css#L103)
> setting a height in
> https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerLeft
> does not have any effect (although the HTML img element carries it, it is
> overwritten by the bootstrap.css)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (MSKINS-169) image height not effective
[
https://issues.apache.org/jira/browse/MSKINS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MSKINS-169:
-
Assignee: Michael Osipov
> image height not effective
> --
>
> Key: MSKINS-169
> URL: https://issues.apache.org/jira/browse/MSKINS-169
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.9
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
>
> As bootstrap 2.3.2 styles all images with {{height: auto}}
> (https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/css/bootstrap-2.3.2.css#L103)
> setting a height in
> https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerLeft
> does not have any effect (although the HTML img element carries it, it is
> overwritten by the bootstrap.css)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (MSKINS-173) Google site search box too wide in sidebar
[
https://issues.apache.org/jira/browse/MSKINS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSKINS-173:
--
Fix Version/s: fluido-1.11.0
> Google site search box too wide in sidebar
> --
>
> Key: MSKINS-173
> URL: https://issues.apache.org/jira/browse/MSKINS-173
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: Screenshot 2021-08-10 at 18.07.30.png
>
>
> The Google Site search input box is too wide for the site bar. Example in
> https://maven.apache.org/plugins/maven-compiler-plugin/index.html.
> !Screenshot 2021-08-10 at 18.07.30.png!
> This is caused by the width being {{95%}}
> (https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L69)
> combined with the default padding for {{input.search-query}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Comment Edited] (MSKINS-182) Fix padding of search input form
[ https://issues.apache.org/jira/browse/MSKINS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530465#comment-17530465 ] Michael Osipov edited comment on MSKINS-182 at 4/30/22 9:50 PM: Fixed with [ce84a312dee11becf2c37ff6b32694bcb030e5df|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=ce84a312dee11becf2c37ff6b32694bcb030e5df]. was (Author: michael-o): Fixed with [ce84a312dee11becf2c37ff6b32694bcb030e5df|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=ce84a312dee11becf2c37ff6b32694bcb030e5df]. > Fix padding of search input form > > > Key: MSKINS-182 > URL: https://issues.apache.org/jira/browse/MSKINS-182 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.10.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > Attachments: screenshot-1.png > > > The padding is currently out of bounds: > !screenshot-1.png! > Make the search input form inside the bounds of the div element. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (MSKINS-173) Google site search box too wide in sidebar
[
https://issues.apache.org/jira/browse/MSKINS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MSKINS-173:
-
Assignee: Michael Osipov
> Google site search box too wide in sidebar
> --
>
> Key: MSKINS-173
> URL: https://issues.apache.org/jira/browse/MSKINS-173
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Attachments: Screenshot 2021-08-10 at 18.07.30.png
>
>
> The Google Site search input box is too wide for the site bar. Example in
> https://maven.apache.org/plugins/maven-compiler-plugin/index.html.
> !Screenshot 2021-08-10 at 18.07.30.png!
> This is caused by the width being {{95%}}
> (https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L69)
> combined with the default padding for {{input.search-query}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MSKINS-173) Google site search box too wide in sidebar
[
https://issues.apache.org/jira/browse/MSKINS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530466#comment-17530466
]
Michael Osipov commented on MSKINS-173:
---
Fixed with
[ce84a312dee11becf2c37ff6b32694bcb030e5df|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=ce84a312dee11becf2c37ff6b32694bcb030e5df].
> Google site search box too wide in sidebar
> --
>
> Key: MSKINS-173
> URL: https://issues.apache.org/jira/browse/MSKINS-173
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Reporter: Konrad Windszus
>Priority: Major
> Attachments: Screenshot 2021-08-10 at 18.07.30.png
>
>
> The Google Site search input box is too wide for the site bar. Example in
> https://maven.apache.org/plugins/maven-compiler-plugin/index.html.
> !Screenshot 2021-08-10 at 18.07.30.png!
> This is caused by the width being {{95%}}
> (https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L69)
> combined with the default padding for {{input.search-query}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] (MSKINS-182) Fix padding of search input form
[ https://issues.apache.org/jira/browse/MSKINS-182 ] Michael Osipov deleted comment on MSKINS-182: --- was (Author: michael-o): Fixed with [ce84a312dee11becf2c37ff6b32694bcb030e5df|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=ce84a312dee11becf2c37ff6b32694bcb030e5df]. > Fix padding of search input form > > > Key: MSKINS-182 > URL: https://issues.apache.org/jira/browse/MSKINS-182 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.10.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Attachments: screenshot-1.png > > > The padding is currently out of bounds: > !screenshot-1.png! > Make the search input form inside the bounds of the div element. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MSKINS-182) Fix padding of search input form
[ https://issues.apache.org/jira/browse/MSKINS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-182. - Fix Version/s: (was: fluido-1.11.0) Resolution: Duplicate > Fix padding of search input form > > > Key: MSKINS-182 > URL: https://issues.apache.org/jira/browse/MSKINS-182 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.10.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Attachments: screenshot-1.png > > > The padding is currently out of bounds: > !screenshot-1.png! > Make the search input form inside the bounds of the div element. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Reopened] (MSKINS-182) Fix padding of search input form
[ https://issues.apache.org/jira/browse/MSKINS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MSKINS-182: --- > Fix padding of search input form > > > Key: MSKINS-182 > URL: https://issues.apache.org/jira/browse/MSKINS-182 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.10.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > Attachments: screenshot-1.png > > > The padding is currently out of bounds: > !screenshot-1.png! > Make the search input form inside the bounds of the div element. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MSKINS-173) Google site search box too wide in sidebar
[
https://issues.apache.org/jira/browse/MSKINS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MSKINS-173.
-
Resolution: Fixed
> Google site search box too wide in sidebar
> --
>
> Key: MSKINS-173
> URL: https://issues.apache.org/jira/browse/MSKINS-173
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: Screenshot 2021-08-10 at 18.07.30.png
>
>
> The Google Site search input box is too wide for the site bar. Example in
> https://maven.apache.org/plugins/maven-compiler-plugin/index.html.
> !Screenshot 2021-08-10 at 18.07.30.png!
> This is caused by the width being {{95%}}
> (https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L69)
> combined with the default padding for {{input.search-query}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MSKINS-178) Upgrade Parent to 36
[ https://issues.apache.org/jira/browse/MSKINS-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530467#comment-17530467 ] Hudson commented on MSKINS-178: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-fluido-skin » master #10 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-fluido-skin/job/master/10/ > Upgrade Parent to 36 > > > Key: MSKINS-178 > URL: https://issues.apache.org/jira/browse/MSKINS-178 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-180) Raise Doxia Sitetools prerequisite to 1.11.1
[ https://issues.apache.org/jira/browse/MSKINS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530469#comment-17530469 ] Hudson commented on MSKINS-180: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-fluido-skin » master #10 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-fluido-skin/job/master/10/ > Raise Doxia Sitetools prerequisite to 1.11.1 > > > Key: MSKINS-180 > URL: https://issues.apache.org/jira/browse/MSKINS-180 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-181) Replace deprecated Velocity context parameters
[ https://issues.apache.org/jira/browse/MSKINS-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530470#comment-17530470 ] Hudson commented on MSKINS-181: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-fluido-skin » master #10 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-fluido-skin/job/master/10/ > Replace deprecated Velocity context parameters > -- > > Key: MSKINS-181 > URL: https://issues.apache.org/jira/browse/MSKINS-181 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-182) Fix padding of search input form
[ https://issues.apache.org/jira/browse/MSKINS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530472#comment-17530472 ] Hudson commented on MSKINS-182: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-fluido-skin » master #10 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-fluido-skin/job/master/10/ > Fix padding of search input form > > > Key: MSKINS-182 > URL: https://issues.apache.org/jira/browse/MSKINS-182 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.10.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Attachments: screenshot-1.png > > > The padding is currently out of bounds: > !screenshot-1.png! > Make the search input form inside the bounds of the div element. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-179) Upgrade plugins ITs
[ https://issues.apache.org/jira/browse/MSKINS-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530468#comment-17530468 ] Hudson commented on MSKINS-179: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-fluido-skin » master #10 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-fluido-skin/job/master/10/ > Upgrade plugins ITs > --- > > Key: MSKINS-179 > URL: https://issues.apache.org/jira/browse/MSKINS-179 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.11.0 > > > * Maven Site Plugin to 3.12.0 > * Maven Project Info Reports Plugin 3.12.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-172) Non-deliberate margin between navigation and rest in side bar
[
https://issues.apache.org/jira/browse/MSKINS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530471#comment-17530471
]
Hudson commented on MSKINS-172:
---
Build succeeded in Jenkins: Maven » Maven TLP » maven-fluido-skin » master #10
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-fluido-skin/job/master/10/
> Non-deliberate margin between navigation and rest in side bar
> -
>
> Key: MSKINS-172
> URL: https://issues.apache.org/jira/browse/MSKINS-172
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: fluido-1.7.png, fluido-1.9.png
>
>
> Due to the change
> https://github.com/apache/maven-fluido-skin/commit/f9cbe82ff307c61cefe0336da89eb0082086585a#diff-f1940cd019654c7f2cb1801363b96b62c6526752fa8640c8de042ea4f0f36778R226
> introduced with MSKINS-153 there is a margin between the navigation and the
> google site search bar and the powered by section. For example look at
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html.
> This is caused by the markup change from
> {code}
>
> ...menu, search bar and powered by
>
> {code} to
> {code}
>
> ...menu
>
>
> ...search bar and powered by
>
> {code}
> combined with the CSS for class {{sidebar-nav}}:
> https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L126
> Example site leveraging fluido 1.9
> (https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html):
> !fluido-1.9.png!
> Example site leveraging fluido 1.7
> (https://maven.apache.org/plugins/maven-compiler-plugin/index.html referenced
> in
> https://github.com/apache/maven-parent/blob/maven-parent-34/src/site/site.xml#L39):
> !fluido-1.7.png!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope
Henning Schmiedehausen created MDEP-804: --- Summary: Allow auto-ignore of all non-test scoped dependencies used only in test scope Key: MDEP-804 URL: https://issues.apache.org/jira/browse/MDEP-804 Project: Maven Dependency Plugin Issue Type: New Feature Components: analyze Affects Versions: 3.3.0 Reporter: Henning Schmiedehausen Pre-3.2.0, dependencies that were used only in test scope but not declared in test scope (most likely declared in compile scope) were accepted by the plugin and not flagged as a problem. Starting with 3.2.0 (and the current 3.3.0), these are reported with "Non-test scoped test only dependencies found". If the scope of the dependencies can not be changed (there are many reasons for that in large projects), the old behavior can be restored by adding each flagged dependency to the "ignoredNonTestScopedDependencies" configuration option in the respective project. This is, especially in large projects, cumbersome and brittle. There should be a boolean flag, "ignoreAllNonTestScoped" that, when set, allows ignoring non-test scoped dependencies if they are used only in test scope. This flag restores the pre-3.2.0 behavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-dependency-plugin] hgschmie opened a new pull request, #211: [MDEP-804] - Allow auto-ignore of all non-test scoped dependencies used only in test scope
hgschmie opened a new pull request, #211: URL: https://github.com/apache/maven-dependency-plugin/pull/211 Implements a flag that allows ignoring non-test scoped dependencies when they are used only in test scope. Includes integration test that verifies the behavior. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
