[jira] [Commented] (MDEP-792) Log4j vulnerability dependencies getting downloaded during the Maven build process
[ https://issues.apache.org/jira/browse/MDEP-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493048#comment-17493048 ] Slawomir Jaranowski commented on MDEP-792: -- How it is connected with maven-dependency-plugin? Which version maven-dependency-plugin are you use? Can you provide minimal example project to reproduce this issue? > Log4j vulnerability dependencies getting downloaded during the Maven build > process > -- > > Key: MDEP-792 > URL: https://issues.apache.org/jira/browse/MDEP-792 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: unpack-dependencies > Environment: Jenkins Build >Reporter: Abhishek Patnaik >Priority: Major > Attachments: Log4j_Vulverability_Problem.docx > > > We are using Maven as a build tool for MuleSoft application using Jenkins. > As part of log4j2 vulnerability scan reports, the MuleSoft Jenkins build > servers got listed. > We verified application Jar file not referring these older versions of log4j. > Below are the findings when we use 3.6.3 and 3.8.4 versions of maven. > Before running the build, we have already clean-up the /tmp & /.m2. > | |*Maven 3.6.3*|*After upgrade Maven 3.8.4*| > |log4j|2.11.2 > 2.13.1 > 2.17.1 > 2.9.1|2.11.2 > 2.13.1 > 2.17.1 > 2.9.1| > |log4j-1.2-api|2.13.1|2.13.1| > |log4j-api|2.13.1 > 2.17.1 > 2.9.1|2.13.1 > 2.17.1 > 2.9.1| > |log4j-core|2.13.1 > 2.17.1 > 2.9.1|2.13.1 > 2.17.1 > 2.9.1| > |log4j-slf4j-impl|2.11.2 > 2.13.1 > 2.9.1|2.11.2 > 2.13.1 > 2.9.1| -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MDEP-792) Log4j vulnerability dependencies getting downloaded during the Maven build process
[ https://issues.apache.org/jira/browse/MDEP-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493058#comment-17493058 ] Michael Osipov commented on MDEP-792: - [~apatnaik], as far as I can see you are already vulnerable and your system has been compromised. The ransom will be requested in the next couple of days. Contact your treasurer to get funds. > Log4j vulnerability dependencies getting downloaded during the Maven build > process > -- > > Key: MDEP-792 > URL: https://issues.apache.org/jira/browse/MDEP-792 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: unpack-dependencies > Environment: Jenkins Build >Reporter: Abhishek Patnaik >Priority: Major > Attachments: Log4j_Vulverability_Problem.docx > > > We are using Maven as a build tool for MuleSoft application using Jenkins. > As part of log4j2 vulnerability scan reports, the MuleSoft Jenkins build > servers got listed. > We verified application Jar file not referring these older versions of log4j. > Below are the findings when we use 3.6.3 and 3.8.4 versions of maven. > Before running the build, we have already clean-up the /tmp & /.m2. > | |*Maven 3.6.3*|*After upgrade Maven 3.8.4*| > |log4j|2.11.2 > 2.13.1 > 2.17.1 > 2.9.1|2.11.2 > 2.13.1 > 2.17.1 > 2.9.1| > |log4j-1.2-api|2.13.1|2.13.1| > |log4j-api|2.13.1 > 2.17.1 > 2.9.1|2.13.1 > 2.17.1 > 2.9.1| > |log4j-core|2.13.1 > 2.17.1 > 2.9.1|2.13.1 > 2.17.1 > 2.9.1| > |log4j-slf4j-impl|2.11.2 > 2.13.1 > 2.9.1|2.11.2 > 2.13.1 > 2.9.1| -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven] michael-o commented on a change in pull request #672: [MNG-7406] Better display of project building errors
michael-o commented on a change in pull request #672:
URL: https://github.com/apache/maven/pull/672#discussion_r807665537
##
File path:
maven-core/src/main/java/org/apache/maven/project/ProjectBuildingException.java
##
@@ -72,7 +67,7 @@ protected ProjectBuildingException( String projectId, String
message, File pomFi
public ProjectBuildingException( List results )
{
-super( createMessage( results ) );
+super( "Some problems were encountered while processing the POMs" );
Review comment:
I guess the message applies to the entire reactor, doesn't it? If so,
leave as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #672: [MNG-7406] Better display of project building errors
mthmulders commented on a change in pull request #672:
URL: https://github.com/apache/maven/pull/672#discussion_r807675659
##
File path:
maven-core/src/main/java/org/apache/maven/project/ProjectBuildingException.java
##
@@ -72,7 +67,7 @@ protected ProjectBuildingException( String projectId, String
message, File pomFi
public ProjectBuildingException( List results )
{
-super( createMessage( results ) );
+super( "Some problems were encountered while processing the POMs" );
Review comment:
> I guess the message applies to the entire reactor, doesn't it?
It does. I'll consider this resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MNGSITE-480) IDE Codestyle vs Maven Checkstyle: a bossfight
Tamás Cservenák created MNGSITE-480:
---
Summary: IDE Codestyle vs Maven Checkstyle: a bossfight
Key: MNGSITE-480
URL: https://issues.apache.org/jira/browse/MNGSITE-480
Project: Maven Project Web Site
Issue Type: Bug
Reporter: Tamás Cservenák
Codestyle updated in MNGSITE-465 for Idea has discrepancies wrt checkstyle
plugin rules.
Typical example:
IDEA IDE reformat result:
{noformat}
StreamSupport.stream( iteratorSearchResponse.iterator().spliterator(), false )
.sorted( ArtifactInfo.VERSION_COMPARATOR ).forEach( ai -> {
artifactInfos.add( ai );
page.add( convert( ai, null ) );
} );
{noformat}
But, checktyle:
{noformat}
[ERROR]
src/main/java/org/apache/maven/index/search/backend/indexer/internal/IndexerCoreSearchBackendImpl.java:[127,83]
(blocks) LeftCurly: '{' at column 83 should be on a new line.{noformat}
In short, for me it looks like our checkstyle is too rigid, unprepared for Java
8 lambdas? (as IMHO the code snippet above with curly on next line would look
awkward).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MNG-7414) Maven version 3.8.3 + 3.8.4 have jsoup vulnerability
Ksenia Hershkovici created MNG-7414: --- Summary: Maven version 3.8.3 + 3.8.4 have jsoup vulnerability Key: MNG-7414 URL: https://issues.apache.org/jira/browse/MNG-7414 Project: Maven Issue Type: Bug Reporter: Ksenia Hershkovici Hi Team, We are facing jsoup component vulnerability with maven versions 3.8.3 and 3.8.4 which is the latest released version of maven. The CVE details are: CVE-2021-37714 Jsoup version which is getting installed while installing maven 3.8.3 and 3.8.4 is v1.12.1. We noticed that both versions have wagon 3.4.3 that is probably installing Jsoup v1.12.1. Can you please provide the details of next maven version release with this fix in it? Thanks. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SCM-977) Retrieve the tags on commits using the changelog command.
Niels Basjes created SCM-977: Summary: Retrieve the tags on commits using the changelog command. Key: SCM-977 URL: https://issues.apache.org/jira/browse/SCM-977 Project: Maven SCM Issue Type: New Feature Components: maven-scm-api, maven-scm-provider-gitexe, maven-scm-provider-jgit Reporter: Niels Basjes My aim is to support having something like [https://www.conventionalcommits.org/] in the maven-release-plugin. This simply means that the next version of a release is calculated from the last tag in the version history and the patterns in the commit messages since that tag. To support this idea the maven-scm should be extended to also retrieve the tags with the changelog command on SCM implementations that support this idea. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (MRELEASE-1078) Conventional Commits: Next version depends on tags and commits.
Niels Basjes created MRELEASE-1078: -- Summary: Conventional Commits: Next version depends on tags and commits. Key: MRELEASE-1078 URL: https://issues.apache.org/jira/browse/MRELEASE-1078 Project: Maven Release Plugin Issue Type: New Feature Reporter: Niels Basjes My aim is to support having something like [https://www.conventionalcommits.org/] in the maven-release-plugin. This simply means that the next version of a release is calculated from the last tag in the version history and the patterns in the commit messages since that tag. This issue depends on https://issues.apache.org/jira/browse/SCM-977 being available (i.e. we have the commit messages and tags available). h4. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7414) Maven version 3.8.3 + 3.8.4 have jsoup vulnerability
[ https://issues.apache.org/jira/browse/MNG-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493107#comment-17493107 ] Michael Osipov commented on MNG-7414: - Which vuln are you expriencing? > Maven version 3.8.3 + 3.8.4 have jsoup vulnerability > > > Key: MNG-7414 > URL: https://issues.apache.org/jira/browse/MNG-7414 > Project: Maven > Issue Type: Bug >Reporter: Ksenia Hershkovici >Priority: Major > > Hi Team, > We are facing jsoup component vulnerability with maven versions 3.8.3 and > 3.8.4 which is the latest released version of maven. The CVE details are: > CVE-2021-37714 > Jsoup version which is getting installed while installing maven 3.8.3 and > 3.8.4 is v1.12.1. > We noticed that both versions have wagon 3.4.3 that is probably installing > Jsoup v1.12.1. > Can you please provide the details of next maven version release with this > fix in it? > Thanks. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNGSITE-480) IDE Codestyle vs Maven Checkstyle: a bossfight
[
https://issues.apache.org/jira/browse/MNGSITE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493127#comment-17493127
]
Benjamin Marwell commented on MNGSITE-480:
--
need to remove the "LAMBDA" token from
[https://checkstyle.sourceforge.io/config_blocks.html#LeftCurly] check.
Maybe even add a second "LeftCurly" check with tokens="LAMBDA" option="eol".
> IDE Codestyle vs Maven Checkstyle: a bossfight
> --
>
> Key: MNGSITE-480
> URL: https://issues.apache.org/jira/browse/MNGSITE-480
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Tamás Cservenák
>Priority: Major
>
> Codestyle updated in MNGSITE-465 for Idea has discrepancies wrt checkstyle
> plugin rules.
>
> Typical example:
> IDEA IDE reformat result:
> {noformat}
> StreamSupport.stream( iteratorSearchResponse.iterator().spliterator(), false )
> .sorted( ArtifactInfo.VERSION_COMPARATOR ).forEach( ai -> {
> artifactInfos.add( ai );
> page.add( convert( ai, null ) );
> } );
> {noformat}
> But, checktyle:
> {noformat}
> [ERROR]
> src/main/java/org/apache/maven/index/search/backend/indexer/internal/IndexerCoreSearchBackendImpl.java:[127,83]
> (blocks) LeftCurly: '{' at column 83 should be on a new line.{noformat}
> In short, for me it looks like our checkstyle is too rigid, unprepared for
> Java 8 lambdas? (as IMHO the code snippet above with curly on next line would
> look awkward).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNGSITE-480) IDE Codestyle vs Maven Checkstyle: a bossfight
[
https://issues.apache.org/jira/browse/MNGSITE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MNGSITE-480:
Attachment: Screenshot 2022-02-16 at 10.40.07.png
> IDE Codestyle vs Maven Checkstyle: a bossfight
> --
>
> Key: MNGSITE-480
> URL: https://issues.apache.org/jira/browse/MNGSITE-480
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Tamás Cservenák
>Priority: Major
> Attachments: Screenshot 2022-02-16 at 10.40.07.png
>
>
> Codestyle updated in MNGSITE-465 for Idea has discrepancies wrt checkstyle
> plugin rules.
>
> Typical example:
> IDEA IDE reformat result:
> {noformat}
> StreamSupport.stream( iteratorSearchResponse.iterator().spliterator(), false )
> .sorted( ArtifactInfo.VERSION_COMPARATOR ).forEach( ai -> {
> artifactInfos.add( ai );
> page.add( convert( ai, null ) );
> } );
> {noformat}
> But, checktyle:
> {noformat}
> [ERROR]
> src/main/java/org/apache/maven/index/search/backend/indexer/internal/IndexerCoreSearchBackendImpl.java:[127,83]
> (blocks) LeftCurly: '{' at column 83 should be on a new line.{noformat}
> In short, for me it looks like our checkstyle is too rigid, unprepared for
> Java 8 lambdas? (as IMHO the code snippet above with curly on next line would
> look awkward).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNGSITE-480) IDE Codestyle vs Maven Checkstyle: a bossfight
[
https://issues.apache.org/jira/browse/MNGSITE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493132#comment-17493132
]
Slawomir Jaranowski commented on MNGSITE-480:
-
There are {{tokens}} properties for {{LeftCurly}} and can be used
https://checkstyle.sourceforge.io/config_blocks.html#LeftCurly
For Idea is probably new options: {{Braces ... In lambda ...}}
in idea xml formater, can be added:
{code}
{code}
> IDE Codestyle vs Maven Checkstyle: a bossfight
> --
>
> Key: MNGSITE-480
> URL: https://issues.apache.org/jira/browse/MNGSITE-480
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Tamás Cservenák
>Priority: Major
> Attachments: Screenshot 2022-02-16 at 10.40.07.png
>
>
> Codestyle updated in MNGSITE-465 for Idea has discrepancies wrt checkstyle
> plugin rules.
>
> Typical example:
> IDEA IDE reformat result:
> {noformat}
> StreamSupport.stream( iteratorSearchResponse.iterator().spliterator(), false )
> .sorted( ArtifactInfo.VERSION_COMPARATOR ).forEach( ai -> {
> artifactInfos.add( ai );
> page.add( convert( ai, null ) );
> } );
> {noformat}
> But, checktyle:
> {noformat}
> [ERROR]
> src/main/java/org/apache/maven/index/search/backend/indexer/internal/IndexerCoreSearchBackendImpl.java:[127,83]
> (blocks) LeftCurly: '{' at column 83 should be on a new line.{noformat}
> In short, for me it looks like our checkstyle is too rigid, unprepared for
> Java 8 lambdas? (as IMHO the code snippet above with curly on next line would
> look awkward).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MNGSITE-480) IDE Codestyle vs Maven Checkstyle: a bossfight
[
https://issues.apache.org/jira/browse/MNGSITE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493132#comment-17493132
]
Slawomir Jaranowski edited comment on MNGSITE-480 at 2/16/22, 10:03 AM:
There are {{tokens}} properties for {{LeftCurly}} and can be used
[https://checkstyle.sourceforge.io/config_blocks.html#LeftCurly]
For Idea is probably new options: {{Braces ... In lambda ...}}
in idea xml formater, can be added:
{code:java}
{code}
was (Author: slawekjaranowski):
There are {{tokens}} properties for {{LeftCurly}} and can be used
https://checkstyle.sourceforge.io/config_blocks.html#LeftCurly
For Idea is probably new options: {{Braces ... In lambda ...}}
in idea xml formater, can be added:
{code}
{code}
> IDE Codestyle vs Maven Checkstyle: a bossfight
> --
>
> Key: MNGSITE-480
> URL: https://issues.apache.org/jira/browse/MNGSITE-480
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Tamás Cservenák
>Priority: Major
> Attachments: Screenshot 2022-02-16 at 10.40.07.png
>
>
> Codestyle updated in MNGSITE-465 for Idea has discrepancies wrt checkstyle
> plugin rules.
>
> Typical example:
> IDEA IDE reformat result:
> {noformat}
> StreamSupport.stream( iteratorSearchResponse.iterator().spliterator(), false )
> .sorted( ArtifactInfo.VERSION_COMPARATOR ).forEach( ai -> {
> artifactInfos.add( ai );
> page.add( convert( ai, null ) );
> } );
> {noformat}
> But, checktyle:
> {noformat}
> [ERROR]
> src/main/java/org/apache/maven/index/search/backend/indexer/internal/IndexerCoreSearchBackendImpl.java:[127,83]
> (blocks) LeftCurly: '{' at column 83 should be on a new line.{noformat}
> In short, for me it looks like our checkstyle is too rigid, unprepared for
> Java 8 lambdas? (as IMHO the code snippet above with curly on next line would
> look awkward).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-mvnd] garywhittington commented on issue #601: java.nio.BufferUnderflowException occurs when I run any mvnd command
garywhittington commented on issue #601: URL: https://github.com/apache/maven-mvnd/issues/601#issuecomment-1041325931 The same problem started for me today. I resolved it by removing the $HOME/.m2/mvnd directory, and then all seems to be working again (with mvnd then recreating this directory). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #601: java.nio.BufferUnderflowException occurs when I run any mvnd command
gnodet commented on issue #601: URL: https://github.com/apache/maven-mvnd/issues/601#issuecomment-1041332611 Yes, the exception clearly indicates the registry has been corrupted. We should put some safeguard mechanism to handle this use case more gracefully. As indicated by @garywhittington, deleting the `$HOME/.m2/mvnd` should be a good workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-480) Running om macOS Monterey produces an error
[
https://issues.apache.org/jira/browse/MCOMPILER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493155#comment-17493155
]
Michael Osipov commented on MCOMPILER-480:
--
Could this be a race condition with Maven and IntelliJ? If it works with plain
Maven then it is likely an IntelliJ issue?
> Running om macOS Monterey produces an error
> ---
>
> Key: MCOMPILER-480
> URL: https://issues.apache.org/jira/browse/MCOMPILER-480
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
> Environment: macOS 12.1 Monterey
>Reporter: Michal Sladek
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> We get the following error building our project with MCP 3.9.0 on 12.1
> Morterey macOS (verified on 2 other machines).
> Running on maven 3.8.3 and 3.8.4.
> The problem disappears when downgrading to 3.8.1. We haven't observed this
> issue on ubuntu os neither windows machines.
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project dokgen: Error while storing the mojo status:
> Input length = 1 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project fp-dokgen: Error while storing the mojo
> status
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error while
> storing the mojo status
> at
> org.apache.maven.shared.incremental.IncrementalBuildHelper.afterRebuildExecution
> (IncrementalBuildHelper.java:338)
> at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute
> (AbstractCompilerMojo.java:1191)
> at org.apache.maven.plugin.compiler.TestCompilerMojo.execute
> (TestCompilerMojo.java:175)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.ja
[GitHub] [maven-surefire] NilsRenaud opened a new pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
NilsRenaud opened a new pull request #471: URL: https://github.com/apache/maven-surefire/pull/471 This PR fixes : https://issues.apache.org/jira/browse/SUREFIRE-1909 We decided to go with the drop in replacement of `--add-exports` with `--add-opens`, as suggested in the issue. To add to the background of this issue, a previous PR has been created, introducing the option to use either `add-exports` or `add-opens`, the PR is still accessible here : https://github.com/apache/maven-surefire/pull/461 To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] NilsRenaud commented on a change in pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
NilsRenaud commented on a change in pull request #471:
URL: https://github.com/apache/maven-surefire/pull/471#discussion_r807824894
##
File path:
surefire-its/src/test/resources/junit5-modulepath/src/test/java/com/app/AppTest.java
##
@@ -0,0 +1,37 @@
+package com.app;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.junit.jupiter.api.Test;
+
+public class AppTest
+{
+@Test
+void testNoop()
Review comment:
This is the point of the test : to run package private test methods as
suggested in [JUnit 5 user
guide](https://junit.org/junit5/docs/current/user-guide/#writing-tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] NilsRenaud commented on pull request #461: [SUREFIRE-1909] Replace --add-exports with --add-opens
NilsRenaud commented on pull request #461: URL: https://github.com/apache/maven-surefire/pull/461#issuecomment-1041385264 PR created : https://github.com/apache/maven-surefire/pull/471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request #55: Bump plexus-utils from 3.3.0 to 3.4.1
dependabot[bot] opened a new pull request #55: URL: https://github.com/apache/maven-pmd-plugin/pull/55 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.3.0 to 3.4.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexus-utils's releases. 3.4.1 🐛 Bug Fixes Fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163: Regression: encoding error when parsing a ISO-8859-1 xml (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/164";>#164) https://github.com/belingueres";>@belingueres 📦 Dependency updates Bump actions/setup-java from 2.2.0 to 2.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/168";>#168) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.32 to 1.33 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/166";>#166) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.32 to 1.33 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/165";>#165) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.1.0 to 2.2.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/167";>#167) https://github.com/dependabot";>@dependabot Bump junit from 4.13.1 to 4.13.2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/162";>#162) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 1 to 2.1.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/157";>#157) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.29 to 1.32 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/159";>#159) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.29 to 1.32 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/160";>#160) https://github.com/dependabot";>@dependabot Bump actions/cache from 2.1.5 to 2.1.6 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/161";>#161) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2 to 2.3.4 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/154";>#154) https://github.com/dependabot";>@dependabot 3.4.0 Enforcing JDK 11 on release (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/148";>#148) https://github.com/mkarg";>@mkarg Using JDK 16 GA instead of JDK 16 EA (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/147";>#147) https://github.com/mkarg";>@mkarg Fixed infinite loop in MXParser and reactivate tests in MXParserTest (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/119";>#119,https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/118";>#118) https://github.com/belingueres";>@belingueres Added support for PPC64LE (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/97";>#97) https://github.com/ezeeyahoo";>@ezeeyahoo Avoid build issues with symlink (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/90";>#90) https://github.com/olamy";>@olamy New feature FileUtils.linkFile(source, destination) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/82";>#82) https://github.com/mkarg";>@mkarg Fix Javadoc build with Java 11 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/88";>#88) https://github.com/olamy";>@olamy Support combine.keys (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/76";>#76) https://github.com/rfscholte";>@rfscholte Support combine.self="remove" (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/75";>#75,https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/74";>#74) https://github.com/belingueres";>@belingueres Input location (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/62";>#62,https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/61";>#61) https://github.com/hboutemy";>@hboutemy UT improvement : Check that symlinks resources are preserved during git clone (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/56";>#56) https://github.com/rfscholte";>@rfscholte Junit4 annotations (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/55";>#55) https://github.com/rfscholte";>@rfscholte Test failure in CommandlineTest#testExecuteBinaryOnPath with Maven 3.5.4 or later (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/50";>#50) https://github.com/belingueres";>@belingueres PrettyPrintXMLWriter fails with a java.util.
[GitHub] [maven] kwin commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)
kwin commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1041396931 @michael-o Any update here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request #56: Bump plexus-resources from 1.1.0 to 1.2.0
dependabot[bot] opened a new pull request #56: URL: https://github.com/apache/maven-pmd-plugin/pull/56 Bumps [plexus-resources](https://github.com/codehaus-plexus/plexus-resources) from 1.1.0 to 1.2.0. Commits https://github.com/codehaus-plexus/plexus-resources/commit/bf06d80eab2acad746c04fe9809dc3318cfdf066";>bf06d80 [maven-release-plugin] prepare release plexus-resources-1.2.0 https://github.com/codehaus-plexus/plexus-resources/commit/3d0340b06346ec9629b5febaf8fe72cdb9392ead";>3d0340b update maven.yaml https://github.com/codehaus-plexus/plexus-resources/commit/e3972e5475b27adc69bef5a5000d7772b84ee9dd";>e3972e5 (doc) remove redundant exclutions https://github.com/codehaus-plexus/plexus-resources/commit/04c1af804389dab5179b62e568594d07193ed6af";>04c1af8 Bump plexus-components from 6.5 to 6.6 https://github.com/codehaus-plexus/plexus-resources/commit/1613d2bdfb538d4419e8094c24cd26e6be2b333b";>1613d2b Bump sisu-maven-plugin from 0.3.4 to 0.3.5 https://github.com/codehaus-plexus/plexus-resources/commit/4b12d6dd6fcee6cd0f6ce0fa9637b2d3039b4a34";>4b12d6d Bump junit-jupiter from 5.8.0 to 5.8.1 https://github.com/codehaus-plexus/plexus-resources/commit/d9cb95a0be05c5cff127c7f1a7a14b253c38e301";>d9cb95a Bump plexus-testing from 1.0.0 to 1.1.0 https://github.com/codehaus-plexus/plexus-resources/commit/2a790c35893212b539313450bd7415ab78e73857";>2a790c3 Bump junit-jupiter from 5.8.0-RC1 to 5.8.0 https://github.com/codehaus-plexus/plexus-resources/commit/d6bc456ef40f8cedf0fb7c6d80e3791b00c7a297";>d6bc456 Bump mockito.version from 3.12.1 to 3.12.4 https://github.com/codehaus-plexus/plexus-resources/commit/733dc3f83dd7b188ff6ac8f8b9840a822450aa25";>733dc3f Bump mockito.version from 3.11.2 to 3.12.1 Additional commits viewable in https://github.com/codehaus-plexus/plexus-resources/compare/plexus-resources-1.1.0...plexus-resources-1.2.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDEP-793) ignoredUsedUndeclaredDependencies not affected to non-test scoped
Slawomir Jaranowski created MDEP-793:
Summary: ignoredUsedUndeclaredDependencies not affected to
non-test scoped
Key: MDEP-793
URL: https://issues.apache.org/jira/browse/MDEP-793
Project: Maven Dependency Plugin
Issue Type: Bug
Components: analyze
Reporter: Slawomir Jaranowski
When we add some of artifacts to *{{ignoredUsedUndeclaredDependencies}}* and
use classes from this artifacts only in test code we have reported it as
*{{non-test scoped}}*.
In order pass *{{non-test scoped}}* check we must add artifacts to project
but we want to avoid adding according to *{{ignoredUsedUndeclaredDependencies}}*
Logs from executing:
{code}
[WARNING] Non-test scoped test only dependencies found:
[WARNING]joda-time:joda-time:jar:2.10:compile
[INFO] Ignored used undeclared dependencies:
[INFO]joda-time:joda-time:jar:2.10:compile
...
{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1041411056 No, not yet. Ping me in a week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] nielsbasjes opened a new pull request #135: [SCM-977] Support for retrieving tags from the changelog
nielsbasjes opened a new pull request #135: URL: https://github.com/apache/maven-scm/pull/135 My aim is to support having something like https://www.conventionalcommits.org/ in the maven-release-plugin. This simply means that the next version of a release is calculated from the last tag in the version history and the patterns in the commit messages since that tag. To support this idea the maven-scm should be extended to also retrieve the tags with the changelog command on SCM implementations that support this idea. This patch adds - Generic support for a ChangeSet to also include the available tags. - Implementation for gitexe and jgit to actually set those if found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml
[
https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493207#comment-17493207
]
James Nord commented on MRELEASE-899:
-
the problem still and has nothing to do with any tooling.
MREALESE changes the line ends period. it should not rely on git to change
them back or not or anything else.
XML parsing by computer not caring is also not important here.
This causes a huge issue regardless of if the XML read by a machine is the same
or not as when looking at git annotate it becomes a lot lot harder to see when
a change (like a dependency) was introduced, as the last change will be at
least the last release possibly newer.
> release:prepare should not change the line separator but detect effective
> line separator from pom.xml
> -
>
> Key: MRELEASE-899
> URL: https://issues.apache.org/jira/browse/MRELEASE-899
> Project: Maven Release Plugin
> Issue Type: Improvement
>Reporter: Ralph van Etten
>Priority: Major
>
> Currently the plugin use the system property {{line.separator}} when it
> rewrites the pom.xml.
> This causes trouble, because every line in changed, when a project is
> released sometimes under Windows and sometimes under Linux (because of its
> different line separators).
> (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the
> systems line separator but the line separator that is already used in the
> pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm
> someone else.
> Therefore it would be an great feature when there would be an property that
> define the expected behaviour, maybe in the same way it is done by the
> maven-assembly-plugin's property fileSet.lineEnding
> (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
Tibor17 commented on a change in pull request #471:
URL: https://github.com/apache/maven-surefire/pull/471#discussion_r807914433
##
File path:
surefire-its/src/test/resources/junit5-modulepath/src/main/java/com/app/Main.java
##
@@ -0,0 +1,34 @@
+package com.app;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.joda.time.DateTime;
+
+public class Main
+{
+public static void main( String... args )
+{
+System.out.println( "module path => " + System.getProperty(
"jdk.module.path" ) );
Review comment:
So, these lines are used as a debug info?
You can maybe verify the classpath in one line, and modulapath in the second
line via combining Java Hamcrest matchers.
Example `validator.assertThatLogLine( containsString( "Running
jiras.surefire1082.Jira1082Test" ), is( 1 ) );`
Example with matching one line: `allOf( containsString( "jar1" ),
containsString( "jar2" ), ... )`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
Tibor17 commented on a change in pull request #471:
URL: https://github.com/apache/maven-surefire/pull/471#discussion_r807914433
##
File path:
surefire-its/src/test/resources/junit5-modulepath/src/main/java/com/app/Main.java
##
@@ -0,0 +1,34 @@
+package com.app;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.joda.time.DateTime;
+
+public class Main
+{
+public static void main( String... args )
+{
+System.out.println( "module path => " + System.getProperty(
"jdk.module.path" ) );
Review comment:
@NilsRenaud
So, these lines are used as a debug info?
You can maybe utilize it and verify the classpath in one line, and
modulapath in the second line via combining Java Hamcrest matchers.
Example `validator.assertThatLogLine( containsString( "Running
jiras.surefire1082.Jira1082Test" ), is( 1 ) );`
Example with matching one line: `allOf( containsString( "jar1" ),
containsString( "jar2" ), ... )`
The second argument `is(1)` only means the number of lines matching this
criteria and it is 1 in this IT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
Tibor17 commented on a change in pull request #471:
URL: https://github.com/apache/maven-surefire/pull/471#discussion_r807914433
##
File path:
surefire-its/src/test/resources/junit5-modulepath/src/main/java/com/app/Main.java
##
@@ -0,0 +1,34 @@
+package com.app;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.joda.time.DateTime;
+
+public class Main
+{
+public static void main( String... args )
+{
+System.out.println( "module path => " + System.getProperty(
"jdk.module.path" ) );
Review comment:
@NilsRenaud
So, these lines are used as a debug info?
You can maybe utilize it and verify the classpath in one line, and
modulapath in the second line via combining Java Hamcrest matchers.
Example:
`validator.assertThatLogLine( containsString( "Running
jiras.surefire1082.Jira1082Test" ), is( 1 ) );`
Example with matching one line: `allOf( containsString( "jar1" ),
containsString( "jar2" ), ... )`
The second argument `is(1)` only means the number of lines matching this
criteria and it is 1 in this IT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
Tibor17 commented on pull request #471: URL: https://github.com/apache/maven-surefire/pull/471#issuecomment-1041493137 Let's keep this surivar open during several release versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 removed a comment on pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
Tibor17 removed a comment on pull request #471: URL: https://github.com/apache/maven-surefire/pull/471#issuecomment-1041493137 Let's keep this surivar open during several release versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #461: [SUREFIRE-1909] Replace --add-exports with --add-opens
Tibor17 commented on pull request #461: URL: https://github.com/apache/maven-surefire/pull/461#issuecomment-1041506070 Let's keep this survivor open during next few versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2015) Implement testRunId and RunMode in the SimpleReportEntry
Tibor Digana created SUREFIRE-2015: -- Summary: Implement testRunId and RunMode in the SimpleReportEntry Key: SUREFIRE-2015 URL: https://issues.apache.org/jira/browse/SUREFIRE-2015 Project: Maven Surefire Issue Type: Improvement Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 3.0.0-M6 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] NilsRenaud commented on a change in pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
NilsRenaud commented on a change in pull request #471:
URL: https://github.com/apache/maven-surefire/pull/471#discussion_r808025692
##
File path:
surefire-its/src/test/resources/junit5-modulepath/src/main/java/com/app/Main.java
##
@@ -0,0 +1,34 @@
+package com.app;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.joda.time.DateTime;
+
+public class Main
+{
+public static void main( String... args )
+{
+System.out.println( "module path => " + System.getProperty(
"jdk.module.path" ) );
Review comment:
I shamelessly copied an existing test with this content.
They are not useful because the `java` arg file content is displayed anyway.
And I'm not really sure what I should verify with these paths.
So I rather like to delete these debug lines. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] mthmulders opened a new pull request #678: [MNG-7244] Ignore pom.-prefix in expressions
mthmulders opened a new pull request #678: URL: https://github.com/apache/maven/pull/678 This pull request removes the long deprecated support of properties with the `pom.` prefix in pom.xml. Contrary to the JIRA ticket suggestion, the build will not fail, it will continue similarly to when a non-existing property is used. When we will remove support for "unprefixed" property expressions (MNG-7404) the code for interpolating expressions becomes a lot easier, as we can then completely remove the `ProblemDetectingValueSource` class that was introduced only to log warnings about the deprecation. --- Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. **[MNG-7244](https://issues.apache.org/jira/browse/MNG-7244)** - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] mthmulders opened a new pull request #139: [MNG-7244] Ignore pom. prefix in expressions
mthmulders opened a new pull request #139:
URL: https://github.com/apache/maven-integration-testing/pull/139
Mainly updates to existing ITs due to removal of `${pom.}`-prefixed
properties (see https://github.com/apache/maven/pull/678). Also adds a test
that verifies the old warning is no longer emitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
Tibor17 commented on a change in pull request #471:
URL: https://github.com/apache/maven-surefire/pull/471#discussion_r808042194
##
File path:
surefire-its/src/test/resources/junit5-modulepath/src/main/java/com/app/Main.java
##
@@ -0,0 +1,34 @@
+package com.app;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.joda.time.DateTime;
+
+public class Main
+{
+public static void main( String... args )
+{
+System.out.println( "module path => " + System.getProperty(
"jdk.module.path" ) );
Review comment:
After you have deleted it, we can force the build to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MDEP-791) Non-test scoped and transitive dependencies in compile scope
[
https://issues.apache.org/jira/browse/MDEP-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MDEP-791:
-
Attachment: MDEP-791.zip
> Non-test scoped and transitive dependencies in compile scope
>
>
> Key: MDEP-791
> URL: https://issues.apache.org/jira/browse/MDEP-791
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Priority: Critical
> Attachments: MDEP-791.zip
>
>
> When we use some dependency in test classes which is not used in production
> code but is required as transitive dependency for other used in production
> code - such dependency should not be included in {*}{{Non-test scoped}}{*}.
> Example:
> * test code use {{ObjectCodec}} from {{jackson-core}}
> * production code use only {{ObjectMapper}} from {{jackson-databind}}
> * production code don't use any classes from {{jackson-core}}
> {{jackson-core}} is needed by {{jackson-databind}} and must by in compile
> scope so should not be reported as {{Non-test scoped}}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-release] nielsbasjes opened a new pull request #104: [MRELEASE-1078] Conventional commits
nielsbasjes opened a new pull request #104: URL: https://github.com/apache/maven-release/pull/104 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MRELEASE-1078) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. Current status is that the `update-versions` IT tests fail and I do not understand why yet. ``` [ERROR] The following builds failed: [ERROR] * projects/update-versions/MRELEASE-611/pom.xml [ERROR] * projects/update-versions/MRELEASE-555/pom.xml [ERROR] * projects/update-versions/MRELEASE-976/pom.xml [ERROR] * projects/update-versions/MRELEASE-783/pom.xml ``` If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This my implementation on creating the option to follow the ideas of [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) to automatically determine the next version. This patch assumes the required changes for maven-scm are available: - Jira issue [SCM-977](https://issues.apache.org/jira/browse/SCM-977) - Pull request https://github.com/apache/maven-scm/pull/135 Summary of the changes: - Extended the VersionPolicyRequest to include the SCM information. - New version policy that retrieves the ChangeLog from SCM (which includes the commit messages and the tags). - An optional configuration string `projectVersionPolicyConfig` that contains the optional config for the version policy. NOTE: I have tried to make it a clean addition of the configuration for the maven-release-plugin but I have not been successful in adding the extra config schema to the plugin. So for now it is a `String` which (because it is XML) must be included as CDATA. - I've added an integration test that shows it works and what the configuration looks like. I'm really looking forward to your feedback on how I can improve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-791) Non-test scoped and transitive dependencies in compile scope
[
https://issues.apache.org/jira/browse/MDEP-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493270#comment-17493270
]
Slawomir Jaranowski commented on MDEP-791:
--
Test project in attachment [^MDEP-791.zip]
Step to reproduce
h2. {{jackson-core}} no on direct dependency
{code}
mvn clean verify
INFO] --- maven-dependency-plugin:3.3.0-SNAPSHOT:analyze-only
(check-dependencies) @ tstp ---
[WARNING] Used undeclared dependencies found:
[WARNING]com.fasterxml.jackson.core:jackson-core:jar:2.13.1:compile
[WARNING] Non-test scoped test only dependencies found:
[WARNING]com.fasterxml.jackson.core:jackson-core:jar:2.13.1:compile
[INFO]
[INFO] BUILD FAILURE
[INFO]
{code}
h2. {{jackson-core}} with compile scope
{code}
mvn clean verify -P core-compile
INFO] --- maven-dependency-plugin:3.3.0-SNAPSHOT:analyze-only
(check-dependencies) @ tstp ---
[WARNING] Non-test scoped test only dependencies found:
[WARNING]com.fasterxml.jackson.core:jackson-core:jar:2.13.1:compile
[INFO]
[INFO] BUILD FAILURE
[INFO]
{code}
h2. {{jackson-core}} with test scope
{code}
mvn clean verify -P core-test
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR] .../tj/src/main/java/tstp/MDEP753.java:[9,48] cannot access
com.fasterxml.jackson.core.Versioned
class file for com.fasterxml.jackson.core.Versioned not found
[INFO] 1 error
{code}
*How to make build pass without exclusion artifacts from analysis?*
Maybe I do something in wrong way ...
> Non-test scoped and transitive dependencies in compile scope
>
>
> Key: MDEP-791
> URL: https://issues.apache.org/jira/browse/MDEP-791
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Priority: Critical
> Attachments: MDEP-791.zip
>
>
> When we use some dependency in test classes which is not used in production
> code but is required as transitive dependency for other used in production
> code - such dependency should not be included in {*}{{Non-test scoped}}{*}.
> Example:
> * test code use {{ObjectCodec}} from {{jackson-core}}
> * production code use only {{ObjectMapper}} from {{jackson-databind}}
> * production code don't use any classes from {{jackson-core}}
> {{jackson-core}} is needed by {{jackson-databind}} and must by in compile
> scope so should not be reported as {{Non-test scoped}}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MDEP-791) Non-test scoped and transitive dependencies in compile scope
[
https://issues.apache.org/jira/browse/MDEP-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493273#comment-17493273
]
Slawomir Jaranowski commented on MDEP-791:
--
[~elharo] please try my steps ...
> Non-test scoped and transitive dependencies in compile scope
>
>
> Key: MDEP-791
> URL: https://issues.apache.org/jira/browse/MDEP-791
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Priority: Critical
> Attachments: MDEP-791.zip
>
>
> When we use some dependency in test classes which is not used in production
> code but is required as transitive dependency for other used in production
> code - such dependency should not be included in {*}{{Non-test scoped}}{*}.
> Example:
> * test code use {{ObjectCodec}} from {{jackson-core}}
> * production code use only {{ObjectMapper}} from {{jackson-databind}}
> * production code don't use any classes from {{jackson-core}}
> {{jackson-core}} is needed by {{jackson-databind}} and must by in compile
> scope so should not be reported as {{Non-test scoped}}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (MDEP-791) Non-test scoped and transitive dependencies in compile scope
[
https://issues.apache.org/jira/browse/MDEP-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reopened MDEP-791:
--
> Non-test scoped and transitive dependencies in compile scope
>
>
> Key: MDEP-791
> URL: https://issues.apache.org/jira/browse/MDEP-791
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Priority: Critical
> Attachments: MDEP-791.zip
>
>
> When we use some dependency in test classes which is not used in production
> code but is required as transitive dependency for other used in production
> code - such dependency should not be included in {*}{{Non-test scoped}}{*}.
> Example:
> * test code use {{ObjectCodec}} from {{jackson-core}}
> * production code use only {{ObjectMapper}} from {{jackson-databind}}
> * production code don't use any classes from {{jackson-core}}
> {{jackson-core}} is needed by {{jackson-databind}} and must by in compile
> scope so should not be reported as {{Non-test scoped}}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
Tibor17 commented on a change in pull request #471:
URL: https://github.com/apache/maven-surefire/pull/471#discussion_r808089493
##
File path: surefire-its/src/test/resources/junit5-modulepath/pom.xml
##
@@ -0,0 +1,46 @@
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+
+4.0.0
+
+foo
+app
+1.0.0-SNAPSHOT
+
+app
+
+
+UTF-8
+
${java.specification.version}
+
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.8.1
Review comment:
It's better to use the [latest
version](https://maven.apache.org/plugins/maven-compiler-plugin/) because we
fixed some bugs and it would be nice to come over those in Surefire too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7414) Maven version 3.8.3 + 3.8.4 have jsoup vulnerability
[ https://issues.apache.org/jira/browse/MNG-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493282#comment-17493282 ] Ksenia Hershkovici commented on MNG-7414: - https://nvd.nist.gov/vuln/detail/CVE-2021-37714 > Maven version 3.8.3 + 3.8.4 have jsoup vulnerability > > > Key: MNG-7414 > URL: https://issues.apache.org/jira/browse/MNG-7414 > Project: Maven > Issue Type: Bug >Reporter: Ksenia Hershkovici >Priority: Major > > Hi Team, > We are facing jsoup component vulnerability with maven versions 3.8.3 and > 3.8.4 which is the latest released version of maven. The CVE details are: > CVE-2021-37714 > Jsoup version which is getting installed while installing maven 3.8.3 and > 3.8.4 is v1.12.1. > We noticed that both versions have wagon 3.4.3 that is probably installing > Jsoup v1.12.1. > Can you please provide the details of next maven version release with this > fix in it? > Thanks. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7414) Maven version 3.8.3 + 3.8.4 have jsoup vulnerability
[ https://issues.apache.org/jira/browse/MNG-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493287#comment-17493287 ] Michael Osipov commented on MNG-7414: - You absolutely know that you are affected by this issue? > Maven version 3.8.3 + 3.8.4 have jsoup vulnerability > > > Key: MNG-7414 > URL: https://issues.apache.org/jira/browse/MNG-7414 > Project: Maven > Issue Type: Bug >Reporter: Ksenia Hershkovici >Priority: Major > > Hi Team, > We are facing jsoup component vulnerability with maven versions 3.8.3 and > 3.8.4 which is the latest released version of maven. The CVE details are: > CVE-2021-37714 > Jsoup version which is getting installed while installing maven 3.8.3 and > 3.8.4 is v1.12.1. > We noticed that both versions have wagon 3.4.3 that is probably installing > Jsoup v1.12.1. > Can you please provide the details of next maven version release with this > fix in it? > Thanks. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7414) Maven version 3.8.3 + 3.8.4 have jsoup vulnerability
[ https://issues.apache.org/jira/browse/MNG-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493295#comment-17493295 ] Ksenia Hershkovici commented on MNG-7414: - Yes, we are. > Maven version 3.8.3 + 3.8.4 have jsoup vulnerability > > > Key: MNG-7414 > URL: https://issues.apache.org/jira/browse/MNG-7414 > Project: Maven > Issue Type: Bug >Reporter: Ksenia Hershkovici >Priority: Major > > Hi Team, > We are facing jsoup component vulnerability with maven versions 3.8.3 and > 3.8.4 which is the latest released version of maven. The CVE details are: > CVE-2021-37714 > Jsoup version which is getting installed while installing maven 3.8.3 and > 3.8.4 is v1.12.1. > We noticed that both versions have wagon 3.4.3 that is probably installing > Jsoup v1.12.1. > Can you please provide the details of next maven version release with this > fix in it? > Thanks. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MDEP-791) Non-test scoped and transitive dependencies in compile scope
[
https://issues.apache.org/jira/browse/MDEP-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MDEP-791:
-
Affects Version/s: 3.2.0
3.3.0
> Non-test scoped and transitive dependencies in compile scope
>
>
> Key: MDEP-791
> URL: https://issues.apache.org/jira/browse/MDEP-791
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0, 3.3.0
>Reporter: Slawomir Jaranowski
>Priority: Critical
> Attachments: MDEP-791.zip
>
>
> When we use some dependency in test classes which is not used in production
> code but is required as transitive dependency for other used in production
> code - such dependency should not be included in {*}{{Non-test scoped}}{*}.
> Example:
> * test code use {{ObjectCodec}} from {{jackson-core}}
> * production code use only {{ObjectMapper}} from {{jackson-databind}}
> * production code don't use any classes from {{jackson-core}}
> {{jackson-core}} is needed by {{jackson-databind}} and must by in compile
> scope so should not be reported as {{Non-test scoped}}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-7414) Maven version 3.8.3 + 3.8.4 have jsoup vulnerability
[ https://issues.apache.org/jira/browse/MNG-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493299#comment-17493299 ] Michael Osipov commented on MNG-7414: - Interesting, how? I want to learn and avoid such situations. > Maven version 3.8.3 + 3.8.4 have jsoup vulnerability > > > Key: MNG-7414 > URL: https://issues.apache.org/jira/browse/MNG-7414 > Project: Maven > Issue Type: Bug >Reporter: Ksenia Hershkovici >Priority: Major > > Hi Team, > We are facing jsoup component vulnerability with maven versions 3.8.3 and > 3.8.4 which is the latest released version of maven. The CVE details are: > CVE-2021-37714 > Jsoup version which is getting installed while installing maven 3.8.3 and > 3.8.4 is v1.12.1. > We noticed that both versions have wagon 3.4.3 that is probably installing > Jsoup v1.12.1. > Can you please provide the details of next maven version release with this > fix in it? > Thanks. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
Tibor17 commented on pull request #471: URL: https://github.com/apache/maven-surefire/pull/471#issuecomment-1041830759 @NilsRenaud The build is running... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7329) Upgrade maven-enforcer-plugin to 3.0.0
[
https://issues.apache.org/jira/browse/MNG-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493339#comment-17493339
]
Maarten Mulders commented on MNG-7329:
--
{quote}[~gnodet], necessary for 3.9.0?
{quote}
Only if
[c3962c1a|https://github.com/apache/maven/commit/c3962c1a6c0b40abbfb12740253437f6431b234b]
is also in 3.9.0.
> Upgrade maven-enforcer-plugin to 3.0.0
> --
>
> Key: MNG-7329
> URL: https://issues.apache.org/jira/browse/MNG-7329
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> Upgrade to latest maven-enforcer-plugin to allow building master with maven 4.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MENFORCER-407) Enforcer 3.0.0 breaks with Maven 3.8.4
[ https://issues.apache.org/jira/browse/MENFORCER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493422#comment-17493422 ] Matt Nelson commented on MENFORCER-407: --- [~michael-o] Does the example help? What brought me to this issue was attempting to upgrade to JDK 17 while using extra-enforcer-rules. extra-enforcer-rules-1.4 was updated[1] to support JDK 17, which also bumped the required[2] enforcer versions, which then introduced changes to the behavior of the dependency convergence rules. [1] https://github.com/mojohaus/extra-enforcer-rules/pull/129 [2] https://github.com/mojohaus/extra-enforcer-rules/issues/131 > Enforcer 3.0.0 breaks with Maven 3.8.4 > -- > > Key: MENFORCER-407 > URL: https://issues.apache.org/jira/browse/MENFORCER-407 > Project: Maven Enforcer Plugin > Issue Type: Bug > Components: Plugin >Affects Versions: 3.0.0 >Reporter: David Pilato >Priority: Major > Fix For: waiting-for-feedback > > Attachments: enforcer-3.0.0.log, enforcer.3.0.0-M3.log > > > Here is the situation. I'm trying to [upgrade enforcer from 3.0.0-M3 to > 3.0.0|https://github.com/dadoonet/fscrawler/pull/1214]. > > Everything worked well on my laptop with Maven 3.5.3. So I looked at the > version used by Github actions and saw that it's using Maven 3.8.4. > As soon as I upgraded my local version of Maven to 3.8.4, I started to hit > the same exact issue. It seems to try to pull > net.sf.ehcache:sizeof-agent:1.0.1. > If I revert Enforcer to 3.0.0-M3 with Maven 3.8.4, I can run without any > issue mvn enforcer:enforce. > So I suspect that the combination of both upgrades is triggering something. > I noted also that 3.0.0 now tries to enforce as well dependencies marked as > provided. Might be the reason of this. > I attached the full logs when running with 3.0.0 and 3.0.0-M3. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-release] michael-o commented on a change in pull request #62: [MRELEASE-899] Feature/lineseparator
michael-o commented on a change in pull request #62: URL: https://github.com/apache/maven-release/pull/62#discussion_r808368072 ## File path: maven-release-manager/src/main/mdo/release-descriptor.mdo ## @@ -604,6 +604,16 @@ + + lineSeparator + 3.0.0+ + String + +Specifies the line separator to use in the pom.xml. +(https://issues.apache.org/jira/browse/MRELEASE-899) Review comment: Redundant ## File path: maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java ## @@ -567,6 +567,15 @@ */ String getAutoResolveSnapshots(); +/** + * Get the line separator to use in the pom.xml. + * + * (https://issues.apache.org/jira/browse/MRELEASE-899). Review comment: This is reduandant since it is in the commit message and blame. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MSHARED-916) Require Maven 3.1.1 (drop dependency to Maven 3.0)
[ https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MSHARED-916: --- Assignee: Slawomir Jaranowski > Require Maven 3.1.1 (drop dependency to Maven 3.0) > -- > > Key: MSHARED-916 > URL: https://issues.apache.org/jira/browse/MSHARED-916 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Reporter: Sylwester Lachiewicz >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MENFORCER-407) Enforcer 3.0.0 breaks with Maven 3.8.4
[ https://issues.apache.org/jira/browse/MENFORCER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493442#comment-17493442 ] Michael Osipov commented on MENFORCER-407: -- Won't be able to look at this before end of month. Feel free to ping me then again. > Enforcer 3.0.0 breaks with Maven 3.8.4 > -- > > Key: MENFORCER-407 > URL: https://issues.apache.org/jira/browse/MENFORCER-407 > Project: Maven Enforcer Plugin > Issue Type: Bug > Components: Plugin >Affects Versions: 3.0.0 >Reporter: David Pilato >Priority: Major > Fix For: waiting-for-feedback > > Attachments: enforcer-3.0.0.log, enforcer.3.0.0-M3.log > > > Here is the situation. I'm trying to [upgrade enforcer from 3.0.0-M3 to > 3.0.0|https://github.com/dadoonet/fscrawler/pull/1214]. > > Everything worked well on my laptop with Maven 3.5.3. So I looked at the > version used by Github actions and saw that it's using Maven 3.8.4. > As soon as I upgraded my local version of Maven to 3.8.4, I started to hit > the same exact issue. It seems to try to pull > net.sf.ehcache:sizeof-agent:1.0.1. > If I revert Enforcer to 3.0.0-M3 with Maven 3.8.4, I can run without any > issue mvn enforcer:enforce. > So I suspect that the combination of both upgrades is triggering something. > I noted also that 3.0.0 now tries to enforce as well dependencies marked as > provided. Might be the reason of this. > I attached the full logs when running with 3.0.0 and 3.0.0-M3. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml
[
https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MRELEASE-899:
---
Assignee: Michael Osipov
> release:prepare should not change the line separator but detect effective
> line separator from pom.xml
> -
>
> Key: MRELEASE-899
> URL: https://issues.apache.org/jira/browse/MRELEASE-899
> Project: Maven Release Plugin
> Issue Type: Improvement
>Reporter: Ralph van Etten
>Assignee: Michael Osipov
>Priority: Major
>
> Currently the plugin use the system property {{line.separator}} when it
> rewrites the pom.xml.
> This causes trouble, because every line in changed, when a project is
> released sometimes under Windows and sometimes under Linux (because of its
> different line separators).
> (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the
> systems line separator but the line separator that is already used in the
> pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm
> someone else.
> Therefore it would be an great feature when there would be an property that
> define the expected behaviour, maybe in the same way it is done by the
> maven-assembly-plugin's property fileSet.lineEnding
> (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml
[
https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-899:
Fix Version/s: 3.0.0-M6
> release:prepare should not change the line separator but detect effective
> line separator from pom.xml
> -
>
> Key: MRELEASE-899
> URL: https://issues.apache.org/jira/browse/MRELEASE-899
> Project: Maven Release Plugin
> Issue Type: Improvement
>Reporter: Ralph van Etten
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> Currently the plugin use the system property {{line.separator}} when it
> rewrites the pom.xml.
> This causes trouble, because every line in changed, when a project is
> released sometimes under Windows and sometimes under Linux (because of its
> different line separators).
> (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the
> systems line separator but the line separator that is already used in the
> pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm
> someone else.
> Therefore it would be an great feature when there would be an property that
> define the expected behaviour, maybe in the same way it is done by the
> maven-assembly-plugin's property fileSet.lineEnding
> (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MSHARED-1035) Get rid of maven-plugin-testing-tools for IT test
Slawomir Jaranowski created MSHARED-1035:
Summary: Get rid of maven-plugin-testing-tools for IT test
Key: MSHARED-1035
URL: https://issues.apache.org/jira/browse/MSHARED-1035
Project: Maven Shared Components
Issue Type: Improvement
Components: maven-dependency-analyzer
Reporter: Slawomir Jaranowski
Using unsupported {{maven-plugin-testing-tools}} for IT tests blocks project
development.
IT tests will be executed by {{maven-invoker-plugin}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (MSHARED-1035) Get rid of maven-plugin-testing-tools for IT test
[
https://issues.apache.org/jira/browse/MSHARED-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MSHARED-1035:
Assignee: Slawomir Jaranowski
> Get rid of maven-plugin-testing-tools for IT test
> -
>
> Key: MSHARED-1035
> URL: https://issues.apache.org/jira/browse/MSHARED-1035
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-dependency-analyzer
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Using unsupported {{maven-plugin-testing-tools}} for IT tests blocks project
> development.
> IT tests will be executed by {{maven-invoker-plugin}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MSITE-883) Upgrade plugins in ITs
[ https://issues.apache.org/jira/browse/MSITE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-883: - Issue Type: Dependency upgrade (was: Task) > Upgrade plugins in ITs > -- > > Key: MSITE-883 > URL: https://issues.apache.org/jira/browse/MSITE-883 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.10.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.11.0 > > > * Maven Javadoc Plugin to 3.3.2 > * Maven JXR Plugin to 3.1.1 > * Maven Project Info Reports Plugin to 3.2.1 > * Maven Changelog Plugin to 2.3 > * Taglist Maven Plugin to 3.0.0 > * Maven Changes Plugin to 2.12.1 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (MENFORCER-413) Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo
Matt Raible created MENFORCER-413:
-
Summary: Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors
about Spring Roo
Key: MENFORCER-413
URL: https://issues.apache.org/jira/browse/MENFORCER-413
Project: Maven Enforcer Plugin
Issue Type: Bug
Components: Plugin
Affects Versions: 3.0.0
Reporter: Matt Raible
In a fresh JHipster project, I get a strange error from the Maven enforcer
plugin about Spring Roo dependencies.
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-dependencyConvergence)
@ lapp-li ---
[WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
missing, no dependency information available
Downloading from spring-libs-snapshot:
https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom
Downloading from spring-libs-release:
https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom
If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
According to the issue below, reverting to -M3 solves the problem.
https://github.com/jhipster/generator-jhipster/issues/16318
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MENFORCER-413) Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo
[
https://issues.apache.org/jira/browse/MENFORCER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Raible updated MENFORCER-413:
--
Description:
In a fresh JHipster project, I get a strange error from the Maven enforcer
plugin about Spring Roo dependencies.
{{[INFO] --- maven-enforcer-plugin:3.0.0:enforce
(enforce-dependencyConvergence) @ lapp-li ---
[WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
missing, no dependency information available
Downloading from spring-libs-snapshot:
https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom
Downloading from spring-libs-release:
https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom}}
If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
According to the issue below, reverting to -M3 solves the problem.
https://github.com/jhipster/generator-jhipster/issues/16318
was:
In a fresh JHipster project, I get a strange error from the Maven enforcer
plugin about Spring Roo dependencies.
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-dependencyConvergence)
@ lapp-li ---
[WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
missing, no dependency information available
Downloading from spring-libs-snapshot:
https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom
Downloading from spring-libs-release:
https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom
If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
According to the issue below, reverting to -M3 solves the problem.
https://github.com/jhipster/generator-jhipster/issues/16318
> Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo
> ---
>
> Key: MENFORCER-413
> URL: https://issues.apache.org/jira/browse/MENFORCER-413
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.0.0
>Reporter: Matt Raible
>Priority: Major
>
> In a fresh JHipster project, I get a strange error from the Maven enforcer
> plugin about Spring Roo dependencies.
> {{[INFO] --- maven-enforcer-plugin:3.0.0:enforce
> (enforce-dependencyConvergence) @ lapp-li ---
> [WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
> missing, no dependency information available
> Downloading from spring-libs-snapshot:
> https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom
> Downloading from spring-libs-release:
> https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom}}
>
> If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
>
> According to the issue below, reverting to -M3 solves the problem.
>
> https://github.com/jhipster/generator-jhipster/issues/16318
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MENFORCER-413) Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo
[
https://issues.apache.org/jira/browse/MENFORCER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Raible updated MENFORCER-413:
--
Description:
In a fresh JHipster project, I get a strange error from the Maven enforcer
plugin about Spring Roo dependencies.
```
[INFO] — maven-enforcer-plugin:3.0.0:enforce (enforce-dependencyConvergence) @
lapp-li —
[WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
missing, no dependency information available
Downloading from spring-libs-snapshot:
[https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
Downloading from spring-libs-release:
[https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
```
If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
According to the issue below, reverting to -M3 solves the problem.
[https://github.com/jhipster/generator-jhipster/issues/16318]
was:
In a fresh JHipster project, I get a strange error from the Maven enforcer
plugin about Spring Roo dependencies.
{{[INFO] --- maven-enforcer-plugin:3.0.0:enforce
(enforce-dependencyConvergence) @ lapp-li ---
[WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
missing, no dependency information available
Downloading from spring-libs-snapshot:
https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom
Downloading from spring-libs-release:
https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom}}
If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
According to the issue below, reverting to -M3 solves the problem.
https://github.com/jhipster/generator-jhipster/issues/16318
> Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo
> ---
>
> Key: MENFORCER-413
> URL: https://issues.apache.org/jira/browse/MENFORCER-413
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.0.0
>Reporter: Matt Raible
>Priority: Major
>
> In a fresh JHipster project, I get a strange error from the Maven enforcer
> plugin about Spring Roo dependencies.
>
> ```
> [INFO] — maven-enforcer-plugin:3.0.0:enforce (enforce-dependencyConvergence)
> @ lapp-li —
> [WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
> missing, no dependency information available
> Downloading from spring-libs-snapshot:
> [https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
> Downloading from spring-libs-release:
> [https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
> ```
> If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
>
> According to the issue below, reverting to -M3 solves the problem.
>
> [https://github.com/jhipster/generator-jhipster/issues/16318]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MENFORCER-413) Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo
[
https://issues.apache.org/jira/browse/MENFORCER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Raible updated MENFORCER-413:
--
Description:
In a fresh JHipster project, I get a strange error from the Maven enforcer
plugin about Spring Roo dependencies.
[INFO] — maven-enforcer-plugin:3.0.0:enforce (enforce-dependencyConvergence) @
lapp-li —
[WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
missing, no dependency information available
Downloading from spring-libs-snapshot:
[https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
Downloading from spring-libs-release:
[https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
According to the issue below, reverting to -M3 solves the problem.
[https://github.com/jhipster/generator-jhipster/issues/16318]
was:
In a fresh JHipster project, I get a strange error from the Maven enforcer
plugin about Spring Roo dependencies.
```
[INFO] — maven-enforcer-plugin:3.0.0:enforce (enforce-dependencyConvergence) @
lapp-li —
[WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
missing, no dependency information available
Downloading from spring-libs-snapshot:
[https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
Downloading from spring-libs-release:
[https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
```
If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
According to the issue below, reverting to -M3 solves the problem.
[https://github.com/jhipster/generator-jhipster/issues/16318]
> Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo
> ---
>
> Key: MENFORCER-413
> URL: https://issues.apache.org/jira/browse/MENFORCER-413
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.0.0
>Reporter: Matt Raible
>Priority: Major
>
> In a fresh JHipster project, I get a strange error from the Maven enforcer
> plugin about Spring Roo dependencies.
>
> [INFO] — maven-enforcer-plugin:3.0.0:enforce (enforce-dependencyConvergence)
> @ lapp-li —
> [WARNING] The POM for org.apache.logging.log4j:log4j-api-java9:zip:2.14.1 is
> missing, no dependency information available
> Downloading from spring-libs-snapshot:
> [https://repo.spring.io/libs-snapshot/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
> Downloading from spring-libs-release:
> [https://repo.spring.io/libs-release/org/springframework/roo/org.springframework.roo.annotations/1.2.3.RELEASE/org.springframework.roo.annotations-1.2.3.RELEASE.pom]
>
> If I run {{{}mvn dependency:tree | grep roo{}}}, there are no results.
>
> According to the issue below, reverting to -M3 solves the problem.
>
> [https://github.com/jhipster/generator-jhipster/issues/16318]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] michael-o commented on a change in pull request #677: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.
michael-o commented on a change in pull request #677:
URL: https://github.com/apache/maven/pull/677#discussion_r808397647
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -138,8 +138,10 @@ public DefaultGraphBuilder( BuildResumptionDataRepository
buildResumptionDataRep
{
ProjectDependencyGraph projectDependencyGraph = new
DefaultProjectDependencyGraph( projects );
List activeProjects =
projectDependencyGraph.getSortedProjects();
+List allSortedProjects =
projectDependencyGraph.getSortedProjects();
Review comment:
It is the same list as above. It it correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #138: [MNG-7390] Testing whether modules can be selected outside the cwd.
michael-o commented on a change in pull request #138:
URL:
https://github.com/apache/maven-integration-testing/pull/138#discussion_r808399621
##
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7390SelectModuleOutsideCwdTest.java
##
@@ -0,0 +1,129 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This test suite tests whether other modules in the same multi module
project can be selected when invoking Maven from a submodule.
+ * Related JIRA issue: https://issues.apache.org/jira/browse/MNG-7390";>MNG-7390.
+ *
+ * @author Martin Kanters
+ */
+public class MavenITmng7390SelectModuleOutsideCwdTest extends
AbstractMavenIntegrationTestCase {
+
+private File moduleADir;
+
+public MavenITmng7390SelectModuleOutsideCwdTest()
+{
+super( "[4.0.0-alpha-1,)" );
+}
+
+@Override
+protected void setUp() throws Exception {
Review comment:
Curly on new line
##
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7390SelectModuleOutsideCwdTest.java
##
@@ -0,0 +1,129 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This test suite tests whether other modules in the same multi module
project can be selected when invoking Maven from a submodule.
+ * Related JIRA issue: https://issues.apache.org/jira/browse/MNG-7390";>MNG-7390.
+ *
+ * @author Martin Kanters
+ */
+public class MavenITmng7390SelectModuleOutsideCwdTest extends
AbstractMavenIntegrationTestCase {
+
+private File moduleADir;
+
+public MavenITmng7390SelectModuleOutsideCwdTest()
+{
+super( "[4.0.0-alpha-1,)" );
+}
+
+@Override
+protected void setUp() throws Exception {
+moduleADir = ResourceExtractor.simpleExtractResources( getClass(),
"/mng-7390-pl-outside-cwd/module-a");
Review comment:
padding space at end
##
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7390SelectModuleOutsideCwdTest.java
##
@@ -0,0 +1,129 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This test suite tests whether other modules in the same multi module
project can be selected when invoking Maven from a submodule.
+ * Related JIRA issue: https://issues.apache.org/jira/browse/MNG-7390";>MNG-7390.
+ *
+ * @author Martin Kanters
+ */
+public
[GitHub] [maven] michael-o commented on a change in pull request #678: [MNG-7244] Ignore pom.-prefix in expressions
michael-o commented on a change in pull request #678:
URL: https://github.com/apache/maven/pull/678#discussion_r808406484
##
File path:
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/AbstractStringBasedModelInterpolator.java
##
@@ -189,7 +187,7 @@ public Object getValue( String expression )
if ( projectDir != null )
{
processors.add( new PathTranslatingPostProcessor(
PROJECT_PREFIXES, TRANSLATED_PATH_EXPRESSIONS,
- projectDir,
pathTranslator ) );
+projectDir, pathTranslator ) );
Review comment:
This should not have happened.
##
File path:
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/ProblemDetectingValueSource.java
##
@@ -60,12 +68,12 @@ public Object getValue( String expression )
if ( value != null && expression.startsWith( bannedPrefix ) )
{
-String msg = "The expression ${" + expression + "} is deprecated.";
+String msg = "The expression ${" + expression + "} is " + status +
".";
Review comment:
Why do we need this now? I mean `pom.` is gone and such an occurency
should be treated as opaque and will not be touched at ll. It will remain as a
placeholder in the effective model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #672: [MNG-7406] Better display of project building errors
michael-o commented on a change in pull request #672:
URL: https://github.com/apache/maven/pull/672#discussion_r808411854
##
File path:
maven-core/src/test/java/org/apache/maven/project/ProjectBuildingResultWithLocationMatcher.java
##
@@ -0,0 +1,87 @@
+package org.apache.maven.project;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.model.building.ModelProblem;
+import org.hamcrest.BaseMatcher;
+import org.hamcrest.Description;
+import org.hamcrest.Matcher;
+
+import static java.util.stream.Collectors.joining;
+
+/**
+ * Hamcrest matcher to help create fluent assertions about {@link
ProjectBuildingResult} instances.
+ */
+class ProjectBuildingResultWithLocationMatcher extends
BaseMatcher
+{
+private final int columnNumber;
+private final int lineNumber;
+
+ProjectBuildingResultWithLocationMatcher( int columnNumber, int lineNumber
) {
+this.columnNumber = columnNumber;
+this.lineNumber = lineNumber;
+}
+
+@Override
+public boolean matches( Object o )
+{
+if ( !( o instanceof ProjectBuildingResult ) ) {
Review comment:
curly on new line
##
File path:
maven-core/src/test/java/org/apache/maven/project/ProjectBuildingResultWithProblemMessageMatcher.java
##
@@ -0,0 +1,81 @@
+package org.apache.maven.project;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.model.building.ModelProblem;
+import org.hamcrest.BaseMatcher;
+import org.hamcrest.Description;
+import org.hamcrest.Matcher;
+
+import static java.util.stream.Collectors.joining;
+
+/**
+ * Hamcrest matcher to help create fluent assertions about {@link
ProjectBuildingResult} instances.
+ */
+class ProjectBuildingResultWithProblemMessageMatcher extends
BaseMatcher
+{
+private final String problemMessage;
+
+ProjectBuildingResultWithProblemMessageMatcher( String problemMessage ) {
Review comment:
curly on new line
##
File path:
maven-core/src/test/java/org/apache/maven/project/ProjectBuildingResultWithProblemMessageMatcher.java
##
@@ -0,0 +1,81 @@
+package org.apache.maven.project;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.model.building.ModelProblem;
+import org.hamcrest.BaseMatcher;
+import org.hamcrest.Description;
+import org.hamcrest.Matcher;
+
+import static java.util.stream.Collectors.joining;
+
+/**
+ * Hamcrest matcher to help create fluent assertions about {@link
ProjectBuildingResult} instances.
+ */
+class ProjectBuildingResultWithProblemMessageMatcher extends
BaseMatcher
+{
+private final String problemMessage;
+
+ProjectBuil
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #139: [MNG-7244] Ignore pom.-prefix in expressions
michael-o commented on a change in pull request #139:
URL:
https://github.com/apache/maven-integration-testing/pull/139#discussion_r808413870
##
File path:
core-it-suite/src/test/resources/mng-4403/repo/org/apache/maven/its/mng4403/b/0.1/b-0.1.pom
##
@@ -80,8 +80,7 @@ under the License.
org.apache.maven.its.mng4403
a
-
- ${pom.version}
+ ${project.version}
Review comment:
Attention, if this file has a chksum it must also be updated
##
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7244IgnorePomPrefixInExpressions.java
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.List;
+
+public class MavenITmng7244IgnorePomPrefixInExpressions extends
AbstractMavenIntegrationTestCase
+{
+private static final String PROJECT_PATH =
"/mng-7244-ignore-pom-prefix-in-expressions";
+
+public MavenITmng7244IgnorePomPrefixInExpressions()
+{
+super( "[4.0.0-alpha-1,)" );
+}
+
+public void testIgnorePomPrefixInExpressions() throws IOException,
VerificationException
+{
+final File projectDir = ResourceExtractor.simpleExtractResources(
getClass(), PROJECT_PATH );
+final Verifier verifier = newVerifier( projectDir.getAbsolutePath() );
+
+verifier.executeGoal( "validate" );
+
+verifyLogDoesNotContainUnexpectedWarning( verifier );
+}
+
+private void verifyLogDoesNotContainUnexpectedWarning( Verifier verifier )
throws IOException
+{
+List loadedLines = verifier.loadLines( "log.txt", "UTF-8" );
+for ( String line : loadedLines )
+{
+if ( line.startsWith( "[WARNING]" ) && line.contains( "The
expression ${pom.version} is deprecated." ) )
+{
+fail("Log contained unexpected deprecation warning");
Review comment:
padding spaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-dependency-analyzer] slawekjaranowski opened a new pull request #50: [MSHARED-1035] Get rid of maven-plugin-testing-tools for IT test
slawekjaranowski opened a new pull request #50: URL: https://github.com/apache/maven-dependency-analyzer/pull/50 IT tests will be executed by maven-invoker-plugin --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. Also be sure having selected the correct component. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #672: [MNG-7406] Better display of project building errors
mthmulders commented on pull request #672: URL: https://github.com/apache/maven/pull/672#issuecomment-1042270427 Apologies for the curly on new line noise... Should've seen that myself! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #672: [MNG-7406] Better display of project building errors
michael-o commented on pull request #672: URL: https://github.com/apache/maven/pull/672#issuecomment-1042293944 > Apologies for the curly on new line noise... Should've seen that myself! No issue... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-analyzer] michael-o commented on pull request #50: [MSHARED-1035] Get rid of maven-plugin-testing-tools for IT test
michael-o commented on pull request #50: URL: https://github.com/apache/maven-dependency-analyzer/pull/50#issuecomment-1042295730 That's massive..., will run... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on pull request #50: [MSHARED-1035] Get rid of maven-plugin-testing-tools for IT test
slawekjaranowski commented on pull request #50: URL: https://github.com/apache/maven-dependency-analyzer/pull/50#issuecomment-1042305778 Idea and way how to was done: - add simple maven plugin `src/it/setup-mock-plugin/src/main/java/it/test/MockAnalyzeMojo.java` - build and instal plugin in setup job of m-invoker-p - plugin generate `target/analysis.txt` with result of executing - use plugin in each IT test - assert content of `target/analysis.txt` in `verify.groovy` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-analyzer] michael-o commented on a change in pull request #50: [MSHARED-1035] Get rid of maven-plugin-testing-tools for IT test
michael-o commented on a change in pull request #50:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/50#discussion_r808452039
##
File path: pom.xml
##
@@ -192,24 +149,34 @@
- maven-repo-local
-
-
- maven.repo.local
-
-
+ run-its
-
-maven-surefire-plugin
+
+org.apache.maven.plugins
+maven-invoker-plugin
+
+
+
+ install
+ integration-test
+ verify
+
+
+
-
-
-
- maven.repo.local
- ${maven.repo.local}
-
-
+ ${project.build.directory}/it
+ target/local-repo
+ src/it/settings.xml
+ verify
+
+verify
+
+
+
${java.specification.version}
+
${java.specification.version}
Review comment:
Does this really make sense? I mean it depends now on the Java version
run?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on pull request #50: [MSHARED-1035] Get rid of maven-plugin-testing-tools for IT test
slawekjaranowski commented on pull request #50: URL: https://github.com/apache/maven-dependency-analyzer/pull/50#issuecomment-1042310851 I can't use new version of `maven-plugin-testing-harness` ... because for tests MavenProject instance is needed ... MavenProject must contains resolve all dependency which is difficult to mock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] asfgit closed pull request #672: [MNG-7406] Better display of project building errors
asfgit closed pull request #672: URL: https://github.com/apache/maven/pull/672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #672: [MNG-7406] Better display of project building errors
mthmulders commented on pull request #672: URL: https://github.com/apache/maven/pull/672#issuecomment-1042315625 > A very nice improvement! Thanks! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on a change in pull request #50: [MSHARED-1035] Get rid of maven-plugin-testing-tools for IT test
slawekjaranowski commented on a change in pull request #50:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/50#discussion_r808458152
##
File path: pom.xml
##
@@ -192,24 +149,34 @@
- maven-repo-local
-
-
- maven.repo.local
-
-
+ run-its
-
-maven-surefire-plugin
+
+org.apache.maven.plugins
+maven-invoker-plugin
+
+
+
+ install
+ integration-test
+ verify
+
+
+
-
-
-
- maven.repo.local
- ${maven.repo.local}
-
-
+ ${project.build.directory}/it
+ target/local-repo
+ src/it/settings.xml
+ verify
+
+verify
+
+
+
${java.specification.version}
+
${java.specification.version}
Review comment:
Many thing depends on bytecode version in analysis so compiling test
code for many version can help detect future problem with ... next java version
if we need test feature which depends of jdk version we can add such
requrement in invoker.properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-dependency-analyzer] michael-o commented on a change in pull request #50: [MSHARED-1035] Get rid of maven-plugin-testing-tools for IT test
michael-o commented on a change in pull request #50:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/50#discussion_r808458657
##
File path: pom.xml
##
@@ -192,24 +149,34 @@
- maven-repo-local
-
-
- maven.repo.local
-
-
+ run-its
-
-maven-surefire-plugin
+
+org.apache.maven.plugins
+maven-invoker-plugin
+
+
+
+ install
+ integration-test
+ verify
+
+
+
-
-
-
- maven.repo.local
- ${maven.repo.local}
-
-
+ ${project.build.directory}/it
+ target/local-repo
+ src/it/settings.xml
+ verify
+
+verify
+
+
+
${java.specification.version}
+
${java.specification.version}
Review comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (MNG-7406) Strange formatting of warning/errors from project building
[
https://issues.apache.org/jira/browse/MNG-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Mulders resolved MNG-7406.
--
Resolution: Fixed
Fixed in
{{[apache/maven@0be5e40|https://github.com/apache/maven/commit/0be5e406d78062b56b32644fefce2642f5eab650]}}.
> Strange formatting of warning/errors from project building
> --
>
> Key: MNG-7406
> URL: https://issues.apache.org/jira/browse/MNG-7406
> Project: Maven
> Issue Type: Improvement
> Components: Errors
>Affects Versions: 4.0.x-candidate
>Reporter: Maarten Mulders
>Assignee: Maarten Mulders
>Priority: Minor
> Fix For: 4.0.0-alpha-1
>
> Attachments: after.png, before.png, image.png
>
>
> If Maven finds an error while building the model, it throws a
> {{{}ProjectBuildingException{}}}. When that makes it to the CLI, it is
> printed in a bit strange way:
> !image.png!
> Note how the message reads:
> {code:java}
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project foo:bar:1.0-SNAPSHOT (/private/tmp/ner/bar/pom.xml) has
> 1 error
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] {code}
> # It contains a severity marker *twice*
> # It repeats the error/warning message
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-7406) Strange formatting of warning/errors from project building
[
https://issues.apache.org/jira/browse/MNG-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7406:
Fix Version/s: 4.0.0
> Strange formatting of warning/errors from project building
> --
>
> Key: MNG-7406
> URL: https://issues.apache.org/jira/browse/MNG-7406
> Project: Maven
> Issue Type: Improvement
> Components: Errors
>Affects Versions: 4.0.x-candidate
>Reporter: Maarten Mulders
>Assignee: Maarten Mulders
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-1
>
> Attachments: after.png, before.png, image.png
>
>
> If Maven finds an error while building the model, it throws a
> {{{}ProjectBuildingException{}}}. When that makes it to the CLI, it is
> printed in a bit strange way:
> !image.png!
> Note how the message reads:
> {code:java}
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project foo:bar:1.0-SNAPSHOT (/private/tmp/ner/bar/pom.xml) has
> 1 error
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] {code}
> # It contains a severity marker *twice*
> # It repeats the error/warning message
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on pull request #50: [MSHARED-1035] Get rid of maven-plugin-testing-tools for IT test
slawekjaranowski commented on pull request #50: URL: https://github.com/apache/maven-dependency-analyzer/pull/50#issuecomment-1042321665 All test pass ... on GH and Jenkins even with 18-ea on localhost 😸 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request #199: Bump maven-reporting-api from 3.0 to 3.1.0
dependabot[bot] opened a new pull request #199: URL: https://github.com/apache/maven-dependency-plugin/pull/199 Bumps [maven-reporting-api](https://github.com/apache/maven-reporting-api) from 3.0 to 3.1.0. Commits https://github.com/apache/maven-reporting-api/commit/deea46250994e4859eee77bfe192a562c400671c";>deea462 [maven-release-plugin] prepare release maven-reporting-api-3.1.0 https://github.com/apache/maven-reporting-api/commit/35fc61e158aef235c2b7760e53c6d05c0529ab54";>35fc61e [MSHARED-1024] Replace deprecated code https://github.com/apache/maven-reporting-api/commit/c45966d088dbd1b367ec48396f7bed2632cbc08c";>c45966d [MSHARED-844] Upgrade Doxia API to 1.11.1 https://github.com/apache/maven-reporting-api/commit/c3e3dd556e996804d684c81f23fa3e74ab620bc7";>c3e3dd5 Add GitHub Actions setup https://github.com/apache/maven-reporting-api/commit/0451d6d357e3476736807e4a26334e92743b110b";>0451d6d update CI url https://github.com/apache/maven-reporting-api/commit/1d15d4908b9f9627e964cb256b9219476cd8f7a4";>1d15d49 update ASF CI url https://github.com/apache/maven-reporting-api/commit/45295c78862cc3566443baf6ebe578e8cc8bfd78";>45295c7 update ASF CI url https://github.com/apache/maven-reporting-api/commit/3733fdc953d821851afe36e9259f6d7edca0bd79";>3733fdc Updated link to Jira https://github.com/apache/maven-reporting-api/commit/9669cc16f15c26805ae6ab7499eccf159c3b9be7";>9669cc1 README improvement https://github.com/apache/maven-reporting-api/commit/365cf78dcfccfb8fe8d662ca0e1f3010b2972007";>365cf78 added README and GitHub configuration Additional commits viewable in https://github.com/apache/maven-reporting-api/compare/maven-reporting-api-3.0...maven-reporting-api-3.1.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-916) Require Maven 3.2.5+ (drop dependency to Maven 2.0.5)
[ https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-916: Summary: Require Maven 3.2.5+ (drop dependency to Maven 2.0.5) (was: Require Maven 3.1.1 (drop dependency to Maven 3.0)) > Require Maven 3.2.5+ (drop dependency to Maven 2.0.5) > - > > Key: MSHARED-916 > URL: https://issues.apache.org/jira/browse/MSHARED-916 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Reporter: Sylwester Lachiewicz >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MSHARED-1003) Require Maven 3.2.5+
[ https://issues.apache.org/jira/browse/MSHARED-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-1003: - Component/s: (was: maven-dependency-analyzer) > Require Maven 3.2.5+ > > > Key: MSHARED-1003 > URL: https://issues.apache.org/jira/browse/MSHARED-1003 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-filtering, maven-shared-incremental >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: maven-shared-incremental-2.0.0, maven-filtering-3.3.0 > > > Grouping all shared components -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-mvnd] cheneychoi commented on issue #560: Let JVM set max heap size instead of a default value of 2GB (`mvnd.maxHeapSize`)
cheneychoi commented on issue #560: URL: https://github.com/apache/maven-mvnd/issues/560#issuecomment-1042504843 @hashhar hey bro,i met the same situation ,is this issue solved? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request #70: Bump maven-site-plugin from 3.10.0 to 3.11.0
dependabot[bot] opened a new pull request #70: URL: https://github.com/apache/maven-apache-parent/pull/70 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.10.0 to 3.11.0. Commits https://github.com/apache/maven-site-plugin/commit/a0e97b4d749756d905821396fa057a48ad70dc93";>a0e97b4 [maven-release-plugin] prepare release maven-site-plugin-3.11.0 https://github.com/apache/maven-site-plugin/commit/26979ff74277d60df4d2e6b8a9e8c63ff52a";>26979ff [MSITE-882] Upgrade Maven Reporting Exec to 1.6.0 https://github.com/apache/maven-site-plugin/commit/09d2f6f442ef43fdc29282735b99b0986002db0d";>09d2f6f [MSITE-881] Upgrade Maven Reporting API to 3.1.0 https://github.com/apache/maven-site-plugin/commit/eca1960b846c228b72327e3b773ac88ff85de8a9";>eca1960 [MSITE-883] Upgrade plugins in ITs https://github.com/apache/maven-site-plugin/commit/db0ed41b00f17f3756338e2516512254caf8cacd";>db0ed41 [MSITE-880] AbstractSiteDeployWebDavTest should not log https://github.com/apache/maven-site-plugin/commit/94e03e7ca946d2a90c6e6eed43fb96091dcf5a31";>94e03e7 Bump maven-archiver from 3.5.1 to 3.5.2 https://github.com/apache/maven-site-plugin/commit/1399379d082258505645a3a58efe13920c9974da";>1399379 send PR notifications to mailto:issues@maven.a.o";>issues@maven.a.o https://github.com/apache/maven-site-plugin/commit/3ebcef647ee9c6b018038cd1ef1f194dac299d2e";>3ebcef6 [MSITE-870] wagon-provider-api is also provided by Maven Core https://github.com/apache/maven-site-plugin/commit/75c8d35df293a4e0defa5c7ac1092c7984e0f93d";>75c8d35 update GitHub notifications scheme https://github.com/apache/maven-site-plugin/commit/26d92aba31c896d8940a09edc01ba8e4623fe7ba";>26d92ab [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.10.0...maven-site-plugin-3.11.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request #50: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2
dependabot[bot] opened a new pull request #50: URL: https://github.com/apache/maven-help-plugin/pull/50 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.1 to 3.3.2. Commits https://github.com/apache/maven-javadoc-plugin/commit/50a41f78278c1d5957cb03e89223fcbc640f1b68";>50a41f7 [maven-release-plugin] prepare release maven-javadoc-plugin-3.3.2 https://github.com/apache/maven-javadoc-plugin/commit/5af4519ce17308f35d4cfb553d0af8168cac35f4";>5af4519 [MJAVADOC-705] Upgrade Maven Reporting API to 3.1.0 https://github.com/apache/maven-javadoc-plugin/commit/ee4132f9d0f6f412784e108305524cf3b3a3009a";>ee4132f [MJAVADOC-704] Javadoc plugin does not respect jdkToolchain https://github.com/apache/maven-javadoc-plugin/commit/651b98e6951ee2e3d8fefa1bcb3629f1dae763be";>651b98e Bump doxia-site-renderer from 1.10 to 1.11.1 https://github.com/apache/maven-javadoc-plugin/commit/db20fddd4eb443711948645613c03a4ccc516dab";>db20fdd Bump plexus-archiver from 4.2.5 to 4.2.6 https://github.com/apache/maven-javadoc-plugin/commit/b51c5d801c1e329b1e59e7b66142c8fd9c0ba6af";>b51c5d8 [MJAVADOC-694] Avoid empty warn message from getResolvePathResult https://github.com/apache/maven-javadoc-plugin/commit/6b1515ed43826417cf4cbad88be1107e92cba3f5";>6b1515e Bump httpcore from 4.4.14 to 4.4.15 https://github.com/apache/maven-javadoc-plugin/commit/a4aa7dcdc22eda19a08cc3c3e231631d422f1725";>a4aa7dc (doc) fix javadoc issues https://github.com/apache/maven-javadoc-plugin/commit/3309cc2ea03237576f3d702cffe1d628c3ea0d12";>3309cc2 Bump maven-project-info-reports-plugin to 3.1.2 https://github.com/apache/maven-javadoc-plugin/commit/51a2c3f803a0124c2591e46925210da705042f19";>51a2c3f Bump maven-javadoc-plugin to 3.3.1 Additional commits viewable in https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.3.1...maven-javadoc-plugin-3.3.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] dependabot[bot] opened a new pull request #47: Bump modello-maven-plugin from 1.11 to 2.0.0
dependabot[bot] opened a new pull request #47: URL: https://github.com/apache/maven-parent/pull/47 Bumps [modello-maven-plugin](https://github.com/codehaus-plexus/modello) from 1.11 to 2.0.0. Release notes Sourced from https://github.com/codehaus-plexus/modello/releases";>modello-maven-plugin's releases. Modello 2.0.0 this releases requires Java 8 (previous releases required Java 7) 🚀 New features and improvements Add Modello 2.0.0 model XSD (c909e6c054a4b4ca7e9f1f9efb3b4db7853c9ad5) https://github.com/hboutemy";>@hboutemy Manage xdoc anchor name conflicts (2 classes with same anchor) (2590c0fa9c069e7d243a6dff0c323f21816f23b4) https://github.com/hboutemy";>@hboutemy Drop unnecessary check for identical branches (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/171";>#171) https://github.com/pzygielo";>@pzygielo Require Maven 3.1.1 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/124";>#124) https://github.com/slachiewicz";>@slachiewicz Use a caching writer to avoid overwriting identical files (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/116";>#116) https://github.com/gnodet";>@gnodet Migrate from codehaus:wstx to com.fasterxml.woodstox:woodstox-core 6.2.4 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/101";>#101) https://github.com/slachiewicz";>@slachiewicz Make location handling more memory efficient (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/31";>#31) https://github.com/oehme";>@oehme Xpp3 extended writer (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/30";>#30) https://github.com/hboutemy";>@hboutemy Refactor some old java APIs usage (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/26";>#26) https://github.com/rfscholte";>@rfscholte Add a new field fileComment (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/3";>#3) https://github.com/ptahchiev";>@ptahchiev 🐛 Bug Fixes Fix javaSource default value (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/117";>#117) https://github.com/gnodet";>@gnodet Fix modello-plugin-snakeyaml (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/56";>#56) https://github.com/pzygielo";>@pzygielo 📦 Dependency updates Bump maven-javadoc-plugin from 3.3.1 to 3.3.2 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/184";>#184) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.17.6 to 5.18.0 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/179";>#179) https://github.com/dependabot";>@dependabot Bump taglist-maven-plugin from 2.4 to 3.0.0 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/177";>#177) https://github.com/dependabot";>@dependabot Bump checkstyle from 9.2.1 to 9.3 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/178";>#178) https://github.com/dependabot";>@dependabot Bump xmlunit-core from 2.8.4 to 2.9.0 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/172";>#172) https://github.com/dependabot";>@dependabot Bump junit from 4.12 to 4.13.1 in /modello-maven-plugin/src/it/maven-model (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump xercesImpl from 2.12.1 to 2.12.2 in /modello-plugins/modello-plugin-xsd (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/175";>#175) https://github.com/dependabot";>@dependabot Bump xercesImpl from 2.12.1 to 2.12.2 in /modello-plugins/modello-plugin-jsonschema (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/174";>#174) https://github.com/dependabot";>@dependabot Bump mavenPluginTools from 3.6.2 to 3.6.4 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/169";>#169) https://github.com/dependabot";>@dependabot Bump maven-compiler-plugin from 3.8.1 to 3.9.0 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/166";>#166) https://github.com/dependabot";>@dependabot Bump maven-jar-plugin from 3.2.0 to 3.2.2 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/164";>#164) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.17.6 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/170";>#170) https://github.com/dependabot";>@dependabot Bump woodstox-core from 6.2.7 to 6.2.8 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/167";>#167) https://github.com/dependabot";>@dependabot Bump maven-release-plugin from 3.0.0-M4 to 3.0.0-M5 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/161";>#161) https://github.com/d
[GitHub] [maven-install-plugin] dependabot[bot] opened a new pull request #22: Bump slf4jVersion from 1.7.32 to 1.7.36
dependabot[bot] opened a new pull request #22: URL: https://github.com/apache/maven-install-plugin/pull/22 Bumps `slf4jVersion` from 1.7.32 to 1.7.36. Updates `slf4j-api` from 1.7.32 to 1.7.36 Commits https://github.com/qos-ch/slf4j/commit/e9ee55cca93c2bf26f14482a9bdf961c750d2a56";>e9ee55c update timestamp before release https://github.com/qos-ch/slf4j/commit/3b6a92f66815605ce851671dd1d6e0758c29ed4c";>3b6a92f reproducible builds https://github.com/qos-ch/slf4j/commit/882502706063b460997a3c6018223018f36cecd3";>8825027 prepare release 1.7.36, fix SLF4J-541 https://github.com/qos-ch/slf4j/commit/561738747da5813b8a9d2e2ebd10f0128a78a960";>5617387 add relase.sh https://github.com/qos-ch/slf4j/commit/02860b67ef7ff39fa9c7d98fd00da2ee913faeda";>02860b6 prepare relase 1.7.35 https://github.com/qos-ch/slf4j/commit/a622f5186a57188dab7f71651245eb91c6ac263b";>a622f51 fix maven deploy issues https://github.com/qos-ch/slf4j/commit/26068bd4bf93fcbd00185ad986dc43b79aceeb4a";>26068bd slf4j no longer references log4j https://github.com/qos-ch/slf4j/commit/0a21ee1ac1daa2d8e077bec68815421dd7a7a54a";>0a21ee1 replace references to slf4j-log4j12 https://github.com/qos-ch/slf4j/commit/51b6d20b71de75f69ee68167afbf4073c1be7c31";>51b6d20 prepare release 1.7.34 https://github.com/qos-ch/slf4j/commit/d22943faedd5da8d0321cf60437796fb53618481";>d22943f relocate slf4j-log4j12 as slf4j-reload4j Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.36";>compare view Updates `slf4j-nop` from 1.7.32 to 1.7.36 Commits https://github.com/qos-ch/slf4j/commit/e9ee55cca93c2bf26f14482a9bdf961c750d2a56";>e9ee55c update timestamp before release https://github.com/qos-ch/slf4j/commit/3b6a92f66815605ce851671dd1d6e0758c29ed4c";>3b6a92f reproducible builds https://github.com/qos-ch/slf4j/commit/882502706063b460997a3c6018223018f36cecd3";>8825027 prepare release 1.7.36, fix SLF4J-541 https://github.com/qos-ch/slf4j/commit/561738747da5813b8a9d2e2ebd10f0128a78a960";>5617387 add relase.sh https://github.com/qos-ch/slf4j/commit/02860b67ef7ff39fa9c7d98fd00da2ee913faeda";>02860b6 prepare relase 1.7.35 https://github.com/qos-ch/slf4j/commit/a622f5186a57188dab7f71651245eb91c6ac263b";>a622f51 fix maven deploy issues https://github.com/qos-ch/slf4j/commit/26068bd4bf93fcbd00185ad986dc43b79aceeb4a";>26068bd slf4j no longer references log4j https://github.com/qos-ch/slf4j/commit/0a21ee1ac1daa2d8e077bec68815421dd7a7a54a";>0a21ee1 replace references to slf4j-log4j12 https://github.com/qos-ch/slf4j/commit/51b6d20b71de75f69ee68167afbf4073c1be7c31";>51b6d20 prepare release 1.7.34 https://github.com/qos-ch/slf4j/commit/d22943faedd5da8d0321cf60437796fb53618481";>d22943f relocate slf4j-log4j12 as slf4j-reload4j Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.36";>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] dependabot[bot] commented on pull request #20: Bump slf4jVersion from 1.7.32 to 1.7.35
dependabot[bot] commented on pull request #20: URL: https://github.com/apache/maven-install-plugin/pull/20#issuecomment-1042580570 Superseded by #22. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] dependabot[bot] closed pull request #20: Bump slf4jVersion from 1.7.32 to 1.7.35
dependabot[bot] closed pull request #20: URL: https://github.com/apache/maven-install-plugin/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-789) Improve documentation of analyze - Non-test scoped
[
https://issues.apache.org/jira/browse/MDEP-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493652#comment-17493652
]
Hudson commented on MDEP-789:
-
Build succeeded in Jenkins: Maven » The Apache Software Foundation »
maven-dependency-plugin » PR-195 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-github/job/maven-dependency-plugin/job/PR-195/2/
> Improve documentation of analyze - Non-test scoped
> --
>
> Key: MDEP-789
> URL: https://issues.apache.org/jira/browse/MDEP-789
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> There is new type of analyze *{{Non-test scoped}}* documentation of analyze
> goal should be updated.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MDEP-789) Improve documentation of analyze - Non-test scoped
[
https://issues.apache.org/jira/browse/MDEP-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493657#comment-17493657
]
Hudson commented on MDEP-789:
-
Build succeeded in Jenkins: Maven » The Apache Software Foundation »
maven-dependency-plugin » PR-197 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-github/job/maven-dependency-plugin/job/PR-197/2/
> Improve documentation of analyze - Non-test scoped
> --
>
> Key: MDEP-789
> URL: https://issues.apache.org/jira/browse/MDEP-789
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> There is new type of analyze *{{Non-test scoped}}* documentation of analyze
> goal should be updated.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 merged pull request #471: [SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens
Tibor17 merged pull request #471: URL: https://github.com/apache/maven-surefire/pull/471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-1909) Support JUnit 5 reflection access by changing add-exports to add-opens
[
https://issues.apache.org/jira/browse/SUREFIRE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1909.
--
Resolution: Fixed
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=6b4ccdd19f904cdef710a126e2b9af4b1c7b60df
> Support JUnit 5 reflection access by changing add-exports to add-opens
> --
>
> Key: SUREFIRE-1909
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1909
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M5
>Reporter: Christian Kohlschütter
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: surefire-jpms-bug.tar.gz
>
>
> Testing JUnit 5 classes of a JPMS-enabled project with Surefire may fail if a
> test class (or, for example, an abstract test base class) is not declared
> "public". I'm seeing the following error:
>
> {code:java}
> java.lang.reflect.InaccessibleObjectException: Unable to make public static
> void some.package.SomeClass.setupClass() throws java.io.IOException
> accessible: module some.module does not "opens some.package" to unnamed
> module @754ba872{code}
> This could be fixed by adding the recommended "{{opens some.package}}" to the
> project's module-info.java, however that is undesirable since it changes the
> project's behavior beyond just unit testing. Adding a secondary "test-only"
> module-info.java is also counterproductive since not all IDEs support this,
> and these two files would have to be kept in sync, which is non-trivial.
> An easy fix would be to change the "{{--add-exports-}}" VM parameter that
> surefire adds automatically to "{{-}}{{add-opens}}" in
> {{maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ModularClasspathForkConfiguration.java}}
> This bug is particularly bad because PMD now specifically complains about
> junit5 classes marked as public instead of package-private; see
> [https://pmd.github.io/2021/05/29/PMD-6.35.0/]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] laeubi commented on pull request #675: [MNG-7407] Introduce a ModelVersionProcessor component to make CI Friends Versions pluggable
laeubi commented on pull request #675: URL: https://github.com/apache/maven/pull/675#issuecomment-1042612293 > The bug can be worked around for your PR. Anything I could do in the meantime to mitigate this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #675: [MNG-7407] Introduce a ModelVersionProcessor component to make CI Friends Versions pluggable
michael-o commented on pull request #675: URL: https://github.com/apache/maven/pull/675#issuecomment-1042622422 > > The bug can be worked around for your PR. > > Anything I could do in the meantime to mitigate this? Just need a bit of time. It is almost complete on my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7415) Cannot define system property with a dot in the name : [ERROR] Unknown lifecycle phase
Neil Crow created MNG-7415:
--
Summary: Cannot define system property with a dot in the name :
[ERROR] Unknown lifecycle phase
Key: MNG-7415
URL: https://issues.apache.org/jira/browse/MNG-7415
Project: Maven
Issue Type: Bug
Components: Command Line
Affects Versions: 3.8.4
Reporter: Neil Crow
In order to skip or debug integration tests or run a single test we need to
define system properties on the command line.
Whenever I try to define a system property with a dot in the name I get the
following error:
{noformat}
mvn install -Dmaven.test.skip=true
[ERROR] Unknown lifecycle phase ".test.skip=true". You must specify a valid
lifecycle phase or a goal in the format
{noformat}
This command works OK
{noformat}
mvn install -DskipITs{noformat}
There are several examples in the documentation which call for dotted system
properties to be passed, all of which seem to be affected by this issue:
* mvn -Dit.test=ITCircle verify
* mvn -Dmaven.failsafe.debug verify
* mvn install -Dmaven.test.skip=true
I have noticed that if I put a space after the -D then it appears to work.
* mvn -D maven.failsafe.debug verify
* mvn install -D maven.test.skip=true
Doc Links:
*
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/debugging.html|http://example.com/]
*
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/single-test.html|http://example.com/]
*
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/skipping-tests.html|http://example.com/]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-7415) Cannot define system property with a dot in the name : [ERROR] Unknown lifecycle phase
[
https://issues.apache.org/jira/browse/MNG-7415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neil Crow updated MNG-7415:
---
Description:
In order to skip or debug integration tests or run a single test we need to
define system properties on the command line.
Whenever I try to define a system property with a dot in the name I get the
following error:
{noformat}
mvn install -Dmaven.test.skip=true
[ERROR] Unknown lifecycle phase ".test.skip=true". You must specify a valid
lifecycle phase or a goal in the format
{noformat}
This command works OK
{noformat}
mvn install -DskipITs{noformat}
There are several examples in the documentation which call for dotted system
properties to be passed, all of which seem to be affected by this issue:
* mvn -Dit.test=ITCircle verify
* mvn -Dmaven.failsafe.debug verify
* mvn install -Dmaven.test.skip=true
I have noticed that if I put a space after the -D then it appears to work.
* mvn -D maven.failsafe.debug verify
* mvn install -D maven.test.skip=true
Doc Links:
*
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/debugging.html|http://example.com/]
*
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/single-test.html|http://example.com/]
*
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/skipping-tests.html|http://example.com/]
was:
In order to skip or debug integration tests or run a single test we need to
define system properties on the command line.
Whenever I try to define a system property with a dot in the name I get the
following error:
{noformat}
mvn install -Dmaven.test.skip=true
[ERROR] Unknown lifecycle phase ".test.skip=true". You must specify a valid
lifecycle phase or a goal in the format
{noformat}
This command works OK
{noformat}
mvn install -DskipITs{noformat}
There are several examples in the documentation which call for dotted system
properties to be passed, all of which seem to be affected by this issue:
* mvn -Dit.test=ITCircle verify
* mvn -Dmaven.failsafe.debug verify
* mvn install -Dmaven.test.skip=true
I have noticed that if I put a space after the -D then it appears to work.
* mvn -D maven.failsafe.debug verify
* mvn install -D maven.test.skip=true
Doc Links:
*
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/debugging.html|http://example.com/]
*
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/single-test.html|http://example.com/]
*
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/skipping-tests.html|http://example.com/]
> Cannot define system property with a dot in the name : [ERROR] Unknown
> lifecycle phase
> --
>
> Key: MNG-7415
> URL: https://issues.apache.org/jira/browse/MNG-7415
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Neil Crow
>Priority: Major
>
> In order to skip or debug integration tests or run a single test we need to
> define system properties on the command line.
> Whenever I try to define a system property with a dot in the name I get the
> following error:
>
> {noformat}
> mvn install -Dmaven.test.skip=true
> [ERROR] Unknown lifecycle phase ".test.skip=true". You must specify a valid
> lifecycle phase or a goal in the format
> {noformat}
> This command works OK
> {noformat}
> mvn install -DskipITs{noformat}
>
> There are several examples in the documentation which call for dotted system
> properties to be passed, all of which seem to be affected by this issue:
> * mvn -Dit.test=ITCircle verify
> * mvn -Dmaven.failsafe.debug verify
> * mvn install -Dmaven.test.skip=true
> I have noticed that if I put a space after the -D then it appears to work.
> * mvn -D maven.failsafe.debug verify
> * mvn install -D maven.test.skip=true
>
> Doc Links:
> *
> [https://maven.apache.org/surefire/maven-failsafe-plugin/examples/debugging.html|http://example.com/]
> *
> [https://maven.apache.org/surefire/maven-failsafe-plugin/examples/single-test.html|http://example.com/]
> *
> [https://maven.apache.org/surefire/maven-failsafe-plugin/examples/skipping-tests.html|http://example.com/]
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
