[GitHub] [maven] andrey-petrenko-db commented on a change in pull request #623: Mng 7129/master db subtree feature
andrey-petrenko-db commented on a change in pull request #623:
URL: https://github.com/apache/maven/pull/623#discussion_r757860817
##
File path:
maven-caching/src/main/java/org/apache/maven/caching/DefaultProjectInputCalculator.java
##
@@ -0,0 +1,127 @@
+package org.apache.maven.caching;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.SessionScoped;
+import org.apache.maven.caching.checksum.MavenProjectInput;
+import org.apache.maven.caching.xml.CacheConfig;
+import org.apache.maven.caching.xml.build.ProjectsInputInfo;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.lifecycle.internal.builder.BuilderCommon;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.repository.RepositorySystem;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import java.util.LinkedHashSet;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+
+@SessionScoped
+@Named
+public class DefaultProjectInputCalculator implements ProjectInputCalculator
+{
+private static final Logger LOGGER = LoggerFactory.getLogger(
DefaultProjectInputCalculator.class );
+
+private final MavenSession mavenSession;
+private final RemoteCacheRepository remoteCache;
+private final CacheConfig cacheConfig;
+private final RepositorySystem repoSystem;
+private final NormalizedModelProvider normalizedModelProvider;
+private final MultiModuleSupport multiModuleSupport;
+
+private final ConcurrentMap checkSumMap = new
ConcurrentHashMap<>();
+
+private static final ThreadLocal> CURRENTLY_CALCULATING =
ThreadLocal.withInitial(
+LinkedHashSet::new
+);
+
+@Inject
+public DefaultProjectInputCalculator( MavenSession mavenSession,
+ RemoteCacheRepository remoteCache,
+ CacheConfig cacheConfig,
+ RepositorySystem repoSystem,
+ NormalizedModelProvider
rawModelProvider,
+ MultiModuleSupport
multiModuleSupport )
+{
+this.mavenSession = mavenSession;
+this.remoteCache = remoteCache;
+this.cacheConfig = cacheConfig;
+this.repoSystem = repoSystem;
+this.normalizedModelProvider = rawModelProvider;
+this.multiModuleSupport = multiModuleSupport;
+}
+
+@Override
+public ProjectsInputInfo calculateInput( MavenProject project )
+{
+LOGGER.info( "Going to calculate checksum for project [groupId=" +
project.getGroupId()
++ ", artifactId=" + project.getArtifactId() + "]" );
+
+String key = BuilderCommon.getKey( project );
+ProjectsInputInfo projectsInputInfo = checkSumMap.get( key );
Review comment:
> could be simplified with computeIfAbsent
recursive computeIfAbsent calls are not allowed in CHM, this could lead to
IllegalStateException("Recursive update")
here is the example to reproduce
```
private static ConcurrentMap suspect = new
ConcurrentHashMap<>();
private static String recursiveUpdate( int i )
{
if ( i == 16 )
{
return String.valueOf( i );
}
return suspect.computeIfAbsent( i, k -> recursiveUpdate( k++ ) );
}
public static void main(String[] args) {
recursiveUpdate( 0 );
System.out.println( "Never printed" );
}
```
In jdk8 there could be infinite loop
https://stackoverflow.com/questions/28840047/recursive-concurrenthashmap-computeifabsent-call-never-terminates-bug-or-fea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MSKINS-167) Add deep anchors to headers
[ https://issues.apache.org/jira/browse/MSKINS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-167: -- Summary: Add deep anchors to headers (was: add deep anchors to headers) > Add deep anchors to headers > --- > > Key: MSKINS-167 > URL: https://issues.apache.org/jira/browse/MSKINS-167 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.9 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: fuildo-1.10 > > Time Spent: 20m > Remaining Estimate: 0h > > having anchors added to headers (using https://github.com/bryanbraun/anchorjs > or handwritten) would help a lot navigation -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MSKINS-167) Add deep anchors to headers
[ https://issues.apache.org/jira/browse/MSKINS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-167: -- Description: Having anchors added to headers (using https://github.com/bryanbraun/anchorjs or handwritten) would help a lot navigation. (was: having anchors added to headers (using https://github.com/bryanbraun/anchorjs or handwritten) would help a lot navigation) > Add deep anchors to headers > --- > > Key: MSKINS-167 > URL: https://issues.apache.org/jira/browse/MSKINS-167 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.9 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: fuildo-1.10 > > Time Spent: 20m > Remaining Estimate: 0h > > Having anchors added to headers (using https://github.com/bryanbraun/anchorjs > or handwritten) would help a lot navigation. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MSITE-876) Execution default-deploy of goal ...deploy failed: An API incompatibility was encountered while executing ....deploy: java.lang.NoSuchMethodError: org.apache.maven.wagon
[
https://issues.apache.org/jira/browse/MSITE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450019#comment-17450019
]
Konrad Windszus commented on MSITE-876:
---
No, I haven't tried that.
> Execution default-deploy of goal ...deploy failed: An API incompatibility was
> encountered while executing deploy: java.lang.NoSuchMethodError:
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.getBufferCapacityForTransfer(J)I
> --
>
> Key: MSITE-876
> URL: https://issues.apache.org/jira/browse/MSITE-876
> Project: Maven Site Plugin
> Issue Type: Bug
>Affects Versions: 3.9.1
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.10.0
>
>
> When using maven-site-plugin 3.9.1 with the additional plugin dependency
> {{org.apache.maven.wagon:wagon-webdav-jackrabbit:3.3.1}} I experience the
> following error
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.9.1:deploy (default-deploy) on
> project ...: Execution default-deploy of goal
> org.apache.maven.plugins:maven-site-plugin:3.9.1:deploy failed: An API
> incompatibility was encountered while executing
> org.apache.maven.plugins:maven-site-plugin:3.9.1:deploy:
> java.lang.NoSuchMethodError:
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.getBufferCapacityForTransfer(J)I
> [ERROR] -
> [ERROR] realm =plugin>org.apache.maven.plugins:maven-site-plugin:3.9.1
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/plugins/maven-site-plugin/3.9.1/maven-site-plugin-3.9.1.jar
> [ERROR] urls[1] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/wagon/wagon-webdav-jackrabbit/3.3.1/wagon-webdav-jackrabbit-3.3.1.jar
> [ERROR] urls[2] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/wagon/wagon-http-shared/3.3.1/wagon-http-shared-3.3.1.jar
> [ERROR] urls[3] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/jsoup/jsoup/1.11.2/jsoup-1.11.2.jar
> [ERROR] urls[4] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/jackrabbit/jackrabbit-webdav/2.14.4/jackrabbit-webdav-2.14.4.jar
> [ERROR] urls[5] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/commons-codec/commons-codec/1.10/commons-codec-1.10.jar
> [ERROR] urls[6] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/slf4j/jcl-over-slf4j/1.7.25/jcl-over-slf4j-1.7.25.jar
> [ERROR] urls[7] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/httpcomponents/httpclient/4.5.6/httpclient-4.5.6.jar
> [ERROR] urls[8] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/httpcomponents/httpcore/4.4.10/httpcore-4.4.10.jar
> [ERROR] urls[9] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/reporting/maven-reporting-api/3.0/maven-reporting-api-3.0.jar
> [ERROR] urls[10] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/reporting/maven-reporting-exec/1.5.1/maven-reporting-exec-1.5.1.jar
> [ERROR] urls[11] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/sonatype/aether/aether-util/1.7/aether-util-1.7.jar
> [ERROR] urls[12] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar
> [ERROR] urls[13] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/shared/maven-shared-utils/3.1.0/maven-shared-utils-3.1.0.jar
> [ERROR] urls[14] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
> [ERROR] urls[15] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/codehaus/plexus/plexus-component-annotations/2.0.0/plexus-component-annotations-2.0.0.jar
> [ERROR] urls[16] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
> [ERROR] urls[17] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
> [ERROR] urls[18] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/maven-archiver/3.5.0/maven-archiver-3.5.0.jar
> [ERROR] urls[19] =
[GitHub] [maven] hboutemy commented on pull request #486: [MNG-7182] Use a pull parser during the build/consumer transformation
hboutemy commented on pull request #486: URL: https://github.com/apache/maven/pull/486#issuecomment-981067843 @rfscholte do you see any drawback to using plexus-utils' XPP3? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-876) Execution default-deploy of goal ...deploy failed: An API incompatibility was encountered while executing ....deploy: java.lang.NoSuchMethodError: org.apache.maven.wagon
[
https://issues.apache.org/jira/browse/MSITE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450037#comment-17450037
]
Michael Osipov commented on MSITE-876:
--
Please try, I'd like to know whether my proposal works.
> Execution default-deploy of goal ...deploy failed: An API incompatibility was
> encountered while executing deploy: java.lang.NoSuchMethodError:
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.getBufferCapacityForTransfer(J)I
> --
>
> Key: MSITE-876
> URL: https://issues.apache.org/jira/browse/MSITE-876
> Project: Maven Site Plugin
> Issue Type: Bug
>Affects Versions: 3.9.1
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.10.0
>
>
> When using maven-site-plugin 3.9.1 with the additional plugin dependency
> {{org.apache.maven.wagon:wagon-webdav-jackrabbit:3.3.1}} I experience the
> following error
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.9.1:deploy (default-deploy) on
> project ...: Execution default-deploy of goal
> org.apache.maven.plugins:maven-site-plugin:3.9.1:deploy failed: An API
> incompatibility was encountered while executing
> org.apache.maven.plugins:maven-site-plugin:3.9.1:deploy:
> java.lang.NoSuchMethodError:
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.getBufferCapacityForTransfer(J)I
> [ERROR] -
> [ERROR] realm =plugin>org.apache.maven.plugins:maven-site-plugin:3.9.1
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/plugins/maven-site-plugin/3.9.1/maven-site-plugin-3.9.1.jar
> [ERROR] urls[1] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/wagon/wagon-webdav-jackrabbit/3.3.1/wagon-webdav-jackrabbit-3.3.1.jar
> [ERROR] urls[2] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/wagon/wagon-http-shared/3.3.1/wagon-http-shared-3.3.1.jar
> [ERROR] urls[3] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/jsoup/jsoup/1.11.2/jsoup-1.11.2.jar
> [ERROR] urls[4] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/jackrabbit/jackrabbit-webdav/2.14.4/jackrabbit-webdav-2.14.4.jar
> [ERROR] urls[5] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/commons-codec/commons-codec/1.10/commons-codec-1.10.jar
> [ERROR] urls[6] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/slf4j/jcl-over-slf4j/1.7.25/jcl-over-slf4j-1.7.25.jar
> [ERROR] urls[7] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/httpcomponents/httpclient/4.5.6/httpclient-4.5.6.jar
> [ERROR] urls[8] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/httpcomponents/httpcore/4.4.10/httpcore-4.4.10.jar
> [ERROR] urls[9] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/reporting/maven-reporting-api/3.0/maven-reporting-api-3.0.jar
> [ERROR] urls[10] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/reporting/maven-reporting-exec/1.5.1/maven-reporting-exec-1.5.1.jar
> [ERROR] urls[11] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/sonatype/aether/aether-util/1.7/aether-util-1.7.jar
> [ERROR] urls[12] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar
> [ERROR] urls[13] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/shared/maven-shared-utils/3.1.0/maven-shared-utils-3.1.0.jar
> [ERROR] urls[14] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
> [ERROR] urls[15] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/codehaus/plexus/plexus-component-annotations/2.0.0/plexus-component-annotations-2.0.0.jar
> [ERROR] urls[16] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
> [ERROR] urls[17] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
> [ERROR] urls[18] =
> file:/var/lib/jenkins/workspace/CQServer-CI_develop/.repository/org/apache/maven/maven-archiver/3.5.0/maven-archiver-3.5.
[GitHub] [maven-plugin-tools] slawekjaranowski opened a new pull request #52: [MPLUGIN-382] only dependency in compile scope in plugin descriptor
slawekjaranowski opened a new pull request #52: URL: https://github.com/apache/maven-plugin-tools/pull/52 `plugin.xml` descriptor - should only contain dependencies in compile scope -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on pull request #52: [MPLUGIN-382] only dependency in compile scope in plugin descriptor
michael-o commented on pull request #52: URL: https://github.com/apache/maven-plugin-tools/pull/52#issuecomment-981104491 @cstamas Can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed
[
https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450063#comment-17450063
]
Alex Chachanashvili commented on SUREFIRE-1621:
---
One important note is that surefire-api is now required as a dependency, I
tested on another project and it wold not work unless I added it explicitly as
a dependency:
org.apache.maven.plugins
maven-surefire-plugin
3.0.0-M5
org.junit.platform
junit-platform-surefire-provider
1.3.2
**
**
*org.apache.maven.surefire*
*surefire-api*
*3.0.0-M5*
**
> package-private class/method supported in JUnit5 is not executed
>
>
> Key: SUREFIRE-1621
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1621
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M3
> Environment: Java openJDK11, Maven 3.6.0
>Reporter: Alex Chachanashvili
>Assignee: Tibor Digana
>Priority: Major
> Attachments: MavenJUnit5Test.tar.gz
>
>
> Test classes/methods have to be made pubic in order for maven/surefire to
> execute them.
>
> Following will not execute (DebugTest.java) with surefire but will work with
> IntelliJ, eclipse, Gradle, etc that support JUnit5:
>
> {code:java}
> class SampleTest {
> @Test
> void testAlwaysFails() { assertTrue(false); }
> }{code}
>
> However changing it to following will work with Surefire but cause IDEs to
> flag public scope that can be changed to package-private:
>
> {code:java}
> public class SampleTest {
> @Test
> public void testAlwaysFails() { assertTrue(false); }
> }
> {code}
>
> JUnit 5 is supposed to support package-private declaration for test classes
> and test methods and IDEs like IntelliJ and eclipse are suggesting this,
> creating issues for people writing new tests that are not aware of the
> surefire anomaly. Also automatic code cleanup in some IDEs are changing the
> tests to be package-private and causing them to no longer run.
>
> Package-private tests are running correctly inside the IDEs and via Gradle,
> but being skipped with Maven+Surefire.
>
> POM is basically a simple java project with test file, attached.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId
[
https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AO Industries, Inc. updated MJAVADOC-682:
-
Affects Version/s: 3.3.1
> Reactor builds fail when multiple modules with same groupId:artifactId
> --
>
> Key: MJAVADOC-682
> URL: https://issues.apache.org/jira/browse/MJAVADOC-682
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar, javadoc
>Affects Versions: 3.1.0, 3.1.1, 3.2.0, 3.3.0, 3.3.1
> Environment: Debian Linux 10.10, Java 11.0.11, Maven 3.8.1
>Reporter: AO Industries, Inc.
>Priority: Major
>
> In versions 3.1.0 through 3.3.0, when a reactor build has multiple projects
> with the same groupId and artifactId, even when different versions, the
> javadoc fails with:
> Exit code: 1 - error: module not found: com.aoindustries.example
> Plugin 3.0.1 works.
> We have created a minimal example project that demonstrates this bug:
> [https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name]
>
> — Copy from demo project README.md —
> h2. To Reproduce:
> # Clone this project: {{git clone
> [https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name.git]}}
> # Change to project directory: {{cd
> maven-javadoc-plugin-failing-multiple-projects-same-name}}
> # Perform build to see error in {{jar}} goal: {{mvn verify}}
> # Also fails with {{javadoc}} goal: {{mvn clean compile javadoc:javadoc}}
> h2. Notes:
> * Can build individual modules directly, such as {{(cd module-1 && mvn
> verify)}}
> * Reverting to maven-javadoc-plugin version 3.0.1 makes it work
> * Changing the groupId or artifactId in either module-1 or module-2 makes it
> work.
> * Changing module names, package names, or class names in modules has no
> effect.
> * We believe this to be distinct from [Issue
> #673|https://issues.apache.org/jira/projects/MJAVADOC/issues/MJAVADOC-673]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId
[
https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AO Industries, Inc. updated MJAVADOC-682:
-
Description:
In versions 3.1.0 through 3.3.1, when a reactor build has multiple projects
with the same groupId and artifactId, even when different versions, the javadoc
fails with:
Exit code: 1 - error: module not found: com.aoindustries.example
Plugin 3.0.1 works.
We have created a minimal example project that demonstrates this bug:
[https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name]
— Copy from demo project README.md —
h2. To Reproduce:
# Clone this project: {{git clone
[https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name.git]}}
# Change to project directory: {{cd
maven-javadoc-plugin-failing-multiple-projects-same-name}}
# Perform build to see error in {{jar}} goal: {{mvn verify}}
# Also fails with {{javadoc}} goal: {{mvn clean compile javadoc:javadoc}}
h2. Notes:
* Can build individual modules directly, such as {{(cd module-1 && mvn
verify)}}
* Reverting to maven-javadoc-plugin version 3.0.1 makes it work
* Changing the groupId or artifactId in either module-1 or module-2 makes it
work.
* Changing module names, package names, or class names in modules has no
effect.
* We believe this to be distinct from [Issue
#673|https://issues.apache.org/jira/projects/MJAVADOC/issues/MJAVADOC-673]
was:
In versions 3.1.0 through 3.3.0, when a reactor build has multiple projects
with the same groupId and artifactId, even when different versions, the javadoc
fails with:
Exit code: 1 - error: module not found: com.aoindustries.example
Plugin 3.0.1 works.
We have created a minimal example project that demonstrates this bug:
[https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name]
— Copy from demo project README.md —
h2. To Reproduce:
# Clone this project: {{git clone
[https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name.git]}}
# Change to project directory: {{cd
maven-javadoc-plugin-failing-multiple-projects-same-name}}
# Perform build to see error in {{jar}} goal: {{mvn verify}}
# Also fails with {{javadoc}} goal: {{mvn clean compile javadoc:javadoc}}
h2. Notes:
* Can build individual modules directly, such as {{(cd module-1 && mvn
verify)}}
* Reverting to maven-javadoc-plugin version 3.0.1 makes it work
* Changing the groupId or artifactId in either module-1 or module-2 makes it
work.
* Changing module names, package names, or class names in modules has no
effect.
* We believe this to be distinct from [Issue
#673|https://issues.apache.org/jira/projects/MJAVADOC/issues/MJAVADOC-673]
> Reactor builds fail when multiple modules with same groupId:artifactId
> --
>
> Key: MJAVADOC-682
> URL: https://issues.apache.org/jira/browse/MJAVADOC-682
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar, javadoc
>Affects Versions: 3.1.0, 3.1.1, 3.2.0, 3.3.0, 3.3.1
> Environment: Debian Linux 10.10, Java 11.0.11, Maven 3.8.1
>Reporter: AO Industries, Inc.
>Priority: Major
>
> In versions 3.1.0 through 3.3.1, when a reactor build has multiple projects
> with the same groupId and artifactId, even when different versions, the
> javadoc fails with:
> Exit code: 1 - error: module not found: com.aoindustries.example
> Plugin 3.0.1 works.
> We have created a minimal example project that demonstrates this bug:
> [https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name]
>
> — Copy from demo project README.md —
> h2. To Reproduce:
> # Clone this project: {{git clone
> [https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name.git]}}
> # Change to project directory: {{cd
> maven-javadoc-plugin-failing-multiple-projects-same-name}}
> # Perform build to see error in {{jar}} goal: {{mvn verify}}
> # Also fails with {{javadoc}} goal: {{mvn clean compile javadoc:javadoc}}
> h2. Notes:
> * Can build individual modules directly, such as {{(cd module-1 && mvn
> verify)}}
> * Reverting to maven-javadoc-plugin version 3.0.1 makes it work
> * Changing the groupId or artifactId in either module-1 or module-2 makes it
> work.
> * Changing module names, package names, or class names in modules has no
> effect.
> * We believe this to be distinct from [Issue
> #673|https://issues.apache.org/jira/projects/MJAVADOC/issues/MJAVADOC-673]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId
[
https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450064#comment-17450064
]
AO Industries, Inc. commented on MJAVADOC-682:
--
We have tested version 3.3.1 and confirm this issue remains. Thank you.
> Reactor builds fail when multiple modules with same groupId:artifactId
> --
>
> Key: MJAVADOC-682
> URL: https://issues.apache.org/jira/browse/MJAVADOC-682
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar, javadoc
>Affects Versions: 3.1.0, 3.1.1, 3.2.0, 3.3.0, 3.3.1
> Environment: Debian Linux 10.10, Java 11.0.11, Maven 3.8.1
>Reporter: AO Industries, Inc.
>Priority: Major
>
> In versions 3.1.0 through 3.3.1, when a reactor build has multiple projects
> with the same groupId and artifactId, even when different versions, the
> javadoc fails with:
> Exit code: 1 - error: module not found: com.aoindustries.example
> Plugin 3.0.1 works.
> We have created a minimal example project that demonstrates this bug:
> [https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name]
>
> — Copy from demo project README.md —
> h2. To Reproduce:
> # Clone this project: {{git clone
> [https://github.com/aoindustries/maven-javadoc-plugin-failing-multiple-projects-same-name.git]}}
> # Change to project directory: {{cd
> maven-javadoc-plugin-failing-multiple-projects-same-name}}
> # Perform build to see error in {{jar}} goal: {{mvn verify}}
> # Also fails with {{javadoc}} goal: {{mvn clean compile javadoc:javadoc}}
> h2. Notes:
> * Can build individual modules directly, such as {{(cd module-1 && mvn
> verify)}}
> * Reverting to maven-javadoc-plugin version 3.0.1 makes it work
> * Changing the groupId or artifactId in either module-1 or module-2 makes it
> work.
> * Changing module names, package names, or class names in modules has no
> effect.
> * We believe this to be distinct from [Issue
> #673|https://issues.apache.org/jira/projects/MJAVADOC/issues/MJAVADOC-673]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (DOXIASITETOOLS-167) Replace deprecated Maven 2 MavenProjectBuilder with Maven 3 ProjectBuilder
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIASITETOOLS-167: -- Summary: Replace deprecated Maven 2 MavenProjectBuilder with Maven 3 ProjectBuilder (was: replace deprecated Maven 2 MavenProjectBuilder with Maven 3 ProjectBuilder) > Replace deprecated Maven 2 MavenProjectBuilder with Maven 3 ProjectBuilder > -- > > Key: DOXIASITETOOLS-167 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-167 > Project: Maven Doxia Sitetools > Issue Type: Task > Components: Integration Tools >Affects Versions: 1.7.1, 1.7.2 >Reporter: Herve Boutemy >Priority: Major > > this will avoid issues with settings like DOXIASITETOOLS-166: the current > workaround works by getting project from reactor when available, but when not > available in reactor (for example because using "-N"), loading pom with > MavenProjectBuilder won't properly interpolate values from settings -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MPLUGIN-382) To many dependencies in plugin descriptor
[
https://issues.apache.org/jira/browse/MPLUGIN-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450097#comment-17450097
]
Slawomir Jaranowski commented on MPLUGIN-382:
-
PR https://github.com/apache/maven-plugin-tools/pull/52
> To many dependencies in plugin descriptor
> -
>
> Key: MPLUGIN-382
> URL: https://issues.apache.org/jira/browse/MPLUGIN-382
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.2
>Reporter: Slawomir Jaranowski
>Priority: Critical
>
> Plugin descriptor {{plugin.xml}} generated by {{maven-plugin-plugin}} in
> version {{*3.6.1*}} for simple mojo has only *one* dependencies as:
> {code:xml}
>
>
> org.slf4j
> slf4j-api
> jar
> 1.7.32
>
>
> {code}
> but with version {{*3.6.2*}} for the same mojo we have, about *40*
> dependencies like:
> {code:xml}
>
>
> org.slf4j
> slf4j-api
> jar
> 1.7.32
>
>
> org.apache.maven
> maven-core
> jar
> 3.5.0
>
>
> org.apache.maven
> maven-model
> jar
> 3.5.0
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #623: Mng 7129/master db subtree feature
AlexanderAshitkin commented on a change in pull request #623:
URL: https://github.com/apache/maven/pull/623#discussion_r757934291
##
File path:
maven-caching/src/main/java/org/apache/maven/caching/DefaultProjectInputCalculator.java
##
@@ -0,0 +1,127 @@
+package org.apache.maven.caching;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.SessionScoped;
+import org.apache.maven.caching.checksum.MavenProjectInput;
+import org.apache.maven.caching.xml.CacheConfig;
+import org.apache.maven.caching.xml.build.ProjectsInputInfo;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.lifecycle.internal.builder.BuilderCommon;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.repository.RepositorySystem;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import java.util.LinkedHashSet;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+
+@SessionScoped
+@Named
+public class DefaultProjectInputCalculator implements ProjectInputCalculator
+{
+private static final Logger LOGGER = LoggerFactory.getLogger(
DefaultProjectInputCalculator.class );
+
+private final MavenSession mavenSession;
+private final RemoteCacheRepository remoteCache;
+private final CacheConfig cacheConfig;
+private final RepositorySystem repoSystem;
+private final NormalizedModelProvider normalizedModelProvider;
+private final MultiModuleSupport multiModuleSupport;
+
+private final ConcurrentMap checkSumMap = new
ConcurrentHashMap<>();
+
+private static final ThreadLocal> CURRENTLY_CALCULATING =
ThreadLocal.withInitial(
+LinkedHashSet::new
+);
+
+@Inject
+public DefaultProjectInputCalculator( MavenSession mavenSession,
+ RemoteCacheRepository remoteCache,
+ CacheConfig cacheConfig,
+ RepositorySystem repoSystem,
+ NormalizedModelProvider
rawModelProvider,
+ MultiModuleSupport
multiModuleSupport )
+{
+this.mavenSession = mavenSession;
+this.remoteCache = remoteCache;
+this.cacheConfig = cacheConfig;
+this.repoSystem = repoSystem;
+this.normalizedModelProvider = rawModelProvider;
+this.multiModuleSupport = multiModuleSupport;
+}
+
+@Override
+public ProjectsInputInfo calculateInput( MavenProject project )
+{
+LOGGER.info( "Going to calculate checksum for project [groupId=" +
project.getGroupId()
++ ", artifactId=" + project.getArtifactId() + "]" );
+
+String key = BuilderCommon.getKey( project );
+ProjectsInputInfo projectsInputInfo = checkSumMap.get( key );
Review comment:
Interesting, thank you. worth to leave a code comment because it is not
obvious (and recursive calls too tbh) - probably i'm not the last one of
thinking to refactor this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #623: Mng 7129/master db subtree feature
AlexanderAshitkin commented on a change in pull request #623:
URL: https://github.com/apache/maven/pull/623#discussion_r757934291
##
File path:
maven-caching/src/main/java/org/apache/maven/caching/DefaultProjectInputCalculator.java
##
@@ -0,0 +1,127 @@
+package org.apache.maven.caching;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.SessionScoped;
+import org.apache.maven.caching.checksum.MavenProjectInput;
+import org.apache.maven.caching.xml.CacheConfig;
+import org.apache.maven.caching.xml.build.ProjectsInputInfo;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.lifecycle.internal.builder.BuilderCommon;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.repository.RepositorySystem;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import java.util.LinkedHashSet;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+
+@SessionScoped
+@Named
+public class DefaultProjectInputCalculator implements ProjectInputCalculator
+{
+private static final Logger LOGGER = LoggerFactory.getLogger(
DefaultProjectInputCalculator.class );
+
+private final MavenSession mavenSession;
+private final RemoteCacheRepository remoteCache;
+private final CacheConfig cacheConfig;
+private final RepositorySystem repoSystem;
+private final NormalizedModelProvider normalizedModelProvider;
+private final MultiModuleSupport multiModuleSupport;
+
+private final ConcurrentMap checkSumMap = new
ConcurrentHashMap<>();
+
+private static final ThreadLocal> CURRENTLY_CALCULATING =
ThreadLocal.withInitial(
+LinkedHashSet::new
+);
+
+@Inject
+public DefaultProjectInputCalculator( MavenSession mavenSession,
+ RemoteCacheRepository remoteCache,
+ CacheConfig cacheConfig,
+ RepositorySystem repoSystem,
+ NormalizedModelProvider
rawModelProvider,
+ MultiModuleSupport
multiModuleSupport )
+{
+this.mavenSession = mavenSession;
+this.remoteCache = remoteCache;
+this.cacheConfig = cacheConfig;
+this.repoSystem = repoSystem;
+this.normalizedModelProvider = rawModelProvider;
+this.multiModuleSupport = multiModuleSupport;
+}
+
+@Override
+public ProjectsInputInfo calculateInput( MavenProject project )
+{
+LOGGER.info( "Going to calculate checksum for project [groupId=" +
project.getGroupId()
++ ", artifactId=" + project.getArtifactId() + "]" );
+
+String key = BuilderCommon.getKey( project );
+ProjectsInputInfo projectsInputInfo = checkSumMap.get( key );
Review comment:
Interesting, thank you. worth to leave a code comment because it is not
obvious (and recursive calls not immediately visible too tbh) - probably i'm
not the last one of thinking to refactor this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #623: Mng 7129/master db subtree feature
AlexanderAshitkin commented on a change in pull request #623:
URL: https://github.com/apache/maven/pull/623#discussion_r757744657
##
File path:
maven-caching/src/main/java/org/apache/maven/caching/CacheControllerImpl.java
##
@@ -397,67 +415,126 @@ private RestoredArtifact restoredArtifact(
org.apache.maven.artifact.Artifact pa
return artifact;
}
-private Future createDownloadTask( CacheResult cacheResult,
CacheContext context, MavenProject project,
- Artifact artifact )
-throws ExecutionException, InterruptedException
+//we might store in cache artifact which was build with previous version
+//1.0-SNAPSHOT is kept in cache but real version of project is 2.0
+//for pom packaging this is done automatically by maven but for jar and
other there might be
+//sensitive metadata with previous version. Versions mismatch could lead
errors
+private Path adjustArchiveArtifactVersion( MavenProject project, String
originalArtifactVersion, Path artifactFile )
+throws IOException
{
-final FutureTask downloadTask = new FutureTask<>( () ->
+
+File file = artifactFile.toFile();
+if ( project.getVersion().equals( originalArtifactVersion ) ||
!isArchive( file ) )
{
-LOGGER.debug( "Downloading artifact {}", artifact.getArtifactId()
);
-final Path artifactFile = localCache.getArtifactFile( context,
cacheResult.getSource(),
-artifact );
-if ( !Files.exists( artifactFile ) )
+return artifactFile;
+}
+
+String currentVersion = project.getVersion();
+File tmpJarFile = File.createTempFile( artifactFile.toFile().getName(),
+'.' + FilenameUtils.getExtension( file.getName() ) );
+tmpJarFile.deleteOnExit();
+String originalImplVersion = Attributes.Name.IMPLEMENTATION_VERSION +
": " + originalArtifactVersion;
+String implVersion = Attributes.Name.IMPLEMENTATION_VERSION + ": " +
currentVersion;
+String commonXmlOriginalVersion = "" +
originalArtifactVersion + "";
+String commonXmlVersion = "" + currentVersion + "";
+String originalPomPropsVersion = "version=" + originalArtifactVersion;
+String pomPropsVersion = "version=" + currentVersion;
+try ( JarFile jarFile = new JarFile( artifactFile.toFile() ) )
+{
+try ( JarOutputStream jos = new JarOutputStream(
+new BufferedOutputStream( new FileOutputStream( tmpJarFile
) ) ) )
{
-throw new FileNotFoundException(
-"Missing file for cached build, cannot restore. File:
" + artifactFile );
+//Copy original jar file to the temporary one.
+Enumeration jarEntries = jarFile.entries();
+byte[] buffer = new byte[1024];
+while ( jarEntries.hasMoreElements() )
+{
+JarEntry entry = jarEntries.nextElement();
+String entryName = entry.getName();
+
+if ( entryName.startsWith( "META-INF/maven" )
+&& ( entryName.endsWith( "plugin.xml" ) ||
entryName.endsWith( "plugin-help.xml" ) ) )
+{
+replaceEntry( jarFile, entry,
commonXmlOriginalVersion, commonXmlVersion, jos );
+continue;
+}
+
+if ( entryName.endsWith( "pom.xml" ) )
+{
+replaceEntry( jarFile, entry,
commonXmlOriginalVersion, commonXmlVersion, jos );
+continue;
+}
+
+if ( entryName.endsWith( "pom.properties" ) )
+{
+replaceEntry( jarFile, entry, originalPomPropsVersion,
pomPropsVersion, jos );
+continue;
+}
+
+if ( JarFile.MANIFEST_NAME.equals( entryName ) )
+{
+replaceEntry( jarFile, entry, originalImplVersion,
implVersion, jos );
+continue;
+}
+jos.putNextEntry( entry );
+try ( InputStream entryInputStream =
jarFile.getInputStream( entry ) )
+{
+int bytesRead;
+while ( ( bytesRead = entryInputStream.read( buffer )
) != -1 )
+{
+jos.write( buffer, 0, bytesRead );
+}
+}
+}
}
-LOGGER.debug( "Downloaded artifact " + artifact.getArtifactId() +
" to: " + artifactFile );
-return artifactFile.toFile();
-} );
-if ( !cacheConfig.isLazyRestore() )
-{
-downloadTask.r
[jira] [Created] (DOXIASITETOOLS-235) Upgrade Maven Doxia to 1.11
Michael Osipov created DOXIASITETOOLS-235: - Summary: Upgrade Maven Doxia to 1.11 Key: DOXIASITETOOLS-235 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-235 Project: Maven Doxia Sitetools Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 1.11 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (DOXIASITETOOLS-236) Deprecate Doxia Sitetools Doc Renderer
Michael Osipov created DOXIASITETOOLS-236: - Summary: Deprecate Doxia Sitetools Doc Renderer Key: DOXIASITETOOLS-236 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-236 Project: Maven Doxia Sitetools Issue Type: Task Components: Doc renderer Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 1.11 Doxia 1.11 will deprecate all page-oriented modules, means this module will rely on code being deprecated and marked for removal. Therefore, we cannot support page-oriented output. Only website-oriented one will remain. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MPDF-94) make build Reproducible
[ https://issues.apache.org/jira/browse/MPDF-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450102#comment-17450102 ] Michael Osipov commented on MPDF-94: [~hboutemy], is this one complete? > make build Reproducible > --- > > Key: MPDF-94 > URL: https://issues.apache.org/jira/browse/MPDF-94 > Project: Maven PDF Plugin > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: 1.5.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #623: Mng 7129/master db subtree feature
AlexanderAshitkin commented on a change in pull request #623:
URL: https://github.com/apache/maven/pull/623#discussion_r757744998
##
File path:
maven-caching/src/main/java/org/apache/maven/caching/CacheControllerImpl.java
##
@@ -397,67 +415,126 @@ private RestoredArtifact restoredArtifact(
org.apache.maven.artifact.Artifact pa
return artifact;
}
-private Future createDownloadTask( CacheResult cacheResult,
CacheContext context, MavenProject project,
- Artifact artifact )
-throws ExecutionException, InterruptedException
+//we might store in cache artifact which was build with previous version
+//1.0-SNAPSHOT is kept in cache but real version of project is 2.0
+//for pom packaging this is done automatically by maven but for jar and
other there might be
+//sensitive metadata with previous version. Versions mismatch could lead
errors
+private Path adjustArchiveArtifactVersion( MavenProject project, String
originalArtifactVersion, Path artifactFile )
+throws IOException
{
-final FutureTask downloadTask = new FutureTask<>( () ->
+
+File file = artifactFile.toFile();
+if ( project.getVersion().equals( originalArtifactVersion ) ||
!isArchive( file ) )
{
-LOGGER.debug( "Downloading artifact {}", artifact.getArtifactId()
);
-final Path artifactFile = localCache.getArtifactFile( context,
cacheResult.getSource(),
-artifact );
-if ( !Files.exists( artifactFile ) )
+return artifactFile;
+}
+
+String currentVersion = project.getVersion();
+File tmpJarFile = File.createTempFile( artifactFile.toFile().getName(),
+'.' + FilenameUtils.getExtension( file.getName() ) );
+tmpJarFile.deleteOnExit();
+String originalImplVersion = Attributes.Name.IMPLEMENTATION_VERSION +
": " + originalArtifactVersion;
+String implVersion = Attributes.Name.IMPLEMENTATION_VERSION + ": " +
currentVersion;
+String commonXmlOriginalVersion = "" +
originalArtifactVersion + "";
+String commonXmlVersion = "" + currentVersion + "";
+String originalPomPropsVersion = "version=" + originalArtifactVersion;
+String pomPropsVersion = "version=" + currentVersion;
+try ( JarFile jarFile = new JarFile( artifactFile.toFile() ) )
+{
+try ( JarOutputStream jos = new JarOutputStream(
+new BufferedOutputStream( new FileOutputStream( tmpJarFile
) ) ) )
{
-throw new FileNotFoundException(
-"Missing file for cached build, cannot restore. File:
" + artifactFile );
+//Copy original jar file to the temporary one.
+Enumeration jarEntries = jarFile.entries();
+byte[] buffer = new byte[1024];
+while ( jarEntries.hasMoreElements() )
+{
+JarEntry entry = jarEntries.nextElement();
+String entryName = entry.getName();
+
+if ( entryName.startsWith( "META-INF/maven" )
+&& ( entryName.endsWith( "plugin.xml" ) ||
entryName.endsWith( "plugin-help.xml" ) ) )
+{
+replaceEntry( jarFile, entry,
commonXmlOriginalVersion, commonXmlVersion, jos );
+continue;
+}
+
+if ( entryName.endsWith( "pom.xml" ) )
+{
+replaceEntry( jarFile, entry,
commonXmlOriginalVersion, commonXmlVersion, jos );
+continue;
+}
+
+if ( entryName.endsWith( "pom.properties" ) )
+{
+replaceEntry( jarFile, entry, originalPomPropsVersion,
pomPropsVersion, jos );
+continue;
+}
+
+if ( JarFile.MANIFEST_NAME.equals( entryName ) )
+{
+replaceEntry( jarFile, entry, originalImplVersion,
implVersion, jos );
+continue;
+}
+jos.putNextEntry( entry );
+try ( InputStream entryInputStream =
jarFile.getInputStream( entry ) )
+{
+int bytesRead;
+while ( ( bytesRead = entryInputStream.read( buffer )
) != -1 )
+{
+jos.write( buffer, 0, bytesRead );
+}
+}
+}
}
-LOGGER.debug( "Downloaded artifact " + artifact.getArtifactId() +
" to: " + artifactFile );
-return artifactFile.toFile();
-} );
-if ( !cacheConfig.isLazyRestore() )
-{
-downloadTask.r
[jira] [Closed] (DOXIASITETOOLS-236) Deprecate Doxia Sitetools Doc Renderer
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIASITETOOLS-236. - Resolution: Fixed Fixed with [cabe7d304f9e75ea1e40f1563854962132cb9a9a|https://gitbox.apache.org/repos/asf?p=maven-doxia-sitetools.git;a=commit;h=cabe7d304f9e75ea1e40f1563854962132cb9a9a]. > Deprecate Doxia Sitetools Doc Renderer > -- > > Key: DOXIASITETOOLS-236 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-236 > Project: Maven Doxia Sitetools > Issue Type: Task > Components: Doc renderer >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 1.11 > > > Doxia 1.11 will deprecate all page-oriented modules, means this module will > rely on code being deprecated and marked for removal. Therefore, we cannot > support page-oriented output. Only website-oriented one will remain. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MRELEASE-581) Git relative pathing broken with release plugin
[
https://issues.apache.org/jira/browse/MRELEASE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-581:
Fix Version/s: (was: Backlog)
> Git relative pathing broken with release plugin
> ---
>
> Key: MRELEASE-581
> URL: https://issues.apache.org/jira/browse/MRELEASE-581
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: Git, prepare
>Affects Versions: 2.0
> Environment: windows xp, service pack 2
>Reporter: Matthew Sandoz
>Assignee: Robert Scholte
>Priority: Minor
> Attachments: MRELEASE-581.patch, gitexe.zip
>
>
> i have a multimodule project, and when i try to do a release, i get
> everything working fine until the end. It seems to think for some reason that
> I am at the root of my scm tree. The repo i have to work in has several
> projects, and mine is in a subdirectory - domains/redemption. the plugin
> appears to try to check in my submodules at my current location instead of my
> scm root.
> COMMAND:
> {{mvn release:prepare -DpreparationGoals="clean install" -DskipTests
> -DautoVersionSubmodules=true}}
> {noformat}
> END OF OUTPUT:
> [INFO] [INFO] Reactor Summary:
> [INFO] [INFO]
>
> [INFO] [INFO] Redemption Parent POM . SUCCESS
> [2.595s]
> [INFO] [INFO] Redemption Runtime Confguration ... SUCCESS
> [3.531s]
> [INFO] [INFO] Redemption Service Metadata ... SUCCESS
> [18.816s]
> [INFO] [INFO] Redemption Model .. SUCCESS
> [35.693s]
> [INFO] [INFO] Redemption DAO SUCCESS
> [41.770s]
> [INFO] [INFO] Redemption Service Implementation . SUCCESS
> [17.517s]
> [INFO] [INFO] crm :: guest :: redemption :: ESB :: Parent POM ... SUCCESS
> [0.016s]
> [INFO] [INFO] crm :: guest :: redemption :: ESB :: XSLT . SUCCESS
> [5.469s]
> [INFO] [INFO] crm :: guest :: redemption :: ESB :: EIP .. SUCCESS
> [0.343s]
> [INFO] [INFO] crm :: guest :: redemption :: ESB :: Version Router ... SUCCESS
> [3.157s]
> [INFO] [INFO] crm :: guest :: redemption :: ESB :: Binding Component ::
> Service Unit SUCCESS [3.656s]
> [INFO] [INFO] crm :: guest :: redemption :: ESB :: Service Assembly . SUCCESS
> [3.516s]
> [INFO] [INFO]
>
> [INFO] [INFO]
>
> [INFO] [INFO] BUILD SUCCESSFUL
> [INFO] [INFO]
>
> [INFO] [INFO] Total time: 2 minutes 26 seconds
> [INFO] [INFO] Finished at: Tue Jul 27 17:18:02 EDT 2010
> [INFO] [INFO] Final Memory: 116M/254M
> [INFO] [INFO]
>
> [INFO] Checking in modified POMs...
> [INFO] Executing: cmd.exe /X /C "git add pom.xml redemption-conf\pom.xml
> redemption-metadata\pom.xml redemption-model\pom.xml rede
> mption-dao\pom.xml redemption-impl\pom.xml redemption-esb\pom.xml
> redemption-esb\redemption-xslt\pom.xml redemption-esb\redemption
> -eip\pom.xml redemption-esb\redemption-router\pom.xml
> redemption-esb\redemption-bc-su\pom.xml redemption-esb\redemption-sa\pom.xml
> "
> [INFO] Working directory: D:\workspaces\crm-dev\domains\redemption
> [INFO] Executing: cmd.exe /X /C "git status"
> [INFO] Working directory: D:\workspaces\crm-dev\domains\redemption
> [INFO] Executing: cmd.exe /X /C "git commit --verbose -F
> D:\DOCUME~1\sandozm\LOCALS~1\Temp\maven-scm-1862033505.commit pom.xml red
> emption-conf\pom.xml redemption-metadata\pom.xml redemption-model\pom.xml
> redemption-dao\pom.xml redemption-impl\pom.xml redemptio
> n-esb\pom.xml redemption-esb\redemption-xslt\pom.xml
> redemption-esb\redemption-eip\pom.xml redemption-esb\redemption-router\pom.xm
> l redemption-esb\redemption-bc-su\pom.xml
> redemption-esb\redemption-sa\pom.xml"
> [INFO] Working directory: D:\workspaces\crm-dev\domains\redemption
> [INFO]
>
> [ERROR] BUILD FAILURE
> [INFO]
>
> [INFO] Unable to commit files
> Provider message:
> The git-commit command failed.
> Command output:
> error: pathspec 'redemption-conf\pom.xml' did not match any file(s) known to
> git.
> error: pathspec 'redemption-metadata\pom.xml' did not match any file(s) known
> to git.
> error: pathspec 'redemption-model\pom.xml' did not match any file(s) known to
> git.
> error: pathspec 'redemption-dao\pom.xml' did not match any file(s) known to
> git.
> error: pa
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #53: (doc) info about Maven 3.2.2 and descriptor goal binding phase
slawekjaranowski commented on pull request #53: URL: https://github.com/apache/maven-plugin-tools/pull/53#issuecomment-981137445 Maybe information about binding override is not need at all? At page http://maven.apache.org/guides/plugin/guide-java-plugin-development.html#project-definition there is not such information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #68: [MINVOKER-271] fix detection of setup projects
slawekjaranowski commented on pull request #68: URL: https://github.com/apache/maven-invoker-plugin/pull/68#issuecomment-981137708 @michael-o kindly reminder 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] michael-o commented on pull request #68: [MINVOKER-271] fix detection of setup projects
michael-o commented on pull request #68: URL: https://github.com/apache/maven-invoker-plugin/pull/68#issuecomment-981138687 > @michael-o kindly reminder 😄 TBH, no clue here. I have never worked on Invoker before. @cstamas If you are certain that the change is correct, please merge this month. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] gunnarmorling edited a comment on pull request #60: [ARCHTYPE-308] optionally ask for properties with default values in
gunnarmorling edited a comment on pull request #60: URL: https://github.com/apache/maven-archetype/pull/60#issuecomment-981138823 Hey @hboutemy, pinging you as I saw you recently committed to this repo. I am interested in seeing a solution to this issue here, so I'm wondering what is missing in order to resolve it? I'd be willing to help if there's need for it. In terms of a solution, I think what's proposed here is good, only that'd I'd preferably make the new behavior the default (i.e. prompt for default options unless it's disabled explicitly). Alternatively, whether to prompt or not prompt could be a part of the archetype definition. WDYT? // CC @rfscholte -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] gunnarmorling commented on pull request #60: [ARCHTYPE-308] optionally ask for properties with default values in
gunnarmorling commented on pull request #60: URL: https://github.com/apache/maven-archetype/pull/60#issuecomment-981138823 Hey @hboutemy, pinging you as I saw you recently committed to this repo. I am interested in seeing a solution to this issue here, so I'm wondering what is missing in order to resolve it? I'd be willing to help if there's need for it. In terms of a solution, I think what's proposed here is good, only that'd I'd preferably make the new behavior the default (i.e. prompt for default options unless it's disabled explicitly). Alternatively, whether to prompt or not prompt could be a part of the archetype definition. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPDF-94) make build Reproducible
[ https://issues.apache.org/jira/browse/MPDF-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MPDF-94. - Resolution: Fixed done in https://github.com/apache/maven-pdf-plugin/commit/07240b3a66c123dcbf7342ef64418b8a3e5c56ed#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8 > make build Reproducible > --- > > Key: MPDF-94 > URL: https://issues.apache.org/jira/browse/MPDF-94 > Project: Maven PDF Plugin > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: 1.5.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #52: [MPLUGIN-382] only dependency in compile scope in plugin descriptor
cstamas commented on a change in pull request #52:
URL: https://github.com/apache/maven-plugin-tools/pull/52#discussion_r757943160
##
File path:
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/GeneratorUtils.java
##
@@ -122,14 +122,19 @@ public static void element( XMLWriter w, String name,
String value, boolean asTe
/**
* @param artifacts not null collection of Artifact
- * @return list of component dependencies
+ * @return list of component dependencies, only in compile scope
*/
public static List toComponentDependencies(
Collection artifacts )
{
List componentDeps = new LinkedList<>();
for ( Artifact artifact : artifacts )
{
+if ( !Artifact.SCOPE_COMPILE.equals( artifact.getScope() ) )
Review comment:
I would rather make `SCOPE = PROVIDED` (then continue). What about
runtime scope? Just to be on safe side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MPDF-81) Override the copyright footer
[ https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPDF-81: --- Fix Version/s: (was: 1.5.0) > Override the copyright footer > - > > Key: MPDF-81 > URL: https://issues.apache.org/jira/browse/MPDF-81 > Project: Maven PDF Plugin > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Alex O'Ree >Priority: Major > Labels: intern > Attachments: maven-pdf-plugin2.pdf > > > As of right now, it doesn't look possible to override the content of the > footer which is on all non-title page pages. It currently reads (c) year - > organization All rights reserved. > I don't see anywhere in the code where this is defined or in any of the > resource files. It is in the generated fo files but it's not obvious where > the xslt is. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-plugin-tools] michael-o commented on pull request #53: (doc) info about Maven 3.2.2 and descriptor goal binding phase
michael-o commented on pull request #53: URL: https://github.com/apache/maven-plugin-tools/pull/53#issuecomment-981144586 > Maybe information about binding override is not need at all? > > At page http://maven.apache.org/guides/plugin/guide-java-plugin-development.html#project-definition there is not such information. Maybe it is incomplete? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-269) Remove tagletArtifact from maven-javadoc-plugin
[
https://issues.apache.org/jira/browse/MPOM-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450112#comment-17450112
]
Michael Osipov commented on MPOM-269:
-
Just have been hit by this in MPDF :-(
> Remove tagletArtifact from maven-javadoc-plugin
> ---
>
> Key: MPOM-269
> URL: https://issues.apache.org/jira/browse/MPOM-269
> Project: Maven POMs
> Issue Type: Bug
> Components: maven-plugins
>Affects Versions: MAVEN-34
>Reporter: Robert Scholte
>Priority: Major
>
> The maven-plugin pom contains the following:
> {code:xml}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
>
>
>combine.id="org.apache.maven.plugin-tools:maven-plugin-tools-javadoc">
> org.apache.maven.plugin-tools
> maven-plugin-tools-javadoc
> ${mavenPluginToolsVersion}
>
>
>
>
> {code}
> However, as of 3.6 maven-plugin-tools-javadoc has been dropped because we
> prefer plugin annotations AND with Java 10 the Taglets API was moved to a
> different package.
> This blocks javadoc generation when mavenPluginToolsVersion is 3.6.0+
> Workaround in plugin project:
> {code:xml}
>
>
>
> org.apache.maven.plugins
> maven-javadoc-plugin
> 3.3.1
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MPDF-99) Add workaround for MPOM-269
Michael Osipov created MPDF-99: -- Summary: Add workaround for MPOM-269 Key: MPDF-99 URL: https://issues.apache.org/jira/browse/MPDF-99 Project: Maven PDF Plugin Issue Type: Task Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 1.5.1 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MPDF-99) Add workaround for MPOM-269
[ https://issues.apache.org/jira/browse/MPDF-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPDF-99. -- Resolution: Fixed Fixed with [286dcb19016670e0788cfda674b2017363ec9f32|https://gitbox.apache.org/repos/asf?p=maven-pdf-plugin.git;a=commit;h=286dcb19016670e0788cfda674b2017363ec9f32]. > Add workaround for MPOM-269 > --- > > Key: MPDF-99 > URL: https://issues.apache.org/jira/browse/MPDF-99 > Project: Maven PDF Plugin > Issue Type: Task >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 1.5.1 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks
cstamas commented on a change in pull request #131:
URL: https://github.com/apache/maven-resolver/pull/131#discussion_r757952484
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/TakariNameMapper.java
##
@@ -0,0 +1,126 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.metadata.Metadata;
+import org.eclipse.aether.named.support.FileSystemFriendly;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.util.Collection;
+import java.util.TreeSet;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link NameMapper} that creates same name mapping as Takari Local
Repository does, with baseDir (local repo).
+ * Part of code blatantly copies parts of the Takari {@code
LockingSyncContext}.
+ *
+ * @see https://github.com/takari/takari-local-repository/blob/master/src/main/java/io/takari/aether/concurrency/LockingSyncContext.java";>Takari
+ * LockingSyncContext.java
+ */
+@Singleton
+@Named( TakariNameMapper.NAME )
+public class TakariNameMapper
+implements NameMapper, FileSystemFriendly
+{
+public static final String NAME = "takari";
+
+private static final char SEPARATOR = '~';
+
+private final ConcurrentHashMap baseDirs;
+
+public TakariNameMapper()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public TreeSet nameLocks( final RepositorySystemSession session,
+ final Collection
artifacts,
+ final Collection
metadatas )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
Review comment:
baseDirs is essentially a barrier protecting costly `getCanonicalFile()`
to execute only once, and yes, it can change, but not within one session but
within things like mvnd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks
cstamas commented on pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#issuecomment-981153722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks
michael-o commented on pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#issuecomment-981153914 Thanks, will chew tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #137: [MRESOLVER-228] Proposed changes
cstamas commented on a change in pull request #137:
URL: https://github.com/apache/maven-resolver/pull/137#discussion_r757953664
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -169,8 +161,13 @@ public CollectResult collectDependencies(
RepositorySystemSession session, Colle
requireNonNull( request, "request cannot be null" );
session = optimizeSession( session );
-verbose = ConfigUtils.getBoolean( session, false,
CONFIG_PROP_RESOLVER_VERBOSE_MODE );
-skipMode = ConfigUtils.getBoolean( session, true,
CONFIG_PROP_RESOLVER_MODE );
+boolean useSkipReconcile = ConfigUtils.getBoolean(
+session, CONFIG_PROP_USE_SKIP_RECONCILE_DEFAULT,
CONFIG_PROP_USE_SKIP_RECONCILE
+);
+if ( useSkipReconcile )
+{
+LOGGER.debug( "Collector skip & reconcile enabled." );
Review comment:
It was present in original PR by @caiwei-ebay so let's wait for his
response here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed
[
https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450119#comment-17450119
]
Tibor Digana commented on SUREFIRE-1621:
Can you attach your POM here to Jira? Thx
Dňa ne 28. 11. 2021, 16:59 Alex Chachanashvili (Jira)
> package-private class/method supported in JUnit5 is not executed
>
>
> Key: SUREFIRE-1621
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1621
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M3
> Environment: Java openJDK11, Maven 3.6.0
>Reporter: Alex Chachanashvili
>Assignee: Tibor Digana
>Priority: Major
> Attachments: MavenJUnit5Test.tar.gz
>
>
> Test classes/methods have to be made pubic in order for maven/surefire to
> execute them.
>
> Following will not execute (DebugTest.java) with surefire but will work with
> IntelliJ, eclipse, Gradle, etc that support JUnit5:
>
> {code:java}
> class SampleTest {
> @Test
> void testAlwaysFails() { assertTrue(false); }
> }{code}
>
> However changing it to following will work with Surefire but cause IDEs to
> flag public scope that can be changed to package-private:
>
> {code:java}
> public class SampleTest {
> @Test
> public void testAlwaysFails() { assertTrue(false); }
> }
> {code}
>
> JUnit 5 is supposed to support package-private declaration for test classes
> and test methods and IDEs like IntelliJ and eclipse are suggesting this,
> creating issues for people writing new tests that are not aware of the
> surefire anomaly. Also automatic code cleanup in some IDEs are changing the
> tests to be package-private and causing them to no longer run.
>
> Package-private tests are running correctly inside the IDEs and via Gradle,
> but being skipped with Maven+Surefire.
>
> POM is basically a simple java project with test file, attached.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed
[
https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450120#comment-17450120
]
Slawomir Jaranowski commented on SUREFIRE-1621:
---
https://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven
{quote}
The junit-platform-surefire-provider, which was originally developed by the
JUnit team, was deprecated in JUnit Platform 1.3 and discontinued in 1.4.
Please use Maven Surefire’s native support instead.
{quote}
> package-private class/method supported in JUnit5 is not executed
>
>
> Key: SUREFIRE-1621
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1621
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M3
> Environment: Java openJDK11, Maven 3.6.0
>Reporter: Alex Chachanashvili
>Assignee: Tibor Digana
>Priority: Major
> Attachments: MavenJUnit5Test.tar.gz
>
>
> Test classes/methods have to be made pubic in order for maven/surefire to
> execute them.
>
> Following will not execute (DebugTest.java) with surefire but will work with
> IntelliJ, eclipse, Gradle, etc that support JUnit5:
>
> {code:java}
> class SampleTest {
> @Test
> void testAlwaysFails() { assertTrue(false); }
> }{code}
>
> However changing it to following will work with Surefire but cause IDEs to
> flag public scope that can be changed to package-private:
>
> {code:java}
> public class SampleTest {
> @Test
> public void testAlwaysFails() { assertTrue(false); }
> }
> {code}
>
> JUnit 5 is supposed to support package-private declaration for test classes
> and test methods and IDEs like IntelliJ and eclipse are suggesting this,
> creating issues for people writing new tests that are not aware of the
> surefire anomaly. Also automatic code cleanup in some IDEs are changing the
> tests to be package-private and causing them to no longer run.
>
> Package-private tests are running correctly inside the IDEs and via Gradle,
> but being skipped with Maven+Surefire.
>
> POM is basically a simple java project with test file, attached.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #52: [MPLUGIN-382] only dependency in compile scope in plugin descriptor
slawekjaranowski commented on a change in pull request #52:
URL: https://github.com/apache/maven-plugin-tools/pull/52#discussion_r757956467
##
File path:
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/GeneratorUtils.java
##
@@ -122,14 +122,19 @@ public static void element( XMLWriter w, String name,
String value, boolean asTe
/**
* @param artifacts not null collection of Artifact
- * @return list of component dependencies
+ * @return list of component dependencies, only in compile scope
*/
public static List toComponentDependencies(
Collection artifacts )
{
List componentDeps = new LinkedList<>();
for ( Artifact artifact : artifacts )
{
+if ( !Artifact.SCOPE_COMPILE.equals( artifact.getScope() ) )
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #53: (doc) info about Maven 3.2.2 and descriptor goal binding phase
slawekjaranowski commented on pull request #53: URL: https://github.com/apache/maven-plugin-tools/pull/53#issuecomment-981164951 It looks like plugin require maven 3.2.5 ... http://maven.apache.org/plugin-tools/maven-plugin-plugin/dependencies.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPLUGIN-383) Missing prerequisites in plugin pom
Slawomir Jaranowski created MPLUGIN-383: --- Summary: Missing prerequisites in plugin pom Key: MPLUGIN-383 URL: https://issues.apache.org/jira/browse/MPLUGIN-383 Project: Maven Plugin Tools Issue Type: Bug Components: Plugin Plugin Reporter: Slawomir Jaranowski There is not defined *prerequisites* tag in plugin pom. So we have Maven 2.0 as Requirements [http://maven.apache.org/plugin-tools/maven-plugin-plugin/plugin-info.html] [https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dist-tool/job/master/site/dist-tool-prerequisites.html] Imported Maven api is 3.2.5 [http://maven.apache.org/plugin-tools/maven-plugin-plugin/dependencies.html] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #81: Bump junit-bom from 5.8.1 to 5.8.2
dependabot[bot] opened a new pull request #81: URL: https://github.com/apache/maven-jlink-plugin/pull/81 Bumps [junit-bom](https://github.com/junit-team/junit5) from 5.8.1 to 5.8.2. Release notes Sourced from https://github.com/junit-team/junit5/releases";>junit-bom's releases. JUnit 5.8.2 = Platform 1.8.2 + Jupiter 5.8.2 + Vintage 5.8.2 See http://junit.org/junit5/docs/5.8.2/release-notes/";>Release Notes. Commits https://github.com/junit-team/junit5/commit/f58cd419755846f1476e8d15783438de8d7aede4";>f58cd41 Release 5.8.2 https://github.com/junit-team/junit5/commit/893617c8bcfd50a9c22023177c80db9973e36d8f";>893617c Fix Javadoc of DEFAULT_DISCOVERY_LISTENER_CONFIGURATION_PROPERTY_NAME https://github.com/junit-team/junit5/commit/3d75f99bf78fa386c17a52009670d6bcfa3f3168";>3d75f99 Use Gradle because to document junit-platform-launcher dependency https://github.com/junit-team/junit5/commit/4ef6e70989fb9ad9efef7bb45996854d876503b1";>4ef6e70 Support CSV headers in display names in parameterized tests https://github.com/junit-team/junit5/commit/69aed70d38b2b2ca3bb51b7a4f29c909573c0544";>69aed70 Polish Overview section of User Guide https://github.com/junit-team/junit5/commit/4181b9c05d5ac8ea056e3c06d35503f99403157a";>4181b9c Make quote character in https://github.com/CsvFileSource";>@CsvFileSource configurable https://github.com/junit-team/junit5/commit/e27058ec5c283bce2f495d0d0b4d328abc16d6e1";>e27058e Stop publishing to scans.gradle.com for PR builds https://github.com/junit-team/junit5/commit/d455b9894ae508d5aa859b7b8ae42debaadb8137";>d455b98 Always update snapshots https://github.com/junit-team/junit5/commit/938ab00d4db1f5ef074856907536bdec5ec414a1";>938ab00 Increase tool timeout to reduce flakiness https://github.com/junit-team/junit5/commit/cd257bd863cc63d32adbefe0c596b881eeabe099";>cd257bd Use longer timeouts to stabilize flaky tests Additional commits viewable in https://github.com/junit-team/junit5/compare/r5.8.1...r5.8.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] dependabot[bot] closed pull request #35: Bump maven-model from 3.8.2 to 3.8.3
dependabot[bot] closed pull request #35: URL: https://github.com/apache/maven-help-plugin/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request #38: Bump maven-model from 3.8.2 to 3.8.4
dependabot[bot] opened a new pull request #38: URL: https://github.com/apache/maven-help-plugin/pull/38 Bumps [maven-model](https://github.com/apache/maven) from 3.8.2 to 3.8.4. Commits https://github.com/apache/maven/commit/9b656c72d54e5bacbed989b64718c159fe39b537";>9b656c7 [maven-release-plugin] prepare release maven-3.8.4 https://github.com/apache/maven/commit/19c3b917b3604f93fef0583a08e70f8695d3a359";>19c3b91 [MNG-7331] Upgrade Jansi to 2.4.0 https://github.com/apache/maven/commit/5c36bf5ef78a162cefea47ccdaf0d28e01c1426c";>5c36bf5 [MNG-7312] Revert ThreadLocal approach from MNG-6843 and MNG-7251 https://github.com/apache/maven/commit/fb5f3f5b0f36d3232b0193c1d9b33fd0b36b9601";>fb5f3f5 [MNG-7270] Switch to shell alternative to "which" https://github.com/apache/maven/commit/b6186e2c7714158b5a2709f4af9d40b194c53f55";>b6186e2 Remove swap file https://github.com/apache/maven/commit/21e597ec777f0b74eed4e067b58b6eb8b0c9fad4";>21e597e [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven/commit/ff8e977a158738155dc465c6a97ffaf31982d739";>ff8e977 [maven-release-plugin] prepare release maven-3.8.3 https://github.com/apache/maven/commit/0a6bbb8301717d386e6588a7ea32e3e2451c7060";>0a6bbb8 [MNG-7235] Speed improvements when calculating the sorted project graph https://github.com/apache/maven/commit/8882a9c599013182e42f0c7c321396c23b84dbe0";>8882a9c [MNG-7164] Add constructor MojoExecutionException(Throwable) https://github.com/apache/maven/commit/ab54d17dc2ec355c1e002e8751739edd9a96fcc3";>ab54d17 [MNG-7253] Display relocation message defined in model Additional commits viewable in https://github.com/apache/maven/compare/maven-3.8.2...maven-3.8.4";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #35: Bump maven-model from 3.8.2 to 3.8.3
dependabot[bot] commented on pull request #35: URL: https://github.com/apache/maven-help-plugin/pull/35#issuecomment-981277144 Superseded by #38. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] dependabot[bot] opened a new pull request #39: Bump mavenPluginToolsVersion from 3.6.1 to 3.6.2
dependabot[bot] opened a new pull request #39: URL: https://github.com/apache/maven-parent/pull/39 Bumps `mavenPluginToolsVersion` from 3.6.1 to 3.6.2. Updates `maven-plugin-annotations` from 3.6.1 to 3.6.2 Commits https://github.com/apache/maven-plugin-tools/commit/c813ad9883dce7d449b9bf609d32f24669ce4496";>c813ad9 [maven-release-plugin] prepare release maven-plugin-tools-3.6.2 https://github.com/apache/maven-plugin-tools/commit/fefa7ca9cd787add15c9aa9f5885cc3cc200a35d";>fefa7ca [MPLUGIN-381] Upgrade QDox to 2.0.1 https://github.com/apache/maven-plugin-tools/commit/9c7b822d689aa450fe95cc5f8ad4cd5e2159191f";>9c7b822 fix wording https://github.com/apache/maven-plugin-tools/commit/2ee1d603e2a71bcd99d58a5e6a4c4b2d2669d9c4";>2ee1d60 [MPLUGIN-380] Always include thread safety in report https://github.com/apache/maven-plugin-tools/commit/64ec552c1721ed4de7e044ea807b0f32cfaafbb5";>64ec552 [MPLUGIN-379] Report goal does not include threadSafe attribute in generated ... https://github.com/apache/maven-plugin-tools/commit/2b4756dd67138ac85a18499fc39f31767b10fd3e";>2b4756d use shared gh action - v1 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/47";>#47) https://github.com/apache/maven-plugin-tools/commit/d57eaff72823b0ee9b043d369b565f98c07ba4e5";>d57eaff [MPLUGIN-376] Drop legacy dependencies (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/42";>#42) https://github.com/apache/maven-plugin-tools/commit/6d3d92e48534e6da29baf142ad9e5247c01d0d7e";>6d3d92e fix links to CI https://github.com/apache/maven-plugin-tools/commit/73e32d10e5ef6d42d3438fb34f6bb5561bce952c";>73e32d1 [MPLUGIN-377] Upgrade to maven 3.x and avoid using deprecated API (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/37";>#37) https://github.com/apache/maven-plugin-tools/commit/960d1500211b0211528dd34d2c3baa3d44bfcff4";>960d150 Weed out ITs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/45";>#45) Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.1...maven-plugin-tools-3.6.2";>compare view Updates `maven-plugin-plugin` from 3.6.1 to 3.6.2 Commits https://github.com/apache/maven-plugin-tools/commit/c813ad9883dce7d449b9bf609d32f24669ce4496";>c813ad9 [maven-release-plugin] prepare release maven-plugin-tools-3.6.2 https://github.com/apache/maven-plugin-tools/commit/fefa7ca9cd787add15c9aa9f5885cc3cc200a35d";>fefa7ca [MPLUGIN-381] Upgrade QDox to 2.0.1 https://github.com/apache/maven-plugin-tools/commit/9c7b822d689aa450fe95cc5f8ad4cd5e2159191f";>9c7b822 fix wording https://github.com/apache/maven-plugin-tools/commit/2ee1d603e2a71bcd99d58a5e6a4c4b2d2669d9c4";>2ee1d60 [MPLUGIN-380] Always include thread safety in report https://github.com/apache/maven-plugin-tools/commit/64ec552c1721ed4de7e044ea807b0f32cfaafbb5";>64ec552 [MPLUGIN-379] Report goal does not include threadSafe attribute in generated ... https://github.com/apache/maven-plugin-tools/commit/2b4756dd67138ac85a18499fc39f31767b10fd3e";>2b4756d use shared gh action - v1 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/47";>#47) https://github.com/apache/maven-plugin-tools/commit/d57eaff72823b0ee9b043d369b565f98c07ba4e5";>d57eaff [MPLUGIN-376] Drop legacy dependencies (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/42";>#42) https://github.com/apache/maven-plugin-tools/commit/6d3d92e48534e6da29baf142ad9e5247c01d0d7e";>6d3d92e fix links to CI https://github.com/apache/maven-plugin-tools/commit/73e32d10e5ef6d42d3438fb34f6bb5561bce952c";>73e32d1 [MPLUGIN-377] Upgrade to maven 3.x and avoid using deprecated API (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/37";>#37) https://github.com/apache/maven-plugin-tools/commit/960d1500211b0211528dd34d2c3baa3d44bfcff4";>960d150 Weed out ITs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/45";>#45) Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.1...maven-plugin-tools-3.6.2";>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will
