[GitHub] [maven-surefire] mguillem commented on pull request #311: doc suiteXmlFiles param incompatible with JUnit
mguillem commented on pull request #311: URL: https://github.com/apache/maven-surefire/pull/311#issuecomment-702596447 From the user perspective it is surely a bug: if you have a `suiteXMLFiles` configured that doesn't cover all your tests, you get troubles executing the remaining tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-140) Default to SHA-1 and MD5 hashing algorithms
[ https://issues.apache.org/jira/browse/MRESOLVER-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206038#comment-17206038 ] Konrad Windszus commented on MRESOLVER-140: --- Is it still possible to enforce deploying SHA512/SHA256 checksums (like required by ASF, https://infra.apache.org/release-distribution.html#sigs-and-sums) with `maven-deploy-plugin` with custom plugin properties or would that now require another change in the maven-install/deploy-plugin? > Default to SHA-1 and MD5 hashing algorithms > --- > > Key: MRESOLVER-140 > URL: https://issues.apache.org/jira/browse/MRESOLVER-140 > Project: Maven Resolver > Issue Type: Sub-task > Components: resolver >Affects Versions: 1.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 1.6.1 > > > This shall revert from SHA-512, SHA-256... to the previous state while the > user still can pass a property to use secure hashing algorithms. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MRESOLVER-140) Default to SHA-1 and MD5 hashing algorithms
[
https://issues.apache.org/jira/browse/MRESOLVER-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206038#comment-17206038
]
Konrad Windszus edited comment on MRESOLVER-140 at 10/2/20, 8:45 AM:
-
Is it still possible to enforce deploying SHA512/SHA256 checksums (like
required by ASF,
https://infra.apache.org/release-distribution.html#sigs-and-sums) with
{{maven-deploy-plugin}} with custom plugin properties or would that now require
another change in the maven-install/deploy-plugin?
was (Author: kwin):
Is it still possible to enforce deploying SHA512/SHA256 checksums (like
required by ASF,
https://infra.apache.org/release-distribution.html#sigs-and-sums) with
`maven-deploy-plugin` with custom plugin properties or would that now require
another change in the maven-install/deploy-plugin?
> Default to SHA-1 and MD5 hashing algorithms
> ---
>
> Key: MRESOLVER-140
> URL: https://issues.apache.org/jira/browse/MRESOLVER-140
> Project: Maven Resolver
> Issue Type: Sub-task
> Components: resolver
>Affects Versions: 1.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.1
>
>
> This shall revert from SHA-512, SHA-256... to the previous state while the
> user still can pass a property to use secure hashing algorithms.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-139) Make SimpleDigest use SHA-1 or MD5 only
[
https://issues.apache.org/jira/browse/MRESOLVER-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206039#comment-17206039
]
Konrad Windszus commented on MRESOLVER-139:
---
In which context is {{SimpleDigest}} being used?
> Make SimpleDigest use SHA-1 or MD5 only
> ---
>
> Key: MRESOLVER-139
> URL: https://issues.apache.org/jira/browse/MRESOLVER-139
> Project: Maven Resolver
> Issue Type: Sub-task
> Components: resolver
>Affects Versions: 1.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.1
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MINSTALL-138) option to calculate more checksum such sha-256 sha-512
[ https://issues.apache.org/jira/browse/MINSTALL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206043#comment-17206043 ] Konrad Windszus commented on MINSTALL-138: -- [~michael-o] As the default has been changed in MRESOLVER-140 we need a way to configure which checksum to generate with plugin parameters. Can you please reopen? > option to calculate more checksum such sha-256 sha-512 > -- > > Key: MINSTALL-138 > URL: https://issues.apache.org/jira/browse/MINSTALL-138 > Project: Maven Install Plugin > Issue Type: New Feature > Components: install:install, install:install-file >Affects Versions: 2.5.2 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > > currently install generate only sha-1 we should be able to generate sha-256 > and sha-512 as well. > NOTE: sha-512 will be required by Apache policy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-ear-plugin] zzzLobster commented on a change in pull request #17: [MEAR-287] Fixed failure when destination directory exists
zzzLobster commented on a change in pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#discussion_r498712047
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -443,7 +443,7 @@ private void copyModules( final JavaEEVersion javaEEVersion,
{
getLog().info( "Copying artifact [" + module + "] to [" +
module.getUri() + "] (unpacked)" );
// Make sure that the destination is a directory to avoid
plexus nasty stuff :)
-if ( !destinationFile.mkdirs() )
+if ( !destinationFile.isDirectory() &&
!destinationFile.mkdirs() )
Review comment:
I have merged the Marat's PR, So the PR currently contains IT for it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MINSTALL-138) option to calculate more checksum such sha-256 sha-512
[ https://issues.apache.org/jira/browse/MINSTALL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206103#comment-17206103 ] Michael Osipov commented on MINSTALL-138: - No, as mentioned numerous times, install does *not* require any checksums. In fact, this is the wrong place. Transport requires and MDEPLOY delegates this Resolver. So Resolver must take care of this. It be a violation of separation of concerns when this would be configurable here. > option to calculate more checksum such sha-256 sha-512 > -- > > Key: MINSTALL-138 > URL: https://issues.apache.org/jira/browse/MINSTALL-138 > Project: Maven Install Plugin > Issue Type: New Feature > Components: install:install, install:install-file >Affects Versions: 2.5.2 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > > currently install generate only sha-1 we should be able to generate sha-256 > and sha-512 as well. > NOTE: sha-512 will be required by Apache policy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRESOLVER-140) Default to SHA-1 and MD5 hashing algorithms
[ https://issues.apache.org/jira/browse/MRESOLVER-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206100#comment-17206100 ] Michael Osipov commented on MRESOLVER-140: -- Use the sytem property Resolver provides and you are good. > Default to SHA-1 and MD5 hashing algorithms > --- > > Key: MRESOLVER-140 > URL: https://issues.apache.org/jira/browse/MRESOLVER-140 > Project: Maven Resolver > Issue Type: Sub-task > Components: resolver >Affects Versions: 1.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 1.6.1 > > > This shall revert from SHA-512, SHA-256... to the previous state while the > user still can pass a property to use secure hashing algorithms. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRESOLVER-139) Make SimpleDigest use SHA-1 or MD5 only
[ https://issues.apache.org/jira/browse/MRESOLVER-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206101#comment-17206101 ] Michael Osipov commented on MRESOLVER-139: -- Calculation of fixed-length strings of repo keys. Use call hierarchy in your IDE. At the end, it affects every resolve call. > Make SimpleDigest use SHA-1 or MD5 only > --- > > Key: MRESOLVER-139 > URL: https://issues.apache.org/jira/browse/MRESOLVER-139 > Project: Maven Resolver > Issue Type: Sub-task > Components: resolver >Affects Versions: 1.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 1.6.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MINSTALL-138) option to calculate more checksum such sha-256 sha-512
[ https://issues.apache.org/jira/browse/MINSTALL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206126#comment-17206126 ] Konrad Windszus commented on MINSTALL-138: -- IMHO creating SHA512/256 checksums during a release is a project-specific settings. Configuring this globally via system variables would require additional settings to share. Although I do agree that checking against those checksums should be a global setting, creating those on the other hand shouldn't require adjusting global settings. > option to calculate more checksum such sha-256 sha-512 > -- > > Key: MINSTALL-138 > URL: https://issues.apache.org/jira/browse/MINSTALL-138 > Project: Maven Install Plugin > Issue Type: New Feature > Components: install:install, install:install-file >Affects Versions: 2.5.2 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > > currently install generate only sha-1 we should be able to generate sha-256 > and sha-512 as well. > NOTE: sha-512 will be required by Apache policy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MINSTALL-138) option to calculate more checksum such sha-256 sha-512
[ https://issues.apache.org/jira/browse/MINSTALL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206126#comment-17206126 ] Konrad Windszus edited comment on MINSTALL-138 at 10/2/20, 11:44 AM: - IMHO creating SHA512/256 checksums during a release is a project-specific setting. Configuring this globally via system variables would require additional settings to share. Although I do agree that checking against those checksums should be a global setting, creating those on the other hand shouldn't require adjusting global settings. was (Author: kwin): IMHO creating SHA512/256 checksums during a release is a project-specific settings. Configuring this globally via system variables would require additional settings to share. Although I do agree that checking against those checksums should be a global setting, creating those on the other hand shouldn't require adjusting global settings. > option to calculate more checksum such sha-256 sha-512 > -- > > Key: MINSTALL-138 > URL: https://issues.apache.org/jira/browse/MINSTALL-138 > Project: Maven Install Plugin > Issue Type: New Feature > Components: install:install, install:install-file >Affects Versions: 2.5.2 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > > currently install generate only sha-1 we should be able to generate sha-256 > and sha-512 as well. > NOTE: sha-512 will be required by Apache policy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MNG-6994) Carify remote repository resolution order
Konrad Windszus created MNG-6994:
Summary: Carify remote repository resolution order
Key: MNG-6994
URL: https://issues.apache.org/jira/browse/MNG-6994
Project: Maven
Issue Type: Improvement
Components: Documentation: General
Reporter: Konrad Windszus
It is possible to declare remote repositories in {{settings.xml}} and
{{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
for {{pom.xml}} it can be given only in the top-level {{repositories}} element.
The order in which an artifact is tried to be resolved from the different
remote repo is sometimes crucial to know (e.g. to speed up build times by first
checking against remote repos having most of the artifacts like Maven Central)
I would assume the order is
1. First all repositories from pom.xml in declaration order
2. Then the repositories from settings.xml in declaration order (independent of
repository or profile id).
It would be nice to document this in
https://maven.apache.org/guides/introduction/introduction-to-repositories.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MJAVADOC-664) Detection of stale files not working on Windows
Frederik Boster created MJAVADOC-664: Summary: Detection of stale files not working on Windows Key: MJAVADOC-664 URL: https://issues.apache.org/jira/browse/MJAVADOC-664 Project: Maven Javadoc Plugin Issue Type: Bug Reporter: Frederik Boster -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-6994) Carify remote repository resolution order
[
https://issues.apache.org/jira/browse/MNG-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MNG-6994:
-
Description:
It is possible to declare remote repositories in {{settings.xml}} and
{{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
for {{pom.xml}} it can be given only in the top-level {{repositories}} element.
The order in which an artifact is tried to be resolved from the different
remote repo is sometimes crucial to know (e.g. to speed up build times by first
checking against remote repos having most of the artifacts like Maven Central)
It would be nice to document this in
https://maven.apache.org/guides/introduction/introduction-to-repositories.html
was:
It is possible to declare remote repositories in {{settings.xml}} and
{{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
for {{pom.xml}} it can be given only in the top-level {{repositories}} element.
The order in which an artifact is tried to be resolved from the different
remote repo is sometimes crucial to know (e.g. to speed up build times by first
checking against remote repos having most of the artifacts like Maven Central)
I would assume the order is
1. First all repositories from pom.xml in declaration order
2. Then the repositories from settings.xml in declaration order (independent of
repository or profile id).
It would be nice to document this in
https://maven.apache.org/guides/introduction/introduction-to-repositories.html
> Carify remote repository resolution order
> -
>
> Key: MNG-6994
> URL: https://issues.apache.org/jira/browse/MNG-6994
> Project: Maven
> Issue Type: Improvement
> Components: Documentation: General
>Reporter: Konrad Windszus
>Priority: Major
>
> It is possible to declare remote repositories in {{settings.xml}} and
> {{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
> for {{pom.xml}} it can be given only in the top-level {{repositories}}
> element. The order in which an artifact is tried to be resolved from the
> different remote repo is sometimes crucial to know (e.g. to speed up build
> times by first checking against remote repos having most of the artifacts
> like Maven Central)
> It would be nice to document this in
> https://maven.apache.org/guides/introduction/introduction-to-repositories.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #17: [MEAR-287] Fixed failure when destination directory exists
elharo commented on a change in pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#discussion_r498837830
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -749,7 +749,7 @@ private void changeManifestClasspath( EarModule module,
File original, JavaEEVer
// Create a temporary work directory
// MEAR-167 use uri as directory to prevent merging of
artifacts with the same artifactId
workDirectory = new File( new File( getTempFolder(), "temp" ),
module.getUri() );
-if ( workDirectory.mkdirs() )
+if ( workDirectory.isDirectory() || workDirectory.mkdirs() )
{
getLog().debug( "Created a temporary work directory: " +
workDirectory.getAbsolutePath() );
Review comment:
log message is now incorrect here; probably need a nested if in this case
##
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##
@@ -993,4 +993,24 @@ public void testProject087()
{
doTestProject( "project-087", new String[] {
"eartest-ejb-sample-one-1.0.jar", "eartest-ejb-sample-two-1.0.jar" } );
}
+
+/**
+ * Builds WAR and EAR as part of multi-module project twice so that the
2nd build is guaranteed to be performed when
+ * target directories and files exist.
+ * @throws Exception in case of an error.
Review comment:
this @throws clause isn't needed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-6994) Carify remote repository resolution order
[
https://issues.apache.org/jira/browse/MNG-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MNG-6994:
-
Description:
It is possible to declare remote repositories in {{settings.xml}} and
{{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
for {{pom.xml}} it can be given in the top-level {{repositories}} element as
well as in profiles. The order in which an artifact is tried to be resolved
from the different remote repo is sometimes crucial to know (e.g. to speed up
build times by first checking against remote repos having most of the artifacts
like Maven Central)
It would be nice to document this in
https://maven.apache.org/guides/introduction/introduction-to-repositories.html
was:
It is possible to declare remote repositories in {{settings.xml}} and
{{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
for {{pom.xml}} it can be given only in the top-level {{repositories}} element.
The order in which an artifact is tried to be resolved from the different
remote repo is sometimes crucial to know (e.g. to speed up build times by first
checking against remote repos having most of the artifacts like Maven Central)
It would be nice to document this in
https://maven.apache.org/guides/introduction/introduction-to-repositories.html
> Carify remote repository resolution order
> -
>
> Key: MNG-6994
> URL: https://issues.apache.org/jira/browse/MNG-6994
> Project: Maven
> Issue Type: Improvement
> Components: Documentation: General
>Reporter: Konrad Windszus
>Priority: Major
>
> It is possible to declare remote repositories in {{settings.xml}} and
> {{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
> for {{pom.xml}} it can be given in the top-level {{repositories}} element as
> well as in profiles. The order in which an artifact is tried to be resolved
> from the different remote repo is sometimes crucial to know (e.g. to speed up
> build times by first checking against remote repos having most of the
> artifacts like Maven Central)
> It would be nice to document this in
> https://maven.apache.org/guides/introduction/introduction-to-repositories.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MJAVADOC-664) Detection of stale files not working on Windows
[
https://issues.apache.org/jira/browse/MJAVADOC-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frederik Boster updated MJAVADOC-664:
-
Affects Version/s: 3.2.0
Description:
h1. Description
The detection of stale files introduced by MJAVADOC-626 does not work on
Windows.
The root cause is that file-arguments on the commandline, i.e. {{@options}} and
{{@packages}}, are not recognized as such, because of double-quoting, and are
therefore not resolved to individual arguments.
h1. Solution Proposal
The generated stale data detection key should contain only the arguments passed
to the javadoc binary but not the whole commandline.
This can be achieved by replacing the usage of {{Commandline#getCommandline()}}
by {{Commandline#getArguments()}} in
{{org.apache.maven.plugins.javadoc.StaleHelper#getStaleData(Commandline)}}
h1. Examples
Example for the generated stale data detection key on Windows:
{noformat}
cmd.exe
/X
/C
""C:\Program Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot\bin\javadoc.exe" @options
@packages"
C:\Programming\project\target\apidocs\allclasses-index.html = 1601644656408
C:\Programming\project\target\apidocs\allclasses.html = 1601644656424
C:\Programming\project\target\apidocs\allpackages-index.html = 1601644656412
C:\Programming\project\target\apidocs\constant-values.html = 1601644656341
C:\Programming\project\target\apidocs\deprecated-list.html = 1601644656421
C:\Programming\project\target\apidocs\element-list = 1601644656318
C:\Programming\project\target\apidocs\help-doc.html = 1601644656432
C:\Programming\project\target\apidocs\index-all.html = 1601644656400
C:\Programming\project\target\apidocs\index.html = 1601644656427
C:\Programming\project\target\apidocs\member-search-index.js = 1601644656395
C:\Programming\project\target\apidocs\member-search-index.zip = 1601644656397
C:\Programming\project\target\apidocs\options = 1601644688290
C:\Programming\project\target\apidocs\overview-tree.html = 1601644656373
C:\Programming\project\target\apidocs\package-search-index.js = 1601644656385
C:\Programming\project\target\apidocs\package-search-index.zip = 1601644656389
C:\Programming\project\target\apidocs\packages = 1601644688291
C:\Programming\project\target\apidocs\script.js = 1601644656441
C:\Programming\project\target\apidocs\search.js = 1601644656449
C:\Programming\project\target\apidocs\stylesheet.css = 1601644656437
C:\Programming\project\target\apidocs\type-search-index.js = 1601644656391
C:\Programming\project\target\apidocs\type-search-index.zip = 1601644656393
{noformat}
Example for the generated stale data detection key on Linux:
{noformat}
/usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc
@options
@packages
-classpath
'/home/x/.m2/repository/org/apache/maven/maven-core/3.6.3/maven-core-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-model/3.6.3/maven-model-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-settings/3.6.3/maven-settings-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-settings-builder/3.6.3/maven-settings-builder-3.6.3.jar:/home/x/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.25/plexus-interpolation-1.25.jar:/home/x/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.4/plexus-sec-dispatcher-1.4.jar:/home/x/.m2/repository/org/sonatype/plexus/plexus-cipher/1.7/plexus-cipher-1.7.jar:/home/x/.m2/repository/org/apache/maven/maven-builder-support/3.6.3/maven-builder-support-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-repository-metadata/3.6.3/maven-repository-metadata-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-artifact/3.6.3/maven-artifact-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-plugin-api/3.6.3/maven-plugin-api-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-model-builder/3.6.3/maven-model-builder-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-resolver-provider/3.6.3/maven-resolver-provider-3.6.3.jar:/home/x/.m2/repository/org/slf4j/slf4j-api/1.7.29/slf4j-api-1.7.29.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-impl/1.4.1/maven-resolver-impl-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-api/1.4.1/maven-resolver-api-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-spi/1.4.1/maven-resolver-spi-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-util/1.4.1/maven-resolver-util-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar:/home/x/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.4/org.eclipse.sisu.plexus-0.3.4.jar:/home/x/.m2/repository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar:/home/x/.m2/repository/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar:/home/x/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.4/org.eclipse.sisu.
[GitHub] [maven-javadoc-plugin] Syquel opened a new pull request #63: [MJAVADOC-664] - Fix stale javadoc data detection on Windows.
Syquel opened a new pull request #63: URL: https://github.com/apache/maven-javadoc-plugin/pull/63 Replaces the usage of the full commandline by only its arguments to generate the stale javadoc detection key. This approach allows to handle file-arguments appropriately in case of double-quoting by resolving them to their actual arguments. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-664) Detection of stale files not working on Windows
[
https://issues.apache.org/jira/browse/MJAVADOC-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206212#comment-17206212
]
Frederik Boster commented on MJAVADOC-664:
--
Pull Request created: https://github.com/apache/maven-javadoc-plugin/pull/63
> Detection of stale files not working on Windows
> ---
>
> Key: MJAVADOC-664
> URL: https://issues.apache.org/jira/browse/MJAVADOC-664
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Frederik Boster
>Priority: Minor
>
> h1. Description
> The detection of stale files introduced by MJAVADOC-626 does not work on
> Windows.
> The root cause is that file-arguments on the commandline, i.e. {{@options}}
> and {{@packages}}, are not recognized as such, because of double-quoting, and
> are therefore not resolved to individual arguments.
> h1. Solution Proposal
> The generated stale data detection key should contain only the arguments
> passed to the javadoc binary but not the whole commandline.
> This can be achieved by replacing the usage of
> {{Commandline#getCommandline()}} by {{Commandline#getArguments()}} in
> {{org.apache.maven.plugins.javadoc.StaleHelper#getStaleData(Commandline)}}
> h1. Examples
> Example for the generated stale data detection key on Windows:
> {noformat}
> cmd.exe
> /X
> /C
> ""C:\Program Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot\bin\javadoc.exe"
> @options @packages"
> C:\Programming\project\target\apidocs\allclasses-index.html = 1601644656408
> C:\Programming\project\target\apidocs\allclasses.html = 1601644656424
> C:\Programming\project\target\apidocs\allpackages-index.html = 1601644656412
> C:\Programming\project\target\apidocs\constant-values.html = 1601644656341
> C:\Programming\project\target\apidocs\deprecated-list.html = 1601644656421
> C:\Programming\project\target\apidocs\element-list = 1601644656318
> C:\Programming\project\target\apidocs\help-doc.html = 1601644656432
> C:\Programming\project\target\apidocs\index-all.html = 1601644656400
> C:\Programming\project\target\apidocs\index.html = 1601644656427
> C:\Programming\project\target\apidocs\member-search-index.js = 1601644656395
> C:\Programming\project\target\apidocs\member-search-index.zip = 1601644656397
> C:\Programming\project\target\apidocs\options = 1601644688290
> C:\Programming\project\target\apidocs\overview-tree.html = 1601644656373
> C:\Programming\project\target\apidocs\package-search-index.js = 1601644656385
> C:\Programming\project\target\apidocs\package-search-index.zip = 1601644656389
> C:\Programming\project\target\apidocs\packages = 1601644688291
> C:\Programming\project\target\apidocs\script.js = 1601644656441
> C:\Programming\project\target\apidocs\search.js = 1601644656449
> C:\Programming\project\target\apidocs\stylesheet.css = 1601644656437
> C:\Programming\project\target\apidocs\type-search-index.js = 1601644656391
> C:\Programming\project\target\apidocs\type-search-index.zip = 1601644656393
> {noformat}
> Example for the generated stale data detection key on Linux:
> {noformat}
> /usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc
> @options
> @packages
> -classpath
> '/home/x/.m2/repository/org/apache/maven/maven-core/3.6.3/maven-core-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-model/3.6.3/maven-model-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-settings/3.6.3/maven-settings-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-settings-builder/3.6.3/maven-settings-builder-3.6.3.jar:/home/x/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.25/plexus-interpolation-1.25.jar:/home/x/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.4/plexus-sec-dispatcher-1.4.jar:/home/x/.m2/repository/org/sonatype/plexus/plexus-cipher/1.7/plexus-cipher-1.7.jar:/home/x/.m2/repository/org/apache/maven/maven-builder-support/3.6.3/maven-builder-support-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-repository-metadata/3.6.3/maven-repository-metadata-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-artifact/3.6.3/maven-artifact-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-plugin-api/3.6.3/maven-plugin-api-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-model-builder/3.6.3/maven-model-builder-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-resolver-provider/3.6.3/maven-resolver-provider-3.6.3.jar:/home/x/.m2/repository/org/slf4j/slf4j-api/1.7.29/slf4j-api-1.7.29.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-impl/1.4.1/maven-resolver-impl-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-api/1.4.1/maven-resolver-api-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-spi/1.4.1/maven-resolver-spi-1.4.1.jar:/hom
[jira] [Updated] (MJAVADOC-664) Detection of stale files not working on Windows
[
https://issues.apache.org/jira/browse/MJAVADOC-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frederik Boster updated MJAVADOC-664:
-
Description:
h1. Description
The detection of stale files introduced by MJAVADOC-626 does not work on
Windows.
The root cause is that file-arguments on the commandline, i.e. {{@options}} and
{{@packages}}, are not recognized as such, because of double-quoting, and are
therefore not resolved to individual arguments.
h1. Solution Proposal
The generated stale data detection key should contain only the arguments passed
to the javadoc binary but not the whole commandline.
This can be achieved by replacing the usage of {{Commandline#getCommandline()}}
by {{Commandline#getArguments()}} in
{{org.apache.maven.plugins.javadoc.StaleHelper#getStaleData(Commandline)}}
h1. Examples
Example for the generated stale data detection key on Windows:
{noformat}
cmd.exe
/X
/C
""C:\Program Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot\bin\javadoc.exe" @options
@packages"
C:\Programming\project\target\apidocs\allclasses-index.html = 1601644656408
C:\Programming\project\target\apidocs\allclasses.html = 1601644656424
C:\Programming\project\target\apidocs\allpackages-index.html = 1601644656412
C:\Programming\project\target\apidocs\constant-values.html = 1601644656341
C:\Programming\project\target\apidocs\deprecated-list.html = 1601644656421
C:\Programming\project\target\apidocs\element-list = 1601644656318
C:\Programming\project\target\apidocs\help-doc.html = 1601644656432
C:\Programming\project\target\apidocs\index-all.html = 1601644656400
C:\Programming\project\target\apidocs\index.html = 1601644656427
C:\Programming\project\target\apidocs\member-search-index.js = 1601644656395
C:\Programming\project\target\apidocs\member-search-index.zip = 1601644656397
C:\Programming\project\target\apidocs\options = 1601644688290
C:\Programming\project\target\apidocs\overview-tree.html = 1601644656373
C:\Programming\project\target\apidocs\package-search-index.js = 1601644656385
C:\Programming\project\target\apidocs\package-search-index.zip = 1601644656389
C:\Programming\project\target\apidocs\packages = 1601644688291
C:\Programming\project\target\apidocs\script.js = 1601644656441
C:\Programming\project\target\apidocs\search.js = 1601644656449
C:\Programming\project\target\apidocs\stylesheet.css = 1601644656437
C:\Programming\project\target\apidocs\type-search-index.js = 1601644656391
C:\Programming\project\target\apidocs\type-search-index.zip = 1601644656393
{noformat}
Example for the generated stale data detection key on Linux:
{noformat}
/usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc
@options
@packages
-classpath
'/home/x/.m2/repository/org/apache/maven/maven-core/3.6.3/maven-core-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-model/3.6.3/maven-model-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-settings/3.6.3/maven-settings-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-settings-builder/3.6.3/maven-settings-builder-3.6.3.jar:/home/x/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.25/plexus-interpolation-1.25.jar:/home/x/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.4/plexus-sec-dispatcher-1.4.jar:/home/x/.m2/repository/org/sonatype/plexus/plexus-cipher/1.7/plexus-cipher-1.7.jar:/home/x/.m2/repository/org/apache/maven/maven-builder-support/3.6.3/maven-builder-support-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-repository-metadata/3.6.3/maven-repository-metadata-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-artifact/3.6.3/maven-artifact-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-plugin-api/3.6.3/maven-plugin-api-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-model-builder/3.6.3/maven-model-builder-3.6.3.jar:/home/x/.m2/repository/org/apache/maven/maven-resolver-provider/3.6.3/maven-resolver-provider-3.6.3.jar:/home/x/.m2/repository/org/slf4j/slf4j-api/1.7.29/slf4j-api-1.7.29.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-impl/1.4.1/maven-resolver-impl-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-api/1.4.1/maven-resolver-api-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-spi/1.4.1/maven-resolver-spi-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/resolver/maven-resolver-util/1.4.1/maven-resolver-util-1.4.1.jar:/home/x/.m2/repository/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar:/home/x/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.4/org.eclipse.sisu.plexus-0.3.4.jar:/home/x/.m2/repository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar:/home/x/.m2/repository/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar:/home/x/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.4/org.eclipse.sisu.inject-0.3.4.jar:/home/x/.m2/r
[jira] [Updated] (MNG-6994) Clarify remote repository resolution order
[
https://issues.apache.org/jira/browse/MNG-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MNG-6994:
-
Summary: Clarify remote repository resolution order (was: Carify remote
repository resolution order)
> Clarify remote repository resolution order
> --
>
> Key: MNG-6994
> URL: https://issues.apache.org/jira/browse/MNG-6994
> Project: Maven
> Issue Type: Improvement
> Components: Documentation: General
>Reporter: Konrad Windszus
>Priority: Major
>
> It is possible to declare remote repositories in {{settings.xml}} and
> {{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
> for {{pom.xml}} it can be given in the top-level {{repositories}} element as
> well as in profiles. The order in which an artifact is tried to be resolved
> from the different remote repo is sometimes crucial to know (e.g. to speed up
> build times by first checking against remote repos having most of the
> artifacts like Maven Central)
> It would be nice to document this in
> https://maven.apache.org/guides/introduction/introduction-to-repositories.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6994) Clarify remote repository resolution order
[
https://issues.apache.org/jira/browse/MNG-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206230#comment-17206230
]
Konrad Windszus commented on MNG-6994:
--
My empirical tests show the following order for downloading assets from
repositories
1. Global settings
2. User settings
3. Local POM (profile repos first)
4. Parent POMs (profiles repos first)
5. Super POM (profiles repos first)
It is weird though that the profiles in the individual files seem to be sorted
bottom up, i.e. repositories in the last profile are listed first (independent
of id).
If multiple repositories are listed in below a {{}} element they
are always tried in declaration order (again independent of id)
> Clarify remote repository resolution order
> --
>
> Key: MNG-6994
> URL: https://issues.apache.org/jira/browse/MNG-6994
> Project: Maven
> Issue Type: Improvement
> Components: Documentation: General
>Reporter: Konrad Windszus
>Priority: Major
>
> It is possible to declare remote repositories in {{settings.xml}} and
> {{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
> for {{pom.xml}} it can be given in the top-level {{repositories}} element as
> well as in profiles. The order in which an artifact is tried to be resolved
> from the different remote repo is sometimes crucial to know (e.g. to speed up
> build times by first checking against remote repos having most of the
> artifacts like Maven Central)
> It would be nice to document this in
> https://maven.apache.org/guides/introduction/introduction-to-repositories.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MINSTALL-138) option to calculate more checksum such sha-256 sha-512
[ https://issues.apache.org/jira/browse/MINSTALL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206231#comment-17206231 ] Michael Osipov commented on MINSTALL-138: - You are looking for something completely else: https://github.com/apache/maven/blob/master/apache-maven/pom.xml#L310-L336 > option to calculate more checksum such sha-256 sha-512 > -- > > Key: MINSTALL-138 > URL: https://issues.apache.org/jira/browse/MINSTALL-138 > Project: Maven Install Plugin > Issue Type: New Feature > Components: install:install, install:install-file >Affects Versions: 2.5.2 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > > currently install generate only sha-1 we should be able to generate sha-256 > and sha-512 as well. > NOTE: sha-512 will be required by Apache policy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MPMD-304) maven-pmd-plugin should be toolchains-aware
[ https://issues.apache.org/jira/browse/MPMD-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-304: Fix Version/s: 3.14.0 > maven-pmd-plugin should be toolchains-aware > --- > > Key: MPMD-304 > URL: https://issues.apache.org/jira/browse/MPMD-304 > Project: Maven PMD Plugin > Issue Type: Improvement >Affects Versions: 3.13.0 > Environment: maven 3.6.3 > JDK 1.8 (maven) > JDK 11 (toolchains.xml) >Reporter: Ed Randall >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > maven-pmd-plugin should be > [toolchains-aware|https://maven.apache.org/guides/mini/guide-using-toolchains.html] > and pick up the correct JDK used for compilation. If toolchains is in use, > it should select that one, not use the same JDK that maven is running. > > We have an enterprise build system which runs maven under JDK 1.8. Some > projects target 1.8, others target 11. The switch is handled using > toolchains.xml. > PMD seemingly cannot cope with 11 code when maven is running under 1.8. We > are forced to set `pmd.typeResolution=false` to avoid all sorts of strange > errors (eg. 'unused private method' despite it being used 28 times in the > same class). > We do have `targetJdk=11`. > These false errors do not occur when maven itself runs under JDK 11, with > `pmd.typeResolution=true`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MPMD-304) maven-pmd-plugin should be toolchains-aware
[ https://issues.apache.org/jira/browse/MPMD-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-304: Component/s: PMD CPD > maven-pmd-plugin should be toolchains-aware > --- > > Key: MPMD-304 > URL: https://issues.apache.org/jira/browse/MPMD-304 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Affects Versions: 3.13.0 > Environment: maven 3.6.3 > JDK 1.8 (maven) > JDK 11 (toolchains.xml) >Reporter: Ed Randall >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > maven-pmd-plugin should be > [toolchains-aware|https://maven.apache.org/guides/mini/guide-using-toolchains.html] > and pick up the correct JDK used for compilation. If toolchains is in use, > it should select that one, not use the same JDK that maven is running. > > We have an enterprise build system which runs maven under JDK 1.8. Some > projects target 1.8, others target 11. The switch is handled using > toolchains.xml. > PMD seemingly cannot cope with 11 code when maven is running under 1.8. We > are forced to set `pmd.typeResolution=false` to avoid all sorts of strange > errors (eg. 'unused private method' despite it being used 28 times in the > same class). > We do have `targetJdk=11`. > These false errors do not occur when maven itself runs under JDK 11, with > `pmd.typeResolution=true`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-pmd-plugin] adangel opened a new pull request #31: [MPMD-304] - maven-pmd-plugin should be toolchains-aware
adangel opened a new pull request #31: URL: https://github.com/apache/maven-pmd-plugin/pull/31 This PR adds toolchain support for PMD and CPD (see https://issues.apache.org/jira/browse/MPMD-304). In order to do this, the following changes are made: * Execution is now separated from PmdReport/CpdReport and moved to PmdExecutor/CpdExecutor * The properties/parameter are handed over as PmdRequest/CpdRequest * If a toolchain is in use, then PmdExecutor/CpdExecutor is called in a forked JVM. PmdRequest/CpdRequest is serialized/deserialized. * The result is provided for reporting via PmdResult/CpdResult. These classes are just wrappers around the always created `target/pmd.xml` and `target/cpd.xml` files. So basically, PMD serializeds the result into these XML files, and m-pmd-p picks it up from there. There are two possible incompatibilities: * The public method `PmdReport.getPMDConfiguration()` is gone - the PMDConfiguration instance is created now by PmdExecutor and is not exposed anymore. * `PmdReportGenerator` and `CpdReportGenerator` now work with the classes generated by m-pmd-p's generated modello classes instead of the PMD classes. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPMD) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPMD-XXX] - Subject of the JIRA Ticket`, where you replace `MPMD-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6994) Clarify remote repository resolution order
[
https://issues.apache.org/jira/browse/MNG-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206291#comment-17206291
]
Michael Osipov commented on MNG-6994:
-
Happily supporting docs improvement.
> Clarify remote repository resolution order
> --
>
> Key: MNG-6994
> URL: https://issues.apache.org/jira/browse/MNG-6994
> Project: Maven
> Issue Type: Improvement
> Components: Documentation: General
>Reporter: Konrad Windszus
>Priority: Major
>
> It is possible to declare remote repositories in {{settings.xml}} and
> {{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
> for {{pom.xml}} it can be given in the top-level {{repositories}} element as
> well as in profiles. The order in which an artifact is tried to be resolved
> from the different remote repo is sometimes crucial to know (e.g. to speed up
> build times by first checking against remote repos having most of the
> artifacts like Maven Central)
> It would be nice to document this in
> https://maven.apache.org/guides/introduction/introduction-to-repositories.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6994) Clarify remote repository resolution order
[
https://issues.apache.org/jira/browse/MNG-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206292#comment-17206292
]
Konrad Windszus commented on MNG-6994:
--
[~michael-o] Will prepare a PR. Do you have a hint for me where I can see that
the order of profiles is bottom up in Maven/Resolver code?
> Clarify remote repository resolution order
> --
>
> Key: MNG-6994
> URL: https://issues.apache.org/jira/browse/MNG-6994
> Project: Maven
> Issue Type: Improvement
> Components: Documentation: General
>Reporter: Konrad Windszus
>Priority: Major
>
> It is possible to declare remote repositories in {{settings.xml}} and
> {{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
> for {{pom.xml}} it can be given in the top-level {{repositories}} element as
> well as in profiles. The order in which an artifact is tried to be resolved
> from the different remote repo is sometimes crucial to know (e.g. to speed up
> build times by first checking against remote repos having most of the
> artifacts like Maven Central)
> It would be nice to document this in
> https://maven.apache.org/guides/introduction/introduction-to-repositories.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6994) Clarify remote repository resolution order
[
https://issues.apache.org/jira/browse/MNG-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206305#comment-17206305
]
Michael Osipov commented on MNG-6994:
-
To be honest, no. I would need to dig too.
> Clarify remote repository resolution order
> --
>
> Key: MNG-6994
> URL: https://issues.apache.org/jira/browse/MNG-6994
> Project: Maven
> Issue Type: Improvement
> Components: Documentation: General
>Reporter: Konrad Windszus
>Priority: Major
>
> It is possible to declare remote repositories in {{settings.xml}} and
> {{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
> for {{pom.xml}} it can be given in the top-level {{repositories}} element as
> well as in profiles. The order in which an artifact is tried to be resolved
> from the different remote repo is sometimes crucial to know (e.g. to speed up
> build times by first checking against remote repos having most of the
> artifacts like Maven Central)
> It would be nice to document this in
> https://maven.apache.org/guides/introduction/introduction-to-repositories.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #17: [MEAR-287] Fixed failure when destination directory exists
mabrarov commented on a change in pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#discussion_r498934256
##
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##
@@ -993,4 +993,24 @@ public void testProject087()
{
doTestProject( "project-087", new String[] {
"eartest-ejb-sample-one-1.0.jar", "eartest-ejb-sample-two-1.0.jar" } );
}
+
+/**
+ * Builds WAR and EAR as part of multi-module project twice so that the
2nd build is guaranteed to be performed when
+ * target directories and files exist.
+ * @throws Exception in case of an error.
Review comment:
I agree with useless of this part of this JavaDoc but I prefer to keep
code consistent - all tests in this file have this `@throws` JavaDoc
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #17: [MEAR-287] Fixed failure when destination directory exists
mabrarov commented on a change in pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#discussion_r498940815
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -749,7 +749,7 @@ private void changeManifestClasspath( EarModule module,
File original, JavaEEVer
// Create a temporary work directory
// MEAR-167 use uri as directory to prevent merging of
artifacts with the same artifactId
workDirectory = new File( new File( getTempFolder(), "temp" ),
module.getUri() );
-if ( workDirectory.mkdirs() )
+if ( workDirectory.isDirectory() || workDirectory.mkdirs() )
{
getLog().debug( "Created a temporary work directory: " +
workDirectory.getAbsolutePath() );
Review comment:
Could we just simplify log message till:
```java
getLog().debug( "Temporary work directory: " +
workDirectory.getAbsolutePath() );
```
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MRESOLVER-102) Make build reproducible
[ https://issues.apache.org/jira/browse/MRESOLVER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-102: - Summary: Make build reproducible (was: make build Reproducible) > Make build reproducible > --- > > Key: MRESOLVER-102 > URL: https://issues.apache.org/jira/browse/MRESOLVER-102 > Project: Maven Resolver > Issue Type: Improvement >Affects Versions: 1.4.1 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: 1.4.2, ant-tasks-1.2.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MRESOLVER-136) Migrate from maven-bundle-plugin to bnd-maven-plugin
[ https://issues.apache.org/jira/browse/MRESOLVER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-136: - Fix Version/s: (was: version-next) 1.6.1 > Migrate from maven-bundle-plugin to bnd-maven-plugin > > > Key: MRESOLVER-136 > URL: https://issues.apache.org/jira/browse/MRESOLVER-136 > Project: Maven Resolver > Issue Type: Improvement > Components: resolver >Affects Versions: 1.6.0 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: 1.6.1 > > > Some of the reasons for the migration are outlined at > https://blogs.paremus.com/2015/03/announcing-the-bnd-maven-plugin. > This requires building with Java 8. The resolver stays compatible with Java > 7, though. > Some hints for migration are listed at > https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/1718 and > https://wcm-io.atlassian.net/wiki/spaces/WCMIO/pages/1267040260/How+to+switch+from+maven-bundle-plugin+to+bnd-maven-plugin > Also this will ease creating reproducible builds: > https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#reproducible-builds -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MRESOLVER-136) Migrate from maven-bundle-plugin to bnd-maven-plugin
[ https://issues.apache.org/jira/browse/MRESOLVER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-136: Assignee: Michael Osipov > Migrate from maven-bundle-plugin to bnd-maven-plugin > > > Key: MRESOLVER-136 > URL: https://issues.apache.org/jira/browse/MRESOLVER-136 > Project: Maven Resolver > Issue Type: Improvement > Components: resolver >Affects Versions: 1.6.0 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: version-next > > > Some of the reasons for the migration are outlined at > https://blogs.paremus.com/2015/03/announcing-the-bnd-maven-plugin. > This requires building with Java 8. The resolver stays compatible with Java > 7, though. > Some hints for migration are listed at > https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/1718 and > https://wcm-io.atlassian.net/wiki/spaces/WCMIO/pages/1267040260/How+to+switch+from+maven-bundle-plugin+to+bnd-maven-plugin > Also this will ease creating reproducible builds: > https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#reproducible-builds -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MRESOLVER-137) Make OSGi bundles reproducible
[
https://issues.apache.org/jira/browse/MRESOLVER-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-137:
-
Summary: Make OSGi bundles reproducible (was: make Resolver OSGI bundles
reproducible)
> Make OSGi bundles reproducible
> --
>
> Key: MRESOLVER-137
> URL: https://issues.apache.org/jira/browse/MRESOLVER-137
> Project: Maven Resolver
> Issue Type: Bug
>Affects Versions: 1.4.2, 1.6.0
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: version-next
>
>
> work done in MRESOLVER-102 has made source jars reproducible, but not OSGI
> bundles created with Felix maven-bundle-plugin: the plugin-generated
> META-INF/MANIFEST.MF contains username and detailed JDK version, and order of
> Private Package is not reproducible
> we need probably to update the plugin and add:
> {noformat}<_reproducible>true{noformat}
> as a side note, here is the reproducibility test of the 1.6.0 release:
> {noformat}$ mvn -Papache-release clean verify -Dgpg.skip artifact:buildinfo
> -Dreference.repo=https://repository.apache.org/content/repositories/maven-1605
> -Dreference.compare.save -Dline.separator=$'\r\n'
> ...
> [INFO] --- maven-artifact-plugin:1.0-SNAPSHOT:buildinfo (default-cli) @
> maven-resolver-synccontext-redisson ---
> [INFO] Saved aggregate info on build to
> /tmp/maven-resolver-1.6.0/maven-resolver-synccontext-redisson/target/maven-resolver-synccontext-redisson-1.6.0.buildinfo
> [INFO] Checking against reference build from
> https://repository.apache.org/content/repositories/maven-1605...
> [WARNING] Reference buildinfo file not found: it will be generated from
> downloaded reference artifacts
> [INFO] Reference build java.version: 1.8 (from MANIFEST.MF Build-Jdk-Spec)
> [INFO] Reference build os.name: Windows (from pom.properties newline)
> [INFO] Minimal buildinfo generated from downloaded artifacts:
> /tmp/maven-resolver-1.6.0/target/reference/maven-resolver-synccontext-redisson-1.6.0.buildinfo
> [WARNING] size mismatch maven-resolver-api-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-api-1.6.0.jar
> maven-resolver-api/target/maven-resolver-api-1.6.0.jar
> [WARNING] size mismatch maven-resolver-spi-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-spi-1.6.0.jar
> maven-resolver-spi/target/maven-resolver-spi-1.6.0.jar
> [WARNING] size mismatch maven-resolver-test-util-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-test-util-1.6.0.jar
> maven-resolver-test-util/target/maven-resolver-test-util-1.6.0.jar
> [WARNING] size mismatch maven-resolver-util-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-util-1.6.0.jar
> maven-resolver-util/target/maven-resolver-util-1.6.0.jar
> [WARNING] size mismatch maven-resolver-impl-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-impl-1.6.0.jar
> maven-resolver-impl/target/maven-resolver-impl-1.6.0.jar
> [WARNING] size mismatch maven-resolver-connector-basic-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-connector-basic-1.6.0.jar
> maven-resolver-connector-basic/target/maven-resolver-connector-basic-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-classpath-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-transport-classpath-1.6.0.jar
> maven-resolver-transport-classpath/target/maven-resolver-transport-classpath-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-file-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-file-1.6.0.jar
> maven-resolver-transport-file/target/maven-resolver-transport-file-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-http-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-http-1.6.0.jar
> maven-resolver-transport-http/target/maven-resolver-transport-http-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-wagon-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-wagon-1.6.0.jar
> maven-resolver-transport-wagon/target/maven-resolver-transport-wagon-1.6.0.jar
> [WARNING] size mismatch maven-resolver-synccontext-global-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-synccontext-global-1.6.0.jar
> maven-resolver-synccontext-global/target/maven-resolver-synccontext-global-1.6.0.jar
> [WARNING] sha512 mismatch maven-resolver-synccontext-redisson-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-synccontext-redisson-1.6.0.jar
> maven-resolver-synccontext-redisson/target/maven-resolver-synccontext-redisson-1.6.0.jar
> [WARNING] Reproducible Build output summary: 14 files ok, 12 different
> [WARNING] see diff
> target/reference/maven-resolver-
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #17: [MEAR-287] Fixed failure when destination directory exists
mabrarov commented on a change in pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#discussion_r498953660
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -749,7 +749,7 @@ private void changeManifestClasspath( EarModule module,
File original, JavaEEVer
// Create a temporary work directory
// MEAR-167 use uri as directory to prevent merging of
artifacts with the same artifactId
workDirectory = new File( new File( getTempFolder(), "temp" ),
module.getUri() );
-if ( workDirectory.mkdirs() )
+if ( workDirectory.isDirectory() || workDirectory.mkdirs() )
{
getLog().debug( "Created a temporary work directory: " +
workDirectory.getAbsolutePath() );
Review comment:
Logging was reworked as requested in 304c4b3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MRESOLVER-136) git pu
[ https://issues.apache.org/jira/browse/MRESOLVER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-136: - Summary: git pu (was: Migrate from maven-bundle-plugin to bnd-maven-plugin) > git pu > -- > > Key: MRESOLVER-136 > URL: https://issues.apache.org/jira/browse/MRESOLVER-136 > Project: Maven Resolver > Issue Type: Improvement > Components: resolver >Affects Versions: 1.6.0 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: 1.6.1 > > > Some of the reasons for the migration are outlined at > https://blogs.paremus.com/2015/03/announcing-the-bnd-maven-plugin. > This requires building with Java 8. The resolver stays compatible with Java > 7, though. > Some hints for migration are listed at > https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/1718 and > https://wcm-io.atlassian.net/wiki/spaces/WCMIO/pages/1267040260/How+to+switch+from+maven-bundle-plugin+to+bnd-maven-plugin > Also this will ease creating reproducible builds: > https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#reproducible-builds -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MRESOLVER-136) Migrate from maven-bundle-plugin to bnd-maven-plugin
[ https://issues.apache.org/jira/browse/MRESOLVER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-136: - Summary: Migrate from maven-bundle-plugin to bnd-maven-plugin (was: git pu) > Migrate from maven-bundle-plugin to bnd-maven-plugin > > > Key: MRESOLVER-136 > URL: https://issues.apache.org/jira/browse/MRESOLVER-136 > Project: Maven Resolver > Issue Type: Improvement > Components: resolver >Affects Versions: 1.6.0 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: 1.6.1 > > > Some of the reasons for the migration are outlined at > https://blogs.paremus.com/2015/03/announcing-the-bnd-maven-plugin. > This requires building with Java 8. The resolver stays compatible with Java > 7, though. > Some hints for migration are listed at > https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/1718 and > https://wcm-io.atlassian.net/wiki/spaces/WCMIO/pages/1267040260/How+to+switch+from+maven-bundle-plugin+to+bnd-maven-plugin > Also this will ease creating reproducible builds: > https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#reproducible-builds -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MRESOLVER-137) Make OSGi bundles reproducible
[
https://issues.apache.org/jira/browse/MRESOLVER-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-137:
-
Fix Version/s: (was: version-next)
1.6.1
> Make OSGi bundles reproducible
> --
>
> Key: MRESOLVER-137
> URL: https://issues.apache.org/jira/browse/MRESOLVER-137
> Project: Maven Resolver
> Issue Type: Bug
>Affects Versions: 1.4.2, 1.6.0
>Reporter: Herve Boutemy
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.1
>
>
> work done in MRESOLVER-102 has made source jars reproducible, but not OSGI
> bundles created with Felix maven-bundle-plugin: the plugin-generated
> META-INF/MANIFEST.MF contains username and detailed JDK version, and order of
> Private Package is not reproducible
> we need probably to update the plugin and add:
> {noformat}<_reproducible>true{noformat}
> as a side note, here is the reproducibility test of the 1.6.0 release:
> {noformat}$ mvn -Papache-release clean verify -Dgpg.skip artifact:buildinfo
> -Dreference.repo=https://repository.apache.org/content/repositories/maven-1605
> -Dreference.compare.save -Dline.separator=$'\r\n'
> ...
> [INFO] --- maven-artifact-plugin:1.0-SNAPSHOT:buildinfo (default-cli) @
> maven-resolver-synccontext-redisson ---
> [INFO] Saved aggregate info on build to
> /tmp/maven-resolver-1.6.0/maven-resolver-synccontext-redisson/target/maven-resolver-synccontext-redisson-1.6.0.buildinfo
> [INFO] Checking against reference build from
> https://repository.apache.org/content/repositories/maven-1605...
> [WARNING] Reference buildinfo file not found: it will be generated from
> downloaded reference artifacts
> [INFO] Reference build java.version: 1.8 (from MANIFEST.MF Build-Jdk-Spec)
> [INFO] Reference build os.name: Windows (from pom.properties newline)
> [INFO] Minimal buildinfo generated from downloaded artifacts:
> /tmp/maven-resolver-1.6.0/target/reference/maven-resolver-synccontext-redisson-1.6.0.buildinfo
> [WARNING] size mismatch maven-resolver-api-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-api-1.6.0.jar
> maven-resolver-api/target/maven-resolver-api-1.6.0.jar
> [WARNING] size mismatch maven-resolver-spi-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-spi-1.6.0.jar
> maven-resolver-spi/target/maven-resolver-spi-1.6.0.jar
> [WARNING] size mismatch maven-resolver-test-util-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-test-util-1.6.0.jar
> maven-resolver-test-util/target/maven-resolver-test-util-1.6.0.jar
> [WARNING] size mismatch maven-resolver-util-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-util-1.6.0.jar
> maven-resolver-util/target/maven-resolver-util-1.6.0.jar
> [WARNING] size mismatch maven-resolver-impl-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-impl-1.6.0.jar
> maven-resolver-impl/target/maven-resolver-impl-1.6.0.jar
> [WARNING] size mismatch maven-resolver-connector-basic-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-connector-basic-1.6.0.jar
> maven-resolver-connector-basic/target/maven-resolver-connector-basic-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-classpath-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-transport-classpath-1.6.0.jar
> maven-resolver-transport-classpath/target/maven-resolver-transport-classpath-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-file-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-file-1.6.0.jar
> maven-resolver-transport-file/target/maven-resolver-transport-file-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-http-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-http-1.6.0.jar
> maven-resolver-transport-http/target/maven-resolver-transport-http-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-wagon-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-wagon-1.6.0.jar
> maven-resolver-transport-wagon/target/maven-resolver-transport-wagon-1.6.0.jar
> [WARNING] size mismatch maven-resolver-synccontext-global-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-synccontext-global-1.6.0.jar
> maven-resolver-synccontext-global/target/maven-resolver-synccontext-global-1.6.0.jar
> [WARNING] sha512 mismatch maven-resolver-synccontext-redisson-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-synccontext-redisson-1.6.0.jar
> maven-resolver-synccontext-redisson/target/maven-resolver-synccontext-redisson-1.6.0.jar
> [WARNING] Reproducible Build output summary: 14 files ok, 12 different
> [WARNING] see diff
> target/reference/maven-res
[jira] [Assigned] (MRESOLVER-137) Make OSGi bundles reproducible
[
https://issues.apache.org/jira/browse/MRESOLVER-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MRESOLVER-137:
Assignee: Michael Osipov
> Make OSGi bundles reproducible
> --
>
> Key: MRESOLVER-137
> URL: https://issues.apache.org/jira/browse/MRESOLVER-137
> Project: Maven Resolver
> Issue Type: Bug
>Affects Versions: 1.4.2, 1.6.0
>Reporter: Herve Boutemy
>Assignee: Michael Osipov
>Priority: Major
> Fix For: version-next
>
>
> work done in MRESOLVER-102 has made source jars reproducible, but not OSGI
> bundles created with Felix maven-bundle-plugin: the plugin-generated
> META-INF/MANIFEST.MF contains username and detailed JDK version, and order of
> Private Package is not reproducible
> we need probably to update the plugin and add:
> {noformat}<_reproducible>true{noformat}
> as a side note, here is the reproducibility test of the 1.6.0 release:
> {noformat}$ mvn -Papache-release clean verify -Dgpg.skip artifact:buildinfo
> -Dreference.repo=https://repository.apache.org/content/repositories/maven-1605
> -Dreference.compare.save -Dline.separator=$'\r\n'
> ...
> [INFO] --- maven-artifact-plugin:1.0-SNAPSHOT:buildinfo (default-cli) @
> maven-resolver-synccontext-redisson ---
> [INFO] Saved aggregate info on build to
> /tmp/maven-resolver-1.6.0/maven-resolver-synccontext-redisson/target/maven-resolver-synccontext-redisson-1.6.0.buildinfo
> [INFO] Checking against reference build from
> https://repository.apache.org/content/repositories/maven-1605...
> [WARNING] Reference buildinfo file not found: it will be generated from
> downloaded reference artifacts
> [INFO] Reference build java.version: 1.8 (from MANIFEST.MF Build-Jdk-Spec)
> [INFO] Reference build os.name: Windows (from pom.properties newline)
> [INFO] Minimal buildinfo generated from downloaded artifacts:
> /tmp/maven-resolver-1.6.0/target/reference/maven-resolver-synccontext-redisson-1.6.0.buildinfo
> [WARNING] size mismatch maven-resolver-api-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-api-1.6.0.jar
> maven-resolver-api/target/maven-resolver-api-1.6.0.jar
> [WARNING] size mismatch maven-resolver-spi-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-spi-1.6.0.jar
> maven-resolver-spi/target/maven-resolver-spi-1.6.0.jar
> [WARNING] size mismatch maven-resolver-test-util-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-test-util-1.6.0.jar
> maven-resolver-test-util/target/maven-resolver-test-util-1.6.0.jar
> [WARNING] size mismatch maven-resolver-util-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-util-1.6.0.jar
> maven-resolver-util/target/maven-resolver-util-1.6.0.jar
> [WARNING] size mismatch maven-resolver-impl-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-impl-1.6.0.jar
> maven-resolver-impl/target/maven-resolver-impl-1.6.0.jar
> [WARNING] size mismatch maven-resolver-connector-basic-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-connector-basic-1.6.0.jar
> maven-resolver-connector-basic/target/maven-resolver-connector-basic-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-classpath-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-transport-classpath-1.6.0.jar
> maven-resolver-transport-classpath/target/maven-resolver-transport-classpath-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-file-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-file-1.6.0.jar
> maven-resolver-transport-file/target/maven-resolver-transport-file-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-http-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-http-1.6.0.jar
> maven-resolver-transport-http/target/maven-resolver-transport-http-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-wagon-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-wagon-1.6.0.jar
> maven-resolver-transport-wagon/target/maven-resolver-transport-wagon-1.6.0.jar
> [WARNING] size mismatch maven-resolver-synccontext-global-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-synccontext-global-1.6.0.jar
> maven-resolver-synccontext-global/target/maven-resolver-synccontext-global-1.6.0.jar
> [WARNING] sha512 mismatch maven-resolver-synccontext-redisson-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-synccontext-redisson-1.6.0.jar
> maven-resolver-synccontext-redisson/target/maven-resolver-synccontext-redisson-1.6.0.jar
> [WARNING] Reproducible Build output summary: 14 files ok, 12 different
> [WARNING] see diff
> target/reference/maven-resolver-synccontext-redisso
[GitHub] [maven-resolver] asfgit closed pull request #71: [MRESOLVER-136] switch to bnd-maven-plugin for generating bundle headers
asfgit closed pull request #71: URL: https://github.com/apache/maven-resolver/pull/71 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-137) Make OSGi bundles reproducible
[
https://issues.apache.org/jira/browse/MRESOLVER-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MRESOLVER-137.
Resolution: Fixed
> Make OSGi bundles reproducible
> --
>
> Key: MRESOLVER-137
> URL: https://issues.apache.org/jira/browse/MRESOLVER-137
> Project: Maven Resolver
> Issue Type: Bug
>Affects Versions: 1.4.2, 1.6.0
>Reporter: Herve Boutemy
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.1
>
>
> work done in MRESOLVER-102 has made source jars reproducible, but not OSGI
> bundles created with Felix maven-bundle-plugin: the plugin-generated
> META-INF/MANIFEST.MF contains username and detailed JDK version, and order of
> Private Package is not reproducible
> we need probably to update the plugin and add:
> {noformat}<_reproducible>true{noformat}
> as a side note, here is the reproducibility test of the 1.6.0 release:
> {noformat}$ mvn -Papache-release clean verify -Dgpg.skip artifact:buildinfo
> -Dreference.repo=https://repository.apache.org/content/repositories/maven-1605
> -Dreference.compare.save -Dline.separator=$'\r\n'
> ...
> [INFO] --- maven-artifact-plugin:1.0-SNAPSHOT:buildinfo (default-cli) @
> maven-resolver-synccontext-redisson ---
> [INFO] Saved aggregate info on build to
> /tmp/maven-resolver-1.6.0/maven-resolver-synccontext-redisson/target/maven-resolver-synccontext-redisson-1.6.0.buildinfo
> [INFO] Checking against reference build from
> https://repository.apache.org/content/repositories/maven-1605...
> [WARNING] Reference buildinfo file not found: it will be generated from
> downloaded reference artifacts
> [INFO] Reference build java.version: 1.8 (from MANIFEST.MF Build-Jdk-Spec)
> [INFO] Reference build os.name: Windows (from pom.properties newline)
> [INFO] Minimal buildinfo generated from downloaded artifacts:
> /tmp/maven-resolver-1.6.0/target/reference/maven-resolver-synccontext-redisson-1.6.0.buildinfo
> [WARNING] size mismatch maven-resolver-api-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-api-1.6.0.jar
> maven-resolver-api/target/maven-resolver-api-1.6.0.jar
> [WARNING] size mismatch maven-resolver-spi-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-spi-1.6.0.jar
> maven-resolver-spi/target/maven-resolver-spi-1.6.0.jar
> [WARNING] size mismatch maven-resolver-test-util-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-test-util-1.6.0.jar
> maven-resolver-test-util/target/maven-resolver-test-util-1.6.0.jar
> [WARNING] size mismatch maven-resolver-util-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-util-1.6.0.jar
> maven-resolver-util/target/maven-resolver-util-1.6.0.jar
> [WARNING] size mismatch maven-resolver-impl-1.6.0.jar: investigate with
> diffoscope target/reference/maven-resolver-impl-1.6.0.jar
> maven-resolver-impl/target/maven-resolver-impl-1.6.0.jar
> [WARNING] size mismatch maven-resolver-connector-basic-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-connector-basic-1.6.0.jar
> maven-resolver-connector-basic/target/maven-resolver-connector-basic-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-classpath-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-transport-classpath-1.6.0.jar
> maven-resolver-transport-classpath/target/maven-resolver-transport-classpath-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-file-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-file-1.6.0.jar
> maven-resolver-transport-file/target/maven-resolver-transport-file-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-http-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-http-1.6.0.jar
> maven-resolver-transport-http/target/maven-resolver-transport-http-1.6.0.jar
> [WARNING] size mismatch maven-resolver-transport-wagon-1.6.0.jar: investigate
> with diffoscope target/reference/maven-resolver-transport-wagon-1.6.0.jar
> maven-resolver-transport-wagon/target/maven-resolver-transport-wagon-1.6.0.jar
> [WARNING] size mismatch maven-resolver-synccontext-global-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-synccontext-global-1.6.0.jar
> maven-resolver-synccontext-global/target/maven-resolver-synccontext-global-1.6.0.jar
> [WARNING] sha512 mismatch maven-resolver-synccontext-redisson-1.6.0.jar:
> investigate with diffoscope
> target/reference/maven-resolver-synccontext-redisson-1.6.0.jar
> maven-resolver-synccontext-redisson/target/maven-resolver-synccontext-redisson-1.6.0.jar
> [WARNING] Reproducible Build output summary: 14 files ok, 12 different
> [WARNING] see diff
> target/reference/maven-resolver-synccontext-redisson-1.6.0.buildinfo
> ma
[jira] [Closed] (MRESOLVER-136) Migrate from maven-bundle-plugin to bnd-maven-plugin
[ https://issues.apache.org/jira/browse/MRESOLVER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-136. Resolution: Fixed Fixed with [526fa331f5d66afeec7a25b80bffb5ed3dde23c8|https://gitbox.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=526fa331f5d66afeec7a25b80bffb5ed3dde23c8]. > Migrate from maven-bundle-plugin to bnd-maven-plugin > > > Key: MRESOLVER-136 > URL: https://issues.apache.org/jira/browse/MRESOLVER-136 > Project: Maven Resolver > Issue Type: Improvement > Components: resolver >Affects Versions: 1.6.0 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: 1.6.1 > > > Some of the reasons for the migration are outlined at > https://blogs.paremus.com/2015/03/announcing-the-bnd-maven-plugin. > This requires building with Java 8. The resolver stays compatible with Java > 7, though. > Some hints for migration are listed at > https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/1718 and > https://wcm-io.atlassian.net/wiki/spaces/WCMIO/pages/1267040260/How+to+switch+from+maven-bundle-plugin+to+bnd-maven-plugin > Also this will ease creating reproducible builds: > https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#reproducible-builds -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRESOLVER-136) Migrate from maven-bundle-plugin to bnd-maven-plugin
[ https://issues.apache.org/jira/browse/MRESOLVER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206386#comment-17206386 ] Hudson commented on MRESOLVER-136: -- Build failed in Jenkins: Maven » Maven TLP » maven-resolver » master #26 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/26/ > Migrate from maven-bundle-plugin to bnd-maven-plugin > > > Key: MRESOLVER-136 > URL: https://issues.apache.org/jira/browse/MRESOLVER-136 > Project: Maven Resolver > Issue Type: Improvement > Components: resolver >Affects Versions: 1.6.0 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: 1.6.1 > > > Some of the reasons for the migration are outlined at > https://blogs.paremus.com/2015/03/announcing-the-bnd-maven-plugin. > This requires building with Java 8. The resolver stays compatible with Java > 7, though. > Some hints for migration are listed at > https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/1718 and > https://wcm-io.atlassian.net/wiki/spaces/WCMIO/pages/1267040260/How+to+switch+from+maven-bundle-plugin+to+bnd-maven-plugin > Also this will ease creating reproducible builds: > https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#reproducible-builds -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MRESOLVER-138) MRESOLVER-56 introduces severe performance regression
[
https://issues.apache.org/jira/browse/MRESOLVER-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-138:
-
Summary: MRESOLVER-56 introduces severe performance regression (was:
MRESOLVER-56 introduces several performance regressions)
> MRESOLVER-56 introduces severe performance regression
> -
>
> Key: MRESOLVER-138
> URL: https://issues.apache.org/jira/browse/MRESOLVER-138
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.1
>
>
> As discussed on the dev ML, [~dantran] found out that additionally
> downloading SHA-512 and SHA-256 when both aren't there introduces a huge
> performance break because of the rounds. {{SimpleDigest}} requires also more
> time with SHA-512. My personal tests with various setups shows at least a 50%
> toll in resolution time.
> Ant Resolver Tasks:
> {noformat}
> master:SHA-512,SHA-256,SHA-1,MD5:central-mirror
>24,20 real40,09 user 4,11 sys
> master:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha256
>24,67 real45,04 user 3,89 sys
> master:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha1-md5
>24,37 real40,02 user 4,20 sys
> master:SHA-512,SHA-256:central-mirror
>33,34 real39,65 user 4,56 sys
> master:SHA-512,SHA-256:central-mirror-sha256
>43,42 real45,75 user 4,93 sys
> master:SHA-512,SHA-256:central-mirror-sha1-md5
>44,30 real46,01 user 5,13 sys
> master:SHA-1,MD5:central-mirror
>22,62 real37,27 user 3,86 sys
> master:SHA-1,MD5:central-mirror-sha256
>22,69 real37,08 user 4,10 sys
> master:SHA-1,MD5:central-mirror-sha1-md5
>22,81 real37,85 user 4,00 sys
> master:SHA-512:central-mirror
>32,20 real33,65 user 4,80 sys
> master:SHA-512:central-mirror-sha256
>33,61 real39,75 user 4,48 sys
> master:SHA-512:central-mirror-sha1-md5
>33,39 real36,00 user 4,12 sys
> master:SHA-256:central-mirror
>32,66 real36,49 user 4,80 sys
> master:SHA-256:central-mirror-sha256
>32,35 real35,41 user 4,44 sys
> master:SHA-256:central-mirror-sha1-md5
>33,44 real37,12 user 4,12 sys
> digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-mirror
>24,59 real44,12 user 4,05 sys
> digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha256
>24,69 real43,62 user 4,27 sys
> digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha1-md5
>24,68 real43,97 user 4,28 sys
> digest-fix:SHA-512,SHA-256:central-mirror
>33,53 real42,76 user 4,35 sys
> digest-fix:SHA-512,SHA-256:central-mirror-sha256
>43,16 real41,90 user 5,12 sys
> digest-fix:SHA-512,SHA-256:central-mirror-sha1-md5
>44,00 real45,75 user 5,24 sys
> digest-fix:SHA-1,MD5:central-mirror
>22,47 real33,67 user 4,02 sys
> digest-fix:SHA-1,MD5:central-mirror-sha256
>22,90 real37,95 user 4,08 sys
> digest-fix:SHA-1,MD5:central-mirror-sha1-md5
>22,62 real33,96 user 4,00 sys
> digest-fix:SHA-512:central-mirror
>32,28 real34,07 user 4,65 sys
> digest-fix:SHA-512:central-mirror-sha256
>33,84 real34,90 user 4,37 sys
> digest-fix:SHA-512:central-mirror-sha1-md5
>33,72 real37,18 user 4,31 sys
> digest-fix:SHA-256:central-mirror
>32,36 real35,70 user 4,39 sys
> digest-fix:SHA-256:central-mirror-sha256
>32,51 real37,18 user 4,57 sys
> digest-fix:SHA-256:central-mirror-sha1-md5
>33,36 real37,88 user 4,50 sys
> master:SHA-512,SHA-256,SHA-1,MD5:central-direct
> 274,93 real54,14 user 7,38 sys
> master:SHA-512,SHA-256:central-direct
> 218,85 real48,71 user 6,61 sys
> master:SHA-1,MD5:central-direct
> 158,51 real42,59 user 6,05 sys
> master:SHA-512:central-direct
> 163,33 real43,27 user 5,95 sys
> master:SHA-256:central-direct
> 167,36 real41,50 user 6,07 sys
> digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-direct
> 247,74 real54,25 user 7,07 sys
> digest-fix:SHA-512,SHA-256:central-direct
> 204,89 real47,79 user 6,49 sys
> digest-fix:SHA-1,MD5:central-direct
> 166,66 real42,36 user 6,03 sys
> digest-fix:SHA-512:central-direct
>
[jira] [Updated] (MRESOLVER-138) MRESOLVER-56 introduces severe performance regression
[
https://issues.apache.org/jira/browse/MRESOLVER-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-138:
-
Description:
As discussed on the dev ML, [~dantran] found out that additional download of
SHA-512 and SHA-256 when both aren't there introduces a huge performance
penalty because of the HTTP roundtrip. {{SimpleDigest}} requires also more time
with SHA-512. My personal tests with various setups show at least a 50% toll in
resolution time. (Not representative, of course)
Ant Resolver Tasks:
{noformat}
master:SHA-512,SHA-256,SHA-1,MD5:central-mirror
24,20 real40,09 user 4,11 sys
master:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha256
24,67 real45,04 user 3,89 sys
master:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha1-md5
24,37 real40,02 user 4,20 sys
master:SHA-512,SHA-256:central-mirror
33,34 real39,65 user 4,56 sys
master:SHA-512,SHA-256:central-mirror-sha256
43,42 real45,75 user 4,93 sys
master:SHA-512,SHA-256:central-mirror-sha1-md5
44,30 real46,01 user 5,13 sys
master:SHA-1,MD5:central-mirror
22,62 real37,27 user 3,86 sys
master:SHA-1,MD5:central-mirror-sha256
22,69 real37,08 user 4,10 sys
master:SHA-1,MD5:central-mirror-sha1-md5
22,81 real37,85 user 4,00 sys
master:SHA-512:central-mirror
32,20 real33,65 user 4,80 sys
master:SHA-512:central-mirror-sha256
33,61 real39,75 user 4,48 sys
master:SHA-512:central-mirror-sha1-md5
33,39 real36,00 user 4,12 sys
master:SHA-256:central-mirror
32,66 real36,49 user 4,80 sys
master:SHA-256:central-mirror-sha256
32,35 real35,41 user 4,44 sys
master:SHA-256:central-mirror-sha1-md5
33,44 real37,12 user 4,12 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-mirror
24,59 real44,12 user 4,05 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha256
24,69 real43,62 user 4,27 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha1-md5
24,68 real43,97 user 4,28 sys
digest-fix:SHA-512,SHA-256:central-mirror
33,53 real42,76 user 4,35 sys
digest-fix:SHA-512,SHA-256:central-mirror-sha256
43,16 real41,90 user 5,12 sys
digest-fix:SHA-512,SHA-256:central-mirror-sha1-md5
44,00 real45,75 user 5,24 sys
digest-fix:SHA-1,MD5:central-mirror
22,47 real33,67 user 4,02 sys
digest-fix:SHA-1,MD5:central-mirror-sha256
22,90 real37,95 user 4,08 sys
digest-fix:SHA-1,MD5:central-mirror-sha1-md5
22,62 real33,96 user 4,00 sys
digest-fix:SHA-512:central-mirror
32,28 real34,07 user 4,65 sys
digest-fix:SHA-512:central-mirror-sha256
33,84 real34,90 user 4,37 sys
digest-fix:SHA-512:central-mirror-sha1-md5
33,72 real37,18 user 4,31 sys
digest-fix:SHA-256:central-mirror
32,36 real35,70 user 4,39 sys
digest-fix:SHA-256:central-mirror-sha256
32,51 real37,18 user 4,57 sys
digest-fix:SHA-256:central-mirror-sha1-md5
33,36 real37,88 user 4,50 sys
master:SHA-512,SHA-256,SHA-1,MD5:central-direct
274,93 real54,14 user 7,38 sys
master:SHA-512,SHA-256:central-direct
218,85 real48,71 user 6,61 sys
master:SHA-1,MD5:central-direct
158,51 real42,59 user 6,05 sys
master:SHA-512:central-direct
163,33 real43,27 user 5,95 sys
master:SHA-256:central-direct
167,36 real41,50 user 6,07 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-direct
247,74 real54,25 user 7,07 sys
digest-fix:SHA-512,SHA-256:central-direct
204,89 real47,79 user 6,49 sys
digest-fix:SHA-1,MD5:central-direct
166,66 real42,36 user 6,03 sys
digest-fix:SHA-512:central-direct
164,31 real38,98 user 6,10 sys
digest-fix:SHA-256:central-direct
170,77 real44,77 user 5,79 sys
{noformat}
as well as Maven 3.7.0-SNAPSHOT:
{noformat}
master:SHA-512,SHA-256,SHA-1,MD5:central-direct
271,06 real65,54 user 7,67 sys
master:SHA-512,SHA-256:central-direct
202,95 real60,87 user 6,77 sys
master:SHA-1,MD5:central-direct
163,64 real50,00 user 6,85 sys
master:SHA-512:central-direct
165,11 real50,17 user 6,25 sys
master:SHA-256:central-direct
163,97 real52,24 user 5,81 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-direct
268,27 real64,90 user
[jira] [Updated] (MRESOLVER-138) MRESOLVER-56 introduces severe performance regression
[
https://issues.apache.org/jira/browse/MRESOLVER-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-138:
-
Description:
As discussed on the dev ML, [~dantran] found out that additional downloading of
SHA-512 and SHA-256 when both aren't there introduces a huge performance
penalty because of the HTTP roundtrip. {{SimpleDigest}} requires also more time
with SHA-512. My personal tests with various setups show at least a 50% toll in
resolution time. (Not representative, of course)
Ant Resolver Tasks:
{noformat}
master:SHA-512,SHA-256,SHA-1,MD5:central-mirror
24,20 real40,09 user 4,11 sys
master:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha256
24,67 real45,04 user 3,89 sys
master:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha1-md5
24,37 real40,02 user 4,20 sys
master:SHA-512,SHA-256:central-mirror
33,34 real39,65 user 4,56 sys
master:SHA-512,SHA-256:central-mirror-sha256
43,42 real45,75 user 4,93 sys
master:SHA-512,SHA-256:central-mirror-sha1-md5
44,30 real46,01 user 5,13 sys
master:SHA-1,MD5:central-mirror
22,62 real37,27 user 3,86 sys
master:SHA-1,MD5:central-mirror-sha256
22,69 real37,08 user 4,10 sys
master:SHA-1,MD5:central-mirror-sha1-md5
22,81 real37,85 user 4,00 sys
master:SHA-512:central-mirror
32,20 real33,65 user 4,80 sys
master:SHA-512:central-mirror-sha256
33,61 real39,75 user 4,48 sys
master:SHA-512:central-mirror-sha1-md5
33,39 real36,00 user 4,12 sys
master:SHA-256:central-mirror
32,66 real36,49 user 4,80 sys
master:SHA-256:central-mirror-sha256
32,35 real35,41 user 4,44 sys
master:SHA-256:central-mirror-sha1-md5
33,44 real37,12 user 4,12 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-mirror
24,59 real44,12 user 4,05 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha256
24,69 real43,62 user 4,27 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-mirror-sha1-md5
24,68 real43,97 user 4,28 sys
digest-fix:SHA-512,SHA-256:central-mirror
33,53 real42,76 user 4,35 sys
digest-fix:SHA-512,SHA-256:central-mirror-sha256
43,16 real41,90 user 5,12 sys
digest-fix:SHA-512,SHA-256:central-mirror-sha1-md5
44,00 real45,75 user 5,24 sys
digest-fix:SHA-1,MD5:central-mirror
22,47 real33,67 user 4,02 sys
digest-fix:SHA-1,MD5:central-mirror-sha256
22,90 real37,95 user 4,08 sys
digest-fix:SHA-1,MD5:central-mirror-sha1-md5
22,62 real33,96 user 4,00 sys
digest-fix:SHA-512:central-mirror
32,28 real34,07 user 4,65 sys
digest-fix:SHA-512:central-mirror-sha256
33,84 real34,90 user 4,37 sys
digest-fix:SHA-512:central-mirror-sha1-md5
33,72 real37,18 user 4,31 sys
digest-fix:SHA-256:central-mirror
32,36 real35,70 user 4,39 sys
digest-fix:SHA-256:central-mirror-sha256
32,51 real37,18 user 4,57 sys
digest-fix:SHA-256:central-mirror-sha1-md5
33,36 real37,88 user 4,50 sys
master:SHA-512,SHA-256,SHA-1,MD5:central-direct
274,93 real54,14 user 7,38 sys
master:SHA-512,SHA-256:central-direct
218,85 real48,71 user 6,61 sys
master:SHA-1,MD5:central-direct
158,51 real42,59 user 6,05 sys
master:SHA-512:central-direct
163,33 real43,27 user 5,95 sys
master:SHA-256:central-direct
167,36 real41,50 user 6,07 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-direct
247,74 real54,25 user 7,07 sys
digest-fix:SHA-512,SHA-256:central-direct
204,89 real47,79 user 6,49 sys
digest-fix:SHA-1,MD5:central-direct
166,66 real42,36 user 6,03 sys
digest-fix:SHA-512:central-direct
164,31 real38,98 user 6,10 sys
digest-fix:SHA-256:central-direct
170,77 real44,77 user 5,79 sys
{noformat}
as well as Maven 3.7.0-SNAPSHOT:
{noformat}
master:SHA-512,SHA-256,SHA-1,MD5:central-direct
271,06 real65,54 user 7,67 sys
master:SHA-512,SHA-256:central-direct
202,95 real60,87 user 6,77 sys
master:SHA-1,MD5:central-direct
163,64 real50,00 user 6,85 sys
master:SHA-512:central-direct
165,11 real50,17 user 6,25 sys
master:SHA-256:central-direct
163,97 real52,24 user 5,81 sys
digest-fix:SHA-512,SHA-256,SHA-1,MD5:central-direct
268,27 real64,90 user
[jira] [Updated] (MPMD-290) CPD ignores the specified language
[ https://issues.apache.org/jira/browse/MPMD-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-290: Fix Version/s: 3.14.0 > CPD ignores the specified language > -- > > Key: MPMD-290 > URL: https://issues.apache.org/jira/browse/MPMD-290 > Project: Maven PMD Plugin > Issue Type: Bug > Components: CPD >Affects Versions: 3.12.0 >Reporter: QualiteSys QualiteSys >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > I wish to analyze C# source code with CPD, with no success > Looking to the CpdReport.java MOJO, it seams that the language is not > extracted from either the pom.xml file or the CLI options. > Line 76 : > @Parameter( defaultValue = "java" ) > private String language; > property = "language" is missing, so the language is always forced to java > Is it possible to fix this bug, and add the missing languages CPD is > supporting ? > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-pmd-plugin] adangel opened a new pull request #32: [MPMD-290] - Add integration test for CPD for C#
adangel opened a new pull request #32: URL: https://github.com/apache/maven-pmd-plugin/pull/32 This PR adds an integration test and also a example configuration in the documentation. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPMD) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPMD-XXX] - Subject of the JIRA Ticket`, where you replace `MPMD-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-294) Add support for setting includes/excludes via a user property
[ https://issues.apache.org/jira/browse/MPMD-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206390#comment-17206390 ] Andreas Dangel commented on MPMD-294: - See [http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#includesFile] and [http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#excludesFile] > Add support for setting includes/excludes via a user property > - > > Key: MPMD-294 > URL: https://issues.apache.org/jira/browse/MPMD-294 > Project: Maven PMD Plugin > Issue Type: New Feature > Components: CPD, PMD >Affects Versions: 3.12.0 >Reporter: Roy Arnon >Priority: Major > > I have a use case were I want to execute pmd on a huge monorepo project, but > only on the changed files. > Getting the changed java files via git is trivial, but it seems that the PMD > plugin does not support setting the includes/excludes by user property. > Can we look into adding a property like maven surefires > includesFile/excludesFile, which will allow us to specify includes/excludes > at runtime? > I may try to prepare a PR for this feature if I have the time. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPMD-290) CPD ignores the specified language
[ https://issues.apache.org/jira/browse/MPMD-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206391#comment-17206391 ] Andreas Dangel commented on MPMD-290: - The PR [https://github.com/apache/maven-pmd-plugin/pull/32] adds an integration test and also a example configuration in the documentation. The original problem is not reproducible. > CPD ignores the specified language > -- > > Key: MPMD-290 > URL: https://issues.apache.org/jira/browse/MPMD-290 > Project: Maven PMD Plugin > Issue Type: Bug > Components: CPD >Affects Versions: 3.12.0 >Reporter: QualiteSys QualiteSys >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > I wish to analyze C# source code with CPD, with no success > Looking to the CpdReport.java MOJO, it seams that the language is not > extracted from either the pom.xml file or the CLI options. > Line 76 : > @Parameter( defaultValue = "java" ) > private String language; > property = "language" is missing, so the language is always forced to java > Is it possible to fix this bug, and add the missing languages CPD is > supporting ? > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARCHETYPE-609) Using common Velocity template breaks with version 3.2.0
[
https://issues.apache.org/jira/browse/ARCHETYPE-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206393#comment-17206393
]
Matthew Compton commented on ARCHETYPE-609:
---
Does anyone know of a work around for this issue so I can continue to use a
shared template file?
> Using common Velocity template breaks with version 3.2.0
>
>
> Key: ARCHETYPE-609
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-609
> Project: Maven Archetype
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.2.0
> Environment: macOS Mojave 10.14.6
>Reporter: Matthew Compton
>Priority: Major
> Attachments: archetype-fail.tar.gz
>
>
> The recently released version 3.2.0 of the Maven Archetype Plugin has broken
> an archetype I created. I have confirmed my archetype still works with
> version 3.1.2 of the plugin but my team and I normally run {{mvn
> archetype:generate ...}} just so we don’t have to specify a particular
> version of the plugin, but now Maven will pick up the 3.2.0 version of the
> plugin and fail. I am aware that using {{mvn
> org.apache.maven.plugins:maven-archetype-plugin:3.1.2:generate ...}} will
> work around the problem, but I’d still like to fix my archetype to work with
> the latest version of the plugin.
> The problem appears to be that something has changed with how the class
> path/resources are setup with the Velocity template engine when rendering
> templates. I tried looking through the release notes but it just looks like
> version numbers were bumped, so I doesn’t seem like this was an intentional
> change in behavior.
> The source of the problem is my archetype has a common
> {{META-INF/common-variable-definitions.vm}} that contains variables that are
> used in multiple files within the archetype. This worked great with earlier
> versions of the archetype plugin, each template that needed the common
> variable definitions simply needed a {{#parse(
> "META-INF/common-variable-definitions.vm”}} ) at the top of the file and then
> all of the usual replacements that were needed are available. Now, with the
> 3.2.0 version of the plugin I get the following error:
> {noformat}
> ...
> [ERROR] ResourceManager : unable to find resource
> 'archetype-resources/META-INF/common-variable-definitions.vm' in any resource
> loader.
> [ERROR] #parse(): cannot find template
> 'archetype-resources/META-INF/common-variable-definitions.vm', called at
> archetype-resources/pom.xml[line 1, column 1]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 1.327 s
> [INFO] Finished at: 2020-08-26T16:28:24-07:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-archetype-plugin:3.2.0:integration-test
> (default-integration-test) on project demo-archetype:
> [ERROR] Archetype IT 'basic' failed: Error merging velocity templates: Unable
> to find resource 'archetype-resources/META-INF/common-variable-definitions.vm'
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException{noformat}
> The issue is that the Velocity engine now expects the common definitions file
> in {{archetype-resources/META-INF}} instead of a top-level {{META-INF}}
> directory. I tried moving the file to
> {{archetype-resources/META-INF/common-variable-definitions.vm}}, but I found
> that only worked for the “first level”, and it essentially expected that file
> to copied into every level of the directory hierarchy of the archetype
> resources that had templates to render, which makes trying to do this totally
> pointless, I might as well copy the definitions into the top of each file
> like I had done in a very early version of my archetype. I also tried using
> “../“ relative paths (like {{#parse(
> “../META-INF/common-variable-definitions.vm” )}}) in files deeper into the
> directory hierarchy to reference back up to a single common velocity
> template, but could not get that to work either.
> Is there something I can do to get this working again with version 3.2.0? Or
> is this no something that is actually supported and I was just getting lucky
> before?
> To help reproduce the problem I created a simple example project to
> demonstrate this chan
[GitHub] [maven-javadoc-plugin] michaelboyles commented on pull request #63: [MJAVADOC-664] - Fix stale javadoc data detection on Windows.
michaelboyles commented on pull request #63: URL: https://github.com/apache/maven-javadoc-plugin/pull/63#issuecomment-702943734 Not a committer, but I think this unlikely to be accepted without a test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRESOLVER-104) maven-resolver-demo-maven-plugin uses reserved groupId
[ https://issues.apache.org/jira/browse/MRESOLVER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MRESOLVER-104: Priority: Minor (was: Major) > maven-resolver-demo-maven-plugin uses reserved groupId > -- > > Key: MRESOLVER-104 > URL: https://issues.apache.org/jira/browse/MRESOLVER-104 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Minor > > [INFO] --- maven-plugin-plugin:3.5.2:descriptor (default-descriptor) @ > maven-resolver-demo-maven-plugin --- > [ERROR] > Artifact Ids of the format maven-___-plugin are reserved for > plugins in the Group Id org.apache.maven.plugins > Please change your artifactId to the format ___-maven-plugin > In the future this error will break the build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-715) Hamcrest used and unused
[ https://issues.apache.org/jira/browse/MDEP-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206526#comment-17206526 ] Elliotte Rusty Harold commented on MDEP-715: A class that exists in two or more dependencies is an error when using Java 9 or later with the Java Platform Module System. From [https://jlbp.dev/JLBP-5] "In Java 9 and later overlapping classes become compile-time and runtime errors when named modules are used. It is critical, especially in Java 9 and later, to remove all but one of the artifacts that contain overlapping classes from the classpath. Generally this requires changing the POMs of multiple Maven artifacts so they no longer include any dependencies on the artifacts you need to remove from your project’s classpath." > Hamcrest used and unused > > > Key: MDEP-715 > URL: https://issues.apache.org/jira/browse/MDEP-715 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: analyze >Reporter: Elliotte Rusty Harold >Priority: Major > Labels: S2, intern > > This is something I've seen when analyzing several Maven plugins. For > example, maven-shared-utils circa July 20, 2020: > > [WARNING] Used undeclared dependencies found: > [WARNING] org.hamcrest:hamcrest:jar:2.2:test > [WARNING] org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M2a:test > [WARNING] Unused declared dependencies found: > [WARNING] org.hamcrest:hamcrest-core:jar:2.2:test > [WARNING] org.apache.maven:maven-core:jar:3.1.0:test > [WARNING] org.codehaus.plexus:plexus-container-default:jar:2.1.0:provided > > Easy fix, right? don't declare org.hamcrest:hamcrest-core:jar:2.2:test and > instead declare org.hamcrest:hamcrest:jar:2.2:test > > But when I do that: > > [WARNING] Used undeclared dependencies found: > [WARNING] org.hamcrest:hamcrest-core:jar:1.3:test > [WARNING] org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M2a:test > [WARNING] Unused declared dependencies found: > [WARNING] org.hamcrest:hamcrest:jar:2.2:test > [WARNING] org.apache.maven:maven-core:jar:3.1.0:test > [WARNING] org.codehaus.plexus:plexus-container-default:jar:2.1.0:provided > > Figure out what's going on here and fix it. Is hamcrest-core needed and used > or not? is hamcrest needed and used or not? Be consistent. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-715) Hamcrest used and unused
[ https://issues.apache.org/jira/browse/MDEP-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206570#comment-17206570 ] Michael Boyles commented on MDEP-715: - I suppose the important bit there is "when named modules are used", which is unfortunate. Plenty of people don't bother with the module system > Hamcrest used and unused > > > Key: MDEP-715 > URL: https://issues.apache.org/jira/browse/MDEP-715 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: analyze >Reporter: Elliotte Rusty Harold >Priority: Major > Labels: S2, intern > > This is something I've seen when analyzing several Maven plugins. For > example, maven-shared-utils circa July 20, 2020: > > [WARNING] Used undeclared dependencies found: > [WARNING] org.hamcrest:hamcrest:jar:2.2:test > [WARNING] org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M2a:test > [WARNING] Unused declared dependencies found: > [WARNING] org.hamcrest:hamcrest-core:jar:2.2:test > [WARNING] org.apache.maven:maven-core:jar:3.1.0:test > [WARNING] org.codehaus.plexus:plexus-container-default:jar:2.1.0:provided > > Easy fix, right? don't declare org.hamcrest:hamcrest-core:jar:2.2:test and > instead declare org.hamcrest:hamcrest:jar:2.2:test > > But when I do that: > > [WARNING] Used undeclared dependencies found: > [WARNING] org.hamcrest:hamcrest-core:jar:1.3:test > [WARNING] org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M2a:test > [WARNING] Unused declared dependencies found: > [WARNING] org.hamcrest:hamcrest:jar:2.2:test > [WARNING] org.apache.maven:maven-core:jar:3.1.0:test > [WARNING] org.codehaus.plexus:plexus-container-default:jar:2.1.0:provided > > Figure out what's going on here and fix it. Is hamcrest-core needed and used > or not? is hamcrest needed and used or not? Be consistent. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
