[GitHub] [maven] maoshuai opened a new pull request #238: using safer shell arguments
maoshuai opened a new pull request #238: using safer shell arguments URL: https://github.com/apache/maven/pull/238 It is safer to use "$@". Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #238: using safer shell arguments
michael-o commented on issue #238: using safer shell arguments URL: https://github.com/apache/maven/pull/238#issuecomment-475939756 Safer in terms of what? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6522) Prepare Maven's Core Integration Test Suite to test with Java 12 and 13-ea
[ https://issues.apache.org/jira/browse/MNG-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799950#comment-16799950 ] Hudson commented on MNG-6522: - Build succeeded in Jenkins: Maven TLP » maven » runITsWithJavaEA #24 See https://builds.apache.org/job/maven-box/job/maven/job/runITsWithJavaEA/24/ > Prepare Maven's Core Integration Test Suite to test with Java 12 and 13-ea > -- > > Key: MNG-6522 > URL: https://issues.apache.org/jira/browse/MNG-6522 > Project: Maven > Issue Type: Improvement > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > > * JDK 12 Windows and Linux (/) > - JDK 13 Window and Linux (/) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6572) use int or long instead of BigIntegers for little numbers in ComparableVersion
[
https://issues.apache.org/jira/browse/MNG-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799948#comment-16799948
]
Hudson commented on MNG-6572:
-
Build succeeded in Jenkins: Maven TLP » maven » runITsWithJavaEA #24
See https://builds.apache.org/job/maven-box/job/maven/job/runITsWithJavaEA/24/
> use int or long instead of BigIntegers for little numbers in ComparableVersion
> --
>
> Key: MNG-6572
> URL: https://issues.apache.org/jira/browse/MNG-6572
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories, Performance
>Affects Versions: 3.6.0
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> while working on MNG-6571, we found that this could enhance performance when
> many versions are compared: perhaps not in Maven builds, since this is
> probably negligible, but in other scenario where version comparison is used,
> this could be useful
> see
> https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
> for every Integer, a BigInteger is currently used
> but for integer that have less than 10 digits, an int would be sufficient and
> would be a lot more efficient
> and for integers that are less than 19 digits, a long would be the way to go
> the biggest numbers we get usually is the timestamp of a SNAPSHOT, like
> {{20171015.230843}} (MMDD.HHmmss), then an int will be sufficient in the
> vast majority of case
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-resolver] michael-o commented on issue #10: [MRESOLVER-7] Download dependency POMs in parallel v2
michael-o commented on issue #10: [MRESOLVER-7] Download dependency POMs in parallel v2 URL: https://github.com/apache/maven-resolver/pull/10#issuecomment-475939824 @hwellmann, why is #30 necessary for this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition
[
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799951#comment-16799951
]
Hudson commented on MNG-6613:
-
Build succeeded in Jenkins: Maven TLP » maven » runITsWithJavaEA #24
See https://builds.apache.org/job/maven-box/job/maven/job/runITsWithJavaEA/24/
> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached
> log file. Even switching {{!maven-core-it,*}} makes no difference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6538) Upgrade Maven Artifact Resolver to 1.3.3 to restore API
[ https://issues.apache.org/jira/browse/MNG-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799949#comment-16799949 ] Hudson commented on MNG-6538: - Build succeeded in Jenkins: Maven TLP » maven » runITsWithJavaEA #24 See https://builds.apache.org/job/maven-box/job/maven/job/runITsWithJavaEA/24/ > Upgrade Maven Artifact Resolver to 1.3.3 to restore API > --- > > Key: MNG-6538 > URL: https://issues.apache.org/jira/browse/MNG-6538 > Project: Maven > Issue Type: Task > Components: Embedding >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.6.1 > > > IntelliJ IDEA Maven integration was broken by API removal done in MRESOLVER-36 > the missing API was added back (with empty implementation) in MRESOLVER-64 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven] maoshuai commented on issue #238: using safer shell arguments
maoshuai commented on issue #238: using safer shell arguments URL: https://github.com/apache/maven/pull/238#issuecomment-475942541 > Safer in terms of what? Say if I pass an parameter with space `deploySite.sh "foo bar"`, which is ONE parameter. But from the POV of `$@`, it will be interpreted as TWO parameters. Additionally, If I pass a parameter with asterisk, it may be variable expanded. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6600) add input location tracking for default lifecycle bindings executions
[ https://issues.apache.org/jira/browse/MNG-6600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799971#comment-16799971 ] Hudson commented on MNG-6600: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6538 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6538/2/ > add input location tracking for default lifecycle bindings executions > - > > Key: MNG-6600 > URL: https://issues.apache.org/jira/browse/MNG-6600 > Project: Maven > Issue Type: Improvement > Components: Inheritance and Interpolation >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Major > Fix For: 3.6.1 > > > working on MPH-160 > default lifecycle bindings injections adds executions with "default-" > id, but does not add any input location tracking > adding > "org.apache.maven:maven-core::default-lifecycle-bindings" > modelId will ease understanding where this comes from -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6597) add input location tracking for plugins configuration
[ https://issues.apache.org/jira/browse/MNG-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799972#comment-16799972 ] Hudson commented on MNG-6597: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6538 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6538/2/ > add input location tracking for plugins configuration > - > > Key: MNG-6597 > URL: https://issues.apache.org/jira/browse/MNG-6597 > Project: Maven > Issue Type: Improvement > Components: Inheritance and Interpolation >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Major > Fix For: 3.6.1 > > > while working on input location display in verbose help:effedctive-pom (see > MPH-160), I found that input location was not tracked for plugins > configuration, ie XPP3 DOM > neet to add this tracking, which requires: > # a newer plexus-utils 3.2.0 version for > [https://github.com/codehaus-plexus/plexus-utils/issues/61] > # a newer Modello 1.10.0 version for > [https://github.com/codehaus-plexus/modello/issues/29] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6572) use int or long instead of BigIntegers for little numbers in ComparableVersion
[
https://issues.apache.org/jira/browse/MNG-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799974#comment-16799974
]
Hudson commented on MNG-6572:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-6538 #2
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6538/2/
> use int or long instead of BigIntegers for little numbers in ComparableVersion
> --
>
> Key: MNG-6572
> URL: https://issues.apache.org/jira/browse/MNG-6572
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories, Performance
>Affects Versions: 3.6.0
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> while working on MNG-6571, we found that this could enhance performance when
> many versions are compared: perhaps not in Maven builds, since this is
> probably negligible, but in other scenario where version comparison is used,
> this could be useful
> see
> https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
> for every Integer, a BigInteger is currently used
> but for integer that have less than 10 digits, an int would be sufficient and
> would be a lot more efficient
> and for integers that are less than 19 digits, a long would be the way to go
> the biggest numbers we get usually is the timestamp of a SNAPSHOT, like
> {{20171015.230843}} (MMDD.HHmmss), then an int will be sufficient in the
> vast majority of case
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6601) add input location tracking for site's reportPlugins injected by reports conversion
[ https://issues.apache.org/jira/browse/MNG-6601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799973#comment-16799973 ] Hudson commented on MNG-6601: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6538 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6538/2/ > add input location tracking for site's reportPlugins injected by reports > conversion > --- > > Key: MNG-6601 > URL: https://issues.apache.org/jira/browse/MNG-6601 > Project: Maven > Issue Type: Improvement > Components: Inheritance and Interpolation >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Major > Fix For: 3.6.1 > > > working on MPH-160 > there is no explanation for site's reportPlugins injected by [reports > conversion to decoupled site > plugin|https://maven.apache.org/ref/3.6.0/maven-model-builder/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6538) Upgrade Maven Artifact Resolver to 1.3.3 to restore API
[ https://issues.apache.org/jira/browse/MNG-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799975#comment-16799975 ] Hudson commented on MNG-6538: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6538 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6538/2/ > Upgrade Maven Artifact Resolver to 1.3.3 to restore API > --- > > Key: MNG-6538 > URL: https://issues.apache.org/jira/browse/MNG-6538 > Project: Maven > Issue Type: Task > Components: Embedding >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.6.1 > > > IntelliJ IDEA Maven integration was broken by API removal done in MRESOLVER-36 > the missing API was added back (with empty implementation) in MRESOLVER-64 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6599) unknown version in model id when version is defined from parent
[
https://issues.apache.org/jira/browse/MNG-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799970#comment-16799970
]
Hudson commented on MNG-6599:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-6538 #2
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6538/2/
> unknown version in model id when version is defined from parent
> ---
>
> Key: MNG-6599
> URL: https://issues.apache.org/jira/browse/MNG-6599
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Affects Versions: 3.6.0
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.1
>
>
> working on MPH-160 limitation
> bq. parent POM version is not recognized, leading to suboptimal output ""
> if we look at this pom:
> {code:xml}
>
> org.apache.maven
> maven-parent
> 33
>
> org.apache.maven.plugins
> maven-plugins
> pom
> ...{code}
> the fact that version is not defined as project.version but should be
> extrapolated from project.parent.version seems to cause the issue in model id
> calculation for input source tracking
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-resolver] hwellmann commented on issue #10: [MRESOLVER-7] Download dependency POMs in parallel v2
hwellmann commented on issue #10: [MRESOLVER-7] Download dependency POMs in parallel v2 URL: https://github.com/apache/maven-resolver/pull/10#issuecomment-475948564 It fixes the failing test org.apache.maven.project.inheritance.t06.ProjectInheritanceTest observed by @slachiewicz in October 2018 as well as some failing tests from maven-integration-testing when using a build of Maven with this verion of Maven Resolver. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-scm-publish-plugin] olamy commented on issue #5: [MSCMPUB-41] Add the ability to deploy into SCM sub-directory
olamy commented on issue #5: [MSCMPUB-41] Add the ability to deploy into SCM sub-directory URL: https://github.com/apache/maven-scm-publish-plugin/pull/5#issuecomment-475948708 @hboutemy ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9
[
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1688#comment-1688
]
Andreas Veithen commented on MNG-6506:
--
I'll give it a try.
> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
> Issue Type: Bug
> Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.1
>
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from
> within a Mojo always return {{null}} (unless the {{package-info}} class has
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws
> {{ClassNotFoundException}}:
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026&view=rev.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6538) Upgrade Maven Artifact Resolver to 1.3.3 to restore API
[ https://issues.apache.org/jira/browse/MNG-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800038#comment-16800038 ] Hudson commented on MNG-6538: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6538 #3 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6538/3/ > Upgrade Maven Artifact Resolver to 1.3.3 to restore API > --- > > Key: MNG-6538 > URL: https://issues.apache.org/jira/browse/MNG-6538 > Project: Maven > Issue Type: Task > Components: Embedding >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.6.1 > > > IntelliJ IDEA Maven integration was broken by API removal done in MRESOLVER-36 > the missing API was added back (with empty implementation) in MRESOLVER-64 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-integration-testing] veithen opened a new pull request #43: Add regression test for MNG-6506
veithen opened a new pull request #43: Add regression test for MNG-6506 URL: https://github.com/apache/maven-integration-testing/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9
[
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800053#comment-16800053
]
Andreas Veithen commented on MNG-6506:
--
Done: https://github.com/apache/maven-integration-testing/pull/43
> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
> Issue Type: Bug
> Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from
> within a Mojo always return {{null}} (unless the {{package-info}} class has
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws
> {{ClassNotFoundException}}:
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026&view=rev.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-integration-testing] eolivelli commented on a change in pull request #43: Add regression test for MNG-6506
eolivelli commented on a change in pull request #43: Add regression test for
MNG-6506
URL:
https://github.com/apache/maven-integration-testing/pull/43#discussion_r268446307
##
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6506PackageAnnotationTest.java
##
@@ -0,0 +1,56 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+public class MavenITmng6506PackageAnnotationTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng6506PackageAnnotationTest()
+{
+super( "[3.6.1,)" );
+}
+
+public void testGetPackageAnnotation()
+throws Exception
+{
+File testDir =
+ResourceExtractor.simpleExtractResources( getClass(),
+
"/mng-6506-package-annotation" );
+File pluginDir = new File( testDir, "plugin" );
+File projectDir = new File( testDir, "project" );
+
+Verifier verifier;
+
+verifier = newVerifier( pluginDir.getAbsolutePath(), "remote" );
+verifier.executeGoal( "install" );
+verifier.resetStreams();
+verifier.verifyErrorFreeLog();
+
+verifier = newVerifier( projectDir.getAbsolutePath(), "remote" );
+verifier.executeGoal( "verify" );
+verifier.resetStreams();
+verifier.verifyErrorFreeLog();
Review comment:
Maybe we could add a more narrow assertion, like printing something in the
test case and then checking that the output contains such text
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (SUREFIRE-1653) Maven sure fire report skip count issue
atul hake created SUREFIRE-1653: --- Summary: Maven sure fire report skip count issue Key: SUREFIRE-1653 URL: https://issues.apache.org/jira/browse/SUREFIRE-1653 Project: Maven Surefire Issue Type: Bug Components: Maven Surefire Report Plugin Affects Versions: 3.0.0-M3 Environment: Windows 10 Reporter: atul hake Attachments: TestListenerAdapter, pom.xml I am re running failed TC using IRetryAnalyzer. If i have 3 TC . 1st pass 2nd fail..retried.again fail. so run count is 3 , pass=1,fail =1 , skip =1. Its correct. now i want to remove skip count from report so i have written code at OnFinish method [see attachmen] to remove skip count...so individual Test- .xml [Target/junitreport] does not contain any skip count. but final Test-Testsuit.xml [target] contains skip count . which is obstacle. Have look at video : https://www.screencast.com/t/JXOx5Qko what is the way to remove skip count from final Test-Testsuit.xml ? is it any version issue? [i want to remove skip count because it disturbing success percentage of report -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MNG-6538) Upgrade Maven Artifact Resolver to 1.3.3 to restore API
[ https://issues.apache.org/jira/browse/MNG-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-6538. Resolution: Done > Upgrade Maven Artifact Resolver to 1.3.3 to restore API > --- > > Key: MNG-6538 > URL: https://issues.apache.org/jira/browse/MNG-6538 > Project: Maven > Issue Type: Task > Components: Embedding >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.6.1 > > > IntelliJ IDEA Maven integration was broken by API removal done in MRESOLVER-36 > the missing API was added back (with empty implementation) in MRESOLVER-64 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6538) Upgrade Maven Artifact Resolver to 1.3.3 to restore API
[ https://issues.apache.org/jira/browse/MNG-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800179#comment-16800179 ] Karl Heinz Marbaise commented on MNG-6538: -- Done in [0be26449fb96774be126a6ad245d1a98dc71907c|https://gitbox.apache.org/repos/asf?p=maven.git;a=commitdiff;h=0be26449fb96774be126a6ad245d1a98dc71907c] > Upgrade Maven Artifact Resolver to 1.3.3 to restore API > --- > > Key: MNG-6538 > URL: https://issues.apache.org/jira/browse/MNG-6538 > Project: Maven > Issue Type: Task > Components: Embedding >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.6.1 > > > IntelliJ IDEA Maven integration was broken by API removal done in MRESOLVER-36 > the missing API was added back (with empty implementation) in MRESOLVER-64 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-integration-testing] veithen commented on a change in pull request #43: Add regression test for MNG-6506
veithen commented on a change in pull request #43: Add regression test for
MNG-6506
URL:
https://github.com/apache/maven-integration-testing/pull/43#discussion_r268455622
##
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6506PackageAnnotationTest.java
##
@@ -0,0 +1,56 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+public class MavenITmng6506PackageAnnotationTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng6506PackageAnnotationTest()
+{
+super( "[3.6.1,)" );
+}
+
+public void testGetPackageAnnotation()
+throws Exception
+{
+File testDir =
+ResourceExtractor.simpleExtractResources( getClass(),
+
"/mng-6506-package-annotation" );
+File pluginDir = new File( testDir, "plugin" );
+File projectDir = new File( testDir, "project" );
+
+Verifier verifier;
+
+verifier = newVerifier( pluginDir.getAbsolutePath(), "remote" );
+verifier.executeGoal( "install" );
+verifier.resetStreams();
+verifier.verifyErrorFreeLog();
+
+verifier = newVerifier( projectDir.getAbsolutePath(), "remote" );
+verifier.executeGoal( "verify" );
+verifier.resetStreams();
+verifier.verifyErrorFreeLog();
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (SUREFIRE-1587) Forked execution prevents correct ServerSocket closing
[
https://issues.apache.org/jira/browse/SUREFIRE-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800194#comment-16800194
]
Tibor Digana commented on SUREFIRE-1587:
[~languitar]
How did you resolve this issue after 5 months?
If the issue still exists, pls send an email to with a question to Apache Maven
Users .
Thx
> Forked execution prevents correct ServerSocket closing
> --
>
> Key: SUREFIRE-1587
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1587
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.22.1
> Environment: Linux, problem becomes visible on archlinux and also on
> Travis CI
>Reporter: Johannes Wienke
>Assignee: Tibor Digana
>Priority: Major
>
> The default mode of forked unit test execution (with JUnit) seems to
> interfere with socket operations. In our case, we see that with a surefire
> execution in forked mode, ServerSocket instances, despite returning from a
> close() call, are sometimes not correctly closed and a subsequent try to
> acquire a server socket on the same port then fails. This does not happen
> outside of surefire or when forkMode is set to none.
> Here is a simple test case to try this. First the maven project pom.xml:
> {code:title=pom.xml|borderStyle=solid}
>
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> testing
> testit
> 1.0-SNAPSHOT
> testit
> A simple testit.
> http://www.example.com
>
> UTF-8
> 1.7
> 1.7
>
>
>
> junit
> junit
> 4.11
> test
>
>
>
>
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.22.1
>
>
>
>
> {code}
> And here a test file to be placed into the test source tree:
> {code:title=AppTest.java|borderStyle=solid}
> package testing;
> import org.junit.Test;
> import java.net.ServerSocket;
> public class AppTest {
> @Test
> public void testSocketStuff() throws Exception {
> while (true) {
> System.out.println("Iteration");
> final ServerSocket socket = new ServerSocket(55444);
> socket.close();
> }
> }
> }
> {code}
> Executing this with the default options (forking mode enabled) will pretty
> soon end up in the following exception after some iterations:
> {code}
> [ERROR] testSocketStuff(testing.AppTest) Time elapsed: 1.376 s <<< ERROR!
> java.net.BindException: Address already in use (Bind failed)
> at testing.AppTest.testSocketStuff(AppTest.java:17)
> {code}
> Executing the same test with -DforkMode=none does not result in this failure
> and the loop runs endlessly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1587) Forked execution prevents correct ServerSocket closing
[
https://issues.apache.org/jira/browse/SUREFIRE-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800194#comment-16800194
]
Tibor Digana edited comment on SUREFIRE-1587 at 3/24/19 11:02 PM:
--
[~languitar]
How did you resolve this issue after 5 months?
If the issue still exists, pls send an email with a question to Apache Maven
Users .
Thx
was (Author: tibor17):
[~languitar]
How did you resolve this issue after 5 months?
If the issue still exists, pls send an email to with a question to Apache Maven
Users .
Thx
> Forked execution prevents correct ServerSocket closing
> --
>
> Key: SUREFIRE-1587
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1587
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.22.1
> Environment: Linux, problem becomes visible on archlinux and also on
> Travis CI
>Reporter: Johannes Wienke
>Assignee: Tibor Digana
>Priority: Major
>
> The default mode of forked unit test execution (with JUnit) seems to
> interfere with socket operations. In our case, we see that with a surefire
> execution in forked mode, ServerSocket instances, despite returning from a
> close() call, are sometimes not correctly closed and a subsequent try to
> acquire a server socket on the same port then fails. This does not happen
> outside of surefire or when forkMode is set to none.
> Here is a simple test case to try this. First the maven project pom.xml:
> {code:title=pom.xml|borderStyle=solid}
>
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> testing
> testit
> 1.0-SNAPSHOT
> testit
> A simple testit.
> http://www.example.com
>
> UTF-8
> 1.7
> 1.7
>
>
>
> junit
> junit
> 4.11
> test
>
>
>
>
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.22.1
>
>
>
>
> {code}
> And here a test file to be placed into the test source tree:
> {code:title=AppTest.java|borderStyle=solid}
> package testing;
> import org.junit.Test;
> import java.net.ServerSocket;
> public class AppTest {
> @Test
> public void testSocketStuff() throws Exception {
> while (true) {
> System.out.println("Iteration");
> final ServerSocket socket = new ServerSocket(55444);
> socket.close();
> }
> }
> }
> {code}
> Executing this with the default options (forking mode enabled) will pretty
> soon end up in the following exception after some iterations:
> {code}
> [ERROR] testSocketStuff(testing.AppTest) Time elapsed: 1.376 s <<< ERROR!
> java.net.BindException: Address already in use (Bind failed)
> at testing.AppTest.testSocketStuff(AppTest.java:17)
> {code}
> Executing the same test with -DforkMode=none does not result in this failure
> and the loop runs endlessly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SUREFIRE-1654) Remove deprecated parameter 'forkMode' and use only 'forkCount'
Tibor Digana created SUREFIRE-1654: -- Summary: Remove deprecated parameter 'forkMode' and use only 'forkCount' Key: SUREFIRE-1654 URL: https://issues.apache.org/jira/browse/SUREFIRE-1654 Project: Maven Surefire Issue Type: Dependency upgrade Components: Maven Failsafe Plugin, Maven Surefire Plugin, process forking Reporter: Tibor Digana Fix For: 3.0.0-M6 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6538) Upgrade Maven Artifact Resolver to 1.3.3 to restore API
[ https://issues.apache.org/jira/browse/MNG-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800211#comment-16800211 ] Hudson commented on MNG-6538: - Build succeeded in Jenkins: Maven TLP » maven » master #184 See https://builds.apache.org/job/maven-box/job/maven/job/master/184/ > Upgrade Maven Artifact Resolver to 1.3.3 to restore API > --- > > Key: MNG-6538 > URL: https://issues.apache.org/jira/browse/MNG-6538 > Project: Maven > Issue Type: Task > Components: Embedding >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.6.1 > > > IntelliJ IDEA Maven integration was broken by API removal done in MRESOLVER-36 > the missing API was added back (with empty implementation) in MRESOLVER-64 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
