[jira] [Commented] (WAGON-537) Maven transfer speed of large artifacts is slow due to unsuitable buffer strategy
[ https://issues.apache.org/jira/browse/WAGON-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735547#comment-16735547 ] Olaf Otto commented on WAGON-537: - Thanks [~michael-o]! My hypothesis is that when maven is executed on a *nix derivate (Linux / Mac...), the costs of java.io.Printstream.print(...) to the console can besignificantly lower than on windows, thus this change does not contribute much to the download speed, as it is already almost optimal. However, it the change may still reduce CPU usage due to the reduced number of calls. I'll try and test this on a *nix machine as soon as I have some time. > Maven transfer speed of large artifacts is slow due to unsuitable buffer > strategy > - > > Key: WAGON-537 > URL: https://issues.apache.org/jira/browse/WAGON-537 > Project: Maven Wagon > Issue Type: Improvement > Components: wagon-http, wagon-provider-api >Affects Versions: 3.2.0 > Environment: Windows 10, JDK 1.8, Nexus Artifact store > 100MB/s > network connection. >Reporter: Olaf Otto >Assignee: Michael Osipov >Priority: Major > Labels: perfomance > Fix For: 3.3.0, 3.3.1 > > Attachments: wagon-issue.png > > > We are using maven for build process automation with docker. This sometimes > involves uploading and downloading artifacts with a few gigabytes in size. > Here, maven's transfer speed is consistently and reproducibly slow. For > instance, an artifact with 7,5 GB in size took almost two hours to transfer > in spite of a 100 MB/s connection with respective reproducible download speed > from the remote nexus artifact repository when using a browser to download. > The same is true when uploding such an artifact. > I have investigated the issue using JProfiler. The result shows an issue in > AbstractWagon's transfer( Resource resource, InputStream input, OutputStream > output, int requestType, long maxSize ) method used for remote artifacts and > the same issue in AbstractHttpClientWagon#writeTo(OutputStream). > Here, the input stream is read in a loop using a 4 Kb buffer. Whenever data > is received, the received data is pushed to downstream listeners via > fireTransferProgress. These listeners (or rather consumers) perform expensive > tasks. > Now, the underlying InputStream implementation used in transfer will return > calls to read(buffer, offset, length) as soon as *some* data is available. > That is, fireTransferProgress may well be invoked with an average number of > bytes less than half the buffer capacity (this varies with the underlying > network and hardware architecture). Consequently, fireTransferProgress is > invoked *millions of times* for large files. As this is a blocking operation, > the time spent in fireTransferProgress dominates and drastically slows down > the transfers by at least one order of magnitude. > !wagon-issue.png! > In our case, we found download speed reduced from a theoretical optimum of > ~80 seconds to to more than 3200 seconds. > From an architectural perspective, I would not want to make the consumers / > listeners invoked via fireTransferProgress aware of their potential impact on > download speed, but rather refactor the transfer method such that it uses a > buffer strategy reducing the the number of fireTransferProgress invocations. > This should be done with regard to the expected file size of the transfer, > such that fireTransferProgress is invoked often enough but not to frequent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6548) Lifecycle plugin version upgrades
[ https://issues.apache.org/jira/browse/MNG-6548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6548: Description: Regular plugin upgrades to absorb changes if plugin version is not specified in the client POM. ||groupId||artifactId||[previous version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target version|| |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| was: Regular plugin update to absorb changes if plugin version is not specified in the client POM. ||groupId||artifactId||[previous version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target version|| |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| > Lifecycle plugin version upgrades > - > > Key: MNG-6548 > URL: https://issues.apache.org/jira/browse/MNG-6548 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.6.x-candidate > > > Regular plugin upgrades to absorb changes if plugin version is not specified > in the client POM. > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6548) Lifecycle plugin version upgrades
[ https://issues.apache.org/jira/browse/MNG-6548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6548: Summary: Lifecycle plugin version upgrades (was: Lifecycle plugin version updates) > Lifecycle plugin version upgrades > - > > Key: MNG-6548 > URL: https://issues.apache.org/jira/browse/MNG-6548 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.6.x-candidate > > > Regular plugin update to absorb changes if plugin version is not specified in > the client POM. > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MNG-6169) Packaging plugin bindings version updates
[ https://issues.apache.org/jira/browse/MNG-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735544#comment-16735544 ] Hervé Boutemy edited comment on MNG-6169 at 1/7/19 8:28 AM: [~hboutemy], there fore I have split to accomondate this issue. The failures require futher investigation. I want to merge MNG-6548 only into 3.6.1. I have reassigned this one. was (Author: michael-o): [~hboutemy], there fore I have split to accomondate this issue. The failures require futher investigation. I want to merge MNG.6548 only into 3.6.1. I have reassigned this one. > Packaging plugin bindings version updates > - > > Key: MNG-6169 > URL: https://issues.apache.org/jira/browse/MNG-6169 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.3.9 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: Issues to be reviewed for 3.x > > > Regular plugin update to absorb changes if plugin version is not specified in > the client POM. > ||groupId||artifactId||[previous > version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.6| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| > |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2| > |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1| > |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| > |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2| > |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (api 3.0+)| > |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0| > |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0| > |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1| > |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (?)| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6169) Packaging plugin bindings version updates
[ https://issues.apache.org/jira/browse/MNG-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735571#comment-16735571 ] Hervé Boutemy commented on MNG-6169: [~michael-o] thank you Michael: this MNG-6548's type should then be turned into Bug, and the fixes expected from these 2 plugins updates should be written down, isn't it? > Packaging plugin bindings version updates > - > > Key: MNG-6169 > URL: https://issues.apache.org/jira/browse/MNG-6169 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.3.9 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: Issues to be reviewed for 3.x > > > Regular plugin update to absorb changes if plugin version is not specified in > the client POM. > ||groupId||artifactId||[previous > version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.6| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| > |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2| > |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1| > |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| > |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2| > |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (api 3.0+)| > |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0| > |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0| > |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1| > |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (?)| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6548) Lifecycle plugin version upgrades
[ https://issues.apache.org/jira/browse/MNG-6548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735587#comment-16735587 ] Hudson commented on MNG-6548: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6548 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6548/2/ > Lifecycle plugin version upgrades > - > > Key: MNG-6548 > URL: https://issues.apache.org/jira/browse/MNG-6548 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.6.x-candidate > > > Regular plugin upgrades to absorb changes if plugin version is not specified > in the client POM. > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6169) Packaging plugin bindings version updates
[ https://issues.apache.org/jira/browse/MNG-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735667#comment-16735667 ] Sylwester Lachiewicz commented on MNG-6169: --- I found in MDEP-82 that if some plugins depend on 2.x then go-offline may not work correctly due to excluding old wagon provider in org.apache.maven.plugin.internal.PluginDependencyResolutionListener#isWagonProvider. I have created a patch for the jacoco plugin to migrate to 3.0+ and issue no longer appears. > Packaging plugin bindings version updates > - > > Key: MNG-6169 > URL: https://issues.apache.org/jira/browse/MNG-6169 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.3.9 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: Issues to be reviewed for 3.x > > > Regular plugin update to absorb changes if plugin version is not specified in > the client POM. > ||groupId||artifactId||[previous > version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.6| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| > |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2| > |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1| > |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| > |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2| > |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (api 3.0+)| > |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0| > |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0| > |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1| > |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (?)| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6169) Packaging plugin bindings version updates
[ https://issues.apache.org/jira/browse/MNG-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6169: -- Description: Regular plugin update to absorb changes if plugin version is not specified in the client POM. ||groupId||artifactId||[previous version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target version|| |-org.apache.maven.plugins-|-maven-clean-plugin-|-2.5-|MNG-6548| |-org.apache.maven.plugins-|-maven-site-plugin-|-3.3-|MNG-6548| |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2| |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1| |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2| |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (already 3.0+)| |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0| |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0| |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1| |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (needs 3.0 release (!))| was: Regular plugin update to absorb changes if plugin version is not specified in the client POM. ||groupId||artifactId||[previous version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target version|| |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| |org.apache.maven.plugins|maven-site-plugin|3.3|3.6| |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2| |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1| |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2| |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (api 3.0+)| |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0| |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0| |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1| |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (?)| > Packaging plugin bindings version updates > - > > Key: MNG-6169 > URL: https://issues.apache.org/jira/browse/MNG-6169 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.3.9 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: Issues to be reviewed for 3.x > > > Regular plugin update to absorb changes if plugin version is not specified in > the client POM. > ||groupId||artifactId||[previous > version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target > version|| > |-org.apache.maven.plugins-|-maven-clean-plugin-|-2.5-|MNG-6548| > |-org.apache.maven.plugins-|-maven-site-plugin-|-3.3-|MNG-6548| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| > |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2| > |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1| > |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| > |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2| > |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (already 3.0+)| > |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0| > |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0| > |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1| > |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (needs 3.0 release (!))| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] asfgit closed pull request #227: [MNG-6520] Update namespaces for maven-assembly to 2.0.0
asfgit closed pull request #227: [MNG-6520] Update namespaces for maven-assembly to 2.0.0 URL: https://github.com/apache/maven/pull/227 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/apache-maven/src/main/assembly/bin.xml b/apache-maven/src/main/assembly/bin.xml index 79723c2a78..a04557d506 100644 --- a/apache-maven/src/main/assembly/bin.xml +++ b/apache-maven/src/main/assembly/bin.xml @@ -17,8 +17,8 @@ specific language governing permissions and limitations under the License. --> -http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd";> +http://maven.apache.org/ASSEMBLY/2.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd";> bin zip diff --git a/apache-maven/src/main/assembly/component.xml b/apache-maven/src/main/assembly/component.xml index 7b05af7c71..56b3f0b65f 100644 --- a/apache-maven/src/main/assembly/component.xml +++ b/apache-maven/src/main/assembly/component.xml @@ -16,8 +16,8 @@ KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -http://maven.apache.org/plugins/maven-assembly-plugin/component/1.1.3"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/component/1.1.3 http://maven.apache.org/xsd/component-1.1.3.xsd";> +http://maven.apache.org/ASSEMBLY-COMPONENT/2.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/ASSEMBLY-COMPONENT/2.0.0 http://maven.apache.org/xsd/assembly-component-2.0.0.xsd";> false diff --git a/apache-maven/src/main/assembly/dir.xml b/apache-maven/src/main/assembly/dir.xml index 0d2b88764e..580b2098d6 100644 --- a/apache-maven/src/main/assembly/dir.xml +++ b/apache-maven/src/main/assembly/dir.xml @@ -17,8 +17,8 @@ specific language governing permissions and limitations under the License. --> -http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd";> +http://maven.apache.org/ASSEMBLY/2.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd";> dir dir diff --git a/apache-maven/src/main/assembly/src.xml b/apache-maven/src/main/assembly/src.xml index fb0aee8153..327ed52d25 100644 --- a/apache-maven/src/main/assembly/src.xml +++ b/apache-maven/src/main/assembly/src.xml @@ -17,8 +17,8 @@ specific language governing permissions and limitations under the License. --> -http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd";> +http://maven.apache.org/ASSEMBLY/2.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd";> src zip This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6520) Update assembly descriptors to 2.0.0
[ https://issues.apache.org/jira/browse/MNG-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735688#comment-16735688 ] Sylwester Lachiewicz commented on MNG-6520: --- Done in [eab62f169daba7d3f1f0b1af49b0137f4fa9e8e1|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=eab62f169daba7d3f1f0b1af49b0137f4fa9e8e1] > Update assembly descriptors to 2.0.0 > > > Key: MNG-6520 > URL: https://issues.apache.org/jira/browse/MNG-6520 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Update namespaces to the version compatible with 3.0+ maven-assembly-plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-469) javadoc-plugin does not double backslashes in argument file
[
https://issues.apache.org/jira/browse/MJAVADOC-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735704#comment-16735704
]
Thorsten Schöning commented on MJAVADOC-469:
There's an answer linking to some good docs:
https://mail.openjdk.java.net/pipermail/javadoc-dev/2019-January/000779.html
> Because backslash (\) is an escape character, a backslash character must be
> escaped with another backslash character.
https://docs.oracle.com/en/java/javase/11/tools/java.html#GUID-4856361B-8BFD-4964-AE84-121F5F6CF111
> Support for @-files in javac, javadoc, javah aligned with launcher support
https://www.oracle.com/technetwork/java/javase/9-notes-3745703.html#JDK-8162810
So, escaping backslashes in general is the correct thing to do, but one needs
to keep in mind additional definitions for Javadoc itself, like "\:" for tag
names. So I suggest keeping my approach by escaping what we really know needs
to be escaped and further improve as necessary.
> javadoc-plugin does not double backslashes in argument file
> ---
>
> Key: MJAVADOC-469
> URL: https://issues.apache.org/jira/browse/MJAVADOC-469
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 2.10.4
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
>
> On Windows `generate-rest-docs` goal of `maven-jira-plugin` calls
> `maven-javadoc-plugin` with:
> {code}additionalparam: -output
> "C:\path\to\target\classes\resourcedoc.xml"{code}
> If this argument was passed to `javadoc.exe` directly, I'm pretty sure this
> would work. However, the javadoc plugin generates an argument file[1] named
> "options" and executes:
> {code}javadoc.exe ... @options{code}
> The file contains all arguments with unescaped backslashes, although javadoc
> command documentation[2] suggests:
> {quote}If a filename contains embedded spaces, put the whole filename in
> double quotes, and double each backslash ("My Files\\Stuff.java"){quote}
> javadoc plugin version "2.4" is hardcoded in jira plugin, but I see no
> related changes in "2.10.4" in AbstractJavadocMojo.addCommandLineOptions() .
> [1]: https://maven.apache.org/plugins/maven-javadoc-plugin/
> [2]:
> http://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#argumentfiles
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6520) Update assembly descriptors to 2.0.0
[ https://issues.apache.org/jira/browse/MNG-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735711#comment-16735711 ] Hudson commented on MNG-6520: - Build succeeded in Jenkins: Maven TLP » maven » master #124 See https://builds.apache.org/job/maven-box/job/maven/job/master/124/ > Update assembly descriptors to 2.0.0 > > > Key: MNG-6520 > URL: https://issues.apache.org/jira/browse/MNG-6520 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Update namespaces to the version compatible with 3.0+ maven-assembly-plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6548) Lifecycle plugin version upgrades
[ https://issues.apache.org/jira/browse/MNG-6548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735752#comment-16735752 ] Michael Osipov commented on MNG-6548: - [~rfscholte], this is a small subset as before. ITs pass on several OSes here. Are we good to merge this one into 3.6.1? > Lifecycle plugin version upgrades > - > > Key: MNG-6548 > URL: https://issues.apache.org/jira/browse/MNG-6548 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.6.x-candidate > > > Regular plugin upgrades to absorb changes if plugin version is not specified > in the client POM. > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MNG-6520) Update assembly descriptors to 2.0.0
[ https://issues.apache.org/jira/browse/MNG-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-6520. - Resolution: Fixed > Update assembly descriptors to 2.0.0 > > > Key: MNG-6520 > URL: https://issues.apache.org/jira/browse/MNG-6520 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Update namespaces to the version compatible with 3.0+ maven-assembly-plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6169) Packaging plugin bindings version updates
[
https://issues.apache.org/jira/browse/MNG-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735762#comment-16735762
]
Michael Osipov commented on MNG-6169:
-
[~hboutemy], not it is not a bug. It is only about {{components.xml}}. There
is not failure triggered in our ITs for this case. I have chosen to split this
into several issues to better track failures on our side. MNG-6548 looks good
to merge to me.
[~slachiewicz] thanks for checking. I will spawn more tickets as soon as I find
more stuff.
> Packaging plugin bindings version updates
> -
>
> Key: MNG-6169
> URL: https://issues.apache.org/jira/browse/MNG-6169
> Project: Maven
> Issue Type: Improvement
> Components: core, Dependencies
>Affects Versions: 3.3.9
>Reporter: Christian Schulte
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Issues to be reviewed for 3.x
>
>
> Regular plugin update to absorb changes if plugin version is not specified in
> the client POM.
> ||groupId||artifactId||[previous
> version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target
> version||
> |-org.apache.maven.plugins-|-maven-clean-plugin-|-2.5-|MNG-6548|
> |-org.apache.maven.plugins-|-maven-site-plugin-|-3.3-|MNG-6548|
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|
> |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2|
> |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1|
> |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
> |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2|
> |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (already 3.0+)|
> |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0|
> |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0|
> |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1|
> |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (needs 3.0 release (!))|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MNG-6169) Packaging plugin bindings version updates
[
https://issues.apache.org/jira/browse/MNG-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735762#comment-16735762
]
Michael Osipov edited comment on MNG-6169 at 1/7/19 12:38 PM:
--
[~hboutemy], no it is not a bug. It is only about {{components.xml}}. There is
not failure triggered in our ITs for this case. I have chosen to split this
into several issues to better track failures on our side. MNG-6548 looks good
to merge to me.
[~slachiewicz] thanks for checking. I will spawn more tickets as soon as I find
more stuff.
was (Author: michael-o):
[~hboutemy], not it is not a bug. It is only about {{components.xml}}. There
is not failure triggered in our ITs for this case. I have chosen to split this
into several issues to better track failures on our side. MNG-6548 looks good
to merge to me.
[~slachiewicz] thanks for checking. I will spawn more tickets as soon as I find
more stuff.
> Packaging plugin bindings version updates
> -
>
> Key: MNG-6169
> URL: https://issues.apache.org/jira/browse/MNG-6169
> Project: Maven
> Issue Type: Improvement
> Components: core, Dependencies
>Affects Versions: 3.3.9
>Reporter: Christian Schulte
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Issues to be reviewed for 3.x
>
>
> Regular plugin update to absorb changes if plugin version is not specified in
> the client POM.
> ||groupId||artifactId||[previous
> version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target
> version||
> |-org.apache.maven.plugins-|-maven-clean-plugin-|-2.5-|MNG-6548|
> |-org.apache.maven.plugins-|-maven-site-plugin-|-3.3-|MNG-6548|
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|
> |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2|
> |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1|
> |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
> |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2|
> |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (already 3.0+)|
> |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0|
> |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0|
> |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1|
> |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (needs 3.0 release (!))|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MNG-6548) Lifecycle plugin version upgrades
[ https://issues.apache.org/jira/browse/MNG-6548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735752#comment-16735752 ] Michael Osipov edited comment on MNG-6548 at 1/7/19 1:05 PM: - [~rfscholte], this is a small subset than before. ITs pass on several OSes here. Are we good to merge this one into 3.6.1? was (Author: michael-o): [~rfscholte], this is a small subset as before. ITs pass on several OSes here. Are we good to merge this one into 3.6.1? > Lifecycle plugin version upgrades > - > > Key: MNG-6548 > URL: https://issues.apache.org/jira/browse/MNG-6548 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.6.x-candidate > > > Regular plugin upgrades to absorb changes if plugin version is not specified > in the client POM. > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MNG-6549) Remove unused inherited dependencies of Guava
Sylwester Lachiewicz created MNG-6549:
-
Summary: Remove unused inherited dependencies of Guava
Key: MNG-6549
URL: https://issues.apache.org/jira/browse/MNG-6549
Project: Maven
Issue Type: Dependency upgrade
Components: Dependencies
Reporter: Sylwester Lachiewicz
Fix For: 3.6.x-candidate
With MNG-6475 we excluded explicit dependency to Guava but it's still required
by Guice and then packaged with all dependencies to the installation package.
Unfortunately, we pack few dependencies that are not required at runtime so we
can skip and decrease the size of the Maven package.
{code:java}
com.google.inject:guice:jar:no_aop:4.2.1:compile
- aopalliance:aopalliance:jar:1.0:compile
- com.google.guava:guava:jar:25.1-android:compile
- com.google.code.findbugs:jsr305:jar:3.0.2:compile
- org.checkerframework:checker-compat-qual:jar:2.0.0:compile
- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
- com.google.j2objc:j2objc-annotations:jar:1.1:compile
- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MNG-5577) Convert the core to use JSR 330 and remove the use of Plexus
[ https://issues.apache.org/jira/browse/MNG-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-5577: - Assignee: (was: Sylwester Lachiewicz) > Convert the core to use JSR 330 and remove the use of Plexus > > > Key: MNG-5577 > URL: https://issues.apache.org/jira/browse/MNG-5577 > Project: Maven > Issue Type: Improvement >Affects Versions: 3.2.1 >Reporter: Jason van Zyl >Priority: Major > Fix For: 3.6.x-candidate > > > Remove the use of Plexus annotations and use JSR330 annotations throughout > the core. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MNG-6550) Packaging 'pom' binding plugin upgrades
Michael Osipov created MNG-6550: --- Summary: Packaging 'pom' binding plugin upgrades Key: MNG-6550 URL: https://issues.apache.org/jira/browse/MNG-6550 Project: Maven Issue Type: Sub-task Components: core, Dependencies Affects Versions: 3.6.0, 3.5.0 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: Issues to be reviewed for 3.x -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6169) Packaging plugin bindings version updates
[
https://issues.apache.org/jira/browse/MNG-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6169:
Description:
This is an umbrella ticket to track work up packaging plugin bindings version
upgrades. The file is
{{maven-core/src/main/resources/META-INF/plexus/default-bindings.xml}}.
The work is structured in subtasks per packaging type.
This table will go away as soon as all tickets will have been created:
Regular plugin update to absorb changes if plugin version is not specified in
the client POM.
||groupId||artifactId||[previous
version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target
version||
|-org.apache.maven.plugins-|-maven-clean-plugin-|-2.5-|MNG-6548|
|-org.apache.maven.plugins-|-maven-site-plugin-|-3.3-|MNG-6548|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2|
|org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (already 3.0+)|
|org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0|
|org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0|
|org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1|
|org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (needs 3.0 release (!))|
was:
Regular plugin update to absorb changes if plugin version is not specified in
the client POM.
||groupId||artifactId||[previous
version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target
version||
|-org.apache.maven.plugins-|-maven-clean-plugin-|-2.5-|MNG-6548|
|-org.apache.maven.plugins-|-maven-site-plugin-|-3.3-|MNG-6548|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2|
|org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (already 3.0+)|
|org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0|
|org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0|
|org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1|
|org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (needs 3.0 release (!))|
> Packaging plugin bindings version updates
> -
>
> Key: MNG-6169
> URL: https://issues.apache.org/jira/browse/MNG-6169
> Project: Maven
> Issue Type: Improvement
> Components: core, Dependencies
>Affects Versions: 3.3.9
>Reporter: Christian Schulte
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Issues to be reviewed for 3.x
>
>
> This is an umbrella ticket to track work up packaging plugin bindings version
> upgrades. The file is
> {{maven-core/src/main/resources/META-INF/plexus/default-bindings.xml}}.
> The work is structured in subtasks per packaging type.
> This table will go away as soon as all tickets will have been created:
> Regular plugin update to absorb changes if plugin version is not specified in
> the client POM.
> ||groupId||artifactId||[previous
> version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target
> version||
> |-org.apache.maven.plugins-|-maven-clean-plugin-|-2.5-|MNG-6548|
> |-org.apache.maven.plugins-|-maven-site-plugin-|-3.3-|MNG-6548|
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|
> |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2|
> |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1|
> |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
> |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2|
> |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (already 3.0+)|
> |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0|
> |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0|
> |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1|
> |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (needs 3.0 release (!))|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-6550) Packaging 'pom' binding plugin upgrades
[ https://issues.apache.org/jira/browse/MNG-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6550: Description: This affects: ||groupId||artifactId||[previous version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_pom_packaging]||target version|| |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| > Packaging 'pom' binding plugin upgrades > --- > > Key: MNG-6550 > URL: https://issues.apache.org/jira/browse/MNG-6550 > Project: Maven > Issue Type: Sub-task > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: Issues to be reviewed for 3.x > > > This affects: > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_pom_packaging]||target > version|| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-469) javadoc-plugin does not double backslashes in argument file
[
https://issues.apache.org/jira/browse/MJAVADOC-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735854#comment-16735854
]
Michael Osipov commented on MJAVADOC-469:
-
Finally, this is a decent specification one can work with. So as far as I can
see, the current generated files are invalid too, they just pass for backward
compat. I think we need a pre 9 and and 9+ implementation. But [~tschoening]'s
solution will do for now.
> javadoc-plugin does not double backslashes in argument file
> ---
>
> Key: MJAVADOC-469
> URL: https://issues.apache.org/jira/browse/MJAVADOC-469
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 2.10.4
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
>
> On Windows `generate-rest-docs` goal of `maven-jira-plugin` calls
> `maven-javadoc-plugin` with:
> {code}additionalparam: -output
> "C:\path\to\target\classes\resourcedoc.xml"{code}
> If this argument was passed to `javadoc.exe` directly, I'm pretty sure this
> would work. However, the javadoc plugin generates an argument file[1] named
> "options" and executes:
> {code}javadoc.exe ... @options{code}
> The file contains all arguments with unescaped backslashes, although javadoc
> command documentation[2] suggests:
> {quote}If a filename contains embedded spaces, put the whole filename in
> double quotes, and double each backslash ("My Files\\Stuff.java"){quote}
> javadoc plugin version "2.4" is hardcoded in jira plugin, but I see no
> related changes in "2.10.4" in AbstractJavadocMojo.addCommandLineOptions() .
> [1]: https://maven.apache.org/plugins/maven-javadoc-plugin/
> [2]:
> http://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#argumentfiles
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6549) Remove unused inherited dependencies of Guava
[
https://issues.apache.org/jira/browse/MNG-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735878#comment-16735878
]
Michael Osipov commented on MNG-6549:
-
I am bit confused here. We remove Guava because we don't need it directly,
granted. Why exclude it when Guice requires it?
> Remove unused inherited dependencies of Guava
> -
>
> Key: MNG-6549
> URL: https://issues.apache.org/jira/browse/MNG-6549
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Dependencies
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> With MNG-6475 we excluded explicit dependency to Guava but it's still
> required by Guice and then packaged with all dependencies to the installation
> package.
> Unfortunately, we pack few dependencies that are not required at runtime so
> we can skip and decrease the size of the Maven package.
>
> {code:java}
> com.google.inject:guice:jar:no_aop:4.2.1:compile
> - aopalliance:aopalliance:jar:1.0:compile
> - com.google.guava:guava:jar:25.1-android:compile
>- com.google.code.findbugs:jsr305:jar:3.0.2:compile
>- org.checkerframework:checker-compat-qual:jar:2.0.0:compile
>- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
>- com.google.j2objc:j2objc-annotations:jar:1.1:compile
>- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MNG-6551) Packaging 'jar' binding plugin upgrades
Michael Osipov created MNG-6551: --- Summary: Packaging 'jar' binding plugin upgrades Key: MNG-6551 URL: https://issues.apache.org/jira/browse/MNG-6551 Project: Maven Issue Type: Sub-task Components: core, Dependencies Affects Versions: 3.5.0, 3.6.0 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: Issues to be reviewed for 3.x This affects: ||groupId||artifactId||[previous version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_pom_packaging]||target version|| |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6551) Packaging 'jar' binding plugin upgrades
[ https://issues.apache.org/jira/browse/MNG-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6551: Description: This affects: ||groupId||artifactId||[previous version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target version|| |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0| |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0| |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| |org.apache.maven.plugins|maven-jar-plugin|2.4|3.1.1| |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| was: This affects: ||groupId||artifactId||[previous version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_pom_packaging]||target version|| |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| > Packaging 'jar' binding plugin upgrades > --- > > Key: MNG-6551 > URL: https://issues.apache.org/jira/browse/MNG-6551 > Project: Maven > Issue Type: Sub-task > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: Issues to be reviewed for 3.x > > > This affects: > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target > version|| > |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0| > |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0| > |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| > |org.apache.maven.plugins|maven-jar-plugin|2.4|3.1.1| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1617) Surefire fails with bad message when path contains whitespaces and colon
[
https://issues.apache.org/jira/browse/SUREFIRE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736050#comment-16736050
]
Florian Wilhelm commented on SUREFIRE-1617:
---
Hi [~tibor17], I'm not sure what you're asking for. The above commands
reproduce the issue, I never touched the MANIFEST.MF file manually. Could you
kindly elaborate a little?
Thank you
Florian
> Surefire fails with bad message when path contains whitespaces and colon
>
>
> Key: SUREFIRE-1617
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1617
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M1
> Environment: Maven Docker container
>Reporter: Florian Wilhelm
>Priority: Major
>
> I noticed that surefire seems not to handle paths like {{/this is: a test}}
> well on mac and linux.
> Steps to reproduce:
> {code:java}
> docker run -it --rm maven:3-jdk-8 bash
> root@x:/# mkdir "this is: a test"
> root@x:/# cd this\ is\:\ a\ test/
> root@x:/this is: a test# mvn archetype:generate -B
> "-DarchetypeGroupId=com.sap.cloud.s4hana.archetypes"
> "-DarchetypeArtifactId=scp-cf-spring" "-DarchetypeVersion=2.8.1"
> "-DgroupId=com.sap.cloud.s4hana.examples" "-DartifactId=my-spring-project"
> "-Dversion=1.0-SNAPSHOT"
> root@x:/this is: a test/my-spring-project# mvn clean install
> {code}
>
> Result:
>
> {noformat}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit4/3.0.0-M1/common-junit4-3.0.0-M1.jar
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M1/common-junit3-3.0.0-M1.jar
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.jar
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M1/common-junit3-3.0.0-M1.jar
> (12 kB at 77 kB/s)
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit4/3.0.0-M1/common-junit4-3.0.0-M1.jar
> (28 kB at 168 kB/s)
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.jar
> (32 kB at 201 kB/s)
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary for my-spring-project - Root 1.0-SNAPSHOT:
> [INFO]
> [INFO] my-spring-project - Root ... SUCCESS [ 9.569
> s]
> [INFO] my-spring-project - Application SUCCESS [01:06
> min]
> [INFO] my-spring-project - Unit Tests . FAILURE [ 26.631
> s]
> [INFO] my-spring-project - Integration Tests .. SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 01:46 min
> [INFO] Finished at: 2018-12-17T12:50:32Z
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test (default-test)
> on project my-spring-project-unit-tests: There are test failures.
> [ERROR]
> [ERROR] Please refer to /this is: a
> test/my-spring-project/unit-tests/target/surefire-reports for the individual
> test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd "/this is: a
> test/my-spring-project/unit-tests" &&
> /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java
> '-javaagent:/root/.m2/repository/org/jacoco/org.jacoco.agent/0.8.2/org.jacoco.agent-0.8.2-runtime.jar=destfile=/this
> is: a test/my-spring-project/unit-tests/target/coverage-reports/jacoco.exec'
> -Xmx1024m -Dorg.slf4j.simpleLogger.defaultLogLevel=info
> -Djava.io.tmpdir=target/arquillian-working-dir/1/ -jar '/this is: a
> test/my-spring-project/unit-tests/target/surefire/surefirebooter8095576716546913586.jar'
> '/this is: a test/my-spring-project/unit-tests/target/surefire'
> 2018-12-17T12-50-30_752-jvmRun1 surefire1102558004600034061tmp
> surefire_04747331235585125480tmp
> [ERROR] Error occurred in starting fork, check ou
[jira] [Created] (ARCHETYPE-558) Allow transitive requiredProperty from non default ones
Esteban DUGUEPEROUX created ARCHETYPE-558:
-
Summary: Allow transitive requiredProperty from non default ones
Key: ARCHETYPE-558
URL: https://issues.apache.org/jira/browse/ARCHETYPE-558
Project: Maven Archetype
Issue Type: New Feature
Components: Generator
Affects Versions: 3.0.1
Reporter: Esteban DUGUEPEROUX
Hi,
I want to create a Maven Archetype with 2 requiredProperty :
apiName is used for the artifactId as follow:
${apiName}
I want also to define transitive properties from these 2 first properties:
${artifactId.replaceAll("^a|-a", "A").replaceAll("^b|-b",
"B").replaceAll("^c|-c", "C").replaceAll("^d|-d", "D").replaceAll("^e|-e",
"E").replaceAll("^f|-f", "F").replaceAll("^g|-g", "G").replaceAll("^h|-h",
"H").replaceAll("^i|-i", "I").replaceAll("^j|-j", "J").replaceAll("^k|-k",
"K").replaceAll("^l|-l", "L").replaceAll("^m|-m", "M").replaceAll("^n|-n",
"N").replaceAll("^o|-o", "O").replaceAll("^p|-p", "P").replaceAll("^q|-q",
"Q").replaceAll("^r|-r", "R").replaceAll("^s|-s", "S").replaceAll("^t|-t",
"T").replaceAll("^u|-u", "U").replaceAll("^v|-v", "V").replaceAll("^w|-w",
"W").replaceAll("^x|-x", "X").replaceAll("^y|-y", "Y").replaceAll("^z|-z",
"Z")}
${resourceName.replaceAll("^a|-a", "A").replaceAll("^b|-b",
"B").replaceAll("^c|-c", "C").replaceAll("^d|-d", "D").replaceAll("^e|-e",
"E").replaceAll("^f|-f", "F").replaceAll("^g|-g", "G").replaceAll("^h|-h",
"H").replaceAll("^i|-i", "I").replaceAll("^j|-j", "J").replaceAll("^k|-k",
"K").replaceAll("^l|-l", "L").replaceAll("^m|-m", "M").replaceAll("^n|-n",
"N").replaceAll("^o|-o", "O").replaceAll("^p|-p", "P").replaceAll("^q|-q",
"Q").replaceAll("^r|-r", "R").replaceAll("^s|-s", "S").replaceAll("^t|-t",
"T").replaceAll("^u|-u", "U").replaceAll("^v|-v", "V").replaceAll("^w|-w",
"W").replaceAll("^x|-x", "X").replaceAll("^y|-y", "Y").replaceAll("^z|-z",
"Z")}
to have a camel case version of the 2 first properties.
For camelCaseAPIName property, it works because it uses artifactId property
which is same as apiName. But for camelCaseResourceName it doesn't works
because resourceName property is not added in velocity context. Only
requiredProperty with no value and default value are set in velocity context.
See
org.apache.maven.archetype.ui.generation.DefaultArchetypeGenerationConfigurator.configureArchetype(ArchetypeGenerationRequest,
Boolean, Properties) line 262.
Could we have velocity context extended to property with value and no default
value?
Best Regards.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6548) Lifecycle plugin version upgrades
[ https://issues.apache.org/jira/browse/MNG-6548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736058#comment-16736058 ] Robert Scholte commented on MNG-6548: - LGTM > Lifecycle plugin version upgrades > - > > Key: MNG-6548 > URL: https://issues.apache.org/jira/browse/MNG-6548 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.6.x-candidate > > > Regular plugin upgrades to absorb changes if plugin version is not specified > in the client POM. > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6551) Packaging 'jar' binding plugin upgrades
[ https://issues.apache.org/jira/browse/MNG-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736070#comment-16736070 ] Robert Scholte commented on MNG-6551: - Ideally only the maven-jar-plugin is updated. In https://github.com/apache/maven-jar-plugin/blob/master/src/main/filtered-resources/META-INF/plexus/components.xml you define the all the plugin versions per phase that are part of the "jar"-binding build-lifecycle. > Packaging 'jar' binding plugin upgrades > --- > > Key: MNG-6551 > URL: https://issues.apache.org/jira/browse/MNG-6551 > Project: Maven > Issue Type: Sub-task > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: Issues to be reviewed for 3.x > > > This affects: > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target > version|| > |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0| > |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0| > |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| > |org.apache.maven.plugins|maven-jar-plugin|2.4|3.1.1| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6551) Packaging 'jar' binding plugin upgrades
[ https://issues.apache.org/jira/browse/MNG-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736084#comment-16736084 ] Michael Osipov commented on MNG-6551: - Yes, I see. I have seen counter effects on local builds. That's why I'd like to isolate them. If the change by this ticket does not introduce any new issues, that's even better. > Packaging 'jar' binding plugin upgrades > --- > > Key: MNG-6551 > URL: https://issues.apache.org/jira/browse/MNG-6551 > Project: Maven > Issue Type: Sub-task > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: Issues to be reviewed for 3.x > > > This affects: > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target > version|| > |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0| > |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0| > |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| > |org.apache.maven.plugins|maven-jar-plugin|2.4|3.1.1| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6548) Lifecycle plugin version upgrades
[ https://issues.apache.org/jira/browse/MNG-6548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6548: Fix Version/s: (was: 3.6.x-candidate) 3.6.1 > Lifecycle plugin version upgrades > - > > Key: MNG-6548 > URL: https://issues.apache.org/jira/browse/MNG-6548 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.6.1 > > > Regular plugin upgrades to absorb changes if plugin version is not specified > in the client POM. > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6551) Packaging 'jar' binding plugin upgrades
[ https://issues.apache.org/jira/browse/MNG-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736106#comment-16736106 ] Robert Scholte commented on MNG-6551: - Just to make clear to everybody why we need both: Suppose someone is using an old maven-jar-plugin that doesn't contain the components.xml yet, then the other plugins must still have a reliable version. Removing it here would mean Maven would look for the LATEST again (which would drop us back to Maven 2.0.x), hence we still need to update this in Maven Core too. > Packaging 'jar' binding plugin upgrades > --- > > Key: MNG-6551 > URL: https://issues.apache.org/jira/browse/MNG-6551 > Project: Maven > Issue Type: Sub-task > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: Issues to be reviewed for 3.x > > > This affects: > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target > version|| > |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0| > |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0| > |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| > |org.apache.maven.plugins|maven-jar-plugin|2.4|3.1.1| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6551) Packaging 'jar' binding plugin upgrades
[ https://issues.apache.org/jira/browse/MNG-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736142#comment-16736142 ] Michael Osipov commented on MNG-6551: - [~rfscholte], thanks for this. This information is crucial! > Packaging 'jar' binding plugin upgrades > --- > > Key: MNG-6551 > URL: https://issues.apache.org/jira/browse/MNG-6551 > Project: Maven > Issue Type: Sub-task > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: Issues to be reviewed for 3.x > > > This affects: > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target > version|| > |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0| > |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0| > |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3| > |org.apache.maven.plugins|maven-jar-plugin|2.4|3.1.1| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject
mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject URL: https://github.com/apache/maven/pull/197#issuecomment-452032331 @hboutemy I'm trying to get back to work on that one, but with MNG-6530, it's much harder to test it properly in m2e (I need to deal with a sequence of commits in the right order both in Maven and m2e to be able to test this issue). I'll try to make progress anyway, but it'd be much simpler to me if we can work on MNG-6530 first. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (MNG-6548) Lifecycle plugin version upgrades
[ https://issues.apache.org/jira/browse/MNG-6548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6548. --- Resolution: Fixed Fixed with [33e4f201d322efcbe53d0ad557c9c332941c1e7a|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=33e4f201d322efcbe53d0ad557c9c332941c1e7a]. > Lifecycle plugin version upgrades > - > > Key: MNG-6548 > URL: https://issues.apache.org/jira/browse/MNG-6548 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.6.1 > > > Regular plugin upgrades to absorb changes if plugin version is not specified > in the client POM. > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6550) Packaging 'pom' binding plugin upgrades
[
https://issues.apache.org/jira/browse/MNG-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736174#comment-16736174
]
Michael Osipov commented on MNG-6550:
-
[~rfscholte], is this something we can safely merge into 3.6.1? {{pom}}
packaging won't go away anyway.
> Packaging 'pom' binding plugin upgrades
> ---
>
> Key: MNG-6550
> URL: https://issues.apache.org/jira/browse/MNG-6550
> Project: Maven
> Issue Type: Sub-task
> Components: core, Dependencies
>Affects Versions: 3.5.0, 3.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: Issues to be reviewed for 3.x
>
>
> This affects:
> ||groupId||artifactId||[previous
> version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_pom_packaging]||target
> version||
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MNG-6550) Packaging 'pom' binding plugin upgrades
[
https://issues.apache.org/jira/browse/MNG-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736174#comment-16736174
]
Michael Osipov edited comment on MNG-6550 at 1/7/19 6:50 PM:
-
[~rfscholte], is this something we can safely merge into 3.6.1? {{pom}}
packaging won't go away anyway. All ITs pass.
was (Author: michael-o):
[~rfscholte], is this something we can safely merge into 3.6.1? {{pom}}
packaging won't go away anyway.
> Packaging 'pom' binding plugin upgrades
> ---
>
> Key: MNG-6550
> URL: https://issues.apache.org/jira/browse/MNG-6550
> Project: Maven
> Issue Type: Sub-task
> Components: core, Dependencies
>Affects Versions: 3.5.0, 3.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: Issues to be reviewed for 3.x
>
>
> This affects:
> ||groupId||artifactId||[previous
> version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_pom_packaging]||target
> version||
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6550) Packaging 'pom' binding plugin upgrades
[ https://issues.apache.org/jira/browse/MNG-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736188#comment-16736188 ] Robert Scholte commented on MNG-6550: - I just remembered that these plugin are a bit stricter. Now if the packaging is a non-pom, you must have a main artifact. Also the alternativeRepository URL for deployment has been changed. So maybe better to save this for Maven 3.7.x, because things might suddenly break for bad configured projects, that shouldn't happen with 3.6.1. > Packaging 'pom' binding plugin upgrades > --- > > Key: MNG-6550 > URL: https://issues.apache.org/jira/browse/MNG-6550 > Project: Maven > Issue Type: Sub-task > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: Issues to be reviewed for 3.x > > > This affects: > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_pom_packaging]||target > version|| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MNG-6549) Remove unused inherited dependencies of Guava
[
https://issues.apache.org/jira/browse/MNG-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned MNG-6549:
-
Assignee: Sylwester Lachiewicz
> Remove unused inherited dependencies of Guava
> -
>
> Key: MNG-6549
> URL: https://issues.apache.org/jira/browse/MNG-6549
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Dependencies
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> With MNG-6475 we excluded explicit dependency to Guava but it's still
> required by Guice and then packaged with all dependencies to the installation
> package.
> Unfortunately, we pack few dependencies that are not required at runtime so
> we can skip and decrease the size of the Maven package.
>
> {code:java}
> com.google.inject:guice:jar:no_aop:4.2.1:compile
> - aopalliance:aopalliance:jar:1.0:compile
> - com.google.guava:guava:jar:25.1-android:compile
>- com.google.code.findbugs:jsr305:jar:3.0.2:compile
>- org.checkerframework:checker-compat-qual:jar:2.0.0:compile
>- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
>- com.google.j2objc:j2objc-annotations:jar:1.1:compile
>- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MNG-6549) Remove unused inherited dependencies of Guava
[
https://issues.apache.org/jira/browse/MNG-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned MNG-6549:
-
Assignee: (was: Sylwester Lachiewicz)
> Remove unused inherited dependencies of Guava
> -
>
> Key: MNG-6549
> URL: https://issues.apache.org/jira/browse/MNG-6549
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Dependencies
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> With MNG-6475 we excluded explicit dependency to Guava but it's still
> required by Guice and then packaged with all dependencies to the installation
> package.
> Unfortunately, we pack few dependencies that are not required at runtime so
> we can skip and decrease the size of the Maven package.
>
> {code:java}
> com.google.inject:guice:jar:no_aop:4.2.1:compile
> - aopalliance:aopalliance:jar:1.0:compile
> - com.google.guava:guava:jar:25.1-android:compile
>- com.google.code.findbugs:jsr305:jar:3.0.2:compile
>- org.checkerframework:checker-compat-qual:jar:2.0.0:compile
>- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
>- com.google.j2objc:j2objc-annotations:jar:1.1:compile
>- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6549) Remove unused inherited dependencies of Guava
[
https://issues.apache.org/jira/browse/MNG-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736289#comment-16736289
]
Sylwester Lachiewicz commented on MNG-6549:
---
I mean exclude dependencies of Guava ie findbugs/checker/errorprone annotations
etc.
> Remove unused inherited dependencies of Guava
> -
>
> Key: MNG-6549
> URL: https://issues.apache.org/jira/browse/MNG-6549
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Dependencies
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> With MNG-6475 we excluded explicit dependency to Guava but it's still
> required by Guice and then packaged with all dependencies to the installation
> package.
> Unfortunately, we pack few dependencies that are not required at runtime so
> we can skip and decrease the size of the Maven package.
>
> {code:java}
> com.google.inject:guice:jar:no_aop:4.2.1:compile
> - aopalliance:aopalliance:jar:1.0:compile
> - com.google.guava:guava:jar:25.1-android:compile
>- com.google.code.findbugs:jsr305:jar:3.0.2:compile
>- org.checkerframework:checker-compat-qual:jar:2.0.0:compile
>- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
>- com.google.j2objc:j2objc-annotations:jar:1.1:compile
>- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] rfscholte commented on a change in pull request #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI
rfscholte commented on a change in pull request #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI URL: https://github.com/apache/maven/pull/153#discussion_r245794401 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -167,7 +170,7 @@ public void displayHelp( PrintStream stdout ) HelpFormatter formatter = new HelpFormatter(); -formatter.printHelp( pw, HelpFormatter.DEFAULT_WIDTH, "mvn [options] [] []", "\nOptions:", +formatter.printHelp( pw, 120, "mvn [options] [] []", "\nOptions:", Review comment: +1, I see no reason why to replace this. I would expect SonarQube to complain about magic numbers. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rfscholte commented on a change in pull request #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI
rfscholte commented on a change in pull request #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI URL: https://github.com/apache/maven/pull/153#discussion_r245794049 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -167,7 +170,7 @@ public void displayHelp( PrintStream stdout ) HelpFormatter formatter = new HelpFormatter(); -formatter.printHelp( pw, HelpFormatter.DEFAULT_WIDTH, "mvn [options] [] []", "\nOptions:", +formatter.printHelp( pw, 120, "mvn [options] [] []", "\nOptions:", Review comment: +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] slachiewicz commented on issue #228: [MNG-6346] Add " around echo in mvn.cmd
slachiewicz commented on issue #228: [MNG-6346] Add " around echo in mvn.cmd URL: https://github.com/apache/maven/pull/228#issuecomment-452089928 I found MNG-6256 with exactly same patch as my in #128 plus additional ITs - I'll use that @eolivelli, ok? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6549) Remove unused inherited dependencies of Guava
[
https://issues.apache.org/jira/browse/MNG-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736398#comment-16736398
]
Michael Osipov commented on MNG-6549:
-
Guice doesn't require it?
> Remove unused inherited dependencies of Guava
> -
>
> Key: MNG-6549
> URL: https://issues.apache.org/jira/browse/MNG-6549
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Dependencies
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> With MNG-6475 we excluded explicit dependency to Guava but it's still
> required by Guice and then packaged with all dependencies to the installation
> package.
> Unfortunately, we pack few dependencies that are not required at runtime so
> we can skip and decrease the size of the Maven package.
>
> {code:java}
> com.google.inject:guice:jar:no_aop:4.2.1:compile
> - aopalliance:aopalliance:jar:1.0:compile
> - com.google.guava:guava:jar:25.1-android:compile
>- com.google.code.findbugs:jsr305:jar:3.0.2:compile
>- org.checkerframework:checker-compat-qual:jar:2.0.0:compile
>- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
>- com.google.j2objc:j2objc-annotations:jar:1.1:compile
>- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-6550) Packaging 'pom' binding plugin upgrades
[ https://issues.apache.org/jira/browse/MNG-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6550: Fix Version/s: (was: Issues to be reviewed for 3.x) 3.7.0-candidate > Packaging 'pom' binding plugin upgrades > --- > > Key: MNG-6550 > URL: https://issues.apache.org/jira/browse/MNG-6550 > Project: Maven > Issue Type: Sub-task > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.7.0-candidate > > > This affects: > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_pom_packaging]||target > version|| > |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1| > |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6549) Remove unused inherited dependencies of Guava
[
https://issues.apache.org/jira/browse/MNG-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736410#comment-16736410
]
Sylwester Lachiewicz commented on MNG-6549:
---
It does not require it. I deleted these files locally from 3.6.0 and it still
works correctly.
> Remove unused inherited dependencies of Guava
> -
>
> Key: MNG-6549
> URL: https://issues.apache.org/jira/browse/MNG-6549
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Dependencies
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> With MNG-6475 we excluded explicit dependency to Guava but it's still
> required by Guice and then packaged with all dependencies to the installation
> package.
> Unfortunately, we pack few dependencies that are not required at runtime so
> we can skip and decrease the size of the Maven package.
>
> {code:java}
> com.google.inject:guice:jar:no_aop:4.2.1:compile
> - aopalliance:aopalliance:jar:1.0:compile
> - com.google.guava:guava:jar:25.1-android:compile
>- com.google.code.findbugs:jsr305:jar:3.0.2:compile
>- org.checkerframework:checker-compat-qual:jar:2.0.0:compile
>- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
>- com.google.j2objc:j2objc-annotations:jar:1.1:compile
>- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] slachiewicz commented on a change in pull request #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI
slachiewicz commented on a change in pull request #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI URL: https://github.com/apache/maven/pull/153#discussion_r245520650 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -167,7 +170,7 @@ public void displayHelp( PrintStream stdout ) HelpFormatter formatter = new HelpFormatter(); -formatter.printHelp( pw, HelpFormatter.DEFAULT_WIDTH, "mvn [options] [] []", "\nOptions:", +formatter.printHelp( pw, 120, "mvn [options] [] []", "\nOptions:", Review comment: HelpFormatter.DEFAULT_WIDTH = 74 chars and if You compare with help printed after an update it looks really better. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6549) Remove unused inherited dependencies of Guava
[
https://issues.apache.org/jira/browse/MNG-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736418#comment-16736418
]
Michael Osipov commented on MNG-6549:
-
That's pretty weird then I do not understand why this is a depenency of Guice
at all.
> Remove unused inherited dependencies of Guava
> -
>
> Key: MNG-6549
> URL: https://issues.apache.org/jira/browse/MNG-6549
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Dependencies
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> With MNG-6475 we excluded explicit dependency to Guava but it's still
> required by Guice and then packaged with all dependencies to the installation
> package.
> Unfortunately, we pack few dependencies that are not required at runtime so
> we can skip and decrease the size of the Maven package.
>
> {code:java}
> com.google.inject:guice:jar:no_aop:4.2.1:compile
> - aopalliance:aopalliance:jar:1.0:compile
> - com.google.guava:guava:jar:25.1-android:compile
>- com.google.code.findbugs:jsr305:jar:3.0.2:compile
>- org.checkerframework:checker-compat-qual:jar:2.0.0:compile
>- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
>- com.google.j2objc:j2objc-annotations:jar:1.1:compile
>- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6549) Remove unused inherited dependencies of Guava
[
https://issues.apache.org/jira/browse/MNG-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736421#comment-16736421
]
Sylwester Lachiewicz commented on MNG-6549:
---
In version [21|https://mvnrepository.com/artifact/com.google.guava/guava/21.0]
all was optional, from 22 (ie split to android and normal) all are compile
dependencies.
> Remove unused inherited dependencies of Guava
> -
>
> Key: MNG-6549
> URL: https://issues.apache.org/jira/browse/MNG-6549
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Dependencies
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> With MNG-6475 we excluded explicit dependency to Guava but it's still
> required by Guice and then packaged with all dependencies to the installation
> package.
> Unfortunately, we pack few dependencies that are not required at runtime so
> we can skip and decrease the size of the Maven package.
>
> {code:java}
> com.google.inject:guice:jar:no_aop:4.2.1:compile
> - aopalliance:aopalliance:jar:1.0:compile
> - com.google.guava:guava:jar:25.1-android:compile
>- com.google.code.findbugs:jsr305:jar:3.0.2:compile
>- org.checkerframework:checker-compat-qual:jar:2.0.0:compile
>- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
>- com.google.j2objc:j2objc-annotations:jar:1.1:compile
>- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MNG-6256) Maven script can break if "-f" path contains special characters
[
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned MNG-6256:
-
Assignee: Sylwester Lachiewicz
> Maven script can break if "-f" path contains special characters
>
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.x-candidate
>
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to
> specify an alternate POM file can break the script if the path contains
> special characters.
> It was originally discovered on a Windows Jenkins instance with working
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file '}} and a new calculator process
> The bug was introduced with commit
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
> for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}}
> commands in {{maven.cmd}} (line 120 and 129).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6526) Upgrade to Wagon 3.3.1
[ https://issues.apache.org/jira/browse/MNG-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736442#comment-16736442 ] Hudson commented on MNG-6526: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6069v2 #5 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6069v2/5/ > Upgrade to Wagon 3.3.1 > -- > > Key: MNG-6526 > URL: https://issues.apache.org/jira/browse/MNG-6526 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Affects Versions: 3.6.0 >Reporter: Olaf Otto >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.1 > > > Wagon 3.3.0 contains an important improvement for the transfer speed of large > artifacts (see WAGON-537). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6069) Migrate to non deprecated parts of Commons CLI
[
https://issues.apache.org/jira/browse/MNG-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736444#comment-16736444
]
Hudson commented on MNG-6069:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-6069v2 #5
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6069v2/5/
> Migrate to non deprecated parts of Commons CLI
> --
>
> Key: MNG-6069
> URL: https://issues.apache.org/jira/browse/MNG-6069
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.3.9, 3.5.0-alpha-1, 3.5.0-beta-1, 3.5.0
>Reporter: Karl Heinz Marbaise
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.1
>
>
> At the moment all parts of {{OptionBuilder...}} are marked deprecated in
> {{CLIManager}}. They should be migrated to:
> {code:java}
> Option.builder( HELP ).longOpt( "help" ).desc( "Display help information"
> ).build()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6529) ProjectBuilder.build(List projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
[
https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736438#comment-16736438
]
Hudson commented on MNG-6529:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-6069v2 #5
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6069v2/5/
> ProjectBuilder.build(List projects, boolean, ProjectBuildingRequest)
> doesn't honor ProjectBuildingRequest.isResolveDependencies()
> ---
>
> Key: MNG-6529
> URL: https://issues.apache.org/jira/browse/MNG-6529
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.5.3
>Reporter: Mickael Istria
>Assignee: Robert Scholte
>Priority: Critical
> Fix For: 3.6.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I'm willing to update Eclipse m2e to take advantage of the
> {{ProjectBuilder.build(List project, boolean, ProjectBuildingRequest)}}
> to avoid duplication of MavenProject in the IDE caused by
> {{ProjectBuilder.build(File singleFile, ProjectBuildingRequest)}}.
> It's already measured to have drastically good impact on the IDE, as
> explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and
> [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
> However, using this cause regressions because the multi-projects entry-point
> method seems to totally ignore the
> {{ProjectBuildRequest.isResolveDependencies()}} flag and never returns a
> valid list of {{MavenProject.getArtifacts()}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6513) Replace depreated Plexus javadoc tags with annotations in ITs
[ https://issues.apache.org/jira/browse/MNG-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736445#comment-16736445 ] Hudson commented on MNG-6513: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6069v2 #5 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6069v2/5/ > Replace depreated Plexus javadoc tags with annotations in ITs > -- > > Key: MNG-6513 > URL: https://issues.apache.org/jira/browse/MNG-6513 > Project: Maven > Issue Type: Improvement > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.1 > > > Remove Javadoc Plexus tags @plexus.component and replace with standard Java > annotations from plexus-component-annotations in Integration Tests > Guide: > [https://maven.apache.org/plugin-developers/cookbook/plexus-plugin-upgrade.html] > As effect - remove Javadoc generation warning about Taglets -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6213) Maven doesn't check the validity of scope value
[
https://issues.apache.org/jira/browse/MNG-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736441#comment-16736441
]
Hudson commented on MNG-6213:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-6069v2 #5
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6069v2/5/
> Maven doesn't check the validity of scope value
> ---
>
> Key: MNG-6213
> URL: https://issues.apache.org/jira/browse/MNG-6213
> Project: Maven
> Issue Type: Improvement
> Components: POM
>Affects Versions: 3.3.9
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T01:41:47+09:00)
> Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> Java version: 1.8.0_121, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.4", arch: "x86_64", family: "mac"
>Reporter: Jin Kwon
>Assignee: Michael Osipov
>Priority: Minor
> Labels: scope
> Fix For: 3.6.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I accidentally put a wrong value into the {{scope}} tag.
> {code:xml}
>
>
>
> org.glassfish.jersey
> jersey-bom
> 2.26-b03
> pom
> include
>
>
>
> {code}
> And, of course, my dependency doesn't work.
> {code:xml}
>
>
> org.glassfish.jersey.core
> jersey-common
> test
>
>
> {code}
> {code}
> 'dependencies.dependency.version' for
> org.glassfish.jersey.core:jersey-common:jar is missing.
> {code}
> Maven should complains about the wrong value of {{include}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6544) Replace CacheUtils#{eq,hash} with Objects
[
https://issues.apache.org/jira/browse/MNG-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736440#comment-16736440
]
Hudson commented on MNG-6544:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-6069v2 #5
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6069v2/5/
> Replace CacheUtils#{eq,hash} with Objects
> -
>
> Key: MNG-6544
> URL: https://issues.apache.org/jira/browse/MNG-6544
> Project: Maven
> Issue Type: Task
> Components: core
>Affects Versions: 3.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.1
>
>
> {{Objects}} now sports idiot-safe {{equals}} and {{hashCode}} just like
> {{CacheUtils}}. We can swap out and deprecate/delete our code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6520) Update assembly descriptors to 2.0.0
[ https://issues.apache.org/jira/browse/MNG-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736443#comment-16736443 ] Hudson commented on MNG-6520: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6069v2 #5 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6069v2/5/ > Update assembly descriptors to 2.0.0 > > > Key: MNG-6520 > URL: https://issues.apache.org/jira/browse/MNG-6520 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Update namespaces to the version compatible with 3.0+ maven-assembly-plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-5965) Parallel build multiplies work if multiple goals are given
[ https://issues.apache.org/jira/browse/MNG-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736439#comment-16736439 ] Hudson commented on MNG-5965: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6069v2 #5 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6069v2/5/ > Parallel build multiplies work if multiple goals are given > -- > > Key: MNG-5965 > URL: https://issues.apache.org/jira/browse/MNG-5965 > Project: Maven > Issue Type: Bug > Components: Bootstrap & Build >Affects Versions: 3.3.9 > Environment: Windows 7 64bit >Reporter: Matthias Schmalz >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.1 > > Attachments: parallel.test.zip > > Time Spent: 20m > Remaining Estimate: 0h > > When I run a parallel build which invokes multiple goals Maven multiplies the > work e.g. when I run > install sonar:sonar > Every phase is executed once as expected. However when I run > install sonar:sonar -T 4 > Every phase is executed twice. > The problem can be reproduced with a single simple Java project (of course > parallel builds are useless with a single module). Debugging showed that > every Mojo is really called twice per project. > Find attached a simple project and two build outputs, where you can see that > the parallel build is doing everything twice (you can ignore that Sonar fails > in the end, due to no server is up). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6548) Lifecycle plugin version upgrades
[ https://issues.apache.org/jira/browse/MNG-6548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736450#comment-16736450 ] Hudson commented on MNG-6548: - Build succeeded in Jenkins: Maven TLP » maven » master #126 See https://builds.apache.org/job/maven-box/job/maven/job/master/126/ > Lifecycle plugin version upgrades > - > > Key: MNG-6548 > URL: https://issues.apache.org/jira/browse/MNG-6548 > Project: Maven > Issue Type: Improvement > Components: core, Dependencies >Affects Versions: 3.5.0, 3.6.0 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.6.1 > > > Regular plugin upgrades to absorb changes if plugin version is not specified > in the client POM. > ||groupId||artifactId||[previous > version|https://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html]||target > version|| > |org.apache.maven.plugins|maven-clean-plugin|2.5|3.1.0| > |org.apache.maven.plugins|maven-site-plugin|3.3|3.7.1| -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6169) Packaging plugin bindings version updates
[
https://issues.apache.org/jira/browse/MNG-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736549#comment-16736549
]
Hervé Boutemy commented on MNG-6169:
if there is no failure, I don't get why we upgrade
> Packaging plugin bindings version updates
> -
>
> Key: MNG-6169
> URL: https://issues.apache.org/jira/browse/MNG-6169
> Project: Maven
> Issue Type: Improvement
> Components: core, Dependencies
>Affects Versions: 3.3.9
>Reporter: Christian Schulte
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Issues to be reviewed for 3.x
>
>
> This is an umbrella ticket to track work up packaging plugin bindings version
> upgrades. The file is
> {{maven-core/src/main/resources/META-INF/plexus/default-bindings.xml}}.
> The work is structured in subtasks per packaging type.
> This table will go away as soon as all tickets will have been created:
> Regular plugin update to absorb changes if plugin version is not specified in
> the client POM.
> ||groupId||artifactId||[previous
> version|http://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html]||target
> version||
> |-org.apache.maven.plugins-|-maven-clean-plugin-|-2.5-|MNG-6548|
> |-org.apache.maven.plugins-|-maven-site-plugin-|-3.3-|MNG-6548|
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|
> |org.apache.maven.plugins|maven-resources-plugin|2.6|3.0.2|
> |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.5.1|
> |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
> |org.apache.maven.plugins|maven-jar-plugin|2.4|3.0.2|
> |org.apache.maven.plugins|maven-ejb-plugin|2.3|2.5.1 (already 3.0+)|
> |org.apache.maven.plugins|maven-plugin-plugin|3.2|3.6.0|
> |org.apache.maven.plugins|maven-war-plugin|2.2|3.0.0|
> |org.apache.maven.plugins|maven-ear-plugin|2.8|3.0.1|
> |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4 (needs 3.0 release (!))|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] eolivelli commented on issue #228: [MNG-6346] Add " around echo in mvn.cmd
eolivelli commented on issue #228: [MNG-6346] Add " around echo in mvn.cmd URL: https://github.com/apache/maven/pull/228#issuecomment-452186350 Sure, okay This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1617) Surefire fails with bad message when path contains whitespaces and colon
[
https://issues.apache.org/jira/browse/SUREFIRE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736778#comment-16736778
]
Tibor Digana commented on SUREFIRE-1617:
I know you are not creating MANIFEST.MF file, but we are
No worries. I will try to fix it and then I will ask you to confirm it's
working fine with the snapshot version.
> Surefire fails with bad message when path contains whitespaces and colon
>
>
> Key: SUREFIRE-1617
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1617
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M1
> Environment: Maven Docker container
>Reporter: Florian Wilhelm
>Priority: Major
>
> I noticed that surefire seems not to handle paths like {{/this is: a test}}
> well on mac and linux.
> Steps to reproduce:
> {code:java}
> docker run -it --rm maven:3-jdk-8 bash
> root@x:/# mkdir "this is: a test"
> root@x:/# cd this\ is\:\ a\ test/
> root@x:/this is: a test# mvn archetype:generate -B
> "-DarchetypeGroupId=com.sap.cloud.s4hana.archetypes"
> "-DarchetypeArtifactId=scp-cf-spring" "-DarchetypeVersion=2.8.1"
> "-DgroupId=com.sap.cloud.s4hana.examples" "-DartifactId=my-spring-project"
> "-Dversion=1.0-SNAPSHOT"
> root@x:/this is: a test/my-spring-project# mvn clean install
> {code}
>
> Result:
>
> {noformat}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit4/3.0.0-M1/common-junit4-3.0.0-M1.jar
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M1/common-junit3-3.0.0-M1.jar
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.jar
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M1/common-junit3-3.0.0-M1.jar
> (12 kB at 77 kB/s)
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit4/3.0.0-M1/common-junit4-3.0.0-M1.jar
> (28 kB at 168 kB/s)
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.jar
> (32 kB at 201 kB/s)
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary for my-spring-project - Root 1.0-SNAPSHOT:
> [INFO]
> [INFO] my-spring-project - Root ... SUCCESS [ 9.569
> s]
> [INFO] my-spring-project - Application SUCCESS [01:06
> min]
> [INFO] my-spring-project - Unit Tests . FAILURE [ 26.631
> s]
> [INFO] my-spring-project - Integration Tests .. SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 01:46 min
> [INFO] Finished at: 2018-12-17T12:50:32Z
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test (default-test)
> on project my-spring-project-unit-tests: There are test failures.
> [ERROR]
> [ERROR] Please refer to /this is: a
> test/my-spring-project/unit-tests/target/surefire-reports for the individual
> test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd "/this is: a
> test/my-spring-project/unit-tests" &&
> /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java
> '-javaagent:/root/.m2/repository/org/jacoco/org.jacoco.agent/0.8.2/org.jacoco.agent-0.8.2-runtime.jar=destfile=/this
> is: a test/my-spring-project/unit-tests/target/coverage-reports/jacoco.exec'
> -Xmx1024m -Dorg.slf4j.simpleLogger.defaultLogLevel=info
> -Djava.io.tmpdir=target/arquillian-working-dir/1/ -jar '/this is: a
> test/my-spring-project/unit-tests/target/surefire/surefirebooter8095576716546913586.jar'
> '/this is: a test/my-spring-project/unit-tests/target/surefire'
> 2018-12-17T12-50-30_752-jvmRun1 surefire1102558004600034061tmp
> surefire_04747331235585125480tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exi
