[GitHub] michael-o commented on issue #188: [MNG-6490] Maven fails reporting circular dependency when the depende…
michael-o commented on issue #188: [MNG-6490] Maven fails reporting circular dependency when the depende… URL: https://github.com/apache/maven/pull/188#issuecomment-431278065 The change looks good to me, but the issue title is misleading and does not reflect the issue. Shouldn't it be "Maven shall not fail..."? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6490) maven fails reporting circular dependency when the dependency is a classified secondary artifact
[
https://issues.apache.org/jira/browse/MNG-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656418#comment-16656418
]
Michael Osipov commented on MNG-6490:
-
I'd even add this fix to 3.6.0.
> maven fails reporting circular dependency when the dependency is a classified
> secondary artifact
>
>
> Key: MNG-6490
> URL: https://issues.apache.org/jira/browse/MNG-6490
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 3.5.2, 3.5.3, 3.5.4
> Environment: Ubuntu 16.0.4 LTS, Ubuntu 18.0.4 LTS, Mac OS High
> Sierra, Oracle and OpenJDK 8, Oracle Java 11,
>Reporter: John Canny
>Priority: Blocker
> Fix For: 3.6.x-candidate
>
>
> As of maven 3.5.2, 3.5.3, 3.5.4, the following pom fails with the error
> "dependencies.dependency. Main:MainJar:1' for Main:MainJar:1 is referencing
> itself"
> But the dependency is not circular, it references a classified jar (in our
> use cases its an architecture-dependent native code container jar). The pom
> below allows the main jar to be built without building the dependency every
> time (other lines conditionally build the dependency), and ensures the
> appropriate pre-built dependency is loaded. Behavior in maven 3.5.0 and
> earlier was correct (i.e. no error). This breaks several of the usage
> scenarios for classified artifacts...
>
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> Main
> MainJar
> jar
> 1
>
>
> ${project.groupId}
> ${project.artifactId}
> ${project.version}
> linux
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6490) maven fails reporting circular dependency when the dependency is a classified secondary artifact
[
https://issues.apache.org/jira/browse/MNG-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656417#comment-16656417
]
ASF GitHub Bot commented on MNG-6490:
-
michael-o commented on issue #188: [MNG-6490] Maven fails reporting circular
dependency when the depende…
URL: https://github.com/apache/maven/pull/188#issuecomment-431278065
The change looks good to me, but the issue title is misleading and does not
reflect the issue. Shouldn't it be "Maven shall not fail..."?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> maven fails reporting circular dependency when the dependency is a classified
> secondary artifact
>
>
> Key: MNG-6490
> URL: https://issues.apache.org/jira/browse/MNG-6490
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 3.5.2, 3.5.3, 3.5.4
> Environment: Ubuntu 16.0.4 LTS, Ubuntu 18.0.4 LTS, Mac OS High
> Sierra, Oracle and OpenJDK 8, Oracle Java 11,
>Reporter: John Canny
>Priority: Blocker
> Fix For: 3.6.x-candidate
>
>
> As of maven 3.5.2, 3.5.3, 3.5.4, the following pom fails with the error
> "dependencies.dependency. Main:MainJar:1' for Main:MainJar:1 is referencing
> itself"
> But the dependency is not circular, it references a classified jar (in our
> use cases its an architecture-dependent native code container jar). The pom
> below allows the main jar to be built without building the dependency every
> time (other lines conditionally build the dependency), and ensures the
> appropriate pre-built dependency is loaded. Behavior in maven 3.5.0 and
> earlier was correct (i.e. no error). This breaks several of the usage
> scenarios for classified artifacts...
>
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> Main
> MainJar
> jar
> 1
>
>
> ${project.groupId}
> ${project.artifactId}
> ${project.version}
> linux
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] erikhakansson commented on issue #49: [MNG-2802] Concurrent-safe access to local Maven repository
erikhakansson commented on issue #49: [MNG-2802] Concurrent-safe access to local Maven repository URL: https://github.com/apache/maven-wagon/pull/49#issuecomment-431325340 Can someone have a new look at this after my comments regarding System.exit? To reiterate, the System.exit isn't run in anything manaded by Surefire and thus shouldn't affect/be affected by surefire behaviour. LazyLockableFileOutputStreamTestDriver is never run by Surefire The test (LazyLockableFileOutputStreamIntegrationTest) launches two separate JVMs to be able to properly isolate file locking behaviour and not having different processes in the same JVM affect each other. I.e, simulating real world behaviour with different instances of Maven accessing the same file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-2802) Concurrent-safe access to local Maven repository
[ https://issues.apache.org/jira/browse/MNG-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656635#comment-16656635 ] ASF GitHub Bot commented on MNG-2802: - erikhakansson commented on issue #49: [MNG-2802] Concurrent-safe access to local Maven repository URL: https://github.com/apache/maven-wagon/pull/49#issuecomment-431325340 Can someone have a new look at this after my comments regarding System.exit? To reiterate, the System.exit isn't run in anything manaded by Surefire and thus shouldn't affect/be affected by surefire behaviour. LazyLockableFileOutputStreamTestDriver is never run by Surefire The test (LazyLockableFileOutputStreamIntegrationTest) launches two separate JVMs to be able to properly isolate file locking behaviour and not having different processes in the same JVM affect each other. I.e, simulating real world behaviour with different instances of Maven accessing the same file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Concurrent-safe access to local Maven repository > > > Key: MNG-2802 > URL: https://issues.apache.org/jira/browse/MNG-2802 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Stepan Roh >Assignee: John Casey >Priority: Major > Fix For: Issues to be reviewed for 3.x > > > It seems that access to local Maven repository is not concurrent-safe that is > multiple Mavens running in parallel may damage contents of local Maven > repository. It would be a nice improvement, because sharing of local > repository will lower the need for contacting any other repository. I know > that Maven proxy can be used, but that adds another layer which may > unnecessarily stress the machine it runs on. > *NOTE:* > http://takari.io/book/30-team-maven.html#concurrent-safe-local-repository is > a Takari Extension for Apache Maven that introduces a concurrent-safe > local-repository. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] erikhakansson edited a comment on issue #49: [MNG-2802] Concurrent-safe access to local Maven repository
erikhakansson edited a comment on issue #49: [MNG-2802] Concurrent-safe access to local Maven repository URL: https://github.com/apache/maven-wagon/pull/49#issuecomment-431325340 Can someone have a new look at this after my comments regarding System.exit? To reiterate, the System.exit isn't run in anything manaded by Surefire and thus shouldn't affect/be affected by surefire behaviour. LazyLockableFileOutputStreamTestDriver is never run by Surefire The test (LazyLockableFileOutputStreamIntegrationTest) launches two separate JVMs to be able to properly isolate file locking behaviour and not having different processes in the same JVM affect each other. I.e, simulating real world behaviour with different instances of Maven accessing the same file. @olamy This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-2802) Concurrent-safe access to local Maven repository
[ https://issues.apache.org/jira/browse/MNG-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656638#comment-16656638 ] ASF GitHub Bot commented on MNG-2802: - erikhakansson edited a comment on issue #49: [MNG-2802] Concurrent-safe access to local Maven repository URL: https://github.com/apache/maven-wagon/pull/49#issuecomment-431325340 Can someone have a new look at this after my comments regarding System.exit? To reiterate, the System.exit isn't run in anything manaded by Surefire and thus shouldn't affect/be affected by surefire behaviour. LazyLockableFileOutputStreamTestDriver is never run by Surefire The test (LazyLockableFileOutputStreamIntegrationTest) launches two separate JVMs to be able to properly isolate file locking behaviour and not having different processes in the same JVM affect each other. I.e, simulating real world behaviour with different instances of Maven accessing the same file. @olamy This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Concurrent-safe access to local Maven repository > > > Key: MNG-2802 > URL: https://issues.apache.org/jira/browse/MNG-2802 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Stepan Roh >Assignee: John Casey >Priority: Major > Fix For: Issues to be reviewed for 3.x > > > It seems that access to local Maven repository is not concurrent-safe that is > multiple Mavens running in parallel may damage contents of local Maven > repository. It would be a nice improvement, because sharing of local > repository will lower the need for contacting any other repository. I know > that Maven proxy can be used, but that adds another layer which may > unnecessarily stress the machine it runs on. > *NOTE:* > http://takari.io/book/30-team-maven.html#concurrent-safe-local-repository is > a Takari Extension for Apache Maven that introduces a concurrent-safe > local-repository. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MSHADE-302) maven-shade-plugin fails to minimize JAR with Java 11
Clément MATHIEU created MSHADE-302:
--
Summary: maven-shade-plugin fails to minimize JAR with Java 11
Key: MSHADE-302
URL: https://issues.apache.org/jira/browse/MSHADE-302
Project: Maven Shade Plugin
Issue Type: Bug
Environment: maven-shade-plugin 3.2.1-SNAPSHOT or master branch.
openjdk version "11" 2018-09-25
OpenJDK Runtime Environment 18.9 (build 11+28)
OpenJDK 64-Bit Server VM 18.9 (build 11+28, mixed mode)
Reporter: Clément MATHIEU
While checking whether maven-shade-plugin is Java 11 compatible or not, I
noticed that it fails when `minimizeJar` is set to `true` and a class contains
a nested static class.
I was able to reproduce the issue by patching the
`shading-with-java-11-sources` integration test:
{code}
diff --git a/src/it/shading-with-java-11-sources/pom.xml
b/src/it/shading-with-java-11-sources/pom.xml
index 0ea23fe..34898b7 100644
--- a/src/it/shading-with-java-11-sources/pom.xml
+++ b/src/it/shading-with-java-11-sources/pom.xml
@@ -76,2 +76,3 @@ under the License.
+ true
true
diff --git
a/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
b/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
index a92156e..c9fc298 100644
---
a/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
+++
b/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
@@ -49,2 +49,5 @@ public class App
}
+
+static class Foo {
+}
}
{code}
Running `mvn -Prun-its -Dinvoker.test="*java-11*" verify` leads to the
following exception
{code}
Caused by: java.lang.UnsupportedOperationException: This feature requires ASM7
at org.objectweb.asm.ClassVisitor.visitNestMember (ClassVisitor.java:236)
at org.objectweb.asm.ClassVisitor.visitNestMember (ClassVisitor.java:239)
at org.objectweb.asm.commons.ClassRemapper.visitNestMember
(ClassRemapper.java:190)
at org.objectweb.asm.ClassReader.accept (ClassReader.java:651)
at org.objectweb.asm.ClassReader.accept (ClassReader.java:391)
at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:179)
at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:140)
at org.apache.maven.plugins.shade.filter.MinijarFilter.
(MinijarFilter.java:97)
at org.apache.maven.plugins.shade.mojo.ShadeMojo.getFilters
(ShadeMojo.java:834)
at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute
(ShadeMojo.java:434)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:356)
{code}
I have not yet troubleshooted the issue. Other jdendency users seems to be
facing a similar issue, see https://github.com/tcurdt/jdependency/issues/21. I
have also seen a similar stack trace in Spring SPR-17371.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MSHADE-302) maven-shade-plugin fails to minimize JAR with Java 11
[
https://issues.apache.org/jira/browse/MSHADE-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clément MATHIEU updated MSHADE-302:
---
Description:
While checking whether maven-shade-plugin is Java 11 compatible or not, I
noticed that it fails when minimizeJar is set to true and a class contains a
nested static class.
I was able to reproduce the issue by patching the shading-with-java-11-sources
integration test:
{code}
diff --git a/src/it/shading-with-java-11-sources/pom.xml
b/src/it/shading-with-java-11-sources/pom.xml
index 0ea23fe..34898b7 100644
--- a/src/it/shading-with-java-11-sources/pom.xml
+++ b/src/it/shading-with-java-11-sources/pom.xml
@@ -76,2 +76,3 @@ under the License.
+ true
true
diff --git
a/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
b/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
index a92156e..c9fc298 100644
---
a/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
+++
b/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
@@ -49,2 +49,5 @@ public class App
}
+
+static class Foo {
+}
}
{code}
Running {{mvn -Prun-its -Dinvoker.test="*java-11*" verify}} leads to the
following exception
{code}
Caused by: java.lang.UnsupportedOperationException: This feature requires ASM7
at org.objectweb.asm.ClassVisitor.visitNestMember (ClassVisitor.java:236)
at org.objectweb.asm.ClassVisitor.visitNestMember (ClassVisitor.java:239)
at org.objectweb.asm.commons.ClassRemapper.visitNestMember
(ClassRemapper.java:190)
at org.objectweb.asm.ClassReader.accept (ClassReader.java:651)
at org.objectweb.asm.ClassReader.accept (ClassReader.java:391)
at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:179)
at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:140)
at org.apache.maven.plugins.shade.filter.MinijarFilter.
(MinijarFilter.java:97)
at org.apache.maven.plugins.shade.mojo.ShadeMojo.getFilters
(ShadeMojo.java:834)
at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute
(ShadeMojo.java:434)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:356)
{code}
I have not yet troubleshooted the issue. Other jdendency users seems to be
facing a similar issue, see https://github.com/tcurdt/jdependency/issues/21. I
have also seen a similar stack trace in Spring SPR-17371.
was:
While checking whether maven-shade-plugin is Java 11 compatible or not, I
noticed that it fails when `minimizeJar` is set to `true` and a class contains
a nested static class.
I was able to reproduce the issue by patching the
`shading-with-java-11-sources` integration test:
{code}
diff --git a/src/it/shading-with-java-11-sources/pom.xml
b/src/it/shading-with-java-11-sources/pom.xml
index 0ea23fe..34898b7 100644
--- a/src/it/shading-with-java-11-sources/pom.xml
+++ b/src/it/shading-with-java-11-sources/pom.xml
@@ -76,2 +7
[jira] [Commented] (MPMD-267) Running maven-pmd-plugin fails on missing HttpServletResponse
[ https://issues.apache.org/jira/browse/MPMD-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657130#comment-16657130 ] Andreas Dangel commented on MPMD-267: - [~vdotjansen]: Do you have a sample project? Or can you provide the logs when you run maven with debug output (-X)? > Running maven-pmd-plugin fails on missing HttpServletResponse > - > > Key: MPMD-267 > URL: https://issues.apache.org/jira/browse/MPMD-267 > Project: Maven PMD Plugin > Issue Type: Bug >Affects Versions: 3.10.0 > Environment: Java 8, Windows Server 2012 r2 >Reporter: Vincent Jansen >Priority: Major > > During running the verify phase on our project we get the following error in > one of our modules > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-pmd-plugin:3.10.0:pmd (pmd) on project > blueriq-component-dashboard: Execution pmd of goal > org.apache.maven.plugins:maven-pmd-plugin:3.10.0:pmd failed: A required class > was missing while executing > org.apache.maven.plugins:maven-pmd-plugin:3.10.0:pmd: > javax/servlet/http/HttpServletResponse > [ERROR] - > [ERROR] realm =plugin>org.apache.maven.plugins:maven-pmd-plugin:3.10.0 > [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy > Could you check why this is? > In maven-PMD-plugin 3.9.0 we did not have this error. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MPMD-274) Release version 3.11.0
[ https://issues.apache.org/jira/browse/MPMD-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel reassigned MPMD-274: --- Assignee: Andreas Dangel > Release version 3.11.0 > -- > > Key: MPMD-274 > URL: https://issues.apache.org/jira/browse/MPMD-274 > Project: Maven PMD Plugin > Issue Type: Task > Components: PMD >Affects Versions: 3.11.0 >Reporter: Vimal David >Assignee: Andreas Dangel >Priority: Major > > All of the [issues > |https://issues.apache.org/jira/browse/MPMD-272?jql=project%20%3D%20MPMD%20AND%20fixVersion%20%3D%203.11.0] > for the version 3.11.0 have been fixed. Release the Plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPMD-274) Release version 3.11.0
[ https://issues.apache.org/jira/browse/MPMD-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657149#comment-16657149 ] Andreas Dangel commented on MPMD-274: - I'll plan to wait for PMD 6.9.0 (which should be released end of this month), since it has one bugfix, that maybe fixes already MPMD-267. > Release version 3.11.0 > -- > > Key: MPMD-274 > URL: https://issues.apache.org/jira/browse/MPMD-274 > Project: Maven PMD Plugin > Issue Type: Task > Components: PMD >Affects Versions: 3.11.0 >Reporter: Vimal David >Assignee: Andreas Dangel >Priority: Major > > All of the [issues > |https://issues.apache.org/jira/browse/MPMD-272?jql=project%20%3D%20MPMD%20AND%20fixVersion%20%3D%203.11.0] > for the version 3.11.0 have been fixed. Release the Plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Issue with apache.maven.plugins:maven-pmd-plugin:3.10.0 under jdk11
Hi, I'm trying to migrate my project from jdk8 to jdk11, but when I switch to jdk11, and run my build, an error message came out: org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.10.0:pmd (pmd) on project : Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.10.0:pmd failed: Plugin org.apache.maven.plugins:maven-pmd-plugin:3.10.0 or one of its dependencies could not be resolved: Could not find artifact com.sun:tools:jar:1.7.0 at specified path /usr/java/jdk-11.0.1/../lib/tools.jar I know that JDK11 removed tools.jar, so how can I make my build work with jdk11? Thanks, Stanley
[jira] [Commented] (MSHADE-302) maven-shade-plugin fails to minimize JAR with Java 11
[
https://issues.apache.org/jira/browse/MSHADE-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657512#comment-16657512
]
Clément MATHIEU commented on MSHADE-302:
Jdependency maintainer just pushed a fix which fix my test case (while asm 7.0
was in the classpath, jdependency forgot to switch to opcodes 7). I will test
that more thoroughly next week and submit a patch as soon as a new jdependency
version is released.
> maven-shade-plugin fails to minimize JAR with Java 11
> -
>
> Key: MSHADE-302
> URL: https://issues.apache.org/jira/browse/MSHADE-302
> Project: Maven Shade Plugin
> Issue Type: Bug
> Environment: maven-shade-plugin 3.2.1-SNAPSHOT or master branch.
> openjdk version "11" 2018-09-25
> OpenJDK Runtime Environment 18.9 (build 11+28)
> OpenJDK 64-Bit Server VM 18.9 (build 11+28, mixed mode)
>Reporter: Clément MATHIEU
>Priority: Major
>
> While checking whether maven-shade-plugin is Java 11 compatible or not, I
> noticed that it fails when minimizeJar is set to true and a class contains a
> nested static class.
> I was able to reproduce the issue by patching the
> shading-with-java-11-sources integration test:
> {code}
> diff --git a/src/it/shading-with-java-11-sources/pom.xml
> b/src/it/shading-with-java-11-sources/pom.xml
> index 0ea23fe..34898b7 100644
> --- a/src/it/shading-with-java-11-sources/pom.xml
> +++ b/src/it/shading-with-java-11-sources/pom.xml
> @@ -76,2 +76,3 @@ under the License.
>
> + true
>true
> diff --git
> a/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
>
> b/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
> index a92156e..c9fc298 100644
> ---
> a/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
> +++
> b/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
> @@ -49,2 +49,5 @@ public class App
> }
> +
> +static class Foo {
> +}
> }
> {code}
>
> Running {{mvn -Prun-its -Dinvoker.test="*java-11*" verify}} leads to the
> following exception
> {code}
> Caused by: java.lang.UnsupportedOperationException: This feature requires ASM7
> at org.objectweb.asm.ClassVisitor.visitNestMember (ClassVisitor.java:236)
> at org.objectweb.asm.ClassVisitor.visitNestMember (ClassVisitor.java:239)
> at org.objectweb.asm.commons.ClassRemapper.visitNestMember
> (ClassRemapper.java:190)
> at org.objectweb.asm.ClassReader.accept (ClassReader.java:651)
> at org.objectweb.asm.ClassReader.accept (ClassReader.java:391)
> at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:179)
> at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:140)
> at org.apache.maven.plugins.shade.filter.MinijarFilter.
> (MinijarFilter.java:97)
> at org.apache.maven.plugins.shade.mojo.ShadeMojo.getFilters
> (ShadeMojo.java:834)
> at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute
> (ShadeMojo.java:434)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Lau
