[GitHub] cloorc commented on issue #52: add --cached option for git rm

2018-08-25 Thread GitBox
cloorc commented on issue #52: add --cached option for git rm
URL: https://github.com/apache/maven-scm/pull/52#issuecomment-415963792
 
 
   Just leave me a chance to keep the files this plugin is going to remove. It 
was a long period since the last time I posted this PR. Without this chance, 
you may lost these files before you confirm it. BTW, it's could be a small 
change that many developers do not care, how about just close this PR? That's 
it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloorc closed pull request #52: add --cached option for git rm

2018-08-25 Thread GitBox
cloorc closed pull request #52: add --cached option for git rm
URL: https://github.com/apache/maven-scm/pull/52
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/pom.xml 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/pom.xml
index b37527b46..1cdb14dee 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/pom.xml
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/pom.xml
@@ -67,7 +67,7 @@
 
   generate-metadata
 
-  
+  
 
   
 
diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/remove/GitRemoveCommand.java
 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/remove/GitRemoveCommand.java
index 604cfe404..680b4045f 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/remove/GitRemoveCommand.java
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/remove/GitRemoveCommand.java
@@ -99,6 +99,8 @@ public static Commandline createCommandLine( File 
workingDirectory, List f
 
 GitCommandLineUtils.addTarget( cl, files );
 
+cl.createArg().setValue("--cached");
+
 return cl;
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MENFORCER-274) Use of RequireJavaVersion with Java-9 breaking starting at b175

2018-08-25 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MENFORCER-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592569#comment-16592569
 ] 

Hudson commented on MENFORCER-274:
--

SUCCESS: Integrated in Jenkins build axiom-trunk #2942 (See 
[https://builds.apache.org/job/axiom-trunk/2942/])
Upgrade maven-enforcer-plugin to avoid MENFORCER-274. (veithen: rev 1839028)
* (edit) axiom/pom.xml
* (edit) axiom/systests/psychopath-tests/pom.xml


> Use of RequireJavaVersion with Java-9 breaking starting at b175
> ---
>
> Key: MENFORCER-274
> URL: https://issues.apache.org/jira/browse/MENFORCER-274
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Standard Rules
>Affects Versions: 1.4.1
>Reporter: Peter Ansell
>Assignee: Guillaume Boué
>Priority: Major
> Fix For: 3.0.0-M1, 3.0.0-M2, 3.0.0
>
>
> The Oracle JDK9 changed from showing a version string of "9-ea" to simply "9" 
> in build 175. 
> This caused the RequireJavaVersion rule that was previously working with 
> "9-ea" to start breaking.
> The break may be due to its use of commons-lang:2, rather than 
> commons-lang3:3.5+ where parsing should work for the newer style of Java 
> versions, but not clear why it started to fail now.
> Stack trace is:
> {noformat}
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:183)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   ... 20 more
> Caused by: org.apache.maven.plugin.PluginContainerException: An API 
> incompatibility was encountered while executing 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce: 
> java.lang.ExceptionInInitializerError: null
> -
> realm =plugin>org.apache.maven.plugins:maven-enforcer-plugin:1.4.1
> strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> urls[0] = 
> file:/home/mint/.m2/repository/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.jar
> urls[1] = 
> file:/home/mint/.m2/repository/org/codehaus/mojo/extra-enforcer-rules/1.0-beta-6/extra-enforcer-rules-1.0-beta-6.jar
> urls[2] = 
> file:/home/mint/.m2/repository/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.jar
> urls[3] = 
> file:/home/mint/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> urls[4] = 
> file:/home/mint/.m2/repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar
> urls[5] = 
> file:/home/mint/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/1.4/maven-common-artifact-filters-1.4.jar
> urls[6] = file:/home/mint/.m2/repository/com/ibm/icu/icu4j/56.1/icu4j-56.1.jar
> urls[7] = 
> file:/home/mint/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
> urls[8] = 
> file:/home/mint/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
> urls[9] = 
> file:/home/mint/.m2/repository/org/slf4j/slf4j-jdk14/1.5.6/slf4j-jdk14-1.5.6.jar
> urls[10] = 
> file:/home/mint/.m2/repository/org/slf4j/jcl-over-slf4j/1.5.6/jcl-over-slf4j-1.5.6.jar
> urls[11] = 
> file:/home/mint/.m2/repository/org/apache/maven/reporting/maven-reporting-api/2.2.1/maven-reporting-api-2.2.1.jar
> urls[12] = 
> file:/home/mint/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.jar
> urls[13] = 
> file:/home/mint/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.jar
> urls[14] = 
> file:/home/mint/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar
> urls[15] = 
> file:/home/mint/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
> urls[16] = 
> file:/home/mint/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
> urls[17] = 
> file:/home/mint/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
> urls[18] = 
> file:/home/mint/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.jar
> urls[19] = 
> file:/home/mint/.m2/repository/commons-lang/commons-lang/2.3/commons-lang-2.3.jar
> urls[20] = 
> file:/home/mint/.m2/repository/org/apache/maven/enforcer/enforcer-api/1.4.1/enforcer-api-1.4.1.jar
> urls[21] = 
> file:/home/mint/.m2/repository/org/apache/maven/enforcer/enforcer-rules/1.4.1/enforcer-rules-1.4.1.jar
> urls[22] = 
> file:/home/mint/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar
> urls[23] = 
> file:/home/mint/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-6/plexus-i18n-1.0-beta-6.jar
> urls[24] = 
> file:/home/mint/.m2/repository/org/apache/maven/

[jira] [Updated] (WAGON-524) Deploy fails with AuthorizationException "Forbidden"

2018-08-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/WAGON-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hüseyin Kartal updated WAGON-524:
-
Attachment: litmus.log

> Deploy fails with AuthorizationException "Forbidden"
> 
>
> Key: WAGON-524
> URL: https://issues.apache.org/jira/browse/WAGON-524
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-webdav
>Affects Versions: 3.1.0
>Reporter: Hüseyin Kartal
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: deployX.txt, deployX2.txt, litmus.log, webdav.zip
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I try to deploy my artifacts to an WebDAV server. Via HTTPS.
> If the directory structure is missing (empty) the deployment of the artifacts 
> fails.
> {{c:\DEV\webdav>mvn deploy}}
>  {{[INFO] Scanning for projects...}}
>  {{[INFO]}}
>  {{[INFO] --< org.wagon:webdav 
> >--}}
>  {{[INFO] Building webdav 0.0.1-SNAPSHOT}}
>  {{[INFO] [ pom 
> ]-}}
>  {{[INFO]}}
>  {{[INFO] — maven-install-plugin:2.4:install (default-install) @ webdav ---}}
>  {{[INFO] Installing c:\DEV\webdav\pom.xml to 
> C:\Users\x\.m2\repository\org\wagon\webdav\0.0.1-SNAPSHOT\webdav-0.0.1-SNAPSHOT.pom}}
>  {{[INFO]}}
>  {{[INFO] — maven-deploy-plugin:2.8.2:deploy (default-deploy) @ webdav ---}}
>  {{[INFO] Downloading from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]}}
>  {{[INFO] Uploading to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180809.152257-1.pom]}}
>  {{[INFO] 
> }}
>  {{[INFO] BUILD FAILURE}}
>  {{[INFO] 
> }}
>  {{[INFO] Total time: 2.497 s}}
>  {{[INFO] Finished at: 2018-08-09T17:22:58+02:00}}
>  {{[INFO] 
> }}
>  {{[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on 
> project webdav: Failed to deploy artifacts: Could not transfer artifact 
> org.wagon}}
>  {{:(webdav:pom:0.0.1-20180809.152257-1 from/to private-repo 
> ([https://webdav.magentacloud.de):|https://webdav.magentacloud.de%29/] Access 
> denied to: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180]}}
>  {{809.152257-1.pom, ReasonPhrase: Forbidden. -> [Help 1]}}
>  {{[ERROR]}}
>  {{[ERROR] To see the full stack trace of the errors, re-run Maven with the 
> -e switch.}}
>  {{[ERROR] Re-run Maven using the -X switch to enable full debug logging.}}
>  {{[ERROR]}}
>  {{[ERROR] For more information about the errors and possible solutions, 
> please read the following articles:}}
>  {{[ERROR] [Help 1] 
> [http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException]}}{{c:\DEV\repo\git\webdav>}}
>  
> But if you create the expected directories manualy the deployment succeeds.
> {{c:\DEV\webdav>mvn deploy}}
>  {{[INFO] Scanning for projects...}}
>  {{[INFO]}}
>  {{[INFO] --< org.wagon:webdav 
> >--}}
>  {{[INFO] Building webdav 0.0.1-SNAPSHOT}}
>  {{[INFO] [ pom 
> ]-}}
>  {{[INFO]}}
>  {{[INFO] — maven-install-plugin:2.4:install (default-install) @ webdav ---}}
>  {{[INFO] Installing c:\DEV\webdav\pom.xml to 
> C:\Users\x\.m2\repository\org\wagon\webdav\0.0.1-SNAPSHOT\webdav-0.0.1-SNAPSHOT.pom}}
>  {{[INFO]}}
>  {{[INFO] — maven-deploy-plugin:2.8.2:deploy (default-deploy) @ webdav ---}}
>  {{[INFO] Downloading from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]}}
>  {{[INFO] Downloaded from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]
>  (592 B at 407 B/s)}}
>  {{[INFO] Uploading to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180809.152158-3.pom]}}
>  {{[INFO] Uploaded to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180809.152158-3.pom]
>  (1.4 kB at 2.9 kB/s)}}
>  {{[INFO] Downloading from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/maven-metadata.xml]}}
>  {{[INFO] Downloaded from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/maven-metadata.xml] (275 B 
> at 1.9 kB/s)}}
>  {{[INFO] Uploading to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]}}
>  {{[INFO] Uploaded to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/w

[jira] [Commented] (WAGON-524) Deploy fails with AuthorizationException "Forbidden"

2018-08-25 Thread JIRA


[ 
https://issues.apache.org/jira/browse/WAGON-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592587#comment-16592587
 ] 

Hüseyin Kartal commented on WAGON-524:
--

Run the litmus test-suite against my WebDAV server. Everything seems OK.

Also tested Windows and Linux integration of WebDAV into the OS and creation of 
folders and files works without problems.

So it look like the misbehavior is on the maven plugin side.

[^litmus.log]

> Deploy fails with AuthorizationException "Forbidden"
> 
>
> Key: WAGON-524
> URL: https://issues.apache.org/jira/browse/WAGON-524
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-webdav
>Affects Versions: 3.1.0
>Reporter: Hüseyin Kartal
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: deployX.txt, deployX2.txt, litmus.log, webdav.zip
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I try to deploy my artifacts to an WebDAV server. Via HTTPS.
> If the directory structure is missing (empty) the deployment of the artifacts 
> fails.
> {{c:\DEV\webdav>mvn deploy}}
>  {{[INFO] Scanning for projects...}}
>  {{[INFO]}}
>  {{[INFO] --< org.wagon:webdav 
> >--}}
>  {{[INFO] Building webdav 0.0.1-SNAPSHOT}}
>  {{[INFO] [ pom 
> ]-}}
>  {{[INFO]}}
>  {{[INFO] — maven-install-plugin:2.4:install (default-install) @ webdav ---}}
>  {{[INFO] Installing c:\DEV\webdav\pom.xml to 
> C:\Users\x\.m2\repository\org\wagon\webdav\0.0.1-SNAPSHOT\webdav-0.0.1-SNAPSHOT.pom}}
>  {{[INFO]}}
>  {{[INFO] — maven-deploy-plugin:2.8.2:deploy (default-deploy) @ webdav ---}}
>  {{[INFO] Downloading from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]}}
>  {{[INFO] Uploading to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180809.152257-1.pom]}}
>  {{[INFO] 
> }}
>  {{[INFO] BUILD FAILURE}}
>  {{[INFO] 
> }}
>  {{[INFO] Total time: 2.497 s}}
>  {{[INFO] Finished at: 2018-08-09T17:22:58+02:00}}
>  {{[INFO] 
> }}
>  {{[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on 
> project webdav: Failed to deploy artifacts: Could not transfer artifact 
> org.wagon}}
>  {{:(webdav:pom:0.0.1-20180809.152257-1 from/to private-repo 
> ([https://webdav.magentacloud.de):|https://webdav.magentacloud.de%29/] Access 
> denied to: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180]}}
>  {{809.152257-1.pom, ReasonPhrase: Forbidden. -> [Help 1]}}
>  {{[ERROR]}}
>  {{[ERROR] To see the full stack trace of the errors, re-run Maven with the 
> -e switch.}}
>  {{[ERROR] Re-run Maven using the -X switch to enable full debug logging.}}
>  {{[ERROR]}}
>  {{[ERROR] For more information about the errors and possible solutions, 
> please read the following articles:}}
>  {{[ERROR] [Help 1] 
> [http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException]}}{{c:\DEV\repo\git\webdav>}}
>  
> But if you create the expected directories manualy the deployment succeeds.
> {{c:\DEV\webdav>mvn deploy}}
>  {{[INFO] Scanning for projects...}}
>  {{[INFO]}}
>  {{[INFO] --< org.wagon:webdav 
> >--}}
>  {{[INFO] Building webdav 0.0.1-SNAPSHOT}}
>  {{[INFO] [ pom 
> ]-}}
>  {{[INFO]}}
>  {{[INFO] — maven-install-plugin:2.4:install (default-install) @ webdav ---}}
>  {{[INFO] Installing c:\DEV\webdav\pom.xml to 
> C:\Users\x\.m2\repository\org\wagon\webdav\0.0.1-SNAPSHOT\webdav-0.0.1-SNAPSHOT.pom}}
>  {{[INFO]}}
>  {{[INFO] — maven-deploy-plugin:2.8.2:deploy (default-deploy) @ webdav ---}}
>  {{[INFO] Downloading from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]}}
>  {{[INFO] Downloaded from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]
>  (592 B at 407 B/s)}}
>  {{[INFO] Uploading to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180809.152158-3.pom]}}
>  {{[INFO] Uploaded to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180809.152158-3.pom]
>  (1.4 kB at 2.9 kB/s)}}
>  {{[INFO] Downloading from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/maven-metadata.xml]}}
>  {{[INFO] Downloaded from private-repo: 
> [

[GitHub] michael-o commented on issue #52: add --cached option for git rm

2018-08-25 Thread GitBox
michael-o commented on issue #52: add --cached option for git rm
URL: https://github.com/apache/maven-scm/pull/52#issuecomment-415974342
 
 
   I did not intend to close, but merely wanted to point out that if you really 
need it, a command param is the way to go. There is a sample commit you can 
build on if you like.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (WAGON-524) Deploy fails with AuthorizationException "Forbidden"

2018-08-25 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/WAGON-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592610#comment-16592610
 ] 

Michael Osipov commented on WAGON-524:
--

I cannot see any of these tests performing some kind of auth and any authz. It 
is pretty hard to find the issue here and I haven't seen anything to prove it. 
Did you try with CarrotDAV?

> Deploy fails with AuthorizationException "Forbidden"
> 
>
> Key: WAGON-524
> URL: https://issues.apache.org/jira/browse/WAGON-524
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-webdav
>Affects Versions: 3.1.0
>Reporter: Hüseyin Kartal
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: deployX.txt, deployX2.txt, litmus.log, webdav.zip
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I try to deploy my artifacts to an WebDAV server. Via HTTPS.
> If the directory structure is missing (empty) the deployment of the artifacts 
> fails.
> {{c:\DEV\webdav>mvn deploy}}
>  {{[INFO] Scanning for projects...}}
>  {{[INFO]}}
>  {{[INFO] --< org.wagon:webdav 
> >--}}
>  {{[INFO] Building webdav 0.0.1-SNAPSHOT}}
>  {{[INFO] [ pom 
> ]-}}
>  {{[INFO]}}
>  {{[INFO] — maven-install-plugin:2.4:install (default-install) @ webdav ---}}
>  {{[INFO] Installing c:\DEV\webdav\pom.xml to 
> C:\Users\x\.m2\repository\org\wagon\webdav\0.0.1-SNAPSHOT\webdav-0.0.1-SNAPSHOT.pom}}
>  {{[INFO]}}
>  {{[INFO] — maven-deploy-plugin:2.8.2:deploy (default-deploy) @ webdav ---}}
>  {{[INFO] Downloading from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]}}
>  {{[INFO] Uploading to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180809.152257-1.pom]}}
>  {{[INFO] 
> }}
>  {{[INFO] BUILD FAILURE}}
>  {{[INFO] 
> }}
>  {{[INFO] Total time: 2.497 s}}
>  {{[INFO] Finished at: 2018-08-09T17:22:58+02:00}}
>  {{[INFO] 
> }}
>  {{[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on 
> project webdav: Failed to deploy artifacts: Could not transfer artifact 
> org.wagon}}
>  {{:(webdav:pom:0.0.1-20180809.152257-1 from/to private-repo 
> ([https://webdav.magentacloud.de):|https://webdav.magentacloud.de%29/] Access 
> denied to: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180]}}
>  {{809.152257-1.pom, ReasonPhrase: Forbidden. -> [Help 1]}}
>  {{[ERROR]}}
>  {{[ERROR] To see the full stack trace of the errors, re-run Maven with the 
> -e switch.}}
>  {{[ERROR] Re-run Maven using the -X switch to enable full debug logging.}}
>  {{[ERROR]}}
>  {{[ERROR] For more information about the errors and possible solutions, 
> please read the following articles:}}
>  {{[ERROR] [Help 1] 
> [http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException]}}{{c:\DEV\repo\git\webdav>}}
>  
> But if you create the expected directories manualy the deployment succeeds.
> {{c:\DEV\webdav>mvn deploy}}
>  {{[INFO] Scanning for projects...}}
>  {{[INFO]}}
>  {{[INFO] --< org.wagon:webdav 
> >--}}
>  {{[INFO] Building webdav 0.0.1-SNAPSHOT}}
>  {{[INFO] [ pom 
> ]-}}
>  {{[INFO]}}
>  {{[INFO] — maven-install-plugin:2.4:install (default-install) @ webdav ---}}
>  {{[INFO] Installing c:\DEV\webdav\pom.xml to 
> C:\Users\x\.m2\repository\org\wagon\webdav\0.0.1-SNAPSHOT\webdav-0.0.1-SNAPSHOT.pom}}
>  {{[INFO]}}
>  {{[INFO] — maven-deploy-plugin:2.8.2:deploy (default-deploy) @ webdav ---}}
>  {{[INFO] Downloading from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]}}
>  {{[INFO] Downloaded from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/maven-metadata.xml]
>  (592 B at 407 B/s)}}
>  {{[INFO] Uploading to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180809.152158-3.pom]}}
>  {{[INFO] Uploaded to private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/0.0.1-SNAPSHOT/webdav-0.0.1-20180809.152158-3.pom]
>  (1.4 kB at 2.9 kB/s)}}
>  {{[INFO] Downloading from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/maven-metadata.xml]}}
>  {{[INFO] Downloaded from private-repo: 
> [https://webdav.magentacloud.de/org/wagon/webdav/maven-metadata.xml] (275 B 
> at 1.9 k

[jira] [Assigned] (MRELEASE-1010) Upgrade maven-plugins parent to version 32

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MRELEASE-1010:
-

Assignee: Karl Heinz Marbaise

> Upgrade maven-plugins parent to version 32
> --
>
> Key: MRELEASE-1010
> URL: https://issues.apache.org/jira/browse/MRELEASE-1010
> Project: Maven Release Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SUREFIRE-1556) Test XML file is not valid when rerun "fails" with an assumption

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana reassigned SUREFIRE-1556:
--

Assignee: Tibor Digana

> Test XML file is not valid when rerun "fails" with an assumption
> 
>
> Key: SUREFIRE-1556
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1556
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.21.0, 2.22.0
>Reporter: Michael Weisgrab
>Assignee: Tibor Digana
>Priority: Blocker
> Attachments: TEST-asdf.SearchTest_assumption_valid.xml, 
> TEST-asdf.SearchTest_rerun_assumption_invalid.xml, 
> TEST-asdf.SearchTest_rerun_fail_valid.xml
>
>
> We are running UI tests and are doing one retry if there is a bug.
> When a test fails with an Exception on the first try and the second try is 
> skipped by an assumption violation the resulting test report xml file is not 
> valid (not well formatted xml file).
> When the test is skipped on the first try or both runs fail with an exception 
> everything is ok.
> This is a testcase which is retried and a valid xml is generated.
>  
> {code:java}
> 
> 
> ...
> 
> 
> ...
> 
> 
> ...
> 
> 
> ...
> 
> ...
> 
> 
> ...
> 
> 
> {code}
>  
>  
> Here is a generated invalid xml. The rerunError tag is missing. The retry 
> "error" is an assumption violation so the test should be marked as skipped 
> with message of the assumptionviolation.
> {code:java}
> 
>   
>   
>   
> ...
>   
>   
> ...
>   
>   < message="There should be a list of ads!">
> 
>   ...
> 
> 
>   ...
> 
>   
> 
> {code}
> I have attached the following files:
>  * TEST-asdf.SearchTest_assumption_valid.xml (assumption violation in the 
> first test run)
>  * TEST-asdf.SearchTest_rerun_fail_valid.xml (both runs throw exception)
>  * TEST-asdf.SearchTest_rerun_assumption_invalid.xml (first run exception - 
> second run assumption violation)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SUREFIRE-1556) Test XML file is not valid when rerun "fails" with an assumption

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592632#comment-16592632
 ] 

Tibor Digana commented on SUREFIRE-1556:


Thx for finding it. I found another issue where XML is invalid. I am going to 
change the XSD for the elements {{rerunError}}, {{rerunFailure}}, 
{{flakyFailure}}, {{flakyError}}. Most probably Jenkins/Travis plugins would 
have to adapt.

Can you help us with writing an integration test for this issue and debug the 
marshaller class {{StatelessXmlReporter}} at least? Perhaps the logic does not 
consider this case. But the logic should evaluate the last successful run or 
take the failure/error as it is.

> Test XML file is not valid when rerun "fails" with an assumption
> 
>
> Key: SUREFIRE-1556
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1556
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.21.0, 2.22.0
>Reporter: Michael Weisgrab
>Assignee: Tibor Digana
>Priority: Blocker
> Attachments: TEST-asdf.SearchTest_assumption_valid.xml, 
> TEST-asdf.SearchTest_rerun_assumption_invalid.xml, 
> TEST-asdf.SearchTest_rerun_fail_valid.xml
>
>
> We are running UI tests and are doing one retry if there is a bug.
> When a test fails with an Exception on the first try and the second try is 
> skipped by an assumption violation the resulting test report xml file is not 
> valid (not well formatted xml file).
> When the test is skipped on the first try or both runs fail with an exception 
> everything is ok.
> This is a testcase which is retried and a valid xml is generated.
>  
> {code:java}
> 
> 
> ...
> 
> 
> ...
> 
> 
> ...
> 
> 
> ...
> 
> ...
> 
> 
> ...
> 
> 
> {code}
>  
>  
> Here is a generated invalid xml. The rerunError tag is missing. The retry 
> "error" is an assumption violation so the test should be marked as skipped 
> with message of the assumptionviolation.
> {code:java}
> 
>   
>   
>   
> ...
>   
>   
> ...
>   
>   < message="There should be a list of ads!">
> 
>   ...
> 
> 
>   ...
> 
>   
> 
> {code}
> I have attached the following files:
>  * TEST-asdf.SearchTest_assumption_valid.xml (assumption violation in the 
> first test run)
>  * TEST-asdf.SearchTest_rerun_fail_valid.xml (both runs throw exception)
>  * TEST-asdf.SearchTest_rerun_assumption_invalid.xml (first run exception - 
> second run assumption violation)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SUREFIRE-1408) Surefire shows random tests failing with fork issue when one of the tests hangs

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592635#comment-16592635
 ] 

Tibor Digana commented on SUREFIRE-1408:


[~Hronom] New Version {{2.22.0}} was released and one issue related to 
Linux/Docker was fixed. Let me know how this version is in your project. See 
the 
[https://maven.apache.org/surefire/maven-surefire-plugin/docker.html|documentation]
 and the image {{maven:3.5.3-jdk-8-alpine}} which contains {{ps}}. Surefire 
uses process {{ps}}. Thx.
I have one more question. Do you use configuration parameter {{parallel}} in 
surefire? It can be related to 
[https://issues.apache.org/jira/browse/SUREFIRE-1430|SUREFIRE-1430].

> Surefire shows random tests failing with fork issue when one of the tests 
> hangs
> ---
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> This was blocking 100% of test runs. Random tests were failing due to fork 
> issue. Which made us really confused on what is happening. We tried a lot of 
> options to fix this (fix memory,ulimits,sys.exit etc.)
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO] 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE 
> [28:40.637s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: There are test failures.
> [ERROR] 
> [ERROR] Please refer to 
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the 
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying 
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server && 
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m 
> -Xms1024m -jar 
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
>  /tmp/ambari_test_java/ambari-server/target/surefire 
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp 
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying 
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server && 
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m 
> -Xms1024m -jar 
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
>  /tmp/ambari_test_java/ambari-server/target/surefire 
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp 
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying 
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server && 
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m 
> -Xms1024m -jar 
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
>  /tmp/ambari_test_java/ambari-server/target/surefire 
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp 
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] 
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminate

[jira] [Created] (SUREFIRE-1559) XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should contain element stackTrace and should not be simpleContent.

2018-08-25 Thread Tibor Digana (JIRA)
Tibor Digana created SUREFIRE-1559:
--

 Summary: XML Report elements rerunError, rerunFailure, 
flakyFailure, flakyError should contain element stackTrace and should not be 
simpleContent.
 Key: SUREFIRE-1559
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1559
 Project: Maven Surefire
  Issue Type: Bug
  Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
Surefire Report Plugin, xml generation
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 2.22.1






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SUREFIRE-1559) XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should contain element stackTrace and should not be simpleContent.

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1559:
---
Description: 
The problem is that XML is invalid
simpleContent

> XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should 
> contain element stackTrace and should not be simpleContent.
> -
>
> Key: SUREFIRE-1559
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1559
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
> Surefire Report Plugin, xml generation
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.1
>
>
> The problem is that XML is invalid
> simpleContent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SUREFIRE-1559) XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should contain element stackTrace and should not be simpleContent.

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1559:
---
Description: 
The problem is that XML is invalid due to {{rerunError, rerunFailure, 
flakyFailure, flakyError}} are
simpleContent having stack trace as XML value and elements {{system-out}}, 
{{system-err}} which belong to complexType. The Jenkins and Travis should be 
informed about this fix and their plugins should adapt.

  was:
The problem is that XML is invalid
simpleContent


> XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should 
> contain element stackTrace and should not be simpleContent.
> -
>
> Key: SUREFIRE-1559
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1559
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
> Surefire Report Plugin, xml generation
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.1
>
>
> The problem is that XML is invalid due to {{rerunError, rerunFailure, 
> flakyFailure, flakyError}} are
> simpleContent having stack trace as XML value and elements {{system-out}}, 
> {{system-err}} which belong to complexType. The Jenkins and Travis should be 
> informed about this fix and their plugins should adapt.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] turbanoff opened a new pull request #6: Use java7 features

2018-08-25 Thread GitBox
turbanoff opened a new pull request #6: Use java7 features
URL: https://github.com/apache/maven-assembly-plugin/pull/6
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (SUREFIRE-1559) XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should contain element stackTrace and should not be simpleContent.

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1559:
---
Description: 
The problem is that XML is invalid due to {{rerunError, rerunFailure, 
flakyFailure, flakyError}} are
simpleContent having stack trace as simple XML string-value. Additionally, it 
contains elements {{system-out}}, {{system-err}} which belong to complexType. 
The Jenkins and Travis should be informed about this fix and their plugins 
should adapt.

  was:
The problem is that XML is invalid due to {{rerunError, rerunFailure, 
flakyFailure, flakyError}} are
simpleContent having stack trace as XML value and elements {{system-out}}, 
{{system-err}} which belong to complexType. The Jenkins and Travis should be 
informed about this fix and their plugins should adapt.


> XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should 
> contain element stackTrace and should not be simpleContent.
> -
>
> Key: SUREFIRE-1559
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1559
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
> Surefire Report Plugin, xml generation
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.1
>
>
> The problem is that XML is invalid due to {{rerunError, rerunFailure, 
> flakyFailure, flakyError}} are
> simpleContent having stack trace as simple XML string-value. Additionally, it 
> contains elements {{system-out}}, {{system-err}} which belong to complexType. 
> The Jenkins and Travis should be informed about this fix and their plugins 
> should adapt.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SUREFIRE-1559) XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should contain element stackTrace and should not be simpleContent.

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1559:
---
Description: 
The problem is that XML is invalid due to {{rerunError, rerunFailure, 
flakyFailure, flakyError}} are
{{simpleContent}} having stack trace as simple XML string-value. Additionally, 
it contains elements {{system-out}}, {{system-err}} which belong to 
complexType. The Jenkins and Travis should be informed about this fix and their 
plugins should adapt.

These elements should be {{complexType}} and the value of {{simpleContent}} 
should appear in new element {{stackTrace}}.

  was:
The problem is that XML is invalid due to {{rerunError, rerunFailure, 
flakyFailure, flakyError}} are
simpleContent having stack trace as simple XML string-value. Additionally, it 
contains elements {{system-out}}, {{system-err}} which belong to complexType. 
The Jenkins and Travis should be informed about this fix and their plugins 
should adapt.


> XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should 
> contain element stackTrace and should not be simpleContent.
> -
>
> Key: SUREFIRE-1559
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1559
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
> Surefire Report Plugin, xml generation
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.1
>
>
> The problem is that XML is invalid due to {{rerunError, rerunFailure, 
> flakyFailure, flakyError}} are
> {{simpleContent}} having stack trace as simple XML string-value. 
> Additionally, it contains elements {{system-out}}, {{system-err}} which 
> belong to complexType. The Jenkins and Travis should be informed about this 
> fix and their plugins should adapt.
> These elements should be {{complexType}} and the value of {{simpleContent}} 
> should appear in new element {{stackTrace}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SUREFIRE-1559) XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should contain element stackTrace and should not be simpleContent.

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1559:
---
Description: 
The problem is that XML is invalid due to {{rerunError, rerunFailure, 
flakyFailure, flakyError}} are
{{simpleContent}} having stack trace as simple XML string-value. Additionally, 
it contains elements {{system-out}}, {{system-err}} which belong to 
complexType. The Jenkins and Travis should be informed about this fix and their 
plugins should adapt.

These elements should be {{complexType}} and the value of {{simpleContent}} 
should appear in new element {{stackTrace}}.

https://github.com/travis-ci/travis-ci/issues/10033
https://issues.jenkins-ci.org/browse/JENKINS-53237

  was:
The problem is that XML is invalid due to {{rerunError, rerunFailure, 
flakyFailure, flakyError}} are
{{simpleContent}} having stack trace as simple XML string-value. Additionally, 
it contains elements {{system-out}}, {{system-err}} which belong to 
complexType. The Jenkins and Travis should be informed about this fix and their 
plugins should adapt.

These elements should be {{complexType}} and the value of {{simpleContent}} 
should appear in new element {{stackTrace}}.


> XML Report elements rerunError, rerunFailure, flakyFailure, flakyError should 
> contain element stackTrace and should not be simpleContent.
> -
>
> Key: SUREFIRE-1559
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1559
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
> Surefire Report Plugin, xml generation
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.1
>
>
> The problem is that XML is invalid due to {{rerunError, rerunFailure, 
> flakyFailure, flakyError}} are
> {{simpleContent}} having stack trace as simple XML string-value. 
> Additionally, it contains elements {{system-out}}, {{system-err}} which 
> belong to complexType. The Jenkins and Travis should be informed about this 
> fix and their plugins should adapt.
> These elements should be {{complexType}} and the value of {{simpleContent}} 
> should appear in new element {{stackTrace}}.
> https://github.com/travis-ci/travis-ci/issues/10033
> https://issues.jenkins-ci.org/browse/JENKINS-53237



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SUREFIRE-1560) Rework SUREFIRE-1535. Use only FORKTESTSET and split SurefireProvider to two interface - currently has two responsibilities

2018-08-25 Thread Tibor Digana (JIRA)
Tibor Digana created SUREFIRE-1560:
--

 Summary: Rework SUREFIRE-1535. Use only FORKTESTSET and split 
SurefireProvider to two interface - currently has two responsibilities
 Key: SUREFIRE-1560
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1560
 Project: Maven Surefire
  Issue Type: Task
  Components: Maven Failsafe Plugin, Maven Surefire Plugin
Affects Versions: 2.22.1
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 3.0


Currently SurefireProvider as an interface is not that easy to understand and 
has two responsibilities. Unnecessarily transfers and serializes tons of 
properties in order to compute suites via {{getSuites}}. The particular name of 
test (class or file suite) is transferred via properties file in multiple keys 
and then the goal of suite is not unique. Hard to implement such complex API. 
This should break the backwards compatibility towards simple API and faster 
startup of provider because we will transfer and serialize only necessary staff.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SUREFIRE-1560) Rework SUREFIRE-1535. Use only FORKTESTSET and split SurefireProvider to two interfaces - currently has two responsibilities

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1560:
---
Summary: Rework SUREFIRE-1535. Use only FORKTESTSET and split 
SurefireProvider to two interfaces - currently has two responsibilities  (was: 
Rework SUREFIRE-1535. Use only FORKTESTSET and split SurefireProvider to two 
interface - currently has two responsibilities)

> Rework SUREFIRE-1535. Use only FORKTESTSET and split SurefireProvider to two 
> interfaces - currently has two responsibilities
> 
>
> Key: SUREFIRE-1560
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1560
> Project: Maven Surefire
>  Issue Type: Task
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 2.22.1
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0
>
>
> Currently SurefireProvider as an interface is not that easy to understand and 
> has two responsibilities. Unnecessarily transfers and serializes tons of 
> properties in order to compute suites via {{getSuites}}. The particular name 
> of test (class or file suite) is transferred via properties file in multiple 
> keys and then the goal of suite is not unique. Hard to implement such complex 
> API. This should break the backwards compatibility towards simple API and 
> faster startup of provider because we will transfer and serialize only 
> necessary staff.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SUREFIRE-1553) @Unroll forces usage of JUnit Vintage

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592653#comment-16592653
 ] 

Tibor Digana commented on SUREFIRE-1553:


[~skrser]
We implemented new JUnit5 Surefire provider in Version 2.22.0.

> @Unroll forces usage of JUnit Vintage
> -
>
> Key: SUREFIRE-1553
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1553
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Sergey Skryabin
>Priority: Major
>
> If run
> {code}mvn clean test{code}
> JUnit4 tests and Spock tests (which not contain @Unroll) are executed 
> normally. Once Spock test with @Unroll annotation appears, then Surefire 
> execute
> {code}[INFO] Running JUnit Vintage{code}
>  and all other JUnit4 tests and Spock tests are wrapped with this runner. 
> In surefire-reports I see _TEST- @Unroll>.xml_ s and than
> _TEST-JUnit Vintage.xml_
> Though it could be done by intention, behaviour is different from 2.21.0 (no 
> wrapping with Vintage). Also it much more visible to have separate reports 
> per test class (both in console output and surefire-reports folder).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SUREFIRE-1553) @Unroll forces usage of JUnit Vintage

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592654#comment-16592654
 ] 

Tibor Digana commented on SUREFIRE-1553:


[~sormu...@gmx.de]
Can you have a look?
I think this case somehow activated JUnit Platform.

[~skrser]
Can you provide us with a project where we can see your POM and reproduce this 
issue? Thx

> @Unroll forces usage of JUnit Vintage
> -
>
> Key: SUREFIRE-1553
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1553
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Sergey Skryabin
>Priority: Major
>
> If run
> {code}mvn clean test{code}
> JUnit4 tests and Spock tests (which not contain @Unroll) are executed 
> normally. Once Spock test with @Unroll annotation appears, then Surefire 
> execute
> {code}[INFO] Running JUnit Vintage{code}
>  and all other JUnit4 tests and Spock tests are wrapped with this runner. 
> In surefire-reports I see _TEST- @Unroll>.xml_ s and than
> _TEST-JUnit Vintage.xml_
> Though it could be done by intention, behaviour is different from 2.21.0 (no 
> wrapping with Vintage). Also it much more visible to have separate reports 
> per test class (both in console output and surefire-reports folder).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SUREFIRE-1523) Adding item to JceKeyStore fails when non-forking with JDK 8_171

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592656#comment-16592656
 ] 

Tibor Digana commented on SUREFIRE-1523:


[~Cousjath]
How can we reproduce this issue?

> Adding item to JceKeyStore fails when non-forking with JDK 8_171
> 
>
> Key: SUREFIRE-1523
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1523
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.21.0
>Reporter: Jonathan Coustick
>Priority: Major
>
> When putting an item in a JceKeyStore in Java 1.8.0_171 where forkCount is 0 
> it fails with InvalidSecretKeyFormat. This does not occur in Java 1.8.0_162 
> or when forkCount is 1.
> The full stacktrace is:
> {{}}
> {code:java}
> java.io.IOException: Invalid secret key format
>     at com.sun.crypto.provider.JceKeyStore.engineLoad(JceKeyStore.java:856)
>     at java.security.KeyStore.load(KeyStore.java:1445)
>     at  
> fish.payara.jcekstest.PasswordAdapter.loadKeyStore(PasswordAdapter.java:116)
>     at 
> fish.payara.jcekstest.PasswordAdapter.writeKeyStoreSafe(PasswordAdapter.java:303)
>     at 
> fish.payara.jcekstest.PasswordAdapter.writeStore(PasswordAdapter.java:184)
>     at 
> fish.payara.jcekstest.PasswordAdapter.setPasswordForAlias(PasswordAdapter.java:202)
>     at 
> fish.payara.jcekstest.JCEKSPasswordAliasStore.put(JCEKSPasswordAliasStore.java:104)
>     at 
> fish.payara.jcekstest.PasswordAliasTest.checkStoreAndGetPWByAlias(PasswordAliasTest.java:97)
>     at 
> fish.payara.jcekstest.PasswordAliasTest.checkLongPW(PasswordAliasTest.java:93)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>     at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>     at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>     at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>     at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>     at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>     at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>     at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>     at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>     at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>     at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>     at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>     at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>     at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>     at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at 
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:206)
>     at 
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:160)
>     at 
> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:83)
>     at 
> org.apache.maven.plugin.surefire.InPluginVMSurefireStarter.runSuitesInProcess(InPluginVMSurefireStarter.java:87)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1132)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:978)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:854)
>     at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(Default

[jira] [Commented] (SUREFIRE-1520) ClassNotFoundException with forkCount>1 and junit5

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592657#comment-16592657
 ] 

Tibor Digana commented on SUREFIRE-1520:


[~pvorb]
This means the issue appears only when running the provider in-plugin process. 
Most probably the artifact is missing in classpath.

> ClassNotFoundException with forkCount>1 and junit5
> --
>
> Key: SUREFIRE-1520
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1520
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.21.0
>Reporter: Stefan Küttner
>Priority: Major
>
> maven-version: 3.2.5 / 3.3.9
> OS: Windows 7
> Java 8 (compiler level & runtime)
> {code:xml|title=pom.xml (effective-pom)|collapse=true}
>   
> maven-surefire-plugin
> 2.21.0
> 
>   
> default-test
> test
> 
>   test
> 
> 
>   
> **/*IntegrationTest.java
>   
>   false
>   2
>   true
>   
> 3600
>   
> -Djava.util.logging.config.file=${project.base.dir}logging.properties
>   alphabetical
>   
> **/*Test.java
>   
> 
>   
> 
> 
>   
> org.junit.platform
> junit-platform-surefire-provider
> 1.2.0
> compile
>   
>   
> org.junit.vintage
> junit-vintage-engine
> 5.2.0
> compile
>   
>   
> org.junit.jupiter
> junit-jupiter-engine
> 5.2.0
> compile
>   
> 
> 
>   2
>   true
>   3600
>   
> -Djava.util.logging.config.file=${project.base.dir}logging.properties
>   alphabetical
>   false
>   
> **/*Test.java
>   
>   
> **/*PerfTest.java
> **/*IntegrationTest.java
>   
> 
>   
> {code}
> result is 
> {code:java|title=java.lang.ClassNotFoundException: 
> org.apache.maven.plugin.surefire.log.api.ConsoleLogger|collapse=true}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) on 
> project mts.ctsm: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test failed: 
> java.lang.ClassNotFoundException: 
> org.apache.maven.plugin.surefire.log.api.ConsoleLogger -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test 
> (default-test) on project mts.ctsm: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test failed: 
> java.lang.ClassNotFoundException: 
> org.apache.maven.plugin.surefire.log.api.ConsoleLogger
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:160)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launch

[jira] [Commented] (SUREFIRE-1520) ClassNotFoundException with forkCount>1 and junit5

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592658#comment-16592658
 ] 

Tibor Digana commented on SUREFIRE-1520:


[~stefan.kuettner]
[~djarnis73]
[~pvorb]
I think you use dependencies inside the plugin. Pls avoid that and use only 
{{junit-jupiter-engine}} and version {{5.2.0}} as shown in the documentation
https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html
Pls inform us about the result after you have modified the POM. Thx.

[~sormu...@gmx.de]
I added your name here because you are more skilled in JUnit5.

> ClassNotFoundException with forkCount>1 and junit5
> --
>
> Key: SUREFIRE-1520
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1520
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.21.0
>Reporter: Stefan Küttner
>Priority: Major
>
> maven-version: 3.2.5 / 3.3.9
> OS: Windows 7
> Java 8 (compiler level & runtime)
> {code:xml|title=pom.xml (effective-pom)|collapse=true}
>   
> maven-surefire-plugin
> 2.21.0
> 
>   
> default-test
> test
> 
>   test
> 
> 
>   
> **/*IntegrationTest.java
>   
>   false
>   2
>   true
>   
> 3600
>   
> -Djava.util.logging.config.file=${project.base.dir}logging.properties
>   alphabetical
>   
> **/*Test.java
>   
> 
>   
> 
> 
>   
> org.junit.platform
> junit-platform-surefire-provider
> 1.2.0
> compile
>   
>   
> org.junit.vintage
> junit-vintage-engine
> 5.2.0
> compile
>   
>   
> org.junit.jupiter
> junit-jupiter-engine
> 5.2.0
> compile
>   
> 
> 
>   2
>   true
>   3600
>   
> -Djava.util.logging.config.file=${project.base.dir}logging.properties
>   alphabetical
>   false
>   
> **/*Test.java
>   
>   
> **/*PerfTest.java
> **/*IntegrationTest.java
>   
> 
>   
> {code}
> result is 
> {code:java|title=java.lang.ClassNotFoundException: 
> org.apache.maven.plugin.surefire.log.api.ConsoleLogger|collapse=true}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) on 
> project mts.ctsm: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test failed: 
> java.lang.ClassNotFoundException: 
> org.apache.maven.plugin.surefire.log.api.ConsoleLogger -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test 
> (default-test) on project mts.ctsm: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test failed: 
> java.lang.ClassNotFoundException: 
> org.apache.maven.plugin.surefire.log.api.ConsoleLogger
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:160)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.lau

[jira] [Commented] (SUREFIRE-1537) ClassNotFoundException with m-surefire-p 2.22.0

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592659#comment-16592659
 ] 

Tibor Digana commented on SUREFIRE-1537:


[~t_heit]
I still do not see the {{ClassNotFoundException }} in your logs. Is it still 
about JavaFx?
It would be fine if you oin together with reporter in SUREFIRE-1438 and analyse 
the Class Path. Definitely some library of JavaFx is missing but I have no idea 
if it is expected from the point of JDK/JRE or you have to add some library 
because I do not know the JavaFx specification from Oracle. Better if you tell 
me what is expected from the point of the spec.

> ClassNotFoundException with m-surefire-p 2.22.0
> ---
>
> Key: SUREFIRE-1537
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1537
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
> Environment: Windows 8.1 x64
> Maven 3.5.4
> Java 10.0.1
>Reporter: Thorsten Heit
>Priority: Major
>
> With Surefire plugin 2.22.0 a JUnit test in one of our projects doesn't work 
> anymore; a ClassNotFoundException is thrown when using {{mvn clean test}}. 
> Using 2.21.0 everyhing works.
> This is the output of {{mvn dependency:tree}}:
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO] -< myorg:facade >-
> [INFO] Building facade 2018.2.0-SNAPSHOT
> [INFO] [ jar 
> ]-
> [INFO]
> [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ facade ---
> [INFO] myorg:facade:jar:2018.2.0-SNAPSHOT
> [INFO] +- myorg:accessors:jar:2018.2.0:compile
> [INFO] |  +- myorg:myids:jar:2018.2.0:compile
> [INFO] |  +- myorg:output:jar:2018.2.0:compile
> [INFO] |  \- org.slf4j:slf4j-api:jar:1.8.0-beta2:compile
> [INFO] +- myorg:utilities:jar:2.2.0:compile
> [INFO] +- com.sun.mail:javax.mail:jar:1.6.1:test
> [INFO] +- javax.activation:javax.activation-api:jar:1.2.0:test
> [INFO] +- externals:externallib:jar:2.1.3:compile
> [INFO] |  +- org.apache.xmlgraphics:fop:jar:2.2:compile
> [INFO] |  |  +- org.apache.xmlgraphics:xmlgraphics-commons:jar:2.2:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-svg-dom:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-css:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-dom:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-parser:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-util:jar:1.9:compile
> [INFO] |  |  |  |  +- org.apache.xmlgraphics:batik-constants:jar:1.9:compile
> [INFO] |  |  |  |  \- org.apache.xmlgraphics:batik-i18n:jar:1.9:compile
> [INFO] |  |  |  \- xml-apis:xml-apis-ext:jar:1.3.04:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-bridge:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-anim:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-script:jar:1.9:compile
> [INFO] |  |  |  \- org.apache.xmlgraphics:batik-xml:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-awt-util:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-gvt:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-transcoder:jar:1.9:compile
> [INFO] |  |  |  \- org.apache.xmlgraphics:batik-svggen:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-extension:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-ext:jar:1.9:compile
> [INFO] |  |  +- 
> org.apache.avalon.framework:avalon-framework-api:jar:4.3.1:compile
> [INFO] |  |  +- 
> org.apache.avalon.framework:avalon-framework-impl:jar:4.3.1:compile
> [INFO] |  |  \- org.apache.pdfbox:fontbox:jar:2.0.4:compile
> [INFO] |  +- commons-io:commons-io:jar:2.5:compile
> [INFO] |  \- org.slf4j:jcl-over-slf4j:jar:1.8.0-beta2:compile
> [INFO] +- myorg:business-objects:jar:2018.2.0:compile
> [INFO] +- 
> org.eclipse.jdt:org.eclipse.jdt.annotation:jar:1.1.0-v20130513-1648:provided
> [INFO] \- junit:junit:jar:4.12:test
> [INFO]\- org.hamcrest:hamcrest-core:jar:1.3:test
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 5.184 s
> [INFO] Finished at: 2018-07-12T09:24:08+02:00
> [INFO] 
> 
> {noformat}
> The supposedly missing class when using 2.22.0 is contained in the dependency 
> *externals:externallib* (see above) which itself is contained as a direct 
> compile-time dependency in my project.
> What I see is that the output of {{mvn -X test}} differs between the two 
> plugin versions:
> 2.21.0:
> {noformat}
> (...)
> [INFO] --- maven-surefire-plugin:2.21.0:test (defau

[jira] [Comment Edited] (SUREFIRE-1537) ClassNotFoundException with m-surefire-p 2.22.0

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592659#comment-16592659
 ] 

Tibor Digana edited comment on SUREFIRE-1537 at 8/25/18 5:37 PM:
-

[~t_heit]
I still do not see the {{ClassNotFoundException}} in your logs. Is it still 
about JavaFx?
It would be fine if you join together with reporter in SUREFIRE-1438 and 
analyse the Class Path. Definitely some library of JavaFx is missing but I have 
no idea if it is expected from the point of JDK/JRE or you have to add some 
library because I do not know the JavaFx specification from Oracle. Better if 
you tell me what is expected from the point of the spec.


was (Author: tibor17):
[~t_heit]
I still do not see the {{ClassNotFoundException }} in your logs. Is it still 
about JavaFx?
It would be fine if you oin together with reporter in SUREFIRE-1438 and analyse 
the Class Path. Definitely some library of JavaFx is missing but I have no idea 
if it is expected from the point of JDK/JRE or you have to add some library 
because I do not know the JavaFx specification from Oracle. Better if you tell 
me what is expected from the point of the spec.

> ClassNotFoundException with m-surefire-p 2.22.0
> ---
>
> Key: SUREFIRE-1537
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1537
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
> Environment: Windows 8.1 x64
> Maven 3.5.4
> Java 10.0.1
>Reporter: Thorsten Heit
>Priority: Major
>
> With Surefire plugin 2.22.0 a JUnit test in one of our projects doesn't work 
> anymore; a ClassNotFoundException is thrown when using {{mvn clean test}}. 
> Using 2.21.0 everyhing works.
> This is the output of {{mvn dependency:tree}}:
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO] -< myorg:facade >-
> [INFO] Building facade 2018.2.0-SNAPSHOT
> [INFO] [ jar 
> ]-
> [INFO]
> [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ facade ---
> [INFO] myorg:facade:jar:2018.2.0-SNAPSHOT
> [INFO] +- myorg:accessors:jar:2018.2.0:compile
> [INFO] |  +- myorg:myids:jar:2018.2.0:compile
> [INFO] |  +- myorg:output:jar:2018.2.0:compile
> [INFO] |  \- org.slf4j:slf4j-api:jar:1.8.0-beta2:compile
> [INFO] +- myorg:utilities:jar:2.2.0:compile
> [INFO] +- com.sun.mail:javax.mail:jar:1.6.1:test
> [INFO] +- javax.activation:javax.activation-api:jar:1.2.0:test
> [INFO] +- externals:externallib:jar:2.1.3:compile
> [INFO] |  +- org.apache.xmlgraphics:fop:jar:2.2:compile
> [INFO] |  |  +- org.apache.xmlgraphics:xmlgraphics-commons:jar:2.2:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-svg-dom:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-css:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-dom:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-parser:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-util:jar:1.9:compile
> [INFO] |  |  |  |  +- org.apache.xmlgraphics:batik-constants:jar:1.9:compile
> [INFO] |  |  |  |  \- org.apache.xmlgraphics:batik-i18n:jar:1.9:compile
> [INFO] |  |  |  \- xml-apis:xml-apis-ext:jar:1.3.04:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-bridge:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-anim:jar:1.9:compile
> [INFO] |  |  |  +- org.apache.xmlgraphics:batik-script:jar:1.9:compile
> [INFO] |  |  |  \- org.apache.xmlgraphics:batik-xml:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-awt-util:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-gvt:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-transcoder:jar:1.9:compile
> [INFO] |  |  |  \- org.apache.xmlgraphics:batik-svggen:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-extension:jar:1.9:compile
> [INFO] |  |  +- org.apache.xmlgraphics:batik-ext:jar:1.9:compile
> [INFO] |  |  +- 
> org.apache.avalon.framework:avalon-framework-api:jar:4.3.1:compile
> [INFO] |  |  +- 
> org.apache.avalon.framework:avalon-framework-impl:jar:4.3.1:compile
> [INFO] |  |  \- org.apache.pdfbox:fontbox:jar:2.0.4:compile
> [INFO] |  +- commons-io:commons-io:jar:2.5:compile
> [INFO] |  \- org.slf4j:jcl-over-slf4j:jar:1.8.0-beta2:compile
> [INFO] +- myorg:business-objects:jar:2018.2.0:compile
> [INFO] +- 
> org.eclipse.jdt:org.eclipse.jdt.annotation:jar:1.1.0-v20130513-1648:provided
> [INFO] \- junit:junit:jar:4.12:test
> [INFO]\- org.hamcrest:hamcrest-core:jar:1.3:test
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] T

[jira] [Commented] (SUREFIRE-1560) Rework SUREFIRE-1535. Use only FORKTESTSET and split SurefireProvider to two interfaces - currently has two responsibilities

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592662#comment-16592662
 ] 

Tibor Digana commented on SUREFIRE-1560:


Partially SUREFIRE-1535 is reworked
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/V30_SUREFIRE-1535
Suite files in the in-process are missing and Surefire Provider is not changed. 
Only {{TEST_SUITE_XML_FILES}} is avoided yet.

> Rework SUREFIRE-1535. Use only FORKTESTSET and split SurefireProvider to two 
> interfaces - currently has two responsibilities
> 
>
> Key: SUREFIRE-1560
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1560
> Project: Maven Surefire
>  Issue Type: Task
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 2.22.1
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0
>
>
> Currently SurefireProvider as an interface is not that easy to understand and 
> has two responsibilities. Unnecessarily transfers and serializes tons of 
> properties in order to compute suites via {{getSuites}}. The particular name 
> of test (class or file suite) is transferred via properties file in multiple 
> keys and then the goal of suite is not unique. Hard to implement such complex 
> API. This should break the backwards compatibility towards simple API and 
> faster startup of provider because we will transfer and serialize only 
> necessary staff.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SUREFIRE-1540) Upgrade maven-plugins parent to version 32

2018-08-25 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592664#comment-16592664
 ] 

Tibor Digana commented on SUREFIRE-1540:


[~khmarbaise]
How urgent is this? Can we use it in the first release candidate of 3.0 also 
when Java 7 will present?
In 2.22.1 I want to push Support for Java 11, remaining user's pull requests 
from GitHub and then we are through with Version series of 2.x.

> Upgrade maven-plugins parent to version 32
> --
>
> Key: SUREFIRE-1540
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1540
> Project: Maven Surefire
>  Issue Type: Dependency upgrade
>Affects Versions: 2.22.1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 2.22.1
>
>
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-5951) add an option to avoid path addition to inherited URLs

2018-08-25 Thread Mark Raynsford (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592665#comment-16592665
 ] 

Mark Raynsford commented on MNG-5951:
-

Any movement on this?

I've just discovered that I've been bitten by this: I've been publishing OSGi 
bundles that contain incorrect URLs due to reading from 
`${project.distributionManagement.site.url}`. Many of my bundles have ended up 
with Bundle-DocURL fields that look like this:

{noformat}
Bundle-DocURL  
https://www.io7m.com/software/jspatial/com.io7m.jspatial.documentation
Bundle-DocURL  
https://www.io7m.com/software/jspatial/com.io7m.jspatial.examples.swing
Bundle-DocURL  https://www.io7m.com/software/jspatial/com.io7m.jspatial.tests
{noformat}

They're supposed to look like this:

{noformat}
Bundle-DocURL  https://www.io7m.com/software/jspatial
Bundle-DocURL  https://www.io7m.com/software/jspatial
Bundle-DocURL  https://www.io7m.com/software/jspatial
{noformat}



> add an option to avoid path addition to inherited URLs
> --
>
> Key: MNG-5951
> URL: https://issues.apache.org/jira/browse/MNG-5951
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
>Affects Versions: 3.0.5, 3.1.1, 3.2.5, 3.3.9
>Reporter: Jörg Sesterhenn
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.x-candidate
>
> Attachments: MNG-5951.zip
>
>
> What I am trying to achieve is 
> the definition of a project.url in a parent pom 
> in a way that all children inherit a url ending with 
> {code}
> ${project.groupId}/${project.artifactId}/${project.version}/ 
> {code}
> in order to be able to publish sites of all artifacts in all versions in 
> parallel
> without having to redefine the url in every child pom.
> This is currently not working as expected in maven due to the default child 
> urls calculation which leads to urls that add up parent urls like 
> http://my.domain.de/sites/de.enterprise.calculatorsGroupId/calculator-artifactID/1.0.0-SNAPSHOT/internetAppParentPOM/calculatorParentPom/calculator-artifactID/
> The part *"internetAppParentPOM/calculatorParentPom/"* is added by automatic 
> child url calculation (those are the artifactIds of all parent poms beneath 
> our enterprise parent pom where the url is defined) and *is expexted to not 
> be there at all*. The repeated artifactID at the end of the url is 
> superfluous as well but tollerable.
> I expect maven-core to be changed so that I can turn on/off the automatic 
> calculation of child URLs as an option which is by default on (current 
> behaviour so nothing will change unless configured explicitly).
> See the discussion in MSITE-672. 
> As this can not be done in the maven-site-plugin there needs to be a change 
> in Maven itself (core), in Maven Model Builder, ie the way effective model is 
> calculated, and more precisely in the inheritance step: 
> http://maven.apache.org/ref/current/maven-model-builder/.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MRELEASE-1010) Upgrade maven-plugins parent to version 32

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MRELEASE-1010.
-
Resolution: Done

Done in 
[39b3e723a9f338bf39fdc385e2d5ec1da6b771a6|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commitdiff;h=39b3e723a9f338bf39fdc385e2d5ec1da6b771a6]

> Upgrade maven-plugins parent to version 32
> --
>
> Key: MRELEASE-1010
> URL: https://issues.apache.org/jira/browse/MRELEASE-1010
> Project: Maven Release Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (MNG-5951) add an option to avoid path addition to inherited URLs

2018-08-25 Thread Mark Raynsford (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592665#comment-16592665
 ] 

Mark Raynsford edited comment on MNG-5951 at 8/25/18 6:08 PM:
--

Any movement on this?

I've just discovered that I've been bitten by this: I've been publishing OSGi 
bundles that contain incorrect URLs due to reading from 
`${project.distributionManagement.site.url}`. Many of my bundles have ended up 
with Bundle-DocURL fields that look like this:

{noformat}
Bundle-DocURL  
https://www.io7m.com/software/jspatial/com.io7m.jspatial.documentation
Bundle-DocURL  
https://www.io7m.com/software/jspatial/com.io7m.jspatial.examples.swing
Bundle-DocURL  https://www.io7m.com/software/jspatial/com.io7m.jspatial.tests
{noformat}

They're supposed to look like this:

{noformat}
Bundle-DocURL  https://www.io7m.com/software/jspatial
Bundle-DocURL  https://www.io7m.com/software/jspatial
Bundle-DocURL  https://www.io7m.com/software/jspatial
{noformat}

_Edit:_ The SCM URLs are wrong too. Irritating.


was (Author: io7m):
Any movement on this?

I've just discovered that I've been bitten by this: I've been publishing OSGi 
bundles that contain incorrect URLs due to reading from 
`${project.distributionManagement.site.url}`. Many of my bundles have ended up 
with Bundle-DocURL fields that look like this:

{noformat}
Bundle-DocURL  
https://www.io7m.com/software/jspatial/com.io7m.jspatial.documentation
Bundle-DocURL  
https://www.io7m.com/software/jspatial/com.io7m.jspatial.examples.swing
Bundle-DocURL  https://www.io7m.com/software/jspatial/com.io7m.jspatial.tests
{noformat}

They're supposed to look like this:

{noformat}
Bundle-DocURL  https://www.io7m.com/software/jspatial
Bundle-DocURL  https://www.io7m.com/software/jspatial
Bundle-DocURL  https://www.io7m.com/software/jspatial
{noformat}



> add an option to avoid path addition to inherited URLs
> --
>
> Key: MNG-5951
> URL: https://issues.apache.org/jira/browse/MNG-5951
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
>Affects Versions: 3.0.5, 3.1.1, 3.2.5, 3.3.9
>Reporter: Jörg Sesterhenn
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.x-candidate
>
> Attachments: MNG-5951.zip
>
>
> What I am trying to achieve is 
> the definition of a project.url in a parent pom 
> in a way that all children inherit a url ending with 
> {code}
> ${project.groupId}/${project.artifactId}/${project.version}/ 
> {code}
> in order to be able to publish sites of all artifacts in all versions in 
> parallel
> without having to redefine the url in every child pom.
> This is currently not working as expected in maven due to the default child 
> urls calculation which leads to urls that add up parent urls like 
> http://my.domain.de/sites/de.enterprise.calculatorsGroupId/calculator-artifactID/1.0.0-SNAPSHOT/internetAppParentPOM/calculatorParentPom/calculator-artifactID/
> The part *"internetAppParentPOM/calculatorParentPom/"* is added by automatic 
> child url calculation (those are the artifactIds of all parent poms beneath 
> our enterprise parent pom where the url is defined) and *is expexted to not 
> be there at all*. The repeated artifactID at the end of the url is 
> superfluous as well but tollerable.
> I expect maven-core to be changed so that I can turn on/off the automatic 
> calculation of child URLs as an option which is by default on (current 
> behaviour so nothing will change unless configured explicitly).
> See the discussion in MSITE-672. 
> As this can not be done in the maven-site-plugin there needs to be a change 
> in Maven itself (core), in Maven Model Builder, ie the way effective model is 
> calculated, and more precisely in the inheritance step: 
> http://maven.apache.org/ref/current/maven-model-builder/.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Moved] (MNGSITE-349) Fix documentation edit instructions

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise moved MNG-6466 to MNGSITE-349:
--

Component/s: (was: Documentation:  General)
 Issue Type: Improvement  (was: Bug)
Key: MNGSITE-349  (was: MNG-6466)
Project: Maven Project Web Site  (was: Maven)

> Fix documentation edit instructions
> ---
>
> Key: MNGSITE-349
> URL: https://issues.apache.org/jira/browse/MNGSITE-349
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> https://maven.apache.org/scm.html
> and
> https://maven.apache.org/guides/development/guide-maven-development.html
> to include instructions on how to edit the site, which is apparently 
> different than how to work on the rest of the code. I.e. press the edit 
> button and use github to create a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Moved] (MNGSITE-350) Add. DS_Store to .gitignore

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise moved MNG-6462 to MNGSITE-350:
--

Affects Version/s: (was: 3.5.4)
  Component/s: (was: General)
  Key: MNGSITE-350  (was: MNG-6462)
  Project: Maven Project Web Site  (was: Maven)

> Add. DS_Store to .gitignore
> ---
>
> Key: MNGSITE-350
> URL: https://issues.apache.org/jira/browse/MNGSITE-350
> Project: Maven Project Web Site
>  Issue Type: Improvement
> Environment: Mac
>Reporter: Elliotte Rusty Harold
>Priority: Trivial
>
> Useful for devs who use Macs:
> Untracked files:
>   (use "git add ..." to include in what will be committed)
>   .DS_Store
>   content/.DS_Store
>   content/odt/.DS_Store
>   content/resources/.DS_Store
>   content/xdoc/.DS_Store



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNGSITE-350) Add .DS_Store to .gitignore

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MNGSITE-350:

Summary: Add .DS_Store to .gitignore  (was: Add. DS_Store to .gitignore)

> Add .DS_Store to .gitignore
> ---
>
> Key: MNGSITE-350
> URL: https://issues.apache.org/jira/browse/MNGSITE-350
> Project: Maven Project Web Site
>  Issue Type: Improvement
> Environment: Mac
>Reporter: Elliotte Rusty Harold
>Priority: Trivial
>
> Useful for devs who use Macs:
> Untracked files:
>   (use "git add ..." to include in what will be committed)
>   .DS_Store
>   content/.DS_Store
>   content/odt/.DS_Store
>   content/resources/.DS_Store
>   content/xdoc/.DS_Store



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MNGSITE-350) Add .DS_Store to .gitignore

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MNGSITE-350.
---
Resolution: Done

Done in 
[123153b87818baf21755a4ee11f58cf85076b185|https://gitbox.apache.org/repos/asf?p=maven-site.git;a=commitdiff;h=123153b87818baf21755a4ee11f58cf85076b185]

> Add .DS_Store to .gitignore
> ---
>
> Key: MNGSITE-350
> URL: https://issues.apache.org/jira/browse/MNGSITE-350
> Project: Maven Project Web Site
>  Issue Type: Improvement
> Environment: Mac
>Reporter: Elliotte Rusty Harold
>Assignee: Karl Heinz Marbaise
>Priority: Trivial
>
> Useful for devs who use Macs:
> Untracked files:
>   (use "git add ..." to include in what will be committed)
>   .DS_Store
>   content/.DS_Store
>   content/odt/.DS_Store
>   content/resources/.DS_Store
>   content/xdoc/.DS_Store



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (MNGSITE-350) Add .DS_Store to .gitignore

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MNGSITE-350:
---

Assignee: Karl Heinz Marbaise

> Add .DS_Store to .gitignore
> ---
>
> Key: MNGSITE-350
> URL: https://issues.apache.org/jira/browse/MNGSITE-350
> Project: Maven Project Web Site
>  Issue Type: Improvement
> Environment: Mac
>Reporter: Elliotte Rusty Harold
>Assignee: Karl Heinz Marbaise
>Priority: Trivial
>
> Useful for devs who use Macs:
> Untracked files:
>   (use "git add ..." to include in what will be committed)
>   .DS_Store
>   content/.DS_Store
>   content/odt/.DS_Store
>   content/resources/.DS_Store
>   content/xdoc/.DS_Store



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Moved] (MNGSITE-351) RAT checks failing in site

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise moved MNG-6464 to MNGSITE-351:
--

Affects Version/s: (was: 3.5.4)
  Component/s: (was: Documentation:  General)
   Issue Type: Improvement  (was: Bug)
  Key: MNGSITE-351  (was: MNG-6464)
  Project: Maven Project Web Site  (was: Maven)

> RAT checks failing in site
> --
>
> Key: MNGSITE-351
> URL: https://issues.apache.org/jira/browse/MNGSITE-351
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> 1. Clone  https://gitbox.apache.org/repos/asf/maven-site.git
> 2. Run mvn test:
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check 
> (rat-check) on project maven-site: Too many files with unapproved license: 
> 100 See RAT report in: /Users/elharo/maven-site/target/rat.txt -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNGSITE-350) Add .DS_Store to .gitignore

2018-08-25 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNGSITE-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592677#comment-16592677
 ] 

Hudson commented on MNGSITE-350:


Build succeeded in Jenkins: Maven TLP » maven-site » master #80

See https://builds.apache.org/job/maven-box/job/maven-site/job/master/80/

> Add .DS_Store to .gitignore
> ---
>
> Key: MNGSITE-350
> URL: https://issues.apache.org/jira/browse/MNGSITE-350
> Project: Maven Project Web Site
>  Issue Type: Improvement
> Environment: Mac
>Reporter: Elliotte Rusty Harold
>Assignee: Karl Heinz Marbaise
>Priority: Trivial
>
> Useful for devs who use Macs:
> Untracked files:
>   (use "git add ..." to include in what will be committed)
>   .DS_Store
>   content/.DS_Store
>   content/odt/.DS_Store
>   content/resources/.DS_Store
>   content/xdoc/.DS_Store



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNGSITE-351) RAT checks failing in site

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MNGSITE-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592680#comment-16592680
 ] 

Karl Heinz Marbaise commented on MNGSITE-351:
-

I have changed the type from Bug to Improvement cause we never use {{mvn test}} 
on the site only {{mvn site}}...

> RAT checks failing in site
> --
>
> Key: MNGSITE-351
> URL: https://issues.apache.org/jira/browse/MNGSITE-351
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> 1. Clone  https://gitbox.apache.org/repos/asf/maven-site.git
> 2. Run mvn test:
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check 
> (rat-check) on project maven-site: Too many files with unapproved license: 
> 100 See RAT report in: /Users/elharo/maven-site/target/rat.txt -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6460) Maven resolves old snapshot jars when an artifact changes from jar to pom deployment

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592681#comment-16592681
 ] 

Karl Heinz Marbaise commented on MNG-6460:
--

The first question which is coming into my mind: Why are you using the maven 
dependency-plugin to resolve these dependencies? Why not simply adding it as a 
dependency to your pom file? If this dep is a packaging {{pom}} than you need 
to define {{pom}} as Robert already has written..otherwise the 
default is to expect {{jar}}...

> Maven resolves old snapshot jars when an artifact changes from jar to pom 
> deployment
> 
>
> Key: MNG-6460
> URL: https://issues.apache.org/jira/browse/MNG-6460
> Project: Maven
>  Issue Type: Bug
>  Components: Dependencies
>Affects Versions: 3.5.0
>Reporter: Andy Grove
>Priority: Major
>
> I have two projects, A and B.
> A started out as a simple project with single pom with jar packaging.
> B had a dependency on A.
> A was refactored to be multi module where each module has jar packaging. The 
> parent pom now has pom packaging.
> After building A and deploying new artifacts to artifactory, and making 
> changes to B's pom I saw compilation errors with references to to the old A 
> and the new A.
> I eventually realized that B still had a reference to the original artifact 
> from A (which was originally had jar packaging but now has pom packaging).
> Even though the latest snapshot for the parent pom in A was correctly 
> published with pom packaging and no corresponding jar file, the 
> maven-dependency-plugin was resolving the jar file from the previous snapshot 
> release from before the refactor.
> This seems like a bug to me. It should have looked at the pom for the latest 
> snapshot and seen that it had pom packaging and then failed to resolve the 
> jar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRELEASE-1010) Upgrade maven-plugins parent to version 32

2018-08-25 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592682#comment-16592682
 ] 

Hudson commented on MRELEASE-1010:
--

Build succeeded in Jenkins: Maven TLP » maven-release » master #54

See https://builds.apache.org/job/maven-box/job/maven-release/job/master/54/

> Upgrade maven-plugins parent to version 32
> --
>
> Key: MRELEASE-1010
> URL: https://issues.apache.org/jira/browse/MRELEASE-1010
> Project: Maven Release Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SUREFIRE-1560) Rework SUREFIRE-1535. Use only FORKTESTSET and split SurefireProvider to two interfaces - currently has two responsibilities

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1560:
---
External issue URL: https://github.com/apache/maven-surefire/pull/190

> Rework SUREFIRE-1535. Use only FORKTESTSET and split SurefireProvider to two 
> interfaces - currently has two responsibilities
> 
>
> Key: SUREFIRE-1560
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1560
> Project: Maven Surefire
>  Issue Type: Task
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 2.22.1
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0
>
>
> Currently SurefireProvider as an interface is not that easy to understand and 
> has two responsibilities. Unnecessarily transfers and serializes tons of 
> properties in order to compute suites via {{getSuites}}. The particular name 
> of test (class or file suite) is transferred via properties file in multiple 
> keys and then the goal of suite is not unique. Hard to implement such complex 
> API. This should break the backwards compatibility towards simple API and 
> faster startup of provider because we will transfer and serialize only 
> necessary staff.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SUREFIRE-1535) Surefire unable to run testng suites in parallel

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana reassigned SUREFIRE-1535:
--

Assignee: Tibor Digana

> Surefire unable to run testng suites in parallel
> 
>
> Key: SUREFIRE-1535
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1535
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: TestNG support
>Affects Versions: 2.22.0
>Reporter: Andrey Panfilov
>Assignee: Tibor Digana
>Priority: Minor
>
> Due to slowness nature of selenium test we would like to run such tests in 
> parallel, moreover, we also would like to avoid thread-safety issues, so our 
> option is to take advantage of  forkCount=N and reuseForks=false instead of 
> using built-in testng capabilities. Unfortunately, when using following maven 
> configuration:
> {code:java}
> 2
> false
> 
> Suite_1.xml
> Suite_2.xml
> 
> {code}
> it does not work like expected, i.e.:
>  * ForkStarter#runSuitesForkPerTestSet correctly spawns multiple JVMs and 
> passes individual testng suite to ForkStarter#fork
>  * TestNGProvider#invoke fails to cover the case that forkTestSet could be a 
> file and runs all testng suites instead of individual one.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SUREFIRE-1535) Surefire unable to run testng suites in parallel

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1535:
---
Fix Version/s: 2.22.1

> Surefire unable to run testng suites in parallel
> 
>
> Key: SUREFIRE-1535
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1535
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: TestNG support
>Affects Versions: 2.22.0
>Reporter: Andrey Panfilov
>Assignee: Tibor Digana
>Priority: Minor
> Fix For: 2.22.1
>
>
> Due to slowness nature of selenium test we would like to run such tests in 
> parallel, moreover, we also would like to avoid thread-safety issues, so our 
> option is to take advantage of  forkCount=N and reuseForks=false instead of 
> using built-in testng capabilities. Unfortunately, when using following maven 
> configuration:
> {code:java}
> 2
> false
> 
> Suite_1.xml
> Suite_2.xml
> 
> {code}
> it does not work like expected, i.e.:
>  * ForkStarter#runSuitesForkPerTestSet correctly spawns multiple JVMs and 
> passes individual testng suite to ForkStarter#fork
>  * TestNGProvider#invoke fails to cover the case that forkTestSet could be a 
> file and runs all testng suites instead of individual one.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] asfgit closed pull request #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel

2018-08-25 Thread GitBox
asfgit closed pull request #190: [SUREFIRE-1535] Surefire unable to run testng 
suites in parallel
URL: https://github.com/apache/maven-surefire/pull/190
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/BooterSerializer.java
 
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/BooterSerializer.java
index 97140efa9..9c501db29 100644
--- 
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/BooterSerializer.java
+++ 
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/BooterSerializer.java
@@ -36,6 +36,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.util.Collections;
 import java.util.List;
 
 import static 
org.apache.maven.surefire.booter.AbstractPathConfiguration.CHILD_DELEGATION;
@@ -125,7 +126,14 @@ File serialize( KeyValueSource sourceProperties, 
ProviderConfiguration booterCon
 if ( testSuiteDefinition != null )
 {
 properties.setProperty( SOURCE_DIRECTORY, 
testSuiteDefinition.getTestSourceDirectory() );
-properties.addList( testSuiteDefinition.getSuiteXmlFiles(), 
TEST_SUITE_XML_FILES );
+if ( testSet instanceof File )
+{
+properties.addList( Collections.singletonList( (File) testSet 
), TEST_SUITE_XML_FILES );
+}
+else
+{
+properties.addList( testSuiteDefinition.getSuiteXmlFiles(), 
TEST_SUITE_XML_FILES );
+}
 TestListResolver testFilter = 
testSuiteDefinition.getTestListResolver();
 properties.setProperty( REQUESTEDTEST, testFilter == null ? "" : 
testFilter.getPluginParameterTest() );
 int rerunFailingTestsCount = 
testSuiteDefinition.getRerunFailingTestsCount();
diff --git 
a/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1535TestNGParallelSuitesIT.java
 
b/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1535TestNGParallelSuitesIT.java
new file mode 100644
index 0..3e4b0f2e1
--- /dev/null
+++ 
b/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1535TestNGParallelSuitesIT.java
@@ -0,0 +1,62 @@
+package org.apache.maven.surefire.its.jiras;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.surefire.its.fixture.OutputValidator;
+import org.apache.maven.surefire.its.fixture.SurefireJUnit4IntegrationTestCase;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class Surefire1535TestNGParallelSuitesIT extends 
SurefireJUnit4IntegrationTestCase
+{
+@Test
+public void testParallelSuites() throws Exception 
+{
+File tmp1 = null;
+File tmp2 = null;
+try
+{
+tmp1 = File.createTempFile( getClass().getName(), "tmp" );
+tmp2 = File.createTempFile( getClass().getName(), "tmp" );
+OutputValidator validator = 
unpack("/surefire-1535-parallel-testng").maven()
+.sysProp( "testNgVersion", "5.7" )
+.sysProp( "testNgClassifier", "jdk15" )
+.sysProp( "it.ParallelTest1", tmp1.getAbsolutePath() )
+.sysProp( "it.ParallelTest2", tmp2.getAbsolutePath() )
+.executeTest();
+Assert.assertFalse(tmp1.exists());
+Assert.assertFalse(tmp2.exists());
+validator.assertTestSuiteResults( 2, 0, 0, 0 );
+}
+finally
+{
+if (tmp1 != null)
+{
+tmp1.delete();
+}
+if (tmp2 != null)
+{
+tmp2.delete();
+}
+}
+}
+}
diff --git 
a/surefire-its/src/test/resources/surefire-1535-parallel-testng/pom.xml 
b/surefire-its/src/test/resources/surefire-1535-parallel-testng/pom.xml
new file mode 1006

[jira] [Commented] (SUREFIRE-1535) Surefire unable to run testng suites in parallel

2018-08-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592697#comment-16592697
 ] 

ASF GitHub Bot commented on SUREFIRE-1535:
--

asfgit closed pull request #190: [SUREFIRE-1535] Surefire unable to run testng 
suites in parallel
URL: https://github.com/apache/maven-surefire/pull/190
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/BooterSerializer.java
 
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/BooterSerializer.java
index 97140efa9..9c501db29 100644
--- 
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/BooterSerializer.java
+++ 
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/BooterSerializer.java
@@ -36,6 +36,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.util.Collections;
 import java.util.List;
 
 import static 
org.apache.maven.surefire.booter.AbstractPathConfiguration.CHILD_DELEGATION;
@@ -125,7 +126,14 @@ File serialize( KeyValueSource sourceProperties, 
ProviderConfiguration booterCon
 if ( testSuiteDefinition != null )
 {
 properties.setProperty( SOURCE_DIRECTORY, 
testSuiteDefinition.getTestSourceDirectory() );
-properties.addList( testSuiteDefinition.getSuiteXmlFiles(), 
TEST_SUITE_XML_FILES );
+if ( testSet instanceof File )
+{
+properties.addList( Collections.singletonList( (File) testSet 
), TEST_SUITE_XML_FILES );
+}
+else
+{
+properties.addList( testSuiteDefinition.getSuiteXmlFiles(), 
TEST_SUITE_XML_FILES );
+}
 TestListResolver testFilter = 
testSuiteDefinition.getTestListResolver();
 properties.setProperty( REQUESTEDTEST, testFilter == null ? "" : 
testFilter.getPluginParameterTest() );
 int rerunFailingTestsCount = 
testSuiteDefinition.getRerunFailingTestsCount();
diff --git 
a/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1535TestNGParallelSuitesIT.java
 
b/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1535TestNGParallelSuitesIT.java
new file mode 100644
index 0..3e4b0f2e1
--- /dev/null
+++ 
b/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1535TestNGParallelSuitesIT.java
@@ -0,0 +1,62 @@
+package org.apache.maven.surefire.its.jiras;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.surefire.its.fixture.OutputValidator;
+import org.apache.maven.surefire.its.fixture.SurefireJUnit4IntegrationTestCase;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class Surefire1535TestNGParallelSuitesIT extends 
SurefireJUnit4IntegrationTestCase
+{
+@Test
+public void testParallelSuites() throws Exception 
+{
+File tmp1 = null;
+File tmp2 = null;
+try
+{
+tmp1 = File.createTempFile( getClass().getName(), "tmp" );
+tmp2 = File.createTempFile( getClass().getName(), "tmp" );
+OutputValidator validator = 
unpack("/surefire-1535-parallel-testng").maven()
+.sysProp( "testNgVersion", "5.7" )
+.sysProp( "testNgClassifier", "jdk15" )
+.sysProp( "it.ParallelTest1", tmp1.getAbsolutePath() )
+.sysProp( "it.ParallelTest2", tmp2.getAbsolutePath() )
+.executeTest();
+Assert.assertFalse(tmp1.exists());
+Assert.assertFalse(tmp2.exists());
+validator.assertTestSuiteResults( 2, 0, 0, 0 );
+}
+finally
+{
+if (tmp1 != null)
+{
+tmp1.delete();
+}
+if (tmp2 !

[jira] [Closed] (SUREFIRE-1535) Surefire unable to run testng suites in parallel

2018-08-25 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed SUREFIRE-1535.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=99083b26bad8a6bf5305aaad08573850623b19d2

> Surefire unable to run testng suites in parallel
> 
>
> Key: SUREFIRE-1535
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1535
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: TestNG support
>Affects Versions: 2.22.0
>Reporter: Andrey Panfilov
>Assignee: Tibor Digana
>Priority: Minor
> Fix For: 2.22.1
>
>
> Due to slowness nature of selenium test we would like to run such tests in 
> parallel, moreover, we also would like to avoid thread-safety issues, so our 
> option is to take advantage of  forkCount=N and reuseForks=false instead of 
> using built-in testng capabilities. Unfortunately, when using following maven 
> configuration:
> {code:java}
> 2
> false
> 
> Suite_1.xml
> Suite_2.xml
> 
> {code}
> it does not work like expected, i.e.:
>  * ForkStarter#runSuitesForkPerTestSet correctly spawns multiple JVMs and 
> passes individual testng suite to ForkStarter#fork
>  * TestNGProvider#invoke fails to cover the case that forkTestSet could be a 
> file and runs all testng suites instead of individual one.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MDEPLOY-241) Remove uniqueVersion parameter

2018-08-25 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MDEPLOY-241:
---

 Summary: Remove uniqueVersion parameter
 Key: MDEPLOY-241
 URL: https://issues.apache.org/jira/browse/MDEPLOY-241
 Project: Maven Deploy Plugin
  Issue Type: Improvement
Affects Versions: 2.8.2
Reporter: Karl Heinz Marbaise
 Fix For: 3.0.0


The parameter for {{uniqueVersion}} should be removed with major release. 
A note in migration guide should be made.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MDEPLOY-241) Remove uniqueVersion parameter

2018-08-25 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MDEPLOY-241.
---
   Resolution: Duplicate
 Assignee: Karl Heinz Marbaise
Fix Version/s: (was: 3.0.0)

See MDEPLOY-211

> Remove uniqueVersion parameter
> --
>
> Key: MDEPLOY-241
> URL: https://issues.apache.org/jira/browse/MDEPLOY-241
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>Affects Versions: 2.8.2
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> The parameter for {{uniqueVersion}} should be removed with major release. 
> A note in migration guide should be made.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] asfgit closed pull request #4: Correct link to Jenkins builds

2018-08-25 Thread GitBox
asfgit closed pull request #4: Correct link to Jenkins builds
URL: https://github.com/apache/maven-fluido-skin/pull/4
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 2ec5e2e..37a8b13 100644
--- a/pom.xml
+++ b/pom.xml
@@ -49,7 +49,7 @@ under the License.
   
   
 Jenkins
-
https://builds.apache.org/view/M-R/view/Maven/job/maven-fluido-skin/
+https://builds.apache.org/job/maven-box/job/maven-fluido-skin/
   
   
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #5: Correct link to Github edit Fork me link

2018-08-25 Thread GitBox
asfgit closed pull request #5: Correct link to Github edit Fork me link
URL: https://github.com/apache/maven-fluido-skin/pull/5
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/site/site.xml b/src/site/site.xml
index b801864..2423eb9 100644
--- a/src/site/site.xml
+++ b/src/site/site.xml
@@ -35,7 +35,7 @@ under the License.
   
   
   
-apache/maven-skins
+apache/${project.artifactId}
 right
 gray
   


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] michael-o commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena…

2018-08-25 Thread GitBox
michael-o commented on issue #1: MSKINS-137 Make the hamburger menu work with 
the top-navigation ena…
URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-415996525
 
 
   Cam someone rebase this? I will review and merge then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only

2018-08-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592705#comment-16592705
 ] 

ASF GitHub Bot commented on MSKINS-137:
---

michael-o commented on issue #1: MSKINS-137 Make the hamburger menu work with 
the top-navigation ena…
URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-415996525
 
 
   Cam someone rebase this? I will review and merge then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable "Hamburger menu" with top-nav only
> -
>
> Key: MSKINS-137
> URL: https://issues.apache.org/jira/browse/MSKINS-137
> Project: Maven Skins
>  Issue Type: Improvement
>Reporter: Josh Elser
>Priority: Major
>
> Revitalizing this old PR https://github.com/apache/maven-skins/pull/4
> Still an issue for us down in HBase. Changes seem to apply and have worked in 
> local testing on the HBase site.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] michael-o commented on issue #28: Fix for SCM-695 : Mvn release plugin problems with too many - in name

2018-08-25 Thread GitBox
michael-o commented on issue #28: Fix for SCM-695 : Mvn release plugin problems 
with too many - in name
URL: https://github.com/apache/maven-scm/pull/28#issuecomment-415998499
 
 
   Can someone please rebase and drop unaffected changes even if they are 
correct? We also need a proper IT which reproduces the issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (SCM-695) Mvn release plugin problems with too many - in name

2018-08-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCM-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592714#comment-16592714
 ] 

ASF GitHub Bot commented on SCM-695:


michael-o commented on issue #28: Fix for SCM-695 : Mvn release plugin problems 
with too many - in name
URL: https://github.com/apache/maven-scm/pull/28#issuecomment-415998499
 
 
   Can someone please rebase and drop unaffected changes even if they are 
correct? We also need a proper IT which reproduces the issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Mvn release plugin problems with too many - in name
> ---
>
> Key: SCM-695
> URL: https://issues.apache.org/jira/browse/SCM-695
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.7
> Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100)
> Maven home: /home/devent/apps/apache-maven-3.0.3
> Java version: 1.7.0_b147-icedtea, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.1/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.1.9-1.fc16.i686", arch: "i386", family: "unix"
>Reporter: Erwin Mueller
>Priority: Blocker
> Fix For: waiting-for-feedback
>
> Attachments: mvn-release-prepare.log
>
>
> Have maven problems with modules containing too many "-"?
> I have projects that are named:
> {noformat}
> globalpom-groovy/
> globalpom-groovy/globalpom-groovy/pom.xml < parent pom
> globalpom-groovy/globalpom-groovy-izpack/pom.xml
> globalpom-groovy/globalpom-groovy-izpack-snglejar/pom.xml
> globalpom-groovy/globalpom-groovy-testutils/pom.xml
> {noformat}
> But if I do mvn release:prepare inside of globalpom-groovy/globalpom-groovy/, 
> then I get the error:
> {noformat}
> [INFO] Executing: /bin/sh -c cd 
> /mnt/read/projects/com.anrisoftware/globalpom/globalpom-groovy/globalpom-
> groovy && git add -- pom.xml -izpack/pom.xml -izpack-singlejar/pom.xml -
> testutils/pom.xml
> [INFO] Working directory: 
> /mnt/read/projects/com.anrisoftware/globalpom/globalpom-groovy/globalpom-
> groovy
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Global POM Groovy . FAILURE [12.365s]
> [INFO] Global POM Groovy IzPack .. SKIPPED
> [INFO] Global POM Groovy IzPack Single Jar ... SKIPPED
> [INFO] Global POM Groovy Test Utilities .. SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 13.066s
> [INFO] Finished at: Sat Jan 21 15:45:50 CET 2012
> [INFO] Final Memory: 12M/152M
> [INFO] 
> 
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-
> plugin:2.0:prepare (default-cli) on project globalpom-groovy: Unable to 
> commit 
> files
> [ERROR] Provider message:
> [ERROR] The git-add command failed.
> [ERROR] Command output:
> [ERROR] fatal: pathspec 'globalpom-groovy/-izpack/pom.xml' did not match any 
> files
> {noformat}
> Of course that's wrong 'globalpom-groovy/-izpack/pom.xml' should be 
> '../globalpom-groovy-izpack/pom.xml', or something like that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Moved] (MNGSITE-352) Copy edit and rewrite the docs

2018-08-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNGSITE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy moved MNG-6463 to MNGSITE-352:


Component/s: (was: Documentation: Guides)
Key: MNGSITE-352  (was: MNG-6463)
Project: Maven Project Web Site  (was: Maven)

> Copy edit and rewrite the docs
> --
>
> Key: MNGSITE-352
> URL: https://issues.apache.org/jira/browse/MNGSITE-352
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Major
> Attachments: MNG-6463-edit-guide-maven-development.patch
>
>
> Catch-all issue for editing and improvement



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)