[jira] [Commented] (MNG-6457) Resolving repository with an environment variable substitution fails when a parent pom needs to be looked up

2018-08-22 Thread Robert Scholte (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588568#comment-16588568
 ] 

Robert Scholte commented on MNG-6457:
-

I'm not convinced this is a valid case. If such a pom is consumed by a project 
and that system doesn't have this environment variable, it cannot find that 
parent.
It will also overcomplicate the resolution, see 
https://maven.apache.org/ref/3.5.4/maven-model-builder/ . Here you see that 
{{parent resolution}} is done before {{model interpolation}}. If we would allow 
this, we need to do early interpolation of environment variables and probably 
only for a few segments in the pom.


> Resolving repository with an environment variable substitution fails when a 
> parent pom needs to be looked up
> 
>
> Key: MNG-6457
> URL: https://issues.apache.org/jira/browse/MNG-6457
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.3.3, 3.5.2
> Environment: ubuntu 18.04, also with windows 10
>Reporter: Martin Knoller Stocker
>Priority: Major
>
> Having a repository entry with a environment variable substitution like 
>  
> {code:java}
> 
> 
> company-java-libs
> https://packagecloud.io/priv/${env.PACKAGECLOUD_JAVA_LIBS_READ_TOKEN}/company/java-libs/maven2
> 
> true
> 
> 
> true
> 
> 
> 
> {code}
> and a parent entry that is not present in your local repository
> {code:java}
>   
> company
> a-parent-module
> 1.0.0
>  
>   
> {code}
> produces a parsing error when running maven commands:
> {code:java}
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] Non-resolvable parent POM for __current_project_version__: Could 
> not transfer artifact company:a-parent-module:pom:1.0.0 in company-java-libs  
> from/to company-java-libs 
> (https://packagecloud.io/priv/${env.PACKAGECLOUD_JAVA_LIBS_READ_TOKEN}/company/java-libs/maven2):
>  Illegal character in path at index 30: 
> https://packagecloud.io/priv/${env.PACKAGECLOUD_JAVA_LIBS_READ_TOKEN}/company/java-libs/maven2/__path__
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (MJLINK-3) Improve verbose output during build

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MJLINK-3:


Assignee: Karl Heinz Marbaise

> Improve verbose output during build
> ---
>
> Key: MJLINK-3
> URL: https://issues.apache.org/jira/browse/MJLINK-3
> Project: Maven JLink Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0-alpha-2
>
>
> Currently the output during a build in relationship with 
> {{true}} looks like this:
> {code}
> [INFO]
> [INFO] --- maven-jlink-plugin:3.0.0-alpha-1:jlink (default-jlink) @ mod-jlink 
> ---
> [INFO] Toolchain in maven-jlink-plugin: jlink [ 
> /Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/bin/jlink 
> ]
> [INFO] The following dependencies will be linked into the runtime image:
> [INFO]  -> module: com.corporate.project ( 
> /../project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod )
> [INFO]  -> module: com.soebes.nine.one.jar ( 
> /../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar )
> [INFO]  -> module: com.soebes.nine.two.jar ( 
> /.../maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar )
> [INFO]
> com.corporate.project 
> file:///.../com/corporate/project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod
> com.soebes.nine.one.jar 
> file:///../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar
> com.soebes.nine.two.jar 
> file:///..//maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar
> java.base 
> file:///Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/jmods/java.base.jmod
> Providers:
>   java.base provides java.nio.file.spi.FileSystemProvider used by java.base
> [INFO] Building zip: 
> /.../maven-example-only-jars/mod-jlink/target/mod-jlink-1.0-SNAPSHOT.zip
> {code}
> The output should be correctly prefixed bei {{[INFO]}} etc. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MJLINK-3) Improve verbose output during build

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MJLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588610#comment-16588610
 ] 

Karl Heinz Marbaise commented on MJLINK-3:
--

Done in 
[2f2aa04f8cc93d9937a9a3f28647285dd5713937|https://gitbox.apache.org/repos/asf?p=maven-jlink-plugin.git;a=commitdiff;h=2f2aa04f8cc93d9937a9a3f28647285dd5713937]

> Improve verbose output during build
> ---
>
> Key: MJLINK-3
> URL: https://issues.apache.org/jira/browse/MJLINK-3
> Project: Maven JLink Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0-alpha-2
>
>
> Currently the output during a build in relationship with 
> {{true}} looks like this:
> {code}
> [INFO]
> [INFO] --- maven-jlink-plugin:3.0.0-alpha-1:jlink (default-jlink) @ mod-jlink 
> ---
> [INFO] Toolchain in maven-jlink-plugin: jlink [ 
> /Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/bin/jlink 
> ]
> [INFO] The following dependencies will be linked into the runtime image:
> [INFO]  -> module: com.corporate.project ( 
> /../project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod )
> [INFO]  -> module: com.soebes.nine.one.jar ( 
> /../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar )
> [INFO]  -> module: com.soebes.nine.two.jar ( 
> /.../maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar )
> [INFO]
> com.corporate.project 
> file:///.../com/corporate/project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod
> com.soebes.nine.one.jar 
> file:///../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar
> com.soebes.nine.two.jar 
> file:///..//maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar
> java.base 
> file:///Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/jmods/java.base.jmod
> Providers:
>   java.base provides java.nio.file.spi.FileSystemProvider used by java.base
> [INFO] Building zip: 
> /.../maven-example-only-jars/mod-jlink/target/mod-jlink-1.0-SNAPSHOT.zip
> {code}
> The output should be correctly prefixed bei {{[INFO]}} etc. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MJLINK-3) Improve verbose output during build

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MJLINK-3.

Resolution: Done

> Improve verbose output during build
> ---
>
> Key: MJLINK-3
> URL: https://issues.apache.org/jira/browse/MJLINK-3
> Project: Maven JLink Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0-alpha-2
>
>
> Currently the output during a build in relationship with 
> {{true}} looks like this:
> {code}
> [INFO]
> [INFO] --- maven-jlink-plugin:3.0.0-alpha-1:jlink (default-jlink) @ mod-jlink 
> ---
> [INFO] Toolchain in maven-jlink-plugin: jlink [ 
> /Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/bin/jlink 
> ]
> [INFO] The following dependencies will be linked into the runtime image:
> [INFO]  -> module: com.corporate.project ( 
> /../project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod )
> [INFO]  -> module: com.soebes.nine.one.jar ( 
> /../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar )
> [INFO]  -> module: com.soebes.nine.two.jar ( 
> /.../maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar )
> [INFO]
> com.corporate.project 
> file:///.../com/corporate/project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod
> com.soebes.nine.one.jar 
> file:///../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar
> com.soebes.nine.two.jar 
> file:///..//maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar
> java.base 
> file:///Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/jmods/java.base.jmod
> Providers:
>   java.base provides java.nio.file.spi.FileSystemProvider used by java.base
> [INFO] Building zip: 
> /.../maven-example-only-jars/mod-jlink/target/mod-jlink-1.0-SNAPSHOT.zip
> {code}
> The output should be correctly prefixed bei {{[INFO]}} etc. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] khmarbaise commented on issue #4: [MJLINK-3] Improve verbose output during build.

2018-08-22 Thread GitBox
khmarbaise commented on issue #4: [MJLINK-3] Improve verbose output during 
build.
URL: https://github.com/apache/maven-jlink-plugin/pull/4#issuecomment-414969042
 
 
   Many thanks for your contribution. The CI has shows everything Ok so far 
https://builds.apache.org/job/maven-box/job/maven-jlink-plugin/job/MJLINK-3/ I 
have merged your contribution to master. The result can been looked here: 
https://gitbox.apache.org/repos/asf?p=maven-jlink-plugin.git;a=commitdiff;h=2f2aa04f8cc93d9937a9a3f28647285dd5713937


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] khmarbaise closed pull request #4: [MJLINK-3] Improve verbose output during build.

2018-08-22 Thread GitBox
khmarbaise closed pull request #4: [MJLINK-3] Improve verbose output during 
build.
URL: https://github.com/apache/maven-jlink-plugin/pull/4
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/it/projects/MJLINK-3_improveVerboseOutput/invoker.properties 
b/src/it/projects/MJLINK-3_improveVerboseOutput/invoker.properties
new file mode 100644
index 000..8b74b48
--- /dev/null
+++ b/src/it/projects/MJLINK-3_improveVerboseOutput/invoker.properties
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.java.version = 1.9+
+invoker.goals = clean install
\ No newline at end of file
diff --git a/src/it/projects/MJLINK-3_improveVerboseOutput/pom.xml 
b/src/it/projects/MJLINK-3_improveVerboseOutput/pom.xml
new file mode 100644
index 000..46e9d79
--- /dev/null
+++ b/src/it/projects/MJLINK-3_improveVerboseOutput/pom.xml
@@ -0,0 +1,75 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  4.0.0
+  org.apache.maven.plugins.jlink.its
+  mjlink3
+  1.0.0-SNAPSHOT
+  jlink
+
+  
+1.9
+1.9
+UTF-8
+  
+
+  
+
+  
+  asm
+  org.ow2.asm
+  6.0
+
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-jlink-plugin
+@project.version@
+true
+
+  true
+  true
+  true
+
+  
+
+
+  
+
+  org.apache.maven.plugins
+  maven-compiler-plugin
+  3.7.0
+  
+${maven.compiler.source}
+${maven.compiler.target}
+  
+
+  
+
+  
+
+
\ No newline at end of file
diff --git 
a/src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkMojo.java 
b/src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkMojo.java
index 2a47e45..39e32ac 100644
--- a/src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkMojo.java
+++ b/src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkMojo.java
@@ -159,10 +159,15 @@ protected void executeCommand( Commandline cmd, File 
outputDirectory )
 
 if ( exitCode != 0 )
 {
+
 if ( StringUtils.isNotEmpty( output ) )
 {
 // Reconsider to use WARN / ERROR ?
-getLog().error( output );
+   //  getLog().error( output );
+for ( String outputLine : output.split( "\n" ) )
+{
+getLog().error( outputLine );
+}
 }
 
 StringBuilder msg = new StringBuilder( "\nExit code: " );
@@ -179,7 +184,11 @@ protected void executeCommand( Commandline cmd, File 
outputDirectory )
 
 if ( StringUtils.isNotEmpty( output ) )
 {
-getLog().info( output );
+//getLog().info( output );
+for ( String outputLine : output.split( "\n" ) )
+{
+getLog().info( outputLine );
+}
 }
 }
 catch ( CommandLineException e )


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MJLINK-3) Improve verbose output during build

2018-08-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MJLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588612#comment-16588612
 ] 

ASF GitHub Bot commented on MJLINK-3:
-

khmarbaise commented on issue #4: [MJLINK-3] Improve verbose output during 
build.
URL: https://github.com/apache/maven-jlink-plugin/pull/4#issuecomment-414969042
 
 
   Many thanks for your contribution. The CI has shows everything Ok so far 
https://builds.apache.org/job/maven-box/job/maven-jlink-plugin/job/MJLINK-3/ I 
have merged your contribution to master. The result can been looked here: 
https://gitbox.apache.org/repos/asf?p=maven-jlink-plugin.git;a=commitdiff;h=2f2aa04f8cc93d9937a9a3f28647285dd5713937


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve verbose output during build
> ---
>
> Key: MJLINK-3
> URL: https://issues.apache.org/jira/browse/MJLINK-3
> Project: Maven JLink Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0-alpha-2
>
>
> Currently the output during a build in relationship with 
> {{true}} looks like this:
> {code}
> [INFO]
> [INFO] --- maven-jlink-plugin:3.0.0-alpha-1:jlink (default-jlink) @ mod-jlink 
> ---
> [INFO] Toolchain in maven-jlink-plugin: jlink [ 
> /Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/bin/jlink 
> ]
> [INFO] The following dependencies will be linked into the runtime image:
> [INFO]  -> module: com.corporate.project ( 
> /../project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod )
> [INFO]  -> module: com.soebes.nine.one.jar ( 
> /../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar )
> [INFO]  -> module: com.soebes.nine.two.jar ( 
> /.../maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar )
> [INFO]
> com.corporate.project 
> file:///.../com/corporate/project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod
> com.soebes.nine.one.jar 
> file:///../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar
> com.soebes.nine.two.jar 
> file:///..//maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar
> java.base 
> file:///Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/jmods/java.base.jmod
> Providers:
>   java.base provides java.nio.file.spi.FileSystemProvider used by java.base
> [INFO] Building zip: 
> /.../maven-example-only-jars/mod-jlink/target/mod-jlink-1.0-SNAPSHOT.zip
> {code}
> The output should be correctly prefixed bei {{[INFO]}} etc. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MJLINK-3) Improve verbose output during build

2018-08-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MJLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588613#comment-16588613
 ] 

ASF GitHub Bot commented on MJLINK-3:
-

khmarbaise closed pull request #4: [MJLINK-3] Improve verbose output during 
build.
URL: https://github.com/apache/maven-jlink-plugin/pull/4
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/it/projects/MJLINK-3_improveVerboseOutput/invoker.properties 
b/src/it/projects/MJLINK-3_improveVerboseOutput/invoker.properties
new file mode 100644
index 000..8b74b48
--- /dev/null
+++ b/src/it/projects/MJLINK-3_improveVerboseOutput/invoker.properties
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.java.version = 1.9+
+invoker.goals = clean install
\ No newline at end of file
diff --git a/src/it/projects/MJLINK-3_improveVerboseOutput/pom.xml 
b/src/it/projects/MJLINK-3_improveVerboseOutput/pom.xml
new file mode 100644
index 000..46e9d79
--- /dev/null
+++ b/src/it/projects/MJLINK-3_improveVerboseOutput/pom.xml
@@ -0,0 +1,75 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  4.0.0
+  org.apache.maven.plugins.jlink.its
+  mjlink3
+  1.0.0-SNAPSHOT
+  jlink
+
+  
+1.9
+1.9
+UTF-8
+  
+
+  
+
+  
+  asm
+  org.ow2.asm
+  6.0
+
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-jlink-plugin
+@project.version@
+true
+
+  true
+  true
+  true
+
+  
+
+
+  
+
+  org.apache.maven.plugins
+  maven-compiler-plugin
+  3.7.0
+  
+${maven.compiler.source}
+${maven.compiler.target}
+  
+
+  
+
+  
+
+
\ No newline at end of file
diff --git 
a/src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkMojo.java 
b/src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkMojo.java
index 2a47e45..39e32ac 100644
--- a/src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkMojo.java
+++ b/src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkMojo.java
@@ -159,10 +159,15 @@ protected void executeCommand( Commandline cmd, File 
outputDirectory )
 
 if ( exitCode != 0 )
 {
+
 if ( StringUtils.isNotEmpty( output ) )
 {
 // Reconsider to use WARN / ERROR ?
-getLog().error( output );
+   //  getLog().error( output );
+for ( String outputLine : output.split( "\n" ) )
+{
+getLog().error( outputLine );
+}
 }
 
 StringBuilder msg = new StringBuilder( "\nExit code: " );
@@ -179,7 +184,11 @@ protected void executeCommand( Commandline cmd, File 
outputDirectory )
 
 if ( StringUtils.isNotEmpty( output ) )
 {
-getLog().info( output );
+//getLog().info( output );
+for ( String outputLine : output.split( "\n" ) )
+{
+getLog().info( outputLine );
+}
 }
 }
 catch ( CommandLineException e )


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve verbose output during build
> ---
>
> Key: MJLINK-3
> URL: https://issues.apache.org/jira/browse/MJLINK-3
> Project: Maven JLink Plugin
> 

[jira] [Commented] (MJLINK-3) Improve verbose output during build

2018-08-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MJLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588616#comment-16588616
 ] 

Hudson commented on MJLINK-3:
-

Build succeeded in Jenkins: Maven TLP » maven-jlink-plugin » master #27

See 
https://builds.apache.org/job/maven-box/job/maven-jlink-plugin/job/master/27/

> Improve verbose output during build
> ---
>
> Key: MJLINK-3
> URL: https://issues.apache.org/jira/browse/MJLINK-3
> Project: Maven JLink Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0-alpha-2
>
>
> Currently the output during a build in relationship with 
> {{true}} looks like this:
> {code}
> [INFO]
> [INFO] --- maven-jlink-plugin:3.0.0-alpha-1:jlink (default-jlink) @ mod-jlink 
> ---
> [INFO] Toolchain in maven-jlink-plugin: jlink [ 
> /Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/bin/jlink 
> ]
> [INFO] The following dependencies will be linked into the runtime image:
> [INFO]  -> module: com.corporate.project ( 
> /../project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod )
> [INFO]  -> module: com.soebes.nine.one.jar ( 
> /../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar )
> [INFO]  -> module: com.soebes.nine.two.jar ( 
> /.../maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar )
> [INFO]
> com.corporate.project 
> file:///.../com/corporate/project/first-jmod/1.0-SNAPSHOT/first-jmod-1.0-SNAPSHOT.jmod
> com.soebes.nine.one.jar 
> file:///../maven-example-only-jars/mod-1-jar/target/mod-1-jar-1.0-SNAPSHOT.jar
> com.soebes.nine.two.jar 
> file:///..//maven-example-only-jars/mod-2-jar/target/mod-2-jar-1.0-SNAPSHOT.jar
> java.base 
> file:///Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/jmods/java.base.jmod
> Providers:
>   java.base provides java.nio.file.spi.FileSystemProvider used by java.base
> [INFO] Building zip: 
> /.../maven-example-only-jars/mod-jlink/target/mod-jlink-1.0-SNAPSHOT.zip
> {code}
> The output should be correctly prefixed bei {{[INFO]}} etc. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MJAVADOC-527) detectLinks may pass invalid urls to javadoc

2018-08-22 Thread Roberto Benedetti (JIRA)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588665#comment-16588665
 ] 

Roberto Benedetti commented on MJAVADOC-527:


When searching for the the javadoc error I didn't find  MJAVADOC-283 so I 
opened a new issue. The example URL reported in that issue 
([http://jcp.org/aboutJava/communityprocess/final/jsr250/index.html/apidocs/package-list])
 does not return HTTP 200 any more, so I cannot check if a redirection occurred.

{{validateLinks}} solves this issue too but checking the content of every 
resource returned is quite time consuming. The proposed patch checks the 
resource we are redirected to is still named {{package-list}} which is fast and 
adequate in most cases. For tricky cases {{validateLinks}} could still be used.

> detectLinks may pass invalid urls to javadoc
> 
>
> Key: MJAVADOC-527
> URL: https://issues.apache.org/jira/browse/MJAVADOC-527
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 3.0.1
> Environment: Windows 10
> JDK 8
> Maven 3.5.2
>Reporter: Roberto Benedetti
>Priority: Major
>  Labels: detectLinks
>
> The url of artifact com.sun.mail:mailapi:1.5.5 is 
> [http://javamail.java.net/mailapi], so the plugin tests if 
> [http://javamail.java.net/mailapi/apidocs/package-list] is valid.
>  That url redirects to [https://javaee.github.io/javamail/] which is JavaMail 
> home page, so the plugin thinks the url is valid and passes it to javadoc.
>  javadoc warns about invalid link.
> Maybe checking if the effective url is still "package-list" would be safer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6461) lombok + assembly + jar 打包冲突

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588695#comment-16588695
 ] 

Karl Heinz Marbaise commented on MNG-6461:
--

First this is a compilation failure and not a bug in Maven..furthermore if you 
are using spring boot you should not use maven-assembly-plugin.. Use 
spring-boot-maven-plugin instead...Apart from that I can't read the chinese/??? 
information ..can you please translate them into english ?

> lombok + assembly + jar 打包冲突
> 
>
> Key: MNG-6461
> URL: https://issues.apache.org/jira/browse/MNG-6461
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap & Build
>Affects Versions: 3.5.4
> Environment: win10, jdk8,maven 3.5.4
>Reporter: 蓝白
>Priority: Major
>  Labels: build, maven
> Attachments: PagingInfo.java, aa.log
>
>
> 项目依赖:
>  spring boot 2.0.4
> lombok  1.16.22
> 使用了maven-assembly +  maven-jar-plugin后打包失败。
> 因为有一个类既有有参构造函数并且增加了@NoArgsConstructor注解,导致maven编译失败。
> 报错信息如下:
> Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: 
> Compilation failure 
> /C:/Users/fengz/Desktop/project/demo-web/src/main/java/com/demo/web/page/PagingInfo.java
>  :[24,1]已在类com.demo.web.page.PagingInfo中定义了构造器PagingInfo()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MINVOKER-242) Support ".java" programs as pre- and post build scripts

2018-08-22 Thread Christian Stein (JIRA)
Christian Stein created MINVOKER-242:


 Summary: Support ".java" programs as pre- and post build scripts
 Key: MINVOKER-242
 URL: https://issues.apache.org/jira/browse/MINVOKER-242
 Project: Maven Invoker Plugin
  Issue Type: Improvement
Reporter: Christian Stein


When running on Java 11, Invoker should allow JEP 330-compatible single-file 
source-code Java progams as pre- and post build scripts.

See [http://openjdk.java.net/jeps/330] for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MVERIFIER-33) Download checksums via https

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MVERIFIER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589135#comment-16589135
 ] 

Karl Heinz Marbaise commented on MVERIFIER-33:
--

Done in 
[39e5c093fcad8b0a7697a73c19618ca8520412c5|https://gitbox.apache.org/repos/asf?p=maven-verifier-plugin.git;a=commitdiff;h=39e5c093fcad8b0a7697a73c19618ca8520412c5]

> Download checksums via https
> 
>
> Key: MVERIFIER-33
> URL: https://issues.apache.org/jira/browse/MVERIFIER-33
> Project: Maven Verifier Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MVERIFIER-33) Download checksums via https

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MVERIFIER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MVERIFIER-33.

Resolution: Done

> Download checksums via https
> 
>
> Key: MVERIFIER-33
> URL: https://issues.apache.org/jira/browse/MVERIFIER-33
> Project: Maven Verifier Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MVERIFIER-33) Download checksums via https

2018-08-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MVERIFIER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589139#comment-16589139
 ] 

Hudson commented on MVERIFIER-33:
-

Build succeeded in Jenkins: Maven TLP » maven-verifier-plugin » master #28

See 
https://builds.apache.org/job/maven-box/job/maven-verifier-plugin/job/master/28/

> Download checksums via https
> 
>
> Key: MVERIFIER-33
> URL: https://issues.apache.org/jira/browse/MVERIFIER-33
> Project: Maven Verifier Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MSHARED-754) Upgrade parent to 32

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MSHARED-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589140#comment-16589140
 ] 

Karl Heinz Marbaise commented on MSHARED-754:
-

Done in 
[1ad76d442764b2318a19e93affb7aa48b5ff9dab|https://gitbox.apache.org/repos?p=asf?p=maven-file-management.git;a=commitdiff;h=1ad76d442764b2318a19e93affb7aa48b5ff9dab]

> Upgrade parent to 32
> 
>
> Key: MSHARED-754
> URL: https://issues.apache.org/jira/browse/MSHARED-754
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: file-management
>Affects Versions: file-management-3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: file-management-3.0.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MSHARED-754) Upgrade parent to 32

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MSHARED-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MSHARED-754.
---
Resolution: Done

> Upgrade parent to 32
> 
>
> Key: MSHARED-754
> URL: https://issues.apache.org/jira/browse/MSHARED-754
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: file-management
>Affects Versions: file-management-3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: file-management-3.0.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MSHARED-754) Upgrade parent to 32

2018-08-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MSHARED-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589142#comment-16589142
 ] 

Hudson commented on MSHARED-754:


Build succeeded in Jenkins: Maven TLP » maven-file-management » master #20

See 
https://builds.apache.org/job/maven-box/job/maven-file-management/job/master/20/

> Upgrade parent to 32
> 
>
> Key: MSHARED-754
> URL: https://issues.apache.org/jira/browse/MSHARED-754
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: file-management
>Affects Versions: file-management-3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: file-management-3.0.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MTOOLCHAINS-24) Upgrade maven-plugins parent to version 32

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589147#comment-16589147
 ] 

Karl Heinz Marbaise commented on MTOOLCHAINS-24:


Done in 
[4ee7d58f9f51c3e144b29a79c9bde7ea91819ea9|https://gitbox.apache.org/repos/asf?p=maven-toolchains-plugin.git;a=commitdiff;h=4ee7d58f9f51c3e144b29a79c9bde7ea91819ea9]

> Upgrade maven-plugins parent to version 32
> --
>
> Key: MTOOLCHAINS-24
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-24
> Project: Maven Toolchains Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MTOOLCHAINS-24) Upgrade maven-plugins parent to version 32

2018-08-22 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MTOOLCHAINS-24.
--
Resolution: Done
  Assignee: Robert Scholte  (was: Karl Heinz Marbaise)

> Upgrade maven-plugins parent to version 32
> --
>
> Key: MTOOLCHAINS-24
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-24
> Project: Maven Toolchains Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.0.0
>
>
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)