[jira] [Updated] (MPMD-249) The plugin documentation point to old (deprecated) rulesets
[ https://issues.apache.org/jira/browse/MPMD-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-249: Fix Version/s: 3.9.0 > The plugin documentation point to old (deprecated) rulesets > --- > > Key: MPMD-249 > URL: https://issues.apache.org/jira/browse/MPMD-249 > Project: Maven PMD Plugin > Issue Type: Bug >Reporter: Juan Martín Sotuyo Dodero >Assignee: Andreas Dangel > Fix For: 3.9.0 > > > As seen on: > http://maven.apache.org/plugins/maven-pmd-plugin/pmd-mojo.html#rulesets > The "stock Java rulesets" point to > http://pmd.github.io/pmd-5.5.1/pmd-java/rules/index.html > Which is an old version (5.5.1). Maybe it should always point to the latest > version? or maybe even the built in one? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MPMD-249) The plugin documentation point to old (deprecated) rulesets
[ https://issues.apache.org/jira/browse/MPMD-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317969#comment-16317969 ] Andreas Dangel commented on MPMD-249: - I've changed the link to https://pmd.github.io/latest/pmd_rules_java.html in master (will push https instead of http soon) with MPMD-247. Since this part of the documentation is generated from javadoc, it'll be difficult to point to the built-in PMD version ({{PMD.VERSION}}). > The plugin documentation point to old (deprecated) rulesets > --- > > Key: MPMD-249 > URL: https://issues.apache.org/jira/browse/MPMD-249 > Project: Maven PMD Plugin > Issue Type: Bug >Reporter: Juan Martín Sotuyo Dodero >Assignee: Andreas Dangel > Fix For: 3.9.0 > > > As seen on: > http://maven.apache.org/plugins/maven-pmd-plugin/pmd-mojo.html#rulesets > The "stock Java rulesets" point to > http://pmd.github.io/pmd-5.5.1/pmd-java/rules/index.html > Which is an old version (5.5.1). Maybe it should always point to the latest > version? or maybe even the built in one? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6326) Build continues when core extensions aren't found
[ https://issues.apache.org/jira/browse/MNG-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318048#comment-16318048 ] Matt Biggs commented on MNG-6326: - I've been experimenting with an extension for gitflow that reads the git branch information and then adds a new remote repository to the build dynamically. I've had to use afterSessionStart() method to inject the repository as it doesn't work in afterProjectsRead() as i'm guessing that's too late in the lifecycle. Since it is using afterSessionStart() i've had to put my extension in the external extensions.xml file as the method isn't called if the extension is defined within a pom. However on initial first use the extension isn't obviously in your repository. It's actually housed in our local company nexus instance and so it can't be found (hence MNG-6327). The build issues a warning at the very beginning and then continues. That then leads to strange behaviour and it's also not very easy to spot the missing extension as it's a warning at the very beginning and unless you happen to browse to the top of the build log/console you won't know. > Build continues when core extensions aren't found > - > > Key: MNG-6326 > URL: https://issues.apache.org/jira/browse/MNG-6326 > Project: Maven > Issue Type: Bug > Components: Bootstrap & Build >Affects Versions: 3.5.2 >Reporter: Matt Biggs >Priority: Critical > > If you define a core extension in *.mvn/extensions.xml* which then can't be > retrieved/found the build issues a warning and then continues leading to > unexpected behaviour depending on the functionality provided by the > extension. > If the extension is defined in the pom and not found the build fails. I would > have expected it to fail when not found in the external extensions.xml file > too as it's quite easy to miss the fact it failed to retrieve it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6327) Add ability to easily retrieve core extensions from alternative pluginRepository
[ https://issues.apache.org/jira/browse/MNG-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318058#comment-16318058 ] Matt Biggs commented on MNG-6327: - The great thing about the extensions.xml file is it can be checked in to git giving all users the same setup. Unfortunately you can't do that with the settings.xml file so that then relies on me trying to get all users to configure their settings.xml file correctly. The profile part was a little misleading, it was just what I used to add our company nexus repository. I added the profile and then added a section. When you say add the repository manager did you mean via a mirror? I just wasn't aware of any other mechanism other than the profile or the mirror within settings.xml. > Add ability to easily retrieve core extensions from alternative > pluginRepository > > > Key: MNG-6327 > URL: https://issues.apache.org/jira/browse/MNG-6327 > Project: Maven > Issue Type: Improvement > Components: Bootstrap & Build >Affects Versions: 3.5.2 >Reporter: Matt Biggs >Priority: Critical > > If you define an extension in *.mvn/extensions.xml* it is automatically > retrieved and installed when you first build but ONLY if it is present in > maven central. > I understand it's obviously a little 'chicken and egg' scenario but it would > be really useful for making a seamless out of the box experience if it could > either a) read the pom and use the pluginRepositories from there, or b) if > you could perhaps specify the repository inside the extensions.xml file? > The only work around I can currently find is to ask the user to add an active > profile to their settings.xml which obviously isn't as nice. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1457) trimStackTrace should be disabled by default
[ https://issues.apache.org/jira/browse/SUREFIRE-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318217#comment-16318217 ] Réda Housni Alaoui commented on SUREFIRE-1457: -- [~tibor17], I understand that backward compatibility must be maintained between minor versions. But major versions are here to allow breaking changes. IMO, the question is "Is it a bad default?", if yes it should be changed in the next major version. Otherwise, we can't touch anything and we are forced to keep bad things because they have always been there? I can't think of a better way to kill any software project. Do we have to consider Maven as dead and move to gradle or other? > trimStackTrace should be disabled by default > > > Key: SUREFIRE-1457 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1457 > Project: Maven Surefire > Issue Type: Improvement >Affects Versions: 2.21.2 >Reporter: Réda Housni Alaoui >Assignee: Tibor Digana >Priority: Critical > > We are using Jenkins at work. > Each time we had test failures, stack trace were incomplete and therefore > totally useless. > I just discovered {{trimStackTrace}} option. > IMO, the fact that this option is currently enabled by default is a total non > sense. > Now we have to change the pom.xml of every projects of the company to have a > correct default. > IMO, and I think I am not the only one here, trimStackTrace should be > disabled by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MDEP-559) Java 9 bytecode cannot be parsed
[ https://issues.apache.org/jira/browse/MDEP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318290#comment-16318290 ] Giovanni Lovato commented on MDEP-559: -- Still experiencing this in 3.0.2 > Java 9 bytecode cannot be parsed > > > Key: MDEP-559 > URL: https://issues.apache.org/jira/browse/MDEP-559 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: analyze >Affects Versions: 3.0.0 > Environment: Apache Maven 3.3.9 > (NON-CANONICAL_2015-11-23T13:17:27+03:00_root; 2015-11-23T21:17:27+11:00) > Maven home: /opt/maven > Java version: 9-ea, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-9-jdk > Default locale: en_AU, platform encoding: UTF-8 > OS name: "linux", version: "4.9.11-1-arch", arch: "amd64", family: "unix" >Reporter: Ben Alex >Assignee: Robert Scholte > > Attempting to run analyze-only against source compiled with Java 9 results in: > {noformat} > [INFO] --- maven-dependency-plugin:3.0.0:analyze-only (config-dependency) @ > lmdbjava --- > [DEBUG] Configuring mojo > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only from > plugin realm > ClassRealm[plugin>org.apache.maven.plugins:maven-dependency-plugin:3.0.0, > parent: jdk.internal.loader.ClassLoaders$AppClassLoader@3b764bce] > [DEBUG] Configuring mojo > 'org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only' with > basic configurator --> > [DEBUG] (f) analyzer = default > [DEBUG] (f) baseDir = /home/bpa/projects/lmdbjava > [DEBUG] (f) failOnWarning = true > [DEBUG] (f) ignoreNonCompile = false > [DEBUG] (f) outputDirectory = /home/bpa/projects/lmdbjava/target > [DEBUG] (f) outputXML = false > [DEBUG] (f) project = MavenProject: org.lmdbjava:lmdbjava:0.0.6-SNAPSHOT @ > /home/bpa/projects/lmdbjava/dependency-reduced-pom.xml > [DEBUG] (f) scriptableFlag = $$%%% > [DEBUG] (f) scriptableOutput = false > [DEBUG] (f) skip = false > [DEBUG] (f) usedDependencies = [org.lmdbjava:lmdbjava-native-linux-x86_64, > org.lmdbjava:lmdbjava-native-windows-x86_64, > org.lmdbjava:lmdbjava-native-osx-x86_64] > [DEBUG] (f) verbose = false > [DEBUG] -- end configuration -- > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 7.256 s > [INFO] Finished at: 2017-03-17T17:32:20+11:00 > [INFO] Final Memory: 40M/132M > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only > (config-dependency) on project lmdbjava: Execution config-dependency of goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only failed. > IllegalArgumentException -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only > (config-dependency) on project lmdbjava: Execution config-dependency of goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only failed. > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:199) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:547) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnh
[jira] [Commented] (MDEP-559) Java 9 bytecode cannot be parsed
[ https://issues.apache.org/jira/browse/MDEP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318311#comment-16318311 ] Mark Raynsford commented on MDEP-559: - My understanding is that maven-dependency-analyzer-1.8 needs to be released first, and then a new version of the dependency plugin that uses 1.8. 3.0.2 still uses 1.7. > Java 9 bytecode cannot be parsed > > > Key: MDEP-559 > URL: https://issues.apache.org/jira/browse/MDEP-559 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: analyze >Affects Versions: 3.0.0 > Environment: Apache Maven 3.3.9 > (NON-CANONICAL_2015-11-23T13:17:27+03:00_root; 2015-11-23T21:17:27+11:00) > Maven home: /opt/maven > Java version: 9-ea, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-9-jdk > Default locale: en_AU, platform encoding: UTF-8 > OS name: "linux", version: "4.9.11-1-arch", arch: "amd64", family: "unix" >Reporter: Ben Alex >Assignee: Robert Scholte > > Attempting to run analyze-only against source compiled with Java 9 results in: > {noformat} > [INFO] --- maven-dependency-plugin:3.0.0:analyze-only (config-dependency) @ > lmdbjava --- > [DEBUG] Configuring mojo > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only from > plugin realm > ClassRealm[plugin>org.apache.maven.plugins:maven-dependency-plugin:3.0.0, > parent: jdk.internal.loader.ClassLoaders$AppClassLoader@3b764bce] > [DEBUG] Configuring mojo > 'org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only' with > basic configurator --> > [DEBUG] (f) analyzer = default > [DEBUG] (f) baseDir = /home/bpa/projects/lmdbjava > [DEBUG] (f) failOnWarning = true > [DEBUG] (f) ignoreNonCompile = false > [DEBUG] (f) outputDirectory = /home/bpa/projects/lmdbjava/target > [DEBUG] (f) outputXML = false > [DEBUG] (f) project = MavenProject: org.lmdbjava:lmdbjava:0.0.6-SNAPSHOT @ > /home/bpa/projects/lmdbjava/dependency-reduced-pom.xml > [DEBUG] (f) scriptableFlag = $$%%% > [DEBUG] (f) scriptableOutput = false > [DEBUG] (f) skip = false > [DEBUG] (f) usedDependencies = [org.lmdbjava:lmdbjava-native-linux-x86_64, > org.lmdbjava:lmdbjava-native-windows-x86_64, > org.lmdbjava:lmdbjava-native-osx-x86_64] > [DEBUG] (f) verbose = false > [DEBUG] -- end configuration -- > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 7.256 s > [INFO] Finished at: 2017-03-17T17:32:20+11:00 > [INFO] Final Memory: 40M/132M > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only > (config-dependency) on project lmdbjava: Execution config-dependency of goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only failed. > IllegalArgumentException -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only > (config-dependency) on project lmdbjava: Execution config-dependency of goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only failed. > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:199) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >
[jira] [Comment Edited] (MDEP-559) Java 9 bytecode cannot be parsed
[ https://issues.apache.org/jira/browse/MDEP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318311#comment-16318311 ] Mark Raynsford edited comment on MDEP-559 at 1/9/18 12:03 PM: -- My understanding is that maven-dependency-analyzer-1.8 needs to be released first, and then a new version of the dependency plugin that uses 1.8. 3.0.2 still uses 1.7 so it'll still have this problem. was (Author: io7m): My understanding is that maven-dependency-analyzer-1.8 needs to be released first, and then a new version of the dependency plugin that uses 1.8. 3.0.2 still uses 1.7. > Java 9 bytecode cannot be parsed > > > Key: MDEP-559 > URL: https://issues.apache.org/jira/browse/MDEP-559 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: analyze >Affects Versions: 3.0.0 > Environment: Apache Maven 3.3.9 > (NON-CANONICAL_2015-11-23T13:17:27+03:00_root; 2015-11-23T21:17:27+11:00) > Maven home: /opt/maven > Java version: 9-ea, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-9-jdk > Default locale: en_AU, platform encoding: UTF-8 > OS name: "linux", version: "4.9.11-1-arch", arch: "amd64", family: "unix" >Reporter: Ben Alex >Assignee: Robert Scholte > > Attempting to run analyze-only against source compiled with Java 9 results in: > {noformat} > [INFO] --- maven-dependency-plugin:3.0.0:analyze-only (config-dependency) @ > lmdbjava --- > [DEBUG] Configuring mojo > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only from > plugin realm > ClassRealm[plugin>org.apache.maven.plugins:maven-dependency-plugin:3.0.0, > parent: jdk.internal.loader.ClassLoaders$AppClassLoader@3b764bce] > [DEBUG] Configuring mojo > 'org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only' with > basic configurator --> > [DEBUG] (f) analyzer = default > [DEBUG] (f) baseDir = /home/bpa/projects/lmdbjava > [DEBUG] (f) failOnWarning = true > [DEBUG] (f) ignoreNonCompile = false > [DEBUG] (f) outputDirectory = /home/bpa/projects/lmdbjava/target > [DEBUG] (f) outputXML = false > [DEBUG] (f) project = MavenProject: org.lmdbjava:lmdbjava:0.0.6-SNAPSHOT @ > /home/bpa/projects/lmdbjava/dependency-reduced-pom.xml > [DEBUG] (f) scriptableFlag = $$%%% > [DEBUG] (f) scriptableOutput = false > [DEBUG] (f) skip = false > [DEBUG] (f) usedDependencies = [org.lmdbjava:lmdbjava-native-linux-x86_64, > org.lmdbjava:lmdbjava-native-windows-x86_64, > org.lmdbjava:lmdbjava-native-osx-x86_64] > [DEBUG] (f) verbose = false > [DEBUG] -- end configuration -- > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 7.256 s > [INFO] Finished at: 2017-03-17T17:32:20+11:00 > [INFO] Final Memory: 40M/132M > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only > (config-dependency) on project lmdbjava: Execution config-dependency of goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only failed. > IllegalArgumentException -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only > (config-dependency) on project lmdbjava: Execution config-dependency of goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only failed. > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:199) > at > java.base/jdk.internal.reflect.NativeMethod
[jira] [Commented] (SUREFIRE-1330) JUnit 5 surefire-provider code donation
[ https://issues.apache.org/jira/browse/SUREFIRE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318803#comment-16318803 ] David J. M. Karlsen commented on SUREFIRE-1330: --- Is there any progress on this? It's s bit of an obstacle - and I don't want to downgrade to surefire 2.19 which brings other problems. > JUnit 5 surefire-provider code donation > --- > > Key: SUREFIRE-1330 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1330 > Project: Maven Surefire > Issue Type: New Feature >Reporter: Benedikt Ritter >Assignee: Tibor Digana > Labels: junit5 > Fix For: 3.0-RC1 > > Attachments: junit-platform-surefire-provider.zip > > > The JUnit team wishes to contribute their surefire provider implementation > for JUnit 5 to the Maven team. > The code is currently located at GitHub: > https://github.com/junit-team/junit5/tree/master/junit-platform-surefire-provider > They have recently relicensed the code under terms of Apache License 2.0: > https://github.com/junit-team/junit5/issues/541 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (MENFORCER-278) Upgrade mockito to 2.X to prevent JDK 9 WARNINGs
[ https://issues.apache.org/jira/browse/MENFORCER-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MENFORCER-278. - Resolution: Fixed Done in [48508c51afe26c15d6c246be88e603831c8fb864|https://gitbox.apache.org/repos/asf?p=maven-enforcer.git;a=commitdiff;h=48508c51afe26c15d6c246be88e603831c8fb864] > Upgrade mockito to 2.X to prevent JDK 9 WARNINGs > > > Key: MENFORCER-278 > URL: https://issues.apache.org/jira/browse/MENFORCER-278 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0-M1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.0.0 > > > Upgrade Mockito Version to 2.X to prevent WARNING in Tests: > {code} > Running org.apache.maven.plugins.enforcer.TestDefaultEnforcementRuleHelper > WARNING: An illegal reflective access operation has occurred > WARNING: Illegal reflective access by org.mockito.cglib.core.ReflectUtils$2 > (file:/Users/kama/.m2/repository/org/mockito/mockito-core/1.9.5/mockito-core-1.9.5.jar) > to method > java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) > WARNING: Please consider reporting this to the maintainers of > org.mockito.cglib.core.ReflectUtils$2 > WARNING: Use --illegal-access=warn to enable warnings of further illegal > reflective access operations > WARNING: All illegal access operations will be denied in a future release > Second: > [INFO] --- maven-invoker-plugin:2.0.0:run (integration-t... > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MNG-6336) Aggregator Mojo should be executed only once even when part of the lifecycle
Francois MAROT created MNG-6336: --- Summary: Aggregator Mojo should be executed only once even when part of the lifecycle Key: MNG-6336 URL: https://issues.apache.org/jira/browse/MNG-6336 Project: Maven Issue Type: Improvement Components: core Affects Versions: 3.5.2 Reporter: Francois MAROT Priority: Minor Currently aggregator Mojo (annotated with @Mojo(aggregator=true, ...) ) are used to define Mojo whose goal whould be called directly, not bound to a lifecycle phase. This is the case for release:prepare / release:perform for exemple. I would be good if such aggregator Mojo ware also executed only once when part of a lifecycle. Currently we have to specify false in the pom. It would comply to the principle of least surprise because it seems every doc I found just say something "like these Mojo will be executed only once", and do not specify "in the case of direct invocation". I first reported this behavior on the mailing list: http://maven.40175.n5.nabble.com/Make-custom-plugin-executed-only-once-in-multimodule-inherited-false-aggregator-td5921630.html This JIRA may be related to improvement in the lifecycle ( MNG-5665 ) as suggested by [~rfscholte] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MSHARED-665) ASMDependencyAnalyzer.analyze(...) returns non-classes
[ https://issues.apache.org/jira/browse/MSHARED-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319064#comment-16319064 ] Robert Scholte commented on MSHARED-665: It looks like with MSHARED-660 the issues are gone. > ASMDependencyAnalyzer.analyze(...) returns non-classes > -- > > Key: MSHARED-665 > URL: https://issues.apache.org/jira/browse/MSHARED-665 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.7 >Reporter: Andreas Sewe > Attachments: example.zip > > > The {{ASMDependencyAnalyzer}} returns far to many bogus entries, which are > not class names at all. > The following is taken when the attached example project analyzes itself > ({{java -jar target/dependency-analyzer-test-0.0.1-SNAPSHOT.jar > file:target/dependency-analyzer-test-0.0.1-SNAPSHOT.jar}}): > {noformat} > Error retrieving checksum file for > charset=([.[^; ]]*) > java.lang.reflect.Array > Unable to resolve context key: > RuntimeInvisibleAnnotations > javax.swing.tree.TreeModel > Repetition count must be > 0 > project information for > empty > {noformat} > Note that this is not a problem in the classic {{dependency:analyze}} use > case: The goal simply computes the set of class dependencies (which contain > the aforementioned bogus class names) of the current project and compares > them with the set of classes of its dependencies (this set is fine). > If one wants to use the {{ASMDependencyAnalyzer}} as a standalone component, > however, these bogus class name make it pretty much *useless*. > Also, even in the {{dependency:analyze}} case, operating with sets that are a > lot larger than necessary (there are typically way more strings than class > names) may impact performance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MRESOURCES-237) Resource plugin's handling of symbolic links changed in 3.0.x, broke existing behavior
[ https://issues.apache.org/jira/browse/MRESOURCES-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319066#comment-16319066 ] Jonathan Haber commented on MRESOURCES-237: --- Just ran into this issue as well. We're seeing this cause the plugin execution to fail which prevents the build from proceeding. The output is: bq. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:3.0.2:resources (default-resources) on project FacsimileApi: /usr/share/hubspot/build/workspace/Facsimile/FacsimileApi/target/classes/migrations.xml (No such file or directory) -> [Help 1] > Resource plugin's handling of symbolic links changed in 3.0.x, broke existing > behavior > -- > > Key: MRESOURCES-237 > URL: https://issues.apache.org/jira/browse/MRESOURCES-237 > Project: Maven Resources Plugin > Issue Type: Bug >Affects Versions: 3.0.0, 3.0.1, 3.0.2 > Environment: Apache Maven 3.3.9 > (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00) > Java version: 1.8.0_121, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc25.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "4.9.11-200.fc25.x86_64", arch: "amd64", family: > "unix" >Reporter: Brian D. Johnson >Priority: Minor > > It looks like the handling of symbolic links in the > {{maven-resources-plugin}} has changed in version 3.0.x. I'm submitting a > JIRA because it breaks the previous behavior and I have not been able to find > this documented anywhere as an intended change. > *Use case:* Multi-module maven project. We have a custom log4j2 > configuration file we use during testing. Instead of maintaining this file > in multiple {{src/test/resources}} directories, we instead maintain a single > copy of the file at the project's root level and create symbolic links from > each module's {{src/test/resources}} directory to the file using relative > paths. > *2.7 Behavior:* the symlink was evaluated and the target file was copied to > {{target/test-classes/}}. > *3.0.x Behavior:* the symlink is copied to {{target/test-classes/}} verbatim. > The symlink's relative path results in the symlink pointing to the wrong > file location. The log4j2 configuration is not found. > *Requested Change:* Either revert to the original 2.7 behavior, or document > the change and provide a configuration parameter to allow the legacy behavior. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (MRESOURCES-237) Resource plugin's handling of symbolic links changed in 3.0.x, broke existing behavior
[ https://issues.apache.org/jira/browse/MRESOURCES-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319066#comment-16319066 ] Jonathan Haber edited comment on MRESOURCES-237 at 1/9/18 8:13 PM: --- Just ran into this issue as well. We're seeing this cause the plugin execution to fail which prevents the build from proceeding. The output is: bq. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:3.0.2:resources (default-resources) on project MyProject: /usr/MyProject/target/classes/myfile.xml (No such file or directory) -> [Help 1] was (Author: jhaber): Just ran into this issue as well. We're seeing this cause the plugin execution to fail which prevents the build from proceeding. The output is: bq. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:3.0.2:resources (default-resources) on project FacsimileApi: /usr/share/hubspot/build/workspace/Facsimile/FacsimileApi/target/classes/migrations.xml (No such file or directory) -> [Help 1] > Resource plugin's handling of symbolic links changed in 3.0.x, broke existing > behavior > -- > > Key: MRESOURCES-237 > URL: https://issues.apache.org/jira/browse/MRESOURCES-237 > Project: Maven Resources Plugin > Issue Type: Bug >Affects Versions: 3.0.0, 3.0.1, 3.0.2 > Environment: Apache Maven 3.3.9 > (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00) > Java version: 1.8.0_121, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc25.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "4.9.11-200.fc25.x86_64", arch: "amd64", family: > "unix" >Reporter: Brian D. Johnson >Priority: Minor > > It looks like the handling of symbolic links in the > {{maven-resources-plugin}} has changed in version 3.0.x. I'm submitting a > JIRA because it breaks the previous behavior and I have not been able to find > this documented anywhere as an intended change. > *Use case:* Multi-module maven project. We have a custom log4j2 > configuration file we use during testing. Instead of maintaining this file > in multiple {{src/test/resources}} directories, we instead maintain a single > copy of the file at the project's root level and create symbolic links from > each module's {{src/test/resources}} directory to the file using relative > paths. > *2.7 Behavior:* the symlink was evaluated and the target file was copied to > {{target/test-classes/}}. > *3.0.x Behavior:* the symlink is copied to {{target/test-classes/}} verbatim. > The symlink's relative path results in the symlink pointing to the wrong > file location. The log4j2 configuration is not found. > *Requested Change:* Either revert to the original 2.7 behavior, or document > the change and provide a configuration parameter to allow the legacy behavior. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MDEP-559) Java 9 bytecode cannot be parsed
[ https://issues.apache.org/jira/browse/MDEP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319067#comment-16319067 ] Robert Scholte commented on MDEP-559: - Let me release maven-dependency-analyzer-1.8 soon. > Java 9 bytecode cannot be parsed > > > Key: MDEP-559 > URL: https://issues.apache.org/jira/browse/MDEP-559 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: analyze >Affects Versions: 3.0.0 > Environment: Apache Maven 3.3.9 > (NON-CANONICAL_2015-11-23T13:17:27+03:00_root; 2015-11-23T21:17:27+11:00) > Maven home: /opt/maven > Java version: 9-ea, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-9-jdk > Default locale: en_AU, platform encoding: UTF-8 > OS name: "linux", version: "4.9.11-1-arch", arch: "amd64", family: "unix" >Reporter: Ben Alex >Assignee: Robert Scholte > > Attempting to run analyze-only against source compiled with Java 9 results in: > {noformat} > [INFO] --- maven-dependency-plugin:3.0.0:analyze-only (config-dependency) @ > lmdbjava --- > [DEBUG] Configuring mojo > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only from > plugin realm > ClassRealm[plugin>org.apache.maven.plugins:maven-dependency-plugin:3.0.0, > parent: jdk.internal.loader.ClassLoaders$AppClassLoader@3b764bce] > [DEBUG] Configuring mojo > 'org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only' with > basic configurator --> > [DEBUG] (f) analyzer = default > [DEBUG] (f) baseDir = /home/bpa/projects/lmdbjava > [DEBUG] (f) failOnWarning = true > [DEBUG] (f) ignoreNonCompile = false > [DEBUG] (f) outputDirectory = /home/bpa/projects/lmdbjava/target > [DEBUG] (f) outputXML = false > [DEBUG] (f) project = MavenProject: org.lmdbjava:lmdbjava:0.0.6-SNAPSHOT @ > /home/bpa/projects/lmdbjava/dependency-reduced-pom.xml > [DEBUG] (f) scriptableFlag = $$%%% > [DEBUG] (f) scriptableOutput = false > [DEBUG] (f) skip = false > [DEBUG] (f) usedDependencies = [org.lmdbjava:lmdbjava-native-linux-x86_64, > org.lmdbjava:lmdbjava-native-windows-x86_64, > org.lmdbjava:lmdbjava-native-osx-x86_64] > [DEBUG] (f) verbose = false > [DEBUG] -- end configuration -- > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 7.256 s > [INFO] Finished at: 2017-03-17T17:32:20+11:00 > [INFO] Final Memory: 40M/132M > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only > (config-dependency) on project lmdbjava: Execution config-dependency of goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only failed. > IllegalArgumentException -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only > (config-dependency) on project lmdbjava: Execution config-dependency of goal > org.apache.maven.plugins:maven-dependency-plugin:3.0.0:analyze-only failed. > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:199) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:547) > at > org.codehaus.plexus.classworlds.launcher.La
[jira] [Commented] (MRESOURCES-237) Resource plugin's handling of symbolic links changed in 3.0.x, broke existing behavior
[ https://issues.apache.org/jira/browse/MRESOURCES-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319069#comment-16319069 ] Jonathan Haber commented on MRESOURCES-237: --- Would you accept a PR that fixes this issue with symlinks? > Resource plugin's handling of symbolic links changed in 3.0.x, broke existing > behavior > -- > > Key: MRESOURCES-237 > URL: https://issues.apache.org/jira/browse/MRESOURCES-237 > Project: Maven Resources Plugin > Issue Type: Bug >Affects Versions: 3.0.0, 3.0.1, 3.0.2 > Environment: Apache Maven 3.3.9 > (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00) > Java version: 1.8.0_121, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc25.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "4.9.11-200.fc25.x86_64", arch: "amd64", family: > "unix" >Reporter: Brian D. Johnson >Priority: Minor > > It looks like the handling of symbolic links in the > {{maven-resources-plugin}} has changed in version 3.0.x. I'm submitting a > JIRA because it breaks the previous behavior and I have not been able to find > this documented anywhere as an intended change. > *Use case:* Multi-module maven project. We have a custom log4j2 > configuration file we use during testing. Instead of maintaining this file > in multiple {{src/test/resources}} directories, we instead maintain a single > copy of the file at the project's root level and create symbolic links from > each module's {{src/test/resources}} directory to the file using relative > paths. > *2.7 Behavior:* the symlink was evaluated and the target file was copied to > {{target/test-classes/}}. > *3.0.x Behavior:* the symlink is copied to {{target/test-classes/}} verbatim. > The symlink's relative path results in the symlink pointing to the wrong > file location. The log4j2 configuration is not found. > *Requested Change:* Either revert to the original 2.7 behavior, or document > the change and provide a configuration parameter to allow the legacy behavior. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MPMD-243) excludeFromFailureFile configuration does not work
[ https://issues.apache.org/jira/browse/MPMD-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319220#comment-16319220 ] Hudson commented on MPMD-243: - Build succeeded in Jenkins: Maven TLP » maven-pmd-plugin » master #11 See https://builds.apache.org/job/maven-box/job/maven-pmd-plugin/job/master/11/ > excludeFromFailureFile configuration does not work > -- > > Key: MPMD-243 > URL: https://issues.apache.org/jira/browse/MPMD-243 > Project: Maven PMD Plugin > Issue Type: Bug > Components: PMD >Affects Versions: 3.2, 3.5, 3.7, 3.8 >Reporter: Benedikt Ritter >Assignee: Andreas Dangel > Fix For: 3.9.0 > > > The excludeFromFailureFile configruation is ignored since version 3.1 of > Maven PMD plugin. Here is my plugin configuration: > {code} > > maven-pmd-plugin > > 3.8 > > true > > > > > check > > > > ${basedir}/config/pmd/pmd-exclude.properties > > > > > {code} > The pmd-exclude.properties file has the following content: > {code} > com.example.ClassWithLotsOfStaticImports=TooManyStaticImports > {code} > When I execude mvn clean pmd:check, I get a violation for > ClassWithLotsOfStaticImports. It works with 3.0 and 3.1. I've testet several > version above 3.1. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] don-vip commented on issue #9: upgrade to ASM 6.0 (final)
don-vip commented on issue #9: upgrade to ASM 6.0 (final) URL: https://github.com/apache/maven-plugin-tools/pull/9#issuecomment-356422339 @rfscholte is there a problem holding back to merge this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rfscholte commented on issue #9: upgrade to ASM 6.0 (final)
rfscholte commented on issue #9: upgrade to ASM 6.0 (final) URL: https://github.com/apache/maven-plugin-tools/pull/9#issuecomment-356425065 time... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] don-vip commented on issue #9: upgrade to ASM 6.0 (final)
don-vip commented on issue #9: upgrade to ASM 6.0 (final) URL: https://github.com/apache/maven-plugin-tools/pull/9#issuecomment-356425745 ok :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MNG-6337) NPE on usage of DefaultMavenSettingsBuilder
Dominic Monroe created MNG-6337: --- Summary: NPE on usage of DefaultMavenSettingsBuilder Key: MNG-6337 URL: https://issues.apache.org/jira/browse/MNG-6337 Project: Maven Issue Type: Bug Components: core Affects Versions: 3.5.2 Reporter: Dominic Monroe Basic usage of the class results in an error. I am not writing java, but I have tried to translate. {code:title=Bar.java|borderStyle=solid} DefaultMavenSettingsBuilder x = new DefaultMavenSettingsBuilder(); x.buildSettings(); {code} This is the stacktrace, sorry that there is frames mixed in: {code} java.lang.NullPointerException at org.apache.maven.settings.DefaultMavenSettingsBuilder.build(DefaultMavenSettingsBuilder.java:90) at org.apache.maven.settings.DefaultMavenSettingsBuilder.buildSettings(DefaultMavenSettingsBuilder.java:76) at org.apache.maven.settings.DefaultMavenSettingsBuilder.buildSettings(DefaultMavenSettingsBuilder.java:56) at user$eval3.invokeStatic(NO_SOURCE_FILE:2) at user$eval3.invoke(NO_SOURCE_FILE:2) at clojure.lang.Compiler.eval(Compiler.java:6927) at clojure.lang.Compiler.eval(Compiler.java:6890) at clojure.core$eval.invokeStatic(core.clj:3105) at clojure.core$eval.invoke(core.clj:3101) at clojure.main$repl$read_eval_print__7408$fn__7411.invoke(main.clj:240) at clojure.main$repl$read_eval_print__7408.invoke(main.clj:240) at clojure.main$repl$fn__7417.invoke(main.clj:258) at clojure.main$repl.invokeStatic(main.clj:258) at clojure.main$repl_opt.invokeStatic(main.clj:322) at clojure.main$main.invokeStatic(main.clj:421) at clojure.main$main.doInvoke(main.clj:384) at clojure.lang.RestFn.invoke(RestFn.java:397) at clojure.lang.Var.invoke(Var.java:375) at clojure.lang.AFn.applyToHelper(AFn.java:152) at clojure.lang.Var.applyTo(Var.java:700) at clojure.main.main(main.java:37) {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MPOM-170) migrate to Git
[ https://issues.apache.org/jira/browse/MPOM-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319263#comment-16319263 ] Hudson commented on MPOM-170: - Build succeeded in Jenkins: Maven TLP » maven-apache-parent » master #8 See https://builds.apache.org/job/maven-box/job/maven-apache-parent/job/master/8/ > migrate to Git > -- > > Key: MPOM-170 > URL: https://issues.apache.org/jira/browse/MPOM-170 > Project: Maven POMs > Issue Type: Task > Components: asf >Affects Versions: ASF-18 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Trivial > Fix For: ASF-19 > > > https://gitbox.apache.org/repos/asf/maven-apache-parent.git > CI: https://builds.apache.org/view/M-R/view/Maven/job/ASF%20Parent%20Pom/ -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] asfgit closed pull request #18: MRELEASE-985
asfgit closed pull request #18: MRELEASE-985 URL: https://github.com/apache/maven-release/pull/18 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java index 522fef4a..65d325f1 100644 --- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java +++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java @@ -103,6 +103,8 @@ public static ReleaseDescriptor merge( ReleaseDescriptor mergeInto, ReleaseDescr mergeInto.setPushChanges( toBeMerged.isPushChanges() ); mergeInto.setWaitBeforeTagging( toBeMerged.getWaitBeforeTagging() ); +mergeInto.setResolvedSnapshotDependencies( toBeMerged.getResolvedSnapshotDependencies() ); + // If the user specifies versions, these should be override the existing versions if ( toBeMerged.getReleaseVersions() != null ) { diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java index dd3c85f2..444b470e 100644 --- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java +++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java @@ -110,7 +110,7 @@ public ReleaseResult execute( ReleaseDescriptor releaseDescriptor, ReleaseEnviro } else { -logInfo( result, "Ignoring SNAPSHOT depenedencies and plugins ..." ); +logInfo( result, "Ignoring SNAPSHOT dependencies and plugins ..." ); } result.setResultCode( ReleaseResult.SUCCESS ); @@ -131,7 +131,7 @@ private void checkProject( MavenProject project, Map originalVer usedSnapshotDependencies.add( project.getParentArtifact() ); } } - + try { @SuppressWarnings( "unchecked" ) @@ -156,7 +156,7 @@ private void checkProject( MavenProject project, Map originalVer @SuppressWarnings( "unchecked" ) Set extensionArtifacts = project.getExtensionArtifacts(); checkExtensions( originalVersions, releaseDescriptor, artifactMap, extensionArtifacts ); - + //@todo check profiles if ( !usedSnapshotDependencies.isEmpty() || !usedSnapshotReports.isEmpty() @@ -315,13 +315,21 @@ private static Artifact getArtifactFromMap( Artifact artifact, Map originalVersions, ReleaseDescriptor releaseDescriptor ) { + String versionlessArtifactKey = ArtifactUtils.versionlessKey( artifact.getGroupId(), artifact.getArtifactId() ); +if ( releaseDescriptor.getResolvedSnapshotDependencies().containsKey( versionlessArtifactKey ) ) +{ +artifact.setVersion( ( String ) ( ( Map ) releaseDescriptor.getResolvedSnapshotDependencies() + .get( versionlessArtifactKey ) ) +.get( ReleaseDescriptor.RELEASE_KEY ) ); +} + // We are only looking at dependencies external to the project - ignore anything found in the reactor as // it's version will be updated boolean result = artifact.isSnapshot() -&& !artifact.getBaseVersion().equals( originalVersions.get( versionlessArtifactKey ) ); +&& !artifact.getBaseVersion().equals( originalVersions.get( versionlessArtifactKey ) ); // If we have a snapshot but allowTimestampedSnapshots is true, accept the artifact if the version // indicates that it is a timestamped snapshot. diff --git a/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhaseTest.java b/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhaseTest.java index e0035144..8324eca7 100644 --- a/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhaseTest.java +++ b/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhaseTest.java @@ -22,14 +22,18 @@ import org.apache.maven.project.MavenProject; import org.apache.maven.shared.release.ReleaseExecutionException; import org.apache.maven.shared.release.ReleaseFailureException; +import org.apache.maven.shared.release.ReleaseRes
[jira] [Commented] (MRELEASE-985) Override SNAPSHOT dependencies from command line
[ https://issues.apache.org/jira/browse/MRELEASE-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319269#comment-16319269 ] ASF GitHub Bot commented on MRELEASE-985: - asfgit closed pull request #18: MRELEASE-985 URL: https://github.com/apache/maven-release/pull/18 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java index 522fef4a..65d325f1 100644 --- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java +++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java @@ -103,6 +103,8 @@ public static ReleaseDescriptor merge( ReleaseDescriptor mergeInto, ReleaseDescr mergeInto.setPushChanges( toBeMerged.isPushChanges() ); mergeInto.setWaitBeforeTagging( toBeMerged.getWaitBeforeTagging() ); +mergeInto.setResolvedSnapshotDependencies( toBeMerged.getResolvedSnapshotDependencies() ); + // If the user specifies versions, these should be override the existing versions if ( toBeMerged.getReleaseVersions() != null ) { diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java index dd3c85f2..444b470e 100644 --- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java +++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java @@ -110,7 +110,7 @@ public ReleaseResult execute( ReleaseDescriptor releaseDescriptor, ReleaseEnviro } else { -logInfo( result, "Ignoring SNAPSHOT depenedencies and plugins ..." ); +logInfo( result, "Ignoring SNAPSHOT dependencies and plugins ..." ); } result.setResultCode( ReleaseResult.SUCCESS ); @@ -131,7 +131,7 @@ private void checkProject( MavenProject project, Map originalVer usedSnapshotDependencies.add( project.getParentArtifact() ); } } - + try { @SuppressWarnings( "unchecked" ) @@ -156,7 +156,7 @@ private void checkProject( MavenProject project, Map originalVer @SuppressWarnings( "unchecked" ) Set extensionArtifacts = project.getExtensionArtifacts(); checkExtensions( originalVersions, releaseDescriptor, artifactMap, extensionArtifacts ); - + //@todo check profiles if ( !usedSnapshotDependencies.isEmpty() || !usedSnapshotReports.isEmpty() @@ -315,13 +315,21 @@ private static Artifact getArtifactFromMap( Artifact artifact, Map originalVersions, ReleaseDescriptor releaseDescriptor ) { + String versionlessArtifactKey = ArtifactUtils.versionlessKey( artifact.getGroupId(), artifact.getArtifactId() ); +if ( releaseDescriptor.getResolvedSnapshotDependencies().containsKey( versionlessArtifactKey ) ) +{ +artifact.setVersion( ( String ) ( ( Map ) releaseDescriptor.getResolvedSnapshotDependencies() + .get( versionlessArtifactKey ) ) +.get( ReleaseDescriptor.RELEASE_KEY ) ); +} + // We are only looking at dependencies external to the project - ignore anything found in the reactor as // it's version will be updated boolean result = artifact.isSnapshot() -&& !artifact.getBaseVersion().equals( originalVersions.get( versionlessArtifactKey ) ); +&& !artifact.getBaseVersion().equals( originalVersions.get( versionlessArtifactKey ) ); // If we have a snapshot but allowTimestampedSnapshots is true, accept the artifact if the version // indicates that it is a timestamped snapshot. diff --git a/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhaseTest.java b/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhaseTest.java index e0035144..8324eca7 100644 --- a/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhaseTest.java +++ b/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPh
[jira] [Closed] (MRELEASE-994) Drop Maven2 support
[ https://issues.apache.org/jira/browse/MRELEASE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MRELEASE-994. --- Resolution: Fixed Fixed in [0e16d46e3ac627dd3dddf28347178054cf77f7de|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=0e16d46e3ac627dd3dddf28347178054cf77f7de] > Drop Maven2 support > --- > > Key: MRELEASE-994 > URL: https://issues.apache.org/jira/browse/MRELEASE-994 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Robert Scholte >Assignee: Robert Scholte > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MRELEASE-994) Drop Maven2 support
[ https://issues.apache.org/jira/browse/MRELEASE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319296#comment-16319296 ] Hudson commented on MRELEASE-994: - Build succeeded in Jenkins: Maven TLP » maven-release » master #22 See https://builds.apache.org/job/maven-box/job/maven-release/job/master/22/ > Drop Maven2 support > --- > > Key: MRELEASE-994 > URL: https://issues.apache.org/jira/browse/MRELEASE-994 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Robert Scholte >Assignee: Robert Scholte > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MPOM-170) migrate to Git
[ https://issues.apache.org/jira/browse/MPOM-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319351#comment-16319351 ] Hudson commented on MPOM-170: - Build succeeded in Jenkins: Maven TLP » maven-apache-parent » master #9 See https://builds.apache.org/job/maven-box/job/maven-apache-parent/job/master/9/ > migrate to Git > -- > > Key: MPOM-170 > URL: https://issues.apache.org/jira/browse/MPOM-170 > Project: Maven POMs > Issue Type: Task > Components: asf >Affects Versions: ASF-18 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Trivial > Fix For: ASF-19 > > > https://gitbox.apache.org/repos/asf/maven-apache-parent.git > CI: https://builds.apache.org/view/M-R/view/Maven/job/ASF%20Parent%20Pom/ -- This message was sent by Atlassian JIRA (v6.4.14#64029)