[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218327#comment-16218327 ] ASF GitHub Bot commented on SCM-805: GitHub user theit opened a pull request: https://github.com/apache/maven-scm/pull/55 Fix for SCM-805 This pull request adds support for the SVN --pin-externals option in copy commands; see https://issues.apache.org/jira/browse/SCM-805 You can merge this pull request into a Git repository by running: $ git pull https://github.com/theit/maven-scm SCM-805 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-scm/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit b2cba71766cef6606aaba78d3d837b0681ad0d8f Author: Thorsten Heit Date: 2017-10-25T08:11:26Z Fix for SCM-805: Add SVN --pin-externals option to copy command in Tag operations > Add SVN --pin-externals option to copy command in Tag operations > > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra > Labels: externals, svn, tag > Fix For: 1.x > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MNG-6295) Inherited plugins are not properly ordered after merging with profile plugins in some special cases
kostd created MNG-6295:
--
Summary: Inherited plugins are not properly ordered after merging
with profile plugins in some special cases
Key: MNG-6295
URL: https://issues.apache.org/jira/browse/MNG-6295
Project: Maven
Issue Type: Bug
Components: Plugins and Lifecycle, Profiles
Affects Versions: 3.3.1
Environment: -- OS name: "windows 7", version: "6.1", arch: "amd64",
family: "dos"
-- Default locale: ru_RU, platform encoding: Cp1251
-- Java version: 1.8.0_77, vendor: Oracle Corporation
-- Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
2015-03-13T23:10:27+03:00)
Reporter: kostd
Attachments: mng-4416-reproducer.zip
See attached repro:
In some specific cases inherited executions order (on single phase) is
corrupted after merge with executions from profile.
1. Steps to reproduce:
1.1. cd to
mng-4416-reproducer/server-app/env-modules/child-with-profile-disabled/
1.2. mvn initialize:
{code}
[INFO]
[INFO] Building child-with-profile-disabled 3.20.0
[INFO]
[INFO]
[INFO] --- maven-antrun-plugin:1.3:run (first-execution-in-grandparent-pom) @
child-with-profile-disabled ---
[INFO] Executing tasks
[echo] first-execution-in-grandparent-pom
[INFO] Executed tasks
[INFO]
[INFO] --- maven-antrun-plugin:1.3:run (second-execution-in-grandparent-pom) @
child-with-profile-disabled ---
[INFO] Executing tasks
[echo] second-execution-in-grandparent-pom
[INFO] Executed tasks
[INFO]
[INFO] --- gmaven-plugin:1.5-jenkins-3:execute (single-execution-in-parent-pom)
@ child-with-profile-disabled ---
single-execution-in-parent-pom
[INFO]
[INFO] BUILD SUCCESS
[INFO]
{code}
U can see expected plugin execution ordering: grandparent executions first,
parent executions after.
1.3. cd to
mng-4416-reproducer/server-app/env-modules/child-with-profile-enabled/
1.4. mvn initialize:
{code}
[INFO]
[INFO] Building child-with-profile-enabled 3.20.0
[INFO]
[INFO]
[INFO] --- gmaven-plugin:1.5-jenkins-3:execute (single-execution-in-parent-pom)
@ child-with-profile-enabled ---
single-execution-in-parent-pom
[INFO]
[INFO] --- maven-antrun-plugin:1.3:run (first-execution-in-grandparent-pom) @
child-with-profile-enabled ---
[INFO] Executing tasks
[echo] first-execution-in-grandparent-pom
[INFO] Executed tasks
[INFO]
[INFO] --- maven-antrun-plugin:1.3:run (second-execution-in-grandparent-pom) @
child-with-profile-enabled ---
[INFO] Executing tasks
[echo] second-execution-in-grandparent-pom
[INFO] Executed tasks
[INFO]
[INFO] BUILD SUCCESS
[INFO]
{code}
As you see this is affected execution order: parent first, grandparent after.
It doesn`t metter, what grandparent-parent
order consider to correct, but order _must not_ be changed when profile
activated!
2. Reproduced on environment:
-- OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
-- Default locale: ru_RU, platform encoding: Cp1251
-- Java version: 1.8.0_77, vendor: Oracle Corporation
-- Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
2015-03-13T23:10:27+03:00)
3. Special conditions to reproduce:
3.1. plugin in test-profile (parent/pom.xml) must be the same as plugin defined
before affected executions(grandparent/pom.xml).
That is, in our case maven-compiler-plugin and maven-compiler-plugin
3.2. affected plugins must have different types: maven-antrun-plugin in
grandparent and gmaven-plugin in parent. Tried
with gmaven-plugin on grandparent -- cant reporduce.
3.3. depends on directory structure. Tried in flat structure -- cant reproduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MNG-6295) Inherited plugins are not properly ordered after merging with profile plugins in some special cases
[
https://issues.apache.org/jira/browse/MNG-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218856#comment-16218856
]
kostd commented on MNG-6295:
see also MNG-4416 [regression] Plugins are not properly ordered after merging
with profile plugins
github link https://github.com/argustelecom/MNG-6295-reproducer
P.S. This repro is simplified _real_ case from our big project. This case is
not sinthetic, repair is important for us.
> Inherited plugins are not properly ordered after merging with profile plugins
> in some special cases
> ---
>
> Key: MNG-6295
> URL: https://issues.apache.org/jira/browse/MNG-6295
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle, Profiles
>Affects Versions: 3.3.1
> Environment: -- OS name: "windows 7", version: "6.1", arch: "amd64",
> family: "dos"
> -- Default locale: ru_RU, platform encoding: Cp1251
> -- Java version: 1.8.0_77, vendor: Oracle Corporation
> -- Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
> 2015-03-13T23:10:27+03:00)
>Reporter: kostd
> Labels: execution-order
> Attachments: mng-4416-reproducer.zip
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> See attached repro:
> In some specific cases inherited executions order (on single phase) is
> corrupted after merge with executions from profile.
> 1. Steps to reproduce:
> 1.1. cd to
> mng-4416-reproducer/server-app/env-modules/child-with-profile-disabled/
> 1.2. mvn initialize:
> {code}
> [INFO]
>
> [INFO] Building child-with-profile-disabled 3.20.0
> [INFO]
>
> [INFO]
> [INFO] --- maven-antrun-plugin:1.3:run (first-execution-in-grandparent-pom) @
> child-with-profile-disabled ---
> [INFO] Executing tasks
> [echo] first-execution-in-grandparent-pom
> [INFO] Executed tasks
> [INFO]
> [INFO] --- maven-antrun-plugin:1.3:run (second-execution-in-grandparent-pom)
> @ child-with-profile-disabled ---
> [INFO] Executing tasks
> [echo] second-execution-in-grandparent-pom
> [INFO] Executed tasks
> [INFO]
> [INFO] --- gmaven-plugin:1.5-jenkins-3:execute
> (single-execution-in-parent-pom) @ child-with-profile-disabled ---
> single-execution-in-parent-pom
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> U can see expected plugin execution ordering: grandparent executions first,
> parent executions after.
> 1.3. cd to
> mng-4416-reproducer/server-app/env-modules/child-with-profile-enabled/
> 1.4. mvn initialize:
> {code}
> [INFO]
>
> [INFO] Building child-with-profile-enabled 3.20.0
> [INFO]
>
> [INFO]
> [INFO] --- gmaven-plugin:1.5-jenkins-3:execute
> (single-execution-in-parent-pom) @ child-with-profile-enabled ---
> single-execution-in-parent-pom
> [INFO]
> [INFO] --- maven-antrun-plugin:1.3:run (first-execution-in-grandparent-pom) @
> child-with-profile-enabled ---
> [INFO] Executing tasks
> [echo] first-execution-in-grandparent-pom
> [INFO] Executed tasks
> [INFO]
> [INFO] --- maven-antrun-plugin:1.3:run (second-execution-in-grandparent-pom)
> @ child-with-profile-enabled ---
> [INFO] Executing tasks
> [echo] second-execution-in-grandparent-pom
> [INFO] Executed tasks
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> As you see this is affected execution order: parent first, grandparent after.
> It doesn`t metter, what grandparent-parent
> order consider to correct, but order _must not_ be changed when profile
> activated!
> 2. Reproduced on environment:
> -- OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
> -- Default locale: ru_RU, platform encoding: Cp1251
> -- Java version: 1.8.0_77, vendor: Oracle Corporation
> -- Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
> 2015-03-13T23:10:27+03:00)
> 3. Special conditions to reproduce:
> 3.1. plugin in test-profile (parent/pom.xml) must be the same as plugin
> defined before affected executions(grandparent/pom.xml).
> That is, in our case maven-compiler-plugin and maven-compiler-plugin
> 3.2. affected plugins must have different types: maven-antrun-plugin in
> grandparent and gmaven-plugin in parent. Tried
> with gmaven-plugin on grandparent -- cant reporduce.
> 3.3. depends on
[jira] [Commented] (MNG-6295) Inherited plugins are not properly ordered after merging with profile plugins in some special cases
[
https://issues.apache.org/jira/browse/MNG-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218864#comment-16218864
]
kostd commented on MNG-6295:
{quote}
It doesn`t metter, what grandparent-parent
order consider to correct, but order must not be changed when profile activated!
{quote}
plugin in profile not bounded to initialize phase, so must not change execution
order on initialize
> Inherited plugins are not properly ordered after merging with profile plugins
> in some special cases
> ---
>
> Key: MNG-6295
> URL: https://issues.apache.org/jira/browse/MNG-6295
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle, Profiles
>Affects Versions: 3.3.1
> Environment: -- OS name: "windows 7", version: "6.1", arch: "amd64",
> family: "dos"
> -- Default locale: ru_RU, platform encoding: Cp1251
> -- Java version: 1.8.0_77, vendor: Oracle Corporation
> -- Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
> 2015-03-13T23:10:27+03:00)
>Reporter: kostd
> Labels: execution-order
> Attachments: mng-4416-reproducer.zip
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> See attached repro:
> In some specific cases inherited executions order (on single phase) is
> corrupted after merge with executions from profile.
> 1. Steps to reproduce:
> 1.1. cd to
> mng-4416-reproducer/server-app/env-modules/child-with-profile-disabled/
> 1.2. mvn initialize:
> {code}
> [INFO]
>
> [INFO] Building child-with-profile-disabled 3.20.0
> [INFO]
>
> [INFO]
> [INFO] --- maven-antrun-plugin:1.3:run (first-execution-in-grandparent-pom) @
> child-with-profile-disabled ---
> [INFO] Executing tasks
> [echo] first-execution-in-grandparent-pom
> [INFO] Executed tasks
> [INFO]
> [INFO] --- maven-antrun-plugin:1.3:run (second-execution-in-grandparent-pom)
> @ child-with-profile-disabled ---
> [INFO] Executing tasks
> [echo] second-execution-in-grandparent-pom
> [INFO] Executed tasks
> [INFO]
> [INFO] --- gmaven-plugin:1.5-jenkins-3:execute
> (single-execution-in-parent-pom) @ child-with-profile-disabled ---
> single-execution-in-parent-pom
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> U can see expected plugin execution ordering: grandparent executions first,
> parent executions after.
> 1.3. cd to
> mng-4416-reproducer/server-app/env-modules/child-with-profile-enabled/
> 1.4. mvn initialize:
> {code}
> [INFO]
>
> [INFO] Building child-with-profile-enabled 3.20.0
> [INFO]
>
> [INFO]
> [INFO] --- gmaven-plugin:1.5-jenkins-3:execute
> (single-execution-in-parent-pom) @ child-with-profile-enabled ---
> single-execution-in-parent-pom
> [INFO]
> [INFO] --- maven-antrun-plugin:1.3:run (first-execution-in-grandparent-pom) @
> child-with-profile-enabled ---
> [INFO] Executing tasks
> [echo] first-execution-in-grandparent-pom
> [INFO] Executed tasks
> [INFO]
> [INFO] --- maven-antrun-plugin:1.3:run (second-execution-in-grandparent-pom)
> @ child-with-profile-enabled ---
> [INFO] Executing tasks
> [echo] second-execution-in-grandparent-pom
> [INFO] Executed tasks
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> As you see this is affected execution order: parent first, grandparent after.
> It doesn`t metter, what grandparent-parent
> order consider to correct, but order _must not_ be changed when profile
> activated!
> 2. Reproduced on environment:
> -- OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
> -- Default locale: ru_RU, platform encoding: Cp1251
> -- Java version: 1.8.0_77, vendor: Oracle Corporation
> -- Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
> 2015-03-13T23:10:27+03:00)
> 3. Special conditions to reproduce:
> 3.1. plugin in test-profile (parent/pom.xml) must be the same as plugin
> defined before affected executions(grandparent/pom.xml).
> That is, in our case maven-compiler-plugin and maven-compiler-plugin
> 3.2. affected plugins must have different types: maven-antrun-plugin in
> grandparent and gmaven-plugin in parent. Tried
> with gmaven-plugin on grandparent -- cant reporduce.
> 3.3. depends on directory structure. Tried in flat structure
[jira] [Commented] (SUREFIRE-1424) javax.transaction.TransactionManager not visible with Java9
[
https://issues.apache.org/jira/browse/SUREFIRE-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219647#comment-16219647
]
Tibor Digana commented on SUREFIRE-1424:
[~eolivelli]
I think {{java.sql}} was {{for removal}} that time we investigated previous
issue for {{2.20.1}}.
I checked JDK internals, it is no more marked for removal in {{module-info}}.
So I think it was a bug in Java 9 and should not be tested with
{{--add-modules=java.sql}} now. At least this how far my understanding goes.
[~eolivelli]
>>Does this sound good to you
Yes it does.
Feel free to write a patch at GitHub.
[~rfscholte]
This {{mave-compiler-plugin}} issue should be then investigated in
[MCOMPILER|https://issues.apache.org/jira/browse/MCOMPILER], right?
> javax.transaction.TransactionManager not visible with Java9
> ---
>
> Key: SUREFIRE-1424
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1424
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.20.1
> Environment: Apache Maven 3.5.0
> (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
> Maven home: /Users/snicoll/tools/maven
> Java version: 9, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home
> Default locale: en_BE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Stephane Nicoll
>Assignee: Tibor Digana
>
> I am trying to port Spring Boot to Java9 and I am hitting an issue that looks
> like Maven specific. I've managed to trim down the problem to [a simple class
> that doesn't involve Spring
> Boot|https://github.com/snicoll-scratches/test-jta-java9]
> If I run this project on the command line, I get the following:
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.043 s <<<
> FAILURE! - in com.example.testjtajava9.TestJtaJava9ApplicationTests
> contextLoads(com.example.testjtajava9.TestJtaJava9ApplicationTests) Time
> elapsed: 0.006 s <<< ERROR!
> java.lang.NoClassDefFoundError: javax/transaction/TransactionManager
> at
> com.example.testjtajava9.TestJtaJava9ApplicationTests.contextLoads(TestJtaJava9ApplicationTests.java:9)
> Caused by: java.lang.ClassNotFoundException:
> javax.transaction.TransactionManager
> at
> com.example.testjtajava9.TestJtaJava9ApplicationTests.contextLoads(TestJtaJava9ApplicationTests.java:9)
> {noformat}
> If I run that test with IntelliJ IDEA, it passes. This sample project has
> also a simple Gradle build that shows it works with Gradle as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1436) Increase usability in quiet mode
[
https://issues.apache.org/jira/browse/SUREFIRE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219677#comment-16219677
]
Tibor Digana commented on SUREFIRE-1436:
[~kgyrtkirk]
I have committed fix now and successfully tested with {{-q
-Dmaven.surefire.debug=true}}.
Feel free to check it out from master.
> Increase usability in quiet mode
>
>
> Key: SUREFIRE-1436
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1436
> Project: Maven Surefire
> Issue Type: Wish
>Affects Versions: 2.20, 2.20.1
>Reporter: Zoltan Haindrich
>Assignee: Tibor Digana
> Fix For: 2.21.0.Jigsaw
>
>
> Prior to SUREFIRE-1436. The messages which were closely related to test
> execution were printed directly to the console instead of the logger.info
> https://github.com/apache/maven-surefire/commit/6a79127ab63273f0f1f5268c65e4806761871a46#diff-94128f02ad41a51dcab77c0e0756705fL136
> I always execute maven with `-q` because of the high volume of irrelevant
> messages it prints out.
> I miss the following messages when silent mode is active:
> {code}
> Running org.apache.hadoop.hive.cli.TestMiniLlapCliDriver
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.93 s - in
> org.apache.hadoop.hive.cli.TestMiniLlapCliDriver
> {code}
> * It would be great to get back the old behaviour
> * especially important to get back disaplaying the {{Listening for transport
> dt_socket at address: 5005}} message in case someone executes: {{mvn install
> -q -Dtest=TestA -Dmaven.surefire.debug}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1436) Increase usability in quiet mode
[
https://issues.apache.org/jira/browse/SUREFIRE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219681#comment-16219681
]
Tibor Digana commented on SUREFIRE-1436:
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=660a4cfab8bf78d8db42aa6cfc3366d8806035a0
> Increase usability in quiet mode
>
>
> Key: SUREFIRE-1436
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1436
> Project: Maven Surefire
> Issue Type: Wish
>Affects Versions: 2.20, 2.20.1
>Reporter: Zoltan Haindrich
>Assignee: Tibor Digana
> Fix For: 2.21.0.Jigsaw
>
>
> Prior to SUREFIRE-1436. The messages which were closely related to test
> execution were printed directly to the console instead of the logger.info
> https://github.com/apache/maven-surefire/commit/6a79127ab63273f0f1f5268c65e4806761871a46#diff-94128f02ad41a51dcab77c0e0756705fL136
> I always execute maven with `-q` because of the high volume of irrelevant
> messages it prints out.
> I miss the following messages when silent mode is active:
> {code}
> Running org.apache.hadoop.hive.cli.TestMiniLlapCliDriver
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.93 s - in
> org.apache.hadoop.hive.cli.TestMiniLlapCliDriver
> {code}
> * It would be great to get back the old behaviour
> * especially important to get back disaplaying the {{Listening for transport
> dt_socket at address: 5005}} message in case someone executes: {{mvn install
> -q -Dtest=TestA -Dmaven.surefire.debug}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
