[jira] [Closed] (MPLUGIN-320) JavaJavadocMojoDescriptorExtractor fails with Java 8 lambdas.

2017-01-15 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/MPLUGIN-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Boué closed MPLUGIN-320.
--
   Resolution: Fixed
 Assignee: Guillaume Boué
Fix Version/s: 3.5.1

> JavaJavadocMojoDescriptorExtractor fails with Java 8 lambdas.
> -
>
> Key: MPLUGIN-320
> URL: https://issues.apache.org/jira/browse/MPLUGIN-320
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-tools-java
>Affects Versions: 3.5
>Reporter: Antony Riley
>Assignee: Guillaume Boué
>Priority: Minor
> Fix For: 3.5.1
>
>
> JavaJavadocMojoDescriptorExtractor fails to parse the following source:
> {code:java}
> package com.example.plugin;
> import com.amazonaws.AmazonWebServiceClient;
> import com.amazonaws.services.ecr.AmazonECRClient;
> import com.amazonaws.services.ecs.AmazonECSClient;
> import java.util.function.Supplier;
> public enum AmazonClients {
> ECS(AmazonECSClient::new),
> ECR(AmazonECRClient::new);
> private final Supplier supplier;
>  AmazonClients(Supplier supplier) {
> this.supplier = new SingletonSupplier(supplier);
> }
> public  T get() {
> return (T) supplier.get();
> }
> private static class SingletonSupplier implements Supplier {
> private final Supplier realSupplier;
> private T instance;
> private SingletonSupplier(Supplier realSupplier) {
> this.realSupplier = realSupplier;
> }
> @Override
> public synchronized T get() {
> return instance == null ? instance = realSupplier.get() : 
> instance;
> }
> }
> }
> {code}
> It fails on the lamdas in the constructors, this causes 
> maven-plugin-plugin:helpmojo to fail with the following exception:
> {noformat}
> Caused by: com.thoughtworks.qdox.parser.ParseException: syntax error @[10,24] 
> in 
> file:/home/antony/work/example/src/main/java/com/example/plugin/AmazonClients.java
> at com.thoughtworks.qdox.parser.impl.Parser.yyerror(Parser.java:1739)
> at com.thoughtworks.qdox.parser.impl.Parser.yyparse(Parser.java:1861)
> at com.thoughtworks.qdox.parser.impl.Parser.parse(Parser.java:1720)
> at 
> com.thoughtworks.qdox.library.SourceLibrary.parse(SourceLibrary.java:232)
> at 
> com.thoughtworks.qdox.library.SourceLibrary.parse(SourceLibrary.java:209)
> at 
> com.thoughtworks.qdox.library.SourceLibrary.addSource(SourceLibrary.java:157)
> at 
> com.thoughtworks.qdox.library.SortedClassLibraryBuilder.addSource(SortedClassLibraryBuilder.java:173)
> at 
> com.thoughtworks.qdox.JavaProjectBuilder.addSource(JavaProjectBuilder.java:151)
> at 
> com.thoughtworks.qdox.JavaProjectBuilder$2.visitFile(JavaProjectBuilder.java:223)
> at 
> com.thoughtworks.qdox.directorywalker.DirectoryScanner.walk(DirectoryScanner.java:103)
> at 
> com.thoughtworks.qdox.directorywalker.DirectoryScanner.walk(DirectoryScanner.java:91)
> at 
> com.thoughtworks.qdox.directorywalker.DirectoryScanner.walk(DirectoryScanner.java:91)
> at 
> com.thoughtworks.qdox.directorywalker.DirectoryScanner.walk(DirectoryScanner.java:91)
> at 
> com.thoughtworks.qdox.directorywalker.DirectoryScanner.walk(DirectoryScanner.java:91)
> at 
> com.thoughtworks.qdox.directorywalker.DirectoryScanner.walk(DirectoryScanner.java:91)
> at 
> com.thoughtworks.qdox.directorywalker.DirectoryScanner.scan(DirectoryScanner.java:81)
> at 
> com.thoughtworks.qdox.JavaProjectBuilder.addSourceTree(JavaProjectBuilder.java:217)
> at 
> com.thoughtworks.qdox.JavaProjectBuilder.addSourceTree(JavaProjectBuilder.java:204)
> at 
> org.apache.maven.tools.plugin.extractor.javadoc.JavaJavadocMojoDescriptorExtractor.discoverClasses(JavaJavadocMojoDescriptorExtractor.java:625)
> at 
> org.apache.maven.tools.plugin.extractor.javadoc.JavaJavadocMojoDescriptorExtractor.execute(JavaJavadocMojoDescriptorExtractor.java:573)
> at 
> org.apache.maven.tools.plugin.scanner.DefaultMojoScanner.populatePluginDescriptor(DefaultMojoScanner.java:96)
> at 
> org.apache.maven.plugin.plugin.AbstractGeneratorMojo.execute(AbstractGeneratorMojo.java:283)
> at 
> org.apache.maven.plugin.plugin.HelpGeneratorMojo.execute(HelpGeneratorMojo.java:92)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> ... 21 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MPLUGIN-314) invalid requirement role generated in plugin.xml

2017-01-15 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/MPLUGIN-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Boué closed MPLUGIN-314.
--
   Resolution: Fixed
 Assignee: Guillaume Boué
Fix Version/s: 3.5.1

> invalid requirement role generated in plugin.xml
> 
>
> Key: MPLUGIN-314
> URL: https://issues.apache.org/jira/browse/MPLUGIN-314
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-tools-java
>Affects Versions: 3.4, 3.5
>Reporter: Jimmy Praet
>Assignee: Guillaume Boué
> Fix For: 3.5.1
>
> Attachments: plugin-bug.zip
>
>
> I ran into this issue when attempting to build a fork of the 
> versions-maven-plugin:
> In the plugin.xml the following is generated:
> {code:xml}
>   
> 
>   org$apache$maven$artifact$resolver$ArtifactResolver
>   resolver
> 
>   
> {code}
> The $ should be dots.
> This only seems to happen when your field is declared with a fully qualified 
> classname, and the class is also imported. If I remove the import or the 
> fully qualified classname, the problem disappears.
> {code:java}
> package plugin.bug;
> import org.apache.maven.plugin.AbstractMojo;
> import org.apache.maven.plugin.MojoExecutionException;
> import org.apache.maven.plugin.MojoFailureException;
> import org.apache.maven.artifact.resolver.ArtifactResolver;
> /**
>  * @goal foo
>  */
> public class FooMojo extends AbstractMojo {
>   /**
>* @component
>*/
>   private org.apache.maven.artifact.resolver.ArtifactResolver resolver;
>   public void execute() throws MojoExecutionException, 
> MojoFailureException {
>   }
> }
> {code}
> It works in version 3.3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MRELEASE-974) HTTP in project element

2017-01-15 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/MRELEASE-974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Boué closed MRELEASE-974.
---
Resolution: Not A Problem

> HTTP in project element
> ---
>
> Key: MRELEASE-974
> URL: https://issues.apache.org/jira/browse/MRELEASE-974
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: prepare
>Affects Versions: 2.5.3
>Reporter: Jeremy Landis
>Priority: Minor
>
> In the pom on the  tag, I'd like to use https as they are available 
> for the xmlns, xmlns:xsi, and xsi:schemaLocation locations.  When I run other 
> plugins it's fine but if I try to release it fails.  It initially fails with 
> xmlns:xsi issue.  If I set that back to http, then it flags tags all with 
> http throughout and crashes.  
> What I have to use now...
> ```
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> ```
> What I would like to use...
> ```
> https://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance"; 
> xsi:schemaLocation="https://maven.apache.org/POM/4.0.0 
> https://maven.apache.org/xsd/maven-4.0.0.xsd";>
> ```
> Is this possible?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MPLUGIN-290) Version 3.4 fails to parse enums with Regex patterns

2017-01-15 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MPLUGIN-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823120#comment-15823120
 ] 

Guillaume Boué commented on MPLUGIN-290:


Fixed implictly during the upgrade of QDox to version 2.0-M5, done in 
MPLUGIN-314 and MPLUGIN-320.

> Version 3.4 fails to parse enums with Regex patterns
> 
>
> Key: MPLUGIN-290
> URL: https://issues.apache.org/jira/browse/MPLUGIN-290
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: Plugin Plugin
>Affects Versions: 3.4
> Environment: Windows
>Reporter: Richard Birenheide
> Attachments: Test.java
>
>
> When having the file attached as Java source file, maven-plugin-plugin fails 
> with the following error messages below.
> Version 3.4 fails to parse the file, version 3.3 works fine.
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-plugin-plugin:3.4:descriptor 
> (default-descriptor) on proje
> ct extensionPointDocu-maven-plugin: Execution default-descriptor of goal 
> org.apache.maven.plugins:maven-plugin-plugin:3.
> 4:descriptor failed: syntax error @[7,22] in 
> file:/D:/D035816/repos/git-repos/fiori_extension_point_documenter/extension
> PointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java -> 
> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-plugin-plu
> gin:3.4:descriptor (default-descriptor) on project 
> extensionPointDocu-maven-plugin: Execution default-descriptor of goal
>  org.apache.maven.plugins:maven-plugin-plugin:3.4:descriptor failed: syntax 
> error @[7,22] in file:/D:/D035816/repos/git-
> repos/fiori_extension_point_documenter/extensionPointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-descriptor of goal org.apache.maven.plugi
> ns:maven-plugin-plugin:3.4:descriptor failed: syntax error @[7,22] in 
> file:/D:/D035816/repos/git-repos/fiori_extension_p
> oint_documenter/extensionPointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: com.thoughtworks.qdox.parser.ParseException: syntax error @[7,22] 
> in file:/D:/D035816/repos/git-repos/fiori_e
> xtension_point_documenter/extensionPointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java
> at com.thoughtworks.qdox.parser.impl.Parser.yyerror(Parser.java:1683)
> at com.thoughtworks.qdox.parser.impl.Parser.yyparse(Parser.java:1805)
> at com.thoughtworks.qdox.parser.impl.Parser.parse(Parser.java:1664)
> at 
> com.thoughtworks.qdox.library.SourceLibrary.parse(SourceLibrary.java:210)
> at 
> com.thoughtworks.qdox.library.

[jira] [Closed] (MPLUGIN-290) Version 3.4 fails to parse enums with Regex patterns

2017-01-15 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/MPLUGIN-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Boué closed MPLUGIN-290.
--
   Resolution: Fixed
 Assignee: Guillaume Boué
Fix Version/s: 3.5.1

> Version 3.4 fails to parse enums with Regex patterns
> 
>
> Key: MPLUGIN-290
> URL: https://issues.apache.org/jira/browse/MPLUGIN-290
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: Plugin Plugin
>Affects Versions: 3.4
> Environment: Windows
>Reporter: Richard Birenheide
>Assignee: Guillaume Boué
> Fix For: 3.5.1
>
> Attachments: Test.java
>
>
> When having the file attached as Java source file, maven-plugin-plugin fails 
> with the following error messages below.
> Version 3.4 fails to parse the file, version 3.3 works fine.
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-plugin-plugin:3.4:descriptor 
> (default-descriptor) on proje
> ct extensionPointDocu-maven-plugin: Execution default-descriptor of goal 
> org.apache.maven.plugins:maven-plugin-plugin:3.
> 4:descriptor failed: syntax error @[7,22] in 
> file:/D:/D035816/repos/git-repos/fiori_extension_point_documenter/extension
> PointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java -> 
> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-plugin-plu
> gin:3.4:descriptor (default-descriptor) on project 
> extensionPointDocu-maven-plugin: Execution default-descriptor of goal
>  org.apache.maven.plugins:maven-plugin-plugin:3.4:descriptor failed: syntax 
> error @[7,22] in file:/D:/D035816/repos/git-
> repos/fiori_extension_point_documenter/extensionPointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-descriptor of goal org.apache.maven.plugi
> ns:maven-plugin-plugin:3.4:descriptor failed: syntax error @[7,22] in 
> file:/D:/D035816/repos/git-repos/fiori_extension_p
> oint_documenter/extensionPointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: com.thoughtworks.qdox.parser.ParseException: syntax error @[7,22] 
> in file:/D:/D035816/repos/git-repos/fiori_e
> xtension_point_documenter/extensionPointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java
> at com.thoughtworks.qdox.parser.impl.Parser.yyerror(Parser.java:1683)
> at com.thoughtworks.qdox.parser.impl.Parser.yyparse(Parser.java:1805)
> at com.thoughtworks.qdox.parser.impl.Parser.parse(Parser.java:1664)
> at 
> com.thoughtworks.qdox.library.SourceLibrary.parse(SourceLibrary.java:210)
> at 
> com.thoughtworks.qdox.library.SourceL

[jira] [Closed] (MPLUGIN-321) improve documentation on maven-plugin-annotations telling that provided is sufficient

2017-01-15 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MPLUGIN-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MPLUGIN-321.
--
Resolution: Fixed
  Assignee: Robert Scholte

Done in [r1778915|http://svn.apache.org/viewvc?rev=1778915&view=rev]

> improve documentation on maven-plugin-annotations telling that provided is 
> sufficient
> -
>
> Key: MPLUGIN-321
> URL: https://issues.apache.org/jira/browse/MPLUGIN-321
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: maven-plugin-annotations
>Affects Versions: 3.5
>Reporter: Hervé Boutemy
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.5.1
>
>
> https://maven.apache.org/plugin-tools-archives/plugin-tools-3.5/maven-plugin-plugin/examples/using-annotations.html#POM_configuration
> tells
> {code:xml}  
> 
> 
>   org.apache.maven.plugin-tools
>   maven-plugin-annotations
>   3.5
>   provided
> 
>   
> {code}
> Yes, annotations are needed only to build the plugin, since they have 
> {{@Retention(value=CLASS)}} which means they stay in bytecode but are not 
> loaded at runtime.
> What is not clear is that this dependency is not really _provided_ at 
> runtime: Maven core does not inject maven-plugin-annotations at runtime (why 
> would it? Maven core works by reading 
> [META-INF/maven/plugin.xml|http://maven.apache.org/ref/3-LATEST/maven-plugin-api/]).
>  But the dependency is simply not used at runtime.
> This doc can be improved:
> {code:xml}{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MPLUGIN-321) improve documentation on maven-plugin-annotations telling that optional=true is sufficient

2017-01-15 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MPLUGIN-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MPLUGIN-321:
---
Summary: improve documentation on maven-plugin-annotations telling that 
optional=true is sufficient  (was: improve documentation on 
maven-plugin-annotations telling that provided is sufficient)

> improve documentation on maven-plugin-annotations telling that optional=true 
> is sufficient
> --
>
> Key: MPLUGIN-321
> URL: https://issues.apache.org/jira/browse/MPLUGIN-321
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: maven-plugin-annotations
>Affects Versions: 3.5
>Reporter: Hervé Boutemy
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.5.1
>
>
> https://maven.apache.org/plugin-tools-archives/plugin-tools-3.5/maven-plugin-plugin/examples/using-annotations.html#POM_configuration
> tells
> {code:xml}  
> 
> 
>   org.apache.maven.plugin-tools
>   maven-plugin-annotations
>   3.5
>   provided
> 
>   
> {code}
> Yes, annotations are needed only to build the plugin, since they have 
> {{@Retention(value=CLASS)}} which means they stay in bytecode but are not 
> loaded at runtime.
> What is not clear is that this dependency is not really _provided_ at 
> runtime: Maven core does not inject maven-plugin-annotations at runtime (why 
> would it? Maven core works by reading 
> [META-INF/maven/plugin.xml|http://maven.apache.org/ref/3-LATEST/maven-plugin-api/]).
>  But the dependency is simply not used at runtime.
> This doc can be improved:
> {code:xml}{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MPLUGIN-321) improve documentation on maven-plugin-annotations telling that optional=true is sufficient

2017-01-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MPLUGIN-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823137#comment-15823137
 ] 

Hudson commented on MPLUGIN-321:


SUCCESS: Integrated in Jenkins build maven-plugin-tools #281 (See 
[https://builds.apache.org/job/maven-plugin-tools/281/])
[MPLUGIN-321] improve documentation on maven-plugin-annotations telling that 
optional=true is sufficient (rfscholte: 
[http://svn.apache.org/viewvc/?view=rev&rev=1778915])
* (edit) maven-plugin-plugin/src/site/apt/examples/using-annotations.apt.vm


> improve documentation on maven-plugin-annotations telling that optional=true 
> is sufficient
> --
>
> Key: MPLUGIN-321
> URL: https://issues.apache.org/jira/browse/MPLUGIN-321
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: maven-plugin-annotations
>Affects Versions: 3.5
>Reporter: Hervé Boutemy
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.5.1
>
>
> https://maven.apache.org/plugin-tools-archives/plugin-tools-3.5/maven-plugin-plugin/examples/using-annotations.html#POM_configuration
> tells
> {code:xml}  
> 
> 
>   org.apache.maven.plugin-tools
>   maven-plugin-annotations
>   3.5
>   provided
> 
>   
> {code}
> Yes, annotations are needed only to build the plugin, since they have 
> {{@Retention(value=CLASS)}} which means they stay in bytecode but are not 
> loaded at runtime.
> What is not clear is that this dependency is not really _provided_ at 
> runtime: Maven core does not inject maven-plugin-annotations at runtime (why 
> would it? Maven core works by reading 
> [META-INF/maven/plugin.xml|http://maven.apache.org/ref/3-LATEST/maven-plugin-api/]).
>  But the dependency is simply not used at runtime.
> This doc can be improved:
> {code:xml}{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MPLUGIN-290) Version 3.4 fails to parse enums with Regex patterns

2017-01-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MPLUGIN-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823136#comment-15823136
 ] 

Hudson commented on MPLUGIN-290:


SUCCESS: Integrated in Jenkins build maven-plugin-tools #281 (See 
[https://builds.apache.org/job/maven-plugin-tools/281/])
[MPLUGIN-290] Version 3.4 fails to parse enums with Regex patterns

Already fixed by the upgrade of QDox to 2.0-M5 done in r1778362. Test added to 
prevent regressions. (gboue: 
[http://svn.apache.org/viewvc/?view=rev&rev=1778912])
* (edit) 
maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaMojoDescriptorExtractorTest.java
* (add) maven-plugin-tools-java/src/test/resources/MPLUGIN-290
* (add) maven-plugin-tools-java/src/test/resources/MPLUGIN-290/Test.java
* (add) 
maven-plugin-tools-java/src/test/resources/MPLUGIN-290/plugin-expected.xml


> Version 3.4 fails to parse enums with Regex patterns
> 
>
> Key: MPLUGIN-290
> URL: https://issues.apache.org/jira/browse/MPLUGIN-290
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: Plugin Plugin
>Affects Versions: 3.4
> Environment: Windows
>Reporter: Richard Birenheide
>Assignee: Guillaume Boué
> Fix For: 3.5.1
>
> Attachments: Test.java
>
>
> When having the file attached as Java source file, maven-plugin-plugin fails 
> with the following error messages below.
> Version 3.4 fails to parse the file, version 3.3 works fine.
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-plugin-plugin:3.4:descriptor 
> (default-descriptor) on proje
> ct extensionPointDocu-maven-plugin: Execution default-descriptor of goal 
> org.apache.maven.plugins:maven-plugin-plugin:3.
> 4:descriptor failed: syntax error @[7,22] in 
> file:/D:/D035816/repos/git-repos/fiori_extension_point_documenter/extension
> PointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java -> 
> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-plugin-plu
> gin:3.4:descriptor (default-descriptor) on project 
> extensionPointDocu-maven-plugin: Execution default-descriptor of goal
>  org.apache.maven.plugins:maven-plugin-plugin:3.4:descriptor failed: syntax 
> error @[7,22] in file:/D:/D035816/repos/git-
> repos/fiori_extension_point_documenter/extensionPointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-descriptor of goal org.apache.maven.plugi
> ns:maven-plugin-plugin:3.4:descriptor failed: syntax error @[7,22] in 
> file:/D:/D035816/repos/git-repos/fiori_extension_p
> oint_documenter/extensionPointDocu-maven-plugin/src/main/java/com/sap/suite/arch/test/Test.java
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
> at 
> org.apache.maven.lifecycle.internal.MojoExecuto

[jira] [Commented] (MCHECKSTYLE-333) Intermittent NPE on checkstyle:check

2017-01-15 Thread Robert Scholte (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823155#comment-15823155
 ] 

Robert Scholte commented on MCHECKSTYLE-333:


Could it be there's a non-jar on the classpath? e.g of type 'pom'?

> Intermittent NPE on checkstyle:check
> 
>
> Key: MCHECKSTYLE-333
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-333
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: OSX El Captain, java 8, maven 3.x, checkstyle 6.19
>Reporter: James Short
>
> I generally run checkstyle:check manually but I wanted to integrate it into 
> the validate phase of my root build.
> After doing this, it will intermittent fail with an NPE:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on 
> project dropwizard-api: Execution checkstyle of goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed. 
> NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) 
> on project dropwizard-api: Execution checkstyle of goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed.
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> checkstyle of goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed.
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   ... 20 more
> Caused by: java.lang.NullPointerException
>   at java.util.zip.ZipFile.getZipEntry(ZipFile.java:566)
>   at java.util.zip.ZipFile.access$900(ZipFile.java:60)
>   at java.util.zip.ZipFile$ZipEntryIterator.next(ZipFile.java:524)
>   at java.util.zip.ZipFile$ZipEntryIterator.nextElement(ZipFile.java:499)
>   at java.util.zip.ZipFile$ZipEntryIterator.nextElement(ZipFile.java:480)
>   at java.util.jar.JarFile$JarEntryIterator.next(JarFile.java:257)
>   at java.util.jar.JarFile$JarEntryIterator.nextElement(JarFile.java:266)
>   at java.util.jar.JarFile$JarEntryIterator.nextElement(JarFile.java:247)
>   at 
> org.codehaus.plexus.resource.loader.JarHolder.getEntries(JarHolder.java:132)
>   at 
> org.codehaus.plexus.resource.loader.JarResourceLoader.loadJar(JarResourceLoader.java:100)
>   at 
> org.codehaus.plexus.resource.loader.JarResourceLoader.initialize(JarResourceLoader.java:63)
>   at 
> org.codehaus.plexus.resource.loader.JarResourceLoader.getResource(JarResourceLoader.java:141)
>   at 
> org.apache.maven.plugin.checkstyle.resource.LicenseResourceManager.getResource(LicenseResourceManager.java:75)
>   at 
> org.codehaus.plexus.resource.DefaultResourceManager.getRe

[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-15 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823183#comment-15823183
 ] 

Guillaume Boué commented on MASSEMBLY-842:
--

The root cause of this issue seems to be in Commons Compress, I created 
COMPRESS-379.

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space

2017-01-15 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte reopened MINVOKER-209:
-

Reopening, IT 'special-characters-should-work' is still failing on my system. 
Traced it back to r1763932 where the test was adjusted with extra spaces.

{noformat}
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 
2015-11-10T17:41:47+01:00)
Maven home: d:\apache-maven-3.3.9\bin\..
Java version: 1.7.0_55, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_55\jre
Default locale: nl_NL, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"
{noformat}


>  ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
>  Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: test-fail, window
> Fix For: 3.0.0
>
> Attachments: 
> MINVOKER-209-maven-invoker-plugin-IT-double-exec-special-characters-should-work.patch,
>  MINVOKER-209-workaround-maven-invoker-plugin.patch
>
>
> When working copy contains some space (common situation on W10 with users 
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work 
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result : 
> {code}
> Running pre-build script: C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale 
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline, 
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D 
> "maven.repo.local=C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s 
> "C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
>  -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script: 
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: 
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058; 
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of :  _DefaultInvoker.executeCommandLine(Commandline, 
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}
> cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D 
> maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s 
> C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D 
> maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> I'm not sure of the root cause (invoker initialization or _plexus-utils_ 
> problem :()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-15 Thread Andreas Aronsson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823198#comment-15823198
 ] 

Andreas Aronsson commented on MASSEMBLY-842:


Maybe we need a separate issue for maven-assembly-plugin-3.x.x to handle the 
invalid zip files like 2.6? 

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-15 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823209#comment-15823209
 ] 

Guillaume Boué commented on MASSEMBLY-842:
--

This can't be solved at the Assembly Plugin level. You can still force the use 
of {{plexus-archiver}} 3.0.1 inside the Assembly plugin dependencies and see if 
it works for you, but it can create other issues. There could potentially be a 
work-around inside {{plexus-archiver}} (don't rely on the output of 
{{isUnixSymlink}} in case of broken entries [in this 
code|https://github.com/codehaus-plexus/plexus-archiver/blob/plexus-archiver-3.4/src/main/java/org/codehaus/plexus/archiver/zip/PlexusIoZipFileResourceCollection.java#L183]),
 but let's see what the Compress issue brings first.

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-15 Thread Andreas Aronsson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823211#comment-15823211
 ] 

Andreas Aronsson commented on MASSEMBLY-842:


I see. Interesting and unfortunate. 
If I understood this correctly, this means that maven-assembly-plugin-3.x is 
unable to create a zip file from jar files created by maven-assembly-plugin-2.4 
that will unzip without errors. This will remain to be the case for many years 
to come. That will also mean that anyone with the same use case must stay at 
maven-assembly-plugin-2.6 for as long. Perhaps a good idea to add this 
gotcha/limitation/whatever to the documentation? 

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-15 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823299#comment-15823299
 ] 

Guillaume Boué commented on MASSEMBLY-842:
--

This is fixed in Commons Compress. Pending their release of 1.14, you can force 
a dependency on {{org.apache.commons:commons-compress:1.14-SNAPSHOT}} in the 
Assembly plugin's dependencies to have the correct behaviour here (the snapshot 
repository to use is 
{{https://repository.apache.org/content/repositories/snapshots}}).

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MNG-5958) java.lang.String cannot be cast to org.apache.maven.lifecycle.mapping.LifecyclePhase

2017-01-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823303#comment-15823303
 ] 

ASF GitHub Bot commented on MNG-5958:
-

GitHub user atanasenko opened a pull request:

https://github.com/apache/maven-integration-testing/pull/18

[MNG-5958] restore binary compatibility of Lifecycle.setPhases

Modify tests for MNG-5805

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/atanasenko/maven-integration-testing MNG-5958

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-integration-testing/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18


commit 2bed491dee89050473a99e06e3e4e5794f492c7f
Author: Anton Tanasenko 
Date:   2017-01-15T23:01:28Z

[MNG-5958] restore binary compatibility of Lifecycle.setPhases

Modify tests for MNG-5805




> java.lang.String cannot be cast to 
> org.apache.maven.lifecycle.mapping.LifecyclePhase
> 
>
> Key: MNG-5958
> URL: https://issues.apache.org/jira/browse/MNG-5958
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.3.9
> Environment: win 8.1
>Reporter: Meytal Genah
>Assignee: Christian Schulte
>Priority: Minor
> Fix For: 3.5.0
>
>
> Our app uses flex mojo.
> We upgraded from Maven 3.3.3 to Maven 3.3.9 and when building we get:
> {noformat}[ERROR] Internal error: java.lang.ClassCastException: 
> java.lang.String cannot be cast to 
> org.apache.maven.lifecycle.mapping.LifecyclePhase -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.maven.lifecycle.mapping.LifecyclePhas
> e
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:121)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.maven.lifecycle.mapping.LifecyclePhase
> at 
> org.apache.maven.lifecycle.internal.DefaultLifecyclePluginAnalyzer.getPluginsBoundByDefaultToAllLifecycles(DefaultLifecyclePluginAnalyzer.java:119)
> at 
> org.apache.maven.model.plugin.DefaultLifecycleBindingsInjector.injectLifecycleBindings(DefaultLifecycleBindingsInjector.java:64)
> at 
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:451)
> at 
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:421)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:620)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:411)
> at 
> org.apache.maven.graph.DefaultGraphBuilder.collectProjects(DefaultGraphBuilder.java:419)
> at 
> org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor(DefaultGraphBuilder.java:410)
> at 
> org.apache.maven.graph.DefaultGraphBuilder.build(DefaultGraphBuilder.java:83)
> at org.apache.maven.DefaultMaven.buildGraph(DefaultMaven.java:491)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:219)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(Defaul

[jira] [Commented] (MCHECKSTYLE-333) Intermittent NPE on checkstyle:check

2017-01-15 Thread James Short (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823349#comment-15823349
 ] 

James Short commented on MCHECKSTYLE-333:
-

So I noticed that when I closed Intellij, which was pointing to these source 
folders, that this behavior no longer occurred (60 mvn clean installs 
approximately).  Could having a running process which is reading from these 
folders cause the ZipFile NPE?

> Intermittent NPE on checkstyle:check
> 
>
> Key: MCHECKSTYLE-333
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-333
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: OSX El Captain, java 8, maven 3.x, checkstyle 6.19
>Reporter: James Short
>
> I generally run checkstyle:check manually but I wanted to integrate it into 
> the validate phase of my root build.
> After doing this, it will intermittent fail with an NPE:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on 
> project dropwizard-api: Execution checkstyle of goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed. 
> NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) 
> on project dropwizard-api: Execution checkstyle of goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed.
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> checkstyle of goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed.
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   ... 20 more
> Caused by: java.lang.NullPointerException
>   at java.util.zip.ZipFile.getZipEntry(ZipFile.java:566)
>   at java.util.zip.ZipFile.access$900(ZipFile.java:60)
>   at java.util.zip.ZipFile$ZipEntryIterator.next(ZipFile.java:524)
>   at java.util.zip.ZipFile$ZipEntryIterator.nextElement(ZipFile.java:499)
>   at java.util.zip.ZipFile$ZipEntryIterator.nextElement(ZipFile.java:480)
>   at java.util.jar.JarFile$JarEntryIterator.next(JarFile.java:257)
>   at java.util.jar.JarFile$JarEntryIterator.nextElement(JarFile.java:266)
>   at java.util.jar.JarFile$JarEntryIterator.nextElement(JarFile.java:247)
>   at 
> org.codehaus.plexus.resource.loader.JarHolder.getEntries(JarHolder.java:132)
>   at 
> org.codehaus.plexus.resource.loader.JarResourceLoader.loadJar(JarResourceLoader.java:100)
>   at 
> org.codehaus.plexus.resource.loader.JarResourceLoader.initialize(JarResourceLoader.java:63)
>   at 
> org.codehaus.plexus.resource.loader.JarResourceLoader.getResource(JarResourceLoader.java:141)
>   at 

[jira] [Updated] (MNG-6110) Upgrade Aether to Maven Resolver

2017-01-15 Thread Christian Schulte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MNG-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schulte updated MNG-6110:
---
Assignee: Hervé Boutemy  (was: Christian Schulte)

> Upgrade Aether to Maven Resolver
> 
>
> Key: MNG-6110
> URL: https://issues.apache.org/jira/browse/MNG-6110
> Project: Maven
>  Issue Type: Dependency upgrade
>  Components: Dependencies
>Affects Versions: 3.3.9
>Reporter: Harald Wellmann
>Assignee: Hervé Boutemy
> Fix For: 3.5.0
>
>
> Replace Aether by Maven Resolver to make use of the latest bugfixes and 
> enhancements related to dependency collection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MNG-5670) ConcurrentModificationException during DefaultMaven.newRepositorySession

2017-01-15 Thread Christian Schulte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MNG-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schulte updated MNG-5670:
---
Assignee: Guillaume Boué  (was: igorfie)

> ConcurrentModificationException during DefaultMaven.newRepositorySession
> 
>
> Key: MNG-5670
> URL: https://issues.apache.org/jira/browse/MNG-5670
> Project: Maven
>  Issue Type: Bug
>  Components: Embedding
>Reporter: Igor Fedorenko
>Assignee: Guillaume Boué
> Fix For: 3.2.3, 3.5.0-candidate
>
>
> DefaultMaven.newRepositorySession will fail with 
> ConcurrentModificationException if System.properties is modified concurrently 
> by another thread. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=439227 
> for original bug report against m2e.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MNG-5823) mvnDebug doesn't work with M2_HOME with spaces - missing quotes

2017-01-15 Thread Christian Schulte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MNG-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schulte updated MNG-5823:
---
Assignee: Michael Osipov  (was: Christian Schulte)

> mvnDebug doesn't work with M2_HOME with spaces - missing quotes
> ---
>
> Key: MNG-5823
> URL: https://issues.apache.org/jira/browse/MNG-5823
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.3.1
> Environment: Windows, Cygwin
>Reporter: Tobias Oberlies
>Assignee: Michael Osipov
> Fix For: 3.5.0-candidate
>
>
> When calling {{mvnDebug}} in a Cygwin shell, I get the following error
> {noformat}
> Preparing to Execute Maven in Debug Mode
> dirname: extra operand `Files/Maven/apache-maven-3.3.1/bin/mvnDebug'
> Try `dirname --help' for more information.
> env: /mvn: No such file or directory
> {noformat}
> The root cause are missing quotes in and around the dirname call. The script 
> currently calls
> {noformat}
> env MAVEN_OPTS="$MAVEN_OPTS $MAVEN_DEBUG_OPTS" $(dirname $0)/mvn "$@"
> {noformat}
> but the call should be 
> {noformat}
> env MAVEN_OPTS="$MAVEN_OPTS $MAVEN_DEBUG_OPTS" "$(dirname "$0")/mvn" "$@"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MNG-5837) Syntax error in bin/mvn on Solaris SPARC

2017-01-15 Thread Christian Schulte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MNG-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schulte updated MNG-5837:
---
Assignee: Michael Osipov  (was: Christian Schulte)

> Syntax error in bin/mvn on Solaris SPARC
> 
>
> Key: MNG-5837
> URL: https://issues.apache.org/jira/browse/MNG-5837
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.3.1
> Environment: Solaris 10
>Reporter: Erlend Birkedal
>Assignee: Michael Osipov
> Fix For: 3.5.0-candidate
>
>
> When running {{mvn}} on Solaris 10 we get the following error:
> {code:none}/opt/apache-maven-3.3.1/bin/mvn: syntax error at line 200: `(' 
> unexpected{code}
> Looks like similas issues as in MNG-5658



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MNG-6056) Implement Feature Toggle Module to handle Feature Toggles

2017-01-15 Thread Christian Schulte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MNG-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schulte updated MNG-6056:
---
Fix Version/s: (was: 3.5.0)

> Implement Feature Toggle Module to handle Feature Toggles
> -
>
> Key: MNG-6056
> URL: https://issues.apache.org/jira/browse/MNG-6056
> Project: Maven
>  Issue Type: Task
>Affects Versions: needing-scrub-3.4.0-fallout
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Attachments: knob.jpg
>
>
> Implement a feature toggle module to handle feature toggles in Maven. The 
> best from my point of view at the moment is having a relationship to the JIRA 
> which defines all kinds of bugs, issues and of course features.
> Create a separate module: {{maven-feature}} to have no other dependency which 
> means it can be integrated into any other module of maven.
> Add appropriate command line option like {{--activate-features}} to activate 
> one or more features in one go. This prevents us from changing the command 
> line every time we add or remove a feature toggle.
> So a command line option could look like this:
> {code}
> mvn --activate-features MNG2345,MNG1299 clean package
> {code}
> This will activate the features {{MNG2345}} and {{MNG1299}}. If you try to 
> activate a feature toggle which does not exist we should simply print out a 
> warning and just continue. This will simplify also future changes which means 
> if 3.4.0 introduces a feature toggle {{MNG-}} but in Maven 3.5.0 this 
> feature toggle does not exists anymore or made default calling the command 
> line that way will only produce a warning nothing more.
> It should be compile time save which means if the feature toggle will be 
> removed the compiler should show where this features has been used or 
> questioned if it is activated. This will simplify the removal of the 
> dependent code.
> Simplify adding of new feature toggles.
> Currently the best seemed to be an enumeration which contains this 
> information.
> It should also be possible to list all available feature toggles via command 
> line option like {{--list-features}} which should print out the existing 
> feature toggles plus an appropriate description for the user (in particular 
> intended for maven devs).
> It should also be simple to query for a feature toggle like:
> {code:java}
>   @Requirement
>   private SelectedFeatures featureToggle;
>   ...
>   if (featureToggle.isFeatureActive(Feature.MNG1)) {
> // The feature is implemented here or a different selection is done.
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MNG-5962) mvn fails when the current directory has spaces in between

2017-01-15 Thread Christian Schulte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MNG-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schulte updated MNG-5962:
---
Assignee: Michael Osipov

> mvn fails when the current directory has spaces in between
> --
>
> Key: MNG-5962
> URL: https://issues.apache.org/jira/browse/MNG-5962
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.3.3, 3.3.9
> Environment:  Windows 7 
>Reporter: Miriam Lee
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: easyfix, newbie
> Fix For: 3.5.0
>
> Attachments: MNG-5962-apache-maven.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Executing {{mvn.cmd}} when the current directory has spaces in between 
> outputs {{The system cannot find the path specified.}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-15 Thread Andreas Aronsson (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Aronsson updated MASSEMBLY-842:
---
Attachment: incorrectentries-compress114snapshot.zip

Attaching updated project as per instructions. 

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, 
> incorrectentries-compress114snapshot.zip, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-15 Thread Andreas Aronsson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823570#comment-15823570
 ] 

Andreas Aronsson edited comment on MASSEMBLY-842 at 1/16/17 7:34 AM:
-

The snapshot does seem to fix the issue. :-)
But I am getting some inconsistent behavior: 
{noformat}
[INFO] Building tar: 
/home/andreasa/tmp/incorrectentries/target/incorrectentries-1-SNAPSHOT.tar
[WARNING] When creating tar entry
java.lang.NullPointerException
at 
org.codehaus.plexus.components.io.resources.PlexusIoURLResource.getContents(PlexusIoURLResource.java:41)
at 
org.codehaus.plexus.components.io.resources.Deferred.getContents(Deferred.java:60)
at 
org.codehaus.plexus.components.io.resources.proxy.ResourceInvocationHandler.invoke(ResourceInvocationHandler.java:62)
at com.sun.proxy.$Proxy23.getContents(Unknown Source)
at 
org.codehaus.plexus.archiver.ArchiveEntry.getInputStream(ArchiveEntry.java:137)
at 
org.codehaus.plexus.archiver.tar.TarArchiver.tarFile(TarArchiver.java:329)
at 
org.codehaus.plexus.archiver.tar.TarArchiver.execute(TarArchiver.java:168)
at 
org.codehaus.plexus.archiver.AbstractArchiver.createArchive(AbstractArchiver.java:993)
at 
org.apache.maven.plugins.assembly.archive.archiver.AssemblyProxyArchiver.createArchive(AssemblyProxyArchiver.java:445)
at 
org.apache.maven.plugins.assembly.archive.DefaultAssemblyArchiver.createArchive(DefaultAssemblyArchiver.java:184)
at 
org.apache.maven.plugins.assembly.mojos.AbstractAssemblyMojo.execute(AbstractAssemblyMojo.java:476)
at 
org.apache.maven.plugins.assembly.mojos.SingleAssemblyMojo.execute(SingleAssemblyMojo.java:58)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
{noformat}
This does not happen on every run. 
Another one even weirder
{noformat}
[INFO] Building tar: 
/home/andreasa/tmp/incorrectentries/target/incorrectentries-1-SNAPSHOT.tar
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x7efc15de3a24, pid=23890, tid=0x7efc16b65700
#
# JRE version: OpenJDK Runtime Environment (8.0_111-b16) (build 1.8.0_111-b16)
# Java VM: OpenJDK 64-Bit Server VM (25.111-b16 mixed mode linux-amd64 
compressed oops)
# Problematic frame:
# C  [libc.so.6+0x90a24]  __memcpy_sse2_unaligned_erms+0x44
#
# Failed to write core dump. Core dumps have been disabled. To enable core 
dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/andreasa/tmp/incorrectentries/hs_err_pid23890.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
/usr/bin/mvn: line 20: 23890 Aborted (core dumped) 
$M2_HOME/bin/mvn "$@"
{noformat}
When I remove the tar packaging it is all w

[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-15 Thread Andreas Aronsson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823570#comment-15823570
 ] 

Andreas Aronsson commented on MASSEMBLY-842:


The snapshot does seem to fix the issue. :-)
But I am getting some inconsistent behavior: 
{noformat}
[INFO] Building tar: 
/home/andreasa/tmp/incorrectentries/target/incorrectentries-1-SNAPSHOT.tar
[WARNING] When creating tar entry
java.lang.NullPointerException
at 
org.codehaus.plexus.components.io.resources.PlexusIoURLResource.getContents(PlexusIoURLResource.java:41)
at 
org.codehaus.plexus.components.io.resources.Deferred.getContents(Deferred.java:60)
at 
org.codehaus.plexus.components.io.resources.proxy.ResourceInvocationHandler.invoke(ResourceInvocationHandler.java:62)
at com.sun.proxy.$Proxy23.getContents(Unknown Source)
at 
org.codehaus.plexus.archiver.ArchiveEntry.getInputStream(ArchiveEntry.java:137)
at 
org.codehaus.plexus.archiver.tar.TarArchiver.tarFile(TarArchiver.java:329)
at 
org.codehaus.plexus.archiver.tar.TarArchiver.execute(TarArchiver.java:168)
at 
org.codehaus.plexus.archiver.AbstractArchiver.createArchive(AbstractArchiver.java:993)
at 
org.apache.maven.plugins.assembly.archive.archiver.AssemblyProxyArchiver.createArchive(AssemblyProxyArchiver.java:445)
at 
org.apache.maven.plugins.assembly.archive.DefaultAssemblyArchiver.createArchive(DefaultAssemblyArchiver.java:184)
at 
org.apache.maven.plugins.assembly.mojos.AbstractAssemblyMojo.execute(AbstractAssemblyMojo.java:476)
at 
org.apache.maven.plugins.assembly.mojos.SingleAssemblyMojo.execute(SingleAssemblyMojo.java:58)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
{noformar}
This does not happen on every run. 
Another one even weirder
{noformat}
[INFO] Building tar: 
/home/andreasa/tmp/incorrectentries/target/incorrectentries-1-SNAPSHOT.tar
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x7efc15de3a24, pid=23890, tid=0x7efc16b65700
#
# JRE version: OpenJDK Runtime Environment (8.0_111-b16) (build 1.8.0_111-b16)
# Java VM: OpenJDK 64-Bit Server VM (25.111-b16 mixed mode linux-amd64 
compressed oops)
# Problematic frame:
# C  [libc.so.6+0x90a24]  __memcpy_sse2_unaligned_erms+0x44
#
# Failed to write core dump. Core dumps have been disabled. To enable core 
dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/andreasa/tmp/incorrectentries/hs_err_pid23890.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
/usr/bin/mvn: line 20: 23890 Aborted (core dumped) 
$M2_HOME/bin/mvn "$@"
{noformat}
When I remove the tar packaging it is all working well. 
Perhaps a separate issue for the ta