[jira] [Updated] (DOXIASITETOOLS-173) Default skin CSS maven-base.css sets border:none on all images with tag img

2017-01-10 Thread Michael Benz (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Benz updated DOXIASITETOOLS-173:

Priority: Minor  (was: Major)

> Default skin CSS maven-base.css sets border:none on all images with tag img
> ---
>
> Key: DOXIASITETOOLS-173
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-173
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
>  Labels: css
>
> The CSS in maven-base.css does not allow for any border around any image. A 
> workaround would need to create a new skin for images with borders or remove 
> the border:none from the img tag.
> {quote}
> Michael Osipov:
> This style is pretty useless because we kill our own decoration model setting 
> with that. It should be up to the user to decide about a border style.
> {quote}
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}
> Bug / Issues created from findings in DOXIASITETOOLS-172



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (DOXIASITETOOLS-173) Default skin CSS maven-base.css sets border:none on all images with tag img

2017-01-10 Thread Michael Benz (JIRA)
Michael Benz created DOXIASITETOOLS-173:
---

 Summary: Default skin CSS maven-base.css sets border:none on all 
images with tag img
 Key: DOXIASITETOOLS-173
 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-173
 Project: Maven Doxia Sitetools
  Issue Type: Bug
  Components: Site renderer
Affects Versions: 1.7.4
Reporter: Michael Benz


The CSS in maven-base.css does not allow for any border around any image. A 
workaround would need to create a new skin for images with borders or remove 
the border:none from the img tag.

{quote}
Michael Osipov:
This style is pretty useless because we kill our own decoration model setting 
with that. It should be up to the user to decide about a border style.
{quote}

{code}
/* from maven-base.css */
img {
  border:none;
}
/* (...) */
#banner img {
  border: none;
}
{code}

Bug / Issues created from findings in DOXIASITETOOLS-172



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

2017-01-10 Thread Michael Benz (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814484#comment-15814484
 ] 

Michael Benz commented on DOXIASITETOOLS-172:
-

border="0" can be removed. I was overzealous in making sure no borders are 
displayed around the banner. That should be the users's choice.
If I use the same alt definition as in the fluido skin, unit test 
DefaultSiteRenderer fails:
{quote}
Message: Attribute "alt" is required and must be specified for element type 
"img".
{quote}
Therefore I need to leave the empty {code}alt=""{code} tag in case neither name 
nor alt are defined for the banner image.

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

2017-01-10 Thread Michael Benz (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814486#comment-15814486
 ] 

Michael Benz commented on DOXIASITETOOLS-172:
-

Created DOXIASITETOOLS-173 for that and will provide a patch as well.

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIASITETOOLS-173) Default skin CSS maven-base.css sets border:none on all images with tag img

2017-01-10 Thread Michael Benz (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Benz updated DOXIASITETOOLS-173:

Attachment: maven-base-image-borders.patch

Remove border:none from img and img #banner elements. This allows the user to 
specify e.g. banner borders.

> Default skin CSS maven-base.css sets border:none on all images with tag img
> ---
>
> Key: DOXIASITETOOLS-173
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-173
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
>  Labels: css
> Attachments: maven-base-image-borders.patch
>
>
> The CSS in maven-base.css does not allow for any border around any image. A 
> workaround would need to create a new skin for images with borders or remove 
> the border:none from the img tag.
> {quote}
> Michael Osipov:
> This style is pretty useless because we kill our own decoration model setting 
> with that. It should be up to the user to decide about a border style.
> {quote}
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}
> Bug / Issues created from findings in DOXIASITETOOLS-172



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

2017-01-10 Thread Michael Benz (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Benz updated DOXIASITETOOLS-172:

Attachment: (was: enable-width-height-border-doxia-sitetools.patch)

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

2017-01-10 Thread Michael Benz (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Benz updated DOXIASITETOOLS-172:

Attachment: enable-width-height-border-doxia-sitetools-alt.patch

Fixed patch setting border="" and alt="" like fluido skin.
Enabling width, height and border settings on banner in default skin.

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools-alt.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

2017-01-10 Thread Michael Benz (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Benz updated DOXIASITETOOLS-172:

Description: 
Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
Skin ignores the width and height and border settings in the site descriptor.

The changes in site.xml were introduced here:
DOXIASITETOOLS-58

{code}

Name
Logo.svg
30
10
Logo Title
2

{code}

Created HTML:
{code}

{code}

Created new issue DOXIASITETOOLS-173 for the CSS issue described below:
The CSS in maven-base.css would anyways not allow for a border around any image 
- one would need to create a new skin for borders or remove the border:none 
from the img tag.
{code}
/* from maven-base.css */
img {
  border:none;
}
/* (...) */
#banner img {
  border: none;
}
{code}


  was:
Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
Skin ignores the width and height and border settings in the site descriptor.

The changes in site.xml were introduced here:
DOXIASITETOOLS-58

{code}

Name
Logo.svg
30
10
Logo Title
2

{code}

Created HTML:
{code}

{code}

The CSS in maven-base.css would anyways not allow for a border around any image 
- one would need to create a new skin for borders or remove the border:none 
from the img tag.
{code}
/* from maven-base.css */
img {
  border:none;
}
/* (...) */
#banner img {
  border: none;
}
{code}



> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools-alt.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> Created new issue DOXIASITETOOLS-173 for the CSS issue described below:
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

2017-01-10 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned DOXIASITETOOLS-172:
-

Assignee: Michael Osipov

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools-alt.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> Created new issue DOXIASITETOOLS-173 for the CSS issue described below:
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (DOXIASITETOOLS-173) Default skin CSS maven-base.css sets border:none on all images with tag img

2017-01-10 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned DOXIASITETOOLS-173:
-

Assignee: Michael Osipov

> Default skin CSS maven-base.css sets border:none on all images with tag img
> ---
>
> Key: DOXIASITETOOLS-173
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-173
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: css
> Attachments: maven-base-image-borders.patch
>
>
> The CSS in maven-base.css does not allow for any border around any image. A 
> workaround would need to create a new skin for images with borders or remove 
> the border:none from the img tag.
> {quote}
> Michael Osipov:
> This style is pretty useless because we kill our own decoration model setting 
> with that. It should be up to the user to decide about a border style.
> {quote}
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}
> Bug / Issues created from findings in DOXIASITETOOLS-172



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIASITETOOLS-173) Default skin CSS maven-base.css sets border:none on all images with tag img

2017-01-10 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated DOXIASITETOOLS-173:
--
Fix Version/s: 1.7.5

> Default skin CSS maven-base.css sets border:none on all images with tag img
> ---
>
> Key: DOXIASITETOOLS-173
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-173
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: css
> Fix For: 1.7.5
>
> Attachments: maven-base-image-borders.patch
>
>
> The CSS in maven-base.css does not allow for any border around any image. A 
> workaround would need to create a new skin for images with borders or remove 
> the border:none from the img tag.
> {quote}
> Michael Osipov:
> This style is pretty useless because we kill our own decoration model setting 
> with that. It should be up to the user to decide about a border style.
> {quote}
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}
> Bug / Issues created from findings in DOXIASITETOOLS-172



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (DOXIASITETOOLS-173) Default skin CSS maven-base.css sets border:none on all images with tag img

2017-01-10 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed DOXIASITETOOLS-173.
-
Resolution: Fixed

Fixed with [r1778110|http://svn.apache.org/r1778110].

> Default skin CSS maven-base.css sets border:none on all images with tag img
> ---
>
> Key: DOXIASITETOOLS-173
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-173
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: css
> Fix For: 1.7.5
>
> Attachments: maven-base-image-borders.patch
>
>
> The CSS in maven-base.css does not allow for any border around any image. A 
> workaround would need to create a new skin for images with borders or remove 
> the border:none from the img tag.
> {quote}
> Michael Osipov:
> This style is pretty useless because we kill our own decoration model setting 
> with that. It should be up to the user to decide about a border style.
> {quote}
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}
> Bug / Issues created from findings in DOXIASITETOOLS-172



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIASITETOOLS-173) Default skin CSS maven-base.css sets border:none on all images with tag img

2017-01-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814732#comment-15814732
 ] 

Hudson commented on DOXIASITETOOLS-173:
---

SUCCESS: Integrated in Jenkins build doxia-all #316 (See 
[https://builds.apache.org/job/doxia-all/316/])
[DOXIASITETOOLS-173] Default skin CSS maven-base.css sets border:none on all 
images with tag img

Submitted-by: Michael Benz  (michaelo: 
[http://svn.apache.org/viewvc/?view=rev&rev=1778110])
* (edit) 
./doxia-sitetools/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/css/maven-base.css


> Default skin CSS maven-base.css sets border:none on all images with tag img
> ---
>
> Key: DOXIASITETOOLS-173
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-173
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: css
> Fix For: 1.7.5
>
> Attachments: maven-base-image-borders.patch
>
>
> The CSS in maven-base.css does not allow for any border around any image. A 
> workaround would need to create a new skin for images with borders or remove 
> the border:none from the img tag.
> {quote}
> Michael Osipov:
> This style is pretty useless because we kill our own decoration model setting 
> with that. It should be up to the user to decide about a border style.
> {quote}
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}
> Bug / Issues created from findings in DOXIASITETOOLS-172



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

2017-01-10 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated DOXIASITETOOLS-172:
--
Fix Version/s: 1.7.5

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 1.7.5
>
> Attachments: enable-width-height-border-doxia-sitetools-alt.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> Created new issue DOXIASITETOOLS-173 for the CSS issue described below:
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

2017-01-10 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed DOXIASITETOOLS-172.
-
Resolution: Fixed

Fixed with [r1778133|http://svn.apache.org/r1778133].

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 1.7.5
>
> Attachments: enable-width-height-border-doxia-sitetools-alt.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> Created new issue DOXIASITETOOLS-173 for the CSS issue described below:
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MSKINS-134) Macro banner does not set image title

2017-01-10 Thread Michael Osipov (JIRA)
Michael Osipov created MSKINS-134:
-

 Summary: Macro banner does not set image title
 Key: MSKINS-134
 URL: https://issues.apache.org/jira/browse/MSKINS-134
 Project: Maven Skins
  Issue Type: Bug
  Components: Fluido Skin
Affects Versions: fluido-1.6
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: fluido-2.0


Macro banner does not set the title if one is provided. It is simply ignored 
from the model.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

2017-01-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815117#comment-15815117
 ] 

Hudson commented on DOXIASITETOOLS-172:
---

SUCCESS: Integrated in Jenkins build doxia-all #317 (See 
[https://builds.apache.org/job/doxia-all/317/])
[DOXIASITETOOLS-172] Width, height and border values not used for banner display

Submitted-by: Michael Benz  (michaelo: 
[http://svn.apache.org/viewvc/?view=rev&rev=1778133])
* (edit) 
./doxia-sitetools/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site-macros.vm


> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 1.7.5
>
> Attachments: enable-width-height-border-doxia-sitetools-alt.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> Created new issue DOXIASITETOOLS-173 for the CSS issue described below:
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MSKINS-134) Banner macro does not set image title from decoration model

2017-01-10 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSKINS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MSKINS-134.
-
Resolution: Fixed

Fixed with [r1778136|http://svn.apache.org/r1778136].

> Banner macro does not set image title from decoration model
> ---
>
> Key: MSKINS-134
> URL: https://issues.apache.org/jira/browse/MSKINS-134
> Project: Maven Skins
>  Issue Type: Bug
>  Components: Fluido Skin
>Affects Versions: fluido-1.6
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: fluido-2.0
>
>
> Macro banner does not set the title if one is provided. It is simply ignored 
> from the model.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MSKINS-134) Banner macro does not set image title from decoration model

2017-01-10 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSKINS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSKINS-134:
--
Summary: Banner macro does not set image title from decoration model  (was: 
Macro banner does not set image title)

> Banner macro does not set image title from decoration model
> ---
>
> Key: MSKINS-134
> URL: https://issues.apache.org/jira/browse/MSKINS-134
> Project: Maven Skins
>  Issue Type: Bug
>  Components: Fluido Skin
>Affects Versions: fluido-1.6
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: fluido-2.0
>
>
> Macro banner does not set the title if one is provided. It is simply ignored 
> from the model.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread Andreas Aronsson (JIRA)
Andreas Aronsson created MASSEMBLY-842:
--

 Summary: Incorrect entries created in MANIFEST/maven
 Key: MASSEMBLY-842
 URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
 Project: Maven Assembly Plugin
  Issue Type: Bug
Affects Versions: 3.0.0
 Environment: Fedora 25
Reporter: Andreas Aronsson
 Attachments: incorrectentries.zip

When executing 'mvn package' on the attached project, the produced archive(s) 
are not produced as expected. As an example, the following entries in the zip 
archive I expect to be marked as directories and end with a slash rather than 
the current state: 
{noformat}
crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j/slf4j-api
{noformat}
In the tar archive they are links which is also not expected. 

I have also tried to find any reference to this in maven-archiver and 
plexus-archiver but wasn't able to find anything. 
Using the {{unzip}} utility asks the following:
{noformat}
replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
{noformat}
during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread Andreas Aronsson (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Aronsson updated MASSEMBLY-842:
---
Attachment: incorrectentries.zip

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSKINS-134) Banner macro does not set image title from decoration model

2017-01-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSKINS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815310#comment-15815310
 ] 

Hudson commented on MSKINS-134:
---

SUCCESS: Integrated in Jenkins build maven-skins #269 (See 
[https://builds.apache.org/job/maven-skins/269/])
[MSKINS-134] Banner macro does not set image title from decoration model 
(michaelo: [http://svn.apache.org/viewvc/?view=rev&rev=1778136])
* (edit) maven-fluido-skin/src/main/resources/META-INF/maven/site-macros.vm


> Banner macro does not set image title from decoration model
> ---
>
> Key: MSKINS-134
> URL: https://issues.apache.org/jira/browse/MSKINS-134
> Project: Maven Skins
>  Issue Type: Bug
>  Components: Fluido Skin
>Affects Versions: fluido-1.6
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: fluido-2.0
>
>
> Macro banner does not set the title if one is provided. It is simply ignored 
> from the model.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816418#comment-15816418
 ] 

Guillaume Boué commented on MASSEMBLY-842:
--

I was able to reproduce the behaviour on Ubuntu 16.04, so here are more 
information. {{zipinfo incorrectentries-1-SNAPSHOT.jar}} shows

{noformat}
lrwsrwsrwt  2.0 unx0 bl defN 16-Feb-11 21:30 META-INF/maven
lrwsrwsrwt  2.0 unx0 bl defN 16-Feb-11 21:30 META-INF/maven/org.slf4j
lrwsrwsrwt  2.0 unx0 bl defN 16-Feb-11 21:30 
META-INF/maven/org.slf4j/slf4j-api
lrwsrwsrwt  2.0 unx0 bl defN 17-Jan-10 23:41 
META-INF/maven/com.example.incorrectentries
lrwsrwsrwt  2.0 unx0 bl defN 17-Jan-10 23:41 
META-INF/maven/com.example.incorrectentries/incorrectentries
{noformat}

when those should be directories. I noticed however, that the {{slf4j-api}} JAR 
also contained faulty entries; executing {{zipinfo 
~/.m2/repository/org/slf4j/slf4j-api/1.7.16/slf4j-api-1.7.16.jar}} shows

{noformat}
?rwsrwsrwt  2.0 unx0 b- stor 16-Feb-11 21:30 META-INF/maven/
?rwsrwsrwt  2.0 unx0 b- stor 16-Feb-11 21:30 META-INF/maven/org.slf4j/
?rwsrwsrwt  2.0 unx0 b- stor 16-Feb-11 21:30 
META-INF/maven/org.slf4j/slf4j-api/
{noformat}

with a leading {{?}} (not sure what that means).

When changing the {{slf4j-api}} dependency to, for example, 
{{log4j:log4j:1.2.17}}, running {{zipinfo incorrectentries-1-SNAPSHOT.jar}} 
shows the expected 

{noformat}
drwxr-xr-x  2.0 unx0 b- stor 12-May-06 13:24 META-INF/maven/
drwxr-xr-x  2.0 unx0 b- stor 12-May-06 13:24 META-INF/maven/log4j/
drwxr-xr-x  2.0 unx0 b- stor 12-May-06 13:24 META-INF/maven/log4j/log4j/
{noformat}

but there is still a 

{noformat}
lrwsrwsrwt  2.0 unx0 bl defN 17-Jan-10 23:32 
META-INF/maven/com.example.incorrectentries
lrwsrwsrwt  2.0 unx0 bl defN 17-Jan-10 23:32 
META-INF/maven/com.example.incorrectentries/incorrectentries
{noformat}

remaining.

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MPOM-158) Use some sensible defaults with Apache RAT

2017-01-10 Thread John D. Ament (JIRA)

[ 
https://issues.apache.org/jira/browse/MPOM-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816799#comment-15816799
 ] 

John D. Ament commented on MPOM-158:


Its primarily based on podling input - simplifying the default setup.  I agree, 
and using a flag like {{useDefaultExcludes}} may make more sense in the scheme 
of what every ASF project could use.  Looking at my own local, *.log is only in 
one project so I suspect its a local project issue there.

So, agree to add {{useDefaultExcludes}}?

> Use some sensible defaults with Apache RAT
> --
>
> Key: MPOM-158
> URL: https://issues.apache.org/jira/browse/MPOM-158
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Reporter: John D. Ament
> Attachments: RAT-CONFIG.patch
>
>
> The rat section in the parent pom doesn't include RAT defaults.  Would be 
> good to use some sensible defaults.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread John Chapin (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817397#comment-15817397
 ] 

John Chapin commented on MASSEMBLY-842:
---

FWIW, I experienced the same issue - it manifested as a failure to unzip jar 
files on AWS's Lambda platform.

Downgrading the maven-assembly-plugin to version 2.6 solved this issue for me. 
I didn't make any changes to the slf4j-api dependencies.

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread Andreas Aronsson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817429#comment-15817429
 ] 

Andreas Aronsson commented on MASSEMBLY-842:


Downgrading works fine for me too. 
I see the same problem with leading {{?}} in 
commons-logging-1.2 but *not* in commons-logging-1.1.1
httpclient-4.3.5.jar and all httpclient versions in my m2 cache 4.0.1  4.0.2  
4.2.3  4.3.5  4.5.1  4.5.2

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread Andreas Aronsson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817429#comment-15817429
 ] 

Andreas Aronsson edited comment on MASSEMBLY-842 at 1/11/17 6:59 AM:
-

Downgrading works fine for me too. 
I see the same problem with leading {{?}} in 
commons-logging-1.2 but *not* in commons-logging-1.1.1
httpclient-4.3.5.jar and all httpclient versions in my m2 cache 4.0.1  4.0.2  
4.2.3  4.3.5  4.5.1  4.5.2

commons-io-2.4 has the faulty entries but not commons-io-2.5. I will try to 
find out what differs. 

Regardless, it might be a good idea to handle faulty entries like in version 
2.6 since there seems to be a large amount of jar files out there that are 
affected. 


was (Author: andreas.aronsson):
Downgrading works fine for me too. 
I see the same problem with leading {{?}} in 
commons-logging-1.2 but *not* in commons-logging-1.1.1
httpclient-4.3.5.jar and all httpclient versions in my m2 cache 4.0.1  4.0.2  
4.2.3  4.3.5  4.5.1  4.5.2

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread Andreas Aronsson (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Aronsson updated MASSEMBLY-842:
---
Attachment: effio24.xml
effio25.xml

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread Andreas Aronsson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817488#comment-15817488
 ] 

Andreas Aronsson commented on MASSEMBLY-842:


Attached effective-pom for commons-io 2.4 and 2.5. It seems that they are build 
with maven-assembly-plugin 2.3 and 2.5.5 respectively. 

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread Andreas Aronsson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817488#comment-15817488
 ] 

Andreas Aronsson edited comment on MASSEMBLY-842 at 1/11/17 7:22 AM:
-

Attached effective-pom for commons-io 2.4 and 2.5. It seems that they are build 
with maven-assembly-plugin 2.3 and 2.5.5 respectively. 

Looks like https://issues.apache.org/jira/browse/MASSEMBLY-422 is the original 
cause. 


was (Author: andreas.aronsson):
Attached effective-pom for commons-io 2.4 and 2.5. It seems that they are build 
with maven-assembly-plugin 2.3 and 2.5.5 respectively. 

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MASSEMBLY-842) Incorrect entries created in MANIFEST/maven

2017-01-10 Thread Andreas Aronsson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817488#comment-15817488
 ] 

Andreas Aronsson edited comment on MASSEMBLY-842 at 1/11/17 7:29 AM:
-

Attached effective-pom for commons-io 2.4 and 2.5. It seems that they are built 
with maven-assembly-plugin 2.3 and 2.5.5 respectively. 

Looks like https://issues.apache.org/jira/browse/MASSEMBLY-422 is the original 
cause. 


was (Author: andreas.aronsson):
Attached effective-pom for commons-io 2.4 and 2.5. It seems that they are build 
with maven-assembly-plugin 2.3 and 2.5.5 respectively. 

Looks like https://issues.apache.org/jira/browse/MASSEMBLY-422 is the original 
cause. 

> Incorrect entries created in MANIFEST/maven
> ---
>
> Key: MASSEMBLY-842
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-842
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Fedora 25
>Reporter: Andreas Aronsson
> Attachments: effio24.xml, effio25.xml, incorrectentries.zip
>
>
> When executing 'mvn package' on the attached project, the produced archive(s) 
> are not produced as expected. As an example, the following entries in the zip 
> archive I expect to be marked as directories and end with a slash rather than 
> the current state: 
> {noformat}
> crwsrwsrwx 0  11-Feb-2016  21:30:54  META-INF/maven/org.slf4j
> crwsrwsrwx 0  11-Feb-2016  21:30:54  
> META-INF/maven/org.slf4j/slf4j-api
> {noformat}
> In the tar archive they are links which is also not expected. 
> I have also tried to find any reference to this in maven-archiver and 
> plexus-archiver but wasn't able to find anything. 
> Using the {{unzip}} utility asks the following:
> {noformat}
> replace META-INF/maven? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
> {noformat}
> during unzip which was also unexpected. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)