[jira] [Commented] (MWAR-257) Remove deprecation of dependentWarExcludes, since there is no alternative on global level
[
https://issues.apache.org/jira/browse/MWAR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763729#comment-15763729
]
Michal Domagala commented on MWAR-257:
--
Global level dependentWarExcludes/Includes are very useful and should be
restored.
That will be a long story...
Global exclusion of {{WEB-INB/lib/*.jar}} is simple solution to solve problem
[MWAR-33| https://issues.apache.org/jira/browse/MWAR-33] (jars with differents
versions can be in WEB-INF/lib with war as dependencies)
Unfortunately, commit https://fisheye6.atlassian.com/changelog/maven?cs=606628
for https://issues.apache.org/jira/browse/MWAR-118 marked
{{dependentWarExcludes}} deprecated. I read issue description and I don't know
why it is deprecated. I expected it was mistake or under analyzed change.
> Remove deprecation of dependentWarExcludes, since there is no alternative on
> global level
> -
>
> Key: MWAR-257
> URL: https://issues.apache.org/jira/browse/MWAR-257
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.1.1
>Reporter: dool
>
> Hello,
> DependentWarExcludes is marked as deprecated. Documentation says to use
> / instead.
> But it seems to me that it is not possible to get the same behaviour with
> / as in this case we have to provide groupIds and
> artifactIds.
> Maybe this behaviour could be reproduced when setting both groupId and
> artifactId to * as below :
>
>
>
> *
> *
> **/*
>
>
>
>
> By the way, I found this, by looking for a way to disable overlay. The
> workaround I thought was configuring your plugin to exclude every files when
> overlaying.
> I think it would be nice to have a configuration parameter for that.
> Many thanks,
> Dool
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MWAR-257) Remove deprecation of dependentWarExcludes, since there is no alternative on global level
[ https://issues.apache.org/jira/browse/MWAR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763765#comment-15763765 ] Michael Osipov commented on MWAR-257: - Unfortunately, there were several errors made with this configuration parameter: 1. The deprecation should have happened with a seperate ticket, not just side comment in a commit 2. There is no profound explanation why this should not be used and what the alternative be 3. There is a good reason to use this w/o configuration explosion > Remove deprecation of dependentWarExcludes, since there is no alternative on > global level > - > > Key: MWAR-257 > URL: https://issues.apache.org/jira/browse/MWAR-257 > Project: Maven WAR Plugin > Issue Type: Bug > Components: overlay >Affects Versions: 2.1.1 >Reporter: dool > > Hello, > DependentWarExcludes is marked as deprecated. Documentation says to use > / instead. > But it seems to me that it is not possible to get the same behaviour with > / as in this case we have to provide groupIds and > artifactIds. > Maybe this behaviour could be reproduced when setting both groupId and > artifactId to * as below : > > > > * > * > **/* > > > > > By the way, I found this, by looking for a way to disable overlay. The > workaround I thought was configuring your plugin to exclude every files when > overlaying. > I think it would be nice to have a configuration parameter for that. > Many thanks, > Dool -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MWAR-257) Remove deprecation of dependentWarExcludes, since there is no alternative on global level
[ https://issues.apache.org/jira/browse/MWAR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MWAR-257: --- Assignee: Michael Osipov > Remove deprecation of dependentWarExcludes, since there is no alternative on > global level > - > > Key: MWAR-257 > URL: https://issues.apache.org/jira/browse/MWAR-257 > Project: Maven WAR Plugin > Issue Type: Bug > Components: overlay >Affects Versions: 2.1.1 >Reporter: dool >Assignee: Michael Osipov > > Hello, > DependentWarExcludes is marked as deprecated. Documentation says to use > / instead. > But it seems to me that it is not possible to get the same behaviour with > / as in this case we have to provide groupIds and > artifactIds. > Maybe this behaviour could be reproduced when setting both groupId and > artifactId to * as below : > > > > * > * > **/* > > > > > By the way, I found this, by looking for a way to disable overlay. The > workaround I thought was configuring your plugin to exclude every files when > overlaying. > I think it would be nice to have a configuration parameter for that. > Many thanks, > Dool -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MWAR-257) Remove deprecation of dependentWarExcludes, since there is no alternative on global level
[ https://issues.apache.org/jira/browse/MWAR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MWAR-257: Fix Version/s: 3.1.0 > Remove deprecation of dependentWarExcludes, since there is no alternative on > global level > - > > Key: MWAR-257 > URL: https://issues.apache.org/jira/browse/MWAR-257 > Project: Maven WAR Plugin > Issue Type: Bug > Components: overlay >Affects Versions: 2.1.1 >Reporter: dool >Assignee: Michael Osipov > Fix For: 3.1.0 > > > Hello, > DependentWarExcludes is marked as deprecated. Documentation says to use > / instead. > But it seems to me that it is not possible to get the same behaviour with > / as in this case we have to provide groupIds and > artifactIds. > Maybe this behaviour could be reproduced when setting both groupId and > artifactId to * as below : > > > > * > * > **/* > > > > > By the way, I found this, by looking for a way to disable overlay. The > workaround I thought was configuring your plugin to exclude every files when > overlaying. > I think it would be nice to have a configuration parameter for that. > Many thanks, > Dool -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MWAR-257) Remove deprecation of dependentWarExcludes, since there is no alternative on global level
[
https://issues.apache.org/jira/browse/MWAR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763729#comment-15763729
]
Michal Domagala edited comment on MWAR-257 at 12/20/16 9:38 AM:
Global level dependentWarExcludes/Includes are very useful and should be
restored.
Global exclusion of {{WEB-INB/lib/*.jar}} is simple solution to problem
[MWAR-33| https://issues.apache.org/jira/browse/MWAR-33] (jars with differents
versions can be in WEB-INF/lib with war as dependencies)
Unfortunately, commit https://fisheye6.atlassian.com/changelog/maven?cs=606628
for https://issues.apache.org/jira/browse/MWAR-118 marked
{{dependentWarExcludes}} deprecated. I read issue description and I don't know
why it is deprecated. I think it was mistake or under analyzed change.
Finally, in maven-war-plugin version 3.0.0 {{dependentWarExcludes}} is
removed. It has dramatic impact on my application, which heavy use WAR
customization implemented by war-extending-war.
My current setup for maven-war-plugin version 2.6 is global
{{dependentWarExcludes=WEB-INF/lib/*.jar}} and multiple WAR projects (for
particular clients) depending on parent WARs. Just dependency, nothing more.
If I switch to 3.0.0, I have to remove global {{dependentWarExcludes}} and for
each WAR project, beside dependency to parent WAR add section {{overlays}},
copy dependency data and add
{{WEB-INF/lib/*.jar}}
I expect answer like:
1. It is stupid to have global configuration in root, better copy the same
settings into multiple child projects. (I will know I have to stay with 2.6)
2. It is cool to have global configuration, keep calm and wait for newer maven
war plugin
was (Author: michaldo):
Global level dependentWarExcludes/Includes are very useful and should be
restored.
That will be a long story...
Global exclusion of {{WEB-INB/lib/*.jar}} is simple solution to solve problem
[MWAR-33| https://issues.apache.org/jira/browse/MWAR-33] (jars with differents
versions can be in WEB-INF/lib with war as dependencies)
Unfortunately, commit https://fisheye6.atlassian.com/changelog/maven?cs=606628
for https://issues.apache.org/jira/browse/MWAR-118 marked
{{dependentWarExcludes}} deprecated. I read issue description and I don't know
why it is deprecated. I expected it was mistake or under analyzed change.
> Remove deprecation of dependentWarExcludes, since there is no alternative on
> global level
> -
>
> Key: MWAR-257
> URL: https://issues.apache.org/jira/browse/MWAR-257
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.1.1
>Reporter: dool
>Assignee: Michael Osipov
> Fix For: 3.1.0
>
>
> Hello,
> DependentWarExcludes is marked as deprecated. Documentation says to use
> / instead.
> But it seems to me that it is not possible to get the same behaviour with
> / as in this case we have to provide groupIds and
> artifactIds.
> Maybe this behaviour could be reproduced when setting both groupId and
> artifactId to * as below :
>
>
>
> *
> *
> **/*
>
>
>
>
> By the way, I found this, by looking for a way to disable overlay. The
> workaround I thought was configuring your plugin to exclude every files when
> overlaying.
> I think it would be nice to have a configuration parameter for that.
> Many thanks,
> Dool
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MWAR-257) Remove deprecation of dependentWarExcludes, since there is no alternative on global level
[ https://issues.apache.org/jira/browse/MWAR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MWAR-257: Fix Version/s: (was: 3.1.0) > Remove deprecation of dependentWarExcludes, since there is no alternative on > global level > - > > Key: MWAR-257 > URL: https://issues.apache.org/jira/browse/MWAR-257 > Project: Maven WAR Plugin > Issue Type: Bug > Components: overlay >Affects Versions: 2.1.1 >Reporter: dool >Assignee: Michael Osipov > > Hello, > DependentWarExcludes is marked as deprecated. Documentation says to use > / instead. > But it seems to me that it is not possible to get the same behaviour with > / as in this case we have to provide groupIds and > artifactIds. > Maybe this behaviour could be reproduced when setting both groupId and > artifactId to * as below : > > > > * > * > **/* > > > > > By the way, I found this, by looking for a way to disable overlay. The > workaround I thought was configuring your plugin to exclude every files when > overlaying. > I think it would be nice to have a configuration parameter for that. > Many thanks, > Dool -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MWAR-257) Remove deprecation of dependentWarExcludes, since there is no alternative on global level
[ https://issues.apache.org/jira/browse/MWAR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763824#comment-15763824 ] Michael Osipov commented on MWAR-257: - I just checked the code again, I have removed the parameter with [MWAR-367|https://github.com/apache/maven-plugins/commit/cb254e434a40b7ff58c936abbb3f823029a0e466#diff-acf964fa3df0af170507b414b9ea005f] because of some issues caused. If someone can provide a PR which does not break stuff, I will test and reintroduce this parameter. > Remove deprecation of dependentWarExcludes, since there is no alternative on > global level > - > > Key: MWAR-257 > URL: https://issues.apache.org/jira/browse/MWAR-257 > Project: Maven WAR Plugin > Issue Type: Bug > Components: overlay >Affects Versions: 2.1.1 >Reporter: dool >Assignee: Michael Osipov > > Hello, > DependentWarExcludes is marked as deprecated. Documentation says to use > / instead. > But it seems to me that it is not possible to get the same behaviour with > / as in this case we have to provide groupIds and > artifactIds. > Maybe this behaviour could be reproduced when setting both groupId and > artifactId to * as below : > > > > * > * > **/* > > > > > By the way, I found this, by looking for a way to disable overlay. The > workaround I thought was configuring your plugin to exclude every files when > overlaying. > I think it would be nice to have a configuration parameter for that. > Many thanks, > Dool -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MRELEASE-959) release:branch does not consider release versions
[
https://issues.apache.org/jira/browse/MRELEASE-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763984#comment-15763984
]
Laszlo Meszaros commented on MRELEASE-959:
--
Is there any progress with that ticket?
Or any workaround to not put -SNAPSHOT in version in the branch's pom?
> release:branch does not consider release versions
> -
>
> Key: MRELEASE-959
> URL: https://issues.apache.org/jira/browse/MRELEASE-959
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: branch
>Affects Versions: 2.5.3
>Reporter: Ramona Koch
> Labels: patch
> Attachments: release-branch-considers-releaseVersion.patch
>
>
> What I try to achieve, is to create a release branch from my development
> branch. The development branch has a snapshot version (e.g. 1.0.0-SNAPSHOT).
> As a result of the command I expect, to get a new branch containing version
> 1.0.0 and a changed development branch with version 1.0.1-SNAPSHOT. My
> project is a multi-module project.
> Related to the specification I assume, that this is the command I need to use:
> {code}
> mvn release:branch -DupdateBranchVersions=true -DupdateWorkCopyVersions=true
> -DupdateVersionsToSnapshot=false -DreleaseVersion=1.0.0
> -DdevelopmentVersion=1.0.1-SNAPSHOT -DbranchName=release-1.0.0
> -DautoVersionSubmodules=true
> {code}
> But this will result in asking me for a branch version, which only accepts
> snapshot versions. If I use {{batch-mode}} it will just use 1.0.1-SNAPSHOT.
> I also tried to give the versions per module by using {{-Dproject.dev...}}
> and {{-Dproject.rel...}}. It results in the same behaviour.
> At the end I had a look into the code and it seems, that it simply ignores
> the updateVersionsToSnapshot, which defines whether to update versions to
> SNAPSHOT in the branch or not. Since the default is true, it will always put
> a snapshot version in the branch.
> I will attach a patch file containing my proposed fix (including tests).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept null input
[
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MRESOLVER-4.
--
Resolution: Fixed
> Use java.util.Objects#requireNonNull to intercept null input
>
>
> Key: MRESOLVER-4
> URL: https://issues.apache.org/jira/browse/MRESOLVER-4
> Project: Maven Resolver
> Issue Type: Improvement
>Affects Versions: Maven Artifact Resolver 1.2.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In several spots of Maven Resolver IAE is thrown where an argument is null.
> This should be turned into NullPointerException since JDK adheres to is and
> the description of this exception indicates that and Effective Java does that
> too.
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
> throw new IllegalArgumentException( "Bad artifact coordinates " +
> coords
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
> throw new IllegalArgumentException( "dependency collection
> request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
> throw new IllegalArgumentException( "repository system session
> not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
> throw new IllegalArgumentException( "deploy request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:
> throw new IllegalArgumentException( "no artifact specified for
> dependency" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
> throw new IllegalArgumentException( "install request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
> throw new IllegalArgumentException( "metadata nature was not
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "repository system session
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
> throw new IllegalArgumentException( "local artifact request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
> throw new IllegalArgumentException( "local metadata request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
> throw new IllegalArgumentException( "repository prototype
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "session not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "event type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorResult.java:
> throw new IllegalArgumentException( "artifact descriptor request
> has not been specified"
[jira] [Reopened] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept invalid input
[
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reopened MRESOLVER-4:
> Use java.util.Objects#requireNonNull to intercept invalid input
> ---
>
> Key: MRESOLVER-4
> URL: https://issues.apache.org/jira/browse/MRESOLVER-4
> Project: Maven Resolver
> Issue Type: Improvement
>Affects Versions: Maven Artifact Resolver 1.2.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In several spots of Maven Resolver IAE is thrown where an argument is null.
> This should be turned into NullPointerException since JDK adheres to is and
> the description of this exception indicates that and Effective Java does that
> too.
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
> throw new IllegalArgumentException( "Bad artifact coordinates " +
> coords
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
> throw new IllegalArgumentException( "dependency collection
> request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
> throw new IllegalArgumentException( "repository system session
> not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
> throw new IllegalArgumentException( "deploy request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:
> throw new IllegalArgumentException( "no artifact specified for
> dependency" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
> throw new IllegalArgumentException( "install request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
> throw new IllegalArgumentException( "metadata nature was not
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "repository system session
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
> throw new IllegalArgumentException( "local artifact request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
> throw new IllegalArgumentException( "local metadata request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
> throw new IllegalArgumentException( "repository prototype
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "session not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "event type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorResult.java:
> throw new IllegalArgumentException( "artifact descriptor request
> has not been specified" );
> ./mave
[jira] [Updated] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept null input
[
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-4:
---
Summary: Use java.util.Objects#requireNonNull to intercept null input
(was: Use java.util.Objects#requireNonNull to intercept invalid input)
> Use java.util.Objects#requireNonNull to intercept null input
>
>
> Key: MRESOLVER-4
> URL: https://issues.apache.org/jira/browse/MRESOLVER-4
> Project: Maven Resolver
> Issue Type: Improvement
>Affects Versions: Maven Artifact Resolver 1.2.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In several spots of Maven Resolver IAE is thrown where an argument is null.
> This should be turned into NullPointerException since JDK adheres to is and
> the description of this exception indicates that and Effective Java does that
> too.
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
> throw new IllegalArgumentException( "Bad artifact coordinates " +
> coords
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
> throw new IllegalArgumentException( "dependency collection
> request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
> throw new IllegalArgumentException( "repository system session
> not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
> throw new IllegalArgumentException( "deploy request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:
> throw new IllegalArgumentException( "no artifact specified for
> dependency" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
> throw new IllegalArgumentException( "install request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
> throw new IllegalArgumentException( "metadata nature was not
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "repository system session
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
> throw new IllegalArgumentException( "local artifact request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
> throw new IllegalArgumentException( "local metadata request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
> throw new IllegalArgumentException( "repository prototype
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "session not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "event type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactD
[jira] [Created] (WAGON-473) Don't abuse IllegalArgumentException to intercept null input
Michael Osipov created WAGON-473:
Summary: Don't abuse IllegalArgumentException to intercept null
input
Key: WAGON-473
URL: https://issues.apache.org/jira/browse/WAGON-473
Project: Maven Wagon
Issue Type: Task
Affects Versions: 2.10
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 2.11
In several spots of Maven Wagon IAE is thrown where an argument is null. This
should be turned into NullPointerException since JDK adheres to is and the
description of this exception indicates that and Effective Java does that too.
Most likely to be misused:
{noformat}
$ grep -r "throw new IllegalArgumentException" .
./wagon-provider-api/src/main/java/org/apache/maven/wagon/PermissionModeUtils.java:
throw new IllegalArgumentException( "The mode is a number but is
not octal" );
./wagon-provider-api/src/main/java/org/apache/maven/wagon/events/SessionEvent.java:
throw new IllegalArgumentException( "Illegal event type: " +
eventType );
./wagon-provider-api/src/main/java/org/apache/maven/wagon/events/TransferEvent.java:
throw new IllegalArgumentException( "Illegal request type: " +
requestType );
./wagon-provider-api/src/main/java/org/apache/maven/wagon/events/TransferEvent.java:
throw new IllegalArgumentException( "Illegal event type: " +
eventType );
./wagon-provider-api/src/main/java/org/apache/maven/wagon/observers/ChecksumObserver.java:
throw new IllegalArgumentException( "Unrecognised length for binary
data: " + bitLength + " bits" );
./wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpWagon.java:
throw new IllegalArgumentException( "Authentication Credentials
cannot be null for FTP protocol" );
./wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/EncodingUtil.java:
throw new IllegalArgumentException( String.format( "Error parsing
url: %s", url ), e );
./wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java:
throw new IllegalArgumentException( "Output stream may not be
null" );
./wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java:
throw new IllegalArgumentException( "Source is a directory: " +
source );
./wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java:
throw new IllegalArgumentException( "Source is not a directory: " +
sourceDirectory );
./wagon-providers/wagon-ssh-common-test/src/main/java/org/apache/maven/wagon/providers/ssh/ScpCommandFactory.java:
throw new IllegalArgumentException( "Unknown command, does not
begin with 'scp'" );
./wagon-providers/wagon-ssh-common-test/src/main/java/org/apache/maven/wagon/providers/ssh/TestPublickeyAuthenticator.java:
throw new IllegalArgumentException( "no Base64 part to decode" );
./wagon-providers/wagon-ssh-common-test/src/main/java/org/apache/maven/wagon/providers/ssh/TestPublickeyAuthenticator.java:
throw new IllegalArgumentException( "unknown type " + type );
./wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/interactive/PrompterUIKeyboardInteractive.java:
throw new IllegalArgumentException( "prompt and echo size arrays
are different!" );
./wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/jackrabbit/webdav/MultiStatus.java:
throw new IllegalArgumentException( "DAV:multistatus element
expected." );
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (WAGON-473) Don't abuse IllegalArgumentException to intercept null input
[
https://issues.apache.org/jira/browse/WAGON-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed WAGON-473.
Resolution: Fixed
Fixed with 30631655e8f6cdf121161b3ca09e3da0134a5198.
> Don't abuse IllegalArgumentException to intercept null input
>
>
> Key: WAGON-473
> URL: https://issues.apache.org/jira/browse/WAGON-473
> Project: Maven Wagon
> Issue Type: Task
>Affects Versions: 2.10
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 2.11
>
>
> In several spots of Maven Wagon IAE is thrown where an argument is null. This
> should be turned into NullPointerException since JDK adheres to is and the
> description of this exception indicates that and Effective Java does that too.
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/PermissionModeUtils.java:
> throw new IllegalArgumentException( "The mode is a number but is
> not octal" );
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/events/SessionEvent.java:
> throw new IllegalArgumentException( "Illegal event type: " +
> eventType );
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/events/TransferEvent.java:
> throw new IllegalArgumentException( "Illegal request type: "
> + requestType );
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/events/TransferEvent.java:
> throw new IllegalArgumentException( "Illegal event type: " +
> eventType );
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/observers/ChecksumObserver.java:
> throw new IllegalArgumentException( "Unrecognised length for
> binary data: " + bitLength + " bits" );
> ./wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpWagon.java:
> throw new IllegalArgumentException( "Authentication Credentials
> cannot be null for FTP protocol" );
> ./wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/EncodingUtil.java:
> throw new IllegalArgumentException( String.format( "Error parsing
> url: %s", url ), e );
> ./wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java:
> throw new IllegalArgumentException( "Output stream may not be
> null" );
> ./wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java:
> throw new IllegalArgumentException( "Source is a directory: " +
> source );
> ./wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java:
> throw new IllegalArgumentException( "Source is not a directory: "
> + sourceDirectory );
> ./wagon-providers/wagon-ssh-common-test/src/main/java/org/apache/maven/wagon/providers/ssh/ScpCommandFactory.java:
> throw new IllegalArgumentException( "Unknown command, does not
> begin with 'scp'" );
> ./wagon-providers/wagon-ssh-common-test/src/main/java/org/apache/maven/wagon/providers/ssh/TestPublickeyAuthenticator.java:
> throw new IllegalArgumentException( "no Base64 part to decode" );
> ./wagon-providers/wagon-ssh-common-test/src/main/java/org/apache/maven/wagon/providers/ssh/TestPublickeyAuthenticator.java:
> throw new IllegalArgumentException( "unknown type " + type );
> ./wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/interactive/PrompterUIKeyboardInteractive.java:
> throw new IllegalArgumentException( "prompt and echo size arrays
> are different!" );
> ./wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/jackrabbit/webdav/MultiStatus.java:
> throw new IllegalArgumentException( "DAV:multistatus element
> expected." );
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MNG-6136) Upgrade Maven Wagon to 2.11
Michael Osipov created MNG-6136: --- Summary: Upgrade Maven Wagon to 2.11 Key: MNG-6136 URL: https://issues.apache.org/jira/browse/MNG-6136 Project: Maven Issue Type: Task Components: Deployment Affects Versions: 3.3.9 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.4.0 Let's absorb latest improvements to Wagon into Maven. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MNG-6137) Clean up duplicate dependencies caused by incomplete Wagon HTTP Provider exclusions
Michael Osipov created MNG-6137:
---
Summary: Clean up duplicate dependencies caused by incomplete
Wagon HTTP Provider exclusions
Key: MNG-6137
URL: https://issues.apache.org/jira/browse/MNG-6137
Project: Maven
Issue Type: Task
Components: Deployment
Affects Versions: 3.3.9
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 3.4.0
Some dependencies are duplicated in {{maven.home/lib}} because not all shaded
dependencies of Wagon HTTP Provider are excluded. This can easily be cleaned up
when Wagon 2.11 is merged.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WAGON-473) Don't abuse IllegalArgumentException to intercept null input
[
https://issues.apache.org/jira/browse/WAGON-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764172#comment-15764172
]
Hudson commented on WAGON-473:
--
FAILURE: Integrated in Jenkins build maven-wagon #1324 (See
[https://builds.apache.org/job/maven-wagon/1324/])
[WAGON-473] Don't abuse IllegalArgumentException to intercept null input
(michaelo: rev 30631655e8f6cdf121161b3ca09e3da0134a5198)
* (edit)
wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java
* (edit)
wagon-provider-api/src/main/java/org/apache/maven/wagon/repository/Repository.java
* (edit)
wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
* (edit)
wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpWagon.java
> Don't abuse IllegalArgumentException to intercept null input
>
>
> Key: WAGON-473
> URL: https://issues.apache.org/jira/browse/WAGON-473
> Project: Maven Wagon
> Issue Type: Task
>Affects Versions: 2.10
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 2.11
>
>
> In several spots of Maven Wagon IAE is thrown where an argument is null. This
> should be turned into NullPointerException since JDK adheres to is and the
> description of this exception indicates that and Effective Java does that too.
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/PermissionModeUtils.java:
> throw new IllegalArgumentException( "The mode is a number but is
> not octal" );
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/events/SessionEvent.java:
> throw new IllegalArgumentException( "Illegal event type: " +
> eventType );
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/events/TransferEvent.java:
> throw new IllegalArgumentException( "Illegal request type: "
> + requestType );
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/events/TransferEvent.java:
> throw new IllegalArgumentException( "Illegal event type: " +
> eventType );
> ./wagon-provider-api/src/main/java/org/apache/maven/wagon/observers/ChecksumObserver.java:
> throw new IllegalArgumentException( "Unrecognised length for
> binary data: " + bitLength + " bits" );
> ./wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpWagon.java:
> throw new IllegalArgumentException( "Authentication Credentials
> cannot be null for FTP protocol" );
> ./wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/EncodingUtil.java:
> throw new IllegalArgumentException( String.format( "Error parsing
> url: %s", url ), e );
> ./wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java:
> throw new IllegalArgumentException( "Output stream may not be
> null" );
> ./wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java:
> throw new IllegalArgumentException( "Source is a directory: " +
> source );
> ./wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java:
> throw new IllegalArgumentException( "Source is not a directory: "
> + sourceDirectory );
> ./wagon-providers/wagon-ssh-common-test/src/main/java/org/apache/maven/wagon/providers/ssh/ScpCommandFactory.java:
> throw new IllegalArgumentException( "Unknown command, does not
> begin with 'scp'" );
> ./wagon-providers/wagon-ssh-common-test/src/main/java/org/apache/maven/wagon/providers/ssh/TestPublickeyAuthenticator.java:
> throw new IllegalArgumentException( "no Base64 part to decode" );
> ./wagon-providers/wagon-ssh-common-test/src/main/java/org/apache/maven/wagon/providers/ssh/TestPublickeyAuthenticator.java:
> throw new IllegalArgumentException( "unknown type " + type );
> ./wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/interactive/PrompterUIKeyboardInteractive.java:
> throw new IllegalArgumentException( "prompt and echo size arrays
> are different!" );
> ./wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/jackrabbit/webdav/MultiStatus.java:
> throw new IllegalArgumentException( "DAV:multistatus element
> expected." );
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MNG-6000) activeProfiles in pom.xml
[
https://issues.apache.org/jira/browse/MNG-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6000:
Fix Version/s: (was: waiting-for-feedback)
> activeProfiles in pom.xml
> -
>
> Key: MNG-6000
> URL: https://issues.apache.org/jira/browse/MNG-6000
> Project: Maven
> Issue Type: Improvement
> Components: POM, Profiles
>Reporter: Fabrizio Lungo
> Labels: features, maven
>
> I would like to see the ability to define {{}} in a pom. I
> think this would be extremely useful and provide a way for a parent pom to
> provide a set of profiles that can be picked and chosen from as per the needs
> of the project.
> A simple but specific example is where I would like to have a profile from
> our corporate parent pom that is activated when a project should build an
> executable jar. This profile provides the configuration for the
> {{maven-jar-plugin}} (as well as adding some validations and checks) and we
> would like to activate this on a per project level.
> Initially I tried using properties but activation conditions only look at
> system properties (and not pom defined ones) and even using a property in the
> {{}} tag. As described in MNG-5235 this is because
> profiles need to be processed first and using properties from the pom would
> create chicken-egg problems and inconsistencies because a profile can then
> modify these properties.
> If {{}} were to be added to pom, this could be read first to
> determine if any profiles need to be activated and allow a pom to define
> which profiles will be active by default.
> Two optional features that could be implemented to supplement this would be:
> * Support for {{}} inside of a profile for profiles to be
> able to recursively enable other profiles (that they may depend on). This
> would allow reduction of duplication if two profiles require some shared
> preconditions they can then just activate the profile with this shared
> configuration and if one or both are activated, the shared configuration
> profile will be activated too. This should be fairly easy to implement using
> recursive checks and not revisiting any profiles already in an active list
> (to avoid cycles - which should be warned about - and unnecessary
> re-evaluations)
> * Support for disabling profiles (possibly by using
> {{!profile-1}} syntax. This could have advantages where a
> parent pom activates a profile by default and the child wants it disabled by
> default although I can see this may cause problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-6000) activeProfiles in pom.xml
[
https://issues.apache.org/jira/browse/MNG-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765549#comment-15765549
]
Joerg Schaible commented on MNG-6000:
-
This is already possible using file exists.
> activeProfiles in pom.xml
> -
>
> Key: MNG-6000
> URL: https://issues.apache.org/jira/browse/MNG-6000
> Project: Maven
> Issue Type: Improvement
> Components: POM, Profiles
>Reporter: Fabrizio Lungo
> Labels: features, maven
>
> I would like to see the ability to define {{}} in a pom. I
> think this would be extremely useful and provide a way for a parent pom to
> provide a set of profiles that can be picked and chosen from as per the needs
> of the project.
> A simple but specific example is where I would like to have a profile from
> our corporate parent pom that is activated when a project should build an
> executable jar. This profile provides the configuration for the
> {{maven-jar-plugin}} (as well as adding some validations and checks) and we
> would like to activate this on a per project level.
> Initially I tried using properties but activation conditions only look at
> system properties (and not pom defined ones) and even using a property in the
> {{}} tag. As described in MNG-5235 this is because
> profiles need to be processed first and using properties from the pom would
> create chicken-egg problems and inconsistencies because a profile can then
> modify these properties.
> If {{}} were to be added to pom, this could be read first to
> determine if any profiles need to be activated and allow a pom to define
> which profiles will be active by default.
> Two optional features that could be implemented to supplement this would be:
> * Support for {{}} inside of a profile for profiles to be
> able to recursively enable other profiles (that they may depend on). This
> would allow reduction of duplication if two profiles require some shared
> preconditions they can then just activate the profile with this shared
> configuration and if one or both are activated, the shared configuration
> profile will be activated too. This should be fairly easy to implement using
> recursive checks and not revisiting any profiles already in an active list
> (to avoid cycles - which should be warned about - and unnecessary
> re-evaluations)
> * Support for disabling profiles (possibly by using
> {{!profile-1}} syntax. This could have advantages where a
> parent pom activates a profile by default and the child wants it disabled by
> default although I can see this may cause problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MRESOLVER-12) Addition of unit tests for the various DependencySelector implementations to test things are working as documented.
Christian Schulte created MRESOLVER-12: -- Summary: Addition of unit tests for the various DependencySelector implementations to test things are working as documented. Key: MRESOLVER-12 URL: https://issues.apache.org/jira/browse/MRESOLVER-12 Project: Maven Resolver Issue Type: Task Reporter: Christian Schulte Assignee: Christian Schulte Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MRESOLVER-12) Addition of unit tests for the various DependencySelector implementations to test things are working as documented.
[
https://issues.apache.org/jira/browse/MRESOLVER-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte updated MRESOLVER-12:
---
Description: The {{DefaultDependencyCollector}} heavily relies on various
components provided by an application. There should be unit tests for testing
that at least the {{ScopeDependencySelector}} and
{{OptionalDependencySelector}} selector are working as stated in the Javadoc.
> Addition of unit tests for the various DependencySelector implementations to
> test things are working as documented.
> ---
>
> Key: MRESOLVER-12
> URL: https://issues.apache.org/jira/browse/MRESOLVER-12
> Project: Maven Resolver
> Issue Type: Task
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Minor
>
> The {{DefaultDependencyCollector}} heavily relies on various components
> provided by an application. There should be unit tests for testing that at
> least the {{ScopeDependencySelector}} and {{OptionalDependencySelector}}
> selector are working as stated in the Javadoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (MRESOLVER-12) Addition of unit tests for the various DependencySelector implementations to test things are working as documented.
[
https://issues.apache.org/jira/browse/MRESOLVER-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte closed MRESOLVER-12.
--
Resolution: Fixed
Fix Version/s: Maven Artifact Resolver 1.2.0
> Addition of unit tests for the various DependencySelector implementations to
> test things are working as documented.
> ---
>
> Key: MRESOLVER-12
> URL: https://issues.apache.org/jira/browse/MRESOLVER-12
> Project: Maven Resolver
> Issue Type: Task
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> The {{DefaultDependencyCollector}} heavily relies on various components
> provided by an application. There should be unit tests for testing that at
> least the {{ScopeDependencySelector}} and {{OptionalDependencySelector}}
> selector are working as stated in the Javadoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (MRESOLVER-8) Mode selection (transitive vs. direct) implemented inconsistently in classes 'ScopeDependencySelector' and 'OptionalDependencySelector'.
[
https://issues.apache.org/jira/browse/MRESOLVER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte reopened MRESOLVER-8:
---
Re-opening to edit description.
> Mode selection (transitive vs. direct) implemented inconsistently in classes
> 'ScopeDependencySelector' and 'OptionalDependencySelector'.
>
>
> Key: MRESOLVER-8
> URL: https://issues.apache.org/jira/browse/MRESOLVER-8
> Project: Maven Resolver
> Issue Type: Bug
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Critical
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> The classes 'ScopeDependencySelector' and 'OptionalDependencySelector'
> inconsistently detected the mode of operation (direct or transitive). Whereas
> the 'ScopeDependencySelector' honours the kind of resolution having been
> requested (dependency vs. POM), the 'OptionalDependencySelector' does not
> honour this difference. As both classes implement the 'DependencySelector',
> they should select the mode of operation (direct vs. transitive) consistently.
> This is what things looked liked before the fix:
> {panel:title=ScopeDependencySelector}
> {code}
> public DependencySelector deriveChildSelector( DependencyCollectionContext
> context )
> {
> if ( this.transitive || context.getDependency() == null )
> {
> return this;
> }
> return new ScopeDependencySelector( true, included, excluded );
> }
> {code}
> {panel}
> {panel:title=OptionalDependencySelector}
> {code}
> public DependencySelector deriveChildSelector( DependencyCollectionContext
> context )
> {
> if ( depth >= 2 )
> {
> return this;
> }
> return new OptionalDependencySelector( depth + 1 );
> }
> {code}
> {panel}
> This is what both classes look like after the fix. No difference in mode
> selection any more.
> {panel:title=ScopeDependencySelector}
> {code}
> public DependencySelector deriveChildSelector( DependencyCollectionContext
> context )
> {
> ScopeDependencySelector child = this;
> if ( context.getDependency() != null && !child.transitive )
> {
> child = new ScopeDependencySelector( true, this.included,
> this.excluded );
> }
> if ( context.getDependency() == null && child.transitive )
> {
> child = new ScopeDependencySelector( false, this.included,
> this.excluded );
> }
> return child;
> }
> {code}
> {panel}
> {panel:title=OptionalDependencySelector}
> {code}
> public DependencySelector deriveChildSelector( DependencyCollectionContext
> context )
> {
> OptionalDependencySelector child = this;
> if ( context.getDependency() != null && !child.transitive )
> {
> child = new OptionalDependencySelector( true );
> }
> if ( context.getDependency() == null && child.transitive )
> {
> child = new OptionalDependencySelector( false );
> }
> return child;
> }
> {code}
> {panel}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MRESOLVER-8) ScopeDependencySelector incorrectly de-selects direct dependencies.
[
https://issues.apache.org/jira/browse/MRESOLVER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte updated MRESOLVER-8:
--
Summary: ScopeDependencySelector incorrectly de-selects direct
dependencies. (was: Mode selection (transitive vs. direct) implemented
inconsistently in classes 'ScopeDependencySelector' and
'OptionalDependencySelector'.)
> ScopeDependencySelector incorrectly de-selects direct dependencies.
> ---
>
> Key: MRESOLVER-8
> URL: https://issues.apache.org/jira/browse/MRESOLVER-8
> Project: Maven Resolver
> Issue Type: Bug
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Critical
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> The classes 'ScopeDependencySelector' and 'OptionalDependencySelector'
> inconsistently detected the mode of operation (direct or transitive). Whereas
> the 'ScopeDependencySelector' honours the kind of resolution having been
> requested (dependency vs. POM), the 'OptionalDependencySelector' does not
> honour this difference. As both classes implement the 'DependencySelector',
> they should select the mode of operation (direct vs. transitive) consistently.
> This is what things looked liked before the fix:
> {panel:title=ScopeDependencySelector}
> {code}
> public DependencySelector deriveChildSelector( DependencyCollectionContext
> context )
> {
> if ( this.transitive || context.getDependency() == null )
> {
> return this;
> }
> return new ScopeDependencySelector( true, included, excluded );
> }
> {code}
> {panel}
> {panel:title=OptionalDependencySelector}
> {code}
> public DependencySelector deriveChildSelector( DependencyCollectionContext
> context )
> {
> if ( depth >= 2 )
> {
> return this;
> }
> return new OptionalDependencySelector( depth + 1 );
> }
> {code}
> {panel}
> This is what both classes look like after the fix. No difference in mode
> selection any more.
> {panel:title=ScopeDependencySelector}
> {code}
> public DependencySelector deriveChildSelector( DependencyCollectionContext
> context )
> {
> ScopeDependencySelector child = this;
> if ( context.getDependency() != null && !child.transitive )
> {
> child = new ScopeDependencySelector( true, this.included,
> this.excluded );
> }
> if ( context.getDependency() == null && child.transitive )
> {
> child = new ScopeDependencySelector( false, this.included,
> this.excluded );
> }
> return child;
> }
> {code}
> {panel}
> {panel:title=OptionalDependencySelector}
> {code}
> public DependencySelector deriveChildSelector( DependencyCollectionContext
> context )
> {
> OptionalDependencySelector child = this;
> if ( context.getDependency() != null && !child.transitive )
> {
> child = new OptionalDependencySelector( true );
> }
> if ( context.getDependency() == null && child.transitive )
> {
> child = new OptionalDependencySelector( false );
> }
> return child;
> }
> {code}
> {panel}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MRESOLVER-8) ScopeDependencySelector incorrectly de-selects direct dependencies.
[
https://issues.apache.org/jira/browse/MRESOLVER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte updated MRESOLVER-8:
--
Description: (was: The classes 'ScopeDependencySelector' and
'OptionalDependencySelector' inconsistently detected the mode of operation
(direct or transitive). Whereas the 'ScopeDependencySelector' honours the kind
of resolution having been requested (dependency vs. POM), the
'OptionalDependencySelector' does not honour this difference. As both classes
implement the 'DependencySelector', they should select the mode of operation
(direct vs. transitive) consistently.
This is what things looked liked before the fix:
{panel:title=ScopeDependencySelector}
{code}
public DependencySelector deriveChildSelector( DependencyCollectionContext
context )
{
if ( this.transitive || context.getDependency() == null )
{
return this;
}
return new ScopeDependencySelector( true, included, excluded );
}
{code}
{panel}
{panel:title=OptionalDependencySelector}
{code}
public DependencySelector deriveChildSelector( DependencyCollectionContext
context )
{
if ( depth >= 2 )
{
return this;
}
return new OptionalDependencySelector( depth + 1 );
}
{code}
{panel}
This is what both classes look like after the fix. No difference in mode
selection any more.
{panel:title=ScopeDependencySelector}
{code}
public DependencySelector deriveChildSelector( DependencyCollectionContext
context )
{
ScopeDependencySelector child = this;
if ( context.getDependency() != null && !child.transitive )
{
child = new ScopeDependencySelector( true, this.included, this.excluded
);
}
if ( context.getDependency() == null && child.transitive )
{
child = new ScopeDependencySelector( false, this.included,
this.excluded );
}
return child;
}
{code}
{panel}
{panel:title=OptionalDependencySelector}
{code}
public DependencySelector deriveChildSelector( DependencyCollectionContext
context )
{
OptionalDependencySelector child = this;
if ( context.getDependency() != null && !child.transitive )
{
child = new OptionalDependencySelector( true );
}
if ( context.getDependency() == null && child.transitive )
{
child = new OptionalDependencySelector( false );
}
return child;
}
{code}
{panel}
)
> ScopeDependencySelector incorrectly de-selects direct dependencies.
> ---
>
> Key: MRESOLVER-8
> URL: https://issues.apache.org/jira/browse/MRESOLVER-8
> Project: Maven Resolver
> Issue Type: Bug
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Critical
> Fix For: Maven Artifact Resolver 1.2.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MRESOLVER-8) ScopeDependencySelector incorrectly de-selects direct dependencies.
[
https://issues.apache.org/jira/browse/MRESOLVER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte updated MRESOLVER-8:
--
Description: The {{ScopeDependencySelector}} decides if a node is a direct
dependency or transitive dependency differently based on the request performed.
For the {{CollectRequest.setRootArtifact(Artifact)}} case, the class is working
correctly. For the {{CollectRequest.setRoot(Dependency)}} case, the class is
de-selecting direct dependencies instead of transitive dependencies.
> ScopeDependencySelector incorrectly de-selects direct dependencies.
> ---
>
> Key: MRESOLVER-8
> URL: https://issues.apache.org/jira/browse/MRESOLVER-8
> Project: Maven Resolver
> Issue Type: Bug
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Critical
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> The {{ScopeDependencySelector}} decides if a node is a direct dependency or
> transitive dependency differently based on the request performed. For the
> {{CollectRequest.setRootArtifact(Artifact)}} case, the class is working
> correctly. For the {{CollectRequest.setRoot(Dependency)}} case, the class is
> de-selecting direct dependencies instead of transitive dependencies.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (MNG-6135) Maven plugins and core extensions are not dependencies, they should be resolved the same way as projects.
[ https://issues.apache.org/jira/browse/MNG-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schulte reopened MNG-6135: Re-opening to edit links. > Maven plugins and core extensions are not dependencies, they should be > resolved the same way as projects. > - > > Key: MNG-6135 > URL: https://issues.apache.org/jira/browse/MNG-6135 > Project: Maven > Issue Type: Bug >Reporter: Christian Schulte >Assignee: Christian Schulte >Priority: Critical > Fix For: 3.4.0 > > > can you explain the logic, please? > I don't understand why "they should be resolved the same way as project", > what it really means and what impact it has: I just see that everything is > currently failing: it's a mess!!! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MNG-6135) Maven plugins and core extensions are not dependencies, they should be resolved the same way as projects.
[
https://issues.apache.org/jira/browse/MNG-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte updated MNG-6135:
---
Description:
Due to a bug in the Maven resolver, plugin and core extensions were resolved
incorrectly. The direct {{test}} and {{provided}} dependencies were ignored.
was:
can you explain the logic, please?
I don't understand why "they should be resolved the same way as project", what
it really means and what impact it has: I just see that everything is currently
failing: it's a mess!!!
> Maven plugins and core extensions are not dependencies, they should be
> resolved the same way as projects.
> -
>
> Key: MNG-6135
> URL: https://issues.apache.org/jira/browse/MNG-6135
> Project: Maven
> Issue Type: Bug
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Critical
> Fix For: 3.4.0
>
>
> Due to a bug in the Maven resolver, plugin and core extensions were resolved
> incorrectly. The direct {{test}} and {{provided}} dependencies were ignored.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (MNG-6135) Maven plugins and core extensions are not dependencies, they should be resolved the same way as projects.
[
https://issues.apache.org/jira/browse/MNG-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte closed MNG-6135.
--
Resolution: Fixed
> Maven plugins and core extensions are not dependencies, they should be
> resolved the same way as projects.
> -
>
> Key: MNG-6135
> URL: https://issues.apache.org/jira/browse/MNG-6135
> Project: Maven
> Issue Type: Bug
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Critical
> Fix For: 3.4.0
>
>
> Due to a bug in the Maven resolver, plugin and core extensions were resolved
> incorrectly. The direct {{test}} and {{provided}} dependencies were ignored.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-6049) Add behavior to filter resolved version ranges of an artifact
[
https://issues.apache.org/jira/browse/MNG-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766006#comment-15766006
]
Christian Schulte commented on MNG-6049:
Is it intention the ITs do not run with 3.4.0-SNAPSHOT?
mng6049VersionRangeResultFilterExtension(Default) SKIPPED - Maven version
3.4.0-SNAPSHOT not in range (3.4.0,)
mng6049VersionRangeResultFilterExtension(VersionRangeResultFilterExtensionSystemProperties)
SKIPPED - Maven version 3.4.0-SNAPSHOT not in range (3.4.0,)
> Add behavior to filter resolved version ranges of an artifact
> -
>
> Key: MNG-6049
> URL: https://issues.apache.org/jira/browse/MNG-6049
> Project: Maven
> Issue Type: Improvement
> Components: core, Dependencies
>Reporter: Uwe Barthel
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 3.4.0
>
>
> The discussion on issue MNG-3092 shows the seriously needs of different kinds
> of version range resolving in Maven.
> This solution provides a hook for Maven extensions/plugins to change the list
> of resolved version range results as required.
> The {{DefaultVersionRangeResolver}} will be extended with a filter for
> version range results. A new interface {{VersionRangeResultFilter}} is added
> and a non-filtering {{DefaultVersionRangeResultFilter}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MNG-6049) Add behavior to filter resolved version ranges of an artifact
[
https://issues.apache.org/jira/browse/MNG-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766006#comment-15766006
]
Christian Schulte edited comment on MNG-6049 at 12/21/16 3:40 AM:
--
Is it intention the ITs do not run with 3.4.0-SNAPSHOT?
{code}
mng6049VersionRangeResultFilterExtension(Default) SKIPPED - Maven version
3.4.0-SNAPSHOT not in range (3.4.0,)
mng6049VersionRangeResultFilterExtension(VersionRangeResultFilterExtensionSystemProperties)
SKIPPED - Maven version 3.4.0-SNAPSHOT not in range (3.4.0,)
{code}
was (Author: schulte77):
Is it intention the ITs do not run with 3.4.0-SNAPSHOT?
mng6049VersionRangeResultFilterExtension(Default) SKIPPED - Maven version
3.4.0-SNAPSHOT not in range (3.4.0,)
mng6049VersionRangeResultFilterExtension(VersionRangeResultFilterExtensionSystemProperties)
SKIPPED - Maven version 3.4.0-SNAPSHOT not in range (3.4.0,)
> Add behavior to filter resolved version ranges of an artifact
> -
>
> Key: MNG-6049
> URL: https://issues.apache.org/jira/browse/MNG-6049
> Project: Maven
> Issue Type: Improvement
> Components: core, Dependencies
>Reporter: Uwe Barthel
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 3.4.0
>
>
> The discussion on issue MNG-3092 shows the seriously needs of different kinds
> of version range resolving in Maven.
> This solution provides a hook for Maven extensions/plugins to change the list
> of resolved version range results as required.
> The {{DefaultVersionRangeResolver}} will be extended with a filter for
> version range results. A new interface {{VersionRangeResultFilter}} is added
> and a non-filtering {{DefaultVersionRangeResultFilter}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (MRESOLVER-8) ScopeDependencySelector incorrectly de-selects direct dependencies.
[
https://issues.apache.org/jira/browse/MRESOLVER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte closed MRESOLVER-8.
-
Resolution: Fixed
> ScopeDependencySelector incorrectly de-selects direct dependencies.
> ---
>
> Key: MRESOLVER-8
> URL: https://issues.apache.org/jira/browse/MRESOLVER-8
> Project: Maven Resolver
> Issue Type: Bug
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Critical
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> The {{ScopeDependencySelector}} decides if a node is a direct dependency or
> transitive dependency differently based on the request performed. For the
> {{CollectRequest.setRootArtifact(Artifact)}} case, the class is working
> correctly. For the {{CollectRequest.setRoot(Dependency)}} case, the class is
> de-selecting direct dependencies instead of transitive dependencies.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MRESOLVER-10) New class 'TransitiveDependencyManager' supporting transitive dependency management.
[
https://issues.apache.org/jira/browse/MRESOLVER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766058#comment-15766058
]
Hudson commented on MRESOLVER-10:
-
SUCCESS: Integrated in Jenkins build maven-resolver #29 (See
[https://builds.apache.org/job/maven-resolver/29/])
[MRESOLVER-10] New class 'TransitiveDependencyManager' supporting (schulte: rev
1a3831df53cdbecc01caa39a792c3a94fd99d803)
* (edit)
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/manager/TransitiveDependencyManager.java
> New class 'TransitiveDependencyManager' supporting transitive dependency
> management.
>
>
> Key: MRESOLVER-10
> URL: https://issues.apache.org/jira/browse/MRESOLVER-10
> Project: Maven Resolver
> Issue Type: New Feature
> Components: resolver
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> The {{ClassicDependencyManager}} ignores the dependency management from
> transitive dependencies to maintain backwards compatibility with Maven 2. The
> {{TransitiveDependencyManager}} will correctly use that dependency management
> (it could also be named {{DefaultDependencyManager}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MRESOLVER-12) Addition of unit tests for the various DependencySelector implementations to test things are working as documented.
[ https://issues.apache.org/jira/browse/MRESOLVER-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766059#comment-15766059 ] Hudson commented on MRESOLVER-12: - SUCCESS: Integrated in Jenkins build maven-resolver #29 (See [https://builds.apache.org/job/maven-resolver/29/]) [MRESOLVER-12] Addition of unit tests for the various DependencySelector (schulte: rev 65e1e5f46e9e47953aead20a9636d1378f1d6400) * (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/management-tree.txt * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/pom-management-tree.txt * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-direct_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-2_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-1_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_root_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_root_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_transitive-3_managed-by-transitive-1.ini * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-of-transitive-of-direct_ver.ini * (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/all-nodes.txt * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_root_ver.ini * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-transitive-of-direct-scope-exclusion-tree.txt * (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_direct_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-1-exclusion-tree.txt * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_5_managed-by-3.ini * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/without-optional-transitive-nodes-of-direct-dependency.txt * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-transitive-of-transitive-of-direct-scope-exclusion-tree.txt * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_0_ver.ini * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-of-direct_ver.ini * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-direct-scope-exclusion-tree.txt * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/all-nodes-of-pom.txt * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-transitive-of-direct_ver.ini * (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/all-nodes.txt * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_transitive-1_managed-by-root.ini * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-transitive-of-transitive-of-direct_ver.ini * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_3_managed-by-1.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_transitive-4_managed-by-transitive-2.ini * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/without-optional-transitive-nodes-of-pom.txt * (edit) maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultDependencyCollectorTest.java * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_direct_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-2-exclusion-tree.txt * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_1_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/optional-transitive-exclusion-tree.txt * (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_direct_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-2_ver.ini * (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_4_managed-by-2.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-1_ver.ini * (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_transitive-2_managed-by-direct.ini * (delete) maven-resolver-impl/src/test/resources/artifact-
[jira] [Commented] (MRESOLVER-8) ScopeDependencySelector incorrectly de-selects direct dependencies.
[
https://issues.apache.org/jira/browse/MRESOLVER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766057#comment-15766057
]
Hudson commented on MRESOLVER-8:
SUCCESS: Integrated in Jenkins build maven-resolver #29 (See
[https://builds.apache.org/job/maven-resolver/29/])
[MRESOLVER-8] ScopeDependencySelector incorrectly de-selects direct (schulte:
rev 9855af4fbd6bb0f64750d27b2eee2e03b25b58ba)
* (edit)
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/selector/ScopeDependencySelector.java
* (edit)
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/selector/OptionalDependencySelector.java
> ScopeDependencySelector incorrectly de-selects direct dependencies.
> ---
>
> Key: MRESOLVER-8
> URL: https://issues.apache.org/jira/browse/MRESOLVER-8
> Project: Maven Resolver
> Issue Type: Bug
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Critical
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> The {{ScopeDependencySelector}} decides if a node is a direct dependency or
> transitive dependency differently based on the request performed. For the
> {{CollectRequest.setRootArtifact(Artifact)}} case, the class is working
> correctly. For the {{CollectRequest.setRoot(Dependency)}} case, the class is
> de-selecting direct dependencies instead of transitive dependencies.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-6135) Maven plugins and core extensions are not dependencies, they should be resolved the same way as projects.
[
https://issues.apache.org/jira/browse/MNG-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766068#comment-15766068
]
Hudson commented on MNG-6135:
-
SUCCESS: Integrated in Jenkins build maven-3.x #1466 (See
[https://builds.apache.org/job/maven-3.x/1466/])
[MNG-6135] Maven plugins and core extensions are not dependencies, they
(schulte: rev e8a0af6e649b21a8fd5f7d59ef8b559ed39fcf16)
* (edit)
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java
> Maven plugins and core extensions are not dependencies, they should be
> resolved the same way as projects.
> -
>
> Key: MNG-6135
> URL: https://issues.apache.org/jira/browse/MNG-6135
> Project: Maven
> Issue Type: Bug
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Critical
> Fix For: 3.4.0
>
>
> Due to a bug in the Maven resolver, plugin and core extensions were resolved
> incorrectly. The direct {{test}} and {{provided}} dependencies were ignored.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MRESOLVER-13) Exceptions are suppressed incorrectly when closing resources fails.
Christian Schulte created MRESOLVER-13: -- Summary: Exceptions are suppressed incorrectly when closing resources fails. Key: MRESOLVER-13 URL: https://issues.apache.org/jira/browse/MRESOLVER-13 Project: Maven Resolver Issue Type: Bug Reporter: Christian Schulte Assignee: Christian Schulte Fix For: Maven Artifact Resolver 1.2.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (MRESOLVER-13) Exceptions are suppressed incorrectly when closing resources fails.
[ https://issues.apache.org/jira/browse/MRESOLVER-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schulte closed MRESOLVER-13. -- Resolution: Fixed Fixed in [1ee92862c67ec98564c4d8be1207355960f1dd5d|https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=1ee92862c67ec98564c4d8be1207355960f1dd5d]. > Exceptions are suppressed incorrectly when closing resources fails. > --- > > Key: MRESOLVER-13 > URL: https://issues.apache.org/jira/browse/MRESOLVER-13 > Project: Maven Resolver > Issue Type: Bug >Reporter: Christian Schulte >Assignee: Christian Schulte > Fix For: Maven Artifact Resolver 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (MRESOLVER-14) Statistics should be calculated using System.nanoTime instead of System.currentTimeMillis.
[ https://issues.apache.org/jira/browse/MRESOLVER-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schulte closed MRESOLVER-14. -- Resolution: Fixed Fixed with [1ee92862c67ec98564c4d8be1207355960f1dd5d|https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=1ee92862c67ec98564c4d8be1207355960f1dd5d]. > Statistics should be calculated using System.nanoTime instead of > System.currentTimeMillis. > -- > > Key: MRESOLVER-14 > URL: https://issues.apache.org/jira/browse/MRESOLVER-14 > Project: Maven Resolver > Issue Type: Bug >Reporter: Christian Schulte >Assignee: Christian Schulte > Fix For: Maven Artifact Resolver 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MRESOLVER-14) Statistics should be calculated using System.nanoTime instead of System.currentTimeMillis.
Christian Schulte created MRESOLVER-14: -- Summary: Statistics should be calculated using System.nanoTime instead of System.currentTimeMillis. Key: MRESOLVER-14 URL: https://issues.apache.org/jira/browse/MRESOLVER-14 Project: Maven Resolver Issue Type: Bug Reporter: Christian Schulte Assignee: Christian Schulte Fix For: Maven Artifact Resolver 1.2.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MNG-5761) Dependency management is not transitive.
[ https://issues.apache.org/jira/browse/MNG-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schulte updated MNG-5761: --- Labels: (was: requires-aether-release) > Dependency management is not transitive. > > > Key: MNG-5761 > URL: https://issues.apache.org/jira/browse/MNG-5761 > Project: Maven > Issue Type: Bug > Components: Dependencies >Affects Versions: 3.2.5 >Reporter: Jeff Schnitzer >Assignee: Christian Schulte >Priority: Critical > Fix For: 3.4.0 > > Attachments: MNG-5761.zip > > > A detailed description of the issue is here: > http://stackoverflow.com/questions/28312975/maven-dependencymanagement-version-ignored-in-transitive-dependencies > The short of it is that maven appears to be using the wrong > version in a transitive dependency. There are two > relevant sections in the build, one pulled in by guice > and one pulled in by gwizard-parent. These are the dependency paths from the > top: > gwizard-example -> gwizard-config -> gwizard-parent > gwizard-example -> gwizard-config -> guice -> guice-parent > gwizard-parent's dependencyManagement specifies guava 18 > guice-parent's dependencyManagement specifies guava 16 > Guava 16 is winning. This seems highly undesirable, and in fact it breaks our > build. I would expect that in a version # fight, "closest to the top" should > win. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MRESOLVER-15) Dependency updates.
Christian Schulte created MRESOLVER-15: -- Summary: Dependency updates. Key: MRESOLVER-15 URL: https://issues.apache.org/jira/browse/MRESOLVER-15 Project: Maven Resolver Issue Type: Task Reporter: Christian Schulte Assignee: Christian Schulte Priority: Trivial Fix For: Maven Artifact Resolver 1.2.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (MRESOLVER-15) Dependency updates.
[ https://issues.apache.org/jira/browse/MRESOLVER-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schulte closed MRESOLVER-15. -- Resolution: Fixed > Dependency updates. > --- > > Key: MRESOLVER-15 > URL: https://issues.apache.org/jira/browse/MRESOLVER-15 > Project: Maven Resolver > Issue Type: Task >Reporter: Christian Schulte >Assignee: Christian Schulte >Priority: Trivial > Fix For: Maven Artifact Resolver 1.2.0 > > > This issue gathers all commits changing dependency versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MRESOLVER-15) Dependency updates.
[ https://issues.apache.org/jira/browse/MRESOLVER-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schulte updated MRESOLVER-15: --- Description: This issue gathers all commits changing dependency versions. > Dependency updates. > --- > > Key: MRESOLVER-15 > URL: https://issues.apache.org/jira/browse/MRESOLVER-15 > Project: Maven Resolver > Issue Type: Task >Reporter: Christian Schulte >Assignee: Christian Schulte >Priority: Trivial > Fix For: Maven Artifact Resolver 1.2.0 > > > This issue gathers all commits changing dependency versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MRESOLVER-15) Dependency updates.
[ https://issues.apache.org/jira/browse/MRESOLVER-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766267#comment-15766267 ] Hudson commented on MRESOLVER-15: - SUCCESS: Integrated in Jenkins build maven-resolver #30 (See [https://builds.apache.org/job/maven-resolver/30/]) [MRESOLVER-15] Dependency updates. (schulte: rev c888bce75f9670c515e772dea124081b33d4c974) * (edit) maven-resolver-transport-http/pom.xml * (edit) pom.xml > Dependency updates. > --- > > Key: MRESOLVER-15 > URL: https://issues.apache.org/jira/browse/MRESOLVER-15 > Project: Maven Resolver > Issue Type: Task >Reporter: Christian Schulte >Assignee: Christian Schulte >Priority: Trivial > Fix For: Maven Artifact Resolver 1.2.0 > > > This issue gathers all commits changing dependency versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (MNG-6023) Upgrade of slf4j-simple to a version later than 1.7.16 blocked by upstream issue.
[
https://issues.apache.org/jira/browse/MNG-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schulte closed MNG-6023.
--
Resolution: Fixed
Fix Version/s: 3.4.0
> Upgrade of slf4j-simple to a version later than 1.7.16 blocked by upstream
> issue.
> -
>
> Key: MNG-6023
> URL: https://issues.apache.org/jira/browse/MNG-6023
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.4.0
>Reporter: Michael Osipov
>Assignee: Christian Schulte
>Priority: Blocker
> Fix For: 3.4.0
>
>
> In
> [ce580ea2fafd7638ee56e1d0574de95a37164322|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=ce580ea2fafd7638ee56e1d0574de95a37164322]
> SLF4J was updated from 1.7.16 to 1.7.21. Use a snapshot of that commit and
> run {{mvn -X}} and see that no debug output is printed. Something is either
> broken in our code now or in SLF4J Simple.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-6023) Upgrade of slf4j-simple to a version later than 1.7.16 blocked by upstream issue.
[
https://issues.apache.org/jira/browse/MNG-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766290#comment-15766290
]
Hudson commented on MNG-6023:
-
SUCCESS: Integrated in Jenkins build maven-3.x #1469 (See
[https://builds.apache.org/job/maven-3.x/1469/])
[MNG-6023] Upgrade of slf4j-simple to a version later than 1.7.16 (schulte: rev
fe42dac2601ae26116b935e8c0916be6a79c1e67)
* (edit) pom.xml
> Upgrade of slf4j-simple to a version later than 1.7.16 blocked by upstream
> issue.
> -
>
> Key: MNG-6023
> URL: https://issues.apache.org/jira/browse/MNG-6023
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.4.0
>Reporter: Michael Osipov
>Assignee: Christian Schulte
>Priority: Blocker
> Fix For: 3.4.0
>
>
> In
> [ce580ea2fafd7638ee56e1d0574de95a37164322|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=ce580ea2fafd7638ee56e1d0574de95a37164322]
> SLF4J was updated from 1.7.16 to 1.7.21. Use a snapshot of that commit and
> run {{mvn -X}} and see that no debug output is printed. Something is either
> broken in our code now or in SLF4J Simple.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
