[jira] [Commented] (MNG-5998) Can not use external xml file referenced from settings.xml
[ https://issues.apache.org/jira/browse/MNG-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621494#comment-15621494 ] Lulseged Zerfu commented on MNG-5998: - Hi We are now using -s option to point out location of our settings.xml file. BR Lulseged > Can not use external xml file referenced from settings.xml > -- > > Key: MNG-5998 > URL: https://issues.apache.org/jira/browse/MNG-5998 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.3.9 >Reporter: Lulseged Zerfu > > Hi > I am trying to use DOCTYPE inside settings.zml file and I always get: > [FATAL] Non-parseable settings /home//.m2/settings.xml. > Mt settings.xml file looks like: > > "~/.m2/xdms-settings.xml"> > ]> > http://maven.apache.org/SETTINGS/1.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 > http://maven.apache.org/xsd/settings-1.0.0.xsd";> > > &maven-settings; > > I have moved middle parts of settings.xml in to xdms-settings.xml. > Is this not supported? it is at least according to xml standard. > BR > Lulseged -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MNG-5896) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621500#comment-15621500 ] Testo Nakada commented on MNG-5896: --- This issue should be a low hanging fruit to help improve the build time. > Download dependency POMs in parallel > > > Key: MNG-5896 > URL: https://issues.apache.org/jira/browse/MNG-5896 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.3.3 >Reporter: Harald Wellmann > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.3 first downloads the dependency POMs > _sequentially_ and then proceeds downloading the dependency JARs with up to 5 > threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621768#comment-15621768 ] Michael Musgrove commented on SUREFIRE-1265: Thanks Amos. That is a workaround but it forces all maven modules to run with the same setting which is not ideal. Notice also that we do use this approach in our build.sh script: bq. MAVEN_OPTS="$MAVEN_OPTS --upgrade-module-path target/upgrademodulepath --add-modules java.corba --add-exports java.corba/com.sun.corba.se.spi.orb=ALL-UNNAMED --add-exports java.corba/com.sun.corba.se.spi.ior=ALL-UNNAMED --add-exports java.corba/com.sun.corba.se.impl.ior=ALL-UNNAMED" but we would prefer a proper fix. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MNG-5896) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621793#comment-15621793 ] Michael Osipov commented on MNG-5896: - [~hwellmann], can you revise your patch for Maven Resolver? Aether has been imported back to us. I am willing to review your patch and merge it into Maven Resolver 1.2. > Download dependency POMs in parallel > > > Key: MNG-5896 > URL: https://issues.apache.org/jira/browse/MNG-5896 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.3.3 >Reporter: Harald Wellmann > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.3 first downloads the dependency POMs > _sequentially_ and then proceeds downloading the dependency JARs with up to 5 > threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MNG-5896) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-5896: --- Assignee: Michael Osipov > Download dependency POMs in parallel > > > Key: MNG-5896 > URL: https://issues.apache.org/jira/browse/MNG-5896 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.3.3 >Reporter: Harald Wellmann >Assignee: Michael Osipov > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.3 first downloads the dependency POMs > _sequentially_ and then proceeds downloading the dependency JARs with up to 5 > threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621800#comment-15621800
]
Tibor Digana commented on SUREFIRE-1265:
[~mmusgrov]
[~zhfeng]
I absolutely do not understand these jdk9 switches {{--upgrade-module-path}},
{{--add-exports}}, {{--add-modules}}.
Although need to know from you guys correct concept in Surefire, what's going
on, why and what we can do about it.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621800#comment-15621800
]
Tibor Digana edited comment on SUREFIRE-1265 at 10/31/16 10:17 AM:
---
[~mmusgrov]
[~zhfeng]
I absolutely do not understand these jdk9 switches {{upgrade-module-path}},
{{add-exports}}, {{add-modules}}.
Although need to know from you guys correct concept in Surefire, what's going
on, why and what we can do about it.
was (Author: tibor17):
[~mmusgrov]
[~zhfeng]
I absolutely do not understand these jdk9 switches {{--upgrade-module-path}},
{{--add-exports}}, {{--add-modules}}.
Although need to know from you guys correct concept in Surefire, what's going
on, why and what we can do about it.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-5896) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621955#comment-15621955 ] Harald Wellmann commented on MNG-5896: -- Sure, I've been waiting all the time for Aether to be integrated from Eclipse. Could you give some more details - is Maven Resolver a separate plugin or project, and where do I find it? What would be the Maven target release and the appropriate branch for testing this? > Download dependency POMs in parallel > > > Key: MNG-5896 > URL: https://issues.apache.org/jira/browse/MNG-5896 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.3.3 >Reporter: Harald Wellmann >Assignee: Michael Osipov > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.3 first downloads the dependency POMs > _sequentially_ and then proceeds downloading the dependency JARs with up to 5 > threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MNG-5896) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621977#comment-15621977 ] Michael Osipov commented on MNG-5896: - Maven Resolver is Aether relabled because the brandname 'Aether' belongs to the Eclipse Foundation: https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git It is fully API compatible. I have some improvements myself in MRESOLVER. If you patch is fine, I'd like to push version 1.2 and add it to Maven 3.4. > Download dependency POMs in parallel > > > Key: MNG-5896 > URL: https://issues.apache.org/jira/browse/MNG-5896 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.3.3 >Reporter: Harald Wellmann >Assignee: Michael Osipov > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.3 first downloads the dependency POMs > _sequentially_ and then proceeds downloading the dependency JARs with up to 5 > threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SUREFIRE-1294) "Skipping by Default" how-to has mistake
[
https://issues.apache.org/jira/browse/SUREFIRE-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1294:
--
Assignee: Tibor Digana
> "Skipping by Default" how-to has mistake
>
>
> Key: SUREFIRE-1294
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1294
> Project: Maven Surefire
> Issue Type: Documentation
> Components: Maven Failsafe Plugin
>Affects Versions: 2.19.1
>Reporter: Eduard von Feek
>Assignee: Tibor Digana
>Priority: Minor
> Labels: documentation, easyfix
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Currently states:
> {code}
>
> [...]
>
> true
>
> [...]
>
>
>
> org.apache.maven.plugins
> maven-failsafe-plugin
> 2.19.1
>
> false
>
>
>
>
> [...]
>
> {code}
> but should actually be
> {code}
>
> [...]
>
> true
>
> [...]
>
>
>
> org.apache.maven.plugins
> maven-failsafe-plugin
> 2.19.1
>
> ${skipTests}
>
>
>
>
> [...]
>
> {code}
> Notice {code}${skipTests}{code}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SUREFIRE-1294) "Skipping by Default" how-to has mistake
[
https://issues.apache.org/jira/browse/SUREFIRE-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1294.
--
Resolution: Duplicate
> "Skipping by Default" how-to has mistake
>
>
> Key: SUREFIRE-1294
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1294
> Project: Maven Surefire
> Issue Type: Documentation
> Components: Maven Failsafe Plugin
>Affects Versions: 2.19.1
>Reporter: Eduard von Feek
>Assignee: Tibor Digana
>Priority: Minor
> Labels: documentation, easyfix
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Currently states:
> {code}
>
> [...]
>
> true
>
> [...]
>
>
>
> org.apache.maven.plugins
> maven-failsafe-plugin
> 2.19.1
>
> false
>
>
>
>
> [...]
>
> {code}
> but should actually be
> {code}
>
> [...]
>
> true
>
> [...]
>
>
>
> org.apache.maven.plugins
> maven-failsafe-plugin
> 2.19.1
>
> ${skipTests}
>
>
>
>
> [...]
>
> {code}
> Notice {code}${skipTests}{code}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1287) Improve logging to understand why test run failed and report the right failed category
[ https://issues.apache.org/jira/browse/SUREFIRE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622467#comment-15622467 ] Tibor Digana commented on SUREFIRE-1287: [~giacomotaylor] Have you found failed tests using argLine=-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/ ? May be you will find file hs_err_pid***.log in project dir or child module. > Improve logging to understand why test run failed and report the right failed > category > -- > > Key: SUREFIRE-1287 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1287 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Samarth Jain >Assignee: Tibor Digana > > As part of our automated jenkins builds that run after every checkin, we have > been seeing a lot of these failures: > Failed to execute goal > org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:verify > (ParallelStatsEnabledTest) on project phoenix-core: There was a timeout or > other error in the fork > Sample run: > https://builds.apache.org/job/Phoenix-master/1420/console > Unfortunately that bit of error information doesn't really help. It would be > good to know why exactly the fork timed out or failed. What we do know is > that some of the tests in the Junit category ParallelStatsDisabledTest failed > to complete. However, failsafe incorrectly reports the failed category as the > first category that ran. In this case it happened to be > ParallelStatsEnabledTest. Also to note is the fact that failsafe kicks off > next category run even before all the tests in the current category have > finished. I am not sure if that is by design or a bug. > FYI, [~jamestaylor]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCOMPILER-267) Compiler plugin could have failOnWarning option
[
https://issues.apache.org/jira/browse/MCOMPILER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622469#comment-15622469
]
Matt Nelson commented on MCOMPILER-267:
---
The docs should be updated to correctly report when the {failOnWarning}
property was introduced.
https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#failOnWarning
> Compiler plugin could have failOnWarning option
> ---
>
> Key: MCOMPILER-267
> URL: https://issues.apache.org/jira/browse/MCOMPILER-267
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Reporter: Matthieu Baechler
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.6.0
>
>
> Nobody really reads maven output and warnings are rarely spoted.
> I would like to make sure warning could be treated as errors to stop the
> build and avoid merging code introducing new warnings.
> Could you think it would be an possible addition ?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MCOMPILER-267) Compiler plugin could have failOnWarning option
[
https://issues.apache.org/jira/browse/MCOMPILER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622469#comment-15622469
]
Matt Nelson edited comment on MCOMPILER-267 at 10/31/16 3:42 PM:
-
The docs should be updated to correctly report when the {{failOnWarning}}
property was introduced.
https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#failOnWarning
was (Author: mattnelson):
The docs should be updated to correctly report when the {failOnWarning}
property was introduced.
https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#failOnWarning
> Compiler plugin could have failOnWarning option
> ---
>
> Key: MCOMPILER-267
> URL: https://issues.apache.org/jira/browse/MCOMPILER-267
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Reporter: Matthieu Baechler
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.6.0
>
>
> Nobody really reads maven output and warnings are rarely spoted.
> I would like to make sure warning could be treated as errors to stop the
> build and avoid merging code introducing new warnings.
> Could you think it would be an possible addition ?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MINVOKER-209) ITs fail (on W10) when working directory contains space ?
Alix Lourme created MINVOKER-209:
Summary: ITs fail (on W10) when working directory contains space ?
Key: MINVOKER-209
URL: https://issues.apache.org/jira/browse/MINVOKER-209
Project: Maven Invoker Plugin
Issue Type: Test
Affects Versions: 3.0.0
Environment: Windows 10
Reporter: Alix Lourme
Priority: Minor
When working copy contains some space (common situation on W10 with users
directories Firstname/Lastname), most of ITs fail.
h3. Scenario
Command:
{code}
mvn invoker:run -Dinvoker.test=special-characters-should-work
-Dfile.encoding=UTF-8 -Prun-its,dev
{code}
h4. working directory with spaces
_build.log_ result :
{code}
Running pre-build script: C:\Users\Firstname
Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
Finished pre-build script: C:\Users\Firstname
Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
Erreur : impossible de trouver ou charger la classe principale
Lastname\git\maven-plugins\maven-invoker-plugin\target
{code}
Content of : _DefaultInvoker.executeCommandLine(Commandline,
InvocationRequest)_ (line: ~126)
cmd:
{code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
"maven.repo.local=C:\Users\Firstname
Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s
"C:\Users\Firstname
Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
-D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
{code}
workDir:
{code}
C:\Users\Firstname
Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
{code}
h3. working directory without space
_build.log_ result:
{code}
Running pre-build script:
c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
Finished pre-build script:
c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058;
2016-10-01T18:01:52+02:00)
... next lines are ok : BUILD SUCCESS
{code}
Content of : _DefaultInvoker.executeCommandLine(Commandline,
InvocationRequest)_ (line: ~126)
cmd:
{code}
cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s
C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D
maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
{code}
workDir:
{code}
C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
{code}
I'm not sure of the root cause (invoker initialization or _plexus-utils_
problem :()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MCOMPILER-267) Compiler plugin could have failOnWarning option
[ https://issues.apache.org/jira/browse/MCOMPILER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623120#comment-15623120 ] Robert Scholte commented on MCOMPILER-267: -- In general all @since values are ignored (i.e. use the default 2.0), will fix it. > Compiler plugin could have failOnWarning option > --- > > Key: MCOMPILER-267 > URL: https://issues.apache.org/jira/browse/MCOMPILER-267 > Project: Maven Compiler Plugin > Issue Type: Improvement >Reporter: Matthieu Baechler >Assignee: Robert Scholte >Priority: Minor > Fix For: 3.6.0 > > > Nobody really reads maven output and warnings are rarely spoted. > I would like to make sure warning could be treated as errors to stop the > build and avoid merging code introducing new warnings. > Could you think it would be an possible addition ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MNG-6109) PluginDescriptor doesn't read since value of parameter
Robert Scholte created MNG-6109: --- Summary: PluginDescriptor doesn't read since value of parameter Key: MNG-6109 URL: https://issues.apache.org/jira/browse/MNG-6109 Project: Maven Issue Type: Bug Components: Plugin API Affects Versions: 3.3.9 Reporter: Robert Scholte Assignee: Robert Scholte Fix For: 3.4.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (MNG-6109) PluginDescriptor doesn't read since value of parameter
[ https://issues.apache.org/jira/browse/MNG-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-6109. --- Resolution: Fixed Fixed in [a277f6f43a9b52c17b6aa2af069554edd2b0e42e|http://git-wip-us.apache.org/repos/asf/maven/commit/a277f6f4] > PluginDescriptor doesn't read since value of parameter > -- > > Key: MNG-6109 > URL: https://issues.apache.org/jira/browse/MNG-6109 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.3.9 >Reporter: Robert Scholte >Assignee: Robert Scholte > Fix For: 3.4.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCOMPILER-267) Compiler plugin could have failOnWarning option
[ https://issues.apache.org/jira/browse/MCOMPILER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623220#comment-15623220 ] Robert Scholte commented on MCOMPILER-267: -- MPLUGIN-310 triggered a bug in Maven (MNG-6109), need to think of a nice way to handle this while generating mojo docs. > Compiler plugin could have failOnWarning option > --- > > Key: MCOMPILER-267 > URL: https://issues.apache.org/jira/browse/MCOMPILER-267 > Project: Maven Compiler Plugin > Issue Type: Improvement >Reporter: Matthieu Baechler >Assignee: Robert Scholte >Priority: Minor > Fix For: 3.6.0 > > > Nobody really reads maven output and warnings are rarely spoted. > I would like to make sure warning could be treated as errors to stop the > build and avoid merging code introducing new warnings. > Could you think it would be an possible addition ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MASSEMBLY-833) Ability to ignore errors about no files to package in assembly
[
https://issues.apache.org/jira/browse/MASSEMBLY-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623230#comment-15623230
]
Plamen Totev commented on MASSEMBLY-833:
[~gboue], just to mention that the archivers themselves can add finalizers(and
some of them are adding real not virtual files). For example
{{AbstractArchiver}} adds {{DotDirectiveArchiveFinalizer}} if
{{dotFileDirectory}} is set. {{DotDirectiveArchiveFinalizer#getVirtualFiles}}
returns empty list because it adds real files (directories stored in
{{.plxarc}}) file. So I'm not completely sure if there is reliable method
outside {{AbstractArchiver}} to check if the archive is going to be empty.
Of course since the assembly plugin have quite a lot of control over the
{{Archiver}} configuration I guess it's safe to say there are no added extra
finalizers apart the ones added by the plugin itself. I just wanted to mention
that just in case :)
> Ability to ignore errors about no files to package in assembly
> --
>
> Key: MASSEMBLY-833
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-833
> Project: Maven Assembly Plugin
> Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Martin Vehovský
> Attachments:
> _MASSEMBLY_833__added_ignoreNoFiles_parameter_allowing_not_to_fail_when_there_are_no_files.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Motivation: Having extremely large multi-module project, some modules lets
> call them "application" modules provide "configuration" files, and they
> provide them for different environments. Problem is that not all
> "application" modules provide "configuration" files for all environments. In
> case there are no files available for assembly, the single goal ends up with
> ERROR:
> Failed to
> create assembly: Error creating assembly archive : You must
> set at least one file.
> Available workaround is to specify a property to by default skip the assembly
> execution and only if there are files for given environment set this property
> to not skip the given assembly execution.
> However for large number of environments this solution starts to be messy and
> hard to maintain.
> Do you think that having assembly Parameter "ignoreNoFiles" that will cause
> to skip the archive creation for cases there are no files to package seems
> like reasonable solution?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space
[
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MINVOKER-209:
Summary: ITs fail (on Windows 10) when working directory contains space
(was: ITs fail (on W10) when working directory contains space ?)
> ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
> Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Priority: Minor
> Labels: test-fail, window
>
> When working copy contains some space (common situation on W10 with users
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result :
> {code}
> Running pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> "maven.repo.local=C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s
> "C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
> -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058;
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}
> cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s
> C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D
> maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> I'm not sure of the root cause (invoker initialization or _plexus-utils_
> problem :()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space
[
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623352#comment-15623352
]
Michael Osipov commented on MINVOKER-209:
-
The issue is actually two-fold:
1. Some configuration has not been quoted in the {{pom.xml}}. It has been fixed
with [r1767367|http://svn.apache.org/r1767367].
2. The {{mvn.cmd}} is faulty with Maven 3.3.9. Maven 3.4.0-SNAPSHOT from master
works as expected.
Please verify and I will close as fixed.
> ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
> Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Priority: Minor
> Labels: test-fail, window
>
> When working copy contains some space (common situation on W10 with users
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result :
> {code}
> Running pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> "maven.repo.local=C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s
> "C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
> -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058;
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}
> cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s
> C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D
> maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> I'm not sure of the root cause (invoker initialization or _plexus-utils_
> problem :()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space
[
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MINVOKER-209:
Fix Version/s: 3.0.0
> ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
> Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Assignee: Michael Osipov
>Priority: Minor
> Labels: test-fail, window
> Fix For: 3.0.0
>
>
> When working copy contains some space (common situation on W10 with users
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result :
> {code}
> Running pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> "maven.repo.local=C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s
> "C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
> -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058;
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}
> cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s
> C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D
> maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> I'm not sure of the root cause (invoker initialization or _plexus-utils_
> problem :()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space
[
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MINVOKER-209:
---
Assignee: Michael Osipov
> ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
> Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Assignee: Michael Osipov
>Priority: Minor
> Labels: test-fail, window
> Fix For: 3.0.0
>
>
> When working copy contains some space (common situation on W10 with users
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result :
> {code}
> Running pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> "maven.repo.local=C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s
> "C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
> -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058;
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}
> cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s
> C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D
> maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> I'm not sure of the root cause (invoker initialization or _plexus-utils_
> problem :()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (MRESOLVER-5) Update minimum Java version to 1.7
[ https://issues.apache.org/jira/browse/MRESOLVER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-5. -- Resolution: Fixed Fixed with [10ccd5fdcefcac100c99e9f4e6bf26a96f5cb8ea|https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=10ccd5fdcefcac100c99e9f4e6bf26a96f5cb8ea]. > Update minimum Java version to 1.7 > -- > > Key: MRESOLVER-5 > URL: https://issues.apache.org/jira/browse/MRESOLVER-5 > Project: Maven Resolver > Issue Type: Task >Affects Versions: Maven Artifact Resolver 1.2.0 >Reporter: Michael Osipov >Assignee: Michael Osipov > Fix For: Maven Artifact Resolver 1.2.0 > > > Maven Resolver is highly coupled in Maven 3. Since Maven now requires 1.7, > Resolver as a key component should require it too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MNG-6109) PluginDescriptor doesn't read since value of parameter
[ https://issues.apache.org/jira/browse/MNG-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623406#comment-15623406 ] Hudson commented on MNG-6109: - FAILURE: Integrated in Jenkins build maven-3.x Jigsaw #3 (See [https://builds.apache.org/job/maven-3.x%20Jigsaw/3/]) [MNG-6109] PluginDescriptor doesn't read since value of parameter (rfscholte: rev a277f6f43a9b52c17b6aa2af069554edd2b0e42e) * (edit) maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java * (edit) maven-plugin-api/src/test/resources/plugin.xml * (edit) maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java > PluginDescriptor doesn't read since value of parameter > -- > > Key: MNG-6109 > URL: https://issues.apache.org/jira/browse/MNG-6109 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.3.9 >Reporter: Robert Scholte >Assignee: Robert Scholte > Fix For: 3.4.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept invalid input
[
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-4:
---
Summary: Use java.util.Objects#requireNonNull to intercept invalid input
(was: Use java.util.Objects to intercept invalid input)
> Use java.util.Objects#requireNonNull to intercept invalid input
> ---
>
> Key: MRESOLVER-4
> URL: https://issues.apache.org/jira/browse/MRESOLVER-4
> Project: Maven Resolver
> Issue Type: Improvement
>Affects Versions: Maven Artifact Resolver 1.2.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In several spots of Maven Resolver IAE is thrown where an argument is null.
> This should be turned into NullPointerException since JDK adheres to is and
> the description of this exception indicates that and Effective Java does that
> too.
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
> throw new IllegalArgumentException( "Bad artifact coordinates " +
> coords
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
> throw new IllegalArgumentException( "dependency collection
> request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
> throw new IllegalArgumentException( "repository system session
> not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
> throw new IllegalArgumentException( "deploy request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:
> throw new IllegalArgumentException( "no artifact specified for
> dependency" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
> throw new IllegalArgumentException( "install request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
> throw new IllegalArgumentException( "metadata nature was not
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "repository system session
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
> throw new IllegalArgumentException( "local artifact request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
> throw new IllegalArgumentException( "local metadata request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
> throw new IllegalArgumentException( "repository prototype
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "session not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "event type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescrip
[jira] [Updated] (MRESOLVER-4) Use java.util.Objects to intercept invalid input
[
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-4:
---
Summary: Use java.util.Objects to intercept invalid input (was: Use
Commons Lang's Validate to intercept invalid input)
> Use java.util.Objects to intercept invalid input
>
>
> Key: MRESOLVER-4
> URL: https://issues.apache.org/jira/browse/MRESOLVER-4
> Project: Maven Resolver
> Issue Type: Improvement
>Affects Versions: Maven Artifact Resolver 1.2.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In several spots of Maven Resolver IAE is thrown where an argument is null.
> This should be turned into NullPointerException since JDK adheres to is and
> the description of this exception indicates that and Effective Java does that
> too.
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
> throw new IllegalArgumentException( "Bad artifact coordinates " +
> coords
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
> throw new IllegalArgumentException( "dependency collection
> request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
> throw new IllegalArgumentException( "repository system session
> not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
> throw new IllegalArgumentException( "deploy request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:
> throw new IllegalArgumentException( "no artifact specified for
> dependency" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
> throw new IllegalArgumentException( "install request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
> throw new IllegalArgumentException( "metadata nature was not
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "repository system session
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
> throw new IllegalArgumentException( "local artifact request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
> throw new IllegalArgumentException( "local metadata request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
> throw new IllegalArgumentException( "repository prototype
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "session not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "event type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorResult.java:
> throw new
[jira] [Commented] (MNG-6109) PluginDescriptor doesn't read since value of parameter
[ https://issues.apache.org/jira/browse/MNG-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623418#comment-15623418 ] Hudson commented on MNG-6109: - SUCCESS: Integrated in Jenkins build maven-3.x #1404 (See [https://builds.apache.org/job/maven-3.x/1404/]) [MNG-6109] PluginDescriptor doesn't read since value of parameter (rfscholte: rev a277f6f43a9b52c17b6aa2af069554edd2b0e42e) * (edit) maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java * (edit) maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java * (edit) maven-plugin-api/src/test/resources/plugin.xml > PluginDescriptor doesn't read since value of parameter > -- > > Key: MNG-6109 > URL: https://issues.apache.org/jira/browse/MNG-6109 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.3.9 >Reporter: Robert Scholte >Assignee: Robert Scholte > Fix For: 3.4.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MRESOLVER-5) Update minimum Java version to 1.7
[ https://issues.apache.org/jira/browse/MRESOLVER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623449#comment-15623449 ] Hudson commented on MRESOLVER-5: FAILURE: Integrated in Jenkins build maven-resolver #9 (See [https://builds.apache.org/job/maven-resolver/9/]) [MRESOLVER-5] Update minimum Java version to 1.7 (michaelo: rev 10ccd5fdcefcac100c99e9f4e6bf26a96f5cb8ea) * (edit) pom.xml > Update minimum Java version to 1.7 > -- > > Key: MRESOLVER-5 > URL: https://issues.apache.org/jira/browse/MRESOLVER-5 > Project: Maven Resolver > Issue Type: Task >Affects Versions: Maven Artifact Resolver 1.2.0 >Reporter: Michael Osipov >Assignee: Michael Osipov > Fix For: Maven Artifact Resolver 1.2.0 > > > Maven Resolver is highly coupled in Maven 3. Since Maven now requires 1.7, > Resolver as a key component should require it too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space
[
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623482#comment-15623482
]
Hudson commented on MINVOKER-209:
-
SUCCESS: Integrated in Jenkins build maven-plugins #7400 (See
[https://builds.apache.org/job/maven-plugins/7400/])
[MINVOKER-209] ITs fail (on Windows 10) when working directory contains space
(michaelo: [http://svn.apache.org/viewvc/?view=rev&rev=1767367])
* (edit) maven-invoker-plugin/pom.xml
> ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
> Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Assignee: Michael Osipov
>Priority: Minor
> Labels: test-fail, window
> Fix For: 3.0.0
>
>
> When working copy contains some space (common situation on W10 with users
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result :
> {code}
> Running pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> "maven.repo.local=C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s
> "C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
> -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058;
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}
> cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s
> C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D
> maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> I'm not sure of the root cause (invoker initialization or _plexus-utils_
> problem :()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MRESOLVER-6) Use java.nio.charset.StandardCharsets whereever possible
Michael Osipov created MRESOLVER-6:
--
Summary: Use java.nio.charset.StandardCharsets whereever possible
Key: MRESOLVER-6
URL: https://issues.apache.org/jira/browse/MRESOLVER-6
Project: Maven Resolver
Issue Type: Improvement
Components: resolver
Affects Versions: Aether 1.0.2
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: Maven Artifact Resolver 1.2.0
In many spots a {{UnsupportedEncodingException}} has to be caught because
{{UTF-8}} is passed as string, though this encoding must be supported by every
JVM implementation. So we can use {{StandardCharsets.UTF_8}} and remove
boilerplate code around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MRESOLVER-6) Use java.nio.charset.StandardCharsets wherever possible
[
https://issues.apache.org/jira/browse/MRESOLVER-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-6:
---
Summary: Use java.nio.charset.StandardCharsets wherever possible (was: Use
java.nio.charset.StandardCharsets whereever possible)
> Use java.nio.charset.StandardCharsets wherever possible
> ---
>
> Key: MRESOLVER-6
> URL: https://issues.apache.org/jira/browse/MRESOLVER-6
> Project: Maven Resolver
> Issue Type: Improvement
> Components: resolver
>Affects Versions: Aether 1.0.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In many spots a {{UnsupportedEncodingException}} has to be caught because
> {{UTF-8}} is passed as string, though this encoding must be supported by
> every JVM implementation. So we can use {{StandardCharsets.UTF_8}} and remove
> boilerplate code around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MRESOLVER-6) Use java.nio.charset.StandardCharsets wherever possible
[
https://issues.apache.org/jira/browse/MRESOLVER-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-6:
---
Description: In many spots an {{UnsupportedEncodingException}} has to be
caught because {{UTF-8}} is passed as string, though this encoding must be
supported by every JVM implementation. So we can use {{StandardCharsets.UTF_8}}
and remove boilerplate code around it. (was: In many spots a
{{UnsupportedEncodingException}} has to be caught because {{UTF-8}} is passed
as string, though this encoding must be supported by every JVM implementation.
So we can use {{StandardCharsets.UTF_8}} and remove boilerplate code around it.)
> Use java.nio.charset.StandardCharsets wherever possible
> ---
>
> Key: MRESOLVER-6
> URL: https://issues.apache.org/jira/browse/MRESOLVER-6
> Project: Maven Resolver
> Issue Type: Improvement
> Components: resolver
>Affects Versions: Aether 1.0.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In many spots an {{UnsupportedEncodingException}} has to be caught because
> {{UTF-8}} is passed as string, though this encoding must be supported by
> every JVM implementation. So we can use {{StandardCharsets.UTF_8}} and remove
> boilerplate code around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (MRESOLVER-6) Use java.nio.charset.StandardCharsets wherever possible
[
https://issues.apache.org/jira/browse/MRESOLVER-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MRESOLVER-6.
--
Resolution: Fixed
Fixed with
[b36a2bff2e5ab980495f39e4f1390a376be3b9b4|https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=b36a2bff2e5ab980495f39e4f1390a376be3b9b4].
> Use java.nio.charset.StandardCharsets wherever possible
> ---
>
> Key: MRESOLVER-6
> URL: https://issues.apache.org/jira/browse/MRESOLVER-6
> Project: Maven Resolver
> Issue Type: Improvement
> Components: resolver
>Affects Versions: Aether 1.0.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In many spots an {{UnsupportedEncodingException}} has to be caught because
> {{UTF-8}} is passed as string, though this encoding must be supported by
> every JVM implementation. So we can use {{StandardCharsets.UTF_8}} and remove
> boilerplate code around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MRESOLVER-6) Use java.nio.charset.StandardCharsets wherever possible
[
https://issues.apache.org/jira/browse/MRESOLVER-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623592#comment-15623592
]
Hudson commented on MRESOLVER-6:
SUCCESS: Integrated in Jenkins build maven-resolver #10 (See
[https://builds.apache.org/job/maven-resolver/10/])
[MRESOLVER-6] Use java.nio.charset.StandardCharsets wherever possible
(michaelo: rev b36a2bff2e5ab980495f39e4f1390a376be3b9b4)
* (edit)
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java
* (edit)
maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpServer.java
* (edit)
maven-resolver-transport-wagon/src/test/java/org/eclipse/aether/transport/wagon/MemStreamWagon.java
* (edit)
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestFileUtils.java
* (edit)
maven-resolver-transport-wagon/src/test/java/org/eclipse/aether/transport/wagon/AbstractWagonTransporterTest.java
* (edit)
maven-resolver-transport-wagon/src/test/java/org/eclipse/aether/transport/wagon/MemWagon.java
* (edit)
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/IniArtifactDataReader.java
* (edit)
maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java
* (edit)
maven-resolver-connector-basic/src/test/java/org/eclipse/aether/connector/basic/ChecksumCalculatorTest.java
* (edit)
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/TrackingFileManagerTest.java
* (edit)
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleDigest.java
* (edit)
maven-resolver-transport-file/src/test/java/org/eclipse/aether/transport/file/FileTransporterTest.java
* (edit)
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/PutTask.java
* (edit)
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestFileProcessor.java
* (edit)
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultInstallerTest.java
* (edit)
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/GetTask.java
* (edit)
maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java
* (edit)
maven-resolver-transport-classpath/src/test/java/org/eclipse/aether/transport/classpath/ClasspathTransporterTest.java
* (edit)
maven-resolver-util/src/test/java/org/eclipse/aether/util/ChecksumUtilTest.java
* (edit)
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultFileProcessor.java
* (edit)
maven-resolver-test-util/src/test/java/org/eclipse/aether/internal/test/util/DependencyGraphParserTest.java
* (edit)
maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpTransporterTest.java
> Use java.nio.charset.StandardCharsets wherever possible
> ---
>
> Key: MRESOLVER-6
> URL: https://issues.apache.org/jira/browse/MRESOLVER-6
> Project: Maven Resolver
> Issue Type: Improvement
> Components: resolver
>Affects Versions: Aether 1.0.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In many spots an {{UnsupportedEncodingException}} has to be caught because
> {{UTF-8}} is passed as string, though this encoding must be supported by
> every JVM implementation. So we can use {{StandardCharsets.UTF_8}} and remove
> boilerplate code around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MASSEMBLY-833) Ability to ignore errors about no files to package in assembly
[
https://issues.apache.org/jira/browse/MASSEMBLY-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623820#comment-15623820
]
Guillaume Boué commented on MASSEMBLY-833:
--
[~plamenttv] I was initially thinking that {{DotDirectiveArchiveFinalizer}}
wouldn't be an issue because the plugin doesn't add it, but the user can
configure the archiver dynamically with the {{archiverConfig}} property of the
plugin, and this could contain a {{dotFileDirectory}} (I tested this and it
works fine). Maybe I'm missing a simple solution here, but what's worse is that
{{DotDirectiveArchiveFinalizer}} is ran at the moment the archive is created,
so there's no real good way to know in advance if it's going to add something
to the archive, apart from running a dry-run on a mock archiver (or duplicating
the logic done inside of them, which isn't really an option).
This could be done inside the plugin, but using Reflection since
{{dotFileDirectory}} does not have a getter, and furthermore, it wouldn't be
able to be in sync with update made to archivers. An {{archiver.isEmpty()}}
would be very convenient here, and the archiver itself will also have to do
this work of running the finalizers having a {{finalizeArchiveCreation}} on a
mock to see if they would add anything. I don't see an easier way here, that's
a bit cumbersome... still cleaner than throwing a custom exception though.
Also, wouldn't adding {{isEmpty()}} on the {{Archiver}} interface require a
major version update of Plexus Archiver? It would be a breaking change for
existing implementations. I'll make a GitHub issue tomorrow to ask for their
feedback on this.
> Ability to ignore errors about no files to package in assembly
> --
>
> Key: MASSEMBLY-833
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-833
> Project: Maven Assembly Plugin
> Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Martin Vehovský
> Attachments:
> _MASSEMBLY_833__added_ignoreNoFiles_parameter_allowing_not_to_fail_when_there_are_no_files.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Motivation: Having extremely large multi-module project, some modules lets
> call them "application" modules provide "configuration" files, and they
> provide them for different environments. Problem is that not all
> "application" modules provide "configuration" files for all environments. In
> case there are no files available for assembly, the single goal ends up with
> ERROR:
> Failed to
> create assembly: Error creating assembly archive : You must
> set at least one file.
> Available workaround is to specify a property to by default skip the assembly
> execution and only if there are files for given environment set this property
> to not skip the given assembly execution.
> However for large number of environments this solution starts to be messy and
> hard to maintain.
> Do you think that having assembly Parameter "ignoreNoFiles" that will cause
> to skip the archive creation for cases there are no files to package seems
> like reasonable solution?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space
[
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alix Lourme updated MINVOKER-209:
-
Attachment:
MINVOKER-209-maven-invoker-plugin-IT-double-exec-special-characters-should-work.patch
> ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
> Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Assignee: Michael Osipov
>Priority: Minor
> Labels: test-fail, window
> Fix For: 3.0.0
>
> Attachments:
> MINVOKER-209-maven-invoker-plugin-IT-double-exec-special-characters-should-work.patch
>
>
> When working copy contains some space (common situation on W10 with users
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result :
> {code}
> Running pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> "maven.repo.local=C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s
> "C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
> -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058;
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}
> cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s
> C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D
> maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> I'm not sure of the root cause (invoker initialization or _plexus-utils_
> problem :()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space
[
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623852#comment-15623852
]
Alix Lourme commented on MINVOKER-209:
--
Hi [~michael-o],
I confirm [r1767367|http://svn.apache.org/r1767367] fixes the problem (with
Maven 3.4.0-SNAPSHOT of 2016-10-01 & 2016-10-31).
(Very good catch, I didn't thought at _java.io.tmpdir_ relation :()
Not directly linked to this issue, but quick patch usefull to execute multiple
time
[special-characters-should-work|http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-invoker-plugin/src/it/special-characters-should-work]
without clean :
[^MINVOKER-209-maven-invoker-plugin-IT-double-exec-special-characters-should-work.patch]
(_File.renameTo_ return _false_ if file already exists).
Best regards.
> ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
> Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Assignee: Michael Osipov
>Priority: Minor
> Labels: test-fail, window
> Fix For: 3.0.0
>
> Attachments:
> MINVOKER-209-maven-invoker-plugin-IT-double-exec-special-characters-should-work.patch
>
>
> When working copy contains some space (common situation on W10 with users
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result :
> {code}
> Running pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> "maven.repo.local=C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s
> "C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
> -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script:
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058;
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline,
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}
> cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D
> maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s
> C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D
> maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> I'm not sure of the root cause (invoker initialization or _plexus-utils_
> problem :()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
