[jira] [Commented] (ARCHETYPE-487) Input validation for required properties defined in artifact descriptor
[ https://issues.apache.org/jira/browse/ARCHETYPE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309878#comment-15309878 ] ASF GitHub Bot commented on ARCHETYPE-487: -- Github user michael-o commented on the pull request: https://github.com/apache/maven-archetype/pull/7 @stain I did already in April and wrote how to improve the PR. Nothing has happened. > Input validation for required properties defined in artifact descriptor > --- > > Key: ARCHETYPE-487 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-487 > Project: Maven Archetype > Issue Type: New Feature > Components: Archetypes, Generator, Plugin >Reporter: Manuel Ryan >Priority: Minor > > Add the possibility to define validation regular expressions for required > properties in artifact descriptors. > Use the regular expressions to validate user input (and ask the user to try > again if the expression doesn't match) > here's an example of a property that is required by the archetype to be only > lower case alphabet characters: > --- in archetype-metadata.xml : > > ^[a-z]*$ > > --- at prompt : > Define value for property 'username' (should match expression '^[a-z]*$'): > John > Value does not match the expression, please try again: john > Define value for property... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARCHETYPE-487) Input validation for required properties defined in artifact descriptor
[ https://issues.apache.org/jira/browse/ARCHETYPE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309897#comment-15309897 ] ASF GitHub Bot commented on ARCHETYPE-487: -- Github user mryan43 commented on a diff in the pull request: https://github.com/apache/maven-archetype/pull/7#discussion_r65317792 --- Diff: maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/ArchetypeConfiguration.java --- @@ -19,12 +19,15 @@ * under the License. */ +import org.apache.maven.archetype.common.Constants; +import org.codehaus.plexus.util.StringUtils; --- End diff -- Dropping this breaks compilation... > Input validation for required properties defined in artifact descriptor > --- > > Key: ARCHETYPE-487 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-487 > Project: Maven Archetype > Issue Type: New Feature > Components: Archetypes, Generator, Plugin >Reporter: Manuel Ryan >Priority: Minor > > Add the possibility to define validation regular expressions for required > properties in artifact descriptors. > Use the regular expressions to validate user input (and ask the user to try > again if the expression doesn't match) > here's an example of a property that is required by the archetype to be only > lower case alphabet characters: > --- in archetype-metadata.xml : > > ^[a-z]*$ > > --- at prompt : > Define value for property 'username' (should match expression '^[a-z]*$'): > John > Value does not match the expression, please try again: john > Define value for property... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARCHETYPE-487) Input validation for required properties defined in artifact descriptor
[ https://issues.apache.org/jira/browse/ARCHETYPE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309987#comment-15309987 ] ASF GitHub Bot commented on ARCHETYPE-487: -- Github user mryan43 commented on the pull request: https://github.com/apache/maven-archetype/pull/7 Hi @stain, I have integrated the feedback from @michael-o, let me know if you need anything else. > Input validation for required properties defined in artifact descriptor > --- > > Key: ARCHETYPE-487 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-487 > Project: Maven Archetype > Issue Type: New Feature > Components: Archetypes, Generator, Plugin >Reporter: Manuel Ryan >Priority: Minor > > Add the possibility to define validation regular expressions for required > properties in artifact descriptors. > Use the regular expressions to validate user input (and ask the user to try > again if the expression doesn't match) > here's an example of a property that is required by the archetype to be only > lower case alphabet characters: > --- in archetype-metadata.xml : > > ^[a-z]*$ > > --- at prompt : > Define value for property 'username' (should match expression '^[a-z]*$'): > John > Value does not match the expression, please try again: john > Define value for property... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARCHETYPE-487) Input validation for required properties defined in artifact descriptor
[ https://issues.apache.org/jira/browse/ARCHETYPE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310098#comment-15310098 ] ASF GitHub Bot commented on ARCHETYPE-487: -- Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-archetype/pull/7#discussion_r65337809 --- Diff: maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/ArchetypeConfiguration.java --- @@ -19,12 +19,15 @@ * under the License. */ +import org.apache.maven.archetype.common.Constants; +import org.codehaus.plexus.util.StringUtils; --- End diff -- This is still an unrelated change because those imports are already present a few lines below and have been moved to this position. An unrelated change for me. > Input validation for required properties defined in artifact descriptor > --- > > Key: ARCHETYPE-487 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-487 > Project: Maven Archetype > Issue Type: New Feature > Components: Archetypes, Generator, Plugin >Reporter: Manuel Ryan >Priority: Minor > > Add the possibility to define validation regular expressions for required > properties in artifact descriptors. > Use the regular expressions to validate user input (and ask the user to try > again if the expression doesn't match) > here's an example of a property that is required by the archetype to be only > lower case alphabet characters: > --- in archetype-metadata.xml : > > ^[a-z]*$ > > --- at prompt : > Define value for property 'username' (should match expression '^[a-z]*$'): > John > Value does not match the expression, please try again: john > Define value for property... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARCHETYPE-487) Input validation for required properties defined in artifact descriptor
[ https://issues.apache.org/jira/browse/ARCHETYPE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310144#comment-15310144 ] ASF GitHub Bot commented on ARCHETYPE-487: -- Github user mryan43 commented on a diff in the pull request: https://github.com/apache/maven-archetype/pull/7#discussion_r65342161 --- Diff: maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/ArchetypeConfiguration.java --- @@ -19,12 +19,15 @@ * under the License. */ +import org.apache.maven.archetype.common.Constants; +import org.codehaus.plexus.util.StringUtils; --- End diff -- okay, I'll put it back to the wrong place (it's the only file where the org.* imports are after the java.* imports) > Input validation for required properties defined in artifact descriptor > --- > > Key: ARCHETYPE-487 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-487 > Project: Maven Archetype > Issue Type: New Feature > Components: Archetypes, Generator, Plugin >Reporter: Manuel Ryan >Priority: Minor > > Add the possibility to define validation regular expressions for required > properties in artifact descriptors. > Use the regular expressions to validate user input (and ask the user to try > again if the expression doesn't match) > here's an example of a property that is required by the archetype to be only > lower case alphabet characters: > --- in archetype-metadata.xml : > > ^[a-z]*$ > > --- at prompt : > Define value for property 'username' (should match expression '^[a-z]*$'): > John > Value does not match the expression, please try again: john > Define value for property... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARCHETYPE-487) Input validation for required properties defined in artifact descriptor
[ https://issues.apache.org/jira/browse/ARCHETYPE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310151#comment-15310151 ] ASF GitHub Bot commented on ARCHETYPE-487: -- Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-archetype/pull/7#discussion_r65342854 --- Diff: maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/ArchetypeConfiguration.java --- @@ -19,12 +19,15 @@ * under the License. */ +import org.apache.maven.archetype.common.Constants; +import org.codehaus.plexus.util.StringUtils; --- End diff -- Yes, though it was the right thing to do. It is still unrelated to this PR. Code improvements are always welcome and shall be made with separate PRs. Thank you! > Input validation for required properties defined in artifact descriptor > --- > > Key: ARCHETYPE-487 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-487 > Project: Maven Archetype > Issue Type: New Feature > Components: Archetypes, Generator, Plugin >Reporter: Manuel Ryan >Priority: Minor > > Add the possibility to define validation regular expressions for required > properties in artifact descriptors. > Use the regular expressions to validate user input (and ask the user to try > again if the expression doesn't match) > here's an example of a property that is required by the archetype to be only > lower case alphabet characters: > --- in archetype-metadata.xml : > > ^[a-z]*$ > > --- at prompt : > Define value for property 'username' (should match expression '^[a-z]*$'): > John > Value does not match the expression, please try again: john > Define value for property... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MASSEMBLY-809) Assembly plugin requires precise dependency order when classifier is used
Ondrej Chaloupk created MASSEMBLY-809:
-
Summary: Assembly plugin requires precise dependency order when
classifier is used
Key: MASSEMBLY-809
URL: https://issues.apache.org/jira/browse/MASSEMBLY-809
Project: Maven Assembly Plugin
Issue Type: Bug
Components: dependencySet
Affects Versions: 2.6, 2.5.5
Reporter: Ondrej Chaloupk
Assembly plugin wrongly pack dependencies of project when {{classifier}}
dependencies are defined in random order.
For the plugin pack it in right way it requires ordering dependencies precisely
where dependency without the {{classifier}} is used before the dependency with
it.
If wrong order is used then the result jar seems to contain both dependencies -
with and without classifier. But the file _without classifier_ is not contained
and the content of it is equal to the one _with the classifier_.
For building Narayana project there is used pom.xml with
{code}
org.jboss.narayana.xts
jbossxts
${project.version}
api
org.jboss.narayana.xts
jbossxts
${project.version}
{code}
pom.xml: https://github.com/jbosstm/narayana/blob/master/narayana-full/pom.xml
bin.xml:
https://github.com/jbosstm/narayana/blob/master/narayana-full/src/main/assembly/bin.xml
For this descriptor the content of the result zip file is
{code}
44658 06-01-2016 14:17
narayana-full-5.3.3.Final-SNAPSHOT/lib/xts/jbossxts-api.jar
44658 06-01-2016 14:17
narayana-full-5.3.3.Final-SNAPSHOT/lib/xts/jbossxts.jar
{code}
You can see the artifacts {{jbossxts-api}} and {{jbossxts}} are the same.
If ordering is changed
{code}
org.jboss.narayana.xts
jbossxts
${project.version}
org.jboss.narayana.xts
jbossxts
${project.version}
api
{code}
then the generated zip file contain correct data.
{code}
972473 06-01-2016 14:17
narayana-full-5.3.3.Final-SNAPSHOT/lib/xts/jbossxts.jar
44658 06-01-2016 14:17
narayana-full-5.3.3.Final-SNAPSHOT/lib/xts/jbossxts-api.jar
{code}
_To reproduce:_
# {{git clone g...@github.com:jbosstm/narayana.git}}
# {{cd narayana}}
# {{./build.sh clean install -Pcommunity -DskipTests -Didlj-enabled=true}}
Now you can see
{{unzip -l narayana-full/target/narayana-full-5.*zip | grep xts}}
showing the same file.
Edit {{narayana-full/pom.xml}} to change the place where {{classfier}} is used
for the {{jbossxts}} artifact.
You can do {{cd narayana-full; mvn clean install}} and when you checked the
result zip there will be different content of both jbossxts files.
Discussed at https://issues.jboss.org/browse/JBTM-2679
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ARCHETYPE-487) Input validation for required properties defined in artifact descriptor
[ https://issues.apache.org/jira/browse/ARCHETYPE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310594#comment-15310594 ] ASF GitHub Bot commented on ARCHETYPE-487: -- Github user michael-o commented on the issue: https://github.com/apache/maven-archetype/pull/7 @mryan43 Looks way better now. Please squash, I will test and pull. > Input validation for required properties defined in artifact descriptor > --- > > Key: ARCHETYPE-487 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-487 > Project: Maven Archetype > Issue Type: New Feature > Components: Archetypes, Generator, Plugin >Reporter: Manuel Ryan >Priority: Minor > > Add the possibility to define validation regular expressions for required > properties in artifact descriptors. > Use the regular expressions to validate user input (and ask the user to try > again if the expression doesn't match) > here's an example of a property that is required by the archetype to be only > lower case alphabet characters: > --- in archetype-metadata.xml : > > ^[a-z]*$ > > --- at prompt : > Define value for property 'username' (should match expression '^[a-z]*$'): > John > Value does not match the expression, please try again: john > Define value for property... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MNG-6031) Moving from Maven 3.2.5 or older to Maven 3.3.1 or newer breaks maven-antrun-plugin
[
https://issues.apache.org/jira/browse/MNG-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310745#comment-15310745
]
Christian Schulte commented on MNG-6031:
Can you please test the issue also exists in a recent
[3.4-SNAPSHOT|https://builds.apache.org/view/All/job/maven-3.3-release-status-build/]
build.
> Moving from Maven 3.2.5 or older to Maven 3.3.1 or newer breaks
> maven-antrun-plugin
> ---
>
> Key: MNG-6031
> URL: https://issues.apache.org/jira/browse/MNG-6031
> Project: Maven
> Issue Type: Bug
> Components: Class Loading, core
>Affects Versions: 3.3.3, 3.3.9
> Environment: Windows 7, JDK 1.8.0_51
>Reporter: Andrei Serea
>Priority: Blocker
> Attachments: pom.xml
>
>
> Running with maven-antrun-plugin an ant target that requires SLF4J breaks
> with a NoClassDefFoundError.
> The example attached calls the cobertura-merge ant task and the error is:
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/slf4j/LoggerFactory
> {code}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO]
>
> [INFO] Building Cobertura Merge test 1.12-SNAPSHOT
> [INFO]
>
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cobertura-report ---
> [INFO] Deleting C:\IBXProjects\SUE\git\discovery\src\java\cobertura\target
> [INFO]
> [INFO] --- maven-antrun-plugin:1.8:run (cobertura-merge-base) @
> cobertura-report ---
> [INFO] Executing tasks
> main:
> [cobertura-merge] Cobertura 2.1.1 - GNU GPL License (NO WARRANTY) - See
> COPYRIGHT file
> [cobertura-merge] Exception in thread "main" java.lang.NoClassDefFoundError:
> org/slf4j/LoggerFactory
> [cobertura-merge] at
> net.sourceforge.cobertura.util.CommandLineBuilder.(CommandLineBuilder.java:73)
> [cobertura-merge] at
> net.sourceforge.cobertura.merge.MergeMain.merge(MergeMain.java:66)
> [cobertura-merge] at
> net.sourceforge.cobertura.merge.MergeMain.main(MergeMain.java:77)
> [cobertura-merge] Caused by: java.lang.ClassNotFoundException:
> org.slf4j.LoggerFactory
> [cobertura-merge] at
> java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> [cobertura-merge] at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> [cobertura-merge] at
> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> [cobertura-merge] at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> [cobertura-merge] ... 3 more
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 2.265 s
> [INFO] Finished at: 2016-05-31T18:59:31+03:00
> [INFO] Final Memory: 9M/119M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run (cobertura-merge-base)
> on project cobertura-report: An Ant BuildException has occured: Error running
> reports. See messages above.
> [ERROR] around Ant part ... datafile="C:\...\cobertura\target/cobertura/cobertura.ser">... @ 5:114 in
> C:\..\cobertura\target\antrun\build-main.xml
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> The pom used:
> {code}
>
>xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";
> xmlns="http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
> 4.0.0
>
> 2.1.1
>
> org.tests
> cobertura-report
> 1.12-SNAPSHOT
> Cobertura Merge test
> pom
>
> cobertura-report
>
>
> org.apache.maven.plugins
> maven-antrun-plugin
> 1.8
>
>
> org.slf4j
>
> slf4j-api
> 1.7.5
>
>
