[jira] [Closed] (MNG-5935) Optional true getting lost in managed dependencies when transitive
[ https://issues.apache.org/jira/browse/MNG-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schulte closed MNG-5935. -- Resolution: Fixed Assignee: Christian Schulte Fix Version/s: 3.4.0 > Optional true getting lost in managed dependencies when transitive > -- > > Key: MNG-5935 > URL: https://issues.apache.org/jira/browse/MNG-5935 > Project: Maven > Issue Type: Bug > Components: Dependencies >Affects Versions: 3.3.9 > Environment: Apache Maven 3.3.9 > (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00) > Maven home: C:\Temp\apache-maven-3.3.9 > Java version: 1.8.0_66, vendor: Oracle Corporation > Java home: C:\Prog\Java\v8_66\jre > Default locale: nl_NL, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos" >Reporter: Marcel Schutte >Assignee: Christian Schulte > Fix For: 3.4.0 > > Attachments: Parent.zip, buildoutput.txt > > > Run 'mvn package' on the project in the attached Parent.zip. Note that the > dependency Jar2 gets packaged in WEB-INF/lib and the other dependencies (Jar, > Jar1 and Jar3) do not. > I think the inclusion of Jar2 is incorrect, because project 'Web' declares > its dependency on 'Jar' to be optional and Jar2 being a transitive dependency > of Jar should inherit this. > If you look at the other Jarx dependencies, they have different combinations > of ways to become optional and have their versions managed. Only the case > when optionality is inherited and the dependency management for the version > is in another pom, yields incorrect results. > Please note that I believe the maven-war-plugin is not the cause of this > behavior. I have built and used a modified version of maven-war-plugin which > as the first thing in its WarMojo.execute() lists the result of > getProject().getArtifacts() including the value of each Artifact's > isOptional() method. Already at this point only Jar2 has optional false. > I am using maven-war-plugin in this bug report for the following reasons: > * maven-war-plugin uses the optional flag of dependencies in deciding whether > to package it or not, making this behavior visible > * I don't know of another way to visualize the value of the optional flag in > core maven (running with -X outputs the dependency tree in a section with > header 'Dependency collection stats', but this only shows the scope value) > * maven-dependency-plugin:resolve also only shows scope and not optionality > * obviously, maven-war-plugin is exactly what I intend to use and where I > found the bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MNG-5935) Optional true getting lost in managed dependencies when transitive
[ https://issues.apache.org/jira/browse/MNG-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142419#comment-15142419 ] Hudson commented on MNG-5935: - SUCCESS: Integrated in maven-3.x #1216 (See [https://builds.apache.org/job/maven-3.x/1216/]) [MNG-5935] Optional true getting lost in managed dependencies when (schulte: rev 184f58ff83a6d043c695a07f1b1ae89630f6bc9e) * maven-aether-provider/src/main/java/org/apache/maven/repository/internal/ArtifactDescriptorReaderDelegate.java * maven-core/src/main/java/org/apache/maven/RepositoryUtils.java > Optional true getting lost in managed dependencies when transitive > -- > > Key: MNG-5935 > URL: https://issues.apache.org/jira/browse/MNG-5935 > Project: Maven > Issue Type: Bug > Components: Dependencies >Affects Versions: 3.3.9 > Environment: Apache Maven 3.3.9 > (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00) > Maven home: C:\Temp\apache-maven-3.3.9 > Java version: 1.8.0_66, vendor: Oracle Corporation > Java home: C:\Prog\Java\v8_66\jre > Default locale: nl_NL, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos" >Reporter: Marcel Schutte >Assignee: Christian Schulte > Fix For: 3.4.0 > > Attachments: Parent.zip, buildoutput.txt > > > Run 'mvn package' on the project in the attached Parent.zip. Note that the > dependency Jar2 gets packaged in WEB-INF/lib and the other dependencies (Jar, > Jar1 and Jar3) do not. > I think the inclusion of Jar2 is incorrect, because project 'Web' declares > its dependency on 'Jar' to be optional and Jar2 being a transitive dependency > of Jar should inherit this. > If you look at the other Jarx dependencies, they have different combinations > of ways to become optional and have their versions managed. Only the case > when optionality is inherited and the dependency management for the version > is in another pom, yields incorrect results. > Please note that I believe the maven-war-plugin is not the cause of this > behavior. I have built and used a modified version of maven-war-plugin which > as the first thing in its WarMojo.execute() lists the result of > getProject().getArtifacts() including the value of each Artifact's > isOptional() method. Already at this point only Jar2 has optional false. > I am using maven-war-plugin in this bug report for the following reasons: > * maven-war-plugin uses the optional flag of dependencies in deciding whether > to package it or not, making this behavior visible > * I don't know of another way to visualize the value of the optional flag in > core maven (running with -X outputs the dependency tree in a section with > header 'Dependency collection stats', but this only shows the scope value) > * maven-dependency-plugin:resolve also only shows scope and not optionality > * obviously, maven-war-plugin is exactly what I intend to use and where I > found the bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MNG-5953) build failed
[ https://issues.apache.org/jira/browse/MNG-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142422#comment-15142422 ] Christian Schulte commented on MNG-5953: Thanks for noting. Makes sense, of course. > build failed > > > Key: MNG-5953 > URL: https://issues.apache.org/jira/browse/MNG-5953 > Project: Maven > Issue Type: Bug > Components: Command Line >Affects Versions: 3.3.9 > Environment: OS name: "windows 8.1", version: "6.3", arch: "amd64", > family: "dos" > Java version: 1.8.0_66, vendor: Oracle Corporation >Reporter: Dmitrii Fedin >Assignee: Christian Schulte > Labels: close-pending > > Standart maven 'mvn clean build' execution failed. > Project uses 'net.flexmojos.oss:flexmojos-maven-plugin:7.0.1' build plugin > with custom packaging types. > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 2015-11-10T19:41:47+03:00) > Maven home: c:\java\apache-maven-3.3.9 > Java version: 1.8.0_66, vendor: Oracle Corporation > Java home: c:\java\jdk1.8.0_66\jre > Default locale: en_US, platform encoding: Cp1251 > OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "dos" > [DEBUG] Created new class realm maven.api > [DEBUG] Importing foreign packages into class realm maven.api > [DEBUG] Imported: javax.enterprise.inject.* < plexus.core > [DEBUG] Imported: javax.enterprise.util.* < plexus.core > [DEBUG] Imported: javax.inject.* < plexus.core > [DEBUG] Imported: org.apache.maven.* < plexus.core > [DEBUG] Imported: org.apache.maven.artifact < plexus.core > [DEBUG] Imported: org.apache.maven.classrealm < plexus.core > [DEBUG] Imported: org.apache.maven.cli < plexus.core > [DEBUG] Imported: org.apache.maven.configuration < plexus.core > [DEBUG] Imported: org.apache.maven.exception < plexus.core > [DEBUG] Imported: org.apache.maven.execution < plexus.core > [DEBUG] Imported: org.apache.maven.execution.scope < plexus.core > [DEBUG] Imported: org.apache.maven.lifecycle < plexus.core > [DEBUG] Imported: org.apache.maven.model < plexus.core > [DEBUG] Imported: org.apache.maven.monitor < plexus.core > [DEBUG] Imported: org.apache.maven.plugin < plexus.core > [DEBUG] Imported: org.apache.maven.profiles < plexus.core > [DEBUG] Imported: org.apache.maven.project < plexus.core > [DEBUG] Imported: org.apache.maven.reporting < plexus.core > [DEBUG] Imported: org.apache.maven.repository < plexus.core > [DEBUG] Imported: org.apache.maven.rtinfo < plexus.core > [DEBUG] Imported: org.apache.maven.settings < plexus.core > [DEBUG] Imported: org.apache.maven.toolchain < plexus.core > [DEBUG] Imported: org.apache.maven.usability < plexus.core > [DEBUG] Imported: org.apache.maven.wagon.* < plexus.core > [DEBUG] Imported: org.apache.maven.wagon.authentication < plexus.core > [DEBUG] Imported: org.apache.maven.wagon.authorization < plexus.core > [DEBUG] Imported: org.apache.maven.wagon.events < plexus.core > [DEBUG] Imported: org.apache.maven.wagon.observers < plexus.core > [DEBUG] Imported: org.apache.maven.wagon.proxy < plexus.core > [DEBUG] Imported: org.apache.maven.wagon.repository < plexus.core > [DEBUG] Imported: org.apache.maven.wagon.resource < plexus.core > [DEBUG] Imported: org.codehaus.classworlds < plexus.core > [DEBUG] Imported: org.codehaus.plexus.* < plexus.core > [DEBUG] Imported: org.codehaus.plexus.classworlds < plexus.core > [DEBUG] Imported: org.codehaus.plexus.component < plexus.core > [DEBUG] Imported: org.codehaus.plexus.configuration < plexus.core > [DEBUG] Imported: org.codehaus.plexus.container < plexus.core > [DEBUG] Imported: org.codehaus.plexus.context < plexus.core > [DEBUG] Imported: org.codehaus.plexus.lifecycle < plexus.core > [DEBUG] Imported: org.codehaus.plexus.logging < plexus.core > [DEBUG] Imported: org.codehaus.plexus.personality < plexus.core > [DEBUG] Imported: org.codehaus.plexus.util.xml.Xpp3Dom < plexus.core > [DEBUG] Imported: org.codehaus.plexus.util.xml.pull.XmlPullParser < > plexus.core > [DEBUG] Imported: org.codehaus.plexus.util.xml.pull.XmlPullParserException > < plexus.core > [DEBUG] Imported: org.codehaus.plexus.util.xml.pull.XmlSerializer < > plexus.core > [DEBUG] Imported: org.eclipse.aether.* < plexus.core > [DEBUG] Imported: org.eclipse.aether.artifact < plexus.core > [DEBUG] Imported: org.eclipse.aether.collection < plexus.core > [DEBUG] Imported: org.eclipse.aether.deployment < plexus.core > [DEBUG] Imported: org.eclipse.aether.graph < plexus.core > [DEBUG] Imported: org.eclipse.aether.impl < plexus.core > [DEBUG] Imported: org.eclipse.aether.installation < plexus.core > [DEBUG] Imported: org.eclipse.aether.internal.impl < plexus.core > [DEBUG] Imported: org.eclipse.aether.metadata < plexus.core > [DEBUG] Imported: org.eclipse
[jira] [Commented] (SUREFIRE-1225) Can't run a single parameterized test
[
https://issues.apache.org/jira/browse/SUREFIRE-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142653#comment-15142653
]
Tibor Digana commented on SUREFIRE-1225:
It seems I can close this issue.
> Can't run a single parameterized test
> -
>
> Key: SUREFIRE-1225
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1225
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.19.1
>Reporter: Dmitry Baev
>
> The sample test to reproduce the problem:
> {code:java|title=com/github/baev/MyTest.java}
> @RunWith(Parameterized.class)
> public class MyTest {
> @Parameterized.Parameters
> public static Collection data() {
> return Arrays.asList(
> new Object[]{},
> new Object[]{}
> );
> }
> @Test
> public void testWithParameters() throws Exception {
> }
> }
> {code}
> and then run
> {{clean test -Dtest=com.github.baev.MyTest#testWithParameters}}
> The output is
> {{Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project surefire-base-test-bug: No tests were executed!}}
> Is it expected?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SUREFIRE-1225) Can't run a single parameterized test
[
https://issues.apache.org/jira/browse/SUREFIRE-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1225.
--
Resolution: Not A Problem
Assignee: Tibor Digana
> Can't run a single parameterized test
> -
>
> Key: SUREFIRE-1225
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1225
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.19.1
>Reporter: Dmitry Baev
>Assignee: Tibor Digana
>
> The sample test to reproduce the problem:
> {code:java|title=com/github/baev/MyTest.java}
> @RunWith(Parameterized.class)
> public class MyTest {
> @Parameterized.Parameters
> public static Collection data() {
> return Arrays.asList(
> new Object[]{},
> new Object[]{}
> );
> }
> @Test
> public void testWithParameters() throws Exception {
> }
> }
> {code}
> and then run
> {{clean test -Dtest=com.github.baev.MyTest#testWithParameters}}
> The output is
> {{Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project surefire-base-test-bug: No tests were executed!}}
> Is it expected?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1225) Can't run a single parameterized test
[
https://issues.apache.org/jira/browse/SUREFIRE-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142750#comment-15142750
]
Dmitry Baev commented on SUREFIRE-1225:
---
Ok
> Can't run a single parameterized test
> -
>
> Key: SUREFIRE-1225
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1225
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.19.1
>Reporter: Dmitry Baev
>Assignee: Tibor Digana
>
> The sample test to reproduce the problem:
> {code:java|title=com/github/baev/MyTest.java}
> @RunWith(Parameterized.class)
> public class MyTest {
> @Parameterized.Parameters
> public static Collection data() {
> return Arrays.asList(
> new Object[]{},
> new Object[]{}
> );
> }
> @Test
> public void testWithParameters() throws Exception {
> }
> }
> {code}
> and then run
> {{clean test -Dtest=com.github.baev.MyTest#testWithParameters}}
> The output is
> {{Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project surefire-base-test-bug: No tests were executed!}}
> Is it expected?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MSKINS-124) Update skins when DOXIASITETOOLS-155 has been published
[ https://issues.apache.org/jira/browse/MSKINS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-124: -- Summary: Update skins when DOXIASITETOOLS-155 has been published (was: Update skins when DOXIASITETOOLS-82 has been published) > Update skins when DOXIASITETOOLS-155 has been published > --- > > Key: MSKINS-124 > URL: https://issues.apache.org/jira/browse/MSKINS-124 > Project: Maven Skins > Issue Type: Sub-task > Components: Default Skin, Fluido Skin >Affects Versions: default-1.1, fluido-1.4 >Reporter: Michael Osipov >Assignee: Michael Osipov > Fix For: default-1.2, fluido-1.5 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MSKINS-124) Update skins when DOXIASITETOOLS-82 has been published
Michael Osipov created MSKINS-124: - Summary: Update skins when DOXIASITETOOLS-82 has been published Key: MSKINS-124 URL: https://issues.apache.org/jira/browse/MSKINS-124 Project: Maven Skins Issue Type: Sub-task Components: Default Skin, Fluido Skin Affects Versions: fluido-1.4, default-1.1 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: default-1.2, fluido-1.5 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MSKINS-124) Update skins when DOXIASITETOOLS-155 has been published
[
https://issues.apache.org/jira/browse/MSKINS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSKINS-124:
--
Description:
The decoration model body/head type has changed to string and we can finally
get rid of this ugly thing:
{noformat}
#if ( $decoration.body.head )
#foreach( $item in $decoration.body.head.getChildren() )
## Workaround for DOXIA-150 due to a non-desired behaviour in p-u
## @see org.codehaus.plexus.util.xml.Xpp3Dom#toString()
## @see org.codehaus.plexus.util.xml.Xpp3Dom#toUnescapedString()
#set ( $documentHeader = '' )
#if ( $item.name == "script" )
$StringUtils.replace( $item.toUnescapedString(), $documentHeader, "" )
#else
$StringUtils.replace( $item.toString(), $documentHeader, "" )
#end
#end
#end
{noformat}
and replace it with
{noformat}
#if( $decoration.body.head )
$render.eval( $decoration.body.head )
#end
{noformat}
> Update skins when DOXIASITETOOLS-155 has been published
> ---
>
> Key: MSKINS-124
> URL: https://issues.apache.org/jira/browse/MSKINS-124
> Project: Maven Skins
> Issue Type: Sub-task
> Components: Default Skin, Fluido Skin
>Affects Versions: default-1.1, fluido-1.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: default-1.2, fluido-1.5
>
>
> The decoration model body/head type has changed to string and we can finally
> get rid of this ugly thing:
> {noformat}
> #if ( $decoration.body.head )
> #foreach( $item in $decoration.body.head.getChildren() )
> ## Workaround for DOXIA-150 due to a non-desired behaviour in p-u
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toString()
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toUnescapedString()
> #set ( $documentHeader = '' )
> #if ( $item.name == "script" )
> $StringUtils.replace( $item.toUnescapedString(), $documentHeader,
> "" )
> #else
> $StringUtils.replace( $item.toString(), $documentHeader, "" )
> #end
> #end
> #end
> {noformat}
> and replace it with
> {noformat}
> #if( $decoration.body.head )
> $render.eval( $decoration.body.head )
> #end
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSKINS-124) Update skins when DOXIASITETOOLS-155 has been published
[
https://issues.apache.org/jira/browse/MSKINS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143339#comment-15143339
]
Michael Osipov commented on MSKINS-124:
---
Fixed with [r1729882|http://svn.apache.org/r1729882] for Default Skin.
> Update skins when DOXIASITETOOLS-155 has been published
> ---
>
> Key: MSKINS-124
> URL: https://issues.apache.org/jira/browse/MSKINS-124
> Project: Maven Skins
> Issue Type: Sub-task
> Components: Default Skin, Fluido Skin
>Affects Versions: default-1.1, fluido-1.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: default-1.2, fluido-1.5
>
>
> The decoration model body/head type has changed to string and we can finally
> get rid of this ugly thing:
> {noformat}
> #if ( $decoration.body.head )
> #foreach( $item in $decoration.body.head.getChildren() )
> ## Workaround for DOXIA-150 due to a non-desired behaviour in p-u
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toString()
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toUnescapedString()
> #set ( $documentHeader = '' )
> #if ( $item.name == "script" )
> $StringUtils.replace( $item.toUnescapedString(), $documentHeader,
> "" )
> #else
> $StringUtils.replace( $item.toString(), $documentHeader, "" )
> #end
> #end
> #end
> {noformat}
> and replace it with
> {noformat}
> #if( $decoration.body.head )
> $render.eval( $decoration.body.head )
> #end
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MSKINS-113) Update the documentation accordingly to MSKINS-110
[
https://issues.apache.org/jira/browse/MSKINS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSKINS-113:
--
Component/s: Fluido Skin
> Update the documentation accordingly to MSKINS-110
> --
>
> Key: MSKINS-113
> URL: https://issues.apache.org/jira/browse/MSKINS-113
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: fluido-1.5
>
>
> Update the documentation accordingly to MSKINS-110 change.
> {quote}
> though you missed to change description on the front page, chapter
> "Configuring column class".
> "When using sidebar, the left column used by default span3 class and body
> column use span9." As well as the example which now depicts the default
> values. Makes no sense anymore.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSKINS-124) Update skins when DOXIASITETOOLS-155 has been published
[
https://issues.apache.org/jira/browse/MSKINS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143372#comment-15143372
]
Hudson commented on MSKINS-124:
---
SUCCESS: Integrated in doxia-all #257 (See
[https://builds.apache.org/job/doxia-all/257/])
[MSKINS-124] Update skins when DOXIASITETOOLS-155 has been published (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1729882])
*
./doxia-sitetools/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm
> Update skins when DOXIASITETOOLS-155 has been published
> ---
>
> Key: MSKINS-124
> URL: https://issues.apache.org/jira/browse/MSKINS-124
> Project: Maven Skins
> Issue Type: Sub-task
> Components: Default Skin, Fluido Skin
>Affects Versions: default-1.1, fluido-1.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: default-1.2, fluido-1.5
>
>
> The decoration model body/head type has changed to string and we can finally
> get rid of this ugly thing:
> {noformat}
> #if ( $decoration.body.head )
> #foreach( $item in $decoration.body.head.getChildren() )
> ## Workaround for DOXIA-150 due to a non-desired behaviour in p-u
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toString()
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toUnescapedString()
> #set ( $documentHeader = '' )
> #if ( $item.name == "script" )
> $StringUtils.replace( $item.toUnescapedString(), $documentHeader,
> "" )
> #else
> $StringUtils.replace( $item.toString(), $documentHeader, "" )
> #end
> #end
> #end
> {noformat}
> and replace it with
> {noformat}
> #if( $decoration.body.head )
> $render.eval( $decoration.body.head )
> #end
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DOXIASITETOOLS-155) Change type of decoration model's body/head element to string
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143371#comment-15143371
]
Hudson commented on DOXIASITETOOLS-155:
---
SUCCESS: Integrated in doxia-all #257 (See
[https://builds.apache.org/job/doxia-all/257/])
[MSKINS-124] Update skins when DOXIASITETOOLS-155 has been published (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1729882])
*
./doxia-sitetools/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm
[DOXIASITETOOLS-155] Change type of decoration model's body/head element to
string (michaelo: [http://svn.apache.org/viewvc/?view=rev&rev=1729881])
*
./doxia-sitetools/doxia-decoration-model/src/main/java/org/apache/maven/doxia/site/decoration/inheritance/DefaultDecorationModelInheritanceAssembler.java
* ./doxia-sitetools/doxia-decoration-model/src/main/mdo/decoration.mdo
*
./doxia-sitetools/doxia-decoration-model/src/test/resources/fully-populated-child.xml
*
./doxia-sitetools/doxia-decoration-model/src/test/resources/fully-populated-merged.xml
*
./doxia-sitetools/doxia-decoration-model/src/test/resources/fully-populated-unresolved.xml
* ./doxia-sitetools/doxia-doc-renderer/src/test/resources/site/site.xml
*
./doxia-sitetools/doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/SiteToolTest.java
> Change type of decoration model's body/head element to string
> -
>
> Key: DOXIASITETOOLS-155
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-155
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Decoration model
>Affects Versions: 1.6
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 1.7
>
>
> Currently {{DOM}} type is used for {{project/body/head}} which gives us a
> hard time to render the content in the Velocity templates. Several annoying
> tricks have been applied in the templates but they are rather ugly. Using a
> string makes it possible to wrap everything in {{CDATA}}. This is is already
> done in the {{footer}} element. This might breaks several {{site.xml}} but
> since we haven't released for a long time, people should carefully read the
> release notes anyway.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSKINS-120) Clean up skins for Doxia Sitetools 1.7
[
https://issues.apache.org/jira/browse/MSKINS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143419#comment-15143419
]
Michael Osipov commented on MSKINS-120:
---
Another necessary cleanup fix with [r1729884|http://svn.apache.org/r1729884].
> Clean up skins for Doxia Sitetools 1.7
> --
>
> Key: MSKINS-120
> URL: https://issues.apache.org/jira/browse/MSKINS-120
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Affects Versions: default-1.1, fluido-1.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: default-1.2, fluido-1.5
>
>
> Doxia (Sitetools) 1.7 will introduce many changes. Make sure that skins'
> {{site.vm}} files will reflect that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (MSKINS-124) Update skins when DOXIASITETOOLS-155 has been published
[
https://issues.apache.org/jira/browse/MSKINS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MSKINS-124.
-
Resolution: Fixed
Fixed with [r1729885|http://svn.apache.org/r1729885] for Fluido Skin.
> Update skins when DOXIASITETOOLS-155 has been published
> ---
>
> Key: MSKINS-124
> URL: https://issues.apache.org/jira/browse/MSKINS-124
> Project: Maven Skins
> Issue Type: Sub-task
> Components: Default Skin, Fluido Skin
>Affects Versions: default-1.1, fluido-1.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: default-1.2, fluido-1.5
>
>
> The decoration model body/head type has changed to string and we can finally
> get rid of this ugly thing:
> {noformat}
> #if ( $decoration.body.head )
> #foreach( $item in $decoration.body.head.getChildren() )
> ## Workaround for DOXIA-150 due to a non-desired behaviour in p-u
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toString()
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toUnescapedString()
> #set ( $documentHeader = '' )
> #if ( $item.name == "script" )
> $StringUtils.replace( $item.toUnescapedString(), $documentHeader,
> "" )
> #else
> $StringUtils.replace( $item.toString(), $documentHeader, "" )
> #end
> #end
> #end
> {noformat}
> and replace it with
> {noformat}
> #if( $decoration.body.head )
> $render.eval( $decoration.body.head )
> #end
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (DOXIASITETOOLS-155) Change type of decoration model's body/head element to string
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed DOXIASITETOOLS-155.
-
Resolution: Fixed
Fixed with [r1729881|http://svn.apache.org/r1729881].
> Change type of decoration model's body/head element to string
> -
>
> Key: DOXIASITETOOLS-155
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-155
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Decoration model
>Affects Versions: 1.6
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 1.7
>
>
> Currently {{DOM}} type is used for {{project/body/head}} which gives us a
> hard time to render the content in the Velocity templates. Several annoying
> tricks have been applied in the templates but they are rather ugly. Using a
> string makes it possible to wrap everything in {{CDATA}}. This is is already
> done in the {{footer}} element. This might breaks several {{site.xml}} but
> since we haven't released for a long time, people should carefully read the
> release notes anyway.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DOXIASITETOOLS-155) Change type of decoration model's body/head element to string
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143484#comment-15143484
]
Hudson commented on DOXIASITETOOLS-155:
---
FAILURE: Integrated in maven-skins #239 (See
[https://builds.apache.org/job/maven-skins/239/])
[MSKINS-124] Update skins when DOXIASITETOOLS-155 has been published (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1729885])
* maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
* maven-fluido-skin/src/site/apt/index.apt.vm
> Change type of decoration model's body/head element to string
> -
>
> Key: DOXIASITETOOLS-155
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-155
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Decoration model
>Affects Versions: 1.6
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 1.7
>
>
> Currently {{DOM}} type is used for {{project/body/head}} which gives us a
> hard time to render the content in the Velocity templates. Several annoying
> tricks have been applied in the templates but they are rather ugly. Using a
> string makes it possible to wrap everything in {{CDATA}}. This is is already
> done in the {{footer}} element. This might breaks several {{site.xml}} but
> since we haven't released for a long time, people should carefully read the
> release notes anyway.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSKINS-124) Update skins when DOXIASITETOOLS-155 has been published
[
https://issues.apache.org/jira/browse/MSKINS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143485#comment-15143485
]
Hudson commented on MSKINS-124:
---
FAILURE: Integrated in maven-skins #239 (See
[https://builds.apache.org/job/maven-skins/239/])
[MSKINS-124] Update skins when DOXIASITETOOLS-155 has been published (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1729885])
* maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
* maven-fluido-skin/src/site/apt/index.apt.vm
[MSKINS-120] Clean up skins for Doxia Sitetools 1.7
Revert r1729051 and r1729239 since their make this skin unusable with Site
Plugin 3.4 and 3.5. Else it will be impossible to pass ITs and build the site
due to MSKINS-124. We have to render always with the previous version because
has to run with the supported Site Plugin version only. (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1729884])
* maven-fluido-skin/pom.xml
* maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
* maven-fluido-skin/src/site/site.xml
> Update skins when DOXIASITETOOLS-155 has been published
> ---
>
> Key: MSKINS-124
> URL: https://issues.apache.org/jira/browse/MSKINS-124
> Project: Maven Skins
> Issue Type: Sub-task
> Components: Default Skin, Fluido Skin
>Affects Versions: default-1.1, fluido-1.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: default-1.2, fluido-1.5
>
>
> The decoration model body/head type has changed to string and we can finally
> get rid of this ugly thing:
> {noformat}
> #if ( $decoration.body.head )
> #foreach( $item in $decoration.body.head.getChildren() )
> ## Workaround for DOXIA-150 due to a non-desired behaviour in p-u
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toString()
> ## @see org.codehaus.plexus.util.xml.Xpp3Dom#toUnescapedString()
> #set ( $documentHeader = '' )
> #if ( $item.name == "script" )
> $StringUtils.replace( $item.toUnescapedString(), $documentHeader,
> "" )
> #else
> $StringUtils.replace( $item.toString(), $documentHeader, "" )
> #end
> #end
> #end
> {noformat}
> and replace it with
> {noformat}
> #if( $decoration.body.head )
> $render.eval( $decoration.body.head )
> #end
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSKINS-120) Clean up skins for Doxia Sitetools 1.7
[
https://issues.apache.org/jira/browse/MSKINS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143486#comment-15143486
]
Hudson commented on MSKINS-120:
---
FAILURE: Integrated in maven-skins #239 (See
[https://builds.apache.org/job/maven-skins/239/])
[MSKINS-120] Clean up skins for Doxia Sitetools 1.7
Revert r1729051 and r1729239 since their make this skin unusable with Site
Plugin 3.4 and 3.5. Else it will be impossible to pass ITs and build the site
due to MSKINS-124. We have to render always with the previous version because
has to run with the supported Site Plugin version only. (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1729884])
* maven-fluido-skin/pom.xml
* maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
* maven-fluido-skin/src/site/site.xml
> Clean up skins for Doxia Sitetools 1.7
> --
>
> Key: MSKINS-120
> URL: https://issues.apache.org/jira/browse/MSKINS-120
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Affects Versions: default-1.1, fluido-1.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: default-1.2, fluido-1.5
>
>
> Doxia (Sitetools) 1.7 will introduce many changes. Make sure that skins'
> {{site.vm}} files will reflect that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSKINS-120) Clean up skins for Doxia Sitetools 1.7
[
https://issues.apache.org/jira/browse/MSKINS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143555#comment-15143555
]
Hudson commented on MSKINS-120:
---
SUCCESS: Integrated in maven-skins #240 (See
[https://builds.apache.org/job/maven-skins/240/])
[MSKINS-120] Clean up skins for Doxia Sitetools 1.7
Revert r1729265 to make it usable with Site Plugin 3.4 and 3.5. (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1729893])
* maven-default-skin/pom.xml
> Clean up skins for Doxia Sitetools 1.7
> --
>
> Key: MSKINS-120
> URL: https://issues.apache.org/jira/browse/MSKINS-120
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Affects Versions: default-1.1, fluido-1.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: default-1.2, fluido-1.5
>
>
> Doxia (Sitetools) 1.7 will introduce many changes. Make sure that skins'
> {{site.vm}} files will reflect that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MSITE-767) Revert r1729902 caused by DOXIASITETOOLS-155 and fix ITs as soon as parent POMs and site.xml descriptors have been upgraded
Michael Osipov created MSITE-767: Summary: Revert r1729902 caused by DOXIASITETOOLS-155 and fix ITs as soon as parent POMs and site.xml descriptors have been upgraded Key: MSITE-767 URL: https://issues.apache.org/jira/browse/MSITE-767 Project: Maven Site Plugin Issue Type: Task Components: inheritance Affects Versions: 3.5 Reporter: Michael Osipov DOXIASITETOOLS-155 changed descriptor model attribute which breaks inheritance. Revert the mentioned revision as soon as everything has been upated to Maven Site Plugin 3.5 and Decoration Model 1.7.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DOXIASITETOOLS-155) Change type of decoration model's body/head element to string
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143616#comment-15143616
]
Hudson commented on DOXIASITETOOLS-155:
---
UNSTABLE: Integrated in maven-plugins #5090 (See
[https://builds.apache.org/job/maven-plugins/5090/])
Disable three ITs which fail due to DOXIASITETOOLS-155 for now (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1729902])
* maven-site-plugin/src/it/effective-site/invoker.properties
* maven-site-plugin/src/it/effective-site/verify.groovy
* maven-site-plugin/src/it/full-reporting/invoker.properties
* maven-site-plugin/src/it/full-reporting/verify.groovy
* maven-site-plugin/src/it/site-sd-stagingSiteURL/invoker.properties
* maven-site-plugin/src/it/site-sd-stagingSiteURL/verify.groovy
> Change type of decoration model's body/head element to string
> -
>
> Key: DOXIASITETOOLS-155
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-155
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Decoration model
>Affects Versions: 1.6
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 1.7
>
>
> Currently {{DOM}} type is used for {{project/body/head}} which gives us a
> hard time to render the content in the Velocity templates. Several annoying
> tricks have been applied in the templates but they are rather ugly. Using a
> string makes it possible to wrap everything in {{CDATA}}. This is is already
> done in the {{footer}} element. This might breaks several {{site.xml}} but
> since we haven't released for a long time, people should carefully read the
> release notes anyway.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
