[jira] (MNG-5630) improve display of forked executions
[
https://jira.codehaus.org/browse/MNG-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=346151#comment-346151
]
Michael Osipov edited comment on MNG-5630 at 5/13/14 1:19 AM:
--
Hervé, this might be better, yes. Are you able to produce a real world example
on the Maven master with the changes to visualize the new ouput? That would
ease the discussion.
was (Author: michael-o):
Hervè, this might be better, yes. Are you able to produce a real world example
on the Maven master with the changes to visualize the new ouput? That would
ease the discussion.
> improve display of forked executions
>
>
> Key: MNG-5630
> URL: https://jira.codehaus.org/browse/MNG-5630
> Project: Maven 2 & 3
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.2.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
> Fix For: 3.2.2
>
>
> Currently we have
> {noformat}[INFO]
> [INFO] >>> maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) @
> forked-lifecycle >>>
> [INFO]
> [INFO] <<< maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) @
> forked-lifecycle <<<{noformat}
> it doesn't tell what is the forked goal or phase, which would be useful
> proposed new format in case of phase:
> {noformat}[INFO]
> [INFO] >>> maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) >
> [optional lifecycle]generate-sources @ forked-lifecycle >>>
> [INFO]
> [INFO] <<< maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) <
> [optional lifecycle]generate-sources @ forked-lifecycle <<<{noformat}
> and in case of goal:
> proposed new format in case of phase:
> {noformat}[INFO]
> [INFO] >>> maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) > :goal @
> forked-lifecycle >>>
> [INFO]
> [INFO] <<< maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) < :goal @
> forked-lifecycle <<<{noformat}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MECLIPSE-745) eclipse:clean not deleting all .project and .settings files (for packaging = pom)
[ https://jira.codehaus.org/browse/MECLIPSE-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=345891#comment-345891 ] Tom Helpstone commented on MECLIPSE-745: Well, it does not (re)create the .project and .classpath also. See [MECLIPSE-659|http://jira.codehaus.org/browse/MECLIPSE-659]. -> Eclipse integration does not work for a project with an aggregate. My workaround is to import the project with "Import Maven Projects" with marking _all_ pom.xml's. The result is a eclipse setup with a build path, which includes the library dependencies coming from maven. > eclipse:clean not deleting all .project and .settings files (for packaging = > pom) > - > > Key: MECLIPSE-745 > URL: https://jira.codehaus.org/browse/MECLIPSE-745 > Project: Maven Eclipse Plugin > Issue Type: Bug > Components: M2Eclipse support >Affects Versions: 2.9 > Environment: All >Reporter: Morten Christensen > > Related to MECLIPSE-731, I have found out that both .project and .settings > files are not deleted for pom type maven projects > (packaging>pom). For other kind of maven projects only .settings > files are not deleted currently. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MNG-5633) NullPointerException when project contains cyclic references
[
https://jira.codehaus.org/browse/MNG-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabriel Reid updated MNG-5633:
--
Patch Submitted: Yes
> NullPointerException when project contains cyclic references
>
>
> Key: MNG-5633
> URL: https://jira.codehaus.org/browse/MNG-5633
> Project: Maven 2 & 3
> Issue Type: Bug
>Reporter: Gabriel Reid
> Attachments: MNG-5633.patch
>
>
> Using maven 3.2.1, when a project has a cyclic dependency between modules, a
> NullPointerException is thrown.
> The situation is that there is a root pom that references two modules, a and
> b. Module a is dependent on b, and module b is dependent on a.
> The relevant portions of the poms are as follows:
> root pom
> {code}
>
> 4.0.0
> test
> invalid
> 0.1-SNAPSHOT
> pom
>
> a
> b
>
>
>
>
> test
> a
> ${project.version}
>
>
> test
> b
> ${project.version}
>
>
>
>
> {code}
> a/pom.xml
> {code}
>
> 4.0.0
> test
> a
>
> test
> invalid
> 0.1-SNAPSHOT
>
>
>
> test
> b
>
>
>
> {code}
> a/pom.xml
> {code}
>
> 4.0.0
> test
> b
>
> test
> invalid
> 0.1-SNAPSHOT
>
>
>
> test
> a
>
>
>
> {code}
> Running a simple maven command such as "mvn clean" results in the following:
> {code}
> $ mvn clean
> [INFO] Scanning for projects...
> [ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:167)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:270)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> ... 11 more
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/InternalErrorException
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MNG-5633) NullPointerException when project contains cyclic references
Gabriel Reid created MNG-5633:
-
Summary: NullPointerException when project contains cyclic
references
Key: MNG-5633
URL: https://jira.codehaus.org/browse/MNG-5633
Project: Maven 2 & 3
Issue Type: Bug
Reporter: Gabriel Reid
Using maven 3.2.1, when a project has a cyclic dependency between modules, a
NullPointerException is thrown.
The situation is that there is a root pom that references two modules, a and b.
Module a is dependent on b, and module b is dependent on a.
The relevant portions of the poms are as follows:
root pom
{code}
4.0.0
test
invalid
0.1-SNAPSHOT
pom
a
b
test
a
${project.version}
test
b
${project.version}
{code}
a/pom.xml
{code}
4.0.0
test
a
test
invalid
0.1-SNAPSHOT
test
b
{code}
a/pom.xml
{code}
4.0.0
test
b
test
invalid
0.1-SNAPSHOT
test
a
{code}
Running a simple maven command such as "mvn clean" results in the following:
{code}
$ mvn clean
[INFO] Scanning for projects...
[ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
org.apache.maven.InternalErrorException: Internal error:
java.lang.NullPointerException
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:167)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: java.lang.NullPointerException
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:270)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
... 11 more
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/InternalErrorException
{code}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-335) announcement-mail broken when NOT using the announcementFile parameter
[
https://jira.codehaus.org/browse/MCHANGES-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=345921#comment-345921
]
Guillaume Husta commented on MCHANGES-335:
--
OK thanks.
I did a little test project. (see attachments : test-changes-335.zip)
Here is an extract of the trace :
{quote}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-changes-plugin:2.10:announcement-mail
(default-cli) on project test-changes-335:
Announcement file
D:\Projets\Java\test-mchanges-335\target\announcement\announcement.vm not
found... -> [Help 1]
{quote}
I hope this will help you.
Regards
> announcement-mail broken when NOT using the announcementFile parameter
> --
>
> Key: MCHANGES-335
> URL: https://jira.codehaus.org/browse/MCHANGES-335
> Project: Maven Changes Plugin
> Issue Type: Bug
> Components: announcement
>Affects Versions: 2.10
>Reporter: Guillaume Husta
> Attachments: test-changes-335.zip
>
>
> When using a custom template to generate an announcement, the goal
> _announcement-mail_ will fail if :
> * I provide the parameters _template_ (other than announcement.vm) and
> _templateDirectory_
> * and I don't provide the parameter _announcementFile_
> Trace :
> bq. [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-changes-plugin:2.10:announcement-mail
> (default-cli) on project test-changes-sendmail: Announcement file
> D:\Projets\Workspace_projets_java\test-changes-sendmail\target\announcement\announcement.vm
> not found... -> [Help 1]
> This is a *regression* : it worked with version 2.9
> Related to MCHANGES-280
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MNG-5630) improve display of forked executions
[
https://jira.codehaus.org/browse/MNG-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MNG-5630:
---
Attachment: mvn-Preporting-site.log.zip
here is an output with the modifications
I extracted modified lines too and counted how much fork info lines were less
than 80 columns: before the change, there were only 8 (on 80 fork messages) and
after 0
looking at such stats, I'm not sure the new format will change much things:
we're already largely out of the 80 limit in a lot of fork info messages
and that's without counting other info message, which a often over 80
characters too
WDYT?
> improve display of forked executions
>
>
> Key: MNG-5630
> URL: https://jira.codehaus.org/browse/MNG-5630
> Project: Maven 2 & 3
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.2.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
> Fix For: 3.2.2
>
> Attachments: mvn-Preporting-site.log.zip
>
>
> Currently we have
> {noformat}[INFO]
> [INFO] >>> maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) @
> forked-lifecycle >>>
> [INFO]
> [INFO] <<< maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) @
> forked-lifecycle <<<{noformat}
> it doesn't tell what is the forked goal or phase, which would be useful
> proposed new format in case of phase:
> {noformat}[INFO]
> [INFO] >>> maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) >
> [optional lifecycle]generate-sources @ forked-lifecycle >>>
> [INFO]
> [INFO] <<< maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) <
> [optional lifecycle]generate-sources @ forked-lifecycle <<<{noformat}
> and in case of goal:
> proposed new format in case of phase:
> {noformat}[INFO]
> [INFO] >>> maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) > :goal @
> forked-lifecycle >>>
> [INFO]
> [INFO] <<< maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) < :goal @
> forked-lifecycle <<<{noformat}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MNG-5630) improve display of forked executions
[
https://jira.codehaus.org/browse/MNG-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=346211#comment-346211
]
Paul Benedict commented on MNG-5630:
The output looks good. However, I am inclined to say that there should be a
option/parameter (or logging category) to turn on this level of forking detail.
It's awfully a lot of detail for the default display.
> improve display of forked executions
>
>
> Key: MNG-5630
> URL: https://jira.codehaus.org/browse/MNG-5630
> Project: Maven 2 & 3
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.2.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
> Fix For: 3.2.2
>
> Attachments: mvn-Preporting-site.log.zip
>
>
> Currently we have
> {noformat}[INFO]
> [INFO] >>> maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) @
> forked-lifecycle >>>
> [INFO]
> [INFO] <<< maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) @
> forked-lifecycle <<<{noformat}
> it doesn't tell what is the forked goal or phase, which would be useful
> proposed new format in case of phase:
> {noformat}[INFO]
> [INFO] >>> maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) >
> [optional lifecycle]generate-sources @ forked-lifecycle >>>
> [INFO]
> [INFO] <<< maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) <
> [optional lifecycle]generate-sources @ forked-lifecycle <<<{noformat}
> and in case of goal:
> proposed new format in case of phase:
> {noformat}[INFO]
> [INFO] >>> maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) > :goal @
> forked-lifecycle >>>
> [INFO]
> [INFO] <<< maven-javadoc-plugin:2.9.1:aggregate (report:aggregate) < :goal @
> forked-lifecycle <<<{noformat}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MNG-5633) NullPointerException when project contains cyclic references
[
https://jira.codehaus.org/browse/MNG-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabriel Reid updated MNG-5633:
--
Attachment: MNG-5633.patch
Patch to resolve the issue, by checking for exceptions before making use of the
project dependency graph (which won't exist if there are cyclic dependencies).
This patch doesn't include any test cases, as I wasn't able to figure out
exactly how to test this specific bit of the code, but I all other tests do
pass and I successfully tested a build with this patch on the situation listed
in the description.
> NullPointerException when project contains cyclic references
>
>
> Key: MNG-5633
> URL: https://jira.codehaus.org/browse/MNG-5633
> Project: Maven 2 & 3
> Issue Type: Bug
>Reporter: Gabriel Reid
> Attachments: MNG-5633.patch
>
>
> Using maven 3.2.1, when a project has a cyclic dependency between modules, a
> NullPointerException is thrown.
> The situation is that there is a root pom that references two modules, a and
> b. Module a is dependent on b, and module b is dependent on a.
> The relevant portions of the poms are as follows:
> root pom
> {code}
>
> 4.0.0
> test
> invalid
> 0.1-SNAPSHOT
> pom
>
> a
> b
>
>
>
>
> test
> a
> ${project.version}
>
>
> test
> b
> ${project.version}
>
>
>
>
> {code}
> a/pom.xml
> {code}
>
> 4.0.0
> test
> a
>
> test
> invalid
> 0.1-SNAPSHOT
>
>
>
> test
> b
>
>
>
> {code}
> a/pom.xml
> {code}
>
> 4.0.0
> test
> b
>
> test
> invalid
> 0.1-SNAPSHOT
>
>
>
> test
> a
>
>
>
> {code}
> Running a simple maven command such as "mvn clean" results in the following:
> {code}
> $ mvn clean
> [INFO] Scanning for projects...
> [ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:167)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:270)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> ... 11 more
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/InternalErrorException
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
