[jira] (MNG-4559) MAVEN_OPTS are incorrectly resolved in Unix
[ https://jira.codehaus.org/browse/MNG-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Milos Kleint reopened MNG-4559: --- It appears to be still relevant in 3.0.5 at least. Please refer to this netbeans issue: https://netbeans.org/bugzilla/show_bug.cgi?id=242638 Steps to reproduce: 1. create a simple war project. 2. Download jrebel from http://zeroturnaround.com/software/jrebel/download/ and install it into a path with space 3. set MAVEN_OPTS environment variable to point the jrebel.jar.. eg. MAVEN_OPTS=-javaagent:/Users/mkleint/space in path/jrebel/jrebel.jar How to quote the value is open question here. 4. run mvn jetty:run and see in the output if the java agent got properly integrated. > MAVEN_OPTS are incorrectly resolved in Unix > --- > > Key: MNG-4559 > URL: https://jira.codehaus.org/browse/MNG-4559 > Project: Maven 2 & 3 > Issue Type: Bug >Affects Versions: 2.2.1 > Environment: OS: Linux, 2.6.32-11-generic, amd64. > Java: 1.6.0_17 >Reporter: Maxim Podkolzine > Fix For: Issues to be reviewed for 3.x > > > I'm trying to pass a quoted parameter through MAVEN_OPTS, e.g. > MAVEN_OPTS="-Dfoo='bar baz'" > As a result the quotes are not resolved, causing Java failure: > Exception in thread "main" java.lang.NoClassDefFoundError: baz' > ... > I couldn't figure out a way to make it work. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MNG-4559) MAVEN_OPTS are incorrectly resolved in Unix
[ https://jira.codehaus.org/browse/MNG-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Milos Kleint updated MNG-4559: -- Environment: OS: Linux, 2.6.32-11-generic, amd64. Java: 1.6.0_17 Also Operating System = Mac OS X version 10.9.2 running on x86_64 Java; VM; Vendor = 1.7.0_51 was: OS: Linux, 2.6.32-11-generic, amd64. Java: 1.6.0_17 > MAVEN_OPTS are incorrectly resolved in Unix > --- > > Key: MNG-4559 > URL: https://jira.codehaus.org/browse/MNG-4559 > Project: Maven 2 & 3 > Issue Type: Bug >Affects Versions: 2.2.1, 3.0.5 > Environment: OS: Linux, 2.6.32-11-generic, amd64. > Java: 1.6.0_17 > Also Operating System = Mac OS X version 10.9.2 running on x86_64 > Java; VM; Vendor = 1.7.0_51 >Reporter: Maxim Podkolzine > > I'm trying to pass a quoted parameter through MAVEN_OPTS, e.g. > MAVEN_OPTS="-Dfoo='bar baz'" > As a result the quotes are not resolved, causing Java failure: > Exception in thread "main" java.lang.NoClassDefFoundError: baz' > ... > I couldn't figure out a way to make it work. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MNG-4559) MAVEN_OPTS are incorrectly resolved in Unix
[ https://jira.codehaus.org/browse/MNG-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Milos Kleint updated MNG-4559: -- Fix Version/s: (was: Issues to be reviewed for 3.x) > MAVEN_OPTS are incorrectly resolved in Unix > --- > > Key: MNG-4559 > URL: https://jira.codehaus.org/browse/MNG-4559 > Project: Maven 2 & 3 > Issue Type: Bug >Affects Versions: 2.2.1, 3.0.5 > Environment: OS: Linux, 2.6.32-11-generic, amd64. > Java: 1.6.0_17 >Reporter: Maxim Podkolzine > > I'm trying to pass a quoted parameter through MAVEN_OPTS, e.g. > MAVEN_OPTS="-Dfoo='bar baz'" > As a result the quotes are not resolved, causing Java failure: > Exception in thread "main" java.lang.NoClassDefFoundError: baz' > ... > I couldn't figure out a way to make it work. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MNG-4559) MAVEN_OPTS are incorrectly resolved in Unix
[ https://jira.codehaus.org/browse/MNG-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Milos Kleint updated MNG-4559: -- Affects Version/s: 3.0.5 > MAVEN_OPTS are incorrectly resolved in Unix > --- > > Key: MNG-4559 > URL: https://jira.codehaus.org/browse/MNG-4559 > Project: Maven 2 & 3 > Issue Type: Bug >Affects Versions: 2.2.1, 3.0.5 > Environment: OS: Linux, 2.6.32-11-generic, amd64. > Java: 1.6.0_17 >Reporter: Maxim Podkolzine > > I'm trying to pass a quoted parameter through MAVEN_OPTS, e.g. > MAVEN_OPTS="-Dfoo='bar baz'" > As a result the quotes are not resolved, causing Java failure: > Exception in thread "main" java.lang.NoClassDefFoundError: baz' > ... > I couldn't figure out a way to make it work. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (SCM-740) Maven Release Plugin releases SNAPSHOT instead of STABLE version
[ https://jira.codehaus.org/browse/SCM-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342832#comment-342832 ] Cem Koc commented on SCM-740: - Please vote this issue... > Maven Release Plugin releases SNAPSHOT instead of STABLE version > > > Key: SCM-740 > URL: https://jira.codehaus.org/browse/SCM-740 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-git > Environment: Everywhere with maven-scm-provider-gitexe of version 1.9 > (and maybe older) >Reporter: Jan Novotný > Attachments: Wrong_base_directory_used1.patch > > > If you have following project structure: > - superproject [Git repository root] > - projectA [release target] > - projectB [release target] > in other words you release subproject of a larger Git repository separately, > you probably run at the same issue as we did. No recipe from above mentioned > sources solves your problems and during release:prepare phase still no commit > of stable pom.xml occurs. There is another bug in GitStatusConsumer class > that checks output of the git status --porcelain command and verifies > existency of the mentioned files on local filesystem. Regretfully it uses > working directory instead of git repository root as the base folder and thus > it constructs invalid path to the file where project folder directory is > duplicated. > Problem is better described here: > http://blog.novoj.net/2014/01/24/maven-release-plugin-releases-snapshot-instead-of-stable-version -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MDEP-436) German umlauts in outputDirectory and destFileName getting garbled
Markus KARG created MDEP-436: Summary: German umlauts in outputDirectory and destFileName getting garbled Key: MDEP-436 URL: https://jira.codehaus.org/browse/MDEP-436 Project: Maven Dependency Plugin Issue Type: Bug Components: copy Affects Versions: 2.8 Environment: Win7 Pro SP1 64 Bit, JRE 7, MVN 3.0.4 Reporter: Markus KARG Priority: Critical I am using German umlauts like Ã, à and à in my POM when configuring the outputDirectory and destFileName properties of the copy goal. When the plugin does the actual copy, the directory and file do not contain that umlauts, but instead a strange symbol (encoding garbage). It seems the plugin is unable to deal with German umlauts. While Java definitively IS able to correctly handle it, and while the POM is encoded in UTF-8, it is definitively a bug of a Maven component. As I do not know which component fails here, I am reporting it at the failing plugin, as it is the entry-point for me. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MSCMPUB-13) automaticRemotePathCreation does not create parent directories
Michael Koch created MSCMPUB-13:
---
Summary: automaticRemotePathCreation does not create parent
directories
Key: MSCMPUB-13
URL: https://jira.codehaus.org/browse/MSCMPUB-13
Project: maven-scm-publish-plugin
Issue Type: Bug
Affects Versions: 1.0
Reporter: Michael Koch
Priority: Minor
{{mvn scm-publish:publish-scm
-Dscmpublish.pubScmUrl=scm:svn:.../$\{project.artifactId\}/$\{project.version\}}}
fails if the directory {{$\{project.artifactId\}}} does not exist. This
happens regardless of the {{automaticRemotePathCreation}} setting. Publishing
the site of a new project therefore fails unless the SVN path is created
manually.
The root cause is that maven-scm-provider-svnexe does not add the "--parents"
parameter to the {{svn mkdir}} command. I don't know if this should be
considered a bug of the provider, or if the provider API should be enhanced to
make this configurable.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-292) announcement-generate goal doesn't respect useJql parameter
[
https://jira.codehaus.org/browse/MCHANGES-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated MCHANGES-292:
-
Fix Version/s: 2.10
Assignee: Dennis Lundberg
Summary: announcement-generate goal doesn't respect useJql parameter
(was: announcement-mail goal doesn't respect useJql parameter)
> announcement-generate goal doesn't respect useJql parameter
> ---
>
> Key: MCHANGES-292
> URL: https://jira.codehaus.org/browse/MCHANGES-292
> Project: Maven Changes Plugin
> Issue Type: New Feature
> Components: announcement, jira
>Reporter: Andrew Murdoch
>Assignee: Dennis Lundberg
> Fix For: 2.10
>
> Attachments: jiraCreateAnnounceJql.patch
>
>
> When configured with the useJql parameter such that the changes plugin is
> able to pull a report from JIRA version 5.1 the announcement-mail goal does
> not appear to respect this.
> Executing the goal 'jira-report' generates the correct URL and produces the
> report successfully, however executing the goal 'announcement-mail' fails as
> if useJql is not specified. This may also be true for jiraUser and
> jiraPassword but it cant get that far due to the useJql error.
> Resulting error
> {noformat}
> [ERROR] Error accessing http://jira.hostname.com/browse/PROJECTID
> java.lang.RuntimeException: The issue management URL in the POM does not
> include a pid, and it was not possible to extract it from the page at that
> URL.
> at
> org.apache.maven.plugin.jira.AbstractJiraDownloader.getParameterBasedQueryURL(AbstractJiraDownloader.java:238)
> at
> org.apache.maven.plugin.jira.AbstractJiraDownloader.doExecute(AbstractJiraDownloader.java:147)
> at
> org.apache.maven.plugin.announcement.AnnouncementMojo.getJiraReleases(AnnouncementMojo.java:682)
> at
> org.apache.maven.plugin.announcement.AnnouncementMojo.execute(AnnouncementMojo.java:454)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:365)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:199)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> {noformat}
> Example configuration which causes the issue
> {code:xml}
> true
> jirauserjiraUser>
> jirapwd
> true
>
>addr...@domain.com
>
> hostname
> 25
>
>JIRA
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-292) announcement-generate goal doesn't respect useJql parameter
[
https://jira.codehaus.org/browse/MCHANGES-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg closed MCHANGES-292.
Resolution: Fixed
Fixed in [r1577308|http://svn.apache.org/viewvc?view=revision&revision=1577308].
> announcement-generate goal doesn't respect useJql parameter
> ---
>
> Key: MCHANGES-292
> URL: https://jira.codehaus.org/browse/MCHANGES-292
> Project: Maven Changes Plugin
> Issue Type: New Feature
> Components: announcement, jira
>Reporter: Andrew Murdoch
>Assignee: Dennis Lundberg
> Fix For: 2.10
>
> Attachments: jiraCreateAnnounceJql.patch
>
>
> When configured with the useJql parameter such that the changes plugin is
> able to pull a report from JIRA version 5.1 the announcement-mail goal does
> not appear to respect this.
> Executing the goal 'jira-report' generates the correct URL and produces the
> report successfully, however executing the goal 'announcement-mail' fails as
> if useJql is not specified. This may also be true for jiraUser and
> jiraPassword but it cant get that far due to the useJql error.
> Resulting error
> {noformat}
> [ERROR] Error accessing http://jira.hostname.com/browse/PROJECTID
> java.lang.RuntimeException: The issue management URL in the POM does not
> include a pid, and it was not possible to extract it from the page at that
> URL.
> at
> org.apache.maven.plugin.jira.AbstractJiraDownloader.getParameterBasedQueryURL(AbstractJiraDownloader.java:238)
> at
> org.apache.maven.plugin.jira.AbstractJiraDownloader.doExecute(AbstractJiraDownloader.java:147)
> at
> org.apache.maven.plugin.announcement.AnnouncementMojo.getJiraReleases(AnnouncementMojo.java:682)
> at
> org.apache.maven.plugin.announcement.AnnouncementMojo.execute(AnnouncementMojo.java:454)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:365)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:199)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> {noformat}
> Example configuration which causes the issue
> {code:xml}
> true
> jirauserjiraUser>
> jirapwd
> true
>
>addr...@domain.com
>
> hostname
> 25
>
>JIRA
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-328) Allow setting useJql parameter from the command line
Dennis Lundberg created MCHANGES-328: Summary: Allow setting useJql parameter from the command line Key: MCHANGES-328 URL: https://jira.codehaus.org/browse/MCHANGES-328 Project: Maven Changes Plugin Issue Type: Improvement Components: jira Affects Versions: 2.9 Reporter: Dennis Lundberg -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHANGES-328) Allow setting useJql parameter from the command line
[ https://jira.codehaus.org/browse/MCHANGES-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed MCHANGES-328. Resolution: Fixed Fix Version/s: 2.10 Assignee: Dennis Lundberg Fixed in [r1577310|http://svn.apache.org/viewvc?view=revision&revision=1577310]. > Allow setting useJql parameter from the command line > > > Key: MCHANGES-328 > URL: https://jira.codehaus.org/browse/MCHANGES-328 > Project: Maven Changes Plugin > Issue Type: Improvement > Components: jira >Affects Versions: 2.9 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 2.10 > > -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHANGES-324) plugin logs into jira, but doesn't seem to make the status request with the session?
[
https://jira.codehaus.org/browse/MCHANGES-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated MCHANGES-324:
-
Component/s: jira
> plugin logs into jira, but doesn't seem to make the status request with the
> session?
>
>
> Key: MCHANGES-324
> URL: https://jira.codehaus.org/browse/MCHANGES-324
> Project: Maven Changes Plugin
> Issue Type: Bug
> Components: jira
>Reporter: Antony Stubbs
>
> After successful login, I end up with:
> {code}
> Nov 11, 2013 5:47:19 PM org.apache.cxf.interceptor.LoggingOutInterceptor
> INFO: Outbound Message
> ---
> ID: 3
> Address: https://x/rest/api/2/status
> Http-Method: GET
> Content-Type: application/json
> Headers: {Accept=[application/json], Content-Type=[application/json]}
> --
> Nov 11, 2013 5:47:19 PM org.apache.cxf.interceptor.LoggingInInterceptor
> INFO: Inbound Message
>
> ID: 3
> Response-Code: 200
> Encoding: UTF-8
> Content-Type: application/json;charset=UTF-8
> Headers: {Cache-Control=[no-cache, no-store, no-transform],
> connection=[keep-alive], Content-Length=[2],
> content-type=[application/json;charset=UTF-8], Date=[Mon, 11 Nov 2013
> 22:47:30 GMT], Server=[nginx],
> Set-Cookie=[atlassian.xsrf.token=B14E-GL73-6FKZ-OP3B|dd19dbabf6f82c59be235929d3f1ee8d9e41fa4a|lout;
> Path=/], Strict-Transport-Security=[max-age=31536;includeSubdomains],
> Vary=[Accept-Encoding], X-AREQUESTID=[1067x34467x1], X-ASEN=[SEN-2356824],
> X-AUSERNAME=[anonymous]}
> Payload: []
> {code}
> Which returns nothing as you can see. I think that may be because it has
> X-AUSERNAME=[anonymous] ? Instead of using the session it created...
> After logging into jira in chrome, pasting the just the rest url into the
> browser returns all the different status (works as I'd expect).
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-308) Support filters when using REST API / JQL
[ https://jira.codehaus.org/browse/MCHANGES-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MCHANGES-308: - Component/s: jira > Support filters when using REST API / JQL > - > > Key: MCHANGES-308 > URL: https://jira.codehaus.org/browse/MCHANGES-308 > Project: Maven Changes Plugin > Issue Type: Wish > Components: jira >Affects Versions: 2.8, 2.9 >Reporter: Johannes Odland > Attachments: > MCHANGES-308__Support_filters_when_using_REST_API___JQL.patch > > > The original JiraDownloader supported a custom filter for downloading issues. > After migrating to REST, the > JiraDownloader/ClassicDownloader/RestJiraDownloader does not support this > filter. > Can you reintroduce support for custom filter? -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHANGES-309) RestJiraDownloader does not handle explicit JSON null values
[
https://jira.codehaus.org/browse/MCHANGES-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated MCHANGES-309:
-
Component/s: jira
> RestJiraDownloader does not handle explicit JSON null values
>
>
> Key: MCHANGES-309
> URL: https://jira.codehaus.org/browse/MCHANGES-309
> Project: Maven Changes Plugin
> Issue Type: Bug
> Components: jira
>Affects Versions: 2.9
>Reporter: Johannes Odland
> Attachments:
> MCHANGES-309__RestJiraDownloader_does_not_handle_explicit_JSON_null_values.patch
>
>
> Jira might return explicit null values in its result {'resolution':null}.
> These are converted to explicit NullNodes by jackson.
> In the case of an explicit null value, RestJiraDownloader throws a
> NullPointerException.
> RestJiraDownloader must check both if val != null and !val.isNull().
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-322) Whether the "By" column can be removed from the generated change report when no dev attribute assigned in the changes.xml file
[ https://jira.codehaus.org/browse/MCHANGES-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MCHANGES-322: - Component/s: changes.xml > Whether the "By" column can be removed from the generated change report when > no dev attribute assigned in the changes.xml file > -- > > Key: MCHANGES-322 > URL: https://jira.codehaus.org/browse/MCHANGES-322 > Project: Maven Changes Plugin > Issue Type: Wish > Components: changes.xml >Affects Versions: 2.9 > Environment: maven 3.0.3 > Oracle jdk 1.7.0_21 >Reporter: cluze yu >Priority: Minor > > We work on and release the application as a team in our situation, so these > is not necessary to put the team name in the "dev" attribute in the action > elements, so the elements is similar as this one, date="2013-04-02">Fix something, but the "by" column will still be > generated even the "dev" attribute is omitted, we are not sure whether this > is a bug but we think this can be improved. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-221) ResourceIncludes default value is wrong
[ https://jira.codehaus.org/browse/MCHECKSTYLE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342860#comment-342860 ] Arlo Louis O'Keeffe commented on MCHECKSTYLE-221: - Thanks for acknowledging my issue. Sadly I am still a little confused. Do you mean that the value is supposed to be \*\*/\*.properties? If yes, could you explain why the includes for Java is different? Because If I look at the default value for [includes|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?view=markup#l68] and [resourceIncludes|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?view=markup#l336] they have a different structure. > ResourceIncludes default value is wrong > --- > > Key: MCHECKSTYLE-221 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.11 >Reporter: Arlo Louis O'Keeffe >Assignee: Dennis Lundberg >Priority: Minor > Fix For: 2.12 > > > The default value for resourceIncludes is supposed to be \*\*\/\*.properties > but in fact it is \*\*/\*.properties. > You can verify in the generated maven site: > https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes > An easy workaround is to simply define resourceIncludes yourself. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-221) ResourceIncludes default value is wrong
[ https://jira.codehaus.org/browse/MCHECKSTYLE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342861#comment-342861 ] Dennis Lundberg commented on MCHECKSTYLE-221: - Yes, the value is supposed to be **/*.properties. I have tried it backwards and forwards and the is the correct working value. I cannot explain why the pattern is different for Java files. > ResourceIncludes default value is wrong > --- > > Key: MCHECKSTYLE-221 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.11 >Reporter: Arlo Louis O'Keeffe >Assignee: Dennis Lundberg >Priority: Minor > Fix For: 2.12 > > > The default value for resourceIncludes is supposed to be \*\*\/\*.properties > but in fact it is \*\*/\*.properties. > You can verify in the generated maven site: > https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes > An easy workaround is to simply define resourceIncludes yourself. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHANGES-296) Failed to parse JIRA XML
[ https://jira.codehaus.org/browse/MCHANGES-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342867#comment-342867 ] Dennis Lundberg commented on MCHANGES-296: -- Which command do you type to get this error? mvn changes:jira-report or what? > Failed to parse JIRA XML > > > Key: MCHANGES-296 > URL: https://jira.codehaus.org/browse/MCHANGES-296 > Project: Maven Changes Plugin > Issue Type: Bug > Components: jira >Affects Versions: 2.8 > Environment: JIRA OnDemand >Reporter: Javier A. Ortiz Bultron > > I guess something changed with the API or returned format. > Here's the configuration in the POM: > > JIRA > > https://simple-marauroa.jira.com/BrowseProject.jspa?id=10500 > > And the report configuration: > > org.apache.maven.plugins > maven-changelog-plugin > > true > true > realUser > realPassword > > > And here's what I get: > org.apache.maven.plugin.MojoExecutionException: Failed to parse JIRA XML. > at org.apache.maven.plugin.jira.JiraXML.parse(JiraXML.java:132) > at org.apache.maven.plugin.jira.JiraXML.parseXML(JiraXML.java:108) > at > org.apache.maven.plugin.jira.AbstractJiraDownloader.getIssueList(AbstractJiraDownloader.java:608) > at > org.apache.maven.plugin.jira.JiraMojo.executeReport(JiraMojo.java:356) > at > org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:190) > at > org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:144) > at > org.apache.maven.plugin.changes.AbstractChangesReport.execute(AbstractChangesReport.java:180) > at > org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:569) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:539) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:362) > at > org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:601) > at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) > at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) > at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) > at org.codehaus.classworlds.Launcher.main(Launcher.java:375) > Caused by: org.xml.sax.SAXParseException; lineNumber: 121; columnNumber: 3; > The element type "meta" must be terminated by the matching end-tag "". > at > org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown > Source) > at org.apache.xerces.util.ErrorHandlerWrapper.fatalError(Unknown Source) > at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source) > at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source) > at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source) > at org.apache.xerces.impl.XMLScanner.reportFatalError(Unknown Source) > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(Unknown > Source) > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown > Source) > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown > Source) > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) > at org.
[jira] (MCHANGES-291) Cannot authenticate to Jira OnDemand
[
https://jira.codehaus.org/browse/MCHANGES-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated MCHANGES-291:
-
Patch Submitted: Yes
> Cannot authenticate to Jira OnDemand
>
>
> Key: MCHANGES-291
> URL: https://jira.codehaus.org/browse/MCHANGES-291
> Project: Maven Changes Plugin
> Issue Type: Bug
> Components: jira
>Affects Versions: 2.8
>Reporter: Gary Clayburg
> Attachments: MCHANGES-291.patch
>
>
> This plugin recently stopped working for our project that uses Atlassian Jira
> OnDemand.
> It now appears to fail with this 400 error. I'm thinking this is due to
> recent changes in the way that Jira OnDemand is doing authentication. I get a
> similar error in a browser if the session is not authenticated. Does anyone
> else use Jira OnDemand with this plugin?
> {code}
> $ mvn -f pom_changestest.xml changes:jira-report
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building changes-tests 1.22
> [INFO]
>
> [INFO]
> [INFO] --- maven-changes-plugin:2.8:jira-report (default-cli) @ changes-tests
> ---
> [WARNING] Deprecated API called - not org.apache.maven.doxia.sink.Sink
> instance and no SinkFactory available. Please update this plugin.
> [INFO] Downloading from JIRA at:
> https://urlremoved.jira.com/sr/jira.issueviews:searchrequest-xml/temp/SearchRequest.xml?tempMax=100&reset=true&jqlQuery=project+%3D+OIAM+AND+fixVersion+in+%28%221.0.5%22%29+AND+status+in+%28Closed%29+AND+resolution+in+%28Fixed%29+ORDER+BY+priority+DESC%2C+created+DESC
> [WARNING] Downloading from JIRA failed. Received: [400]
> [WARNING] JIRA file C:\QA\integration-tests\target\jira-results.xml doesn't
> exist.
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 3.340s
> [INFO] Finished at: Fri Oct 05 09:32:48 MDT 2012
> [INFO] Final Memory: 18M/152M
> [INFO]
>
> {code}
> The pom.xml file is this:
> {code}
>
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd";>
> 4.0.0
> com.urlremoved
> changes-tests
> jar
> changes-tests
> 1.22
>
> JIRA
> https://urlremoved.jira.com/browse/OIAM
>
>
> changes-tests
>
>
> org.apache.maven.plugins
> maven-changes-plugin
> 2.8
>
> true
> 1.0.5
> justsomed...@somewhere.com
> EnterRealPasswordHere
>
>
>
>
>
>
>
>
>
>
>
> {code}
> I also notice that even this test is executed in debug mode, it indicates
> that login to Jira succeeded even when an invalid password is supplied:
> {code}
> [WARNING] Deprecated API called - not org.apache.maven.doxia.sink.Sink
> instance and no SinkFactory available. Please update this plugin.
> [DEBUG] Encoding JQL query project = OIAM AND fixVersion in ("1.0.5") AND
> status in (Closed) AND resolution in (Fixed) ORDER BY priority DESC, created
> DESC
> [DEBUG] Encoded JQL query
> project+%3D+OIAM+AND+fixVersion+in+%28%221.0.5%22%29+AND+status+in+%28Closed%29+AND+resolution+in+%28Fixed%29+ORDER+BY+priority+DESC%2C+created+DESC
> [DEBUG] JIRA lives at: https://urlremoved.jira.com
> [DEBUG] Login URL:
> https://urlremoved.jira.com/login.jsp?os_destination=/secure/&os_username=justsomedude%40somewhere.com&os_password=*
> [DEBUG] Successfully logged in into JIRA.
> [DEBUG] download jira issues from url
> https://urlremoved.jira.com/sr/jira.issueviews:searchrequest-xml/temp/SearchRequest.xml?tempMax=100&reset=true&jqlQuery=project+%3D+OIAM+AND+fixVersion+in+%28%221.0.5%22%29+AND+status+in+%28Closed%29+AND+resolution+in+%28Fixed%29+ORDER+BY+priority+DESC%2C+created+DESC
> [INFO] Downloading from JIRA at:
> https://urlremoved.jira.com/sr/jira.issueviews:searchrequest-xml/temp/SearchRequest.xml?tempMax=100&reset=true&jqlQuery=project+%3D+OIAM+AND+fixVersion+in+%28%221.0.5%22%29+AND+status+in+%28Closed%29+AND+resolution+in+%28Fixed%29+ORDER+BY+priority+DESC%2C+created+DESC
> [WARNING] Downloading from JIRA failed. Received: [400]
> {code}
> This issue is related to MCHANGES-285
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-288) JIRA url not fully respected
[
https://jira.codehaus.org/browse/MCHANGES-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated MCHANGES-288:
-
Patch Submitted: Yes
> JIRA url not fully respected
>
>
> Key: MCHANGES-288
> URL: https://jira.codehaus.org/browse/MCHANGES-288
> Project: Maven Changes Plugin
> Issue Type: Bug
> Components: jira
>Affects Versions: 2.8
> Environment: OS XP, maven 3.0.4
>Reporter: Bruno Marti
> Attachments: jiraPreserveContextLogin.patch
>
>
> Issue url is not fully used by maven-changes-plugin:2.8
> have following issue url:
> {quote}
>
> JIRA
> https://my.ch/prod/jira/?pid=1
>
> {quote}
> with changes-plugin:2.7.1 works well:
> {quote}
> [INFO] Generating "JIRA Report" report--- maven-changes-plugin:2.7.1
> [DEBUG] JIRA lives at: https://my.ch/prod/jira
> [DEBUG] Login URL:
> https://my.ch/prod/jira/login.jsp?os_destination=/secure/&os_username=*&os_password=*
> [DEBUG] Successfully logged in into JIRA.
> {quote}
> BUT with changes-plugin:2.8, got error:
> {quote}
> [INFO] Generating "JIRA Report" report--- maven-changes-plugin:2.8
> [DEBUG] JIRA lives at: https://my.ch
> [DEBUG] Login URL:
> https://my.ch/login.jsp?os_destination=/secure/&os_username=*&os_password=*
> [ERROR] Error trying to login into JIRA.
> java.net.SocketException: Connection reset
> {quote}
> Problem is, that the additional context */prod/jira/* gets lost.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-308) Support filters when using REST API / JQL
[ https://jira.codehaus.org/browse/MCHANGES-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MCHANGES-308: - Patch Submitted: Yes > Support filters when using REST API / JQL > - > > Key: MCHANGES-308 > URL: https://jira.codehaus.org/browse/MCHANGES-308 > Project: Maven Changes Plugin > Issue Type: Wish > Components: jira >Affects Versions: 2.8, 2.9 >Reporter: Johannes Odland > Attachments: > MCHANGES-308__Support_filters_when_using_REST_API___JQL.patch > > > The original JiraDownloader supported a custom filter for downloading issues. > After migrating to REST, the > JiraDownloader/ClassicDownloader/RestJiraDownloader does not support this > filter. > Can you reintroduce support for custom filter? -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHANGES-309) RestJiraDownloader does not handle explicit JSON null values
[
https://jira.codehaus.org/browse/MCHANGES-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated MCHANGES-309:
-
Patch Submitted: Yes
> RestJiraDownloader does not handle explicit JSON null values
>
>
> Key: MCHANGES-309
> URL: https://jira.codehaus.org/browse/MCHANGES-309
> Project: Maven Changes Plugin
> Issue Type: Bug
> Components: jira
>Affects Versions: 2.9
>Reporter: Johannes Odland
> Attachments:
> MCHANGES-309__RestJiraDownloader_does_not_handle_explicit_JSON_null_values.patch
>
>
> Jira might return explicit null values in its result {'resolution':null}.
> These are converted to explicit NullNodes by jackson.
> In the case of an explicit null value, RestJiraDownloader throws a
> NullPointerException.
> RestJiraDownloader must check both if val != null and !val.isNull().
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-325) RestJiraDownloader doesn't process issueType
[ https://jira.codehaus.org/browse/MCHANGES-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MCHANGES-325: - Patch Submitted: Yes > RestJiraDownloader doesn't process issueType > > > Key: MCHANGES-325 > URL: https://jira.codehaus.org/browse/MCHANGES-325 > Project: Maven Changes Plugin > Issue Type: Bug > Components: jira >Affects Versions: 2.9 >Reporter: Marshall Schor > Attachments: patch-without-debug-msgs.txt > > > The RestJiraDownloader receives as one of the many fields, the issuetype, but > ignores it. So, although the docs suggest you can have the "Type" field as a > display option, and a sort option (see: > http://maven.apache.org/plugins/maven-changes-plugin/examples/customizing-jira-report.html > scroll to selecting columns), this in fact fails for 2.9 version. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHANGES-280) announcement generation broken in 2.7, possibly by velocity upgrade
[
https://jira.codehaus.org/browse/MCHANGES-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342868#comment-342868
]
Dennis Lundberg commented on MCHANGES-280:
--
Benson, can you remember which configuration you used for this failing example?
> announcement generation broken in 2.7, possibly by velocity upgrade
> ---
>
> Key: MCHANGES-280
> URL: https://jira.codehaus.org/browse/MCHANGES-280
> Project: Maven Changes Plugin
> Issue Type: Bug
> Components: announcement
>Affects Versions: 2.7
>Reporter: Benson Margulies
>
> The following is not good at all:
> {noformat}[INFO] [changes:announcement-generate {execution: default-cli}]
> Apr 30, 2012 4:40:24 PM org.apache.commons.httpclient.HttpMethodBase
> getResponseBody
> WARNING: Going to buffer response body of large or unknown size. Using
> getResponseBodyAsStream instead is recommended.
> [ERROR] maven-changes-plugin: None of the configured sortColumnNames 'null'
> are correct.
> [INFO] Downloading from JIRA at:
> http://jira.codehaus.org/secure/IssueNavigator.jspa?view=rss&pid=11212&statusIds=6&resolutionIds=1&tempMax=1000&reset=true&decorator=none
> [INFO] The JIRA version is '4.4.3'
> [INFO] Including issues from JIRA in announcement...
> [debug] Found 10 releases.
> [ERROR] ResourceManager : unable to find resource
> 'org/apache/maven/plugins/announcement.vm' in any resource loader.
> [INFO]
>
> [ERROR] BUILD ERROR
> [INFO]
>
> [INFO] Resource not found.
> Embedded error: Template not found. (
> org/apache/maven/plugins/announcement.vm )
> [INFO]
>
> [INFO] For more information, run Maven with the -e switch
> [INFO]
>
> [INFO] Total time: 9 seconds
> [INFO] Finished at: Mon Apr 30 16:40:29 EDT 2012
> [INFO] Final Memory: 23M/81M{noformat}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHANGES-280) announcement generation broken in 2.7, possibly by velocity upgrade
[
https://jira.codehaus.org/browse/MCHANGES-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342869#comment-342869
]
Benson Margulies commented on MCHANGES-280:
---
I think I was releasing the release plugin.
> announcement generation broken in 2.7, possibly by velocity upgrade
> ---
>
> Key: MCHANGES-280
> URL: https://jira.codehaus.org/browse/MCHANGES-280
> Project: Maven Changes Plugin
> Issue Type: Bug
> Components: announcement
>Affects Versions: 2.7
>Reporter: Benson Margulies
>
> The following is not good at all:
> {noformat}[INFO] [changes:announcement-generate {execution: default-cli}]
> Apr 30, 2012 4:40:24 PM org.apache.commons.httpclient.HttpMethodBase
> getResponseBody
> WARNING: Going to buffer response body of large or unknown size. Using
> getResponseBodyAsStream instead is recommended.
> [ERROR] maven-changes-plugin: None of the configured sortColumnNames 'null'
> are correct.
> [INFO] Downloading from JIRA at:
> http://jira.codehaus.org/secure/IssueNavigator.jspa?view=rss&pid=11212&statusIds=6&resolutionIds=1&tempMax=1000&reset=true&decorator=none
> [INFO] The JIRA version is '4.4.3'
> [INFO] Including issues from JIRA in announcement...
> [debug] Found 10 releases.
> [ERROR] ResourceManager : unable to find resource
> 'org/apache/maven/plugins/announcement.vm' in any resource loader.
> [INFO]
>
> [ERROR] BUILD ERROR
> [INFO]
>
> [INFO] Resource not found.
> Embedded error: Template not found. (
> org/apache/maven/plugins/announcement.vm )
> [INFO]
>
> [INFO] For more information, run Maven with the -e switch
> [INFO]
>
> [INFO] Total time: 9 seconds
> [INFO] Finished at: Mon Apr 30 16:40:29 EDT 2012
> [INFO] Final Memory: 23M/81M{noformat}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHECKSTYLE-221) ResourceIncludes default value is wrong
[
https://jira.codehaus.org/browse/MCHECKSTYLE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342870#comment-342870
]
Arlo Louis O'Keeffe commented on MCHECKSTYLE-221:
-
You are absolutely right. It is the correct value. Maven file patterns are
influenced by [ant FileSets|http://ant.apache.org/manual/Types/fileset.html]
and the first example explains it perfectly.
I just followed the trail of the includes property and believe that the \ can
be safely removed.
[DefaultCheckstyleExcecutor|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java?view=markup#l557]
passes {{\*\*\/\*.java}} to
[org.codehaus.plexus.util.FileUtils.getFiles()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/FileUtils.java#FileUtils.getFiles%28java.io.File%2Cjava.lang.String%2Cjava.lang.String%29]
which uses
[AbstractScanner.setIncludes|http://plexus.codehaus.org/plexus-utils/apidocs/index.html].
There the pattern is converted to {{\*\*//\*.java}} (in the case of a unix
system). This pattern is passed to
[MatchPatterns.from()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/MatchPatterns.java#MatchPatterns.from%28java.lang.String%5B%5D%29]
and ends up in a Tokenizer that uses {{/}} as a separator. The Tokenizer will
ignore the duplicate {{/}} and therefore the \ can be removed.
> ResourceIncludes default value is wrong
> ---
>
> Key: MCHECKSTYLE-221
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
>Affects Versions: 2.11
>Reporter: Arlo Louis O'Keeffe
>Assignee: Dennis Lundberg
>Priority: Minor
> Fix For: 2.12
>
>
> The default value for resourceIncludes is supposed to be \*\*\/\*.properties
> but in fact it is \*\*/\*.properties.
> You can verify in the generated maven site:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes
> An easy workaround is to simply define resourceIncludes yourself.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHECKSTYLE-221) ResourceIncludes default value is wrong
[
https://jira.codehaus.org/browse/MCHECKSTYLE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342870#comment-342870
]
Arlo Louis O'Keeffe edited comment on MCHECKSTYLE-221 at 3/13/14 7:11 PM:
--
You are absolutely right. It is the correct value. Maven file patterns are
influenced by [ant FileSets|http://ant.apache.org/manual/Types/fileset.html]
and the first example explains it perfectly.
I just followed the trail of the includes property and believe that the \ can
be safely removed.
[DefaultCheckstyleExcecutor|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java?view=markup#l557]
passes {{\*\*\/\*.java}} to
[org.codehaus.plexus.util.FileUtils.getFiles()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/FileUtils.java#FileUtils.getFiles%28java.io.File%2Cjava.lang.String%2Cjava.lang.String%29]
which uses
[AbstractScanner.setIncludes|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/AbstractScanner.java#AbstractScanner.setIncludes%28java.lang.String%5B%5D%29].
There the pattern is converted to {{\*\*//\*.java}} (in the case of a unix
system). This pattern is passed to
[MatchPatterns.from()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/MatchPatterns.java#MatchPatterns.from%28java.lang.String%5B%5D%29]
and ends up in a Tokenizer that uses {{/}} as a separator. The Tokenizer will
ignore the duplicate {{/}} and therefore the \ can be removed.
was (Author: arlol):
You are absolutely right. It is the correct value. Maven file patterns are
influenced by [ant FileSets|http://ant.apache.org/manual/Types/fileset.html]
and the first example explains it perfectly.
I just followed the trail of the includes property and believe that the \ can
be safely removed.
[DefaultCheckstyleExcecutor|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java?view=markup#l557]
passes {{\*\*\/\*.java}} to
[org.codehaus.plexus.util.FileUtils.getFiles()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/FileUtils.java#FileUtils.getFiles%28java.io.File%2Cjava.lang.String%2Cjava.lang.String%29]
which uses
[AbstractScanner.setIncludes|http://plexus.codehaus.org/plexus-utils/apidocs/index.html].
There the pattern is converted to {{\*\*//\*.java}} (in the case of a unix
system). This pattern is passed to
[MatchPatterns.from()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/MatchPatterns.java#MatchPatterns.from%28java.lang.String%5B%5D%29]
and ends up in a Tokenizer that uses {{/}} as a separator. The Tokenizer will
ignore the duplicate {{/}} and therefore the \ can be removed.
> ResourceIncludes default value is wrong
> ---
>
> Key: MCHECKSTYLE-221
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
>Affects Versions: 2.11
>Reporter: Arlo Louis O'Keeffe
>Assignee: Dennis Lundberg
>Priority: Minor
> Fix For: 2.12
>
>
> The default value for resourceIncludes is supposed to be \*\*\/\*.properties
> but in fact it is \*\*/\*.properties.
> You can verify in the generated maven site:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes
> An easy workaround is to simply define resourceIncludes yourself.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
