[jira] (MNG-5395) logger name for plugins should not be DefaultMavenPluginManager
[ https://jira.codehaus.org/browse/MNG-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=314802#comment-314802 ] Herve Boutemy commented on MNG-5395: I did a little local fix: the discussion on the global question (logger names, NDC, MDC, coding conventions, actual code state, ...) still need to be done but no need to stay in the actual bogus situation, this fix will be useful to better see the actual code status > logger name for plugins should not be DefaultMavenPluginManager > --- > > Key: MNG-5395 > URL: https://jira.codehaus.org/browse/MNG-5395 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Plugin Requests >Affects Versions: 3.0.4 >Reporter: Herve Boutemy >Assignee: Herve Boutemy > Fix For: 3.1.0 > > > there are discussion about what should be the best name for every logger in > Maven, which hasn't come to a final decision yet. > But waiting for the final choice, actual value is completely wrong: every > plugin uses the same logger that is the logger from DefaultMavenPluginManager > In actual spirit, the value should be the mojo class name -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5396) logger name for execution events should not be MavenCli
Herve Boutemy created MNG-5396: -- Summary: logger name for execution events should not be MavenCli Key: MNG-5396 URL: https://jira.codehaus.org/browse/MNG-5396 Project: Maven 2 & 3 Issue Type: Bug Components: Logging Affects Versions: 3.0.4 Reporter: Herve Boutemy actually, a lot of Maven output is done with MavenCli logger even 3 times the code executed is not in MavenCli. See the MavenCli code: 1. CLIReportingUtils.showErrors 2. ExecutionEventLogger 3. getBatchTransferListener() If it can make sense to have the first one reporting with MavenCli logger name, the 2 formers whould better be with their own logger: this would ease filtering -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5396) logger name for execution events should not be MavenCli
[ https://jira.codehaus.org/browse/MNG-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MNG-5396. -- Resolution: Fixed Fix Version/s: 3.1.0 Assignee: Herve Boutemy fixed in [1062524b| http://git-wip-us.apache.org/repos/asf/maven/commit/1062524b] > logger name for execution events should not be MavenCli > --- > > Key: MNG-5396 > URL: https://jira.codehaus.org/browse/MNG-5396 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Logging >Affects Versions: 3.0.4 >Reporter: Herve Boutemy >Assignee: Herve Boutemy > Fix For: 3.1.0 > > > actually, a lot of Maven output is done with MavenCli logger even 3 times the > code executed is not in MavenCli. See the MavenCli code: > 1. CLIReportingUtils.showErrors > 2. ExecutionEventLogger > 3. getBatchTransferListener() > If it can make sense to have the first one reporting with MavenCli logger > name, the 2 formers whould better be with their own logger: this would ease > filtering -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5397) Use SLF4J for logging
Herve Boutemy created MNG-5397: -- Summary: Use SLF4J for logging Key: MNG-5397 URL: https://jira.codehaus.org/browse/MNG-5397 Project: Maven 2 & 3 Issue Type: New Feature Components: Logging Affects Versions: 3.0.4 Reporter: Herve Boutemy -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5397) Use SLF4J for logging
[ https://jira.codehaus.org/browse/MNG-5397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MNG-5397. -- Resolution: Fixed Fix Version/s: 3.1.0 Assignee: Jason van Zyl done in [r1396842|http://svn.apache.org/viewvc?rev=1396842&view=rev] > Use SLF4J for logging > - > > Key: MNG-5397 > URL: https://jira.codehaus.org/browse/MNG-5397 > Project: Maven 2 & 3 > Issue Type: New Feature > Components: Logging >Affects Versions: 3.0.4 >Reporter: Herve Boutemy >Assignee: Jason van Zyl > Fix For: 3.1.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-787) release:prepare-with-pom fails when suppressCommitBeforeTag is used (SVN)
[
https://jira.codehaus.org/browse/MRELEASE-787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MRELEASE-787.
---
Resolution: Fixed
I found the cause and fixed it in
[r1416042|http://svn.apache.org/viewvc?rev=1416042&view=rev]
This way the release will succeed, but there's one minor afterwards: the
release-pom.xml is still marked as {{added}}, since that's required for the
tagging. I haven't seen the option in [SCM|http://maven.apache.org/scm] for
reverting.
> release:prepare-with-pom fails when suppressCommitBeforeTag is used (SVN)
> -
>
> Key: MRELEASE-787
> URL: https://jira.codehaus.org/browse/MRELEASE-787
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare-with-pom
>Affects Versions: 2.2, 2.3.2
> Environment: Subversion 1.6.12
>Reporter: Brian Albers
>Assignee: Robert Scholte
> Fix For: 2.4
>
> Attachments: MRELEASE-787.diff
>
>
> When running a prepare-with-pom goal, using the suppressCommitBeforeTag
> option causes the removal of the release-pom.xml to fail.
> This is due to the fact that the SVN command to remove the release-pom won't
> complete because the release-pom was never committed. The ultimate error is
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:2.3.2:prepare-with-pom
> (default-cli) on project com.example.project: Cannot remove release POMs from
> SCM
> [ERROR] Provider message:
> [ERROR] The svn command failed.
> [ERROR] Command output:
> [ERROR] svn: Use --force to override this restriction
> [ERROR] svn: 'C:\code\release-pom.xml' has local modifications
> {code}
> When suppressCommitBeforeTag is not used, the SCM operations are:
> # Status
> # Add the release-pom.xml
> # (build)
> # Commit with release version
> # Copy (create the tag)
> # Remove the release-pom.xml
> # Commit with next development version
> When suppressCommitBeforeTag is used, step #4 is omitted, which causes step
> #6 to fail with the supplied error. In both cases, the tag successfully has
> the release-pom.xml included.
> Could the --force option be used to suppress the warning?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-4588) DefaultMavenExecutionRequest - dead store to local variable
[ https://jira.codehaus.org/browse/MNG-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Rosenvold closed MNG-4588. --- Resolution: Fixed Fix Version/s: (was: Issues to be reviewed for 3.x) Assignee: Kristian Rosenvold Fixed somewhere in 3.x ;) > DefaultMavenExecutionRequest - dead store to local variable > --- > > Key: MNG-4588 > URL: https://jira.codehaus.org/browse/MNG-4588 > Project: Maven 2 & 3 > Issue Type: Bug >Affects Versions: 2.2.1 >Reporter: Maciej Szarlinski >Assignee: Kristian Rosenvold >Priority: Minor > > Method setSession(MavenSession session) in DefaultMavenExecutionRequest > assigns parameter to itself, so that variable session can't be changed. It > should be: this.session = session; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5398) scriptSourceDirectory in superpom is not prefixed with ${project.basedir}/
Robert Scholte created MNG-5398:
---
Summary: scriptSourceDirectory in superpom is not prefixed with
${project.basedir}/
Key: MNG-5398
URL: https://jira.codehaus.org/browse/MNG-5398
Project: Maven 2 & 3
Issue Type: Bug
Components: POM
Affects Versions: 3.0.4
Reporter: Robert Scholte
Priority: Minor
Due to this issue the {{release-pom.xml}} (generated by the
{{maven-release-plugin}}) has an absolute path, which makes it system-dependent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5399) Upgrade version of maven-release-plugin in superpom
Robert Scholte created MNG-5399:
---
Summary: Upgrade version of maven-release-plugin in superpom
Key: MNG-5399
URL: https://jira.codehaus.org/browse/MNG-5399
Project: Maven 2 & 3
Issue Type: Improvement
Components: POM
Affects Versions: 3.0.4
Reporter: Robert Scholte
The version is still locked on {{2.0}}. I'd prefer to upgrade this to {{2.3.2}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5399) Upgrade version of maven-release-plugin in superpom to 2.3.2
[
https://jira.codehaus.org/browse/MNG-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte updated MNG-5399:
Summary: Upgrade version of maven-release-plugin in superpom to 2.3.2
(was: Upgrade version of maven-release-plugin in superpom)
> Upgrade version of maven-release-plugin in superpom to 2.3.2
>
>
> Key: MNG-5399
> URL: https://jira.codehaus.org/browse/MNG-5399
> Project: Maven 2 & 3
> Issue Type: Improvement
> Components: POM
>Affects Versions: 3.0.4
>Reporter: Robert Scholte
>
> The version is still locked on {{2.0}}. I'd prefer to upgrade this to
> {{2.3.2}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5399) Upgrade version of maven-release-plugin in superpom to 2.3.2
[
https://jira.codehaus.org/browse/MNG-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MNG-5399.
---
Resolution: Fixed
Fix Version/s: 3.1.0
Assignee: Robert Scholte
Fixed in [http://git-wip-us.apache.org/repos/asf/maven/commit/e052ebaa]
> Upgrade version of maven-release-plugin in superpom to 2.3.2
>
>
> Key: MNG-5399
> URL: https://jira.codehaus.org/browse/MNG-5399
> Project: Maven 2 & 3
> Issue Type: Improvement
> Components: POM
>Affects Versions: 3.0.4
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.1.0
>
>
> The version is still locked on {{2.0}}. I'd prefer to upgrade this to
> {{2.3.2}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5400) Upgrade version of maven-dependency-plugin in superpom to 2.5
Robert Scholte created MNG-5400: --- Summary: Upgrade version of maven-dependency-plugin in superpom to 2.5 Key: MNG-5400 URL: https://jira.codehaus.org/browse/MNG-5400 Project: Maven 2 & 3 Issue Type: Improvement Components: POM Affects Versions: 3.0.4 Reporter: Robert Scholte Priority: Minor -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5398) scriptSourceDirectory in superpom is not prefixed with ${project.basedir}/
[
https://jira.codehaus.org/browse/MNG-5398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MNG-5398.
---
Resolution: Fixed
Fix Version/s: 3.1.0
Assignee: Robert Scholte
Fixed in http://git-wip-us.apache.org/repos/asf/maven/commit/dbef526e
> scriptSourceDirectory in superpom is not prefixed with ${project.basedir}/
> --
>
> Key: MNG-5398
> URL: https://jira.codehaus.org/browse/MNG-5398
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.0.4
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.1.0
>
>
> Due to this issue the {{release-pom.xml}} (generated by the
> {{maven-release-plugin}}) has an absolute path, which makes it
> system-dependent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5400) Upgrade version of maven-dependency-plugin in superpom to 2.5
[ https://jira.codehaus.org/browse/MNG-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-5400. --- Resolution: Fixed Fix Version/s: 3.1.0 Assignee: Robert Scholte Fixed in http://git-wip-us.apache.org/repos/asf/maven/commit/327e1b7e > Upgrade version of maven-dependency-plugin in superpom to 2.5 > - > > Key: MNG-5400 > URL: https://jira.codehaus.org/browse/MNG-5400 > Project: Maven 2 & 3 > Issue Type: Improvement > Components: POM >Affects Versions: 3.0.4 >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Minor > Fix For: 3.1.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MGPG-41) Passphrase revealed when backspacing at prompt
Tony Trinh created MGPG-41:
--
Summary: Passphrase revealed when backspacing at prompt
Key: MGPG-41
URL: https://jira.codehaus.org/browse/MGPG-41
Project: Maven 2.x and 3.x GPG Plugin
Issue Type: Bug
Affects Versions: 1.4
Environment: Mac OS X Mountain Lion
Apache Maven 3.0.3 (r1075438; 2011-02-28 11:31:09-0600)
Maven home: /usr/share/maven
Java version: 1.6.0_37, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: en_US, platform encoding: MacRoman
OS name: "mac os x", version: "10.8.2", arch: "x86_64", family: "mac"
Reporter: Tony Trinh
At the "GPG Passphrase" prompt, if I hit the backspace key during the entry,
the passphrase is printed in cleartext with one less character. For example:
{code}GPG Passphrase: **^R
mysecretpasswor*^R
mysecretpasswo*^R
mysecretpassw*^R
mysecretpass*^R
mysecretpas*^R
mysecretpa*^R
mysecretp*^R
mysecret*^R
mysecre*^R
mysecr*^R
mysec*^R
myse*^R
mys*^R
my*^R
m*^R
*^R
*{code}
This can be fixed by replacing the {{MaskingThread}} with Java 6's built-in
password prompt (as the [code
comment|http://grepcode.com/file/repository.jboss.org/maven2/org.apache.maven.plugins/maven-gpg-plugin/1.0-alpha-4/org/apache/maven/plugin/gpg/GpgSigner.java#217]
had suggested to do):
{code:java}Console console = System.console();
if ( console != null )
{
pass = new String( console.readPassword( "GPG Passphrase: " ) );
}{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
