[jira] (SUREFIRE-873) NPE in DefaultArtifactResolver.java:312

2012-05-27 Thread Rodionov Andrey (JIRA)
Rodionov Andrey created SUREFIRE-873:


 Summary: NPE in DefaultArtifactResolver.java:312
 Key: SUREFIRE-873
 URL: https://jira.codehaus.org/browse/SUREFIRE-873
 Project: Maven Surefire
  Issue Type: Bug
  Components: Maven Surefire Plugin
Affects Versions: 2.12, 2.10, 2.9, 2.7.2
 Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 11:44:56+0300)
Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
Java home: /usr/lib/jvm/java-6-sun-1.6.0.24/jre
Default locale: ru_RU, platform encoding: UTF-8
OS name: "linux", version: "2.6.32-30-generic", arch: "i386", family: "unix"
Reporter: Rodionov Andrey


{code}
Caused by: java.lang.NullPointerException
at 
org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:312)
at 
org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:293)
at 
org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:271)
at 
org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:256)
at 
org.apache.maven.plugin.surefire.AbstractSurefireMojo.resolveArtifact(AbstractSurefireMojo.java:779)
at 
org.apache.maven.plugin.surefire.AbstractSurefireMojo.addArtifact(AbstractSurefireMojo.java:787)
at 
org.apache.maven.plugin.surefire.AbstractSurefireMojo.createStartupConfiguration(AbstractSurefireMojo.java:349)
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPMD-139) Cannot parse "super. someMethod()" syntax

2012-05-27 Thread Andreas Dangel (JIRA)

[ 
https://jira.codehaus.org/browse/MPMD-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299829#comment-299829
 ] 

Andreas Dangel commented on MPMD-139:
-

I can confirm that this problem is solved with PMD 4.3, which is used by 
maven-pmd-plugin 2.7.1.

> Cannot parse "super. someMethod()" syntax
> ---
>
> Key: MPMD-139
> URL: https://jira.codehaus.org/browse/MPMD-139
> Project: Maven 2.x PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 2.6
> Environment: $ mvn --version
> Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100)
> Maven home: xxx\apache-maven-3.0.3
> Java version: 1.6.0_17, vendor: Sun Microsystems Inc.
> Java home: xxx\jdk1.6.0_17\jre
> Default locale: de_CH, platform encoding: Cp1252
> OS name: "windows xp", version: "5.1", arch: "x86", family: "windows"
> PMD plugin configuration:
>   maven-pmd-plugin
>   2.6
>   
> false
> true
> 1.5
> UTF-8
>   
>Reporter: Morten Lauritsen Khodabocus
>
> The description has been anonymized, but AFAIK, all important details remain. 
> :-)
> On the following code:
> Line 155:return super. someMethod(someArgument);
> PMD reports the following problem:
> [WARNING] Error while parsing xxx\MyClass.java: Encountered " "<" "< "" at 
> line 155, column 22.
> Was expecting:
>  ...
> I tried the following:
> 1) Updated PMD maven plugin to 2.6 (I was using 2.5)
> 2) Verified that the targetJdk setting is taking effect (I get an error when 
> setting it to "xxx")
> 3) I set the source encoding to UTF-8 (My default is Cp1252)
> 4) When changing line 155 to "return (Iterable) 
> super.someMethod(someArgument);", no error is reported
> So it seems that Java 5 mode is enabled, but the particular syntax of 
> parameterizing the method call on invocation is not supported.
> This is valid syntax, the code is running in production.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPMD-139) Cannot parse "super. someMethod()" syntax

2012-05-27 Thread Andreas Dangel (JIRA)

[ 
https://jira.codehaus.org/browse/MPMD-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299829#comment-299829
 ] 

Andreas Dangel edited comment on MPMD-139 at 5/27/12 1:22 PM:
--

-I can confirm that this problem is solved with PMD 4.3, which is used by 
maven-pmd-plugin 2.7.1.-

Sorry, I was too optimistic. It works with "this. 
someMethod(someArgument)" but not with "super".

I created a bug in PMD: 
https://sourceforge.net/tracker/?func=detail&aid=3530124&group_id=56262&atid=479921

  was (Author: adangel):
I can confirm that this problem is solved with PMD 4.3, which is used by 
maven-pmd-plugin 2.7.1.
  
> Cannot parse "super. someMethod()" syntax
> ---
>
> Key: MPMD-139
> URL: https://jira.codehaus.org/browse/MPMD-139
> Project: Maven 2.x PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 2.6
> Environment: $ mvn --version
> Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100)
> Maven home: xxx\apache-maven-3.0.3
> Java version: 1.6.0_17, vendor: Sun Microsystems Inc.
> Java home: xxx\jdk1.6.0_17\jre
> Default locale: de_CH, platform encoding: Cp1252
> OS name: "windows xp", version: "5.1", arch: "x86", family: "windows"
> PMD plugin configuration:
>   maven-pmd-plugin
>   2.6
>   
> false
> true
> 1.5
> UTF-8
>   
>Reporter: Morten Lauritsen Khodabocus
>
> The description has been anonymized, but AFAIK, all important details remain. 
> :-)
> On the following code:
> Line 155:return super. someMethod(someArgument);
> PMD reports the following problem:
> [WARNING] Error while parsing xxx\MyClass.java: Encountered " "<" "< "" at 
> line 155, column 22.
> Was expecting:
>  ...
> I tried the following:
> 1) Updated PMD maven plugin to 2.6 (I was using 2.5)
> 2) Verified that the targetJdk setting is taking effect (I get an error when 
> setting it to "xxx")
> 3) I set the source encoding to UTF-8 (My default is Cp1252)
> 4) When changing line 155 to "return (Iterable) 
> super.someMethod(someArgument);", no error is reported
> So it seems that Java 5 mode is enabled, but the particular syntax of 
> parameterizing the method call on invocation is not supported.
> This is valid syntax, the code is running in production.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-204) recognize classical Maven objects as components

2012-05-27 Thread Herve Boutemy (JIRA)
Herve Boutemy created MPLUGIN-204:
-

 Summary: recognize classical Maven objects as components
 Key: MPLUGIN-204
 URL: https://jira.codehaus.org/browse/MPLUGIN-204
 Project: Maven 2.x Plugin Tools
  Issue Type: New Feature
Affects Versions: 2.9
Reporter: Herve Boutemy


${session}, ${project}, ${mojo}, ${plugin}, ${settings} expressions are 
classical Maven objects injected into Mojos with readonly attribute (ie not 
configurable)

Having them automatically injected with @component annotation, recognized by 
their type, would simplify code

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-193) Allow for generic parameter types in plugin.xml

2012-05-27 Thread Olivier Lamy (JIRA)

[ 
https://jira.codehaus.org/browse/MPLUGIN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299832#comment-299832
 ] 

Olivier Lamy commented on MPLUGIN-193:
--

will be fixed imho using annotations.

> Allow for generic parameter types in plugin.xml
> ---
>
> Key: MPLUGIN-193
> URL: https://jira.codehaus.org/browse/MPLUGIN-193
> Project: Maven 2.x Plugin Tools
>  Issue Type: Improvement
>  Components: Plugin Plugin
>Affects Versions: 2.9
>Reporter: Joseph Walton
> Fix For: 3.0
>
>
> Anno Mojo generates a {{plugin.xml}} that includes generic parameter types. 
> This causes {{PluginXdocGenerator}} to generate non-well-formed XML in one 
> case and an unclear description in another, so {{site}} fails.
> Without a clear specification of whether generics are permitted or not, it 
> would be better to deal with them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-193) Allow for generic parameter types in plugin.xml

2012-05-27 Thread Olivier Lamy (JIRA)

 [ 
https://jira.codehaus.org/browse/MPLUGIN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy closed MPLUGIN-193.


   Resolution: Fixed
Fix Version/s: 3.0
 Assignee: Olivier Lamy

> Allow for generic parameter types in plugin.xml
> ---
>
> Key: MPLUGIN-193
> URL: https://jira.codehaus.org/browse/MPLUGIN-193
> Project: Maven 2.x Plugin Tools
>  Issue Type: Improvement
>  Components: Plugin Plugin
>Affects Versions: 2.9
>Reporter: Joseph Walton
>Assignee: Olivier Lamy
> Fix For: 3.0
>
>
> Anno Mojo generates a {{plugin.xml}} that includes generic parameter types. 
> This causes {{PluginXdocGenerator}} to generate non-well-formed XML in one 
> case and an unclear description in another, so {{site}} fails.
> Without a clear specification of whether generics are permitted or not, it 
> would be better to deal with them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-204) recognize classical Maven objects as components

2012-05-27 Thread Herve Boutemy (JIRA)

 [ 
https://jira.codehaus.org/browse/MPLUGIN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy closed MPLUGIN-204.
-

   Resolution: Fixed
Fix Version/s: 3.0
 Assignee: Herve Boutemy

done in [r1343086|http://svn.apache.org/viewvc?rev=1343086&view=rev]

> recognize classical Maven objects as components
> ---
>
> Key: MPLUGIN-204
> URL: https://jira.codehaus.org/browse/MPLUGIN-204
> Project: Maven 2.x Plugin Tools
>  Issue Type: New Feature
>Affects Versions: 2.9
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
> Fix For: 3.0
>
>
> ${session}, ${project}, ${mojo}, ${plugin}, ${settings} expressions are 
> classical Maven objects injected into Mojos with readonly attribute (ie not 
> configurable)
> Having them automatically injected with @component annotation, recognized by 
> their type, would simplify code

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MNG-5185) Improve "missing dependency" error message when _maven.repositories conflict

2012-05-27 Thread Herve Boutemy (JIRA)

[ 
https://jira.codehaus.org/browse/MNG-5185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299834#comment-299834
 ] 

Herve Boutemy commented on MNG-5185:


bq. Improving this error message would be a very quick change

do you have a patch? I can apply it

> Improve "missing dependency" error message when _maven.repositories conflict
> 
>
> Key: MNG-5185
> URL: https://jira.codehaus.org/browse/MNG-5185
> Project: Maven 2 & 3
>  Issue Type: Improvement
>Reporter: Mark Derricutt
>
> Based on a discussion on the users list [1], Maven 3 has changed how it 
> resolves artifacts from custom repositories.  Unfortunately, when conflicts 
> arise ( GAV is in local repo, but POM has no matching repository id declared 
> ) Maven just tells the user that the artifact could not be resolved.
> This leads to confusion from users who find the .jar files in their local 
> repository, and they just get frustrated and complain that "maven sucks".
> It would be good if Maven was updated with some improved error messages along 
> the lines of:
> "The {GAV} artifact was found in your local repository, but came from the 
> undeclared repository "xxx", either configure this in your pom with {insert 
> sample XML block in error message}, or in your "yyy" mirror."
> The "mirror" section of the error message should be included -if- the current 
> ~/.m2/settings.xml declares a mirror.  By improving the messages here we can 
> help the users move on to building software, rather than pulling out their 
> hair :)
> [1] 
> http://maven.40175.n5.nabble.com/Maven-3-maven-repositories-and-lastUpdated-td4927537.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-109) NullPointerException when using minimizeJar

2012-05-27 Thread Benson Margulies (JIRA)

 [ 
https://jira.codehaus.org/browse/MSHADE-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benson Margulies closed MSHADE-109.
---

Resolution: Cannot Reproduce
  Assignee: Benson Margulies

> NullPointerException when using minimizeJar
> ---
>
> Key: MSHADE-109
> URL: https://jira.codehaus.org/browse/MSHADE-109
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
> Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: /usr/share/maven
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> Default locale: en_US, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> plugin configuration:
> 
> org.apache.maven.plugins
> maven-shade-plugin
> 1.5
> 
> 
> package
> 
> shade
> 
> 
> 
> target/${project.artifactId}-${project.version}-uber.jar
> 
>  implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
> 
> com.webguys.djinn.marid.REPL
> 
> 
> 
> 
> 
> org.fusesource.jansi:jansi
> 
> 
> true
> 
> 
> 
> 
>Reporter: Kevin Birch
>Assignee: Benson Margulies
>Priority: Critical
>  Labels: moreinfo
>
> When setting minimizeJar=true, the below exception is thrown.  When this 
> configuration is not set, everything works fine.  Could this be a API 
> compatibility issue between Maven 2.x and 3.x?
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:1.5:shade (default) on project 
> djinn: Error creating shaded jar: null: NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-shade-plugin:1.5:shade (default) on 
> project djinn: Error creating shaded jar: null
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
>   at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error crea

[jira] (MSHADE-109) NullPointerException when using minimizeJar

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299836#comment-299836
 ] 

Benson Margulies commented on MSHADE-109:
-

Line 63 is not a valid line in the current source of MinijarFilter. That 
combined with the lack of response leads me to be inclined to close this.

> NullPointerException when using minimizeJar
> ---
>
> Key: MSHADE-109
> URL: https://jira.codehaus.org/browse/MSHADE-109
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
> Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: /usr/share/maven
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> Default locale: en_US, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> plugin configuration:
> 
> org.apache.maven.plugins
> maven-shade-plugin
> 1.5
> 
> 
> package
> 
> shade
> 
> 
> 
> target/${project.artifactId}-${project.version}-uber.jar
> 
>  implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
> 
> com.webguys.djinn.marid.REPL
> 
> 
> 
> 
> 
> org.fusesource.jansi:jansi
> 
> 
> true
> 
> 
> 
> 
>Reporter: Kevin Birch
>Priority: Critical
>  Labels: moreinfo
>
> When setting minimizeJar=true, the below exception is thrown.  When this 
> configuration is not set, everything works fine.  Could this be a API 
> compatibility issue between Maven 2.x and 3.x?
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:1.5:shade (default) on project 
> djinn: Error creating shaded jar: null: NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-shade-plugin:1.5:shade (default) on 
> project djinn: Error creating shaded jar: null
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
>   at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at com.intellij.rt.execution.appli

[jira] (MSHADE-108) Shade ha sissue generating a source jar on linux, and generates an error on Java 7

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299837#comment-299837
 ] 

Benson Margulies commented on MSHADE-108:
-

I can repro this on MacOSX.


> Shade ha sissue generating a source jar on linux, and generates an error on 
> Java 7
> --
>
> Key: MSHADE-108
> URL: https://jira.codehaus.org/browse/MSHADE-108
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Reporter: Emmanuel Lécharny
>Priority: Blocker
>
> We are having issues with the shade plugin on Ubuntu, when it works well on 
> mac OSX. Here is how to reproduce the error:
> 1) svn co 
> http://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/
> 2) cd shared
> 3) mvn clean install -Dmaven.test.skip
> On Mac OSX, maven 3.0.3, Java 1.6.0_29, the shared/all/target directory 
> contains :
> -rw-r--r--  1 elecharny  staff 8573 Jan 27 16:20 
> original-shared-all-1.0.0-M10-SNAPSHOT.jar
> -rw-r--r--  1 elecharny  staff  2535518 Jan 27 16:21 
> shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> -rw-r--r--  1 elecharny  staff  2643029 Jan 27 16:20 
> shared-all-1.0.0-M10-SNAPSHOT.jar
> All is fine, the shared-all-1.0.0-M10-SNAPSHOT-sources.jar file contains 
> everything we need.
> On Ubuntu 11.10, maven 3.0.3, Java 1.6.0_29, running the exact same command, 
> the shared-all-1.0.0-M10-SNAPSHOT-sources.jar contains 0 bytes.
> Same but using Java 7 on ubuntu, we now get an error :
> Failed to execute goal 
> org.apache.geronimo.genesis.plugins:tools-maven-plugin:1.4:verify-legal-files 
> (verify-legal-files) on project shared-all: Atifact does not contain any 
> legal files: shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> We run the following command on Mac OSX, using maven 3.0.3 and Java 1.6.0_29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-108) Shade ha sissue generating a source jar on linux, and generates an error on Java 7

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299837#comment-299837
 ] 

Benson Margulies edited comment on MSHADE-108 at 5/27/12 6:34 PM:
--

I can repro this on MacOSX with maven 3.0.4.


  was (Author: bmargulies):
I can repro this on MacOSX.

  
> Shade ha sissue generating a source jar on linux, and generates an error on 
> Java 7
> --
>
> Key: MSHADE-108
> URL: https://jira.codehaus.org/browse/MSHADE-108
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Reporter: Emmanuel Lécharny
>Priority: Blocker
>
> We are having issues with the shade plugin on Ubuntu, when it works well on 
> mac OSX. Here is how to reproduce the error:
> 1) svn co 
> http://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/
> 2) cd shared
> 3) mvn clean install -Dmaven.test.skip
> On Mac OSX, maven 3.0.3, Java 1.6.0_29, the shared/all/target directory 
> contains :
> -rw-r--r--  1 elecharny  staff 8573 Jan 27 16:20 
> original-shared-all-1.0.0-M10-SNAPSHOT.jar
> -rw-r--r--  1 elecharny  staff  2535518 Jan 27 16:21 
> shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> -rw-r--r--  1 elecharny  staff  2643029 Jan 27 16:20 
> shared-all-1.0.0-M10-SNAPSHOT.jar
> All is fine, the shared-all-1.0.0-M10-SNAPSHOT-sources.jar file contains 
> everything we need.
> On Ubuntu 11.10, maven 3.0.3, Java 1.6.0_29, running the exact same command, 
> the shared-all-1.0.0-M10-SNAPSHOT-sources.jar contains 0 bytes.
> Same but using Java 7 on ubuntu, we now get an error :
> Failed to execute goal 
> org.apache.geronimo.genesis.plugins:tools-maven-plugin:1.4:verify-legal-files 
> (verify-legal-files) on project shared-all: Atifact does not contain any 
> legal files: shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> We run the following command on Mac OSX, using maven 3.0.3 and Java 1.6.0_29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-108) Shade ha sissue generating a source jar on linux, and generates an error on Java 7

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299838#comment-299838
 ] 

Benson Margulies commented on MSHADE-108:
-

I wonder about:


INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for 
org.apache.directory.shared:shared-all:jar:1.0.0-M13-SNAPSHOT
[WARNING] 'parent.relativePath' of POM 
org.apache.directory.shared:shared-parent:1.0.0-M13-SNAPSHOT 
(/Users/benson/asf/trunk-with-dependencies/shared/pom.xml) points at 
org.apache.directory.server:apacheds-with-dependencies instead of 
org.apache.directory.project:project, please verify your project structure @ 
org.apache.directory.shared:shared-parent:1.0.0-M13-SNAPSHOT, 
/Users/benson/asf/trunk-with-dependencies/shared/pom.xml, line 22, column 11
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten 
the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support 
building such malformed projects.




> Shade ha sissue generating a source jar on linux, and generates an error on 
> Java 7
> --
>
> Key: MSHADE-108
> URL: https://jira.codehaus.org/browse/MSHADE-108
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Reporter: Emmanuel Lécharny
>Priority: Blocker
>
> We are having issues with the shade plugin on Ubuntu, when it works well on 
> mac OSX. Here is how to reproduce the error:
> 1) svn co 
> http://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/
> 2) cd shared
> 3) mvn clean install -Dmaven.test.skip
> On Mac OSX, maven 3.0.3, Java 1.6.0_29, the shared/all/target directory 
> contains :
> -rw-r--r--  1 elecharny  staff 8573 Jan 27 16:20 
> original-shared-all-1.0.0-M10-SNAPSHOT.jar
> -rw-r--r--  1 elecharny  staff  2535518 Jan 27 16:21 
> shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> -rw-r--r--  1 elecharny  staff  2643029 Jan 27 16:20 
> shared-all-1.0.0-M10-SNAPSHOT.jar
> All is fine, the shared-all-1.0.0-M10-SNAPSHOT-sources.jar file contains 
> everything we need.
> On Ubuntu 11.10, maven 3.0.3, Java 1.6.0_29, running the exact same command, 
> the shared-all-1.0.0-M10-SNAPSHOT-sources.jar contains 0 bytes.
> Same but using Java 7 on ubuntu, we now get an error :
> Failed to execute goal 
> org.apache.geronimo.genesis.plugins:tools-maven-plugin:1.4:verify-legal-files 
> (verify-legal-files) on project shared-all: Atifact does not contain any 
> legal files: shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> We run the following command on Mac OSX, using maven 3.0.3 and Java 1.6.0_29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-108) Shade ha sissue generating a source jar on linux, and generates an error on Java 7

2012-05-27 Thread Benson Margulies (JIRA)

 [ 
https://jira.codehaus.org/browse/MSHADE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benson Margulies reassigned MSHADE-108:
---

Assignee: Benson Margulies

> Shade ha sissue generating a source jar on linux, and generates an error on 
> Java 7
> --
>
> Key: MSHADE-108
> URL: https://jira.codehaus.org/browse/MSHADE-108
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Reporter: Emmanuel Lécharny
>Assignee: Benson Margulies
>Priority: Blocker
>
> We are having issues with the shade plugin on Ubuntu, when it works well on 
> mac OSX. Here is how to reproduce the error:
> 1) svn co 
> http://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/
> 2) cd shared
> 3) mvn clean install -Dmaven.test.skip
> On Mac OSX, maven 3.0.3, Java 1.6.0_29, the shared/all/target directory 
> contains :
> -rw-r--r--  1 elecharny  staff 8573 Jan 27 16:20 
> original-shared-all-1.0.0-M10-SNAPSHOT.jar
> -rw-r--r--  1 elecharny  staff  2535518 Jan 27 16:21 
> shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> -rw-r--r--  1 elecharny  staff  2643029 Jan 27 16:20 
> shared-all-1.0.0-M10-SNAPSHOT.jar
> All is fine, the shared-all-1.0.0-M10-SNAPSHOT-sources.jar file contains 
> everything we need.
> On Ubuntu 11.10, maven 3.0.3, Java 1.6.0_29, running the exact same command, 
> the shared-all-1.0.0-M10-SNAPSHOT-sources.jar contains 0 bytes.
> Same but using Java 7 on ubuntu, we now get an error :
> Failed to execute goal 
> org.apache.geronimo.genesis.plugins:tools-maven-plugin:1.4:verify-legal-files 
> (verify-legal-files) on project shared-all: Atifact does not contain any 
> legal files: shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> We run the following command on Mac OSX, using maven 3.0.3 and Java 1.6.0_29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-108) Shade ha sissue generating a source jar on linux, and generates an error on Java 7

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299840#comment-299840
 ] 

Benson Margulies commented on MSHADE-108:
-

The problem here is that you never run the sources plugin to build any sources 
that can be combined by shade. I've attached a fix to this for your tree.



> Shade ha sissue generating a source jar on linux, and generates an error on 
> Java 7
> --
>
> Key: MSHADE-108
> URL: https://jira.codehaus.org/browse/MSHADE-108
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Reporter: Emmanuel Lécharny
>Assignee: Benson Margulies
>Priority: Blocker
> Attachments: sources.patch
>
>
> We are having issues with the shade plugin on Ubuntu, when it works well on 
> mac OSX. Here is how to reproduce the error:
> 1) svn co 
> http://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/
> 2) cd shared
> 3) mvn clean install -Dmaven.test.skip
> On Mac OSX, maven 3.0.3, Java 1.6.0_29, the shared/all/target directory 
> contains :
> -rw-r--r--  1 elecharny  staff 8573 Jan 27 16:20 
> original-shared-all-1.0.0-M10-SNAPSHOT.jar
> -rw-r--r--  1 elecharny  staff  2535518 Jan 27 16:21 
> shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> -rw-r--r--  1 elecharny  staff  2643029 Jan 27 16:20 
> shared-all-1.0.0-M10-SNAPSHOT.jar
> All is fine, the shared-all-1.0.0-M10-SNAPSHOT-sources.jar file contains 
> everything we need.
> On Ubuntu 11.10, maven 3.0.3, Java 1.6.0_29, running the exact same command, 
> the shared-all-1.0.0-M10-SNAPSHOT-sources.jar contains 0 bytes.
> Same but using Java 7 on ubuntu, we now get an error :
> Failed to execute goal 
> org.apache.geronimo.genesis.plugins:tools-maven-plugin:1.4:verify-legal-files 
> (verify-legal-files) on project shared-all: Atifact does not contain any 
> legal files: shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> We run the following command on Mac OSX, using maven 3.0.3 and Java 1.6.0_29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-108) Shade ha sissue generating a source jar on linux, and generates an error on Java 7

2012-05-27 Thread Benson Margulies (JIRA)

 [ 
https://jira.codehaus.org/browse/MSHADE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benson Margulies updated MSHADE-108:


Attachment: sources.patch

Here's the fix to your tree.

> Shade ha sissue generating a source jar on linux, and generates an error on 
> Java 7
> --
>
> Key: MSHADE-108
> URL: https://jira.codehaus.org/browse/MSHADE-108
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Reporter: Emmanuel Lécharny
>Assignee: Benson Margulies
>Priority: Blocker
> Attachments: sources.patch
>
>
> We are having issues with the shade plugin on Ubuntu, when it works well on 
> mac OSX. Here is how to reproduce the error:
> 1) svn co 
> http://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/
> 2) cd shared
> 3) mvn clean install -Dmaven.test.skip
> On Mac OSX, maven 3.0.3, Java 1.6.0_29, the shared/all/target directory 
> contains :
> -rw-r--r--  1 elecharny  staff 8573 Jan 27 16:20 
> original-shared-all-1.0.0-M10-SNAPSHOT.jar
> -rw-r--r--  1 elecharny  staff  2535518 Jan 27 16:21 
> shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> -rw-r--r--  1 elecharny  staff  2643029 Jan 27 16:20 
> shared-all-1.0.0-M10-SNAPSHOT.jar
> All is fine, the shared-all-1.0.0-M10-SNAPSHOT-sources.jar file contains 
> everything we need.
> On Ubuntu 11.10, maven 3.0.3, Java 1.6.0_29, running the exact same command, 
> the shared-all-1.0.0-M10-SNAPSHOT-sources.jar contains 0 bytes.
> Same but using Java 7 on ubuntu, we now get an error :
> Failed to execute goal 
> org.apache.geronimo.genesis.plugins:tools-maven-plugin:1.4:verify-legal-files 
> (verify-legal-files) on project shared-all: Atifact does not contain any 
> legal files: shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> We run the following command on Mac OSX, using maven 3.0.3 and Java 1.6.0_29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-108) Shade ha sissue generating a source jar on linux, and generates an error on Java 7

2012-05-27 Thread Benson Margulies (JIRA)

 [ 
https://jira.codehaus.org/browse/MSHADE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benson Margulies closed MSHADE-108.
---

Resolution: Not A Bug

See patch attached for your pom to actually make some sources to combine in 
shade.


> Shade ha sissue generating a source jar on linux, and generates an error on 
> Java 7
> --
>
> Key: MSHADE-108
> URL: https://jira.codehaus.org/browse/MSHADE-108
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Reporter: Emmanuel Lécharny
>Assignee: Benson Margulies
>Priority: Blocker
> Attachments: sources.patch
>
>
> We are having issues with the shade plugin on Ubuntu, when it works well on 
> mac OSX. Here is how to reproduce the error:
> 1) svn co 
> http://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/
> 2) cd shared
> 3) mvn clean install -Dmaven.test.skip
> On Mac OSX, maven 3.0.3, Java 1.6.0_29, the shared/all/target directory 
> contains :
> -rw-r--r--  1 elecharny  staff 8573 Jan 27 16:20 
> original-shared-all-1.0.0-M10-SNAPSHOT.jar
> -rw-r--r--  1 elecharny  staff  2535518 Jan 27 16:21 
> shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> -rw-r--r--  1 elecharny  staff  2643029 Jan 27 16:20 
> shared-all-1.0.0-M10-SNAPSHOT.jar
> All is fine, the shared-all-1.0.0-M10-SNAPSHOT-sources.jar file contains 
> everything we need.
> On Ubuntu 11.10, maven 3.0.3, Java 1.6.0_29, running the exact same command, 
> the shared-all-1.0.0-M10-SNAPSHOT-sources.jar contains 0 bytes.
> Same but using Java 7 on ubuntu, we now get an error :
> Failed to execute goal 
> org.apache.geronimo.genesis.plugins:tools-maven-plugin:1.4:verify-legal-files 
> (verify-legal-files) on project shared-all: Atifact does not contain any 
> legal files: shared-all-1.0.0-M10-SNAPSHOT-sources.jar
> We run the following command on Mac OSX, using maven 3.0.3 and Java 1.6.0_29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-75) Package maven multimodule project with shade plugin : error in opening zip on directory

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299842#comment-299842
 ] 

Benson Margulies commented on MSHADE-75:


This is not a test case for the problem at hand. The pom supplied creates a 
classified jar but does not include it in shade. Instead, it fails, as far as I 
can tell, because there are no resources to include in the shaded jar at all. 
I'm looking further.

> Package maven multimodule project with shade plugin : error in opening zip on 
> directory
> ---
>
> Key: MSHADE-75
> URL: https://jira.codehaus.org/browse/MSHADE-75
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.3.1
> Environment: Ubuntu 9.04 - Jaunty Jackalope -, Eclispse (Galileo), 
> java 1.6.0_16
>Reporter: Yoann Yonnet
>  Labels: moreinfo
> Attachments: patch-maven-shade-plugin.txt, pom.xml
>
>
> Hello,
> I make a maven aggregator project with two modules.
> The first module is a dependency of the second.
> The first module is build with the install goal.
> The second with the shade plugin during the package phase.
> The first module build runs successfully and install resulting jar file in 
> the maven local repository.
> The second module build fails with this error : 
> {noformat}[INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error creating shaded jar: error in opening zip file 
> /home/yoann/workspace/maven.1265640716107/trunk/tcx-ws-client/module1/target/classes
> [INFO] 
> 
> [INFO] For more information, run Maven with the -e switch
> [INFO] 
> 
> [INFO] Total time: 10 seconds
> [INFO] Finished at: Fri Feb 12 10:39:29 CET 2010
> [INFO] Final Memory: 59M/583M
> [INFO] 
> {noformat}
> It's due to the shade plugin whose tries to reference first module classes 
> from target/classes repository instead of the jar file previously build.
> Therefore, it seems that the shade plugin doesn't work with a maven 
> multimodules project.
> I manage to build my maven aggregator project by applying the attached patch 
> (patch-maven-shade-plugin.txt) on the class ShadeMojo.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-75) Package maven multimodule project with shade plugin : error in opening zip on directory

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299842#comment-299842
 ] 

Benson Margulies edited comment on MSHADE-75 at 5/27/12 7:24 PM:
-

This is not a fix for the problem at hand. The patch doesn't change the 
behavior at all, it would apply to a case where a declared dependency had a 
classifier, and the fix would never work, either.

  was (Author: bmargulies):
This is not a test case for the problem at hand. The pom supplied creates a 
classified jar but does not include it in shade. Instead, it fails, as far as I 
can tell, because there are no resources to include in the shaded jar at all. 
I'm looking further.
  
> Package maven multimodule project with shade plugin : error in opening zip on 
> directory
> ---
>
> Key: MSHADE-75
> URL: https://jira.codehaus.org/browse/MSHADE-75
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.3.1
> Environment: Ubuntu 9.04 - Jaunty Jackalope -, Eclispse (Galileo), 
> java 1.6.0_16
>Reporter: Yoann Yonnet
>  Labels: moreinfo
> Attachments: patch-maven-shade-plugin.txt, pom.xml
>
>
> Hello,
> I make a maven aggregator project with two modules.
> The first module is a dependency of the second.
> The first module is build with the install goal.
> The second with the shade plugin during the package phase.
> The first module build runs successfully and install resulting jar file in 
> the maven local repository.
> The second module build fails with this error : 
> {noformat}[INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error creating shaded jar: error in opening zip file 
> /home/yoann/workspace/maven.1265640716107/trunk/tcx-ws-client/module1/target/classes
> [INFO] 
> 
> [INFO] For more information, run Maven with the -e switch
> [INFO] 
> 
> [INFO] Total time: 10 seconds
> [INFO] Finished at: Fri Feb 12 10:39:29 CET 2010
> [INFO] Final Memory: 59M/583M
> [INFO] 
> {noformat}
> It's due to the shade plugin whose tries to reference first module classes 
> from target/classes repository instead of the jar file previously build.
> Therefore, it seems that the shade plugin doesn't work with a maven 
> multimodules project.
> I manage to build my maven aggregator project by applying the attached patch 
> (patch-maven-shade-plugin.txt) on the class ShadeMojo.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-75) Package maven multimodule project with shade plugin : error in opening zip on directory

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299843#comment-299843
 ] 

Benson Margulies commented on MSHADE-75:


I claim that this case should not work, but it could 'not work' more politely.

What you've done is disrupt the production of the project's main artifact. By 
adding a classifier to the default execution of the jar plugin, you've made the 
jar plugin create an attached artifact *instead of* the main 'jar' artifact. 
This leaves the project 'naked' and no longer producing a jar, and so shade is 
flummoxed. Arguably, this case should produce a diagnostic like the diagnostic 
for non-jar projects, and that's what I'm going to make it do. Then, I believe 
that you could exclude the project's main artifact from shade and ask for the 
classified one instead.


> Package maven multimodule project with shade plugin : error in opening zip on 
> directory
> ---
>
> Key: MSHADE-75
> URL: https://jira.codehaus.org/browse/MSHADE-75
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.3.1
> Environment: Ubuntu 9.04 - Jaunty Jackalope -, Eclispse (Galileo), 
> java 1.6.0_16
>Reporter: Yoann Yonnet
>  Labels: moreinfo
> Attachments: patch-maven-shade-plugin.txt, pom.xml
>
>
> Hello,
> I make a maven aggregator project with two modules.
> The first module is a dependency of the second.
> The first module is build with the install goal.
> The second with the shade plugin during the package phase.
> The first module build runs successfully and install resulting jar file in 
> the maven local repository.
> The second module build fails with this error : 
> {noformat}[INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error creating shaded jar: error in opening zip file 
> /home/yoann/workspace/maven.1265640716107/trunk/tcx-ws-client/module1/target/classes
> [INFO] 
> 
> [INFO] For more information, run Maven with the -e switch
> [INFO] 
> 
> [INFO] Total time: 10 seconds
> [INFO] Finished at: Fri Feb 12 10:39:29 CET 2010
> [INFO] Final Memory: 59M/583M
> [INFO] 
> {noformat}
> It's due to the shade plugin whose tries to reference first module classes 
> from target/classes repository instead of the jar file previously build.
> Therefore, it seems that the shade plugin doesn't work with a maven 
> multimodules project.
> I manage to build my maven aggregator project by applying the attached patch 
> (patch-maven-shade-plugin.txt) on the class ShadeMojo.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-75) Package maven multimodule project with shade plugin : error in opening zip on directory

2012-05-27 Thread Benson Margulies (JIRA)

 [ 
https://jira.codehaus.org/browse/MSHADE-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benson Margulies closed MSHADE-75.
--

   Resolution: Fixed
Fix Version/s: 1.7
 Assignee: Benson Margulies

Proper diagnosis added.


> Package maven multimodule project with shade plugin : error in opening zip on 
> directory
> ---
>
> Key: MSHADE-75
> URL: https://jira.codehaus.org/browse/MSHADE-75
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.3.1
> Environment: Ubuntu 9.04 - Jaunty Jackalope -, Eclispse (Galileo), 
> java 1.6.0_16
>Reporter: Yoann Yonnet
>Assignee: Benson Margulies
>  Labels: moreinfo
> Fix For: 1.7
>
> Attachments: patch-maven-shade-plugin.txt, pom.xml
>
>
> Hello,
> I make a maven aggregator project with two modules.
> The first module is a dependency of the second.
> The first module is build with the install goal.
> The second with the shade plugin during the package phase.
> The first module build runs successfully and install resulting jar file in 
> the maven local repository.
> The second module build fails with this error : 
> {noformat}[INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error creating shaded jar: error in opening zip file 
> /home/yoann/workspace/maven.1265640716107/trunk/tcx-ws-client/module1/target/classes
> [INFO] 
> 
> [INFO] For more information, run Maven with the -e switch
> [INFO] 
> 
> [INFO] Total time: 10 seconds
> [INFO] Finished at: Fri Feb 12 10:39:29 CET 2010
> [INFO] Final Memory: 59M/583M
> [INFO] 
> {noformat}
> It's due to the shade plugin whose tries to reference first module classes 
> from target/classes repository instead of the jar file previously build.
> Therefore, it seems that the shade plugin doesn't work with a maven 
> multimodules project.
> I manage to build my maven aggregator project by applying the attached patch 
> (patch-maven-shade-plugin.txt) on the class ShadeMojo.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-82) Add the ability to deploy a reduced pom in place of the original

2012-05-27 Thread Benson Margulies (JIRA)

 [ 
https://jira.codehaus.org/browse/MSHADE-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benson Margulies closed MSHADE-82.
--

Resolution: Not A Bug
  Assignee: Benson Margulies

This is the 'dependency-reduced-pom' feature, present in shade since forever.

> Add the ability to deploy a reduced pom in place of  the original
> -
>
> Key: MSHADE-82
> URL: https://jira.codehaus.org/browse/MSHADE-82
> Project: Maven 2.x Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 1.3.3
>Reporter: Christophe Lallement
>Assignee: Benson Margulies
>
> shade plugin is very useful to merge some jar into one. It can be used when 
> we have a *terminal* pom (i mean a pom where no other pom can depend).
> sometime we want to have a project packaged with it's dependencies into one 
> (for ex. because we use only a few class of a dep. or to avoid conflict) and 
> deploy for other projects that can add dependencies on it.
> Shade plugin works very fine until the generation of jar and reduced pom.
> So at this stage *we can deploy merging jar but not the reduced pom*.
> I looking for other plugin / maven tricks to do this task but doesn't find 
> anything.
> *Is this task can be done into the shade plugin ?*
> Thx
> Christopje

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-107) ArrayIndexOutOfBoundsException when using minimizeJar with shade plugin

2012-05-27 Thread Benson Margulies (JIRA)

 [ 
https://jira.codehaus.org/browse/MSHADE-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benson Margulies reassigned MSHADE-107:
---

Assignee: Benson Margulies

> ArrayIndexOutOfBoundsException when using minimizeJar with shade plugin
> ---
>
> Key: MSHADE-107
> URL: https://jira.codehaus.org/browse/MSHADE-107
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
> Environment: Apache Maven 2.2.1 (rdebian-1)
> Java version: 1.6.0_26
>Reporter: Thomas Kruse
>Assignee: Benson Margulies
>  Labels: moreinfo
> Attachments: mshade-107.patch, mshade-107-revised.patch, pom.xml
>
>
> The shade plugin fails with error message
> {code}
> [INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error creating shaded jar: 26
> {code}
> Running maven with -e on the project yields
> {code}
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error creating shaded jar: 26
> [INFO] 
> 
> [INFO] Trace
> org.apache.maven.lifecycle.LifecycleExecutionException: Error creating shaded 
> jar: 26
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:719)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
>   at 
> org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>   at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>   at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>   at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
> shaded jar: 26
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:503)
>   at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
>   ... 17 more
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 26
>   at org.objectweb.asm.ClassReader.readClass(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at org.vafer.jdependency.Clazzpath.addClazzpathUnit(Clazzpath.java:94)
>   at 
> org.apache.maven.plugins.shade.filter.MinijarFilter.(MinijarFilter.java:74)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.getFilters(ShadeMojo.java:696)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:438)
>   ... 19 more
> {code}
> The failing module is part of a multi module build, has a quite large number 
> of transitive dependencies.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-75) Package maven multimodule project with shade plugin : error in opening zip on directory

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299847#comment-299847
 ] 

Benson Margulies commented on MSHADE-75:


r1343119 | bimargulies | 2012-05-27 20:52:20 -0400 (Sun, 27 May 2012) | 3 lines

MSHADE-75: Package maven multimodule project with shade plugin : error in 
opening zip on directory
o detect and diagnose missing jar main artifact.




r1343121 | bimargulies | 2012-05-27 21:01:53 -0400 (Sun, 27 May 2012) | 3 lines

MSHADE-75: Package maven multimodule project with shade plugin : error in 
opening zip on directory
 o this was a dumb error in the work on -75 that I misattributed briefly.





> Package maven multimodule project with shade plugin : error in opening zip on 
> directory
> ---
>
> Key: MSHADE-75
> URL: https://jira.codehaus.org/browse/MSHADE-75
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.3.1
> Environment: Ubuntu 9.04 - Jaunty Jackalope -, Eclispse (Galileo), 
> java 1.6.0_16
>Reporter: Yoann Yonnet
>Assignee: Benson Margulies
>  Labels: moreinfo
> Fix For: 1.7
>
> Attachments: patch-maven-shade-plugin.txt, pom.xml
>
>
> Hello,
> I make a maven aggregator project with two modules.
> The first module is a dependency of the second.
> The first module is build with the install goal.
> The second with the shade plugin during the package phase.
> The first module build runs successfully and install resulting jar file in 
> the maven local repository.
> The second module build fails with this error : 
> {noformat}[INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error creating shaded jar: error in opening zip file 
> /home/yoann/workspace/maven.1265640716107/trunk/tcx-ws-client/module1/target/classes
> [INFO] 
> 
> [INFO] For more information, run Maven with the -e switch
> [INFO] 
> 
> [INFO] Total time: 10 seconds
> [INFO] Finished at: Fri Feb 12 10:39:29 CET 2010
> [INFO] Final Memory: 59M/583M
> [INFO] 
> {noformat}
> It's due to the shade plugin whose tries to reference first module classes 
> from target/classes repository instead of the jar file previously build.
> Therefore, it seems that the shade plugin doesn't work with a maven 
> multimodules project.
> I manage to build my maven aggregator project by applying the attached patch 
> (patch-maven-shade-plugin.txt) on the class ShadeMojo.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MSHADE-107) ArrayIndexOutOfBoundsException when using minimizeJar with shade plugin

2012-05-27 Thread Benson Margulies (JIRA)

 [ 
https://jira.codehaus.org/browse/MSHADE-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benson Margulies closed MSHADE-107.
---

   Resolution: Fixed
Fix Version/s: 1.7


r1343123 | bimargulies | 2012-05-27 21:15:51 -0400 (Sun, 27 May 2012) | 3 lines

MSHADE-107: ArrayIndexOutOfBoundsException when using minimizeJar with shade 
plugin
 o accepted patch that improved the diagnostics for bad dependencies.



> ArrayIndexOutOfBoundsException when using minimizeJar with shade plugin
> ---
>
> Key: MSHADE-107
> URL: https://jira.codehaus.org/browse/MSHADE-107
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
> Environment: Apache Maven 2.2.1 (rdebian-1)
> Java version: 1.6.0_26
>Reporter: Thomas Kruse
>Assignee: Benson Margulies
>  Labels: moreinfo
> Fix For: 1.7
>
> Attachments: mshade-107.patch, mshade-107-revised.patch, pom.xml
>
>
> The shade plugin fails with error message
> {code}
> [INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error creating shaded jar: 26
> {code}
> Running maven with -e on the project yields
> {code}
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error creating shaded jar: 26
> [INFO] 
> 
> [INFO] Trace
> org.apache.maven.lifecycle.LifecycleExecutionException: Error creating shaded 
> jar: 26
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:719)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
>   at 
> org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>   at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>   at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>   at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
> shaded jar: 26
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:503)
>   at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
>   ... 17 more
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 26
>   at org.objectweb.asm.ClassReader.readClass(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at org.vafer.jdependency.Clazzpath.addClazzpathUnit(Clazzpath.java:94)
>   at 
> org.apache.maven.plugins.shade.filter.MinijarFilter.(MinijarFilter.java:74)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.getFilters(ShadeMojo.java:696)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:438)
>   ... 19 more
> {code}
> The failing module is part of a multi module build, has a quite large number 
> of transitive dependencies.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, s

[jira] (MSHADE-103) maven-shade-plugin does not resolve from user-defined repositories

2012-05-27 Thread Benson Margulies (JIRA)

[ 
https://jira.codehaus.org/browse/MSHADE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299849#comment-299849
 ] 

Benson Margulies commented on MSHADE-103:
-

It is very unlikely that this is specific to shade. It does not have 
repository-sensitive code, it just calls the core of Maven to do its work.

> maven-shade-plugin does not resolve from user-defined repositories
> --
>
> Key: MSHADE-103
> URL: https://jira.codehaus.org/browse/MSHADE-103
> Project: Maven 2.x Shade Plugin
>  Issue Type: Bug
>Affects Versions: 1.3.3, 1.4
> Environment: Maven 3.0.3 (works with 2.2.1)
>Reporter: Lukas Fryc
>
> maven-shade-plugin doesn't consult repositories defined in 
> settings.xml when trying to resolve parents of given pom. It contacts 
> only central repo: 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:1.4:shade (default) on 
> project richfaces-components-api: Error creating shaded jar: 1 problem 
> was encountered while building the effective model for 
> org.richfaces.ui:richfaces-components-api:4.1.0-SNAPSHOT 
> [ERROR] [FATAL] Non-resolvable parent POM for 
> org.richfaces:richfaces-bom:4.1.0-SNAPSHOT: Could not find artifact 
> org.richfaces:richfaces-parent:pom:10 in central 
> (http://repo1.maven.org/maven2) and 'parent.relativePath' points at 
> wrong local POM @ org.richfaces:richfaces-bom:4.1.0-SNAPSHOT, 
> /home/lfryc/workspaces/richfaces/build/bom/pom.xml, line 24, column 10 
> [ERROR] for project 
> org.richfaces.ui:richfaces-components-api:4.1.0-SNAPSHOT at 
> /home/lfryc/workspaces/richfaces/components/dist/richfaces-components-api/dependency-reduced-pom.xml
>  
> for project org.richfaces.ui:richfaces-components-api:4.1.0-SNAPSHOT at 
> /home/lfryc/workspaces/richfaces/components/dist/richfaces-components-api/dependency-reduced-pom.xml
>  
> [ERROR] -> [Help 1] 
> There is affected project (it references version 1.3.3, but the behavior is 
> same with 1.4) if you would like to try at own: 
> https://github.com/richfaces/components/blob/develop/dist/richfaces-components-api/pom.xml

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-205) @Mojo in maven-plugin-annotations does not use the specified value of requiresProject

2012-05-27 Thread Joseph Walton (JIRA)
Joseph Walton created MPLUGIN-205:
-

 Summary: @Mojo in maven-plugin-annotations does not use the 
specified value of requiresProject
 Key: MPLUGIN-205
 URL: https://jira.codehaus.org/browse/MPLUGIN-205
 Project: Maven 2.x Plugin Tools
  Issue Type: Bug
  Components: maven-plugin-annotations
Affects Versions: 3.0
Reporter: Joseph Walton


A mojo defined as:

{noformat}
@Mojo(name = "sample", requiresProject = false)
public class SampleMojo extends AbstractMojo
{noformat}

still indicates that it requires a project in the generated plugin descriptor:

{noformat}
true
{noformat}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-205) @Mojo in maven-plugin-annotations does not use the specified value of requiresProject

2012-05-27 Thread Joseph Walton (JIRA)

 [ 
https://jira.codehaus.org/browse/MPLUGIN-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Walton updated MPLUGIN-205:
--

Attachment: MPLUGIN-205.diff

> @Mojo in maven-plugin-annotations does not use the specified value of 
> requiresProject
> -
>
> Key: MPLUGIN-205
> URL: https://jira.codehaus.org/browse/MPLUGIN-205
> Project: Maven 2.x Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.0
>Reporter: Joseph Walton
> Attachments: MPLUGIN-205.diff
>
>
> A mojo defined as:
> {noformat}
> @Mojo(name = "sample", requiresProject = false)
> public class SampleMojo extends AbstractMojo
> {noformat}
> still indicates that it requires a project in the generated plugin descriptor:
> {noformat}
> true
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-206) Annotations in superclasses are not found if an intermediate class is not annotated

2012-05-27 Thread Joseph Walton (JIRA)
Joseph Walton created MPLUGIN-206:
-

 Summary: Annotations in superclasses are not found if an 
intermediate class is not annotated
 Key: MPLUGIN-206
 URL: https://jira.codehaus.org/browse/MPLUGIN-206
 Project: Maven 2.x Plugin Tools
  Issue Type: Bug
  Components: maven-plugin-annotations
Affects Versions: 3.0
Reporter: Joseph Walton


My concrete mojo class extends an intermediate class which in turn extends an 
abstract mojo that defines parameters. Those parameters aren't being picked up 
when inheritance is indirect.

i.e.,

* A: Defines a @Parameter paramA
* B extends A
* C extends B, defines @Parameter paramC

C's results only includes paramC.

Adding a dummy @Parameter to B means C sees parameters from all three classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-206) Annotations in superclasses are not found if an intermediate class is not annotated

2012-05-27 Thread Joseph Walton (JIRA)

[ 
https://jira.codehaus.org/browse/MPLUGIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=299855#comment-299855
 ] 

Joseph Walton commented on MPLUGIN-206:
---

Looks like {{DefaultMojoAnnotationsScanner}} gathers all the classes in the 
project that use annotations and 
{{JavaAnnotationsMojoDescriptorExtractor#getParametersParent}} later relies on 
this being an exhaustive record.

If the missing parent class is {{AbstractMojo}} then that's expected to be 
missing from the project, but anything else suggests that something is missing 
from the hierarchy. Maybe this should be an error? I'd have found a build error 
less surprising than missing parameters.


> Annotations in superclasses are not found if an intermediate class is not 
> annotated
> ---
>
> Key: MPLUGIN-206
> URL: https://jira.codehaus.org/browse/MPLUGIN-206
> Project: Maven 2.x Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.0
>Reporter: Joseph Walton
>
> My concrete mojo class extends an intermediate class which in turn extends an 
> abstract mojo that defines parameters. Those parameters aren't being picked 
> up when inheritance is indirect.
> i.e.,
> * A: Defines a @Parameter paramA
> * B extends A
> * C extends B, defines @Parameter paramC
> C's results only includes paramC.
> Adding a dummy @Parameter to B means C sees parameters from all three classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-205) @Mojo in maven-plugin-annotations does not use the specified value of requiresProject

2012-05-27 Thread Olivier Lamy (JIRA)

 [ 
https://jira.codehaus.org/browse/MPLUGIN-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy closed MPLUGIN-205.


   Resolution: Fixed
Fix Version/s: 3.0
 Assignee: Olivier Lamy

fixed r1343148
Thanks for the patch !

> @Mojo in maven-plugin-annotations does not use the specified value of 
> requiresProject
> -
>
> Key: MPLUGIN-205
> URL: https://jira.codehaus.org/browse/MPLUGIN-205
> Project: Maven 2.x Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.0
>Reporter: Joseph Walton
>Assignee: Olivier Lamy
> Fix For: 3.0
>
> Attachments: MPLUGIN-205.diff
>
>
> A mojo defined as:
> {noformat}
> @Mojo(name = "sample", requiresProject = false)
> public class SampleMojo extends AbstractMojo
> {noformat}
> still indicates that it requires a project in the generated plugin descriptor:
> {noformat}
> true
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-206) Annotations in superclasses are not found if an intermediate class is not annotated

2012-05-27 Thread Olivier Lamy (JIRA)

 [ 
https://jira.codehaus.org/browse/MPLUGIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy reassigned MPLUGIN-206:


Assignee: Olivier Lamy

> Annotations in superclasses are not found if an intermediate class is not 
> annotated
> ---
>
> Key: MPLUGIN-206
> URL: https://jira.codehaus.org/browse/MPLUGIN-206
> Project: Maven 2.x Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.0
>Reporter: Joseph Walton
>Assignee: Olivier Lamy
>
> My concrete mojo class extends an intermediate class which in turn extends an 
> abstract mojo that defines parameters. Those parameters aren't being picked 
> up when inheritance is indirect.
> i.e.,
> * A: Defines a @Parameter paramA
> * B extends A
> * C extends B, defines @Parameter paramC
> C's results only includes paramC.
> Adding a dummy @Parameter to B means C sees parameters from all three classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (MPLUGIN-206) Annotations in superclasses are not found if an intermediate class is not annotated

2012-05-27 Thread Olivier Lamy (JIRA)

 [ 
https://jira.codehaus.org/browse/MPLUGIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy updated MPLUGIN-206:
-

Fix Version/s: 3.0

> Annotations in superclasses are not found if an intermediate class is not 
> annotated
> ---
>
> Key: MPLUGIN-206
> URL: https://jira.codehaus.org/browse/MPLUGIN-206
> Project: Maven 2.x Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.0
>Reporter: Joseph Walton
>Assignee: Olivier Lamy
> Fix For: 3.0
>
>
> My concrete mojo class extends an intermediate class which in turn extends an 
> abstract mojo that defines parameters. Those parameters aren't being picked 
> up when inheritance is indirect.
> i.e.,
> * A: Defines a @Parameter paramA
> * B extends A
> * C extends B, defines @Parameter paramC
> C's results only includes paramC.
> Adding a dummy @Parameter to B means C sees parameters from all three classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira