Re: [I] Remove -XX:ActiveProcessorCount=1 from template.gradle.properties [lucene]
dweiss commented on issue #14829: URL: https://github.com/apache/lucene/issues/14829#issuecomment-2994005520 I've applied this on main and branch_10x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] build: replace six simple error prone checks [lucene]
dweiss commented on code in PR #14831:
URL: https://github.com/apache/lucene/pull/14831#discussion_r2160248134
##
lucene/test-framework/src/test/org/apache/lucene/tests/util/TestBeforeAfterOverrides.java:
##
@@ -30,7 +30,9 @@ public TestBeforeAfterOverrides() {
public static class Before1 extends WithNestedTests.AbstractNestedTest {
@Before
-public void before() {}
+public void before() {
+ /* intentionally left blank */
+}
Review Comment:
It's clearer now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Custom google java format tasks to replace spotless [lucene]
github-actions[bot] commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2994008065 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Remove -XX:ActiveProcessorCount=1 from template.gradle.properties [lucene]
dweiss closed issue #14829: Remove -XX:ActiveProcessorCount=1 from template.gradle.properties URL: https://github.com/apache/lucene/issues/14829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Custom google java format tasks to replace spotless [lucene]
dweiss merged PR #14824: URL: https://github.com/apache/lucene/pull/14824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[I] add generated files lists/patterns to .gitattributes [lucene]
rmuir opened a new issue, #14833: URL: https://github.com/apache/lucene/issues/14833 ### Description generated files can be specified in `.gitattributes` as generated for a couple bonuses in github: * doesn't mess up source code analysis (counts etc) * changes are folded/hidden by default in code reviews It isn't much, but it would be nice to do. Maybe other tools respect it too (now or in the future) and it makes our lives easier? https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]
rmuir commented on PR #14832: URL: https://github.com/apache/lucene/pull/14832#issuecomment-2994425325 will also push a commit adding this one to `.git-blame-ignore-revs`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] build: replace six simple error prone checks [lucene]
github-actions[bot] commented on PR #14831: URL: https://github.com/apache/lucene/pull/14831#issuecomment-2994427294 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]
rmuir commented on PR #14832: URL: https://github.com/apache/lucene/pull/14832#issuecomment-2994386376 The validation does make `eclint` run slower, but it still burns relative to other tasks in the build: ``` $ time eclint real 0m5.289s user 0m7.823s sys 0m0.601s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Remove -XX:ActiveProcessorCount=1 from template.gradle.properties [lucene]
dsmiley commented on issue #14829: URL: https://github.com/apache/lucene/issues/14829#issuecomment-2994866377 I imagine you'd recommend the same for Solr? It's not clear if Spotless vs. the direct GoogleJavaFormat aspect changes the answer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]
rmuir merged PR #14832: URL: https://github.com/apache/lucene/pull/14832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Optimize `CombinedFieldQuery` by `nextDocsAndScores` [lucene]
HUSTERGS opened a new pull request, #14834: URL: https://github.com/apache/lucene/pull/14834 ### Description This PR propose to implement `nextDocsAndScores` in order to help the auto-vectorize of score calculation, I'v seen similar code under `TermScorer`. Basically this pr add a new `scoreRange` method for `MultiNormsLeafSimScorer` and do `freq()` and `norm()` before the actual score caculation. (I'm not very sure whether I should change the code under `sandbox`, but currently the luceneutil still use the `CombinedFieldQuery` under `sandbox`) https://github.com/mikemccand/luceneutil/blob/2c59f24382da40d980497ddc3ab413fa21b3d1ac/src/main/perf/TaskParser.java#L52 The luceneutil benchmark result (**which use `sandbox` version of `CombinedFieldQuery` by default**) on `wikimediumall` with `searchConcurrency=0`, `taskCountPerCat=5`, `taskRepeatCount=50` after 20 iterations: ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value AndStopWords9.19 (4.2%)8.92 (8.4%) -3.0% ( -14% -9%) 0.151 OrStopWords9.87 (5.3%)9.59 (10.0%) -2.8% ( -17% - 13%) 0.266 AndHighHigh 26.30 (3.8%) 25.82 (9.1%) -1.8% ( -14% - 11%) 0.405 And3Terms 86.85 (3.6%) 85.43 (7.2%) -1.6% ( -12% -9%) 0.366 OrMany5.53 (4.5%)5.45 (6.6%) -1.6% ( -12% -9%) 0.372 OrHighHigh 25.09 (3.1%) 24.73 (8.9%) -1.4% ( -13% - 10%) 0.496 Or3Terms 78.24 (3.2%) 77.13 (7.9%) -1.4% ( -12% -9%) 0.456 AndHighMed 67.33 (3.1%) 66.76 (8.1%) -0.9% ( -11% - 10%) 0.660 DismaxTerm 653.55 (4.1%) 648.63 (4.7%) -0.8% ( -9% -8%) 0.587 AndMedOrHighHigh 20.67 (1.5%) 20.53 (3.2%) -0.7% ( -5% -4%) 0.405 DismaxOrHighHigh 45.07 (2.7%) 44.84 (5.6%) -0.5% ( -8% -7%) 0.715 OrHighMed 88.76 (3.9%) 88.37 (8.7%) -0.4% ( -12% - 12%) 0.837 Term10K 587.56 (5.1%) 585.84 (6.8%) -0.3% ( -11% - 12%) 0.878 Term 587.09 (5.0%) 586.16 (6.8%) -0.2% ( -11% - 12%) 0.933 TermB1M1P 586.61 (5.0%) 585.76 (6.8%) -0.1% ( -11% - 12%) 0.939 Term100 586.92 (5.1%) 586.16 (6.9%) -0.1% ( -11% - 12%) 0.946 Wildcard 58.83 (3.2%) 58.76 (3.7%) -0.1% ( -6% -7%) 0.909 Term1M 586.18 (5.2%) 585.54 (6.7%) -0.1% ( -11% - 12%) 0.954 Prefix3 99.19 (2.1%) 99.09 (3.4%) -0.1% ( -5% -5%) 0.907 AndHighOrMedMed 17.48 (3.4%) 17.47 (2.7%) -0.1% ( -6% -6%) 0.938 DismaxOrHighMed 64.98 (3.3%) 64.96 (5.4%) -0.0% ( -8% -8%) 0.986 FilteredPrefix3 92.50 (2.1%) 92.51 (3.2%)0.0% ( -5% -5%) 0.998 TermB1M 586.74 (5.0%) 586.88 (7.0%)0.0% ( -11% - 12%) 0.990 IntNRQ 48.59 (1.5%) 48.62 (2.9%)0.1% ( -4% -4%) 0.940 CountAndHighHigh 61.27 (1.6%) 61.36 (1.7%)0.1% ( -3% -3%) 0.775 FilteredOrStopWords 10.84 (2.1%) 10.85 (3.0%)0.2% ( -4% -5%) 0.836 CountAndHighMed 92.67 (2.5%) 92.85 (3.3%)0.2% ( -5% -6%) 0.831 TermTitleSort 65.99 (6.0%) 66.13 (6.7%)0.2% ( -11% - 13%) 0.911 CountFilteredOrMany6.04 (1.8%)6.05 (1.7%)0.2% ( -3% -3%) 0.654 FilteredIntNRQ 48.22 (1.5%) 48.35 (2.9%)0.3% ( -4% -4%) 0.722 SpanNear3.04 (5.0%)3.04 (5.4%)0.3% ( -9% - 11%) 0.870 CountOrHighHigh 62.55 (2.9%) 62.76 (2.5%)0.3% ( -4% -5%) 0.701 CountFilteredIntNRQ 22.23 (1.9%) 22.31 (1.8%)0.4% ( -3% -4%) 0.538 FilteredOrMany5.07 (1.9%)5.09 (2.7%)0.4% ( -4% -5%) 0.620 FilteredAn
[PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]
rmuir opened a new pull request, #14832: URL: https://github.com/apache/lucene/pull/14832 editorconfig indents were set across the board for all files, but nothing was done with existing files. For example, yaml was set to have a 2-space indent, yet it is the wild-west out there: 1-space indents, 3-space indents, you name it. * Validate any indent settings specified in editorconfig * Fix all existing violations (html, xml, etc were especially painful) * Disable indent settings where it isn't appropriate or reasonable (e.g. .txt files) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Optimize `CombinedFieldQuery` by `nextDocsAndScores` [lucene]
github-actions[bot] commented on PR #14834: URL: https://github.com/apache/lucene/pull/14834#issuecomment-2994705537 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] build: add eclint to verify editorconfig in CI [lucene]
rmuir merged PR #14825: URL: https://github.com/apache/lucene/pull/14825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]
github-actions[bot] commented on PR #14832: URL: https://github.com/apache/lucene/pull/14832#issuecomment-2994383872 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
