Re: [I] TopFieldCollector mistakenly assumes that all leaves share the same index sort [lucene]
jainankitk commented on issue #14399: URL: https://github.com/apache/lucene/issues/14399#issuecomment-2800571535 This is an interesting issue, and as such I don't see any good solution, other than removing the cache itself. I am wondering if it is good idea for Collector to know the `List`, similar to `setWeight` for passing `Weight` to Collector. `TopFieldCollector` should be able to compute `searchSortPartOfIndexSort` correctly and use the information within `TopFieldLeafCollector`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Refactor doc values to expose a `DocIdSetIterator` instead of extending `DocIdSetIterator`. [lucene]
gf2121 commented on PR #14475: URL: https://github.com/apache/lucene/pull/14475#issuecomment-2800544295 > The benefit of adding advanceExact directly to DocIdSetIterator is that then we no longer need to duplicate (and increase polymorphism) impls such as the one returned by DocIdSetIterator#all for both the case when it supports advanceExact and the case when it doesn't. +1 for this approach, thanks for sharing and explanation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Adding profiling support for concurrent segment search [lucene]
jainankitk commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-2800331295 After giving some more thought, added new interface `QueryLeafProfilerAggregator`, implementation of which allows aggregating leaf level breakdowns using `THREAD`, `SLICE` or `LEAF` level. The profiler result has `aggregationType` field that indicates the level of aggregation, and what `id` in the aggregated result will correspond to. `thread` or `slice` or `leaf` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
