Re: [PR] Add new Directory implementation for AWS S3 [lucene]
github-actions[bot] commented on PR #13949: URL: https://github.com/apache/lucene/pull/13949#issuecomment-2525356998 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Randomize KnnVector codec params in RandomCodec; addresses gh-14047 [lucene]
msokolov commented on PR #14049: URL: https://github.com/apache/lucene/pull/14049#issuecomment-2525276990 Thank Simon, that's good feedback about avoiding randomization for these tests. There's nothing to revert - this hasn't been committed, it's just github running tests that is failing. I do wonder though if we run the risk of a user with a customized Codec (just applying settings like graph bushiness and enabling quantization requires a custom Codec, so it would be typical) failing to be able to load an older index version for some reason, and we'd have no advance warning from the back-compat tests. Maybe that shouldn't be a concern, I'm not sure. In any case I will disable the randomization for these tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Reduce specialization in `ForUtil` and `ForDeltaUtil`. [lucene]
jpountz merged PR #14048: URL: https://github.com/apache/lucene/pull/14048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Randomize KnnVector codec params in RandomCodec; addresses gh-14047 [lucene]
s1monw commented on PR #14049: URL: https://github.com/apache/lucene/pull/14049#issuecomment-2525074361 @msokolov I didn't invent this test. Yet, we never tested the current version obeying with it's own BWC expecations. Please make sure nothing randomizes anything in this test. BWC tests are not made for this. you need to supress anything that potentially randomizes stuff here. > Another test fails now (this is going to be fun, it's hard to ferret all these things out proactively): maybe revert then? That's what it takes I guess? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
