Re: [PR] Speed up prefix sums when decoding doc IDs. [lucene]
jpountz commented on PR #13658: URL: https://github.com/apache/lucene/pull/13658#issuecomment-2294992594 Sadly, this seems to have caused a minor regression on nightly benchmarks, e.g. [`AndHighMed`](https://people.apache.org/~mikemccand/lucenebench/AndHighMed.html) lost 2% with a p-value of 0. I cannot reproduce the slowdown locally. However, one thing I am observing is that `splitLongs` is never inlined into the `decodeX` methods, which is annoying as I would expect it to be important performance-wise to unroll various loops. I am not sure if this is due to insufficient warming or if we could organize the code a bit differently to help the JVM make better inlining decisions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] nocommit: demonstrate how a minor change in IndexSearcher can have an inexplicable performance impact [lucene]
epotyom commented on PR #13657: URL: https://github.com/apache/lucene/pull/13657#issuecomment-2295025111 I've noticed by accident that creating two identical lists of collectors, before and after `createWeight`, makes regression disappear. Diff: https://github.com/epotyom/lucene/pull/2/files ``` Report after iter 18: TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value MedTerm 752.75 (3.6%) 753.41 (2.6%)0.1% ( -5% -6%) 0.932 HighTerm 520.02 (4.6%) 525.65 (3.3%)1.1% ( -6% -9%) 0.403 ``` Not sure what to make of it, but it does feel like some heap allocation peculiarity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Add support for intra-segment search concurrency [lucene]
github-actions[bot] commented on PR #13542: URL: https://github.com/apache/lucene/pull/13542#issuecomment-2295040060 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Check whether liveDoc is null out of loop in Weight.scoreAll [lucene]
github-actions[bot] commented on PR #13557: URL: https://github.com/apache/lucene/pull/13557#issuecomment-2295040055 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Check whether liveDoc is null out of loop in Weight.scoreAll [lucene]
vsop-479 closed pull request #13557: Check whether liveDoc is null out of loop in Weight.scoreAll URL: https://github.com/apache/lucene/pull/13557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
