Re: [PR] TaskExecutor should not fork unnecessarily [lucene]
mikemccand commented on PR #13472: URL: https://github.com/apache/lucene/pull/13472#issuecomment-2185015445 > So searching concurrently results in a lot more duplicate work. Thanks @jpountz -- I had actually not realized this. I thought concurrent search exchanged information across each thread/slice and was able to be more efficient (visit/collect fewer hits, spend less aggregated CPU) than sequential search. Conceptually it seems like Lucene should eventually be able to be more efficient when collecting concurrently. > This was one of my motivations for enabling concurrency on nightly benchmarks: so that we identify these cases and fix them. +1, I think Lucene has a lot of exciting innovations still in this area! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] TaskExecutor should not fork unnecessarily [lucene]
mikemccand commented on PR #13472: URL: https://github.com/apache/lucene/pull/13472#issuecomment-2185019080 I've opened https://github.com/mikemccand/luceneutil/issues/275 to close the traps in `luceneutil` when testing concurrent search. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove unused segNo calculation in IndexWriter.doFlush [lucene]
vsop-479 commented on code in PR #13491:
URL: https://github.com/apache/lucene/pull/13491#discussion_r1650283929
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -4271,12 +4271,7 @@ private boolean doFlush(boolean applyAllDeletes) throws
IOException {
boolean flushSuccess = false;
try {
long seqNo = docWriter.flushAllThreads();
- if (seqNo < 0) {
-seqNo = -seqNo;
-anyChanges = true;
- } else {
-anyChanges = false;
- }
+ anyChanges = seqNo < 0;
Review Comment:
It makes sense, thanks @cpoerschke . I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
