Re: [PR] Prevent DefaultPassageFormatter from taking shorter overlapping passages [lucene]
zkendall commented on code in PR #13384:
URL: https://github.com/apache/lucene/pull/13384#discussion_r1606204717
##
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java:
##
@@ -1422,7 +1422,7 @@ public Analyzer getWrappedAnalyzer(String fieldName) {
Set.of("field_tripples", "field_characters"),
"danc",
"dance with star",
-"dance with star");
+"dance with star");
Review Comment:
Edit existing test. This test is of "every character" is a token AND "every
_three_ characters is a token".. So "dan" is a better highlight than "da" and
"n" separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Prevent DefaultPassageFormatter from taking shorter overlapping passages [lucene]
zkendall commented on code in PR #13384:
URL: https://github.com/apache/lucene/pull/13384#discussion_r1606204717
##
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java:
##
@@ -1422,7 +1422,7 @@ public Analyzer getWrappedAnalyzer(String fieldName) {
Set.of("field_tripples", "field_characters"),
"danc",
"dance with star",
-"dance with star");
+"dance with star");
Review Comment:
This existing test is of "every character" is a token AND "every _three_
characters is a token".. So "dan" is a better highlight than "da" and "n"
separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Remove unused segNo calculation in IndexWriter.doFlush [lucene]
vsop-479 opened a new pull request, #13491: URL: https://github.com/apache/lucene/pull/13491 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Fix Method declared 'final' in 'final' class in Term. [lucene]
vsop-479 opened a new pull request, #13492: URL: https://github.com/apache/lucene/pull/13492 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
