Re: [PR] github workflow cleanup and minor improvements [lucene]
dweiss commented on PR #13110: URL: https://github.com/apache/lucene/pull/13110#issuecomment-1948233095 I'll commit this shortly. There may be follow-ups, I'll keep an eye on those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] github workflow cleanup and minor improvements [lucene]
dweiss merged PR #13110: URL: https://github.com/apache/lucene/pull/13110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] [LUCENE-13044][replicator] NRT add configurable commitData for Custom… [lucene]
dianjifzm commented on PR #13045: URL: https://github.com/apache/lucene/pull/13045#issuecomment-1948293102 > Hi @dianjifzm! Can you give more context for what you're trying to do? I [passed the PR description through Google Translate](https://translate.google.com/?sl=auto&tl=en&text=%E5%BC%80%E6%94%BEcommitData%E7%9A%84%E4%BF%AE%E6%94%B9%EF%BC%8C%E5%8F%AF%E4%BB%A5%E8%87%AA%E5%AE%9A%E4%B9%89%E4%B8%BB%E4%BB%8E%E5%90%8C%E6%AD%A5%E7%9A%84%E5%AE%89%E5%85%A8%E6%9C%BA%E5%88%B6&op=translate), but it wasn't enough for me to understand how this is helpful. 在业务开发过程中，有时为了故障恢复，有时是为了abtest，经常会发生replica切换primary的情况。 目前primary和replica之间主要靠primaryGen做安全验证，这个机制并不可靠。 只要primary的primaryGen大于replica的primaryGen，索引同步就会发生。 而新的primary与replica的索引类型可能都不相同，数据也可能不一致。 为了避免此类问题的发生，就需要自定义的主从验证机制，而这个机制需要放到commitData中。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[I] Make token stream settings as final and only set on construction [lucene]
easyice opened a new issue, #13112: URL: https://github.com/apache/lucene/issues/13112 ### Description As discussed in https://github.com/apache/lucene/pull/13104, the current API allows for changing the configuration of token streams after construction(such as `ShingleFilter`), but it should be set only during construction. Perhaps we can impose some constraints on the API to prevent more such cases in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Fix test failure in #13057 [lucene]
benwtrent merged PR #13102: URL: https://github.com/apache/lucene/pull/13102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Reproducible failure in TestParentBlockJoinFloatKnnVectorQuery.testScoringWithMultipleChildren [lucene]
benwtrent closed issue #13057: Reproducible failure in TestParentBlockJoinFloatKnnVectorQuery.testScoringWithMultipleChildren URL: https://github.com/apache/lucene/issues/13057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Improve smoketester JDK versions support [lucene]
dweiss commented on issue #13107: URL: https://github.com/apache/lucene/issues/13107#issuecomment-1948515415 So, here's what I managed to do so far. I've set up a simple gh workflow that can be triggered manually and provided with a release candidate to verify - here's what it looks like:  the workflow runs a matrix test against an array of JDKs: 11, 17, 21, 22-ea, automatically fetching the latest version of these (temurin distribution). A parameter allows one to turn off the tests (I'm not sure how long they'd take on github - was afraid to check...). Interestingly, I didn't have to touch the smoke tester at all as it already allows passing parameters to gradle, so I: * skipped all the tests by passing a filtering condition pointing at a non-existing test group, * compile and test against the matrix's java distribution using the existing runtime.java.home parameter we already have. I didn't modify the smoke tester so it reports that it runs gradle against Java 11, but reading the code I think it does the right thing and runs it against the provided Java version. Here is the whole workflow definition - https://raw.githubusercontent.com/dweiss/lucene/main/.github/workflows/run-smoketester.yml And here's a run I made to confirm it's working: https://github.com/dweiss/lucene/actions/runs/7932039311 note each run against a different JVM, including 22-ea, the logs confirming this:  The execution times are not bad at all - ~10 minutes per job and they're mostly in parallel, so no big deal I think. From here, I think it's a short walk to making a workflow that builds the distribution first, uploads it as an artifact which is then consumed by a job verifying the smoke tester against all the JVMs in question... unfortunately I won't be able to work on this the following week so if somebody wishes to take over and try, please go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
