Re: [PR] LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict [lucene]
mocobeta commented on PR #772: URL: https://github.com/apache/lucene/pull/772#issuecomment-1858761902 @mikemccand I tried to backport this to branch_9x and found that we should handle many conflicts in both kuromoji and nori to cherry-pick this in 9x branch. I think it can be a daunting task. I'd like to check the conflicts you are seeing, could you point out the PR under concern? It looks like #12911 is an issue. I guess you mean #12933? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Use growNoCopy in some places [lucene]
easyice opened a new pull request, #12951: URL: https://github.com/apache/lucene/pull/12951 Found some `grow` method can be change to `growNoCopy` when reading code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use growNoCopy in some places [lucene]
dweiss commented on code in PR #12951:
URL: https://github.com/apache/lucene/pull/12951#discussion_r1428895426
##
lucene/core/src/java/org/apache/lucene/util/BytesRefBuilder.java:
##
@@ -60,6 +60,13 @@ public void grow(int capacity) {
ref.bytes = ArrayUtil.grow(ref.bytes, capacity);
}
+ /**
+ * Used to grow the builder without coping bytes. see {@link
ArrayUtil#growNoCopy(byte[], int)}.
Review Comment:
```suggestion
* Used to grow the builder without copying bytes. see {@link
ArrayUtil#growNoCopy(byte[], int)}.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use growNoCopy in some places [lucene]
easyice commented on code in PR #12951:
URL: https://github.com/apache/lucene/pull/12951#discussion_r1428978833
##
lucene/core/src/java/org/apache/lucene/util/BytesRefBuilder.java:
##
@@ -60,6 +60,13 @@ public void grow(int capacity) {
ref.bytes = ArrayUtil.grow(ref.bytes, capacity);
}
+ /**
+ * Used to grow the builder without coping bytes. see {@link
ArrayUtil#growNoCopy(byte[], int)}.
Review Comment:
Thank you @dweiss , sorry for the typo!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Improve Javadoc for DocValuesConsumer [lucene]
easyice opened a new pull request, #12952: URL: https://github.com/apache/lucene/pull/12952 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
