Re: [PR] Only enable support for tests.profile if jdk.jfr module is available in Gradle runtime [lucene]

2023-11-25 Thread via GitHub


dweiss commented on code in PR #12845:
URL: https://github.com/apache/lucene/pull/12845#discussion_r1405192426


##
buildSrc/build.gradle:
##
@@ -38,3 +38,9 @@ dependencies {
   implementation 
"commons-codec:commons-codec:${scriptDepVersions['commons-codec']}"
 }
 
+if (!rootProject.hasJavaFlightRecorder) {
+  logger.warn('Module jdk.jfr is not available; skipping compilation of Java 
Flight Recorder support.')
+  tasks.named('compileJava').configure {
+exclude('**/ProfileResults.java')

Review Comment:
   Nice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



Re: [PR] Only enable support for tests.profile if jdk.jfr module is available in Gradle runtime [lucene]

2023-11-25 Thread via GitHub


uschindler merged PR #12845:
URL: https://github.com/apache/lucene/pull/12845


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org