[GitHub] [lucene] uschindler commented on issue #11870: Create a Markdown based documentation
uschindler commented on issue #11870: URL: https://github.com/apache/lucene/issues/11870#issuecomment-1373330425 There is markdown (or commonmark) support coming for JDK javadoc: https://bugs.openjdk.org/browse/JDK-8298405 So at some point we might replace those overview HTML files by markdown, when we changed to java 21! If we still want to do this now, we may need to use the already existing markdown converter for the global documentation also in modules and convert those overview.md to overview.html before executing javadoc. But this might not work if javadoc does not allow to give some folder in build dir as source for resources. But for now I would stick with HTML in source tree. For more general documentation the root documentation module is fine. It supports markdown and static resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zhaih commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge
zhaih commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1063681335
##
lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java:
##
@@ -94,36 +93,83 @@ public int size() {
}
/**
- * Add node on the given level
+ * Add node on the given level. Nodes can be inserted out of order, but it
requires that the nodes
Review Comment:
For `NodesIterator` I think once we have confirmed there's benefit of using
tree structure we can further subclass it into `Array/TreeBasedNodesIterator`.
Because it seems the `NodesIterator` still only provides what normal iterator
is providing but not some exotic random access or other operation that can't be
achieved by a tree, so I guess shouldn't become a big problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zhaih commented on a diff in pull request #12034: Remove null check in IndexReaderContext#leaves() usages
zhaih commented on code in PR #12034:
URL: https://github.com/apache/lucene/pull/12034#discussion_r1063684215
##
lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java:
##
@@ -314,19 +314,15 @@ private static TermStates adjustFrequencies(
IndexReaderContext readerContext, TermStates ctx, int artificialDf, long
artificialTtf)
throws IOException {
List leaves = readerContext.leaves();
-final int len;
-if (leaves == null) {
- len = 1;
-} else {
- len = leaves.size();
-}
TermStates newCtx = new TermStates(readerContext);
-for (int i = 0; i < len; ++i) {
- TermState termState = ctx.get(leaves.get(i));
- if (termState == null) {
-continue;
+if (leaves != null) {
Review Comment:
Thanks for changing it, I think it is better to leave a CHNAGES.txt entry
anyway!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] ErikPelli commented on a diff in pull request #12034: Remove null check in IndexReaderContext#leaves() usages
ErikPelli commented on code in PR #12034:
URL: https://github.com/apache/lucene/pull/12034#discussion_r1063816707
##
lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java:
##
@@ -314,19 +314,15 @@ private static TermStates adjustFrequencies(
IndexReaderContext readerContext, TermStates ctx, int artificialDf, long
artificialTtf)
throws IOException {
List leaves = readerContext.leaves();
-final int len;
-if (leaves == null) {
- len = 1;
-} else {
- len = leaves.size();
-}
TermStates newCtx = new TermStates(readerContext);
-for (int i = 0; i < len; ++i) {
- TermState termState = ctx.get(leaves.get(i));
- if (termState == null) {
-continue;
+if (leaves != null) {
Review Comment:
Added it and squashed all the commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zhaih merged pull request #12034: Remove null check in IndexReaderContext#leaves() usages
zhaih merged PR #12034: URL: https://github.com/apache/lucene/pull/12034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on issue #12067: Getting exception on search after upgrading to Lucene 9.4
rmuir commented on issue #12067: URL: https://github.com/apache/lucene/issues/12067#issuecomment-1374409314 The bug is in your code, because you index inconsitently different data in the same field: the data going into docvalues is lowercased, the data going into stringfield is not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir closed issue #12067: Getting exception on search after upgrading to Lucene 9.4
rmuir closed issue #12067: Getting exception on search after upgrading to Lucene 9.4 URL: https://github.com/apache/lucene/issues/12067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
