[GitHub] [lucene] jpountz commented on pull request #11841: GITHUB-11761 (part 2): Fix unit tests to cleany work with new TierMer…
jpountz commented on PR #11841: URL: https://github.com/apache/lucene/pull/11841#issuecomment-1274178342 Thank you @mdmarshmallow ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #11840: GITHUB-11838 Add api to allow concurrent query rewrite
jpountz commented on PR #11840: URL: https://github.com/apache/lucene/pull/11840#issuecomment-1274185245 We already have one class that wraps an `IndexReader` and an `Executor`: `IndexSearcher`. Should this new `rewrite` method take an `IndexSearcher` instead of an `IndexReader` and an `Executor`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #11840: GITHUB-11838 Add api to allow concurrent query rewrite
jpountz commented on PR #11840: URL: https://github.com/apache/lucene/pull/11840#issuecomment-1274202665 (and should it replace the existing rewrite method instead of just adding another one?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] iverase commented on pull request #11753: Added interface to relate a LatLonShape with another shape represented as Component2D
iverase commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1274303872 I would prefer that factory methods that creates `LatLonShapeDocValues` are placed on that class instead of crowding `LatLonShape` with all those methods. Same for XY. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] OpakAlex commented on pull request #11807: No need to rewrite queries in unified highlighter
OpakAlex commented on PR #11807: URL: https://github.com/apache/lucene/pull/11807#issuecomment-1274363022 Thanks for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] navneet1v commented on pull request #11753: Added interface to relate a LatLonShape with another shape represented as Component2D
navneet1v commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1275118229 > I would prefer that factory methods that creates `LatLonShapeDocValues` are placed on that class instead of crowding `LatLonShape` with all those methods. Same for XY. I can see functions which creates LatLonShapeDocValues present in the LatLonShape as of now. Plus I believe this is good as it provides 1 single class with different interfaces to work with LatLonShape or LatLonShapeDocValues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] nknize commented on pull request #11753: Added interface to relate a LatLonShape with another shape represented as Component2D
nknize commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1275150028 > Plus I believe this is good as it provides 1 single class with different interfaces to work with LatLonShape or LatLonShapeDocValues. I agree. That was the intent of the LatLonShape and XYShape factory classes so developer's don't have to go hunting around for all of the public ctors. It's a clean API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] navneet1v commented on pull request #11753: Added interface to relate a LatLonShape with another shape represented as Component2D
navneet1v commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1275235694 Updated the Code as there were merge conflicts. @jpountz or @iverase can you please review, as I need 1 more reviewer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
