[GitHub] [lucene] mikemccand commented on pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation
mikemccand commented on PR #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-1272530502 I have not looked closely at this PR but it sounds very useful (enabling ICU transformations pre-tokenization), looks like the requested change from @uschindler was addressed, and `precommit` looks happy! Maybe we should progress-not-perfection this and push it soon? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mdmarshmallow opened a new pull request, #11841: GITHUB-11761 (part 2): Fix unit tests to cleany work with new TierMer…
mdmarshmallow opened a new pull request, #11841: URL: https://github.com/apache/lucene/pull/11841 …gePolicy delete pct default ### Description We recently changed the default delete percentage of `TieredMergePolicy` that broke 2 unit tests. To fix this, we originally change the delete percentage to the old delete percentage. This change makes the unit tests work with new default delete percentages without changing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mdmarshmallow commented on pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…
mdmarshmallow commented on PR #11831: URL: https://github.com/apache/lucene/pull/11831#issuecomment-1272635717 These new tests did fail, I created a new PR (tied to the same issue as this one) to more cleanly fix the unit tests without having to change the default percentage: https://github.com/apache/lucene/pull/11841. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation
rmuir commented on PR #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-1272840381 @mikemccand i had 2 remaining concerns: 1. legal, there is a lot of copied/forked ICU code here and any of that should be done correctly 2. maintenance: consequence of the above, it is actually more code than the rest of the existing icu module, thousands of lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
