[GitHub] [lucene] shubhamvishu commented on a diff in pull request #11832: Added static factory method for loading VectorValues
shubhamvishu commented on code in PR #11832:
URL: https://github.com/apache/lucene/pull/11832#discussion_r984717340
##
lucene/core/src/java/org/apache/lucene/index/VectorValues.java:
##
@@ -35,6 +35,25 @@ public abstract class VectorValues extends DocIdSetIterator {
/** Sole constructor */
protected VectorValues() {}
+ /**
+ * Returns the {@link VectorValues} index for this field, or {@link #EMPTY}
if it has none.
+ *
+ * @param reader Leaf reader instance
+ * @param field Field name
+ * @return VectorValues instance, or an empty instance if {@code field} does
not exist in this
+ * reader
+ * @throws IOException if the field does not have any vector values
+ */
+ public static VectorValues getVectorValues(LeafReader reader, String field)
throws IOException {
+VectorValues values = reader.getVectorValues(field);
+if (values == null) {
+ return EMPTY;
+} else if (!reader.getFieldInfos().fieldInfo(field).hasVectorValues()) {
Review Comment:
Got itThanks @rmuir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] shubhamvishu commented on a diff in pull request #11832: Added static factory method for loading VectorValues
shubhamvishu commented on code in PR #11832:
URL: https://github.com/apache/lucene/pull/11832#discussion_r984718205
##
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##
@@ -2585,7 +2585,7 @@ public static Status.VectorValuesStatus testVectors(
+ "\" has vector values but dimension is "
+ dimension);
}
-VectorValues values = reader.getVectorValues(fieldInfo.name);
+VectorValues values = VectorValues.getVectorValues(reader,
fieldInfo.name);
if (values == null) {
Review Comment:
YesWe can remove it. Thanks @gsmiller !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #11796: GITHUB#11795: Add FilterDirectory to track write amplification factor
mdmarshmallow commented on code in PR #11796:
URL: https://github.com/apache/lucene/pull/11796#discussion_r984889764
##
lucene/misc/src/java/org/apache/lucene/misc/store/ByteWritesTrackingDirectoryWrapper.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.misc.store;
+
+import java.io.IOException;
+import java.util.concurrent.atomic.AtomicLong;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.store.FilterDirectory;
+import org.apache.lucene.store.IOContext;
+import org.apache.lucene.store.IndexOutput;
+
+/** {@link FilterDirectory} that tracks write amplification factor */
+public final class ByteWritesTrackingDirectoryWrapper extends FilterDirectory {
+
+ private final AtomicLong flushedBytes = new AtomicLong();
+ private final AtomicLong mergedBytes = new AtomicLong();
+ public final boolean trackTempOutput;
+
+ public ByteWritesTrackingDirectoryWrapper(Directory in) {
+this(in, false);
+ }
+ /**
+ * Constructor with option to track tempOutput
+ *
+ * @param in input Directory
+ * @param trackTempOutput if true, will also track temporary outputs created
by this directory
+ */
+ public ByteWritesTrackingDirectoryWrapper(Directory in, boolean
trackTempOutput) {
+super(in);
+this.trackTempOutput = trackTempOutput;
+ }
+
+ @Override
+ public IndexOutput createOutput(String name, IOContext ioContext) throws
IOException {
+IndexOutput output = in.createOutput(name, ioContext);
+return createByteTrackingOutput(output, ioContext.context);
+ }
+
+ @Override
+ public IndexOutput createTempOutput(String prefix, String suffix, IOContext
ioContext)
+ throws IOException {
+IndexOutput output = in.createTempOutput(prefix, suffix, ioContext);
+return trackTempOutput ? createByteTrackingOutput(output,
ioContext.context) : output;
+ }
+
+ private IndexOutput createByteTrackingOutput(IndexOutput output,
IOContext.Context context) {
+switch (context) {
+ case FLUSH:
+return new ByteTrackingIndexOutput(output, flushedBytes);
+ case MERGE:
+return new ByteTrackingIndexOutput(output, mergedBytes);
+ case DEFAULT:
+ case READ:
+ default:
Review Comment:
Checkstyle complains when I don't explicitly include all cases in the enum
unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mdmarshmallow commented on pull request #11796: GITHUB#11795: Add FilterDirectory to track write amplification factor
mdmarshmallow commented on PR #11796: URL: https://github.com/apache/lucene/pull/11796#issuecomment-1263938801 Not sure why the tests are failing as `./gradlew check` passes on my machine. I checked the macos-latest distributions test logs and found this: ``` 2022-09-29T19:53:49.4803130Z Failed to resolve action download info. Error: nodename nor servname provided, or not known (pipelines.actions.githubusercontent.com:443) 2022-09-29T19:53:49.4820400Z Retrying in 13.157 seconds 2022-09-29T19:55:42.7778120Z Failed to resolve action download info. Error: The HTTP request timed out after 00:01:40. 2022-09-29T19:55:42.7787910Z Retrying in 15.793 seconds 2022-09-29T19:56:49.5196790Z ##[error]Failed to resolve action download info. ``` It seems like a transient error to me, but I'm not knowledgable enough about this to be sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mdmarshmallow commented on issue #11761: Expand TieredMergePolicy deletePctAllowed limits
mdmarshmallow commented on issue #11761: URL: https://github.com/apache/lucene/issues/11761#issuecomment-1264018168 I can include that in the above PR as well if you all agree that it's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
